Timeline


and

02/14/11:

21:53 Changeset [78531] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

allow for modifying comments without the mouse
https://bugs.webkit.org/show_bug.cgi?id=54433

Use n/p to navigate the comments.
Enter to begin editing a comment.
Escape to finish editing a comment.

  • code-review.js:
21:46 Changeset [78530] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

improve line selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54430

-shift+click now extends the comment context
-selecting outside of a diff section no longer clears the selected lines.

Instead it just restricts the selected lines to that diff section.

  • code-review.js:
19:04 WebKit Team edited by kalman@chromium.org
Add myself to committers list (diff)
18:30 Changeset [78529] by mihaip@chromium.org
  • 10 edits in branches/chromium/648/Source/WebCore

Roll out r74807 (in the 648 branch only).

BUG=68516
TBR=kerz@chromium.org

18:23 Changeset [78528] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix minor regression introduced in r78522. For some reason, Python
provides a platform.mac_ver() routine on Linux, so we need to
check to make sure it's returning something in addition to
checking for its existence.

  • Scripts/webkitpy/layout_tests/port/mac.py:
17:49 Changeset [78527] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Jeremy Orlow <jorlow@chromium.org>

efl build fix

  • CMakeLists.txt:
17:38 Changeset [78526] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add WKPageSetMemoryCacheClientCallsEnabled API
https://bugs.webkit.org/show_bug.cgi?id=54422

  • UIProcess/API/C/WKPage.cpp: (WKPageSetMemoryCacheClientCallsEnabled):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setMemoryCacheMessagesEnabled):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
17:18 Changeset [78525] by jorlow@chromium.org
  • 81 edits
    2 moves
    11 deletes in trunk

2011-02-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331

Make the requried changes + s/result/request/g (where it should
have always been that way) + remove the verify functions (since
these days they mostly just add noise) + get rid of the callback
in the delete object store funciton.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (evalAndExpectException): (deleteAllObjectStores):
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/tutorial.html:

2011-02-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331

We shouldn't have our own event subclasses. Instead, we
should just fire Event's with the proper type and bubble
settings. All the attributes on the events before should
just be on the request. IDBRequest should throw if they're
accessed before the success event fires.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp:
  • dom/Event.h:
  • page/DOMWindow.idl:
  • storage/IDBAbortEvent.h: Removed.
  • storage/IDBCompleteEvent.cpp: Removed.
  • storage/IDBCompleteEvent.h: Removed.
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBErrorEvent.cpp: Removed.
  • storage/IDBErrorEvent.h: Removed.
  • storage/IDBErrorEvent.idl: Removed.
  • storage/IDBEvent.h: Removed.
  • storage/IDBEvent.idl: Removed.
  • storage/IDBEventDispatcher.cpp: (WebCore::IDBEventDispatcher::dispatch):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::result): (WebCore::IDBRequest::errorCode): (WebCore::IDBRequest::webkitErrorMessage): (WebCore::IDBRequest::source): (WebCore::IDBRequest::transaction): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::createSuccessEvent): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Removed.
  • storage/IDBSuccessEvent.h: Removed.
  • storage/IDBSuccessEvent.idl: Removed.
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::dispatchEvent):
17:14 Changeset [78524] by kalman@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

16:03 Changeset [78523] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: View not updated completely when coming back from a cached back/forward navigation
<rdar://problem/8787264>
https://bugs.webkit.org/show_bug.cgi?id=54419

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState): Invalidate the entire page
when completing a restore from the back/forward cache.

16:03 Changeset [78522] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Clean up the way we handle platform names in
new-run-webkit-tests. Previously, if you specified
'--platform mac' or '--platform chromium-mac' on the command
line, it would use that platform name to determine baseline search
paths, etc. This is almost never the right thing to do, because
it ignores the existence of version-specific baselines.

So, I changed this so that ports that support versions must
always use a version, and the version should default to the
version of the operating system that the port is being run on
(e.g., if you're running on Leopard, then passing '--platform
mac' will default to the 'mac-leopard' port). This means that
port.name() should always include a version-specific suffix if
the port supports versions.

However, we still support things like '--platform mac' as input
so that the user doesn't have to explicitly specify a version,
both for convenience and so we don't have to make buildbot
configs more complicated than they already are.

Also, I cleaned up how the baselines were being searched
on the chromium-mac port (this is one of the two bugs that
prompted this refactoring), and made the logic easier to follow
and more consistent across the mac and chromium ports

Lastly, I added a port.get_all_names() method that could be used
to get the names of all of the ports to search, rather than having
to guess (incorrectly) from the list of directories under
LayoutTests/platform (this last thing was necessary because the
deduplicate_tests unittest broke as the fallback dirs changed).

https://bugs.webkit.org/show_bug.cgi?id=54248

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
16:01 Changeset [78521] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54418
Fix a Linux expectation, mark another test as expected-failing.

  • platform/chromium/test_expectations.txt:
15:59 Changeset [78520] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

update-webkit hangs in a git-only checkout

Previously it would hang forever trying to do a 'git svn
rebase'. Now, it will default to a 'git pull' if the
svn-remote.svn.fetch variable isn't set, and bail out if it
doesn't know where to pull from.

https://bugs.webkit.org/show_bug.cgi?id=54265

  • Scripts/update-webkit:
  • Scripts/VCSUtils.pm:
15:51 Changeset [78519] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] testwebdatasource test fails in the bots
https://bugs.webkit.org/show_bug.cgi?id=54414

Changed the uri we check, added www to avoid the rewrite that we
get when we as the uri to the request in case it finishes.

  • tests/testwebdatasource.c: (notify_load_status_cb):
15:46 Changeset [78518] by alex@webkit.org
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r78516.
http://trac.webkit.org/changeset/78516

The rebaseline was previously done

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
15:35 Changeset [78517] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
https://bugs.webkit.org/show_bug.cgi?id=54416

Reviewed by Dan Bernstein.

We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.

15:29 Changeset [78516] by alex@webkit.org
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Rebaseline GTK test results after r78491.

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
15:15 Changeset [78515] by leviw@chromium.org
  • 17 edits
    3 adds in trunk

2011-02-14 Levi Weintraub <leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475

Changing the behavior of the strikethrough execCommand when styleWithCSS
is false. We formerly created <s> tags, which was different than both IE
and FF and caused problems with some rich text editors that would strip
out unexpected tags such as <s>.

Test: editing/execCommand/strikethrough-uses-strike-tag.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2011-02-14 Levi Weintraub <leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475

Updating test expectations and creating a test in an attempt to prevent the
uninformed WebKit dev from switching back to using <s> tags for strikethrough.
As explained in the bug, this is bad for compatibility with various rich text
editors.

  • editing/execCommand/query-text-decoration-with-typing-style-expected.txt:
  • editing/execCommand/script-tests/strikethrough-uses-strike-tag.js: Added. (test):
  • editing/execCommand/script-tests/toggle-style-2.js:
  • editing/execCommand/strikethrough-uses-strike-tag-expected.txt: Added.
  • editing/execCommand/strikethrough-uses-strike-tag.html: Added.
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/push-down-implicit-styles-around-list-expected.txt:
  • editing/style/push-down-implicit-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-implicit-styles-around-list.js:
  • editing/style/script-tests/push-down-implicit-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
15:02 Changeset [78514] by enrica@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.exp.in

Build fix. Unreviewed.

15:01 Changeset [78513] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Shared memory should be made shared immediately
https://bugs.webkit.org/show_bug.cgi?id=54413
<rdar://problem/8972153>

Under some circumstances, mach_make_memory_entry_64 may only return parts of a
memory allocation. Work around this by creating a mach port representing the shared memory
right away. Also, hand out this mach port in createHandle when using the default memory protection.

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
14:58 Changeset [78512] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch modifies NRWT's Worker clas to use the new
WorkerMixin class to actually run tests. With this patch, the
multiprocess version of NRWT is fully functional and just needs
the values for --worker-model and --child-processes to be corrected
in the port/* classes to start using the new code by default.

https://bugs.webkit.org/show_bug.cgi?id=54082

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
14:56 Changeset [78511] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch shuffles code out of dump_render_tree_thread and
single_test_runner and into a new worker_mixin class that will
be shared by both TestShellThread and Worker. This change
restores single_test_runner to its state as of r77606 - it is
stateless again. It also prunes TestShellThread to pretty much
just the logic used for the original shared-memory access.

https://bugs.webkit.org/show_bug.cgi?id=54079

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.
14:56 Changeset [78510] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Try using the right syntax this time.

  • platform/chromium/test_expectations.txt:
14:26 Changeset [78509] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
14:20 Changeset [78508] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove dead code in FormDataStreamCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54401

Reviewed by Darin Adler.

The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.

  • platform/network/cf/FormDataStreamCFNet.cpp:
14:15 Changeset [78507] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch updates NRWT to add per-worker and per-shard test stats
into TestRunner2, bringing it to parity with TestRunner.

https://bugs.webkit.org/show_bug.cgi?id=54074

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
14:13 Changeset [78506] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing: add code to handle interrupts and wedged
threads.
https://bugs.webkit.org/show_bug.cgi?id=54072

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Adds the cancel(), is_alive(), join(), and log_wedged_worker() methods to the WorkerConnection class
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Adds the cancel() method to the Worker class
14:08 Changeset [78505] by pkasting@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 78431 - Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

TBR=weinig@apple.com
Review URL: http://codereview.chromium.org/6523001

13:55 Changeset [78504] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54409
Mark tests as failing due to r78484.

  • platform/chromium/test_expectations.txt:
13:54 Changeset [78503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-14 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

GraphicsContext: Add clip(IntRect) overload for Qt
https://bugs.webkit.org/show_bug.cgi?id=54365

Qt has special code paths for clipping to integer rectangles.
Add a GraphicsContext::clip() overload to allow us to take
advantage of the optimized code.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clip):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
13:48 Changeset [78502] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

update the NRWT multiprocessing code to spawn multiple workers
instead of just using one.

https://bugs.webkit.org/show_bug.cgi?id=54071

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
13:44 QtWebKit edited by andreas.kling@nokia.com
(diff)
13:29 Changeset [78501] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some MarkedBlock refactoring.

Rubber-stamped by Gavin Barraclough.

Made cells private.

Renamed cells => m_cells

marked => m_marks.

  • runtime/JSCell.h:

(JSC::JSCell::MarkedBlock::allocate):

  • runtime/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):

  • runtime/MarkedBlock.h:

(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach):

13:28 Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
13:27 Changeset [78500] by xji@chromium.org
  • 10 edits in trunk/LayoutTests

2011-02-14 Xiaomei Ji <xji@chromium.org>

Unreviewed.
Rebaseline after r78491. Since select-visual-hebrew.html and visual-hebrew-text-field.html
are marked as FAIL in Chromium WIN and LINUX, rebaseline for them are done manually and
only changed the part related to r78491.

  • platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
13:23 Changeset [78499] by darin@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-14 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The first version failed some tests because
of incorrect error handling. The second version was missing one line
of code that made it decode incomplete sequences at the end of the
buffer twice.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
13:13 Changeset [78498] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit/win

Need WebKit API to determine whether we have a site icon for a given URL
https://bugs.webkit.org/show_bug.cgi?id=54400

Reviewed by Brady Eidson.

This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.

  • Interfaces/IWebIconDatabase.idl: Added new function.
  • Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
  • WebIconDatabase.cpp:

(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we

load the icon from disk, and call iconURLForPageURL to determine whether or not
we actually have an icon.

  • WebIconDatabase.h:
12:48 Changeset [78497] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379

Add a constructor for copying a Vector into a String. I suspect there
are a number of call sites that are doing this manually that would
benefit from being moved to this API.

  • wtf/text/WTFString.h: (WTF::String::String):

2011-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379

The parser in this patch is very basic. It just segments the CSP
header into directives. The exactly syntax will likely change a bit as
we discuss the details in public-web-security, but this parser will
allow us to make progress.

Sadly, this patch does not contain any tests. That's because CSP
policies do not have any observable effects yet. Hopefully we'll get
enough sketched out in the next couple patches to begin writing tests.

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::name): (WebCore::CSPDirective::value): (WebCore::ContentSecurityPolicy::~ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::parse):
  • page/ContentSecurityPolicy.h:
12:19 Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
12:03 Changeset [78496] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test expectations, missed a test
in my last checkin.

  • platform/chromium/test_expectations.txt:
11:48 Changeset [78495] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-02-14 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Kenneth Russell.

[Qt] WebKit fails to compile for Qt when WebGL enabled
https://bugs.webkit.org/show_bug.cgi?id=53431

No new tests.

  • WebCore.pro: Add source and header files and include directory to Qt project.
  • html/canvas/WebGLRenderingContext.cpp: File uses 'emit' which is a Qt keyword - #undef emit.
  • platform/graphics/gpu/qt: Added.
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added. Partial implementation of DrawingBuffer for Qt. (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/qt/Extensions3DQt.cpp: Noop implementation for pure virtual methods added to Extensions3D.h (WebCore::Extensions3DQt::blitFramebuffer): (WebCore::Extensions3DQt::renderbufferStorageMultisample):
  • platform/graphics/qt/Extensions3DQt.h: Declare new methods added to Extensions3D.h
  • platform/graphics/qt/GraphicsContext3DQt.cpp: Remove method implementations no longer in GraphicsContext3D.h. Change m_syntheticErrors to use unsigned int to match new GC3Denum type. (WebCore::GraphicsContext3D::create): Change return type to match GraphicsContext3D.h (WebCore::GraphicsContext3D::lineWidth): Change argument type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getUniformLocation): Change return type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getExtensions): Need to call get() on OwnPtr. (WebCore::GraphicsContext3D::getImageData): Rename enum values to match declarations in GraphicsContext3D.h
11:45 Changeset [78494] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-14 Jay Soffian <jaysoffian@gmail.com>

Reviewed by Darin Fisher.

Expose checked field of HTMLInputElement to Chromium API
https://bugs.webkit.org/show_bug.cgi?id=54333

  • public/WebInputElement.h:
  • src/WebInputElement.cpp:
11:40 Changeset [78493] by tony@chromium.org
  • 8 edits in trunk

2011-02-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152

No new tests, covered by existing pixel results (fast/forms/basic-selects.html
convers lots of cases).

2011-02-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152

  • public/linux/WebThemeEngine.h:
  • src/PlatformBridge.cpp: (WebCore::GetWebThemeExtraParams):
11:25 Changeset [78492] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

http://code.google.com/p/v8/issues/detail?id=1154
Temporarily mark a test as failing due to a new V8 version.

  • platform/chromium/test_expectations.txt:
11:21 Changeset [78491] by xji@chromium.org
  • 7 edits
    2 adds in trunk

2011-02-14 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128

Test: fast/text/international/iso-8859-8.html

  • platform/text/BidiResolver.h: Add VisualDirectionOverride enum. (WebCore::::createBidiRunsForLine): For lines with visual direction override, create bidi runs without resolving bidi levels (one run per render object), set bidi level as 0 or 1 depending on LTR or RTL override, and reverse runs for RTL override.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): Set inline box bidi level the same as BidiRun's bidi level without special handling of VisualDirectionOverride. (WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride to createBidiRunsForLine().

2011-02-14 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128

  • fast/text/international/iso-8859-8-expected.txt: Added.
  • fast/text/international/iso-8859-8.html: Added.
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
11:02 Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:52 Changeset [78490] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-14 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000

Check the value is valid before use it.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::~SharedTimerQt):

2011-02-14 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000

Test case to cover the crash.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::deleteQWebViewTwice):
10:29 Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:28 Webkit2Innards created by siddharth.mathur@nokia.com
10:25 Changeset [78489] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

React to accelerated compositing changes and allocation failures in DrawingAreaImpl::display

Fixes <http://webkit.org/b/54398> DrawingAreaImpl::display handles error cases poorly.

Reviewed by Darin Adler and Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display): Bail out if the layout we perform puts us into
accelerated compositing mode. Moved the layout earlier in this function so we can bail
before doing other work that would be unnecessary in this case. Moved the allocation of the
ShareableBitmap earlier so we will leave our state (e.g., dirty region) intact even if the
allocation fails.

10:24 Changeset [78488] by aroben@apple.com
  • 14 edits in trunk/Source/WebKit2

Add a way to flash backing store and view updates

The new WKPageSetDebugPaintFlags SPI can be used to control whether backing store and/or
view updates are flashed. A blueish color is used for view updates, and a purpleish color is
used for backing store updates. The flashing currently only works on Windows.

Fixes <http://webkit.org/b/54303>.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetDebugPaintFlags):
(WKPageGetDebugPaintFlags):

  • UIProcess/API/C/WKPagePrivate.h:

Added. These call through to WebPageProxy.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage_p.h:

Stubbed out new PageClient functions.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Tell the WebPageProxy to flash the
backing store updates we're performing.

  • UIProcess/PageClient.h: Added flashBackingStoreUpdates.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::flashBackingStoreUpdates): Call through to the PageClient.
(WebKit::WebPageProxy::viewUpdatesFlashColor): Return the blueish color used for view
updates.
(WebKit::WebPageProxy::backingStoreUpdatesFlashColor): Return the purpleish color used for
backing store updates.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setDebugPaintFlags):
(WebKit::WebPageProxy::debugPaintFlags):
Added these simple accessors.

  • UIProcess/win/WebView.cpp:

(WebKit::flashRects):
(WebKit::createBrush):
New helper functions.

(WebKit::WebView::onPaintEvent): Flash the dirty region if requested.
(WebKit::WebView::flashBackingStoreUpdates): Added. Calls through to flashRects.

  • UIProcess/win/WebView.h: Added flashBackingStoreUpdates.
  • win/WebKit2Generated.make: Export WKPagePrivate.h so clients can use it.
10:13 Changeset [78487] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: unflake inspector/styles-iframe.html

  • inspector/resources/styles-iframe-data.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
09:54 Changeset [78486] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
https://bugs.webkit.org/show_bug.cgi?id=33220

  • inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
09:53 Changeset [78485] by inferno@chromium.org
  • 7 edits
    4 copies in branches/chromium/648

Merge 77563

BUG=70336
Review URL: http://codereview.chromium.org/6519013

09:29 Changeset [78484] by enne@google.com
  • 8 edits in trunk/Source/WebCore

2011-02-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Modify LayerTilerChromium to use TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143

Most of the previous data in LayerTilerChromium is now calculated
from TilingData. TilingData was modified to allow for a dynamic
tile size and page size. LayerTilerChromium also gets its own
shader with a texture transform to handle drawing from a texture
that is larger than a tile.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::tilerSharedValues):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::layerSize): (WebCore::LayerTilerChromium::layerTileSize): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTexturedQuad): (WebCore::LayerTilerChromium::SharedValues::SharedValues): (WebCore::LayerTilerChromium::SharedValues::~SharedValues):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram): (WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation): (WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation): (WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation): (WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation): (WebCore::LayerTilerChromium::SharedValues::initialized):
  • platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::setTotalSize): (WebCore::TilingData::setMaxTextureSize): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::textureOffset): (WebCore::TilingData::recomputeNumTiles):
  • platform/graphics/gpu/TilingData.h:
09:18 QtWebKit edited by siddharth.mathur@nokia.com
(diff)
09:18 QtWebKit edited by siddharth.mathur@nokia.com
(diff)
09:17 QtWebKit edited by siddharth.mathur@nokia.com
(diff)
09:17 Changeset [78483] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
https://bugs.webkit.org/show_bug.cgi?id=54388

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded):
08:40 Changeset [78482] by podivilov@chromium.org
  • 17 edits in trunk

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • wtf/text/TextPosition.h: (WTF::ZeroBasedNumber::convertAsOneBasedInt):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • Make call frame line and column zero based
  • Set execution line in source frame based on call frame line:column
  • Determine currently hit breakpoint based on call frame line:column
  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  • bindings/v8/DebuggerScript.js: ():
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLocation): (WebInspector.SourceFrame.prototype.clearExecutionLocation): (WebInspector.SourceFrame.prototype._setExecutionLocation): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
08:34 Changeset [78481] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
08:31 Changeset [78480] by christian@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression: Back, Forward, Reload hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=54393

Reviewed by Gustavo Noronha Silva.

  • page/ContextMenuController.cpp: Always show Back, Forward,

Reload and Stop context menu items for the GTK+ port.

08:12 Changeset [78479] by aroben@apple.com
  • 3 edits in trunk/Source/WebKit2

Add some .messages.in and script files to WebKit2 projects

This is just for convenience. It doesn't affect the build.

  • win/WebKit2.vcproj: Also let VS resort some files.
  • win/WebKit2Generated.vcproj:
08:04 Changeset [78478] by jnd@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Johnny Ding <jnd@chromium.org>

Reviewed by Andreas Kling.

Move the finiteness check into common code.

Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isPointInPath):
07:43 Changeset [78477] by pfeldman@chromium.org
  • 30 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move timeline and highlighter tests to the new harness.
https://bugs.webkit.org/show_bug.cgi?id=54390

  • inspector/cookie-resource-match.html:
  • inspector/elements-panel-search.html:
  • inspector/evaluate-in-frontend-expected.txt: Removed.
  • inspector/evaluate-in-frontend.html: Removed.
  • inspector/inspected-objects-not-overriden.html:
  • inspector/resources/timeline-iframe-data.html:
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-html.html:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
  • inspector/syntax-highlight.js: (initialize_SyntaxHighlight.InspectorTest.dumpSyntaxHighlight): (initialize_SyntaxHighlight):
  • inspector/timeline-enum-stability-expected.txt:
  • inspector/timeline-enum-stability.html:
  • inspector/timeline-event-dispatch.html:
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-layout.html:
  • inspector/timeline-mark-timeline.html:
  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-network-resource.html:
  • inspector/timeline-network-resource.js:
  • inspector/timeline-paint.html:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-parse-html.html:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-recalculate-styles.html:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-script-tag-2.html:
  • inspector/timeline-script-tag-2.js:
  • inspector/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step1): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint.step3): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords): (initialize_Timeline.InspectorTest._timelineResults): (initialize_Timeline.InspectorTest.dumpTimelineRecord): (initialize_Timeline.InspectorTest.dumpTimelineRecords): (initialize_Timeline.InspectorTest.printTimelineRecordProperties): (initialize_Timeline.InspectorTest._timelineAgentTypeToString): (initialize_Timeline):
  • inspector/timeline-trivial.html:
07:29 Changeset [78476] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: update chromium expectation for inspector test.

  • inspector/console-uncaught-exception-in-eval.html:
  • platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
06:27 Changeset [78475] by pfeldman@chromium.org
  • 6 edits
    1 move
    3 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium-win/inspector/console-format-expected.txt: Removed.
  • platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Removed.
  • platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Removed.
  • platform/chromium/inspector/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console-dir-global-expected.txt.
  • platform/chromium/inspector/console-format-collections-expected.txt:
  • platform/chromium/inspector/console-format-expected.txt:
  • platform/chromium/inspector/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console-uncaught-exception-expected.txt:
  • platform/chromium/inspector/debugger-expand-scope-expected.txt:
06:23 Changeset [78474] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped some tests that were causing problems just in
one of the bots, apparently rounding issues.
https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped:
06:08 Changeset [78473] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=54377

Rearranged the condition blocks, removed superfluous conditions:
.) if-statements where it's already clear that a search field is being generated
.) testing for spin-buttons on field types that can never have them.

createInnerBlockStyle(): only search fields create an inner block, and
these can never have spin buttons.

No new tests. (Refactoring - covered by existing tests)

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
06:06 Changeset [78472] by podivilov@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-10 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
https://bugs.webkit.org/show_bug.cgi?id=54195

Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.

  • inspector/front-end/ResourceView.js: (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.SourceMappingForFormattedScript): (WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation): (WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._setBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint): (WebInspector.SourceFrameContentProvider.prototype.requestContent):
  • inspector/front-end/SourceFrameContent.js: (WebInspector.SourceFrameContent): (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber): (WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.fromScriptLocation): (WebInspector.SourceMapping.prototype.toScriptLocation): (WebInspector.IdenticalSourceMapping): (WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation): (WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
  • inspector/front-end/utilities.js: (String.prototype.lineEndings):
06:00 Changeset [78471] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped generated-content-inside-table.htm test, it
fails in the bots, opened bug:
https://bugs.webkit.org/show_bug.cgi?id=54389

  • platform/gtk/Skipped:
05:20 Changeset [78470] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=54277

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::showPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::stopUserInitiatedProfiling):
05:13 Changeset [78469] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-14 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743

Adds a test to ensure style 'max-width: none' works correctly.

  • fast/css/max-width-none-expected.txt: Added.
  • fast/css/max-width-none.html: Added.

2011-02-14 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743

Fix a bug that "max-width:none" works wrong.
See also: http://trac.webkit.org/changeset/13462

Test: fast/css/max-width-none.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-width of none, set it to Length(undefinedLength, Fixed), which is the correct value.
05:13 Changeset [78468] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
https://bugs.webkit.org/show_bug.cgi?id=54344

Reviewed by Andreas Kling.

Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
05:11 Changeset [78467] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-14 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix wrong popup position for RTL(again)
https://bugs.webkit.org/show_bug.cgi?id=54375

Fix right position bug introduce by https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.

No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset(). (WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect(). (WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value. (WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
  • platform/chromium/PopupMenuChromium.h: Change the function name and parameters.
05:06 Changeset [78466] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r78460 with more expectation updates.

  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
04:31 Changeset [78465] by alex@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r78451.
http://trac.webkit.org/changeset/78451
https://bugs.webkit.org/show_bug.cgi?id=53898

It is causing crashes in some bots

  • platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): (WebCore::TextCodecICU::registerBaseEncodingNames): (WebCore::TextCodecICU::registerBaseCodecs): (WebCore::TextCodecICU::registerExtendedEncodingNames): (WebCore::TextCodecICU::registerExtendedCodecs): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::getGbkEscape): (WebCore::urlEscapedEntityCallback): (WebCore::gbkCallbackEscape): (WebCore::gbkUrlEscapedEntityCallack): (WebCore::gbkCallbackSubstitute):
  • platform/text/TextCodecICU.h: (WebCore::ICUConverterWrapper::ICUConverterWrapper):
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): (WebCore::nonASCIISequenceLength): (WebCore::decodeNonASCIISequence): (WebCore::TextCodecUTF8::decode):
  • platform/text/TextCodecUTF8.h:
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
03:32 Changeset [78464] by hamaji@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectations for SVG tests.

  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
03:29 Changeset [78463] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r78460 with expectation updates.

  • inspector/styles-iframe-expected.txt:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
03:22 Changeset [78462] by hamaji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectation for http://trac.webkit.org/changeset/78449

  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Added.
03:14 Changeset [78461] by hamaji@chromium.org
  • 2 edits
    29 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectations for inline-box-background-*

  • platform/chromium-linux/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
02:58 Changeset [78460] by pfeldman@chromium.org
  • 83 edits
    3 moves
    1 add
    4 deletes in trunk/LayoutTests

2011-02-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
https://bugs.webkit.org/show_bug.cgi?id=54354

  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js: Renamed from LayoutTests/http/tests/inspector/console-tests2.js.
  • http/tests/inspector/console-tests.js: Removed.
  • http/tests/inspector/console-websocket-error.html:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/debugger-test.js: Renamed from LayoutTests/http/tests/inspector/debugger-test2.js.
  • http/tests/inspector/elements-test.js: Added.
  • http/tests/inspector/inspector-test2.js:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resource-tests.js: Removed.
  • http/tests/inspector/resources-test.js: Renamed from LayoutTests/http/tests/inspector/resource-test2.js.
  • inspector/command-line-api.html:
  • inspector/console-api-on-call-frame.html:
  • inspector/console-assert.html:
  • inspector/console-clear.html:
  • inspector/console-command-clear-expected.txt:
  • inspector/console-command-clear.html:
  • inspector/console-dir-global.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-eval-global.html:
  • inspector/console-eval.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format-expected.txt:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-log-syntax-error.html:
  • inspector/console-object-constructor-name.html:
  • inspector/console-tests.html:
  • inspector/console-trace-in-eval.html:
  • inspector/console-trace.html:
  • inspector/console-uncaught-exception-in-eval.html:
  • inspector/console-uncaught-exception.html:
  • inspector/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-on-call-frame.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-expand-scope.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-pause-on-exception.html:
  • inspector/debugger-proto-property.html:
  • inspector/debugger-scripts.html:
  • inspector/debugger-step-in.html:
  • inspector/debugger-step-out.html:
  • inspector/debugger-step-over.html:
  • inspector/debugger-suspend-active-dom-objects.html:
  • inspector/dom-breakpoints.html:
  • inspector/elements-delete-inline-style.html:
  • inspector/elements-img-tooltip-expected.txt:
  • inspector/elements-img-tooltip.html:
  • inspector/elements-panel-limited-children-expected.txt:
  • inspector/elements-panel-limited-children.html:
  • inspector/elements-panel-rewrite-href-expected.txt:
  • inspector/elements-panel-rewrite-href.html:
  • inspector/elements-panel-selection-on-refresh-expected.txt:
  • inspector/elements-panel-selection-on-refresh.html:
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-structure.html:
  • inspector/elements-panel-styles.html:
  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements-panel-xhtml-structure.xhtml:
  • inspector/elements-tests.js: Removed.
  • inspector/elements-tests2.js: Removed.
  • inspector/resources/elements-panel-styles.css:
  • inspector/resources/styles-iframe-data.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles-add-blank-property.html:
  • inspector/styles-computed-trace.html:
  • inspector/styles-disable-inherited.html:
  • inspector/styles-disable-then-change.html:
  • inspector/styles-disable-then-delete.html:
  • inspector/styles-disable-then-enable.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
  • inspector/styles-new-API.html:
  • inspector/styles-source-lines-expected.txt:
  • inspector/styles-source-lines-inline.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets.html:
  • inspector/styles-url-linkify.html:
02:54 Changeset [78459] by hamaji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test_expectations.

  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/chromium/test_expectations.txt:
01:28 Changeset [78458] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Need implementation of ResourceRequest and ResourceResponse serialization
https://bugs.webkit.org/show_bug.cgi?id=54339

Add dummy implementation with FIXME and let the core go with it for now.

  • Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
00:05 Changeset [78457] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster

Reviewed by Dan Bernstein.

  • use std::sort
  • cache specificity, it is slow to compute
  • inline compare function
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):

  • css/CSSStyleSelector.h:

02/13/11:

23:58 Changeset [78456] by hayato@chromium.org
  • 2 edits in trunk

2011-02-13 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore to ignore files which Ninja build system generates.

https://bugs.webkit.org/show_bug.cgi?id=54378

  • .gitignore:
21:01 WebKit Team edited by jhanssen@gmail.com
Add myself to the committer list (diff)
20:22 Changeset [78455] by tkent@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

The second attempt to merge r77114.
(It was merged by r78166 and reverted by r78381)

HTMLFormControlElement::insertedIntoDocument() and removedFromDocument()
should call HTMLElement::insertedIntoDocument() and removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=inferno@chromium.org

20:12 WebKit Team edited by helder@sencha.com
(diff)
20:02 Changeset [78454] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2011-02-13 Simon Fraser <simon.fraser@apple.com>

Change previous test to dump as text, with pixel output, to fix
Qt failure.

  • fast/gradients/css3-repeating-end-fill-expected.txt:
  • fast/gradients/css3-repeating-end-fill.html:
20:00 Changeset [78453] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

19:56 Changeset [78452] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20

New tag.

19:28 Changeset [78451] by darin@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-12 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
18:50 Changeset [78450] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.

Reviewed by Maciej Stachowiak.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

18:09 Changeset [78449] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2011-02-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Andreas Kling.

Repeating gradients drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53502

The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.

Test: fast/gradients/css3-repeating-end-fill.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
17:19 Changeset [78448] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

Unused variable result in RenderBlock::addOverflowFromFloats()
https://bugs.webkit.org/show_bug.cgi?id=54363

Remove the unused variable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats):
16:14 Changeset [78447] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Anders Carlsson.

WebCore fails to build with Clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54367

  • loader/PingLoader.h:

(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.

16:12 Changeset [78446] by andreas.kling@nokia.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-02-13 Andreas Kling <kling@webkit.org>

Unreviewed, remove unnecessary platform expectations for now-passing test.

  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
16:09 Changeset [78445] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative fix for

Reviewed by Maciej Stachowiak.

<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.

15:19 Changeset [78444] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Nico Weber <thakis@chromium.org>

Reviewed by Anders Carlsson.

RenderBR::width() tries but fails to override RenderText::width()
https://bugs.webkit.org/show_bug.cgi?id=54301

The superclass method's signature changed, e.g. in
http://trac.webkit.org/changeset/57215, but the subclass was not
updated.

  • rendering/RenderBR.h: (WebCore::RenderBR::width):
15:11 Changeset [78443] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>

Fix chromium's test_expectations

  • fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
  • fast/css/test-setting-canvas-color.html is failing
  • platform/chromium/test_expectations.txt:
13:41 Changeset [78442] by andreas.kling@nokia.com
  • 10 edits
    2 adds in trunk

2011-02-13 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168

Based on previous work by Julien Chaffraix <jchaffraix@codeaurora.org>
and Jan Erik Hanssen <jhanssen@sencha.com>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor.

(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.

  • css/CSSParser.h: Added the new parseSystemColor method.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work.
  • html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.

2011-02-13 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168

  • fast/css/test-setting-canvas-color-expected.txt: Added.
  • fast/css/test-setting-canvas-color.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
13:39 Changeset [78441] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

The plug-in process heap should be executable by default
https://bugs.webkit.org/show_bug.cgi?id=54364
<rdar://problem/8990563>

  • UIProcess/Launcher/ProcessLauncher.h: Add executableHeap flag.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Set the right posix_spawn flag if executableHeap is true.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize executableHeap to true.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::connect): Initialize executableHeap to false.
13:21 Changeset [78440] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Messages waited on are never dispatched
https://bugs.webkit.org/show_bug.cgi?id=54362
<rdar://problem/8995051>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage): Get the argument encoder from the incoming message.
12:28 Changeset [78439] by jeremy@chromium.org
  • 16 edits in trunk/Source

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

  • wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.

Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

No behavior changes so no new tests.

  • WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
  • WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
  • loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes):
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:04 Changeset [78438] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
https://bugs.webkit.org/show_bug.cgi?id=53320

The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.

  • platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL):
11:33 Changeset [78437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-13 Leo Yang <leo.yang.c@gmail.com>

Reviewed by Andreas Kling.

Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
https://bugs.webkit.org/show_bug.cgi?id=54351

We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.

No functionality change, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
11:23 Changeset [78436] by commit-queue@webkit.org
  • 10 edits
    6 adds
    2 deletes in trunk

2011-02-13 Jarred Nicholls <jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.

2011-02-13 Jarred Nicholls <jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html

fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
11:10 Changeset [78435] by abarth@webkit.org
  • 4 edits in trunk

2011-02-13 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
https://bugs.webkit.org/show_bug.cgi?id=54346

  • security/crypto-random-values-types-expected.txt:

2011-02-13 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
https://bugs.webkit.org/show_bug.cgi?id=54346

As requested by Sam.

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
11:06 Changeset [78434] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=54349
Inline some accessors in PrintContext

No change in behavior, so no tests.

  • WebCore.exp.in:
  • page/PrintContext.cpp:
  • page/PrintContext.h: (WebCore::PrintContext::pageCount): (WebCore::PrintContext::pageRect): Inline pageCount() and pageRect() to match pageRects().
11:05 Changeset [78433] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back
in with fixes to make it work with render layers.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::contentsSize):
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:
11:03 Changeset [78432] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=54348
Crash when printing a document with no pages

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake page that computePagesForPrinting() added to a pageless document.
10:46 Changeset [78431] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

10:35 Changeset [78430] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Roll out r78424. It broke a bunch of tests.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
09:39 Changeset [78429] by weinig@apple.com
  • 13 edits in trunk/Source/WebKit2

Reviewed and landed by Sam Weinig.

Patch by Chris Fleizach <cfleizach@apple.com> on 2011-02-13
AX: Update WK2 usage of remote accessibility api
https://bugs.webkit.org/show_bug.cgi?id=54220

Rename some of the remote accessibility methods to be more accurate.
Make sure to unregister the AccessibilityWebPageObject on dealloc.
Send the window remote token along with the WKView remote token.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):
(-[WKView _setAccessibilityWebProcessToken:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject dealloc]):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

02:12 Changeset [78428] by cwzwarich@webkit.org
  • 8 edits in trunk/Source

Reviewed by Dan Bernstein.

Bug 53760 - JSC fails to build with TOT Clang
https://bugs.webkit.org/show_bug.cgi?id=53760

Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.

JavaScriptCore:

  • API/JSCallbackObject.h: Remove pointlessly overloaded method.
  • API/JSCallbackObjectFunctions.h: Ditto.
  • runtime/Arguments.cpp:

(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.

  • runtime/Arguments.h: Ditto.

JavaScriptGlue:

  • UserObjectImp.cpp:

(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.

  • UserObjectImp.h:
02:02 Changeset [78427] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>

Update chromium's test expectations for fast/inline/inline-box-background-*

  • platform/chromium/test_expectations.txt:

02/12/11:

20:01 Changeset [78426] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=54335
<rdar://problem/8895141> Make window.print() work with WebKit2

  • Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): (WebKit::TiledDrawingAreaProxy::removeTile):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::postMessageToInjectedBundle): Updated for send() -> deprecatedSend() rename.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print(). (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation. (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving window.print(). (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ditto. (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching): When waiting for a web process to launch, store message flags, too. This is not practically important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags than to remember about this pitfall.
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send(). (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was conflicting with the other one after adding a flags argument. This matches a change previously made to CoreIPC::Connection.
16:18 Changeset [78425] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
https://bugs.webkit.org/show_bug.cgi?id=54345

Some sites flip between composited and non-comosited state while loading. When the timing is
right, when we flip out of compositing we will need to do a display while tossing all the
compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
while we are in the middle of tossing layers, which leads to a crash.

The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
doing its display, using a timer.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
  • WebProcess/WebPage/DrawingAreaImpl.h:
15:31 Changeset [78424] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>

Reviewed by Dan Bernstein.

When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.

In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.

(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):

  • rendering/RenderListBox.h:

Add implementations for visibleHeight/visibleWidth.

14:42 Changeset [78423] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

Follow up fix to:
https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
14:13 Changeset [78422] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342

Test which types of arrays work with crypto.getRandomValues.

  • security/crypto-random-values-types-expected.txt: Added.
  • security/crypto-random-values-types.html: Added.

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342

As discussed on whatwg, we should support all the integer array types.

Test: security/crypto-random-values-types.html

  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
13:35 Changeset [78421] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279

I'm not sure it makes much of a difference whether we use arc4random or
/dev/urandom on Mac. However, there's some aesthetic benefit to using
the same underlying API on as many platforms as reasonable.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.

Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279

Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.

  • config.h:
13:10 Changeset [78420] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2011-02-12 Chang Shu <cshu@webkit.org>

Unreviewed.

Update my own email addresses and IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
12:46 Changeset [78419] by zmo@google.com
  • 8 edits in trunk/Source

2011-02-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321

  • public/WebSettings.h: Add a flag for multisampling setting.
  • src/WebSettingsImpl.cpp: Ditto. (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
  • src/WebSettingsImpl.h: Ditto.

2011-02-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
  • page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled):
  • page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled):
12:32 Changeset [78418] by kdecker@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
<rdar://problem/8990069>


  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added. (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
  • WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
04:37 Changeset [78417] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Deploy EditingStyle in applyBlockStyle and applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=53911

Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.

No new tests are added since this is a refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
  • editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
  • editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude.
03:56 Changeset [78416] by jochen@chromium.org
  • 13 edits
    2 adds in trunk

2011-02-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193

  • storage/indexeddb/objectstore-clear-expected.txt: Added.
  • storage/indexeddb/objectstore-clear.html: Added.

2011-02-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193

Test: storage/indexeddb/objectstore-clear.html

  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2011-02-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193

  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::clear):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::clear):
  • src/WebIDBObjectStoreImpl.h:
02:13 Changeset [78415] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <abarth@webkit.org>

Another attempt to fix the EFL build. Looks like we're missing one
more file.

  • CMakeLists.txt:
02:01 Changeset [78414] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <abarth@webkit.org>

Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.

  • CMakeLists.txt:
01:39 Changeset [78413] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix.

  • dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets):
01:36 Changeset [78412] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <abarth@webkit.org>

CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.

  • WebCore.pro:
01:29 Changeset [78411] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-12 Adam Barth <abarth@webkit.org>

Update test expectations on Windows to account for ArrayBuffers being
on by default.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
  • platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
01:18 Changeset [78410] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <abarth@webkit.org>

Apparently lines in .pro files need to be \-terminated.

  • WebCore.pro:
01:10 Changeset [78409] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a function to process contents for one node from Range::processContents
https://bugs.webkit.org/show_bug.cgi?id=54282

Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.

When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).

When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).

No new tests are added since this is a refactoring.

  • dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added.
  • dom/Range.h:
01:07 Changeset [78408] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-12 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt Windows build.

  • WebCore.pro:
00:24 Changeset [78407] by abarth@webkit.org
  • 54 edits
    3 deletes in trunk

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310

Export the required functions.

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310

As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
  • page/Crypto.h:
  • page/Crypto.idl:
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

2011-02-12 Adam Barth <abarth@webkit.org>

Reviewed by Kenneth Russell.

Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310

Revert incorrect expectations from
http://trac.webkit.org/changeset/78337. These results were cased by
ArrayBuffers not beign enabled on Windows previous to this patch.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-function-resolve-expected.txt: Removed.
  • platform/win/fast/js/var-declarations-shadowing-expected.txt: Removed.
  • platform/win/security: Removed.
  • platform/win/security/crypto-random-values-expected.txt: Removed.

02/11/11:

20:57 Changeset [78406] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-11 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

indexeddb: add onBlocked to WebKit::WebIDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=54329

  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onBlocked):
19:16 Changeset [78405] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Can’t open local files on reload or navigation from the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=54332
<rdar://problem/8903076>

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::isInspectorPage):
  • UIProcess/WebInspectorProxy.h: Check whether the given page is a web inspector page.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeSandboxExtensionHandle): If this is a web inspector page, we don't want to make a sandbox extension.

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
Pass a sandbox extension along when sending the message.

  • UIProcess/WebPageProxy.h: Make initializeSandboxExtensionHandle a member function.
  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Pass a sandbox extension along.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goForward): (WebKit::WebPage::goBack): (WebKit::WebPage::goToBackForwardItem): Hand the sandbox extension to the sandbox extension tracker.

(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
Pass the sandbox extension to goToBackForwardItem.

(WebKit::shouldReuseCommittedSandboxExtension):
New function that checks whether a committed sandbox extension should be re-used. We
do this for page reloads, as well as regular page navigations when both the committed
and provisional documents have file URLs.

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Reuse the committed sandbox extension if necessary.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
19:09 Changeset [78404] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix Snow Leopard build.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didFailToSendSyncMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didFailToSendSyncMessage):

18:50 Changeset [78403] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt webkit2 build fix after r78392.

  • WebProcess/WebProcess.h:
18:42 Changeset [78402] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Daniel Bates <dbates@rim.com>

Reviewed by Geoffrey Garen.

Remove explicit disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports
https://bugs.webkit.org/show_bug.cgi?id=54107


It is unnecessary to explicitly disable ENABLE_ASSEMBLER_WX_EXCLUSIVE
by the definition of ENABLE().

  • wtf/Platform.h:
18:05 Changeset [78401] by pkasting@chromium.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Unify identical expectation files in chromium/ and update for r78383.

  • platform/chromium-mac/fast/url/port-expected.txt: Removed.
  • platform/chromium-win/fast/url/port-expected.txt: Removed.
  • platform/chromium/fast/url/port-expected.txt: Copied from platform/chromium-win/fast/url/port-expected.txt.
17:49 Changeset [78400] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebProcess hung communicating with the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=54328
<rdar://problem/8854075>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection): Add the DispatchMessageEvenWhenWaitingForSyncReply message send flag when sending the PluginProcess::CreateWebProcessConnection message, since the plug-in process can be busy waiting for a sync reply from the web process.
17:45 Changeset [78399] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Incoming synchronous messages should always be processed regardless of connection waiting for a reply
https://bugs.webkit.org/show_bug.cgi?id=54326

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::getOrCreate): Assert that the map has a non-null SyncMessageState object.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_waitForSyncReplyCount.

(CoreIPC::Connection::SyncMessageState::beginWaitForSyncReply):
Increment m_waitForSyncReplyCount.

(CoreIPC::Connection::SyncMessageState::endWaitForSyncReply):
Decrement m_waitForSyncReplyCount. If it's 0, enqueue any incoming sync messages.

(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
If this is a message that needs to be dispatched, add it to the queue and wake up the client run loop.

(CoreIPC::Connection::SyncMessageState::dispatchMessages):
Go through the queue of incoming messages and dispatch them.

(CoreIPC::Connection::sendSyncMessage):
call beginWaitForSyncReply/endWaitForSyncReply.

(CoreIPC::Connection::waitForSyncReply):
Dispatch messages.

(CoreIPC::Connection::processIncomingMessage):
Call SyncMessageState::processIncomingMessage.

(CoreIPC::Connection::enqueueIncomingMessage):
Add helper function for enqueuing an incoming message.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::destinationID):
17:42 Changeset [78398] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-02-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

This patch adds to NRWT most of the support needed to run the new
message-based workers in separate threads or processes. The code
isn't fully complete yet because we don't support cancel() or
is_alive().

https://bugs.webkit.org/show_bug.cgi?id=54070

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:36 Changeset [78397] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2: Going to Ars Technica crashes WebProcess in WebCore::ResourceRequestBase::url() const + 9
<rdar://problem/8978832>

Reviewed by Maciej Stachowiak.

Speculative fix for crash accessing a bad ResourceRequest in policy
client code. Remove early returns from dispatchDecidePolicyForMIMEType
and dispatchDecidePolicyForNavigationAction that are not present in the WebKit1
equivalent code. This should be safe, now that the IPC calls are synchronous.

Also removes some invalid assertions in WebFrameProxy that were getting hit. It is okay
for the url to empty.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

17:34 Changeset [78396] by yael.aharon@nokia.com
  • 3 edits
    19 adds in trunk

2011-02-11 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862

  • fast/inline/inline-box-background-long-image.html: Added.
  • fast/inline/inline-box-background-repeat-x.html: Added.
  • fast/inline/inline-box-background-repeat-y.html: Added.
  • fast/inline/inline-box-background.html: Added.
  • fast/inline/resources: Added.
  • fast/inline/resources/checker.png: Added.
  • fast/inline/resources/gradient.png: Added.
  • platform/mac/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt: Added.

2011-02-11 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862

When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order.

Tests: fast/inline/inline-box-background-long-image.html

fast/inline/inline-box-background-repeat-x.html
fast/inline/inline-box-background-repeat-y.html
fast/inline/inline-box-background.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
17:17 Changeset [78395] by commit-queue@webkit.org
  • 9 edits in trunk

2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318

Broke Safari extensions (Requested by eseidel on #webkit).

  • fast/url/host-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318

Broke Safari extensions (Requested by eseidel on #webkit).

  • platform/KURL.cpp: (WebCore::KURL::parse):
17:07 Changeset [78394] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8976456> Scrollbars for overflow
areas never appear for WKScrollbarPainter scrollers

Reviewed by Sam Weinig.

Call ScrollableArea::didAddVerticalScrollbar() and
ScrollableArea::willRemoveVerticalScrollbar() when
appropriate for RenderLayers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

16:57 Changeset [78393] by pkasting@chromium.org
  • 3 edits
    2 moves in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Also moved a test that's not Linux-specific and other platforms seem to
pass from chromium-linux/ to chromium/.

  • platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Removed.
  • platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/text/international/complex-text-rectangle-expected.txt: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt.
  • platform/chromium/fast/text/international/complex-text-rectangle.html: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle.html.
  • platform/chromium/test_expectations.txt:
16:24 Changeset [78392] by ap@apple.com
  • 7 edits in trunk/Source/WebKit2

Reviewed by Darin Adler and Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=53593
<rdar://problem/8948380> Crash beneath HistoryController::recursiveSetProvisionalItem in web
process (preceded by assertion failure) if UI process exits while
Messages::WebPage::RestoreSessionAndNavigateToCurrentItem is being handled

Can't test exiting the UI process.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Client::didFailToSendSyncMessage): Notify connection client when the connection fails to send a sync message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didFailToSendSyncMessage):
  • WebProcess/WebProcess.h: Quit the web process immediately if it tried to send a sync message to a dead UI process. It never needs to continue and handle an unexpected null "reply".
  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::didFailToSendSyncMessage):
  • PluginProcess/PluginProcess.h: Ditto. There is no need for a plug-in to keep running even briefly if it couldn't get a reply to a sync message.
16:17 Changeset [78391] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <mihaip@chromium.org>

Unrevied chromium-gpu expectations update. Update expectations for
chromium-gpu-mac (it often has image diffs only, since it can use the
text results from the mac port).

  • platform/chromium/test_expectations.txt:
16:16 Changeset [78390] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Not reviewed.

Randomly touch some build files in the hopes of fixing the Qt build.

16:13 Changeset [78389] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320

Reviewed by Sam Weinig.

(Rolling back in r78386 with the build fixed.)

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make
our timer inert after forcing a GC, to avoid GC'ing repeatedly.

16:10 Changeset [78388] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark tests that fail only on
Snow Leopard, so that we can begin to have green Snow Leopard bots.

  • platform/chromium/test_expectations.txt:
16:06 Changeset [78387] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Used svn merge -r78386:78385 to roll out r78386 because it broke the build.

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallbackPlatformData::trigger):

15:58 Changeset [78386] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make our timer inert after forcing a GC, to avoid GC'ing repeatedly.
15:49 Changeset [78385] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a way to send async messages that can't get out of order with sync ones
https://bugs.webkit.org/show_bug.cgi?id=54319
<rdar://problem/8894844>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): sendMessage now takes a messageSendFlags. Update the messageID if the messageSendFlags contain DispatchMessageEvenWhenWaitingForSyncReply.

(CoreIPC::Connection::waitForSyncReply):
Process asynchronous messages as well.

(CoreIPC::Connection::processIncomingMessage):
Check if a message should be dispatched even when we're waiting for a
synchronous reply.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): Send now takes a messageSendFlags parameter.
  • Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::messageIDWithAddedFlags): Return a new MessageID object with the given flags added.

(CoreIPC::MessageID::shouldDispatchMessageWhenWaitingForSyncReply):
Add getter.

15:48 Changeset [78384] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build: added an exported symbol.

15:47 Changeset [78383] by eric@webkit.org
  • 12 edits in trunk

2011-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090

Added a new test to show that we are intentionally removing
a colon after a host name. http://foo.com:/ -> http://foo.com/

  • fast/url/port-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/segments-expected.txt:
  • fast/url/segments-from-data-url-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090

  • platform/KURL.cpp: (WebCore::isDefaultPortForScheme): (WebCore::KURL::parse):
15:31 Changeset [78382] by ggaren@apple.com
  • 18 edits
    1 delete in trunk/Source

2011-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298


CollectorHeapIterator is a God object that knows the internals of each
of the pieces of the heap. This undermines the encapsulation I'm trying
to achieve by splitting concepts into different classes.


As an alternative, I've given each class a forEach iteration function,
which takes a functor as an argument. Now, each class just needs to
know how to iterate the things it knows about.

  • debugger/Debugger.cpp: (JSC::Recompiler::Recompiler): (JSC::Recompiler::~Recompiler): (JSC::Recompiler::operator()): (JSC::Debugger::recompileAllJSFunctions): Updated to use forEach interface instead of an iterator.
  • runtime/CollectorHeapIterator.h: Removed.
  • runtime/Heap.cpp: (JSC::TypeCounter::TypeCounter): (JSC::TypeCounter::typeName): (JSC::TypeCounter::operator()): (JSC::TypeCounter::take): (JSC::Heap::protectedObjectTypeCounts): (JSC::Heap::objectTypeCounts): Added forEach and removed iterator.
  • runtime/Heap.h: (JSC::Heap::forEach):
  • runtime/JSGlobalData.cpp: (JSC::Recompiler::operator()): (JSC::JSGlobalData::recompileAllJSFunctions):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::forEach): Added forEach. Removed friend declaration for CollectorHeapIterator. Now, we can make all our data private and change it without breaking any other classes.
  • runtime/MarkedSpace.cpp:
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::forEach): Added forEach and removed iterator.

2011-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298

  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):

2011-02-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
15:16 Changeset [78381] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Crash with dynamic popup menu use
<rdar://problem/8716952>

Reviewed by Anders Carlsson.

Invalidate popup menus when forcing them closed, since they might still be
in their tracking loop.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):

  • UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::invalidate):

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):

15:13 Changeset [78380] by inferno@chromium.org
  • 2 deletes in branches/chromium/597/LayoutTests/fast/canvas/webgl

remove accidently added .orig files

15:12 Changeset [78379] by inferno@chromium.org
  • 5 edits
    2 adds in branches/chromium/597

Merge 77956, crbug 71717

15:09 Changeset [78378] by inferno@chromium.org
  • 6 edits in branches/chromium/597/WebCore

Revert 78366 - Revert 78101 - Merge r76728, crbug 68263

Review URL: http://codereview.chromium.org/6508005

15:05 Changeset [78377] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend
is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp

No new tests. All existing canvas layouttests exercise this code path

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
14:56 Changeset [78376] by inferno@chromium.org
  • 4 edits in branches/chromium/597/WebCore

Revert 78354 - Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005

Review URL: http://codereview.chromium.org/6510003

14:56 Changeset [78375] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Actually initialize m_syncMessageState.

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):

14:46 Changeset [78374] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.

compositing/reflections/reflection-opacity.html has a JS exception
https://bugs.webkit.org/show_bug.cgi?id=54314

The JS code that the test was running was producing an error, and in
any case it didn't seem to be doing anything, since we don't define a
"moved" class (copy-and-paste error?).

  • compositing/reflections/reflection-opacity.html:
  • platform/mac/compositing/reflections/reflection-opacity-expected.txt:
14:45 Changeset [78373] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Mihai Parparita <mihaip@chromium.org>

Unrevied chromium-gpu expectations update. Remove failing expectations
for tests that now pass on the chromium-gpu-win bot.

  • platform/chromium/test_expectations.txt:
14:38 Changeset [78372] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Move the binary semaphore into SyncMessageState
https://bugs.webkit.org/show_bug.cgi?id=54311

With this change, all connections that belong to the same run loop will use same binary semaphore.
This is in preparation for making any connection be able to wakeup the client run loop.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::wakeUpClientRunLoop): (CoreIPC::Connection::SyncMessageState::wait): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::connectionDidClose):
  • Platform/CoreIPC/Connection.h:
14:26 Changeset [78371] by inferno@chromium.org
  • 4 edits
    2 deletes in branches/chromium/597

Revert 78166 - Merge r77114

Review URL: http://codereview.chromium.org/6508002

14:21 Changeset [78370] by mrobinson@webkit.org
  • 2 edits
    5 deletes in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Explicitly skip webarchive tests on GTK+, because we do not
support them. Remove all GTK+-specific webarchive expected results.

  • platform/gtk/Skipped: Explicitly skip all webarchive tests.
  • platform/gtk/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt: Removed.
  • platform/gtk/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
14:14 Changeset [78369] by mrobinson@webkit.org
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
14:03 Changeset [78368] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-11 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add a SyncMessageState class to CoreIPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=54309

SyncMessageState objects are shared between all connections scheduled on
a given run loop. It will be used to keep track of state when waiting
for replies for a synchronous message.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::syncMessageStateMap): (CoreIPC::Connection::SyncMessageState::syncMessageStateMapMutex): Add a global RunLoop -> SyncMessageState map and a mutex for locking.

(CoreIPC::Connection::SyncMessageState::getOrCreate):
Look in the map for an existing SyncMessageState object and create a new
one if none is found.

(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_runLoop.

(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
Remove the object from the map.

14:03 Changeset [78367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Adam Klein <adamk@chromium.org>

Reviewed by Darin Adler.

Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=54304

This avoids potential crashes in HashMap, as WTF's StringHash doesn't
accept empty Strings.

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
13:56 Changeset [78366] by inferno@chromium.org
  • 6 edits
    2 deletes in branches/chromium/597

Revert 78101 - Merge r76728, crbug 68263

Review URL: http://codereview.chromium.org/6474050

13:51 Changeset [78365] by mihaip@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-02-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Add more fine-grained
expectations for compositing on Windows (instead of the whole directory
being marked PASS FAIL). Also replace all FAIL GPU expectations with
more specific ones (e.g. TEXT or IMAGE+TEXT).

  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.checksum: Added.
  • platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:41 Changeset [78364] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

plugins/invalidate_rect.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=54122

This test was fixed on Windows in http://trac.webkit.org/changeset/78359. Remove the failing
expected results. Unreviewed.

  • platform/win/plugins/invalidate_rect-expected.txt: Removed.
13:39 Changeset [78363] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

crashes in WebProcess at WebCore::Range::startPosition const + 16
https://bugs.webkit.org/show_bug.cgi?id=54294
<rdar://problem/8982710>

Reviewed by Darin Adler.

I don't have a repro case for this bugs, but the side-by-side
comparison of the IME support implementation in WebKit and WebKi2
shows a missing null check on a Range that could very well explain
this crash.
I tried running platform/mac/editing/input tests with a version of WebKit
without the null check and I can reproduce a crash with the same signature.
These tests are not yet enabled for WebKit2.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::firstRectForCharacterRange):

13:39 Changeset [78362] by commit-queue@webkit.org
  • 22 edits
    11 adds in trunk

2011-02-11 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529

Tests for filesystem: URIs, testing both their security origin
properties and the existence of the Entry.toURI method.

  • fast/filesystem/directory-entry-to-uri-expected.txt: Added.
  • fast/filesystem/directory-entry-to-uri.html: Added.
  • fast/filesystem/file-entry-to-uri-expected.txt: Added.
  • fast/filesystem/file-entry-to-uri.html: Added.
  • fast/filesystem/filesystem-uri-origin-expected.txt: Added.
  • fast/filesystem/filesystem-uri-origin.html: Added.
  • fast/filesystem/resources/directory-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestDirectory): ():
  • fast/filesystem/resources/file-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestFile): ():
  • http/tests/security/filesystem-iframe-from-remote-expected.txt: Added.
  • http/tests/security/filesystem-iframe-from-remote.html: Added.
  • http/tests/security/resources/create-filesystem-file.html: Added.

2011-02-11 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529

There are two major parts to this patch: one is to add an
implementation of Entry.toURI to the FileSystem API.
The other is to implement security origin checking for this
new scheme.

All changes are guarded by the FILE_SYSTEM feature. An accompanying
Chromium change, to support loading of filesystem: URIs, has recently
been submitted as Chromium r74082.

Spec:

http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2

Proposed URI format, and discussion of security origin issues:

http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html

Tests: fast/filesystem/directory-entry-to-uri.html

fast/filesystem/file-entry-to-uri.html
fast/filesystem/filesystem-uri-origin.html
http/tests/security/filesystem-iframe-from-remote.html

  • fileapi/Entry.cpp: (WebCore::Entry::toURI):
  • fileapi/Entry.h:
  • fileapi/Entry.idl:
  • Added toURI method to the IDL, omitting the MIME type argument specified in the spec as it will soon be removed.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • crack the filesystem: URI to get at the origin of the site (WebCore::SecurityOrigin::canDisplay):
  • canDisplay for filesystem: URIs is equivalent to canRequest
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::create): (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::type):
  • Exposed filesystem type to allow toURI to use it as part of the path. (WebCore::AsyncFileSystem::AsyncFileSystem):
  • platform/SchemeRegistry.cpp: (WebCore::canDisplayOnlyIfCanRequestSchemes): (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest): (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
  • Generalized canDisplayOnlyIfCanRequest as it applies to both filesystem: and blob: URIs.
  • platform/SchemeRegistry.h:

2011-02-11 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529

Changes to Chromium WebKit API required to expose
the FileSystem type to WebCore's fileapi code, since the
type is part of the filesystem URI.

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
  • src/AsyncFileSystemChromium.h: (WebCore::AsyncFileSystemChromium::create):
  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
  • src/WebFileSystemCallbacksImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
  • src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create):
13:21 Changeset [78361] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62

Reviewed by Darin Adler.

Must check for null _animator.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

12:52 Changeset [78360] by crogers@google.com
  • 5 edits in trunk/Source/WebCore

2011-02-11 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
https://bugs.webkit.org/show_bug.cgi?id=54158

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
  • bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::createBufferCallback):
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • webaudio/AudioContext.idl:
12:41 Changeset [78359] by commit-queue@webkit.org
  • 6 edits in trunk

2011-02-11 Sailesh Agrawal <sail@chromium.org>

Reviewed by Kenneth Russell.

plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051

invalidate_rect.html should now pass on Windows. Removing skip.

  • platform/chromium/test_expectations.txt:

2011-02-11 Sailesh Agrawal <sail@chromium.org>

Reviewed by Kenneth Russell.

plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051

This change fixes the invalidate_rect.html test failure on Windows.

There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.

The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.

This change also updates the build path in chromium_win.py to use the new Source directory.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventWin): (NPP_HandleEvent):
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
12:24 Changeset [78358] by mrobinson@webkit.org
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Add another batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
12:19 Changeset [78357] by mrobinson@webkit.org
  • 2 edits
    148 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
12:10 Changeset [78356] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
https://bugs.webkit.org/show_bug.cgi?id=54224

No new tests. Existing canvas tests exercise this...
fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
11:53 Changeset [78355] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-02-11 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by David Levin.

Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390

No new tests.

  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl: Wrap methods and declarations that use HTMLVideoElement with #if ENABLE(VIDEO).
11:44 Changeset [78354] by inferno@chromium.org
  • 5 edits in branches/chromium/597/WebCore

Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005

11:41 Changeset [78353] by mrobinson@webkit.org
  • 2 edits
    142 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Add the next batch of GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:37 Changeset [78352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] wmode gets overridden even if already windowless in QGraphicsWebView
Do not override wmode if it is not set to "window".
https://bugs.webkit.org/show_bug.cgi?id=50495

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
11:23 Changeset [78351] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Eliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
https://bugs.webkit.org/show_bug.cgi?id=54296

Reviewed by Steve Falkenburg.

  • win/WebKit2Common.vsprops: Remove msimg32.dll from the list of DelayLoadDLLs.
11:16 Changeset [78350] by alex@webkit.org
  • 5 edits
    4 adds in trunk/Source/WebKit2

2011-02-11 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy
classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54080

  • GNUmakefile.am:
  • Shared/gtk/UpdateChunk.cpp: Added. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/gtk/UpdateChunk.h: Added. (WebKit::UpdateChunk::rect): (WebKit::UpdateChunk::isEmpty): (WebKit::UpdateChunk::size):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): Initialize the surface.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h: Added cairo variables.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingAreaProxy::page): (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
11:03 Changeset [78349] by sergio@webkit.org
  • 5 edits
    2 deletes in trunk

2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
  • platform/gtk/accessibility/document-reload-events.html: Removed.

2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach):

2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295

This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus):
10:42 Changeset [78348] by mrobinson@webkit.org
  • 2 edits
    461 adds in trunk/LayoutTests

2011-02-11 Martin Robinson <mrobinson@igalia.com>

Generate more GTK+ results for many SVG tests missing them.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:21 Changeset [78347] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introduction in
r76621.
https://bugs.webkit.org/show_bug.cgi?id=54291

Unreviewed, adding this test to the Windows XP skip list in order to get the bots green.

  • platform/win-xp/Skipped:
10:11 Changeset [78346] by kov@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GDOM] Video element needs proper wrapping
https://bugs.webkit.org/show_bug.cgi?id=54231

Use the same strategy as the one used for the audio tag to wrap
video as well. No layout tests because this only adds API.

  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createVideoWrapper): (WebKit::createHTMLElementWrapper):
10:00 Changeset [78345] by krit@webkit.org
  • 59 edits in trunk/Source/WebCore

2011-02-11 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
https://bugs.webkit.org/show_bug.cgi?id=54259

Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
avoid overloading a virtual function.

No change of functionality. Just fixing a build warning, so no new tests.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
09:54 Changeset [78344] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

  • platform/win-xp/fast/dom: Added.
  • platform/win-xp/fast/dom/52776-expected.txt: Added.
09:43 Changeset [78343] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
https://bugs.webkit.org/show_bug.cgi?id=54089

09:28 Changeset [78342] by japhet@chromium.org
  • 32 edits in trunk/Source

2011-02-10 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489

Refactor, no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::explicitClose): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
09:16 Changeset [78341] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-11 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added two tests to the skipped file that started to fail only in
64-bit debug bot. Rounding issues are most likely the source of
differences between 32 and 64bit bots.

  • platform/gtk/Skipped: added svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
08:48 ApplicationsGtk edited by christian@webkit.org
(diff)
08:47 ApplicationsGtk edited by christian@webkit.org
(diff)
08:36 Changeset [78340] by ager@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-02-11 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

Remove unnecessary chromium layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=54278

  • platform/chromium/fast/js/ToNumber-expected.txt: Removed.
  • platform/chromium/fast/js/parseFloat-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.
08:24 Changeset [78339] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: unflake inspector test (2).

  • inspector/command-line-api.html:
  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.selectElementAndRun):
07:47 Changeset [78338] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: unflake inspector test.

  • inspector/command-line-api-expected.txt:
  • inspector/command-line-api.html:
07:42 Changeset [78337] by jberlin@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
fast/js/global-function-resolve.html,
fast/js/var-declarations-shadowing.html,
and security/crypto-random-values.html failing since r78321.
https://bugs.webkit.org/show_bug.cgi?id=54285

Unreviewed, landing expected failing results to get the bots green.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-function-resolve-expected.txt: Added.
  • platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
  • platform/win/security: Added.
  • platform/win/security/crypto-random-values-expected.txt: Added.
07:23 Changeset [78336] by pfeldman@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-02-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
https://bugs.webkit.org/show_bug.cgi?id=54227

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler):
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::mainDOMContentLoaded): (WebCore::InspectorDOMAgent::loadEventFired):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::FrontendProvider::create): (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider): (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::mute): (WebCore::InspectorState::updateCookie):
  • inspector/InspectorState.h: (WebCore::InspectorState::~InspectorState):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
06:54 Changeset [78335] by pfeldman@chromium.org
  • 5 edits in trunk

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283

  • inspector/command-line-api-expected.txt:
  • inspector/command-line-api.html:

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283

  • inspector/InjectedScriptSource.js:
06:21 Changeset [78334] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Increase the timeout of Qt API tests to 120 seconds.

Reviewed by Andreas Kling.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
05:25 Changeset [78333] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-11 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

CryptographicRandomNumber has its threading ifdefs backwards
https://bugs.webkit.org/show_bug.cgi?id=54280

Turns out we want the mutex when thread is enabled. :)

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
05:19 Changeset [78332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Andreas Kling.

[Qt][S60] Vertical borders of buttons and frames are misaligned
https://bugs.webkit.org/show_bug.cgi?id=51169

Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
without anti-aliasing. Patch idea by Laszlo Agocs.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
04:53 Changeset [78331] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Added new layout test to check the right signals are emitted.

  • platform/gtk/accessibility/document-reload-events-expected.txt: Added.
  • platform/gtk/accessibility/document-reload-events.html: Added.

2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

Test: platform/gtk/accessibility/document-reload-events.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
03:19 Changeset [78330] by abarth@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-11 Adam Barth <abarth@webkit.org>

Turns out that expectation isn't Qt specific.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.
02:53 Changeset [78329] by abarth@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-02-11 Adam Barth <abarth@webkit.org>

Update Qt expected results for window.crypto.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
02:50 Changeset [78328] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
  • inspector/command-line-api-expected.txt: Added.
  • inspector/command-line-api.html: Added.

2011-02-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275

Test: inspector/command-line-api.html

  • inspector/InjectedScriptSource.js:
02:31 Changeset [78327] by abarth@webkit.org
  • 7 edits in trunk

2011-02-11 Adam Barth <abarth@webkit.org>

Turns out window.crypto is supposed to be readonly.

  • page/DOMWindow.idl:

2011-02-11 Adam Barth <abarth@webkit.org>

Update test expectations to show window.crypto.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
02:10 Changeset [78326] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-02-11 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added new test expectations for the GTK port.

  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
01:34 Changeset [78325] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Adam Barth <abarth@webkit.org>

Actually add Crypto.cpp to the Windows build. I'm terrible.

  • WebCore.vcproj/WebCore.vcproj:
01:21 Changeset [78324] by abarth@webkit.org
  • 1 edit in trunk/Source/WebCore/page/Crypto.h

Fix typo

01:12 Changeset [78323] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-11 Adam Barth <abarth@webkit.org>

Attempt to fix the Windows build. Apparently we don't support
conditional attributes on functions. This patch makes the whole Crypto
interface conditional on ArrayBuffer support.

  • page/DOMWindow.idl:
  • page/Crypto.cpp:
  • page/Crypto.h:
  • page/Crypto.idl:
00:57 Changeset [78322] by antti@apple.com
  • 6 edits in trunk/Source/WebCore

Enable ancestor identifier filtering for tree building
https://bugs.webkit.org/show_bug.cgi?id=54241

Reviewed by Dave Hyatt.

Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.

This roughly halves the remaining time in style matching over a typical page load.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Document.h:

(WebCore::Document::styleSelectorIfExists):

  • dom/Element.cpp:

(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

  • dom/Element.h:
00:37 Changeset [78321] by abarth@webkit.org
  • 21 edits
    6 adds in trunk

2011-02-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049

Test crypto.getRandomValues API. It's pretty hard to write a
deterministic API for a randomized API, but this test should catch some
regressions.

  • security/crypto-random-values-expected.txt: Added.
  • security/crypto-random-values.html: Added.

2011-02-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049

Teach JavaScriptCore how to export this function.

2011-02-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049

Add crypto.getRandomValues. Yes, all these diffs are required to
expose a single function to the DOM.

Test: security/crypto-random-values.html

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • config.h:
  • page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues):
  • page/Crypto.h: Added. (WebCore::Crypto::create):
  • page/Crypto.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto):
  • page/DOMWindow.idl:
00:26 Changeset [78320] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-11 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[GTK] Build break with 2.18.3
https://bugs.webkit.org/show_bug.cgi?id=54057

  • platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
00:14 Changeset [78319] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-11 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749

No new tests. Refactoring.

  • platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init):
  • platform/KURLGooglePrivate.h:

02/10/11:

23:36 Changeset [78318] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Temporarily skip a test that fails in WebKit2 due to a recent regression
https://bugs.webkit.org/show_bug.cgi?id=54276

  • platform/mac-wk2/Skipped:
23:21 Changeset [78317] by aestes@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-10 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

Convert ContainerNode::firstElementChild() to a free function.
https://bugs.webkit.org/show_bug.cgi?id=54269

No new tests. No change in behavior.

It seemed incorrect to have a method on ContainerNode that had the
concept of an Element but couldn't return an Element*, but a method on
Element could not be called by holders of ContainerNodes or other
non-Element ContainerNode subclasses. A free function can both return
an Element* and be called by anyone with a ContainerNode*.

  • dom/ContainerNode.h: (WebCore::ContainerNode::lastChild): (WebCore::Node::lastChild):
  • dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
  • dom/Element.cpp: (WebCore::Element::firstElementChild):
  • dom/Element.h: (WebCore::firstElementChild):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
22:50 Changeset [78316] by ager@chromium.org
  • 3 edits
    3 adds in trunk

2011-02-10 Mads Ager <ager@chromium.org>

Reviewed by Nate Chapin.

[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216

Check for exceptions when attempting to get the handleEvent property
of an event-handler object.

Test: fast/dom/exception-getting-event-handler.html

  • bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::getListenerFunction):

2011-02-10 Mads Ager <ager@chromium.org>

Reviewed by Nate Chapin.

[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216

Add crash regression test with custom chromium expectations.

  • fast/dom/exception-getting-event-handler-expected.txt: Added.
  • fast/dom/exception-getting-event-handler.html: Added.
  • platform/chromium/fast/dom/exception-getting-event-handler-expected.txt: Added.
22:38 Changeset [78315] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-10 Naoki Takano <takano.naoki@gmail.com>

Reviewed by James Robinson.

[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857

This fix is for 2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. Add 2d.composite.globalAlpha.fillPath.html as a new test for the combination with globalAlpha and fillPath().

  • fast/canvas/2d.composite.globalAlpha.fillPath-expected.txt: Added.
  • fast/canvas/2d.composite.globalAlpha.fillPath.html: Added.

2011-02-10 Naoki Takano <takano.naoki@gmail.com>

Reviewed by James Robinson.

[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857

globalAlpha is not applied to fillPath() and fillRect().

Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called. (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor. (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor.
22:35 Changeset [78314] by aestes@apple.com
  • 5 edits in trunk/Source/WebCore

2011-02-10 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Remove an unneeded argument from HTMLDocument::create().
https://bugs.webkit.org/show_bug.cgi?id=54268

Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for
fragment parsing, there isn't a need to explicitly specify a baseURL
when constructing an HTMLDocument. We can remove the unneeded argument.

Also fix some style issues in Document.h and HTMLDocument.h caught by
check-webkit-style.

No new tests. No change in behavior.

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
22:17 Changeset [78313] by mrobinson@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Clean up the skipped list and skip some tests that show differences
between the bots. Rebaseline Acid2 tests results.

  • platform/gtk/Skipped: Clean up the skipped list. Skip failing test.
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
21:34 Changeset [78312] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-02-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A little more encapsulation for MarkedBlock: Made all constants private
so clients don't know whether allocations are fixed-sized or not
https://bugs.webkit.org/show_bug.cgi?id=54270


SunSpider reports no change.

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::advance): Updated for removal of HeapConstants.
  • runtime/Error.cpp: Switched to using ASSERT_CLASS_FITS_IN_CELL, like all other classes.
  • runtime/Heap.cpp: (JSC::Heap::allocate): Updated for removal of HeapConstants. (JSC::Heap::reset): Updated to use size(), instead of calculating size on our own.
  • runtime/Heap.h: Moved the ASSERT here to MarkedBlock, since it enforces on special knowledge of fixed-sizery, which only MarkedBlock is supposed to know about.
  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for removal of HeapConstants. Also changed to reset nextCell to 0 at the end of a block, since that seems more consistent.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Changed to use a fixed array of char. This hard-coded size is a little wonky, but the compiler will tell us if it's ever wrong, so I think it's OK.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep): Updated for removal of HeapConstants.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::size): (JSC::MarkedBlock::capacity): Made constants private to this class. Removed HeapConstants. Added size() and capacity() functions.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::size): (JSC::MarkedSpace::capacity):
  • runtime/MarkedSpace.h: Use MarkedBlock helper functions instead of direct knowledge of MarkedBlock internals.
21:14 Changeset [78311] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

remove extra space from expansion lines
https://bugs.webkit.org/show_bug.cgi?id=54266

  • code-review.js:
21:12 Changeset [78310] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-09 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

only erase draft comments after publish is successful
https://bugs.webkit.org/show_bug.cgi?id=54163

If there is a conflict or 500, then draft comments will survive.
One drawback here is that the form post is now to the iframe,
so to break out of the iframe we redirect to the bug page, which
loses the information of who the email was sent to.

Once WebKit supports seamless iframes we should be able to avoid
the redirect.

  • code-review.js:
21:07 Changeset [78309] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, fix a typo.

  • platform/chromium/test_expectations.txt:
20:41 Changeset [78308] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
20:24 Changeset [78307] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
20:19 Changeset [78306] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
19:55 Changeset [78305] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
19:32 Changeset [78304] by zmo@google.com
  • 2 edits in trunk/Tools

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • DumpRenderTree/DumpRenderTree.gypi:
19:23 Changeset [78303] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A little more encapsulation for MarkedBlock: Made mark bits private
https://bugs.webkit.org/show_bug.cgi?id=54264


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients don't need to know that marks are represented as bits. Renamed markedCells => markCount, since clients don't need to know that blocks are split into cells.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::markCount): New helper functions for encapsulating the information clients actually need.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::clearMarks): (JSC::MarkedSpace::markCount): (JSC::MarkedSpace::objectCount):
  • runtime/MarkedSpace.h: Use new helper functions instead of accessing MarkedBlock data directly.
19:18 Changeset [78302] by dpranke@chromium.org
  • 5 edits
    1 add in trunk/Tools

2011-02-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

This patch adds the bulk of the remaining functionality for
the NRWT message-passing implementation. The patch adds a new
Worker class that will eventually replace the TestShellThread
class in dump_render_tree_thread.py, and implements enough of
TestRunner2 and the inline version of the manager_worker_broker
to actually be able to send a full set of messages back and
forth. The Worker stubs do not actually run tests, and there's
lots of error handling and stats needed, but this is the core
logic.

https://bugs.webkit.org/show_bug.cgi?id=54068

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
19:04 Changeset [78301] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

19:03 Changeset [78300] by mrowe@apple.com
  • 1 copy in tags/Safari-534.19

New tag.

18:57 Changeset [78299] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-10 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Re-landing this fix, bug without the test case, since it causes hangs on the bots.
https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test.

Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.

(WebKit::PluginView::evaluate):
Add a plug-in protector.

18:24 Changeset [78298] by zmo@google.com
  • 2 edits in trunk/Tools

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • DumpRenderTree/DumpRenderTree.gypi:
18:10 Changeset [78297] by msaboff@apple.com
  • 9 edits in trunk/Source

2011-02-10 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245

Added clear method which removes SourceProviderCache items.
Cleaned up extraneous whitespace.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • parser/SourceProviderCache.cpp: (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::clear): (JSC::SourceProviderCache::byteSize): (JSC::SourceProviderCache::add):
  • parser/SourceProviderCache.h:

2011-02-10 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245

Added logic in CachedScript to clear SourceProviderCache data in
destroyDecodedData(). Added and changed CachedScript timeout to
act similar to CachedImage. Changed didAddClient to call super
class method instead of duplicating the logic in the derived
classes.

  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
  • loader/cache/CachedScript.h:
18:06 Changeset [78296] by zmo@google.com
  • 2 edits in trunk/Tools

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • DumpRenderTree/DumpRenderTree.gypi:
17:45 Changeset [78295] by zmo@google.com
  • 2 edits in trunk/Tools

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, attempt to fix crashing plugin tests.

  • DumpRenderTree/DumpRenderTree.gypi:
17:26 Changeset [78294] by zmo@google.com
  • 2 edits in trunk/Tools

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • DumpRenderTree/DumpRenderTree.gypi:
17:23 Changeset [78293] by bdakin@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228

Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10
Reviewed by David Levin.

Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.

No new tests. This is a style fix.

  • platform/KURLGoogle.cpp:
  • platform/KURLGooglePrivate.h:
17:16 Changeset [78292] by joepeck@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-10 Joseph Pecoraro <joepeck@webkit.org>

Follow-up fix to r78291. I should pass (int) 0, not '0' to memset.

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change.
17:09 Changeset [78291] by joepeck@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-10 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Geoffrey Garen.

Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
https://bugs.webkit.org/show_bug.cgi?id=54257

A subclass may want to specify the CFRunLoop that the Garbage Collection
will happen on. It was difficult to manipulate this in a subclass because
the current DefaultGCActivityCallback class does this in its constructor.
This patch generalizes things a bit more so that a specific run loop can
be passed in to the constructor. This makes it so all run loop management
can stay in DefaultGCActivityCallback and a subclass can specify any runloop.

  • runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can specify the runloop GC can be scheduled on.
  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors, one that specifies the run loop and passes that on to commonConstructor and the old constructor defaults to the current run loop. (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction, adding the timer to the given runloop.
17:03 Changeset [78290] by mrobinson@webkit.org
  • 2 edits
    442 adds in trunk/LayoutTests

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Generate GTK+ results for many SVG tests missing them.

  • platform/gtk/Skipped: Unskip tests which now have results.
17:01 Changeset [78289] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-10 Cosmin Truta <ctruta@chromium.org>

Reviewed by David Levin.

Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228

Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.

No new tests. This is a style fix.

  • platform/KURLGoogle.cpp:
  • platform/KURLGooglePrivate.h:
16:56 Changeset [78288] by alice.liu@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=54254

Reviewed by Enrica Casucci and Adele Peterson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _handleStyleKeyEquivalent:]):
Return early if we're not in an editable region.

16:50 Changeset [78287] by weinig@apple.com
  • 2 edits in trunk/Tools

Try and fix some crashing tests on the chromium build bot.

  • DumpRenderTree/DumpRenderTree.gypi:
16:45 Changeset [78286] by aestes@apple.com
  • 8 edits
    2 adds in trunk

2011-02-10 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719


The HTML5 fragment parsing algorithm specifies that a new Document
should be created to serve as the temporary parent of fragment nodes
during parsing. Document creation is expensive and accounts for ~38% of
the Peacekeeper DOM performance regression. Avoid the cost of creating
a dummy document by using the already-created DocumentFragment as the
root node during fragment parsing.


With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~24%.

Test: fast/parser/fragment-parser-doctype.html

  • dom/ContainerNode.h: (WebCore::ContainerNode::firstElementChild): Add a method that returns the first element-typed child from a ContainerNode.
  • dom/Document.cpp: (WebCore::Document::cacheDocumentElement): Call ContainerNode::firstElementChild() to retrieve and cache the document element.
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the root ContainerNode. (WebCore::HTMLConstructionSite::detach): Clear the reference to the root ContainerNode. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Attach the new element to the root ContainerNode. (WebCore::HTMLConstructionSite::insertDoctype): Ditto. (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
  • html/parser/HTMLConstructionSite.h: Store a pointer to a ContainerNode that will be used as the root node for document parsing. This node might or might not be the same as m_document.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the HTMLConstructionSite with the correct root ContainerNode based on whether or not we're parsing a fragment. (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Remove m_dummyDocumentForFragmentParsing. (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the fragment has a context element, store only the children of the root element (HTML5 Section 10.4, Step 7).
  • html/parser/HTMLTreeBuilder.h:

2011-02-09 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

  • fast/parser/fragment-parser-doctype-expected.txt: Added.
  • fast/parser/fragment-parser-doctype.html: Added.
16:32 Changeset [78285] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative fix for <rdar://problem/8985232> Overlay
scrollers can appear on the sliding page during
back/forward fluid gesture

Reviewed by Oliver Hunt.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):

16:20 Changeset [78284] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-02-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little more encapsulation for MarkedBlock: Moved allocate() and sweep() into MarkedBlock
https://bugs.webkit.org/show_bug.cgi?id=54253


SunSpider reports no change.

  • runtime/CollectorHeapIterator.h: Removed DeadObjectIterator, since it is now unused.
  • runtime/Heap.cpp: (JSC::Heap::reset): Moved the call to shrink() here, since it seems a little more clear for MarkedSpace's client to tell it explicitly when to shrink.
  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Split out from MarkedSpace::allocate.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::sweep): Split out from MarkedSpace::sweep, and converted to more directly iterate a MarkedBlock based on knowing its internal structure.
  • runtime/MarkedBlock.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep):
  • runtime/MarkedSpace.h: Split out the code mentioned above.
16:14 Changeset [78283] by ojan@chromium.org
  • 4 edits in trunk/Websites/bugs.webkit.org

2011-02-09 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

save overall comments when saving drafts in the review tool
https://bugs.webkit.org/show_bug.cgi?id=54165

-save overall comments in localstorage as well
-save all draft comments as you type
-give a *subtle* indicator of saved state

The latter should also make it super easy if someone wanted to do
the work to store draft comments in appengine/s3/bugzilla/etc.

  • PrettyPatch/PrettyPatch.rb:
  • code-review-test.html:
  • code-review.js:
15:58 Changeset [78282] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:51 Changeset [78281] by andersca@apple.com
  • 3 edits in trunk/Tools

2011-02-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Log an error if a plug-in test can't be found
https://bugs.webkit.org/show_bug.cgi?id=54252

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::create): Return null if the test wasn't found.
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Report an error if PluginTest::create returns null.
15:49 Changeset [78280] by jorlow@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB event targets need to ensure their wrappers aren't garbage collected
https://bugs.webkit.org/show_bug.cgi?id=54144

hasActivityPending should return true as long as it's possible that we'll
fire more event listeners on our event targets. It is still possible for
user generated events to run into problems, but I'm not sure how to address
that yet (or how big of a deal it is).

There's really no way to test this deterministically. Testing by hand makes
it seem like this patch works as expected though.

  • storage/IDBCursorBackendImpl.cpp:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::hasPendingActivity): (WebCore::IDBDatabase::stop):
  • storage/IDBDatabase.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::hasPendingActivity): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::finished): (WebCore::IDBTransaction::hasPendingActivity): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
  • storage/IDBTransaction.h:
15:29 Changeset [78279] by mrobinson@webkit.org
  • 2 edits
    61 adds in trunk/LayoutTests

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Add results for HTTP tests missing GTK+ results.

  • platform/gtk/Skipped: Unskip HTTP tests that now have results.
15:26 Changeset [78278] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-10 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Fix compilation error on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=53766

Add a HAVE_STRNSTR in Platform.h and define it only on Darwin and FreeBSD.

  • wtf/Platform.h:
  • wtf/StringExtras.h: Use HAVE(STRNSTR) now.
15:23 Changeset [78277] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, tiny test fix from cira.

Excluding v8Locale from property-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=54250

  • fast/dom/script-tests/prototype-inheritance.js:
15:03 Changeset [78276] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Unskip some GTK+ HTTP tests that are passing locally. All the bots
should have the same libsoup version now.

  • platform/gtk/Skipped: Unskip some passing tests.
14:58 Changeset [78275] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [78274] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-10 Andreas Kling <kling@webkit.org>

Unreviewed Qt build fix.

waitFor() -> deprecatedWaitFor()

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
14:54 Changeset [78273] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] create pkg-config files for mingw
https://bugs.webkit.org/show_bug.cgi?id=54238

(mingw is mostly the same as unix)

This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.

Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
45fe2dddc3a0677b9ec9fce09f07cd4129e37afa

  • WebCore.pro:
14:52 Changeset [78272] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-10 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
https://bugs.webkit.org/show_bug.cgi?id=54246

  • rendering/style/RenderStyle.h:
14:45 Changeset [78271] by krit@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-10 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVG animation avoid unnecessary adjust for currentColor
https://bugs.webkit.org/show_bug.cgi?id=54243

At the moment we try to adjust every animation value for currentColor - independent of the animation type.
Since the value is a string and the target element may needs to get called by getElementById, this could
be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
as a string and parse it to Color afterwards again.
With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
parsed as a string again.

No change of functionality, no new tests.

  • svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
14:32 Changeset [78270] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Ensure WebView press delay timer is cancelled when grab is taken
https://bugs.webkit.org/show_bug.cgi?id=54242

As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-15529

Flickable steals the grab, but the timer was not stopped and the
keepGrab flag is set and the mouse grabbed. This means that the WebView
now has the grab and subsequent clicks on another element are ignored.

Original patch from Martin Jones <martin.jones@nokia.com>
reviewed (there) by Joona Petrell
52068f57f9c32098a90cc217730a530f85590f65

  • declarative/qdeclarativewebview.cpp: (GraphicsWebView::sceneEvent):
  • declarative/qdeclarativewebview_p.h:
14:17 Changeset [78269] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix assert in QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=54240

As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-14278

Instantiating a QDeclarativeWebView twice will trigger an assertion
when in debug mode.

Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
reviewed (there) by Aaron Kennedy
f532679ca11914b453e22342f2ae5e9f790ce47a

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
14:15 Changeset [78268] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Remove the use of deprecated qFindChildren()
https://bugs.webkit.org/show_bug.cgi?id=54232

This was applied on the Qt repository and affects QtWebKit there.
(13833beb641289c45faed337848d37280195aadc)

The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if that's possible today anyway).

Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.

The changes are result of the following commands:

git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(this,* */f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[
>]*>\)(&\([\(),]*\),* */
2.f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[
>]*>\)(\([\(),]*()\),* */
2->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[
>]*>\)(\([\(),]*\):\([\(),]*\),* */(
2:
3)->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*\),* */
2->f
1(/'" qFindChild

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):
14:03 Changeset [78267] by inferno@chromium.org
  • 3 edits in branches/chromium/648

Merge 77956

BUG=71717
Review URL: http://codereview.chromium.org/6486014

13:59 Changeset [78266] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Misc documentation fixes/updates
https://bugs.webkit.org/show_bug.cgi?id=54236

There are a few commits in the Qt repository (master and 4.7 branches)
with QtWebKit documentation fixes:

84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
Clarified documentation of loadFinished() signal

eebe205b306daaa3674d9746de11a73bef4bd0de
Doc: Fixed QML, unindented snippet

b0d64717d2c541976dc5524e4100c62f060e206f
doc: Changed a table into 3 tables to eliminate a \raw.

As these are all minor doc changes, I decided to group them
into one single patch.

  • Api/qwebpage.cpp:
  • declarative/qdeclarativewebview.cpp:
  • docs/qtwebkit.qdoc:
13:58 Changeset [78265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Rename build target from "embedded" to "qpa"
https://bugs.webkit.org/show_bug.cgi?id=54233

This flag is used by Qt's configure script to enable a QPA build
("QPA is a window system agnostic implementation of Qt" --
previously known as lighthouse).

On the Qt repository, this was changed by two commits:

13a0b4935900093607f2b3b7688e1452d22770fd
(from embedded to embedded_lite)

9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
(from embedded_lite to qpa)

  • WebCore.pro:
13:49 Changeset [78264] by kbr@google.com
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-02-10 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Incorporate algorithm for processing paths into GPU-renderable triangle meshes
https://bugs.webkit.org/show_bug.cgi?id=45521

Adding an implementation of Loop and Blinn's GPU accelerated path
rendering algorithm from GPU Gems 3. This implementation pays
particular attention to the efficiency of the curve subdivision
phase needed for correct rendering. It utilizes the OpenGL utility
library tessellator for triangulation of the interior of the
shape. The regions handled by Loop and Blinn's algorithm are
handled by the local triangulator previously incorporated.

No tests yet; pixel tests will eventually be used to verify this
algorithm and prevent regressions.

  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added. (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup): (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint): (WebCore::LoopBlinnPathProcessorImplementation::Segment::next): (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour): (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex): (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString): (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour): (WebCore::LoopBlinnPathProcessorImplementation::Contour::add): (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin): (WebCore::LoopBlinnPathProcessorImplementation::Contour::end): (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate): (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::process): (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY): (WebCore::LoopBlinnPathProcessor::determineSidesToFill): (WebCore::LoopBlinnPathProcessor::determineOrientation): (WebCore::SweepData::SweepEvent::SweepEvent): (WebCore::SweepData::SweepEvent::setup): (WebCore::SweepData::SweepEvent::x): (WebCore::SweepData::SweepEvent::entry): (WebCore::SweepData::SweepEvent::interval): (WebCore::SweepData::SweepEvent::operator<): (WebCore::SweepData::trianglesOverlap): (WebCore::LoopBlinnPathProcessor::subdivideCurves): (WebCore::LoopBlinnPathProcessor::conditionallySubdivide): (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow): (WebCore::TessellationState::vertexCallback): (WebCore::TessellationState::combineCallback): (WebCore::TessellationState::edgeFlagCallback): (WebCore::LoopBlinnPathProcessor::tessellateInterior):
  • platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.
13:18 Changeset [78263] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229

This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)

The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).

Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.

The changes are result of the following commands:

git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([
>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([
>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([
>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):

2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229

This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)

The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).

Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.

The changes are result of the following commands:

git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([
>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([
>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([
>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myInvokableWithQObjectListArg): (MyQObject::myInvokableWithListOfIntArg): (MyQObject::myInvokableWithQObjectStarArg): (MyQObject::myInvokableWithQBrushArg): (MyQObject::myInvokableWithBrushStyleArg): (MyQObject::myInvokableWithVoidStarArg): (MyQObject::myInvokableWithAmbiguousArg): (MyQObject::myInvokableWithDefaultArgs): (MyQObject::myInvokableWithPointArg): (MyQObject::myOverloadedSlot):
13:10 Changeset [78262] by zmo@google.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
13:04 Changeset [78261] by thakis@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-10 Nico Weber <thakis@chromium.org>

Reviewed by Darin Adler.

Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=54221

The method name conflicts with ContainerNode::getRect() so rename it to
computeRect(). Rename getPath() to computePath() for consistency as
well.

No intended functionality change, covered by existing tests.

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::elementRect):
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::computePath): (WebCore::HTMLAreaElement::computeRect):
  • html/HTMLAreaElement.h:
  • page/SpatialNavigation.cpp: (WebCore::virtualRectForAreaElementAndDirection):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing):
13:04 Changeset [78260] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Move code to dispatch an incoming message out into a new function
https://bugs.webkit.org/show_bug.cgi?id=54239

This also fixes a leak where we wouldn't free ArgumentDecoder objects
after a connection has been invalidated.


  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchMessage): (CoreIPC::Connection::dispatchMessages):
  • Platform/CoreIPC/Connection.h:
12:44 Changeset [78259] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-10 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854

We now respect the outline property and html.css defines the outline of the focus
ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses
it as the pen size. We should ignore the size and keep a default one. I also
reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia,
CG Win, Haiku, WinCE ports also ignore the width.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath): (WebCore::GraphicsContext::drawFocusRing):
12:36 Changeset [78258] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Skip newly added tests that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=54235

  • platform/mac-wk2/Skipped:
12:26 Changeset [78257] by mrobinson@webkit.org
  • 5 edits in trunk

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090

  • platform/gtk/Skipped: Unskip tests which should now be passing.

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090

Call didSendData as body data is uploaded to the server. This is necessary
for XHR upload events to function properly.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members. One to track the total amount of body data and one to track the total amount of body data sent so far.
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::wroteBodyDataCallback): Added. (WebCore::addFormElementsToSoupMessage): Split this out into a helper function. Will now now sum the total amount of body data. (WebCore::startHttp): Attach a wrote-body-data signal handler.
12:18 Changeset [78256] by robert@webkit.org
  • 8 edits in trunk

2011-02-10 Robert Hogan <robert@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039

  • platform/qt/Skipped: unskip editing/selection/context-menu-on-text.html

2011-02-10 Robert Hogan <robert@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (iterateContextMenu): (DumpRenderTreeSupportQt::contextMenu):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-10 Robert Hogan <robert@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
  • DumpRenderTree/qt/EventSenderQt.h:
12:12 Changeset [78255] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try again to fix the Qt build.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

11:58 Changeset [78254] by zmo@google.com
  • 10 edits in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
11:50 Changeset [78253] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-10 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=53925

  • platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::downloadToFile): (WebCore::ResourceRequest::setDownloadToFile):
  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
11:37 Changeset [78252] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Attempt to fix the Qt build.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):

11:28 UsingGitWithWebKit edited by ddkilzer@webkit.org
(diff)
11:27 UsingGitWithWebKit edited by ddkilzer@webkit.org
(diff)
11:26 Changeset [78251] by aroben@apple.com
  • 8 edits
    1 add in trunk

Handle a null FindIndicator correctly

We are passed a null FindIndicator when the find indicator becomes hidden.

Fixes <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
FindIndicator::contentImage when scrolling page

Reviewed by Steve Falkenburg.

Source/WebKit2:

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::isNull): Implemented.
(WebKit::SharedMemory::create): Bail out if the handle is null, just like Mac does.
Otherwise assert that ::MapViewOfFile succeeded. This doesn't fix the bug, but should help
catch other errors.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator): Null-check the FindIndicator before dereferencing it.
Also changed the function to store the FindIndicator in a RefPtr.

Tools:

Test showing and hiding the find indicator on Windows

  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
bitmap.
(TestWebKitAPI::initialize): Hook up our callbacks.
(TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::page):

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::page):
Made page a const member function.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
11:25 Changeset [78250] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Print locations of assertions and logs in a way that Visual Studio understands

With this change, double-clicking one of these locations in Visual Studio's Output Window
will focus that line of code in the editor.

Fixes <http://webkit.org/b/54208> Double-clicking locations of assertions/logs in Visual
Studio's Output Window does nothing

Reviewed by Alexey Proskuryakov.

  • wtf/Assertions.cpp:

(printCallSite): Use OS(WINDOWS) instead of the meaningless OS(WIN). When we aren't using
the debug CRT (and thus can't call _CrtDbgReport), print the file and line number using the
same format that cl.exe uses when it prints compiler errors.

11:16 Changeset [78249] by krit@webkit.org
  • 122 edits in trunk/Source/WebCore

2011-02-10 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimateElement needs information about the animated attribute type
https://bugs.webkit.org/show_bug.cgi?id=53442

For animations, we need to know the SVG property type for a XML attribute. A global static mapping between
attribute name and a type is not possible, since one attribute name can be bound to different property types:
x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports
the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between
the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static
HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function
that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons.

No change of functionality, so no new test cases.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::attributeToPropertyTypeMap): (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::attributeToPropertyTypeMap): (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::attributeToPropertyTypeMap): (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap): (WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::attributeToPropertyTypeMap): (WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::attributeToPropertyTypeMap): (WebCore::SVGElement::animatedPropertyTypeForAttribute):
  • svg/SVGElement.h: (WebCore::SVGElement::fillAttributeToPropertyTypeMap):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::attributeToPropertyTypeMap): (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::attributeToPropertyTypeMap): (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap): (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::attributeToPropertyTypeMap): (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap): (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::attributeToPropertyTypeMap): (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap): (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::attributeToPropertyTypeMap): (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::attributeToPropertyTypeMap): (WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap): (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap): (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::attributeToPropertyTypeMap): (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap): (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::attributeToPropertyTypeMap): (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::attributeToPropertyTypeMap): (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
  • svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap): (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGlyphElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attributeToPropertyTypeMap): (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::attributeToPropertyTypeMap): (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap): (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::attributeToPropertyTypeMap): (WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::attributeToPropertyTypeMap): (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeToPropertyTypeMap): (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMaskElement.h:
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::attributeToPropertyTypeMap): (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::attributeToPropertyTypeMap): (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::attributeToPropertyTypeMap): (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap): (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::attributeToPropertyTypeMap): (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::attributeToPropertyTypeMap): (WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap):
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::attributeToPropertyTypeMap): (WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap):
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::attributeToPropertyTypeMap): (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty): (WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::attributeToPropertyTypeMap): (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::attributeToPropertyTypeMap): (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::attributeToPropertyTypeMap): (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::attributeToPropertyTypeMap): (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::attributeToPropertyTypeMap): (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::attributeToPropertyTypeMap): (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::attributeToPropertyTypeMap): (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::attributeToPropertyTypeMap): (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::attributeToPropertyTypeMap): (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
  • svg/SVGViewElement.h:
11:05 Changeset [78248] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-10 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

Fix a Warning after removing FileSystem support for the inspector.

  • WebCore.pro:
10:55 Changeset [78247] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add 'deprecated' to the deprecated CoreIPC functions
https://bugs.webkit.org/show_bug.cgi?id=54223

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): (CoreIPC::Connection::deprecatedSendSync): (CoreIPC::Connection::deprecatedSend): (CoreIPC::Connection::deprecatedWaitFor):
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::open):
  • PluginProcess/PluginProcess.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection):
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::postMessage): (WebKit::InjectedBundle::postSynchronousMessage):
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::setSize):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
10:50 Changeset [78246] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-02-10 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Window resizer does not have a border when there are scrollbars in WebKit2 windows
<rdar://problem/8488476>
https://bugs.webkit.org/show_bug.cgi?id=54222

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
  • UIProcess/API/mac/WKView.mm: (-[WKView _updateGrowBoxForWindowFrameChange]): (-[WKView _didChangeScrollbarsForMainFrame]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::didChangeScrollbarsForMainFrame):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didChangeScrollbarsForMainFrame):
  • UIProcess/win/WebView.h:
10:44 Changeset [78245] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-10 Ivan Krstić <ike@apple.com>

Reviewed by Adam Roben.

Rename remaining instances of _HOME sandbox parameter.
<rdar://problem/8983428>

  • WebProcess/com.apple.WebProcess.sb:
10:42 Changeset [78244] by mario@webkit.org
  • 3 edits
    2 adds in trunk/Tools

2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Log signals from AtkDocument interface also in AccessibilityController
https://bugs.webkit.org/show_bug.cgi?id=54198

Trace AtkDocument's signals emission through AccessibilityController.

Also, taken the code related to adding and removing global
listeners for ATK signals out to a separate file, for the sake of
clarity and to ease future additions.

  • DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added (printAccessibilityEvent): Print information about an event. (axObjectEventListener): Global listener for AtkObject's signals. (axDocumentEventListener): Global listener for AtkDocument's signals. (connectAccessibilityCallbacks): Connect all global listeners. (disconnectAccessibilityCallbacks): Disconnect all global listeners.
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::setLogAccessibilityEvents): Call to connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
  • GNUmakefile.am: Added new files.
10:40 Changeset [78243] by zmo@google.com
  • 33 edits
    16 adds in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
  • platform/mac-leopard/svg/batik/filters/feTile-expected.png:
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png:
10:38 Changeset [78242] by tony@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/platform/ScrollView.cpp

Merge 77549 - Scroll thumb jumps to top when resizing horizontally.

Reviewed by Beth Dakin.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.

TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/6490004

10:25 Changeset [78241] by cfleizach@apple.com
  • 13 edits in trunk/Source

AX: AX needs to stop using WebCoreViewFactory
https://bugs.webkit.org/show_bug.cgi?id=54153

Reviewed by Anders Carlsson.

../WebCore:

WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
to get off of it and use WebCoreSystemInterface, like other clients.

  • WebCore.exp.in:
  • accessibility/AXObjectCache.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/mac/AccessibilityObjectWrapper.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetElement):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::accessibilityConvertScreenRect):
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

../WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:15 Changeset [78240] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source

2011-02-10 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201

Add files for the fullscreen video playback handling. It also fix
a missing header.

  • WebCore.pro:

2011-02-10 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201

Add a default fullscreen handler when there is no plaftform plugin
installed. This handler creates a fullscreen QVideoWidget and plays
the video. Space pause/resume the video playback and esc quit the
fullscreen mode.

  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback): (WebCore::DefaultFullScreenVideoHandler::enterFullScreen): (WebCore::DefaultFullScreenVideoHandler::exitFullScreen): (WebCore::FullScreenVideoQt::FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/FullScreenVideoWidget.cpp: Added. (WebCore::FullScreenVideoWidget::FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::~FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::show): (WebCore::FullScreenVideoWidget::closeEvent): (WebCore::FullScreenVideoWidget::event): (WebCore::FullScreenVideoWidget::keyPressEvent): (WebCore::FullScreenVideoWidget::hideCursor): (WebCore::FullScreenVideoWidget::showCursor):
  • WebCoreSupport/FullScreenVideoWidget.h: Added.
10:11 Changeset [78239] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations trying to read crypto preferences.
<rdar://problem/8981151>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
10:07 Changeset [78238] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Martin Robinson <mrobinson@igalia.com>

Clump the tests failing only on the GTK+ 32-bit bot together with the
other tests that have this kind of failure.

  • platform/gtk/Skipped: Clean up the skipped list slightly.
09:49 Changeset [78237] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLVM Compiler build fix.

  • runtime/MarkedBlock.cpp:

(JSC::MarkedBlock::create):

09:47 Changeset [78236] by inferno@chromium.org
  • 5 edits in branches/chromium/597/WebCore

Merge r76205, crbug 54262

09:47 Changeset [78235] by zmo@google.com
  • 67 edits
    34 adds
    15 deletes in trunk/LayoutTests

2011-02-10 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
09:43 Changeset [78234] by pfeldman@chromium.org
  • 17 edits
    3 deletes in trunk/Source/WebCore

2011-02-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove FileSystem support from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=50695

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorFileSystemAgent.cpp: Removed.
  • inspector/InspectorFileSystemAgent.h: Removed.
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  • inspector/front-end/FileSystemView.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
09:29 Changeset [78233] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/648

Merge 77891

BUG=72217
Review URL: http://codereview.chromium.org/6488001

09:13 Changeset [78232] by philn@webkit.org
  • 24 edits in trunk/Source/WebCore

2011-02-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78219.
http://trac.webkit.org/changeset/78219
https://bugs.webkit.org/show_bug.cgi?id=54215

breaks editing/style/iframe-onload-crash.html on GTK 64-bit
Debug (Requested by philn-tp on #webkit).

  • dom/Document.h:
  • dom/DocumentFragment.h:
  • dom/Element.h:
  • dom/Node.h:
  • dom/Text.h:
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): (WebCore::canHaveChildrenForEditing):
  • editing/htmlediting.h:
  • html/HTMLBRElement.h:
  • html/HTMLButtonElement.h:
  • html/HTMLDataGridElement.h:
  • html/HTMLFormControlElement.h:
  • html/HTMLFrameElementBase.h:
  • html/HTMLHRElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLOutputElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLProgressElement.h:
  • wml/WMLBRElement.h:
  • wml/WMLDoElement.h:
  • wml/WMLImageElement.h:
  • wml/WMLInputElement.h:
  • wml/WMLSelectElement.h:
09:07 Changeset [78231] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77049

BUG=70885
Review URL: http://codereview.chromium.org/6482031

09:04 Changeset [78230] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77329

BUG=71167
Review URL: http://codereview.chromium.org/6478032

08:58 Changeset [78229] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp

Merge 78143

BUG=72387
Review URL: http://codereview.chromium.org/6478030

08:46 Changeset [78228] by mrobinson@webkit.org
  • 5 edits
    1 delete in trunk

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157

Unskip passing tests and remove some bogus expected results.

  • platform/gtk/Skipped: Unskip some tests which are now passing.
  • platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157

Disable the default error page during DRT runs. This prevents unexpected loads
from interfering with tests that have planned failed loads.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadError): Added, disable default handler. (createWebView): Connect the new load-error handler.
08:21 Changeset [78227] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

French translation for Webkit/GTK
https://bugs.webkit.org/show_bug.cgi?id=26108

  • fr.po: Added.
08:16 Changeset [78226] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-10 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt][V8] Fix the build.

No new tests needed.

  • bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header.
  • loader/cache/CachedScript.h: do not use extra qualification for base class enum.
08:03 Changeset [78225] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input
https://bugs.webkit.org/show_bug.cgi?id=54205

  • inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
  • inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty):
  • inspector/front-end/StylesSidebarPane.js: ():
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete):
08:01 Changeset [78224] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed skip failing fast/text/international/hindi-whitespace.html test on GTK
https://bugs.webkit.org/show_bug.cgi?id=54212

  • platform/gtk/Skipped:
07:50 Changeset [78223] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed skip failing fast/text/atsui* tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=54210

  • platform/gtk/Skipped:
07:47 Changeset [78222] by reni@webkit.org
  • 4 edits
    40 adds in trunk

2011-02-10 Renata Hodovan <reni@webkit.org>

Reviewed by Dirk Schulze.

SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186

Adding layout tests for feSpecularLighting dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularConstant-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularExponent-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-surfaceScale-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularConstant-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularExponent-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-surfaceScale-prop.js: Added. (executeTest):

2011-02-10 Renata Hodovan <reni@webkit.org>

Reviewed by Dirk Schulze.

SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186

The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html

svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html

  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
  • svg/SVGFESpecularLightingElement.h:
06:59 Changeset [78221] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed skipping websocket tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=53683

  • platform/gtk/Skipped:
06:54 Changeset [78220] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-10 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Error messages are not displayed for the last line in a script
https://bugs.webkit.org/show_bug.cgi?id=54204

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._createConditionElement):
06:47 Changeset [78219] by rniwa@webkit.org
  • 24 edits in trunk/Source/WebCore

2011-02-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564

Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.

As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:

HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input,

meter, object, output, progress, and select.

WML: br, do, img, input, and select.

No new tests are added since this change cannot be tested directly.

  • dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
  • dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
  • dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
  • dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
  • dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
  • editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
  • editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
  • html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto.
  • html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
  • html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
  • html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
  • html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
  • html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
  • html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
  • wml/WMLBRElement.h: (WebCore::WMLBRElement::canContainRangeEndPoint): Ditto.
  • wml/WMLDoElement.h: (WebCore::WMLDoElement::canContainRangeEndPoint): Ditto.
  • wml/WMLImageElement.h: (WebCore::WMLImageElement::canContainRangeEndPoint): Ditto.
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::canContainRangeEndPoint): Ditto.
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto.
06:32 Changeset [78218] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Update GTK results after r78204

  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
06:20 Changeset [78217] by zoltan@webkit.org
  • 5 edits
    4 copies
    2 adds in trunk/Tools

[Qt] Add UrlLoader and command line argument handling to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54192

Reviewed by Andreas Kling.

Copy and modify files from QtTestBrowser's implementation.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):

  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h

(WindowOptions::WindowOptions):
(MiniBrowserApplication::urls):
(MiniBrowserApplication::isRobotized):
(MiniBrowserApplication::robotTimeout):
(MiniBrowserApplication::robotExtraTime):

  • MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp

(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
(UrlLoader::loadUrlList):
(UrlLoader::getUrl):

  • MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h
  • MiniBrowser/qt/main.cpp:

(main):

  • MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp

(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
(urlFromUserInput):

  • MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
06:18 Changeset [78216] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
06:14 Changeset [78215] by zoltan@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=54200

Reviewed by Andreas Kling.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
06:05 Changeset [78214] by aroben@apple.com
  • 4 edits in trunk/LayoutTests

Update Windows results after r78204

  • platform/win/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/win/fast/text/international/text-combine-image-test-expected.png:
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:
06:04 Changeset [78213] by aroben@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Update Windows results after r78182

Nikolas Zimmermann says he thinks we're not matching the Mac results anymore due to rounding
differences.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
06:03 Changeset [78212] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: define interface per domain in Inspector.idl.
https://bugs.webkit.org/show_bug.cgi?id=54135

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
05:39 Changeset [78211] by pvarga@webkit.org
  • 24 edits
    2 deletes in trunk

2011-02-10 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188

  • Source/cmake/WebKitFS.cmake:

2011-02-10 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188

  • Android.mk:
  • Android.v8.wtf.mk:
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.order:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • pcre/AUTHORS: Removed.
  • pcre/COPYING: Removed.
  • pcre/dftables: Removed.
  • pcre/pcre.h: Removed.
  • pcre/pcre.pri: Removed.
  • pcre/pcre_compile.cpp: Removed.
  • pcre/pcre_exec.cpp: Removed.
  • pcre/pcre_internal.h: Removed.
  • pcre/pcre_tables.cpp: Removed.
  • pcre/pcre_ucp_searchfuncs.cpp: Removed.
  • pcre/pcre_xclass.cpp: Removed.
  • pcre/ucpinternal.h: Removed.
  • pcre/ucptable.cpp: Removed.
  • wscript:

2011-02-10 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188

  • ForwardingHeaders/pcre/pcre.h: Removed.

2011-02-10 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188

  • WebKit2.pro:

2011-02-10 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188

  • wx/build/settings.py:
05:37 Changeset [78210] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-10 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
https://bugs.webkit.org/show_bug.cgi?id=54098

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel.prototype._totalHeight): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.get height):
  • inspector/front-end/textViewer.css: (.webkit-line-content):
05:24 Changeset [78209] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing fast/text/midword-break-after-breakable-char.html on
GTK

  • platform/gtk/Skipped:
05:15 Changeset [78208] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-10 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Add randomValuesFromOS for OS(WINDOWS)
https://bugs.webkit.org/show_bug.cgi?id=54155

Use CryptGenRandom for generating cryptographically secure random numbers.
This will work on WinCE and MinGW too.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
05:06 Changeset [78207] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-10 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] add WebIDBObjectStore::clear method

https://bugs.webkit.org/show_bug.cgi?id=54149

  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::deleteFunction): (WebKit::WebIDBObjectStore::clear):
04:59 Changeset [78206] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing fast/text/capitalize-boundaries.html on
GTK

  • platform/gtk/Skipped:
04:52 Changeset [78205] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-10 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style should be able to figure out function modifiers and return type.
https://bugs.webkit.org/show_bug.cgi?id=54124

  • Scripts/webkitpy/style/checkers/cpp.py: (_rfind_in_lines): A way to search backwards in lines. (_FunctionState.modifiers_and_return_type):
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
04:48 Changeset [78204] by commit-queue@webkit.org
  • 7 edits in trunk

2011-02-10 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169

Added a test for this bug to existing text-combine test.

  • fast/text/international/text-combine-image-test.html:
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt:

2011-02-10 takano takumi <takano@apple.com>

Reviewed by Dan Bernstein.

A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169

  • rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
  • Fixed by resetting font's orientation to horizontal when we decided to make combined text. Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.
04:46 Changeset [78203] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-10 Jarred Nicholls <jarred@sencha.com>

Reviewed by Adam Barth.

REGRESSION(r78149): Return value of read() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=54167

stdio read should have its return value handled. Build error in gcc 4.4.5.

  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
04:42 Changeset [78202] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-10 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=50306
<rdar://problem/8976152> REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload()
uses an initialized result value (breaks form submission with clang-built WebKit)

No new test, because I can't reproduce the observable effect with my gcc build.

  • platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an empty path check - an empty path was causing an exception in Foundation.
04:41 Changeset [78201] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Turn on the new drawing area on Windows

Fixes <http://webkit.org/b/53805> <rdar://problem/8960666> WebKit2 on Windows should use
DrawingAreaProxyImpl

Reviewed by Darin Adler.

  • UIProcess/win/WebView.cpp:

(WebKit::useNewDrawingArea): Return true!

04:40 Changeset [78200] by aroben@apple.com
  • 4 edits
    1 add in trunk

Hook up WM_PRINT to the new drawing area

Fixes <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)

Reviewed by Darin Adler.

Source/WebKit2:

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::paint): Added. Code came from onPaintEvent.

(WebKit::WebView::onPaintEvent):
(WebKit::WebView::onPrintClientEvent):
Changed to call paint.

  • UIProcess/win/WebView.h: Added paint. Also separated message handler functions into their

own paragraph.

Tools:

Test that WM_PRINT doesn't trigger an assertion

  • TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.

(TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.

04:40 Changeset [78199] by aroben@apple.com
  • 4 edits in trunk

Notice when the backing store goes away after DidSetSize

Fixes <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden

Reviewed by Darin Adler.

Source/WebKit2:

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paint): Null-check m_backingStore after waiting for
DidSetSize, as m_backingStore can go away when we receive that message. This is the bug fix.
Also moved the accelerated compositing check inside the block where we wait for DidSetSize.
If we didn't wait for DidSetSize, we already know that we're not in accelerated compositing
mode (and asserted so earlier in this function).

Tools:

Test that having a WKView paint after being resized while hidden doesn't cause a crash

  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:

(TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.

04:39 Changeset [78198] by aroben@apple.com
  • 5 edits
    1 add in trunk

Decode a null SharedMemory::Handle correctly on Windows

Fixes <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
performs badly if is resized while hidden (assertion fails in
BackingStore::incorporateUpdate in Debug builds)

Reviewed by Darin Adler.

Source/WebKit2:

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::getDuplicatedHandle): Added. Code came from decode. The only changes were to
null-check sourceHandle (this is the bug fix) and to assert when ::DuplicateHandle fails
(which would have caught the bug earlier).
(WebKit::SharedMemory::Handle::decode): Changed to use getDuplicatedHandle.

Tools:

Add a test that resizes a WKView while it's hidden

  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
(TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
that all pending messages have been handled by the UI and web process.
(TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
(TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
(TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
chance to display, then flush all pending messages.
(TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
the backing store to update. This triggers the assertion from bug 54141.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::resizeTo): Implemented.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
04:38 Changeset [78197] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't invalidate outside of the WebPage's bounds

Fixes <http://webkit.org/b/54123> <rdar://problem/8978383> Assertion failure in
BackingStore::BackingStore if a new WebPage becomes active before receiving a size

Reviewed by Darin Adler.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setNeedsDisplay): Intersect the dirty rect with our bounds before
doing anything else.
(WebKit::DrawingAreaImpl::display): Added an assertion to help catch the bad case a little
earlier.

04:36 Changeset [78196] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Network & Resource panels make multiple requests for images with no content
https://bugs.webkit.org/show_bug.cgi?id=54085

  • Added success parameter to resourceContent
  • NetworkManager.requestContent() now returns empty for zero-length resources, null for errors
  • inspector/Inspector.idl:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._contentURL):
04:26 Changeset [78195] by paroga@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-10 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Rename randomValuesFromOS to cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=54156

randomValuesFromOS generates random numbers of cryptographic quality.
Make this clear by adding "cryptographically" to the function name.

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::stir):
  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
  • wtf/OSRandomSource.h:
04:23 Changeset [78194] by reni@webkit.org
  • 9 edits
    3 adds in trunk/Source/WebCore

2011-02-10 Renata Hodovan <reni@webkit.org>

Reviewed by Dirk Schulze.

Move the light source implementations into their own files.
https://bugs.webkit.org/show_bug.cgi?id=53996

Splitting LightSource.cpp into 3 files.

No new tests are added since this is a refactoring.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/DistantLightSource.cpp: Added. (WebCore::DistantLightSource::initPaintingData): (WebCore::DistantLightSource::updatePaintingData): (WebCore::DistantLightSource::setAzimuth): (WebCore::DistantLightSource::setElevation): (WebCore::DistantLightSource::externalRepresentation):
  • platform/graphics/filters/LightSource.cpp:
  • platform/graphics/filters/PointLightSource.cpp: Added. (WebCore::PointLightSource::initPaintingData): (WebCore::PointLightSource::updatePaintingData): (WebCore::PointLightSource::setX): (WebCore::PointLightSource::setY): (WebCore::PointLightSource::setZ): (WebCore::operator<<): (WebCore::PointLightSource::externalRepresentation):
  • platform/graphics/filters/SpotLightSource.cpp: Added. (WebCore::SpotLightSource::initPaintingData): (WebCore::SpotLightSource::updatePaintingData): (WebCore::SpotLightSource::setX): (WebCore::SpotLightSource::setY): (WebCore::SpotLightSource::setZ): (WebCore::SpotLightSource::setPointsAtX): (WebCore::SpotLightSource::setPointsAtY): (WebCore::SpotLightSource::setPointsAtZ): (WebCore::SpotLightSource::setSpecularExponent): (WebCore::SpotLightSource::setLimitingConeAngle): (WebCore::operator<<): (WebCore::SpotLightSource::externalRepresentation):
04:07 Changeset [78193] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-02-10 Avi Drissman <avi@google.com>

Reviewed by Darin Fisher.

<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969

Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::updateFromElement):
  • platform/chromium/PopupMenuChromium.h:

2011-02-10 Avi Drissman <avi@google.com>

Reviewed by Darin Fisher.

<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969

Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.

  • public/WebMenuItemInfo.h:
  • public/WebPopupMenuInfo.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo):
03:58 Changeset [78192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-10 kasthuri <kasthuri.n-s@nokia.com>

Reviewed by Antonio Gomes.

[Qt] QWebFrame::setHtml doesn't emit loadFinished signal
https://bugs.webkit.org/show_bug.cgi?id=38634

QWebView->page()->mainFrame()->setHtml(html) is always emitting
the loadFinished() signal for all types of html files.
But the proposed test content was trying to catch the signal after
calling setHtml() api and becuase of this the emitted signal for a
simple html page is never caught as its emitted before even the connect
call was successful.

updated the tst_QWebFrame::setHtml() in tst_qwebframe.cpp to check for
signal using the QSignalSpy.

  • tests/qwebframe/tst_qwebframe.cpp:
03:54 Changeset [78191] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing fast/replaced/border-radius-clip.html on GTK

  • platform/gtk/Skipped:
03:39 Changeset [78190] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184

Regenerate result with a 64bit SL machine.. a pity that we have diffs there.

  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
03:11 Changeset [78189] by zimmermann@webkit.org
  • 29 edits in trunk/LayoutTests

2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184

Update mac-leopard/qt baselines after r78182.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
03:06 Changeset [78188] by philn@webkit.org
  • 15 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated svg GTK baselines after r78182.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
03:02 Changeset [78187] by hans@chromium.org
  • 6 edits in trunk

2011-02-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102

Update test to reflect the new semantics.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:

2011-02-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102

Update the semantics of put: For object stores with auto increment,
it should be allowed to provide an explicit key, or an in-line key,
overriding the key generator mechanism.

This reflects the spec changes suggested here:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11976

Extracting key-selection logic into its own function
to make it a bit easier on the eyes.

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::resetAutoIncrementKeyCache):
02:51 Changeset [78186] by philn@webkit.org
  • 2 edits in trunk/Tools

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix after roll out of r78157...

  • GNUmakefile.am:
02:49 Changeset [78185] by eric@webkit.org
  • 7 edits
    3 deletes in trunk

2011-02-10 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150

Fails on a bunch of bots

  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Removed.
  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Removed.

2011-02-10 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150

Fails on a bunch of bots

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): (WebKit::PluginView::evaluate):

2011-02-10 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150

Fails on a bunch of bots

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
02:44 Changeset [78184] by mario@webkit.org
  • 2 edits in trunk/Tools

2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
https://bugs.webkit.org/show_bug.cgi?id=54185

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
02:43 Changeset [78183] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=54103
Implement fast path for matching simple selectors

Reviewed by Darin Adler.

Implement a fast path for single and descendant selectors consisting
of id, class and tag selectors only.

Selectors like this are marked on style selector initialization. When
encountered during style matching they are resolved using a fast path.

Since selectors like this are very common this speeds up style matching
quite a bit (up to 50% on some sites according to Shark).

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasTopSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::selectorTagMatches):
(WebCore::isFastCheckableSelector):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::RuleData):

  • css/CSSStyleSelector.h:
02:25 Changeset [78182] by zimmermann@webkit.org
  • 90 edits
    1 delete in trunk/LayoutTests

2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Maciej Stachowiak.

LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184

Fix wrong xlink:hrefs in dozens of SVG testcases. SVGFreeSans.svg is now used in more places.
Remove unnecessary xml-stylesheet declarations, and unneeded text css attributes in some places.

Updated pixel test results for the affected testcases.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.checksum:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/text/text-tref-01-b-expected.checksum:
  • platform/mac/svg/text/text-tref-01-b-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg:
  • svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:
  • svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg:
  • svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg:
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
  • svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-01-b.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-02-f.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-03-b.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-05-b.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:
  • svg/W3C-SVG-1.1-SE/types-dom-07-f.svg:
  • svg/W3C-SVG-1.1/filters-light-04-f.svg:
  • svg/W3C-SVG-1.1/filters-turb-02-f.svg:
  • svg/W3C-SVG-1.1/resources/interact-order-02-b-targ.svg:
  • svg/W3C-SVG-1.1/resources/interact-order-03-b-targ.svg:
  • svg/W3C-SVG-1.1/resources/linkingToc-t.svg:
  • svg/batik/filters/feTile.svg:
  • svg/css/circle-in-mask-with-shadow.svg:
  • svg/css/mask-with-shadow.svg:
  • svg/custom/image-clipped-hit.svg:
  • svg/foreignObject/text-tref-02-b.svg:
  • svg/hixie/cascade/002.css: Removed.
  • svg/text/text-tref-01-b.svg:
  • svg/transforms/animated-path-inside-transformed-html.xhtml:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/page/zoom-zoom-coords.xhtml:
02:04 Changeset [78181] by philn@webkit.org
  • 4 edits in trunk

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed GTK build fix.

Adding
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
in the build, fixing the
plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
test.

  • GNUmakefile.am:

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, typo fix.

  • platform/gtk/Skipped:
01:29 Changeset [78180] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test.

  • platform/gtk/Skipped: Skip fast/events/focusingUnloadedFrame.html
01:03 Changeset [78179] by mario@webkit.org
  • 6 edits in trunk/Tools

2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Add support in DRT to log "accessibility events"
https://bugs.webkit.org/show_bug.cgi?id=54116

Added a way to log accessibility related events, in a
platform-dependant way.

Add new function to AccessibilityController.

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityController.cpp: (logAccessibilityEventsCallback): New callback. (AccessibilityController::getJSClass): Added new function. (AccessibilityController::resetToConsistentState): Initialized calling setLogAccessibilityEvents(false).

Provided implementation for the GTK port.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (accessibility_event_listener): Common listener for logging information about all the signals emitted by any AtkObject. (AccessibilityController::setLogAccessibilityEvents): Add or remove listeners for signals, as specified by the parameter.

Provide dummy implementations for mac and win ports.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::setLogAccessibilityEvents):
  • DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::setLogAccessibilityEvents):
01:00 Changeset [78178] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-10 Shinichiro Hamaji <hamaji@chromium.org>

Chromium expectations update.

fast/box-shadow/shadow-buffer-partial.html is failing.

  • platform/chromium/test_expectations.txt:
00:09 Changeset [78177] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Skip newly added test that depends on unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54172

  • platform/mac-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.