Timeline
02/15/11:
- 23:31 Changeset [78687] by
-
Dan Bernstein came up with this fix while we debugged it. I just typed.
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=54532
On platforms without platformWidgets, going Back to a scrolled page
draws at the top-left before drawing at the restored scroll position
<rdar://problem/8998838>
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Don't send the didFirstLayout and didFirstVisuallyNonEmptyLayout callbacks
for nested layouts. Doing so was causing ScrollView::setScrollPosition()
to short-circuit.
- 23:27 Changeset [78686] by
-
Unreviewed.
[Qt][V8] Buildfix. Add missing USE(JSC) guard.
Source/WebCore:
- plugins/qt/PluginViewQt.cpp:
Source/WebKit/qt:
- Api/qwebelement.cpp:
- 22:48 Changeset [78685] by
-
2011-02-15 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Kent Tamura.
Fixed a small bug about --no-timeout option.
https://bugs.webkit.org/show_bug.cgi?id=52873
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
- 22:41 Changeset [78684] by
-
Versioning.
- 22:39 Changeset [78683] by
-
New tag.
- 21:33 Changeset [78682] by
-
2011-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Chromium-Mac-Leopard baseline files for r78677.
- platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
- platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
- 21:08 Changeset [78681] by
-
2011-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Chromium baseline files for a new test of r78677.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
- platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
- platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
- platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
- platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
- 21:07 Changeset [78680] by
-
2011-02-15 Ami Fischman <fischman@chromium.org>
Reviewed by David Levin.
Remove the artificial -32px shift for media controls in mediaDocuments
so that they overlap the canvas as they do in non-mediaDocuments.
This also fixes test_shell failing to update the media slider (see
linked crbug below).
https://bugs.webkit.org/show_bug.cgi?id=27798
http://crbug.com/72623
Test: media/video-controls-in-media-document.html
Added a render test that asserts that the controls show up in the
expected spot (0,208) instead of below the canvas (0,240).
- css/mediaControlsChromium.css:
- 21:05 Changeset [78679] by
-
2011-02-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Extract a function to process ancestor and their sibling nodes from processContents
https://bugs.webkit.org/show_bug.cgi?id=54425
Extracted processAncestorsAndTheirSiblings.
- dom/Range.cpp: (WebCore::Range::processContents): Calls processContents. (WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents.
- dom/Range.h:
- 20:51 Changeset [78678] by
-
2011-02-15 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
https://bugs.webkit.org/show_bug.cgi?id=54489
No tests needed, exposes no new functionality
- src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
- src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
- src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
- src/WebURLResponsePrivate.h:
- 20:14 Changeset [78677] by
-
[Chromium] Rendering error of spin buttons on layers
https://bugs.webkit.org/show_bug.cgi?id=54427
Reviewed by Darin Fisher.
Source/WebCore:
Test: fast/forms/input-appearance-spinbutton-layer.html
- rendering/RenderThemeChromiumWin.cpp: Add checks for multiple ThemePainter instances.
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
Avoid to create multiple ThemePainter instances.
LayoutTests:
- fast/forms/input-appearance-spinbutton-layer.html: Added.
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 20:11 Changeset [78676] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebPluginSiteDataManager should work with plug-in process
https://bugs.webkit.org/show_bug.cgi?id=54523
<rdar://problem/8689312>
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::removeWebProcessConnection): Call startShutdownTimerIfNecessary().
(WebKit::PluginProcess::getSitesWithData):
Ask the plug-in module for the sites with data and send them back
in a PluginProcessProxy::DidGetSitesWithData message.
(WebKit::PluginProcess::clearSiteData):
Clear site data and send back a DidClearSiteData message.
(WebKit::PluginProcess::startShutdownTimerIfNecessary):
Factor code out from removeWebProcessConnection.
- PluginProcess/PluginProcess.messages.in: Add new messages.
- UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): New function for getting all plug-ins.
- UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): Call getOrCreatePluginProcess.
(WebKit::PluginProcessManager::getSitesWithData):
Get a plug-in process proxy and call getSitesWithData.
(WebKit::PluginProcessManager::clearSiteData):
Get a plug-in process proxy and call clearSiteData.
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
Factor code to create a plug-in process out into a separate function.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getSitesWithData): (WebKit::PluginProcessProxy::clearSiteData): Update the pending reply struct. If the process is still launching, enqueue the request. Otherwise, just send the message.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Make sure that pending replies are sent out.
(WebKit::PluginProcessProxy::didFinishLaunching):
Send our pending requests.
(WebKit::PluginProcessProxy::didGetSitesWithData):
(WebKit::PluginProcessProxy::didClearSiteData):
Call down to the plug-in site data manager.
- UIProcess/Plugins/PluginProcessProxy.messages.in: Add DidGetSitesWithData and DidClearSiteData messages.
- UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): Initialize the state.
(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin):
If the plug-in queue is empty, call didGetSitesWithDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.
(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin):
Update the sites set and get sites for the next plug-in.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState):
Initialize the state.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin):
If the plug-in queue is empty, call didClearSiteDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin):
Update the sites set and ask the next plug-in to clear site data.
(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
Assert that all maps are empty.
(WebKit::WebPluginSiteDataManager::invalidate):
Delete and clear the pending state maps.
(WebKit::WebPluginSiteDataManager::getSitesWithData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new GetSitesWithDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a GetSitesWithPluginData message.
(WebKit::WebPluginSiteDataManager::clearSiteData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new ClearSiteDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a ClearPluginSiteData message.
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin):
Call down to the GetSitesWithDataState object.
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.
(WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin):
Call down to the GetSitesWithDataState object.
(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.
- UIProcess/WebContext.cpp: (WebKit::WebContext::processDidClose): Don't invalidate the plug-in site data manager if we're using a plug-in process.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Call shutdownIfPossible().
- 19:41 Changeset [78675] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Skip all Hixie SVG performance tests on GTK+. They seem
to be timing out on the GTK+ debug bots.
- platform/gtk/Skipped: Skip Hixie SVG performance tests.
- 19:16 Changeset [78674] by
-
2011-02-15 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
Reviewed by Darin Adler.
- WebView/WebDynamicScrollBarsView.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed declaration.
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved implementation into correct category.
- WebView/WebDynamicScrollBarsViewInternal.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added declaration.
- WebView/WebHTMLView.mm: Included WebDynamicScrollBarsViewInternal.h instead of WebDynamicScrollBarsView.h.
- 19:08 Changeset [78673] by
-
Copy over new WebKit 2 header.
Rubber-stamped by Alice Liu.
- win/WebKit2Generated.make:
- 19:03 Changeset [78672] by
-
Skipped crashing test on Windows.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=54519
- platform/win/Skipped: Skip fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
- 18:12 Changeset [78671] by
-
2011-02-15 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix race condition in JavaScriptAudioNode
https://bugs.webkit.org/show_bug.cgi?id=54518
No new tests since audio API is not yet implemented.
- webaudio/JavaScriptAudioNode.cpp: (WebCore::JavaScriptAudioNode::process):
- 18:06 Changeset [78670] by
-
Merge r78578.
- 18:06 Changeset [78669] by
-
Merge r78609.
- 18:06 Changeset [78668] by
-
Merge r78600.
- 18:02 Changeset [78667] by
-
Merge 77724 - 2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.
- fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
- fast/images/cmyk-jpeg-with-color-profile.html: Added.
- fast/images/resources/cmyk-jpeg.jpg: Added.
- fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.
Test: fast/images/cmyk-jpeg-with-color-profile.html
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
- 18:01 Changeset [78666] by
-
Merge r78513.
- 17:57 Changeset [78665] by
-
Merge r78523.
- 17:56 Changeset [78664] by
-
Unreviewed, Chromium test expectations update.
Remove line with dupe expectations.
- platform/chromium/test_expectations.txt:
- 17:55 Changeset [78663] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Implement WKPluginSiteDataManagerClearSiteData
https://bugs.webkit.org/show_bug.cgi?id=54512
<rdar://problem/8689312>
- UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetTypeID): Implement this.
(toNPClearSiteDataFlags):
Convert WKClearSiteDataFlags to NPP_ClearSiteData flags.
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
Call through to WebPluginSiteDataManager::clearSiteData.
- UIProcess/API/C/WKPluginSiteDataManager.h: Change the clear functions to take a completion callback.
- UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::clearSiteData): Ask the plug-in info store for all plug-in paths and send a ClearPluginSiteData message to the web process.
(WebKit::WebPluginSiteDataManager::didClearSiteData):
call the callback.
- UIProcess/WebContext.cpp: (WebKit::WebContext::didClearPluginSiteData): Call through to the plug-in site data manager.
- UIProcess/WebContext.messages.in: Add ClearPluginSiteData message.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearPluginSiteData): Iterate over all the plug-in paths, creating plug-in modules and calling clearSiteData for each one.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Add DidClearPluginSiteData message.
- 17:53 Changeset [78662] by
-
Merge r78517.
- 17:50 Changeset [78661] by
-
Merge r78630.
- 17:46 Changeset [78660] by
-
Merge r78612.
- 17:44 Changeset [78659] by
-
Merge r78589.
- 17:42 Changeset [78658] by
-
Merge r78588.
- 17:37 Changeset [78657] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu-linux rebaseline of
compositing/geometry/vertical-scroll-composited.html.
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- 17:36 Changeset [78656] by
-
Unreviewed, Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 17:24 Changeset [78655] by
-
2011-02-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249
- storage/indexeddb/exception-in-event-aborts-expected.txt: Added.
- storage/indexeddb/exception-in-event-aborts.html: Added.
tests new feature
- storage/indexeddb/queued-commands-expected.txt:
- storage/indexeddb/queued-commands.html:
cleaned up (while debuggign something else)
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-event-propagation.html:
a few additional tests + cleanup
- storage/indexeddb/transaction-event-propagation-expected.txt:
- storage/indexeddb/transaction-event-propagation.html:
a few additional tests + cleanup
2011-02-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249
When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.
Test: storage/indexeddb/exception-in-event-aborts.html
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
- dom/EventTarget.cpp: (WebCore::EventTarget::uncaughtExceptionInEventHandler):
- dom/EventTarget.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
- storage/IDBRequest.h:
- 17:22 Changeset [78654] by
-
Windows build fix for
https://bugs.webkit.org/show_bug.cgi?id=54415
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
Remove deleted files.
- 17:19 Changeset [78653] by
-
Versioning.
- 17:15 Changeset [78652] by
-
2011-02-15 Ian Henderson <ianh@apple.com>
Reviewed by Darin Adler.
To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size
https://bugs.webkit.org/show_bug.cgi?id=53281
When determining properties of an image (such as its size), CG ends up
decoding part of the image. This patch adds accounting for this extra
decoded size so a cache prune can clean up the allocations.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyMetadataAndNotify): Clearing the source destroys the extra decoded data. Report this change in decoded size to the image observer. (WebCore::BitmapImage::cacheFrame): The first decoded frame subsumes the data decoded when determining image properties, so we subtract it out here. (WebCore::BitmapImage::didDecodeProperties): Reports the extra decoded size to the image's observer. (WebCore::BitmapImage::size): (WebCore::BitmapImage::currentFrameSize): (WebCore::BitmapImage::getHotSpot): (WebCore::BitmapImage::frameCount): (WebCore::BitmapImage::isSizeAvailable): (WebCore::BitmapImage::repetitionCount):
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): The default value is 0 to match the current behavior on other platforms.
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): Add a constant value for bytesDecodedToDetermineProperties(), measured by tracing malloc/calloc calls while asking an image source for its properties.
- 17:11 Changeset [78651] by
-
Windows-specific results for tests added in r78396.
https://bugs.webkit.org/show_bug.cgi?id=54506
- platform/win/fast/inline: Added.
- platform/win/fast/inline/inline-box-background-expected.txt: Added.
- platform/win/fast/inline/inline-box-background-long-image-expected.txt: Added.
- platform/win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
- platform/win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
- 17:05 Changeset [78650] by
-
New branch.
- 16:58 Changeset [78649] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu rebaseline. Rebaseline tests that were unskipped
after r78619 as well as some lingering Mac rebaselines.
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.png: Added.
- platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.png: Added.
- platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.png: Added.
- platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png: Added.
- platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
- platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png: Added.
- platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
- platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.png: Added.
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
- platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.txt: Added.
- platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.png: Added.
- platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 16:53 Changeset [78648] by
-
2011-02-15 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188
Tests that requestAnimationFrame callbacks are suspended while a modal
dialog is showing.
- fast/animation/request-animation-frame-during-modal-expected.txt: Added.
- fast/animation/request-animation-frame-during-modal.html: Added.
2011-02-15 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188
requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.
Test: fast/animation/request-animation-frame-during-modal.html
- WebCore.gypi:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
- dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create):
- history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame):
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 16:49 Changeset [78647] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Jon Honeycutt.
Implement WKPluginSiteDataManagerGetSitesWithData
https://bugs.webkit.org/show_bug.cgi?id=54510
<rdar://problem/8689312>
- UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager): Call WebContext::pluginSiteDataManager.
- UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetSitesWithData): Call WebPluginSiteDataManager::getSitesWithData.
- UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::getPluginPaths):
- UIProcess/Plugins/PluginInfoStore.h: Populate the paths argument with the paths of all plug-ins.
- UIProcess/Plugins/WebPluginSiteDataManager.cpp: Added. (WebKit::WebPluginSiteDataManager::invalidate): Invalidate the callbacks map.
(WebKit::WebPluginSiteDataManager::getSitesWithData):
Ask the plug-in info store for all plug-in paths and send a
GetSitesWithPluginData message to the web process.
(WebKit::WebPluginSiteDataManager::didGetSitesWithPluginData):
Call the callback.
- UIProcess/Plugins/WebPluginSiteDataManager.h: Added. (WebKit::WebPluginSiteDataManager::clearContext): Clear the context.
- UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize m_pluginSiteDataManager.
(WebKit::WebContext::~WebContext):
Invalidate the plug-in site data manager and clear its context.
(WebKit::WebContext::processDidClose):
Invalidate the plug-in site data manager.
(WebKit::WebContext::didGetSitesWithPluginData):
Call through to the plug-in site data manager.
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in: Add GetSitesWithPluginData message.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj: Add new files.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): Iterate over all plug-in paths and get the sites from all plug-ins.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Add DidGetSitesWithPluginData.
- 16:43 Changeset [78646] by
-
2011-02-15 Benjamin Kalman <kalman@chromium.org>
Reviewed by Darin Adler.
Clean up results for editing/selection/extend-selection-home-end layout test
https://bugs.webkit.org/show_bug.cgi?id=54508
Line up results in columns, remove unused pixel test results from qt.
- editing/selection/extend-selection-home-end-expected.txt:
- editing/selection/extend-selection-home-end.html:
- platform/mac/editing/selection/extend-selection-home-end-expected.txt:
- platform/qt/editing/selection/extend-selection-home-end-expected.checksum: Removed.
- platform/qt/editing/selection/extend-selection-home-end-expected.png: Removed.
- platform/win/editing/selection/extend-selection-home-end-expected.txt:
- 16:38 Changeset [78645] by
-
2011-02-14 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add initial support for per-origin quotas to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54421
Add support for non-persistent per-origin quotas. If one is
specified, it overrides the default.
No tests as this is only exposed via the Chromium webkit API.
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setQuota):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
2011-02-14 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add initial support for per-origin quotas to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54421
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::setQuota):
- src/AssertMatchingEnums.cpp:
- src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::setQuota):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::setQuota):
- src/WebIDBFactoryImpl.h:
- 16:36 Changeset [78644] by
-
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSLT with output method HTML and images crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=54462
http://trac.webkit.org/changeset/75577 created Document::setContent but
didn't notice that the code paths combined into Document::setContent
were subtly different. In particular, some of the code paths called
parser->finish() whereas other did not.
The difference is that an explicit call to parser->finish() is required
in the case where there is no frame because explicitClose doesn't call
endIfNotLoadingMainResource if there is no frame. This patch moves
that logic inside explicitClose, which is more natural.
This patch also removes removeAllChildren, which has not effect in this
situation and should never have been added in the first place.
Test: fast/parser/xslt-with-html.xml
- dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::explicitClose):
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSLT with output method HTML and images crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=54462
Test that we don't try to prepare to stop twice when pasing HTML
generated from an XSLT.
- fast/parser/resources/xslt-with-html.xsl: Added.
- fast/parser/xslt-with-html-expected.txt: Added.
- fast/parser/xslt-with-html.xml: Added.
- 16:36 Changeset [78643] by
-
2011-02-15 Kenneth Russell <kbr@google.com>
Unreviewed. Remove whitespace-only change from
http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
now that the patch has passed the Windows build bots.
- Interfaces/WebKit.idl:
- 16:32 Changeset [78642] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Rebaseline some GTK+ tests which have different results on the bots.
Skip a test which appears to be timing out intermittently.
- platform/gtk/Skipped: Skip a test which has been timing out.
- platform/gtk/svg/custom/use-nested-transform-expected.txt:
- platform/gtk/svg/hixie/perf/001-expected.txt:
- platform/gtk/svg/hixie/perf/002-expected.txt:
- platform/gtk/svg/hixie/perf/007-expected.txt:
- 16:23 Changeset [78641] by
-
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Patch by Jia Pu <jpu@apple.com> on 2011-02-15
Reviewed by Darin Adler.
Rebaselined tests affected by code change.
- platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
- platform/mac/editing/spelling/autocorrection-delete-expected.txt:
- platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
- platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
- platform/mac/editing/spelling/autocorrection-simple-expected.txt:
- platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
- 16:18 Changeset [78640] by
-
Fix Qt build.
- WebKit2.pro:
- 16:11 Changeset [78639] by
-
2011-02-15 Oliver Hunt <oliver@apple.com>
Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415
- CMakeLists.txt:
- 16:10 Changeset [78638] by
-
Fix Windows build.
- win/WebKit2.vcproj:
- 16:04 Changeset [78637] by
-
2011-02-15 Oliver Hunt <oliver@apple.com>
Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415
- CMakeLists.txt:
- 15:59 Changeset [78636] by
-
<http://webkit.org/b/54487> Minor header clean up in RenderLayerBacking.cpp
Reviewed by Darin Adler.
- rendering/RenderLayerBacking.cpp: Remove unused
WebGLRenderingContext.h header, and move GraphicsContext3D.h
into a #if ENABLE(WEBGL) ENABLE(ACCELERATED_2D_CANVAS)/#endif block.
- 15:55 Changeset [78635] by
-
Unreviewed, Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=40147
https://bugs.webkit.org/show_bug.cgi?id=48029
https://bugs.webkit.org/show_bug.cgi?id=53740
https://bugs.webkit.org/show_bug.cgi?id=54387
https://bugs.webkit.org/show_bug.cgi?id=54418
https://bugs.webkit.org/show_bug.cgi?id=54499
Remove a couple erroneously-added baselines, unmark some now-passing
tests, bug numbers, etc.
- platform/chromium-linux/http/tests/xmlhttprequest: Removed.
- platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Removed.
- platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 15:54 Changeset [78634] by
-
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Move to a true handle based mechanism for GC value protection. This
also allows us to switch to a more sensible behaviour for weak pointers
in which weak pointers are automatically updated.
This allows us to remove the old (and convoluted) that required all
objects that may be held by a weak reference to be aware of the reference
and manually clear them in their destructors.
This also adds a few new data types to JSC that we use to efficiently
allocate and return the underlying handle storage.
This patch is largely renaming and removing now unnecessary destructors
from objects.
- API/JSClassRef.cpp: (OpaqueJSClass::create): (OpaqueJSClassContextData::OpaqueJSClassContextData): (OpaqueJSClass::contextData): (OpaqueJSClass::prototype):
- API/JSClassRef.h:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- collector/handles/Global.h: Added.
New Global handle type used to keep gc objects live, even if they're not
marked.
(JSC::Global::Global):
(JSC::Global::~Global):
(JSC::Global::set):
We can only assign directly to a global from another global.
In all other cases we need the JSGlobalData to be provided
explicitly so we use a set function.
(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::isHashTableDeletedValue):
(JSC::Global::internalSet):
- collector/handles/Handle.h: Added.
Root "Handle" type used for immutable handles and to provide the basic
APIs needed for pointer-like behaviour.
(JSC::HandleBase::operator!):
(JSC::HandleBase::operator UnspecifiedBoolType*):
(JSC::HandleBase::isEmpty):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::invalidate):
(JSC::HandleBase::setSlot):
(JSC::HandleTypes::getFromSlot):
(JSC::HandleTypes::toJSValue):
(JSC::HandleTypes::validateUpcast):
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
(JSC::Handle::Handle):
(JSC::Handle::get):
(JSC::Handle::wrapSlot):
(JSC::operator==):
(JSC::operator!=):
- collector/handles/HandleHeap.cpp: Added.
New heap for global handles.
(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::grow):
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::updateAfterMark):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):
- collector/handles/HandleHeap.h: Added. (JSC::HandleHeap::heapFor): (JSC::HandleHeap::toHandle): (JSC::HandleHeap::toNode): (JSC::HandleHeap::allocate): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak):
Convert a hard handle into weak handle that does not
protect the object it points to.
(JSC::HandleHeap::makeSelfDestroying):
Converts a handle to a weak handle that will be returned
to the free list when the referenced object dies.
(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::slot):
(JSC::HandleHeap::Node::handleHeap):
(JSC::HandleHeap::Node::setFinalizer):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::makeSelfDestroying):
(JSC::HandleHeap::Node::isSelfDestroying):
(JSC::HandleHeap::Node::finalizer):
(JSC::HandleHeap::Node::setPrev):
(JSC::HandleHeap::Node::prev):
(JSC::HandleHeap::Node::setNext):
(JSC::HandleHeap::Node::next):
- interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
- interpreter/Interpreter.h:
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollected):
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- runtime/GCHandle.cpp: Removed.
- runtime/GCHandle.h: Removed.
- runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::markRoots):
- runtime/Heap.h: (JSC::Heap::allocateGlobalHandle): (JSC::Heap::reportExtraMemoryCost):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateGlobalHandle):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache):
- runtime/Protect.h:
- runtime/Structure.cpp: (JSC::Structure::~Structure):
- runtime/Structure.h:
- runtime/WeakGCPtr.h: (JSC::WeakGCPtrBase::get): (JSC::WeakGCPtrBase::clear): (JSC::WeakGCPtrBase::operator!): (JSC::WeakGCPtrBase::operator UnspecifiedBoolType*): (JSC::WeakGCPtrBase::~WeakGCPtrBase): (JSC::WeakGCPtrBase::WeakGCPtrBase): (JSC::WeakGCPtrBase::internalSet): (JSC::LazyWeakGCPtr::LazyWeakGCPtr): (JSC::LazyWeakGCPtr::set): (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::operator=):
- runtime/WriteBarrier.h:
- wtf/BlockStack.h: Added. (WTF::::BlockStack): (WTF::::~BlockStack): (WTF::::blocks): (WTF::::grow): (WTF::::shrink):
- wtf/SentinelLinkedList.h: Added. (WTF::::SentinelLinkedList): (WTF::::begin): (WTF::::end): (WTF::::push): (WTF::::remove):
- wtf/SinglyLinkedList.h: Added. (WTF::::SinglyLinkedList): (WTF::::isEmpty): (WTF::::push): (WTF::::pop):
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Update to use new Global<> type
- JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
- JSRun.h:
- JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper):
- JSValueWrapper.h:
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Update WebCore to use the new Global<> type rather than ProtectedJSValue
and gc[Un]Protect. Also update to use new WeakGCPtr APIs, and remove now
unnecessary destructors.
- ForwardingHeaders/collector/handles/Global.h: Added.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData):
- bindings/js/JSCustomVoidCallback.h:
- bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
- bindings/js/JSDataGridDataSource.h:
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h: (WebCore::JSEventListener::setWrapper):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptCachedFrameData.h:
- bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptArguments):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWindowShell): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::attachDebugger):
- bindings/js/ScriptController.h:
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): (WebCore::ScriptCallback::call):
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject):
- bindings/js/ScriptObject.h:
- bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
- bindings/js/ScriptState.h:
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction): (WebCore::ScriptValue::deserialize):
- bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::setWrapper):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::~WorkerScriptController): (WebCore::WorkerScriptController::initScript): (WebCore::WorkerScriptController::evaluate):
- bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::workerContextWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
- bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject):
- bridge/jsc/BridgeJSC.h:
- bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::invalidate):
- bridge/runtime_root.cpp: (JSC::Bindings::RootObject::RootObject): (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::globalObject): (JSC::Bindings::RootObject::updateGlobalObject):
- bridge/runtime_root.h:
- dom/EventListener.h:
- dom/EventTarget.h: (WebCore::EventTarget::markJSEventListeners):
- xml/XMLHttpRequest.cpp:
Qt bindings courtesy of Csaba Osztrogonác
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::QtConnectionObject): (JSC::Bindings::QtConnectionObject::execute): (JSC::Bindings::QtConnectionObject::match):
- bridge/qt/qt_runtime.h:
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Update to use Global<> instead of ProtectedPtr, and refactored slightly
to get global data to places it's needed for when we're assigning to
Global<>s
- ForwardingHeaders/collector/handles/Global.h: Added.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::addValueToArray):
- WebView/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Update code to new Global<> API, and refactor to get global data to
necessary points.
- WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::create): (WebKit::NPJSObject::NPJSObject): (WebKit::NPJSObject::initialize): (WebKit::NPJSObject::invokeDefault): (WebKit::NPJSObject::construct): (WebKit::NPJSObject::invoke):
- WebProcess/Plugins/Netscape/NPJSObject.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateNPObject): (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): (WebKit::NPRuntimeObjectMap::evaluate):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::windowScriptNPObject): (WebKit::PluginView::pluginElementNPObject):
- 15:51 Changeset [78633] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Jon Honeycutt.
Add stubbed out WKPluginSiteDataManagerRef API
https://bugs.webkit.org/show_bug.cgi?id=54504
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager):
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKPluginSiteDataManager.cpp: Added. (WKPluginSiteDataManagerGetTypeID): (WKPluginSiteDataManagerGetSitesWithData): (WKPluginSiteDataManagerClearSiteData): (WKPluginSiteDataManagerClearAllSiteData):
- UIProcess/API/C/WKPluginSiteDataManager.h: Added.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 15:44 Changeset [78632] by
-
2011-02-15 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Please see WebCore/ChangeLog for detailed description.
- WebCoreSupport/WebEditorClient.cpp: (WebFrameImpl::replaceSelection): Adopted new signature of ReplaceSelectionCommand::create().
2011-02-15 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Please see WebCore/ChangeLog for detailed description.
- WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::recordAutocorrectionResponse): Ditto.
- WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
Adopted new signature of ReplaceSelectionCommand::create().
2011-02-15 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Manual test: manual-tests/autocorrection/undo-autocorrection.html
When user undoes an autocorrection, we need to do four things:
- Revert the change in text that has been made by correction.
- Revert the selection to pre-correction state so that user can immediately continue typing.
- Add appropriate markers to reverted text so that it won't be corrected again and/or shown as misspelled.
- If applicable, notify spell checking service to record this reversion.
To achieve these, this patch introduces following changes:
- Created SpellingCorrectionCommand so that correction can be undone in similar way as any other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand, SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand.
- Created SetSelectionCommand so that undo command can restore selection state.
- Added member function recordAutocorrectionResponse() to editor client.
To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection()
and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been
replaced by enum variable.
- WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand.
- WebCore.xcodeproj/project.pbxproj: Updated for new source files.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create().
- editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection(). (WebCore::Editor::confirmComposition): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the
level of deeply nested if statement. Adopted SpellingCorrectionCommand.
(WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand.
(WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and
for notifiying editor client about undone correction.
(WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection().
(WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions
instead of boolean variables.
- editing/Editor.h: Added Editor::unappliedSpellCorrection().
- editing/EditorCommand.cpp: (WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create().
- editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments
with an enum value.
- editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create): Ditto.
- editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection(). (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::respondToNodeModification): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent): (WebCore::SelectionController::setSelectedRange):
- editing/SelectionController.h: (WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value.
- editing/SetSelectionCommand.cpp: Added. (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
- editing/SetSelectionCommand.h: Added. (WebCore::SetSelectionCommand::create):
- editing/mac/SpellingCorrectionCommand.cpp: Added. (WebCore::SpellingCorrectionRecordUndoCommand::create): (WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand): (WebCore::SpellingCorrectionRecordUndoCommand::doApply): (WebCore::SpellingCorrectionRecordUndoCommand::doUnapply): (WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand): (WebCore::SpellingCorrectionCommand::doApply):
- editing/mac/SpellingCorrectionCommand.h: Added. (WebCore::SpellingCorrectionCommand::create):
- loader/EmptyClients.h: Updated for the new function declared in EditorClient. (WebCore::EmptyEditorClient::recordAutocorrectionResponse):
- manual-tests/autocorrection/undo-autocorrection.html: Added.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create().
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Ditto.
- page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse().
2011-02-15 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Please see WebCore/ChangeLog for detailed description.
- WebProcess/WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::recordAutocorrectionResponse): Ditto.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::replaceSelectionWithText): Adopted new signature of ReplaceSelectionCommand::create().
- 15:41 Changeset [78631] by
-
Add media/audio-delete-while-slider-thumb-clicked.html to Windows skipped list.
Failing since r78562.
- platform/win/Skipped:
- 15:39 Changeset [78630] by
-
Speculative fix for <rdar://problem/8998498> CrashTracer: [USER]
8 crashes in WebProcess calling setOverlayScrollerState:forceImmediately:
Reviewed by Darin Adler.
My best guess is that this is crashing because
willRemoveVerticalScrollbar()/Horizontal was not being called
properly from the RenderLayer destructor.
Call willRemoveVerticalScrollbar()/Horizontal from destroyScrollbar()
so that all current and future scrollbar-destroyers will properly
call this function. And only do it for native scrollers.
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderListBox::destroyScrollbar):
For consistency's sake, I also moved didAddVerticalScrollbar()
/Horizontal to createScrollbar(). Again, only call for native
scrollers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderListBox::createScrollbar):
These functions no longer call didAdd/willRemove.
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setHasVerticalScrollbar):
Remove unnecessary ScrollableArea::-prefix
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
- 15:38 Changeset [78629] by
-
2011-02-15 Stephen White <senorblanco@chromium.org>
Unreviewed; new baselines for canvas GPU tests.
Rebaseline for slight pixel differences on windows.
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium/test_expectations.txt:
- 15:31 Changeset [78628] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu expectations update. Update expectations after
tests that were unskipped by r78619 started to be run again. Most of
them don't time out anymore, instead they have image and/or text diffs.
Also remove flaky expectations for fast/canvas/shadow-offset-*.html,
since they pass consistently now that the bug on the Chromium/V8 side
(http://crbug.com/67732) has been fixed.
- platform/chromium/test_expectations.txt:
- 15:25 Changeset [78627] by
-
<http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
Reviewed by Darin Adler.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
-inProgramaticScroll.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
- 15:20 Changeset [78626] by
-
2011-02-15 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Cleanup Some Potential ENABLE(INSPECTOR) Related Building Issues
https://bugs.webkit.org/show_bug.cgi?id=54048
- WebCore.exp.in: moved inspector only export into ENABLE(INSPECTOR) block.
- bindings/js/ScriptHeapSnapshot.h: include no longer needed.
- 15:17 Changeset [78625] by
-
2011-02-15 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
[chromium] clearRect() is incorrect in accelerated 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=54497
When doing GPU-Canvas2D clearRect() using the fast path (glClear()),
we were not correctly converting from canvas to screen coordinates.
Fixed by inverting the rectangle in Y, and changing
SharedGraphicsContext3D::scissor to take glScissor-like parameters.
Covered by fast/canvas/canvas-strokeRect.html.
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::clearRect): Flip the Y coord of the rectangle passed to scissor().
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::scissor):
- platform/graphics/gpu/SharedGraphicsContext3D.h: Give scissor() the same param types as GraphicsContext3D::scissor().
2011-02-15 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
[chromium] Mark fast/canvas/canvas-strokeRect.html as passing on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=54497
- platform/chromium/test_expectations.txt:
- 15:16 Changeset [78624] by
-
WebKit2: Use the Database directory location specified in NSUserDefaults.
https://bugs.webkit.org/show_bug.cgi?id=54496
Reviewed by Darin Adler.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
Use the same logic as WebKit1's WebDatabaseManager::databasesDirectoryPath.
- 15:01 Changeset [78623] by
-
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson, Darin Adler.
Layers stick around in DrawingAreaImpl until we switch out of compositing
https://bugs.webkit.org/show_bug.cgi?id=54498
When leaving compositing mode soon, remove all the child layers
of the nonCompositedContent layer right away, so they don't stick
around.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setRootCompositingLayer):
- 15:01 Changeset [78622] by
-
2011-02-15 Pratik Solanki <psolanki@apple.com>
Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168
Reviewed by Darin Adler.
- wtf/Platform.h: Define WTF_USE_CFNETWORK for Windows builds.
2011-02-15 Pratik Solanki <psolanki@apple.com>
Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168
Reviewed by Darin Adler.
- config.h: Remove WTF_USE_CFNETWORK.
- 14:55 Changeset [78621] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu expectations update.
compositing/reflections/animation-inside-reflection.html and
compositing/reflections/nested-reflection-animated.html are flaky on
Linux too.
- platform/chromium/test_expectations.txt:
- 14:53 Changeset [78620] by
-
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Implemented new method setMinimumTimerInterval in
LayoutTestController for all ports.
- DumpRenderTree/LayoutTestController.cpp: (setMinimumTimerIntervalCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMinimumTimerInterval):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMinimumTimerInterval):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMinimumTimerInterval):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMinimumTimerInterval):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMinimumTimerInterval):
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
- fast/dom/timer-increase-min-interval-and-reset-part-1-expected.txt: Added.
- fast/dom/timer-increase-min-interval-and-reset-part-1.html: Added.
- fast/dom/timer-increase-min-interval-and-reset-part-2-expected.txt: Added.
- fast/dom/timer-increase-min-interval-and-reset-part-2.html: Added.
- Chained tests (the assumption is that the run-webkit-tests harness will run them sequentially, which is a reasonably good assumption) which verify that the minimum timer interval is reset between tests.
- fast/dom/timer-increase-min-interval-expected.txt: Added.
- fast/dom/timer-increase-min-interval.html: Added.
- Verifies that increasing the minimum timer interval causes fast timers to run slowly.
- fast/dom/timer-increase-then-decrease-min-interval-expected.txt: Added.
- fast/dom/timer-increase-then-decrease-min-interval.html: Added.
- Verifies that decreasing the minimum timer interval causes previously slowed-down timers to be reevaluated immediately.
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
- public/WebSettings.h:
- Added setMinimumTimerInterval.
- src/WebKit.cpp:
(WebKit::initialize):
- Added FIXME to remove setting of page's default timer interval.
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setMinimumTimerInterval):
- Implemented new method on WebSettings.
- src/WebSettingsImpl.h:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::defaultMinimumTimerInterval): (DumpRenderTreeSupportQt::setMinimumTimerInterval):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval): (DumpRenderTreeSupportGtk::setMinimumTimerInterval):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method. Includes whitespace-only change to
WebKit.idl to trigger proper rebuild on bots; will be removed in
subsequent checkin.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebView.cpp: (WebView::initWithFrame): (WebView::defaultMinimumTimerInterval): (WebView::setMinimumTimerInterval):
- WebView.h:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (+[WebView _defaultMinimumTimerInterval]): (-[WebView _setMinimumTimerInterval:]):
- WebView/WebViewPrivate.h:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Renamed DOMTimer::minTimerInterval and setMinTimerInterval to
defaultMinTimerInterval and setDefaultMinTimerInterval, made them
private and exposed them via Settings::defaultMinDOMTimerInterval
and setDefaultMinDOMTimerInterval. Added new
Settings::setMinDOMTimerInterval and minDOMTimerInterval.
The storage for the minimum timer interval currently lives in the
Page, though this could be moved to the Settings object if
desired. The accessor methods on the Page are private and exposed
to Settings by making Settings a friend, so the abstraction
barrier is clear at the API level.
Adjusting the interval both upward and downward may cause the fire
times of the active timers on the page to be adjusted, if they
would be affected by the clamping value. This is needed to reduce
latency when bringing a tab to the foreground, in particular if
the minimum timer interval was decreased from a very high value to
a very low value.
A new method, setMinimumTimerInterval, has been added to
LayoutTestController, implemented in all ports of DumpRenderTree,
and used in new layout tests.
Ideally changing the page's minimum timer interval would affect
dedicated workers, but this is too much to do in an initial patch,
so a FIXME has been added.
Tested with:
- The new layout tests on the WebKit Mac and Chromium (Mac, Linux) DRT ports.
- Hooked up the new API in Chromium and ran some simple manual tests.
Tests: fast/dom/timer-increase-min-interval-and-reset-part-1.html
fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-min-interval.html
fast/dom/timer-increase-then-decrease-min-interval.html
- WebCore.exp.in:
- dom/Document.cpp: (WebCore::Document::minimumTimerInterval):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::adjustMinimumTimerInterval): (WebCore::ScriptExecutionContext::minimumTimerInterval):
- dom/ScriptExecutionContext.h:
- page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::adjustMinimumTimerInterval): (WebCore::DOMTimer::intervalClampedToMinimum):
- page/DOMTimer.h: (WebCore::DOMTimer::defaultMinTimerInterval): (WebCore::DOMTimer::setDefaultMinTimerInterval):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setMinimumTimerInterval): (WebCore::Page::minimumTimerInterval):
- page/Page.h:
- page/Settings.cpp: (WebCore::Settings::setDefaultMinDOMTimerInterval): (WebCore::Settings::defaultMinDOMTimerInterval): (WebCore::Settings::setMinDOMTimerInterval): (WebCore::Settings::minDOMTimerInterval):
- page/Settings.h:
- platform/Timer.h: (WebCore::TimerBase::augmentFireInterval): (WebCore::TimerBase::augmentRepeatInterval):
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
- 14:49 Changeset [78619] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu baseline update. Unskip some tests that fail;
we want to keep running them in case they regress in unexpected ways
(e.g. they start to crash).
- platform/chromium/test_expectations.txt:
- 14:46 Changeset [78618] by
-
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494
Remove code added in r78394 which was intended to find out whether
a scrollbar was being rendered into a compositing layer. r78612
obviated the need for this code.
- page/FrameView.h:
- platform/ScrollableArea.h:
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
- 14:37 Changeset [78617] by
-
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Let Xcode have its way with the project.
- WebCore.xcodeproj/project.pbxproj:
- 14:37 Changeset [78616] by
-
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Fix Mac builds that don't use rubber-band scrolling
by moving m_drawingIntoLayer out of the #ifdef.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- 14:30 Changeset [78615] by
-
Merge 78548 - 2011-02-15 Gavin Peters <gavinp@chromium.org>
Reviewed by Antti Koivisto.
SharedBuffer::buffer() does not do what you think.
https://bugs.webkit.org/show_bug.cgi?id=54420
No new tests.
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
- platform/SharedBuffer.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6526023
- 14:16 Changeset [78614] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323
Update the results of this test, which is now passing. Also update results for
all other tests which have different results now.
- platform/gtk/fast/css/font-weight-1-expected.checksum:
- platform/gtk/fast/css/font-weight-1-expected.png:
- platform/gtk/fast/css/font-weight-1-expected.txt:
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323
- platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::fontWeightToFontconfigWeight): Added this helper to map between CSS and Fontconfig font weights. (WebCore::FontCache::createFontPlatformData): Use the new helper instead of just deciding between bold and regular.
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323
Add the WeightWatcher fonts to the list of sourced fonts when intializing
DRT. This will allow us to pass tests that use WeightWatcher.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Source the WebkitWeightWatcher fonts.
- 14:12 Changeset [78613] by
-
2011-02-15 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu-linux rebaseline. Check in correct expectations
which should allow us to remove the PASS FAIL line for compositing/ for
this platform.
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/generated-content-expected.checksum:
- platform/chromium-gpu-linux/compositing/generated-content-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png: Added.
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.checksum:
- platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png: Added.
- platform/chromium-gpu-linux/compositing/sibling-positioning-expected.checksum:
- platform/chromium-gpu-linux/compositing/sibling-positioning-expected.png:
- platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 14:00 Changeset [78612] by
-
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494
The scroller delegate was failing to return a layer in a case
where the scroller was still rendering into a GraphicsLayer, because
even though WebCore had switched out of compositing mode, the
DrawingAreaImpl was still rendering into its nonCompositedContent
layer. This happens when the m_exitCompositingTimer timer hasn't fired
yet.
The fix is to track whether we're drawing into a layer via the
GraphicsContext, rather than asking about compositing layers.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): Getter and setter for the bit that says if we're rendering into a CALayer.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Store a bool for whether this context targets a layer.
- platform/graphics/mac/WebLayer.mm: (drawLayerContents): Call setIsCALayerContext(true).
- platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorMac::isDrawingIntoLayer): New methods to get and set a flag that says when we're drawing into a layer, so that the delegate can get at this state.
- platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterDelegate layer]): Use isDrawingIntoLayer() (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Init the flag.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::unregisterScrollbar): Whitespace. (WebCore::ScrollbarThemeMac::paint): Push the "isDrawingIntoLayer" state down onto ScrollAnimatorMac, getting it from the GraphicsContext.
- 13:35 Changeset [78611] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add sitesWithData and clearSiteData to NetscapePluginModule
https://bugs.webkit.org/show_bug.cgi?id=54492
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::NetscapePluginModule): (WebKit::NetscapePluginModule::pluginCreated): (WebKit::NetscapePluginModule::pluginDestroyed): (WebKit::NetscapePluginModule::sitesWithData): (WebKit::NetscapePluginModule::clearSiteData): (WebKit::NetscapePluginModule::tryGetSitesWithData): (WebKit::NetscapePluginModule::tryClearSiteData): (WebKit::NetscapePluginModule::incrementLoadCount): (WebKit::NetscapePluginModule::decrementLoadCount):
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- 13:33 Changeset [78610] by
-
2011-02-15 Tony Chang <tony@chromium.org>
Rebaseline chromium-linux tests with menulists (select drop downs).
We now match Windows w.r.t. sizes, the only difference is the
background color of the menulist (in themeChromiumLinux.css).
- platform/chromium-linux/editing/pasteboard/4641033-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4641033-expected.png:
- platform/chromium-linux/editing/pasteboard/4641033-expected.txt:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.txt:
- platform/chromium-linux/editing/pasteboard/4944770-2-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
- platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
- platform/chromium-linux/editing/selection/caret-before-select-expected.png:
- platform/chromium-linux/editing/selection/caret-before-select-expected.txt:
- platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.checksum:
- platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
- platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.txt:
- platform/chromium-linux/editing/selection/select-box-expected.checksum:
- platform/chromium-linux/editing/selection/select-box-expected.png:
- platform/chromium-linux/editing/selection/select-box-expected.txt:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.txt:
- platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
- platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
- platform/chromium-linux/fast/block/float/float-avoidance-expected.txt:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
- platform/chromium-linux/fast/forms/003-expected.checksum:
- platform/chromium-linux/fast/forms/003-expected.png:
- platform/chromium-linux/fast/forms/003-expected.txt:
- platform/chromium-linux/fast/forms/004-expected.checksum:
- platform/chromium-linux/fast/forms/004-expected.png:
- platform/chromium-linux/fast/forms/004-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.checksum:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
- platform/chromium-linux/fast/forms/basic-selects-expected.png:
- platform/chromium-linux/fast/forms/basic-selects-expected.txt:
- platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum:
- platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
- platform/chromium-linux/fast/forms/control-clip-overflow-expected.txt:
- platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum:
- platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
- platform/chromium-linux/fast/forms/menulist-clip-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-clip-expected.png:
- platform/chromium-linux/fast/forms/menulist-clip-expected.txt:
- platform/chromium-linux/fast/forms/menulist-deselect-update-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
- platform/chromium-linux/fast/forms/menulist-deselect-update-expected.txt:
- platform/chromium-linux/fast/forms/menulist-narrow-width-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-narrow-width-expected.png:
- platform/chromium-linux/fast/forms/menulist-narrow-width-expected.txt:
- platform/chromium-linux/fast/forms/menulist-no-overflow-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
- platform/chromium-linux/fast/forms/menulist-no-overflow-expected.txt:
- platform/chromium-linux/fast/forms/menulist-option-wrap-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-option-wrap-expected.png:
- platform/chromium-linux/fast/forms/menulist-option-wrap-expected.txt:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.txt: Removed.
- platform/chromium-linux/fast/forms/menulist-separator-painting-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
- platform/chromium-linux/fast/forms/menulist-separator-painting-expected.txt:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.txt:
- platform/chromium-linux/fast/forms/menulist-width-change-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
- platform/chromium-linux/fast/forms/menulist-width-change-expected.txt:
- platform/chromium-linux/fast/forms/option-script-expected.checksum:
- platform/chromium-linux/fast/forms/option-script-expected.png:
- platform/chromium-linux/fast/forms/option-script-expected.txt:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
- platform/chromium-linux/fast/forms/option-text-clip-expected.checksum:
- platform/chromium-linux/fast/forms/option-text-clip-expected.png:
- platform/chromium-linux/fast/forms/option-text-clip-expected.txt:
- platform/chromium-linux/fast/forms/select-align-expected.checksum:
- platform/chromium-linux/fast/forms/select-align-expected.png:
- platform/chromium-linux/fast/forms/select-align-expected.txt:
- platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
- platform/chromium-linux/fast/forms/select-baseline-expected.png:
- platform/chromium-linux/fast/forms/select-baseline-expected.txt:
- platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
- platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
- platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/chromium-linux/fast/forms/select-disabled-appearance-expected.checksum:
- platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
- platform/chromium-linux/fast/forms/select-disabled-appearance-expected.txt:
- platform/chromium-linux/fast/forms/select-empty-option-height-expected.checksum:
- platform/chromium-linux/fast/forms/select-empty-option-height-expected.png:
- platform/chromium-linux/fast/forms/select-empty-option-height-expected.txt:
- platform/chromium-linux/fast/forms/select-selected-expected.checksum:
- platform/chromium-linux/fast/forms/select-selected-expected.png:
- platform/chromium-linux/fast/forms/select-selected-expected.txt:
- platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.checksum:
- platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/chromium-linux/fast/html/keygen-expected.checksum:
- platform/chromium-linux/fast/html/keygen-expected.png:
- platform/chromium-linux/fast/html/keygen-expected.txt:
- platform/chromium-linux/fast/invalid/014-expected.checksum:
- platform/chromium-linux/fast/invalid/014-expected.png:
- platform/chromium-linux/fast/invalid/014-expected.txt:
- platform/chromium-linux/fast/invalid/residual-style-expected.checksum:
- platform/chromium-linux/fast/invalid/residual-style-expected.png:
- platform/chromium-linux/fast/invalid/residual-style-expected.txt:
- platform/chromium-linux/fast/parser/document-write-option-expected.checksum:
- platform/chromium-linux/fast/parser/document-write-option-expected.png:
- platform/chromium-linux/fast/parser/document-write-option-expected.txt:
- platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
- platform/chromium-linux/fast/repaint/control-clip-expected.png:
- platform/chromium-linux/fast/repaint/control-clip-expected.txt:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
- platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.checksum:
- platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/chromium-linux/fast/replaced/three-selects-break-expected.checksum:
- platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
- platform/chromium-linux/fast/replaced/three-selects-break-expected.txt:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
- platform/chromium-linux/tables/mozilla/core/margins-expected.checksum:
- platform/chromium-linux/tables/mozilla/core/margins-expected.png:
- platform/chromium-linux/tables/mozilla/core/margins-expected.txt:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.checksum:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.txt:
- platform/chromium/test_expectations.txt:
- 13:30 Changeset [78609] by
-
Fix windows build.
- Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceRequest):
- 13:22 Changeset [78608] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Reversing an expectations update, that I mistakenly uploaded in r78595.
- platform/gtk/Skipped: Skip this test, as the results are incorrect on GTK+.
- svg/text/lengthAdjust-text-metrics-expected.txt: Restore expectations for this test.
- 13:21 Changeset [78607] by
-
Skip failing tests being tracked by https://bugs.webkit.org/show_bug.cgi?id=54490
- platform/win/Skipped:
- 13:09 Changeset [78606] by
-
2011-02-15 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] add WebIDBFactory::deleteDatabase method
https://bugs.webkit.org/show_bug.cgi?id=54447
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open): (WebKit::WebIDBFactory::deleteDatabase):
- 13:03 Changeset [78605] by
-
2011-02-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved MarkedBlock data members to the head of the block
https://bugs.webkit.org/show_bug.cgi?id=54482
This allows for a variable-sized tail, to accommodate oversized blocks.
SunSpider reports no change.
- runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate):
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
- runtime/MarkedBlock.h: Added missing element to the CELLS_PER_BLOCK calculation. This kind of error is why we want to migrate to the system described below.
(JSC::roundUpToMultipleOf):
(JSC::MarkedBlock::firstCell):
(JSC::MarkedBlock::cells):
(JSC::MarkedBlock::cellNumber): Use subtraction instead of masking to
calculate cell number. The mask is no longer correct because the first
cell is not at the head of the block.
(JSC::MarkedBlock::forEach): Replaced m_cells data member with a cells()
accessor. We want to use sizeof(MarkedBlock) to calculate the size of the
block header, so we can't have an explicit data member to represent the block tail.
Also replaced iteration from zero with iteration from startCell(), since
the first N cells are now occupied by the header.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset): Replaced iteration from zero as above.
- 12:50 Changeset [78604] by
-
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add NPP_GetSitesWithData and NPP_URLRedirectNotify to the NPAPI headers
https://bugs.webkit.org/show_bug.cgi?id=54481
We should really sync all headers with the NPAPI repository, but doing that
lead to build errors so I just added what was needed.
- bridge/npapi.h: Add new functions.
- bridge/nptypes.h: Sync with the official NPAPI repository, adding 64-bit integer types and removing a duplicate license header.
- plugins/npfunctions.h: Add new functions.
- 12:37 Changeset [78603] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=54480
<rdar://problem/8975229> REGRESSION (WebKit2): A web page remains unresponsive for a long
time after printing
Nothing was painted until moving the mouse over browser chrome, deactivating the window,
or taking some other drastic measure like that.
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Call -[NSView displayIfNeeded] after enabling autodisplay. For some reason, this makes WebCore push updates again.
- 12:29 Changeset [78602] by
-
https://bugs.webkit.org/show_bug.cgi?id=54486
Crashes under CachedResourceLoader::revalidateResource
Reviewed by Darin Adler.
CachedResourceLoader might get deleted from under one of its methods.
Try to catch a more informative crash stack.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):
- loader/cache/CachedResourceLoader.h:
- 12:12 Changeset [78601] by
-
2011-02-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Make new-run-webkit-tests --processes work under Windows' weird
multiprocessing model. This requires us to be running a Python
file that can be imported as a module, so I've modified the
new-run-webkit-tests script to spawn a subprocess runing
webkitpy.layout_tests.run_webkit_tests.py. I've also modified
the manager_worker_broker tests because you can't pickle a
nested class. This requires us to use globals to pass queues
back and forth for testing, but the alternative is to pass extra
arguments to start_worker() and that feels like a bad tradeoff
just for testing.
- Scripts/new-run-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- 12:10 Changeset [78600] by
-
2011-02-15 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Crash loading fast/loader/empty-embed-src-attribute.html
<rdar://problem/9005541>
https://bugs.webkit.org/show_bug.cgi?id=54483
Add the ability to encode/decode and empty ResourceRequest.
- Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
- Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
- 12:02 Changeset [78599] by
-
2011-02-15 Stephen White <senorblanco@chromium.org>
Unreviewed; new Chromium/Linux test baselines.
canvas-composite.html rebaselined due to new GPU-based path drawing code.
canvas-text-alignment and image-object-in-canvas rebaselined due to slight pixel differences near the scrollbar.
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- 11:58 Changeset [78598] by
-
2011-02-15 Tony Chang <tony@chromium.org>
Unreviewed, update the version of Chromium in webkit.
- DEPS:
- 11:52 Changeset [78597] by
-
2011-02-15 Chris Rogers <crogers@google.com>
Reviewed by Alexey Proskuryakov.
Fix Mutex::tryLock() on Windows to work properly with PlatformCondition::timedWait()
https://bugs.webkit.org/show_bug.cgi?id=54408
- wtf/ThreadingWin.cpp: (WTF::PlatformCondition::timedWait):
- 11:47 Changeset [78596] by
-
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Optimize Color::serialized()
https://bugs.webkit.org/show_bug.cgi?id=54452
Apply the optimizations from CSSPrimitiveValue::cssText() [CSS_RGBCOLOR]
to Color::serialized() - build the serialized color strings manually
instead of using String::format().
- platform/graphics/Color.cpp: (WebCore::appendHexNumber): (WebCore::Color::serialized):
- 11:26 Changeset [78595] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Import the last set of GTK+ baselines for SVG tests.
- platform/gtk/Skipped: Unskip tests which now have results. Classify failures.
- 11:17 Changeset [78594] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 11:17 Changeset [78593] by
-
2011-02-15 Andreas Kling <kling@webkit.org>
Unreviewed Qt build fix after r78588.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add WKPageLoaderClient::shouldGoToHistoryItem.
- 11:10 Changeset [78592] by
-
2011-02-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78579.
http://trac.webkit.org/changeset/78579
https://bugs.webkit.org/show_bug.cgi?id=54479
Undo wrong rebaseline for Gtk results (Requested by msanchez
on #webkit).
- platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
- 11:10 Changeset [78591] by
-
2011-02-15 Jarred Nicholls <jarred@sencha.com>
Reviewed by Alexey Proskuryakov.
XMLHttpRequest::abort() doesn't clear response data
https://bugs.webkit.org/show_bug.cgi?id=54118
Properly clear all buffer data on abort, so no memory hangs around unnecessarily.
No new tests because there is no observable effect except for less memory used.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort):
- 11:01 Changeset [78590] by
-
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Rename Color::name() to Color::nameForRenderTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=54464
Color::name() returns the color as either #RRGGBB or #RRGGBBAA.
Since the latter is not a valid CSS color, it can't be re-parsed
by WebKit, and should only be used in DRT dumps.
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
- platform/graphics/Color.cpp: (WebCore::Color::nameForRenderTreeAsText):
- platform/graphics/Color.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
- rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):
- rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeRenderSVGTextBox):
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
- svg/SVGColor.cpp: (WebCore::SVGColor::cssText):
- 10:57 Changeset [78589] by
-
Stop using deprecated API to flip the dragImage.
<rdar://problem/8930897>
https://bugs.webkit.org/show_bug.cgi?id=54477
Reviewed by Darin Adler.
NSImage setFlipped is a deprecated API. We replace it with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setDragImage): Removed call to setFlipped.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): The image is now drawn with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.
- 10:46 Changeset [78588] by
-
<rdar://problem/9002047> and https://bugs.webkit.org/show_bug.cgi?id=54426
WebFrameLoaderClient::shouldGoToHistoryItem needs implementation
Reviewed by Darin Adler.
Source/WebKit2:
Expose HistoryItem -> ItemID mapping for the message:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::idForItem):
- WebProcess/WebPage/WebBackForwardListProxy.h:
Sync message to the UIProcess for the answer:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
Call out to the WebLoaderClient for the answer:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldGoToBackForwardListItem):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Call out to the client application for the answer:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):
- UIProcess/WebLoaderClient.h:
Add API for the client application to listen for this:
- UIProcess/API/C/WKPage.h:
Tools:
Add dummy implementations to keep our tools building.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 10:43 Changeset [78587] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Import the next batch of GTK+ SVG test results and correct an incorrect
line in the skipped list.
- platform/gtk/Skipped: Unskip tests which now have results.
- 10:38 Changeset [78586] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
SKIP two more Inspector tests, from r78581 (by pfeldman's request).
- 10:25 Changeset [78585] by
-
2011-02-15 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Andreas Kling.
[Qt] Typo fix.
No new tests needed.
- WebCore.pro: add missing ASCII to header name.
- 10:22 Changeset [78584] by
-
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
- platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Removed.
- platform/qt/Skipped:
- 10:18 Changeset [78583] by
-
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Continue importing GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 10:14 Changeset [78582] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
SKIP two Inspector tests (by pfeldman's request).
- 10:07 Changeset [78581] by
-
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: test whether inspector gets populated with databases and storages upon opening.
https://bugs.webkit.org/show_bug.cgi?id=54469
- http/tests/inspector-enabled/database-open-expected.txt: Added.
- http/tests/inspector-enabled/database-open.html: Added.
- http/tests/inspector-enabled/dom-storage-open-expected.txt: Added.
- http/tests/inspector-enabled/dom-storage-open.html: Added.
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: test whether inspector gets populated with databases and storages upon opening.
https://bugs.webkit.org/show_bug.cgi?id=54469
Tests: http/tests/inspector-enabled/database-open.html
http/tests/inspector-enabled/dom-storage-open.html
- inspector/front-end/DOMStorage.js:
- inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):
- 09:58 Changeset [78580] by
-
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Share the helper functions used by Latin-1 and UTF-8 text codecs
https://bugs.webkit.org/show_bug.cgi?id=54446
Move MachineWord, UCharByteFiller and the other helper functions
into TextCodecASCIIFastPath.h where they can be used by both
TextCodecUTF8 and TextCodecLatin1.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextCodecASCIIFastPath.h: Added. (WebCore::isAllASCII): (WebCore::copyASCIIMachineWord): (WebCore::isAlignedToMachineWord): (WebCore::alignToMachineWord):
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
- platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode):
- 09:52 Changeset [78579] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, rebaseline of Gtk result.
- platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
- 09:49 Changeset [78578] by
-
Fix Anders typo. false -> 0.
Reviewed by Anders Carlsson.
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::create):
- 09:45 Changeset [78577] by
-
[Chromium] Unreviewed text expectations fix
- 09:41 Changeset [78576] by
-
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement DOM agent tests.
https://bugs.webkit.org/show_bug.cgi?id=54459
- http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.expandedNodeWithId.callback): (initialize_ElementTest.InspectorTest.expandedNodeWithId): (initialize_ElementTest.InspectorTest.dumpElementsTree): (initialize_ElementTest.InspectorTest.dumpElementsTree.print): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
- http/tests/inspector/extensions-resources-redirect-expected.txt:
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (output): (clearOutput):
- inspector/debugger/dom-breakpoints.html:
- inspector/elements/elements-panel-limited-children-expected.txt:
- inspector/elements/elements-panel-rewrite-href.html:
- inspector/elements/elements-panel-structure-expected.txt:
- inspector/elements/elements-panel-structure.html:
- inspector/elements/elements-panel-xhtml-structure-expected.txt:
- inspector/elements/elements-panel-xhtml-structure.xhtml:
- inspector/elements/insert-node-collapsed-expected.txt: Added.
- inspector/elements/insert-node-collapsed.html: Added.
- inspector/elements/insert-node-expected.txt: Added.
- inspector/elements/insert-node.html: Added.
- inspector/elements/modify-chardata-expected.txt: Added.
- inspector/elements/modify-chardata.html: Added.
- inspector/elements/mutate-unknown-node-expected.txt: Added.
- inspector/elements/mutate-unknown-node.html: Added.
- inspector/elements/remove-node-expected.txt: Added.
- inspector/elements/remove-node.html: Added.
- inspector/elements/set-attribute.html: Added.
- inspector/extensions/extensions-expected.txt:
- 09:36 Changeset [78575] by
-
2011-02-15 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Kent Tamura.
Code style issue in WebCore/dom/InputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=54428
Remove 2 extra spaces in InputElement.cpp line 221.
Code style fix, No new tests.
- dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
- 09:30 Changeset [78574] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as passing.
Mark media/audio-delete-while-slider-thumb-clicked.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=54472
- 09:29 Changeset [78573] by
-
2011-02-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Remove some dead code in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=54461
- assembler/ARMv7Assembler.h: remove dead code.
- 09:28 Changeset [78572] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, test crashing because of failing ASSERT on GTK 64-bit debug bot.
[GTK] svg/text/select-textLength-spacing-squeeze-1.svg crashes due to ASSERT failing
https://bugs.webkit.org/show_bug.cgi?id=54470
- platform/gtk/Skipped: Skipped test.
- 08:59 Changeset [78571] by
-
2011-02-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] Video player sets system volume to 100%
https://bugs.webkit.org/show_bug.cgi?id=54140
Don't explicitely set volume at startup and use the
GstStreamVolume interface with cubic volume scale when
updating/retrieving the volume value. This gives a much better
user-experience.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- 08:48 Changeset [78570] by
-
2011-02-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Andreas Kling.
[Gtk] Cleanup in the canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54458
Unskip canvas tests that already pass.
- platform/gtk/Skipped:
- 08:47 Changeset [78569] by
-
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381
- http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html: Added.
- Test that we don't block scripts when the policy is just img-src.
- http/tests/security/contentSecurityPolicy/script-src-in-iframe.html:
- http/tests/security/contentSecurityPolicy/script-src-none.html:
- http/tests/security/contentSecurityPolicy/script-src-redirect.html:
- Turns out we need to escape the ; character in order for it to be echoed back correctly in the header.
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381
This patch provides a sketch of the script-src directive. We still do
not parse the value of the directive, and the wiring into the rest of
WebCore is incorrect, but those are things we can fix in future
patches. For the momemnt, this patch lets us test what we're doing.
Test: http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html
- page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::allows): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::emitDirective):
- page/ContentSecurityPolicy.h:
- 08:45 Changeset [78568] by
-
svg/custom/use-css-no-effect-on-shadow-tree.svg produces empty image on Chromium Linux after r58556
https://bugs.webkit.org/show_bug.cgi?id=54460
Reviewed by Andreas Kling.
Don't use fast path for SVG. There are some additional rules for shadow trees that are not
implemented on fast path.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
- 08:41 Changeset [78567] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK 64-bit debug bot.
editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995
- platform/gtk/Skipped: Skipped flaky test.
- 08:15 Changeset [78566] by
-
2011-02-15 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 1.
Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.
No new tests needed.
- CodeGenerators.pri: Copied from Source/WebCore/WebCore.pri. Don't add non-source generated files to SOURCES.
- DerivedSources.pro: Change WebCore.pri to CodeGenerators.pri.
- WebCore.pri: Move code generation rules to CodeGenerators.pri.
- WebCore.pro: Move common options to WebCore.pri.
2011-02-15 Andras Becsi <abecsi@webkit.org>
Reviewed by NOBODY Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 1.
Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.
- WebKit2.pro: Simplify and deduplicate includepaths.
- 08:14 Changeset [78565] by
-
2011-02-15 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Refactor the extend-selection tests to be clearer what they're doing
https://bugs.webkit.org/show_bug.cgi?id=54429
This is essentially a cleanup to extend-selection.js and propagation of those changes to the affected tests.
- editing/selection/extend-selection-character.html:
- editing/selection/extend-selection-enclosing-block.html:
- editing/selection/extend-selection-home-end.html:
- editing/selection/extend-selection-word.html:
- editing/selection/resources/extend-selection.js: (getSerializedSelection): (extendSelectionWithinBlock): (extendSelectionToEnd): (fold): (logMismatchingPositions): (extendAndLogSelection): (extendAndLogSelectionWithinBlock): (extendAndLogSelectionToEnd): (runSelectionTestsWithGranularity): (getTestNodeContainer): (createNode): (createCharAndWordNodes): (createEnclosingBlockNodes): (createHomeEndNodes): (createAllNodes): (.window.onload):
- 08:11 Changeset [78564] by
-
Merge 78561 - 2011-02-15 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219
Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().
- loader/FrameLoader.cpp:
- manual-tests/navigation-during-onload-triggered-by-back.html: Added.
- manual-tests/resources/navigation-during-onload-container.html: Added.
BUG=72458
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6524014
- 07:58 Changeset [78563] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as failing.
https://bugs.webkit.org/show_bug.cgi?id=54460
- 07:56 Changeset [78562] by
-
2011-02-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53247
Refactored the test to use the seeking event instead of timeupdate
and avoid flakyness.
- media/audio-delete-while-slider-thumb-clicked-expected.txt:
- media/audio-delete-while-slider-thumb-clicked.html:
- platform/gtk/Skipped:
- 07:55 Changeset [78561] by
-
2011-02-15 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219
Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().
- loader/FrameLoader.cpp:
- manual-tests/navigation-during-onload-triggered-by-back.html: Added.
- manual-tests/resources/navigation-during-onload-container.html: Added.
- 07:48 Changeset [78560] by
-
2011-02-15 Dirk Schulze <krit@webkit.org>
Unreviewed rebaseline.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
Rebaseline of Gtk result.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- 07:47 Changeset [78559] by
-
Unreviewed. Add myself to the list of committers.
- 07:28 Changeset [78558] by
-
2011-02-15 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287
No tests needed, exposes no new functionality
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading):
- loader/DocumentThreadableLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFinishLoading):
- loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::didFinishLoading):
- loader/cache/CachedResourceRequest.h:
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFinishLoading):
- loader/icon/IconLoader.h:
- 07:23 Changeset [78557] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Update test results for xmlhttprequest/cache-override.html after r78541.
- 07:13 Changeset [78556] by
-
Enable fast path selector checking for child and subselector combinators
https://bugs.webkit.org/show_bug.cgi?id=54360
Reviewed by Darin Adler.
- css/CSSStyleSelector.cpp:
(WebCore::isFastCheckableSelector):
(WebCore::fastCheckSingleSelector):
(WebCore::checkClassValue):
(WebCore::checkIdValue):
(WebCore::checkTagValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
- 07:06 Changeset [78555] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Add test results for animate-elem-31-t.svg after r78543, r78552.
- 06:50 Changeset [78554] by
-
2011-02-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console auto-scroll is broken when there are both scrollers.
https://bugs.webkit.org/show_bug.cgi?id=54273
- inspector/front-end/utilities.js: (Element.prototype.isScrolledToBottom): use clientHeight instead of offsetHeight to determine whether the element is scrolled to the bottom.
- 06:39 Changeset [78553] by
-
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
https://bugs.webkit.org/show_bug.cgi?id=53910
Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::drawNodeHighlight):
- 06:03 Changeset [78552] by
-
2011-02-15 Dirk Schulze <krit@webkit.org>
Rubber-stamped by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
Accidently replaced start value RegularPropertyValue for m_fromPropertyValueType
and m_toPropertyValueType by CurrentColorValue before landing. Check for property
value type 'inherit' on color validation was missing.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):
2011-02-15 Dirk Schulze <krit@webkit.org>
Rubber-stamped by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
We have support for 'inherit' in SVG animations now. This means the cyan circles
are invisible at the beginning.
The test itself is still broken, since calcMode gets handled incorrectly.
- platform/mac-wk2/Skipped:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- 05:35 Changeset [78551] by
-
Source/WebKit/gtk: * webkit/webkitwebsettings.cpp: Correct a typo, it is
acces*s*ibility with two s.
Rubber-stamped by Gustavo Noronha Silva.
Source/WebKit/gtk/po: * *.po: Correct a typo in acces*s*ibility.
Rubber-stamped by Gustavo Noronha Silva.
- 05:31 Changeset [78550] by
-
Windows build fix after r78533
- WebCore.vcproj/WebCore.vcproj: Fix bad XML syntax.
- 05:23 Changeset [78549] by
-
Unreviewed translation file.
Brazilian Portuguese Translation Update
https://bugs.webkit.org/show_bug.cgi?id=42833
- pt_BR.po: Updated.
- 05:09 Changeset [78548] by
-
2011-02-15 Gavin Peters <gavinp@chromium.org>
Reviewed by Antti Koivisto.
SharedBuffer::buffer() does not do what you think.
https://bugs.webkit.org/show_bug.cgi?id=54420
No new tests.
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
- platform/SharedBuffer.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
- 03:44 Changeset [78547] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, unskip passing test after r78541.
r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418
- platform/gtk/Skipped: Unskip passing test.
- 03:33 Changeset [78546] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, GTK baselines for 4 new tests added in r78396.
- platform/gtk/fast/inline/inline-box-background-expected.checksum: Added.
- platform/gtk/fast/inline/inline-box-background-expected.png: Added.
- platform/gtk/fast/inline/inline-box-background-expected.txt: Added.
- platform/gtk/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/gtk/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/gtk/fast/inline/inline-box-background-long-image-expected.txt: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
- 03:27 Changeset [78545] by
-
2011-02-15 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api).
https://bugs.webkit.org/show_bug.cgi?id=52271
- Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
- 03:26 Changeset [78544] by
-
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: update inspector expectation path for mac-leopard.
- platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/platform/mac-leopard/inspector/extensions-resources-expected.txt.
- 03:16 Changeset [78543] by
-
2011-02-15 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
Check support for 'inherit' and 'currentColor' on SVG animations.
- svg/animations/animate-currentColor-expected.txt: Added.
- svg/animations/animate-currentColor.html: Added.
- svg/animations/animate-inherit-css-property-expected.txt: Added.
- svg/animations/animate-inherit-css-property.html: Added.
- svg/animations/script-tests/animate-currentColor.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/animate-inherit-css-property.js: Added. (sample1): (sample2): (sample3): (executeTest):
2011-02-15 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines
if the attribute of the target element is an animatable CSS Property and computes the style during the
animation.
This fixes the following tests on the W3C test suite:
- animate-elem-84-t.svg
- animate-elem-85-t.svg
Tests: svg/animations/animate-currentColor.html
svg/animations/animate-inherit-css-property.html
- svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::adjustForInheritance): (WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor' during the animation, get the computed style of the property since the values could be animated themselves. (WebCore::inheritsFromProperty): (WebCore::attributeValueIsCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the string 'inherit' or 'currentColor' and if the attribute supports one of these values. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
- svg/SVGAnimateElement.h:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency.
- svg/SVGAnimationElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable.
- svg/SVGStyledElement.h:
- svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine if the target element is stylable and the attribute is an animatable CSS property. (WebCore::SMILTimeContainer::baseValueFor):
- 03:06 Changeset [78542] by
-
Reverting poor merge of http://trac.webkit.org/changeset/74261 that landed in M9 as http://trac.webkit.org/changeset/74265.
It resulted in the regression: Chrome 9 dev tools no longer lists resources pulled via XHR.
This has been approved by Anthony.
BUG=72834
Review URL: http://codereview.chromium.org/6528009
- 03:03 Changeset [78541] by
-
r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418
Reviewed by Andreas Kling.
Check for zero buffer length.
- platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
- 02:55 Changeset [78540] by
-
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector tests expectations update.
- platform/chromium/inspector/console/console-format-collections-expected.txt:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- 02:49 Changeset [78539] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Update image results for CSS tests on Mac Leopard.
- 02:35 Changeset [78538] by
-
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update after r78525
LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt
- 02:26 Changeset [78537] by
-
2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test timing out on SnowLeopard, GTK and Chromium bots.
r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418
- platform/gtk/Skipped: Skipped test.
- 02:22 Changeset [78536] by
-
Unreviewed.
[Qt]REGRESSION?(78477): inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html fail
https://bugs.webkit.org/show_bug.cgi?id=54442
- platform/qt/Skipped: inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html added until fix.
- 02:02 Changeset [78535] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move rest of the tests off old harness.
https://bugs.webkit.org/show_bug.cgi?id=54437
- http/tests/inspector-enabled/console-log-before-frame-navigation.html:
- http/tests/inspector/change-iframe-src-expected.txt:
- http/tests/inspector/change-iframe-src.html:
- http/tests/inspector/console-resource-errors.html:
- http/tests/inspector/console-websocket-error.html:
- http/tests/inspector/console-xhr-logging.html:
- http/tests/inspector/extensions-headers.html:
- http/tests/inspector/extensions-resources-redirect-expected.txt:
- http/tests/inspector/extensions-resources-redirect.html:
- http/tests/inspector/extensions-test.js:
- http/tests/inspector/inspect-iframe-from-different-domain-expected.txt:
- http/tests/inspector/inspect-iframe-from-different-domain.html:
- http/tests/inspector/inspector-test.js:
- http/tests/inspector/inspector-test2.js: Removed.
- http/tests/inspector/network-preflight-options.html:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters.html:
- http/tests/inspector/resources/extension-main.html:
- http/tests/inspector/resources/iframe-from-different-domain-data.html:
- inspector/audits/audits-panel-functional-expected.txt: Renamed from LayoutTests/inspector/audits-panel-functional-expected.txt.
- inspector/audits/audits-panel-functional.html: Renamed from LayoutTests/inspector/audits-panel-functional.html.
- inspector/audits/audits-test.js: Renamed from LayoutTests/inspector/audits-tests2.js.
- inspector/audits/resources/Ahem.ttf: Copied from LayoutTests/inspector/resources/Ahem.ttf.
- inspector/audits/resources/abe.png: Copied from LayoutTests/inspector/resources/abe.png.
- inspector/audits/resources/audits-script1.js: Renamed from LayoutTests/inspector/resources/audits-script1.js.
- inspector/audits/resources/audits-script2.js: Renamed from LayoutTests/inspector/resources/audits-script2.js.
- inspector/audits/resources/audits-style1.css: Copied from LayoutTests/inspector/resources/audits-style1.css.
- inspector/console/command-line-api-expected.txt: Renamed from LayoutTests/inspector/command-line-api-expected.txt.
- inspector/console/command-line-api.html: Renamed from LayoutTests/inspector/command-line-api.html.
- inspector/console/console-api-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/console-api-on-call-frame-expected.txt.
- inspector/console/console-api-on-call-frame.html: Renamed from LayoutTests/inspector/console-api-on-call-frame.html.
- inspector/console/console-assert-expected.txt: Renamed from LayoutTests/inspector/console-assert-expected.txt.
- inspector/console/console-assert.html: Renamed from LayoutTests/inspector/console-assert.html.
- inspector/console/console-clear-expected.txt: Renamed from LayoutTests/inspector/console-clear-expected.txt.
- inspector/console/console-clear.html: Renamed from LayoutTests/inspector/console-clear.html.
- inspector/console/console-command-clear-expected.txt: Renamed from LayoutTests/inspector/console-command-clear-expected.txt.
- inspector/console/console-command-clear.html: Renamed from LayoutTests/inspector/console-command-clear.html.
- inspector/console/console-dir-expected.txt: Renamed from LayoutTests/inspector/console-dir-expected.txt.
- inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/inspector/console-dir-global-expected.txt.
- inspector/console/console-dir-global.html: Renamed from LayoutTests/inspector/console-dir-global.html.
- inspector/console/console-dir.html: Renamed from LayoutTests/inspector/console-dir.html.
- inspector/console/console-dirxml-expected.txt: Renamed from LayoutTests/inspector/console-dirxml-expected.txt.
- inspector/console/console-dirxml.html: Renamed from LayoutTests/inspector/console-dirxml.html.
- inspector/console/console-eval-expected.txt: Renamed from LayoutTests/inspector/console-eval-expected.txt.
- inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/inspector/console-eval-global-expected.txt.
- inspector/console/console-eval-global.html: Renamed from LayoutTests/inspector/console-eval-global.html.
- inspector/console/console-eval.html: Renamed from LayoutTests/inspector/console-eval.html.
- inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/inspector/console-format-collections-expected.txt.
- inspector/console/console-format-collections.html: Renamed from LayoutTests/inspector/console-format-collections.html.
- inspector/console/console-format-expected.txt: Renamed from LayoutTests/inspector/console-format-expected.txt.
- inspector/console/console-format.html: Renamed from LayoutTests/inspector/console-format.html.
- inspector/console/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- inspector/console/console-log-before-inspector-open.html: Renamed from LayoutTests/inspector/console-log-before-inspector-open.html.
- inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/inspector/console-log-native-funcs-expected.txt.
- inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/inspector/console-log-syntax-error-expected.txt.
- inspector/console/console-log-syntax-error.html: Renamed from LayoutTests/inspector/console-log-syntax-error.html.
- inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/inspector/console-object-constructor-name-expected.txt.
- inspector/console/console-object-constructor-name.html: Renamed from LayoutTests/inspector/console-object-constructor-name.html.
- inspector/console/console-substituted-expected.txt: Renamed from LayoutTests/inspector/console-substituted-expected.txt.
- inspector/console/console-substituted.html: Renamed from LayoutTests/inspector/console-substituted.html.
- inspector/console/console-tests-expected.txt: Renamed from LayoutTests/inspector/console-tests-expected.txt.
- inspector/console/console-tests.html: Renamed from LayoutTests/inspector/console-tests.html.
- inspector/console/console-trace-expected.txt: Renamed from LayoutTests/inspector/console-trace-expected.txt.
- inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-trace-in-eval-expected.txt.
- inspector/console/console-trace-in-eval.html: Renamed from LayoutTests/inspector/console-trace-in-eval.html.
- inspector/console/console-trace.html: Renamed from LayoutTests/inspector/console-trace.html.
- inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
- inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval-expected.txt.
- inspector/console/console-uncaught-exception-in-eval.html: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval.html.
- inspector/console/console-uncaught-exception.html: Renamed from LayoutTests/inspector/console-uncaught-exception.html.
- inspector/console/resources/syntax-error.js: Copied from LayoutTests/inspector/resources/syntax-error.js.
- inspector/cookie-parser.html:
- inspector/cookie-resource-match.html:
- inspector/cpu-profiler-profiling.html:
- inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
- inspector/debugger/debugger-autocontinue-on-syntax-error.html: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html.
- inspector/debugger/debugger-breakpoints-not-activated-on-reload-expected.txt: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload-expected.txt.
- inspector/debugger/debugger-breakpoints-not-activated-on-reload.html: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html.
- inspector/debugger/debugger-cyclic-ref-expected.txt: Renamed from LayoutTests/inspector/debugger-cyclic-ref-expected.txt.
- inspector/debugger/debugger-cyclic-ref.html: Renamed from LayoutTests/inspector/debugger-cyclic-ref.html.
- inspector/debugger/debugger-eval-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame-expected.txt.
- inspector/debugger/debugger-eval-on-call-frame.html: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame.html.
- inspector/debugger/debugger-eval-while-paused-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-while-paused-expected.txt.
- inspector/debugger/debugger-eval-while-paused.html: Renamed from LayoutTests/inspector/debugger-eval-while-paused.html.
- inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/inspector/debugger-expand-scope-expected.txt.
- inspector/debugger/debugger-expand-scope.html: Renamed from LayoutTests/inspector/debugger-expand-scope.html.
- inspector/debugger/debugger-no-nested-pause-expected.txt: Renamed from LayoutTests/inspector/debugger-no-nested-pause-expected.txt.
- inspector/debugger/debugger-no-nested-pause.html: Renamed from LayoutTests/inspector/debugger-no-nested-pause.html.
- inspector/debugger/debugger-pause-in-eval-script-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script-expected.txt.
- inspector/debugger/debugger-pause-in-eval-script.html: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script.html.
- inspector/debugger/debugger-pause-on-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint-expected.txt.
- inspector/debugger/debugger-pause-on-breakpoint.html: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint.html.
- inspector/debugger/debugger-pause-on-debugger-statement-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement-expected.txt.
- inspector/debugger/debugger-pause-on-debugger-statement.html: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement.html.
- inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-exception-expected.txt.
- inspector/debugger/debugger-pause-on-exception.html: Renamed from LayoutTests/inspector/debugger-pause-on-exception.html.
- inspector/debugger/debugger-proto-property-expected.txt: Renamed from LayoutTests/inspector/debugger-proto-property-expected.txt.
- inspector/debugger/debugger-proto-property.html: Renamed from LayoutTests/inspector/debugger-proto-property.html.
- inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/inspector/debugger-scripts-expected.txt.
- inspector/debugger/debugger-scripts.html: Renamed from LayoutTests/inspector/debugger-scripts.html.
- inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/inspector/debugger-step-in-expected.txt.
- inspector/debugger/debugger-step-in.html: Renamed from LayoutTests/inspector/debugger-step-in.html.
- inspector/debugger/debugger-step-out-expected.txt: Renamed from LayoutTests/inspector/debugger-step-out-expected.txt.
- inspector/debugger/debugger-step-out.html: Renamed from LayoutTests/inspector/debugger-step-out.html.
- inspector/debugger/debugger-step-over-expected.txt: Renamed from LayoutTests/inspector/debugger-step-over-expected.txt.
- inspector/debugger/debugger-step-over.html: Renamed from LayoutTests/inspector/debugger-step-over.html.
- inspector/debugger/debugger-suspend-active-dom-objects-expected.txt: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt.
- inspector/debugger/debugger-suspend-active-dom-objects.html: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects.html.
- inspector/debugger/dom-breakpoints-expected.txt: Renamed from LayoutTests/inspector/dom-breakpoints-expected.txt.
- inspector/debugger/dom-breakpoints.html: Renamed from LayoutTests/inspector/dom-breakpoints.html.
- inspector/debugger/resources/syntax-error.js: Renamed from LayoutTests/inspector/resources/syntax-error.js.
- inspector/elements/elements-delete-inline-style-expected.txt: Renamed from LayoutTests/inspector/elements-delete-inline-style-expected.txt.
- inspector/elements/elements-delete-inline-style.html: Renamed from LayoutTests/inspector/elements-delete-inline-style.html.
- inspector/elements/elements-img-tooltip-expected.txt: Renamed from LayoutTests/inspector/elements-img-tooltip-expected.txt.
- inspector/elements/elements-img-tooltip.html: Renamed from LayoutTests/inspector/elements-img-tooltip.html.
- inspector/elements/elements-panel-limited-children-expected.txt: Renamed from LayoutTests/inspector/elements-panel-limited-children-expected.txt.
- inspector/elements/elements-panel-limited-children.html: Renamed from LayoutTests/inspector/elements-panel-limited-children.html.
- inspector/elements/elements-panel-rewrite-href-expected.txt: Renamed from LayoutTests/inspector/elements-panel-rewrite-href-expected.txt.
- inspector/elements/elements-panel-rewrite-href.html: Renamed from LayoutTests/inspector/elements-panel-rewrite-href.html.
- inspector/elements/elements-panel-search-expected.txt: Renamed from LayoutTests/inspector/elements-panel-search-expected.txt.
- inspector/elements/elements-panel-search.html: Renamed from LayoutTests/inspector/elements-panel-search.html.
- inspector/elements/elements-panel-selection-on-refresh-expected.txt: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh-expected.txt.
- inspector/elements/elements-panel-selection-on-refresh.html: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh.html.
- inspector/elements/elements-panel-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-structure-expected.txt.
- inspector/elements/elements-panel-structure.html: Renamed from LayoutTests/inspector/elements-panel-structure.html.
- inspector/elements/elements-panel-styles-expected.txt: Renamed from LayoutTests/inspector/elements-panel-styles-expected.txt.
- inspector/elements/elements-panel-styles.html: Renamed from LayoutTests/inspector/elements-panel-styles.html.
- inspector/elements/elements-panel-xhtml-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt.
- inspector/elements/elements-panel-xhtml-structure.xhtml: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure.xhtml.
- inspector/elements/resources/elements-panel-styles.css: Renamed from LayoutTests/inspector/resources/elements-panel-styles.css.
- inspector/evaluate-in-page.html:
- inspector/extensions/extensions-api-expected.txt: Renamed from LayoutTests/inspector/extensions-api-expected.txt.
- inspector/extensions/extensions-api.html: Renamed from LayoutTests/inspector/extensions-api.html.
- inspector/extensions/extensions-audits-api-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-api-expected.txt.
- inspector/extensions/extensions-audits-api.html: Renamed from LayoutTests/inspector/extensions-audits-api.html.
- inspector/extensions/extensions-audits-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-expected.txt.
- inspector/extensions/extensions-audits-tests.js: Renamed from LayoutTests/inspector/extensions-audits-tests.js.
- inspector/extensions/extensions-audits.html: Renamed from LayoutTests/inspector/extensions-audits.html.
- inspector/extensions/extensions-eval-expected.txt: Renamed from LayoutTests/inspector/extensions-eval-expected.txt.
- inspector/extensions/extensions-eval.html: Renamed from LayoutTests/inspector/extensions-eval.html.
- inspector/extensions/extensions-events-expected.txt: Renamed from LayoutTests/inspector/extensions-events-expected.txt.
- inspector/extensions/extensions-events.html: Renamed from LayoutTests/inspector/extensions-events.html.
- inspector/extensions/extensions-expected.txt: Renamed from LayoutTests/inspector/extensions-expected.txt.
- inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/inspector/extensions-resources-expected.txt.
- inspector/extensions/extensions-resources.html: Renamed from LayoutTests/inspector/extensions-resources.html.
- inspector/extensions/extensions.html: Renamed from LayoutTests/inspector/extensions.html.
- inspector/extensions/resources/Ahem.ttf: Renamed from LayoutTests/inspector/resources/Ahem.ttf.
- inspector/extensions/resources/abe.png: Renamed from LayoutTests/inspector/resources/abe.png.
- inspector/extensions/resources/audits-style1.css: Renamed from LayoutTests/inspector/resources/audits-style1.css.
- inspector/inspected-objects-not-overriden.html:
- inspector/report-API-errors.html:
- inspector/report-protocol-errors.html:
- inspector/storage-panel-dom-storage.html:
- inspector/styles/resources/styles-iframe-data.html: Renamed from LayoutTests/inspector/resources/styles-iframe-data.html.
- inspector/styles/resources/styles-new-API-1.css: Renamed from LayoutTests/inspector/resources/styles-new-API-1.css.
- inspector/styles/resources/styles-new-API.css: Renamed from LayoutTests/inspector/resources/styles-new-API.css.
- inspector/styles/resources/styles-source-lines-inline-iframe.html: Renamed from LayoutTests/inspector/resources/styles-source-lines-inline-iframe.html.
- inspector/styles/resources/styles-source-offsets.css: Renamed from LayoutTests/inspector/resources/styles-source-offsets.css.
- inspector/styles/resources/styles-url-linkify-iframe.html: Renamed from LayoutTests/inspector/resources/styles-url-linkify-iframe.html.
- inspector/styles/resources/styles-url-linkify.css: Renamed from LayoutTests/inspector/resources/styles-url-linkify.css.
- inspector/styles/styles-add-blank-property-expected.txt: Renamed from LayoutTests/inspector/styles-add-blank-property-expected.txt.
- inspector/styles/styles-add-blank-property.html: Renamed from LayoutTests/inspector/styles-add-blank-property.html.
- inspector/styles/styles-computed-trace-expected.txt: Renamed from LayoutTests/inspector/styles-computed-trace-expected.txt.
- inspector/styles/styles-computed-trace.html: Renamed from LayoutTests/inspector/styles-computed-trace.html.
- inspector/styles/styles-disable-inherited-expected.txt: Renamed from LayoutTests/inspector/styles-disable-inherited-expected.txt.
- inspector/styles/styles-disable-inherited.html: Renamed from LayoutTests/inspector/styles-disable-inherited.html.
- inspector/styles/styles-disable-then-change-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-change-expected.txt.
- inspector/styles/styles-disable-then-change.html: Renamed from LayoutTests/inspector/styles-disable-then-change.html.
- inspector/styles/styles-disable-then-delete-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-delete-expected.txt.
- inspector/styles/styles-disable-then-delete.html: Renamed from LayoutTests/inspector/styles-disable-then-delete.html.
- inspector/styles/styles-disable-then-enable-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-enable-expected.txt.
- inspector/styles/styles-disable-then-enable.html: Renamed from LayoutTests/inspector/styles-disable-then-enable.html.
- inspector/styles/styles-iframe-expected.txt: Renamed from LayoutTests/inspector/styles-iframe-expected.txt.
- inspector/styles/styles-iframe.html: Renamed from LayoutTests/inspector/styles-iframe.html.
- inspector/styles/styles-new-API-expected.txt: Renamed from LayoutTests/inspector/styles-new-API-expected.txt.
- inspector/styles/styles-new-API.html: Renamed from LayoutTests/inspector/styles-new-API.html.
- inspector/styles/styles-source-lines-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-expected.txt.
- inspector/styles/styles-source-lines-inline-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-inline-expected.txt.
- inspector/styles/styles-source-lines-inline.html: Renamed from LayoutTests/inspector/styles-source-lines-inline.html.
- inspector/styles/styles-source-lines.html: Renamed from LayoutTests/inspector/styles-source-lines.html.
- inspector/styles/styles-source-offsets-expected.txt: Renamed from LayoutTests/inspector/styles-source-offsets-expected.txt.
- inspector/styles/styles-source-offsets.html: Renamed from LayoutTests/inspector/styles-source-offsets.html.
- inspector/styles/styles-url-linkify-expected.txt: Renamed from LayoutTests/inspector/styles-url-linkify-expected.txt.
- inspector/styles/styles-url-linkify.html: Renamed from LayoutTests/inspector/styles-url-linkify.html.
- inspector/syntax-highlight-css.html:
- inspector/syntax-highlight-html.html:
- inspector/syntax-highlight-javascript.html:
- inspector/timeline/resources/timeline-iframe-data.html: Renamed from LayoutTests/inspector/resources/timeline-iframe-data.html.
- inspector/timeline/timeline-enum-stability-expected.txt: Renamed from LayoutTests/inspector/timeline-enum-stability-expected.txt.
- inspector/timeline/timeline-enum-stability.html: Renamed from LayoutTests/inspector/timeline-enum-stability.html.
- inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/inspector/timeline-event-dispatch-expected.txt.
- inspector/timeline/timeline-event-dispatch.html: Renamed from LayoutTests/inspector/timeline-event-dispatch.html.
- inspector/timeline/timeline-layout-expected.txt: Renamed from LayoutTests/inspector/timeline-layout-expected.txt.
- inspector/timeline/timeline-layout.html: Renamed from LayoutTests/inspector/timeline-layout.html.
- inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/inspector/timeline-mark-timeline-expected.txt.
- inspector/timeline/timeline-mark-timeline.html: Renamed from LayoutTests/inspector/timeline-mark-timeline.html.
- inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/inspector/timeline-network-resource-expected.txt.
- inspector/timeline/timeline-network-resource.html: Renamed from LayoutTests/inspector/timeline-network-resource.html.
- inspector/timeline/timeline-network-resource.js: Renamed from LayoutTests/inspector/timeline-network-resource.js.
- inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/inspector/timeline-paint-expected.txt.
- inspector/timeline/timeline-paint.html: Renamed from LayoutTests/inspector/timeline-paint.html.
- inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/inspector/timeline-parse-html-expected.txt.
- inspector/timeline/timeline-parse-html.html: Renamed from LayoutTests/inspector/timeline-parse-html.html.
- inspector/timeline/timeline-recalculate-styles-expected.txt: Renamed from LayoutTests/inspector/timeline-recalculate-styles-expected.txt.
- inspector/timeline/timeline-recalculate-styles.html: Renamed from LayoutTests/inspector/timeline-recalculate-styles.html.
- inspector/timeline/timeline-script-tag-1-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-1-expected.txt.
- inspector/timeline/timeline-script-tag-1.html: Renamed from LayoutTests/inspector/timeline-script-tag-1.html.
- inspector/timeline/timeline-script-tag-2-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-2-expected.txt.
- inspector/timeline/timeline-script-tag-2.html: Renamed from LayoutTests/inspector/timeline-script-tag-2.html.
- inspector/timeline/timeline-script-tag-2.js: Renamed from LayoutTests/inspector/timeline-script-tag-2.js.
- inspector/timeline/timeline-test.js: Renamed from LayoutTests/inspector/timeline-test.js.
- inspector/timeline/timeline-trivial-expected.txt: Renamed from LayoutTests/inspector/timeline-trivial-expected.txt.
- inspector/timeline/timeline-trivial.html: Renamed from LayoutTests/inspector/timeline-trivial.html.
- platform/chromium/inspector/console/console-dir-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-expected.txt.
- platform/chromium/inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-global-expected.txt.
- platform/chromium/inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-eval-global-expected.txt.
- platform/chromium/inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-collections-expected.txt.
- platform/chromium/inspector/console/console-format-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-expected.txt.
- platform/chromium/inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-native-funcs-expected.txt.
- platform/chromium/inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-syntax-error-expected.txt.
- platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-object-constructor-name-expected.txt.
- platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-trace-in-eval-expected.txt.
- platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-expected.txt.
- platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt.
- platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
- platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-expand-scope-expected.txt.
- platform/chromium/inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-pause-on-exception-expected.txt.
- platform/chromium/inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-step-in-expected.txt.
- platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-event-dispatch-expected.txt.
- platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-mark-timeline-expected.txt.
- platform/chromium/inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-network-resource-expected.txt.
- platform/chromium/inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-paint-expected.txt.
- platform/chromium/inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-parse-html-expected.txt.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 01:57 Changeset [78534] by
-
2011-02-15 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
- page/EditorClient.h: Changed GrammarDetail forward declaration from class to struct.
- 00:28 Changeset [78533] by
-
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
Created new abstract class TextCheckerClient. The class has
spellcheck related API which is split.
This is the first step for sharing spell-checking codebase
between ports. A standalone TextCheckerClient implementation
should be done in future changes.
No new tests. No behavioral change.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling):
- editing/Editor.cpp: Replacing some client() call with textChecker(). (WebCore::Editor::textChecker): Added. (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired):
- editing/Editor.h:
- editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker):
- editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker(). (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
- loader/EmptyClients.h: Added EmptyTextCheckerClient. (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument): (WebCore::EmptyTextCheckerClient::learnWord): (WebCore::EmptyTextCheckerClient::checkSpellingOfString): (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord): (WebCore::EmptyTextCheckerClient::checkGrammarOfString): (WebCore::EmptyTextCheckerClient::checkTextOfParagraph): (WebCore::EmptyTextCheckerClient::getGuessesForWord): (WebCore::EmptyTextCheckerClient::requestCheckingOfString): (WebCore::EmptyEditorClient::textChecker):
- page/EditorClient.h: Extracted TextCheckerClient.
- page/Page.h:
- platform/text/TextCheckerClient.h: Added. (WebCore::TextCheckerClient::~TextCheckerClient):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- src/EditorClientImpl.h: (WebKit::EditorClientImpl::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/WebEditorClient.h: (WebEditorClient::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/WebEditorClient.h: (WebEditorClient::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClientWinCE::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::textChecker):
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
- Shared/WebCoreArgumentCoders.h:
- UIProcess/TextChecker.h:
- WebProcess/WebCoreSupport/WebEditorClient.h: (WebKit::WebEditorClient::textChecker):
- Scripts/webkit2/messages.py: Re-arranged the include file
- 00:21 Changeset [78532] by
-
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): Added. (WebKit::EditorClientImpl::canPaste): Added.
- src/EditorClientImpl.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): Added. (WebCore::EditorClientQt::canPaste): Added.
- WebCoreSupport/EditorClientQt.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::canCopyCut): Added. (WebKit::EditorClient::canPaste): Added.
- WebCoreSupport/EditorClientGtk.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::canCopyCut): Added. (WebEditorClient::canPaste): Added.
- WebCoreSupport/WebEditorClient.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::canCopyCut): Added. (WebCore::EditorClientWx::canPaste): Added.
- WebKitSupport/EditorClientWx.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::canCopyCut): Added. (WebEditorClient::canPaste): Added.
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::canCopyCut): Added. (WebCore::EditorClientHaiku::canPaste): Added.
- WebCoreSupport/EditorClientHaiku.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::canCopyCut): Added. (WebKit::EditorClientWinCE::canPaste): Added.
- WebCoreSupport/EditorClientWinCE.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::canCopyCut): Added. (WebCore::EditorClientEfl::canPaste): Added.
- WebCoreSupport/EditorClientEfl.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. These functions
returns true iff the current frame should be able to copy/cut and paste respectively.
They take the default value determined by isDOMPasteAllowed and javaScriptCanAccessClipboard.
These callbacks allows embedders to decide whether or not copy/cut/paste should be enabled
per frame and thus per origin rather than per page.
No new tests are added since this is a WebKit/WebCore interface change.
- editing/EditorCommand.cpp: (WebCore::supportedCopyCut): Calls canCopyCut. (WebCore::supportedPaste): Calls canPaste.
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::canCopyCut): Added. (WebCore::EmptyEditorClient::canPaste): Added.
- page/EditorClient.h:
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::canCopyCut): Added. (WebKit::WebEditorClient::canPaste): Added.
- WebProcess/WebCoreSupport/WebEditorClient.h:
02/14/11:
- 21:53 Changeset [78531] by
-
2011-02-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
allow for modifying comments without the mouse
https://bugs.webkit.org/show_bug.cgi?id=54433
Use n/p to navigate the comments.
Enter to begin editing a comment.
Escape to finish editing a comment.
- code-review.js:
- 21:46 Changeset [78530] by
-
2011-02-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
improve line selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54430
-shift+click now extends the comment context
-selecting outside of a diff section no longer clears the selected lines.
Instead it just restricts the selected lines to that diff section.
- code-review.js:
- 19:04 WebKit Team edited by
- Add myself to committers list (diff)
- 18:30 Changeset [78529] by
-
Roll out r74807 (in the 648 branch only).
BUG=68516
TBR=kerz@chromium.org
- 18:23 Changeset [78528] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix minor regression introduced in r78522. For some reason, Python
provides a platform.mac_ver() routine on Linux, so we need to
check to make sure it's returning something in addition to
checking for its existence.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 17:49 Changeset [78527] by
-
2011-02-14 Jeremy Orlow <jorlow@chromium.org>
efl build fix
- CMakeLists.txt:
- 17:38 Changeset [78526] by
-
2011-02-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add WKPageSetMemoryCacheClientCallsEnabled API
https://bugs.webkit.org/show_bug.cgi?id=54422
- UIProcess/API/C/WKPage.cpp: (WKPageSetMemoryCacheClientCallsEnabled):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setMemoryCacheMessagesEnabled):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 17:18 Changeset [78525] by
-
2011-02-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331
Make the requried changes + s/result/request/g (where it should
have always been that way) + remove the verify functions (since
these days they mostly just add noise) + get rid of the callback
in the delete object store funciton.
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/create-and-remove-object-store.html:
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/create-object-store-options.html:
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/cursor-delete.html:
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-index-delete.html:
- storage/indexeddb/cursor-skip-deleted-expected.txt:
- storage/indexeddb/cursor-skip-deleted.html:
- storage/indexeddb/cursor-update-expected.txt:
- storage/indexeddb/cursor-update.html:
- storage/indexeddb/data-corruption-expected.txt:
- storage/indexeddb/data-corruption.html:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/duplicates.html:
- storage/indexeddb/error-causes-abort-by-default-expected.txt:
- storage/indexeddb/error-causes-abort-by-default.html:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/queued-commands-expected.txt:
- storage/indexeddb/queued-commands.html:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-event-propagation.html:
- storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (evalAndExpectException): (deleteAllObjectStores):
- storage/indexeddb/transaction-after-close-expected.txt:
- storage/indexeddb/transaction-after-close.html:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
- storage/indexeddb/transaction-crash-on-abort-expected.txt:
- storage/indexeddb/transaction-crash-on-abort.html:
- storage/indexeddb/transaction-event-propagation-expected.txt:
- storage/indexeddb/transaction-event-propagation.html:
- storage/indexeddb/transaction-read-only-expected.txt:
- storage/indexeddb/transaction-read-only.html:
- storage/indexeddb/tutorial.html:
2011-02-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331
We shouldn't have our own event subclasses. Instead, we
should just fire Event's with the proper type and bubble
settings. All the attributes on the events before should
just be on the request. IDBRequest should throw if they're
accessed before the success event fires.
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
- dom/Event.cpp:
- dom/Event.h:
- page/DOMWindow.idl:
- storage/IDBAbortEvent.h: Removed.
- storage/IDBCompleteEvent.cpp: Removed.
- storage/IDBCompleteEvent.h: Removed.
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::~IDBDatabase):
- storage/IDBDatabaseException.h:
- storage/IDBDatabaseException.idl:
- storage/IDBErrorEvent.cpp: Removed.
- storage/IDBErrorEvent.h: Removed.
- storage/IDBErrorEvent.idl: Removed.
- storage/IDBEvent.h: Removed.
- storage/IDBEvent.idl: Removed.
- storage/IDBEventDispatcher.cpp: (WebCore::IDBEventDispatcher::dispatch):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::result): (WebCore::IDBRequest::errorCode): (WebCore::IDBRequest::webkitErrorMessage): (WebCore::IDBRequest::source): (WebCore::IDBRequest::transaction): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::createSuccessEvent): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
- storage/IDBRequest.h:
- storage/IDBRequest.idl:
- storage/IDBSuccessEvent.cpp: Removed.
- storage/IDBSuccessEvent.h: Removed.
- storage/IDBSuccessEvent.idl: Removed.
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::dispatchEvent):
- 17:14 Changeset [78524] by
-
Unreviewed. Add myself to the list of committers.
- 16:03 Changeset [78523] by
-
WebKit2: View not updated completely when coming back from a cached back/forward navigation
<rdar://problem/8787264>
https://bugs.webkit.org/show_bug.cgi?id=54419
Reviewed by Anders Carlsson.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState): Invalidate the entire page
when completing a restore from the back/forward cache.
- 16:03 Changeset [78522] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
Clean up the way we handle platform names in
new-run-webkit-tests. Previously, if you specified
'--platform mac' or '--platform chromium-mac' on the command
line, it would use that platform name to determine baseline search
paths, etc. This is almost never the right thing to do, because
it ignores the existence of version-specific baselines.
So, I changed this so that ports that support versions must
always use a version, and the version should default to the
version of the operating system that the port is being run on
(e.g., if you're running on Leopard, then passing '--platform
mac' will default to the 'mac-leopard' port). This means that
port.name() should always include a version-specific suffix if
the port supports versions.
However, we still support things like '--platform mac' as input
so that the user doesn't have to explicitly specify a version,
both for convenience and so we don't have to make buildbot
configs more complicated than they already are.
Also, I cleaned up how the baselines were being searched
on the chromium-mac port (this is one of the two bugs that
prompted this refactoring), and made the logic easier to follow
and more consistent across the mac and chromium ports
Lastly, I added a port.get_all_names() method that could be used
to get the names of all of the ports to search, rather than having
to guess (incorrectly) from the list of directories under
LayoutTests/platform (this last thing was necessary because the
deduplicate_tests unittest broke as the fallback dirs changed).
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- 16:01 Changeset [78521] by
-
Unreviewed, Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=54418
Fix a Linux expectation, mark another test as expected-failing.
- platform/chromium/test_expectations.txt:
- 15:59 Changeset [78520] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
update-webkit hangs in a git-only checkout
Previously it would hang forever trying to do a 'git svn
rebase'. Now, it will default to a 'git pull' if the
svn-remote.svn.fetch variable isn't set, and bail out if it
doesn't know where to pull from.
- Scripts/update-webkit:
- Scripts/VCSUtils.pm:
- 15:51 Changeset [78519] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] testwebdatasource test fails in the bots
https://bugs.webkit.org/show_bug.cgi?id=54414
Changed the uri we check, added www to avoid the rewrite that we
get when we as the uri to the request in case it finishes.
- tests/testwebdatasource.c: (notify_load_status_cb):
- 15:46 Changeset [78518] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r78516.
http://trac.webkit.org/changeset/78516
The rebaseline was previously done
- platform/gtk/fast/css/rtl-ordering-expected.checksum:
- platform/gtk/fast/css/rtl-ordering-expected.png:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
- platform/gtk/fast/forms/select-visual-hebrew-expected.png:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
- 15:35 Changeset [78517] by
-
Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
https://bugs.webkit.org/show_bug.cgi?id=54416
Reviewed by Dan Bernstein.
We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.
- 15:29 Changeset [78516] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed. Rebaseline GTK test results after r78491.
- platform/gtk/fast/css/rtl-ordering-expected.checksum:
- platform/gtk/fast/css/rtl-ordering-expected.png:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
- platform/gtk/fast/forms/select-visual-hebrew-expected.png:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
- 15:15 Changeset [78515] by
-
2011-02-14 Levi Weintraub <leviw@chromium.org>
Reviewed by Alexey Proskuryakov.
Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475
Changing the behavior of the strikethrough execCommand when styleWithCSS
is false. We formerly created <s> tags, which was different than both IE
and FF and caused problems with some rich text editors that would strip
out unexpected tags such as <s>.
Test: editing/execCommand/strikethrough-uses-strike-tag.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2011-02-14 Levi Weintraub <leviw@chromium.org>
Reviewed by Alexey Proskuryakov.
Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475
Updating test expectations and creating a test in an attempt to prevent the
uninformed WebKit dev from switching back to using <s> tags for strikethrough.
As explained in the bug, this is bad for compatibility with various rich text
editors.
- editing/execCommand/query-text-decoration-with-typing-style-expected.txt:
- editing/execCommand/script-tests/strikethrough-uses-strike-tag.js: Added. (test):
- editing/execCommand/script-tests/toggle-style-2.js:
- editing/execCommand/strikethrough-uses-strike-tag-expected.txt: Added.
- editing/execCommand/strikethrough-uses-strike-tag.html: Added.
- editing/execCommand/strikethroughSelection-expected.txt:
- editing/execCommand/toggle-style-2-expected.txt:
- editing/style/inline-style-container-expected.txt:
- editing/style/inline-style-extend-run-expected.txt:
- editing/style/push-down-implicit-styles-around-list-expected.txt:
- editing/style/push-down-implicit-styles-expected.txt:
- editing/style/script-tests/inline-style-container.js:
- editing/style/script-tests/inline-style-extend-run.js:
- editing/style/script-tests/push-down-implicit-styles-around-list.js:
- editing/style/script-tests/push-down-implicit-styles.js:
- editing/style/style-text-node-without-editable-parent-expected.txt:
- 15:02 Changeset [78514] by
-
Build fix. Unreviewed.
- 15:01 Changeset [78513] by
-
2011-02-14 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Shared memory should be made shared immediately
https://bugs.webkit.org/show_bug.cgi?id=54413
<rdar://problem/8972153>
Under some circumstances, mach_make_memory_entry_64 may only return parts of a
memory allocation. Work around this by creating a mach port representing the shared memory
right away. Also, hand out this mach port in createHandle when using the default memory protection.
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
- 14:58 Changeset [78512] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
This patch modifies NRWT's Worker clas to use the new
WorkerMixin class to actually run tests. With this patch, the
multiprocess version of NRWT is fully functional and just needs
the values for --worker-model and --child-processes to be corrected
in the port/* classes to start using the new code by default.
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 14:56 Changeset [78511] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
This patch shuffles code out of dump_render_tree_thread and
single_test_runner and into a new worker_mixin class that will
be shared by both TestShellThread and Worker. This change
restores single_test_runner to its state as of r77606 - it is
stateless again. It also prunes TestShellThread to pretty much
just the logic used for the original shared-memory access.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.
- 14:56 Changeset [78510] by
-
Unreviewed, Chromium test expectations update.
Try using the right syntax this time.
- platform/chromium/test_expectations.txt:
- 14:26 Changeset [78509] by
-
Unreviewed, Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 14:20 Changeset [78508] by
-
Remove dead code in FormDataStreamCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54401
Reviewed by Darin Adler.
The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.
- platform/network/cf/FormDataStreamCFNet.cpp:
- 14:15 Changeset [78507] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
This patch updates NRWT to add per-worker and per-shard test stats
into TestRunner2, bringing it to parity with TestRunner.
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- 14:13 Changeset [78506] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt multiprocessing: add code to handle interrupts and wedged
threads.
https://bugs.webkit.org/show_bug.cgi?id=54072
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Adds the cancel(), is_alive(), join(), and log_wedged_worker() methods to the WorkerConnection class
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py: Adds the cancel() method to the Worker class
- 14:08 Changeset [78505] by
-
Merge 78431 - Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262
Reviewed by Dan Bernstein.
Make sure that all calls to the scrollable area are null checked.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
TBR=weinig@apple.com
Review URL: http://codereview.chromium.org/6523001
- 13:55 Changeset [78504] by
-
Unreviewed, Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=54409
Mark tests as failing due to r78484.
- platform/chromium/test_expectations.txt:
- 13:54 Changeset [78503] by
-
2011-02-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
GraphicsContext: Add clip(IntRect) overload for Qt
https://bugs.webkit.org/show_bug.cgi?id=54365
Qt has special code paths for clipping to integer rectangles.
Add a GraphicsContext::clip() overload to allow us to take
advantage of the optimized code.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clip):
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
- 13:48 Changeset [78502] by
-
2011-02-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
update the NRWT multiprocessing code to spawn multiple workers
instead of just using one.
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- 13:44 QtWebKit edited by
- (diff)
- 13:29 Changeset [78501] by
-
Some MarkedBlock refactoring.
Rubber-stamped by Gavin Barraclough.
Made cells private.
Renamed cells => m_cells
marked => m_marks.
- runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate):
- runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
- runtime/MarkedBlock.h:
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach):
- 13:28 Webkit2Innards edited by
- (diff)
- 13:27 Changeset [78500] by
-
2011-02-14 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r78491. Since select-visual-hebrew.html and visual-hebrew-text-field.html
are marked as FAIL in Chromium WIN and LINUX, rebaseline for them are done manually and
only changed the part related to r78491.
- platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
- platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
- platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/chromium-win/fast/css/rtl-ordering-expected.txt:
- platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
- platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
- 13:23 Changeset [78499] by
-
2011-02-14 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Covered by existing tests; not adding new tests at this time.
This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The first version failed some tests because
of incorrect error handling. The second version was missing one line
of code that made it decode incomplete sequences at the end of the
buffer twice.
- platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
- platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
- platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
- platform/text/TextCodecUTF8.h: Made virtual function overrides private.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
- 13:13 Changeset [78498] by
-
Need WebKit API to determine whether we have a site icon for a given URL
https://bugs.webkit.org/show_bug.cgi?id=54400
Reviewed by Brady Eidson.
This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.
- Interfaces/IWebIconDatabase.idl: Added new function.
- Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
- WebIconDatabase.cpp:
(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
load the icon from disk, and call iconURLForPageURL to determine whether or not
we actually have an icon.
- WebIconDatabase.h:
- 12:48 Changeset [78497] by
-
2011-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379
Add a constructor for copying a Vector into a String. I suspect there
are a number of call sites that are doing this manually that would
benefit from being moved to this API.
- wtf/text/WTFString.h: (WTF::String::String):
2011-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379
The parser in this patch is very basic. It just segments the CSP
header into directives. The exactly syntax will likely change a bit as
we discuss the details in public-web-security, but this parser will
allow us to make progress.
Sadly, this patch does not contain any tests. That's because CSP
policies do not have any observable effects yet. Hopefully we'll get
enough sketched out in the next couple patches to begin writing tests.
- page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::name): (WebCore::CSPDirective::value): (WebCore::ContentSecurityPolicy::~ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::parse):
- page/ContentSecurityPolicy.h:
- 12:19 Webkit2Innards edited by
- (diff)
- 12:03 Changeset [78496] by
-
2011-02-14 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test expectations, missed a test
in my last checkin.
- platform/chromium/test_expectations.txt:
- 11:48 Changeset [78495] by
-
2011-02-14 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Kenneth Russell.
[Qt] WebKit fails to compile for Qt when WebGL enabled
https://bugs.webkit.org/show_bug.cgi?id=53431
No new tests.
- WebCore.pro: Add source and header files and include directory to Qt project.
- html/canvas/WebGLRenderingContext.cpp: File uses 'emit' which is a Qt keyword - #undef emit.
- platform/graphics/gpu/qt: Added.
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added. Partial implementation of DrawingBuffer for Qt. (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
- platform/graphics/qt/Extensions3DQt.cpp: Noop implementation for pure virtual methods added to Extensions3D.h (WebCore::Extensions3DQt::blitFramebuffer): (WebCore::Extensions3DQt::renderbufferStorageMultisample):
- platform/graphics/qt/Extensions3DQt.h: Declare new methods added to Extensions3D.h
- platform/graphics/qt/GraphicsContext3DQt.cpp: Remove method implementations no longer in GraphicsContext3D.h. Change m_syntheticErrors to use unsigned int to match new GC3Denum type. (WebCore::GraphicsContext3D::create): Change return type to match GraphicsContext3D.h (WebCore::GraphicsContext3D::lineWidth): Change argument type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getUniformLocation): Change return type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getExtensions): Need to call get() on OwnPtr. (WebCore::GraphicsContext3D::getImageData): Rename enum values to match declarations in GraphicsContext3D.h
- 11:45 Changeset [78494] by
-
2011-02-14 Jay Soffian <jaysoffian@gmail.com>
Reviewed by Darin Fisher.
Expose checked field of HTMLInputElement to Chromium API
https://bugs.webkit.org/show_bug.cgi?id=54333
- public/WebInputElement.h:
- src/WebInputElement.cpp:
- 11:40 Changeset [78493] by
-
2011-02-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152
No new tests, covered by existing pixel results (fast/forms/basic-selects.html
convers lots of cases).
- css/themeChromiumLinux.css: (select):
- platform/chromium/PlatformBridge.h:
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintMenuList): match border logic in RenderThemeChromiumWin.cpp: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp#L463
2011-02-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152
- public/linux/WebThemeEngine.h:
- src/PlatformBridge.cpp: (WebCore::GetWebThemeExtraParams):
- 11:25 Changeset [78492] by
-
Unreviewed, Chromium test expectations update.
http://code.google.com/p/v8/issues/detail?id=1154
Temporarily mark a test as failing due to a new V8 version.
- platform/chromium/test_expectations.txt:
- 11:21 Changeset [78491] by
-
2011-02-14 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128
Test: fast/text/international/iso-8859-8.html
- platform/text/BidiResolver.h: Add VisualDirectionOverride enum. (WebCore::::createBidiRunsForLine): For lines with visual direction override, create bidi runs without resolving bidi levels (one run per render object), set bidi level as 0 or 1 depending on LTR or RTL override, and reverse runs for RTL override.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): Set inline box bidi level the same as BidiRun's bidi level without special handling of VisualDirectionOverride. (WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride to createBidiRunsForLine().
2011-02-14 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128
- fast/text/international/iso-8859-8-expected.txt: Added.
- fast/text/international/iso-8859-8.html: Added.
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/forms/select-visual-hebrew-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- 11:02 Webkit2Innards edited by
- (diff)
- 10:52 Changeset [78490] by
-
2011-02-14 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000
Check the value is valid before use it.
- platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::~SharedTimerQt):
2011-02-14 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000
Test case to cover the crash.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::deleteQWebViewTwice):
- 10:29 Webkit2Innards edited by
- (diff)
- 10:28 Webkit2Innards created by
- 10:25 Changeset [78489] by
-
React to accelerated compositing changes and allocation failures in DrawingAreaImpl::display
Fixes <http://webkit.org/b/54398> DrawingAreaImpl::display handles error cases poorly.
Reviewed by Darin Adler and Anders Carlsson.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display): Bail out if the layout we perform puts us into
accelerated compositing mode. Moved the layout earlier in this function so we can bail
before doing other work that would be unnecessary in this case. Moved the allocation of the
ShareableBitmap earlier so we will leave our state (e.g., dirty region) intact even if the
allocation fails.
- 10:24 Changeset [78488] by
-
Add a way to flash backing store and view updates
The new WKPageSetDebugPaintFlags SPI can be used to control whether backing store and/or
view updates are flashed. A blueish color is used for view updates, and a purpleish color is
used for backing store updates. The flashing currently only works on Windows.
Fixes <http://webkit.org/b/54303>.
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetDebugPaintFlags):
(WKPageGetDebugPaintFlags):
- UIProcess/API/C/WKPagePrivate.h:
Added. These call through to WebPageProxy.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::flashBackingStoreUpdates):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::flashBackingStoreUpdates):
- UIProcess/API/qt/qwkpage_p.h:
Stubbed out new PageClient functions.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Tell the WebPageProxy to flash the
backing store updates we're performing.
- UIProcess/PageClient.h: Added flashBackingStoreUpdates.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::flashBackingStoreUpdates): Call through to the PageClient.
(WebKit::WebPageProxy::viewUpdatesFlashColor): Return the blueish color used for view
updates.
(WebKit::WebPageProxy::backingStoreUpdatesFlashColor): Return the purpleish color used for
backing store updates.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setDebugPaintFlags):
(WebKit::WebPageProxy::debugPaintFlags):
Added these simple accessors.
- UIProcess/win/WebView.cpp:
(WebKit::flashRects):
(WebKit::createBrush):
New helper functions.
(WebKit::WebView::onPaintEvent): Flash the dirty region if requested.
(WebKit::WebView::flashBackingStoreUpdates): Added. Calls through to flashRects.
- UIProcess/win/WebView.h: Added flashBackingStoreUpdates.
- win/WebKit2Generated.make: Export WKPagePrivate.h so clients can use it.
- 10:13 Changeset [78487] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: unflake inspector/styles-iframe.html
- inspector/resources/styles-iframe-data.html:
- inspector/styles-iframe-expected.txt:
- inspector/styles-iframe.html:
- 09:54 Changeset [78486] by
-
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
https://bugs.webkit.org/show_bug.cgi?id=33220
- inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
- 09:53 Changeset [78485] by
-
Merge 77563
BUG=70336
Review URL: http://codereview.chromium.org/6519013
- 09:29 Changeset [78484] by
-
2011-02-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Modify LayerTilerChromium to use TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143
Most of the previous data in LayerTilerChromium is now calculated
from TilingData. TilingData was modified to allow for a dynamic
tile size and page size. LayerTilerChromium also gets its own
shader with a texture transform to handle drawing from a texture
that is larger than a tile.
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::tilerSharedValues):
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::layerSize): (WebCore::LayerTilerChromium::layerTileSize): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTexturedQuad): (WebCore::LayerTilerChromium::SharedValues::SharedValues): (WebCore::LayerTilerChromium::SharedValues::~SharedValues):
- platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram): (WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation): (WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation): (WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation): (WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation): (WebCore::LayerTilerChromium::SharedValues::initialized):
- platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::setTotalSize): (WebCore::TilingData::setMaxTextureSize): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::textureOffset): (WebCore::TilingData::recomputeNumTiles):
- platform/graphics/gpu/TilingData.h:
- 09:18 QtWebKit edited by
- (diff)
- 09:18 QtWebKit edited by
- (diff)
- 09:17 QtWebKit edited by
- (diff)
- 09:17 Changeset [78483] by
-
2011-02-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
https://bugs.webkit.org/show_bug.cgi?id=54388
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded):
- 08:40 Changeset [78482] by
-
2011-02-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):
2011-02-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001
- wtf/text/TextPosition.h: (WTF::ZeroBasedNumber::convertAsOneBasedInt):
2011-02-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001
- Make call frame line and column zero based
- Set execution line in source frame based on call frame line:column
- Determine currently hit breakpoint based on call frame line:column
- bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
- bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
- bindings/v8/DebuggerScript.js: ():
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLocation): (WebInspector.SourceFrame.prototype.clearExecutionLocation): (WebInspector.SourceFrame.prototype._setExecutionLocation): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):
2011-02-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001
- src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
- 08:34 Changeset [78481] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium expectations update.
- platform/chromium/inspector/timeline-network-resource-expected.txt:
- 08:31 Changeset [78480] by
-
Regression: Back, Forward, Reload hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=54393
Reviewed by Gustavo Noronha Silva.
- page/ContextMenuController.cpp: Always show Back, Forward,
Reload and Stop context menu items for the GTK+ port.
- 08:12 Changeset [78479] by
-
Add some .messages.in and script files to WebKit2 projects
This is just for convenience. It doesn't affect the build.
- win/WebKit2.vcproj: Also let VS resort some files.
- win/WebKit2Generated.vcproj:
- 08:04 Changeset [78478] by
-
2011-02-14 Johnny Ding <jnd@chromium.org>
Reviewed by Andreas Kling.
Move the finiteness check into common code.
Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isPointInPath):
- 07:43 Changeset [78477] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move timeline and highlighter tests to the new harness.
https://bugs.webkit.org/show_bug.cgi?id=54390
- inspector/cookie-resource-match.html:
- inspector/elements-panel-search.html:
- inspector/evaluate-in-frontend-expected.txt: Removed.
- inspector/evaluate-in-frontend.html: Removed.
- inspector/inspected-objects-not-overriden.html:
- inspector/resources/timeline-iframe-data.html:
- inspector/syntax-highlight-css.html:
- inspector/syntax-highlight-html.html:
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/syntax-highlight-javascript.html:
- inspector/syntax-highlight.js: (initialize_SyntaxHighlight.InspectorTest.dumpSyntaxHighlight): (initialize_SyntaxHighlight):
- inspector/timeline-enum-stability-expected.txt:
- inspector/timeline-enum-stability.html:
- inspector/timeline-event-dispatch.html:
- inspector/timeline-layout-expected.txt:
- inspector/timeline-layout.html:
- inspector/timeline-mark-timeline.html:
- inspector/timeline-network-resource-expected.txt:
- inspector/timeline-network-resource.html:
- inspector/timeline-network-resource.js:
- inspector/timeline-paint.html:
- inspector/timeline-parse-html-expected.txt:
- inspector/timeline-parse-html.html:
- inspector/timeline-recalculate-styles-expected.txt:
- inspector/timeline-recalculate-styles.html:
- inspector/timeline-script-tag-1-expected.txt:
- inspector/timeline-script-tag-1.html:
- inspector/timeline-script-tag-2-expected.txt:
- inspector/timeline-script-tag-2.html:
- inspector/timeline-script-tag-2.js:
- inspector/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step1): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint.step3): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords): (initialize_Timeline.InspectorTest._timelineResults): (initialize_Timeline.InspectorTest.dumpTimelineRecord): (initialize_Timeline.InspectorTest.dumpTimelineRecords): (initialize_Timeline.InspectorTest.printTimelineRecordProperties): (initialize_Timeline.InspectorTest._timelineAgentTypeToString): (initialize_Timeline):
- inspector/timeline-trivial.html:
- 07:29 Changeset [78476] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: update chromium expectation for inspector test.
- inspector/console-uncaught-exception-in-eval.html:
- platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
- 06:27 Changeset [78475] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium expectations update.
- platform/chromium-win/inspector/console-format-expected.txt: Removed.
- platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Removed.
- platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Removed.
- platform/chromium/inspector/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console-dir-global-expected.txt.
- platform/chromium/inspector/console-format-collections-expected.txt:
- platform/chromium/inspector/console-format-expected.txt:
- platform/chromium/inspector/console-trace-in-eval-expected.txt:
- platform/chromium/inspector/console-uncaught-exception-expected.txt:
- platform/chromium/inspector/debugger-expand-scope-expected.txt:
- 06:23 Changeset [78474] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipped some tests that were causing problems just in
one of the bots, apparently rounding issues.
https://bugs.webkit.org/show_bug.cgi?id=39022
- platform/gtk/Skipped:
- 06:08 Changeset [78473] by
-
2011-02-14 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=54377
Rearranged the condition blocks, removed superfluous conditions:
.) if-statements where it's already clear that a search field is being generated
.) testing for spin-buttons on field types that can never have them.
createInnerBlockStyle(): only search fields create an inner block, and
these can never have spin buttons.
No new tests. (Refactoring - covered by existing tests)
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- 06:06 Changeset [78472] by
-
2011-02-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
https://bugs.webkit.org/show_bug.cgi?id=54195
Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.
- inspector/front-end/ResourceView.js: (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.SourceMappingForFormattedScript): (WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation): (WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
- inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._setBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint): (WebInspector.SourceFrameContentProvider.prototype.requestContent):
- inspector/front-end/SourceFrameContent.js: (WebInspector.SourceFrameContent): (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber): (WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.fromScriptLocation): (WebInspector.SourceMapping.prototype.toScriptLocation): (WebInspector.IdenticalSourceMapping): (WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation): (WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
- inspector/front-end/utilities.js: (String.prototype.lineEndings):
- 06:00 Changeset [78471] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipped generated-content-inside-table.htm test, it
fails in the bots, opened bug:
https://bugs.webkit.org/show_bug.cgi?id=54389
- platform/gtk/Skipped:
- 05:20 Changeset [78470] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=54277
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::showPanel):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::stopUserInitiatedProfiling):
- 05:13 Changeset [78469] by
-
2011-02-14 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743
Adds a test to ensure style 'max-width: none' works correctly.
- fast/css/max-width-none-expected.txt: Added.
- fast/css/max-width-none.html: Added.
2011-02-14 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743
Fix a bug that "max-width:none" works wrong.
See also: http://trac.webkit.org/changeset/13462
Test: fast/css/max-width-none.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-width of none, set it to Length(undefinedLength, Fixed), which is the correct value.
- 05:13 Changeset [78468] by
-
REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
https://bugs.webkit.org/show_bug.cgi?id=54344
Reviewed by Andreas Kling.
Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- 05:11 Changeset [78467] by
-
2011-02-14 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium] Fix wrong popup position for RTL(again)
https://bugs.webkit.org/show_bug.cgi?id=54375
Fix right position bug introduce by https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.
No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset(). (WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect(). (WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value. (WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
- platform/chromium/PopupMenuChromium.h: Change the function name and parameters.
- 05:06 Changeset [78466] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r78460 with more expectation updates.
- inspector/styles-iframe-expected.txt:
- inspector/styles-iframe.html:
- 04:31 Changeset [78465] by
-
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r78451.
http://trac.webkit.org/changeset/78451
https://bugs.webkit.org/show_bug.cgi?id=53898
It is causing crashes in some bots
- platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): (WebCore::TextCodecICU::registerBaseEncodingNames): (WebCore::TextCodecICU::registerBaseCodecs): (WebCore::TextCodecICU::registerExtendedEncodingNames): (WebCore::TextCodecICU::registerExtendedCodecs): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::getGbkEscape): (WebCore::urlEscapedEntityCallback): (WebCore::gbkCallbackEscape): (WebCore::gbkUrlEscapedEntityCallack): (WebCore::gbkCallbackSubstitute):
- platform/text/TextCodecICU.h: (WebCore::ICUConverterWrapper::ICUConverterWrapper):
- platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): (WebCore::nonASCIISequenceLength): (WebCore::decodeNonASCIISequence): (WebCore::TextCodecUTF8::decode):
- platform/text/TextCodecUTF8.h:
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
- 03:32 Changeset [78464] by
-
2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
Rebaseline chromium's test expectations for SVG tests.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
- platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
- platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
- platform/chromium/test_expectations.txt:
- 03:29 Changeset [78463] by
-
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r78460 with expectation updates.
- inspector/styles-iframe-expected.txt:
- platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
- platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
- 03:22 Changeset [78462] by
-
2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
Rebaseline chromium's test expectation for http://trac.webkit.org/changeset/78449
- platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Added.
- 03:14 Changeset [78461] by
-
2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
Rebaseline chromium's test expectations for inline-box-background-*
- platform/chromium-linux/fast/inline/inline-box-background-expected.checksum: Added.
- platform/chromium-linux/fast/inline/inline-box-background-expected.png: Added.
- platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Added.
- platform/chromium-mac/fast/inline/inline-box-background-expected.png: Added.
- platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/chromium-win/fast/inline/inline-box-background-expected.checksum: Added.
- platform/chromium-win/fast/inline/inline-box-background-expected.png: Added.
- platform/chromium-win/fast/inline/inline-box-background-expected.txt: Added.
- platform/chromium-win/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 02:58 Changeset [78460] by
-
2011-02-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
https://bugs.webkit.org/show_bug.cgi?id=54354
- http/tests/inspector/console-resource-errors.html:
- http/tests/inspector/console-test.js: Renamed from LayoutTests/http/tests/inspector/console-tests2.js.
- http/tests/inspector/console-tests.js: Removed.
- http/tests/inspector/console-websocket-error.html:
- http/tests/inspector/console-xhr-logging-expected.txt:
- http/tests/inspector/console-xhr-logging.html:
- http/tests/inspector/debugger-test.js: Renamed from LayoutTests/http/tests/inspector/debugger-test2.js.
- http/tests/inspector/elements-test.js: Added.
- http/tests/inspector/inspector-test2.js:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resource-parameters.html:
- http/tests/inspector/resource-tests.js: Removed.
- http/tests/inspector/resources-test.js: Renamed from LayoutTests/http/tests/inspector/resource-test2.js.
- inspector/command-line-api.html:
- inspector/console-api-on-call-frame.html:
- inspector/console-assert.html:
- inspector/console-clear.html:
- inspector/console-command-clear-expected.txt:
- inspector/console-command-clear.html:
- inspector/console-dir-global.html:
- inspector/console-dir.html:
- inspector/console-dirxml.html:
- inspector/console-eval-global.html:
- inspector/console-eval.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-collections.html:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- inspector/console-log-before-inspector-open.html:
- inspector/console-log-syntax-error.html:
- inspector/console-object-constructor-name.html:
- inspector/console-tests.html:
- inspector/console-trace-in-eval.html:
- inspector/console-trace.html:
- inspector/console-uncaught-exception-in-eval.html:
- inspector/console-uncaught-exception.html:
- inspector/debugger-autocontinue-on-syntax-error.html:
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-cyclic-ref.html:
- inspector/debugger-eval-on-call-frame.html:
- inspector/debugger-eval-while-paused.html:
- inspector/debugger-expand-scope.html:
- inspector/debugger-no-nested-pause.html:
- inspector/debugger-pause-in-eval-script.html:
- inspector/debugger-pause-on-breakpoint.html:
- inspector/debugger-pause-on-debugger-statement.html:
- inspector/debugger-pause-on-exception.html:
- inspector/debugger-proto-property.html:
- inspector/debugger-scripts.html:
- inspector/debugger-step-in.html:
- inspector/debugger-step-out.html:
- inspector/debugger-step-over.html:
- inspector/debugger-suspend-active-dom-objects.html:
- inspector/dom-breakpoints.html:
- inspector/elements-delete-inline-style.html:
- inspector/elements-img-tooltip-expected.txt:
- inspector/elements-img-tooltip.html:
- inspector/elements-panel-limited-children-expected.txt:
- inspector/elements-panel-limited-children.html:
- inspector/elements-panel-rewrite-href-expected.txt:
- inspector/elements-panel-rewrite-href.html:
- inspector/elements-panel-selection-on-refresh-expected.txt:
- inspector/elements-panel-selection-on-refresh.html:
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
- inspector/elements-panel-styles.html:
- inspector/elements-panel-xhtml-structure-expected.txt:
- inspector/elements-panel-xhtml-structure.xhtml:
- inspector/elements-tests.js: Removed.
- inspector/elements-tests2.js: Removed.
- inspector/resources/elements-panel-styles.css:
- inspector/resources/styles-iframe-data.html:
- inspector/storage-panel-dom-storage.html:
- inspector/styles-add-blank-property.html:
- inspector/styles-computed-trace.html:
- inspector/styles-disable-inherited.html:
- inspector/styles-disable-then-change.html:
- inspector/styles-disable-then-delete.html:
- inspector/styles-disable-then-enable.html:
- inspector/styles-iframe-expected.txt:
- inspector/styles-iframe.html:
- inspector/styles-new-API.html:
- inspector/styles-source-lines-expected.txt:
- inspector/styles-source-lines-inline.html:
- inspector/styles-source-lines.html:
- inspector/styles-source-offsets.html:
- inspector/styles-url-linkify.html:
- 02:54 Changeset [78459] by
-
2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
Rebaseline chromium's test_expectations.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 01:28 Changeset [78458] by
-
2011-02-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Need implementation of ResourceRequest and ResourceResponse serialization
https://bugs.webkit.org/show_bug.cgi?id=54339
Add dummy implementation with FIXME and let the core go with it for now.
- Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
- 00:05 Changeset [78457] by
-
https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster
Reviewed by Dan Bernstein.
- use std::sort
- cache specificity, it is slow to compute
- inline compare function
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):
- css/CSSStyleSelector.h:
02/13/11:
- 23:58 Changeset [78456] by
-
2011-02-13 Hayato Ito <hayato@chromium.org>
Reviewed by Kent Tamura.
Update .gitignore to ignore files which Ninja build system generates.
- .gitignore:
- 21:01 WebKit Team edited by
- Add myself to the committer list (diff)
- 20:22 Changeset [78455] by
-
The second attempt to merge r77114.
(It was merged by r78166 and reverted by r78381)
HTMLFormControlElement::insertedIntoDocument() and removedFromDocument()
should call HTMLElement::insertedIntoDocument() and removedFromDocument().
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.
Test: fast/forms/dangling-form-element-crash.html
- html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
- html/HTMLFormControlElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds a test that ensures dangling form associated elements are not
registered on the document.
- fast/forms/dangling-form-element-crash-expected.txt: Added.
- fast/forms/dangling-form-element-crash.html: Added.
BUG=crbug.com/70078
TBR=inferno@chromium.org
- 20:12 WebKit Team edited by
- (diff)
- 20:02 Changeset [78454] by
-
2011-02-13 Simon Fraser <simon.fraser@apple.com>
Change previous test to dump as text, with pixel output, to fix
Qt failure.
- fast/gradients/css3-repeating-end-fill-expected.txt:
- fast/gradients/css3-repeating-end-fill.html:
- 20:00 Changeset [78453] by
-
Versioning.
- 19:56 Changeset [78452] by
-
New tag.
- 19:28 Changeset [78451] by
-
2011-02-12 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Covered by existing tests; not adding new tests at this time.
This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.
- platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
- platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
- platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
- platform/text/TextCodecUTF8.h: Made virtual function overrides private.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
- 18:50 Changeset [78450] by
-
<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.
Reviewed by Maciej Stachowiak.
- platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):
- 18:09 Changeset [78449] by
-
2011-02-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Andreas Kling.
Repeating gradients drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53502
The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.
Test: fast/gradients/css3-repeating-end-fill.html
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
- 17:19 Changeset [78448] by
-
2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
Unused variable result in RenderBlock::addOverflowFromFloats()
https://bugs.webkit.org/show_bug.cgi?id=54363
Remove the unused variable.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats):
- 16:14 Changeset [78447] by
-
Reviewed by Anders Carlsson.
WebCore fails to build with Clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54367
- loader/PingLoader.h:
(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.
- 16:12 Changeset [78446] by
-
2011-02-13 Andreas Kling <kling@webkit.org>
Unreviewed, remove unnecessary platform expectations for now-passing test.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
- 16:09 Changeset [78445] by
-
Speculative fix for
Reviewed by Maciej Stachowiak.
<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.
- 15:19 Changeset [78444] by
-
2011-02-13 Nico Weber <thakis@chromium.org>
Reviewed by Anders Carlsson.
RenderBR::width() tries but fails to override RenderText::width()
https://bugs.webkit.org/show_bug.cgi?id=54301
The superclass method's signature changed, e.g. in
http://trac.webkit.org/changeset/57215, but the subclass was not
updated.
- rendering/RenderBR.h: (WebCore::RenderBR::width):
- 15:11 Changeset [78443] by
-
2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>
Fix chromium's test_expectations
- fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
- fast/css/test-setting-canvas-color.html is failing
- platform/chromium/test_expectations.txt:
- 13:41 Changeset [78442] by
-
2011-02-13 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168
Based on previous work by Julien Chaffraix <jchaffraix@codeaurora.org>
and Jan Erik Hanssen <jhanssen@sencha.com>
- css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
- css/CSSParser.h: Added the new parseSystemColor method.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
- html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work.
- html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
2011-02-13 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168
- fast/css/test-setting-canvas-color-expected.txt: Added.
- fast/css/test-setting-canvas-color.html: Added.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
- 13:39 Changeset [78441] by
-
2011-02-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
The plug-in process heap should be executable by default
https://bugs.webkit.org/show_bug.cgi?id=54364
<rdar://problem/8990563>
- UIProcess/Launcher/ProcessLauncher.h: Add executableHeap flag.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Set the right posix_spawn flag if executableHeap is true.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize executableHeap to true.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::connect): Initialize executableHeap to false.
- 13:21 Changeset [78440] by
-
2011-02-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Messages waited on are never dispatched
https://bugs.webkit.org/show_bug.cgi?id=54362
<rdar://problem/8995051>
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage): Get the argument encoder from the incoming message.
- 12:28 Changeset [78439] by
-
2011-02-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Adam Barth.
Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712
Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
Ports Affected:
WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.
- wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.
2011-02-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Adam Barth.
Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712
Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.
Ports Affected:
WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.
No behavior changes so no new tests.
- WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
- WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
- loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
- loader/FrameLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
- loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes):
- page/Settings.cpp:
- page/Settings.h:
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
2011-02-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Adam Barth.
Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712
Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
- 12:04 Changeset [78438] by
-
2011-02-13 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
https://bugs.webkit.org/show_bug.cgi?id=53320
The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.
- platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL):
- 11:33 Changeset [78437] by
-
2011-02-13 Leo Yang <leo.yang.c@gmail.com>
Reviewed by Andreas Kling.
Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
https://bugs.webkit.org/show_bug.cgi?id=54351
We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.
No functionality change, no new tests.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
- 11:23 Changeset [78436] by
-
2011-02-13 Jarred Nicholls <jarred@sencha.com>
Reviewed by Simon Fraser.
getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343
Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
- platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
- fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
- fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
- fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
2011-02-13 Jarred Nicholls <jarred@sencha.com>
Reviewed by Simon Fraser.
getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343
Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.
Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html
fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 11:10 Changeset [78435] by
-
2011-02-13 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should throw TYPE_MISMATCH_ERR
https://bugs.webkit.org/show_bug.cgi?id=54346
- security/crypto-random-values-types-expected.txt:
2011-02-13 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should throw TYPE_MISMATCH_ERR
https://bugs.webkit.org/show_bug.cgi?id=54346
As requested by Sam.
- page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
- 11:06 Changeset [78434] by
-
2011-02-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54349
Inline some accessors in PrintContext
No change in behavior, so no tests.
- WebCore.exp.in:
- page/PrintContext.cpp:
- page/PrintContext.h: (WebCore::PrintContext::pageCount): (WebCore::PrintContext::pageRect): Inline pageCount() and pageRect() to match pageRects().
- 11:05 Changeset [78433] by
-
Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back
in with fixes to make it work with render layers.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::contentsSize):
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):
- rendering/RenderListBox.h:
- 11:03 Changeset [78432] by
-
2011-02-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54348
Crash when printing a document with no pages
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake page that computePagesForPrinting() added to a pageless document.
- 10:46 Changeset [78431] by
-
Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262
Reviewed by Dan Bernstein.
Make sure that all calls to the scrollable area are null checked.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
- 10:35 Changeset [78430] by
-
Roll out r78424. It broke a bunch of tests.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
(WebCore::RenderLayer::contentsSize):
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
- 09:39 Changeset [78429] by
-
Reviewed and landed by Sam Weinig.
Patch by Chris Fleizach <cfleizach@apple.com> on 2011-02-13
AX: Update WK2 usage of remote accessibility api
https://bugs.webkit.org/show_bug.cgi?id=54220
Rename some of the remote accessibility methods to be more accurate.
Make sure to unregister the AccessibilityWebPageObject on dealloc.
Send the window remote token along with the WKView remote token.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):
(-[WKView _setAccessibilityWebProcessToken:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject dealloc]):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):
- 02:12 Changeset [78428] by
-
Reviewed by Dan Bernstein.
Bug 53760 - JSC fails to build with TOT Clang
https://bugs.webkit.org/show_bug.cgi?id=53760
Fix -Woverloaded-virtual warnings. This is also a 6% speedup on the v8 raytrace
benchmark; it is nothing-to-noise on everything else.
- API/JSCallbackObject.h: Remove pointlessly overloaded method.
- API/JSCallbackObjectFunctions.h: Ditto.
- runtime/Arguments.cpp:
(JSC::Arguments::put): Change signature to match the base class. This implementation
was no longer being called by anyone. This wasn't noticed because it is merely an
optimization of the base class' implementation.
- runtime/Arguments.h: Ditto.
JavaScriptGlue:
- UserObjectImp.cpp:
(UserObjectImp::toPrimitive): Use PreferredPrimitiveType instead of JSType to
match the base class.
- UserObjectImp.h:
- 02:02 Changeset [78427] by
-
2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test expectations for fast/inline/inline-box-background-*
- platform/chromium/test_expectations.txt:
02/12/11:
- 20:01 Changeset [78426] by
-
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=54335
<rdar://problem/8895141> Make window.print() work with WebKit2
- Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): (WebKit::TiledDrawingAreaProxy::removeTile):
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::postMessageToInjectedBundle): Updated for send() -> deprecatedSend() rename.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print(). (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation. (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving window.print(). (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ditto. (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching): When waiting for a web process to launch, store message flags, too. This is not practically important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags than to remember about this pitfall.
- UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send(). (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was conflicting with the other one after adding a flags argument. This matches a change previously made to CoreIPC::Connection.
- 16:18 Changeset [78425] by
-
2011-02-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
https://bugs.webkit.org/show_bug.cgi?id=54345
Some sites flip between composited and non-comosited state while loading. When the timing is
right, when we flip out of compositing we will need to do a display while tossing all the
compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
while we are in the middle of tossing layers, which leads to a crash.
The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
doing its display, using a timer.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 15:31 Changeset [78424] by
-
WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>
Reviewed by Dan Bernstein.
When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.
In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):
- rendering/RenderListBox.h:
Add implementations for visibleHeight/visibleWidth.
- 14:42 Changeset [78423] by
-
Reviewed by Dan Bernstein.
Follow up fix to:
https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
- 14:13 Changeset [78422] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342
Test which types of arrays work with crypto.getRandomValues.
- security/crypto-random-values-types-expected.txt: Added.
- security/crypto-random-values-types.html: Added.
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342
As discussed on whatwg, we should support all the integer array types.
Test: security/crypto-random-values-types.html
- page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
- 13:35 Changeset [78421] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279
I'm not sure it makes much of a difference whether we use arc4random or
/dev/urandom on Mac. However, there's some aesthetic benefit to using
the same underlying API on as many platforms as reasonable.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279
Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.
- config.h:
- 13:10 Changeset [78420] by
-
2011-02-12 Chang Shu <cshu@webkit.org>
Unreviewed.
Update my own email addresses and IRC nickname.
- Scripts/webkitpy/common/config/committers.py:
- 12:46 Changeset [78419] by
-
2011-02-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321
- public/WebSettings.h: Add a flag for multisampling setting.
- src/WebSettingsImpl.cpp: Ditto. (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
- src/WebSettingsImpl.h: Ditto.
2011-02-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
- page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled):
- page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled):
- 12:32 Changeset [78418] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
<rdar://problem/8990069>
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added. (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
- WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
- 04:37 Changeset [78417] by
-
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Deploy EditingStyle in applyBlockStyle and applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=53911
Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.
No new tests are added since this is a refactoring.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
- editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
- editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
- editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude.
- 03:56 Changeset [78416] by
-
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
- storage/indexeddb/objectstore-clear-expected.txt: Added.
- storage/indexeddb/objectstore-clear.html: Added.
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
Test: storage/indexeddb/objectstore-clear.html
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear):
- storage/IDBObjectStore.h:
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::clear):
- src/IDBObjectStoreProxy.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::clear):
- src/WebIDBObjectStoreImpl.h:
- 02:13 Changeset [78415] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Another attempt to fix the EFL build. Looks like we're missing one
more file.
- CMakeLists.txt:
- 02:01 Changeset [78414] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.
- CMakeLists.txt:
- 01:39 Changeset [78413] by
-
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix.
- dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets):
- 01:36 Changeset [78412] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.
- WebCore.pro:
- 01:29 Changeset [78411] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Update test expectations on Windows to account for ArrayBuffers being
on by default.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
- platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
- 01:18 Changeset [78410] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Apparently lines in .pro files need to be \-terminated.
- WebCore.pro:
- 01:10 Changeset [78409] by
-
2011-02-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Extract a function to process contents for one node from Range::processContents
https://bugs.webkit.org/show_bug.cgi?id=54282
Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.
When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).
When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).
No new tests are added since this is a refactoring.
- dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added.
- dom/Range.h:
- 01:07 Changeset [78408] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt Windows build.
- WebCore.pro:
- 00:24 Changeset [78407] by
-
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
Export the required functions.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.
- DerivedSources.cpp:
- WebCore.vcproj/WebCore.vcproj:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
- bindings/js/JSArrayBufferCustom.cpp:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDataViewCustom.cpp:
- bindings/js/JSFloat32ArrayCustom.cpp:
- bindings/js/JSInt16ArrayCustom.cpp:
- bindings/js/JSInt32ArrayCustom.cpp:
- bindings/js/JSInt8ArrayCustom.cpp:
- bindings/js/JSUint16ArrayCustom.cpp:
- bindings/js/JSUint32ArrayCustom.cpp:
- bindings/js/JSUint8ArrayCustom.cpp:
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
- bindings/v8/custom/V8DataViewCustom.cpp:
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
- html/canvas/ArrayBuffer.cpp:
- html/canvas/ArrayBuffer.idl:
- html/canvas/ArrayBufferView.cpp:
- html/canvas/ArrayBufferView.idl:
- html/canvas/DataView.cpp:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.cpp:
- html/canvas/Float32Array.idl:
- html/canvas/Int16Array.cpp:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.cpp:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.cpp:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.cpp:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.cpp:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.cpp:
- html/canvas/Uint8Array.idl:
- page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
- page/Crypto.h:
- page/Crypto.idl:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
Revert incorrect expectations from
http://trac.webkit.org/changeset/78337. These results were cased by
ArrayBuffers not beign enabled on Windows previous to this patch.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-function-resolve-expected.txt: Removed.
- platform/win/fast/js/var-declarations-shadowing-expected.txt: Removed.
- platform/win/security: Removed.
- platform/win/security/crypto-random-values-expected.txt: Removed.
02/11/11:
- 20:57 Changeset [78406] by
-
2011-02-11 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
indexeddb: add onBlocked to WebKit::WebIDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=54329
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onBlocked):
- 19:16 Changeset [78405] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Can’t open local files on reload or navigation from the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=54332
<rdar://problem/8903076>
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::isInspectorPage):
- UIProcess/WebInspectorProxy.h: Check whether the given page is a web inspector page.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeSandboxExtensionHandle): If this is a web inspector page, we don't want to make a sandbox extension.
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
Pass a sandbox extension along when sending the message.
- UIProcess/WebPageProxy.h: Make initializeSandboxExtensionHandle a member function.
- UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Pass a sandbox extension along.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goForward): (WebKit::WebPage::goBack): (WebKit::WebPage::goToBackForwardItem): Hand the sandbox extension to the sandbox extension tracker.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
Pass the sandbox extension to goToBackForwardItem.
(WebKit::shouldReuseCommittedSandboxExtension):
New function that checks whether a committed sandbox extension should be re-used. We
do this for page reloads, as well as regular page navigations when both the committed
and provisional documents have file URLs.
(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Reuse the committed sandbox extension if necessary.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 19:09 Changeset [78404] by
-
Fix Snow Leopard build.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didFailToSendSyncMessage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didFailToSendSyncMessage):
- 18:50 Changeset [78403] by
-
Unreviewed Qt webkit2 build fix after r78392.
- WebProcess/WebProcess.h:
- 18:42 Changeset [78402] by
-
2011-02-11 Daniel Bates <dbates@rim.com>
Reviewed by Geoffrey Garen.
Remove explicit disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports
https://bugs.webkit.org/show_bug.cgi?id=54107
It is unnecessary to explicitly disable ENABLE_ASSEMBLER_WX_EXCLUSIVE
by the definition of ENABLE().
- wtf/Platform.h:
- 18:05 Changeset [78401] by
-
Unreviewed, Chromium test expectations update.
Unify identical expectation files in chromium/ and update for r78383.
- platform/chromium-mac/fast/url/port-expected.txt: Removed.
- platform/chromium-win/fast/url/port-expected.txt: Removed.
- platform/chromium/fast/url/port-expected.txt: Copied from platform/chromium-win/fast/url/port-expected.txt.
- 17:49 Changeset [78400] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebProcess hung communicating with the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=54328
<rdar://problem/8854075>
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection): Add the DispatchMessageEvenWhenWaitingForSyncReply message send flag when sending the PluginProcess::CreateWebProcessConnection message, since the plug-in process can be busy waiting for a sync reply from the web process.
- 17:45 Changeset [78399] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Incoming synchronous messages should always be processed regardless of connection waiting for a reply
https://bugs.webkit.org/show_bug.cgi?id=54326
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::getOrCreate): Assert that the map has a non-null SyncMessageState object.
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_waitForSyncReplyCount.
(CoreIPC::Connection::SyncMessageState::beginWaitForSyncReply):
Increment m_waitForSyncReplyCount.
(CoreIPC::Connection::SyncMessageState::endWaitForSyncReply):
Decrement m_waitForSyncReplyCount. If it's 0, enqueue any incoming sync messages.
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
If this is a message that needs to be dispatched, add it to the queue and wake up the client run loop.
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
Go through the queue of incoming messages and dispatch them.
(CoreIPC::Connection::sendSyncMessage):
call beginWaitForSyncReply/endWaitForSyncReply.
(CoreIPC::Connection::waitForSyncReply):
Dispatch messages.
(CoreIPC::Connection::processIncomingMessage):
Call SyncMessageState::processIncomingMessage.
(CoreIPC::Connection::enqueueIncomingMessage):
Add helper function for enqueuing an incoming message.
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::destinationID):
- 17:42 Changeset [78398] by
-
2011-02-11 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch adds to NRWT most of the support needed to run the new
message-based workers in separate threads or processes. The code
isn't fully complete yet because we don't support cancel() or
is_alive().
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 17:36 Changeset [78397] by
-
WebKit2: Going to Ars Technica crashes WebProcess in WebCore::ResourceRequestBase::url() const + 9
<rdar://problem/8978832>
Reviewed by Maciej Stachowiak.
Speculative fix for crash accessing a bad ResourceRequest in policy
client code. Remove early returns from dispatchDecidePolicyForMIMEType
and dispatchDecidePolicyForNavigationAction that are not present in the WebKit1
equivalent code. This should be safe, now that the IPC calls are synchronous.
Also removes some invalid assertions in WebFrameProxy that were getting hit. It is okay
for the url to empty.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- 17:34 Changeset [78396] by
-
2011-02-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862
- fast/inline/inline-box-background-long-image.html: Added.
- fast/inline/inline-box-background-repeat-x.html: Added.
- fast/inline/inline-box-background-repeat-y.html: Added.
- fast/inline/inline-box-background.html: Added.
- fast/inline/resources: Added.
- fast/inline/resources/checker.png: Added.
- fast/inline/resources/gradient.png: Added.
- platform/mac/fast/inline/inline-box-background-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
2011-02-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862
When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order.
Tests: fast/inline/inline-box-background-long-image.html
fast/inline/inline-box-background-repeat-x.html
fast/inline/inline-box-background-repeat-y.html
fast/inline/inline-box-background.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
- 17:17 Changeset [78395] by
-
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318
Broke Safari extensions (Requested by eseidel on #webkit).
- fast/url/host-expected.txt:
- fast/url/ipv4-expected.txt:
- fast/url/ipv6-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318
Broke Safari extensions (Requested by eseidel on #webkit).
- platform/KURL.cpp: (WebCore::KURL::parse):
- 17:07 Changeset [78394] by
-
Fix for <rdar://problem/8976456> Scrollbars for overflow
areas never appear for WKScrollbarPainter scrollers
Reviewed by Sam Weinig.
Call ScrollableArea::didAddVerticalScrollbar() and
ScrollableArea::willRemoveVerticalScrollbar() when
appropriate for RenderLayers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
- 16:57 Changeset [78393] by
-
Unreviewed, Chromium test expectations update.
Also moved a test that's not Linux-specific and other platforms seem to
pass from chromium-linux/ to chromium/.
- platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Removed.
- platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/text/international/complex-text-rectangle-expected.txt: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt.
- platform/chromium/fast/text/international/complex-text-rectangle.html: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle.html.
- platform/chromium/test_expectations.txt:
- 16:24 Changeset [78392] by
-
Reviewed by Darin Adler and Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=53593
<rdar://problem/8948380> Crash beneath HistoryController::recursiveSetProvisionalItem in web
process (preceded by assertion failure) if UI process exits while
Messages::WebPage::RestoreSessionAndNavigateToCurrentItem is being handled
Can't test exiting the UI process.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Client::didFailToSendSyncMessage): Notify connection client when the connection fails to send a sync message.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::didFailToSendSyncMessage):
- WebProcess/WebProcess.h: Quit the web process immediately if it tried to send a sync message to a dead UI process. It never needs to continue and handle an unexpected null "reply".
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::didFailToSendSyncMessage):
- PluginProcess/PluginProcess.h: Ditto. There is no need for a plug-in to keep running even briefly if it couldn't get a reply to a sync message.
- 16:17 Changeset [78391] by
-
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unrevied chromium-gpu expectations update. Update expectations for
chromium-gpu-mac (it often has image diffs only, since it can use the
text results from the mac port).
- platform/chromium/test_expectations.txt:
- 16:16 Changeset [78390] by
-
Not reviewed.
Randomly touch some build files in the hopes of fixing the Qt build.
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- 16:13 Changeset [78389] by
-
Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320
Reviewed by Sam Weinig.
(Rolling back in r78386 with the build fixed.)
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make
our timer inert after forcing a GC, to avoid GC'ing repeatedly.
- 16:10 Changeset [78388] by
-
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Mark tests that fail only on
Snow Leopard, so that we can begin to have green Snow Leopard bots.
- platform/chromium/test_expectations.txt:
- 16:06 Changeset [78387] by
-
Not reviewed.
Used svn merge -r78386:78385 to roll out r78386 because it broke the build.
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::trigger):
- 15:58 Changeset [78386] by
-
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make our timer inert after forcing a GC, to avoid GC'ing repeatedly.
- 15:49 Changeset [78385] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a way to send async messages that can't get out of order with sync ones
https://bugs.webkit.org/show_bug.cgi?id=54319
<rdar://problem/8894844>
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): sendMessage now takes a messageSendFlags. Update the messageID if the messageSendFlags contain DispatchMessageEvenWhenWaitingForSyncReply.
(CoreIPC::Connection::waitForSyncReply):
Process asynchronous messages as well.
(CoreIPC::Connection::processIncomingMessage):
Check if a message should be dispatched even when we're waiting for a
synchronous reply.
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): Send now takes a messageSendFlags parameter.
- Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::messageIDWithAddedFlags): Return a new MessageID object with the given flags added.
(CoreIPC::MessageID::shouldDispatchMessageWhenWaitingForSyncReply):
Add getter.
- 15:48 Changeset [78384] by
-
Try to fix the Windows build: added an exported symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 15:47 Changeset [78383] by
-
2011-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090
Added a new test to show that we are intentionally removing
a colon after a host name. http://foo.com:/ -> http://foo.com/
- fast/url/port-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090
- platform/KURL.cpp: (WebCore::isDefaultPortForScheme): (WebCore::KURL::parse):
- 15:31 Changeset [78382] by
-
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
CollectorHeapIterator is a God object that knows the internals of each
of the pieces of the heap. This undermines the encapsulation I'm trying
to achieve by splitting concepts into different classes.
As an alternative, I've given each class a forEach iteration function,
which takes a functor as an argument. Now, each class just needs to
know how to iterate the things it knows about.
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed CollectorHeapIterator.
- debugger/Debugger.cpp: (JSC::Recompiler::Recompiler): (JSC::Recompiler::~Recompiler): (JSC::Recompiler::operator()): (JSC::Debugger::recompileAllJSFunctions): Updated to use forEach interface instead of an iterator.
- runtime/CollectorHeapIterator.h: Removed.
- runtime/Heap.cpp: (JSC::TypeCounter::TypeCounter): (JSC::TypeCounter::typeName): (JSC::TypeCounter::operator()): (JSC::TypeCounter::take): (JSC::Heap::protectedObjectTypeCounts): (JSC::Heap::objectTypeCounts): Added forEach and removed iterator.
- runtime/Heap.h: (JSC::Heap::forEach):
- runtime/JSGlobalData.cpp: (JSC::Recompiler::operator()): (JSC::JSGlobalData::recompileAllJSFunctions):
- runtime/MarkedBlock.h: (JSC::MarkedBlock::forEach): Added forEach. Removed friend declaration for CollectorHeapIterator. Now, we can make all our data private and change it without breaking any other classes.
- runtime/MarkedSpace.cpp:
- runtime/MarkedSpace.h: (JSC::MarkedSpace::forEach): Added forEach and removed iterator.
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
- WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
- 15:16 Changeset [78381] by
-
Crash with dynamic popup menu use
<rdar://problem/8716952>
Reviewed by Anders Carlsson.
Invalidate popup menus when forcing them closed, since they might still be
in their tracking loop.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
- UIProcess/WebPopupMenuProxy.h:
(WebKit::WebPopupMenuProxy::invalidate):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):
- 15:13 Changeset [78380] by
-
remove accidently added .orig files
- 15:12 Changeset [78379] by
-
Merge 77956, crbug 71717
- 15:09 Changeset [78378] by
-
Revert 78366 - Revert 78101 - Merge r76728, crbug 68263
Review URL: http://codereview.chromium.org/6508005
- 15:05 Changeset [78377] by
-
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend
is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp
No new tests. All existing canvas layouttests exercise this code path
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
- 14:56 Changeset [78376] by
-
Revert 78354 - Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005
Review URL: http://codereview.chromium.org/6510003
- 14:56 Changeset [78375] by
-
Actually initialize m_syncMessageState.
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
- 14:46 Changeset [78374] by
-
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
compositing/reflections/reflection-opacity.html has a JS exception
https://bugs.webkit.org/show_bug.cgi?id=54314
The JS code that the test was running was producing an error, and in
any case it didn't seem to be doing anything, since we don't define a
"moved" class (copy-and-paste error?).
- compositing/reflections/reflection-opacity.html:
- platform/mac/compositing/reflections/reflection-opacity-expected.txt:
- 14:45 Changeset [78373] by
-
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unrevied chromium-gpu expectations update. Remove failing expectations
for tests that now pass on the chromium-gpu-win bot.
- platform/chromium/test_expectations.txt:
- 14:38 Changeset [78372] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move the binary semaphore into SyncMessageState
https://bugs.webkit.org/show_bug.cgi?id=54311
With this change, all connections that belong to the same run loop will use same binary semaphore.
This is in preparation for making any connection be able to wakeup the client run loop.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::wakeUpClientRunLoop): (CoreIPC::Connection::SyncMessageState::wait): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
- 14:26 Changeset [78371] by
-
Revert 78166 - Merge r77114
Review URL: http://codereview.chromium.org/6508002
- 14:21 Changeset [78370] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Explicitly skip webarchive tests on GTK+, because we do not
support them. Remove all GTK+-specific webarchive expected results.
- platform/gtk/Skipped: Explicitly skip all webarchive tests.
- platform/gtk/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
- 14:14 Changeset [78369] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 14:03 Changeset [78368] by
-
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add a SyncMessageState class to CoreIPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=54309
SyncMessageState objects are shared between all connections scheduled on
a given run loop. It will be used to keep track of state when waiting
for replies for a synchronous message.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::syncMessageStateMap): (CoreIPC::Connection::SyncMessageState::syncMessageStateMapMutex): Add a global RunLoop -> SyncMessageState map and a mutex for locking.
(CoreIPC::Connection::SyncMessageState::getOrCreate):
Look in the map for an existing SyncMessageState object and create a new
one if none is found.
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_runLoop.
(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
Remove the object from the map.
- 14:03 Changeset [78367] by
-
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Adler.
Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=54304
This avoids potential crashes in HashMap, as WTF's StringHash doesn't
accept empty Strings.
- platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
- 13:56 Changeset [78366] by
-
Revert 78101 - Merge r76728, crbug 68263
Review URL: http://codereview.chromium.org/6474050
- 13:51 Changeset [78365] by
-
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu expectations update. Add more fine-grained
expectations for compositing on Windows (instead of the whole directory
being marked PASS FAIL). Also replace all FAIL GPU expectations with
more specific ones (e.g. TEXT or IMAGE+TEXT).
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.checksum: Added.
- platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 13:41 Changeset [78364] by
-
plugins/invalidate_rect.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=54122
This test was fixed on Windows in http://trac.webkit.org/changeset/78359. Remove the failing
expected results. Unreviewed.
- platform/win/plugins/invalidate_rect-expected.txt: Removed.
- 13:39 Changeset [78363] by
-
crashes in WebProcess at WebCore::Range::startPosition const + 16
https://bugs.webkit.org/show_bug.cgi?id=54294
<rdar://problem/8982710>
Reviewed by Darin Adler.
I don't have a repro case for this bugs, but the side-by-side
comparison of the IME support implementation in WebKit and WebKi2
shows a missing null check on a Range that could very well explain
this crash.
I tried running platform/mac/editing/input tests with a version of WebKit
without the null check and I can reproduce a crash with the same signature.
These tests are not yet enabled for WebKit2.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::firstRectForCharacterRange):
- 13:39 Changeset [78362] by
-
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
Tests for filesystem: URIs, testing both their security origin
properties and the existence of the Entry.toURI method.
- fast/filesystem/directory-entry-to-uri-expected.txt: Added.
- fast/filesystem/directory-entry-to-uri.html: Added.
- fast/filesystem/file-entry-to-uri-expected.txt: Added.
- fast/filesystem/file-entry-to-uri.html: Added.
- fast/filesystem/filesystem-uri-origin-expected.txt: Added.
- fast/filesystem/filesystem-uri-origin.html: Added.
- fast/filesystem/resources/directory-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestDirectory): ():
- fast/filesystem/resources/file-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestFile): ():
- http/tests/security/filesystem-iframe-from-remote-expected.txt: Added.
- http/tests/security/filesystem-iframe-from-remote.html: Added.
- http/tests/security/resources/create-filesystem-file.html: Added.
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
There are two major parts to this patch: one is to add an
implementation of Entry.toURI to the FileSystem API.
The other is to implement security origin checking for this
new scheme.
All changes are guarded by the FILE_SYSTEM feature. An accompanying
Chromium change, to support loading of filesystem: URIs, has recently
been submitted as Chromium r74082.
Spec:
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2
Proposed URI format, and discussion of security origin issues:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html
Tests: fast/filesystem/directory-entry-to-uri.html
fast/filesystem/file-entry-to-uri.html
fast/filesystem/filesystem-uri-origin.html
http/tests/security/filesystem-iframe-from-remote.html
- fileapi/Entry.cpp: (WebCore::Entry::toURI):
- fileapi/Entry.h:
- fileapi/Entry.idl:
- Added toURI method to the IDL, omitting the MIME type argument specified in the spec as it will soon be removed.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
- crack the filesystem: URI to get at the origin of the site (WebCore::SecurityOrigin::canDisplay):
- canDisplay for filesystem: URIs is equivalent to canRequest
- platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::create): (WebCore::AsyncFileSystem::openFileSystem):
- platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::type):
- Exposed filesystem type to allow toURI to use it as part of the path. (WebCore::AsyncFileSystem::AsyncFileSystem):
- platform/SchemeRegistry.cpp: (WebCore::canDisplayOnlyIfCanRequestSchemes): (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest): (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
- Generalized canDisplayOnlyIfCanRequest as it applies to both filesystem: and blob: URIs.
- platform/SchemeRegistry.h:
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
Changes to Chromium WebKit API required to expose
the FileSystem type to WebCore's fileapi code, since the
type is part of the filesystem URI.
- src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
- src/AsyncFileSystemChromium.h: (WebCore::AsyncFileSystemChromium::create):
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
- src/WebFileSystemCallbacksImpl.h:
- src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
- src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create):
- 13:21 Changeset [78361] by
-
Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62
Reviewed by Darin Adler.
Must check for null _animator.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 12:52 Changeset [78360] by
-
2011-02-11 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
https://bugs.webkit.org/show_bug.cgi?id=54158
No new tests since audio API is not yet implemented.
- bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
- bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::createBufferCallback):
- platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
- webaudio/AudioContext.idl:
- 12:41 Changeset [78359] by
-
2011-02-11 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
invalidate_rect.html should now pass on Windows. Removing skip.
- platform/chromium/test_expectations.txt:
2011-02-11 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
This change fixes the invalidate_rect.html test failure on Windows.
There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.
The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.
This change also updates the build path in chromium_win.py to use the new Source directory.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect):
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventWin): (NPP_HandleEvent):
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- 12:24 Changeset [78358] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add another batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 12:19 Changeset [78357] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 12:10 Changeset [78356] by
-
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
https://bugs.webkit.org/show_bug.cgi?id=54224
No new tests. Existing canvas tests exercise this...
fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
- 11:53 Changeset [78355] by
-
2011-02-11 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by David Levin.
Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390
No new tests.
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl: Wrap methods and declarations that use HTMLVideoElement with #if ENABLE(VIDEO).
- 11:44 Changeset [78354] by
-
Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005
- 11:41 Changeset [78353] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 11:37 Changeset [78352] by
-
2011-02-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] wmode gets overridden even if already windowless in QGraphicsWebView
Do not override wmode if it is not set to "window".
https://bugs.webkit.org/show_bug.cgi?id=50495
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- 11:23 Changeset [78351] by
-
Eliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
https://bugs.webkit.org/show_bug.cgi?id=54296
Reviewed by Steve Falkenburg.
- win/WebKit2Common.vsprops: Remove msimg32.dll from the list of DelayLoadDLLs.
- 11:16 Changeset [78350] by
-
2011-02-11 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy
classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54080
- GNUmakefile.am:
- Shared/gtk/UpdateChunk.cpp: Added. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
- Shared/gtk/UpdateChunk.h: Added. (WebKit::UpdateChunk::rect): (WebKit::UpdateChunk::isEmpty): (WebKit::UpdateChunk::size):
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): Initialize the surface.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h: Added cairo variables.
- UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingAreaProxy::page): (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
- 11:03 Changeset [78349] by
-
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
- platform/gtk/accessibility/document-reload-events.html: Removed.
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach):
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus):
- 10:42 Changeset [78348] by
-
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Generate more GTK+ results for many SVG tests missing them.
- platform/gtk/Skipped: Unskip tests which now have results.
- 10:21 Changeset [78347] by
-
[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introduction in
r76621.
https://bugs.webkit.org/show_bug.cgi?id=54291
Unreviewed, adding this test to the Windows XP skip list in order to get the bots green.
- platform/win-xp/Skipped:
- 10:11 Changeset [78346] by
-
2011-02-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GDOM] Video element needs proper wrapping
https://bugs.webkit.org/show_bug.cgi?id=54231
Use the same strategy as the one used for the audio tag to wrap
video as well. No layout tests because this only adds API.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createVideoWrapper): (WebKit::createHTMLElementWrapper):
- 10:00 Changeset [78345] by
-
2011-02-11 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
https://bugs.webkit.org/show_bug.cgi?id=54259
Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
avoid overloading a virtual function.
No change of functionality. Just fixing a build warning, so no new tests.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
- 09:54 Changeset [78344] by
-
Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776
- platform/win-xp/fast/dom: Added.
- platform/win-xp/fast/dom/52776-expected.txt: Added.
- 09:43 Changeset [78343] by
-
2011-02-11 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
https://bugs.webkit.org/show_bug.cgi?id=54089
- inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): (WebInspector.Drawer.prototype.immediatelyFinishAnimation): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/inspector.js: (WebInspector.animateStyle): (WebInspector.animateStyle.forceComplete): (WebInspector.animateStyle.cancel): (WebInspector.showSourceLine):
- 09:28 Changeset [78342] by
-
2011-02-10 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489
Refactor, no new tests.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::explicitClose): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
- dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
- html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 09:16 Changeset [78341] by
-
2011-02-11 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added two tests to the skipped file that started to fail only in
64-bit debug bot. Rounding issues are most likely the source of
differences between 32 and 64bit bots.
- platform/gtk/Skipped: added svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
- 08:48 ApplicationsGtk edited by
- (diff)
- 08:47 ApplicationsGtk edited by
- (diff)
- 08:36 Changeset [78340] by
-
2011-02-11 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unnecessary chromium layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=54278
- platform/chromium/fast/js/ToNumber-expected.txt: Removed.
- platform/chromium/fast/js/parseFloat-expected.txt: Removed.
- platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.
- 08:24 Changeset [78339] by
-
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: unflake inspector test (2).
- inspector/command-line-api.html:
- inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.selectElementAndRun):
- 07:47 Changeset [78338] by
-
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: unflake inspector test.
- inspector/command-line-api-expected.txt:
- inspector/command-line-api.html:
- 07:42 Changeset [78337] by
-
[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
fast/js/global-function-resolve.html,
fast/js/var-declarations-shadowing.html,
and security/crypto-random-values.html failing since r78321.
https://bugs.webkit.org/show_bug.cgi?id=54285
Unreviewed, landing expected failing results to get the bots green.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-function-resolve-expected.txt: Added.
- platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
- platform/win/security: Added.
- platform/win/security/crypto-random-values-expected.txt: Added.
- 07:23 Changeset [78336] by
-
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
https://bugs.webkit.org/show_bug.cgi?id=54227
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler):
- inspector/InspectorAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::mainDOMContentLoaded): (WebCore::InspectorDOMAgent::loadEventFired):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
- inspector/InspectorDOMStorageResource.h:
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
- inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::FrontendProvider::create): (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider): (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::create):
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::mute): (WebCore::InspectorState::updateCookie):
- inspector/InspectorState.h: (WebCore::InspectorState::~InspectorState):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- 06:54 Changeset [78335] by
-
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283
- inspector/command-line-api-expected.txt:
- inspector/command-line-api.html:
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283
- inspector/InjectedScriptSource.js:
- 06:21 Changeset [78334] by
-
[Qt] Increase the timeout of Qt API tests to 120 seconds.
Reviewed by Andreas Kling.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 05:25 Changeset [78333] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
CryptographicRandomNumber has its threading ifdefs backwards
https://bugs.webkit.org/show_bug.cgi?id=54280
Turns out we want the mutex when thread is enabled. :)
- wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
- 05:19 Changeset [78332] by
-
2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Andreas Kling.
[Qt][S60] Vertical borders of buttons and frames are misaligned
https://bugs.webkit.org/show_bug.cgi?id=51169
Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
without anti-aliasing. Patch idea by Laszlo Agocs.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- 04:53 Changeset [78331] by
-
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Added new layout test to check the right signals are emitted.
- platform/gtk/accessibility/document-reload-events-expected.txt: Added.
- platform/gtk/accessibility/document-reload-events.html: Added.
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.
Test: platform/gtk/accessibility/document-reload-events.html
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Emit the right signals when reloading a document.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
- 03:19 Changeset [78330] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Turns out that expectation isn't Qt specific.
- http/tests/security/cross-frame-access-put-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.
- 02:53 Changeset [78329] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Update Qt expected results for window.crypto.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
- 02:50 Changeset [78328] by
-
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
- inspector/command-line-api-expected.txt: Added.
- inspector/command-line-api.html: Added.
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275
Test: inspector/command-line-api.html
- inspector/InjectedScriptSource.js:
- 02:31 Changeset [78327] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Turns out window.crypto is supposed to be readonly.
- page/DOMWindow.idl:
2011-02-11 Adam Barth <abarth@webkit.org>
Update test expectations to show window.crypto.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt:
- 02:10 Changeset [78326] by
-
2011-02-11 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new test expectations for the GTK port.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- 01:34 Changeset [78325] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Actually add Crypto.cpp to the Windows build. I'm terrible.
- WebCore.vcproj/WebCore.vcproj:
- 01:21 Changeset [78324] by
-
Fix typo
- 01:12 Changeset [78323] by
-
2011-02-11 Adam Barth <abarth@webkit.org>
Attempt to fix the Windows build. Apparently we don't support
conditional attributes on functions. This patch makes the whole Crypto
interface conditional on ArrayBuffer support.
- page/DOMWindow.idl:
- page/Crypto.cpp:
- page/Crypto.h:
- page/Crypto.idl:
- 00:57 Changeset [78322] by
-
Enable ancestor identifier filtering for tree building
https://bugs.webkit.org/show_bug.cgi?id=54241
Reviewed by Dave Hyatt.
Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.
This roughly halves the remaining time in style matching over a typical page load.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
- dom/Document.h:
(WebCore::Document::styleSelectorIfExists):
- dom/Element.cpp:
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/Element.h:
- 00:37 Changeset [78321] by
-
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Test crypto.getRandomValues API. It's pretty hard to write a
deterministic API for a randomized API, but this test should catch some
regressions.
- security/crypto-random-values-expected.txt: Added.
- security/crypto-random-values.html: Added.
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Teach JavaScriptCore how to export this function.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Add crypto.getRandomValues. Yes, all these diffs are required to
expose a single function to the DOM.
Test: security/crypto-random-values.html
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- config.h:
- page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues):
- page/Crypto.h: Added. (WebCore::Crypto::create):
- page/Crypto.idl: Added.
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto):
- page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto):
- page/DOMWindow.idl:
- 00:26 Changeset [78320] by
-
2011-02-11 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[GTK] Build break with 2.18.3
https://bugs.webkit.org/show_bug.cgi?id=54057
- platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
- 00:14 Changeset [78319] by
-
2011-02-11 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749
No new tests. Refactoring.
- platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init):
- platform/KURLGooglePrivate.h:
