Timeline



Feb 24, 2011:

10:28 PM Changeset in webkit [79663] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Daniel Bates <​dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Extract table height adjustment for <caption> into common function
​https://bugs.webkit.org/show_bug.cgi?id=54936

We use similar logic for adjusting the height of a table with respect
to a top- and bottom-positioned <caption>. Instead, we should extract
the common code into a shared function.

No functionality changed. So no new tests.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::adjustLogicalHeightForCaption): Added. (WebCore::RenderTable::layout): Extracted common code to adjust table height with respect to the <caption> into RenderTable::adjustLogicalHeightForCaption().
  • rendering/RenderTable.h:
10:21 PM Changeset in webkit [79662] by mihaip@chromium.org
  • 5 edits
    2 copies in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Rebaseline media/audio-repaint.html and media/video-display-toggle.html
for Snow Leopard.

  • platform/chromium-mac-leopard/media/video-display-toggle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.checksum.
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
9:55 PM Changeset in webkit [79661] by Simon Fraser
  • 5 edits in trunk/LayoutTests

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

fast/repaint/bugzilla-6473.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=53655

Add a waitUntilDone() and notifyDone() to this test, since it uses
a setTimeout(), and update results accordingly.

  • fast/repaint/bugzilla-6473.html:
  • platform/mac/fast/repaint/bugzilla-6473-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-6473-expected.png:
  • platform/mac/fast/repaint/bugzilla-6473-expected.txt:
9:54 PM Changeset in webkit [79660] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated results after r79629.

  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
7:20 PM Changeset in webkit [79659] by jamesr@google.com
  • 12 edits
    3 adds in trunk/Source/WebCore

2011-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Move draw time properties out of *LayerChromium to CCLayerImpl
​https://bugs.webkit.org/show_bug.cgi?id=55013

This adds a new type (tentatively named CCLayerImpl) responsible for drawing/compositing layers.
Currently LayerChromiums know about their CCLayerImpls and CCLayerImpls rely on the LayerChromium
tree for structure. In theory updates are a LayerChromium-only concept and draw is a CCLayerImpl-only
concept, but this patch doesn't go all there yet in the interest of keeping the patch small-ish.

RenderSurfaces are a CCLayerImpl-only concepts and no longer have any direct LayerChromium dependencies.

Note: I've put CCLayerImpl into a new 'cc' directory under platform/graphics/chromium/ and intentionally
not added it to the include path. We plan to add more compositor implementation details to this directory
and we want to keep accidental dependencies on these files to a minimum.

See ​https://bugs.webkit.org/show_bug.cgi?id=54047 for the big picture.

Refactor only, compositing/ tests cover these codepaths.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::setLayerRenderer): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::setNeedsDisplay): (WebCore::LayerChromium::setBorderColor): (WebCore::LayerChromium::borderColor): (WebCore::LayerChromium::setBorderWidth): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::layerRenderer): (WebCore::LayerChromium::setDoubleSided): (WebCore::LayerChromium::bounds):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::maskDrawLayer): (WebCore::LayerChromium::ccLayerImpl):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::drawSurface): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: Added. (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::~CCLayerImpl): (WebCore::CCLayerImpl::superlayer): (WebCore::CCLayerImpl::maskLayer): (WebCore::CCLayerImpl::replicaLayer): (WebCore::CCLayerImpl::setLayerRenderer): (WebCore::CCLayerImpl::createRenderSurface): (WebCore::CCLayerImpl::updateContentsIfDirty): (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::draw): (WebCore::CCLayerImpl::unreserveContentsTexture): (WebCore::CCLayerImpl::bindContentsTexture): (WebCore::CCLayerImpl::cleanupResources): (WebCore::CCLayerImpl::getDrawRect): (WebCore::CCLayerImpl::drawDebugBorder):
  • platform/graphics/chromium/cc/CCLayerImpl.h: Added. (WebCore::CCLayerImpl::create): (WebCore::CCLayerImpl::setDebugBorderColor): (WebCore::CCLayerImpl::debugBorderColor): (WebCore::CCLayerImpl::setDebugBorderWidth): (WebCore::CCLayerImpl::debugBorderWidth): (WebCore::CCLayerImpl::layerRenderer): (WebCore::CCLayerImpl::renderSurface): (WebCore::CCLayerImpl::clearRenderSurface): (WebCore::CCLayerImpl::drawDepth): (WebCore::CCLayerImpl::setDrawDepth): (WebCore::CCLayerImpl::drawOpacity): (WebCore::CCLayerImpl::setDrawOpacity): (WebCore::CCLayerImpl::scissorRect): (WebCore::CCLayerImpl::setScissorRect): (WebCore::CCLayerImpl::targetRenderSurface): (WebCore::CCLayerImpl::setTargetRenderSurface): (WebCore::CCLayerImpl::doubleSided): (WebCore::CCLayerImpl::setDoubleSided): (WebCore::CCLayerImpl::bounds): (WebCore::CCLayerImpl::setBounds): (WebCore::CCLayerImpl::drawTransform): (WebCore::CCLayerImpl::setDrawTransform): (WebCore::CCLayerImpl::drawableContentRect): (WebCore::CCLayerImpl::setDrawableContentRect):
7:20 PM Changeset in webkit [79658] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated results after r79629.

  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
6:41 PM Changeset in webkit [79657] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Qt build fix.

  • WebKit2.pri:
6:21 PM Changeset in webkit [79656] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
​https://bugs.webkit.org/show_bug.cgi?id=55197

Reviewed by Simon Fraser.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
if there are no expansion opportunities. This allows RenderRubyBase to center itself.

6:20 PM Changeset in webkit [79655] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79466): http/tests/incremental/slow-utf8-html.pl flaky due to incorrect assertions
​https://bugs.webkit.org/show_bug.cgi?id=55135

  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode): Removed incorrect assertions.
6:15 PM Changeset in webkit [79654] by beidson@apple.com
  • 20 edits
    9 adds in trunk/Source/WebKit2

Part of <rdar://problem/8762095> and ​https://bugs.webkit.org/show_bug.cgi?id=55172
Need WebKit2 API to view/manage origins with LocalStorage.

Reviewed by Sam Weinig and looked over by Brian Weinstein.

Project file stuff:

  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:

WK2 derived sources and API stuff:

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add an KeyValueStorageManager to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit::WebContext::keyValueStorageManagerProxy):

Add API to get the KeyValueStorageManager for a context:

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetKeyValueStorageManager):

  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebKeyValueStorageManagerProxy:

  • UIProcess/API/C/WKKeyValueStorageManager.cpp: Added.

(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):

  • UIProcess/API/C/WKKeyValueStorageManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebKeyValueStorageManagerProxy.cpp: Added.

(WebKit::WebKeyValueStorageManagerProxy::create):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::~WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::invalidate):
(WebKit::WebKeyValueStorageManagerProxy::didReceiveMessage):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::didGetKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):

  • UIProcess/WebKeyValueStorageManagerProxy.h: Added.

(WebKit::WebKeyValueStorageManagerProxy::clearContext):
(WebKit::WebKeyValueStorageManagerProxy::type):

  • UIProcess/WebKeyValueStorageManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/KeyValueStorage: Added.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Added.

(WebKit::WebKeyValueStorageManager::shared):
(WebKit::WebKeyValueStorageManager::WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::didReceiveMessage):
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h: Added.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.messages.in: Added.
6:13 PM Changeset in webkit [79653] by mihaip@chromium.org
  • 11 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix a few css1/ and css2.1/ Snow Leopard failures by deleting obsolete
chromium-mac baselines (so that we fall back on correct mac ones)

Also promotes some chromium-mac-leopard baselines to mac-leopard, since
they appear to work for the mac port too.

  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/mac-leopard/css1/box_properties/clear_float-expected.checksum:
  • platform/mac-leopard/css1/box_properties/clear_float-expected.png:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/text_properties/text_align-expected.checksum:
  • platform/mac/css1/text_properties/text_align-expected.png:
6:10 PM Changeset in webkit [79652] by Darin Adler
  • 8 edits
    2 adds in trunk/Source

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit2: Image-based cursors do not work
​https://bugs.webkit.org/show_bug.cgi?id=55184

  • WebCore.exp.in: Exported new entry points now used by WebKit2.

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit2: Image-based cursors do not work
​https://bugs.webkit.org/show_bug.cgi?id=55184

  • Shared/ShareableBitmap.h: Added releaseData function declaration. This is only defined for CG, but we can declare it without defining it on non-CG platforms without causing problems.
  • Shared/WebCoreArgumentCoders.cpp: Added. (CoreIPC::encodeImage): Added. For use in the Cursor argument coder. (CoreIPC::decodeImage): Ditto.
  • Shared/WebCoreArgumentCoders.h: Added code to the Cursor encoder and decoder to handle image-based cursors, using the new encodeImage and decodeImage functions.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::releaseData): Added. (WebKit::ShareableBitmap::createGraphicsContext): Use CGBitmapContextCreateWithData instead of CGBitmapContextCreate, to guarantee we outlast the CGBitmapContext we create. (WebKit::ShareableBitmap::paint): Got rid of unnneeded local variable.
  • Shared/cg/WebCoreArgumentCodersCG.cpp: Added. (CoreIPC::createImage): Added. For use by CoreIPC::decodeImage.
  • WebKit2.xcodeproj/project.pbxproj: Added WebCoreArgumentCoders.cpp and WebCoreArgumentCodersCG.cpp.
  • win/WebKit2.vcproj: Ditto.
6:07 PM Changeset in webkit [79651] by mdelaney@apple.com
  • 3 edits
    2 adds in trunk

2011-02-24 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

ImageBuffer::clip creates an image of the incorrect context in IOSurface case
​https://bugs.webkit.org/show_bug.cgi?id=55170

  • fast/canvas/2d.fillText.gradient.html: Added. Draws a large "I" with an all-green gradient over a previously red canvas. Checks if (75,75) pixel is green to make sure the bottom left base of the I was painted, and checks (25,25) to make sure the red background wasn't overwritten by the textFill.

2011-02-24 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

ImageBuffer::clip creates an image of the incorrect context in IOSurface case
​https://bugs.webkit.org/show_bug.cgi?id=55170

Test: fast/canvas/2d.fillText.gradient.html

  • platform/graphics/cg/ImageBufferCG.cpp: Clipping against ImageBuffer's context instead of ourself (the passed in context).
5:51 PM Changeset in webkit [79650] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2011-02-24 James Robinson <​jamesr@chromium.org>

Update chromium-linux expectations for media/video-replaces-poster.html and expectations for V8 bugs.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [79649] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add LEOPARD modifier to tests that only fail on Leopard, not on Snow
Leopard.

Also updates Leopard expectations for fast/box-shadow/inset-expected.html
(SL expectations were updated in r78062).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/inset-expected.png:
5:20 PM Changeset in webkit [79648] by jamesr@google.com
  • 5 edits
    6 adds in trunk/LayoutTests

2011-02-24 James Robinson <​jamesr@chromium.org>

Update chromium test expectations and baselines.

  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.checksum:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.txt:
  • platform/chromium/test_expectations.txt:
5:02 PM Changeset in webkit [79647] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

RenderBoxModelObject::paintBoxShadow should bail earlier
​https://bugs.webkit.org/show_bug.cgi?id=55186

Make paintBoxShadow() bail early if there is no shadow, and make
callers consistent in not checking for box-shadow before calling it.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
5:01 PM Changeset in webkit [79646] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add GYP project for JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=55027

Again, this GYP files is very rough, but it succeeds in building
JavaScriptCore. There's a lot more work to do here, especially in the
area of sharing with JavaScriptGlue.gyp. This patch is more of a
checkpoint so that other folks can help out if they wish.

  • gyp: Added.
  • gyp/JavaScriptCore.gyp: Added.
  • gyp/generate-derived-sources.sh: Added.
4:58 PM Changeset in webkit [79645] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing files to JavaScriptCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=55193

I forgot to add mm files in my previous patch.

4:55 PM Changeset in webkit [79644] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter name in GCActivityCallback.cpp
​https://bugs.webkit.org/show_bug.cgi?id=55194

This change is not strictly required for the GYP-based build system,
but I noticed this error when working on the new build system.

  • runtime/GCActivityCallback.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
4:53 PM Changeset in webkit [79643] by jamesr@google.com
  • 2 edits
    8 adds in trunk/LayoutTests

2011-02-24 James Robinson <​jamesr@chromium.org>

Update chromium test expectations and baselines.

  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
4:51 PM Changeset in webkit [79642] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a script for creating gypi files
​https://bugs.webkit.org/show_bug.cgi?id=55113

This is a trivial script to create gypi files from the source code in
the current directory.

  • Scripts/make-gypi: Added.
4:42 PM Changeset in webkit [79641] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79628.
​http://trac.webkit.org/changeset/79628
​https://bugs.webkit.org/show_bug.cgi?id=55195

"broke chromium win tests" (Requested by dpranke on #webkit).

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4:34 PM Changeset in webkit [79640] by mihaip@chromium.org
  • 9 edits
    2 deletes in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed expectations update.

  • svg/custom/use-multiple-on-nested-disallowed-font.html has not crashed recently
  • Rebaseline fast/css/text-overflow-ellipsis.html for Leopard (Snow Leopard baselines were checked in with r78890)
  • Rebaseline fast/table/colspanMinWidth-vertical.html and fast/table/fixed-with-auto-with-colspan-vertical.html after r79618
  • platform/chromium-mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
4:04 PM Changeset in webkit [79639] by jamesr@google.com
  • 7 edits in trunk/Source

2011-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
​https://bugs.webkit.org/show_bug.cgi?id=55189

Defaults USE(BUILTIN_UTF8_CODEC) to true for all platforms except chromium, which controls the flag via features.gypi.

  • wtf/Platform.h:

2011-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
​https://bugs.webkit.org/show_bug.cgi?id=55189

Guards the built in UTF8 codec registration with USE(BUILTIN_UTF8_CODEC). ICU is used if the USE() is not set.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

2011-02-24 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
​https://bugs.webkit.org/show_bug.cgi?id=55189

Defaults USE(BUILTIN_UTF8_CODEC) to true for the Chromium port.

  • features.gypi:
3:58 PM Changeset in webkit [79638] by jamesr@google.com
  • 1 edit
    25 adds in trunk/LayoutTests

2011-02-24 James Robinson <​jamesr@chromium.org>

Add chromium baselines for new fast/block/position/vertical- tests.

  • platform/chromium-linux/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.txt: Added.
3:50 PM Changeset in webkit [79637] by ap@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

Rubber-stamped by Eric Seidel

Moving a test that doesn't need to be an http one out of http/tests.

  • fast/css/counter-crash-expected.txt: Copied from http/tests/css/counter-crash-expected.txt.
  • fast/css/counter-crash.html: Copied from http/tests/css/counter-crash.html.
  • fast/css/resources/counter-crash-frame-src.html: Copied from http/tests/css/resources/counter-crash-frame-src.html.
  • http/tests/css/counter-crash-expected.txt: Removed.
  • http/tests/css/counter-crash.html: Removed.
  • http/tests/css/resources/counter-crash-frame-src.html: Removed.
3:50 PM Changeset in webkit [79636] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

rebaseline-chromium-webkit-tests can't handle GPU variants
​https://bugs.webkit.org/show_bug.cgi?id=55002

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3:41 PM Changeset in webkit [79635] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

2011-02-24 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Seidel.

New baselines for media/video-replaces-poster.html needed after r79401
​https://bugs.webkit.org/show_bug.cgi?id=54910

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum:
  • platform/chromium-mac/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [79634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when trying to send a sync message on an invalid connection
​https://bugs.webkit.org/show_bug.cgi?id=55190
<rdar://problem/9035806>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): Don't try to call a client function if isValid() returns false since the client will be null in that case.
3:39 PM Changeset in webkit [79633] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: log command used to start web server to --verbose

​https://bugs.webkit.org/show_bug.cgi?id=55188

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
3:16 PM Changeset in webkit [79632] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Try to fix the Qt build.

3:13 PM Changeset in webkit [79631] by andersca@apple.com
  • 8 edits
    8 deletes in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Remove the layer backed drawing area
​https://bugs.webkit.org/show_bug.cgi?id=55174

  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: Removed.
  • UIProcess/LayerBackedDrawingAreaProxy.h: Removed.
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Removed.
  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Removed.
  • UIProcess/win/WebView.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: Removed.
  • WebProcess/WebPage/LayerBackedDrawingArea.h: Removed.
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Removed.
  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Removed.
  • win/WebKit2.vcproj:
3:10 PM Changeset in webkit [79630] by mihaip@chromium.org
  • 145 edits
    2 moves in trunk

2011-02-24 Victoria Kirst <​vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=55089

Media's UILayoutTests rely on video-test.js and media-file.js to be in
the media/ folder.

  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-file.js: Renamed from LayoutTests/http/tests/media/media-file.js.
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: Renamed from LayoutTests/http/tests/media/video-test.js.
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 Victoria Kirst <​vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=55089

This adds an alias into the media/ directory so that http/tests/media
tests can access the media resources when running in an httpd process.

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
3:07 PM Changeset in webkit [79629] by mitz@apple.com
  • 8 edits
    4 adds in trunk

<rdar://problem/8902740> Expand ruby base when it is shorter than the ruby text
​https://bugs.webkit.org/show_bug.cgi?id=55183

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/ruby/base-shorter-than-text.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableLogicalWidthForLine):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Added. The base clase implementation does nothing.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::textAlignmentForLine): Added. Implements the logic that changes "justify" to "auto" for
the last line or a line that ends with a hard break.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Use textAlignmentForLine(), compute the available
width more efficiently, and call adjustInlineDirectionLineBounds() for justified lines.

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::rubyRun): Added.
(WebCore::RenderRubyBase::textAlignmentForLine): Added. Alwyas returns "justify".
(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds): Added. Insets the line such that the inset is
half the width of a single intra-line expansion.

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::addChild):

LayoutTests:

  • fast/ruby/base-shorter-than-text.html: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
3:05 PM Changeset in webkit [79628] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: enable multiple processes by default on Chromium Win.

​https://bugs.webkit.org/show_bug.cgi?id=55163

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2:58 PM Changeset in webkit [79627] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-02-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Variable-sized allocation (but still capped at 64 bytes)
​https://bugs.webkit.org/show_bug.cgi?id=55159


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::allocateSlowCase): Split allocation into a fast and slow case, so the fast case can inline size class selection and turn it into a compile-time constant.


Changed the collect-on-every allocation debugging switch to collect only
on every slow allocation, so you can still flip the switch without
recompiling the world. This may also be preferable for debugging purposes,
since collecting after every single allocation can be unusably slow,
and can mask problems by running destructors early.

  • runtime/Heap.h: Ditto.
  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::Heap::allocate): (JSC::JSCell::JSCell::operator new): The inlining mentioned above.
  • runtime/MarkedBlock.h: Dropped the block size from 256KB to 16KB. With multiple size classes, allocating a full 256KB for the first allocation in a given class can be pathologically wasteful. (8KB, or 4KB Mac and 8KB Windows, would be even better, but that seems to be a peformance regression for now.)


  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset): There's more than one size class now, and its cell size is not constant.
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass): Ditto.
2:53 PM Changeset in webkit [79626] by weinig@apple.com
  • 2 edits in trunk/Tools

Attempt to fix Qt.

  • WebKitTestRunner/TestInvocation.cpp:
2:40 PM Changeset in webkit [79625] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

2011-02-24 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Eric Seidel.

In layout tests, iframe's onload handler should not use script function
defined after the iframe.
​https://bugs.webkit.org/show_bug.cgi?id=54942

  • editing/pasteboard/paste-noscript-svg-expected.txt:
  • editing/pasteboard/paste-noscript-svg.html:
  • editing/selection/cleared-by-relayout.html:
  • editing/undo/undo-iframe-location-change.html:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype.html:
  • fast/dom/Window/window-postmessage-clone-frames.html:
  • fast/dom/wrapper-classes.html:
  • fast/dynamic/paused-event-dispatch.html:
  • fast/replaced/max-width-percent.html:
2:40 PM Changeset in webkit [79624] by mthole@apple.com
  • 5 edits in trunk/Source/WebKit2

WK2: Add ability to get document node for a WKBundleNodeHandle
​https://bugs.webkit.org/post_bug.cgi

Reviewed by Sam Weinig.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyDocument):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::document):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2:38 PM Changeset in webkit [79623] by jamesr@google.com
  • 145 edits
    2 moves in trunk

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79598.
​http://trac.webkit.org/changeset/79598
​https://bugs.webkit.org/show_bug.cgi?id=55089

Appears to be causing trouble with httpd on windows

  • http/tests/media/media-file.js: Renamed from LayoutTests/media/media-file.js. (): (mimeTypeForExtension): (setSrcByTagName): (setSrcById): (stripExtension):
  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • http/tests/media/video-test.js: Renamed from LayoutTests/media/video-test.js. (disableFullTestDetailsPrinting): (enableFullTestDetailsPrinting): (logConsole): (findMediaElement): (testAndEnd): (test): (testExpected): (reportExpected): (runSilently): (run): (waitForEventAndEnd): (waitForEvent._eventCallback): (waitForEvent): (waitForEventTestAndEnd): (waitForEventAndFail): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest): (endTestLater): (failTestIn): (failTest): (logResult): (consoleWrite): (relativeURL): (isInTimeRanges):
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-in-media-document.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-plays-past-end-of-test.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79598.
​http://trac.webkit.org/changeset/79598
​https://bugs.webkit.org/show_bug.cgi?id=55089

Appears to be causing trouble with httpd on windows

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
2:30 PM Changeset in webkit [79622] by mihaip@chromium.org
  • 6 edits
    11 adds in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium/test_expectations.txt:
2:27 PM Changeset in webkit [79621] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderBox.cpp

Add null check for containing block to stop reflections crash.

2:15 PM Changeset in webkit [79620] by jamesr@google.com
  • 3 edits
    4 deletes in trunk

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79604.
​http://trac.webkit.org/changeset/79604
​https://bugs.webkit.org/show_bug.cgi?id=55017

Causes assertions to fail on some SVG tests

  • svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Removed.
  • svg/misc/SVGImage-leak-ResourceLoader.html: Removed.
  • svg/misc/resources/load-script.html: Removed.
  • svg/misc/resources/small.png: Removed.

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79604.
​http://trac.webkit.org/changeset/79604
​https://bugs.webkit.org/show_bug.cgi?id=55017

Causes assertions to fail on some SVG tests

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
2:14 PM Changeset in webkit [79619] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix

2:08 PM Changeset in webkit [79618] by hyatt@apple.com
  • 4 edits
    52 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Rework the logical height computation for positioned elements to work in terms of before and after. That way the offset is determined from
the correct container side in flipped block writing modes (e.g., vertical-rl).

Patch locationOffsetIncludingFlipping to use the containing block to flip so that it will behave correctly with absolute/fixed positioned
elements.

Patch offsetFromContainer to use the flipped location offset for absolute/fixed positioned elements so that localToAbsolute works properly.

Added twelve tests in fast/block/positioning/vertical-rl and fast/block/positioning/vertical-lr.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

LayoutTests:

  • fast/block/positioning/vertical-lr: Added.
  • fast/block/positioning/vertical-lr/001.html: Added.
  • fast/block/positioning/vertical-lr/002.html: Added.
  • fast/block/positioning/vertical-lr/003.html: Added.
  • fast/block/positioning/vertical-lr/004.html: Added.
  • fast/block/positioning/vertical-lr/005.html: Added.
  • fast/block/positioning/vertical-lr/006.html: Added.
  • fast/block/positioning/vertical-rl: Added.
  • fast/block/positioning/vertical-rl/001.html: Added.
  • fast/block/positioning/vertical-rl/002.html: Added.
  • fast/block/positioning/vertical-rl/003.html: Added.
  • fast/block/positioning/vertical-rl/004.html: Added.
  • fast/block/positioning/vertical-rl/005.html: Added.
  • fast/block/positioning/vertical-rl/006.html: Added.
  • platform/mac/fast/block/positioning/vertical-lr: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.txt: Added.
2:04 PM Changeset in webkit [79617] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2011-02-24 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Layout test fast/dom/timer-increase-then-decrease-min-interval.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=55176

Wait twice as long (1 second instead of 0.5 seconds) for results
from these two tests. They were on the verge of passing when
failures occurred previously, so this increase should push them
well over the passing threshold.

  • fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
  • fast/dom/timer-increase-then-decrease-min-interval.html:
1:59 PM Changeset in webkit [79616] by oliver@apple.com
  • 24 edits
    2 deletes in trunk/Source

2011-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make WeakGCMap use new handle infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=55100

Remove old WeakGCMap implementation and move over to new handle
based logic.

This has a number of benefits, most notably it makes a WeakGCMap
always reflect the true state of the world by as all entries are
removed at the first gc cycle that makes them dead. This allows
us to get rid of code in a wide variety of objects where the only
purpose was to remove themselves from maps.

It also means that we no longer need to have special "unchecked"
versions of any functions on WeakGCMap. Alas in order to maintain
compatibility with the JSWeakObjectMapClear API it is still
necessary to have an api that resembles uncheckedRemove, this is
now deprecatedRemove and will be dealt with in a later patch.

In order to get correct semantics in WeakGCMap we need more
contextual information in the finalizer, so we've added an
abstract class based finaliser and a context parameter to the
calls.

The new an improved WeakGCMap also results in sigificantly more
churn in the weak handle lists so exposed some potential problems
during the post mark phase which have been rectified as well.

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWeakObjectMapRefPrivate.h:
  • runtime/Heap.cpp: (JSC::Heap::globalObjectCount): (JSC::Heap::protectedGlobalObjectCount):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): (JSC::JSGlobalObject::init):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::iterator::iterator): (JSC::WeakGCMap::iterator::get): (JSC::WeakGCMap::iterator::getSlot): (JSC::WeakGCMap::iterator::operator++): (JSC::WeakGCMap::iterator::operator==): (JSC::WeakGCMap::iterator::operator!=): (JSC::WeakGCMap::WeakGCMap): (JSC::WeakGCMap::isEmpty): (JSC::WeakGCMap::clear): (JSC::WeakGCMap::get): (JSC::WeakGCMap::getSlot): (JSC::WeakGCMap::set): (JSC::WeakGCMap::take): (JSC::WeakGCMap::size): (JSC::WeakGCMap::deprecatedRemove): (JSC::WeakGCMap::begin): (JSC::WeakGCMap::end): (JSC::WeakGCMap::~WeakGCMap): (JSC::WeakGCMap::finalize):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set):

2011-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make WeakGCMap use new handle infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=55100

Update to new WeakGCMap APIs, this requires threading global
data to a few functions that did not need it in the past, but
also gets rid of a large number of destructors, as well as the
forgetDOMNode, etc APIs.

We can also drop the JSDebugWrapperSet as its only purpose was
to ensure that we retained correct semantics in the old WeakGCMap,
but happilly these semantics are now guaranteed by the map itself.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp: (WebCore::hasCachedDOMObjectWrapperUnchecked): (WebCore::cacheDOMObjectWrapper): (WebCore::hasCachedDOMNodeWrapperUnchecked): (WebCore::cacheDOMNodeWrapper): (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): (WebCore::takeWrappers): (WebCore::updateDOMNodeDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper): (WebCore::stringWrapperDestroyed): (WebCore::jsStringSlowCase):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWrapper.cpp: (WebCore::DOMObject::~DOMObject):
  • bindings/js/JSDebugWrapperSet.cpp: Removed.
  • bindings/js/JSDebugWrapperSet.h: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::createRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::~RuntimeObject):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
1:56 PM Changeset in webkit [79615] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix clang build.

  • WebCoreSupport/WebKeyGenerator.m:

(toWebCertificateParseResult):
(-[WebKeyGenerator addCertificatesToKeychainFromData:]):

  • WebView/WebTextCompletionController.mm:
1:54 PM Changeset in webkit [79614] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-24 James Robinson <​jamesr@chromium.org>

Fix chromium compile.

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::toStringCallback):
1:45 PM Changeset in webkit [79613] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r79607.
​http://trac.webkit.org/changeset/79607
​https://bugs.webkit.org/show_bug.cgi?id=55157

Broke Chromium layout tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer):
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
  • rendering/RenderMediaControls.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeWin.h:
1:37 PM Changeset in webkit [79612] by weinig@apple.com
  • 15 edits
    6 adds in trunk/Tools

Add basic pixel testing support to WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=55161

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

Don't print color space information when using WebKitTestRunner since
we don't need to change the screen.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
Add call to initializePlatformDefaults.

(WTR::InjectedBundle::done):
Return a dictionary on completion with both the text output and pixel dump override.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

Add declaration for initializePlatformDefaults.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::dumpAsText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpPixels):
Make setting dumpAsText override the dump pixels preference.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.

(WTR::InjectedBundle::initializePlatformDefaults):
Set platform defaults matching DumpRenderTree.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.

(WTR::InjectedBundle::initializePlatformDefaults):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WTR::InjectedBundle::initializePlatformDefaults):
Add stubs for initializePlatformDefaults.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
Parse expected pixel results out of stdin and setup the invocation with it.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
Initialize new members.

(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
(WTR::sizeWebViewForCurrentTest):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.

  • WebKitTestRunner/mac/TestInvocationMac.mm: Added.

(WTR::createCGContextFromPlatformView):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::forceRepaintFunction):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Add mac specific pixel dumping support. Right now, we always pull pixels
from the window server.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Add new files.

1:31 PM Changeset in webkit [79611] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Fix the clang -Woverloaded-virtual build.

Reviewed by Sam Weinig.

JSLocation has a toString function which conflicts with the virtual JSObject::toString member function.
Fix this by renaming the implementation function from JSLocation::toString to JSLocation::toStringFunction.

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::toStringFunction):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::toStringFunctionCallback):

  • page/Location.idl:
1:31 PM Changeset in webkit [79610] by chang.shu@nokia.com
  • 4 edits in trunk/Tools

2011-02-24 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Launch MiniBrowser if the test run is WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=55145

  • Scripts/old-run-webkit-tests:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:
1:24 PM Changeset in webkit [79609] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined release]):
Release should be "oneway void".

(-[WebUndefined retainCount]):
Return NSUIntegerMax instead of UINT_MAX.

1:23 PM Changeset in webkit [79608] by mihaip@chromium.org
  • 8 edits in trunk/LayoutTests

2011-02-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Leopard baseline update for some text tests after r78846
(Snow Leopard baselines were updated with r78862). chromium-mac (the
Leopard bot) should be passing with the mac-leopard baselines.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/mac-leopard/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac-leopard/fast/text/trailing-white-space-2-expected.checksum:
  • platform/mac-leopard/fast/text/trailing-white-space-2-expected.png:
  • platform/mac-leopard/fast/text/trailing-white-space-expected.checksum:
  • platform/mac-leopard/fast/text/trailing-white-space-expected.png:
1:10 PM Changeset in webkit [79607] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.
​https://bugs.webkit.org/show_bug.cgi?id=55157

Refactoring, no functional changes. Covered by existing tests.

RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
logic for all platforms. This patch:
a) moves the common logic of determining absolute positioning to a

platform-agnostic place;

b) simplifies the method to return constant offset.

  • html/shadow/MediaControls.cpp: (WebCore::volumeSliderOffset): Added new helper function,

capturing common logic of finding the absolute position of the volume slider.

(WebCore::MediaControls::updateVolumeSliderContainer): Changed to use the

new helper.

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeChromiumMac.h: Ditto.
  • rendering/RenderThemeChromiumMac.mm: Ditto. (WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: Ditto. (WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeWin.h: Ditto.
1:06 PM Changeset in webkit [79606] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-24 Tom Sepez <​tsepez@chromium.org>

Reviewed by Darin Fisher.

Add test for frame removal during resize event handler. Update
other tests to account for async onresize event disptach.
​https://bugs.webkit.org/show_bug.cgi?id=54467

  • fast/dynamic/paused-event-dispatch.html:
  • fast/events/resize-subframe.html:
  • fast/replaced/frame-removed-during-resize-smaller-expected.txt: Added.
  • fast/replaced/frame-removed-during-resize-smaller.html: Added.

2011-02-24 Tom Sepez <​tsepez@chromium.org>

Reviewed by Darin Fisher.

Make frameview resized event dispatch async so that it occurs
after layout has completed.


​https://bugs.webkit.org/show_bug.cgi?id=54467
Test: fast/replaced/frame-removed-during-resize-smaller.html

  • page/EventHandler.cpp: (WebCore::EventHandler::sendResizeEvent):
1:03 PM Changeset in webkit [79605] by scherkus@chromium.org
  • 7 edits in branches/chromium/648/Source

Merge 78787 - 2011-02-16 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
​https://bugs.webkit.org/show_bug.cgi?id=54559

Adds logic to properly resize the range of YUV textures to only
select legitimate values.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):

2011-02-16 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
​https://bugs.webkit.org/show_bug.cgi?id=54559

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::width): (WebKit::VideoFrameChromiumImpl::height): (WebKit::VideoFrameChromiumImpl::requiredTextureSize): (WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
  • src/VideoFrameChromiumImpl.h:

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6578030

12:57 PM Changeset in webkit [79604] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2011-02-24 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Adam Barth.

Add a test to ensure SVGImage won't cause ResourceLoader leaks.
​https://bugs.webkit.org/show_bug.cgi?id=55017

  • svg/misc: Added.
  • svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Added.
  • svg/misc/SVGImage-leak-ResourceLoader.html: Added.
  • svg/misc/resources: Added.
  • svg/misc/resources/load-script.html: Added.
  • svg/misc/resources/small.png: Added.

2011-02-24 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Adam Barth.

Use loader->init() instead of loader->load() to avoid complex fake
request loading and cleanup logic, and also avoid ResourceLoader leaks.

​https://bugs.webkit.org/show_bug.cgi?id=55017

Test: svg/misc/SVGImage-leak-ResourceLoader.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:45 PM Changeset in webkit [79603] by commit-queue@webkit.org
  • 27 edits
    6 copies
    1 add in trunk/LayoutTests

2011-02-24 Anna Cavender <​annacc@chromium.org>

Reviewed by Mihai Parparita.

Rebaselines for media tests under snowleopard.
​https://bugs.webkit.org/show_bug.cgi?id=54994

  • platform/chromium-mac-leopard/media/audio-repaint-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.checksum.
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.png.
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.checksum.
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.png.
  • platform/chromium-mac-leopard/media/video-zoom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.checksum.
  • platform/chromium-mac-leopard/media/video-zoom-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.png.
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.checksum:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
12:30 PM Changeset in webkit [79602] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Chromium Mac build fix after r79591.

  • WebCore.gypi: Added RenderMediaControls to WebCore.gypi.
12:09 PM Changeset in webkit [79601] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Make weaklist processing deal with weak handles being removed during the iteration
​https://bugs.webkit.org/show_bug.cgi?id=55105

It is possible for the handle heap to end up in a broken state if
a handle's finalizer removes either the current or next handle
to be visited during the post-gc cleanup. This patch removes that
problem by allowing the deallocate(Node*) routine to update the
iterator if it is called during finalization.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::updateAfterMark): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount):
  • collector/handles/HandleHeap.h: (JSC::Finalizer::~Finalizer): (JSC::HandleHeap::getFinalizer): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::makeSelfDestroying): (JSC::HandleHeap::Node::Node): (JSC::HandleHeap::Node::setFinalizer): (JSC::HandleHeap::Node::finalizer): (JSC::HandleHeap::Node::finalizerContext):
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::setGlobalObject): (JSC::GlobalObjectNotifier::finalize): (JSC::RegisterFile::globalObjectCollectedNotifier):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set):
11:54 AM Changeset in webkit [79600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-24 James Kozianski <​koz@chromium.org>

Reviewed by Ojan Vafai.

Add missing plumbing for registerProtocolHandler in ChromeClientImpl.
​https://bugs.webkit.org/show_bug.cgi?id=55112

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::registerProtocolHandler):
11:46 AM Changeset in webkit [79599] by jamesr@google.com
  • 5 edits
    8 adds in trunk/LayoutTests

2011-02-24 James Robinson <​jamesr@chromium.org>

Update chromium test expectations.

  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-linux/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.txt: Added.
  • platform/chromium/inspector/debugger/dom-breakpoints-expected.txt: Added.
  • platform/mac-leopard/transitions/default-timing-function-expected.checksum: Added.
  • platform/mac-leopard/transitions/default-timing-function-expected.png: Added.
11:42 AM Changeset in webkit [79598] by mihaip@chromium.org
  • 145 edits
    2 moves in trunk

2011-02-24 Victoria Kirst <​vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=55089

Media's UILayoutTests rely on video-test.js and media-file.js to be in
the media/ folder.

  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-file.js: Renamed from LayoutTests/http/tests/media/media-file.js.
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: Renamed from LayoutTests/http/tests/media/video-test.js.
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 Victoria Kirst <​vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=55089

This adds an alias into the media/ directory so that http/tests/media
tests can access the media resources when running in an httpd process.

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
11:40 AM Changeset in webkit [79597] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-24 Anna Cavender <​annacc@chromium.org>

Reviewed by Ojan Vafai.

rebaseline for media/video-controls-rendering.html on mac
​https://bugs.webkit.org/show_bug.cgi?id=55108

  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium/test_expectations.txt:
11:35 AM Changeset in webkit [79596] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=55165
Can call CF API with a null CFArray in WebResourceCacheManager

Reviewed by Adam Roben and looked at by Brian Weinstein.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins): cfURLCacheHostNames() can return a null CFArrayRef,

so the call to CFArrayGetCount must be null checked.

11:31 AM Changeset in webkit [79595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Misha Tyutyunik <​michael.tyutyunik@nokia.com>

Reviewed by Andreas Kling.

[Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
(2048Kb for now).
​https://bugs.webkit.org/show_bug.cgi?id=54887

No new tests required.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache): (WebCore::GraphicsLayerQtImpl::drawLayerContent): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
11:25 AM Changeset in webkit [79594] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

PatternAlternative leaked in YarrPatternConstructor::atomParenthesesEnd()
​https://bugs.webkit.org/show_bug.cgi?id=55156

Added code to delete unneeded PatternAlternative after it is removed
from m_alternatives Vector.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
11:25 AM Changeset in webkit [79593] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

ASSERTION FAILED: !isInAcceleratedCompositingMode() when entering accelerated compositing early
​https://bugs.webkit.org/show_bug.cgi?id=55162
<rdar://problem/9048523>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::updateState): Call setShouldNotifyAfterNextScheduledLayerFlush(false) so the web process process won't send an EnterAcceleratedCompositingMode message.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
setShouldNotifyAfterNextScheduledLayerFlush now takes a boolean.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush): Make this take a boolean.
11:00 AM Changeset in webkit [79592] by Martin Robinson
  • 104 edits
    2 copies
    46 adds in trunk

2011-02-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Nikolas Zimmermann.

[CAIRO] Support ImageBuffers clip operation on all Cairo ports
​https://bugs.webkit.org/show_bug.cgi?id=23526

Update results for tests which are now passing and unskip them.

  • platform/gtk/Skipped: Unskip tests which are now passing.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.png: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/gtk/svg/batik/masking/maskRegions-expected.checksum:
  • platform/gtk/svg/batik/masking/maskRegions-expected.png:
  • platform/gtk/svg/batik/text/textEffect2-expected.checksum:
  • platform/gtk/svg/batik/text/textEffect2-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.png:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • platform/gtk/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.checksum:
  • platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.png:
  • platform/gtk/svg/custom/js-late-mask-creation-expected.checksum:
  • platform/gtk/svg/custom/js-late-mask-creation-expected.png:
  • platform/gtk/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/gtk/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/gtk/svg/custom/mask-changes-expected.png.
  • platform/gtk/svg/custom/marker-child-changes-css-expected.txt: Added.
  • platform/gtk/svg/custom/mask-changes-expected.checksum:
  • platform/gtk/svg/custom/mask-changes-expected.png:
  • platform/gtk/svg/custom/mask-child-changes-expected.checksum:
  • platform/gtk/svg/custom/mask-child-changes-expected.png:
  • platform/gtk/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/gtk/svg/custom/mask-colorspace-expected.png: Added.
  • platform/gtk/svg/custom/mask-colorspace-expected.txt: Added.
  • platform/gtk/svg/custom/mask-inside-defs-expected.checksum:
  • platform/gtk/svg/custom/mask-inside-defs-expected.png:
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.png: Added.
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • platform/gtk/svg/custom/mask-with-all-units-expected.checksum:
  • platform/gtk/svg/custom/mask-with-all-units-expected.png:
  • platform/gtk/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/gtk/svg/custom/recursive-mask-expected.checksum: Added.
  • platform/gtk/svg/custom/recursive-mask-expected.png: Added.
  • platform/gtk/svg/custom/recursive-mask-expected.txt:
  • platform/gtk/svg/custom/visibility-override-mask-expected.checksum:
  • platform/gtk/svg/custom/visibility-override-mask-expected.png:
  • platform/gtk/svg/filters/feGaussianBlur-expected.checksum: Added.
  • platform/gtk/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.
  • platform/gtk/svg/filters/filter-clip-expected.checksum: Added.
  • platform/gtk/svg/filters/filter-clip-expected.png: Added.
  • platform/gtk/svg/filters/filter-clip-expected.txt: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.checksum: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

2011-02-20 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Nikolas Zimmermann.

[CAIRO] Support ImageBuffers clip operation on all Cairo ports
​https://bugs.webkit.org/show_bug.cgi?id=23526

Add support for ImageBuffer clipping on Cairo by emulating them with image
masks. Since masking is immediate on Cairo, we must store the mask surfaces
on a stack and apply them during restorePlatformState.

  • platform/graphics/GraphicsContext.h: Add pushImageMask.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::savePlatformState): Push an empty mask onto the stack, so we can keep track of when to actually apply the image mask. (WebCore::GraphicsContext::restorePlatformState): When we are ready to apply an image mask, use cairo_mask_surface to mask the group that we pushed onto our surface. (WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface onto the image mask stack and push a group onto the Cairo state, so that the masking only affects what we paint after this point.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep track of image masking information after calls to pushImageMask. (WebCore::ImageMaskInformation::update): Added (WebCore::ImageMaskInformation::valid): Added (WebCore::ImageMaskInformation::maskSurface): Added (WebCore::ImageMaskInformation::maskRect): Added
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.
10:54 AM Changeset in webkit [79591] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Add RenderMediaControls to Mac build, unduplicate one method.
​https://bugs.webkit.org/show_bug.cgi?id=55152

Refactoring, no functional changes.

  • WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to project,

ran sort-XCode-project-file.

  • rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WIN)

defines to allow building on Mac.

  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced guts

with a call to RenderMediaControls function.

10:44 AM Changeset in webkit [79590] by eric@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Eric Seidel <​eric@webkit.org>

Reviewed by Anders Carlsson.

VectorBuffer should not call malloc(0)
​https://bugs.webkit.org/show_bug.cgi?id=55091

Turns out the malloc() call which was so hot in:
​https://bugs.webkit.org/show_bug.cgi?id=55005
was actually just malloc(0).

We shouldn't be calling malloc(0) anyway, since there is no need to
and it might actually do work on some systems.
I believe on Mac it ends up taking the standard spinlocks (expensive)
and the code on Brew actually does a malloc(1) instead. Neither is desirable.

  • wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::VectorBufferBase::tryAllocateBuffer):
10:42 AM Changeset in webkit [79589] by commit-queue@webkit.org
  • 23 edits in trunk

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • http/tests/navigation/useragent-expected.txt:
  • http/tests/navigation/useragent.php:

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • StringsNotToBeLocalized.txt:

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • webkit/webkitwebsettings.cpp: (webkitUserAgent):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::userAgent):

2011-02-24 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
​https://bugs.webkit.org/show_bug.cgi?id=54566

  • UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent):
10:37 AM Changeset in webkit [79588] by jamesr@google.com
  • 10 edits in trunk/Source

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79584.
​http://trac.webkit.org/changeset/79584
​https://bugs.webkit.org/show_bug.cgi?id=44797

[chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
not set

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-24 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79584.
​http://trac.webkit.org/changeset/79584
​https://bugs.webkit.org/show_bug.cgi?id=44797

[chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
not set

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
10:11 AM Changeset in webkit [79587] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

Do not cache the default cairo font options using a static
variable. It fixes a memory leak reported by valgrind.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::getDefaultFontOptions): (WebCore::FontPlatformData::initializeWithFontFace):
10:07 AM Changeset in webkit [79586] by atwilson@chromium.org
  • 30 edits in trunk

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCore.exp.in:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-24 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79570.
​http://trac.webkit.org/changeset/79570
​https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
10:02 AM Changeset in webkit [79585] by bweinstein@apple.com
  • 20 edits
    9 adds in trunk/Source/WebKit2

Part of WebKit2: Need a way to manage cookies from the web process
​https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Adam Roben and looked over by Jessie Berlin.

This patch adds the plumbing and classes that are needed to manage cookies from the web process.
The functions that the API calls are currently stubs, but will be implemented in a follow-up patch.

Project file changes.

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:

Add some needed plumbing for WebCookieManager{Proxy}.

  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetCookieManager): Gets the cookie manager proxy.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKCookieManager.cpp: Added.

(WKCookieManagerGetTypeID):
(WKCookieManagerGetHostnamesWithCookies): Calls through to WebCookieManagerProxy.
(WKCookieManagerDeleteCookiesForHostname): Ditto.
(WKCookieManagerDeleteAllCookies): Ditto.

  • UIProcess/API/C/WKCookieManager.h: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the cookie manager.
(WebKit::WebContext::~WebContext): Invalidate the cookie manager.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebContext.h:

(WebKit::WebContext::cookieManagerProxy): Returns the cookie manager.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebCookieManagerProxy.cpp: Added.

(WebKit::WebCookieManagerProxy::create):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::invalidate):
(WebKit::WebCookieManagerProxy::didReceiveMessage):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Call through to the web process to get hostnames with cookies.
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies): Call the callback we were passed in getHostnamesWithCookies.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Call through to the web process to delete cookies

for the origin.

(WebKit::WebCookieManagerProxy::deleteAllCookies): Call through to the web process to delete all cookies.

  • UIProcess/WebCookieManagerProxy.h: Added.

(WebKit::WebCookieManagerProxy::clearContext):
(WebKit::WebCookieManagerProxy::type):

  • UIProcess/WebCookieManagerProxy.messages.in: Added.
  • WebProcess/Cookies: Added.
  • WebProcess/Cookies/WebCookieManager.cpp: Added.

(WebKit::WebCookieManager::shared):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage): Call through to didReceiveWebCookieManagerMessage.
(WebKit::WebCookieManager::getHostnamesWithCookies): Build an array from a HashSet (that isn't filled yet), and

convert that HashSet to a Vector to send to the UI process.

(WebKit::WebCookieManager::deleteCookiesForHostname): Added a stub.
(WebKit::WebCookieManager::deleteAllCookies): Ditto.

  • WebProcess/Cookies/WebCookieManager.h: Added.
  • WebProcess/Cookies/WebCookieManager.messages.in: Added.
10:00 AM Changeset in webkit [79584] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-02-24 David Dorwin <​ddorwin@chromium.org>

Reviewed by Eric Seidel.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

Tested by the existing fullscreen Layout Tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-24 David Dorwin <​ddorwin@chromium.org>

Reviewed by Eric Seidel.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
​https://bugs.webkit.org/show_bug.cgi?id=44797

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
  • src/WebSettingsImpl.h:
9:53 AM Changeset in webkit [79583] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk

2011-02-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
​https://bugs.webkit.org/show_bug.cgi?id=55131

  • http/tests/inspector/inspector-test.js:
  • inspector/elements/dom-agent-query-selector-expected.txt: Added.
  • inspector/elements/dom-agent-query-selector.html: Added.

2011-02-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
​https://bugs.webkit.org/show_bug.cgi?id=55131

Test: inspector/elements/dom-agent-query-selector.html

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule):
9:50 AM Changeset in webkit [79582] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove obsolete PLATFORM(CI)
​https://bugs.webkit.org/show_bug.cgi?id=55082

  • wtf/Platform.h:
9:41 AM Changeset in webkit [79581] by alex
  • 5 edits
    3 adds in trunk/Source

2011-02-24 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48510

Exported static functions for GTK, we need them to create events
in WebKit2.

  • platform/PlatformKeyboardEvent.h:
  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode): (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): (WebCore::PlatformKeyboardEvent::singleCharacterString):

2011-02-24 Amruth Raj <​amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <​ravi.kasibhatla@motorola.com> and Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Shared/gtk/WebEventFactory.cpp: Added. implementation for WebMouseEvent, WebWheelEvent, WebKeyboardEvent.
  • Shared/gtk/WebEventFactory.h: Added.
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: Added. Stubbed implementation for GTK port.
9:38 AM Changeset in webkit [79580] by Martin Robinson
  • 5 edits in trunk/Source

2011-02-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the GFile GOwnPtr specialization
​https://bugs.webkit.org/show_bug.cgi?id=55154

Remove the GFile specialization of GOwnPtr. It's sufficient to use GRefPtr
to track GFiles since they are just regular reference-counted GObjects.

  • wtf/gobject/GOwnPtr.cpp: Remove GFile specialization.
  • wtf/gobject/GOwnPtr.h: Ditto.

2011-02-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the GFile GOwnPtr specialization
​https://bugs.webkit.org/show_bug.cgi?id=55154

Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.

No new tests. This should not change behavior.

  • plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include. (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr.
9:37 AM Changeset in webkit [79579] by Adam Roben
  • 2 edits
    2 adds in trunk/LayoutTests

Update Windows XP test results after r78846

  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:
9:33 AM Changeset in webkit [79578] by Patrick Gansterer
  • 36 edits in trunk/Source

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
​https://bugs.webkit.org/show_bug.cgi?id=55090

  • wtf/Platform.h:

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
​https://bugs.webkit.org/show_bug.cgi?id=55090

  • config.h: Removed second define of PLATFORM(SKIA).
  • html/HTMLCanvasElement.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.cpp:
  • platform/graphics/Pattern.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GLES2Canvas.cpp:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp:
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • rendering/svg/RenderSVGResourceSolidColor.cpp:

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
​https://bugs.webkit.org/show_bug.cgi?id=55090

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
9:33 AM Changeset in webkit [79577] by alex
  • 2 edits in trunk

2011-02-24 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Martin Robinson.

Fixed compilation after r79537, added a bug to solve webkit2
translations:
​https://bugs.webkit.org/show_bug.cgi?id=55153

  • GNUmakefile.am:
9:29 AM Changeset in webkit [79576] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to 79566. USE_PARAM not declared
​https://bugs.webkit.org/show_bug.cgi?id=55155

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
9:20 AM Changeset in webkit [79575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-24 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] add android 2.2 user agent to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=55085

Credit to Forrest Hodgkins to find right user-agent which works for youtube.

  • QtTestBrowser/useragentlist.txt:
8:59 AM Changeset in webkit [79574] by eae@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-24 Emil A Eklund <​eae@chromium.org>

Reviewed by Simon Fraser.

Add support for missing properties to getComputedStyle
​https://bugs.webkit.org/show_bug.cgi?id=23668

Test getComputedStyle for the content, counter and outline-offset
properties.

  • fast/css/getComputedStyle/computed-style-properties-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-properties.html: Added.

2011-02-24 Emil A Eklund <​eae@chromium.org>

Reviewed by Simon Fraser.

Add support for missing properties to getComputedStyle
​https://bugs.webkit.org/show_bug.cgi?id=23668

Implement getComputedStyle for the content, counter and outline-offset
properties.

Test: fast/css/getComputedStyle/computed-style-properties.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::contentToCSSValue): (WebCore::counterToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:
8:56 AM Changeset in webkit [79573] by Adam Roben
  • 2 edits in trunk/Tools

Change FrameLoadDelegate to support any number of delegates with delayed work to process

This makes our behavior match Mac more closely, and allows us to remove an incorrect
assertion that was firing during some tests. (The assertion was claiming that there was
never more than one delegate with delayed work to process, but that was not the case.)

Fixes <​http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
when running http/tests/navigation/back-twice-without-commit.html

Reviewed by Eric Carlson.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
process. A single delegate may appear in this Vector more than once (just as, on Mac, a
single delegate may have multiple performSelector requests).
(processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
assertion that the timer firing is the shared process work timer. Instead of using the
single, global "delegate waiting for timer" delegate, give all delegates that have delayed
work to process a chance to process their work.
(FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
Vector so our processWork function will be called when the timer fires.

8:52 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
moved Qt to last section, it's optional (diff)
8:50 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
8:44 AM Changeset in webkit [79572] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

SegmentedString does not need an m_composite member
​https://bugs.webkit.org/show_bug.cgi?id=55083

Storing m_composite as distinct from m_substrings.isEmpty()
was just error prone and eventually going to get us in trouble.

I also cleaned up some of the style in SegementedString.*
since this file long predates check-webkit-style.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::length): (WebCore::SegmentedString::setExcludeLineNumbers): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString):
  • platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::appendTo): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::isComposite):
8:40 AM Changeset in webkit [79571] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Add missing include for UnusedParam.h

Not reviewed.

  • platform/mac/FileSystemMac.mm: Add include. It should have

originally been added with r76614.

8:39 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
Improved English :) Remove references to Python script. Emphasized … (diff)
8:26 AM Changeset in webkit [79570] by commit-queue@webkit.org
  • 30 edits in trunk

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-24 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
​https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
8:22 AM Changeset in webkit [79569] by krit@webkit.org
  • 10 edits
    8 adds in trunk

2011-02-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler.

Removing a SVG animation target during animation crashes WebKit
​https://bugs.webkit.org/show_bug.cgi?id=12065

SVGAnimations with IRI references via 'xlink:href' are slow
​https://bugs.webkit.org/show_bug.cgi?id=49437

Test that WebKit does not crash, if the target element of a SVG animation gets removed, or if
its id changed.

  • platform/mac/svg/custom/animate-target-id-changed-expected.checksum: Added.
  • platform/mac/svg/custom/animate-target-id-changed-expected.png: Added.
  • platform/mac/svg/custom/animate-target-id-changed-expected.txt: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.png: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.txt: Added.
  • svg/custom/animate-target-id-changed.svg: Added.
  • svg/custom/animate-target-removed-from-document.svg: Added.

2011-02-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler.

Removing a SVG animation target during animation crashes WebKit
​https://bugs.webkit.org/show_bug.cgi?id=12065

SVGAnimations with IRI references via 'xlink:href' are slow
​https://bugs.webkit.org/show_bug.cgi?id=49437

Store reference to target element for SVG animation elements. This is important if the
target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple
times on every animation step. A very expensive operation. This will be avoided with this patch.
On the other hand, we need to be sure that the target element is always valid. The reference is
reset, if the target was removed from document or its destructor was called. A HashMap in
SVGDocumentExtensions stores all mappings from target element to all current animation elements.

Tests: svg/custom/animate-target-id-changed.svg

svg/custom/animate-target-removed-from-document.svg

  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target. (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap. (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all references in SVG animation elements.
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::removedFromDocument): (WebCore::SVGElement::attributeChanged):
  • svg/SVGElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::removedFromDocument):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::removedFromDocument):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::SVGSMILElement::removedFromDocument): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::targetElement):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::resetTargetElement):
8:12 AM Changeset in webkit [79568] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

REGRESSION: Accelerated transitions are jumpy
​https://bugs.webkit.org/show_bug.cgi?id=55022

When an accelerated transition used the default timing function,
a typo in toCAMediaTimingFunction() resulting in the incorrect
timing function being used.

Test: transitions/default-timing-function.html

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (toCAMediaTimingFunction):
8:09 AM Changeset in webkit [79567] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-24 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove bogus optimizations in TextBreakIteratorQt
​https://bugs.webkit.org/show_bug.cgi?id=55139

Let QTextBoundaryFinder hold a deep copy of the string data it's
operating on, and don't use the same working buffer for all iterators.

  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::TextBreakIterator): (WebCore::setUpIterator):
8:05 AM Changeset in webkit [79566] by podivilov@chromium.org
  • 3 edits
    6 adds in trunk

2011-02-24 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Bug in the highlighter
​https://bugs.webkit.org/show_bug.cgi?id=54876

Fixing two bugs: 1) When restoring the state from a successful updateHighlight() call, we should restore the old state only if it is greater (closer to the end) than the current one.
2) When a long line is being highlighted in more than one chunk (timer tick), we wrongly deleted the result of the work done in the previous tick, rather than updating it with the new results.

  • inspector/editor/highlighter-long-line-expected.txt: Added.
  • inspector/editor/highlighter-long-line.html: Added.
  • inspector/editor/highlighter-paste-in-comment-expected.txt: Added.
  • inspector/editor/highlighter-paste-in-comment.html: Added.
  • inspector/editor/highlighter-test.js: Added. (initialize_HighlighterTests.InspectorTest.dumpTextModel): (initialize_HighlighterTests):

2011-02-24 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Bug in the highlighter
​https://bugs.webkit.org/show_bug.cgi?id=54876

Tests: inspector/editor/highlighter-long-line.html

inspector/editor/highlighter-paste-in-comment.html

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
7:51 AM Changeset in webkit [79565] by simonjam@chromium.org
  • 6 edits in trunk

2011-02-24 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
​https://bugs.webkit.org/show_bug.cgi?id=55068

  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Expect navStart and unload to be zero.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html: Expect navStart to be zero.
  • http/tests/misc/webtiming-origins-expected.txt:

2011-02-24 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
​https://bugs.webkit.org/show_bug.cgi?id=55068

Test: http/tests/misc/webtiming-origins.html

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect. (WebCore::PerformanceTiming::unloadEventStart): Ditto. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
7:49 AM Changeset in webkit [79564] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Remove pthreads dependecy for JSLock
​https://bugs.webkit.org/show_bug.cgi?id=54832

JSLock is only needed to support an obsolete execution model where JavaScriptCore
automatically protected against concurrent access from multiple threads.
So it's safe to disable it on non-mac platforms where we don't have native pthreads.

  • runtime/JSLock.cpp:
7:49 AM Changeset in webkit [79563] by commit-queue@webkit.org
  • 6 edits
    2 moves
    1 delete in trunk/Source

2011-02-24 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
​https://bugs.webkit.org/show_bug.cgi?id=54516

Give Chromium's NetworkStateNotifier the ability to change the value
of m_isOnLine, rather than making it always true.

No new tests, not sure how to test this. No other LayoutTests seem
to exercise navigator.onLine.

  • WebCore.gypi:
  • platform/network/NetworkStateNotifier.cpp: (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid.
  • platform/network/NetworkStateNotifier.h: (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine.
  • platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
  • platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
  • platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.

2011-02-24 Adam Klein <​adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
​https://bugs.webkit.org/show_bug.cgi?id=54516

Add a new WebNetworkStateNotifier class with a single static method,
setOnLine(), which dispatches to WebCore's singleton NetworkStateNotifier.

  • WebKit.gyp:
  • public/WebNetworkStateNotifier.h: Added.
  • src/WebNetworkStateNotifier.cpp: Added. (WebKit::WebNetworkStateNotifier::setOnLine):
7:31 AM TriagingTestFailures edited by Adam Roben
Add tips for looking at old builds on build.webkit.org (diff)
7:21 AM Changeset in webkit [79562] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source

2011-02-24 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

Support building WebKit with Python 3
​https://bugs.webkit.org/show_bug.cgi?id=55038

Add support for Python 3 without breaking support for Python 2.

Main issues:
-print is a function in Python 3
-list.sort() no longer have the cmp parameter
-string.uppercase and string.lowercase have been removed

  • html/parser/create-html-entity-table:

2011-02-24 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

Support building WebKit with Python 3
​https://bugs.webkit.org/show_bug.cgi?id=55038

Update the generator scripts to support Python 3.

  • Scripts/generate-message-receiver.py: print is a function in Python 3, write the output to sys.stdout to be compatible with Python 2 and 3.
  • Scripts/generate-messages-header.py:
  • Scripts/webkit2/messages.py: dist.iteritems does not exist in Python 3, fallback to dict.items which is common to Python 2 and 3.
7:15 AM Changeset in webkit [79561] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am

Fixes <​http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
but did

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added some more tests.

7:12 AM Changeset in webkit [79560] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix bad expectation for new test added in r79555.

  • inspector/debugger/scripts-panel-expected.txt:
6:56 AM Changeset in webkit [79559] by Chris Fleizach
  • 4 edits
    2 adds in trunk

2011-02-24 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
​https://bugs.webkit.org/show_bug.cgi?id=55049

  • platform/mac/accessibility/math-alttext-expected.txt: Added.
  • platform/mac/accessibility/math-alttext.html: Added.

2011-02-24 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
​https://bugs.webkit.org/show_bug.cgi?id=55049

Make <math> elements behave as ARIA math roles and use MathML::alttext as a
possible accessible label.

Test: platform/mac/accessibility/math-alttext.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  • mathml/mathattrs.in:
6:51 AM Changeset in webkit [79558] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: adjust protocol message format according to spec.
​https://bugs.webkit.org/show_bug.cgi?id=55140

  • inspector/CodeGeneratorInspector.pm:
6:48 AM Changeset in webkit [79557] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows Production build fix

  • platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for

<rdar://problem/9042114>.

6:43 AM Changeset in webkit [79556] by pfeldman@chromium.org
  • 30 edits
    2 adds in trunk

2011-02-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
​https://bugs.webkit.org/show_bug.cgi?id=55057

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite):
  • inspector/console/command-line-api-inspect-expected.txt: Added.
  • inspector/console/command-line-api-inspect.html: Added.

2011-02-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
​https://bugs.webkit.org/show_bug.cgi?id=55057

Test: inspector/console/command-line-api-inspect.html

I am working on getting rid of DOM agent pushes - everything should happen upon
front-end request. This patch changes the way we handle inspect() command line
api: instead of pushing nodes, we are telling front-end that inspect(object) has
been requested. It is then up to front-end to request dom nodes and focus them in
the tree. I also made inspect() work in a generic manner, using same routines for
nodes, databases, storages and potentially new elements.

As a side-effect, we don't do console.log from within inspect() anymore, but dump
inspected value as inspect's result.

Also, I added individual object release method and made object groups optional.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::JSInjectedScriptHost::inspect): (WebCore::JSInjectedScriptHost::databaseId): (WebCore::JSInjectedScriptHost::storageId):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::inspectCallback): (WebCore::V8InjectedScriptHost::databaseIdCallback): (WebCore::V8InjectedScriptHost::storageIdCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::releaseObject): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::inspectNode):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::databaseId):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObject):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/inspector.js: (WebInspector.inspect):
6:38 AM Changeset in webkit [79555] by podivilov@chromium.org
  • 7 edits
    5 adds in trunk

2011-02-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactor "script or resource" mess in scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=54961

  • Use sourceName instead of scriptOrResource
  • Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions
  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.assertEquals): (initialize_InspectorTest.InspectorTest.safeWrap):
  • inspector/debugger/resources/script1.js: Added. (f1):
  • inspector/debugger/resources/script2.js: Added. (f2):
  • inspector/debugger/resources/script3.js: Added. (f3):
  • inspector/debugger/scripts-panel-expected.txt: Added.
  • inspector/debugger/scripts-panel.html: Added.

2011-02-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactor "script or resource" mess in scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=54961

  • Use sourceName instead of scriptOrResource
  • Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions

Test: inspector/debugger/scripts-panel.html

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList): (WebInspector.ScriptsPanel.prototype._sourceNameForScript): (WebInspector.ScriptsPanel.prototype._scriptForSourceName): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._filesSelectChanged): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setExecutionLine):
6:34 AM Changeset in webkit [79554] by eric@webkit.org
  • 5 edits in trunk

2011-02-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing does not need to use HTMLSourceTracker
​https://bugs.webkit.org/show_bug.cgi?id=55011

Remove support of XSS-filtering innerHTML content.

  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:

2011-02-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing does not need to use HTMLSourceTracker
​https://bugs.webkit.org/show_bug.cgi?id=55011

Any performance gains from this patch are likely
the result of working around:
​https://bugs.webkit.org/show_bug.cgi?id=55005
(Which suggests that fixing bug 55005 will speed
up normal HTML parsing substantially.)

Assuming I ran the numbers correct, here is the
change from PerformanceTests/Parser/tiny-innerHTML:
Before patch:
avg 5586.1
median 5594
stdev 41.295157101045135
min 5425
max 5633

After Patch:
avg 2603.9
median 2609.5
stdev 32.500615378789355
min 2475
max 2649

Removing just the HTMLSourceTracker calls brought our
score from 5500 to 5200, removing the XSSFilter as well
brought it to 2600 on my machine.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
6:08 AM Changeset in webkit [79553] by pfeldman@chromium.org
  • 9 edits in trunk/LayoutTests

2011-02-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: beautified inspector test suite output.

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite):
  • inspector/debugger/source-frame-expected.txt:
  • inspector/elements/insert-node-collapsed-expected.txt:
  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/modify-chardata-expected.txt:
  • inspector/elements/remove-node-expected.txt:
  • inspector/elements/set-attribute-expected.txt:
5:44 AM Changeset in webkit [79552] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-02-24 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebView::setPalette(activeFG) fails
​https://bugs.webkit.org/show_bug.cgi?id=55029

This time it should be the proper fix. The window needs to be shown before we
call activateWindow() otherwise there is no active windows for the application.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette):
5:25 AM Changeset in webkit [79551] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Chao-ying Fu <​fu@mips.com>

Reviewed by Eric Seidel.

Fix MIPS build with new patchOffsetPut/GetByIdPropertyMapOffset1/2 values
​https://bugs.webkit.org/show_bug.cgi?id=54997

  • jit/JIT.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
5:14 AM Changeset in webkit [79550] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping crashing test on GTK

  • platform/gtk/Skipped:
5:11 AM Changeset in webkit [79549] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium Mac test expectations update.

fast/text/shadow-no-blur.html has been passing for a while.
http tests have been passing since r79279.
media/video-display-toggle.html has been passing since r79415.
svg/text/font-size-below-point-five.svg has been passing since r78844.

  • platform/chromium/test_expectations.txt:
4:58 AM Changeset in webkit [79548] by abecsi@webkit.org
  • 14 edits in trunk

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • JavaScriptCore.pri: rename addJavaScriptCore to prependJavaScriptCore
  • jsc.pro: ditto

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • api/QtScript.pro:

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

No new tests needed.

  • WebCore.pri:

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • QtWebKit.pro: prepend libraries in the correct order

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • WebKit2.pri:

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
​https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
4:52 AM Changeset in webkit [79547] by abarth@webkit.org
  • 7 edits
    3 adds in trunk

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP's script-src should block JavaScript URLs
​https://bugs.webkit.org/show_bug.cgi?id=54787

Test how various CSP policies affect JavaScript URLs. We could test
more contexts in the future, but this is a start.

  • http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-url.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/javascript-url.pl: Added.

2011-02-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP's script-src should block JavaScript URLs
​https://bugs.webkit.org/show_bug.cgi?id=54787

Blocking JavaScript URLs required some re-architecting of the lifetime
of the ContentSecurityPolicy object. We now manage the lifetime the
same way we manage the lifetime of the SecurityOrigin object. In
particular, when SecurityOrigin inherits into an about:blank iframe, we
inherit the CSP object as well. (This is covered by the test added in
this patch.) In the future, we might consider making
ContentSecurityPolicy a component of SecurityOrigin instead of a
component of Document.

I noted the trickiness in
​http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
make sure it gets defined properly in the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-url.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::create):
4:47 AM Changeset in webkit [79546] by Philippe Normand
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-02-21 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] GRefPtr support for GstElement
​https://bugs.webkit.org/show_bug.cgi?id=54870

  • CMakeListsEfl.txt:
  • GNUmakefile.am:
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added. (WTF::GstElement):
  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
4:39 AM Changeset in webkit [79545] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] Remove ARMv5 Release buildbot.

Patch by Gabor Loki <​loki@webkit.org> on 2011-02-24
Reviewed by Csaba Osztrogonác.

Remove ARMv5 Release buildbot, because there is very little difference
between ARMv5 and ARMv7 Release bots, and there is also very little
interest in ARMv5 build slave (compared to ARMv7).

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:33 AM Changeset in webkit [79544] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] REGRESSION(69304): WKNativeEvent.h forwarding header is always regenerated
​https://bugs.webkit.org/show_bug.cgi?id=47589

In case of file name clashes only generate forwarding header for the current platform.

  • Scripts/generate-forwarding-headers.pl:
4:31 AM Changeset in webkit [79543] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

Share code between elementFromPoint and caretRangeFromPoint in Document.
​https://bugs.webkit.org/show_bug.cgi?id=54610

Eliminate duplicate code by moving shared logic from elementFromPoint and
caretRangeFromPoint into helper function.

  • dom/Document.cpp: (WebCore::nodeFromPoint): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
3:57 AM Changeset in webkit [79542] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeAttribute):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::cachedResources):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
3:51 AM Changeset in webkit [79541] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-24 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Eric Seidel.

[gtk] Failing collinear arcTo canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=54658

Enable two more tests that pass after adding collinearity check
when drawing arcTo in canvas.

  • platform/gtk/Skipped:

2011-02-24 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Eric Seidel.

[gtk] Failing collinear arcTo canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=54658

Check for collinearity of the three points that affect how arcTo call
results. This behavior is in accordance with the HTML standard.

No new tests added as this is already covered by at least two tests.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::areaOfTriangleFormedByPoints): (WebCore::Path::addArcTo):
3:50 AM Changeset in webkit [79540] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectations update.
Removed tests that have been passing since r79478.

  • platform/chromium/test_expectations.txt:
3:43 AM Changeset in webkit [79539] by loislo@chromium.org
  • 30 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: There is a validator of the protocol message format.

It has two parts. InspectorBackendStub.js is the frontend part.
InspectorBackendDispatcher.cpp is the backend part.
Both parts are checking protocol message format and report the error if
the message has not enough fields or the types of fields do not match with
Inspector.idl specification. These validators are generated automatically.

In addition, we have a number of places at the backend where we check the
function arguments and do nothing if the arguments are invalid
from the business logic point of view.

This patch bring us an ability to report a custom error from such function to the frontend.

​https://bugs.webkit.org/show_bug.cgi?id=54971

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
3:25 AM Changeset in webkit [79538] by eric@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Deque<T> should support inline capacity
​https://bugs.webkit.org/show_bug.cgi?id=55032

The title says it all. There are currently no places
which use this code yet, however it's been tested in conjunction
with code for bug 55005.

This also adds an ASSERT that capacity is never 1. If you were able
to set the capacity equal to 1, the Deque would just get confused
and happily append your item but still think it had size 0.

  • wtf/Deque.h: (WTF::DequeIterator::DequeIterator): (WTF::DequeConstIterator::DequeConstIterator): (WTF::DequeReverseIterator::DequeReverseIterator): (WTF::DequeConstReverseIterator::DequeConstReverseIterator): (WTF::::checkValidity): (WTF::::checkIndexValidity): (WTF::::invalidateIterators): (WTF::::Deque): (WTF::deleteAllValues): (WTF::::operator): (WTF::::destroyAll): (WTF::::~Deque): (WTF::::swap): (WTF::::clear): (WTF::::findIf): (WTF::::expandCapacityIfNeeded): (WTF::::expandCapacity): (WTF::::takeFirst): (WTF::::append): (WTF::::prepend): (WTF::::removeFirst): (WTF::::remove): (WTF::::addToIteratorsList): (WTF::::removeFromIteratorsList): (WTF::::DequeIteratorBase): (WTF::::~DequeIteratorBase): (WTF::::isEqual): (WTF::::increment): (WTF::::decrement): (WTF::::after): (WTF::::before):
  • wtf/Vector.h:
3:22 AM Changeset in webkit [79537] by christian@webkit.org
  • 2 edits in trunk

[GTK] webkitgtk 1.3.7 build without translations
​https://bugs.webkit.org/show_bug.cgi?id=50612

Rubber-stamped by Eric Seidel.

  • GNUmakefile.am: Require stamp-po target for all-local so

that po files are built before they install.

3:09 AM Changeset in webkit [79536] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Crash when deleting inside a blockquote with a large offset
​https://bugs.webkit.org/show_bug.cgi?id=55098

The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
the downstream position to instantiate caretPos.

Co-author: Abhishek Arya <​inferno@chromium.org>.

Test: editing/deleting/delete-blockquote-large-offsets.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Crash when deleting inside a blockquote with a large offset
​https://bugs.webkit.org/show_bug.cgi?id=55098

Added a test to ensure WebKit doesn't crash when deleting line inside a blockquote
and the caret is programmatically set to have a large offset.

Co-author: Abhishek Arya <​inferno@chromium.org>.

  • editing/deleting/delete-blockquote-large-offsets-expected.txt: Added.
  • editing/deleting/delete-blockquote-large-offsets.html: Added.
3:03 AM Changeset in webkit [79535] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
2:57 AM Changeset in webkit [79534] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-02-24 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Darin Fisher.

Added timestamps to PlatformTouchEvent etc.

PlatformTouchEvent doesn't have a timestamp and so
eventSender.leapForward cannot be used for touchevent based tests.
This change adds a timestamp to PlatformTouchEvent and initializes
it in a reasonable manner on Android and Qt platforms.

[chromium] [WebCore] [android] Touch events are missing time stamps
​https://bugs.webkit.org/show_bug.cgi?id=53510

  • platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::timestamp):
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):

2011-02-24 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Darin Fisher.

Added timestamps to PlatformTouchEvent etc.

PlatformTouchEvent doesn't have a timestamp and so
eventSender.leapForward cannot be used for touchevent based tests.
This change constructs PlatformTouchEvents with timestamps
provided from a WebTouchEvent on chromium. It also adds an enum
to make code referring to specific WebTouchPoints easier to read.

[chromium] [WebCore] [android] Touch events are missing time stamps
​https://bugs.webkit.org/show_bug.cgi?id=53510

  • public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
  • src/WebInputEventConversion.cpp: (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
2:49 AM Changeset in webkit [79533] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-02-24 Andreas Kling <​kling@webkit.org>

Unreviewed Qt rebaseline.

  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
2:36 AM Changeset in webkit [79532] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Mac rebaselines for r79490 and r79493.

  • fast/repaint/text-emphasis-h-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
2:24 AM Changeset in webkit [79531] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip 2 fixed SVG tests on GTK after r79530.

  • platform/gtk/Skipped:
2:21 AM Changeset in webkit [79530] by reni@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed GTK, Snow Leopard build fix for r79474.

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setKernelUnitLength):

  • platform/graphics/filters/FEConvolveMatrix.h:
2:18 AM Changeset in webkit [79529] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <​morrita@google.com>

Unreviewed skipping failing tests. (r79517 removed too many.)

  • platform/chromium/test_expectations.txt:
2:12 AM Changeset in webkit [79528] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <​pnormand@igalia.com>

Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
canvas/philip/tests/2d.imageData.object.wrap.html on GTK.

They were passing before r79501.

  • platform/gtk/Skipped:
2:00 AM Changeset in webkit [79527] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
canvas/philip/tests/2d.imageData.object.wrap.html on Mac.

It was removed from the skipped list in r64156 but it wasn't added back
when r79501 reverted it.

  • platform/mac/Skipped:
1:34 AM Changeset in webkit [79526] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Xan Lopez.

Use IntRect instead of a pointer to a GtkAllocation struct to avoid
unnecessary memory allocations.

  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::plugAddedCallback):
1:30 AM Changeset in webkit [79525] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky media test on GTK.

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [79524] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix the build with GTK+ 3.

  • plugins/PluginView.h:
12:55 AM Changeset in webkit [79523] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping 2 GTK+ SVG crashing tests.

  • platform/gtk/Skipped:
12:22 AM Changeset in webkit [79522] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <​morrita@google.com>

Unreviewed skipping failing tests.

  • platform/chromium/test_expectations.txt:
12:20 AM Changeset in webkit [79521] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Refactor HTMLEquivalent into a hierachy of classes
​https://bugs.webkit.org/show_bug.cgi?id=55025

Converted HTMLEquivalent into a class. Some logic in removeImplicitlyStyledElement is
extracted as member functions of HTMLEquivalent and its subclasses.

  • editing/ApplyStyleCommand.cpp: (WebCore::HTMLEquivalent::create): Added. (WebCore::HTMLEquivalent::~HTMLEquivalent): Added. (WebCore::HTMLEquivalent::matches): Returns true if the element is an equivalent, meaning that the element's implicit style affects the property of this equivalence. (WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalence requires attributes; e.g. color, size, dir. (WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the property of this equivalence exists in the specified style. e.g. if this equivalence is for size attribute and font-size property, this function returns true if the specified style has font-size property set. (WebCore::HTMLEquivalent::HTMLEquivalent): Added. (WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the specified style has the implicit style of the specified element of this equivalence. (WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the element of this equivalence to the specified mutable style. (WebCore::HTMLEquivalentValueList::create): Added. (WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added. (WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added. (WebCore::HTMLEquivalentAttribute::create): Added. (WebCore::HTMLEquivalentAttribute::matches): Added. (WebCore::HTMLEquivalentAttribute::hasAttribute): Added. (WebCore::HTMLEquivalentAttribute::attributeName): Added. (WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added. (WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added. (WebCore::HTMLEquivalentAttribute::addToStyle): Added. (WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added. (WebCore::HTMLEquivalentFontSizeAttribute::create): Added. (WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribute): Added. (WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Added. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new classes.
12:13 AM Changeset in webkit [79520] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-02-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

fix revision number finding when creating git patches
​https://bugs.webkit.org/show_bug.cgi?id=55024

HEAD~n does not walk merge commits correctly. git log however does.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:

Feb 23, 2011:

11:56 PM Changeset in webkit [79519] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-22 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

Add missing files to JavaScriptCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=55020

gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.

11:03 PM Changeset in webkit [79518] by Csaba Osztrogonác
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r79510.
​http://trac.webkit.org/changeset/79510
​https://bugs.webkit.org/show_bug.cgi?id=55114

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-02-23
It made ~200 tests crash on Qt bot (Requested by Ossy_ on
#webkit).

  • platform/text/TextBreakIterator.h:
  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::lineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::lineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h:

(WebCore::isBreakable):

10:05 PM Changeset in webkit [79517] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed unskipping another passed tests.

  • platform/chromium/test_expectations.txt:
9:14 PM Changeset in webkit [79516] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-02-23 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a couple GTK+ test results.

  • platform/gtk/fast/repaint/text-emphasis-h-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
8:21 PM Changeset in webkit [79515] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-23 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

autocomplete=off prevents refilling form fields on back/forward navigation
​https://bugs.webkit.org/show_bug.cgi?id=47463

I haven't actually run this patch due to the difficulty of getting
a bugzilla instance running. It's simple enough code that I'm not too worried
about it.

  • committers-autocomplete.js:
7:38 PM Changeset in webkit [79514] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed unskipping passed tests.

  • platform/chromium/test_expectations.txt:
6:12 PM Changeset in webkit [79513] by ggaren@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebCore

Used svn merge -r79502:79501 to roll out r79502 because it broke the
SnowLeopard and Leopard builds.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/HTMLConverter.h: Removed.
  • platform/mac/HTMLConverter.mm: Removed.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

5:56 PM Changeset in webkit [79512] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Refactored MarkedSpace to operate in terms of size classes
​https://bugs.webkit.org/show_bug.cgi?id=55106


SunSpider reports no change.

  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::MarkedSpace::allocate): Delegate allocation based on size class. Since these functions are inline, the compiler can constant fold them.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::cellSize): (JSC::MarkedBlock::size): Factored out a cellSize() helper.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::allocateFromSizeClass): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass): (JSC::MarkedSpace::SizeClass::reset): Changed to operate in terms of abstract SizeClass objects, which are independent linked lists of blocks of a certain size class, instead of a single m_heap object.
5:47 PM Changeset in webkit [79511] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
when scrolling

Reviewed by Dan Bernstein.

When there is both a horizontal and a vertical scrollbar, it is necessary to
include the space between them in the invalidation.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

5:45 PM Changeset in webkit [79510] by mitz@apple.com
  • 9 edits in trunk/Source/WebCore

Minimize calls to ubrk_setText()
​https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <​nholbrook@apple.com> on 2011-02-23
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

  • platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.cpp.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.

  • rendering/RenderText.cpp: Use a local LazyLineBreakIterator.

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than TextBreakIterator.

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h: Accept LazyLineBreakIterator rather than TextBreakIterator.

(WebCore::isBreakable):

5:40 PM Changeset in webkit [79509] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove some of the old accelerated compositing code
​https://bugs.webkit.org/show_bug.cgi?id=55084

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext): (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
  • UIProcess/win/WebView.cpp:
  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/WebPage.h:
5:28 PM Changeset in webkit [79508] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/mac/HTMLConverter.h:
5:20 PM Changeset in webkit [79507] by eae@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

2011-02-23 Emil A Eklund <​eae@chromium.org>

Unreviewed.

Add myself to the list of committers.

5:00 PM Changeset in webkit [79506] by atwilson@chromium.org
  • 2 edits
    4 deletes in trunk/LayoutTests

Removed outdated/incorrect chromium baselins. Unreviewed.

  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:49 PM Changeset in webkit [79505] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 James Robinson <​jamesr@chromium.org>

Update chromium expectations for fast/repaint/text-emphasis-h.html

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [79504] by jamesr@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

2011-02-23 James Robinson <​jamesr@chromium.org>

Update chromium baselines and expectations.

  • platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Added.
  • platform/chromium-mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/chromium-win/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [79503] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Source

2011-02-23 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
​https://bugs.webkit.org/show_bug.cgi?id=55093

Exclude OSRandomSource.cpp from the Chromium build. This function is
implemented in WebKit/chromium/src instead.

2011-02-23 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
​https://bugs.webkit.org/show_bug.cgi?id=55093

We need to get OS randomness from the WebKit client rather than try to
get it from /dev/urandom directly because WebKit doesn't have access to
the file system when running inside the Chromium sandbox.

  • WebKit.gyp:
  • src/ChromiumOSRandomSource.cpp: Added.
4:09 PM Changeset in webkit [79502] by enrica@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

REGRESSION: Copied content loses formatting on paste to external apps.
​https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

  • WebCore.xcodeproj/project.pbxproj: Added new file.
  • platform/mac/HTMLConverter.h: Added.
  • platform/mac/HTMLConverter.mm: Added.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

4:04 PM Changeset in webkit [79501] by oliver@apple.com
  • 7 edits in trunk

Roll out r64156 as it introduces incorrect behaviour.

4:02 PM Changeset in webkit [79500] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Roll Chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=55096

Rolling to the future, like a truck.

  • DEPS:
3:57 PM Changeset in webkit [79499] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverting an unintentional change that was part of ​http://trac.webkit.org/changeset/79494.
Unreviewed.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::interceptEditingKeyboardEvent):

3:34 PM Changeset in webkit [79498] by atwilson@chromium.org
  • 1 edit
    15 deletes in trunk/LayoutTests

Unreviewed removal of superfluous chromium expectations.

  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/trailing-white-space-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/trailing-white-space-expected.checksum: Removed.
3:27 PM Changeset in webkit [79497] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightUsing to be writing-mode-aware.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):

  • rendering/RenderBox.h:
3:19 PM Changeset in webkit [79496] by mihaip@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed. Revert incorrect baseline added by r79473.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
3:05 PM Changeset in webkit [79495] by Martin Robinson
  • 3 edits
    1 add in trunk/Source/WebCore

2011-02-23 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Flash item placed on wrong location right after load
​https://bugs.webkit.org/show_bug.cgi?id=37769

If a plugin is GtkSocket based, do not set the widget allocation until the
window is actually embedded in the parent. When the window is embedded, use
any pending allocation for the call to gtk_widget_size_allocate. This bug
seems to only appear with Flash movies loaded as the src of an iframe.

  • manual-tests/plugins/windowed-in-iframe.html: Added.
  • plugins/PluginView.h: Add a few new members to track window embedding state.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin wait until the plug-added signal fires to set the widget allocation. (WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that we can access private members. If there is a pending allocation, call gtk_widget_size_allocate with it. (WebCore::PluginView::platformStart): Update the plugin state, so that we do not call gtk_widget_size_allocate if the window isn't embedded.
2:56 PM Changeset in webkit [79494] by enrica@apple.com
  • 18 edits in trunk/Source

Source/WebCore: Mac OS X Services are not available for selected text in WebKit2 windows.
​https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

The changes to WebCore for this bug are limited to exposing a new
entry point in the Editor class to write to the pasteboard and
changes to the Pasteboard class to write the selection with
a given set of pasteboard types. The majority of the work
is done in WebKit2.

  • WebCore.exp.in:
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: Added entrypoint to write the

selection to the pasteboard.
(WebCore::Editor::writeSelectionToPasteboard):

  • platform/Pasteboard.h:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

Source/WebKit2: Mac OS X Services are not available for selected text in WebKit2 windows.
​https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

This patch adds support for Mac OS X Services in WebKit2 windows.
In WKView we now call registerServicesMenuSendTypes providing the
pasteboard types supported by WebKit and we also implement the two
protocol methods required to validate the send type and write the
content to the pasteboard. Unfortunately, AppKit expects the content
to be available in the pasteboard upon return from writeSelectionToPasteboard and
this is the reason why the call to the WebProcess is synchronous.

  • Shared/SelectionState.h:

(WebKit::SelectionState::SelectionState): Extended to include
isContentRichlyEditable

  • Shared/mac/PasteboardTypes.h:
  • Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forSelection): Added.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Added call
to registerServicesMenuSendTypes.
(-[WKView writeSelectionToPasteboard:types:]): Added.
(-[WKView validRequestorForSendType:returnType:]): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::writeSelectionToPasteboard):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Modified to
support the new SelectionState value.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::writeSelectionToPasteboard): Added synchronous
message to write the selected content to the pasteboard.

2:55 PM Changeset in webkit [79493] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Patch computePositionedLogicalHeight to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeight):

2:51 PM Changeset in webkit [79492] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved the "nextAtom" allocation pointer into MarkedBlock for better encapsulation
​https://bugs.webkit.org/show_bug.cgi?id=55079


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reset): Moved Zombie sweeping here, up from MarkedSpace, since we want Heap to logically control MarkedSpace. MarkedSpace should never choose to sweep itself.
  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for nextAtom becoming a member of MarkedBlock. No need to reset nextAtom to firstAtom() when we reach the end of a block, since there's now an explicit reset pass during GC.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::reset): Added the nextAtom data member, and reordered some data members to improve cache locality.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): Removed nextAtom, and added an explicit reset pass.
2:47 PM Changeset in webkit [79491] by mihaip@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Remove tests that pass after
r79473, do the equivalent chromium-mac-leopard update for
fast/text/international/pop-up-button-text-alignment-and-direction.html

  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [79490] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
environment, since height computations will overwrite all values computed here until they are patched as well.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing):

  • rendering/RenderBox.h:
2:22 PM Changeset in webkit [79489] by atwilson@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

More unreviewed expectations cleanup for chromium.

  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
2:11 PM Changeset in webkit [79488] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-23 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FEColorMatrixElement changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=54880

When the FEColorMatrixElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modificiation is covered by the dynamic update tests of FEColorMatrix.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::setType): (WebCore::FEColorMatrix::setValues):
  • platform/graphics/filters/FEColorMatrix.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
  • svg/SVGFEColorMatrixElement.h:
2:08 PM Changeset in webkit [79487] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

[Chromium] Add WebKitClient::cryptographicallyRandomValues
​https://bugs.webkit.org/show_bug.cgi?id=55073

This patch adds a WebKit client API to get cryptographic randomness.
We'll use this API to gather seed randomness while inside the sandbox.

  • public/WebKitClient.h: (WebKit::WebKitClient::cryptographicallyRandomValues):
2:06 PM Changeset in webkit [79486] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-23 James Robinson <​jamesr@chromium.org>

REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name.html fails

Reverts TextCodecUTF16.cpp back to pre-79466 state. The crash fix in 79466 was for UTF-8 only, it also caused the UTF16 path to fail.

  • platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): (WebCore::newStreamingTextDecoderUTF16BE): (WebCore::TextCodecUTF16::decode): (WebCore::TextCodecUTF16::encode):
2:04 PM Changeset in webkit [79485] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidth to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

1:55 PM Changeset in webkit [79484] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a ShareableBitmap::create overload that takes an existing SharedMemory object
​https://bugs.webkit.org/show_bug.cgi?id=55081

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::create):
  • Shared/ShareableBitmap.h:
1:40 PM Changeset in webkit [79483] by jamesr@google.com
  • 4 edits in trunk/Source

2011-02-23 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79428.
​http://trac.webkit.org/changeset/79428
​https://bugs.webkit.org/show_bug.cgi?id=54714

Does not work in the Chromium sandbox

2011-02-23 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r79428.
​http://trac.webkit.org/changeset/79428
​https://bugs.webkit.org/show_bug.cgi?id=54714

Does not work in the Chromium sandbox

  • websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
1:32 PM Changeset in webkit [79482] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Add logical accessors for the left()/right()/top()/bottom() properties on the RenderStyle.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::logicalLeft):
(WebCore::InheritedFlags::logicalRight):
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

1:31 PM Changeset in webkit [79481] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Add failing expectations for
two editing tests that were hidden by the TIMEOUT expectation remove by
r79480.

  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [79480] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed.

Many tests started timing out on the chrome mac canaries around r79035
​https://bugs.webkit.org/show_bug.cgi?id=54885

Remove TIMEOUT expectations from tests, they were caused by a bad bot
(and are passing now that the bot has been restarted).

  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [79479] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Web Inspector toolbar looks bad in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=55076
<rdar://problem/8866258>

  • UIProcess/API/mac/WKView.mm: (-[WKView mouseDownCanMoveWindow]): Return NO from mouseDownCanMoveWindow to prevent drags in the (now transparent) inspector WKView from dragging the window around.
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Call [WKView setDrawsBackground:NO].
1:05 PM Changeset in webkit [79478] by atwilson@chromium.org
  • 1 edit
    290 adds in trunk/LayoutTests

Unreviewed expectations update for chromium.

  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5240265-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/continuationCrash-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-default-title-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-default-title-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-positioned-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-style-color-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-white-space-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/control-clip-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/control-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-selected-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-selected-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/document-write-option-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/064-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/selectors/064-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/append-cells2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/line-breaks-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/line-breaks-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
12:57 PM Changeset in webkit [79477] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix crash seen in one of the regression tests.

Reviewed by Alexey Proskuryakov.

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode): Handle case where we did not decode any new data,
we were not told to flush, and we had a buffered byte. The assertion here was incorrect,
and the correct thing to do is nothing.

12:49 PM Changeset in webkit [79476] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-23 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by James Robinson.

SVGCursorElement::removeClient() should verify that its argument is connected with
the proper cursor element.
​https://bugs.webkit.org/show_bug.cgi?id=54979

Test: svg/css/multiple-cursors-crash.html

  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::removeClient):

2011-02-23 Sergey Glazunov <​serg.glazunov@gmail.com>

Reviewed by James Robinson.

SVGCursorElement::removeClient() should verify that its argument is connected with
the proper cursor element.
​https://bugs.webkit.org/show_bug.cgi?id=54979

  • svg/css/multiple-cursors-crash-expected.txt: Added.
  • svg/css/multiple-cursors-crash.html: Added.
12:45 PM Changeset in webkit [79475] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Fix an off-by-one error in JSC::appendSourceToError

Looks like this bug has been around since the code was first added in r35245.

Fixes <​http://webkit.org/b/55052> <rdar://problem/9043512> Crash in JSC::appendSourceToError
when running fast/dom/objc-big-method-name.html on Windows with full page heap enabled

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError): When trimming whitespace off the end of the string, examine the
character at stop-1 rather than at stop. At this point in the code, stop represents the
index just past the end of the characters we care about, and can even be just past the end
of the entire data buffer.

12:45 PM Changeset in webkit [79474] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-23 Renata Hodovan <​reni@webkit.org>

Reviewed by Darin Adler.

FEConvolveMatrixElement changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=55067

When the FEConvolveMatrixElement receives an update message but the
given value remains the same we don't need to relayout the filter.

No new tests are needed because this modificiation is covered by the
dynamic update tests of FEConvolveMatrix.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setDivisor): (WebCore::FEConvolveMatrix::setBias): (WebCore::FEConvolveMatrix::setTargetOffset): (WebCore::FEConvolveMatrix::edgeMode): (WebCore::FEConvolveMatrix::setEdgeMode): (WebCore::FEConvolveMatrix::setPreserveAlpha):
  • platform/graphics/filters/FEConvolveMatrix.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  • svg/SVGFEConvolveMatrixElement.h:
12:45 PM Changeset in webkit [79473] by Simon Fraser
  • 16 edits
    3 adds
    2 deletes in trunk/LayoutTests

2011-02-22 Simon Fraser <Simon Fraser>

New Leopard results after r78846.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/mac-leopard/fast/dom/52776-expected.txt:
  • platform/mac-leopard/fast/forms/basic-selects-expected.txt:
  • platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
  • platform/mac-leopard/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Removed.
12:25 PM Changeset in webkit [79472] by ggaren@apple.com
  • 12 edits
    3 adds in trunk/Source

2011-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Rolled back in r79367 with SnowLeopard Release bot crash fixed.
​https://bugs.webkit.org/show_bug.cgi?id=54999


The crash was caused by failure to update the "nextBlock" pointer when
removing a block from the list while shrinking. The fix is to update the
"nextBlock" pointer.


This crash was very rare because it only happened in cases where the very
first block in the heap contained no marked cells.

2011-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Rolled back in r79367 with SnowLeopard Release bot crash fixed.
​https://bugs.webkit.org/show_bug.cgi?id=54999

2011-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Rolled back in r79367 with SnowLeopard Release bot crash fixed.
​https://bugs.webkit.org/show_bug.cgi?id=54999

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Added.
12:13 PM Changeset in webkit [79471] by weinig@apple.com
  • 12 edits
    1 delete in trunk/Source/WebKit2

Remove WKPageForceRepaintWithInvalidation and instead make WKPageForceRepaint
always dirty the entire page.

Reviewed by Anders Carlsson.

  • Shared/ForceRepaintFlags.h: Removed.
  • UIProcess/API/C/WKPage.cpp:

(WKPageForceRepaint):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

  • UIProcess/WebPageProxy.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::forceRepaint):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • win/WebKit2.vcproj:
12:08 PM Changeset in webkit [79470] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/Source/WebCore

2011-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add more thorough manual test coverage for media controls
​https://bugs.webkit.org/show_bug.cgi?id=55006

  • manual-tests/media-controls.html: Added.
12:07 PM Changeset in webkit [79469] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode): Removed stray unused local variable.

12:06 PM Changeset in webkit [79468] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Setting shadow host should also attach and set inDocument, just like
appending/inserting a child.
​https://bugs.webkit.org/show_bug.cgi?id=55065

No new tests, because functionality is not yet used.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Add attaching and setting inDocument

for the shadow DOM subtree, like the host.

12:00 PM Changeset in webkit [79467] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Darin Adler and Simon Fraser.

  • Add clientLogicalWidth and clientLogicalHeight that call the correct clientWidth or clientHeight based off

writing-mode.

  • Patch clientLogicalBottom to use clientLogicalHeight.
  • Convert containingBlockWidthForPositioned and containingBlockHeightForPositioned to be logical and to make use of

clientLogicalHeight/Width. Also make them able to handle perpendicular writing mode containining blocks.

  • Refine containingBlockLogicalHeightForPositioned to match containingBlockLogicalWidthForPositioned more closely.


  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
(WebCore::RenderBox::clientLogicalBottom):

12:00 PM Changeset in webkit [79466] by Darin Adler
  • 4 edits in trunk/Source/WebCore

2011-02-23 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
​https://bugs.webkit.org/show_bug.cgi?id=54862

Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 decoders when flushing with zero length
​https://bugs.webkit.org/show_bug.cgi?id=54444

No new tests at this time. I will add some tests later, but since multiple
people are hitting this I wanted to get it in as quickly as possible.

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit. Removed special case for zero length now that main code handles it correctly. Used words instead of abbreviations for local variable names. Added error handling for a trailing byte.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper function to make the handleError and handlePartialSequence functions clearer. (WebCore::TextCodecUTF8::handleError): Added. Helper function to make the handlePartialSequence clearer. (WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out code for the partial sequence case. Making this a separate function probably helps make the fast case a little faster. This new version handles more cases correctly, which is what fixes the crashes we were seeing. In particular, it no longer assumes that the partial sequence is truly partial, because there are cases where we end up handling complete sequences here, such as when a complete sequence is inside a malformed partial sequence. (WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this call handlePartialSequence instead. Could be streamlined if we double checked that passing a reference to "destination" and "source" doesn't harm code generation too much, so perhaps someone can do that research on a few compilers later and clean this up. Removed special case for zero length now that the main code handles that correctly.
  • platform/text/TextCodecUTF8.h: Added declarations for new functions. Made partial sequence buffer large enough to hold a whole sequence so we can use it to complete and decode a sequence in place.
11:42 AM Changeset in webkit [79465] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-23 Abhishek Arya <​inferno@chromium.org>

Unreviewed. Qt rebaseline for my crasher test in r79462.

  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
11:17 AM Changeset in webkit [79464] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Race condition when creating and destroying pages quickly
​https://bugs.webkit.org/show_bug.cgi?id=55061
<rdar://problem/8708435>

When the last page in a web process is closed, the web process would
previously terminate, even if the UI process had created a new page
(the CreateNewPage message just wouldn't have reached the web process yet).

Fix this by adding a ShouldTerminate message that the web process sends when it's
about to terminate. If the UI process has any pending pages, downloads etc. it will
prevent the web process from terminating. Otherwise, it will immmediately disconnect
the WebPageProxy so that creating a page after that will launch a new web process.

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::shouldTerminate):
  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::shouldTerminate): (WebKit::WebContext::disconnectProcess):
  • UIProcess/WebContext.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::disconnect): (WebKit::WebProcessProxy::didReceiveSyncMessage): (WebKit::WebProcessProxy::didClose): (WebKit::WebProcessProxy::shouldTerminate):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::terminateIfPossible):
11:03 AM Changeset in webkit [79463] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-23 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] tst_QWebView::setPalette(activeFG) fails
​https://bugs.webkit.org/show_bug.cgi?id=55029

Attempt to make the test more robust. By investigating with the bot virtual machine
I discovered that the activation can take some time. In this patch we make sure that
the active window we want to have is the same as the QApplication.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette):
11:03 AM Changeset in webkit [79462] by inferno@chromium.org
  • 4 edits
    4 adds
    2 deletes in trunk

2011-02-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Rename a layouttest for conformity. Tests that we do not crash
when trying to overflow the logical height of a root inline box.
​https://bugs.webkit.org/show_bug.cgi?id=54995

  • fast/overflow/overflow-block-logical-height-crash-expected.txt: Removed.
  • fast/overflow/overflow-block-logical-height-crash.html: Removed.
  • fast/overflow/overflow-height-float-not-removed-crash2-expected.txt: Added.
  • fast/overflow/overflow-height-float-not-removed-crash2.html: Added.
  • fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
  • fast/overflow/overflow-height-float-not-removed-crash3.html: Added.

2011-02-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Make clear float lineboxes resilient against overflows.
​https://bugs.webkit.org/show_bug.cgi?id=54995

We try to dirty everthing in block range if we have a negative
logical bottom, or if our logical bottom is less than our logical
top, or if our logical top is equal to INT_MAX. Plus, we also dirty
a linebox if its block logical height is less than zero.
Tests: fast/overflow/overflow-height-float-not-removed-crash2.html

fast/overflow/overflow-height-float-not-removed-crash3.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::markLinesDirtyInBlockRange):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack added in r69735. we don't need this anymore since we are making the underlying float dirty logic resilient.
11:01 AM Changeset in webkit [79461] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Include frame numbers in backtraces.
​https://bugs.webkit.org/show_bug.cgi?id=55060

Reviewed by Gavin Barraclough.

  • wtf/Assertions.cpp:
10:55 AM Changeset in webkit [79460] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gavin Barraclough.

latest jsc for armv7 crashes in sunspider tests
​https://bugs.webkit.org/show_bug.cgi?id=54667

Update JIT offset values in ARMv7 after r78732. Fixes crashes in
SunSpider and JavaScript tests.

  • jit/JIT.h: update values.
10:50 AM Changeset in webkit [79459] by mthole@apple.com
  • 2 edits in trunk/Source/WebKit2

WKBundleNavigationAction.h should be exposed as a public header
​https://bugs.webkit.org/show_bug.cgi?id=55059

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Changed WKBundleNavigationAction.h from 'project' to 'public'.

10:34 AM Changeset in webkit [79458] by hans@chromium.org
  • 64 edits in trunk/LayoutTests

2011-02-23 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Each layout test should use a separate DB
​https://bugs.webkit.org/show_bug.cgi?id=55042

Each layout test should use a separate database to avoid problems in
case tests are run concurrently.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/tutorial.html:
10:26 AM Changeset in webkit [79457] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Add final set of
Snow Leopard-only failures.

  • platform/chromium/test_expectations.txt:
10:14 AM Changeset in webkit [79456] by kbr@google.com
  • 4 edits in trunk

2011-02-23 Kenneth Russell <​kbr@google.com>

Unreviewed, rolling out r79387.
​https://bugs.webkit.org/show_bug.cgi?id=54885

Reapply the code changes from r79038 since they weren't the root
cause of the test timeouts.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):

2011-02-23 Kenneth Russell <​kbr@google.com>

Unreviewed, rolling out r79387.
​https://bugs.webkit.org/show_bug.cgi?id=54885

Reapply the code changes from r79038 since they weren't the root
cause of the test timeouts.

  • src/WebKit.cpp: (WebKit::initialize):
10:00 AM Changeset in webkit [79455] by kbr@google.com
  • 4 edits
    4 adds in trunk

2011-02-22 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Per-page minimum DOMTimer interval broken for repeating timers
​https://bugs.webkit.org/show_bug.cgi?id=55014

When the minimum timer interval is adjusted, if the timer is
repeating, cause its repeat interval to be set to its original
timeout clamped to the new minimum interval.

Tests: fast/dom/timer-increase-min-interval-repeating.html

fast/dom/timer-increase-then-decrease-min-interval-repeating.html

  • page/DOMTimer.cpp: (WebCore::DOMTimer::adjustMinimumTimerInterval):

2011-02-23 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Per-page minimum DOMTimer interval broken for repeating timers
​https://bugs.webkit.org/show_bug.cgi?id=55014

Add tests using setInterval rather than setTimeout.
timer-increase-then-decrease-min-interval-repeating.html catches
the bug.

  • fast/dom/timer-increase-min-interval-repeating-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-repeating.html: Added.
  • fast/dom/timer-increase-then-decrease-min-interval-repeating-expected.txt: Added.
  • fast/dom/timer-increase-then-decrease-min-interval-repeating.html: Added.
  • platform/mac-wk2/Skipped:
9:43 AM Changeset in webkit [79454] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

[Windows 7 Release Tests] ~26 tests failing after r78846
​https://bugs.webkit.org/show_bug.cgi?id=54748

Update the pixel results for fast/blockflow/Kusa-Makura-background-canvas.html.
The pixel results for fast/ruby/nested-ruby.html turned out to be identical to
those before r78846. Unreviewed.

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
9:38 AM Changeset in webkit [79453] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark failures from bug 54885
as being Leopard-only (which they are) so that they don't result in
duplicates with all the Snow Leopard expectations.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [79452] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Add more Snow Leopard-only
failures.

  • platform/chromium/test_expectations.txt:
9:10 AM Changeset in webkit [79451] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix two issues seen in WebKit2 views on Mac:

  • <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
  • <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text

Reviewed by Maciej Stachowiak.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
to -1. Since WebKit2 doesn't support non-activating clicks yet (<​http://webkit.org/b/55053>
<rdar://problem/9042197>) and doesn't send event numbers, all events were considered to be
window-activating events. This in turn prevented them from clearing the selection and resuming
caret blinking on mouse up.

9:07 AM Changeset in webkit [79450] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-23 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dan Bernstein.

[Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
​http://trac.webkit.org/changeset/79167 refactored the way the bound size of
the frame is handled. A new API setBoundsSize was added, we need to call it
in addition to setFrameRect. I could call setBoundSize after setFrameRect but
I thought It would be more elegant to use the resize method.

  • Api/qwebpage.cpp: (QWebPage::setViewportSize):
8:38 AM Changeset in webkit [79449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-23 Jacob Dinu <​dinu.jacob@nokia.com>

Reviewed by Pavel Feldman.

Web Inspector: Linking error for some InspectorController symbols
​https://bugs.webkit.org/show_bug.cgi?id=54953

Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::resume):
8:30 AM Changeset in webkit [79448] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Add more Snow Leopard-only
failures.

  • platform/chromium/test_expectations.txt:
8:14 AM Changeset in webkit [79447] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

Added TIMEOUTs that the last change missed.

  • platform/chromium/test_expectations.txt:
7:41 AM Changeset in webkit [79446] by Laszlo Gombos
  • 4 edits in trunk

2011-02-23 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Make sure Symbian binary UIDs are unique

  • WebProcess.pro: Resolve the UID collision with QtTestBrowser.pro by changing the UID.

2011-02-23 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Make sure Symbian binary UIDs are unique

  • MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with QtTestBrowser.pro by changing the UID.
7:10 AM Changeset in webkit [79445] by hans@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-23 Hans Wennborg <​hans@chromium.org>

IndexedDB: Move some SQL code into IDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=54889

The idea is to gather all the SQL logic into IDBBackingStore.

No new functionality, so no new tests.

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::IDBBackingStore): (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::getDatabaseSchemaVersion): (WebCore::migrateDatabase): (WebCore::IDBBackingStore::open): (WebCore::IDBBackingStore::extractIDBDatabaseMetaData): (WebCore::IDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBBackingStore::getObjectStores): (WebCore::IDBBackingStore::createObjectStore): (WebCore::doDelete): (WebCore::IDBBackingStore::deleteObjectStore): (WebCore::whereSyntaxForKey): (WebCore::bindKeyToQuery): (WebCore::IDBBackingStore::getObjectStoreRecord): (WebCore::bindKeyToQueryWithNulls): (WebCore::IDBBackingStore::putObjectStoreRecord): (WebCore::IDBBackingStore::deleteIndexDataForRecord): (WebCore::IDBBackingStore::putIndexDataForRecord): (WebCore::IDBBackingStore::createIndex): (WebCore::IDBBackingStore::deleteIndex): (WebCore::IDBBackingStore::clearObjectStore):
  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::addIDBBackingStore): (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::clearInternal): (WebCore::populateIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
6:48 AM Changeset in webkit [79444] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
6:46 AM Changeset in webkit [79443] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-23 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix the Symbian build after r79334
​https://bugs.webkit.org/show_bug.cgi?id=55044

No new tests as there is no new functionality.

  • WebCore.pri: Reorder symbian blocks to make sure that system-sqlite is set before it is tested.

Copy the rules from JavaScriptCore.pri for defineTest().

2011-02-23 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix the Symbian build after r79334
​https://bugs.webkit.org/show_bug.cgi?id=55044

  • WebKit2.pri: Copy the rules from JavaScriptCore.pri for defineTest().

Remove addWebKit2LibWholeArchive as it is no longer needed.

6:40 AM Changeset in webkit [79442] by morrita@google.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79418.
​http://trac.webkit.org/changeset/79418
​https://bugs.webkit.org/show_bug.cgi?id=55043

"breaks shlib linux build" (Requested by morrita on #webkit).

6:05 AM Changeset in webkit [79441] by Patrick Gansterer
  • 4 edits in trunk/Source

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
​https://bugs.webkit.org/show_bug.cgi?id=54992

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
​https://bugs.webkit.org/show_bug.cgi?id=54992

Also remove the WTF namespace from AtomicString and String.

  • ewk/ewk_view.cpp:
6:00 AM Changeset in webkit [79440] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-23 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, fixed GTK WebKit2 compilation after r79366.

  • GNUmakefile.am:
5:32 AM Changeset in webkit [79439] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Move platform dependent files out of main CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=53891

Apple Windows port does not use the image decoders,
so move them into the platform specific CMake files.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
4:31 AM Changeset in webkit [79438] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
4:05 AM Changeset in webkit [79437] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Jittering when animating a rotated image
​https://bugs.webkit.org/show_bug.cgi?id=50775

Since Skia does not seem to suffer from pixel cracks when scaling to
non-integral sizes the way CG does, no-op roundToDevicePixels on the
Skia implementation.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
3:58 AM Changeset in webkit [79436] by Patrick Gansterer
  • 2 edits
    1 move in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Get rid of TemporaryLinkStubs.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54825

  • CMakeListsWinCE.txt:
  • platform/network/win/CookieStorageWin.cpp: Copied from platform/wince/TemporaryLinkStubs.cpp.
  • platform/wince/TemporaryLinkStubs.cpp: Removed.
3:42 AM Changeset in webkit [79435] by Patrick Gansterer
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54831

  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/Structure.cpp: (JSC::ignoreSetMutex): (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::initializeThreading):
  • runtime/Structure.h:
3:31 AM Changeset in webkit [79434] by Patrick Gansterer
  • 46 edits in trunk

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • runtime/DatePrototype.cpp:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • wtf/CurrentTime.cpp:
  • wtf/Platform.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/text/WTFString.h:
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebCore.gyp/WebCore.gyp:
  • editing/SmartReplace.cpp:
  • editing/SmartReplaceICU.cpp:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail):
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes):
  • platform/FileSystem.h:
  • platform/KURL.h:
  • platform/KURLGoogle.cpp:
  • platform/RunLoopTimer.h:
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::certificatePath):
  • platform/text/cf/StringCF.cpp:
  • platform/text/cf/StringImplCF.cpp:
  • platform/win/BString.cpp:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getWebLocData): (WebCore::getURL): (WebCore::getClipboardData):
  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebCoreSupport/WebInspectorClientCF.cpp:

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebView.cpp:

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::formatLocalizedString):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
​https://bugs.webkit.org/show_bug.cgi?id=53540

  • DumpRenderTree/config.h:
3:15 AM Changeset in webkit [79433] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
3:05 AM Changeset in webkit [79432] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] media/controls-without-preload.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=55028

  • platform/qt/Skipped: Add media/controls-without-preload.html until fix.
2:58 AM Changeset in webkit [79431] by ukai@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-23 Fumitoshi Ukai <​ukai@chromium.org>

Unreviewed build fix for Windows.

WebSocket uses insecure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=54714

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export WTF::cryptographicallyRandomNumber()
2:49 AM Changeset in webkit [79430] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed attempt to fix a flaky test.
​https://bugs.webkit.org/show_bug.cgi?id=51757

  • fast/css/font-face-download-error.html: Increase the wait to 200ms.
2:10 AM Changeset in webkit [79429] by kalman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-23 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ojan Vafai.

Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
​https://bugs.webkit.org/show_bug.cgi?id=51001

Add regression test.

  • editing/selection/extend-backward-by-word-over-non-editable-expected.txt: Added.
  • editing/selection/extend-backward-by-word-over-non-editable.html: Added.

2011-02-23 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ojan Vafai.

Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
​https://bugs.webkit.org/show_bug.cgi?id=51001

Test: editing/selection/extend-backward-by-word-over-non-editable.html

Revert some previous changes (the TextIteratorEndsAtEditingBoundary text iteration behaviour) which caused this
bug in the first place, and fix SimplifiedBackwardsTextIterator's iteration range check as an alternative fix.

The original bug was that double-clicking on an inline editable span at the start of a paragraph would clear the
selection (webkit.org/b/36360). This was caused by upstream/downstream VisbiblePosition complications. To fix,
refuse to iterate beyond the start node (rather than refusing to iterate across editable boundaries, which
causes this bug).

To see why this is correct, and to make it clearer that is indeed what is happening, the text iterator code has
been slightly restructured to express the invariant that the iterator will never advance past the start node.

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Remove references to TextIterationEndsAtEditing boundary. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Remove m_pastStartNode as the mechanism for iteration range checking, and use a flag m_havePassedStartNode instead. (WebCore::SimplifiedBackwardsTextIterator::advance): Clean up, use advanceRespectingRange and m_havePassedStartNode for iteration range checking rather than m_pastStartNode. (WebCore::SimplifiedBackwardsTextIterator::advanceRespectingRange): The new way of modifying m_node which updates m_havePassedStartNode and refuses to continue when it becomes true.
  • editing/TextIterator.h: Remove TextIteratorEndsAtEditingBoundary, update for new/removed prototypes and member variables.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Remove references to TextIteratorEndsAtEditingBoundary.
1:50 AM Changeset in webkit [79428] by ukai@chromium.org
  • 4 edits in trunk/Source

2011-02-23 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=54714

2011-02-23 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=54714

  • websockets/WebSocketHandshake.cpp: (WebCore::randomNumberLessThan): (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
1:42 AM Changeset in webkit [79427] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Takashi Toyoshima <​toyoshim@chromium.org>

Reviewed by Shinichiro Hamaji.

[chromium] Control-Up/Down should be PageUp/Down on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=54606

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard):
1:40 AM Changeset in webkit [79426] by hans@chromium.org
  • 13 edits
    2 moves in trunk/Source/WebCore

2011-02-21 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBSQLiteDatabase to IDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=54864

No new functionality, so no new tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::IDBBackingStore): (WebCore::IDBBackingStore::~IDBBackingStore):
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::create): (WebCore::IDBBackingStore::db):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::sqliteDatabase): (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore): (WebCore::openSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::sqliteDatabase):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal): (WebCore::IDBObjectStoreBackendImpl::loadIndexes): (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create):
1:30 AM Changeset in webkit [79425] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-23 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Kenneth Russell.

Add a new test to make sure that a canvas can receive click events and
that hit testing is working correctly.

​https://bugs.webkit.org/show_bug.cgi?id=54697

  • canvas/canvas-mouse-events-expected.txt: Added.
  • canvas/canvas-mouse-events.html: Added.
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win-wk2/Skipped:

2011-02-23 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Kenneth Russell.

Add a hit test handler for canvas elements that handles clicks on the canvas but ignores children.
​https://bugs.webkit.org/show_bug.cgi?id=54697

New test to prevent this from regressing in the future: canvas/canvas-mouse-events.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::nodeAtPoint):
1:29 AM Changeset in webkit [79424] by dpranke@chromium.org
  • 10 edits
    1 add in trunk/Tools

2011-02-23 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
​https://bugs.webkit.org/show_bug.cgi?id=55016

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
1:28 AM Changeset in webkit [79423] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

Recovered "BUGWK54736 MAC" lines which was removed at r79413.
The failure type became from TEXT+IMAGE to IMAGAE.

  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [79422] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-02-23 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
​https://bugs.webkit.org/show_bug.cgi?id=55004

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment): (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment): (main): Use a C++ object to ensure that TearDownTestEnvironment

gets called when --check-layout-test-sys-deps is called

1:11 AM Changeset in webkit [79421] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu()
​https://bugs.webkit.org/show_bug.cgi?id=54996

Send the signal QWKPage::showContextMenu() with an empty menu even if the content menu generated
is empty/contain only disabled elements.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::showContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu):
1:10 AM Changeset in webkit [79420] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove obsolete focusRingColor functions
​https://bugs.webkit.org/show_bug.cgi?id=54824

  • CMakeListsWinCE.txt:
  • platform/graphics/haiku/ColorHaiku.cpp:
  • platform/graphics/wince/ColorWinCE.cpp: Removed.
1:07 AM Changeset in webkit [79419] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-23 Gopal Raghavan <​gopal.1.raghavan@nokia.com>

Reviewed by Anders Carlsson.

[Qt] [Qt] check webkit style fails in qt/tests
​https://bugs.webkit.org/show_bug.cgi?id=54998

check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.

  • Scripts/webkitpy/style/checker.py:
12:59 AM Changeset in webkit [79418] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-22 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

Add missing files to JavaScriptCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=55020

gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.

12:56 AM Changeset in webkit [79417] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-23 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of media tests.

  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
12:45 AM Changeset in webkit [79416] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Remove passing tests.
12:27 AM Changeset in webkit [79415] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Anna Cavender <​annacc@chromium.org>

Reviewed by Mihai Parparita.

Avoid flakiness due to async drawing of control glyphs by acting on "canplaythrough" instead of "playing".
​https://bugs.webkit.org/show_bug.cgi?id=54640

  • media/video-display-toggle.html:
12:08 AM Changeset in webkit [79414] by Csaba Osztrogonác
  • 43 edits
    10 adds in trunk/LayoutTests

Unreviewed.

[Qt] <select>s on ​http://www.ryanair.com render wrong
​https://bugs.webkit.org/show_bug.cgi?id=29647

Update Qt specific expected files after r79407.

  • platform/qt/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4641033-expected.png: Added.
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4944770-1-expected.png: Added.
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4944770-2-expected.png: Added.
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.checksum:
  • platform/qt/editing/selection/caret-before-select-expected.png:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.checksum:
  • platform/qt/fast/forms/basic-selects-expected.png:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/qt/fast/forms/menulist-style-color-expected.png: Added.
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.png:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.checksum:
  • platform/qt/tables/mozilla/core/margins-expected.png:
  • platform/qt/tables/mozilla/core/margins-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:

Feb 22, 2011:

11:49 PM Changeset in webkit [79413] by morrita@google.com
  • 144 edits
    29 adds in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed, added or updated more Leopard-specific expectations for Chromium.

  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-security-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-security-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium/test_expectations.txt:
11:13 PM Changeset in webkit [79412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-22 Fabrizio Machado <​fabrizio.machado@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
​https://bugs.webkit.org/show_bug.cgi?id=54976

Test not needed.

  • WebCoreSupport/InspectorClientQt.cpp:
11:06 PM Changeset in webkit [79411] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-22 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

On Mac OS X, English contractions are marked misspelled with certain user preference setting.
​https://bugs.webkit.org/show_bug.cgi?id=54975

manual test: manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html

Without this patch, we check for contraction only when autocorrection or other type of auto-
substituation is on. And we failed to check for contraction if only spellchecking is turned on.
This patch implements the desired behavior, checking for contraction when either correction/substitution,
or spellchecking, is on.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html: Added.
10:58 PM Changeset in webkit [79410] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-22 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Remove DatabasePolicy from FrameLoaderTypes
​https://bugs.webkit.org/show_bug.cgi?id=54968

The DatabasePolicy enum is no longer needed now that we avoid stopping
loaders on same-document navigations.

Existing test: storage/hash-change-with-xhr.html

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • workers/WorkerThread.cpp:
10:54 PM Changeset in webkit [79409] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-22 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QWebView ignores a palette set with QWebView::setPalette()
​https://bugs.webkit.org/show_bug.cgi?id=31742

Use custom QWebView palette if the view provides one.
Modified version of a patch made by Fabrizio Machado.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformFocusRingColor):

2011-02-22 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QWebView ignores a palette set with QWebView::setPalette()
​https://bugs.webkit.org/show_bug.cgi?id=31742

Test case to check that the palette sets on the QWebView is taken
into account.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette_data): (tst_QWebView::setPalette):
10:48 PM Changeset in webkit [79408] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Brian Salomon <​bsalomon@google.com>

Reviewed by Kenneth Russell.

Don't disable accelerated canvas when using the skia gpu backend.

No new tests are required.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
10:41 PM Changeset in webkit [79407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] <select>s on ​http://www.ryanair.com render wrong
​https://bugs.webkit.org/show_bug.cgi?id=29647

Reducing padding in <select> elements to improve its rendering and introducing a
rendering adjustment specific to QMacStyle.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::setPopupPadding): (WebCore::RenderThemeQt::paintMenuList):
10:38 PM Changeset in webkit [79406] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
10:04 PM Changeset in webkit [79405] by morrita@google.com
  • 2 edits
    102 adds in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed, added Leopard-specific expectations for Chromium.

  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Added.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
10:01 PM Changeset in webkit [79404] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

LLVM Compiler build fix.

  • Scripts/webkit2/messages.py:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:
9:54 PM Changeset in webkit [79403] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

2011-02-22 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should dump as text if test path contains "dumpAsText/"
​https://bugs.webkit.org/show_bug.cgi?id=54873

  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpAsText): (LayoutTestController::setShouldGeneratePixelResults):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldDumpAsText): (dump): (runTest):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldDumpAsText): (runTest):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isDumpAsTextTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldDumpAsText): (runTest):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
9:53 PM Changeset in webkit [79402] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Andreas Kling <​kling@webkit.org>

Reviewed by Dan Bernstein.

FontCache: Make cTargetInactiveFontData an int instead of float.
​https://bugs.webkit.org/show_bug.cgi?id=54963

  • platform/graphics/FontCache.cpp:
9:51 PM Changeset in webkit [79401] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Fix for media/video-replaces-poster.html. The test was failing because it assumes the results of a seek will be immediately available, when in fact the seek is asynchronous. I did not remove the line in test-expectations because rebaselines for many (all?) platforms will likely be needed after this patch lands. See also, ​http://code.google.com/p/chromium/issues/detail?id=60244
​https://bugs.webkit.org/show_bug.cgi?id=54910

  • media/video-replaces-poster.html:
9:49 PM Changeset in webkit [79400] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; second attempt to land Windows 7 expected failure results for new tests from r79318
​http://webkit.org/b/54966 tracks the failure.

  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
9:39 PM Changeset in webkit [79399] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] focus first visible node if no node is focused
​https://bugs.webkit.org/show_bug.cgi?id=54935

Now hitting j/k/n/p will focus the first/last visible node
if no other node is focused. Also tweaked the scroll into view
logic a bit to avoid scrolling in this case.

  • code-review.js:
9:35 PM Changeset in webkit [79398] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Make Editor::selectionComputedStyle return EditingStyle
​https://bugs.webkit.org/show_bug.cgi?id=54933

Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
It also no longer takes a boolean shouldUseFixedFontDefaultSize.

Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
by an existing layout test only after the code was shared with selectionStartStyle.

No tests are added since this is a refactoring.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  • editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle. (WebCore::EditingStyle::mergeTypingStyle): Added.
  • editing/EditingStyle.h: (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::selectionStartCSSPropertyValue): Ditto. (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
9:30 PM Changeset in webkit [79397] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] painting of windowed plugins faulty on certain scroll events

​https://bugs.webkit.org/show_bug.cgi?id=52735

Invalidate the pluginview's relative rect rather then the frameRect(). This is because QWebFrame::renderRelativeCoords()
imitates ScrollView and adds the scroll offset back on to the rect we damage here (making the co-ordinates absolute
to the frame again) before passing it to FrameView.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
9:29 PM Changeset in webkit [79396] by Laszlo Gombos
  • 22 edits
    2 adds in trunk

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • http/tests/navigation/useragent-expected.txt: Added.
  • http/tests/navigation/useragent.php: Added.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • StringsNotToBeLocalized.txt: Change the User Agent string template.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • webkit/webkitwebsettings.cpp: (webkitUserAgent):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Drop the language tag part.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange test.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::userAgent):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
​https://bugs.webkit.org/show_bug.cgi?id=54560

  • UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent): Drop the language tag part and fix style.
9:27 PM Changeset in webkit [79395] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Update Snow Leopard
expectations (some SVG tests now pass thanks to patches for bug 54474,
others now fail).

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [79394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

Minimal build broken
​https://bugs.webkit.org/show_bug.cgi?id=54743

Moved the code of setInspectorExtensionAPI and
dispatchMessageFromFrontend out of #if
ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::dispatchMessageFromFrontend):
8:49 PM Changeset in webkit [79393] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/Source/JavaScriptGlue

2011-02-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a GYP project for JavaScriptGlue
​https://bugs.webkit.org/show_bug.cgi?id=55019

This is really just a proof-of-concept. The Xcode project file it
produces is able to build JavaScriptGlue, but it's not 100% correct.
Also, the GYP declarations aren't properly structured to allow for
multiple projects or ports. That should get better as we add
proof-of-concepts for other projects and ports.

This build system is not used currently.

  • gyp: Added.
  • gyp/JavaScriptGlue.gyp: Added.
  • gyp/JavaScriptGlue.gypi: Added.
8:45 PM Changeset in webkit [79392] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-02-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; fixed Windows expected failure results added by r79328 for new tests from r79318
​http://webkit.org/b/54966 tracks the failure.

  • platform/win-xp/media: Added.
  • platform/win-xp/media/audio-repaint-expected.txt: Added.
  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Added.
  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
7:35 PM Changeset in webkit [79391] by weinig@apple.com
  • 11 edits
    1 add in trunk/Source/WebKit2

Add WebKit2 API to force a repaint with an invalidation
​https://bugs.webkit.org/show_bug.cgi?id=55015

Reviewed by Anders Carlsson.

  • Shared/ForceRepaintFlags.h: Added.
  • UIProcess/API/C/WKPage.cpp:

(WKPageForceRepaint):
(WKPageForceRepaintWithInvalidation):

  • UIProcess/API/C/WKPage.h:

Add WKPageForceRepaintWithInvalidation which does the same thing WKPageForceRepaint
but also calls setNeedsDisplay on the entire bounds of the page.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::forceRepaint):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe the flag down to the WebProcess.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add ForceRepaintFlags.h.

7:31 PM Changeset in webkit [79390] by rniwa@webkit.org
  • 12 edits
    3 deletes in trunk/Source

2011-02-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
​http://trac.webkit.org/changeset/79367
​https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::collectorBlock):
  • wtf/CMakeLists.txt:
  • wtf/DoublyLinkedList.h: Removed.

2011-02-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
​http://trac.webkit.org/changeset/79367
​https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.

2011-02-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
​http://trac.webkit.org/changeset/79367
​https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
7:30 PM Changeset in webkit [79389] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] remove patch fuzzing
​https://bugs.webkit.org/show_bug.cgi?id=54940

This code is buggy and not as necessary now that we
include svn revision numbers in uploaded patches.

  • code-review.js:
7:25 PM Changeset in webkit [79388] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Mihai Parparita <​mihaip@chromium.org>

Unreviewed Chromium expectations update. Uncomment SNOWLEOPARD
expectations, since we still fail all those tests on Snow Leopard
(lines were commented out by r79275).

  • platform/chromium/test_expectations.txt:
7:23 PM Changeset in webkit [79387] by kbr@google.com
  • 4 edits in trunk

2011-02-22 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Many tests started timing out on the chrome mac canaries around r79035
​https://bugs.webkit.org/show_bug.cgi?id=54885

Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).

  • src/WebKit.cpp: (WebKit::initialize):

2011-02-22 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Many tests started timing out on the chrome mac canaries around r79035
​https://bugs.webkit.org/show_bug.cgi?id=54885

Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
7:11 PM Changeset in webkit [79386] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:07 PM Changeset in webkit [79385] by mrowe@apple.com
  • 1 copy in tags/Safari-534.21

New tag.

6:36 PM Changeset in webkit [79384] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Marked tests as failing (image + text) on chromium, to reflect now-deleted rebaselines.

  • platform/chromium/test_expectations.txt:
6:31 PM Changeset in webkit [79383] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

2011-02-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/9039670>

Make sure that we set the accelerateDrawing property on the LayerTreeHosts's
non-composited content layer if the preference is set.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac):
6:22 PM Changeset in webkit [79382] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
​https://bugs.webkit.org/show_bug.cgi?id=54944

Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.

Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
which returns true iff the specified element has inline style that conflicts or matches the editing style.
It also appends conflicting property IDs to the vector of property IDs if one is specified.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as conflictsWithInlineStyleOfElement. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto. (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
  • editing/EditingStyle.h: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
6:15 PM Changeset in webkit [79381] by atwilson@chromium.org
  • 18 edits
    6 adds in trunk/LayoutTests

Unreviewed chromium-gpu expectations update.

  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium/test_expectations.txt:
6:09 PM Changeset in webkit [79380] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by James Robinson.

nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
​https://bugs.webkit.org/show_bug.cgi?id=55009

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
6:08 PM Changeset in webkit [79379] by Martin Robinson
  • 1 edit
    6 adds in trunk/LayoutTests

2011-02-22 Martin Robinson <​mrobinson@igalia.com>

Add missing files from r79351. These are expected results for new media tests.

  • platform/gtk/media/audio-repaint-expected.checksum: Added.
  • platform/gtk/media/audio-repaint-expected.png: Added.
  • platform/gtk/media/audio-repaint-expected.txt: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.png: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.txt: Added.
5:51 PM Changeset in webkit [79378] by atwilson@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

Unreviewed expectations change for chromium.

  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt:
  • platform/chromium/test_expectations.txt:
5:37 PM Changeset in webkit [79377] by chang.shu@nokia.com
  • 4 edits in trunk/Source

2011-02-22 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] editing/deleting/5408255.html fails
​https://bugs.webkit.org/show_bug.cgi?id=54964

Move WebCore resource file to QtWebKit since they are referred in WebKit.

2011-02-22 Chang Shu <​cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] editing/deleting/5408255.html fails
​https://bugs.webkit.org/show_bug.cgi?id=54964

Move WebCore resource file to QtWebKit since they are referred in WebKit.

  • WebCore.pro:
5:25 PM Changeset in webkit [79376] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix it Windows-style.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

5:21 PM Changeset in webkit [79375] by morrita@google.com
  • 17 edits
    2 deletes in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update to catch up r79359.

  • platform/chromium-linux/media/audio-repaint-expected.checksum:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.checksum:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
4:58 PM Changeset in webkit [79374] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Remove no-longer-necessary test expectation (LINUX video-cancel-load)
​https://bugs.webkit.org/show_bug.cgi?id=55003

Patch by Ami Fischman <​fischman@chromium.org> on 2011-02-22
Reviewed by Peter Kasting.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [79373] by atwilson@chromium.org
  • 111 edits
    16 adds
    442 deletes in trunk/LayoutTests

Revert "Unreviewed rebaselines for Chromium." because the baselines were put in the wrong directory.

This partially reverts r79034 (we keep test_expectations the same as it is currently to avoid breaking the canaries).

4:42 PM Changeset in webkit [79372] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Rename WebProcess::shutdownIfPossible to WebProcess::terminateIfPossible
​https://bugs.webkit.org/show_bug.cgi?id=55008

  • WebProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::downloadFinished):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::removeWebPage): (WebKit::WebProcess::terminateIfPossible): (WebKit::WebProcess::getSitesWithPluginData):
  • WebProcess/WebProcess.h:
  • WebProcess/gtk/WebProcessGtk.cpp: (WebKit::WebProcess::platformTerminate):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformTerminate):
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformTerminate):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformTerminate):
4:30 PM Changeset in webkit [79371] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build-fix attempt.

  • win/WebKit2Generated.make:
4:14 PM Changeset in webkit [79370] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed.

<rdar://problem/8762042> and ​https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

[Qt][WK2] Buildfix after r79364.

  • DerivedSources.pro:
  • WebKit2.pri:
4:14 PM Changeset in webkit [79369] by mihaip@chromium.org
  • 39 edits
    3 copies in branches/chromium/648

Merge 79107 - 2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Tests that going forward within the same document does not stop loading.

  • http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
  • http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
  • http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • loader/EmptyClients.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
  • page/Page.cpp:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Call Page::goToItem instead of HistoryController::goToItem, so that
FrameLoader::stopAllLoaders is called first. Also adds a callback in
FrameLoaderClient for checking for pseudo-back-forward URLs.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
  • WebKitSupport/FrameLoaderClientWx.h:

2011-02-19 Charlie Reis <​creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
​https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

BUG=73444
TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6541090

4:10 PM Changeset in webkit [79368] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8762042> and ​https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

Implement these to be used by WK2 API:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):

3:23 PM Changeset in webkit [79367] by ggaren@apple.com
  • 12 edits
    2 copies
    1 add in trunk/Source

2011-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
​https://bugs.webkit.org/show_bug.cgi?id=54999


SunSpider reports no change.

  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::setPrev): (JSC::MarkedBlock::setNext): (JSC::MarkedBlock::prev): (JSC::MarkedBlock::next): Added linked list data members and accessors.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): Stop using vector, since it doesn't exist anymore.

(JSC::MarkedSpace::freeBlocks): New helper function for updating relevant
data structures when freeing blocks.

(JSC::MarkedSpace::allocate): Updated for nextBlock being a pointer and
not a vector index.

(JSC::MarkedSpace::shrink): Construct a temporary list of empties and
then free them, to avoid modifying our hash table while iterating it.
This wasn't a concern before because we were using indirect array
indexing, not direct pointer indexing.

(JSC::MarkedSpace::reset): Updated for nextBlock being a pointer and
not a vector index.

  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): Changed data type from vector to linked list.
  • wtf/DoublyLinkedList.h: Added. New linked list class. (WTF::::DoublyLinkedList): (WTF::::isEmpty): (WTF::::head): (WTF::::append): (WTF::::remove):

2011-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
​https://bugs.webkit.org/show_bug.cgi?id=54999


New WTF header.

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.

2011-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
​https://bugs.webkit.org/show_bug.cgi?id=54999


New WTF header.

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
3:22 PM Changeset in webkit [79366] by andersca@apple.com
  • 9 edits
    2 deletes in trunk/Source/WebKit2

2011-02-22 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson and looked over by Brian Weinstein.

<rdar://problem/8762042> and ​https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.

Project file changes:

  • GNUmakefile.am:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

WK2 build-system and API paperwork:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:

  • Shared/SecurityOriginData.cpp: (WebKit::performAPICallbackWithSecurityOriginDataVector):
  • Shared/SecurityOriginData.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::~WebContext): (WebKit::WebContext::processDidClose): (WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
  • UIProcess/WebContext.h: (WebKit::WebContext::applicationCacheManagerProxy): (WebKit::WebContext::resourceCacheManagerProxy):

Add API to get the ApplicationCacheManager for a context:

  • UIProcess/API/C/WKContext.cpp: (WKContextGetApplicationCacheManager): (WKContextGetResourceCacheManager):
  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebApplicationCacheManagerProxy:

  • UIProcess/API/C/WKApplicationCacheManager.cpp: Added. (WKApplicationCacheManagerGetTypeID): (WKApplicationCacheManagerGetApplicationCacheOrigins): (WKApplicationCacheManagerDeleteEntriesForOrigin): (WKApplicationCacheManagerDeleteAllEntries):
  • UIProcess/API/C/WKApplicationCacheManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebApplicationCacheManagerProxy.cpp: Added. (WebKit::WebApplicationCacheManagerProxy::create): (WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::invalidate): (WebKit::WebApplicationCacheManagerProxy::didReceiveMessage): (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here. (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebApplicationCacheManagerProxy.h: Added. (WebKit::WebApplicationCacheManagerProxy::clearContext): (WebKit::WebApplicationCacheManagerProxy::type):
  • UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/ApplicationCache: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added. (WebKit::WebApplicationCacheManager::shared): (WebKit::WebApplicationCacheManager::WebApplicationCacheManager): (WebKit::WebApplicationCacheManager::didReceiveMessage): (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries):
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
3:01 PM Changeset in webkit [79365] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; neglected to update an expected result after changing some
boilerplate text at the top of the test.

  • media/audio-repaint-expected.txt:
2:52 PM Changeset in webkit [79364] by beidson@apple.com
  • 21 edits
    9 adds in trunk/Source/WebKit2

<rdar://problem/8762042> and ​https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson and looked over by Brian Weinstein.

I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.

Project file changes:

  • GNUmakefile.am:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

WK2 build-system and API paperwork:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/SecurityOriginData.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.

  • UIProcess/WebContext.h:

(WebKit::WebContext::applicationCacheManagerProxy):
(WebKit::WebContext::resourceCacheManagerProxy):

Add API to get the ApplicationCacheManager for a context:

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetApplicationCacheManager):
(WKContextGetResourceCacheManager):

  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebApplicationCacheManagerProxy:

  • UIProcess/API/C/WKApplicationCacheManager.cpp: Added.

(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):

  • UIProcess/API/C/WKApplicationCacheManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebApplicationCacheManagerProxy.cpp: Added.

(WebKit::WebApplicationCacheManagerProxy::create):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::invalidate):
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

  • UIProcess/WebApplicationCacheManagerProxy.h: Added.

(WebKit::WebApplicationCacheManagerProxy::clearContext):
(WebKit::WebApplicationCacheManagerProxy::type):

  • UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/ApplicationCache: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.

(WebKit::WebApplicationCacheManager::shared):
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::didReceiveMessage):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
2:34 PM Changeset in webkit [79363] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-22 Ami Fischman <​fischman@chromium.org>

Reviewed by Eric Carlson.

Second attempt at removing flakiness from media/video-poster.html (in
service of ​http://crbug.com/60845). First attempt (r79161)
relied on load & error events firing on the video element for
poster-related events, which the standard does not specify (and
are thus a bug). This change instead relies on a 20ms sleep loop to
observe the new expected dimensions (and relies on the test
runner to time out if the expectations fail to be met).

​https://bugs.webkit.org/show_bug.cgi?id=54685

  • media/video-poster.html:
2:29 PM Changeset in webkit [79362] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Get rid of WebProcessManager::getAllWebProcessContexts
​https://bugs.webkit.org/show_bug.cgi?id=55000

  • Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval): Call WebContext::allContexts instead.
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h: Add a vector of WebContext objects. Update it when creating and destroying contexts.
  • UIProcess/WebProcessManager.cpp:
  • UIProcess/WebProcessManager.h: Remove WebProcessManager::getAllWebProcessContexts.
2:29 PM Changeset in webkit [79361] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79339.
​http://trac.webkit.org/changeset/79339
​https://bugs.webkit.org/show_bug.cgi?id=54974

Baselines were put in the wrong directory, so we need to
continue to ignore failures

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [79360] by Beth Dakin
  • 10 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=54991
Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
Scrollbars
-and corresponding-
<rdar://problem/9034318>

Reviewed by Sam Weinig.

Instead of consulting the theme directly, callers should ask the Scrollbar or
ScrollableArea if the scrollbars are overlay or not.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::hasOverlayScrollbars):

  • platform/ScrollableArea.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::isOverlayScrollbar):

  • platform/Scrollbar.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):

  • rendering/RenderScrollbar.h:

(WebCore::RenderScrollbar::isOverlayScrollbar):

2:09 PM Changeset in webkit [79359] by jer.noble@apple.com
  • 9 edits
    1 add in trunk/LayoutTests

2011-02-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

media/audio-repaint.html flakey.
​https://bugs.webkit.org/show_bug.cgi?id=54970

Audio repaint tests flakey, as they took a snapshot 1.5s into a 7s file. Tests
modified to test against a 1s file, and will trigger a snapshot when the audio
finishes seeking to the 1/2way point.

  • media/audio-repaint-expected.txt:
  • media/audio-repaint.html:
  • media/content/silence.wav: Added.
  • media/media-document-audio-repaint-expected.txt:
  • media/media-document-audio-repaint.html:
  • platform/mac/media/audio-repaint-expected.checksum:
  • platform/mac/media/audio-repaint-expected.png:
  • platform/mac/media/media-document-audio-repaint-expected.checksum:
  • platform/mac/media/media-document-audio-repaint-expected.png:
2:09 PM Changeset in webkit [79358] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Re-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
a crash running fast/loader/empty-embed-src-attribute.html. This matches a
bail out in the default policy delegate in WebKit1.

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2:00 PM Changeset in webkit [79357] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] New fails caused by change(s) between r79317-r79320.

  • platform/qt/Skipped: Skip tests until fix.
1:55 PM Changeset in webkit [79356] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

1:49 PM Changeset in webkit [79355] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Bug 54988 - Re-create StructureTransitionTable class, encapsulate transition table

Reviewed by Sam Weinig.

The Structure class keeps a table of transitions to derived Structure types. Since
this table commonly contains a single entry we employ an optimization where instead
of holding a map, we may hold a pointer directly to a single instance of the mapped
type. We use an additional bit of data to flag whether the pointer is currently
pointing to a table of transitions, or a singleton transition. Previously we had
commonly used a pattern of storing data in the low bits of pointers, but had moved
away from this since it causes false leaks to be reported by the leaks tool. However
in this case, the entries in the map are weak links - this pointer will never be
responsible for keeping an object alive. As such we can use this approach provided
that the bit is set when a table is not in use (otherwise the table would appear to
be leaked).

Additionally, the transition table currently allows two entries to exist for a given
key - one specialized to a particular value, and one not specialized. This is
unnecessary, wasteful, and a little inconsistent. (If you create an entry for a
specialized value, then a non-specialized entry, both will exist. If you create an
entry for a non-specialized value, then try to create a specialized entry, only a
non-specialized form will be allowed.)

This shows a small progression on v8.

(JSC::JSObject::putDirectInternal):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC::Structure::get):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):
(JSC::StructureTransitionTable::Hash::equal):
(JSC::StructureTransitionTable::HashTraits::emptyValue):
(JSC::StructureTransitionTable::HashTraits::constructDeletedValue):
(JSC::StructureTransitionTable::HashTraits::isDeletedValue):
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::isUsingSingleSlot):
(JSC::StructureTransitionTable::map):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):

1:45 PM Changeset in webkit [79354] by thakis@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] WebWorkerBase::openFileSystem confuses clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54920

Rename WebWorkerBase::openFileSystem() to openFileSystemForWorker() to
make it obvious it's not an override of
WebFrameClient::openFileSystem().

Remove a failed attempt to override it in WebWorkerClientImpl (the
override didn't change the behavior).

No intended functionality change.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Call new name.
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker): Rename openFileSystem() to openFileSystemForWorker().
  • src/WebWorkerBase.h: Rename openFileSystem() to openFileSystemForWorker().
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase): Remove unsuccessful (and pointless) override.
1:35 PM Changeset in webkit [79353] by atwilson@chromium.org
  • 2 edits
    18 adds in trunk/LayoutTests

Unreviewed expectations change.

[Chromium] Generate results for media/audio-repaint.html and media/media-document-audio-repaint.html
​https://bugs.webkit.org/show_bug.cgi?id=54983

  • platform/chromium-linux/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-linux/media/audio-repaint-expected.png: Added.
  • platform/chromium-linux/media/audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-win/media/audio-repaint-expected.png: Added.
  • platform/chromium-win/media/audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [79352] by abecsi@webkit.org
  • 4 edits in trunk/Source

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Csaba Osztrogonác.

Move inspector's resource files into the final build step to fix the layout test regression.

Source/WebCore:

No new tests needed.

  • WebCore.pro: Move inspector's resource files into QtWebKit.pro.

Source/WebKit/qt:

  • QtWebKit.pro: Add inspector's reaource files.
1:15 PM Changeset in webkit [79351] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-22 Martin Robinson <​mrobinson@igalia.com>

Add some GTK+-specific expectations for new media tests.

  • platform/gtk/Skipped: Unskip tests which now have results.
1:06 PM Changeset in webkit [79350] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
​https://bugs.webkit.org/show_bug.cgi?id=54990

No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
to start passing again.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect): Update this method to match the original in the parent class.
1:01 PM Changeset in webkit [79349] by Martin Robinson
  • 6 edits in trunk

2011-01-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/gtk/Skipped: Unskip passing test.

2011-01-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
​https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/ScrollView.cpp: Remove the GTK+ guards around the implementation of platformAddChild and platformRemoveChild. This code can be shared.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached adjustment. Connect the adjustment value-changed signal handler after resetting the adjustment. This prevents the rest from stomping on pre-existing WebCore values. (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to a scrollview do not listing for value changes. These scrollbars are defunct.
  • platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
1:01 PM Changeset in webkit [79348] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Grammar correction from Spelling & Grammar window doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=54982
<rdar://problem/8940918>

  • UIProcess/API/mac/WKView.mm: (-[WKView isGrammarCheckingEnabled]): (-[WKView setGrammarCheckingEnabled:]): Call down to the text checker.
  • UIProcess/TextChecker.h: Add updateSpellingUIWithGrammarString.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateSpellingUIWithGrammarString): Call TextChecker::updateSpellingUIWithGrammarString.
  • UIProcess/WebPageProxy.messages.in: Add UpdateSpellingUIWithGrammarString message.
  • UIProcess/gtk/TextCheckerGtk.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
  • UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
  • UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Add stubs.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Update the spelling panel.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::updateSpellingUIWithGrammarString): Send an UpdateSpellingUIWithGrammarString message to the UI process.
12:42 PM Changeset in webkit [79347] by Martin Robinson
  • 3 edits in trunk/Source/WebKit/gtk

2011-02-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] position:fixed elements flicker while scrolling after r74196
​https://bugs.webkit.org/show_bug.cgi?id=54981

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations boolean to false. (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we having pending scrolling invalidations, instruct GDK to process updates now. (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
  • WebCoreSupport/ChromeClientGtk.h: Add new boolean member.
12:40 PM Changeset in webkit [79346] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed, adding new pixel tests to the skipped list of various platforms.

media/audio-repaint.html flakey.
​https://bugs.webkit.org/show_bug.cgi?id=54970

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
12:18 PM Changeset in webkit [79345] by pfeldman@chromium.org
  • 20 edits in trunk

2011-02-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
​https://bugs.webkit.org/show_bug.cgi?id=54954

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::JSInjectedScriptHost::inspect):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::V8InjectedScriptHost::inspectCallback):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspect):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspect): (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
11:38 AM Changeset in webkit [79344] by beidson@apple.com
  • 6 edits in trunk/Source

Part of <rdar://problem/8762042> and ​https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

../WebCore:

Stub these out for now:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
(WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac

  • loader/appcache/ApplicationCacheStorage.h:

Export the new symbols:

  • WebCore.exp.in:

../WebKit/mac:

  • WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.

11:36 AM Changeset in webkit [79343] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix debug build.

  • WebCore.exp.in:
11:28 AM Changeset in webkit [79342] by atwilson@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

2011-02-22 Andrew Wilson <​atwilson@chromium.org>

Unreviewed, rolling out r79337.
​http://trac.webkit.org/changeset/79337

GPU-only test should have GPU baselines

  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [79341] by Philippe Normand
  • 1 copy in releases/WebKitGTK/webkit-1.3.12

Branching for WebKitGTK+ release

10:59 AM Changeset in webkit [79340] by enne@google.com
  • 16 edits in trunk/LayoutTests

2011-02-22 Adrienne Walker <​enne@google.com>

Unreviewed rebaseline of some GPU tests.

This cleans up the rest of the BUGWK54409 expectations after r79084.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/test_expectations.txt:
10:56 AM Changeset in webkit [79339] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Prospectively removing test_expectations entries for some tests that seem to be passing now on the canaries.

  • platform/chromium/test_expectations.txt:
10:53 AM Changeset in webkit [79338] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky Inspector test on Windows

<​http://webkit.org/b/54974> tracks the failure.

  • platform/win/Skipped: Added inspector/extensions/extensions-events.html.
10:51 AM Changeset in webkit [79337] by atwilson@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed expectations update for deeply-nested-reflections.html

  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [79336] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Ojan Vafai.

Default to 500 for --exit-after-n-failures
​https://bugs.webkit.org/show_bug.cgi?id=54773

Make 500 the default value for --exit-after-n-failures (ORWT bots
already default to this as of r75726). Similarly, change the default for
--exit-after-n-crashes-or-timeouts to 20.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:45 AM Changeset in webkit [79335] by kbalazs@webkit.org
  • 62 edits
    1 delete in trunk/Source

notImplemented() should behave identical in WebCore and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Source/WebCore:

No functional change so no new tests.

  • WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header

to be able to use it in WebKit2.

Source/WebKit2:

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Removed.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
  • config.h:
  • win/WebKit2.vcproj:
10:41 AM Changeset in webkit [79334] by abecsi@webkit.org
  • 5 edits in trunk/Source

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.

The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.

Source/WebCore:

No new tests needed.

  • WebCore.pri: Add common LIB and CONFIG options.
  • WebCore.pro: Add accidentally moved sections.

Source/WebKit/qt:

  • QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
10:26 AM Changeset in webkit [79333] by Philippe Normand
  • 3 edits in trunk

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.12 release preparation
​https://bugs.webkit.org/show_bug.cgi?id=54967

Version bump for 1.3.12 and updated NEWS file with release notes.
Also bumped libsoup requirement to 2.33.6 as agreed with Sergio
and Martin.

  • Source/WebKit/gtk/NEWS:
  • configure.ac:
10:24 AM Changeset in webkit [79332] by Philippe Normand
  • 3 edits
    2 deletes in trunk

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r79321.
​http://trac.webkit.org/changeset/79321
​https://bugs.webkit.org/show_bug.cgi?id=53146

Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rolling out r79321.
​http://trac.webkit.org/changeset/79321
​https://bugs.webkit.org/show_bug.cgi?id=53146

Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::notifyChildrenSelectionChange): (WebCore::AXObjectCache::postPlatformNotification):
10:19 AM Changeset in webkit [79331] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Invalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.

Rubber-stamped by Brady Eidson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidClose):

9:45 AM Changeset in webkit [79330] by Philippe Normand
  • 2 edits in trunk

Unreviewed, revert the duplicate ChangeLog entries added in r79307, r79312, r79313 and r79314

9:39 AM Changeset in webkit [79329] by Martin Robinson
  • 9 edits in trunk

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

  • platform/gtk/Skipped: Unskip passing tests.

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
listens to this value during DRT runs. Perhaps later we can expose this to the public
API.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk for the appropriate return value.

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
to DumpRenderTreeSupportGtk for this functionality.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to false when reseting values between tests.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace with the appropriate value.
9:16 AM Changeset in webkit [79328] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows expected failure results for new tests from r79318

<​http://webkit.org/b/54966> tracks the failure.

  • platform/win/media/audio-repaint-expected.txt: Added.
  • platform/win/media/media-document-audio-repaint-expected.txt: Added.
8:08 AM Changeset in webkit [79327] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger a Windows build when the top-level ChangeLog changes

r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.

Fixes <​http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.

8:07 AM Changeset in webkit [79326] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Make DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web process

This will be useful for sending repeated messages for the same state ID to the web process.
We don't do this currently, but will need to if we're asked to paint after we've thrown away
our backing store to save memory.

Fixes <​http://webkit.org/b/54916> DrawingAreaProxyImpl should keep track of the state ID it
last sent to the web process

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_requestedStateID, and
reordered member initialization to match the new declaration order.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Added an assertion that the stateID we got
from the web process is no newer than the most recent one we requested.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Changed to increment and send
m_requestedStateID instead of a new global stateID.

  • UIProcess/DrawingAreaProxyImpl.h: Added m_requestedStateID, and moved the state IDs before

other data members. Also beefed the comment explaining m_currentStateID.

8:01 AM Changeset in webkit [79325] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector.IDL change. rename attribute notify -> event.
​https://bugs.webkit.org/show_bug.cgi?id=54958

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
7:44 AM Changeset in webkit [79324] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r78691.
​http://trac.webkit.org/changeset/78691
​https://bugs.webkit.org/show_bug.cgi?id=54956

Leopard Debug is successfully building again (Requested by
aroben on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
7:32 AM Changeset in webkit [79323] by yurys@chromium.org
  • 16 edits in trunk

2011-02-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline agent should have same lifetime as InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=54951

  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
  • inspector/timeline/timeline-trivial.html:

2011-02-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline agent should have same lifetime as InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=54951

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::clearFrontend): (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::startTimelineProfiler): (WebCore::InspectorTimelineAgent::stopTimelineProfiler): (WebCore::InspectorTimelineAgent::timelineProfilerStarted): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::clearRecordStack):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
7:28 AM Changeset in webkit [79322] by loislo@chromium.org
  • 14 edits
    2 deletes in trunk

2011-02-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: flakyness of inspector tests.
​https://bugs.webkit.org/show_bug.cgi?id=54729

As far as we have the protocol with sequence numbers we can simplify test harness support
and drop out chomium specific methods.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/TestController.js: (WebInspector.TestController): (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.TestController.prototype._evaluateForTestInFrontend):
  • inspector/front-end/inspector.js: (WebInspector.dispatch):

Source/WebKit/chromium:

  • src/js/DevTools.js:

LayoutTests:

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::sendMessageToInspectorFrontend): (DRTDevToolsAgent::runtimePropertyChanged): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::call):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendMessageToBackend): (DRTDevToolsClient::asyncCall): (DRTDevToolsClient::call):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
7:26 AM Changeset in webkit [79321] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-22 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
​https://bugs.webkit.org/show_bug.cgi?id=53146

New GTK-specific layout test to check the right signals are emitted.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.

2011-02-22 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
​https://bugs.webkit.org/show_bug.cgi?id=53146

Emit the selection-changed signals when the menu list value has changed

Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
7:14 AM Changeset in webkit [79320] by abecsi@webkit.org
  • 14 edits
    1 add in trunk

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • Source/WebKit.pri: Add common include paths
  • Source/WebKit.pro: Add new project file to SUBDIRS

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • QtWebKit.pro: Added. Project file for the final build step.

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

No new tests needed.

  • WebCore.pri: Add needed rules for handling the static library.
  • WebCore.pro: Reorganize API and linker options to QtWebKit.pro.

2011-02-22 Andras Becsi <​abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
​https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • WebKit2.pri: Add include paths.
  • WebKit2.pro: Move include paths to WebKit2.pri and move the API source to WebKit/qt/QtWebKit.pro
7:09 AM Changeset in webkit [79319] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
​https://bugs.webkit.org/show_bug.cgi?id=54947

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromCookie):
  • inspector/InspectorState.h:
7:07 AM Changeset in webkit [79318] by jer.noble@apple.com
  • 3 edits
    8 adds in trunk

2011-02-15 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
​https://bugs.webkit.org/show_bug.cgi?id=46142

Added a repaint test which ensures the timeline controls repaint in an audio-only MediaDocument. Since
the change also affects in-page audio, also added a repaint test for those cases as well.

Other platforms will need to have results generated.

  • media/audio-repaint.html: Added.
  • media/media-document-audio-repaint-expected.txt: Added.
  • media/media-document-audio-repaint.html: Added.
  • platform/mac/media/audio-repaint-expected.checksum: Added.
  • platform/mac/media/audio-repaint-expected.png: Added.
  • platform/mac/media/audio-repaint-expected.txt: Added.
  • platform/mac/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/mac/media/media-document-audio-repaint-expected.png: Added.

2011-02-15 Jer Noble <​jer.noble@apple.com>

Reviewed by Darin Adler.

Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
​https://bugs.webkit.org/show_bug.cgi?id=46142

Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
container elements. This is necessary because, during layout(), the child renderers
query the current LayoutState to determine where they will be repainting. If a new
LayoutState is not pushed here, child renderers will attempt to repaint relative to
their grandparent's origin instead of their parents', and repaint operations will fail.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
6:49 AM Changeset in webkit [79317] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-22 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
​https://bugs.webkit.org/show_bug.cgi?id=54952

Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
a valid reference for the input type FileInputType.

  • page/Chrome.cpp: (WebCore::Chrome::setToolTip):
5:25 AM Changeset in webkit [79316] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source/WebKit2

2011-02-22 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
​https://bugs.webkit.org/show_bug.cgi?id=54902

Refactor the context menu handling of Qt to make it simpler to manage memory.

WebContextMenuProxyQt uses smart pointer for all the references to menu so
there is no need to delete it explicitely.

Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
the client can choose to handle the memory, but there is no leak if it does not.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
5:20 AM Changeset in webkit [79315] by Philippe Normand
  • 1 edit in trunk/LayoutTests/ChangeLog

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip crashing inspector test on GTK

  • platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
5:20 AM Changeset in webkit [79314] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
5:20 AM Changeset in webkit [79313] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
​https://bugs.webkit.org/show_bug.cgi?id=54671

  • factored toolbar handling out of inspector.js
  • added toolbar dropdown
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
  • inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
5:20 AM Changeset in webkit [79312] by Philippe Normand
  • 2 edits in trunk

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
5:17 AM Changeset in webkit [79311] by podivilov@chromium.org
  • 11 edits
    3 adds in trunk

2011-02-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=54645

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.createWrapper.return.try): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.showScriptSource):
  • inspector/debugger/source-frame-expected.txt: Added.
  • inspector/debugger/source-frame.html: Added.

2011-02-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
​https://bugs.webkit.org/show_bug.cgi?id=54645

This is needed to map one script to several source files.

Test: inspector/debugger/source-frame.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DebuggerPresentationModel.js: Added. (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._addSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get loaded): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint.filter): (WebInspector.SourceFrame.prototype._findBreakpoint):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-02-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=54645

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
5:11 AM Changeset in webkit [79310] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of fast/forms/placeholder-position.html

  • platform/gtk/fast/forms/placeholder-position-expected.txt:
5:08 AM Changeset in webkit [79309] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of media/video-aspect-ratio.html

  • platform/gtk/media/video-aspect-ratio-expected.txt:
5:06 AM Changeset in webkit [79308] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip crashing inspector test on GTK

  • platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
5:05 AM Changeset in webkit [79307] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
4:16 AM Changeset in webkit [79306] by caseq@chromium.org
  • 9 edits
    1 add in trunk/Source/WebCore

2011-02-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
​https://bugs.webkit.org/show_bug.cgi?id=54671

  • factored toolbar handling out of inspector.js
  • added toolbar dropdown
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
  • inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
4:12 AM Changeset in webkit [79305] by Csaba Osztrogonác
  • 359 edits
    737 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
3:11 AM Changeset in webkit [79304] by Philippe Normand
  • 4 edits in trunk/Source

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
​https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
1:34 AM Changeset in webkit [79303] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-21 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=54891

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::instrumentingAgents):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::setFrontend): (WebCore::InspectorDOMStorageAgent::clearFrontend): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): (WebCore::InspectorDOMStorageAgent::clearResources):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::clearResources): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
1:12 AM Changeset in webkit [79302] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-22 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebProcess should be installed with 'make install'
​https://bugs.webkit.org/show_bug.cgi?id=44100

Follow the standard in other project files and allow install
location to be changed with INSTALL_BINS variable.

  • WebProcess.pro: Install QtWebProcess.
1:03 AM Changeset in webkit [79301] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-22 Steve Lacey <​sjl@chromium.org>

Reviewed by Darin Fisher.

Rename new media statistics apis to better names

​https://bugs.webkit.org/show_bug.cgi?id=54784

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount): (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrameCount): (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrameCount): (WebCore::MediaPlayer::droppedFrameCount): (WebCore::MediaPlayer::audioDecodedByteCount): (WebCore::MediaPlayer::videoDecodedByteCount):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrameCount): (WebCore::MediaPlayerPrivateInterface::droppedFrameCount): (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount): (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
12:41 AM Changeset in webkit [79300] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt update.

Removed more BUGWK54736 lines which are no longer failed.

  • platform/chromium/test_expectations.txt:
12:32 AM Changeset in webkit [79299] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt update.

Mark styles-update-from-js.html as flaky.

  • platform/chromium/test_expectations.txt:
12:23 AM Changeset in webkit [79298] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
​https://bugs.webkit.org/show_bug.cgi?id=54435

Changed the function to a series of early-exit 'if's,
removed most temporary variables.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
12:18 AM Changeset in webkit [79297] by kbalazs@webkit.org
  • 60 edits
    1 copy in trunk/Source/WebKit2

Unreviewed, rolling out r79296.
​http://trac.webkit.org/changeset/79296
​https://bugs.webkit.org/show_bug.cgi?id=54941

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-02-22
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
  • config.h:
  • win/WebKit2.vcproj:

Feb 21, 2011:

11:42 PM Changeset in webkit [79296] by kbalazs@webkit.org
  • 60 edits
    1 delete in trunk/Source/WebKit2

notImplemented() should behave identical in WebCore and WebKit2 ​https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Removed.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
11:21 PM Changeset in webkit [79295] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-21 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
​https://bugs.webkit.org/show_bug.cgi?id=54806

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): spatial navigation setting initialization added

2011-02-21 Lukasz Slachciak <​l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
​https://bugs.webkit.org/show_bug.cgi?id=54806

  • EWebLauncher/main.c: (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
11:05 PM Changeset in webkit [79294] by thakis@chromium.org
  • 5 edits in trunk/Source

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54923

Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().

No intended functionality change.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showInRect): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54923

Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().

No intended functionality change.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
10:48 PM Changeset in webkit [79293] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

Improve the local{SharedStyle,CousinList} algorithm
​https://bugs.webkit.org/show_bug.cgi?id=45507

This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.

No new test, refactoring only.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle): While changing the algorithm, cleaned up the style of those 2 methods (use early return, renamed some variables).
  • css/CSSStyleSelector.h:
10:46 PM Changeset in webkit [79292] by thakis@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by Adam Barth.

RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54922

RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.

No intended functionality change.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cellBaselinePosition):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows):
10:45 PM Changeset in webkit [79291] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt update.

r79285 removes too much lines. recover failed one.

  • platform/chromium/test_expectations.txt:
10:24 PM Changeset in webkit [79290] by kalman@chromium.org
  • 5 edits in trunk

2011-02-21 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
​https://bugs.webkit.org/show_bug.cgi?id=54724

Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.

  • editing/selection/extend-left-right-by-lineboundary-expected.txt:
  • editing/selection/extend-left-right-by-lineboundary.html:

2011-02-21 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
​https://bugs.webkit.org/show_bug.cgi?id=54724

On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).

However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
10:19 PM Changeset in webkit [79289] by morrita@google.com
  • 10 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed expectation rebaseline for r79284.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.checksum:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.checksum:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
10:10 PM Changeset in webkit [79288] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by Adam Barth.

ImageDocument::imageChanged() confuses clang's -Woverride-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54924

Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().

  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocument::imageUpdated):
  • html/ImageDocument.h:
9:58 PM Changeset in webkit [79287] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54934 - Sort the WebCore project file(s)
​https://bugs.webkit.org/show_bug.cgi?id=54934

No new tests. (no code affected)

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
9:51 PM Changeset in webkit [79286] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by Adam Barth.

canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
​https://bugs.webkit.org/show_bug.cgi?id=54909

Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
  • rendering/RootInlineBox.h:
9:14 PM Changeset in webkit [79285] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt update.

Removed BUGWK54736 lines which are no longer failed.

  • platform/chromium/test_expectations.txt:
8:56 PM Changeset in webkit [79284] by adele@apple.com
  • 7 edits in trunk

Source/WebCore: Fix for for ​https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Test: updated fast/forms/placeholder-position.html and tested manually

Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.

  • fast/forms/placeholder-position.html: Added a case for a search field with the results button.
  • platform/mac/fast/forms/placeholder-position-expected.checksum:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
7:59 PM Changeset in webkit [79283] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] focus comment on accept
​https://bugs.webkit.org/show_bug.cgi?id=54930

  • code-review.js:
7:57 PM Changeset in webkit [79282] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by Kent Tamura.

GIFImageDecoder::setSize() tries to override the superclass method but fails
​https://bugs.webkit.org/show_bug.cgi?id=54305

The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.h:
7:44 PM Changeset in webkit [79281] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch changes a test to work around a bug in PrettyPatch where
it will crash if lines starting with "--" are missing from the actual
output. The actual fix needed to PrettyPatch is described in the
bug.

​https://bugs.webkit.org/show_bug.cgi?id=54918

  • platform/mac/fast/objc/dom-html-select-activate-expected.txt:
  • platform/mac/fast/objc/dom-html-select-activate.html:
7:38 PM Changeset in webkit [79280] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] avoid overriding ctrl/cmd + r
​https://bugs.webkit.org/show_bug.cgi?id=54852

  • code-review.js:
7:31 PM Changeset in webkit [79279] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-02-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Kent Tamura.

nrwt: revert behavior on 10.5 to "old-threads". It's possible
that r79062 has introduced a bunch of flakiness, although I
can't explain why right now. This change should restore the
old behavior, and then we can look at the build logs to see
if the tests stop timing out or being flaky.

​https://bugs.webkit.org/show_bug.cgi?id=54925

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6:28 PM Changeset in webkit [79278] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
​https://bugs.webkit.org/show_bug.cgi?id=54528

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Allows style to be a null pointer. (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property. (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because ApplyStyleCommand::applyInlineStyle already does it.
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null. (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
  • editing/EditingStyle.h:
6:14 PM Changeset in webkit [79277] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO

Reviewed by Darin Adler and Alexey Proskuryakov.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.

6:08 PM Changeset in webkit [79276] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-21 Nico Weber <​thakis@chromium.org>

Reviewed by Kent Tamura.

[chromium] ChromePluginPrintContext::begin() fails to override superclass method
​https://bugs.webkit.org/show_bug.cgi?id=54914

Update subclass method signature to match superclass again. This
regressed in ​http://trac.webkit.org/changeset/71964

  • src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::begin):
6:07 PM Changeset in webkit [79275] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt update.

Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.

  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [79274] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp

Fix Windows build.

5:43 PM Changeset in webkit [79273] by timothy@apple.com
  • 11 edits in trunk/Source/WebKit2

Set and update the window title for the Web Inspector in WebKit2.

​https://webkit.org/b/50945
rdar://problem/8762410

Reviewed by Adam Roben.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.

  • WebProcess/WebPage/WebInspector.h:
5:40 PM Changeset in webkit [79272] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectation.txt clenaup.
Removed disabled lines which I commented out.

  • platform/chromium/test_expectations.txt:
5:32 PM Changeset in webkit [79271] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

5:28 PM Changeset in webkit [79270] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.8

New tag.

5:27 PM Changeset in webkit [79269] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-21 James Kozianski <​koz@chromium.org>

Reviewed by Kent Tamura.

Causes elements to be unfocusable after tabindex property is removed.
​https://bugs.webkit.org/show_bug.cgi?id=54727

  • fast/html/tabindex-removal-expected.txt: Added.
  • fast/html/tabindex-removal.html: Added.

2011-02-21 James Kozianski <​koz@chromium.org>

Reviewed by Kent Tamura.

Causes elements to be unfocusable after tabindex property is removed.
​https://bugs.webkit.org/show_bug.cgi?id=54727

Test: fast/html/tabindex-removal.html

  • dom/Node.cpp: (WebCore::Node::clearTabIndexExplicitly):
  • dom/Node.h:
  • dom/NodeRareData.h: (WebCore::NodeRareData::clearTabIndexExplicitly):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
5:23 PM Changeset in webkit [79268] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78673.

5:23 PM Changeset in webkit [79267] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Mark Rowe.

<rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods

  • platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
5:22 PM Changeset in webkit [79266] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectations update.

Removed fast/js/kde/math.html because it has been passing since r79246.
Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.

  • platform/chromium/test_expectations.txt:
5:18 PM Changeset in webkit [79265] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Overhang areas need to be invalidated on scroll
<rdar://problem/9032194>
​https://bugs.webkit.org/show_bug.cgi?id=54917

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): We need to explicitly invalidate the overhang areas when we scroll the contents of a ScrollView, since they could contain arbitrary content that cannot be blitted.
5:06 PM Changeset in webkit [79264] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/648

Merge 78168 - 2011-02-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
​https://bugs.webkit.org/show_bug.cgi?id=54053

The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.

Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.

Test: fast/forms/file-input-hit-test.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:

2011-02-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
​https://bugs.webkit.org/show_bug.cgi?id=54053

Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.

  • fast/forms/file-input-hit-test-expected.txt: Added.
  • fast/forms/file-input-hit-test.html: Added.

TBR=​rniwa@webkit.org
Review URL: ​http://codereview.chromium.org/6542053

5:01 PM Changeset in webkit [79263] by Lucas Forschler
  • 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
4:56 PM Changeset in webkit [79262] by Lucas Forschler
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp

Reviewed by Stephanie Lewis.

No new tests required.

  • WebCore.xcodeproj/project.pbxproj:
4:13 PM Changeset in webkit [79261] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove global initializer in CookieStorageCFNet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54905

Reviewed by Darin Adler.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):

3:57 PM Changeset in webkit [79260] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
3:47 PM Changeset in webkit [79259] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Jer Noble <​jer.noble@apple.com>

Reviewed by Sam Weinig.

WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
​https://bugs.webkit.org/show_bug.cgi?id=54771

Now that video is accelerated, we no longer need to special case
video playing within a media document.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
3:42 PM Changeset in webkit [79258] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Fix linker warning on Windows

r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.

Rubber-stamped by Anders Carlsson.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
3:34 PM Changeset in webkit [79257] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-21 Ami Fischman <​fischman@chromium.org>

Reviewed by Eric Carlson.

Add regression test for clean shutdown during video playback.
DumpRenderTree used to crash if the test was ended while a video
was still playing. (​http://crbug.com/72730).
​https://bugs.webkit.org/show_bug.cgi?id=54888

  • media/video-plays-past-end-of-test-expected.txt: Added.
  • media/video-plays-past-end-of-test.html: Added.
3:29 PM Changeset in webkit [79256] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Initialize DrawingAreaProxy::m_size
​https://bugs.webkit.org/show_bug.cgi?id=54913

This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
3:21 PM Changeset in webkit [79255] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Add some assertions about the state IDs we receive from the web process

Rubber-stamped by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.

3:20 PM Changeset in webkit [79254] by Adam Roben
  • 9 edits in trunk/Source/WebKit2

Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".

As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.

This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:

  • Messages::DrawingArea::SetSize -> UpdateState
  • Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
  • DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
  • DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
  • DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
  • DrawingAreaImpl::m_inSetSize -> m_inUpdateState
  • generateSequenceNumber -> generateStateID
  • sequenceNumber -> stateID

Fixes <​http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Performed the renames described above.

2:47 PM Changeset in webkit [79253] by ap@apple.com
  • 19 edits in trunk/Source

Reviewed by Adam Roben.

REGRESSION (WebKit2): HTTP requests time out after 60 seconds
​https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>

WebCore:

It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).

  • WebCore.exp.in:
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of default timeout interval (may be 0 if using NSURLRequest default). (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable. (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource request is updated. Plaform code often calls updateResourceRequest() indirectly from this function, and that must obviously be a no-op. (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite direction.
  • platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to "defaultTimeoutInterval". It has been used as default by most platforms anyway. (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.

WebKit2:

  • Shared/API/c/WKURLRequest.cpp: (WKURLRequestSetDefaultTimeoutInterval):
  • Shared/API/c/WKURLRequest.h: Added an API to set a default timeout interval for requests created from URLs. The API affects both the UI process and requests created internally by the Web process. Requests created from NSURLRequest or CFURLRequest take timeout from those.
  • Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
  • Shared/WebURLRequest.h: Pipe the default timeout interval from WKURLRequest down to actual implementation. Since WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects NSURLRequest default timeout interval.
  • UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
  • UIProcess/WebProcessManager.h: Added a way to enumerate all contexts running in separate processes.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::setDefaultRequestTimeoutInterval):
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Use UI process default timeout interval in separate process contexts, too.
2:26 PM Changeset in webkit [79252] by bweinstein@apple.com
  • 13 edits
    2 adds in trunk

Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Add a new use flag for using the CFURLCache.

  • wtf/Platform.h:

Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add

create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.

(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for

the origin's hostname.

  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/ResourceCache/cf: Added.
  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.

(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.

  • win/WebKit2.vcproj: Added new file.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.

WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Update WebKitSystemInterface headers and libraries with new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
2:21 PM Changeset in webkit [79251] by Adam Roben
  • 6 edits in trunk/Source/WebKit2

Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl

DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.

Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.

When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.

The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.

This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.

This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).

Fixes <​http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.

  • WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.

  • WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to

match the base class.

2:02 PM Changeset in webkit [79250] by bweinstein@apple.com
  • 2 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.

Rubber-stamped by Dan Bernstein.

  • WebKitSystemInterface.h:
1:35 PM Changeset in webkit [79249] by Martin Robinson
  • 5 edits in trunk

2011-02-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
​https://bugs.webkit.org/show_bug.cgi?id=54895

Update the results for this test which now includes a few more passing
lines. We maintain separate results, because we seem to pass more tests
than other platforms.

  • platform/gtk/Skipped: Unskip a test which is now passing.
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:

2011-02-21 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
​https://bugs.webkit.org/show_bug.cgi?id=54895

Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text". (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
1:23 PM Changeset in webkit [79248] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

nrwt: fix typo causing us to try and repeatedly shut down the servers
​https://bugs.webkit.org/show_bug.cgi?id=54904

  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1:14 PM Changeset in webkit [79247] by xan@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-21 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gavin Barraclough.

Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
​https://bugs.webkit.org/show_bug.cgi?id=54901

  • jit/JIT.h: swap actual and expected values in message, they were reversed.
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of a simple ASSERT.
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): ditto. (JSC::JIT::compileGetByIdHotPath): ditto. (JSC::JIT::compileGetByIdSlowCase): ditto. (JSC::JIT::emit_op_put_by_id): ditto.
12:46 PM Changeset in webkit [79246] by barraclough@apple.com
  • 5 edits in trunk

Ruber stamped by Sam Weinig

Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.

Source/JavaScriptCore:

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

LayoutTests:

  • fast/js/kde/math-expected.txt:
  • fast/js/kde/script-tests/math.js:
12:30 PM Changeset in webkit [79245] by commit-queue@webkit.org
  • 2 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-02-21 Anna Cavender <​annacc@timberline.sea.corp.google.com>

Reviewed by Eric Carlson.

new baselines for video-transformed.html on mac
​https://bugs.webkit.org/show_bug.cgi?id=54765

  • platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [79244] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

ProcessingInstruction should provide a way to know if it is of CSS type.
​https://bugs.webkit.org/show_bug.cgi?id=54868

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
  • dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::isCSS):
11:55 AM Changeset in webkit [79243] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-21 Simon Fraser <Simon Fraser>

Put JSDOMImplementationCustom.cpp where it belongs in the project.

  • WebCore.xcodeproj/project.pbxproj:
11:49 AM Changeset in webkit [79242] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip
editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
​https://bugs.webkit.org/show_bug.cgi?id=54895

  • platform/gtk/Skipped:
11:33 AM Changeset in webkit [79241] by Csaba Osztrogonác
  • 542 edits
    1083 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
11:31 AM Changeset in webkit [79240] by barraclough@apple.com
  • 35 edits in trunk/Source

Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.

Reviewed by Sam Weinig.

The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.

Source/JavaScriptCore:

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObjectFunctions.h:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSZombie.h:
  • runtime/MathObject.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:

Source/WebCore:

  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_object.cpp:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
11:16 AM Changeset in webkit [79239] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: skip new inspector test on wk2.

  • platform/mac-wk2/Skipped:
11:07 AM Changeset in webkit [79238] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix radar url.

11:06 AM Changeset in webkit [79237] by alex
  • 2 edits in trunk/Tools

2011-02-21 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Csaba Osztrogonác.

REGRESSION(r79157):
plugins/get-url-with-javascript-destroying-plugin.html make the
next test crash
​https://bugs.webkit.org/show_bug.cgi?id=54863

  • GNUmakefile.am:
10:45 AM Changeset in webkit [79236] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Skip WebKit2 tests that need EventSender
​https://bugs.webkit.org/show_bug.cgi?id=54890

These tests fail because EventSender is missing.

  • platform/mac-wk2/Skipped:
10:40 AM Changeset in webkit [79235] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
​https://bugs.webkit.org/show_bug.cgi?id=54863

Bug was fixed by ​http://trac.webkit.org/changeset/79231.

  • platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.
10:29 AM Changeset in webkit [79234] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: navigation does not work after reopening frontend.
​https://bugs.webkit.org/show_bug.cgi?id=54879

Test: http/tests/inspector-enabled/open-close-open.html

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::unmute):
  • inspector/InspectorState.h:
10:03 AM Changeset in webkit [79233] by Martin Robinson
  • 2 edits
    18 adds in trunk/LayoutTests

2011-02-21 Martin Robinson <​mrobinson@igalia.com>

Add results for tests missing results and unskip a test that
is passing locally and when run manually on the bots.

  • platform/gtk/Skipped: Unskip tests that are now passing.
  • platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/gtk/fast/runin/generated2-expected.checksum: Added.
  • platform/gtk/fast/runin/generated2-expected.png: Added.
  • platform/gtk/fast/runin/generated2-expected.txt: Added.
  • platform/gtk/fast/runin/generated3-expected.checksum: Added.
  • platform/gtk/fast/runin/generated3-expected.png: Added.
  • platform/gtk/fast/runin/generated3-expected.txt: Added.
  • platform/gtk/fast/runin/generated4-expected.checksum: Added.
  • platform/gtk/fast/runin/generated4-expected.png: Added.
  • platform/gtk/fast/runin/generated4-expected.txt: Added.
  • platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
  • platform/gtk/media/video-aspect-ratio-expected.png: Added.
  • platform/gtk/media/video-aspect-ratio-expected.txt: Added.
10:01 AM Changeset in webkit [79232] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <​alex@igalia.com>

Unreviewed added more tests with pixel differences between bots.

  • platform/gtk/Skipped:
9:48 AM Changeset in webkit [79231] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Protect the PluginView when evaluating javascript: URLs

Fixes <​http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added

Reviewed by Sam Weinig.

  • plugins/PluginView.cpp:

(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.

9:44 AM Changeset in webkit [79230] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-21 Martin Robinson <​mrobinson@igalia.com>

Fix GTK+ build after r79223.

  • GNUmakefile.am: Add file missing from the source list.
9:35 AM Changeset in webkit [79229] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: audits should not warn about gzip compression for 304s
​https://bugs.webkit.org/show_bug.cgi?id=54343

Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
9:25 AM Changeset in webkit [79228] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change to mark tests as timing out.

Many tests started timing out on the chrome mac canaries around r79035
​https://bugs.webkit.org/show_bug.cgi?id=54885

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [79227] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.

Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
​https://bugs.webkit.org/show_bug.cgi?id=54882

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [79226] by antonm@chromium.org
  • 1 edit in trunk/Source/WebCore/WebCore.pro

Another followup to 79223: correct QT project file

8:18 AM Changeset in webkit [79225] by antonm@chromium.org
  • 1 add in trunk/Source/WebCore/bindings/js/JSDOMImplementationCustom.cpp

Followup to 79223: forgotten file

8:13 AM Changeset in webkit [79224] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-21 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement WorkQueue::sheduleWorkAfterDelay
​https://bugs.webkit.org/show_bug.cgi?id=54878

  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWorkAfterDelay):
8:01 AM Changeset in webkit [79223] by antonm@chromium.org
  • 17 edits in trunk

2011-02-08 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
​https://bugs.webkit.org/show_bug.cgi?id=53611

This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.

Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
  • dom/Document.h:

2011-02-21 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
​https://bugs.webkit.org/show_bug.cgi?id=53611

Additional test which checks case when parent document can be collected while
its implementation is alive.

  • fast/dom/gc-9.html:
7:55 AM Changeset in webkit [79222] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Export JSObject::s_info from JavaScriptCore.dll

This matches what we do for all other ClassInfo objects that WebCore needs access to.

Fixes <​http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows

Reviewed by Sam Weinig.

  • runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
7:03 AM Changeset in webkit [79221] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Optimize editing updates in gutter panel
​https://bugs.webkit.org/show_bug.cgi?id=54866

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set startEditingListener): (WebInspector.TextViewer.prototype.set endEditingListener): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
6:44 AM Changeset in webkit [79220] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed the change log entry for r79219.

6:42 AM Changeset in webkit [79219] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
​https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:
6:40 AM Changeset in webkit [79218] by apavlov@chromium.org
  • 5 edits in trunk

2011-02-21 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
​https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:

2011-02-21 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
​https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
6:38 AM Changeset in webkit [79217] by yurys@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

2011-02-21 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: create and destroy DOM agent along with InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=54875

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve on this object. (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::~InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorConsoleAgent): (WebCore::InstrumentingAgents::setInspectorConsoleAgent): (WebCore::InstrumentingAgents::inspectorDOMAgent): (WebCore::InstrumentingAgents::setInspectorDOMAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent): (WebCore::InstrumentingAgents::inspectorResourceAgent): (WebCore::InstrumentingAgents::setInspectorResourceAgent): (WebCore::InstrumentingAgents::inspectorRuntimeAgent): (WebCore::InstrumentingAgents::setInspectorRuntimeAgent): (WebCore::InstrumentingAgents::inspectorStorageAgent): (WebCore::InstrumentingAgents::setInspectorStorageAgent): (WebCore::InstrumentingAgents::inspectorTimelineAgent): (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::clearFrontend): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached. (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end is attached. (WebCore::InspectorDOMAgent::clearFrontend):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
6:33 AM Changeset in webkit [79216] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79029.
​http://trac.webkit.org/changeset/79029
​https://bugs.webkit.org/show_bug.cgi?id=54869

Revert unnecessary Chromium rebaseline (Requested by apavlov
on #webkit).

  • platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.
6:29 AM Changeset in webkit [79215] by alex
  • 3 edits in trunk/Source/WebKit/gtk

2011-02-21 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] After r79130, spell tests did not work
​https://bugs.webkit.org/show_bug.cgi?id=54860

  • WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided freeing the default PangoLanguage.
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Initialized list of dictionaries.
6:16 AM Changeset in webkit [79214] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.

  • platform/mac-wk2/Skipped:
6:07 AM Changeset in webkit [79213] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; Remove incorrect Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:27 AM Changeset in webkit [79212] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.

  • platform/mac-wk2/Skipped:
5:10 AM Changeset in webkit [79211] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-21 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Switched to compiler based detection, where the error actually is.

It is not the platform that needs the workaround, it is the compiler.

QtWebKit fails to compile on Windows XP with msvc-2008
​https://bugs.webkit.org/show_bug.cgi?id=54746

  • bytecode/CodeBlock.h:
  • runtime/RegExpObject.h:
5:05 AM Changeset in webkit [79210] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][V8]REGRESSION(r79157): Fix build
​https://bugs.webkit.org/show_bug.cgi?id=54871

Reviewed by Andreas Kling.

  • bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
3:49 AM Changeset in webkit [79209] by vitalyr@chromium.org
  • 5 edits in trunk

2011-02-16 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Mihai Parparita.

[V8] SerializedScriptValue: fix JS exception handling.
​https://bugs.webkit.org/show_bug.cgi?id=54555

Added checks for exceptions and empty handles:

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::checkException): (WebCore::Serializer::reportFailure): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::push): (WebCore::Serializer::handleError): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::SerializedScriptValue::SerializedScriptValue):

2011-02-16 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Mihai Parparita.

[V8] SerializedScriptValue: fix JS exception handling.
​https://bugs.webkit.org/show_bug.cgi?id=54555

Added an exception throwing test case:

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:
3:24 AM Changeset in webkit [79208] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Add selectionchange event
​https://bugs.webkit.org/show_bug.cgi?id=45712

Added a test to ensure WebKit fires selectionchange event for the correct document
when the document has an iframe, and a test to ensure selectionchange events are fired
on user-initiated events.

  • fast/events/selectionchange-iframe-expected.txt: Added.
  • fast/events/selectionchange-iframe.html: Added.
  • fast/events/selectionchange-user-initiated-expected.txt: Added.
  • fast/events/selectionchange-user-initiated.html: Added.

2011-02-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Add selectionchange event
​https://bugs.webkit.org/show_bug.cgi?id=45712

Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
This event is not cancelable and does not bubble. An event listener can be attached to a document by
body element's onselectionchange attribute or via document's onselectionchange property.

Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
will not observe the event before the control returns to JavaScript.

See also: ​http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx

Tests: fast/events/selectionchange-iframe.html

fast/events/selectionchange-user-initiated.html

  • dom/Document.cpp: (WebCore::Document::enqueueDocumentEvent): Added.
  • dom/Document.h: Added selectionchange event listener.
  • dom/Document.idl: Added onselectionchagne attribute.
  • dom/EventNames.h: Added selectionchange
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Fires selectionchange event.
  • html/HTMLAttributeNames.in: Added onselectionchange.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
3:20 AM Changeset in webkit [79207] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
​https://bugs.webkit.org/show_bug.cgi?id=54863

  • platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html

and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.

3:16 AM Changeset in webkit [79206] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=54859

  • inspector/CodeGeneratorInspector.pm:
3:12 AM Changeset in webkit [79205] by pfeldman@chromium.org
  • 18 edits in trunk/LayoutTests

2011-02-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
​https://bugs.webkit.org/show_bug.cgi?id=54638

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack): (initialize_DebuggerTest.InspectorTest.waitUntilResumed): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath): (initialize_DebuggerTest.InspectorTest.expandProperties):
  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump): (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (initialize_InspectorTest.InspectorTest.safeWrap):
  • http/tests/inspector/resource-parameters.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/debugger/dom-breakpoints-expected.txt:
  • inspector/debugger/dom-breakpoints.html:
  • inspector/extensions/extensions-audits-tests.js: (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • platform/chromium/test_expectations.txt:
3:03 AM Changeset in webkit [79204] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: generate protocol documentation based on IDL.
​https://bugs.webkit.org/show_bug.cgi?id=54822

  • inspector/CodeGeneratorInspector.pm:
2:55 AM Changeset in webkit [79203] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <​alex@igalia.com>

Fixed typo in gtk Skipped list.

  • platform/gtk/Skipped:
2:40 AM Changeset in webkit [79202] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=54863

Paper over one more regression to make Qt buildbot happy and green.

  • platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.
2:19 AM Changeset in webkit [79201] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
​https://bugs.webkit.org/show_bug.cgi?id=54747

  • media/audio-delete-while-slider-thumb-clicked.html: Autoplay the media element and trigger the seek after playback started.
2:12 AM Changeset in webkit [79200] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andoni Morales Alastruey <​amorales@flumotion.com>

Reviewed by Martin Robinson.

[GStreamer] Add URI queries support in webkitwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=54627

This allow replying to URI queries from downstream elements
with the uri currently set in the source element.

No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
2:11 AM Changeset in webkit [79199] by morrita@google.com
  • 1 edit
    7 adds in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update.

  • platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.
1:58 AM Changeset in webkit [79198] by Csaba Osztrogonác
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed.

[Qt] Possible DRT bug revealed by r72003
​https://bugs.webkit.org/show_bug.cgi?id=49538

After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.

  • platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
  • platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.
1:33 AM Changeset in webkit [79197] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andoni Morales Alastruey <​amorales@flumotion.com>

Reviewed by Martin Robinson.

[GStreamer] Add 'location' property in webkitwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=54628

No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_class_init): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty):
1:28 AM Changeset in webkit [79196] by rniwa@webkit.org
  • 55 edits in trunk/Source

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode().

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node(). (WebKit::WebViewImpl::confirmComposition): Ditto. (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode().

  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-02-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
​https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
calls were of the form node()->document() and node()->inDocument() in which case they were
replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.

  • WebCore.exp.in: Added Position::containerNode.

The rest abbreviated for simplicity. Please see svn log.

1:00 AM Changeset in webkit [79195] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Another unreviewed attempt to expectation update.

  • platform/chromium/test_expectations.txt:
12:16 AM Changeset in webkit [79194] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebResourceCacheDataManager to the compilation after r78848
​https://bugs.webkit.org/show_bug.cgi?id=54732

Added resource cache manager API to GTK+ compilation after r78848.

  • GNUmakefile.am:
12:12 AM Changeset in webkit [79193] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update. (Removes invalid lines.)

  • platform/chromium/test_expectations.txt:

Feb 20, 2011:

11:26 PM Changeset in webkit [79192] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
11:21 PM Changeset in webkit [79191] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-16 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

keyboard support for extending/shrinking comment context
​https://bugs.webkit.org/show_bug.cgi?id=54612

ctrl+shift+up/down will extend/shrink the comment context when
a comment is focused or when one is being edited.

Also, switch over to using keydown instead of keypress events.
This lets us share code for handling escape and other key events.
Also, keypress is evil and should die.

  • code-review.js:
11:09 PM Changeset in webkit [79190] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Recommit accidental revert.
r79180 accidentally revereted r79178.

  • code-review.js:
11:04 PM Changeset in webkit [79189] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] add more help information
​https://bugs.webkit.org/show_bug.cgi?id=54847

  • code-review.js:
10:53 PM Changeset in webkit [79188] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:48 PM Changeset in webkit [79187] by Lucas Forschler
  • 1 move in tags/Safari-534.20.7

Renaming tag

10:46 PM Changeset in webkit [79186] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use 'r' to focus the review select element
​https://bugs.webkit.org/show_bug.cgi?id=54845

This allows for quick keyboard access to the toolbar items.
Hit r to get to the review select element. Then you can
tab to the cq/preview/publish elements.

  • code-review.js:
10:41 PM Changeset in webkit [79185] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] don't let lines/diffblocks be mouse focusable
​https://bugs.webkit.org/show_bug.cgi?id=54851

Unfortunately, this will only work once ​https://bugs.webkit.org/show_bug.cgi?id=54727
is committed. In the interim, it won't break anything.

  • code-review.js:
10:40 PM Changeset in webkit [79184] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.8

New tag.

10:39 PM Changeset in webkit [79183] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use keydown instead of keypress
​https://bugs.webkit.org/show_bug.cgi?id=54849

There is no functional change. This is just a cleanup
to make future patches (e.g. ​https://bugs.webkit.org/show_bug.cgi?id=54612)
cleaner.

  • code-review.js:
10:37 PM Changeset in webkit [79182] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix layout nit
​https://bugs.webkit.org/show_bug.cgi?id=54848

There is occasionally an off-by-one in the 50% width
calculation. This ensures that the add lines always
line up with the shared context lines.

  • PrettyPatch/PrettyPatch.rb:
9:48 PM Changeset in webkit [79181] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

test-webkitpy: stop skipping a bunch of tests on win32
​https://bugs.webkit.org/show_bug.cgi?id=54788

  • Scripts/webkitpy/common/net/testoutputset_unittest.py:
  • Scripts/webkitpy/test/main.py:
9:44 PM Changeset in webkit [79180] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make escape hide the preview form
​https://bugs.webkit.org/show_bug.cgi?id=54844

  • code-review.js:
9:37 PM Changeset in webkit [79179] by barraclough@apple.com
  • 5 edits in trunk/Source/WebCore

Build fix (remove includes).

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:
9:37 PM Changeset in webkit [79178] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make enter work when an individual line is focused
​https://bugs.webkit.org/show_bug.cgi?id=54843

  • code-review.js:
9:18 PM Changeset in webkit [79177] by barraclough@apple.com
  • 51 edits
    5 deletes in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.

Reviewed by Oliver Hunt.

Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.

NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.

GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.

Source/JavaScriptCore:

Removed symbols / references to files.

  • runtime/GlobalEvalFunction.cpp: Removed.
  • runtime/GlobalEvalFunction.h: Removed.
  • runtime/NativeFunctionWrapper.h: Removed.
  • runtime/PrototypeFunction.cpp: Removed.
  • runtime/PrototypeFunction.h: Removed.

Removed.

  • runtime/Executable.cpp:

(JSC::NativeExecutable::~NativeExecutable):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

Added interpreter-friendly constructors for NativeExecutables.

  • bytecompiler/BytecodeGenerator.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/BooleanPrototype.h:
  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp:
  • runtime/ErrorPrototype.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/Lookup.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/RegExpPrototype.h:
  • runtime/SmallStrings.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:

Removed use of redundant classes.

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:

Removed use of redundant classes.

9:07 PM Changeset in webkit [79176] by dpranke@chromium.org
  • 8 edits in trunk/Tools

2011-02-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

Fix various bugs related to handling of dir separators and real
vs. fake filesystems that were causing test-webkitpy to fail
tests on win32. These bugs have a variety of causes but are
lumped together because they should be easy to review.

​https://bugs.webkit.org/show_bug.cgi?id=54700

  • Scripts/webkitpy/common/net/testoutput.py: Here we were using os.path.sep but not escaping it prior to using in a regexp, which caused bad things on win32.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Same here.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Here we were using the native filesystem instead of the mock filesystem, making some tests unnecessarily platform dependent. Also we weren't setting the default configuration for the TestChromiumWinPort.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Here we *shouldn't* use os.path.join(), just so the code becomes less platform dependent.
  • Scripts/webkitpy/style/checker.py: Here we should be using os.path.sep instead of "/"; the tests require the native filesystem.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Here the underlying code is using os.path.sep, so we probably should as well.
  • Scripts/webkitpy/style/test_expectations_unittest.py: Here we should be using the filesystem hanging of the port object (which is the mocked filesystem) rather than the native one.
8:59 PM Changeset in webkit [79175] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <​morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
8:37 PM Changeset in webkit [79174] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79169.
​http://trac.webkit.org/changeset/79169
​https://bugs.webkit.org/show_bug.cgi?id=54846

Made unexpected results for tests without CJK characters
(Requested by tkent on #webkit).

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
8:28 PM Changeset in webkit [79173] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79170.

8:20 PM Changeset in webkit [79172] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-534.20-branch

Merge r79167.

7:58 PM Changeset in webkit [79171] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit/efl

2011-02-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
​https://bugs.webkit.org/show_bug.cgi?id=54842

Fix style errors in ewk files.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_window_features.h:
7:43 PM Changeset in webkit [79170] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.

7:28 PM Changeset in webkit [79169] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Chun-Lung Huang <​alvincl.huang@gmail.com>

Reviewed by Kent Tamura.

On Chromium Windows, glyphs in vertical text tests are rotated 90
degrees clockwise. ​https://bugs.webkit.org/show_bug.cgi?id=51450

This platform dependent patch makes Chromium Windows show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
7:26 PM Changeset in webkit [79168] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-20 Simon Fraser <Simon Fraser>

Reviewed by Dirk Schulze.

REGRESSION (r73369-r73405): transform animation interpolates incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=54793

After the refactoring in r73380, the ending state for some types of
accelerated animations was computed incorrectly, because the TransformationMatrix
wasn't reset to identity before the ending value transformations were applied.

Fix by cleaning up the code to use explicit, separate values for
starting and ending values. Only matrix-type animations had this
issue, but cleaned up other clauses similarly.

Test: animations/3d/matrix-transform-type-animation.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
7:06 PM Changeset in webkit [79167] by mitz@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/frames/iframe-scale-applied-twice.html

  • page/FrameView.cpp:

(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.

  • platform/ScrollView.h:

(WebCore::ScrollView::boundsSize): Added this getter.

  • platform/Widget.h:

(WebCore::Widget::resize): Set the bounds size to the frame size.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.

LayoutTests:

  • fast/frames/iframe-scale-applied-twice-expected.txt: Added.
  • fast/frames/iframe-scale-applied-twice.html: Added.
6:45 PM Changeset in webkit [79166] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

use shift+j/k to focus next/previous line
​https://bugs.webkit.org/show_bug.cgi?id=54723

Tested on a large Hyatt change to confirm it performed fine.
(​https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

  • code-review.js:
6:38 PM Changeset in webkit [79165] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix escape handling in code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54722

This broke with ​http://trac.webkit.org/changeset/78948.
Apparently jquery events get a wrapped object that
does not expose keyIdentifier.

  • code-review.js:
6:36 PM Changeset in webkit [79164] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

create comments when hitting enter with a focused diff
​https://bugs.webkit.org/show_bug.cgi?id=54719

  • code-review.js:
6:29 PM Changeset in webkit [79163] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

use actual browser focus in the code review tool
​https://bugs.webkit.org/show_bug.cgi?id=54726

This makes keyboard handling play better with focusable element
(i.e. links/textareas/buttons). Also, in theory, this makes
the review tool more amenable to screen readers (I think).

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:24 PM Changeset in webkit [79162] by Lucas Forschler
  • 4 edits in branches/safari-534.20-branch/Source/WebKit2

Merge 79165.

6:20 PM Changeset in webkit [79161] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-20 Ami Fischman <​fischman@chromium.org>

Reviewed by Kent Tamura.

Remove flakiness from media/video-poster.html by using event callbacks
instead of 100ms timeouts and hoping that states have transitioned in
time (!).
Removed seemingly-outdated BUG_DRT annotation from test_expectation.

​https://bugs.webkit.org/show_bug.cgi?id=54685
​http://crbug.com/60845

  • media/video-poster.html:
  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [79160] by kalman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-21 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Make editing/selection/extend-selection tests more human readable and hand-runnable
​https://bugs.webkit.org/show_bug.cgi?id=54712

Three changes to achieve this:

  • Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
  • Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
  • Fix typo causing failing tests to have a js error (rather than layout error).

Expected results need to change due to column alignment.

  • editing/selection/extend-selection-character-expected.txt:
  • editing/selection/extend-selection-word-expected.txt:
  • editing/selection/resources/extend-selection.js: (logMismatchingPositions): (runSelectionTestsWithGranularity): (getTestNodeContainer.createButton.button.onmousedown): (getTestNodeContainer.createButton): (getTestNodeContainer.createButtonToSwitchDirection): (getTestNodeContainer): (createNode):
5:07 PM Changeset in webkit [79159] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Eric Seidel.

Tighten up access permissions by using libxslt API
​https://bugs.webkit.org/show_bug.cgi?id=52688
<rdar://problem/8909191>

  • xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only interested in a string result, so let libxslt know about that.
4:35 PM Changeset in webkit [79158] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r79104.
​http://trac.webkit.org/changeset/79104
​https://bugs.webkit.org/show_bug.cgi?id=54835

Might have caused flaky canaries (Requested by tonyg-cr on
#webkit).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::isLayoutTimerActive):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  • page/FrameView.h:
4:09 PM Changeset in webkit [79157] by andersca@apple.com
  • 11 edits
    3 adds in trunk

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add new plug-in test.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_GetURL):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added. (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin): (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add test.

  • plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
  • plugins/get-url-with-javascript-destroying-plugin.html: Added.

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::destroy): Null out m_pluginController.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Don't access the frame through m_pluginElement since it will be nulled out when the plug-in is destroyed.
3:04 PM Changeset in webkit [79156] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix another crash when a plug-in is destroyed when evaluating JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=54834
<rdar://problem/9013384>

This contains three separate fixes:

  • In unprotectPluginFromDestruction we can't just destroy the plug-in once the count reaches zero, because the plug-in might still have code executing on the stack. To fix this we use a zero-delay timer to defer destruction of the plug-in.
  • Trying to get the NPObject for the window using NPN_GetValue would return NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return NPERR_GENERIC_ERROR instead.
  • Protect the plug-in from destruction anytime an NPAPI call that sends a synchronous IPC message is made.
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::destroy): (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::PluginDestructionProtector::PluginDestructionProtector): (WebKit::NPN_GetValue): (WebKit::NPN_Evaluate): (WebKit::NPN_GetProperty): (WebKit::NPN_SetProperty): (WebKit::NPN_RemoveProperty): (WebKit::NPN_HasProperty): (WebKit::NPN_HasMethod): (WebKit::NPN_Enumerate): (WebKit::NPN_Construct): (WebKit::NPN_GetValueForURL): (WebKit::NPN_SetValueForURL):
2:27 PM Changeset in webkit [79155] by krit@webkit.org
  • 18 edits
    3 adds in trunk

2011-02-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
​https://bugs.webkit.org/show_bug.cgi?id=54542

Check dynamic update of attributeName. The test fails at the moment, because of some wrong
internal mapping. Tested update manually with gdb. Working on a fix to get this test pass
as well.

  • svg/animations/animate-dynamic-update-attributeName-expected.txt: Added.
  • svg/animations/animate-dynamic-update-attributeName.html: Added.
  • svg/animations/script-tests/animate-dynamic-update-attributeName.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-02-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
​https://bugs.webkit.org/show_bug.cgi?id=54542

Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
with AnimatedAttributeType instead. More cleanup of the animation code.
Added missing fillAttributeToPropertyTypeMap() for SVGGElement.

Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.

No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
with the W3C test suite in trunk.

The change on SVGUseElement gets covered by animate-elem-39-t.svg

Test: svg/animations/animate-dynamic-update-attributeName.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::inheritsFromProperty): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidAttributeType): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::calculateDistance):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::calculateFromAndByValues): (WebCore::SVGAnimateTransformElement::applyResultsToTarget): (WebCore::SVGAnimateTransformElement::calculateDistance):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced): (WebCore::solveEpsilon): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGAnimationElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::attributeToPropertyTypeMap): (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
  • svg/SVGGElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name. (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name. (WebCore::SVGSMILElement::removedFromDocument): Ditto. (WebCore::SVGSMILElement::attributeChanged): Ditto.
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::attributeName):
1:16 PM Changeset in webkit [79154] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)

Not reviewed.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

3:20 AM Changeset in webkit [79153] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

3:14 AM Changeset in webkit [79152] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.6

New tag.

1:28 AM Changeset in webkit [79151] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
​https://bugs.webkit.org/show_bug.cgi?id=52880

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
1:22 AM Changeset in webkit [79150] by Carlos Garcia Campos
  • 2 edits in trunk

2011-02-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Bump GTK+3 dependency to 3.0
​https://bugs.webkit.org/show_bug.cgi?id=54394

  • configure.ac:
12:50 AM Changeset in webkit [79149] by mitz@apple.com
  • 815 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

12:11 AM Changeset in webkit [79148] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

Note: See TracTimeline for information about the timeline view.