Timeline



Mar 7, 2011:

11:49 PM Changeset in webkit [80545] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Looks editing/pasteboard/data-transfer-items.html is slow.

  • platform/chromium/test_expectations.txt:
11:47 PM Changeset in webkit [80544] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Final build fix for r80536.

  • DerivedSources.make:
11:33 PM Changeset in webkit [80543] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Adjust functions of WebCore's efl port to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55924

Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.

  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::frameRectsChanged): (WebCore::Widget::setEvasObject):
11:27 PM Changeset in webkit [80542] by aestes@apple.com
  • 5 edits in trunk

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

A change to the date parser to handle the case where the year is
specified before the time zone inadvertently started accepting strings
such as '+0000' as valid years. Those strings actually represent time
zones in an offset of hours and minutes from UTC, not years.

  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): If the current character in dateString is '+' or '-', do not try to parse the next token as a year.

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
11:18 PM Changeset in webkit [80541] by dcheng@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

More build fixes for r80536.

  • CMakeLists.txt:
  • platform/chromium/ClipboardChromium.cpp:
  • platform/chromium/ClipboardChromium.h:
11:05 PM Changeset in webkit [80540] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917

Adjust webkit style to ScrollbarEfl files.

  • platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage): (ScrollbarEfl::setParent): (ScrollbarEfl::updateThumbPositionAndProportion): (ScrollbarEfl::frameRectsChanged): (ScrollbarEfl::paint):
  • platform/efl/ScrollbarEfl.h:
10:45 PM Changeset in webkit [80539] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Fix jquery/effects.html and fast/viewpoert/viewport-129.html

  • platform/chromium/test_expectations.txt:
10:18 PM Changeset in webkit [80538] by dcheng@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Build fix for Chromium after r80536.

  • platform/chromium/DataTransferItemChromium.cpp:
  • platform/chromium/DataTransferItemsChromium.cpp:
9:58 PM Changeset in webkit [80537] by ojan@chromium.org
  • 5 edits
    1 add in trunk/Tools

2011-03-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add webkit-patch attach-to-bug for posting to bugzilla from the commandline
https://bugs.webkit.org/show_bug.cgi?id=55749

  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/attachtobug.py: Added.
  • Scripts/webkitpy/tool/steps/options.py:
9:48 PM Changeset in webkit [80536] by dcheng@chromium.org
  • 28 edits
    14 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Layout test to verify that the basic properties of dataTransfer.items function as expected.

  • editing/pasteboard/data-transfer-items-expected.txt: Added.
  • editing/pasteboard/data-transfer-items.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
all functionality on the DataTransferItems collection has been implemented.
This change does not actually hook up DataTransferItems to reflect the actual contents of a
drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
enabled via several followup patches.

Test: editing/pasteboard/data-transfer-items.html

  • Android.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
  • bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
  • dom/Clipboard.h: (WebCore::Clipboard::policy):
  • dom/Clipboard.idl:
  • dom/DataTransferItem.cpp: Added.
  • dom/DataTransferItem.h: Added. (WebCore::DataTransferItem::~DataTransferItem):
  • dom/DataTransferItem.idl: Added.
  • dom/DataTransferItems.h: Added. (WebCore::DataTransferItems::~DataTransferItems):
  • dom/DataTransferItems.idl: Added.
  • dom/StringCallback.cpp: Added. (WebCore::StringCallback::scheduleCallback):
  • dom/StringCallback.h: Added. (WebCore::StringCallback::~StringCallback):
  • dom/StringCallback.idl: Added.
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemChromium.cpp: Added. (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::kind): (WebCore::DataTransferItemChromium::type): (WebCore::DataTransferItemChromium::getAsString):
  • platform/chromium/DataTransferItemChromium.h: Added.
  • platform/chromium/DataTransferItemsChromium.cpp: Added. (WebCore::DataTransferItemsChromium::create): (WebCore::DataTransferItemsChromium::DataTransferItemsChromium): (WebCore::DataTransferItemsChromium::length): (WebCore::DataTransferItemsChromium::item): (WebCore::DataTransferItemsChromium::deleteItem): (WebCore::DataTransferItemsChromium::clear): (WebCore::DataTransferItemsChromium::add):
  • platform/chromium/DataTransferItemsChromium.h: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Add new runtime enabled flag for data transfer items feature.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDataTransferItems): (WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Enable data transfer items in DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
9:41 PM Changeset in webkit [80535] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-03-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[test dashboard] pull treemap files
https://bugs.webkit.org/show_bug.cgi?id=55852

  • TestResultServer/handlers/dashboardhandler.py:
9:22 PM Changeset in webkit [80534] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char.html on Windows

  • platform/chromium/test_expectations.txt:
9:19 PM Changeset in webkit [80533] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-07 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

Rebaseline GPU media/video-display-toggle.html for snow leopard
https://bugs.webkit.org/show_bug.cgi?id=55920

  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:
9:06 PM Changeset in webkit [80532] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/viewport/viewport-{128,129}.html

  • platform/chromium/test_expectations.txt:
8:49 PM Changeset in webkit [80531] by dcheng@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Updated Skipped lists for editing/pasteboard/onpaste-text-html-types.html.
https://bugs.webkit.org/show_bug.cgi?id=55921
https://bugs.webkit.org/show_bug.cgi?id=55922

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
8:07 PM Changeset in webkit [80530] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Chromium build fix.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
8:02 PM Changeset in webkit [80529] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char-dos.html

  • platform/chromium/test_expectations.txt:
7:54 PM Changeset in webkit [80528] by rniwa@webkit.org
  • 13 edits in trunk/Source

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Calls selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

  • WebView/WebHTMLView.mm: Removed unused selectionHasStyle. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.

Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
call sites of these two functions.

  • WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports selectionStartHasStyle because it's not called anywhere outside of WebCore.
  • WebCore.order: Ditto.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id and a property value. (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
  • editing/EditingStyle.h: (WebCore::EditingStyle::create): Added.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of a CSSStyleDeclaration. (WebCore::Editor::selectionHasStyle): Ditto.
  • editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle. (WebCore::stateStyle): Ditto.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
7:31 PM Changeset in webkit [80527] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Add svg/css/rect-gradient-stroke-shadow.svg added by webkit r80515

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [80526] by ap@apple.com
  • 8 edits in trunk

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

  • platform/mac/fast/text/large-text-composed-char-expected.txt: The huge text run is split into multiple text nodes again.

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

<rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
linkifying e-mail addresses in in -[DOMCharacterData setData:]

Changes render tree of fast/text/large-text-composed-char.html, but not image results.

  • dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
  • dom/CharacterData.h: Moved a constant for maximum length from Text.h.
  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h: This function was unused in ToT. Moved code around to share with CharacterData.
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode): Chnaged to split large text nodes while parsing again.
7:13 PM Changeset in webkit [80525] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

svg/W3C-SVG-1.1/struct-image-07-t.svg failing

  • platform/chromium/test_expectations.txt:
7:07 PM Changeset in webkit [80524] by hayato@chromium.org
  • 4 edits in trunk/Tools

2011-03-03 Hayato Ito <hayato@chromium.org>

Reviewed by Mihai Parparita.

[NRWT] Clear output image file used by DumpRenderTree to make sure the
previous image should not be used in the ChromiumDriver.

Also make sure that output image from the ChromiumDriver should be
(empty string) if a test crashes for consistency with the WebKitDriver
implementation.

https://bugs.webkit.org/show_bug.cgi?id=55746

  • Scripts/webkitpy/layout_tests/port/chromium.py:
6:32 PM Changeset in webkit [80523] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-07 Damian Kaleta <dkaleta@apple.com>

Reviewed by Anders Carlsson.

QuickTime plugin should opt in to a 32-bit non-executable heap
https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/8105706>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap. By default it should opt-out. (WebKit::PluginProcessProxy::PluginProcessProxy):
6:25 PM Changeset in webkit [80522] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark several jquery tests slow for debug build.

  • platform/chromium/test_expectations.txt:
6:19 PM Changeset in webkit [80521] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Adam Barth.

Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522

Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.

No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.

  • platform/image-encoders/JPEGImageEncoder.cpp: (WebCore::jpegEmptyOutputBuffer):
6:13 PM Changeset in webkit [80520] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

  • svg/dom/vkern-element-crash-expected.txt: Added.
  • svg/dom/vkern-element-crash.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

Test: svg/dom/vkern-element-crash.html

  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument):
6:09 PM Changeset in webkit [80519] by ukai@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80514.
http://trac.webkit.org/changeset/80514
https://bugs.webkit.org/show_bug.cgi?id=55915

Caused assertion failures (Requested by ukai on #webkit).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
5:55 PM Changeset in webkit [80518] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-07 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] fast/js/navigator-language.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=55880

Add LANG variable to the clean environment when running
old-run-webkit-tests script.

  • Scripts/old-run-webkit-tests:
5:55 PM Changeset in webkit [80517] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark jquery/effects.html slow.

  • platform/chromium/test_expectations.txt:
5:51 PM Changeset in webkit [80516] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

  • svg/custom/resources/rgb.svg: Added.
  • svg/custom/use-image-in-g-expected.checksum: Added.
  • svg/custom/use-image-in-g-expected.png: Added.
  • svg/custom/use-image-in-g-expected.txt: Added.
  • svg/custom/use-image-in-g.svg: Added.

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

The result of sourceURI must use the URL of the enclosing document as base.
Otherwise, the base may sometimes be empty, and, as a consequence,
the intermediate KURL object may be invalid.

Test: svg/custom/use-image-in-g.svg

  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
5:49 PM Changeset in webkit [80515] by helder@sencha.com
  • 5 edits
    9 adds in trunk

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

  • fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokeRect-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokeRect-gradient-shadow.js: Added.
  • platform/chromium/test_expectations.txt: Skip new test since it fails.
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/qt/Skipped: Skip new test since it fails.
  • platform/qt/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
  • platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • svg/css/rect-gradient-stroke-shadow-expected.txt: Added.
  • svg/css/rect-gradient-stroke-shadow.svg: Added.

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html

svg/css/rect-gradient-stroke-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeRect):
5:37 PM Changeset in webkit [80514] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

Fix for blurs behind bitmap images in Chromium, and boosting
shadow blur quality
Bug URLs:

https://bugs.webkit.org/show_bug.cgi?id=55410
https://bugs.webkit.org/show_bug.cgi?id=55506

No new tests. Covered by existing layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
5:14 PM Changeset in webkit [80513] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Some fast/viewport tests are missing expectations.

  • platform/chromium/test_expectations.txt:
5:02 PM Changeset in webkit [80512] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-07 Andreas Kling <kling@webkit.org>

Unreviewed Mac build fix after r80508.

  • WebCore.exp.in:
4:57 PM Changeset in webkit [80511] by abarth@webkit.org
  • 1 edit
    125 adds in trunk/LayoutTests

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Import jquery test suite
https://bugs.webkit.org/show_bug.cgi?id=55911

This test suite is imported from https://github.com/jquery/jquery. I
tried to make as few changes as possible in case we want to merge with
upstream in the future. The test suite was original licensed under the
MIT license, which is compatible with WebKit's license.

  • jquery: Added.
4:50 PM Changeset in webkit [80510] by enrica@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebCore

Unreviewed build fix.

Rolling back http://trac.webkit.org/changeset/80497 due to the
32-bit build failures.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/HTMLConverter.h: Removed.
  • platform/mac/HTMLConverter.mm: Removed.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

4:45 PM Changeset in webkit [80509] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Skip onpaste-text-html-types.html on Mac and Qt since parts of the test
infrastructure to support it aren't there.

  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:
4:36 PM Changeset in webkit [80508] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-07 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.

  • page/FrameView.cpp: (WebCore::FrameView::setBaseBackgroundColor):
  • page/FrameView.h:
4:17 PM Changeset in webkit [80507] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

  • fast/parser/document-write-into-initial-document-expected.txt: Added.
  • fast/parser/document-write-into-initial-document.html: Added.

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

The m_frame can disappear out from under us, and there's no point in
checking whether the load is complete in a non-existant frame.

Test: fast/parser/document-write-into-initial-document.html

  • dom/Document.cpp: (WebCore::Document::explicitClose):
3:57 PM Changeset in webkit [80506] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

LLVM Compiler build fix.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkGrammarOfString):

3:50 PM Changeset in webkit [80505] by tony@chromium.org
  • 1 edit
    325 deletes in trunk/LayoutTests

2011-03-07 Tony Chang <tony@chromium.org>

Unreviewed, delete chromium layout test pngs that don't have
corresponding checksum files. They're not getting picked up by
run-webkit-tests without a checksum, so just remove them.

  • platform/chromium-linux/animations/suspend-transform-animation-expected.png: Removed.
  • platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-hkern-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.png: Removed.
  • platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Removed.
  • platform/chromium-mac-leopard/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Removed.
  • platform/chromium-mac/animations/state-at-end-event-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/5390681-2-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5138441-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5481523-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4960116-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-mac/fast/css/apple-prefix-expected.png: Removed.
  • platform/chromium-mac/fast/css/compare-content-style-expected.png: Removed.
  • platform/chromium-mac/fast/css/css3-space-in-nth-and-lang-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-woff-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-comments-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-empty-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-escapes-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-invalid-at-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png: Removed.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Removed.
  • platform/chromium-mac/fast/lists/anonymous-items-expected.png: Removed.
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/line-clamp-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/opacity-reflection-transform-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated2-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated3-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated4-expected.png: Removed.
  • platform/chromium-mac/fast/text/stripNullFromText-expected.png: Removed.
  • platform/chromium-mac/http/tests/misc/slow-loading-mask-expected.png: Removed.
  • platform/chromium-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png: Removed.
  • platform/chromium-mac/svg/css/css-box-min-width-expected.png: Removed.
  • platform/chromium-mac/svg/custom/container-opacity-clip-viewBox-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.png: Removed.
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
  • platform/chromium-mac/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Removed.
  • platform/chromium-mac/svg/custom/transformedMaskFails-expected.png: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug6674-expected.png: Removed.
  • platform/chromium-mac/transitions/transition-end-event-rendering-expected.png: Removed.
  • platform/chromium-mac/webarchive/test-link-rel-icon-expected.png: Removed.
  • platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Removed.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textProperties-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize03-expected.png: Removed.
  • platform/chromium-win/fast/block/float/009-expected.png: Removed.
  • platform/chromium-win/fast/block/float/034-expected.png: Removed.
  • platform/chromium-win/fast/block/float/4145535Crash-expected.png: Removed.
  • platform/chromium-win/fast/block/float/br-with-clear-expected.png: Removed.
  • platform/chromium-win/fast/block/float/float-on-zero-height-line-expected.png: Removed.
  • platform/chromium-win/fast/block/float/narrow-after-wide-expected.png: Removed.
  • platform/chromium-win/fast/block/float/negative-margin-clear-expected.png: Removed.
  • platform/chromium-win/fast/block/float/nowrap-clear-min-width-expected.png: Removed.
  • platform/chromium-win/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/003-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/004-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/005-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/006-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/007-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/008-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/009-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/010-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/011-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/012-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/013-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/014-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/015-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/016-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/017-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/018-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/019-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/020-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/021-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/022-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/023-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/024-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/025-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/026-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/027-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/028-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/029-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/030-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/031-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/032-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/033-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/034-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/035-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/036-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/037-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/038-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/039-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/040-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/041-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/042-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/043-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/044-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/045-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/046-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/048-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/049-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/050-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/062-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/move-with-auto-width-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/relative-overconstrained-expected.png: Removed.
  • platform/chromium-win/fast/borders/outline-offset-min-assert-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
  • platform/chromium-win/fast/clip/017-expected.png: Removed.
  • platform/chromium-win/fast/css/006-expected.png: Removed.
  • platform/chromium-win/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
  • platform/chromium-win/fast/css/content-dynamic-expected.png: Removed.
  • platform/chromium-win/fast/css/last-child-style-sharing-expected.png: Removed.
  • platform/chromium-win/fast/css/transition-color-unspecified-expected.png: Removed.
  • platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Removed.
  • platform/chromium-win/fast/dom/css-cached-import-rule-expected.png: Removed.
  • platform/chromium-win/fast/dom/css-insert-import-rule-expected.png: Removed.
  • platform/chromium-win/fast/dom/delete-contents-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/001-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/005-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/float-no-longer-overhanging-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/float-withdrawal-2-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-2-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/genContentDestroyChildren-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/staticY-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
  • platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/chromium-win/fast/events/onloadFrameCrash-expected.png: Removed.
  • platform/chromium-win/fast/frames/002-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-fixed-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-order-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-percentage-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-relative-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-round-expected.png: Removed.
  • platform/chromium-win/fast/frames/empty-cols-attribute-expected.png: Removed.
  • platform/chromium-win/fast/frames/empty-frame-src-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-length-fractional-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
  • platform/chromium-win/fast/frames/no-frame-borders-expected.png: Removed.
  • platform/chromium-win/fast/images/image-in-map-expected.png: Removed.
  • platform/chromium-win/fast/images/pdf-as-tiled-background-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-image-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/chromium-win/fast/inline-block/004-expected.png: Removed.
  • platform/chromium-win/fast/inline-block/005-expected.png: Removed.
  • platform/chromium-win/fast/invalid/015-expected.png: Removed.
  • platform/chromium-win/fast/invalid/table-residual-style-crash-expected.png: Removed.
  • platform/chromium-win/fast/js/exception-linenums-in-html-3-expected.png: Removed.
  • platform/chromium-win/fast/js/missing-style-end-tag-js-expected.png: Removed.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Removed.
  • platform/chromium-win/fast/layers/positioned-inside-root-with-margins-expected.png: Removed.
  • platform/chromium-win/fast/layers/zindex-ridonkulous-expected.png: Removed.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/chromium-win/fast/overflow/position-relative-expected.png: Removed.
  • platform/chromium-win/fast/overflow/unreachable-content-test-expected.png: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.png: Removed.
  • platform/chromium-win/fast/reflections/table-cell-expected.png: Removed.
  • platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
  • platform/chromium-win/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
  • platform/chromium-win/fast/replaced/008-expected.png: Removed.
  • platform/chromium-win/fast/table/024-expected.png: Removed.
  • platform/chromium-win/fast/table/031-expected.png: Removed.
  • platform/chromium-win/fast/table/caption-relayout-expected.png: Removed.
  • platform/chromium-win/fast/table/div-as-col-span-expected.png: Removed.
  • platform/chromium-win/fast/table/giantCellspacing-expected.png: Removed.
  • platform/chromium-win/fast/table/growCellForImageQuirk-expected.png: Removed.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/chromium-win/fast/table/percent-widths-stretch-expected.png: Removed.
  • platform/chromium-win/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
  • platform/chromium-win/fast/text/align-center-rtl-spill-expected.png: Removed.
  • platform/chromium-win/fast/text/apply-start-width-after-skipped-text-expected.png: Removed.
  • platform/chromium-win/fast/text/fixed-pitch-control-characters-expected.png: Removed.
  • platform/chromium-win/fast/text/selection-painted-separately-expected.png: Removed.
  • platform/chromium-win/fast/text/soft-hyphen-3-expected.png: Removed.
  • platform/chromium-win/fast/text/stripNullFromText-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-1-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-2-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/script-after-frameset-expected.png: Removed.
  • platform/chromium-win/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGNumber-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGPoint-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGRect-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/attribute-namespace-check-expected.png: Removed.
  • platform/chromium-win/svg/custom/class-selector-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-child-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-units-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-with-transform-expected.png: Removed.
  • platform/chromium-win/svg/custom/conditional-processing-outside-switch-expected.png: Removed.
  • platform/chromium-win/svg/custom/create-metadata-element-expected.png: Removed.
  • platform/chromium-win/svg/custom/createelement-expected.png: Removed.
  • platform/chromium-win/svg/custom/css-pixels-dpi-expected.png: Removed.
  • platform/chromium-win/svg/custom/display-none-expected.png: Removed.
  • platform/chromium-win/svg/custom/dynamic-viewBox-expected.png: Removed.
  • platform/chromium-win/svg/custom/evt-onload-expected.png: Removed.
  • platform/chromium-win/svg/custom/fill-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/filter-source-alpha-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-add-stops-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-attr-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-stop-style-change-expected.png: Removed.
  • platform/chromium-win/svg/custom/hover-default-fill-expected.png: Removed.
  • platform/chromium-win/svg/custom/image-with-aspect-ratio-stretch-expected.png: Removed.
  • platform/chromium-win/svg/custom/inner-percent-expected.png: Removed.
  • platform/chromium-win/svg/custom/inner-svg-hit-test-expected.png: Removed.
  • platform/chromium-win/svg/custom/invalid-transforms-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-excessive-malloc-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-inside-defs-expected.png: Removed.
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.png: Removed.
  • platform/chromium-win/svg/custom/percentage-rect2-expected.png: Removed.
  • platform/chromium-win/svg/custom/poly-identify-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-hittest-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-invalid-points-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-setattribute-points-null-expected.png: Removed.
  • platform/chromium-win/svg/custom/prevent-default-expected.png: Removed.
  • platform/chromium-win/svg/custom/repaint-on-image-bounds-change-expected.png: Removed.
  • platform/chromium-win/svg/custom/resource-client-removal-expected.png: Removed.
  • platform/chromium-win/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/chromium-win/svg/custom/rootelement-expected.png: Removed.
  • platform/chromium-win/svg/custom/scroll-hit-test-expected.png: Removed.
  • platform/chromium-win/svg/custom/sheet-title-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-absolute-children-expected.png: Removed.
  • platform/chromium-win/svg/custom/text-gradient-no-content-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-ignore-after-invalid-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-invalid-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-removeAttributeNS-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-scale-parse-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-with-ending-space-expected.png: Removed.
  • platform/chromium-win/svg/custom/transformedMaskFails-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-empty-reference-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-recalcStyle-crash-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-symbol-overflow-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-clip-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-no-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-update2-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-clip-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-mask-expected.png: Removed.
  • platform/chromium-win/svg/custom/xhtml-no-svg-renderer-expected.png: Removed.
  • platform/chromium-win/svg/custom/xml-stylesheet-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/006-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/007-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/008-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/009-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/014-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/014-test-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/015-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/016-expected.png: Removed.
  • platform/chromium-win/svg/hixie/painting/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/chromium-win/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/002-test-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/chromium-win/svg/webarchive/svg-script-subresouces-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug103533-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222336-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222467-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug269566-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug277062-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug28933-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug2954-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
  • platform/chromium-win/transitions/transition-end-event-rendering-expected.png: Removed.
  • platform/chromium-win/webarchive/archive-with-unencoded-url-expected.png: Removed.
  • platform/chromium-win/webarchive/test-body-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-img-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-input-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-link-rel-icon-expected.png: Removed.
  • platform/chromium-win/webarchive/test-object-data-expected.png: Removed.
  • platform/chromium-win/webarchive/test-script-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-table-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-td-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-xml-stylesheet-expected.png: Removed.
3:40 PM Changeset in webkit [80504] by tony@chromium.org
  • 1 edit
    1 add in trunk/Tools

2011-03-07 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Find .checksum files without .pngs and vice-versa
https://bugs.webkit.org/show_bug.cgi?id=55236

  • Scripts/find-mismatched-layout-test-results: Added. A script for finding

mismatched results.

3:18 PM Changeset in webkit [80503] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-07 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip test caretRangeFromPoint-in-zoom-and-scroll.html in mac-wk2 since
EventSender.mouseMoveTo is not yet supported.

  • platform/mac-wk2/Skipped:
3:14 PM Changeset in webkit [80502] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80500.
http://trac.webkit.org/changeset/80500
https://bugs.webkit.org/show_bug.cgi?id=55908

Caused mysterious GYP error (Requested by abarth on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:54 PM Changeset in webkit [80501] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Fix Chromium Mac build. This header should only be included when the
feature is enabled.

  • platform/cf/RunLoopTimerCF.cpp:
2:37 PM Changeset in webkit [80500] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add WML files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55905

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:34 PM Changeset in webkit [80499] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-07 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Add missing include to #define Skia parameter
https://bugs.webkit.org/show_bug.cgi?id=55885

  • platform/graphics/chromium/ShaderChromium.h:
2:31 PM Changeset in webkit [80498] by Chris Fleizach
  • 17 edits in trunk

Source/WebCore: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootObjectForFrame):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::firstChild):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/mac: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
returns the scroll bar objects).
Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
will expect that as its child, instead of the WebCore ScrollView object.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Tools: AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::focusedElement):

Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
because it could change at any time.

(AccessibilityController::rootElement):

LayoutTests: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

  • platform/mac/accessibility/webkit-scrollarea-expected.txt:
  • platform/mac/accessibility/webkit-scrollarea-position-expected.txt:
  • platform/mac/accessibility/webkit-scrollarea-position.html:
  • platform/mac/accessibility/webkit-scrollarea.html:
2:13 PM Changeset in webkit [80497] by enrica@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

  • WebCore.xcodeproj/project.pbxproj: Added new file.
  • platform/mac/HTMLConverter.h: Added.
  • platform/mac/HTMLConverter.mm: Added.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

2:04 PM Changeset in webkit [80496] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some missing platform files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55897

There are a bunch more, but this is a start.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
1:56 PM Changeset in webkit [80495] by barraclough@apple.com
  • 4 edits in trunk

Source/JavaScriptCore: Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

Patch by Yuta Kitamura <yutak@chromium.org> on 2011-03-06
Reviewed by Kent Tamura.

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

(WTF::MD5::MD5):

  • wtf/SHA1.cpp: Added.

(WTF::testSHA1): This function will be run the first time SHA1
constructor is called. This function computes a few hash values
and checks the results in debug builds. However, constructor is
probably not a good place to run these tests, so we need to find
a good place for it (bug 55853).
(WTF::expectSHA1):
(WTF::f):
(WTF::k):
(WTF::rotateLeft):
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):
(WTF::SHA1::finalize):
(WTF::SHA1::processBlock):
(WTF::SHA1::reset):

  • wtf/SHA1.h: Added.

(WTF::SHA1::addBytes):

  • wtf/wtf.pri:

LayoutTests: Bug 55815 - Should throw an exception from JSObject::defineOwnProperty if !isExtensible().

Reviewed by Cameron Zwarich.

  • ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:

Now with added passingness!

1:52 PM Changeset in webkit [80494] by steveblock@google.com
  • 7 edits
    2 moves in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55879

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/v8/JavaClassV8.cpp:
  • bridge/jni/v8/JavaClassV8.h:
  • bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp. (JavaField::JavaField):
  • bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaField::type): (JSC::Bindings::JavaField::getJNIType):
  • bridge/jni/v8/JavaInstanceV8.cpp:
  • bridge/jni/v8/JavaNPObjectV8.cpp:
1:31 PM Changeset in webkit [80493] by dcheng@chromium.org
  • 9 edits
    2 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This requires a DEPS roll for a Chromium-side change to support DRT testing of
event.dataTransfer.types.

  • DEPS:
1:22 PM Changeset in webkit [80492] by xji@chromium.org
  • 8 edits in trunk/LayoutTests

2011-03-07 Xiaomei Ji <xji@chromium.org>

Reviewed by Martin Robinson.

Make fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html less port-dependent.
Preiously, the test clicked at a specific pixel so different fonts result in slightly different positions.
Change the test to click on a specific character offset.
https://bugs.webkit.org/show_bug.cgi?id=30816

  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
1:01 PM Changeset in webkit [80491] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-07 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Clean up fast/viewport expectations and remove a test that no longer
crashes (the underlying V8 bug was fixed).

  • platform/chromium/test_expectations.txt:
12:52 PM Changeset in webkit [80490] by Joseph Pecoraro
  • 61 edits
    6 adds in trunk/LayoutTests

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Include expected results for r80483.

Numerous LayoutTests/fast/viewport tests.

12:43 PM Changeset in webkit [80489] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Use preferred locale information when choosing fallback
font using fontconfig on Linux platform.
http://bugs.webkit.org/show_bug.cgi?id=55453

No new tests, as it depends on ICU and locale setting, so it will be
covered by Chromium side.

  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp:

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

Use preferred locale information when choosing fallback font using
fontconfig on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=55453

Tests will be covered by Chromium side.

  • public/gtk/WebFontInfo.h: (WebKit::WebFontInfo::familyForChars): added 3rd parameter |preferredLocale|
  • public/linux/WebSandboxSupport.h: (WebKit::WebSandboxSupport::getFontFamilyForCharacters): added 3rd parameter |preferredLocale|
  • src/PlatformBridge.cpp:
  • src/gtk/WebFontInfo.cpp:
12:31 PM BuildingQtOnLinux edited by srikumar.b@gmail.com
by default, ubuntu does not come with g++. And aptitude tells unknown … (diff)
12:14 PM Changeset in webkit [80488] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add gobject, cpp, and objc bindings to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55892

These are also excluded from the Chromium build but needed for various
other ports.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:10 PM Changeset in webkit [80487] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

  • fast/dom/dom-method-document-change-expected.txt: Added.
  • fast/dom/dom-method-document-change.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

Test: fast/dom/dom-method-document-change.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Node.cpp: (WebCore::Node::checkReplaceChild): (WebCore::Node::checkAddChild):
  • dom/Node.h:
11:55 AM Changeset in webkit [80486] by dcheng@chromium.org
  • 7 edits
    2 deletes in trunk

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Removed.
  • editing/pasteboard/onpaste-text-html-types.html: Removed.

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types):
  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
11:52 AM Changeset in webkit [80485] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add missing bindings/js files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55888

These files are excluded from the Chromium build but needed for the Mac
build.

  • WebCore.gypi:
11:48 AM Changeset in webkit [80484] by dcheng@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
11:41 AM Changeset in webkit [80483] by Joseph Pecoraro
  • 4 edits
    6 adds in trunk

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Added tests specifically to test Console warnings.

  • fast/viewport/viewport-warnings-1.html: Added.
  • fast/viewport/viewport-warnings-2.html: Added.
  • fast/viewport/viewport-warnings-3.html: Added.
  • fast/viewport/viewport-warnings-4.html: Added.
  • fast/viewport/viewport-warnings-5.html: Added.
  • fast/viewport/viewport-warnings-6.html: Added.

2011-03-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Correct and improve the error messages for viewport parsing.

Tests: fast/viewport/viewport-warnings-1.html

fast/viewport/viewport-warnings-2.html
fast/viewport/viewport-warnings-3.html
fast/viewport/viewport-warnings-4.html
fast/viewport/viewport-warnings-5.html
fast/viewport/viewport-warnings-6.html

  • dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findSizeValue): remove incorrect device-width / height tips. (WebCore::setViewportFeature): report a warning for an unrecognized key. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key. (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
  • dom/ViewportArguments.h: removed no longer used warnings.
11:37 AM Changeset in webkit [80482] by jamesr@google.com
  • 9 edits in trunk/Source

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

This splits up LayerRendererChromium::drawLayers() into two phases,
one that updates layers and one that actually draws them. Most of the
patch is moving the bodies of drawLayers() and updateLayersRecursive()
into smaller helper functions.

The main entry point is renamed updateAndDrawLayers(), but otherwise
has the same signature as drawLayers() did. Internally it does the
following:

1.) Updates the root layer's contents
2.) Updates the root layer's scrollbars
3.) Updates the RenderSurface tree and the contents of all child
layers
4.) Draws the root layer and root layer scrollbars
5.) Draws all child layers using the previously updated
CCLayerImpl/RenderSurface data.

A few things still need to be done after this patch to complete the separation
of the update and draw step, but they can happen in later patches:
*) The root layer and root layer scrollbars contents should be
uploaded to textures at draw time, not update time.
*) The RenderSurface tree should be updated at draw time, not update
time.

Covered by the compositing/ tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::updateRootLayerScrollbars): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateContentsRecursive): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::visibleRectSize):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the &quot;update&quot; and &quot;draw&quot; portions of LayerRendererChromium&apos;s drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

Call updated LayerRendererChromium APIs.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::doComposite):
11:34 AM Changeset in webkit [80481] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sort WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55887

These files should be in order. This is preparation for adding in the
missing files.

  • WebCore.gypi:
11:19 AM Changeset in webkit [80480] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r80478.

  • dom/Document.cpp: Add suggested parentheses to make GCC happy.

(WebCore::Document::didReceiveTask):

11:05 AM Changeset in webkit [80479] by weinig@apple.com
  • 13 edits in trunk

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::unableToImplementPolicy):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp: (WebKit::WebPolicyClient::unableToImplementPolicy):
  • UIProcess/WebPolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: (WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): Pipe unableToImplementPolicy through both the bundle and the main WebKit2 API.

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Update policy client initialization struct for new member.
10:54 AM Changeset in webkit [80478] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-03-07 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401

Manual test added: manual-tests/database-callback-deferred.html.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::didReceiveTask): (WebCore::Document::postTask): (WebCore::Document::pendingTasksTimerFired): (WebCore::Document::willDeferLoading): (WebCore::Document::didResumeLoading):
  • dom/Document.h:
  • manual-tests/database-callback-deferred.html: Added.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
10:53 AM Changeset in webkit [80477] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Use HashMaps for caching primitive values
https://bugs.webkit.org/show_bug.cgi?id=55873

Reviewed by Sam Weinig.

Most documents use only small subset of cacheable primitive values. By replacing
fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
expanding the range of cacheable values.

  • css/CSSPrimitiveValueCache.cpp:

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

  • css/CSSPrimitiveValueCache.h:
10:50 AM Changeset in webkit [80476] by steveblock@google.com
  • 8 edits
    1 copy
    1 move
    2 adds
    1 delete in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55881

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
  • bridge/jni/jsc/JNIBridgeJSC.h: Removed.
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JavaClassJSC.cpp:
  • bridge/jni/jsc/JavaClassJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
10:28 AM Changeset in webkit [80475] by weinig@apple.com
  • 48 edits in trunk

Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827

Reviewed by Anders Carlsson.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):

  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkContentPolicy):

  • loader/PolicyChecker.h:

Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

Source/WebKit/chromium:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForResponse):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Source/WebKit/qt:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebFrame.cpp:

(WebFrame::dispatchDecidePolicyForResponse):

  • WebFrame.h:

Source/WebKit/wince:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDecidePolicyForResponse):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse and pass the entire response, instead of just the MIMEType.
  • Updated both UIProcess API and bundle API to also be based on the whole response, not just the MIMEType.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForResponse):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForResponse):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForResponse):
(-[BrowserWindowController awakeFromNib]):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Update tools for new name.

10:20 AM Changeset in webkit [80474] by bulach@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-07 Marcus Bulach <bulach@chromium.org>

Reviewed by Dan Bernstein.

WebViewImpl::focusedWebCoreFrame() should be const.
https://bugs.webkit.org/show_bug.cgi?id=55870

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::focusedWebCoreFrame):
  • src/WebViewImpl.h:
10:13 AM Changeset in webkit [80473] by eric.carlson@apple.com
  • 13 edits in trunk/Source

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>

No new tests, this is just more plumbing.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions. (WebCore::addMediaEngine): Ditto. (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::registerSelf): Update for MediaEngineRegistrar change.
10:09 AM Changeset in webkit [80472] by steveblock@google.com
  • 12 edits
    1 copy
    2 moves in trunk/Source/WebCore

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55774

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature): (JavaMethod::JNIReturnType): (JavaMethod::methodID):
  • bridge/jni/JavaMethod.h: (JSC::Bindings::JavaMethod::name): (JSC::Bindings::JavaMethod::returnType): (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters): (JSC::Bindings::JavaMethod::isStatic):
  • bridge/jni/JavaString.h: (JSC::Bindings::JavaString::JavaString): (JSC::Bindings::JavaString::utf8): (JSC::Bindings::JavaString::length): (JSC::Bindings::JavaString::impl):
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/v8/JNIBridgeV8.h:
  • bridge/jni/v8/JavaClassV8.cpp:
  • bridge/jni/v8/JavaClassV8.h:
  • bridge/jni/v8/JavaInstanceV8.cpp:
9:33 AM Changeset in webkit [80471] by jorlow@chromium.org
  • 16 edits in trunk

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBIndex, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

This brings us in line with what's in the spec:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::create): (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::source):
  • storage/IDBCursor.h:
  • storage/IDBCursor.idl:
  • storage/IDBCursorWithValue.cpp: (WebCore::IDBCursorWithValue::create): (WebCore::IDBCursorWithValue::IDBCursorWithValue):
  • storage/IDBCursorWithValue.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create): (WebCore::IDBIndex::objectStore):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
9:20 AM Changeset in webkit [80470] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
https://bugs.webkit.org/show_bug.cgi?id=55735

Reviewed by Beth Dakin.

Source/WebCore:

The ARIA grid implementation needed to verify the row/column range of a cell instead of
assuming a 1-1 mapping between children and row/column.

Test: platform/mac/accessibility/aria-table-with-colspan-cells.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

LayoutTests:

  • platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
  • platform/mac/accessibility/aria-table-with-colspan-cells.html: Added.
8:47 AM Changeset in webkit [80469] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Bump version.

  • win/tools/scripts/VERSION:
7:38 AM Changeset in webkit [80468] by andreip@google.com
  • 9 edits in trunk/Source

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
IDBObjectStore objects used to be created asynchronously, so we needed
this method to be invoked, with the new object store as the parameter,
whenever the creation succeeded. The spec has changed so that IDBObjectStore
objects are created synchronously, so this method is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=55777

No new tests, just refactoring.

  • storage/IDBCallbacks.h:
  • storage/IDBRequest.cpp:
  • storage/IDBRequest.h:

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
https://bugs.webkit.org/show_bug.cgi?id=55777

  • src/IDBCallbacksProxy.cpp:
  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCallbacksImpl.h:
7:15 AM Changeset in webkit [80467] by steveblock@google.com
  • 8 edits in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaParameter should be removed
https://bugs.webkit.org/show_bug.cgi?id=55772

No new tests, refactoring only.

  • bridge/jni/JNIBridge.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (JavaMethod::signature):
  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters):
  • bridge/jni/JNIUtility.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
5:39 AM Changeset in webkit [80466] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

[Chromium] test_expectations.txt cannot be parsed correctly
https://bugs.webkit.org/show_bug.cgi?id=55871

  • platform/chromium/test_expectations.txt:
4:20 AM Changeset in webkit [80465] by andreas.kling@nokia.com
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-07 Kenneth Rohde Christiansen <kenneth@webkit.org>

Unreviewed.

Add expected results to the new viewport tests

  • fast/viewport/viewport-91-expected.txt: Added.
  • fast/viewport/viewport-92-expected.txt: Added.
  • fast/viewport/viewport-93-expected.txt: Added.
  • fast/viewport/viewport-94-expected.txt: Added.
  • fast/viewport/viewport-95-expected.txt: Added.
  • fast/viewport/viewport-96-expected.txt: Added.
3:23 AM Changeset in webkit [80464] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/inspector/resource-parameters.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55867

  • platform/qt/Skipped: Add http/tests/inspector/resource-parameters.html to make buildbot happy.
3:19 AM Changeset in webkit [80463] by Antti Koivisto
  • 16 edits
    5 adds in trunk

Source/WebCore: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

Make CSS primitive value cache per-document.

Test: http/tests/security/cross-origin-css-primitive.html

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionXY):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitNumber):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:

(WebCore::CSSParser::primitiveValueCache):

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createColor):
(WebCore::CSSPrimitiveValue::create):

  • css/CSSPrimitiveValueCache.cpp: Added.

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

  • css/CSSPrimitiveValueCache.h: Added.

(WebCore::CSSPrimitiveValueCache::create):
(WebCore::CSSPrimitiveValueCache::createValue):

  • dom/Document.cpp:

(WebCore::Document::cssPrimitiveValueCache):

  • dom/Document.h:

LayoutTests: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

  • http/tests/security/cross-origin-css-primitive-expected.txt: Added.
  • http/tests/security/cross-origin-css-primitive.html: Added.
  • http/tests/security/resources/cross-origin-css-primitive-iframe.html: Added.
2:40 AM Changeset in webkit [80462] by alex
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Added new GTK+ test results.

  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt: Added.
1:55 AM Changeset in webkit [80461] by ukai@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80458.
http://trac.webkit.org/changeset/80458
https://bugs.webkit.org/show_bug.cgi?id=55863

caused tests to crash on several chromium bots (Requested by
ukai on #webkit).

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
  • src/AssociatedURLLoader.h:
1:35 AM Changeset in webkit [80460] by alex
  • 2 edits in trunk/LayoutTests

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Skipped failing test that requires a missing feature in
layoutTestController. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=55862

  • platform/gtk/Skipped:
1:25 AM Changeset in webkit [80459] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Filter sources in WebCore GYP build for Mac
https://bugs.webkit.org/show_bug.cgi?id=55857

This patch removes a large number of files that do not build as part of
the Mac build. I'm not fully sold on this method of
including/excluding files, but it's the "gyp way" so we should probably
try it first.

This patch also sets xcode_list_excluded_files to 0, which removes the
excluded files from the Xcode project file, which is necessary in order
to prevent the header map feature from including the wrong header file.

  • gyp/WebCore.gyp:
12:46 AM Changeset in webkit [80458] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-07 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925

No tests needed. Exposes no new functionality.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h: (WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):
12:20 AM Changeset in webkit [80457] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed EFL build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=55858

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
12:19 AM Changeset in webkit [80456] by commit-queue@webkit.org
  • 44 edits in trunk/LayoutTests

2011-03-07 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Tony Gentilcore.

In layout tests, iframe's onload handler should not use script function
defined after the iframe.
https://bugs.webkit.org/show_bug.cgi?id=54942

Found and fixed more tests in addition to the first patch to bug 54942.
Tried best to avoid expectation changes.

  • editing/execCommand/find-after-replace.html:
  • editing/input/option-page-up-down.html:
  • editing/input/scroll-viewport-page-up-down.html:
  • editing/pasteboard/copy-standalone-image.html:
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
  • editing/pasteboard/paste-noscript-xhtml.xhtml:
  • editing/selection/drag-in-iframe.html:
  • editing/undo/undo-iframe-location-change.html:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype.html:
  • fast/dom/Window/window-postmessage-clone-frames.html:
  • fast/dynamic/paused-event-dispatch.html:
  • fast/events/keydown-remove-frame.html:
  • fast/events/mousedown-in-subframe-scrollbar.html:
  • fast/frames/content-opacity-2.html:
  • fast/frames/viewsource-plain-text-tags.html:
  • fast/frames/viewsource-unfinished-tags.html:
  • fast/history/form-submit-in-frame-via-onclick.html:
  • fast/history/form-submit-in-frame.html:
  • fast/xsl/xslt-text-expected.txt:
  • fast/xsl/xslt-text.html:
  • http/tests/messaging/cross-domain-message-send.html:
  • http/tests/misc/cached-scripts-expected.txt:
  • http/tests/misc/cached-scripts.html:
  • http/tests/plugins/post-url-file-expected.txt:
  • http/tests/plugins/post-url-file.html:
  • http/tests/security/listener/xss-inactive-closure-expected.html:
  • http/tests/security/listener/xss-inactive-closure.html:
  • http/tests/security/postMessage/delivery-order.html:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception.html:
  • http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
  • http/tests/security/postMessage/target-origin.html:
  • http/tests/security/xss-DENIED-getSVGDocument-iframe.html:
  • http/tests/xmlhttprequest/detaching-frame-2.html:
  • media/media-document-audio-repaint.html:
  • media/media-document-audio-size.html:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
  • platform/mac/fast/loader/non-html-load-event-expected.txt:
  • platform/mac/fast/loader/non-html-load-event.html:
  • scrollbars/hidden-iframe-scrollbar-crash2.html:
  • storage/close-during-stress-test.html:
  • svg/custom/js-update-transform-changes.svg:

Mar 6, 2011:

11:57 PM Changeset in webkit [80455] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

inspector/styles/styles-add-blank-property.html becomes flaky.

  • platform/chromium/test_expectations.txt:
11:22 PM Changeset in webkit [80454] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewd, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109) on Mac

platform/chromium/fast/text/international/complex-text-rectangle.html

  • platform/chromium/test_expectations.txt:
10:25 PM Changeset in webkit [80453] by tkent@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium expectation files for r80449.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
10:02 PM Changeset in webkit [80452] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webcore_derived_source_files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55856

This is the list of files generated by the Mac port. It's possible
other ports generate a different list of files.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
9:41 PM Changeset in webkit [80451] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium.
https://bugs.webkit.org/show_bug.cgi?id=55844

Chromium will find it useful to know the page dismissal status (i.e.,
whether a frame is in the midst of executing a beforeunload or unload
handler), so expose that information through the chromium port in the
WebKit API.

This is my second attempt at this patch. The previous one broke
downstream Chromium builds of some unit tests which had classes derived
from WebFrame (and thus became uninstantiable because of this new pure
virtual method). Those have now been fixed (http://crrev.com/77101).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
9:14 PM Changeset in webkit [80450] by tkent@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add a Mac expectation for a new test of r80449.

  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
9:12 PM Changeset in webkit [80449] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.

Test: fast/forms/input-appearance-spinbutton-visibility.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

  • fast/forms/input-appearance-spinbutton-visibility.html: Added for the test to make sure input type=number spin buttons are shown or hidden correctly with Javascript.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added for the expectation checksum.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added for the expectation image.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added for the expectation render tree txt.
8:50 PM Changeset in webkit [80448] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.

Test: manual-tests/popup-width-restriction-within-screen.html

  • manual-tests/popup-width-restriction-within-screen.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
8:02 PM Changeset in webkit [80447] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80440 (bug 55854) also on mac.

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [80446] by yutak@chromium.org
  • 11 edits
    3 adds in trunk/Source

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MD5.cpp: (WTF::MD5::MD5):
  • wtf/SHA1.cpp: Added. (WTF::testSHA1): This function will be run the first time SHA1 constructor is called. This function computes a few hash values and checks the results in debug builds. However, constructor is probably not a good place to run these tests, so we need to find a good place for it (bug 55853). (WTF::expectSHA1): (WTF::f): (WTF::k): (WTF::rotateLeft): (WTF::SHA1::SHA1): (WTF::SHA1::addBytes): (WTF::SHA1::computeHash): (WTF::SHA1::finalize): (WTF::SHA1::processBlock): (WTF::SHA1::reset):
  • wtf/SHA1.h: Added. (WTF::SHA1::addBytes):
  • wtf/wtf.pri:

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

  • ForwardingHeaders/wtf/SHA1.h: Added.
6:23 PM Changeset in webkit [80445] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109)

fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
platform/chromium/fast/text/international/complex-text-rectangle.html
svg/css/getComputedStyle-basic.xhtml
fast/text/hyphenate-limit-before-after.html

Regression at WebKit r80440 (bug 55854)

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [80444] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

LLVM Compiler build fix.

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setValueForUser:]):

5:11 PM Changeset in webkit [80443] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel and David Kilzer.

Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
https://bugs.webkit.org/show_bug.cgi?id=55503

Fix misspelled word "Dowloads" [sic] in the message printed to standard output
in checkForJavaSDK().

Also, remove extraneous space in function prototype for unlinkZeroFiles.

  • Scripts/build-webkit:
5:00 PM Changeset in webkit [80442] by eric.carlson@apple.com
  • 11 edits in trunk/Source/WebCore

2011-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

QuickTime based media engines should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55848

No new tests, it is only possible to test this by manually deleting and monitoring the
the Quicktime caches.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing. (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine. (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when

creating new movie.

(WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in

m_privateBrowsing and set movie attribute.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):

Initialize m_privateBrowsing.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store

privacy setting in m_privateBrowsing and call QTMovie.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing. (QTMovie::load):Pass private browsing property when creating new movie. (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and

set movie property.

  • platform/graphics/win/QTMovie.h:
4:44 PM Changeset in webkit [80441] by mitz@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

Updated more platform-specific results after r80438.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Copied from platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt.
4:34 PM Changeset in webkit [80440] by mitz@apple.com
  • 4 edits
    1 add in trunk/LayoutTests

Updated platform-specific results after r80438.

  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:22 PM Changeset in webkit [80439] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
the value for border-spacing from the value of the WebKit internal CSS
property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.

The CSS property border-spacing describes the horizontal and vertical border
spacing for an HTML Table element. Notice, WebKit internally represents the value
of this property as two properties: -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
respectively. And WebKit doesn't know to reconstitute these internal properties.
Therefore style.borderSpacing always returns the empty string.

Test: fast/css/table-border-spacing.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
  • css/CSSMutableStyleDeclaration.h:

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Tests that style.borderSpacing returns the correct result for valid, negative, and missing border-spacing values.

  • fast/css/table-border-spacing-expected.txt: Added.
  • fast/css/table-border-spacing.html: Added.
2:44 PM Changeset in webkit [80438] by mitz@apple.com
  • 13 edits
    6 adds in trunk

<rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=55850

Reviewed by Oliver Hunt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit.html

fast/text/hyphenate-limit-before-after.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedProperties) Updated this array with the new properties and some old properties
that it was missing.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
CSSPropertyWebkitHyphenateLimit{Before,After}.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
'auto' and non-negative integers.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
allow hyphenation if the prefix and the suffix are sufficiently long.
(WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitBefore): Added.
(WebCore::InheritedFlags::hyphenationLimitAfter): Added.
(WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
(WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
(WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
representation of 'auto'.
(WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
(WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/parsing-hyphenate-limit-expected.txt: Added.
  • fast/css/parsing-hyphenate-limit.html: Added.
  • fast/text/hyphenate-limit-before-after.html: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
2:00 PM Changeset in webkit [80437] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80436.
http://trac.webkit.org/changeset/80436
https://bugs.webkit.org/show_bug.cgi?id=55849

Broke Chromium compile across the board (Requested by dglazkov
on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:36 PM Changeset in webkit [80436] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium
https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
10:39 AM Changeset in webkit [80435] by jberlin@webkit.org
  • 19 edits in trunk

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Sam Weinig.

Source/WebCore:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCore.exp.in:

Add the new WKSI functions.

  • platform/mac/WebCoreSystemInterface.h:

Ditto.

  • platform/mac/WebCoreSystemInterface.mm:

Ditto.

  • platform/mac/CookieJar.mm:

(WebCore::cookies):
If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
Otherwise, behave the same as before.
(WebCore::cookieRequestHeaderFieldValue):
Ditto.
(WebCore::setCookies):
Ditto.
(WebCore::cookiesEnabled):
Ditto
(WebCore::getRawCookies):
Ditto.
(WebCore::deleteCookie):
Ditto.

  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
function instead of at the global scope.
(WebCore::currentCookieStorage):
Use privateBrowsingCookieStorage.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
wkCreatePrivateInMemoryHTTPCookieStorage.

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
Refactor the logic to determine whether or not to relax the third party cookie policy here.
If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
(WebCore::ResourceHandle::createNSURLConnection):
Use shouldRelaxThirdPartyCookiePolicy.
(WebCore::ResourceHandle::loadResourceSynchronously):
Ditto.

Source/WebKit/mac:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

Source/WebKit2:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

WebKitLibraries:

When Private Browsing is enabled, use cookies from a in-memory Cookie Storage based on the
Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
10:29 AM Changeset in webkit [80434] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk/Source/WebKit2

2011-03-06 Oleg Romashin <romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part1
Adding dummy Qt files for Plugin Process implementation,
Adding missing sources into Qt pro files
https://bugs.webkit.org/show_bug.cgi?id=55719

  • DerivedSources.pro:
  • PluginProcess/qt: Added.
  • PluginProcess/qt/PluginControllerProxyQt.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/qt/PluginProcessMainQt.cpp: Added. (WebKit::PluginProcessMain):
  • PluginProcess/qt/PluginProcessQt.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Added. (WebKit::PluginProxy::needsBackingStore):

Mar 5, 2011:

10:23 PM Changeset in webkit [80433] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-05 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Add method to WebClipboard to read images from the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=55814

  • public/WebClipboard.h: (WebKit::WebClipboard::readImage):
10:11 PM Changeset in webkit [80432] by mitz@apple.com
  • 1431 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

5:40 PM Changeset in webkit [80431] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-05 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded onPageClose function from DrawingArea
https://bugs.webkit.org/show_bug.cgi?id=55836

  • WebProcess/WebPage/DrawingArea.h: Remove empty function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Remove only called
3:38 PM Changeset in webkit [80430] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
http://trac.webkit.org/changeset/80428
https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • http/tests/plugins/resources/dump-post.pl:
  • platform/gtk/Skipped:

2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
http://trac.webkit.org/changeset/80428
https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile):
2:32 PM Changeset in webkit [80429] by Martin Robinson
  • 5 edits in trunk/Source

2011-03-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531

manual test: manual-tests/plugins/windowless.html

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::initXEvent): Instead of setting the window for windowless plugin events, set the window value to none. This method is also used to send focus in / focus out events to windowed plugins, but this is not one of the plugin types where the window parameter matters. This matches what Mozilla does. Also pass in the display of the widget itself, not the default display. (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area, reset the cursor. (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the widget the top-level window explicitly. This matches Mozilla.

2011-03-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here which is more fitting since it sets the cursor for the entire window.
2:02 PM Changeset in webkit [80428] by Martin Robinson
  • 5 edits in trunk

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

  • http/tests/plugins/resources/dump-post.pl: Instead of printing out the "keywords" parameter, print out the POSTDATA parameter. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA.
  • platform/gtk/Skipped: Unskip the test which is now passing.

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.
11:49 AM Changeset in webkit [80427] by bweinstein@apple.com
  • 2 edits in trunk/Tools

Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned

by willSendRequestForFrame. The API expects a retained reference to the URL request.

10:03 AM Changeset in webkit [80426] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness of extension-events.html.

  • inspector/extensions/extensions-events.html:
9:39 AM Changeset in webkit [80425] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=55824

Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype.handleShortcut): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles): (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
9:32 AM Changeset in webkit [80424] by qi.2.zhang@nokia.com
  • 5 edits in trunk/Source

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • WebCore.pri:
  • features.pri:

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
9:10 AM Changeset in webkit [80423] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding null check to prevent inspector tests from failing.

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
8:47 AM Changeset in webkit [80422] by pfeldman@chromium.org
  • 7 edits in trunk

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement): (WebInspector.DOMBreakpointView.prototype._format):

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/dom-breakpoints.html:
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
8:00 AM QtWebKitContrib edited by adawit@kde.org
Fixed the git url for the remote add step. (diff)
6:34 AM Changeset in webkit [80421] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=54974

Properly serialize test output to fix flakiness due to race with output during page reload.

  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • platform/win/Skipped:
5:42 AM Changeset in webkit [80420] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] pause when script is running is broken.
https://bugs.webkit.org/show_bug.cgi?id=55762

  • inspector/CodeGeneratorInspector.pm:
3:20 AM Changeset in webkit [80419] by loislo@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-03-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce protocol test for ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=55819

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest._dumpEvent): (initialize_ProtocolTest.InspectorTest._dumpCallArguments): (initialize_ProtocolTest): (initialize_ProtocolTest.):
  • inspector/protocol/console-agent-expected.txt: Added.
  • inspector/protocol/console-agent.html: Added.
  • inspector/protocol/runtime-agent.html:
3:09 AM Changeset in webkit [80418] by abarth@webkit.org
  • 5 edits
    1 add in trunk/Source

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Rename the action to be friendlier.

  • gyp/JavaScriptCore.gyp:

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Adding the derived source action to the GYP file required tweaking
DerivedSources.make. I'm not sure how DerivedSources.make worked
before beause these paths were incorrectly based.

  • DerivedSources.make:
  • gyp/generate-derived-sources.sh: Added.
  • gyp/WebCore.gyp:
3:07 AM Changeset in webkit [80417] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: install onerror handler in inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55690

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.onError):
  • http/tests/inspector/resources/extension-main.js: (onError):
2:09 AM Changeset in webkit [80416] by pfeldman@chromium.org
  • 30 edits
    2 adds
    1 delete in trunk

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

  • Timeline now uses instrumentation calls, not UI representation while collecting events for tests
  • No reloads in debugger tests that don't need them
  • Forcing layout in timeline via calculating offsetHeight
  • http/tests/inspector/inspector-test.js:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/resources/syntax-error.html: Added.
  • inspector/debugger/resources/syntax-error.js: Removed.
  • inspector/elements/elements-panel-limited-children-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/timeline/timeline-layout.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline.addRecord): (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords):
  • inspector/timeline/timeline-trivial.html:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

  • Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
  • Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::issueEvaluateForTestCommands):
  • inspector/InspectorAgent.h:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord):
  • inspector/front-end/inspector.js: (WebInspector.dispatch):
1:50 AM Changeset in webkit [80415] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should generate fewer than 10,000 compile errors per file
https://bugs.webkit.org/show_bug.cgi?id=55810

This patch adds some missing include paths. We need to figure out how
to handle separate include paths per port. It's clear that
ForwardingHeaders are only useful for Mac, but it's less clear how to
handle the others.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
1:20 AM Changeset in webkit [80414] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
https://bugs.webkit.org/show_bug.cgi?id=55817

Reviewed by Cameron Zwarich.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
a CGFont obtained from Core Text for the primary font. This CGFont may be different from
the CGFont stored in the FontPlatformData.

12:48 AM Changeset in webkit [80413] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Add fast/forms/onchange-setvalueforuser.html to the Skipped
list because of missing layoutTestController.setValueForUser()

  • platform/qt/Skipped:
12:09 AM Changeset in webkit [80412] by commit-queue@webkit.org
  • 27 edits
    4 adds in trunk

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • fast/forms/onchange-change-type-expected.txt: Added.
  • fast/forms/onchange-change-type.html: Added.
  • fast/forms/onchange-setvalueforuser-expected.txt: Added.
  • fast/forms/onchange-setvalueforuser.html: Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused.
Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

Test: fast/forms/onchange-change-type.html
Test: fast/forms/onchange-setvalueforuser.html

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Element.h: (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag. (WebCore::HTMLInputElement::setValue):

For a focused text field, dispatch an input event, but delay the change event until the field loses focus.

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::WMLInputElement): (WebCore::WMLInputElement::defaultEventHandler):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
  • DOM/WebDOMOperationsPrivate.h:
  • WebView/WebViewInternal.h:

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • DumpRenderTree/LayoutTestController.cpp: (setValueForUserCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.

Mar 4, 2011:

11:43 PM Changeset in webkit [80411] by commit-queue@webkit.org
  • 2 edits
    29 adds in trunk/LayoutTests

2011-03-04 Victoria Kirst <vrk@google.com>

Reviewed by Eric Carlson.

[chromium] Baselines for media GPU layout tests
https://bugs.webkit.org/show_bug.cgi?id=55796

Adding baselines for some of the media GPU layout tests.
Updates test_expectations with expected media GPU failures.

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-zoom-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-zoom-expected.png: Added.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-win/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-zoom-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:08 PM Changeset in webkit [80410] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Add a test to ensure SVGImage won't cause ResourceLoader leaks.
https://bugs.webkit.org/show_bug.cgi?id=55017

  • fast/images/svg-image-leak-loader-expected.txt: Added.
  • fast/images/svg-image-leak-loader.html: Added.
  • fast/images/resources/load-script.html: Added.

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Remove fake request loading of SVGImage to avoid MainResourceLoader
leak. The frame->init() already ensures initialization of the
document loader.

https://bugs.webkit.org/show_bug.cgi?id=55017

Test: fast/images/svg-image-leak-loader.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
10:32 PM Changeset in webkit [80409] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

  • platform/chromium/test_expectations.txt:

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::addArc):
10:12 PM Changeset in webkit [80408] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html

Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
to convert the bounding box to window coordinate using ScrollView::contentToWindow().

  • dom/Range.cpp: (WebCore::Range::getBoundingClientRect): (WebCore::Range::boundingRect):
  • dom/Range.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::windowRectForRange):
  • editing/Editor.h:
  • manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
  • manual-tests/autocorrection/document-for-iframe-test.html: Added.

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
is already in window coordinate. We don't need to do further conversion anymore.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::showCorrectionPanel):
10:02 PM Changeset in webkit [80407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-04 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Need symbian version of cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=55782

Implement Symbian version of cryptographicallyRandomValuesFromOS

  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
9:41 PM Changeset in webkit [80406] by simonjam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-04 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Test that scripts with unknown types aren't loaded.
https://bugs.webkit.org/show_bug.cgi?id=51760

  • fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt: Added.
  • fast/dom/HTMLScriptElement/dont-load-unknown-type.html: Added.
9:20 PM Changeset in webkit [80405] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
https://bugs.webkit.org/show_bug.cgi?id=55731

No new tests. There's no behavioral change.

This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().

  • editing/Editor.cpp: (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
8:27 PM Changeset in webkit [80404] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Add test case for (non-)premultiplied-alpha compositing.

  • compositing/webgl/webgl-nonpremultiplied-blend.html: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.checksum: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Update compositor to set the blending of each layer correctly.

Test: compositing/webgl/webgl-nonpremultiplied-blend.html

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):
7:58 PM Changeset in webkit [80403] by jhoneycutt@apple.com
  • 3 edits in trunk/Source/WebKit2

WK2 Mac build fix.

  • UIProcess/API/C/WKPage.cpp:

(WKPageComputePagesForPrinting):
(WKPageBeginPrinting):

  • UIProcess/API/C/WKPagePrivate.h:
6:34 PM Changeset in webkit [80402] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

WK2 Mac build fix.

  • UIProcess/API/C/WKPagePrivate.h:
5:54 PM Changeset in webkit [80401] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Snow Leopard Release Tests] accessibility/plugin.html,
compositing/geometry/empty-embed-rects.html, and fast/loader/loadInProgress.html timing out.
https://bugs.webkit.org/show_bug.cgi?id=55805
https://bugs.webkit.org/show_bug.cgi?id=55807
https://bugs.webkit.org/show_bug.cgi?id=55808

Unreviewed. Add these tests to the Snow Leopard skipped list to get the bots green.

  • platform/mac-snowleopard/Skipped:
5:48 PM Changeset in webkit [80400] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should link with the correct frameworks
https://bugs.webkit.org/show_bug.cgi?id=55804

  • gyp/WebCore.gyp:
5:44 PM Changeset in webkit [80399] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should Check For Inappropriate Files in Framework
https://bugs.webkit.org/show_bug.cgi?id=55806

  • gyp/WebCore.gyp:
5:21 PM Changeset in webkit [80398] by jhoneycutt@apple.com
  • 9 edits in trunk/Source/WebKit2

WK2 needs printing support on Windows
https://bugs.webkit.org/show_bug.cgi?id=55800
<rdar://problem/8903808>

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(ComputedPagesContext::ComputedPagesContext):
(computedPagesCallback):
From the Vector of WebCore::IntRects, build up a Vector of WKRects.
Call the callback, passing these rects and the scale factor.
(printInfoFromWKPrintInfo):
Return a PrintInfo structure from the WKPrintInfo.
(WKPageComputePagesForPrinting):
Call WebPageProxy::computePagesForPrinting(). Pass
computedPagesCallback as the callback function, so that we can
translate the WebCore rect type to WKRect before calling the caller's
callback function.
(WKPageBeginPrinting):
Call WebPageProxy::beginPrinting().
(WKPageDrawPagesToPDF):
Call WebPageProxy::drawPagesToPDF().

  • UIProcess/API/C/WKPagePrivate.h:

Declare the WKPrintInfo type and new functions.

  • UIProcess/WebPageProxy.cpp:

Compile this code on Windows.

  • UIProcess/WebPageProxy.h:

Ditto.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::paint):
We're painting the window; leave printing mode.

  • WebProcess/WebPage/WebPage.cpp:

Compile this code on Windows.

  • WebProcess/WebPage/WebPage.h:

Ditto.

  • WebProcess/WebPage/WebPage.messages.in:

Ditto.

5:15 PM Changeset in webkit [80397] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug 54945 - The web page hangs towards the end of page load in Interpreter enabled javascript code in the latest webkit trunk.

Rubber stamped by olliej.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

(1) don't infinite loop.
(2) goto 1.

5:08 PM Changeset in webkit [80396] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

cmake build fix.

  • CMakeLists.txt:
5:07 PM Changeset in webkit [80395] by sfalken@apple.com
  • 11 edits
    2 deletes in trunk/Source

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Calculate the WebKit version for the useragent via autoversion.h
instead of reading it back from the DLL.


We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

  • WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
  • WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
  • WebView.cpp: (WebView::standardUserAgentWithApplicationName): Use BUILD_NUMBER_SHORT for the version. (osVersion): Removed

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021320>

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

Fetch the WebKit version from a string resource instead of the version resource.

  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::userVisibleWebKitVersionString): Fetch version from a string resource.
  • win/WebKit2.rc: Removed version, added stringtable.
  • win/WebKit2WebProcess.rc: Removed.
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessPostBuild.cmd: Don't run autoversion script. It isn't used in this project.
  • win/WebKit2WebProcessPreBuild.cmd: Stamp version.
  • win/WebKitPostBuild.cmd: Stamp version.
4:58 PM Changeset in webkit [80394] by jeffm@apple.com
  • 19 edits in trunk/Source/WebKit2

Add WKPageValidateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55793

Reviewed by Darin Adler.

On the Mac, validation of edit menu commands is handled within WebKit2 in WKView.mm.
However, on Windows we need to do this in the client, so expose this functionality
in the API via WKPageValidateCommand().

Change the Mac implementation to call WebPageProxy::validateCommand() with a callback
to match this new API, so it no longer has to go through PageClient to get notified
when a command is validated. This makes PageClient::setEditCommandState() obsolete,
so I removed the stub implementations in qt and gtk as well.

  • UIProcess/API/C/WKPage.cpp:

(WKPageValidateCommand): Added.

  • UIProcess/API/C/WKPage.h: Added WKPageValidateCommand().
  • UIProcess/API/mac/PageClientImpl.h: Removed setEditCommandState().
  • UIProcess/API/mac/PageClientImpl.mm: Removed setEditCommandState().
  • UIProcess/API/mac/WKView.mm:

(validateCommandCallback): Added.
(-[WKView validateUserInterfaceItem:]): Pass callback to validateCommand().

  • UIProcess/API/qt/qwkpage.cpp: Removed setEditCommandState().
  • UIProcess/API/qt/qwkpage_p.h: Removed setEditCommandState().
  • UIProcess/PageClient.h: Removed setEditCommandState().
  • UIProcess/WebPageProxy.cpp: Removed didValidateCommand().

(WebKit::WebPageProxy::validateCommand): This now takes a callback.
(WebKit::WebPageProxy::validateCommandCallback): Added.
(WebKit::WebPageProxy::processDidCrash): Invalidate m_validateCommandCallbacks.

  • UIProcess/WebPageProxy.h: Removed didValidateCommand(), validateCommand() now takes a callback.

(WebKit::ValidateCommandCallback::create): Added.
(WebKit::ValidateCommandCallback::~ValidateCommandCallback): Added.
(WebKit::ValidateCommandCallback::performCallbackWithReturnValue): Added.
(WebKit::ValidateCommandCallback::invalidate): Added.
(WebKit::ValidateCommandCallback::ValidateCommandCallback): Added.

  • UIProcess/WebPageProxy.messages.in: Removed DidValidateCommand, added ValidateCommandCallback.
  • UIProcess/gtk/WebView.cpp: Removed setEditCommandState().
  • UIProcess/gtk/WebView.h: Removed setEditCommandState().
  • UIProcess/win/WebView.cpp: Removed setEditCommandState().
  • UIProcess/win/WebView.h: Removed setEditCommandState().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::validateCommand): This now takes a callbackID.

  • WebProcess/WebPage/WebPage.h: validateCommand now takes a callbackID.
  • WebProcess/WebPage/WebPage.messages.in: ValidateCommand now takes a callbackID.
4:55 PM Changeset in webkit [80393] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

  • Source/gyp/configure: Added WebCore.

2011-03-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

This doesn't yet build, but the basic structure is there.

  • WebCore.gypi: Added headers and include directories variables.
  • gyp/WebCore.gyp: Added.
4:35 PM Changeset in webkit [80392] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit2

Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong
https://bugs.webkit.org/show_bug.cgi?id=53919
<rdar://problem/8966020>

Reviewed by Darin Adler.

Adopt the result of m_client.willSendRequestForFrame (which will be leaked by the client).

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):

4:23 PM Changeset in webkit [80391] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

2011-03-04 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

WebKit2 session state should include even loads too new to be in the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=55781
part of <rdar://problem/8968847>

  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::sessionStateData): Save URLs that are early enough in the loading process to not be included in the back/forward list yet: The pending API request URL and the provisional URL. (WebKit::WebPageProxy::restoreFromSessionStateData): Call loadURL if the back/forward list is not restored and a URL is present. Later we can improve the way we handle the case where we have both a back/forward list and a URL.
4:19 PM Changeset in webkit [80390] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Copy Files step to JavaScriptCore GYP build for apitest and minidom
https://bugs.webkit.org/show_bug.cgi?id=55798

4:16 PM Changeset in webkit [80389] by abarth@webkit.org
  • 6 edits in trunk/Source

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

  • WebKit.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

This is just cleanup work, but it was bugging me.

  • WebCore.gyp/WebCore.gyp:
4:13 PM Changeset in webkit [80388] by abarth@webkit.org
  • 1 edit
    1 add in trunk

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add a basic configure script for the GYP build
https://bugs.webkit.org/show_bug.cgi?id=55791

This script just calls GYP on the various gyp projects. As we add more
build systems, this script should be able to select which of them you'd
like to generate the project for.

  • Source/gyp/configure: Added.
4:11 PM Changeset in webkit [80387] by abarth@webkit.org
  • 5 edits
    1 add in trunk

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

This file contains GYP declarations that are shared by all the modules.
Currently, we use this to set up the configurations, albeit primitively.

  • Source/gyp/common.gypi: Added.

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

  • gyp/JavaScriptCore.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

  • gyp/JavaScriptGlue.gyp:
4:00 PM Changeset in webkit [80386] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-04 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Option to use skia's native text drawing APIs when drawing text
on Windows, rather than from outlines using drawPath(). This will
only have a significant effect when the skia-gpu backend is enabled.
https://bugs.webkit.org/show_bug.cgi?id=55609

No new tests. This is disabled by default. When enabled, it will draw
essentially the same, but with slightly different antialiased edges, due
to differences between the current scanconverter and GDI's font scaler.
When enabled, we will have to recalibrate layouttest image results.

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): (WebCore::setupPaintForFont): (WebCore::paintSkiaText):
3:59 PM Changeset in webkit [80385] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

[chromium] Fail new test for JSC feature introduced by r80378
https://bugs.webkit.org/show_bug.cgi?id=55801

  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [80384] by enne@google.com
  • 5 edits
    5 adds
    2 deletes in trunk

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Turn on pixel tests for huge-layer-img.html for better test coverage.
https://bugs.webkit.org/show_bug.cgi?id=55679

Also, modify this test to be more pixel test friendly.

  • compositing/tiling/huge-layer-img-expected.checksum: Added.
  • compositing/tiling/huge-layer-img-expected.png: Added.
  • compositing/tiling/huge-layer-img-expected.txt: Added.
  • compositing/tiling/huge-layer-img.html:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Removed.

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix texture stride issues on large content and image layers.
https://bugs.webkit.org/show_bug.cgi?id=55679

This was an error caused during the refactoring in r80081.

Tests: LayoutTests/compositing/tiling/huge-layer-img.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateTexture):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureIfNeeded):
3:38 PM Changeset in webkit [80383] by tonyg@chromium.org
  • 8 edits in trunk

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
3:36 PM Changeset in webkit [80382] by mrowe@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc

Reviewed by Alexey Proskuryakov.

GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.

  • DumpRenderTree/mac/CheckedMalloc.cpp:

(protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
(makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
and then restore the initial protection flags when we're done.

3:09 PM Changeset in webkit [80381] by jberlin@webkit.org
  • 8 edits in trunk/Source

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Darin Adler.

Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.

Source/WebCore:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):

  • platform/network/mac/ResourceRequestMac.mm:

Source/WebKit2:

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

3:07 PM Changeset in webkit [80380] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>

Reviewed by Darin Adler.

improve layout performance by reducing the traversal time of the floating objects
https://bugs.webkit.org/show_bug.cgi?id=55440

We observered large overhead on traversing the floating objects list
in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
when the list becomes enormous, for example in the default 30x30 maze test
from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
there're >3700 floating objects. When placing a new floating object the
entire list (from begin to end) is traversed for multiple times.
There's a low hanging fruit to reduce the chances to do the traversal
which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
As the two routines either cares about FloatLeft objects or FloatRight objects only,
if we know there's no corresponding type floating objects in the list
we can avoid the traversal actually. One thing we could do is to record
the number of FloatLeft objects and the number of FloatRight objects and
add a check before doing the traversal. This can reduce the time by 45%
to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
Chromium browser 11 (from 503s to 269s).

No new tests, relying on existing layout tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::addOverflowFromFloats): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::removeFloatingObjectsBelow): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::positionNewFloatOnLine): (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::nextFloatLogicalBottomBelow): (WebCore::RenderBlock::lowestFloatLogicalBottom): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats): (WebCore::RenderBlock::containsFloat): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::FloatingObjects::clear): (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount): (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::FloatingObjects::FloatingObjects): (WebCore::RenderBlock::FloatingObjects::hasLeftObjects): (WebCore::RenderBlock::FloatingObjects::hasRightObjects): (WebCore::RenderBlock::FloatingObjects::set):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine):
3:05 PM Changeset in webkit [80379] by commit-queue@webkit.org
  • 8 edits in trunk

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
2:34 PM Changeset in webkit [80378] by barraclough@apple.com
  • 127 edits
    3 adds in trunk

Bug 55736 - Implement seal/freeze/preventExtensions for normal object types.
Provide basic functionallity from section 15.2.4 of ECMA-262.
This support will need expanding to cover arrays, too.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Shows a 0.5% progression on SunSpidey, this seems to be due to changing
ObjectConstructor to use a static table.

(JSC::ExecState::objectConstructorTable):

Add a static table for ObjectConstructor.

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

Add a static table for ObjectConstructor.

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

Add a static table for ObjectConstructor.

  • runtime/JSObject.cpp:

(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):

Transition the object's structure.

(JSC::JSObject::defineOwnProperty):

Check isExtensible.

  • runtime/JSObject.h:

(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):

These wrap method on structure.

(JSC::JSObject::putDirectInternal):

Check isExtensible.

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

Change ObjectConstructor to use a static table.

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

Add new methods on Object.

  • runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

init/propagate m_preventExtensions

(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):

transition the structure, materializing the property map, setting m_preventExtensions & changing attributes.

(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):

check attributes to detect if object is sealed/frozen.

  • runtime/Structure.h:

(JSC::Structure::isExtensible):

checks the m_preventExtensions flag.

LayoutTests:

Update results - many more tests PASS.
Also adds a new testcase.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • ietestcenter/Javascript/15.2.3.10-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-26-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-27-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-26-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-27-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.4-4-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-1-expected.txt:
2:08 PM Changeset in webkit [80377] by sfalken@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix ChangeLog

2:07 PM Changeset in webkit [80376] by evan@chromium.org
  • 2 edits in trunk/Tools

2011-03-04 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[gdb] pretty-print KURL in gdb
https://bugs.webkit.org/show_bug.cgi?id=55788

  • gdb/webkit.py: extend the pretty-printers to print WTF::CString and KURLGooglePrivate. As always, "p/r" can be used to sidestep pretty-printing.
2:06 PM Changeset in webkit [80375] by sfalken@apple.com
  • 5 edits
    1 delete in trunk/Source/WebCore

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Reviewed by NOBODY Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

  • WebCore.vcproj/QTMovieWin.rc: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
  • WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2:05 PM Changeset in webkit [80374] by sfalken@apple.com
  • 4 edits
    1 delete in trunk/Source/JavaScriptCore

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021273>

Reviewed by Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

2:03 PM Changeset in webkit [80373] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to 80355, fixing Qt tests.

  • http/tests/inspector/inspector-test.js:
1:59 PM Changeset in webkit [80372] by mihaip@chromium.org
  • 14 edits
    1 copy
    9 adds in trunk/LayoutTests

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline fast/blockflow.

  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum.
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [80371] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

Clarify comment about potential memory leak in SVGImage
https://bugs.webkit.org/show_bug.cgi?id=55362

No functionality change. No new tests.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:37 PM Changeset in webkit [80370] by jberlin@webkit.org
  • 13 edits in trunk

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Maciej Stachowiak.

When Private Browsing is enabled, get the cached url response from the cache associated with
the Private Browsing Storage Session.

Source/WebCore:

  • WebCore.exp.in:

Export the symbol for ResourceHandle::privateBrowsingStorageSession.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

Source/WebKit2:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the response.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the CFURLCacheRef.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

WebKitLibraries:

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
12:30 PM Changeset in webkit [80369] by mdelaney@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Incorrect location for expected result for 2d.line.cap.closed.html
https://bugs.webkit.org/show_bug.cgi?id=55637

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt.
  • platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
11:21 AM Changeset in webkit [80368] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore GYP build should use a header map
https://bugs.webkit.org/show_bug.cgi?id=55712

This patch moves the os-win32 files into their own variable so that we
can use a header map in the Apple Mac Xcode build. The problem is that
the header map searches the whole project rather than just the files
included in a given target. Another solution to this problem is to
make GYP smarter about filtering out what files are added to the
project file.

11:17 AM Changeset in webkit [80367] by steveblock@google.com
  • 10 edits
    2 moves in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JSC and V8 versions of Java bridge should share JobjectWrapper
https://bugs.webkit.org/show_bug.cgi?id=55763

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JobjectWrapper.cpp: (JobjectWrapper::JobjectWrapper): (JobjectWrapper::~JobjectWrapper):
  • bridge/jni/JobjectWrapper.h: (JSC::Bindings::JobjectWrapper::instance): (JSC::Bindings::JobjectWrapper::setInstance): (JSC::Bindings::JobjectWrapper::ref): (JSC::Bindings::JobjectWrapper::deref):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaArray::JavaArray):
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::JavaInstance):
  • bridge/jni/jsc/JavaInstanceJSC.h:
10:32 AM Changeset in webkit [80366] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add one expected failure for Snow Leopard, make other failure lines
more specific (since the tests pass on SL) and remove some flaky test
entries for tests that are no longer flaky.

  • platform/chromium/test_expectations.txt:
10:08 AM Changeset in webkit [80365] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Move WKViewExecuteCommand() to WKPageExecuteCommand()
https://bugs.webkit.org/show_bug.cgi?id=55744


Executing a command operates on a page, so it makes more sense for it to be in WKPage.
This also makes it available on all platforms, not just Windows.

  • UIProcess/API/C/WKPage.cpp: (WKPageExecuteCommand): Added.
  • UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
  • UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
  • UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().
10:08 AM Changeset in webkit [80364] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

[chromium] Rebaseline to match r80351
https://bugs.webkit.org/show_bug.cgi?id=55783

  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
9:55 AM Changeset in webkit [80363] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 WebKit2 Release Tests] fast/frames/iframe-plugin-load-remove-document-crash.html
and platform/win/plugins/get-value-netscape-window.html crashing.
https://bugs.webkit.org/show_bug.cgi?id=55778
https://bugs.webkit.org/show_bug.cgi?id=55780

Unreviewed. Add these tests to the Windows WebKit2 Skipped list to get the bots green.

  • platform/win-wk2/Skipped:
9:38 AM Changeset in webkit [80362] by Patrick Gansterer
  • 13 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Reviewed by Nikolas Zimmermann.

Move shared code into SVGStyledTransformableElement::svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=55771

All sub classes of SVGStyledTransformableElement request a relayout
the same way. So move that code into the common base class.

  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
9:32 AM QtWebKitReleases edited by Ademar Reis
minor (diff)
9:22 AM Changeset in webkit [80361] by jam@chromium.org
  • 7 edits in trunk/Source

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

  • DEPS:
  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp:

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
9:22 AM Changeset in webkit [80360] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/audio-repaint.html times out
https://bugs.webkit.org/show_bug.cgi?id=55761

  • media/audio-repaint.html: Register the seeked event listener before performing the seek and thus avoid a timeout of the test.
9:20 AM Changeset in webkit [80359] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

LLVM Compiler build fix.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

9:19 AM QtWebKitReleases edited by Ademar Reis
misc fixes + a section about the qtwebkit/tools used for release-management (diff)
8:46 AM Changeset in webkit [80358] by timothy@apple.com
  • 14 edits in trunk

Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).

Reviewed by Darin Adler.

  • WebCore.exp.in: Added ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.

Source/WebKit2: Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

https://webkit.org/b/55623

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.

  • UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.

  • UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
  • UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.

Tools: Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.

Reviewed by Darin Adler.

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::javaScriptCallback):

  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:

(TestWebKitAPI::didRunJavaScript):

  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::nullJavaScriptCallback):

  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:

(TestWebKitAPI::didRunJavaScript):

8:46 AM Changeset in webkit [80357] by timothy@apple.com
  • 2 edits in trunk/Tools

Make run-api-tests show failed if a test fails.

https://webkit.org/b/55725

Reviewed by Sam Weinig.

  • Scripts/run-api-tests:

(runTest): Remove "my" from the nested $result assignment so the
check outside the condition sees the real result.

8:40 AM Changeset in webkit [80356] by podivilov@chromium.org
  • 10 edits in trunk

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
  • inspector/debugger/debug-inlined-scripts.html:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-pause-on-breakpoint.html:
  • inspector/debugger/source-frame.html:

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
to encapsulate source mapping aspects from SourceFrame.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.SourceFrameDelegateForResourcesPanel): (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._doubleClick): (WebInspector.SourceFrame.prototype._didEditLine): (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.requestContent): (WebInspector.SourceFrameDelegate.prototype.debuggingSupported): (WebInspector.SourceFrameDelegate.prototype.setBreakpoint): (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint): (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint): (WebInspector.SourceFrameDelegate.prototype.continueToLine): (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource): (WebInspector.SourceFrameDelegate.prototype.editScriptSource): (WebInspector.SourceFrameDelegate.prototype.debuggerPaused): (WebInspector.SourceFrameDelegate.prototype.evaluate): (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
8:37 AM Changeset in webkit [80355] by caseq@chromium.org
  • 7 edits in trunk

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Use internal ids for resources in extension server.
Log errors in inspector tests.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources
https://bugs.webkit.org/show_bug.cgi?id=55686

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.consoleOutputHook):

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
https://bugs.webkit.org/show_bug.cgi?id=55686

  • Use internal ids for resources in extension server.
  • Log errors in inspector tests.
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.resetResources): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._resourceId): (WebInspector.ExtensionServer.prototype._resourceById):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._reset):
8:25 AM Changeset in webkit [80354] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: exceptions when building context menu in network panel
https://bugs.webkit.org/show_bug.cgi?id=55678

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.dataGridNodeFromNode): (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
8:07 AM Changeset in webkit [80353] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-04 Ilya Sherman <isherman@chromium.org>

Reviewed by James Robinson.

Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
is a FramelessScrollView -- which is mostly just for Autofill.
In service of http://crbug.com/73772 (crash)
https://bugs.webkit.org/show_bug.cgi?id=55557

No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
In particular, DRT crashes when trying to render a FramelessScrollView.

  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner(). (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
  • platform/chromium/FramelessScrollView.cpp: (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromium.h:
7:59 AM Changeset in webkit [80352] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-03-04 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=55667

  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get): only style is fixed
  • ewk/ewk_settings.h:
7:26 AM Changeset in webkit [80351] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix inspector test flake.

  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
7:15 AM Changeset in webkit [80350] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-03-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=55770

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didCommitLoad):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorCSSAgent): (WebCore::InstrumentingAgents::setInspectorCSSAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
7:09 AM Writing Layout Tests for DumpRenderTree edited by playmobil@google.com
Add links to view LayoutTest files in trac . (diff)
7:05 AM Changeset in webkit [80349] by loislo@chromium.org
  • 18 edits in trunk

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::releaseObjectGroup):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._hidePopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
6:51 AM Changeset in webkit [80348] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Gutter height should be 100% when few lines are displayed
https://bugs.webkit.org/show_bug.cgi?id=55574

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
  • inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents .inner-container): (.webkit-line-number):
6:40 AM Changeset in webkit [80347] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Do bisect to find visible chunks
https://bugs.webkit.org/show_bug.cgi?id=55685

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
6:20 AM Changeset in webkit [80346] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] DOMNodeRemoved events are missing
https://bugs.webkit.org/show_bug.cgi?id=55769

5:26 AM Changeset in webkit [80345] by loislo@chromium.org
  • 5 edits in trunk

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-protocol-errors-expected.txt:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/CodeGeneratorInspector.pm:
5:18 AM Changeset in webkit [80344] by christian@webkit.org
  • 8 edits in trunk/Source/WebCore

Enable Copy Image Address context menu item in the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=55136

Reviewed by Gustavo Noronha Silva.

  • page/ContextMenuController.cpp:
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
4:37 AM Changeset in webkit [80343] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Two http auth tests fail with Qt 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=55767

Add failing tests to the Skipped list to make buildbot happy.

  • platform/qt/Skipped: Add http/tests/appcache/auth.html and http/tests/xmlhttprequest/basic-auth.html.
3:16 AM Changeset in webkit [80342] by pfeldman@chromium.org
  • 14 edits in trunk

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement getCompletions via evaluate.
https://bugs.webkit.org/show_bug.cgi?id=55759

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
3:11 AM Changeset in webkit [80341] by loislo@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482

  • http/tests/inspector/protocol-test.js: Added. (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpStepResult): (initialize_ProtocolTest.InspectorTest._runNextStep): (initialize_ProtocolTest.InspectorTest.runProtocolTestSuite): (initialize_ProtocolTest):
  • inspector/protocol/runtime-agent-expected.txt: Added.
  • inspector/protocol/runtime-agent.html: Added.
2:13 AM SuccessfulPortHowTo edited by vikasdalal111@yahoo.co.in
(diff)
2:06 AM Changeset in webkit [80340] by morrita@google.com
  • 3 edits in trunk/Tools

2011-03-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
https://bugs.webkit.org/show_bug.cgi?id=55434

Changed WebTask to be a subclass of webkit_support::TaskAdaptor
and passed the object webkit_support::PostDelayedTask directly.

Note that the change keeps postTask() as is because it has a
semantics taht webkit_support::PostDelayedTask() has; It jumps to
the main thread.

  • DumpRenderTree/chromium/Task.cpp: (postDelayedTask):
  • DumpRenderTree/chromium/Task.h: (WebTask::Run):
1:45 AM Changeset in webkit [80339] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

V8 version of JavaString should obtain string from JNI in UTF-16 encoding
https://bugs.webkit.org/show_bug.cgi?id=55566

We obtain the string from JNI in UTF-16 encoding and convert
to UTF-8 using our own routines as required. This matches the
behaviour of the JSC version of JavaString.

No new tests, no change in behaviour.

  • bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::init): (JSC::Bindings::JavaStringImpl::utf8): (JSC::Bindings::JavaStringImpl::impl):
1:40 AM Changeset in webkit [80338] by pfeldman@chromium.org
  • 19 edits in trunk

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::clearFrontend): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::getDocument): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setDetachedRoot): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMDispatcher.prototype.documentUpdated):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.): (initialize_DebuggerTest):
  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • inspector/console/command-line-api-inspect.html:
  • inspector/elements/dom-agent-query-selector.html:
  • inspector/elements/mutate-unknown-node.html:
  • inspector/styles/styles-new-API.html:
1:26 AM Changeset in webkit [80337] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar may overlap content of the network item view
https://bugs.webkit.org/show_bug.cgi?id=55656

  • drop custom summary bar placement logic, do it with CSS instead.
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.resize): (WebInspector.NetworkPanel.prototype._createSummaryBar): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid td): (.network-sidebar tr.filler td): (.network-summary-bar): (.network-sidebar .data-grid .network-summary-bar td): (.network-summary-bar img):
1:04 AM Changeset in webkit [80336] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.

No intended functionality change.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

No intended functionality change.

  • src/mac/WebInputEventFactory.mm: (WebKit::windowsKeyCodeForKeyEvent): Use the same implementation provided in WebCore/platform/mac/KeyEventMac.mm.
12:53 AM Changeset in webkit [80335] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r80324.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
12:44 AM Changeset in webkit [80334] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-04 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r80324.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
12:38 AM Changeset in webkit [80333] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-04 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin

Expose ability to create instance of DOMFileSystem from Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=55618

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFileSystem):
  • src/WebFrameImpl.h:
12:28 AM Changeset in webkit [80332] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-03-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AppCache agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55673

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::setFrontend): (WebCore::InspectorApplicationCacheAgent::clearFrontend):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
12:06 AM CommitterTips edited by ojan@chromium.org
(diff)

Mar 3, 2011:

11:20 PM Changeset in webkit [80331] by bweinstein@apple.com
  • 11 edits in trunk/Source

Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.

Reviewed by Adam Roben.

Source/WebCore:

Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.

Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
for platforms that don't implement them.

  • platform/android/TemporaryLinkStubs.cpp:
  • platform/brew/TemporaryLinkStubs.cpp:
  • platform/chromium/TemporaryLinkStubs.cpp:
  • platform/efl/TemporaryLinkStubs.cpp:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/haiku/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubsQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:

Source/WebKit2:

Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
on all platforms, and stub the functions on platforms that don't implement them.

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):

11:03 PM Changeset in webkit [80330] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-03 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
https://bugs.webkit.org/show_bug.cgi?id=55720

There are two thing going on here:

  1. Delaying nextRenderer calculation until we actually use it, previously we would always compute nextRenderer (expensive!) even if no renderer insertion was to occur.
  2. Fix fullscreen elements to be inserted into the right place in the rendering tree. Previously they would always be the last child in their parent's list, even if that wasn't the right place.

I don't know of any way to trigger the fullscreen bug,
but I tested this with peacekeeper and saw no performance change.

Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
but I don't really trust the stability of peacekeeper to begin with.

This paves the way for further improvement in our nextRenderer calculation.

  • dom/Node.cpp: (WebCore::Node::attach): (WebCore::Node::previousRenderer): (WebCore::Node::nextRenderer): (WebCore::Node::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h:
10:43 PM Changeset in webkit [80329] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

Correct EntrySync.toURI test expectations to get the test passing under Chromium.
https://bugs.webkit.org/show_bug.cgi?id=55724

  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
10:25 PM Changeset in webkit [80328] by rniwa@webkit.org
  • 7 edits in trunk/Source

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::copyGlobalsTo): Pass nullptr instead of 0. (JSC::JSGlobalObject::resizeRegisters): Ditto; also use OwnArrayPtr instead of a raw pointer.
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals): Ditto.
  • wtf/PassOwnArrayPtr.h: Removed #define LOOSE_PASS_OWN_ARRAY_PTR (WTF::PassOwnArrayPtr::PassOwnArrayPtr): Added a constructor that takes nullptr_t.

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554

  • platform/Length.cpp: (WebCore::newLengthArray): Pass nullptr instead of 0.
10:22 PM Changeset in webkit [80327] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk/Source

2011-03-03 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=54710

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.h: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::writeIndent): (WebCore::ContentLayerChromium::dumpLayerProperties):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::updateNames): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::setupContentsLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.h: (WebCore::ImageLayerChromium::drawsContent): (WebCore::ImageLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setName): (WebCore::LayerChromium::layerTreeAsText): (WebCore::writeIndent): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::dumpLayerProperties):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::name): (WebCore::LayerChromium::drawsContent): (WebCore::LayerChromium::debugID): (WebCore::LayerChromium::layerTypeAsString):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::layerTreeAsText): (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::getHeadsUpDisplay): (WebCore::LayerRendererChromium::rootVisibleRect):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::drawsContent): (WebCore::PluginLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::name): (WebCore::writeIndent): (WebCore::RenderSurfaceChromium::dumpSurface):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::drawsContent): (WebCore::VideoLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::layerTypeAsString):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added. (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::draw): (WebCore::CCHeadsUpDisplay::drawHudContents): (WebCore::CCHeadsUpDisplay::onPresent):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added. (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::showFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree): (WebCore::CCHeadsUpDisplay::showPlatformLayerTree): (WebCore::CCHeadsUpDisplay::enabled):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::writeIndent): (WebCore::CCLayerImpl::dumpLayerProperties):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::debugID): (WebCore::CCLayerImpl::setName): (WebCore::CCLayerImpl::name):

2011-03-03 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Create a LayerChromium layerTreeAsText. Add HUD to
LayerRendererChromium that draws compositor FPS and, optionally,
the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=54710

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setShowFPSCounter): (WebKit::WebSettingsImpl::setShowPlatformLayerTree):
  • src/WebSettingsImpl.h: (WebKit::WebSettingsImpl::showFPSCounter): (WebKit::WebSettingsImpl::showPlatformLayerTree):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doComposite):
10:20 PM Changeset in webkit [80326] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

crash in adoptNode with mutation events
https://bugs.webkit.org/show_bug.cgi?id=50046

  • fast/dom/adopt-node-crash.html:

2011-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

crash in adoptNode with mutation events
https://bugs.webkit.org/show_bug.cgi?id=50046

If the DOM is modified during the removeChild call in adoptNode,
then the setDocument call that follows can leave the DOM in an
inconsistent state.

  • dom/Document.cpp: (WebCore::Document::adoptNode):
10:02 PM Changeset in webkit [80325] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add audio tag tests to the media controls manual test suite.
https://bugs.webkit.org/show_bug.cgi?id=55722

  • manual-tests/media-controls.html: Added 4 audio tests.
9:50 PM Changeset in webkit [80324] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
https://bugs.webkit.org/show_bug.cgi?id=54392

Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
WebCore's functions should adhere WebKit coding style.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntryReset): (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate): (WebCore::RenderThemeEfl::cacheThemePartNew): (WebCore::RenderThemeEfl::cacheThemePartReset): (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): (WebCore::RenderThemeEfl::cacheThemePartGet): (WebCore::RenderThemeEfl::cacheThemePartFlush): (WebCore::RenderThemeEfl::applyEdjeStateFromForm): (WebCore::RenderThemeEfl::paintThemePart): (WebCore::renderThemeEflColorClassSelectionActive): (WebCore::renderThemeEflColorClassSelectionInactive): (WebCore::renderThemeEflColorClassFocusRing): (WebCore::renderThemeEflColorClassButtonText): (WebCore::renderThemeEflColorClassComboText): (WebCore::renderThemeEflColorClassEntryText): (WebCore::renderThemeEflColorClassSearchText): (WebCore::RenderThemeEfl::applyPartDescription): (WebCore::RenderThemeEfl::applyPartDescriptions): (WebCore::RenderThemeEfl::controlSupportsTints): (WebCore::RenderThemeEfl::baselinePosition): (WebCore::RenderThemeEfl::paintSliderTrack): (WebCore::RenderThemeEfl::adjustSliderTrackStyle): (WebCore::RenderThemeEfl::adjustSliderThumbStyle): (WebCore::RenderThemeEfl::paintSliderThumb): (WebCore::RenderThemeEfl::adjustCheckboxStyle): (WebCore::RenderThemeEfl::paintCheckbox): (WebCore::RenderThemeEfl::adjustRadioStyle): (WebCore::RenderThemeEfl::paintRadio): (WebCore::RenderThemeEfl::adjustButtonStyle): (WebCore::RenderThemeEfl::paintButton): (WebCore::RenderThemeEfl::adjustMenuListStyle): (WebCore::RenderThemeEfl::paintMenuList): (WebCore::RenderThemeEfl::adjustTextFieldStyle): (WebCore::RenderThemeEfl::paintTextField): (WebCore::RenderThemeEfl::adjustTextAreaStyle): (WebCore::RenderThemeEfl::paintTextArea): (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeEfl::paintSearchFieldDecoration): (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeEfl::paintSearchFieldResultsButton): (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration): (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeEfl::paintSearchFieldCancelButton): (WebCore::RenderThemeEfl::adjustSearchFieldStyle): (WebCore::RenderThemeEfl::paintSearchField): (WebCore::RenderThemeEfl::adjustProgressBarStyle): (WebCore::RenderThemeEfl::paintProgressBar): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
9:36 PM Changeset in webkit [80323] by abarth@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add jsc to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55711

  • JavaScriptCore.gypi:
    • Move jsc.cpp into jsc_files because it's really part of the jsc target.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Remove extraneous files from the normal jsc build. I probably added these by mistake at some point.
  • gyp/JavaScriptCore.gyp:
    • Add the jsc target to the GYP file.
9:36 PM Changeset in webkit [80322] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-03 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Refactor classes in GenericCallback.h
https://bugs.webkit.org/show_bug.cgi?id=55732


Since we're going to need to add additional callback classes, make a CallbackBase class that manages
the context and the callback ID. The existing callback classes (VoidCallback, GenericCallback, and
ComputedPagesCallback) now all derive from CallbackBase.


Fix bug in VoidCallback where we meant to implement the destructor, but we were implementing the default
constructor instead (we forgot the leading ~).


  • UIProcess/GenericCallback.h: (WebKit::CallbackBase::~CallbackBase): (WebKit::CallbackBase::callbackID): (WebKit::CallbackBase::CallbackBase): (WebKit::CallbackBase::context): (WebKit::CallbackBase::generateCallbackID): (WebKit::VoidCallback::~VoidCallback): (WebKit::VoidCallback::performCallback): (WebKit::VoidCallback::invalidate): (WebKit::VoidCallback::VoidCallback): (WebKit::GenericCallback::create): (WebKit::GenericCallback::~GenericCallback): (WebKit::GenericCallback::performCallbackWithReturnValue): (WebKit::GenericCallback::invalidate): (WebKit::GenericCallback::GenericCallback): (WebKit::ComputedPagesCallback::create): (WebKit::ComputedPagesCallback::~ComputedPagesCallback): (WebKit::ComputedPagesCallback::performCallbackWithReturnValue): (WebKit::ComputedPagesCallback::invalidate): (WebKit::ComputedPagesCallback::ComputedPagesCallback):
9:24 PM Changeset in webkit [80321] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add testapi to JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55707

The new testapi target is slightly incomplete. There's a resource
copying step that we don't quite have yet.

This patch also cleans up some of the configuration issues in
JavaScriptCore.xcodeproj. It seems kind of wordy to repeat these for
each target. I suspect there's a more compact way of defining the
configurations, but this removes the "Default" configuration, which is
progress.

9:15 PM Changeset in webkit [80320] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2011-03-03 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Assertion failure in toElement(WebCore::Node*)
https://bugs.webkit.org/show_bug.cgi?id=55697

  • fast/parser/fragment-foreign-content-expected.txt: Added.
  • fast/parser/fragment-foreign-content.html: Added.

2011-03-03 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Assertion failure in toElement(WebCore::Node*)
https://bugs.webkit.org/show_bug.cgi?id=55697

Test: fast/parser/fragment-foreign-content.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current element in the HTMLElementStack might be a DocumentFragment if a fragment is being parsed who's first node is foreign content.
9:13 PM Changeset in webkit [80319] by commit-queue@webkit.org
  • 13 edits in trunk

2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334

Re-enable geolocation layout testing for qt port. Also enable a long pending
failure with geolocation as it works with client-based geolocation.
Skipped one last case related to multiple window which needs some code cleanup in qt DRT.

  • platform/qt/Skipped:

2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334

Implements client() to GeolocationController to re-use geolocationClientMock class
for layout testing purpose.

  • page/GeolocationController.h: (WebCore::GeolocationController::client):

2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334

Implement layout testing for Client-Based geolocation. If drt_run is set
then create mock geolocationClient and update the same with controller.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::mockGeolocationReset): (DumpRenderTreeSupportQt::setMockGeolocationPermission): (DumpRenderTreeSupportQt::setMockGeolocationPosition): (DumpRenderTreeSupportQt::setMockGeolocationError):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::GeolocationClientQt):
  • WebCoreSupport/GeolocationClientQt.h:

2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[QT] Implement mock client-based geolocation for layout testing
https://bugs.webkit.org/show_bug.cgi?id=54334

Implement testing for Client-Based geolocation for QtWebkit.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition):
9:00 PM Changeset in webkit [80318] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Update GPU media/media-document-audio-repaint.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fmedia-document-audio-repaint.html

  • platform/chromium/test_expectations.txt:
8:58 PM Changeset in webkit [80317] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=55352

Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and no longer calls deprecated functions.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion. Check if the text node inside a tab span before checking if the container node is a text node because the position before or after a text node can still be inside a tab span. (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
  • editing/InsertTextCommand.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start or the end of selection could be an immediate child of a list node (e.g. br inside ul)
8:55 PM Changeset in webkit [80316] by jeremy@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-03 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Annotate bidi tests which we intentionally fail.
https://bugs.webkit.org/show_bug.cgi?id=48522

Add a readme file in fast/text/international detailing
a bunch of tests that we intentionally fail. This
mimics a similar file in fast/block/positioning/.

  • fast/text/international/readme.txt: Added.
8:52 PM Changeset in webkit [80315] by hans@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Move last bits of SQL into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55668

After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.

No new tests: refactoring only.

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::createTransaction):
  • storage/IDBBackingStore.h:
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::backingStore):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBKey.h:
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp:
8:50 PM Changeset in webkit [80314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebFrame::setUrl works only from second time if url fragment is present
https://bugs.webkit.org/show_bug.cgi?id=32723

Create an auto-test for Qt based on the bug description.

  • tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
8:25 PM Changeset in webkit [80313] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Tighten up ResolveURICallbacks
https://bugs.webkit.org/show_bug.cgi?id=55638

Two changes:

  • Retry only on TYPE_MISMATCH_ERR now that Chromium properly sets that error code.
  • Call DirectoryEntry instead of DOMFileSystem methods.

No change in behavior, so no new tests.

  • fileapi/FileSystemCallbacks.cpp: (WebCore::ResolveURICallbacks::didOpenFileSystem):
8:09 PM Changeset in webkit [80312] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach JavaScriptCore GYP build about private headers
https://bugs.webkit.org/show_bug.cgi?id=55532

This patch distinguishes between public and private framework headers
so that public headers are copied into the Headers directory and
private headers are copied into the PrivateHeaders directory.

  • gyp/JavaScriptCore.gyp:
7:41 PM Changeset in webkit [80311] by levin@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-03 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Need web worker referer layout test for xhr requests.
https://bugs.webkit.org/show_bug.cgi?id=55590

Verify that the referrer is set for sync and async XHR requests
from both workers and shared workers.

  • http/tests/xmlhttprequest/workers/referer-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/referer.html: Added.
  • http/tests/xmlhttprequest/workers/resources/referer-test.js: Added.
  • http/tests/xmlhttprequest/workers/resources/referer.js: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/shared-worker-referer.html: Added.
7:21 PM Changeset in webkit [80310] by andersca@apple.com
  • 19 edits in trunk/Source

2011-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Get the current history item and update it using WebView::setGlobalHistoryItem.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView.cpp: (WebView::globalHistoryItem): (WebView::setGlobalHistoryItem):
  • WebView.h:

2011-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Get the current history item and update it using -[WebView _setGlobalHistoryItem:].


  • WebView/WebView.mm: (-[WebView _globalHistoryItem]): (-[WebView _setGlobalHistoryItem:]): Set _globalHistoryItem ivar.
  • WebView/WebViewData.h:
  • WebView/WebViewData.mm: Add _globalHistoryItem ivar.

2011-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738

The m_globalHistoryItem is only used by Mac and Windows WebKit1.
Instead of having WebCore updating this member variable, just call out
to a FrameLoaderClient member function and let WebKit keep it up to date.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
  • loader/HistoryController.cpp: (WebCore::HistoryController::goToItem): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
  • page/Page.cpp:
  • page/Page.h:
7:00 PM Changeset in webkit [80309] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't assume the web process has had a chance to paint before the view has to paint

Fixes <http://webkit.org/b/55739> REGRESSION (r80307): Lots of tests crashing in
BackingStore::paint

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paint): Bail if the web process hasn't had a chance to paint
yet.

6:18 PM Changeset in webkit [80308] by jorlow@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Cursor.continue with a key param should test less than, not equal to
https://bugs.webkit.org/show_bug.cgi?id=55640

  • storage/indexeddb/cursor-continue-expected.txt: Added.
  • storage/indexeddb/cursor-continue.html: Added.

2011-03-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Cursor.continue with a key param should test less than, not equal to
https://bugs.webkit.org/show_bug.cgi?id=55640

If you supply a param to cursor.continue, we sould guarantee that
the item we continue to is greater than or equal to the parameter.
Right now, we only test equality.

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor

Test: storage/indexeddb/cursor-continue.html

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  • storage/IDBKey.cpp: (WebCore::IDBKey::isLessThan): (WebCore::IDBKey::isEqual):
  • storage/IDBKey.h:
5:37 PM Changeset in webkit [80307] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Throw away DrawingAreaProxyImpl's backing store after not painting for 5 seconds

The intent is to save memory for views that aren't painting.

Fixes <http://webkit.org/b/51262> <rdar://problem/8782537> WebPageProxy should delete its
backing store after not painting for a while

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize our timer.
(WebKit::DrawingAreaProxyImpl::paint): Don't bail if we don't have a backing store (but do
bail if we're in accelerated compositing mode); we might have thrown it away to save memory
but now are being asked to paint by the view. The existing code in this function will handle
getting a new backing store if possible by blocking for a little while to try to receive a
DidUpdateBackingStoreState message. Added an assertion that we do have a backing store if we
don't have any outstanding UpdateBackingStoreState requests. After painting, call
discardBackingStoreSoon to update our timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Set the timer for 5 seconds in the
future.
(WebKit::DrawingAreaProxyImpl::discardBackingStore): Throw away the backing store, and tell
the web process we'll need a full backing store update on the next paint.

  • UIProcess/DrawingAreaProxyImpl.h: Added m_discardBackingStoreTimer.
5:36 PM Changeset in webkit [80306] by Adam Roben
  • 7 edits in trunk/Source/WebKit2

Add a way to tell the web process to perform a full backing store update on its next paint

Messages::DrawingArea::UpdateBackingStoreState now takes a boolean specifying whether the
full backing store update should happen immediately or should be deferred until the next
paint or compositing mode change occurs. The deferred update isn't used yet, but will be
used when we start throwing away backing stores to save memory.

Fixes <http://webkit.org/b/55730> UI process needs a way to tell the web process its backing
store needs a full update on the next paint

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::paint): If we have an outstanding backing store state change
request, tell the web process to perform the backing store update right away, in case we
previously told it it could defer the update.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Specify that we need an immediate backing
store update.
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): We can no longer assert that we
were waiting for a DidUpdateBackingStoreState message when we receive one, as it's possible
for the web process to decide to send us this message on its own (if we asked it to do a
deferred backing store update and then it needed to paint some part of the page). Specify
that we need an immediate backing store update if the web process hasn't updated to our
latest state, as we're about to draw potentially out-of-date bits to the screen and want to
get the right bits as soon as possible. Also added a FIXME about a potential optimization.
(WebKit::DrawingAreaProxyImpl::backingStoreStateDidChange): Added a RespondImmediatelyOrNot
parameter, which is just passed through to sendUpdateBackingStoreState.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Added a RespondImmediatelyOrNot
parameter that is used to specify to the web process whether to perform the full backing
store update immediately. We now only wait for a DidUpdateBackingStoreState message (and
thus suppress any more UpdateBackingStoreState messages until one is received) when we ask
the web process for an immediate response; otherwise we could end up accidentally calling
waitForAndDispatchDidUpdateBackingStoreState when the web process hasn't been told to send
us such a message.

  • UIProcess/DrawingAreaProxyImpl.h: Added RespondImmediatelyOrNot.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateBackingStoreState): Added respondImmediately argument.

  • WebProcess/WebPage/DrawingArea.messages.in: Added respondImmediately argument to

UpdateBackingStoreState message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member that's used to track
whether we should send a DidUpdateBackingStoreState message instead of an Update or
compositing mode change message. This will be set to true when a deferred backing store
update is pending.
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message.
(WebKit::DrawingAreaImpl::updateBackingStoreState): Added respondImmediately argument. If
we've already been told about this state ID (as can happen when the UI process decides it
needs an immediate update to a state that it previously requested a deferred update to),
don't bother updating the page's size, etc. In addition, if we've already sent a
DidUpdateBackingStoreState message for this state, we don't have to do anything at all.
Moved code to send the DidUpdateBackingStoreState message from here...
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): ...to here.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Always update our dirty region,
even if painting is suspended or we're in the process of updating the backing store state.
It causes no harm and simplifies the code. If a deferred update is pending, send a
DidUpdateBackingStoreState message instead of a compositing mode change message. Also
removed a redundant if.
(WebKit::DrawingAreaImpl::display): Added an assertion that this isn't called while updating
backing store state, as otherwise we might end up sending two DidUpdateBackingStoreState
messages. If a deferred update is pending, send a DidUpdateBackingStoreState message instead
of an Update message.

  • WebProcess/WebPage/DrawingAreaImpl.h: Updated updateBackingStoreState to match the base

class. Added sendDidUpdateBackingStoreState and m_shouldSendDidUpdateBackingStoreState.

5:36 PM Changeset in webkit [80305] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build correction.

  • WebFrame.cpp:

(scaleFactor): Update after 77286 to replace right/bottom
with new maxX/maxY terminology.

5:31 PM Changeset in webkit [80304] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

Build fix. Need win/cURL DownloadBundle stub.

  • platform/network/curl/DownloadBundle.h: Added.
5:27 PM Changeset in webkit [80303] by ggaren@apple.com
  • 30 edits in trunk/Source

2011-03-03 Geoffrey Garen <ggaren@apple.com>

Rolled out 80277 and 80280 because they caused event handler layout test
failures.

4:58 PM Changeset in webkit [80302] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

4:55 PM Changeset in webkit [80301] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80237.
http://trac.webkit.org/changeset/80237
https://bugs.webkit.org/show_bug.cgi?id=55714

Windows bots aren't ready to be core (Requested by aroben on
#webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:55 PM Changeset in webkit [80300] by mrowe@apple.com
  • 1 copy in tags/Safari-534.23

New tag.

4:52 PM Changeset in webkit [80299] by beidson@apple.com
  • 24 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer

Reviewed by Darin Adler.

../WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::icon):
(WebCore::HistoryItem::setURLString):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconDatabase.cpp:

(WebCore::iconDatabase):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseNone.cpp:

(WebCore::iconDatabase):

  • loader/icon/wince/IconDatabaseWinCE.cpp:

(WebCore::iconDatabase):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::finishLoading):

../WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):
(ewk_settings_icon_database_path_get):
(ewk_settings_icon_database_clear):
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

../WebKit/gtk:

  • webkit/webkitglobals.cpp:

(closeIconDatabaseOnExit):
(WebKit::setIconDatabaseEnabled):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_icon_uri):

../WebKit/mac:

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics iconPageURLMappingCount]):
(+[WebCoreStatistics iconRetainedPageURLCount]):
(+[WebCoreStatistics iconRecordCount]):
(+[WebCoreStatistics iconsWithDataCount]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase isEnabled]):
(-[WebIconDatabase setEnabled:]):
(-[WebIconDatabase removeAllIcons]):
(+[WebIconDatabase _checkIntegrityBeforeOpening]):
(-[WebIconDatabase _startUpIconDatabase]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
(importToWebCoreFormat):

  • WebView/WebView.mm:

(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

../WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath):
(QWebSettings::iconDatabasePath):
(QWebSettings::clearIconDatabase):
(QWebSettings::iconForUrl):

../WebKit/win:

  • WebCoreStatistics.cpp:

(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):

  • WebIconDatabase.cpp:

(WebIconDatabase::init):
(WebIconDatabase::startUpIconDatabase):
(WebIconDatabase::iconForURL):
(WebIconDatabase::retainIconForURL):
(WebIconDatabase::releaseIconForURL):
(WebIconDatabase::removeAllIcons):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::isEnabled):
(WebIconDatabase::setEnabled):
(WebIconDatabase::hasIconForURL):
(WebIconDatabase::getOrCreateDefaultIconBitmap):

  • WebKitDLL.cpp:

(shutDownWebKit):

4:49 PM Changeset in webkit [80298] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Martin Robinson.

Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=52742

Use firstPositionInOrBeforeNode to instantiate appropriate position.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder):
4:42 PM Changeset in webkit [80297] by aestes@apple.com
  • 11 edits in trunk/Source

When displaying the missing plug-in sheet, pass the 'pluginspage'
attribute to the UI process.
https://bugs.webkit.org/show_bug.cgi?id=55553

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Export ZN7WebCore9HTMLNames15pluginspageAttrE.
  • html/HTMLAttributeNames.in: Add 'pluginspage' as a known content

attribute.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h: Add pluginsPageURL as the third argument to

missingPluginButtonClicked.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::missingPluginButtonClicked): Ditto.

  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::missingPluginButtonClicked): Ditto.

  • UIProcess/WebUIClient.h: Ditto.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::missingPluginButtonClicked): Get the value of
pluginspageAttr.

4:32 PM Changeset in webkit [80296] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Suggested by Dan Bernstein.

Move "const" around "NSString *", so that it suddenly begins to make sense.

  • WebProcess/mac/FullKeyboardAccessWatcher.mm:
4:11 PM Changeset in webkit [80295] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-03 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Add WKViewRef API for executing edit commands
https://bugs.webkit.org/show_bug.cgi?id=49829

Added WKViewExecuteCommand() and documented some of the WebCore EditorCommand strings.

  • UIProcess/API/C/win/WKView.cpp: (WKViewExecuteCommand): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewExecuteCommand() and comment block with WebCore EditorCommand strings.
3:43 PM Changeset in webkit [80294] by jberlin@webkit.org
  • 19 edits in trunk

Source/WebCore: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebCore.exp.in:

Support using WKCopyRequestWithStorageSession in WebCore.

  • platform/mac/WebCoreSystemInterface.h:

Ditto.

  • platform/mac/WebCoreSystemInterface.mm:

Ditto.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
(WebCore::ResourceHandle::willSendRequest):
Ditto.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::setStorageSession):
Call through to WKSI.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::setStorageSession):
Ditto.

Source/WebKit/mac: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.

Source/WebKit2: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Support using WKCopyRequestWithStorageSession in WebCore.

WebKitLibraries: WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435

Reviewed by Adam Roben.

Set the Private Browsing Storage Session on requests when Private Browsing is enabled.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
3:36 PM Changeset in webkit [80293] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

Fix a couple more media/ expectations.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [80292] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Don't try to paint outside the page's bounds

When the page is resized smaller, we would allocate a ShareableBitmap at the old, larger
size, even though we only needed to paint at the new, smaller size.

The assertion added in this patch will fire during the WebKit2/ResizeViewWhileHidden API
test if this fix gets broken in the future.

Fixes <http://webkit.org/b/55715> DrawingAreaImpl allocates more memory than necessary when
the page is resized smaller

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState): Update our dirty region even if painting
is suspended (but still refrain from updating it when in accelerated compositing mode).
Rather than unite our existing dirty region with the page's new bounds, overwrite our dirty
region with the page's new bounds. This prevents us from accumulating a dirty region that is
larger than the page in the case where the page is being resized smaller.
(WebKit::DrawingAreaImpl::display): Added an assertion that we're not trying to paint
outside of the page's bounds.

3:28 PM Changeset in webkit [80291] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

Add another media/ crash.

  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [80290] by mihaip@chromium.org
  • 32 edits
    27 copies
    27 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline tables/mozilla/bugs/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we scale the images differently
(most likely due to CG i386 vs. x86_64 differences, see bug 52335).

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12910-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14929-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4523-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug97383-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [80289] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-03 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022

Changed the way default TimingFunction is stored according to Adam Roben's
suggestion.

  • platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3:09 PM Changeset in webkit [80288] by mitz@apple.com
  • 15 edits in trunk

Rename -webkit-hyphenate-locale to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=55709

Reviewed by Sam Weinig.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::cssPropertyID):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::locale):
(WebCore::InheritedFlags::setLocale):
(WebCore::InheritedFlags::initialLocale):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/text/hyphenate-character.html:
  • fast/text/hyphenate-first-word.html:
  • fast/text/hyphenate-locale.html:
  • fast/text/hyphens.html:
2:51 PM Changeset in webkit [80287] by kevino@webkit.org
  • 8 edits in trunk

[wx] Build fixes for Windows.

2:41 PM Changeset in webkit [80286] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Two tests crash on Snow Leopard on the GPU path.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [80285] by oliver@apple.com
  • 15 edits in trunk/Source

2011-03-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698

Replace the direct usage of Register in JSVariableObject (and descendents)
with WriteBarrier. This requires updating the Arguments object to use
WriteBarrier as well.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArgList.h: (JSC::MarkedArgumentBuffer::initialize):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::copyToRegisters): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::symbolTableGet): (JSC::JSActivation::symbolTablePut): (JSC::JSActivation::symbolTablePutWithAttributes): (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes): (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::put): (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::markChildren): (JSC::JSGlobalObject::copyGlobalsFrom): (JSC::JSGlobalObject::copyGlobalsTo): (JSC::JSGlobalObject::resizeRegisters):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::setRegisters): (JSC::JSGlobalObject::addStaticGlobals):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put): (JSC::JSStaticScopeObject::putWithAttributes):
  • runtime/JSVariableObject.cpp: (JSC::JSVariableObject::symbolTableGet):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::registerAt): (JSC::JSVariableObject::JSVariableObjectData::JSVariableObjectData): (JSC::JSVariableObject::symbolTableGet): (JSC::JSVariableObject::symbolTablePut): (JSC::JSVariableObject::symbolTablePutWithAttributes): (JSC::JSVariableObject::copyRegisterArray): (JSC::JSVariableObject::setRegisters):

2011-03-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698

Update to pass JSGlobalData for the symbol table write used
to set the document property.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::updateDocument):
2:18 PM Changeset in webkit [80284] by mihaip@chromium.org
  • 5 edits in trunk/Tools

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
https://bugs.webkit.org/show_bug.cgi?id=55694

Fixes for interruptions in NRWT:

  • Make TestRunInterruptedException be pickleable correctly (the base Exception class defines a reduce that does not include the reason)
  • Fix ordering of returned arguments from TestRunner2._run_tests (interrupted and keyboard_interrupted were reversed)
  • Fix cancel_workers callsites (was using old name).
  • In handle_exception re-raise actual exception instance that was thrown
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:04 PM Changeset in webkit [80283] by ap@apple.com
  • 2 edits
    1 move in trunk/Source/WebCore

More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.

  • WebCore.xcodeproj/project.pbxproj:
  • page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
  • page/mac/WebCoreKeyboardUIMode.h: Removed.
1:55 PM Changeset in webkit [80282] by ap@apple.com
  • 18 edits in trunk/Source

Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.

  • page/ChromeClient.h:
1:46 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:45 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:45 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:44 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:42 PM Changeset in webkit [80281] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Brady Eidson.

WebProcess is calling CFURLCacheRemoveAllCachedResponses when loading, results in origin-load for all resources
https://bugs.webkit.org/show_bug.cgi?id=55701
<rdar://problem/9074017>

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize cache-clearing flag parameters to false. (WebKit::WebProcessCreationParameters::encode): Serialize them properly. (WebKit::WebProcessCreationParameters::decode): And deserialize.
1:42 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:42 PM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
1:41 PM QtWebKitCheckList created by alexis.menard@openbossa.org
1:39 PM Changeset in webkit [80280] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed obsolete symbol.
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlot): Don't mark this function
inline -- it's virtual.

1:34 PM Changeset in webkit [80279] by ap@apple.com
  • 41 edits
    2 adds in trunk/Source

Reviewed by Darin Adler.

REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/mac/FullKeyboardAccessWatcher.h: Added.
  • WebProcess/mac/FullKeyboardAccessWatcher.mm: Added. (-[FullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): (-[FullKeyboardAccessWatcher init]): (+[FullKeyboardAccessWatcher fullKeyboardAccessEnabled]): Get the current state of full keyboard access, listening for change notifications.
  • WebProcess/WebProcess.h: Added fullKeyboardAccessEnabled().
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::fullKeyboardAccessEnabled): WebKit1 also doesn't implement this on platforms other than Mac.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::fullKeyboardAccessEnabled): Just ask FullKeyboardAccessWatcher.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::keyboardUIMode):
  • WebProcess/WebCoreSupport/WebChromeClient.h: Added keyboardUIMode(), removed tabsToLinks().
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyboardUIMode):
  • WebProcess/WebPage/WebPage.h: Generate keyboard UI mode from tabToLinks preference and current state of FKA.
1:28 PM Changeset in webkit [80278] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Fix Win compile break, caused by r80276.

  • rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton

to match RenderTheme.h.

1:24 PM Changeset in webkit [80277] by ggaren@apple.com
  • 27 edits in trunk/Source

2011-03-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653

  • JavaScriptCore.exp:
  • bytecompiler/BytecodeGenerator.cpp:
  • jit/JITOpcodes.cpp:
  • runtime/Arguments.h:
  • runtime/JSActivation.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): Added an imprecise size class to accomodate objects up to 1K.
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/JSObject.cpp: Don't ASSERT that JSFinalObject fills the maximum object size, since it doesn't anymore.
  • runtime/JSStaticScopeObject.cpp:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.h: Removed out-of-line storage. Changed d-> to m_.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: Added an imprecise size class to accomodate objects up to 1K.

2011-03-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSRun.h: (JSGlueGlobalObject::Flags): (JSGlueGlobalObject::userObjectStructure): Removed out-of-line storage. Changed d-> to m_.

2011-03-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
1:19 PM Changeset in webkit [80276] by Dimitri Glazkov
  • 11 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
https://bugs.webkit.org/show_bug.cgi?id=55099

Cleanup, no behavior change.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox

instead of Node.

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed

to use RenderBox as argument.

  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeChromiumMac.h: Ditto.
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
1:06 PM Changeset in webkit [80275] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-03 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Give the Bundle's policy client the option of deciding the policy
https://bugs.webkit.org/show_bug.cgi?id=55699

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add WKBundlePagePolicyAction enum and make it the return value of the WKBundlePagePolicyClient functions.
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: (WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction): (WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction): (WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Pass the return value back to the caller. For unimplemented functions, return WKBundlePagePolicyActionPassThrough.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Call the policy function early if the bundle handles it.
1:03 PM Changeset in webkit [80274] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
for GstElement.

  • WebCore.pro:
  • features.pri:
1:00 PM Changeset in webkit [80273] by loislo@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80272.
http://trac.webkit.org/changeset/80272
https://bugs.webkit.org/show_bug.cgi?id=55700

the test are flaky (Requested by loislo_ on #webkit).

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addObject):
  • http/tests/inspector/protocol-test.js: Removed.
  • inspector/protocol/runtime-agent-expected.txt: Removed.
  • inspector/protocol/runtime-agent.html: Removed.
12:22 PM Changeset in webkit [80272] by loislo@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482

  • http/tests/inspector/protocol-test.js: Added. (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpStepResult): (initialize_ProtocolTest.InspectorTest._runNextStep): (initialize_ProtocolTest.InspectorTest.runProtocolTestSuite): (initialize_ProtocolTest):
  • inspector/protocol/runtime-agent-expected.txt: Added.
  • inspector/protocol/runtime-agent.html: Added.
11:58 AM Changeset in webkit [80271] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix the Windows build again.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:58 AM Changeset in webkit [80270] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-03-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
https://bugs.webkit.org/show_bug.cgi?id=55568

We should use updateMicroFocus() from QGraphicsItem rather than the implementation
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
in QGraphicsItem.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
11:54 AM Changeset in webkit [80269] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Add another CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55693

To help track down bug 53045, add a CRASH call when the the array and/or
CSSSelector member in CSSSelectorList is disposed of more than once.

Just a check, no new tests necessary.

  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):
11:51 AM Changeset in webkit [80268] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Yet another attempt at fixing the Windows build.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:36 AM Changeset in webkit [80267] by qi.2.zhang@nokia.com
  • 2 edits in trunk/Tools

Unreviewed.

Adding myself as a committer.

11:33 AM Changeset in webkit [80266] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebCore

2011-03-02 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022

Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
is now always passed in. The TimingFunction class now has a static method to get
a default object which has the 'ease' values in it. I now assert in both Mac and
Win implementations if a null TimingFunction pointer is seen.

  • platform/animation/TimingFunction.h: (WebCore::CubicBezierTimingFunction::create): (WebCore::CubicBezierTimingFunction::defaultTimingFunction): (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (toCAMediaTimingFunction):
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (toCACFTimingFunction):
11:28 AM Changeset in webkit [80265] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix clang compile after r80220
https://bugs.webkit.org/show_bug.cgi?id=55692

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
11:21 AM Changeset in webkit [80264] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
11:16 AM Changeset in webkit [80263] by bweinstein@apple.com
  • 16 edits
    2 adds in trunk/Source

Source/WebCore: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

Add functions to be exported.

  • WebCore.exp.in:

Source/WebKit2: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>

Reviewed by Adam Roben.

This patch adds the communication from the WebProcess <-> UIProcess about starting/stopping
listening for cookies changing, and adds a mechanism for the WebProcess to notify the UIProcess
when the cookies have changed. The WebProcess sends a message to the UIProcess when the cookies
change, and the UIProcess passes this along to the WebCookieManagerProxyClient.

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient): Call through to WebCookieManagerProxy.
(WKCookieManagerStartObservingCookieChanges): Ditto.
(WKCookieManagerStopObservingCookieChanges): Ditto.

  • UIProcess/API/C/WKCookieManager.h: Add new functions and a WKCookieManagerClient

which is responsible for cookiesDidChange.

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Send the message down to the web process.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::cookiesDidChange): Tell the WKCookieManagerClient the cookies were

modified.

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.messages.in: Add new messages.
  • UIProcess/WebCookieManagerProxyClient.cpp: Added.

(WebKit::WebCookieManagerProxyClient::cookiesDidChange): Calls through to the client saying that

cookies changed.

  • UIProcess/WebCookieManagerProxyClient.h: Added.


  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::startObservingCookieChanges): Call through to WebCore::startObservingCookieChanges

(on platforms that support it).

(WebKit::WebCookieManager::stopObservingCookieChanges): Ditto (for stopObservingCookieChanges).
(WebKit::WebCookieManager::dispatchDidModifyCookies): Send a message to the UI process that cookies changed.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:


Add new files.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • win/WebKit2.vcproj:
11:15 AM Changeset in webkit [80262] by tonyg@chromium.org
  • 4 edits in trunk/Tools

2011-03-03 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Teach sheriffbot to answer whois commands
https://bugs.webkit.org/show_bug.cgi?id=55687

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
11:14 AM Changeset in webkit [80261] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

2011-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Remove CanRunBeforeUnloadConfirmPanel sync message
https://bugs.webkit.org/show_bug.cgi?id=55689

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode canRunBeforeUnloadConfirmPanel, as well as canRunModal, which wasn't being encoded/decoded.
  • Shared/WebPageCreationParameters.h: Add canRunBeforeUnloadConfirmPanel.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeUIClient): Send SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.

(WebKit::WebPageProxy::creationParameters):
Initialize parameters.canRunBeforeUnloadConfirmPanel.

  • UIProcess/WebPageProxy.messages.in: Remove CanRunBeforeUnloadConfirmPanel message.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
  • UIProcess/WebUIClient.h: Make canRunBeforeUnloadConfirmPanel const.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel): Ask the web page instead of sending a synchronous message.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_canRunBeforeUnloadConfirmPanel.
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::canRunBeforeUnloadConfirmPanel): (WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel): Add getter and setter for m_canRunBeforeUnloadConfirmPanel.

(WebKit::WebPage::setCanRunModal):
Add setter for m_canRunModal.

  • WebProcess/WebPage/WebPage.messages.in: Add SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
11:01 AM Changeset in webkit [80260] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

2011-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Improve WebCore build time by ~5%
https://bugs.webkit.org/show_bug.cgi?id=55688

Forward declare the CATransform3D and CGAffineTransform structs instead of including
large chunks of QuartzCore and Core Graphics.

On an 8 core Mac Pro, this sped up building WebCore by about 5%.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/TransformationMatrixCA.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
10:57 AM Changeset in webkit [80259] by imasaki@chromium.org
  • 3 edits
    2 copies in trunk/LayoutTests

2011-03-03 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Snow Leopard rebaseline of media/video-layer-crash
http://code.google.com/p/chromium/issues/detail?id=60744

  • platform/chromium-mac-leopard/media/video-layer-crash-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.
  • platform/chromium-mac-leopard/media/video-layer-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.png.
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
10:48 AM Changeset in webkit [80258] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Adjusted call to a method renamed in r80102.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing):
10:39 AM Changeset in webkit [80257] by mihaip@chromium.org
  • 4 edits in trunk

2011-03-03 Victoria Kirst <vrk@google.com>

Reviewed by Eric Carlson.

Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608

Suppressing the test failures until baselines are added.

  • platform/chromium/test_expectations.txt:

2011-03-03 Victoria Kirst <vrk@google.com>

Reviewed by Eric Carlson.

Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608

Add media folder to the list of GPU test paths.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
10:37 AM Changeset in webkit [80256] by timothy@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Attempt to fix the Windows build.

10:36 AM Changeset in webkit [80255] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Tony Gentilcore.

[Chromium] Revert the change in http/tests/media/video-referer.html
in rev80227

  • platform/chromium/test_expectations.txt:
10:28 AM Changeset in webkit [80254] by timothy@apple.com
  • 8 edits
    1 add in trunk/Source

Use APIEntryShim instead of JSLock in SerializedScriptValue.

Source/JavaScriptCore: Make APIShims usable from WebCore.

Reviewed by Oliver Hunt.

Source/WebCore: Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
by contexts not created by WebCore.

https://webkit.org/b/55642

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
(WebCore::SerializedScriptValue::deserialize): Ditto.

10:19 AM Changeset in webkit [80253] by mihaip@chromium.org
  • 26 edits
    24 copies
    48 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline tables/mozilla/marvin/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we scale the raptor image
differently (most likely due to CG i386 vs. x86_64 differences, see
bug 52335).

  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:10 AM Changeset in webkit [80252] by ap@apple.com
  • 4 edits
    6 adds in trunk

Reviewed by Darin Adler.

WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
https://bugs.webkit.org/show_bug.cgi?id=55498
<rdar://problem/8752706>

Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html

http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html

  • websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response header fields. Removed separate member variables for those, as they were duplicating data available in response, and there is no reason to squeeze microsecods here.
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field values to reset here. (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders(). (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response. (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto. (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto. (WebCore::WebSocketHandshake::serverSetCookie): Ditto. (WebCore::WebSocketHandshake::serverSetCookie2): Ditto. (WebCore::WebSocketHandshake::serverUpgrade): Added. (WebCore::WebSocketHandshake::serverConnection): Added. (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection header field presence and values.
9:54 AM QtWebKitReleases edited by Ademar Reis
(diff)
9:48 AM Changeset in webkit [80251] by mihaip@chromium.org
  • 6 edits
    4 copies
    8 adds in trunk/LayoutTests

2011-03-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline remaining editing/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.

We can't use the mac/ baselines since we render selections differently.

  • platform/chromium-mac-leopard/editing/selection/4402375-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/4402375-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/4402375-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/4402375-expected.checksum:
  • platform/chromium-mac/editing/selection/4402375-expected.png: Added.
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum:
  • platform/chromium-mac/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:43 AM Changeset in webkit [80250] by helder@sencha.com
  • 4 edits in trunk

[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=55651

Reviewed by Andreas Kling.

When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.

Source/WebCore:

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::strokePath):

LayoutTests:

  • platform/qt/Skipped: Remove test from skipped list.
9:36 AM Changeset in webkit [80249] by Adam Roben
  • 2 edits in trunk/Tools

Work around a bug in KURL's parsing of Windows-style absolute file: URLs

Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs

Reviewed by Tim Hatcher.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<http://webkit.org/b/55683>.

9:34 AM Changeset in webkit [80248] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-03-03 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Run kill-old-processes on the chromium-win bot too
https://bugs.webkit.org/show_bug.cgi?id=55630

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
9:18 AM Changeset in webkit [80247] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test on GTK. See bug 55682.

  • platform/gtk/Skipped: Skip fast/images/support-broken-image-delegate.html
9:03 AM Changeset in webkit [80246] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-03-03 Martin Robinson <mrobinson@igalia.com>

XHTMLMP build broken after r78342
https://bugs.webkit.org/show_bug.cgi?id=55286

Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
instead of FrameLoader.

No new tests. This is a build fix.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
8:59 AM Changeset in webkit [80245] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip svg test failing on 32-bits Release, likely due
to a rounding error, see bug 39022.

  • platform/gtk/Skipped:
8:54 AM Changeset in webkit [80244] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80219.
http://trac.webkit.org/changeset/80219
https://bugs.webkit.org/show_bug.cgi?id=55680

"Causes several media test crashes" (Requested by tonyg-cr on
#webkit).

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
  • src/AssociatedURLLoader.h:
8:42 AM Changeset in webkit [80243] by Carlos Garcia Campos
  • 4 edits in trunk

2011-03-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=53960

  • platform/gtk/Skipped: Unskip fast/events/popup-blocking-click-in-iframe.html that passes now.

2011-03-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=53960

  • DumpRenderTree/gtk/EventSender.cpp: (sendClick): (scheduleAsynchronousClickCallback):
8:40 AM Changeset in webkit [80242] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Tweak MediaControlMuteButtonElement class hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=55614

This allows the mute button on the panel to have event handlers that are
different from the mute button in the volume slider.

No change in behavior, covered by existing tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::updateDisplayType): (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added. (WebCore::MediaControlPanelMuteButtonElement::create): Added. (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
  • rendering/MediaControlElements.h: Added defs.
8:29 AM Changeset in webkit [80241] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2011-03-03 Martin Robinson <mrobinson@igalia.com>

Unskipped one test that just needs platform-independent results (it
does not fail on GTK+) and one failure so that we can get a test diff
from it (not failing locally or when run manually on the bots).

8:21 AM Changeset in webkit [80240] by Adam Roben
  • 6 edits
    2 copies in trunk

Make Inspector tests work in WebKit2 on Windows

Fixes <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time out or crash on
Windows 7 Release (WebKit2 Tests)

Reviewed by Darin Adler.

Source/WebKit2:

Create the CFBundleRef for WebKit.dll on Windows if needed

  • Shared/win/WebKitBundle.cpp: Added.

(WebKit::createWebKitBundle): Returns a pre-existing bundle, if possible, otherwise creates
and returns a new bundle.
(WebKit::webKitBundle): Creates and caches a bundle, and returns it.

  • Shared/win/WebKitBundle.h: Added.
  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):

  • WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL):
Changed to use webKitBundle() to ensure that the bundle has been created.

  • win/WebKit2.vcproj: Added new files.

Tools:

Look for Windows-style paths when checking whether a test is an Inspector test

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
Windows.

7:52 AM Changeset in webkit [80239] by yurys@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Resource agent should have same lifetime as Inspector agent
https://bugs.webkit.org/show_bug.cgi?id=55461

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed to clear frontend reference in all agents. (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::resourceAgent):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::disable): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore):
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.frontendReused):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
7:02 AM Changeset in webkit [80238] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

  • platform/gtk/Skipped: Skip fast/canvas/rgba-parsing.html
6:39 AM CommitterTips edited by Adam Roben
Added a tip about using auto-props to set the MIME type for PNGs correctly (diff)
6:31 AM Changeset in webkit [80237] by Adam Roben
  • 3 edits in trunk/Tools

Make Windows 7 Release (Tests) a core builder

We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.

Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot): Added a regexp to match Windows 7 Release (Tests).

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.

6:28 AM Changeset in webkit [80236] by Philippe Normand
  • 2 edits
    55 adds in trunk/LayoutTests

2011-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

5:48 AM Changeset in webkit [80235] by abecsi@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-03 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
https://bugs.webkit.org/show_bug.cgi?id=55661

Test case originally written by Andreas Kling <andreas.kling@nokia.com>

Add a test of rgba() color parsing for the edge cases.

  • fast/canvas/rgba-parsing-expected.txt: Added.
  • fast/canvas/rgba-parsing.html: Added.
  • fast/canvas/script-tests/rgba-parsing.js: Added. (parse):

2011-03-03 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
https://bugs.webkit.org/show_bug.cgi?id=55661

Test case originally written by Andreas Kling <andreas.kling@nokia.com>

Test: fast/canvas/rgba-parsing.html

  • css/CSSParser.cpp: (WebCore::isValidDouble): Check whether the given string is a valid double. (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
5:43 AM Changeset in webkit [80234] by antonm@chromium.org
  • 6 edits
    6 deletes in trunk/LayoutTests/platform

Unreviewed. Making expectations platform specific.

  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png
4:16 AM Changeset in webkit [80233] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

Reviewed by Andreas Kling.

  • Scripts/webkitpy/common/config/committers.py:
4:15 AM Changeset in webkit [80232] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-03 David Holloway <dhollowa@chromium.org>

Reviewed by Dimitri Glazkov.

Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
for non-empty suggestion text. The visibility of the placeholder text
now turned off when suggestion text is set.
https://bugs.webkit.org/show_bug.cgi?id=55245

No new tests because, by design, the suggestion text is not accessible
through the DOM.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
  • html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isEmptySuggestedValue):
4:13 AM Changeset in webkit [80231] by aestes@apple.com
  • 9 edits in trunk/Source/WebCore

2011-03-03 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719


Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.


With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
regression no longer lies in fragment parsing.

No new tests. No change in behavior.

  • dom/Element.h: (WebCore::Node::hasLocalName):
  • dom/Node.h:
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLNames::hasImpliedEndTag): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::attachToCurrent): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement): (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): (WebCore::HTMLConstructionSite::generateImpliedEndTags): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::shouldFosterParent):
  • html/parser/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::currentNode):
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isNumberedHeaderElement): (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLNames::isSelectScopeMarker): (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popUntilPopped): (WebCore::HTMLElementStack::popUntilTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::find): (WebCore::HTMLElementStack::topmost): (WebCore::HTMLElementStack::contains): (WebCore::inScopeCommon): (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::rootNode): (WebCore::HTMLElementStack::pushCommon):
  • html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::node): (WebCore::HTMLElementStack::topNode):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::finished):
  • html/parser/HTMLTreeBuilder.h:
3:58 AM Changeset in webkit [80230] by yurys@chromium.org
  • 5 edits in trunk

2011-03-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector protocol should allow different domains to have methods with same name
https://bugs.webkit.org/show_bug.cgi?id=55558

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-03-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector protocol should allow different domains to have methods with same name
https://bugs.webkit.org/show_bug.cgi?id=55558

  • inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
3:28 AM Changeset in webkit [80229] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add an equals() method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=55631

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::equals):
3:27 AM Changeset in webkit [80228] by podivilov@chromium.org
  • 7 edits in trunk/Source

2011-03-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make selected call frame debugger presentation model property.
https://bugs.webkit.org/show_bug.cgi?id=55582

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame): (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._callFrameSelected):

2011-03-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make selected call frame debugger presentation model property.
https://bugs.webkit.org/show_bug.cgi?id=55582

  • src/js/Tests.js:
3:21 AM Changeset in webkit [80227] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-03 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-flaky tests and update bugs/comments in
media related layout tests in test expectation

  • platform/chromium/test_expectations.txt:
3:13 AM Changeset in webkit [80226] by commit-queue@webkit.org
  • 29 edits in trunk

2011-03-03 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac OS X, spelling suggestion panel stops showing up after change set 80121
https://bugs.webkit.org/show_bug.cgi?id=55628

Rebaselined tests affected by changeset 80121.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word.html:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
  • platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:

2011-03-03 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac OS X, spelling suggestion panel stops showing up after change set 80121
https://bugs.webkit.org/show_bug.cgi?id=55628

Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • manual-tests/autocorrection/autocorrection-contraction.html:
3:06 AM Changeset in webkit [80225] by commit-queue@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2011-03-03 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Extended application cache database API and added unit tests file.
https://bugs.webkit.org/show_bug.cgi?id=55335

  • GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
  • tests/testapplicationcache.c: Added. (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly. (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly. (main):
  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
  • webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.

2011-03-03 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Extended application cache database API and added unit tests file.
https://bugs.webkit.org/show_bug.cgi?id=55335

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration of webkit_application_cache_set_maximum_size due to API exposal.
3:03 AM Changeset in webkit [80224] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
https://bugs.webkit.org/show_bug.cgi?id=55569

  • inspector/debugger/scripts-panel.html:

2011-03-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
https://bugs.webkit.org/show_bug.cgi?id=55569

sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ScriptsPanel.js:
2:58 AM Changeset in webkit [80223] by jeremy@chromium.org
  • 2 edits
    1 add
    14 deletes in trunk/LayoutTests

2011-03-03 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Convert offsetLeft-offsetTop-borders.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=55612

This test outputs the values of offsetLeft/offsetTop for portions
of the DOM. It appears it would do just as well as a text-based test.

  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders.html:
  • platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
  • platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
  • platform/qt/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
2:51 AM Changeset in webkit [80222] by steveblock@google.com
  • 8 edits in trunk/Source/WebCore

2011-03-03 Steve Block <steveblock@google.com>

Reviewed by David Levin.

JavaString API should be implementable by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55567

Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.

No new tests, refactoring only.

  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::impl):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::impl):
  • bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::impl):
2:44 AM Changeset in webkit [80221] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Adam Roben.

REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=55602

Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.

The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
objects need to be deleted manually with ListHashSet.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
2:37 AM Changeset in webkit [80220] by hans@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-03-03 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55376

Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.

No new functionality, so no new tests.

  • storage/IDBBackingStore.cpp: (WebCore::lowerCursorWhereFragment): (WebCore::upperCursorWhereFragment): (WebCore::IDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBBackingStore::keyExistsInObjectStore): (WebCore::IDBBackingStore::getObjectViaIndex): (WebCore::keyFromQuery): (WebCore::IDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBBackingStore::keyExistsInIndex): (WebCore::CursorImplCommon::CursorImplCommon::continueInternal): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value): (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction): (WebCore::IDBBackingStore::openObjectStoreCursor): (WebCore::ObjectStoreCursorImpl::loadCurrentRow): (WebCore::ObjectStoreCursorImpl::currentRowExists): (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl): (WebCore::IndexKeyCursorImpl::indexDataId): (WebCore::IndexKeyCursorImpl::key): (WebCore::IndexKeyCursorImpl::primaryKey): (WebCore::IndexKeyCursorImpl::continueFunction): (WebCore::IDBBackingStore::openIndexKeyCursor): (WebCore::IndexKeyCursorImpl::loadCurrentRow): (WebCore::IndexKeyCursorImpl::currentRowExists): (WebCore::IndexCursorImpl::IndexCursorImpl): (WebCore::IndexCursorImpl::indexDataId): (WebCore::IndexCursorImpl::key): (WebCore::IndexCursorImpl::primaryKey): (WebCore::IndexCursorImpl::value): (WebCore::IndexCursorImpl::continueFunction): (WebCore::IDBBackingStore::openIndexCursor): (WebCore::IndexCursorImpl::loadCurrentRow): (WebCore::IndexCursorImpl::currentRowExists):
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Cursor::~Cursor):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::deleteFunction):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::isEqual):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBObjectStoreBackendImpl.h:
2:28 AM Changeset in webkit [80219] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-03 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925

No tests needed. Exposes no new functionality.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h: (WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):
2:24 AM Changeset in webkit [80218] by commit-queue@webkit.org
  • 13 edits in trunk

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • http/tests/navigation/useragent-expected.txt:
  • http/tests/navigation/useragent.php:

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • StringsNotToBeLocalized.txt:

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • webkit/webkitwebsettings.cpp: (webkitPlatform): (webkitUserAgent):

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-03-03 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567

  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent):
2:22 AM Changeset in webkit [80217] by pvarga@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-03 Peter Varga <pvarga@webkit.org>

Reviewed by Oliver Hunt.

Begin Characters Optimization Causes YARR Interpreter Errors
https://bugs.webkit.org/show_bug.cgi?id=55479

The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.

Reenable the Beginning Character Optimization in the YARR Interpreter again.

  • fast/js/regexp-alternatives-expected.txt: Added.
  • fast/js/regexp-alternatives.html: Added.
  • fast/js/script-tests/regexp-alternatives.js: Added.

2011-03-03 Peter Varga <pvarga@webkit.org>

Reviewed by Oliver Hunt.

Begin Characters Optimization Causes YARR Interpreter Errors
https://bugs.webkit.org/show_bug.cgi?id=55479

The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.

Reenable the Beginning Character Optimization in the YARR Interpreter again.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms): (JSC::Yarr::YarrPattern::compile):
2:09 AM Changeset in webkit [80216] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip tests fixed by r80214 on GTK.

  • platform/gtk/Skipped:
1:33 AM Changeset in webkit [80215] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-03 Steve Lacey <sjl@chromium.org>

Reviewed by Darin Fisher.

Wire up webkit metrics changes to chromium changes.
https://bugs.webkit.org/show_bug.cgi?id=54580

  • features.gypi:
  • public/WebMediaPlayer.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::decodedFrameCount): (WebKit::WebMediaPlayerClientImpl::droppedFrameCount): (WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount): (WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
  • src/WebMediaPlayerClientImpl.h:
1:00 AM Changeset in webkit [80214] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

New GTK-specific layout test to check the right signals are emitted.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.

2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Emit the selection-changed signals when the menu list value has changed

Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
12:35 AM Changeset in webkit [80213] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338

Include wtf/Forward.h instead of wtf/text/String.h

  • editing/EditingStyle.h:
12:32 AM Changeset in webkit [80212] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial fix after r80169.

[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
https://bugs.webkit.org/show_bug.cgi?id=55484

  • WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
12:02 AM Changeset in webkit [80211] by ojan@chromium.org
  • 4 edits in trunk/Tools

2011-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make webkit-patch upload work for security bugs
https://bugs.webkit.org/show_bug.cgi?id=55655

The problem is that we shell out to prepare-ChangeLog,
which does not authenticate with bugzilla. All it needs from
bugzilla is the bug title though. We just pass it through from
webkit-patch instead.

  • Scripts/prepare-ChangeLog:
  • Scripts/webkitpy/common/net/bugzilla/bug.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
Note: See TracTimeline for information about the timeline view.