Timeline


and

03/08/11:

23:36 Writing Reftests edited by hayato@chromium.org
(diff)
23:26 Writing Reftests edited by hayato@chromium.org
(diff)
23:23 Writing Reftests edited by hayato@chromium.org
(diff)
23:21 Writing Reftests edited by hayato@chromium.org
(diff)
23:18 Writing Reftests edited by hayato@chromium.org
(diff)
22:58 Changeset [80624] by xji@chromium.org

2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825

  • inspector/protocol/runtime-agent-expected.txt:
22:32 Changeset [80623] by loislo@chromium.org

2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825

  • inspector/protocol/runtime-agent-expected.txt:

2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825

  • inspector/InjectedScriptSource.js:
22:23 Changeset [80622] by xji@chromium.org

2011-03-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.

  • fast/dom/scroll-reveal-left-overflow.html: Added.
  • fast/dom/scroll-reveal-top-overflow.html: Added.
  • platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
  • platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
  • platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
  • platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
  • platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.

2011-03-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.

Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.

Tests: fast/dom/scroll-reveal-left-overflow.html

fast/dom/scroll-reveal-top-overflow.html

  • platform/ScrollView.cpp: (WebCore::ScrollView::calculateOverhangAreasForPainting):
22:08 Writing Reftests created by hayato@chromium.org
21:57 Changeset [80621] by barraclough@apple.com

Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).

Reviewed by Sam Weinig

Source/JavaScriptCore:

Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

Added test cases.

  • fast/js/array-proto-func-length-getter-except-expected.txt: Added.
  • fast/js/array-proto-func-length-getter-except.html: Added.
  • fast/js/script-tests/array-proto-func-length-getter-except.js: Added.

(lengthGetter):
(test):

21:57 Changeset [80620] by dbates@webkit.org

2011-03-08 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351

By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
can be called on an array A without the caller explicitly specifying the size of A.

No functionality was changed. So no new tests.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}(). (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size" to better reflect its purpose - to be the size of the passed array. (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto. (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine the size of a passed array. Changed type of second argument to size_t since it represents the size of an array. (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto. (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
21:51 WikiStart edited by hayato@chromium.org
(diff)
21:50 WikiStart edited by hayato@chromium.org
(diff)
21:19 Changeset [80619] by jer.noble@apple.com

2011-03-08 Jer Noble <jer.noble@apple.com>

Reviewed by Sam Weinig.

WebKit2: Plumb through the FULLSCREEN_API Chrome client calls
https://bugs.webkit.org/show_bug.cgi?id=55273

The FULLSCREEN_API Chrome client calls need to be plumbed through from the
WebProcess to the UIProcess. To do this, WebFullScreenManager (and Proxy)
classes have been added to WebPage.

  • DerivedSources.make: Added rules necessary to build DerivedSources for new .in files.
  • DerivedSources.pro: Ditto.
  • Platform/CoreIPC/MessageID.h: Added message types for WebFullScreenManager.
  • Shared/API/c/WKBase.h: Added WKFullScreenManagerRef.
  • Shared/APIObject.h: Added APIType for WebFullScreenManager.
  • UIProcess/WebFullScreenManagerProxy.cpp: Added.
  • UIProcess/WebFullScreenManagerProxy.h: Added.
  • UIProcess/WebFullScreenManagerProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Invalidate and clear m_fullScreenManager. (WebKit::WebPageProxy::processDidCrash): Ditto. (WebKit::WebPageProxy::didReceiveMessage): Pass messages on to WebFullScreenManagerProxy. (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto. (WebKit::WebPageProxy::fullScreenManager): Added. Lazy instantiation of m_fullScreenManager.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebKit2.xcodeproj/project.pbxproj: Added references to new classes in project file.
  • WebKit2.pro: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • WebKit2.pri: Added new directories to include file path.
  • win/WebKit2Common.vsprops: Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.cpp: Added.
  • WebProcess/FullScreen/WebFullScreenManager.h: Added.
  • WebProcess/FullScreen/WebFullScreenManager.messages.in: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::supportsFullScreenForElement): Pass through to WebFullScreenManager. (WebKit::WebChromeClient::enterFullScreenForElement): Ditto. (WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Invalidate and clear m_fullScreenManager. (WebKit::WebPage::fullScreenManager): Lazy instantiation of m_fullScreenManager. (WebKit::WebPage::didReceiveMessage): Pass messages through to WebFullScreenManager.
  • WebProcess/WebPage/WebPage.h:
19:44 Changeset [80618] by mihaip@chromium.org

2011-03-08 Mihai Parparita <mihaip@chromium.org>

Add failing expectation for compositing/webgl/
webgl-nonpremultiplied-blend.html.

  • platform/chromium/test_expectations.txt:
19:15 Changeset [80617] by kinuko@chromium.org

2011-03-08 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Destroying WorkerFileSystemCallbacksBridge on main thread results in ASSERT in WorkerContext::Observer::~Observer
https://bugs.webkit.org/show_bug.cgi?id=55895

  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::runTaskOnWorkerThread): Added stopObserving() so that releasing the bridge on the main thread (this could happen before or after the runTaskOnWorkerThread) does not cause the assertion error.
19:04 Changeset [80616] by mrowe@apple.com

There's more chance that this will work if the file is compiled.

18:28 Changeset [80615] by enrica@apple.com

REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/HTMLConverter.h: Added.
  • platform/mac/HTMLConverter.mm: Added.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

18:25 Changeset [80614] by jamesr@google.com

2011-03-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55900

This adds an explicit step to synchronize properties from
LayerChromiums to their corresponding CCLayerImpls.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setBounds):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::doubleSided): (WebCore::LayerChromium::setDoubleSided):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::updateFromLayer): (WebCore::CCLayerImpl::descendantsDrawsContent):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::anchorPoint): (WebCore::CCLayerImpl::anchorPointZ): (WebCore::CCLayerImpl::masksToBounds): (WebCore::CCLayerImpl::opacity): (WebCore::CCLayerImpl::position): (WebCore::CCLayerImpl::preserves3D): (WebCore::CCLayerImpl::sublayerTransform): (WebCore::CCLayerImpl::transform):
18:22 Changeset [80613] by jamesr@google.com

2011-03-08 James Robinson <jamesr@chromium.org>

Chromium compile fix.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
18:09 Changeset [80612] by jer.noble@apple.com

2011-03-08 Jer Noble <jer.noble@apple.com>

Reviewed by Sam Weinig.

WebKit2: Plumb through the "supportsFullScreen" preference.
https://bugs.webkit.org/show_bug.cgi?id=55261

The "supportsFullScreen" preference needs to be plumbed through from
the UIProcess to the WebProcess.

  • Shared/WebPreferencesStore.h: Add a new macro entry.
  • UIProcess/API/C/WKPreferences.cpp: Implement preferences getter and setter. (WKPreferencesSetFullScreenEnabled): (WKPreferencesGetFullScreenEnabled):
  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Sync the fullScreenEnabled setting through to

the settings object.

17:44 Changeset [80611] by pkasting@chromium.org

Unify Windows version checks, part 1.
https://bugs.webkit.org/show_bug.cgi?id=55979

Reviewed by James Robinson.

Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
now-unnecessary WindowsVersion.cpp from Chromium.

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):

  • platform/chromium/WindowsVersion.cpp: Removed.
  • platform/chromium/WindowsVersion.h: Removed.
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::fillBMPGlyphs):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::getNonClientMetrics):

17:39 Changeset [80610] by rniwa@webkit.org

2011-03-08 Ryosuke Niwa <rniwa@webkit.org>

Chromium Linux build fix attempt after r80582.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::GlyphPage::fill):
17:35 Changeset [80609] by jeffm@apple.com

2011-03-08 Jeff Miller <jeffm@apple.com>

Reviewed by Adele Peterson.

WebKit2: Implement Windows glue for Undo/Redo
https://bugs.webkit.org/show_bug.cgi?id=55961


Expose Undo/Redo infrastructure through WKView on Windows by
adding an undo client as well as APIs to reapply and unapply
an edit command.

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetViewUndoClient): Added. (WKViewReapplyEditCommand): Added. (WKViewUnapplyEditCommand): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewUndoClient, WKViewSetViewUndoClient(), and WKViewUnapplyEditCommand().
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isValidEditCommand): Added, used to validated an edit command from a WKView API.
  • UIProcess/WebPageProxy.h: Added isValidEditCommand().
  • UIProcess/win/WebUndoClient.cpp: Added, APIClient for WKViewUndoClient. (WebKit::WebUndoClient::registerEditCommand): Added. (WebKit::WebUndoClient::clearAllEditCommands): Added.
  • UIProcess/win/WebUndoClient.h: Added, APIClient for WKViewUndoClient.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::initializeUndoClient): Added. (WebKit::WebView::close): Clear out undo client. (WebKit::WebView::registerEditCommand): Implemented to call through to WKViewUndoClient. (WebKit::WebView::clearAllEditCommands): Implmented to call through to WKViewUndoClient. (WebKit::WebView::reapplyEditCommand): Added. (WebKit::WebView::unapplyEditCommand): Added.
  • UIProcess/win/WebView.h: Added undo client support.
  • win/WebKit2.vcproj: Added WebUndoClient.cpp and WebUndoClient.h.
17:27 Changeset [80608] by rniwa@webkit.org

2011-03-08 Ryosuke Niwa <rniwa@webkit.org>

Mac build fix attempt for r80582.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::disableLigatures):
17:25 Changeset [80607] by imasaki@chromium.org

Adding myself to the committer file.

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
17:16 Changeset [80606] by imasaki@chromium.org

[Chromium] Clean up Media GPU test expectation since
http://crbug.com?id=74887 was fixed. These expectations are based
on the results on flakiness dashboard.

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
17:00 Changeset [80605] by jeffm@apple.com

2011-03-08 Jeff Miller <jeffm@apple.com>

Reviewed by Sam Weinig.

WebKit2: Expose WebEditCommandProxy in the C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=55962


Make WebEditCommandProxy a subclass of APIObject, and define
WKEditCommandRef as the type that will be exposed through the C API.

  • Shared/API/c/win/WKBaseWin.h: Add WKEditCommandRef.
  • Shared/APIObject.h: Add platform-specific TypeEditCommandProxy.
  • UIProcess/API/C/win/WKAPICastWin.h: Add API mapping for WKEditCommandRef.
  • UIProcess/WebEditCommandProxy.h: Subclass WebEditCommandProxy from APIObject. (WebKit::WebEditCommandProxy::type): Added.
16:51 Changeset [80604] by rniwa@webkit.org

2011-03-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=54937

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain the document. Also restrained the lifetime of document variable. (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode() to determine whether or not position becomes null after removing a node. (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container so call containerNode() instead of deprecatedNode(). (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer() instead of deprecatedNode() and deprecatedEditingOffset() respectively. (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode() instead of deprecatedNode to determine whether or not selection inside a password field. Also assert that the specified position is not before or after the shadow root as it violates our assumption.
  • editing/VisibleSelection.cpp: (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode() and deprecatedEditingOffset() respectively because start is always parent anchored and therefore guaranteed to be an offset inside an anchor node. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode() instead of deprecatedNode() to look for the lowest editable ancestor because position before or after an editable element isn't editable.
  • page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode() and deprecatedEditingOffset() respectively in the following functions because they are exposed to DOM, which doesn't have before/after concept. (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::extentOffset):
16:18 Changeset [80603] by jeffm@apple.com

2011-03-08 Jeff Miller <jeffm@apple.com>

Reviewed by Oliver Hunt.

WebKit2: Redo is broken
https://bugs.webkit.org/show_bug.cgi?id=55978


WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
For example, when we unapply(), we should register a Redo command, not an Undo command.

  • UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command. (WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.
16:02 Changeset [80602] by bfulgham@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=55977
Refine CF/CFNet distinctions for better code sharing.

  1. Rename Downloads/cf/win/DownloadCFNetWin.cpp to DownloadCFWin.cpp since it does not use any CFNETWORK features.
  2. Create new cfnet directory.
  3. Move Downloads/cf/DownloadCFNet.cpp to Downloads/cfnet
  4. Update project file.

Reviewed by Adam Roben.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp: Removed.
  • WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp: Removed.
  • WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Copied from WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp.
  • WebProcess/Downloads/cfnet: Added.
  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp: Copied from WebProcess/Downloads/cf/DownloadCFNet.cpp.
  • win/WebKit2.vcproj:
16:00 Changeset [80601] by bfulgham@webkit.org

Correct uninitialized variable in PolicyCallback found while
running WebKit in BoundsChecker.
https://bugs.webkit.org/show_bug.cgi?id=45199.

Reviewed by Adam Roben.

  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::PolicyCallback): Initialize
m_argument.

15:44 Changeset [80600] by mrowe@apple.com

<http://webkit.org/b/55976> Provisional URL should be loaded when restoring session state even if there are back / forward list entries.

Reviewed by Brady Eidson.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): If there's a provisional URL that we will load then restore the session state
without navigating to the current item.

  • WebProcess/WebPage/WebPage.messages.in: Expose the ability to restore the session state without navigating to the current item.
15:43 Changeset [80599] by jberlin@webkit.org

Fix two leaks I introduced into the API tests.

Rubber-stamped by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:

(TestWebKitAPI::TEST):

15:17 Changeset [80598] by oliver@apple.com

2011-03-07 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make CodeBlock GC write barrier safe
https://bugs.webkit.org/show_bug.cgi?id=55910

In order to make CodeBlock WriteBarrier safe it was necessary
to make it have a single GC owner, and for that reason I have
made ExecutableBase a GC allocated object. This required
updating their creation routines as well as all sites that hold
a reference to them. GC objects that held Executable's have been
converted to WriteBarriers, and all other sites now use Global<>.

As an added benefit this gets rid of JSGlobalData's list of
GlobalCodeBlocks.

Perf testing shows a 0.5% progression on v8, vs. a 0.3% regression
on SunSpider. Given none of the tests that show regressions
demonstrate a regression on their own, and sampling shows up nothing.
I suspect we're just getting one or two additional gc passes at
the end of the run.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::EvalCodeCache::markAggregate): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::ownerExecutable): (JSC::CodeBlock::addConstant): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::getConstant): (JSC::CodeBlock::addFunctionDecl): (JSC::CodeBlock::addFunctionExpr): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ExecState::r):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
  • bytecode/SamplingTool.h: (JSC::ScriptSampleRecord::ScriptSampleRecord):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstantValue): (JSC::BytecodeGenerator::emitEqualityOp):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::callEval):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadDouble): (JSC::JIT::emitLoadInt32ToDouble):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::hostFunctionStub): (JSC::JITThunks::clearHostFunctionStubs):
  • jit/JITStubs.h:
  • runtime/Completion.cpp: (JSC::checkSyntax): (JSC::evaluate):
  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::FunctionExecutable::~FunctionExecutable): (JSC::EvalExecutable::markChildren): (JSC::ProgramExecutable::markChildren): (JSC::FunctionExecutable::markChildren): (JSC::FunctionExecutable::fromGlobalCode):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::create): (JSC::NativeExecutable::NativeExecutable): (JSC::VPtrHackExecutable::VPtrHackExecutable): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::create): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):
  • runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots):
  • runtime/Heap.h:
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::markChildren):
  • runtime/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::~JSFunction): (JSC::JSFunction::markChildren):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::getHostFunction):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • runtime/JSObject.cpp:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObjectData::JSStaticScopeObjectData): (JSC::JSStaticScopeObject::JSStaticScopeObject):
  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):
  • runtime/JSZombie.h: (JSC::JSZombie::createStructure):
  • runtime/MarkedSpace.h:
15:13 Changeset [80597] by mrobinson@webkit.org

2011-03-08 Martin Robinson <mrobinson@igalia.com>

Rebaseline a GTK+ result after r80582.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
15:06 Changeset [80596] by bfulgham@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=55956
WebKit2 Changes to correct WinCairo port build

Reviewed by Anders Carlsson.

  • Shared/LayerTreeContext.h: Don't exclude CoreIPC declarations for non-accelerated compositing case.
  • UIProcess/DrawingAreaProxy.h: Add "stdint.h" include needed for Cairo build.
  • UIProcess/DrawingAreaProxyImpl.cpp: Exclude accelerated compositing code for WinCairo build.

(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):

  • UIProcess/DrawingAreaProxyImpl.h: Exclude declarations for code only used when accelerated compositing is enabled.

(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode):

  • UIProcess/win/WebView.cpp: Protect CG-specific drawing code.

(WebKit::WebView::setFindIndicator):

  • WebProcess/Downloads/Download.h: Allow CFLite implentation to share overwrite flag, as well as destination and bundle paths.
  • WebProcess/Downloads/curl/DownloadCurl.cpp: Remove stub (to share CFNet implementation of file handling. This will be moved to a common area in a future patch.)
  • WebProcess/WebPage/DrawingAreaImpl.cpp: Exclude accelerated-compositing paths.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):

  • WebProcess/WebPage/WebPage.cpp: Protect CG-specific drawing code.

(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):

  • win/WebKit2.vcproj: Exclude unused LayerTreeContext from WinCairo
14:49 Changeset [80595] by ossy@webkit.org

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
Update Qt specific expected results after r80582.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
14:37 Changeset [80594] by bfulgham@webkit.org

More build bustage fix.

  • platform/graphics/win/cairo/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation): Duplicate accessor
in WinCairo-local header. This is such a mess!

14:16 Changeset [80593] by ike@apple.com

2011-03-08 Ivan Krstić <ike@apple.com>

Reviewed by Sam Weinig.

Re-fix: can't paste from 3rd party text editor into WebKit2 window
<rdar://problem/8978624>

  • WebProcess/com.apple.WebProcess.sb:
14:15 Fingerprinting edited by robert@roberthogan.net
(diff)
14:10 Changeset [80592] by kerz@chromium.org

Branching Chromium 696.

14:09 Changeset [80591] by kerz@chromium.org

Un-Branching Chromium 696.

14:07 Changeset [80590] by kerz@chromium.org

Branching Chromium 696.

14:05 Changeset [80589] by hyatt@apple.com

Fix build bustage. Hide orientation setting behind a setter and stub it out in all
FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::verticalRightOrientationFontData):

  • platform/graphics/cg/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/chromium/FontPlatformDataLinux.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/cocoa/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/freetype/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/wince/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

  • platform/graphics/wx/FontPlatformData.h:

(WebCore::FontPlatformData::setOrientation):

13:57 Changeset [80588] by mrobinson@webkit.org

2011-03-08 Martin Robinson <mrobinson@igalia.com>

Fix the WebKit2 compilation after r80578.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::setFocus): Added.
  • UIProcess/gtk/WebView.h:
13:49 Changeset [80587] by commit-queue@webkit.org

2011-03-08 Joe Wild <joseph.wild@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941

Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.

Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.

  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2011-03-08 Joe Wild <joseph.wild@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Missing SVG variables
https://bugs.webkit.org/show_bug.cgi?id=32941

Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.

Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.

  • features.pri:
  • page/DOMWindow.idl:
13:42 Changeset [80586] by jberlin@webkit.org

Crash in CFNetwork visiting google.com
https://bugs.webkit.org/show_bug.cgi?id=55958

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/API/c/cf/WKURLResponseCF.cpp:

(WKURLResponseCopyCFURLResponse):
If the response to copy is null, return 0;

Tools:

Add a test for not trying to copy a null CFURLResponse.

  • TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
13:19 Changeset [80585] by sullivan@apple.com

Reverted the patch for https://bugs.webkit.org/show_bug.cgi?id=55940

The patch was insufficient, and it wasn't useful for the intended client use either.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

13:18 Changeset [80584] by commit-queue@webkit.org

2011-03-08 Alok priyadarshi <alokp@chromium.org>

Reviewed by Dimitri Glazkov.

Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242

No test needed. A simple get function is added.

  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::getTextureId):

2011-03-08 Alok priyadarshi <alokp@chromium.org>

Reviewed by Dimitri Glazkov.

Plugins needs a way to trigger style recalc
https://bugs.webkit.org/show_bug.cgi?id=55242

It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId):
  • src/WebPluginContainerImpl.h:
13:18 Changeset [80583] by hyatt@apple.com

Fix Lion build bustage.

12:53 Changeset [80582] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.

Reviewed by Dan Bernstein.

This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).

Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
vertically oriented font that rotates all glyphs.

The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
simple or complex code paths, although the simple code path at least gets close.

Added fast/blockflow/text-orientation-basic.html

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextOrientation):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData):

  • loader/cache/CachedFont.h:
  • platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::setTextOrientation):
(WebCore::FontDescription::operator==):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter):
(WebCore::offsetToMiddleOfGlyph):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::hasVerticalGlyphs):
(WebCore::SimpleFontData::isTextOrientationFallback):

  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cocoa/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::textOrientation):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):

  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/haiku/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):
(WebCore::Font::drawGlyphs):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/pango/FontCustomPlatformDataPango.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/wince/FontCustomPlatformData.h:
  • platform/text/TextOrientation.h: Added.
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::initialTextOrientation):

LayoutTests:

  • fast/blockflow/text-orientation-basic.html: Added.
  • platform/mac/fast/blockflow/text-orientation-basic-expected.checksum: Added.
  • platform/mac/fast/blockflow/text-orientation-basic-expected.png: Added.
  • platform/mac/fast/blockflow/text-orientation-basic-expected.txt: Added.
12:14 Changeset [80581] by alex@webkit.org

2011-03-08 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed GTK+ compilation after r80569.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::windowToScreen):
  • UIProcess/gtk/WebView.h:
12:12 Changeset [80580] by rniwa@webkit.org

2011-03-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

addInlineStyleIfNeeded should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55950

Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration. (WebCore::StyleChange::init): Ditto. (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement instead of manually merging styles. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
  • editing/EditingStyle.h:
12:07 Changeset [80579] by thakis@chromium.org

2011-03-08 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951

  • fast/canvas/shadow-huge-blur-expected.txt: Added.
  • fast/canvas/shadow-huge-blur.html: Added.

2011-03-08 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Crash on big blur radius with canvas
https://bugs.webkit.org/show_bug.cgi?id=55951

Move the clamping code out of an if branch, so that it happens in the
canvas case as well.

Test: fast/canvas/shadow-huge-blur.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
12:04 Changeset [80578] by cfleizach@apple.com

Source/WebCore: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281

Reviewed by Sam Weinig.

In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
Instead, the focus/unfocus messages need to be sent to the UIProcess side.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::setFocus):

Source/WebKit2: WK2: Cannot set focus on an element when focus is outside of WKView
https://bugs.webkit.org/show_bug.cgi?id=55281

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFocus):

  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::setFocus):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFocus):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.h:

(WebKit::WebView::setFocus):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focus):
(WebKit::WebChromeClient::unfocus):

11:50 Changeset [80577] by jeffm@apple.com

Unreviewed, fix last change so WKBaseWin.h is in alphabetical order in the project XML.

  • win/WebKit2.vcproj: Move WKBaseWin.h to be in alphabetical order.
11:40 Changeset [80576] by tony@chromium.org

2011-03-08 Tony Chang <tony@chromium.org>

Unreviewed, add pngs to chromium and chromium-linux .checksum files
that are missing pngs. I generated these on my local desktop.

  • platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-rl-text-expected.png: Added.
  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Added.
  • platform/chromium/fast/images/png_per_row_alpha_decoding-expected.png: Added.
11:33 Changeset [80575] by commit-queue@webkit.org

2011-03-08 Martin Maly <mmaly@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Expectation updates for strict mode V8 features.
https://bugs.webkit.org/show_bug.cgi?id=55789

  • platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt:
11:32 Changeset [80574] by jeffm@apple.com

2011-03-08 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Remove Source/WebKit2/UIProcess/API/C/win/WKBaseWin.h
https://bugs.webkit.org/show_bug.cgi?id=55952

  • UIProcess/API/C/win/WKBaseWin.h: Removed.
  • win/WebKit2.vcproj: Refer to the Shared version of WKBaseWin.h instead of the one in UIProcess.
11:24 Changeset [80573] by darin@apple.com

2011-03-08 Darin Adler <darin@apple.com>

Reviewed by Timothy Hatcher.

Promote a method used outside WebKit from internal to private
https://bugs.webkit.org/show_bug.cgi?id=55949

  • Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration. Minor tweak, not directly related to the rest of this patch.
  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved this method from the internal category into the private category. Streamlined the code a bit.
  • WebView/WebFrameInternal.h: Removed _computePageRects method.
  • WebView/WebFramePrivate.h: Added _computePageRects method.
11:02 Changeset [80572] by weinig@apple.com

Overflow: scroll areas should not paint white in scroll corner if the
scrollbars are overlay.
<rdar://problem/9082871>

Reviewed by Anders Carlsson.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintScrollCorner):
Don't paint the scroll corner white if we have overlay scrollbars.

10:42 Changeset [80571] by alex@webkit.org

2011-03-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add new files to compilation after r77974
https://bugs.webkit.org/show_bug.cgi?id=54076

The commit added new code to allow passing context to policy
delegate methods, we also added dummy ResourceRequest and
ResourceResponse decoders until we implement them.

  • GNUmakefile.am:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
10:29 Changeset [80570] by cmarrin@apple.com

2011-03-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

The first time animations are committed they have a bad start time
https://bugs.webkit.org/show_bug.cgi?id=55947

Do a check for a returned lastCommitTime of <=0 and replace it
with the mediaTime.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
10:18 Changeset [80569] by cfleizach@apple.com

AX: Webkit2 not sending UAZoomFocusChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=55916

Reviewed by Darin Adler.

Needed to implement the windowToScreen() method so that the right frame
could be calculated to send for zoom focus changes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::windowToScreen):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::windowToScreen):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowToScreen):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::windowToScreen):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowToScreen):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowToScreen):

  • WebProcess/WebPage/WebPage.h:
10:10 Changeset [80568] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=55940
WebKit2 should support Ignore policy from injected bundle client

Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Added WKBundlePagePolicyActionIgnore.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
If the injected bundle client returns WKBundlePagePolicyActionIgnore, convert it
to the loader's PolicyIgnore.

10:03 Changeset [80567] by tony@chromium.org

2011-03-08 Tony Chang <tony@chromium.org>

Unreviewed, remove png layout test results that don't have
corresponding checksum files. I checked a few of these and they
were cases where the .checksum was removed and the .png forgotten.

  • platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/gtk/svg/hixie/error/004-expected.png: Removed.
  • platform/gtk/svg/hixie/error/005-expected.png: Removed.
  • platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
  • platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
  • platform/mac/editing/selection/contenteditable-click-outside-expected.png: Removed.
  • platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/mac/fast/dynamic/8952-reduction-expected.png: Removed.
  • platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/mac/fast/js/Plug-ins-expected.png: Removed.
  • platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
  • platform/mac/svg/hixie/error/004-expected.png: Removed.
  • platform/mac/svg/hixie/error/005-expected.png: Removed.
  • platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
  • platform/win/fast/table/row-height-recalc2-expected.png: Removed.
09:41 Changeset [80566] by commit-queue@webkit.org

2011-03-08 James Kozianski <koz@chromium.org>

Reviewed by David Levin.

Expose isValidProtocol() in KURL.h.
https://bugs.webkit.org/show_bug.cgi?id=54594

This is needed to validate protocols used in calls to
navigator.registerProtocolHandler().

  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::isValidProtocol):
09:32 Changeset [80565] by aroben@apple.com

Set svn:mime-type to text/css for all Inspector CSS files

This will cause them to be served with the correct MIME type from svn.webkit.org's web
interface.

Rubber-stamped by Tim Hatcher.

  • inspector/front-end/audits.css: Added property svn:mime-type.
  • inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
  • inspector/front-end/heapProfiler.css: Added property svn:mime-type.
  • inspector/front-end/helpScreen.css: Added property svn:mime-type.
  • inspector/front-end/inspector.css: Added property svn:mime-type.
  • inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
  • inspector/front-end/networkPanel.css: Added property svn:mime-type.
  • inspector/front-end/popover.css: Added property svn:mime-type.
  • inspector/front-end/textViewer.css: Added property svn:mime-type.
08:05 Changeset [80564] by andreip@google.com

2011-03-08 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938

The IndexedDatabase specification changed and IDBIndex objects are no
longer created asynchronously. We therefore no longer need this method.

No new tests, just cleanup.

  • storage/IDBCallbacks.h:
  • storage/IDBRequest.cpp:
  • storage/IDBRequest.h:

2011-03-08 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=55938

  • public/WebIDBCallbacks.h:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:
07:42 Changeset [80563] by commit-queue@webkit.org

2011-03-08 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_window_features and ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=55026

  • ewk/ewk_contextmenu.cpp: (ewk_context_menu_item_select): returns EINA_FALSE when CONTEXT_MENU is disabled
  • ewk/ewk_contextmenu.h:
  • ewk/ewk_window_features.cpp:
  • ewk/ewk_window_features.h:
07:20 Changeset [80562] by philn@webkit.org

2011-03-08 Philippe Normand <pnormand@igalia.com>

REGRESSION (r80478): broke GTK inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55941

Unreviewed, skipping inspector crashing tests on GTK.

  • platform/gtk/Skipped:
06:48 Changeset [80561] by christian@webkit.org

[GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510

Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on

the icon database for new icons.

  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitglobals.cpp:
  • webkit/webkitglobals.h: Add a function to obtain the global

icon database.

  • webkit/webkiticondatabase.cpp:
  • webkit/webkiticondatabase.h: Implement public icon database

object with methods for obtaining icon URLs, pixbufs, clearing
waiting for new icons.

  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: Add a method to obtain an icon pixbuf

for the web view.

05:03 Changeset [80560] by commit-queue@webkit.org

2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80551.
http://trac.webkit.org/changeset/80551
https://bugs.webkit.org/show_bug.cgi?id=55933

It broke 285 tests on Qt bot (Requested by Ossy on #webkit).

  • WebCore.pro:
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData):
  • platform/qt/QtByteBlock.cpp: Removed.
  • platform/qt/QtByteBlock.h: Removed.
  • platform/qt/SharedBufferQt.cpp:
04:35 Changeset [80559] by andreas.kling@nokia.com

2011-03-08 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

RenderObject: Pass complex type arguments as const-references.

  • WebCore.exp.in:
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath): (WebCore::RenderObject::drawArcForBoxSide): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal):
03:47 Changeset [80558] by hayato@chromium.org

2011-03-08 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.

FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.

https://bugs.webkit.org/show_bug.cgi?id=55450

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
03:18 Changeset [80557] by commit-queue@webkit.org

2011-03-08 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

Path: Make measurement functions const
https://bugs.webkit.org/show_bug.cgi?id=55914

  • platform/graphics/Path.cpp: (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::strokeBoundingRect): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/wince/PathWinCE.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeBoundingRect):
02:17 Changeset [80556] by philn@webkit.org

2011-03-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK baselines of fast/text and 2 SVG
text-related tests after r80526.

  • platform/gtk/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/gtk/fast/text/international/thai-line-breaks-expected.txt:
  • platform/gtk/fast/text/large-text-composed-char-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/gtk/svg/text/text-intro-05-t-expected.txt:
02:04 Changeset [80555] by carlosgc@webkit.org

2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Do not set juntion sides on scrollbar stepper buttons
https://bugs.webkit.org/show_bug.cgi?id=55868

Fixes rendering of steppers for themes using rounded stepper
buttons on scrollbars like Adwaita.

  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintButton):
02:00 Changeset [80554] by carlosgc@webkit.org

2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use doubles instead of integers for coordinates when rendering arrows
https://bugs.webkit.org/show_bug.cgi?id=55866

To prevent off-by-one rounding errors.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::ScrollbarThemeGtk::paintButton):
01:54 Changeset [80553] by carlosgc@webkit.org

2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862

  • platform/gtk/Skipped: Unskip test fast/forms/onchange-setvalueforuser.html that passes now.

2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862

Add setValueForUser method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setValueForUser):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
https://bugs.webkit.org/show_bug.cgi?id=55862

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Implement setValueForUser()
01:27 Changeset [80552] by laszlo.1.gombos@nokia.com

2011-03-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] [WK2] Fix building WebKit 2 API tests
https://bugs.webkit.org/show_bug.cgi?id=55876

Make sure TESTS_SOURCE_DIR is set for Symbian the same way
as it is for WK1.

  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyPage):
  • UIProcess/API/qt/tests/tests.pri:
01:14 Changeset [80551] by andreas.kling@nokia.com

2011-03-08 Markus Goetz <guruz@guruz.de>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use the QNetworkAccessManager zerocopy feature
https://bugs.webkit.org/show_bug.cgi?id=50082

The feature will be introduced in Qt 4.8.
This patch is backwards compatible with Qt 4.7.

  • WebCore.pro:
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::bufferedData): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::downloadProgress): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData):
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::wrapQtByteBlock): (WebCore::SharedBuffer::hasPlatformData): (WebCore::SharedBuffer::platformData): (WebCore::SharedBuffer::platformDataSize): (WebCore::SharedBuffer::maybeTransferPlatformData): (WebCore::SharedBuffer::clearPlatformData):
01:13 Changeset [80550] by commit-queue@webkit.org

2011-03-08 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[Chromium] Rebaseline CSS3 elliptical gradient tests linux, win32
https://bugs.webkit.org/show_bug.cgi?id=55742

Skia CSS3 elliptical gradient support was added on r79063; rebaseline the associated
win32 and linux tests. There are separate linux results herein due to (minor) pixel
differences with win32. See the bug for the diff images.

  • platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-color-stops-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-color-stops-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-color-stops-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients2-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:
01:06 Changeset [80549] by paroga@webkit.org

2011-03-08 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Add script_shell_command to WebKitPort
https://bugs.webkit.org/show_bug.cgi?id=55925

Add a central place where we generate the shell command from the script name.
This function will be used later to detect the correct script interpreter on Win32.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
00:45 Changeset [80548] by alex@webkit.org

2011-03-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix compilation warnings after r80429
https://bugs.webkit.org/show_bug.cgi?id=55864

  • platform/gtk/WidgetGtk.cpp:
00:21 Changeset [80547] by philn@webkit.org

2011-03-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix after r80536

  • GNUmakefile.am:
00:10 Changeset [80546] by commit-queue@webkit.org

2011-03-08 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878

Enable a passing test now that we properly use the quality value when requesting
a GdkPixbuf to be saved into a buffer.

  • platform/gtk/Skipped:

2011-03-08 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878

Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
when saving GdkPixbuf to a buffer.

  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):

03/07/11:

23:49 Changeset [80545] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Looks editing/pasteboard/data-transfer-items.html is slow.

  • platform/chromium/test_expectations.txt:
23:47 Changeset [80544] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Final build fix for r80536.

  • DerivedSources.make:
23:33 Changeset [80543] by gyuyoung.kim@samsung.com

2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Adjust functions of WebCore's efl port to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55924

Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.

  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::frameRectsChanged): (WebCore::Widget::setEvasObject):
23:27 Changeset [80542] by aestes@apple.com

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

A change to the date parser to handle the case where the year is
specified before the time zone inadvertently started accepting strings
such as '+0000' as valid years. Those strings actually represent time
zones in an offset of hours and minutes from UTC, not years.

  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): If the current character in dateString is '+' or '-', do not try to parse the next token as a year.

2011-03-07 Andy Estes <aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r79060): Timestamp is missing from tweets in twitter.
https://bugs.webkit.org/show_bug.cgi?id=55228

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
23:18 Changeset [80541] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

More build fixes for r80536.

  • CMakeLists.txt:
  • platform/chromium/ClipboardChromium.cpp:
  • platform/chromium/ClipboardChromium.h:
23:05 Changeset [80540] by gyuyoung.kim@samsung.com

2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917

Adjust webkit style to ScrollbarEfl files.

  • platform/efl/ScrollbarEfl.cpp: (scrollbarEflEdjeMessage): (ScrollbarEfl::setParent): (ScrollbarEfl::updateThumbPositionAndProportion): (ScrollbarEfl::frameRectsChanged): (ScrollbarEfl::paint):
  • platform/efl/ScrollbarEfl.h:
22:45 Changeset [80539] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Fix jquery/effects.html and fast/viewpoert/viewport-129.html

  • platform/chromium/test_expectations.txt:
22:18 Changeset [80538] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Build fix for Chromium after r80536.

  • platform/chromium/DataTransferItemChromium.cpp:
  • platform/chromium/DataTransferItemsChromium.cpp:
21:58 Changeset [80537] by ojan@chromium.org

2011-03-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add webkit-patch attach-to-bug for posting to bugzilla from the commandline
https://bugs.webkit.org/show_bug.cgi?id=55749

  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/attachtobug.py: Added.
  • Scripts/webkitpy/tool/steps/options.py:
21:48 Changeset [80536] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Layout test to verify that the basic properties of dataTransfer.items function as expected.

  • editing/pasteboard/data-transfer-items-expected.txt: Added.
  • editing/pasteboard/data-transfer-items.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
all functionality on the DataTransferItems collection has been implemented.
This change does not actually hook up DataTransferItems to reflect the actual contents of a
drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
enabled via several followup patches.

Test: editing/pasteboard/data-transfer-items.html

  • Android.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
  • bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
  • dom/Clipboard.h: (WebCore::Clipboard::policy):
  • dom/Clipboard.idl:
  • dom/DataTransferItem.cpp: Added.
  • dom/DataTransferItem.h: Added. (WebCore::DataTransferItem::~DataTransferItem):
  • dom/DataTransferItem.idl: Added.
  • dom/DataTransferItems.h: Added. (WebCore::DataTransferItems::~DataTransferItems):
  • dom/DataTransferItems.idl: Added.
  • dom/StringCallback.cpp: Added. (WebCore::StringCallback::scheduleCallback):
  • dom/StringCallback.h: Added. (WebCore::StringCallback::~StringCallback):
  • dom/StringCallback.idl: Added.
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DataTransferItemChromium.cpp: Added. (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::kind): (WebCore::DataTransferItemChromium::type): (WebCore::DataTransferItemChromium::getAsString):
  • platform/chromium/DataTransferItemChromium.h: Added.
  • platform/chromium/DataTransferItemsChromium.cpp: Added. (WebCore::DataTransferItemsChromium::create): (WebCore::DataTransferItemsChromium::DataTransferItemsChromium): (WebCore::DataTransferItemsChromium::length): (WebCore::DataTransferItemsChromium::item): (WebCore::DataTransferItemsChromium::deleteItem): (WebCore::DataTransferItemsChromium::clear): (WebCore::DataTransferItemsChromium::add):
  • platform/chromium/DataTransferItemsChromium.h: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Add new runtime enabled flag for data transfer items feature.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDataTransferItems): (WebKit::WebRuntimeFeatures::isDataTransferItemsEnabled):

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Enable data transfer items in DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
21:41 Changeset [80535] by ojan@chromium.org

2011-03-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[test dashboard] pull treemap files
https://bugs.webkit.org/show_bug.cgi?id=55852

  • TestResultServer/handlers/dashboardhandler.py:
21:22 Changeset [80534] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char.html on Windows

  • platform/chromium/test_expectations.txt:
21:19 Changeset [80533] by commit-queue@webkit.org

2011-03-07 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

Rebaseline GPU media/video-display-toggle.html for snow leopard
https://bugs.webkit.org/show_bug.cgi?id=55920

  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:
21:06 Changeset [80532] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Update fast/viewport/viewport-{128,129}.html

  • platform/chromium/test_expectations.txt:
20:49 Changeset [80531] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Updated Skipped lists for editing/pasteboard/onpaste-text-html-types.html.
https://bugs.webkit.org/show_bug.cgi?id=55921
https://bugs.webkit.org/show_bug.cgi?id=55922

  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
20:07 Changeset [80530] by rniwa@webkit.org

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Chromium build fix.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
20:02 Changeset [80529] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Update fast/text/large-text-composed-char-dos.html

  • platform/chromium/test_expectations.txt:
19:54 Changeset [80528] by rniwa@webkit.org

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Calls selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.

  • WebView/WebHTMLView.mm: Removed unused selectionHasStyle. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.

2011-03-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.

Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
call sites of these two functions.

  • WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports selectionStartHasStyle because it's not called anywhere outside of WebCore.
  • WebCore.order: Ditto.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id and a property value. (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
  • editing/EditingStyle.h: (WebCore::EditingStyle::create): Added.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of a CSSStyleDeclaration. (WebCore::Editor::selectionHasStyle): Ditto.
  • editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle. (WebCore::stateStyle): Ditto.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
19:31 Changeset [80527] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Add svg/css/rect-gradient-stroke-shadow.svg added by webkit r80515

  • platform/chromium/test_expectations.txt:
19:17 Changeset [80526] by ap@apple.com

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

  • platform/mac/fast/text/large-text-composed-char-expected.txt: The huge text run is split into multiple text nodes again.

2011-03-07 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
https://bugs.webkit.org/show_bug.cgi?id=55898

<rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
linkifying e-mail addresses in in -[DOMCharacterData setData:]

Changes render tree of fast/text/large-text-composed-char.html, but not image results.

  • dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
  • dom/CharacterData.h: Moved a constant for maximum length from Text.h.
  • dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
  • dom/Text.h: This function was unused in ToT. Moved code around to share with CharacterData.
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode): Chnaged to split large text nodes while parsing again.
19:13 Changeset [80525] by ukai@chromium.org

Unreviewed, update chromium test expectations.

svg/W3C-SVG-1.1/struct-image-07-t.svg failing

  • platform/chromium/test_expectations.txt:
19:07 Changeset [80524] by hayato@chromium.org

2011-03-03 Hayato Ito <hayato@chromium.org>

Reviewed by Mihai Parparita.

[NRWT] Clear output image file used by DumpRenderTree to make sure the
previous image should not be used in the ChromiumDriver.

Also make sure that output image from the ChromiumDriver should be
(empty string) if a test crashes for consistency with the WebKitDriver
implementation.

https://bugs.webkit.org/show_bug.cgi?id=55746

  • Scripts/webkitpy/layout_tests/port/chromium.py:
18:32 Changeset [80523] by andersca@apple.com

2011-03-07 Damian Kaleta <dkaleta@apple.com>

Reviewed by Anders Carlsson.

QuickTime plugin should opt in to a 32-bit non-executable heap
https://bugs.webkit.org/show_bug.cgi?id=55704
<rdar://problem/8105706>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::pluginNeedsExecutableHeap): Decides per plugin if it should opt-in to a 32-bit non-executable heap. By default it should opt-out. (WebKit::PluginProcessProxy::PluginProcessProxy):
18:25 Changeset [80522] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Mark several jquery tests slow for debug build.

  • platform/chromium/test_expectations.txt:
18:19 Changeset [80521] by commit-queue@webkit.org

2011-03-07 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Adam Barth.

Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
https://bugs.webkit.org/show_bug.cgi?id=54522

Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.

No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.

  • platform/image-encoders/JPEGImageEncoder.cpp: (WebCore::jpegEmptyOutputBuffer):
18:13 Changeset [80520] by commit-queue@webkit.org

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

  • svg/dom/vkern-element-crash-expected.txt: Added.
  • svg/dom/vkern-element-crash.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Eric Seidel.

Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
https://bugs.webkit.org/show_bug.cgi?id=55896

Test: svg/dom/vkern-element-crash.html

  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument):
18:09 Changeset [80519] by ukai@chromium.org

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80514.
http://trac.webkit.org/changeset/80514
https://bugs.webkit.org/show_bug.cgi?id=55915

Caused assertion failures (Requested by ukai on #webkit).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
17:55 Changeset [80518] by commit-queue@webkit.org

2011-03-07 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] fast/js/navigator-language.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=55880

Add LANG variable to the clean environment when running
old-run-webkit-tests script.

  • Scripts/old-run-webkit-tests:
17:55 Changeset [80517] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Mark jquery/effects.html slow.

  • platform/chromium/test_expectations.txt:
17:51 Changeset [80516] by commit-queue@webkit.org

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

  • svg/custom/resources/rgb.svg: Added.
  • svg/custom/use-image-in-g-expected.checksum: Added.
  • svg/custom/use-image-in-g-expected.png: Added.
  • svg/custom/use-image-in-g-expected.txt: Added.
  • svg/custom/use-image-in-g.svg: Added.

2011-03-07 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

SVG <image> referenced by <use> is displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=55750

The result of sourceURI must use the URL of the enclosing document as base.
Otherwise, the base may sometimes be empty, and, as a consequence,
the intermediate KURL object may be invalid.

Test: svg/custom/use-image-in-g.svg

  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
17:49 Changeset [80515] by helder@sencha.com

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

  • fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokeRect-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokeRect-gradient-shadow.js: Added.
  • platform/chromium/test_expectations.txt: Skip new test since it fails.
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/qt/Skipped: Skip new test since it fails.
  • platform/qt/svg/css/rect-gradient-stroke-shadow-expected.checksum: Added.
  • platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • svg/css/rect-gradient-stroke-shadow-expected.txt: Added.
  • svg/css/rect-gradient-stroke-shadow.svg: Added.

2011-03-07 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
We need to draw the gradient clipped to the stroke on a CGLayer first,
and then draw the layer on the GraphicsContext.

Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html

svg/css/rect-gradient-stroke-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeRect):
17:37 Changeset [80514] by commit-queue@webkit.org

2011-03-07 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

Fix for blurs behind bitmap images in Chromium, and boosting
shadow blur quality
Bug URLs:

https://bugs.webkit.org/show_bug.cgi?id=55410
https://bugs.webkit.org/show_bug.cgi?id=55506

No new tests. Covered by existing layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
17:14 Changeset [80513] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Some fast/viewport tests are missing expectations.

  • platform/chromium/test_expectations.txt:
17:02 Changeset [80512] by andreas.kling@nokia.com

2011-03-07 Andreas Kling <kling@webkit.org>

Unreviewed Mac build fix after r80508.

  • WebCore.exp.in:
16:57 Changeset [80511] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Import jquery test suite
https://bugs.webkit.org/show_bug.cgi?id=55911

This test suite is imported from https://github.com/jquery/jquery. I
tried to make as few changes as possible in case we want to merge with
upstream in the future. The test suite was original licensed under the
MIT license, which is compatible with WebKit's license.

  • jquery: Added.
16:50 Changeset [80510] by enrica@apple.com

Unreviewed build fix.

Rolling back http://trac.webkit.org/changeset/80497 due to the
32-bit build failures.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/HTMLConverter.h: Removed.
  • platform/mac/HTMLConverter.mm: Removed.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

16:45 Changeset [80509] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Unreviewed.

Skip onpaste-text-html-types.html on Mac and Qt since parts of the test
infrastructure to support it aren't there.

  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:
16:36 Changeset [80508] by andreas.kling@nokia.com

2011-03-07 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.

  • page/FrameView.cpp: (WebCore::FrameView::setBaseBackgroundColor):
  • page/FrameView.h:
16:17 Changeset [80507] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

  • fast/parser/document-write-into-initial-document-expected.txt: Added.
  • fast/parser/document-write-into-initial-document.html: Added.

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
https://bugs.webkit.org/show_bug.cgi?id=55894

The m_frame can disappear out from under us, and there's no point in
checking whether the load is complete in a non-existant frame.

Test: fast/parser/document-write-into-initial-document.html

  • dom/Document.cpp: (WebCore::Document::explicitClose):
15:57 Changeset [80506] by mitz@apple.com

LLVM Compiler build fix.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkGrammarOfString):

15:50 Changeset [80505] by tony@chromium.org

2011-03-07 Tony Chang <tony@chromium.org>

Unreviewed, delete chromium layout test pngs that don't have
corresponding checksum files. They're not getting picked up by
run-webkit-tests without a checksum, so just remove them.

  • platform/chromium-linux/animations/suspend-transform-animation-expected.png: Removed.
  • platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-hkern-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.png: Removed.
  • platform/chromium-linux/transitions/suspend-transform-transition-expected.png: Removed.
  • platform/chromium-mac-leopard/animations/3d/state-at-end-event-transform-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/svg-curve-with-relative-cordinates-expected.png: Removed.
  • platform/chromium-mac/animations/state-at-end-event-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/5390681-2-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5138441-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/5481523-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.png: Removed.
  • platform/chromium-mac/editing/selection/4960116-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Removed.
  • platform/chromium-mac/fast/css/apple-prefix-expected.png: Removed.
  • platform/chromium-mac/fast/css/compare-content-style-expected.png: Removed.
  • platform/chromium-mac/fast/css/css3-space-in-nth-and-lang-expected.png: Removed.
  • platform/chromium-mac/fast/css/font-face-woff-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-comments-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-empty-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-escapes-expected.png: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-invalid-at-expected.png: Removed.
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png: Removed.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Removed.
  • platform/chromium-mac/fast/lists/anonymous-items-expected.png: Removed.
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/line-clamp-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/opacity-reflection-transform-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated2-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated3-expected.png: Removed.
  • platform/chromium-mac/fast/runin/generated4-expected.png: Removed.
  • platform/chromium-mac/fast/text/stripNullFromText-expected.png: Removed.
  • platform/chromium-mac/http/tests/misc/slow-loading-mask-expected.png: Removed.
  • platform/chromium-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png: Removed.
  • platform/chromium-mac/svg/css/css-box-min-width-expected.png: Removed.
  • platform/chromium-mac/svg/custom/container-opacity-clip-viewBox-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.png: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.png: Removed.
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
  • platform/chromium-mac/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Removed.
  • platform/chromium-mac/svg/custom/transformedMaskFails-expected.png: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug6674-expected.png: Removed.
  • platform/chromium-mac/transitions/transition-end-event-rendering-expected.png: Removed.
  • platform/chromium-mac/webarchive/test-link-rel-icon-expected.png: Removed.
  • platform/chromium-win-xp/animations/suspend-transform-animation-expected.png: Removed.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textProperties-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-win-xp/transitions/suspend-transform-transition-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize03-expected.png: Removed.
  • platform/chromium-win/fast/block/float/009-expected.png: Removed.
  • platform/chromium-win/fast/block/float/034-expected.png: Removed.
  • platform/chromium-win/fast/block/float/4145535Crash-expected.png: Removed.
  • platform/chromium-win/fast/block/float/br-with-clear-expected.png: Removed.
  • platform/chromium-win/fast/block/float/float-on-zero-height-line-expected.png: Removed.
  • platform/chromium-win/fast/block/float/narrow-after-wide-expected.png: Removed.
  • platform/chromium-win/fast/block/float/negative-margin-clear-expected.png: Removed.
  • platform/chromium-win/fast/block/float/nowrap-clear-min-width-expected.png: Removed.
  • platform/chromium-win/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/003-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/004-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/005-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/006-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/007-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/008-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/009-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/010-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/011-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/012-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/013-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/014-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/015-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/016-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/017-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/018-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/019-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/020-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/021-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/022-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/023-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/024-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/025-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/026-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/027-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/028-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/029-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/030-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/031-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/032-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/033-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/034-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/035-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/036-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/037-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/038-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/039-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/040-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/041-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/042-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/043-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/044-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/045-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/046-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/048-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/049-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/050-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/062-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/move-with-auto-width-expected.png: Removed.
  • platform/chromium-win/fast/block/positioning/relative-overconstrained-expected.png: Removed.
  • platform/chromium-win/fast/borders/outline-offset-min-assert-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
  • platform/chromium-win/fast/clip/017-expected.png: Removed.
  • platform/chromium-win/fast/css/006-expected.png: Removed.
  • platform/chromium-win/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
  • platform/chromium-win/fast/css/content-dynamic-expected.png: Removed.
  • platform/chromium-win/fast/css/last-child-style-sharing-expected.png: Removed.
  • platform/chromium-win/fast/css/transition-color-unspecified-expected.png: Removed.
  • platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Removed.
  • platform/chromium-win/fast/dom/css-cached-import-rule-expected.png: Removed.
  • platform/chromium-win/fast/dom/css-insert-import-rule-expected.png: Removed.
  • platform/chromium-win/fast/dom/delete-contents-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/001-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/005-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/float-no-longer-overhanging-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/float-withdrawal-2-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-2-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/genContentDestroyChildren-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/staticY-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-boundary-percent-height-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-no-common-root-static-y-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/subtree-table-cell-height-expected.png: Removed.
  • platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
  • platform/chromium-win/fast/events/onloadFrameCrash-expected.png: Removed.
  • platform/chromium-win/fast/frames/002-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-fixed-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-order-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-percentage-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-relative-expected.png: Removed.
  • platform/chromium-win/fast/frames/calculate-round-expected.png: Removed.
  • platform/chromium-win/fast/frames/empty-cols-attribute-expected.png: Removed.
  • platform/chromium-win/fast/frames/empty-frame-src-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-length-fractional-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
  • platform/chromium-win/fast/frames/no-frame-borders-expected.png: Removed.
  • platform/chromium-win/fast/images/image-in-map-expected.png: Removed.
  • platform/chromium-win/fast/images/pdf-as-tiled-background-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-image-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/chromium-win/fast/inline-block/004-expected.png: Removed.
  • platform/chromium-win/fast/inline-block/005-expected.png: Removed.
  • platform/chromium-win/fast/invalid/015-expected.png: Removed.
  • platform/chromium-win/fast/invalid/table-residual-style-crash-expected.png: Removed.
  • platform/chromium-win/fast/js/exception-linenums-in-html-3-expected.png: Removed.
  • platform/chromium-win/fast/js/missing-style-end-tag-js-expected.png: Removed.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Removed.
  • platform/chromium-win/fast/layers/positioned-inside-root-with-margins-expected.png: Removed.
  • platform/chromium-win/fast/layers/zindex-ridonkulous-expected.png: Removed.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/chromium-win/fast/overflow/position-relative-expected.png: Removed.
  • platform/chromium-win/fast/overflow/unreachable-content-test-expected.png: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.png: Removed.
  • platform/chromium-win/fast/reflections/table-cell-expected.png: Removed.
  • platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
  • platform/chromium-win/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
  • platform/chromium-win/fast/replaced/008-expected.png: Removed.
  • platform/chromium-win/fast/table/024-expected.png: Removed.
  • platform/chromium-win/fast/table/031-expected.png: Removed.
  • platform/chromium-win/fast/table/caption-relayout-expected.png: Removed.
  • platform/chromium-win/fast/table/div-as-col-span-expected.png: Removed.
  • platform/chromium-win/fast/table/giantCellspacing-expected.png: Removed.
  • platform/chromium-win/fast/table/growCellForImageQuirk-expected.png: Removed.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Removed.
  • platform/chromium-win/fast/table/percent-widths-stretch-expected.png: Removed.
  • platform/chromium-win/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
  • platform/chromium-win/fast/text/align-center-rtl-spill-expected.png: Removed.
  • platform/chromium-win/fast/text/apply-start-width-after-skipped-text-expected.png: Removed.
  • platform/chromium-win/fast/text/fixed-pitch-control-characters-expected.png: Removed.
  • platform/chromium-win/fast/text/selection-painted-separately-expected.png: Removed.
  • platform/chromium-win/fast/text/soft-hyphen-3-expected.png: Removed.
  • platform/chromium-win/fast/text/stripNullFromText-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-1-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-2-expected.png: Removed.
  • platform/chromium-win/fast/tokenizer/script-after-frameset-expected.png: Removed.
  • platform/chromium-win/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGNumber-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGPoint-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/SVGRect-interface-expected.png: Removed.
  • platform/chromium-win/svg/custom/attribute-namespace-check-expected.png: Removed.
  • platform/chromium-win/svg/custom/class-selector-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-child-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-units-changes-expected.png: Removed.
  • platform/chromium-win/svg/custom/clip-path-with-transform-expected.png: Removed.
  • platform/chromium-win/svg/custom/conditional-processing-outside-switch-expected.png: Removed.
  • platform/chromium-win/svg/custom/create-metadata-element-expected.png: Removed.
  • platform/chromium-win/svg/custom/createelement-expected.png: Removed.
  • platform/chromium-win/svg/custom/css-pixels-dpi-expected.png: Removed.
  • platform/chromium-win/svg/custom/display-none-expected.png: Removed.
  • platform/chromium-win/svg/custom/dynamic-viewBox-expected.png: Removed.
  • platform/chromium-win/svg/custom/evt-onload-expected.png: Removed.
  • platform/chromium-win/svg/custom/fill-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/filter-source-alpha-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-add-stops-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-attr-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/gradient-stop-style-change-expected.png: Removed.
  • platform/chromium-win/svg/custom/hover-default-fill-expected.png: Removed.
  • platform/chromium-win/svg/custom/image-with-aspect-ratio-stretch-expected.png: Removed.
  • platform/chromium-win/svg/custom/inner-percent-expected.png: Removed.
  • platform/chromium-win/svg/custom/inner-svg-hit-test-expected.png: Removed.
  • platform/chromium-win/svg/custom/invalid-transforms-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-excessive-malloc-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-inside-defs-expected.png: Removed.
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.png: Removed.
  • platform/chromium-win/svg/custom/percentage-rect2-expected.png: Removed.
  • platform/chromium-win/svg/custom/poly-identify-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-hittest-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-invalid-points-expected.png: Removed.
  • platform/chromium-win/svg/custom/polyline-setattribute-points-null-expected.png: Removed.
  • platform/chromium-win/svg/custom/prevent-default-expected.png: Removed.
  • platform/chromium-win/svg/custom/repaint-on-image-bounds-change-expected.png: Removed.
  • platform/chromium-win/svg/custom/resource-client-removal-expected.png: Removed.
  • platform/chromium-win/svg/custom/rgbcolor-syntax-expected.png: Removed.
  • platform/chromium-win/svg/custom/rootelement-expected.png: Removed.
  • platform/chromium-win/svg/custom/scroll-hit-test-expected.png: Removed.
  • platform/chromium-win/svg/custom/sheet-title-expected.png: Removed.
  • platform/chromium-win/svg/custom/svg-absolute-children-expected.png: Removed.
  • platform/chromium-win/svg/custom/text-gradient-no-content-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-ignore-after-invalid-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-invalid-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-removeAttributeNS-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-scale-parse-expected.png: Removed.
  • platform/chromium-win/svg/custom/transform-with-ending-space-expected.png: Removed.
  • platform/chromium-win/svg/custom/transformedMaskFails-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-empty-reference-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-recalcStyle-crash-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-symbol-overflow-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-clip-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-no-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-update-expected.png: Removed.
  • platform/chromium-win/svg/custom/viewport-update2-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-clip-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-expected.png: Removed.
  • platform/chromium-win/svg/custom/visibility-override-mask-expected.png: Removed.
  • platform/chromium-win/svg/custom/xhtml-no-svg-renderer-expected.png: Removed.
  • platform/chromium-win/svg/custom/xml-stylesheet-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/chromium-win/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/006-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/007-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/008-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/009-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/014-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/014-test-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/015-expected.png: Removed.
  • platform/chromium-win/svg/hixie/error/016-expected.png: Removed.
  • platform/chromium-win/svg/hixie/painting/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/chromium-win/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/use/002-test-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/chromium-win/svg/webarchive/svg-script-subresouces-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug103533-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222336-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222467-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug269566-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug277062-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug28933-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug2954-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
  • platform/chromium-win/transitions/transition-end-event-rendering-expected.png: Removed.
  • platform/chromium-win/webarchive/archive-with-unencoded-url-expected.png: Removed.
  • platform/chromium-win/webarchive/test-body-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-img-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-input-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-link-rel-icon-expected.png: Removed.
  • platform/chromium-win/webarchive/test-object-data-expected.png: Removed.
  • platform/chromium-win/webarchive/test-script-src-expected.png: Removed.
  • platform/chromium-win/webarchive/test-table-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-td-background-expected.png: Removed.
  • platform/chromium-win/webarchive/test-xml-stylesheet-expected.png: Removed.
15:40 Changeset [80504] by tony@chromium.org

2011-03-07 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[Chromium] Find .checksum files without .pngs and vice-versa
https://bugs.webkit.org/show_bug.cgi?id=55236

  • Scripts/find-mismatched-layout-test-results: Added. A script for finding

mismatched results.

15:18 Changeset [80503] by xji@chromium.org

2011-03-07 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip test caretRangeFromPoint-in-zoom-and-scroll.html in mac-wk2 since
EventSender.mouseMoveTo is not yet supported.

  • platform/mac-wk2/Skipped:
15:14 Changeset [80502] by abarth@webkit.org

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80500.
http://trac.webkit.org/changeset/80500
https://bugs.webkit.org/show_bug.cgi?id=55908

Caused mysterious GYP error (Requested by abarth on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
14:54 Changeset [80501] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Fix Chromium Mac build. This header should only be included when the
feature is enabled.

  • platform/cf/RunLoopTimerCF.cpp:
14:37 Changeset [80500] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add WML files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55905

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
14:34 Changeset [80499] by enne@google.com

2011-03-07 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Add missing include to #define Skia parameter
https://bugs.webkit.org/show_bug.cgi?id=55885

  • platform/graphics/chromium/ShaderChromium.h:
14:31 Changeset [80498] by cfleizach@apple.com

Source/WebCore: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rootObjectForFrame):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::isAttachment):
(WebCore::AccessibilityScrollView::widgetForAttachmentView):

  • accessibility/AccessibilityScrollView.h:

(WebCore::AccessibilityScrollView::firstChild):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Source/WebKit/mac: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
returns the scroll bar objects).
Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
will expect that as its child, instead of the WebCore ScrollView object.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Tools: AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::focusedElement):

Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
because it could change at any time.

(AccessibilityController::rootElement):

LayoutTests: AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
https://bugs.webkit.org/show_bug.cgi?id=55706

Reviewed by Beth Dakin.

  • platform/mac/accessibility/webkit-scrollarea-expected.txt:
  • platform/mac/accessibility/webkit-scrollarea-position-expected.txt:
  • platform/mac/accessibility/webkit-scrollarea-position.html:
  • platform/mac/accessibility/webkit-scrollarea.html:
14:13 Changeset [80497] by enrica@apple.com

REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This is a resubmission of a patch that was landed a while ago then rolled
back because of a build failure on SnowLeopard and Leopard.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

  • WebCore.xcodeproj/project.pbxproj: Added new file.
  • platform/mac/HTMLConverter.h: Added.
  • platform/mac/HTMLConverter.mm: Added.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

14:04 Changeset [80496] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some missing platform files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55897

There are a bunch more, but this is a start.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
13:56 Changeset [80495] by barraclough@apple.com

Source/JavaScriptCore: Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

Patch by Yuta Kitamura <yutak@chromium.org> on 2011-03-06
Reviewed by Kent Tamura.

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

(WTF::MD5::MD5):

  • wtf/SHA1.cpp: Added.

(WTF::testSHA1): This function will be run the first time SHA1
constructor is called. This function computes a few hash values
and checks the results in debug builds. However, constructor is
probably not a good place to run these tests, so we need to find
a good place for it (bug 55853).
(WTF::expectSHA1):
(WTF::f):
(WTF::k):
(WTF::rotateLeft):
(WTF::SHA1::SHA1):
(WTF::SHA1::addBytes):
(WTF::SHA1::computeHash):
(WTF::SHA1::finalize):
(WTF::SHA1::processBlock):
(WTF::SHA1::reset):

  • wtf/SHA1.h: Added.

(WTF::SHA1::addBytes):

  • wtf/wtf.pri:

LayoutTests: Bug 55815 - Should throw an exception from JSObject::defineOwnProperty if !isExtensible().

Reviewed by Cameron Zwarich.

  • ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:

Now with added passingness!

13:52 Changeset [80494] by steveblock@google.com

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55879

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/v8/JavaClassV8.cpp:
  • bridge/jni/v8/JavaClassV8.h:
  • bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp. (JavaField::JavaField):
  • bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h. (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaField::type): (JSC::Bindings::JavaField::getJNIType):
  • bridge/jni/v8/JavaInstanceV8.cpp:
  • bridge/jni/v8/JavaNPObjectV8.cpp:
13:31 Changeset [80493] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This requires a DEPS roll for a Chromium-side change to support DRT testing of
event.dataTransfer.types.

  • DEPS:
13:22 Changeset [80492] by xji@chromium.org

2011-03-07 Xiaomei Ji <xji@chromium.org>

Reviewed by Martin Robinson.

Make fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html less port-dependent.
Preiously, the test clicked at a specific pixel so different fonts result in slightly different positions.
Change the test to click on a specific character offset.
https://bugs.webkit.org/show_bug.cgi?id=30816

  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
13:01 Changeset [80491] by mihaip@chromium.org

2011-03-07 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Clean up fast/viewport expectations and remove a test that no longer
crashes (the underlying V8 bug was fixed).

  • platform/chromium/test_expectations.txt:
12:52 Changeset [80490] by joepeck@webkit.org

2011-03-07 Joseph Pecoraro <joepeck@webkit.org>

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Include expected results for r80483.

Numerous LayoutTests/fast/viewport tests.

12:43 Changeset [80489] by commit-queue@webkit.org

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Use preferred locale information when choosing fallback
font using fontconfig on Linux platform.
http://bugs.webkit.org/show_bug.cgi?id=55453

No new tests, as it depends on ICU and locale setting, so it will be
covered by Chromium side.

  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp:

2011-03-07 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

Use preferred locale information when choosing fallback font using
fontconfig on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=55453

Tests will be covered by Chromium side.

  • public/gtk/WebFontInfo.h: (WebKit::WebFontInfo::familyForChars): added 3rd parameter |preferredLocale|
  • public/linux/WebSandboxSupport.h: (WebKit::WebSandboxSupport::getFontFamilyForCharacters): added 3rd parameter |preferredLocale|
  • src/PlatformBridge.cpp:
  • src/gtk/WebFontInfo.cpp:
12:31 BuildingQtOnLinux edited by srikumar.b@gmail.com
by default, ubuntu does not come with g++. And aptitude tells unknown … (diff)
12:14 Changeset [80488] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add gobject, cpp, and objc bindings to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55892

These are also excluded from the Chromium build but needed for various
other ports.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:10 Changeset [80487] by commit-queue@webkit.org

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

  • fast/dom/dom-method-document-change-expected.txt: Added.
  • fast/dom/dom-method-document-change.html: Added.

2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Dimitri Glazkov.

Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
https://bugs.webkit.org/show_bug.cgi?id=55803

Test: fast/dom/dom-method-document-change.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Node.cpp: (WebCore::Node::checkReplaceChild): (WebCore::Node::checkAddChild):
  • dom/Node.h:
11:55 Changeset [80486] by dcheng@chromium.org

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Removed.
  • editing/pasteboard/onpaste-text-html-types.html: Removed.

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80484.
http://trac.webkit.org/changeset/80484
https://bugs.webkit.org/show_bug.cgi?id=55891

requires Chromium DEPS roll (Requested by dcheng on #webkit).

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types):
  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
11:52 Changeset [80485] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add missing bindings/js files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55888

These files are excluded from the Chromium build but needed for the Mac
build.

  • WebCore.gypi:
11:48 Changeset [80484] by dcheng@chromium.org

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Add a simple layout test to verify that event.clipboardData.types
reflects the types available in a paste.

  • editing/pasteboard/onpaste-text-html-types-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html-types.html: Added.

2011-03-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

This is a preliminary patch to support event.dataTransfer.items. This
adds plumbing to support retrieving the types in a paste event. It also
moves the check for files in a drag/paste up to ClipboardChromium, since
internal code needs to be able to differentiate between actual files in
a drag and someone that simply decided to use "Files" as a custom type
string.

Test: editing/pasteboard/onpaste-text-html-types.html

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::containsFilenames):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::types):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
11:41 Changeset [80483] by joepeck@webkit.org

2011-03-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Added tests specifically to test Console warnings.

  • fast/viewport/viewport-warnings-1.html: Added.
  • fast/viewport/viewport-warnings-2.html: Added.
  • fast/viewport/viewport-warnings-3.html: Added.
  • fast/viewport/viewport-warnings-4.html: Added.
  • fast/viewport/viewport-warnings-5.html: Added.
  • fast/viewport/viewport-warnings-6.html: Added.

2011-03-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707

Correct and improve the error messages for viewport parsing.

Tests: fast/viewport/viewport-warnings-1.html

fast/viewport/viewport-warnings-2.html
fast/viewport/viewport-warnings-3.html
fast/viewport/viewport-warnings-4.html
fast/viewport/viewport-warnings-5.html
fast/viewport/viewport-warnings-6.html

  • dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findSizeValue): remove incorrect device-width / height tips. (WebCore::setViewportFeature): report a warning for an unrecognized key. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key. (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
  • dom/ViewportArguments.h: removed no longer used warnings.
11:37 Changeset [80482] by jamesr@google.com

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

This splits up LayerRendererChromium::drawLayers() into two phases,
one that updates layers and one that actually draws them. Most of the
patch is moving the bodies of drawLayers() and updateLayersRecursive()
into smaller helper functions.

The main entry point is renamed updateAndDrawLayers(), but otherwise
has the same signature as drawLayers() did. Internally it does the
following:

1.) Updates the root layer's contents
2.) Updates the root layer's scrollbars
3.) Updates the RenderSurface tree and the contents of all child
layers
4.) Draws the root layer and root layer scrollbars
5.) Draws all child layers using the previously updated
CCLayerImpl/RenderSurface data.

A few things still need to be done after this patch to complete the separation
of the update and draw step, but they can happen in later patches:
*) The root layer and root layer scrollbars contents should be
uploaded to textures at draw time, not update time.
*) The RenderSurface tree should be updated at draw time, not update
time.

Covered by the compositing/ tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::updateRootLayerScrollbars): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateContentsRecursive): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::visibleRectSize):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

2011-03-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Separate the &quot;update&quot; and &quot;draw&quot; portions of LayerRendererChromium&apos;s drawLayers function
https://bugs.webkit.org/show_bug.cgi?id=54047

Call updated LayerRendererChromium APIs.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::doComposite):
11:34 Changeset [80481] by abarth@webkit.org

2011-03-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sort WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55887

These files should be in order. This is preparation for adding in the
missing files.

  • WebCore.gypi:
11:19 Changeset [80480] by ossy@webkit.org

Unreviewed buildfix after r80478.

  • dom/Document.cpp: Add suggested parentheses to make GCC happy.

(WebCore::Document::didReceiveTask):

11:05 Changeset [80479] by weinig@apple.com

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::unableToImplementPolicy):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp: (WebKit::WebPolicyClient::unableToImplementPolicy):
  • UIProcess/WebPolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: (WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): Pipe unableToImplementPolicy through both the bundle and the main WebKit2 API.

2011-03-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add unableToImplementPolicy callback for WebKit2 policy client
<rdar://problem/9071902>
https://bugs.webkit.org/show_bug.cgi?id=55884

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Update policy client initialization struct for new member.
10:54 Changeset [80478] by commit-queue@webkit.org

2011-03-07 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
Schedule them with timer when page loading is resumed. The tasks will be performed
in the original order. This fixes the problem that database callbacks could be missed
when page loading was deferred.
https://bugs.webkit.org/show_bug.cgi?id=49401

Manual test added: manual-tests/database-callback-deferred.html.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::didReceiveTask): (WebCore::Document::postTask): (WebCore::Document::pendingTasksTimerFired): (WebCore::Document::willDeferLoading): (WebCore::Document::didResumeLoading):
  • dom/Document.h:
  • manual-tests/database-callback-deferred.html: Added.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
10:53 Changeset [80477] by antti@apple.com

Use HashMaps for caching primitive values
https://bugs.webkit.org/show_bug.cgi?id=55873

Reviewed by Sam Weinig.

Most documents use only small subset of cacheable primitive values. By replacing
fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
expanding the range of cacheable values.

  • css/CSSPrimitiveValueCache.cpp:

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

  • css/CSSPrimitiveValueCache.h:
10:50 Changeset [80476] by steveblock@google.com

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55881

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
  • bridge/jni/jsc/JNIBridgeJSC.h: Removed.
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JavaClassJSC.cpp:
  • bridge/jni/jsc/JavaClassJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
10:28 Changeset [80475] by weinig@apple.com

Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827

Reviewed by Anders Carlsson.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):

  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkContentPolicy):

  • loader/PolicyChecker.h:

Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

Source/WebKit/chromium:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForResponse):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Source/WebKit/qt:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebFrame.cpp:

(WebFrame::dispatchDecidePolicyForResponse):

  • WebFrame.h:

Source/WebKit/wince:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDecidePolicyForResponse):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse and pass the entire response, instead of just the MIMEType.
  • Updated both UIProcess API and bundle API to also be based on the whole response, not just the MIMEType.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForResponse):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForResponse):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForResponse):
(-[BrowserWindowController awakeFromNib]):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Update tools for new name.

10:20 Changeset [80474] by bulach@chromium.org

2011-03-07 Marcus Bulach <bulach@chromium.org>

Reviewed by Dan Bernstein.

WebViewImpl::focusedWebCoreFrame() should be const.
https://bugs.webkit.org/show_bug.cgi?id=55870

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::focusedWebCoreFrame):
  • src/WebViewImpl.h:
10:13 Changeset [80473] by eric.carlson@apple.com

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>

No new tests, this is just more plumbing.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions. (WebCore::addMediaEngine): Ditto. (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.

2011-03-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::registerSelf): Update for MediaEngineRegistrar change.
10:09 Changeset [80472] by steveblock@google.com

2011-03-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=55774

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature): (JavaMethod::JNIReturnType): (JavaMethod::methodID):
  • bridge/jni/JavaMethod.h: (JSC::Bindings::JavaMethod::name): (JSC::Bindings::JavaMethod::returnType): (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters): (JSC::Bindings::JavaMethod::isStatic):
  • bridge/jni/JavaString.h: (JSC::Bindings::JavaString::JavaString): (JSC::Bindings::JavaString::utf8): (JSC::Bindings::JavaString::length): (JSC::Bindings::JavaString::impl):
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/v8/JNIBridgeV8.h:
  • bridge/jni/v8/JavaClassV8.cpp:
  • bridge/jni/v8/JavaClassV8.h:
  • bridge/jni/v8/JavaInstanceV8.cpp:
09:33 Changeset [80471] by jorlow@chromium.org

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBIndex, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:

2011-03-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
https://bugs.webkit.org/show_bug.cgi?id=55812

This brings us in line with what's in the spec:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::create): (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::source):
  • storage/IDBCursor.h:
  • storage/IDBCursor.idl:
  • storage/IDBCursorWithValue.cpp: (WebCore::IDBCursorWithValue::create): (WebCore::IDBCursorWithValue::IDBCursorWithValue):
  • storage/IDBCursorWithValue.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create): (WebCore::IDBIndex::objectStore):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
09:20 Changeset [80470] by cfleizach@apple.com

AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
https://bugs.webkit.org/show_bug.cgi?id=55735

Reviewed by Beth Dakin.

Source/WebCore:

The ARIA grid implementation needed to verify the row/column range of a cell instead of
assuming a 1-1 mapping between children and row/column.

Test: platform/mac/accessibility/aria-table-with-colspan-cells.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

LayoutTests:

  • platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
  • platform/mac/accessibility/aria-table-with-colspan-cells.html: Added.
08:47 Changeset [80469] by sfalken@apple.com

Bump version.

  • win/tools/scripts/VERSION:
07:38 Changeset [80468] by andreip@google.com

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
IDBObjectStore objects used to be created asynchronously, so we needed
this method to be invoked, with the new object store as the parameter,
whenever the creation succeeded. The spec has changed so that IDBObjectStore
objects are created synchronously, so this method is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=55777

No new tests, just refactoring.

  • storage/IDBCallbacks.h:
  • storage/IDBRequest.cpp:
  • storage/IDBRequest.h:

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
https://bugs.webkit.org/show_bug.cgi?id=55777

  • src/IDBCallbacksProxy.cpp:
  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCallbacksImpl.h:
07:15 Changeset [80467] by steveblock@google.com

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaParameter should be removed
https://bugs.webkit.org/show_bug.cgi?id=55772

No new tests, refactoring only.

  • bridge/jni/JNIBridge.cpp: (JavaMethod::JavaMethod): (JavaMethod::~JavaMethod): (JavaMethod::signature):
  • bridge/jni/JNIBridge.h: (JSC::Bindings::JavaMethod::parameterAt): (JSC::Bindings::JavaMethod::numParameters):
  • bridge/jni/JNIUtility.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::convertNPVariantToJValue):
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::invokeMethod):
05:39 Changeset [80466] by andreip@google.com

2011-03-07 Andrei Popescu <andreip@google.com>

Reviewed by Steve Block.

[Chromium] test_expectations.txt cannot be parsed correctly
https://bugs.webkit.org/show_bug.cgi?id=55871

  • platform/chromium/test_expectations.txt:
04:20 Changeset [80465] by andreas.kling@nokia.com

2011-03-07 Kenneth Rohde Christiansen <kenneth@webkit.org>

Unreviewed.

Add expected results to the new viewport tests

  • fast/viewport/viewport-91-expected.txt: Added.
  • fast/viewport/viewport-92-expected.txt: Added.
  • fast/viewport/viewport-93-expected.txt: Added.
  • fast/viewport/viewport-94-expected.txt: Added.
  • fast/viewport/viewport-95-expected.txt: Added.
  • fast/viewport/viewport-96-expected.txt: Added.
03:23 Changeset [80464] by ossy@webkit.org

Unreviewed.

[Qt] http/tests/inspector/resource-parameters.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55867

  • platform/qt/Skipped: Add http/tests/inspector/resource-parameters.html to make buildbot happy.
03:19 Changeset [80463] by antti@apple.com

Source/WebCore: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

Make CSS primitive value cache per-document.

Test: http/tests/security/cross-origin-css-primitive.html

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseWCSSInputProperty):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionXY):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDelay):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationDuration):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitNumber):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:

(WebCore::CSSParser::primitiveValueCache):

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createColor):
(WebCore::CSSPrimitiveValue::create):

  • css/CSSPrimitiveValueCache.cpp: Added.

(WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
(WebCore::CSSPrimitiveValueCache::createIdentifierValue):
(WebCore::CSSPrimitiveValueCache::createColorValue):
(WebCore::CSSPrimitiveValueCache::createValue):

  • css/CSSPrimitiveValueCache.h: Added.

(WebCore::CSSPrimitiveValueCache::create):
(WebCore::CSSPrimitiveValueCache::createValue):

  • dom/Document.cpp:

(WebCore::Document::cssPrimitiveValueCache):

  • dom/Document.h:

LayoutTests: REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
https://bugs.webkit.org/show_bug.cgi?id=55166
<rdar://problem/9050430>

Reviewed by Oliver Hunt.

  • http/tests/security/cross-origin-css-primitive-expected.txt: Added.
  • http/tests/security/cross-origin-css-primitive.html: Added.
  • http/tests/security/resources/cross-origin-css-primitive-iframe.html: Added.
02:40 Changeset [80462] by alex@webkit.org

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Added new GTK+ test results.

  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt: Added.
01:55 Changeset [80461] by ukai@chromium.org

2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80458.
http://trac.webkit.org/changeset/80458
https://bugs.webkit.org/show_bug.cgi?id=55863

caused tests to crash on several chromium bots (Requested by
ukai on #webkit).

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::prepareRequest): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
  • src/AssociatedURLLoader.h:
01:35 Changeset [80460] by alex@webkit.org

2011-03-07 Alejandro G. Castro <alex@igalia.com>

Skipped failing test that requires a missing feature in
layoutTestController. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=55862

  • platform/gtk/Skipped:
01:25 Changeset [80459] by abarth@webkit.org

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Filter sources in WebCore GYP build for Mac
https://bugs.webkit.org/show_bug.cgi?id=55857

This patch removes a large number of files that do not build as part of
the Mac build. I'm not fully sold on this method of
including/excluding files, but it's the "gyp way" so we should probably
try it first.

This patch also sets xcode_list_excluded_files to 0, which removes the
excluded files from the Xcode project file, which is necessary in order
to prevent the header map feature from including the wrong header file.

  • gyp/WebCore.gyp:
00:46 Changeset [80458] by commit-queue@webkit.org

2011-03-07 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925

No tests needed. Exposes no new functionality.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h: (WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):
00:20 Changeset [80457] by commit-queue@webkit.org

2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed EFL build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=55858

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
00:19 Changeset [80456] by commit-queue@webkit.org

2011-03-07 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Tony Gentilcore.

In layout tests, iframe's onload handler should not use script function
defined after the iframe.
https://bugs.webkit.org/show_bug.cgi?id=54942

Found and fixed more tests in addition to the first patch to bug 54942.
Tried best to avoid expectation changes.

  • editing/execCommand/find-after-replace.html:
  • editing/input/option-page-up-down.html:
  • editing/input/scroll-viewport-page-up-down.html:
  • editing/pasteboard/copy-standalone-image.html:
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
  • editing/pasteboard/paste-noscript-xhtml.xhtml:
  • editing/selection/drag-in-iframe.html:
  • editing/undo/undo-iframe-location-change.html:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype.html:
  • fast/dom/Window/window-postmessage-clone-frames.html:
  • fast/dynamic/paused-event-dispatch.html:
  • fast/events/keydown-remove-frame.html:
  • fast/events/mousedown-in-subframe-scrollbar.html:
  • fast/frames/content-opacity-2.html:
  • fast/frames/viewsource-plain-text-tags.html:
  • fast/frames/viewsource-unfinished-tags.html:
  • fast/history/form-submit-in-frame-via-onclick.html:
  • fast/history/form-submit-in-frame.html:
  • fast/xsl/xslt-text-expected.txt:
  • fast/xsl/xslt-text.html:
  • http/tests/messaging/cross-domain-message-send.html:
  • http/tests/misc/cached-scripts-expected.txt:
  • http/tests/misc/cached-scripts.html:
  • http/tests/plugins/post-url-file-expected.txt:
  • http/tests/plugins/post-url-file.html:
  • http/tests/security/listener/xss-inactive-closure-expected.html:
  • http/tests/security/listener/xss-inactive-closure.html:
  • http/tests/security/postMessage/delivery-order.html:
  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
  • http/tests/security/postMessage/invalid-origin-throws-exception.html:
  • http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
  • http/tests/security/postMessage/target-origin.html:
  • http/tests/security/xss-DENIED-getSVGDocument-iframe.html:
  • http/tests/xmlhttprequest/detaching-frame-2.html:
  • media/media-document-audio-repaint.html:
  • media/media-document-audio-size.html:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
  • platform/mac/fast/loader/non-html-load-event-expected.txt:
  • platform/mac/fast/loader/non-html-load-event.html:
  • scrollbars/hidden-iframe-scrollbar-crash2.html:
  • storage/close-during-stress-test.html:
  • svg/custom/js-update-transform-changes.svg:

03/06/11:

23:57 Changeset [80455] by ukai@chromium.org

Unreviewed, update chromium test expectations.

inspector/styles/styles-add-blank-property.html becomes flaky.

  • platform/chromium/test_expectations.txt:
23:22 Changeset [80454] by ukai@chromium.org

Unreviewd, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109) on Mac

platform/chromium/fast/text/international/complex-text-rectangle.html

  • platform/chromium/test_expectations.txt:
22:25 Changeset [80453] by tkent@chromium.org

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium expectation files for r80449.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
22:02 Changeset [80452] by abarth@webkit.org

2011-03-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webcore_derived_source_files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55856

This is the list of files generated by the Mac port. It's possible
other ports generate a different list of files.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
21:41 Changeset [80451] by commit-queue@webkit.org

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium.
https://bugs.webkit.org/show_bug.cgi?id=55844

Chromium will find it useful to know the page dismissal status (i.e.,
whether a frame is in the midst of executing a beforeunload or unload
handler), so expose that information through the chromium port in the
WebKit API.

This is my second attempt at this patch. The previous one broke
downstream Chromium builds of some unit tests which had classes derived
from WebFrame (and thus became uninstantiable because of this new pure
virtual method). Those have now been fixed (http://crrev.com/77101).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
21:14 Changeset [80450] by tkent@chromium.org

2011-03-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add a Mac expectation for a new test of r80449.

  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added.
21:12 Changeset [80449] by tkent@chromium.org

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.

Test: fast/forms/input-appearance-spinbutton-visibility.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
https://bugs.webkit.org/show_bug.cgi?id=55839
http://crbug.com/73866
http://crbug.com/62527

  • fast/forms/input-appearance-spinbutton-visibility.html: Added for the test to make sure input type=number spin buttons are shown or hidden correctly with Javascript.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.checksum: Added for the expectation checksum.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Added for the expectation image.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Added for the expectation render tree txt.
20:50 Changeset [80448] by commit-queue@webkit.org

2011-03-06 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
https://bugs.webkit.org/show_bug.cgi?id=54795

Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.

Test: manual-tests/popup-width-restriction-within-screen.html

  • manual-tests/popup-width-restriction-within-screen.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
20:02 Changeset [80447] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Regression at WebKit r80440 (bug 55854) also on mac.

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
19:17 Changeset [80446] by yutak@chromium.org

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

The code is based on Chromium's portable SHA-1 implementation
(src/base/sha1_portable.cc). Modifications were made in order
to make the code comply with WebKit coding style.

  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MD5.cpp: (WTF::MD5::MD5):
  • wtf/SHA1.cpp: Added. (WTF::testSHA1): This function will be run the first time SHA1 constructor is called. This function computes a few hash values and checks the results in debug builds. However, constructor is probably not a good place to run these tests, so we need to find a good place for it (bug 55853). (WTF::expectSHA1): (WTF::f): (WTF::k): (WTF::rotateLeft): (WTF::SHA1::SHA1): (WTF::SHA1::addBytes): (WTF::SHA1::computeHash): (WTF::SHA1::finalize): (WTF::SHA1::processBlock): (WTF::SHA1::reset):
  • wtf/SHA1.h: Added. (WTF::SHA1::addBytes):
  • wtf/wtf.pri:

2011-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039

  • ForwardingHeaders/wtf/SHA1.h: Added.
18:23 Changeset [80445] by ukai@chromium.org

Unreviewed, update chromium test expectations.

Regression at WebKit r80438 (crbug.com/75109)

fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
platform/chromium/fast/text/international/complex-text-rectangle.html
svg/css/getComputedStyle-basic.xhtml
fast/text/hyphenate-limit-before-after.html

Regression at WebKit r80440 (bug 55854)

fast/forms/onchange-setvalueforuser.html

  • platform/chromium/test_expectations.txt:
17:35 Changeset [80444] by mitz@apple.com

LLVM Compiler build fix.

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setValueForUser:]):

17:11 Changeset [80443] by dbates@webkit.org

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel and David Kilzer.

Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
https://bugs.webkit.org/show_bug.cgi?id=55503

Fix misspelled word "Dowloads" [sic] in the message printed to standard output
in checkForJavaSDK().

Also, remove extraneous space in function prototype for unlinkZeroFiles.

  • Scripts/build-webkit:
17:00 Changeset [80442] by eric.carlson@apple.com

2011-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

QuickTime based media engines should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55848

No new tests, it is only possible to test this by manually deleting and monitoring the
the Quicktime caches.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing. (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine. (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing. (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when

creating new movie.

(WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in

m_privateBrowsing and set movie attribute.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):

Initialize m_privateBrowsing.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store

privacy setting in m_privateBrowsing and call QTMovie.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing. (QTMovie::load):Pass private browsing property when creating new movie. (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and

set movie property.

  • platform/graphics/win/QTMovie.h:
16:44 Changeset [80441] by mitz@apple.com

Updated more platform-specific results after r80438.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Copied from platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt.
16:34 Changeset [80440] by mitz@apple.com

Updated platform-specific results after r80438.

  • platform/mac-leopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
16:22 Changeset [80439] by dbates@webkit.org

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
the value for border-spacing from the value of the WebKit internal CSS
property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.

The CSS property border-spacing describes the horizontal and vertical border
spacing for an HTML Table element. Notice, WebKit internally represents the value
of this property as two properties: -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
respectively. And WebKit doesn't know to reconstitute these internal properties.
Therefore style.borderSpacing always returns the empty string.

Test: fast/css/table-border-spacing.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
  • css/CSSMutableStyleDeclaration.h:

2011-03-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

style.borderSpacing always returns empty string
https://bugs.webkit.org/show_bug.cgi?id=54816

Tests that style.borderSpacing returns the correct result for valid, negative, and missing border-spacing values.

  • fast/css/table-border-spacing-expected.txt: Added.
  • fast/css/table-border-spacing.html: Added.
14:44 Changeset [80438] by mitz@apple.com

<rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=55850

Reviewed by Oliver Hunt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit.html

fast/text/hyphenate-limit-before-after.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedProperties) Updated this array with the new properties and some old properties
that it was missing.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
CSSPropertyWebkitHyphenateLimit{Before,After}.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
'auto' and non-negative integers.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
allow hyphenation if the prefix and the suffix are sufficiently long.
(WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitBefore): Added.
(WebCore::InheritedFlags::hyphenationLimitAfter): Added.
(WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
(WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
(WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
representation of 'auto'.
(WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
(WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/parsing-hyphenate-limit-expected.txt: Added.
  • fast/css/parsing-hyphenate-limit.html: Added.
  • fast/text/hyphenate-limit-before-after.html: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
14:00 Changeset [80437] by commit-queue@webkit.org

2011-03-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80436.
http://trac.webkit.org/changeset/80436
https://bugs.webkit.org/show_bug.cgi?id=55849

Broke Chromium compile across the board (Requested by dglazkov
on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:36 Changeset [80436] by commit-queue@webkit.org

2011-03-06 Sreeram Ramachandran <sreeram@google.com>

Reviewed by Dimitri Glazkov.

Expose page dismissal event status through the WebKit API for chromium
https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageDismissalEventBeingDispatched):
  • src/WebFrameImpl.h:
10:39 Changeset [80435] by jberlin@webkit.org

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Sam Weinig.

Source/WebCore:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCore.exp.in:

Add the new WKSI functions.

  • platform/mac/WebCoreSystemInterface.h:

Ditto.

  • platform/mac/WebCoreSystemInterface.mm:

Ditto.

  • platform/mac/CookieJar.mm:

(WebCore::cookies):
If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
Otherwise, behave the same as before.
(WebCore::cookieRequestHeaderFieldValue):
Ditto.
(WebCore::setCookies):
Ditto.
(WebCore::cookiesEnabled):
Ditto
(WebCore::getRawCookies):
Ditto.
(WebCore::deleteCookie):
Ditto.

  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
function instead of at the global scope.
(WebCore::currentCookieStorage):
Use privateBrowsingCookieStorage.
(WebCore::setCurrentCookieStorage):
Ditto.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
wkCreatePrivateInMemoryHTTPCookieStorage.

  • platform/network/mac/CookieStorageMac.mm:

(WebCore::privateBrowsingCookieStorage):
Keep track of the Private Browsing Cookie Storage.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::shouldRelaxThirdPartyCookiePolicy):
Refactor the logic to determine whether or not to relax the third party cookie policy here.
If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
(WebCore::ResourceHandle::createNSURLConnection):
Use shouldRelaxThirdPartyCookiePolicy.
(WebCore::ResourceHandle::loadResourceSynchronously):
Ditto.

Source/WebKit/mac:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

Source/WebKit2:

When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
Private Browsing Storage Session.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Add support for using the new WKSI functions in WebCore.

WebKitLibraries:

When Private Browsing is enabled, use cookies from a in-memory Cookie Storage based on the
Private Browsing Storage Session.

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
10:29 Changeset [80434] by commit-queue@webkit.org

2011-03-06 Oleg Romashin <romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part1
Adding dummy Qt files for Plugin Process implementation,
Adding missing sources into Qt pro files
https://bugs.webkit.org/show_bug.cgi?id=55719

  • DerivedSources.pro:
  • PluginProcess/qt: Added.
  • PluginProcess/qt/PluginControllerProxyQt.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/qt/PluginProcessMainQt.cpp: Added. (WebKit::PluginProcessMain):
  • PluginProcess/qt/PluginProcessQt.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2API.pri:
  • WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Added. (WebKit::PluginProxy::needsBackingStore):

03/05/11:

22:23 Changeset [80433] by dcheng@chromium.org

2011-03-05 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Add method to WebClipboard to read images from the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=55814

  • public/WebClipboard.h: (WebKit::WebClipboard::readImage):
22:11 Changeset [80432] by mitz@apple.com

Set the svn:mime-type property of some PNG files to image/png

17:40 Changeset [80431] by weinig@apple.com

2011-03-05 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded onPageClose function from DrawingArea
https://bugs.webkit.org/show_bug.cgi?id=55836

  • WebProcess/WebPage/DrawingArea.h: Remove empty function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Remove only called
15:38 Changeset [80430] by commit-queue@webkit.org

2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
http://trac.webkit.org/changeset/80428
https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • http/tests/plugins/resources/dump-post.pl:
  • platform/gtk/Skipped:

2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80428.
http://trac.webkit.org/changeset/80428
https://bugs.webkit.org/show_bug.cgi?id=55833

Broke SnowLeopard (Requested by xan_ on #webkit).

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile):
14:32 Changeset [80429] by mrobinson@webkit.org

2011-03-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531

manual test: manual-tests/plugins/windowless.html

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::initXEvent): Instead of setting the window for windowless plugin events, set the window value to none. This method is also used to send focus in / focus out events to windowed plugins, but this is not one of the plugin types where the window parameter matters. This matches what Mozilla does. Also pass in the display of the widget itself, not the default display. (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area, reset the cursor. (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the widget the top-level window explicitly. This matches Mozilla.

2011-03-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here which is more fitting since it sets the cursor for the entire window.
14:02 Changeset [80428] by mrobinson@webkit.org

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

  • http/tests/plugins/resources/dump-post.pl: Instead of printing out the "keywords" parameter, print out the POSTDATA parameter. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA.
  • platform/gtk/Skipped: Unskip the test which is now passing.

2011-03-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.
11:49 Changeset [80427] by bweinstein@apple.com

Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned

by willSendRequestForFrame. The API expects a retained reference to the URL request.

10:03 Changeset [80426] by caseq@chromium.org

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness of extension-events.html.

  • inspector/extensions/extensions-events.html:
09:39 Changeset [80425] by mnaganov@chromium.org

2011-03-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=55824

Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilesPanel.prototype.handleShortcut): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint): (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint): (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles): (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
09:32 Changeset [80424] by qi.2.zhang@nokia.com

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • WebCore.pri:
  • features.pri:

2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
09:10 Changeset [80423] by pfeldman@chromium.org

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding null check to prevent inspector tests from failing.

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
08:47 Changeset [80422] by pfeldman@chromium.org

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement): (WebInspector.DOMBreakpointView.prototype._format):

2011-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium rebaseline, flaky test fix.

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/dom-breakpoints.html:
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
08:00 QtWebKitContrib edited by adawit@kde.org
Fixed the git url for the remote add step. (diff)
06:34 Changeset [80421] by caseq@chromium.org

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=54974

Properly serialize test output to fix flakiness due to race with output during page reload.

  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • platform/win/Skipped:
05:42 Changeset [80420] by podivilov@chromium.org

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] pause when script is running is broken.
https://bugs.webkit.org/show_bug.cgi?id=55762

  • inspector/CodeGeneratorInspector.pm:
03:20 Changeset [80419] by loislo@chromium.org

2011-03-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce protocol test for ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=55819

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest._dumpEvent): (initialize_ProtocolTest.InspectorTest._dumpCallArguments): (initialize_ProtocolTest): (initialize_ProtocolTest.):
  • inspector/protocol/console-agent-expected.txt: Added.
  • inspector/protocol/console-agent.html: Added.
  • inspector/protocol/runtime-agent.html:
03:09 Changeset [80418] by abarth@webkit.org

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Rename the action to be friendlier.

  • gyp/JavaScriptCore.gyp:

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Derived Sources to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55813

Adding the derived source action to the GYP file required tweaking
DerivedSources.make. I'm not sure how DerivedSources.make worked
before beause these paths were incorrectly based.

  • DerivedSources.make:
  • gyp/generate-derived-sources.sh: Added.
  • gyp/WebCore.gyp:
03:07 Changeset [80417] by caseq@chromium.org

2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: install onerror handler in inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55690

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.onError):
  • http/tests/inspector/resources/extension-main.js: (onError):
02:09 Changeset [80416] by pfeldman@chromium.org

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

  • Timeline now uses instrumentation calls, not UI representation while collecting events for tests
  • No reloads in debugger tests that don't need them
  • Forcing layout in timeline via calculating offsetHeight
  • http/tests/inspector/inspector-test.js:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/resources/syntax-error.html: Added.
  • inspector/debugger/resources/syntax-error.js: Removed.
  • inspector/elements/elements-panel-limited-children-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/timeline/timeline-layout.html:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline.addRecord): (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords):
  • inspector/timeline/timeline-trivial.html:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix layout tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55816

  • Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
  • Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::issueEvaluateForTestCommands):
  • inspector/InspectorAgent.h:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord):
  • inspector/front-end/inspector.js: (WebInspector.dispatch):
01:50 Changeset [80415] by abarth@webkit.org

2011-03-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should generate fewer than 10,000 compile errors per file
https://bugs.webkit.org/show_bug.cgi?id=55810

This patch adds some missing include paths. We need to figure out how
to handle separate include paths per port. It's clear that
ForwardingHeaders are only useful for Mac, but it's less clear how to
handle the others.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
01:20 Changeset [80414] by mitz@apple.com

<rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
https://bugs.webkit.org/show_bug.cgi?id=55817

Reviewed by Cameron Zwarich.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
a CGFont obtained from Core Text for the primary font. This CGFont may be different from
the CGFont stored in the FontPlatformData.

00:48 Changeset [80413] by ossy@webkit.org

Unreviewed.

[Qt] Add fast/forms/onchange-setvalueforuser.html to the Skipped
list because of missing layoutTestController.setValueForUser()

  • platform/qt/Skipped:
00:09 Changeset [80412] by commit-queue@webkit.org

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • fast/forms/onchange-change-type-expected.txt: Added.
  • fast/forms/onchange-change-type.html: Added.
  • fast/forms/onchange-setvalueforuser-expected.txt: Added.
  • fast/forms/onchange-setvalueforuser.html: Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused.
Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

Test: fast/forms/onchange-change-type.html
Test: fast/forms/onchange-setvalueforuser.html

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/Element.h: (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added. (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag. (WebCore::HTMLInputElement::setValue):

For a focused text field, dispatch an input event, but delay the change event until the field loses focus.

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::subtreeHasChanged):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::WMLInputElement): (WebCore::WMLInputElement::defaultEventHandler):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added. (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
  • DOM/WebDOMOperationsPrivate.h:
  • WebView/WebViewInternal.h:

2011-03-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::setValue() should schedule change event when the element is focused
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53160

  • DumpRenderTree/LayoutTestController.cpp: (setValueForUserCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setValueForUser): Stubbed out; need real implementation.

03/04/11:

23:43 Changeset [80411] by commit-queue@webkit.org

2011-03-04 Victoria Kirst <vrk@google.com>

Reviewed by Eric Carlson.

[chromium] Baselines for media GPU layout tests
https://bugs.webkit.org/show_bug.cgi?id=55796

Adding baselines for some of the media GPU layout tests.
Updates test_expectations with expected media GPU failures.

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-zoom-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-mac/media/video-zoom-expected.png: Added.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png: Added.
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png: Added.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png: Added.
  • platform/chromium-gpu-win/media/video-zoom-expected.checksum: Added.
  • platform/chromium-gpu-win/media/video-zoom-expected.png: Added.
  • platform/chromium/test_expectations.txt:
23:08 Changeset [80410] by commit-queue@webkit.org

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Add a test to ensure SVGImage won't cause ResourceLoader leaks.
https://bugs.webkit.org/show_bug.cgi?id=55017

  • fast/images/svg-image-leak-loader-expected.txt: Added.
  • fast/images/svg-image-leak-loader.html: Added.
  • fast/images/resources/load-script.html: Added.

2011-03-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Remove fake request loading of SVGImage to avoid MainResourceLoader
leak. The frame->init() already ensures initialization of the
document loader.

https://bugs.webkit.org/show_bug.cgi?id=55017

Test: fast/images/svg-image-leak-loader.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
22:32 Changeset [80409] by commit-queue@webkit.org

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

  • platform/chromium/test_expectations.txt:

2011-03-04 Mike Reed <reed@google.com>

Reviewed by Mihai Parparita.

[Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=49477

  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::addArc):
22:12 Changeset [80408] by commit-queue@webkit.org

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html

Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
to convert the bounding box to window coordinate using ScrollView::contentToWindow().

  • dom/Range.cpp: (WebCore::Range::getBoundingClientRect): (WebCore::Range::boundingRect):
  • dom/Range.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::windowRectForRange):
  • editing/Editor.h:
  • manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
  • manual-tests/autocorrection/document-for-iframe-test.html: Added.

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717
<rdar://problem/9018127>

With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
is already in window coordinate. We don't need to do further conversion anymore.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::showCorrectionPanel):
22:02 Changeset [80407] by commit-queue@webkit.org

2011-03-04 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Need symbian version of cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=55782

Implement Symbian version of cryptographicallyRandomValuesFromOS

  • wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
21:41 Changeset [80406] by simonjam@chromium.org

2011-03-04 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Test that scripts with unknown types aren't loaded.
https://bugs.webkit.org/show_bug.cgi?id=51760

  • fast/dom/HTMLScriptElement/dont-load-unknown-type-expected.txt: Added.
  • fast/dom/HTMLScriptElement/dont-load-unknown-type.html: Added.
21:20 Changeset [80405] by commit-queue@webkit.org

2011-03-04 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
https://bugs.webkit.org/show_bug.cgi?id=55731

No new tests. There's no behavioral change.

This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().

  • editing/Editor.cpp: (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
20:27 Changeset [80404] by commit-queue@webkit.org

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Add test case for (non-)premultiplied-alpha compositing.

  • compositing/webgl/webgl-nonpremultiplied-blend.html: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.checksum: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:

2011-03-04 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

[chromium] premultipliedAlpha WebGL context attribute is ignored.
https://bugs.webkit.org/show_bug.cgi?id=55411

Update compositor to set the blending of each layer correctly.

Test: compositing/webgl/webgl-nonpremultiplied-blend.html

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):
19:58 Changeset [80403] by jhoneycutt@apple.com

WK2 Mac build fix.

  • UIProcess/API/C/WKPage.cpp:

(WKPageComputePagesForPrinting):
(WKPageBeginPrinting):

  • UIProcess/API/C/WKPagePrivate.h:
18:34 Changeset [80402] by jhoneycutt@apple.com

WK2 Mac build fix.

  • UIProcess/API/C/WKPagePrivate.h:
17:54 Changeset [80401] by jberlin@webkit.org

[Snow Leopard Release Tests] accessibility/plugin.html,
compositing/geometry/empty-embed-rects.html, and fast/loader/loadInProgress.html timing out.
https://bugs.webkit.org/show_bug.cgi?id=55805
https://bugs.webkit.org/show_bug.cgi?id=55807
https://bugs.webkit.org/show_bug.cgi?id=55808

Unreviewed. Add these tests to the Snow Leopard skipped list to get the bots green.

  • platform/mac-snowleopard/Skipped:
17:48 Changeset [80400] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should link with the correct frameworks
https://bugs.webkit.org/show_bug.cgi?id=55804

  • gyp/WebCore.gyp:
17:44 Changeset [80399] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should Check For Inappropriate Files in Framework
https://bugs.webkit.org/show_bug.cgi?id=55806

  • gyp/WebCore.gyp:
17:21 Changeset [80398] by jhoneycutt@apple.com

WK2 needs printing support on Windows
https://bugs.webkit.org/show_bug.cgi?id=55800
<rdar://problem/8903808>

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(ComputedPagesContext::ComputedPagesContext):
(computedPagesCallback):
From the Vector of WebCore::IntRects, build up a Vector of WKRects.
Call the callback, passing these rects and the scale factor.
(printInfoFromWKPrintInfo):
Return a PrintInfo structure from the WKPrintInfo.
(WKPageComputePagesForPrinting):
Call WebPageProxy::computePagesForPrinting(). Pass
computedPagesCallback as the callback function, so that we can
translate the WebCore rect type to WKRect before calling the caller's
callback function.
(WKPageBeginPrinting):
Call WebPageProxy::beginPrinting().
(WKPageDrawPagesToPDF):
Call WebPageProxy::drawPagesToPDF().

  • UIProcess/API/C/WKPagePrivate.h:

Declare the WKPrintInfo type and new functions.

  • UIProcess/WebPageProxy.cpp:

Compile this code on Windows.

  • UIProcess/WebPageProxy.h:

Ditto.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::paint):
We're painting the window; leave printing mode.

  • WebProcess/WebPage/WebPage.cpp:

Compile this code on Windows.

  • WebProcess/WebPage/WebPage.h:

Ditto.

  • WebProcess/WebPage/WebPage.messages.in:

Ditto.

17:15 Changeset [80397] by barraclough@apple.com

Bug 54945 - The web page hangs towards the end of page load in Interpreter enabled javascript code in the latest webkit trunk.

Rubber stamped by olliej.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

(1) don't infinite loop.
(2) goto 1.

17:08 Changeset [80396] by barraclough@apple.com

cmake build fix.

  • CMakeLists.txt:
17:07 Changeset [80395] by sfalken@apple.com

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Calculate the WebKit version for the useragent via autoversion.h
instead of reading it back from the DLL.


We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

  • WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
  • WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
  • WebView.cpp: (WebView::standardUserAgentWithApplicationName): Use BUILD_NUMBER_SHORT for the version. (osVersion): Removed

2011-03-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021320>

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

Fetch the WebKit version from a string resource instead of the version resource.

  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::userVisibleWebKitVersionString): Fetch version from a string resource.
  • win/WebKit2.rc: Removed version, added stringtable.
  • win/WebKit2WebProcess.rc: Removed.
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessPostBuild.cmd: Don't run autoversion script. It isn't used in this project.
  • win/WebKit2WebProcessPreBuild.cmd: Stamp version.
  • win/WebKitPostBuild.cmd: Stamp version.
16:58 Changeset [80394] by jeffm@apple.com

Add WKPageValidateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55793

Reviewed by Darin Adler.

On the Mac, validation of edit menu commands is handled within WebKit2 in WKView.mm.
However, on Windows we need to do this in the client, so expose this functionality
in the API via WKPageValidateCommand().

Change the Mac implementation to call WebPageProxy::validateCommand() with a callback
to match this new API, so it no longer has to go through PageClient to get notified
when a command is validated. This makes PageClient::setEditCommandState() obsolete,
so I removed the stub implementations in qt and gtk as well.

  • UIProcess/API/C/WKPage.cpp:

(WKPageValidateCommand): Added.

  • UIProcess/API/C/WKPage.h: Added WKPageValidateCommand().
  • UIProcess/API/mac/PageClientImpl.h: Removed setEditCommandState().
  • UIProcess/API/mac/PageClientImpl.mm: Removed setEditCommandState().
  • UIProcess/API/mac/WKView.mm:

(validateCommandCallback): Added.
(-[WKView validateUserInterfaceItem:]): Pass callback to validateCommand().

  • UIProcess/API/qt/qwkpage.cpp: Removed setEditCommandState().
  • UIProcess/API/qt/qwkpage_p.h: Removed setEditCommandState().
  • UIProcess/PageClient.h: Removed setEditCommandState().
  • UIProcess/WebPageProxy.cpp: Removed didValidateCommand().

(WebKit::WebPageProxy::validateCommand): This now takes a callback.
(WebKit::WebPageProxy::validateCommandCallback): Added.
(WebKit::WebPageProxy::processDidCrash): Invalidate m_validateCommandCallbacks.

  • UIProcess/WebPageProxy.h: Removed didValidateCommand(), validateCommand() now takes a callback.

(WebKit::ValidateCommandCallback::create): Added.
(WebKit::ValidateCommandCallback::~ValidateCommandCallback): Added.
(WebKit::ValidateCommandCallback::performCallbackWithReturnValue): Added.
(WebKit::ValidateCommandCallback::invalidate): Added.
(WebKit::ValidateCommandCallback::ValidateCommandCallback): Added.

  • UIProcess/WebPageProxy.messages.in: Removed DidValidateCommand, added ValidateCommandCallback.
  • UIProcess/gtk/WebView.cpp: Removed setEditCommandState().
  • UIProcess/gtk/WebView.h: Removed setEditCommandState().
  • UIProcess/win/WebView.cpp: Removed setEditCommandState().
  • UIProcess/win/WebView.h: Removed setEditCommandState().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::validateCommand): This now takes a callbackID.

  • WebProcess/WebPage/WebPage.h: validateCommand now takes a callbackID.
  • WebProcess/WebPage/WebPage.messages.in: ValidateCommand now takes a callbackID.
16:55 Changeset [80393] by abarth@webkit.org

2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

  • Source/gyp/configure: Added WebCore.

2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

This doesn't yet build, but the basic structure is there.

  • WebCore.gypi: Added headers and include directories variables.
  • gyp/WebCore.gyp: Added.
16:35 Changeset [80392] by bweinstein@apple.com

Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong
https://bugs.webkit.org/show_bug.cgi?id=53919
<rdar://problem/8966020>

Reviewed by Darin Adler.

Adopt the result of m_client.willSendRequestForFrame (which will be leaked by the client).

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):

16:23 Changeset [80391] by darin@apple.com

2011-03-04 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

WebKit2 session state should include even loads too new to be in the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=55781
part of <rdar://problem/8968847>

  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::sessionStateData): Save URLs that are early enough in the loading process to not be included in the back/forward list yet: The pending API request URL and the provisional URL. (WebKit::WebPageProxy::restoreFromSessionStateData): Call loadURL if the back/forward list is not restored and a URL is present. Later we can improve the way we handle the case where we have both a back/forward list and a URL.
16:19 Changeset [80390] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add Copy Files step to JavaScriptCore GYP build for apitest and minidom
https://bugs.webkit.org/show_bug.cgi?id=55798

16:16 Changeset [80389] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

  • WebKit.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unneeded round-trips through ../Source in the Chromium GYP build
https://bugs.webkit.org/show_bug.cgi?id=55795

This is just cleanup work, but it was bugging me.

  • WebCore.gyp/WebCore.gyp:
16:13 Changeset [80388] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add a basic configure script for the GYP build
https://bugs.webkit.org/show_bug.cgi?id=55791

This script just calls GYP on the various gyp projects. As we add more
build systems, this script should be able to select which of them you'd
like to generate the project for.

  • Source/gyp/configure: Added.
16:11 Changeset [80387] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

This file contains GYP declarations that are shared by all the modules.
Currently, we use this to set up the configurations, albeit primitively.

  • Source/gyp/common.gypi: Added.

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

  • gyp/JavaScriptCore.gyp:

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Use target_defaults to reduce boilerplate in GYP build system
https://bugs.webkit.org/show_bug.cgi?id=55790

Instead of setting up the configuration in each target, just defer to
target_defaults. Also, removed a define that was redundant with the
xcconfig.

  • gyp/JavaScriptGlue.gyp:
16:00 Changeset [80386] by jamesr@google.com

2011-03-04 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Option to use skia's native text drawing APIs when drawing text
on Windows, rather than from outlines using drawPath(). This will
only have a significant effect when the skia-gpu backend is enabled.
https://bugs.webkit.org/show_bug.cgi?id=55609

No new tests. This is disabled by default. When enabled, it will draw
essentially the same, but with slightly different antialiased edges, due
to differences between the current scanconverter and GDI's font scaler.
When enabled, we will have to recalibrate layouttest image results.

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText): (WebCore::setupPaintForFont): (WebCore::paintSkiaText):
15:59 Changeset [80385] by tonyg@chromium.org

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

[chromium] Fail new test for JSC feature introduced by r80378
https://bugs.webkit.org/show_bug.cgi?id=55801

  • platform/chromium/test_expectations.txt:
15:57 Changeset [80384] by enne@google.com

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Turn on pixel tests for huge-layer-img.html for better test coverage.
https://bugs.webkit.org/show_bug.cgi?id=55679

Also, modify this test to be more pixel test friendly.

  • compositing/tiling/huge-layer-img-expected.checksum: Added.
  • compositing/tiling/huge-layer-img-expected.png: Added.
  • compositing/tiling/huge-layer-img-expected.txt: Added.
  • compositing/tiling/huge-layer-img.html:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Removed.

2011-03-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix texture stride issues on large content and image layers.
https://bugs.webkit.org/show_bug.cgi?id=55679

This was an error caused during the refactoring in r80081.

Tests: LayoutTests/compositing/tiling/huge-layer-img.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateTexture):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureIfNeeded):
15:38 Changeset [80383] by tonyg@chromium.org

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80379.
http://trac.webkit.org/changeset/80379
https://bugs.webkit.org/show_bug.cgi?id=55799

"Breaks leopard compile (implicit conversion)" (Requested by
tonyg-cr on #webkit).

  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
15:36 Changeset [80382] by mrowe@apple.com

<rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc

Reviewed by Alexey Proskuryakov.

GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.

  • DumpRenderTree/mac/CheckedMalloc.cpp:

(protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
(makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
and then restore the initial protection flags when we're done.

15:09 Changeset [80381] by jberlin@webkit.org

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Darin Adler.

Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.

Source/WebCore:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):

  • platform/network/mac/ResourceRequestMac.mm:

Source/WebKit2:

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

15:07 Changeset [80380] by commit-queue@webkit.org

2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>

Reviewed by Darin Adler.

improve layout performance by reducing the traversal time of the floating objects
https://bugs.webkit.org/show_bug.cgi?id=55440

We observered large overhead on traversing the floating objects list
in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
when the list becomes enormous, for example in the default 30x30 maze test
from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
there're >3700 floating objects. When placing a new floating object the
entire list (from begin to end) is traversed for multiple times.
There's a low hanging fruit to reduce the chances to do the traversal
which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
As the two routines either cares about FloatLeft objects or FloatRight objects only,
if we know there's no corresponding type floating objects in the list
we can avoid the traversal actually. One thing we could do is to record
the number of FloatLeft objects and the number of FloatRight objects and
add a check before doing the traversal. This can reduce the time by 45%
to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
Chromium browser 11 (from 503s to 269s).

No new tests, relying on existing layout tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::addOverflowFromFloats): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::removeFloatingObjectsBelow): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::positionNewFloatOnLine): (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::nextFloatLogicalBottomBelow): (WebCore::RenderBlock::lowestFloatLogicalBottom): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats): (WebCore::RenderBlock::containsFloat): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::FloatingObjects::clear): (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount): (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::FloatingObjects::FloatingObjects): (WebCore::RenderBlock::FloatingObjects::hasLeftObjects): (WebCore::RenderBlock::FloatingObjects::hasRightObjects): (WebCore::RenderBlock::FloatingObjects::set):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine):
15:05 Changeset [80379] by commit-queue@webkit.org

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-03-04 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
14:34 Changeset [80378] by barraclough@apple.com

Bug 55736 - Implement seal/freeze/preventExtensions for normal object types.
Provide basic functionallity from section 15.2.4 of ECMA-262.
This support will need expanding to cover arrays, too.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Shows a 0.5% progression on SunSpidey, this seems to be due to changing
ObjectConstructor to use a static table.

(JSC::ExecState::objectConstructorTable):

Add a static table for ObjectConstructor.

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

Add a static table for ObjectConstructor.

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

Add a static table for ObjectConstructor.

  • runtime/JSObject.cpp:

(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):

Transition the object's structure.

(JSC::JSObject::defineOwnProperty):

Check isExtensible.

  • runtime/JSObject.h:

(JSC::JSObject::isSealed):
(JSC::JSObject::isFrozen):
(JSC::JSObject::isExtensible):

These wrap method on structure.

(JSC::JSObject::putDirectInternal):

Check isExtensible.

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):

Change ObjectConstructor to use a static table.

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

Add new methods on Object.

  • runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

init/propagate m_preventExtensions

(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):

transition the structure, materializing the property map, setting m_preventExtensions & changing attributes.

(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):

check attributes to detect if object is sealed/frozen.

  • runtime/Structure.h:

(JSC::Structure::isExtensible):

checks the m_preventExtensions flag.

LayoutTests:

Update results - many more tests PASS.
Also adds a new testcase.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • ietestcenter/Javascript/15.2.3.10-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.10-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-26-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-27-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.11-4-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-26-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-27-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.12-3-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-0-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-10-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-11-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-12-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-13-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-14-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-15-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-16-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-17-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-18-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-19-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-3-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-7-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-8-expected.txt:
  • ietestcenter/Javascript/15.2.3.13-2-9-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-4-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-5-expected.txt:
  • ietestcenter/Javascript/15.2.3.14-2-6-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-20-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-21-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-22-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-23-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-24-expected.txt:
  • ietestcenter/Javascript/15.2.3.3-4-25-expected.txt:
  • ietestcenter/Javascript/15.2.3.4-4-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.6-4-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.8-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-0-1-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-0-2-expected.txt:
  • ietestcenter/Javascript/15.2.3.9-1-expected.txt:
14:08 Changeset [80377] by sfalken@apple.com

Fix ChangeLog

14:07 Changeset [80376] by evan@chromium.org

2011-03-04 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[gdb] pretty-print KURL in gdb
https://bugs.webkit.org/show_bug.cgi?id=55788

  • gdb/webkit.py: extend the pretty-printers to print WTF::CString and KURLGooglePrivate. As always, "p/r" can be used to sidestep pretty-printing.
14:06 Changeset [80375] by sfalken@apple.com

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784

Reviewed by NOBODY Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

  • WebCore.vcproj/QTMovieWin.rc: Removed.
  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
  • WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
  • WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
14:05 Changeset [80374] by sfalken@apple.com

Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
<rdar://problem/9021273>

Reviewed by Jon Honeycutt.

We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.

14:03 Changeset [80373] by pfeldman@chromium.org

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to 80355, fixing Qt tests.

  • http/tests/inspector/inspector-test.js:
13:59 Changeset [80372] by mihaip@chromium.org

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard rebaseline.

Rebaseline fast/blockflow.

  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum.
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium/test_expectations.txt:
13:28 Changeset [80371] by commit-queue@webkit.org

2011-03-04 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

Clarify comment about potential memory leak in SVGImage
https://bugs.webkit.org/show_bug.cgi?id=55362

No functionality change. No new tests.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:37 Changeset [80370] by jberlin@webkit.org

WebKit2: Use CFNetwork Sessions API.
https://bugs.webkit.org/show_bug.cgi?id=55435.

Reviewed by Maciej Stachowiak.

When Private Browsing is enabled, get the cached url response from the cache associated with
the Private Browsing Storage Session.

Source/WebCore:

  • WebCore.exp.in:

Export the symbol for ResourceHandle::privateBrowsingStorageSession.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

Source/WebKit2:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the response.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformHasLocalDataForURL):
If Private Browsing is enabled, call into WKSI to get the CFURLCacheRef.
(WebKit::WebPage::cachedResponseMIMETypeForURL):
Ditto.

WebKitLibraries:

Update WebKitSystemInterface headers and libraries with the new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
12:30 Changeset [80369] by mdelaney@apple.com

2011-03-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Incorrect location for expected result for 2d.line.cap.closed.html
https://bugs.webkit.org/show_bug.cgi?id=55637

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt.
  • platform/mac/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
11:21 Changeset [80368] by abarth@webkit.org

2011-03-04 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore GYP build should use a header map
https://bugs.webkit.org/show_bug.cgi?id=55712

This patch moves the os-win32 files into their own variable so that we
can use a header map in the Apple Mac Xcode build. The problem is that
the header map searches the whole project rather than just the files
included in a given target. Another solution to this problem is to
make GYP smarter about filtering out what files are added to the
project file.

11:17 Changeset [80367] by steveblock@google.com

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JSC and V8 versions of Java bridge should share JobjectWrapper
https://bugs.webkit.org/show_bug.cgi?id=55763

No new tests, refactoring only.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JobjectWrapper.cpp: (JobjectWrapper::JobjectWrapper): (JobjectWrapper::~JobjectWrapper):
  • bridge/jni/JobjectWrapper.h: (JSC::Bindings::JobjectWrapper::instance): (JSC::Bindings::JobjectWrapper::setInstance): (JSC::Bindings::JobjectWrapper::ref): (JSC::Bindings::JobjectWrapper::deref):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaArray::JavaArray):
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::JavaInstance):
  • bridge/jni/jsc/JavaInstanceJSC.h:
10:32 Changeset [80366] by mihaip@chromium.org

2011-03-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add one expected failure for Snow Leopard, make other failure lines
more specific (since the tests pass on SL) and remove some flaky test
entries for tests that are no longer flaky.

  • platform/chromium/test_expectations.txt:
10:08 Changeset [80365] by jeffm@apple.com

2011-03-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Move WKViewExecuteCommand() to WKPageExecuteCommand()
https://bugs.webkit.org/show_bug.cgi?id=55744


Executing a command operates on a page, so it makes more sense for it to be in WKPage.
This also makes it available on all platforms, not just Windows.

  • UIProcess/API/C/WKPage.cpp: (WKPageExecuteCommand): Added.
  • UIProcess/API/C/WKPage.h: Add WKPageExecuteCommand().
  • UIProcess/API/C/win/WKView.cpp: Remove WKViewExecuteCommand().
  • UIProcess/API/C/win/WKView.h: Remove WKViewExecuteCommand().
10:08 Changeset [80364] by tonyg@chromium.org

2011-03-04 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

[chromium] Rebaseline to match r80351
https://bugs.webkit.org/show_bug.cgi?id=55783

  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
09:55 Changeset [80363] by jberlin@webkit.org

[Windows 7 WebKit2 Release Tests] fast/frames/iframe-plugin-load-remove-document-crash.html
and platform/win/plugins/get-value-netscape-window.html crashing.
https://bugs.webkit.org/show_bug.cgi?id=55778
https://bugs.webkit.org/show_bug.cgi?id=55780

Unreviewed. Add these tests to the Windows WebKit2 Skipped list to get the bots green.

  • platform/win-wk2/Skipped:
09:38 Changeset [80362] by paroga@webkit.org

2011-03-04 Patrick Gansterer <paroga@webkit.org>

Reviewed by Nikolas Zimmermann.

Move shared code into SVGStyledTransformableElement::svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=55771

All sub classes of SVGStyledTransformableElement request a relayout
the same way. So move that code into the common base class.

  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
09:32 QtWebKitReleases edited by ademar.reis@openbossa.org
minor (diff)
09:22 Changeset [80361] by jam@chromium.org

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

  • DEPS:
  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp:

2011-03-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
https://bugs.webkit.org/show_bug.cgi?id=55748

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
09:22 Changeset [80360] by philn@webkit.org

2011-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/audio-repaint.html times out
https://bugs.webkit.org/show_bug.cgi?id=55761

  • media/audio-repaint.html: Register the seeked event listener before performing the seek and thus avoid a timeout of the test.
09:20 Changeset [80359] by mitz@apple.com

LLVM Compiler build fix.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

09:19 QtWebKitReleases edited by ademar.reis@openbossa.org
misc fixes + a section about the qtwebkit/tools used for … (diff)
08:46 Changeset [80358] by timothy@apple.com

Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).

Reviewed by Darin Adler.

  • WebCore.exp.in: Added ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.

Source/WebKit2: Make the WKPageRunJavaScriptFunction callback take a WKSerializedScriptValueRef.

https://webkit.org/b/55623

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.

  • UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.

  • UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
  • UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.

Tools: Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.

Reviewed by Darin Adler.

  • TestWebKitAPI/JavaScriptTest.cpp:

(TestWebKitAPI::javaScriptCallback):

  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:

(TestWebKitAPI::didRunJavaScript):

  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::nullJavaScriptCallback):

  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:

(TestWebKitAPI::didRunJavaScript):

08:46 Changeset [80357] by timothy@apple.com

Make run-api-tests show failed if a test fails.

https://webkit.org/b/55725

Reviewed by Sam Weinig.

  • Scripts/run-api-tests:

(runTest): Remove "my" from the nested $result assignment so the
check outside the condition sees the real result.

08:40 Changeset [80356] by podivilov@chromium.org

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
  • inspector/debugger/debug-inlined-scripts.html:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-pause-on-breakpoint.html:
  • inspector/debugger/source-frame.html:

2011-03-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract all code that depends on source mapping from SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=55464

Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
to encapsulate source mapping aspects from SourceFrame.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.SourceFrameDelegateForResourcesPanel): (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._doubleClick): (WebInspector.SourceFrame.prototype._didEditLine): (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.requestContent): (WebInspector.SourceFrameDelegate.prototype.debuggingSupported): (WebInspector.SourceFrameDelegate.prototype.setBreakpoint): (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint): (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint): (WebInspector.SourceFrameDelegate.prototype.continueToLine): (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource): (WebInspector.SourceFrameDelegate.prototype.editScriptSource): (WebInspector.SourceFrameDelegate.prototype.debuggerPaused): (WebInspector.SourceFrameDelegate.prototype.evaluate): (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
08:37 Changeset [80355] by caseq@chromium.org

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Use internal ids for resources in extension server.
Log errors in inspector tests.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources
https://bugs.webkit.org/show_bug.cgi?id=55686

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.consoleOutputHook):

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
https://bugs.webkit.org/show_bug.cgi?id=55686

  • Use internal ids for resources in extension server.
  • Log errors in inspector tests.
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.resetResources): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._resourceId): (WebInspector.ExtensionServer.prototype._resourceById):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._reset):
08:25 Changeset [80354] by caseq@chromium.org

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: exceptions when building context menu in network panel
https://bugs.webkit.org/show_bug.cgi?id=55678

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.dataGridNodeFromNode): (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
08:07 Changeset [80353] by commit-queue@webkit.org

2011-03-04 Ilya Sherman <isherman@chromium.org>

Reviewed by James Robinson.

Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
is a FramelessScrollView -- which is mostly just for Autofill.
In service of http://crbug.com/73772 (crash)
https://bugs.webkit.org/show_bug.cgi?id=55557

No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
In particular, DRT crashes when trying to render a FramelessScrollView.

  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner(). (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
  • platform/chromium/FramelessScrollView.cpp: (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromium.h:
07:59 Changeset [80352] by commit-queue@webkit.org

2011-03-04 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=55667

  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get): only style is fixed
  • ewk/ewk_settings.h:
07:26 Changeset [80351] by pfeldman@chromium.org

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix inspector test flake.

  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-network-resource.html:
07:15 Changeset [80350] by yurys@chromium.org

2011-03-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=55770

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didCommitLoad):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorCSSAgent): (WebCore::InstrumentingAgents::setInspectorCSSAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
07:09 Writing Layout Tests for DumpRenderTree edited by playmobil@google.com
Add links to view LayoutTest files in trac . (diff)
07:05 Changeset [80349] by loislo@chromium.org

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
https://bugs.webkit.org/show_bug.cgi?id=55773

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::releaseObjectGroup):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._hidePopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
06:51 Changeset [80348] by podivilov@chromium.org

2011-03-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Gutter height should be 100% when few lines are displayed
https://bugs.webkit.org/show_bug.cgi?id=55574

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
  • inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents .inner-container): (.webkit-line-number):
06:40 Changeset [80347] by podivilov@chromium.org

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Do bisect to find visible chunks
https://bugs.webkit.org/show_bug.cgi?id=55685

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.get offsetTop): (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange): (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
06:20 Changeset [80346] by podivilov@chromium.org

2011-03-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] DOMNodeRemoved events are missing
https://bugs.webkit.org/show_bug.cgi?id=55769

05:26 Changeset [80345] by loislo@chromium.org

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/report-protocol-errors-expected.txt:

2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove unnecessary domain and success flags from the response messages.
https://bugs.webkit.org/show_bug.cgi?id=55768

We have domain property in the response messages but it is not used because we dispatch
the responses on the callback associated with seq.

If we have property 'errors' in the response then success eq false and true in the other case.

  • inspector/CodeGeneratorInspector.pm:
05:18 Changeset [80344] by christian@webkit.org

Enable Copy Image Address context menu item in the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=55136

Reviewed by Gustavo Noronha Silva.

  • page/ContextMenuController.cpp:
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
04:37 Changeset [80343] by ossy@webkit.org

Unreviewed.

[Qt] Two http auth tests fail with Qt 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=55767

Add failing tests to the Skipped list to make buildbot happy.

  • platform/qt/Skipped: Add http/tests/appcache/auth.html and http/tests/xmlhttprequest/basic-auth.html.
03:16 Changeset [80342] by pfeldman@chromium.org

2011-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement getCompletions via evaluate.
https://bugs.webkit.org/show_bug.cgi?id=55759

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
03:11 Changeset [80341] by loislo@chromium.org

2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482

  • http/tests/inspector/protocol-test.js: Added. (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpStepResult): (initialize_ProtocolTest.InspectorTest._runNextStep): (initialize_ProtocolTest.InspectorTest.runProtocolTestSuite): (initialize_ProtocolTest):
  • inspector/protocol/runtime-agent-expected.txt: Added.
  • inspector/protocol/runtime-agent.html: Added.
02:13 SuccessfulPortHowTo edited by vikasdalal111@yahoo.co.in
(diff)
02:06 Changeset [80340] by morrita@google.com

2011-03-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
https://bugs.webkit.org/show_bug.cgi?id=55434

Changed WebTask to be a subclass of webkit_support::TaskAdaptor
and passed the object webkit_support::PostDelayedTask directly.

Note that the change keeps postTask() as is because it has a
semantics taht webkit_support::PostDelayedTask() has; It jumps to
the main thread.

  • DumpRenderTree/chromium/Task.cpp: (postDelayedTask):
  • DumpRenderTree/chromium/Task.h: (WebTask::Run):
01:45 Changeset [80339] by steveblock@google.com

2011-03-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

V8 version of JavaString should obtain string from JNI in UTF-16 encoding
https://bugs.webkit.org/show_bug.cgi?id=55566

We obtain the string from JNI in UTF-16 encoding and convert
to UTF-8 using our own routines as required. This matches the
behaviour of the JSC version of JavaString.

No new tests, no change in behaviour.

  • bridge/jni/v8/JavaStringV8.h: (JSC::Bindings::JavaStringImpl::init): (JSC::Bindings::JavaStringImpl::utf8): (JSC::Bindings::JavaStringImpl::impl):
01:40 Changeset [80338] by pfeldman@chromium.org

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::clearFrontend): (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::getDocument): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode): (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setDetachedRoot): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMDispatcher.prototype.documentUpdated):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):

2011-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not push document into front-end, make it request one.
https://bugs.webkit.org/show_bug.cgi?id=55664

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.): (initialize_DebuggerTest):
  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • inspector/console/command-line-api-inspect.html:
  • inspector/elements/dom-agent-query-selector.html:
  • inspector/elements/mutate-unknown-node.html:
  • inspector/styles/styles-new-API.html:
01:26 Changeset [80337] by caseq@chromium.org

2011-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar may overlap content of the network item view
https://bugs.webkit.org/show_bug.cgi?id=55656

  • drop custom summary bar placement logic, do it with CSS instead.
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.resize): (WebInspector.NetworkPanel.prototype._createSummaryBar): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid td): (.network-sidebar tr.filler td): (.network-summary-bar): (.network-sidebar .data-grid .network-summary-bar td): (.network-summary-bar img):
01:04 Changeset [80336] by commit-queue@webkit.org

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.

No intended functionality change.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-03-04 James Su <suzhe@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] keycode is always 0 when using non-Latin keyboard layout.
https://bugs.webkit.org/show_bug.cgi?id=54939

No intended functionality change.

  • src/mac/WebInputEventFactory.mm: (WebKit::windowsKeyCodeForKeyEvent): Use the same implementation provided in WebCore/platform/mac/KeyEventMac.mm.
00:53 Changeset [80335] by paroga@webkit.org

2011-03-04 Patrick Gansterer <paroga@webkit.org>

Unreviewed EFL build fix for r80324.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
00:44 Changeset [80334] by paroga@webkit.org

2011-03-04 Patrick Gansterer <paroga@webkit.org>

Unreviewed EFL build fix for r80324.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
00:38 Changeset [80333] by commit-queue@webkit.org

2011-03-04 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin

Expose ability to create instance of DOMFileSystem from Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=55618

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFileSystem):
  • src/WebFrameImpl.h:
00:28 Changeset [80332] by yurys@chromium.org

2011-03-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AppCache agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55673

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::setFrontend): (WebCore::InspectorApplicationCacheAgent::clearFrontend):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent): (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
00:06 CommitterTips edited by ojan@chromium.org
(diff)
Note: See TracTimeline for information about the timeline view.