Timeline



Mar 15, 2011:

11:59 PM Changeset in webkit [81224] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix bug number typo

  • platform/win/Skipped:
11:54 PM Changeset in webkit [81223] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip an asserting test on Windows

<http://webkit.org/b/56047> tracks the failure.

  • platform/win/Skipped: Added editing/style/iframe-onload-crash.html.
11:46 PM Changeset in webkit [81222] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests
https://bugs.webkit.org/show_bug.cgi?id=56389

Instead of sending one big request populateScriptObjects each agent requests
for initial data in its constructor.

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::getPreferredPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): (WebCore::InspectorDOMAgent::restore):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::isEnabled):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.js:
11:33 PM Changeset in webkit [81221] by levin@chromium.org
  • 3 edits
    10 deletes in trunk/LayoutTests

Fix few more baselines (which the tool didn't handle well before due to them
being in the mac-leopard directory).

svg/w3c due to r81168
svg/custom/mouse due to r81053

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
11:21 PM Changeset in webkit [81220] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Devirtualize isContentEditable and isRichlyContentEditable
https://bugs.webkit.org/show_bug.cgi?id=56421

Rewrote Node::isContentEditable as a non-recursive non-virtual function.

  • dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable.
  • dom/Document.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::isContentEditable): Rewritten.
  • dom/Node.h: (WebCore::Node::isContentEditable): Calls isContentEditable(Editable). (WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable).
  • html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable.
  • html/HTMLElement.h: Ditto.
11:00 PM Changeset in webkit [81219] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Felipe Oliveira da Silva Netto <f.dachshund@gmail.com>

Reviewed by Adam Roben.

Function relativeScriptsDir doesn't return the correct relative
Scripts directory.

  • Scripts/webkitdirs.pm: (relativeScriptsDir): Ensure we use the directory that contains webkitdirs.pm, not the one that contains the original script that was invoked.
10:46 PM Changeset in webkit [81218] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/
https://bugs.webkit.org/show_bug.cgi?id=56412

Yay for smooth sailing.

  • gyp/WebCore.gyp:
10:02 PM Changeset in webkit [81217] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Fisher.

Move isReadOnly() from WebInputElement to WebFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=55760

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::isReadOnly):
  • src/WebInputElement.cpp:
9:13 PM Changeset in webkit [81216] by Dimitri Glazkov
  • 5 edits
    4 adds in trunk

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
https://bugs.webkit.org/show_bug.cgi?id=56059

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics.

  • fast/dom/HTMLInputElement/input-slider-update-styled.html: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.checksum: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.png: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
https://bugs.webkit.org/show_bug.cgi?id=56059

Test: fast/dom/HTMLInputElement/input-slider-update-styled.html

  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromValue): Added. (WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint. (WebCore::SliderThumbElement::setPositionFromPoint): Ditto. (WebCore::SliderThumbElement::defaultEventHandler): Ditto.
  • html/shadow/SliderThumbElement.h: Added decls.
9:04 PM Changeset in webkit [81215] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix following r81213. Same song second verse.

  • platform/image-encoders/skia/PNGImageEncoder.cpp:

(WebCore::encodePixels):

8:59 PM Changeset in webkit [81214] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix for Chromium OSX release build following r81213.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call.

8:26 PM Changeset in webkit [81213] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

2011-03-15 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
https://bugs.webkit.org/show_bug.cgi?id=56238

Add new test from webgl conformance test.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt: Added.
  • fast/canvas/webgl/premultiplyalpha-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Update to fix fillTexture (WebGLTestUtils):
  • platform/chromium/test_expectations.txt:
  • platform/mac-wk2/Skipped:

2011-03-15 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
https://bugs.webkit.org/show_bug.cgi?id=56238

Attempt to get an ImageData (non-premultiplied) from a WebGL canvas
instead of getting an ImageBuffer, so there's a chance the data can be
passed straight through to the consumer with no premultiplication
necessary. Fixes Chromium and Safari.

Test: fast/canvas/webgl/premultiplyalpha-test.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::getImageData):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::readRenderingResults): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): (WebCore::RGBAtoRGB): (WebCore::encodePixels): (WebCore::JPEGImageEncoder::encode):
  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA): (WebCore::encodePixels): (WebCore::PNGImageEncoder::encode):
  • platform/image-encoders/skia/PNGImageEncoder.h:

2011-03-15 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
https://bugs.webkit.org/show_bug.cgi?id=56238

Add support for reading a webgl context into an ImageData.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
  • src/GraphicsContext3DInternal.h:
8:10 PM Changeset in webkit [81212] by kevino@webkit.org
  • 6 edits in trunk

[wx] Build fixes after recent changes.

7:50 PM Changeset in webkit [81211] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r81208 for https://bugs.webkit.org/show_bug.cgi?id=56425

  • loader/icon/IconDatabaseBase.h: #include instead of forward declare.
7:31 PM Changeset in webkit [81210] by levin@chromium.org
  • 9 edits
    28 adds in trunk/LayoutTests

A little more clean-up due to r81168. Also, some adjustment of the results for Linux due to r81162.

  • platform/chromium-mac-leopard/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium/test_expectations.txt:
7:21 PM Changeset in webkit [81209] by Beth Dakin
  • 14 edits in trunk/Source/WebCore

Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas. In
turn, all of the ScrollableArea classes that add themselves to the HashSet must
keep a weak pointer to Page so that they can remove themselves without relying on
Frames or Renderers to still have references.

Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.

  • page/EventHandler.cpp:

(WebCore::layerForNode):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

(WebCore::FrameView::disconnectFromPage):

Add the new ScrollableArea set.

  • page/Page.cpp:

(WebCore::Page::~Page):
(WebCore::Page::addScrollableArea):

7:15 PM Changeset in webkit [81208] by beidson@apple.com
  • 27 edits
    7 adds in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 icon database.

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:

../WebKit2:

Project file paperwork:

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • Scripts/webkit2/messages.py: Special-case capitalization for messages that start with "URL" to be lowercased to "url" instead of "uRL".

Add messaging-related stuff:

  • Platform/CoreIPC/MessageID.h:
  • UIProcess/WebIconDatabase.messages.in: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

Prep to make WebIconDatabase an API object:

  • Shared/APIObject.h:

Add an "icon DB is enabled" flag to WebProcessCreationParameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI for client apps to set the icon database path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetIconDatabasePath):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.h:

(WebKit::WebContext::setIconDatabasePath):

Hook up initialization, clearing, and messaging for the icon database:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::iconDatabasePath):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

Add the UIProcess-side IconDatabase. It will be the "actual database" as well as the API object:

  • UIProcess/WebIconDatabase.cpp: Added.

(WebKit::WebIconDatabase::create):
(WebKit::WebIconDatabase::~WebIconDatabase):
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::invalidate):
(WebKit::WebIconDatabase::retainIconForPageURL):
(WebKit::WebIconDatabase::releaseIconForPageURL):
(WebKit::WebIconDatabase::setIconURLForPageURL):
(WebKit::WebIconDatabase::setIconDataForIconURL):
(WebKit::WebIconDatabase::iconDataForPageURL):
(WebKit::WebIconDatabase::iconURLForPageURL):
(WebKit::WebIconDatabase::iconDataKnownForIconURL):
(WebKit::WebIconDatabase::loadDecisionForIconURL):
(WebKit::WebIconDatabase::didReceiveMessage):
(WebKit::WebIconDatabase::didReceiveSyncMessage):

  • UIProcess/WebIconDatabase.h: Added.

(WebKit::WebIconDatabase::clearContext):
(WebKit::WebIconDatabase::type):

Add the WebProcess-side IconDatabaseProxy. It acts as the WebCore IconDatabase and operates via messaging:

  • WebProcess/IconDatabase: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Added.

(WebKit::WebIconDatabaseProxy::~WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::isEnabled):
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::iconForPageURL):
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::iconURLForPageURL):
(WebKit::WebIconDatabaseProxy::iconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
(WebKit::WebIconDatabaseProxy::urlImportFinished):
(WebKit::WebIconDatabaseProxy::didReceiveMessage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h: Added.

Hook up initialization and messaging for the icon database proxy:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
7:13 PM Changeset in webkit [81207] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Update Qt specific expected results after r80846.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
6:17 PM Changeset in webkit [81206] by weinig@apple.com
  • 1 edit
    1 add in trunk/Tools

Add script to convert a patch to a prettypatch and show in the default browser
https://bugs.webkit.org/show_bug.cgi?id=56416

Reviewed by Darin Adler.

This can be used either like

$ svn-create-patch | show-pretty-diff

or

$ show-pretty-diff patch.diff

  • Scripts/show-pretty-diff: Added.
5:50 PM Changeset in webkit [81205] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-15 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: False SPOD cursor when context menu is open
<rdar://problem/9029154>
https://bugs.webkit.org/show_bug.cgi?id=56433

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showContextMenu): Update to match showPopupMenu idiomatically, and stop the responsivenessTimer since the act of showing the context menu could spin a nested runloop.
  • UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::showContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu):
  • UIProcess/win/WebContextMenuProxyWin.cpp: (WebKit::WebContextMenuProxyWin::showContextMenu): Move isEmpty() check to implementations, since we don't want to show this in any case, not just the one where we check it.
5:48 PM Changeset in webkit [81204] by levin@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r81144.
http://trac.webkit.org/changeset/81144
https://bugs.webkit.org/show_bug.cgi?id=56432

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-15
It broke the ui test
NPAPITesterBase.GetURLRedirectNotification. (Requested by
dave_levin on #webkit).

  • public/WebURLLoader.h:
  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
(WebKit::AssociatedURLLoader::prepareRequest):
(WebKit::AssociatedURLLoader::willSendRequest):
(WebKit::AssociatedURLLoader::didSendData):
(WebKit::AssociatedURLLoader::didReceiveResponse):
(WebKit::AssociatedURLLoader::didDownloadData):
(WebKit::AssociatedURLLoader::didReceiveData):
(WebKit::AssociatedURLLoader::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoader::didFinishLoading):
(WebKit::AssociatedURLLoader::didFail):

  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81203] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build editing, fileapi, history, and html
https://bugs.webkit.org/show_bug.cgi?id=56411

These all went smoothly.

  • gyp/WebCore.gyp:
5:31 PM Changeset in webkit [81202] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build dom/
https://bugs.webkit.org/show_bug.cgi?id=56409

  • gyp/WebCore.gyp:
5:29 PM Changeset in webkit [81201] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build css/
https://bugs.webkit.org/show_bug.cgi?id=56408

CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the
build yet. I've punted on that problem for now, but we'll come back to
it.

  • gyp/WebCore.gyp:
5:26 PM Changeset in webkit [81200] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build bindings/
https://bugs.webkit.org/show_bug.cgi?id=56406

I wanted to include bindings/objc in this patch, but they were somewhat
complicated. It looks like they include headers from the output
directory (via PrivateHeaders), but we haven't wired up the
PrivateHeaders yet.

  • gyp/WebCore.gyp:
5:13 PM Changeset in webkit [81199] by levin@chromium.org
  • 6 edits
    1 move
    14 deletes in trunk/LayoutTests

Update Leopard specific baselines for tests (editing, css) changes due to r80755.
Fix the expectation for input-autofilled.

  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/input-autofilled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/input-autofilled-expected.txt.
  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [81198] by simonjam@chromium.org
  • 20 edits
    2 moves
    5 adds in trunk

2011-03-15 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added test cases for forceAsync.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Ditto.
  • http/tests/misc/script-async-load-execute-in-order-expected.txt: Added.
  • http/tests/misc/script-async-load-execute-in-order.html: Added.

2011-03-15 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

http/tests/misc/script-async-load-execute-in-order.html

  • Android.mk: Rename AsyncScriptRunner -> ScriptRunner.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Ditto. (WebCore::Document::~Document): Ditto.
  • dom/Document.h: (WebCore::Document::scriptRunner): Ditto.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder. (WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes. (WebCore::ScriptElement::prepareScript): Added support for forceAsync. (WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed.
  • dom/ScriptElement.h: (WebCore::ScriptElement::forceAsync): Added.
  • dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp. (WebCore::ScriptRunner::ScriptRunner): Added in-order script queue. (WebCore::ScriptRunner::~ScriptRunner): Ditto. (WebCore::ScriptRunner::executeScriptSoon): (WebCore::ScriptRunner::queueScriptForInOrderExecution): Added. (WebCore::ScriptRunner::suspend): (WebCore::ScriptRunner::resume): (WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready.
  • dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h. (WebCore::ScriptRunner::create): (WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes. (WebCore::HTMLScriptElement::setAsync): Ditto. (WebCore::HTMLScriptElement::async): Include forceAsync in calculation.
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto.
4:59 PM Changeset in webkit [81197] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Removed another deprecatedAppend
https://bugs.webkit.org/show_bug.cgi?id=56429

Patch by Geoffrey Garen <ggaren@apple.com> on 2011-03-15
Reviewed by Oliver Hunt.

  • collector/handles/HandleHeap.cpp:

(JSC::HandleHeap::markStrongHandles):

  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are

marked directly by the Heap.

  • runtime/Heap.cpp:

(JSC::Heap::markRoots): Ditto.

4:59 PM Changeset in webkit [81196] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another deprecatedAppend
https://bugs.webkit.org/show_bug.cgi?id=56429

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles):
  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are marked directly by the Heap.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Ditto.
4:54 PM Changeset in webkit [81195] by Martin Robinson
  • 1 edit
    319 adds in trunk/LayoutTests

2011-03-15 Martin Robinson <mrobinson@igalia.com>

Adding new test results for GTK+.

  • platform/gtk: All files omitted to prevent overflowing the BuildBot console.
4:54 PM Changeset in webkit [81194] by tony@chromium.org
  • 163 edits in trunk/Source

2011-03-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

No new tests, just compressing png files.

  • inspector/front-end/Images/applicationCache.png:
  • inspector/front-end/Images/auditsIcon.png:
  • inspector/front-end/Images/back.png:
  • inspector/front-end/Images/breakpointBorder.png:
  • inspector/front-end/Images/breakpointConditionalBorder.png:
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/breakpointsActivateButtonGlyph.png:
  • inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png:
  • inspector/front-end/Images/checker.png:
  • inspector/front-end/Images/clearConsoleButtonGlyph.png:
  • inspector/front-end/Images/closeButtons.png:
  • inspector/front-end/Images/consoleButtonGlyph.png:
  • inspector/front-end/Images/consoleIcon.png:
  • inspector/front-end/Images/cookie.png:
  • inspector/front-end/Images/database.png:
  • inspector/front-end/Images/databaseTable.png:
  • inspector/front-end/Images/debuggerContinue.png:
  • inspector/front-end/Images/debuggerPause.png:
  • inspector/front-end/Images/debuggerStepInto.png:
  • inspector/front-end/Images/debuggerStepOut.png:
  • inspector/front-end/Images/debuggerStepOver.png:
  • inspector/front-end/Images/disclosureTriangleSmallDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRight.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightWhite.png:
  • inspector/front-end/Images/dockButtonGlyph.png:
  • inspector/front-end/Images/elementsIcon.png:
  • inspector/front-end/Images/enableOutlineButtonGlyph.png:
  • inspector/front-end/Images/enableSolidButtonGlyph.png:
  • inspector/front-end/Images/errorIcon.png:
  • inspector/front-end/Images/errorMediumIcon.png:
  • inspector/front-end/Images/errorRedDot.png:
  • inspector/front-end/Images/excludeButtonGlyph.png:
  • inspector/front-end/Images/focusButtonGlyph.png:
  • inspector/front-end/Images/forward.png:
  • inspector/front-end/Images/frame.png:
  • inspector/front-end/Images/garbageCollectButtonGlyph.png:
  • inspector/front-end/Images/gearButtonGlyph.png:
  • inspector/front-end/Images/glossyHeader.png:
  • inspector/front-end/Images/glossyHeaderPressed.png:
  • inspector/front-end/Images/glossyHeaderSelected.png:
  • inspector/front-end/Images/glossyHeaderSelectedPressed.png:
  • inspector/front-end/Images/goArrow.png:
  • inspector/front-end/Images/graphLabelCalloutLeft.png:
  • inspector/front-end/Images/graphLabelCalloutRight.png:
  • inspector/front-end/Images/helpButtonGlyph.png:
  • inspector/front-end/Images/largerResourcesButtonGlyph.png:
  • inspector/front-end/Images/localStorage.png:
  • inspector/front-end/Images/networkIcon.png:
  • inspector/front-end/Images/nodeSearchButtonGlyph.png:
  • inspector/front-end/Images/paneAddButtons.png:
  • inspector/front-end/Images/paneBottomGrow.png:
  • inspector/front-end/Images/paneBottomGrowActive.png:
  • inspector/front-end/Images/paneGrowHandleLine.png:
  • inspector/front-end/Images/paneSettingsButtons.png:
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png:
  • inspector/front-end/Images/percentButtonGlyph.png:
  • inspector/front-end/Images/popoverArrows.png:
  • inspector/front-end/Images/popoverBackground.png:
  • inspector/front-end/Images/profileGroupIcon.png:
  • inspector/front-end/Images/profileIcon.png:
  • inspector/front-end/Images/profileSmallIcon.png:
  • inspector/front-end/Images/profilesIcon.png:
  • inspector/front-end/Images/profilesSilhouette.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/Images/radioDot.png:
  • inspector/front-end/Images/recordButtonGlyph.png:
  • inspector/front-end/Images/recordToggledButtonGlyph.png:
  • inspector/front-end/Images/reloadButtonGlyph.png:
  • inspector/front-end/Images/resourceCSSIcon.png:
  • inspector/front-end/Images/resourceDocumentIcon.png:
  • inspector/front-end/Images/resourceDocumentIconSmall.png:
  • inspector/front-end/Images/resourceJSIcon.png:
  • inspector/front-end/Images/resourcePlainIcon.png:
  • inspector/front-end/Images/resourcePlainIconSmall.png:
  • inspector/front-end/Images/resourcesIcon.png:
  • inspector/front-end/Images/resourcesSizeGraphIcon.png:
  • inspector/front-end/Images/resourcesTimeGraphIcon.png:
  • inspector/front-end/Images/scriptsIcon.png:
  • inspector/front-end/Images/scriptsSilhouette.png:
  • inspector/front-end/Images/searchSmallBlue.png:
  • inspector/front-end/Images/searchSmallBrightBlue.png:
  • inspector/front-end/Images/searchSmallGray.png:
  • inspector/front-end/Images/searchSmallWhite.png:
  • inspector/front-end/Images/segment.png:
  • inspector/front-end/Images/segmentEnd.png:
  • inspector/front-end/Images/segmentHover.png:
  • inspector/front-end/Images/segmentHoverEnd.png:
  • inspector/front-end/Images/segmentSelected.png:
  • inspector/front-end/Images/segmentSelectedEnd.png:
  • inspector/front-end/Images/sessionStorage.png:
  • inspector/front-end/Images/splitviewDimple.png:
  • inspector/front-end/Images/splitviewDividerBackground.png:
  • inspector/front-end/Images/statusbarButtons.png:
  • inspector/front-end/Images/statusbarMenuButton.png:
  • inspector/front-end/Images/statusbarMenuButtonSelected.png:
  • inspector/front-end/Images/statusbarResizerHorizontal.png:
  • inspector/front-end/Images/statusbarResizerVertical.png:
  • inspector/front-end/Images/successGreenDot.png:
  • inspector/front-end/Images/thumbActiveHoriz.png:
  • inspector/front-end/Images/thumbActiveVert.png:
  • inspector/front-end/Images/thumbHoriz.png:
  • inspector/front-end/Images/thumbHoverHoriz.png:
  • inspector/front-end/Images/thumbHoverVert.png:
  • inspector/front-end/Images/thumbVert.png:
  • inspector/front-end/Images/timelineBarBlue.png:
  • inspector/front-end/Images/timelineBarGray.png:
  • inspector/front-end/Images/timelineBarGreen.png:
  • inspector/front-end/Images/timelineBarOrange.png:
  • inspector/front-end/Images/timelineBarPurple.png:
  • inspector/front-end/Images/timelineBarRed.png:
  • inspector/front-end/Images/timelineBarYellow.png:
  • inspector/front-end/Images/timelineCheckmarks.png:
  • inspector/front-end/Images/timelineDots.png:
  • inspector/front-end/Images/timelineHollowPillBlue.png:
  • inspector/front-end/Images/timelineHollowPillGray.png:
  • inspector/front-end/Images/timelineHollowPillGreen.png:
  • inspector/front-end/Images/timelineHollowPillOrange.png:
  • inspector/front-end/Images/timelineHollowPillPurple.png:
  • inspector/front-end/Images/timelineHollowPillRed.png:
  • inspector/front-end/Images/timelineHollowPillYellow.png:
  • inspector/front-end/Images/timelineIcon.png:
  • inspector/front-end/Images/timelinePillBlue.png:
  • inspector/front-end/Images/timelinePillGray.png:
  • inspector/front-end/Images/timelinePillGreen.png:
  • inspector/front-end/Images/timelinePillOrange.png:
  • inspector/front-end/Images/timelinePillPurple.png:
  • inspector/front-end/Images/timelinePillRed.png:
  • inspector/front-end/Images/timelinePillYellow.png:
  • inspector/front-end/Images/toolbarItemSelected.png:
  • inspector/front-end/Images/trackHoriz.png:
  • inspector/front-end/Images/trackVert.png:
  • inspector/front-end/Images/treeDownTriangleBlack.png:
  • inspector/front-end/Images/treeDownTriangleWhite.png:
  • inspector/front-end/Images/treeRightTriangleBlack.png:
  • inspector/front-end/Images/treeRightTriangleWhite.png:
  • inspector/front-end/Images/treeUpTriangleBlack.png:
  • inspector/front-end/Images/treeUpTriangleWhite.png:
  • inspector/front-end/Images/undockButtonGlyph.png:
  • inspector/front-end/Images/userInputIcon.png:
  • inspector/front-end/Images/userInputPreviousIcon.png:
  • inspector/front-end/Images/userInputResultIcon.png:
  • inspector/front-end/Images/warningIcon.png:
  • inspector/front-end/Images/warningMediumIcon.png:
  • inspector/front-end/Images/warningOrangeDot.png:
  • inspector/front-end/Images/warningsErrors.png:

2011-03-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentHoverChromium.png:
  • src/js/Images/segmentHoverEndChromium.png:
  • src/js/Images/segmentSelectedChromium.png:
  • src/js/Images/segmentSelectedEndChromium.png:
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonSelectedChromium.png:
4:54 PM Changeset in webkit [81193] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some more deprecated / unsafe append
https://bugs.webkit.org/show_bug.cgi?id=56428

  • collector/handles/HandleStack.cpp: (JSC::HandleStack::mark):
  • collector/handles/HandleStack.h: Mark the handle stack using a HeapRoot marker, since it's a heap root.


  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists): (JSC::MarkedArgumentBuffer::slowAppend):
  • runtime/ArgList.h: Ditto.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Added a mark call for marking the handle stack. It seems like Oliver forgot this in his last patch. (!)
  • runtime/MarkStack.h: Removed appendSlots, since it would allow an object to embed JSValues directly instead of using WriteBarrier.

(JSC::MarkStack::append): Added a private append for a list of values.

(JSC::HeapRootMarker::mark): Access to the above.

4:42 PM Changeset in webkit [81192] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-03-15 Martin Robinson <mrobinson@igalia.com>

Rebaseline some GTK+ tests after r81035 and r81049.

  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
4:29 PM Changeset in webkit [81191] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a few more deprecatedAppends, and removed HeapRoot<T>
https://bugs.webkit.org/show_bug.cgi?id=56422


Added HeapRootMarker, a privileged class for marking direct heap roots
that are iterated during each garbage collection. This is easier to use
and more reliable than HeapRoot<T>, so I've removed HeapRoot<T>.

  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/Completion.cpp: (JSC::evaluate): exception is no longer a HeapRoot<T>, so no need to call .get() on it.
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/Heap.h: Updated to use HeapRootMarker.
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::append): Added private functions for HeapRootMarker to use.
  • runtime/JSGlobalData.h: exception is no longer a HeapRoot<T>.
  • runtime/MarkStack.h: (JSC::HeapRootMarker::HeapRootMarker): (JSC::HeapRootMarker::mark): Added private functions for HeapRootMarker to use.
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::markChildren): Updated to use HeapRootMarker.
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings): Updated to use HeapRootMarker.
  • runtime/WriteBarrier.h: Removed HeapRoot<T>.
4:24 PM Changeset in webkit [81190] by Adam Roben
  • 1 edit
    24 adds in trunk/LayoutTests

Update Windows XP results after r81168

They differ from Windows 7 due to different fonts being used.

  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Added.
4:24 PM Changeset in webkit [81189] by bweinstein@apple.com
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

Rubber-stamped by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
4:12 PM Changeset in webkit [81188] by oliver@apple.com
  • 16 edits
    4 adds in trunk/Source/JavaScriptCore

2011-03-15 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Introduce Local<T> to allow us to start moving to precise marking of locals
https://bugs.webkit.org/show_bug.cgi?id=56394

Introduce a new handle type, Local<T> and a scoping mechanism
LocalScope to allow us to start moving towards precise marking
of temporaries and local variables.

We also start to use the new Local<> type in the JSON stringifier
so that we can have some coverage of their behaviour in the initial
checkin.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • collector/handles/Handle.h: (JSC::::asObject):
  • collector/handles/HandleStack.cpp: Added. (JSC::HandleStack::HandleStack): (JSC::HandleStack::mark): (JSC::HandleStack::grow):
  • collector/handles/HandleStack.h: Added. (JSC::HandleStack::enterScope): (JSC::HandleStack::zapTo): (JSC::HandleStack::leaveScope): (JSC::HandleStack::push):
  • collector/handles/Local.h: Added. (JSC::Local::internalSet): (JSC::::Local): (JSC::::operator): (JSC::LocalStack::LocalStack): (JSC::LocalStack::peek): (JSC::LocalStack::pop): (JSC::LocalStack::push): (JSC::LocalStack::isEmpty): (JSC::LocalStack::size):
  • collector/handles/LocalScope.h: Added. (JSC::LocalScope::LocalScope): (JSC::LocalScope::~LocalScope): (JSC::LocalScope::release):
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::allocateLocalHandle): (JSC::Heap::handleStack):
  • runtime/JSCell.h: (JSC::JSCell::::getString):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateLocalHandle):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Stringifier): (JSC::Stringifier::stringify): (JSC::Stringifier::appendStringifiedValue): (JSC::Stringifier::Holder::Holder): (JSC::Walker::Walker): (JSC::Walker::walk): (JSC::JSONProtoFuncParse): (JSC::JSONProtoFuncStringify): (JSC::JSONStringify):
  • runtime/JSONObject.h:
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::appendSlots):
3:58 PM Changeset in webkit [81187] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update Windows results again after r81168

I accidentally copied the Mac results into platform/win for these two tests when I tried to
update results in r81179.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/text/small-fonts-2-expected.txt:
3:55 PM Changeset in webkit [81186] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-15 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian][WK2] Fix exporting and importing the WebProcessMainQt symbol
https://bugs.webkit.org/show_bug.cgi?id=56417

Use the Q_DECL_EXPORT and Q_DECL_IMPORT macros directly to make sure
the symbol is always exported/imported.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
  • qt/MainQt.cpp:
3:37 PM Changeset in webkit [81185] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
https://bugs.webkit.org/show_bug.cgi?id=56372

The bug was caused by insertNodeAfter's calling parentElement on document's child.
Fixed this by changing the node that AppendNodeCommand takes.

There was also a bug that document node always returned false for isContentEditable
and isContentRichlyEditable because they never overrode Node's default implementation.
Fixed this by overriding them in Document.

Test: editing/execCommand/append-node-under-document.html

  • dom/Document.cpp: (WebCore::Document::isContentEditable): Added. (WebCore::Document::isContentRichlyEditable): Added.
  • dom/Document.h:
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
  • editing/AppendNodeCommand.h: (WebCore::AppendNodeCommand::create): Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
  • editing/CompositeEditCommand.h:

2011-03-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
https://bugs.webkit.org/show_bug.cgi?id=56372

Added a test to ensure WebKit does not crash when appending a node to a document
that has only two nested iframes.

  • editing/execCommand/append-node-under-document-expected.txt: Added.
  • editing/execCommand/append-node-under-document.html: Added.
3:32 PM Changeset in webkit [81184] by levin@chromium.org
  • 20 edits
    1 copy
    449 adds
    1 delete in trunk/LayoutTests

Compensate for r81168 (svg) and r81155 (fast/forms/input-autofilled.html) and r81049 (fast/table).
Also, remove the linux debug crashes from test expectations due to r81162 which should clear these up.
Add update baselines for transitions/default-timing-function due to r80806.

  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png: Added.
  • platform/chromium-win/fast/forms/input-autofilled-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-win/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-linux/transitions/default-timing-function-expected.checksum:
  • platform/chromium-linux/transitions/default-timing-function-expected.png:
  • platform/chromium-mac/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-mac/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.checksum:
  • platform/chromium-win/transitions/default-timing-function-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [81183] by Michael Nordman
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

When initiating a main resource load, let the application cache
know which frame the load is being conducted for. This patch doesn't
resolve the following bug, but the additional WebFrame parameter
should provide the chromium port with enough info to pick the
"most appropiate" cached resource.
https://bugs.webkit.org/show_bug.cgi?id=55505

Also fixup a stale comment in stopLoadingInFrame.

  • public/WebApplicationCacheHost.h: (WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource): (WebCore::ApplicationCacheHost::stopLoadingInFrame):
3:26 PM Changeset in webkit [81182] by helder@sencha.com
  • 2 edits in trunk/LayoutTests

2011-03-15 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/canvas-strokeRect-gradient-shadow.html no longer fails
https://bugs.webkit.org/show_bug.cgi?id=56413

Rect stroking uses the same code path as path stroking, which was fixed
in r80250. Therefore, the test can be removed from the Skipped list as
it now succeeds.

  • platform/qt/Skipped:
3:17 PM Changeset in webkit [81181] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-03-15 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
3:02 PM Changeset in webkit [81180] by levin@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-03-15 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

Links from code reviews to trac are incorrect for files in Source/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=56404

  • PrettyPatch/PrettyPatch.rb: Remove WebKit from the list of top level directories since it is now under Source.
2:48 PM Changeset in webkit [81179] by Adam Roben
  • 3 edits
    128 adds in trunk/LayoutTests

Add Windows results for tests added in r81168

The differences from the Mac results seem to be due to rounding and font differences.

  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-query-expected.png: Added.
  • platform/win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/win/svg/text/bidi-tspans-expected.png: Added.
  • platform/win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/win/svg/text/small-fonts-2-expected.checksum: Added.
  • platform/win/svg/text/small-fonts-2-expected.png: Added.
  • platform/win/svg/text/small-fonts-2-expected.txt:
2:42 PM Changeset in webkit [81178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

accessibility should build in WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56405

This patch changes our include/exclude strategy to more closely match
the strategy used by the Chromium GYP build system. Ideally, we'd find
a way to share more of these patterns. In the meantime, I'm going to
slowly increase the number of translation units in the project and
adjust the include/exclude filters appropriately.

  • gyp/WebCore.gyp:
2:42 PM Changeset in webkit [81177] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

Update Gtk baseline.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/gtk/svg/text/text-align-02-b-expected.txt:
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt:
2:39 PM Changeset in webkit [81176] by Nikolas Zimmermann
  • 5 edits
    47 adds in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

Update Mac Leopard baseline.

  • platform/mac-leopard/svg/W3C-I18N: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt:
2:37 PM Changeset in webkit [81175] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
https://bugs.webkit.org/show_bug.cgi?id=56335

Reland with a fix to avoid really long command lines on Windows.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
2:20 PM Changeset in webkit [81174] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Forgot to save a modification to this file when committing.

  • WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2:15 PM Changeset in webkit [81173] by ap@apple.com
  • 25 edits
    2 moves
    2 deletes in trunk

Reviewed by Darin Adler.

REGRESSION (WebKit2): keygen element doesn't work
https://bugs.webkit.org/show_bug.cgi?id=56402
<rdar://problem/9006545>

Covered by existing regresison tests.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in: Removed WebCoreKeyGenerator, which no longer exists. Added _wkSignedPublicKeyAndChallengeString, so that this WKSI function could be used in WebCore.
  • platform/mac/SSLKeyGeneratorMac.mm: Removed.
  • platform/mac/WebCoreKeyGenerator.h: Removed.
  • platform/mac/WebCoreKeyGenerator.m: Removed.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • WebCore.xcodeproj/project.pbxproj: Renamed SSLKeyGeneratorMac.mm to .cpp, as it doesn't use any Objective C any more. Removed WebCoreKeyGenerator, as we no longer need an interface to WebKit.
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName):
  • platform/LocalizedStrings.h: Added strings used by keygen element, now that the code using them is in WebCore.
  • platform/mac/SSLKeyGeneratorMac.cpp: Copied from Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Moved the code from WebKit. There is never any need to provide implementation at runtime, like old code was doing.
  • platform/win/SSLKeyGeneratorWin.cpp: (WebCore::WebCore::getSupportedKeySizes): Added a FIXME about localization. Note that Safari for Windows doesn't support keygen.
2:02 PM Changeset in webkit [81172] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang build.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.h:
1:40 PM Changeset in webkit [81171] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Fix Lion build after r81161.

Pass the PlatformCALayer down into drawLayerContents()
so we can use its acceleratesDrawing() method.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (-[WebLayer drawInContext:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer drawInContext:]):
1:39 PM Changeset in webkit [81170] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

Update Qt baseline, still waiting for gtk/leopard/win7/winxp.

  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/qt/svg/text/text-align-02-b-expected.txt:
  • platform/qt/svg/text/text-align-04-b-expected.txt:
1:17 PM Changeset in webkit [81169] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-15 Alok priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
https://bugs.webkit.org/show_bug.cgi?id=56390

  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId):

2011-03-15 Alok priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
https://bugs.webkit.org/show_bug.cgi?id=56390

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId): (WebKit::WebPluginContainerImpl::platformLayer):
1:15 PM Changeset in webkit [81168] by Nikolas Zimmermann
  • 24 edits
    6 moves
    236 adds in trunk

2011-03-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text. The actual bidi support is working
fine, the problem is that SVG demands to reorder x/y/dx/dy/rotate value lists, in order to
main correspondance between the attributes and the potentially reordered text.

Land a new suite of SVG & i18n tests, covering unicode-bidi/direction and text-anchor support
with BiDi text (Arabic mixed with Latin) in LayoutTests/svg/W3C-I18N.

Enable long-disabled SVG BiDi tests, and international fonts support in svg/W3C-SVG-1.1
by providing a SVGFont replacment, replacing the need for MS Office Fonts to be present.
These tests have some value and we'd like to have them enabled again.

  • platform/mac/svg/W3C-I18N: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • svg/W3C-I18N: Added.
  • svg/W3C-I18N/NOTE: Added.
  • svg/W3C-I18N/g-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/resources: Added.
  • svg/W3C-I18N/resources/img1.png: Added.
  • svg/W3C-I18N/resources/img11.png: Added.
  • svg/W3C-I18N/resources/img12.png: Added.
  • svg/W3C-I18N/resources/img13.png: Added.
  • svg/W3C-I18N/resources/img14.png: Added.
  • svg/W3C-I18N/resources/img15.png: Added.
  • svg/W3C-I18N/resources/img16.png: Added.
  • svg/W3C-I18N/resources/img17.png: Added.
  • svg/W3C-I18N/resources/img18.png: Added.
  • svg/W3C-I18N/resources/img19.png: Added.
  • svg/W3C-I18N/resources/img2.png: Added.
  • svg/W3C-I18N/resources/img20.png: Added.
  • svg/W3C-I18N/resources/img21.png: Added.
  • svg/W3C-I18N/resources/img24.png: Added.
  • svg/W3C-I18N/resources/img25.png: Added.
  • svg/W3C-I18N/resources/img3.png: Added.
  • svg/W3C-I18N/resources/img4.png: Added.
  • svg/W3C-I18N/resources/img5.png: Added.
  • svg/W3C-I18N/resources/tanchor-left-right.png: Added.
  • svg/W3C-I18N/resources/tanchor-left.png: Added.
  • svg/W3C-I18N/resources/tanchor-right.png: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-no-markup.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-direction-ltr.svg: Added.
  • svg/W3C-I18N/tspan-direction-rtl.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg: Added.
  • svg/W3C-SVG-1.1/resources/SVGExotic.svg: Added.
  • svg/W3C-SVG-1.1/text-align-08-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-align-08-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-align-08-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • svg/text/bidi-reorder-value-lists.svg: Added.
  • svg/text/bidi-text-anchor-direction.svg: Added.
  • svg/text/bidi-text-query.svg: Added.
  • svg/text/bidi-tspans.svg: Added.

2011-03-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text.

BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in
the order the characters appear in the markup), and when laying out bidi text, we associated the current character
in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout.
The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct.

Long story:
Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics>
for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in
the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with
"abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6
width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class).
The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands
that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10").

To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all
characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to
determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the
inline box tree, in _visual order_, as it will appear on screen.

After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the
found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout
rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position
in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order,
the x/y/.. lists are all in logical order.

Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction:

the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20".

Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine,
before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now
process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order.

Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated,
which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of
shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by
dozens of new tests.

Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg

svg/W3C-I18N/g-dirLTR-ubOverride.svg
svg/W3C-I18N/g-dirRTL-ubNone.svg
svg/W3C-I18N/g-dirRTL-ubOverride.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-no-markup.svg
svg/W3C-I18N/text-dirLTR-ubNone.svg
svg/W3C-I18N/text-dirLTR-ubOverride.svg
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/text-dirRTL-ubOverride.svg
svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-direction-ltr.svg
svg/W3C-I18N/tspan-direction-rtl.svg
svg/W3C-SVG-1.1-SE/text-intro-02-b.svg
svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
svg/W3C-SVG-1.1-SE/text-intro-09-b.svg
svg/W3C-SVG-1.1/text-align-08-b.svg
svg/W3C-SVG-1.1/text-fonts-03-t.svg
svg/W3C-SVG-1.1/text-intro-01-t.svg
svg/W3C-SVG-1.1/text-intro-02-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg
svg/W3C-SVG-1.1/text-intro-04-t.svg
svg/text/bidi-reorder-value-lists.svg
svg/text/bidi-text-anchor-direction.svg
svg/text/bidi-text-query.svg
svg/text/bidi-tspans.svg

  • rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text. (WebCore::RenderBlock::determineStartPosition):
  • rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
  • rendering/svg/SVGRenderTreeAsText.cpp: Ditto. (WebCore::writeSVGInlineTextBox):
  • rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup).

This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual
order as the characters are presented on screen.

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption. (WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left. (WebCore::SVGTextChunk::calculateLength): (WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl).
  • rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield. (WebCore::SVGTextChunk::isVerticalText): (WebCore::SVGTextChunk::hasDesiredTextLength): (WebCore::SVGTextChunk::hasTextAnchor): (WebCore::SVGTextChunk::hasLengthAdjustSpacing): (WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs):
  • rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes. (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk):
  • rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text. (WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object

that we cache, refers to the _rendered_ character. For Arabic text that means, that we're
measuring the shaped width of the glyph, not the glyph in its isolated form. Without that
fix reordering boxes containing Arabic is wrong.

  • rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm

has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have
to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine,
to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog.

(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph.

The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for
Arabic until now.)

(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct. (WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange):
  • rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method. (WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed.
  • rendering/svg/SVGTextMetrics.h: (WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic).
  • rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::calculateGlyphBoundaries):
1:12 PM Changeset in webkit [81167] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Revert 81151 - Merge 80887 - 2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=enne@google.com

TBR=enne@google.com

12:52 PM Changeset in webkit [81166] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix make distcheck for 1.3.13 release
https://bugs.webkit.org/show_bug.cgi?id=56371

No new tests as this is a build fix.

  • GNUmakefile.am: added a couple of missing files.
12:36 PM Changeset in webkit [81165] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-03-08 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode
https://bugs.webkit.org/show_bug.cgi?id=52642

Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous
functions that create new positions. Also fixing various parts of editing code that
incorrectly handled the new positions now being created.

No new tests as this is refactoring/cleanup.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange):
  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::Position::getInlineBoxAndOffset):
  • dom/Position.h: (WebCore::operator==):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::unlistifyParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::enclosingEmptyListItem):
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
12:22 PM Changeset in webkit [81164] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth

Make WebConsoleMessage properly respect the log level.
https://bugs.webkit.org/show_bug.cgi?id=56386

  • public/WebConsoleMessage.h: (WebKit::WebConsoleMessage::WebConsoleMessage):
11:53 AM Changeset in webkit [81163] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::cancelAnimations):

11:45 AM Changeset in webkit [81162] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56329

Reviewed by Dave Levin.

Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's
constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of
mutating orientation.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformInit):

11:42 AM Changeset in webkit [81161] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Disable ShadowBlur shadow drawing in accelerated contexts
https://bugs.webkit.org/show_bug.cgi?id=56392

When drawing into a graphics context that is accelerated, don't use
ShadowBlur, because it may be slower.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): (WebCore::GraphicsContext::setIsAcceleratedContext): (WebCore::GraphicsContext::isAcceleratedContext):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
11:39 AM Changeset in webkit [81160] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix the Windows build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:

(NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):

11:30 AM Changeset in webkit [81159] by Beth Dakin
  • 21 edits in trunk/Source

Source/WebCore: Fix for <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new
page.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

Scroll animations should be suspended if the FrameLoadState is anything but
complete.

  • page/FrameView.cpp:

(WebCore::FrameView::shouldSuspendScrollAnimations):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldSuspendScrollAnimations):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::shouldSuspendScrollAnimations):

  • rendering/RenderListBox.h:

New virtual function cancelAnimations() is only needed on the Mac, so the base
class is empty.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::cancelAnimations):

ScrollAnimatorMac needs to keep track of whether the page has been scrolled since
it started loading. If so, we will override optimizations that wait for the
FrameLoadState to be complete before animating scrollbars.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad):

If the scrollbar animations should be suspended, we start a timer to make sure
that we do flash the scrollbars. Animating the scrollbars is expensive, so this is
both a performance optimization and a UI enhancement since the scrollbar won't
jump around nearly as much on a page load.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

New WebCoreSystemInterface function to force the scrollbars to flash

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: WebKit2 part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

11:25 AM Changeset in webkit [81158] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Remove stale comment at RenderStyle::diff.
https://bugs.webkit.org/show_bug.cgi?id=56387

  • rendering/style/RenderStyle.cpp: Removed comment.
11:23 AM Changeset in webkit [81157] by andersca@apple.com
  • 14 edits
    3 adds in trunk

2011-03-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Make sure to always increment the load count whenever a web process connection
is opened to a plug-in process, and decrement it when the last web process connection
goes away.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection): (WebKit::PluginProcess::startShutdownTimerIfNecessary):
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): (WebKit::NetscapePlugin::~NetscapePlugin):

2011-03-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Add test.

  • plugins/npruntime/np-deallocate-called-before-np-shutdown-expected.txt: Added.
  • plugins/npruntime/np-deallocate-called-before-np-shutdown.html: Added.

2011-03-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
https://bugs.webkit.org/show_bug.cgi?id=56391

Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::PluginTest): (PluginTest::NP_Shutdown): (PluginTest::registerNPShutdownFunction):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added. (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown): (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty): (NPDeallocateCalledBeforeNPShutdown::NPP_New): (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue): (NPDeallocateCalledBeforeNPShutdown::shutdown):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Shutdown):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:
11:22 AM Changeset in webkit [81156] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

<http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

Reviewed by Simon Fraser.

Typedef-ing Objective-C classes as void* for pure C++ makes it
easier for bugs to creep in because compilers can't do any type
checking for void pointers.

  • platform/graphics/GraphicsContext3D.h: Changed typedef

declarations for CALayer and WebGLLayer from void* to structs.
(WebCore::GraphicsContext3D::platformLayer): Changed
static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
CALayer and WebGLLayer are not void pointers.

  • platform/graphics/GraphicsLayer.h: Changed typedef declaration

for PlatformLayer from void* to struct CALayer.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

declaration for CAPropertyAnimation from void* to a struct.
Extracted typdef for PlatformAnimationRef.

11:02 AM Changeset in webkit [81155] by commit-queue@webkit.org
  • 19 edits
    3 adds in trunk

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382

  • fast/forms/input-autofilled-expected.txt: Added.
  • fast/forms/input-autofilled.html: Added.
  • platform/win/fast/forms/input-autofilled-expected.txt: Added.

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382

Test: fast/forms/input-autofilled.html

  • css/html.css: (input:-webkit-autofill): Added foreground color: #000000
  • css/wml.css: (input:-webkit-autofill): Added foreground color: #000000

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
  • DOM/WebDOMOperationsPrivate.h:

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
https://bugs.webkit.org/show_bug.cgi?id=48382

  • DumpRenderTree/LayoutTestController.cpp: (setAutofilledCallback): Added. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAutofilled): Added. (LayoutTestController::setValueForUser): Style tweak.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAutofilled): Added (stub).
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAutofilled): Added (stub).
11:02 AM Changeset in webkit [81154] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix broken assert in new code.

Reviewed by Sam Weinig.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordPutByVal):

  • recordPutByVal is called for both PutByVal & PutByValAlias.
10:57 AM Changeset in webkit [81153] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed redundant code from BytecodeGenerator.

Rubber stamped by Sam Weinig.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
    • delete uncalled code missed when reparsing was removed.
10:56 AM Changeset in webkit [81152] by tony@chromium.org
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <tony@chromium.org>

Revert r81147 and r81149, broke the chromium win build.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Removed.
10:52 AM Changeset in webkit [81151] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80887 - 2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=enne@google.com

10:51 AM Changeset in webkit [81150] by Adam Roben
  • 2 edits in trunk/Source/WebKit/mac

2011-03-15 Adam Roben <Adam Roben>

Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin

Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
WebStorageTrackerClient::dispatchDidModifyOrigin

Reviewed by Antti Koivisto.

  • Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed to us by dispatchDidModifyOrigin. (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an unnecessary cast.
10:49 AM Changeset in webkit [81149] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <tony@chromium.org>

Fix chromium build using python 2.5 (with statement).

  • scripts/generate_devtools_grd.py:
10:47 AM Changeset in webkit [81148] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80824 - 2011-03-10 Chris Guillory <chris.guillory@google.com>

Reviewed by James Robinson.

Fix for Coverity discovered NO_EFFECT (self-assign) defect.
https://bugs.webkit.org/show_bug.cgi?id=54143

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::setMaxTextureSize):

TBR=enne@google.com

10:40 AM Changeset in webkit [81147] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
https://bugs.webkit.org/show_bug.cgi?id=56335

This is the webkit side of the fix for
http://code.google.com/p/chromium/issues/detail?id=35793

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
10:35 AM Changeset in webkit [81146] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update WebKit2 Skipped file for some new tests that rely on unimplemented features

  • platform/mac-wk2/Skipped:
10:32 AM Changeset in webkit [81145] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
if it's an internal pause for example.
https://bugs.webkit.org/show_bug.cgi?id=56374

In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
change into the DOM.

No new tests: Verified manually.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
10:24 AM Changeset in webkit [81144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-15 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. No new functionality exposed.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
10:14 AM Changeset in webkit [81143] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Alok priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Remove unnecessary function WebPlugin::getBackingTextureId
https://bugs.webkit.org/show_bug.cgi?id=56122

It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.

  • public/WebPlugin.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::platformLayer):
9:51 AM Changeset in webkit [81142] by mitz@apple.com
  • 2 edits in trunk/Tools

Build fix after r81135.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
9:33 AM Changeset in webkit [81141] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed. Update chromium deps to pick up the latest V8.

  • DEPS:
9:30 AM Changeset in webkit [81140] by mitz@apple.com
  • 5 edits in trunk/Tools

Build fix after r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/mac/TestControllerMac.mm:
  • WebKitTestRunner/mac/TestInvocationMac.mm:
  • WebKitTestRunner/mac/main.mm:
9:01 AM Changeset in webkit [81139] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Barth.

REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
https://bugs.webkit.org/show_bug.cgi?id=56349

  • QtTestBrowser/QtTestBrowser.pro: Link against fontconfig on platforms where we use it. Copied from DumpRenderTree.pro.
8:51 AM Changeset in webkit [81138] by mitz@apple.com
  • 3 edits in trunk/Tools

Build fix after r81135.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
8:44 AM Changeset in webkit [81137] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-03-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] [WebKit2] The UIProcess never changes the mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=56333

Add an implementation for WebView::addCursor for WebKit2 GTK+. This allows
the cursor to change as the user mouses around the page. There is currently
no test infrastructure to track cursor changes.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::setCursor): Ported implementation from WebKit1.
8:12 AM Changeset in webkit [81136] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
7:59 AM Changeset in webkit [81135] by kevino@webkit.org
  • 55 edits
    3 adds in trunk

Reviewed by Darin Adler.

Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.

https://bugs.webkit.org/show_bug.cgi?id=27551

7:41 AM Changeset in webkit [81134] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Chromium: shared lib linux build are failing.

Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
It was webcore_remaining instead of webcore_platform.

  • WebCore.gyp/WebCore.gyp:
7:38 AM Changeset in webkit [81133] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expanding/collapsing object shouldn&apos;t affect outer console.group expansion state
https://bugs.webkit.org/show_bug.cgi?id=56373

  • inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.toggleExpanded): (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
7:13 AM Changeset in webkit [81132] by pfeldman@chromium.org
  • 6 edits in trunk

2011-03-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:

2011-03-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/InspectorDOMAgent.cpp:
  • inspector/front-end/ElementsTreeOutline.js:
7:02 AM Changeset in webkit [81131] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-15 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
6:47 AM Changeset in webkit [81130] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
https://bugs.webkit.org/show_bug.cgi?id=56327

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionAPISchema.json:
6:08 AM Changeset in webkit [81129] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
https://bugs.webkit.org/show_bug.cgi?id=56114

  • inspector/console/console-nested-group-expected.txt: Added.
  • inspector/console/console-nested-group.html: Added.

2011-03-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
https://bugs.webkit.org/show_bug.cgi?id=56114

Test: inspector/console/console-nested-group.html

  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::type):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
3:47 AM Changeset in webkit [81128] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-15 Chris Mumford <chris.mumford@palm.com>

Reviewed by Adam Barth.

Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.

No new tests: No feature additions/removals.

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
3:46 AM Changeset in webkit [81127] by hayato@chromium.org
  • 9 edits in trunk/Tools

2011-03-15 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

[NRWT] Add support for reftests to new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=55457

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:33 AM Changeset in webkit [81126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=56255
Fix build on Solaris 10/Sun Studio 12 C++

No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++

  • bridge/runtime_array.h: (JSC::RuntimeArray::getConcreteArray):
3:32 AM Changeset in webkit [81125] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

  • platform/gtk/Skipped:
3:19 AM Changeset in webkit [81124] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-15 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, update test expectations

  • platform/chromium/test_expectations.txt:
3:10 AM Changeset in webkit [81123] by alex
  • 2 edits in trunk/Tools

2011-03-15 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix compilation warning after r80892
https://bugs.webkit.org/show_bug.cgi?id=56302

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::originsWithLocalStorage):
2:41 AM Changeset in webkit [81122] by robert@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

Document the qmakearg argument, and hint how to build webkit2 on Qt
https://bugs.webkit.org/show_bug.cgi?id=56326

  • Scripts/build-webkit: add --qmakearg to build-webkit --help
2:09 AM Changeset in webkit [81121] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-15 Ilya Sherman <isherman@chromium.org>

Reviewed by David Levin.

Update Chromium test expectations for fast/forms/onchange-setvalueforuser
https://bugs.webkit.org/show_bug.cgi?id=56365

  • platform/chromium/fast/forms/onchange-setvalueforuser-expected.txt: Added.
12:28 AM Changeset in webkit [81120] by Adam Roben
  • 3 edits in trunk/Tools

Make Windows 7 Release (Tests) a core builder

We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.

Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder

Reviewed by Sam Weinig.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot): Added a regexp to match Windows 7 Release (Tests).

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.

Mar 14, 2011:

11:58 PM Changeset in webkit [81119] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Another Chromium rebaseline for r81095.

  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
11:50 PM Changeset in webkit [81118] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Buildfix when JIT is not enabled after r81079
https://bugs.webkit.org/show_bug.cgi?id=56361

  • runtime/Executable.cpp:
11:34 PM Changeset in webkit [81117] by Adam Roben
  • 1 edit
    1 add in trunk/Tools

Add forgotten file from r81116

  • TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
11:21 PM Changeset in webkit [81116] by weinig@apple.com
  • 12 edits
    1 add in trunk

about:blank fake responses don't get serialized when sent the UIProcess
<rdar://problem/9108119>
https://bugs.webkit.org/show_bug.cgi?id=56357

Source/WebCore:

Reviewed by Adam Roben

Test: AboutBlankLoad

  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
Create a CFURLResponseRef if one does not exist yet as we do for
NSURLResponses on the mac.

Tools:

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Add test that loads of about:blank have a response with a MIMEType of text/html.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
Add helper to get the MIMEType from a WKURLResponse.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add new files.

11:11 PM Changeset in webkit [81115] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-14 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

REGRESSION: Print preview is blank when selecting multiple pages per sheet
https://bugs.webkit.org/show_bug.cgi?id=56341
<rdar://problem/8991382>

  • UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected callback number after receiving a different one. We only update preview after receiving the latest expected page data (and the assumption is that AppKit will ask for pages in natural order for N-up).
10:59 PM Changeset in webkit [81114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
https://bugs.webkit.org/show_bug.cgi?id=56145

We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
of a bug in QtMultimedia.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::seek): (WebCore::MediaPlayerPrivateQt::stateChanged): (WebCore::MediaPlayerPrivateQt::positionChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
10:56 PM Changeset in webkit [81113] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-14 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Graphics Context is not properly recovered if the GPU process dies.
https://bugs.webkit.org/show_bug.cgi?id=56148

Split context recreation into two steps.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h:
10:50 PM Changeset in webkit [81112] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2011-03-14 MORITA Hajime <morrita@google.com>

Unreviewed, skipped tests that uses an unsupported DRT API.

  • platform/qt/Skipped:
  • platform/win/Skipped:
10:48 PM Changeset in webkit [81111] by ap@apple.com
  • 5 edits in trunk

2011-03-14 Alexey Proskuryakov <ap@apple.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=44138
Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests.

  • platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that locally, becasue most WebSocket tests time out on my machine.

2011-03-14 Alexey Proskuryakov <ap@apple.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=44138
Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html

https://bugs.webkit.org/show_bug.cgi?id=55375
http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

https://bugs.webkit.org/show_bug.cgi?id=56185
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

  • platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that a pointer can be passed across threads when wrapped in a RefPtr.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists when executing a method on main thread by using RefPtr.
10:44 PM Changeset in webkit [81110] by rniwa@webkit.org
  • 20 edits
    1 delete in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaselines for r81095.

  • platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/selection/after-line-break-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
10:31 PM Changeset in webkit [81109] by rniwa@webkit.org
  • 21 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

GTK and Qt rebaselines for r81095.

  • platform/gtk/editing/deleting/smart-delete-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-002-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/gtk/editing/selection/expanding-selections-expected.txt:
  • platform/gtk/editing/selection/expanding-selections2-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/selection/expanding-selections-expected.txt:
  • platform/qt/editing/selection/expanding-selections2-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
10:24 PM Changeset in webkit [81108] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=56006

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
9:58 PM Changeset in webkit [81107] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix. Part 1 of N.

  • WebCore.exp.in:
9:49 PM Changeset in webkit [81106] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

Add method to make BuildBot return test outputs
https://bugs.webkit.org/show_bug.cgi?id=54374

The Builder.latest_cached_build will be used by the new rebaseline
script to determine the build to use baselines from.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
9:30 PM Changeset in webkit [81105] by Adam Roben
  • 10 edits
    2 adds in trunk

Make WKBundlePageCanHandleRequest return true for empty document URLs

Reviewed by Sam Weinig.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
empty documents, and defer to the platform for everything else.

  • WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformCanHandleRequest):
Renamed from canHandleRequest.

Tools:

Test that WKBundlePageCanHandleRequest returns true for empty document URLs

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
(TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
(TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
ensure the web process is initialized, then ask the bundle to run the test and assert that
it succeeded.

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.

(TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
(TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
handle a given URL.
(TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
URL type cannot be handled).
(TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
result.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

Added new files to the project.

9:11 PM Changeset in webkit [81104] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
https://bugs.webkit.org/show_bug.cgi?id=56316

  • http/tests/media/video-play-stall-before-meta-data-expected.txt: Added.
  • http/tests/media/video-play-stall-before-meta-data.html: Added.

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
https://bugs.webkit.org/show_bug.cgi?id=56316

We should stop delaying the load event when the load has
stalled naturally, or if we require a user gesture to
continue the load.

Test: http/tests/media/video-play-stall-before-meta-data.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
8:56 PM Changeset in webkit [81103] by mrowe@apple.com
  • 12 edits in trunk

Roll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots.

8:50 PM Changeset in webkit [81102] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Possible leaks after splitting TextCheckerClientEnchant.
https://bugs.webkit.org/show_bug.cgi?id=55989

Convert gchar* to GOwnPtr<gchar> and refactor the code.

  • WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
7:38 PM Changeset in webkit [81101] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-03-13 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
https://bugs.webkit.org/show_bug.cgi?id=48799

  • editing/pasteboard/drop-file-svg.html: Added.
  • editing/pasteboard/resources/drop-file-svg.svg: Added.

2011-03-13 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
https://bugs.webkit.org/show_bug.cgi?id=48799

DragController tried to dispatch textInput event even when the
drag destination is not the editable area.
This change skips the event dispatching on that case.

Test: editing/pasteboard/drop-file-svg.html

  • page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): (WebCore::DragController::concludeEditDrag):
7:28 PM Changeset in webkit [81100] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Made the global object moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56348


SunSpider reports no change.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Removed a dubious comment that suggested we do not need to visit all our references during GC, since that is not true in a moving GC.

Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.

  • runtime/JSGlobalObject.h: Re-sorted data members by type.
7:27 PM Changeset in webkit [81099] by levin@chromium.org
  • 17 edits in trunk

Unreviewed, rolling out r81094.
http://trac.webkit.org/changeset/81094
https://bugs.webkit.org/show_bug.cgi?id=56355

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-14
Broke the chromium DRT related build. (Requested by dave_levin
on #webkit).

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText):

  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::layerTreeAsText):

  • src/WebFrameImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):
(TestShell::dump):

  • DumpRenderTree/chromium/TestShell.h:

(TestParams::TestParams):

7:24 PM Changeset in webkit [81098] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <abarth@webkit.org>

Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
the Chromium build, otherwise the objects visible in the global scope
change.

  • WebCore.gyp/WebCore.gyp:
7:17 PM Changeset in webkit [81097] by commit-queue@webkit.org
  • 12 edits in trunk

2011-03-14 Rik Cabanier <cabanier@gmail.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-14 Rik Cabanier <cabanier@adobe.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
7:09 PM Changeset in webkit [81096] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <abarth@webkit.org>

Attempted Chromium build fix. Exclude AllInOne harder.

  • WebCore.gyp/WebCore.gyp:
7:07 PM Changeset in webkit [81095] by rniwa@webkit.org
  • 19 edits in trunk

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

EventHandler calls shouldChangeSelection needlessly
https://bugs.webkit.org/show_bug.cgi?id=56324

Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
avoided calling shouldChangeSelection and setSelection when the existing
selection is identical to that of new selection.

  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): Extracted. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.

2011-03-14 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.
6:56 PM Changeset in webkit [81094] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-14 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-14 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-14 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
6:42 PM Changeset in webkit [81093] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add remaining files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56351

Adding the remaining files to WebCore.gypi required updating the
include/exclude lists in WebCore.gyp. These lists aren't overly
elegant, but we can try to improve them in the future.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/ScriptCachedFrameData.cpp:
    • Added ifdefs to this file to match the header.
  • platform/graphics/WOFFFileFormat.cpp:
    • Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
6:19 PM Changeset in webkit [81092] by antonm@chromium.org
  • 13 edits in trunk

2011-03-14 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.

2011-03-14 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::calculateRootStyleSheet): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping): (WebCore::V8GCController::gcPrologue):
  • bindings/v8/WrapperTypeInfo.h: (WebCore::WrapperTypeInfo::isSubclass):
  • css/CSSRuleList.h: (WebCore::CSSRuleList::styleList):
  • css/StyleSheetList.h: (WebCore::StyleSheetList::document):
6:15 PM Changeset in webkit [81091] by luiz@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping some tests on Windows due to problems on mouse click handling.
See https://bugs.webkit.org/show_bug.cgi?id=56347.

  • platform/win/Skipped:
6:13 PM Changeset in webkit [81090] by rniwa@webkit.org
  • 17 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).

  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
  • platform/mac-leopard/editing/selection/fake-drag-expected.png:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
6:11 PM Changeset in webkit [81089] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
https://bugs.webkit.org/show_bug.cgi?id=56336

Reviewed by Beth Dakin.

Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
pointers.

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityHitTest:]):

5:53 PM Changeset in webkit [81088] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

Assertion failure by form validation message for <select required> with float:left
https://bugs.webkit.org/show_bug.cgi?id=55995

Reviewed by James Robinson.

Source/WebCore:

Test: fast/forms/interactive-validation-select-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks):

isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().

LayoutTests:

  • fast/forms/interactive-validation-select-crash-expected.txt: Added.
  • fast/forms/interactive-validation-select-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:48 PM Changeset in webkit [81087] by alice.liu@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide API for creating WKImage from CGImageRef
https://bugs.webkit.org/show_bug.cgi?id=56159

Reviewed by Sam Weinig.

Add function for creating a WKImage from CGImage data.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it.

  • Shared/API/c/cg/WKImageCG.h:
5:39 PM Changeset in webkit [81086] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Made JSWrapperObject and subclasses moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56346


SunSpider reports no change.

  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code. This doesn't cause any problems in our existing code since the base class never reads the anonymous slot it declares, but it caused crashes when I tried to start using the slot in an initial version of this patch.
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue): Resolved a problem where our internal value was stored in two places: an anonymous slot, and a data member which was not always visited during GC. Now, we only use the data member, and we always visit it. (Instead of relying on certain subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/NumberObject.h: Removed meaningless declaration.
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/StringObject.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code.
5:36 PM Changeset in webkit [81085] by msaboff@apple.com
  • 4 edits
    3 adds in trunk

2011-03-14 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
https://bugs.webkit.org/show_bug.cgi?id=56082

Changed parentheses assertion processing to temporarily back out the
number of known characters after the assertion while processing the
assertion. This was done so that assertions don't fail due to
checking the number of required characters as additional to the
rest of the express since assertions don't "consume" input.
Added a byte code to uncheck characters to support the change.

  • yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::uncheckInput): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::UncheckInput):

2011-03-14 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
https://bugs.webkit.org/show_bug.cgi?id=56082

New tests to verify the corresponding changes.

  • fast/regex/assertion-expected.txt: Added.
  • fast/regex/assertion.html: Added.
  • fast/regex/script-tests/assertion.js: Added.
5:32 PM Changeset in webkit [81084] by kbalazs@webkit.org
  • 15 edits in trunk

2011-03-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109

No code changes so no new tests.

Revert the changes that were needed to use KURL
in WebKitTestRunner.

  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:

2011-03-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109

Add API's to WKURL and WKString to satisfy
WebKitTestRunner's needs.

  • Shared/API/c/WKString.cpp: (WKStringIsEqualToUTF8CStringIgnoringCase):
  • Shared/API/c/WKString.h:
  • Shared/API/c/WKURL.cpp: (WKURLCopyHostName): (WKURLCopyScheme):
  • Shared/API/c/WKURL.h:
  • Shared/WebString.h: (WebKit::WebString::equalToUTF8StringIgnoringCase):
  • Shared/WebURL.h: Added OwnPtr<KURL> member to be able to lazily parse the URL and store the result. (WebKit::WebURL::host): (WebKit::WebURL::protocol): (WebKit::WebURL::parseURLIfNecessary):
  • win/WebKit2.def: Revert the symbol exports that were needed to use KURL in WebKitTestRunner.

2011-03-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2 API's instead of KURL to analyze the URL.
  • WebKitTestRunner/StringFunctions.h: (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally in the WebKitTestRunner project. (WTR::toWK): Use adoptWK. (WTR::operator<<): Added helper for printing a WKURL.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link against WebCore.
4:59 PM Changeset in webkit [81083] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

It's the same old song (about the linux debug crash).

  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [81082] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-14 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=56340

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetScrollOffsetOnNextResize): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size. (WebKit::WebView::setScrollOffsetOnNextResize): Added.
  • UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
4:47 PM Changeset in webkit [81081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
https://bugs.webkit.org/show_bug.cgi?id=56133

Add condition to not compile webkit internal math round functions on RVCT compiler versions
from 3.0.0 because they are already defined in compiler math library.

  • wtf/MathExtras.h:
4:40 PM Changeset in webkit [81080] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix two memory leaks within LayoutTestController's storage support.

Reviewed by Adam Roben.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
by JSStringCreateWithCFString.
(LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
allocate.

4:31 PM Changeset in webkit [81079] by barraclough@apple.com
  • 5 edits
    20 adds in trunk/Source/JavaScriptCore

Bug 56284 - Add a dataflow intermediate representation for use in JIT generation.

Reviewed by Geoffrey Garen & Oliver Hunt.

The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.

This patch adds:

  • a dataflow intermediate representation capable of describing a single basic block of operations,
  • a mechanism to convert a simple, single-block bytecode functions to the new IR,
  • and a JIT code generator capable of generating code from this representation.

The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.

The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.

The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:

  • the policy to only generate arithmetic code on the speculative path using integer instructions, never using floating point.
  • the policy to only generate arithmetic code on the non-speculative path using floating point instructions, never using integer.
  • always generating JSValue adds on the non-speculative path as a call out to a C-function, never handling this in JIT code.
  • always assuming by-Value property accesses on the speculative path to be array accesses.
  • generating all by-Value property accesses from the non-speculative path as a call out to a C-function.
  • generating all by-Indentifer property accesses as a call out to a C-function.

Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files to Xcode project.
  • dfg: Added.
    • Added directory for new code.
  • dfg/DFGByteCodeParser.cpp: Added.
  • dfg/DFGByteCodeParser.h: Added.
    • Contruct a DFG::Graph representation from a bytecode CodeBlock.
  • dfg/DFGGenerationInfo.h: Added.
    • Track type & register information for VirtualRegisters during JIT code generation.
  • dfg/DFGGraph.cpp: Added.
  • dfg/DFGGraph.h: Added.
    • Dataflow graph intermediate representation for code generation.
  • dfg/DFGJITCodeGenerator.cpp: Added.
  • dfg/DFGJITCodeGenerator.h: Added.
    • Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
  • dfg/DFGJITCompiler.cpp: Added.
  • dfg/DFGJITCompiler.h: Added.
    • Class responsible for driving code generation of speculativeJIT & non-speculative code paths from the dataflow graph.
  • dfg/DFGNonSpeculativeJIT.cpp: Added.
  • dfg/DFGNonSpeculativeJIT.h: Added.
    • Used to generate the non-speculative code path, this make no assumptions about operand types.
  • dfg/DFGOperations.cpp: Added.
  • dfg/DFGOperations.h: Added.
    • Helper functions called from the JIT generated code.
  • dfg/DFGRegisterBank.h: Added.
    • Used to track contents of physical registers during JIT code generation.
  • dfg/DFGSpeculativeJIT.cpp: Added.
  • dfg/DFGSpeculativeJIT.h: Added.
    • Used to generate the speculative code path, this make assumptions about operand types to enable optimization.
  • runtime/Executable.cpp:
    • Add code to attempt to use the DFG JIT to compile a function, with fallback to the existing JIT.
  • wtf/Platform.h:
    • Added compile guards to enable the DFG JIT.
4:29 PM Changeset in webkit [81078] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more linux debug crashers to the sad list.

  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [81077] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
https://bugs.webkit.org/show_bug.cgi?id=56321

  • Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c" to the list of exceptions for WebKit2 C API headers.
4:24 PM Changeset in webkit [81076] by Martin Robinson
  • 7 edits
    4 adds in trunk/LayoutTests

2011-03-14 Martin Robinson <mrobinson@igalia.com>

Update GTK+ pixel results after r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.checksum:
  • platform/gtk/editing/selection/drag-select-1-expected.png:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
  • platform/gtk/editing/selection/fake-drag-expected.png: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
4:14 PM Changeset in webkit [81075] by Adam Roben
  • 2 edits in trunk/Tools

Show the list of recent leaky builds in reverse chronological order

Previously they were being shown in a deterministic but surprising order based on
lexicographically sorting the build offsets (-1, -10, -2, -3...).

Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
callback.

4:13 PM Changeset in webkit [81074] by psolanki@apple.com
  • 3 edits in trunk/WebKitLibraries

I checked in Intel-only version of these files in r80975. This fixes that by building all
the correct slices - i386/x86_64/ppc for SnowLeopard and i386/x86_64/ppc/ppc64 for Leopard.

Rubber-stamped by Mark Rowe.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:47 PM Changeset in webkit [81073] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Upstream test expectations from the chromium repository to WebKit.

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [81072] by rniwa@webkit.org
  • 15 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Mac pixel rebaselines for r81053.

  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/fake-drag-expected.checksum:
  • platform/mac/editing/selection/fake-drag-expected.png:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
3:31 PM Changeset in webkit [81071] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed more cases of DeprecatedPtr (exception, SmallStrings)
https://bugs.webkit.org/show_bug.cgi?id=56332

  • runtime/Identifier.cpp: (JSC::Identifier::add): (JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because this reference is owned and managed directly by the heap.
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope):
  • runtime/JSString.h: (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsString): (JSC::jsStringWithFinalizer): (JSC::jsSubstring): (JSC::jsOwnedString): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::markChildren): (JSC::SmallStrings::clear): (JSC::SmallStrings::count): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of DeprecatedPtr because these references are owned and managed directly by the heap.


Stop using FixedArray because we only want a very limited set
of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)

  • runtime/WriteBarrier.h: (JSC::operator==): (JSC::WriteBarrier::WriteBarrier): (JSC::HeapRoot::HeapRoot): (JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set without write barrier because we assume all HeapRoots are scanned during all GC passes.
3:28 PM Changeset in webkit [81070] by levin@chromium.org
  • 17 edits in trunk/LayoutTests

Update the chromium windows baselines for r81053.

  • platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-win/editing/selection/drag-select-1-expected.png:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:25 PM Changeset in webkit [81069] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=55964

  • WebCore.pro:
  • platform/graphics/qt/Extensions3DQt.cpp:
3:19 PM Changeset in webkit [81068] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Show a list of up to 10 recent leaky builds when Leaks Viewer loads

Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
analyze

Reviewed by David Kilzer and Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#url-prompt): Made this a bit taller to make room for the list of builds.

(#recent-builds-loading-indicator):
(#recent-builds-list):
Added styles for the build list and loading indicator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
it. This will unescape it.
(LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
(LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
(LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
(LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
prompt UI.
(LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
now also used when a recent build is clicked.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.

(RecentBuildsLoader): Store the callback.
(RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
builder. Find the revision number, leak count, and results URL for each one. Pass the
resulting info to our callback.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:

(range): Added this helper function to return an array containing the integers [0, n).

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added

RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.

3:17 PM Changeset in webkit [81067] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed typo in the change log entry for r81066.

3:15 PM Changeset in webkit [81066] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaselines or r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:15 PM Changeset in webkit [81065] by bweinstein@apple.com
  • 7 edits
    2 adds in trunk/Source

FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>

Reviewed by Adam Roben and Gavin Barraclough.

Source/JavaScriptCore:

Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.

  • wtf/text/StringConcatenate.h:

Source/WebCore:

Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.

Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FileSystemWin.cpp:

(WebCore::listDirectory): Call through to PathWalker.

  • platform/win/PathWalker.cpp: Added.

(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument

for the pattern to pass to the Windows File APIs.

(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.

  • platform/win/PathWalker.h: Added.

Source/WebKit2:

Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::pluginPathsInDirectory):

3:14 PM Changeset in webkit [81064] by levin@chromium.org
  • 13 edits
    21 adds in trunk/LayoutTests

Add rebaselines due to two changes:
For r81053, we have

editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml

For r81049, we have

fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html

  • platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.png:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [81063] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.

  • platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
2:48 PM Changeset in webkit [81062] by luiz@webkit.org
  • 2 edits
    45 adds in trunk/LayoutTests

Adjusting Snow Leopard expected results after r81035.

  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/mac/fast/html/details-open1-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt: Added.
  • platform/mac/fast/html/details-open3-expected.txt: Added.
  • platform/mac/fast/html/details-open4-expected.txt: Added.
  • platform/mac/fast/html/details-open5-expected.txt: Added.
  • platform/mac/fast/html/details-open6-expected.txt: Added.
  • platform/mac/fast/html/details-position-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
2:45 PM Changeset in webkit [81061] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Qt rebaselines for r81053.

  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:44 PM Changeset in webkit [81060] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did. (sigh)

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

2:35 PM Changeset in webkit [81059] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <rniwa@webkit.org>

Mac rebaselines for r81053.

  • platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:25 PM Changeset in webkit [81058] by beidson@apple.com
  • 11 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"

Reviewed by Anders Carlsson.

../WebCore:

Remove HistoryItem::icon():

  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • WebCore.exp.in:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::defaultIcon):

../WebKit/efl:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get): Use IconDatabase directly.

../WebKit/mac:

  • History/WebHistoryItem.mm:

(-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.

../WebKit/qt:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon): Use IconDatabase directly.

2:22 PM Changeset in webkit [81057] by aestes@apple.com
  • 4 edits
    2 adds in trunk

2011-03-13 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=55104

  • fast/events/popup-blocking-timers-expected.txt: Added.
  • fast/events/popup-blocking-timers.html: Added.

2011-03-14 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=55104

If a timer is installed by a gesture-originated event and will fire
within one second, the timer-initiated event should behave as if it
were also initiated by a user gesture. Multi-shot timers should only
get this behavior on their first execution. Nested timers should not
get this behavior. This makes us compatible with Gecko when handling
popups and file chooser dialogs created from timer events.

Test: fast/events/popup-blocking-timers.html

  • page/DOMTimer.cpp: (WebCore::timeoutId): Create a helper function so that m_timeoutId can be initialized in the data member initialization list. (WebCore::shouldForwardUserGesture): Ditto, but for m_shouldForwardUserGesture. (WebCore::DOMTimer::DOMTimer): Move initialization of data members from the ctor body to the data member initialization list. Also rename the argument 'timeout' to 'interval'. (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its state based on the value of m_shouldForwardUserGesture. (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was renamed to m_originalInterval.
  • page/DOMTimer.h: Add m_shouldForwardUserGesture and rename m_originalTimeout to m_originalInterval.
2:19 PM Changeset in webkit [81056] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-09 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053

Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.

  • editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
  • editing/deleting/delete-inserts-br-after-button.html: Added.

2011-03-09 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053

Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
DeleteSelectionCommand treating them as blockflow.

Test: editing/deleting/delete-inserts-br-after-button.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs):
1:56 PM Changeset in webkit [81055] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=45164

Reviewed by Dan Bernstein.

REGRESSION: <a><img align=top></a> Clickable area too large

Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.

Source/WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

LayoutTests:

  • fast/inline/inline-position-top-align-expected.txt: Added.
  • fast/inline/inline-position-top-align.html: Added.
1:53 PM Changeset in webkit [81054] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
https://bugs.webkit.org/show_bug.cgi?id=52845

The lastCommitTime() value in CACFLayerTreeHost was returning as the time
the render previous to this one happened. That often made it seem like
animations started more in the past than they did, breaking many animations.
The startAnimations() call actually fires from a CACF callback after all the
WebKit content has been rendered. So sending currentTime as the start time
to the animations is close enough for proper synchronization.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
1:47 PM Changeset in webkit [81053] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213

Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
using the mouse coordinates of the mousedown event that started the drag.

Test: editing/selection/drag-select-rapidly.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent):

2011-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213

Added a test to ensure the selection start is computed using the mouse coordinates passed down
to the corresponding mousedown event instead of that of the first mousemove event.

The test is co-authored by Evan Martin.

  • editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
  • editing/selection/anchor-focus3-expected.txt: Ditto.
  • editing/selection/drag-select-rapidly-expected.txt: Added.
  • editing/selection/drag-select-rapidly.html: Added.
  • platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
  • platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
1:45 PM Changeset in webkit [81052] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Add a baseline for linux for this test since it matches what we have for OSX
except for the typical minor font differences.

  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 PM Changeset in webkit [81051] by mrowe@apple.com
  • 4 edits in trunk

<http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions): Remove duplicate entries.

1:40 PM Changeset in webkit [81050] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Apply a large, blunt object directly to the skull of the Leopard build.

Reviewed by Timothy Hatcher.

  • Configurations/Base.xcconfig: Disable the generation of debugging symbols when

building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.

1:30 PM Changeset in webkit [81049] by hyatt@apple.com
  • 10 edits
    12 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=56246

Reviewed by Beth Dakin.

Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.

Source/WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRelPositioned):

  • rendering/RenderTableCell.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/table/relative-position-containment.html: Added.
  • fast/table/relative-position-offsets.html: Added.
  • fast/table/relative-position-stacking.html: Added.
  • platform/mac/fast/table/overflowHidden-expected.txt:
  • platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/mac/fast/table/relative-position-containment-expected.txt: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.txt: Added.
1:20 PM Changeset in webkit [81048] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
layer, since first layouts and printing mess up otherwise.

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

1:19 PM Changeset in webkit [81047] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Improvements for the mondo linux debug failure list changes:

+ Add more tests that belong there.
+ Sort the tests that are there.
+ Add PASS to the lines that are there since these tests are known to pass and a passing

result for them shouldn't cause a test run to go orange.

  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [81046] by alice.liu@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/PerlSupport/Makefile:

Add whitespace when joining "-arch" with the architectures passed in as arguments.

11:59 AM Changeset in webkit [81045] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.

Reviewed by Simon Fraser.

Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.

Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.

No new tests, since this is untestable on ports that invalidate on a resize.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):

  • rendering/RenderLayer.h:
11:51 AM Changeset in webkit [81044] by levin@chromium.org
  • 3 edits
    361 adds in trunk/LayoutTests

Rebaselines due to r81035.
Also, added yet more tests to the linux debug crash sweeping through the layout tests.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open1-expected.png: Added.
  • platform/chromium-win/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open2-expected.png: Added.
  • platform/chromium-win/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open3-expected.png: Added.
  • platform/chromium-win/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open4-expected.png: Added.
  • platform/chromium-win/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open5-expected.png: Added.
  • platform/chromium-win/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open6-expected.png: Added.
  • platform/chromium-win/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-position-expected.png: Added.
  • platform/chromium-win/fast/html/details-position-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [81043] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build

11:38 AM Changeset in webkit [81042] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Daniel Bates <dbates@rim.com>

https://bugs.webkit.org/show_bug.cgi?id=55438
Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.

  • Scripts/build-webkit:
11:23 AM Changeset in webkit [81041] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
https://bugs.webkit.org/show_bug.cgi?id=55438

Separate out the EFL- and WinCE-specific logic from the port-independent logic in
webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
CMake arguments for feature defines.

  • Scripts/build-webkit:
    • Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
    • Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
    • Sorted forward declarations.
    • Initialize $makeArgs with the empty string so as to simplify its use in string operations; Modified call sites as needed.
  • Scripts/webkitdirs.pm:
    • Added cleanCMakeGeneratedProject() to clean a CMake build.
    • Added buildCMakeGeneratedProject() to build using generated build system.
    • Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
    • Added generateBuildSystemFromCMakeProject() to generate the build system from a CMake project.
    • Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
11:16 AM Changeset in webkit [81040] by oliver@apple.com
  • 32 edits in trunk/Source

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.

For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.

  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

Make sure everything builds still.

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
11:02 AM Changeset in webkit [81039] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix for r81035.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::defaultEventHandler):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):

10:52 AM Changeset in webkit [81038] by jer.noble@apple.com
  • 15 edits
    4 adds in trunk

2011-03-12 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

FullScreen: Handle entering full screen security restrictions
https://bugs.webkit.org/show_bug.cgi?id=56264

  • fullscreen/full-screen-css.html: Use runWithKeyDown.
  • fullscreen/full-screen-remove-ancestor.html: Ditto.
  • fullscreen/full-screen-remove.html: Ditto.
  • fullscreen/full-screen-request.html: Ditto.
  • fullscreen/full-screen-twice.html: Ditto.
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-iframe-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-allowed.html: Added.
  • fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-not-allowed.html: Added. (runWithKeyDown): Added. Wraps the command in a keyDown/keyPress

listener.

  • platform/mac-wk2/Skipped: Added new tests to skipped list.
  • platform/qt-wk2/Skipped: Ditto.

2011-03-13 Jer Noble <jer.noble@apple.com>

FullScreen: Handle entering full screen security restrictions
https://bugs.webkit.org/show_bug.cgi?id=56264

Tests: fullscreen/full-screen-iframe-allowed.html

fullscreen/full-screen-iframe-not-allowed.html

Disable full screen documents in the following conditions:
1) requesting element is in an iframe which does not have a
webkitallowfullscreen attribute.
2) page is not processing a user gesture.

  • dom/Document.cpp: (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks

to see if elements contained in IFRAMES are allowed to
enter full screen.

(WebCore::Document::webkitRequestFullScreenForElement): Checks

if page is currently processing a user gesture.

  • dom/Document.h:
  • html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
  • html/HTMLFrameElementBase.h:
10:46 AM Changeset in webkit [81037] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
https://bugs.webkit.org/show_bug.cgi?id=56303

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-14
Reviewed by David Levin.

Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):

10:39 AM Changeset in webkit [81036] by steveblock@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-14 Steve Block <steveblock@google.com>

Reviewed by Oliver Hunt.

JavaMethod.cpp does not compile with V8
https://bugs.webkit.org/show_bug.cgi?id=56306

Moved the ScopeChain.h include to JavaStringJSC.

No new tests, build fix only.

  • bridge/jni/JavaMethod.cpp:
  • bridge/jni/jsc/JavaStringJSC.h
10:35 AM Changeset in webkit [81035] by luiz@webkit.org
  • 15 edits
    92 adds in trunk

HTML5 <details> and <summary>: rendering
https://bugs.webkit.org/show_bug.cgi?id=51071

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/html/details-add-summary-1-and-click.html

fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-mouse-click.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html

http://www.w3.org/TR/html5/interactive-elements.html#the-details-element

The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):

  • html/HTMLDetailsElement.h:

(WebCore::HTMLDetailsElement::mainSummary):

Method createRenderer added to class HTMLSummaryElement.

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createRenderer):

  • html/HTMLSummaryElement.h:

The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):

  • rendering/RenderDetails.h:

(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):

A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):

  • rendering/RenderDetailsMarker.h:

(WebCore::toRenderDetailsMarker):

  • rendering/RenderSummary.cpp:

(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):

  • rendering/RenderSummary.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

  • fast/html/details-add-summary-1-and-click.html: Added.
  • fast/html/details-add-summary-1.html: Added.
  • fast/html/details-add-summary-10-and-click.html: Added.
  • fast/html/details-add-summary-10.html: Added.
  • fast/html/details-add-summary-2-and-click.html: Added.
  • fast/html/details-add-summary-2.html: Added.
  • fast/html/details-add-summary-3-and-click.html: Added.
  • fast/html/details-add-summary-3.html: Added.
  • fast/html/details-add-summary-4-and-click.html: Added.
  • fast/html/details-add-summary-4.html: Added.
  • fast/html/details-add-summary-5-and-click.html: Added.
  • fast/html/details-add-summary-5.html: Added.
  • fast/html/details-add-summary-6-and-click.html: Added.
  • fast/html/details-add-summary-6.html: Added.
  • fast/html/details-add-summary-7-and-click.html: Added.
  • fast/html/details-add-summary-7.html: Added.
  • fast/html/details-add-summary-8-and-click.html: Added.
  • fast/html/details-add-summary-8.html: Added.
  • fast/html/details-add-summary-9-and-click.html: Added.
  • fast/html/details-add-summary-9.html: Added.
  • fast/html/details-mouse-click-expected.txt: Added.
  • fast/html/details-mouse-click.html: Added.
  • fast/html/details-no-summary1.html: Added.
  • fast/html/details-no-summary2.html: Added.
  • fast/html/details-no-summary3.html: Added.
  • fast/html/details-no-summary4.html: Added.
  • fast/html/details-open-javascript.html: Added.
  • fast/html/details-open1.html: Added.
  • fast/html/details-open2.html: Added.
  • fast/html/details-open3.html: Added.
  • fast/html/details-open4.html: Added.
  • fast/html/details-open5.html: Added.
  • fast/html/details-open6.html: Added.
  • fast/html/details-position.html: Added.
  • fast/html/details-remove-summary-1-and-click.html: Added.
  • fast/html/details-remove-summary-1.html: Added.
  • fast/html/details-remove-summary-2-and-click.html: Added.
  • fast/html/details-remove-summary-2.html: Added.
  • fast/html/details-remove-summary-3-and-click.html: Added.
  • fast/html/details-remove-summary-3.html: Added.
  • fast/html/details-remove-summary-4-and-click.html: Added.
  • fast/html/details-remove-summary-4.html: Added.
  • fast/html/details-remove-summary-5-and-click.html: Added.
  • fast/html/details-remove-summary-5.html: Added.
  • fast/html/details-remove-summary-6-and-click.html: Added.
  • fast/html/details-remove-summary-6.html: Added.
  • fast/html/details-writing-mode.html: Added.
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary1-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary2-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary3-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary4-expected.txt: Added.
  • platform/qt/fast/html/details-open-javascript-expected.txt: Added.
  • platform/qt/fast/html/details-open1-expected.txt: Added.
  • platform/qt/fast/html/details-open2-expected.txt: Added.
  • platform/qt/fast/html/details-open3-expected.txt: Added.
  • platform/qt/fast/html/details-open4-expected.txt: Added.
  • platform/qt/fast/html/details-open5-expected.txt: Added.
  • platform/qt/fast/html/details-open6-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-writing-mode-expected.txt: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
10:20 AM Changeset in webkit [81034] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56296
Clean up IconDatabaseBase header.

Reviewed by Sam Weinig.

-Get rid of the "PlatformString.h" include and replace it with a forward declaration.
-Group methods by which are used in WebCore directly and which are used in WebKit ports.

This'll make it easier to use in external frameworks (like WebKit2).

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::open):

9:47 AM Changeset in webkit [81033] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76437 - 2011-01-22 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/6686050

9:47 AM Changeset in webkit [81032] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: No icon shown for <input type=file>
<rdar://problem/8988982>
https://bugs.webkit.org/show_bug.cgi?id=54288

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::chooseIconForFiles):
Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles.

9:46 AM Changeset in webkit [81031] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76864 - 2011-01-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Tiled compositor crashes if compositing turned off mid-paint
https://bugs.webkit.org/show_bug.cgi?id=53198

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/6686049

9:43 AM Changeset in webkit [81030] by podivilov@chromium.org
  • 14 edits
    2 deletes in trunk

2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
http://trac.webkit.org/changeset/81026
https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/debugger/xhr-breakpoints-expected.txt: Removed.
  • inspector/debugger/xhr-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
http://trac.webkit.org/changeset/81026
https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._createXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.BreakpointManager.prototype._createXHRBreakpointId): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._serializeToJSON): (WebInspector.XHRBreakpointView): (WebInspector.XHRBreakpointView.prototype.compareTo): (WebInspector.XHRBreakpointView.prototype.populateEditElement): (WebInspector.XHRBreakpointView.prototype.populateLabelElement): (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.set attached):
9:08 AM Changeset in webkit [81029] by mnaganov@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
https://bugs.webkit.org/show_bug.cgi?id=56312

Test: inspector/utilities.html

  • inspector/front-end/utilities.js:

2011-03-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
https://bugs.webkit.org/show_bug.cgi?id=56312

  • inspector/utilities-expected.txt: Added.
  • inspector/utilities.html: Added.
8:33 AM Changeset in webkit [81028] by antonm@chromium.org
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=antonm@chromium.org

8:32 AM Changeset in webkit [81027] by antonm@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/6691008

8:27 AM Changeset in webkit [81026] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
8:16 AM Changeset in webkit [81025] by podivilov@chromium.org
  • 7 edits in trunk

2011-03-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56123

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

2011-03-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56123

DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
setBreakpoint/removeBreakpoint are now called from DPM only.

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled): (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
7:21 AM Changeset in webkit [81024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81015.
http://trac.webkit.org/changeset/81015
https://bugs.webkit.org/show_bug.cgi?id=56308

A Similar patch landed in r76960 (Requested by philn-tp on
#webkit).

  • GNUmakefile.am:
7:00 AM Changeset in webkit [81023] by pfeldman@chromium.org
  • 10 edits in trunk

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
  • inspector/extensions/extensions-audits-expected.txt:

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.snippet):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/GoToLineDialog.js:
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/ShortcutsHelp.js: (WebInspector.ShortcutsSection.prototype.renderSection): (WebInspector.ShortcutsSection.prototype._renderHeader):
6:44 AM Changeset in webkit [81022] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Disable live-edit in favor of the text editor
https://bugs.webkit.org/show_bug.cgi?id=56176

  • inspector/front-end/Settings.js:
6:41 AM Changeset in webkit [81021] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
https://bugs.webkit.org/show_bug.cgi?id=56095

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer):
6:36 AM Changeset in webkit [81020] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56179

Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
5:51 AM Changeset in webkit [81019] by apavlov@chromium.org
  • 6 edits in trunk

2011-03-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
https://bugs.webkit.org/show_bug.cgi?id=56111

  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-03-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
https://bugs.webkit.org/show_bug.cgi?id=56111

This change reduces the getStylesForNode() payload more than twice for BODY elements.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.parsePayload):
5:26 AM Changeset in webkit [81018] by jknotten@chromium.org
  • 31 edits
    4 adds in trunk

2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
generated on watch when window is closed.

  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:

2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
https://bugs.webkit.org/show_bug.cgi?id=55577

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocation):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp: (WebCore::Navigator::resetGeolocation):
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  • platform/mock/GeolocationClientMock.h:

2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

  • DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
5:11 AM Changeset in webkit [81017] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
https://bugs.webkit.org/show_bug.cgi?id=56183

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleKeyDown): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:57 AM Changeset in webkit [81016] by alex
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <alex@igalia.com>

Rebaseline GTK+ tests after r80996.

  • platform/gtk/fast/text/soft-hyphen-2-expected.txt:
  • platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.
4:40 AM Changeset in webkit [81015] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Rogers <crogers@google.com>

Reviewed by Xan Lopez.

Add all web audio auto-generated files to GTK make system
https://bugs.webkit.org/show_bug.cgi?id=50497

No new tests since these are build-system tweaks.

  • GNUmakefile.am:
4:21 AM Changeset in webkit [81014] by jknotten@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=56202

By testing for geolocation watch errors, the test tests more than
it should, which can cause a flaky result as demonstrated by
https://bugs.webkit.org/show_bug.cgi?id=56126 .

  • fast/dom/Geolocation/resources/window-close-popup.html:
  • fast/dom/Geolocation/script-tests/window-close-crash.js:
4:19 AM Changeset in webkit [81013] by alex
  • 2 edits in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <alex@igalia.com>

Update more expectations after r80857.

  • platform/gtk/fast/layers/video-layer-expected.txt:
3:55 AM Changeset in webkit [81012] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Move the crash result and the bug to the debug line for the test (instead of release)
since that is where the crash occurs.

  • platform/chromium/test_expectations.txt:
3:29 AM Changeset in webkit [81011] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: remove the flaky part of the new inspector test for now.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
2:45 AM Changeset in webkit [81010] by pfeldman@chromium.org
  • 9 edits in trunk

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/elements/elements-panel-search.html:
  • inspector/elements/mutate-unknown-node.html:

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::cancelSearch): (WebCore::InspectorDOMAgent::onMatchJobsTimer): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.mycallback): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._childNodeCountUpdated): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMAgent.prototype.performSearch): (WebInspector.DOMAgent.prototype.cancelSearch): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._reset): (WebInspector.ElementsPanel.prototype._documentUpdated): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._addNodesToSearchResult): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype._childNodeCountUpdated): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2:42 AM Changeset in webkit [81009] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
https://bugs.webkit.org/show_bug.cgi?id=56248

  • inspector/elements/edit-dom-actions-expected.txt: Added.
  • inspector/elements/edit-dom-actions.html: Added.

2011-03-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
https://bugs.webkit.org/show_bug.cgi?id=56248

Test: inspector/elements/edit-dom-actions.html

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.removeAttribute):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler):
2:07 AM Changeset in webkit [81008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-03-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Modify my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
1:44 AM Changeset in webkit [81007] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix typo TEXT vs TEST.

  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [81006] by levin@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

Rebaseline some test due to r80996.
Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
and add a few bugs which track the other failures.

  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:44 AM Changeset in webkit [81005] by beidson@apple.com
  • 4 edits in trunk/Source

<rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage

Reviewed by Dan Bernstein.

../WebCore:

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread

before the StorageTracker thread can do it on the background thread.

../WebKit2:

Hookup the existing API stubs to the WebCore implementations:

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

12:11 AM Changeset in webkit [81004] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

2011-03-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move cache_directory api
https://bugs.webkit.org/show_bug.cgi?id=52139

Move cache directory related apis from ewk_view to ewk_settings because
those are not related to ewk_view.

  • ewk/ewk_main.cpp: (_ewk_init_body):
  • ewk/ewk_settings.cpp: (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del):
  • ewk/ewk_view.h:

Mar 13, 2011:

11:24 PM Changeset in webkit [81003] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=56285

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):

  • storage/StorageTracker.h:
11:20 PM Changeset in webkit [81002] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

11:02 PM Changeset in webkit [81001] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

10:47 PM Changeset in webkit [81000] by beidson@apple.com
  • 16 edits in trunk/Source/WebKit2

<rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI to set the path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory):

  • UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setLocalStorageDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

10:35 PM Changeset in webkit [80999] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <jer.noble@apple.com>

Reviewed by Mark Rowe.

WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=56260

Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

  • UIProcess/mac/WKFullScreenWindowController.mm:
10:23 PM Changeset in webkit [80998] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:23 PM Changeset in webkit [80997] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Clean up overlapping test_expectation which I mistakenly added in my haste.

  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80996] by mitz@apple.com
  • 13 edits in trunk

Include hyphenation information in text representation of render tree
https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

  • fast/text/soft-hyphen-4-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphenate-first-word-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
9:56 PM Changeset in webkit [80995] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

A few Heap-related renames (sans file moves, which should come next)
https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):

  • runtime/ConservativeSet.h:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):

  • runtime/Heap.h:

(JSC::Heap::machineThreads):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):

  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h:

(JSC::MarkStack::append):

9:53 PM Changeset in webkit [80994] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<https://bugs.webkit.org/show_bug.cgi?id=56270>

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

9:37 PM Changeset in webkit [80993] by levin@chromium.org
  • 4 edits in trunk

Build fix adding remaining enum values to switch statement.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80992] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80991] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [80990] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

8:01 PM Changeset in webkit [80989] by mrowe@apple.com
  • 1 copy in tags/Safari-534.24

New tag.

7:36 PM Changeset in webkit [80988] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after r80982.

  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
6:35 PM Changeset in webkit [80987] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix the Mac build.

ConervativeSet.h, since it's now visible when compiling other projects.

6:27 PM Changeset in webkit [80986] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):
Add missing constructor.

6:16 PM Changeset in webkit [80985] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (ConservativeSet)
https://bugs.webkit.org/show_bug.cgi?id=56281


The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append. (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated the size of the set based on sizeof(DeprecatedPtr<T>*) instead of sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not. (JSC::ConservativeSet::size): (JSC::ConservativeSet::set): Use direct pointers, as stated above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MarkStack.h: (JSC::MarkStack::append): Created a special case of append for ConservativeSet. I didn't want to add back a generic "append JSCell*" function, since other class might start using that wrong. (In the end, this function might go away, since the Heap will want to do something slightly more interesting with the conservative set, but this is OK for now.)
6:09 PM Changeset in webkit [80984] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Source/WebCore: REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

  • fast/text/soft-hyphen-4-expected.checksum: Added.
  • fast/text/soft-hyphen-4-expected.png: Added.
  • fast/text/soft-hyphen-4-expected.txt: Added.
  • fast/text/soft-hyphen-4.html: Added.
5:58 PM Changeset in webkit [80983] by levin@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [80982] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

5:34 PM Changeset in webkit [80981] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Add ability to create a WKErrorRef
<rdar://problem/9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add new exports.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

  • Shared/API/c/cf/WKErrorCF.cpp: Added.

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

  • Shared/API/c/cf/WKErrorCF.h: Added.

Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:34 PM Changeset in webkit [80980] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (PutPropertySlot)
https://bugs.webkit.org/show_bug.cgi?id=56278

  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot, since it's a stack-allocated temporary.
5:31 PM Changeset in webkit [80979] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add one more failure which is related to change in this range:

http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860

that I haven't been able to narrow down yet.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [80978] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [80977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-13 Joe Wild <joseph.wild@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher does not load the same set of fonts as the DRT
https://bugs.webkit.org/show_bug.cgi?id=34959

This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (initWebKitTestFonts): (launcherMain): (LauncherApplication::handleUserOptions):
5:14 PM Changeset in webkit [80976] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed one case of DeprecatedPtr (ScopeChainIterator)
https://bugs.webkit.org/show_bug.cgi?id=56277

  • runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator, since it's a stack-allocated temporary.
5:10 PM Changeset in webkit [80975] by psolanki@apple.com
  • 15 edits in trunk

Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:41 PM Changeset in webkit [80974] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [80973] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [80972] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

  • marked these methods const.

(JSC::AbstractMacroAssembler::Jump::isSet):

  • add a method to check whether a Jump object has been set to reference an instruction, or is in a null, unset state.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • add non-explicit constructor, for FunctionPtr's to C/C++ functions.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):

  • add three operand forms of these instructions.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::JmpSrc::isSet):

  • add a method to check whether a JmpSrc object has been set to reference an instruction, or is in a null, unset state.

(JSC::X86Assembler::movsd_rr):

  • added FP register-register move.

(JSC::X86Assembler::linkJump):

  • Add an assert to check jumps aren't linked more than once.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadInt32ToDouble):

  • load integers to the FPU via regsiters on x86-64.
3:05 PM Changeset in webkit [80971] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [80970] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load32):

2:16 PM Changeset in webkit [80969] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

  • bytecode/SamplingTool.h:
  • interpreter/Register.h:
  • interpreter/RegisterFile.h:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:
  • wtf/RefCounted.h:
    • Change these classes to no longer friend the JIT, add accessors for member offsets.
  • jit/JIT.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
    • Change the JIT to use class accessors, rather than taking object ofsets directly.
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
    • Since the accessors for objects members return const pointers to retain encapsulation, methods generating code with absolute addresses must be able to handle const pointers (the JIT doesn't write to these values, do dies treat the pointer to value as const from within the C++ code of the JIT, if not at runtime!).
1:30 PM Changeset in webkit [80968] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

WebPageProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from

here to WebPageProxyMac.mm.

  • UIProcess/WebPageProxy.h: Cleaned up #includes.
  • UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations

here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

1:28 PM Changeset in webkit [80967] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

1:24 PM Changeset in webkit [80966] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash when dragging.

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap): Retain the saved context.

12:46 PM Changeset in webkit [80965] by jeremy@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Update comment in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=56266

The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

No tests - just updating a comment.

  • css/CSSValueKeywords.in:
12:07 PM Changeset in webkit [80964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Anton D'Auria <adauria@apple.com>

Reviewed by Alice Liu.

StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
https://bugs.webkit.org/show_bug.cgi?id=56259

Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker):
11:47 AM Changeset in webkit [80963] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-13 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
https://bugs.webkit.org/show_bug.cgi?id=53470

Prefer !important over normal properties when dealing with duplicate properties in style rules.

Test: fast/css/duplicate-property-in-rule-important.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
11:42 AM Changeset in webkit [80962] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [80961] by levin@chromium.org
  • 5 edits
    11 adds in trunk/LayoutTests

Update test expections due to the OSX specific ex size change done in r80755.

  • platform/chromium-mac/fast/lists/008-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
10:04 AM Changeset in webkit [80960] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test expectations due to bad update:

r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [80959] by levin@chromium.org
  • 2 edits
    21 adds in trunk/LayoutTests

Added the following expectations:

fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:30 AM Changeset in webkit [80958] by levin@chromium.org
  • 12 edits
    40 adds in trunk/LayoutTests

Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

Mar 12, 2011:

11:34 PM Changeset in webkit [80957] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80895.
http://trac.webkit.org/changeset/80895
https://bugs.webkit.org/show_bug.cgi?id=56261

Causing crashes in several tests including
t1202-counters-16-c.html (see
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
(Requested by dave_levin on #webkit).

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::create): (WebCore::CounterNode::resetRenderer): (WebCore::CounterNode::resetRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::showTreeAndMark):
  • rendering/CounterNode.h: (WebCore::CounterNode::renderer):
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::~RenderCounter): (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree):
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
  • rendering/RenderObjectChildList.h:
8:19 PM Changeset in webkit [80956] by levin@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

Add results for newly added test in r80883.
The differences appear to be very small in keep with the typical
font drawing differences.

  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.
8:05 PM Changeset in webkit [80955] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Fixed typo in a comment.

8:03 PM Changeset in webkit [80954] by levin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

r80743 updated the main baseline due to a jsc change.
chromium isn't affected by the change.

  • platform/chromium/fast/js/regexp-caching-expected.txt: Added.

chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.

  • platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.
7:46 PM Changeset in webkit [80953] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Remove bad test_expectation updates.

I fixed both of these already:

http://trac.webkit.org/changeset/80911
http://trac.webkit.org/changeset/80904

so it is unclear why they were added.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [80952] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-03-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
https://bugs.webkit.org/show_bug.cgi?id=56258

No tests because the wrong hashing is mostly harmless. The only symptom
we have seen is an occasional assertion in debug builds about the size
not being a multiple of two. But a worse hash is worse for performance too.

  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather than the number of array entries.
7:36 PM Changeset in webkit [80951] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Fix the build with newer GCCs and remove some extra whitespae.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::uint8_t):

7:24 PM Changeset in webkit [80950] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Rubber-stamped by Oliver Hunt.

Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):

7:18 PM Changeset in webkit [80949] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Oliver Hunt.

WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257

Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian):

7:11 PM Changeset in webkit [80948] by Darin Adler
  • 7 edits in trunk/Source

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebCore.exp.in: Added some additional exports. Re-sorted.

2011-03-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::convertImageToBitmap): Added. Factored out from startDrag to make the startDrag code clearer. (WebKit::WebDragClient::startDrag): Streamlined code a bit. (WebKit::cachedImage): Added. Helper for function below. (WebKit::arrayForURLsWithTitles): Added. Helper for function below. (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file promises and removed a log of uneeded code. (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added. (promisedDataClient): Added. (-[WKPasteboardOwner clearImage]): Added. (-[WKPasteboardOwner initWithImage:]): Added. (-[WKPasteboardOwner dealloc]): Added. (-[WKPasteboardOwner finalize]): Added. (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added. (-[WKPasteboardOwner pasteboardChangedOwner:]): Added. (matchesExtensionOrEquivalent): Added. (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added. Much of the new code above came from the WebKit1 drag code.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
  • WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::setDragSource): Added. (WebKit::WebPage::platformDragEnded): Added.
2:32 PM Changeset in webkit [80947] by mitz@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
DumpRenderTree is being built for.

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/PerlSupport/Makefile:
2:15 PM Changeset in webkit [80946] by mrowe@apple.com
  • 7 edits in trunk/Source

Fix the 32-bit build.

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.

Source/WebKit2:

This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

1:42 PM Changeset in webkit [80945] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.

Reviewed by Sam Weinig.

(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.

(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.

1:30 PM Changeset in webkit [80944] by mitz@apple.com
  • 2 edits in trunk/Tools

Suggested by Mark Rowe.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled

as they were before r80915.

12:43 PM Changeset in webkit [80943] by andersca@apple.com
  • 12 edits in trunk

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256

  • UIProcess/API/C/WKPage.h: Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView _applyPDFPreferences]): (-[WKPDFView _updatePreferences:]): Use new PDFViewController::page getter.

(-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
Call PDFViewController::savePDFToDownloadsFolder.

(WebKit::releaseCFData):
(WebKit::PDFViewController::savePDFToDownloadsFolder):
Create a WebData that wraps the CFData, then pass it along to
WebPageProxy::saveDataToFileInDownloadsFolder.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder): Call WebUIClient::saveDataToFileInDownloadsFolder.

(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/WebUIClient.h: Call the UI client callback function.

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize): Update for API changes.
11:34 AM Changeset in webkit [80942] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebData should be able to wrap already existing data
https://bugs.webkit.org/show_bug.cgi?id=56254

  • Shared/WebData.h: (WebKit::WebData::createWithoutCopying): (WebKit::WebData::create): (WebKit::WebData::~WebData): (WebKit::WebData::bytes): (WebKit::WebData::size): (WebKit::WebData::WebData): (WebKit::WebData::fastFreeBytes):
10:14 AM Changeset in webkit [80941] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
https://bugs.webkit.org/show_bug.cgi?id=56250

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
8:44 AM Changeset in webkit [80940] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium expectations.

  • platform/chromium/test_expectations.txt:
8:07 AM Changeset in webkit [80939] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [80938] by loislo@chromium.org
  • 33 edits in trunk/Source

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/StructureStubInfo.cpp:
  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::payloadFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):
  • runtime/ArgList.cpp:
  • runtime/DateConversion.cpp:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/Identifier.cpp:
  • runtime/JSActivation.h: (JSC::asActivation):
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.cpp:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.cpp:
  • runtime/MarkedBlock.cpp:
  • runtime/MarkedSpace.cpp:
  • runtime/PropertyNameArray.cpp:
  • runtime/ScopeChain.h: (JSC::ExecState::globalThisValue):
  • wtf/DateMath.cpp:

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251

all windows bots failed to compile this change (Requested by
loislo on #webkit).

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
7:47 AM Changeset in webkit [80937] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-03-12 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r80900.

  • CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
7:38 AM Changeset in webkit [80936] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Andras Becsi <abecsi@webkit.org>

Unreviewed typo fix.

No new tests needed.

  • WebCore.pro: Fix typo in header name.
6:44 AM Changeset in webkit [80935] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:55 AM Fingerprinting edited by robert@roberthogan.net
(diff)
4:00 AM Changeset in webkit [80934] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Inspect Element action regression fix.

3:53 AM Changeset in webkit [80933] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. One line fix for inspector/dom-breakpoints.html

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
3:26 AM Changeset in webkit [80932] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Almost all inspector tests are crashing after r80928.

  • inspector/front-end/inspector.js:
1:10 AM Changeset in webkit [80931] by pfeldman@chromium.org
  • 27 edits in trunk

2011-03-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/elements/elements-panel-search.html:

2011-03-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::setPropertyValue):
  • inspector/InjectedScript.h:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setNodeName): (WebInspector.DOMNode.prototype.setNodeValue): (WebInspector.DOMNode.prototype.getChildNodes): (WebInspector.DOMNode.prototype.getOuterHTML): (WebInspector.DOMNode.prototype.setOuterHTML): (WebInspector.DOMNode.prototype.removeNode): (WebInspector.DOMNode.prototype.copyNode): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.EventListeners.getEventListenersForNode):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype.updateChildren): ():
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.evaluate):
  • inspector/front-end/inspector.js:
12:24 AM Changeset in webkit [80930] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

12:07 AM Changeset in webkit [80929] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244

  • CMakeLists.txt: Add missing files.
  • platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).

2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244

  • ewk/ewk_settings.cpp: (ewk_settings_icon_database_path_set):

Mar 11, 2011:

11:21 PM Changeset in webkit [80928] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move profiler related methods from inspector agent to profiler agent
https://bugs.webkit.org/show_bug.cgi?id=56204

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::showProfilesPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::disable): (WebCore::InspectorProfilerAgent::setFrontend): (WebCore::InspectorProfilerAgent::clearFrontend): (WebCore::InspectorProfilerAgent::restore): (WebCore::InspectorProfilerAgent::restoreEnablement): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::start): (WebCore::InspectorProfilerAgent::stop):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype._registerProfileType): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
9:38 PM Changeset in webkit [80927] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-03-11 Anton D'Auria <adauria@apple.com>

Reviewed by Brady Eidson.

Adding StorageTracker tests to skip lists of platforms that don't support it.
https://bugs.webkit.org/show_bug.cgi?id=51878

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:28 PM Changeset in webkit [80926] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer(). (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
9:16 PM Changeset in webkit [80925] by jer.noble@apple.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:52 PM Changeset in webkit [80924] by jer.noble@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:19 PM Changeset in webkit [80923] by jer.noble@apple.com
  • 4 edits
    1 copy
    1 add in trunk/Source

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

8:01 PM Changeset in webkit [80922] by jer.noble@apple.com
  • 13 edits in trunk/Source

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer(). (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.

2011-03-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220

  • WebProcess/FullScreen/WebFullScreenManager.cpp: . (WebKit::WebFullScreenManager::~WebFullScreenManager): Added. (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs. (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color. (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto. (WebKit::WebFullScreenManager::willExitFullScreen): Ditto. (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
  • WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a

concrete subclass.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added. (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations. (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added. (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added. (-[WebFullScreenManagerAnimationListener invalidate]): Added. (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac. (WebKit::WebFullScreenManagerMac::create): Added. (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added. (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host. (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D

which will animate the full screen renderer from its initial position to its final one.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

7:35 PM Changeset in webkit [80921] by alice.liu@apple.com
  • 2 edits in trunk/Source/WebKit2

Support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158

Reviewed by Sam Weinig.

Added encoding/decoding for APIObject::TypeData

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

7:32 PM Changeset in webkit [80920] by alice.liu@apple.com
  • 5 edits in trunk/Source/WebKit2

Add api for "remove" to WKMutableDictionary
https://bugs.webkit.org/show_bug.cgi?id=56157

Reviewed by Sam Weinig.

  • Shared/API/c/WKMutableDictionary.cpp:

(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.

  • Shared/API/c/WKMutableDictionary.h:
  • Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.

  • Shared/MutableDictionary.h:
7:12 PM Changeset in webkit [80919] by oliver@apple.com
  • 33 edits in trunk/Source

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.

For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.

  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):

2011-03-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

Make sure everything builds still.

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
6:38 PM Changeset in webkit [80918] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

6:24 PM Changeset in webkit [80917] by rniwa@webkit.org
  • 10 edits
    2 deletes in trunk/Source/WebKit2

2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r80899 and r80912.
http://trac.webkit.org/changeset/80899
http://trac.webkit.org/changeset/80912
https://bugs.webkit.org/show_bug.cgi?id=56236

Caused animation tests to crash on Snow Leopard WebKit2
(Requested by rniwa on #webkit).

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::resize):
  • Shared/ShareableBitmap.h: (WebKit::ShareableBitmap::numBytesForSize): (WebKit::ShareableBitmap::sizeInBytes):
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate):
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::~DrawingAreaImpl): (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): (WebKit::DrawingAreaImpl::didUpdate): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::display):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
  • WebProcess/WebPage/SharedMemoryCache.h: Removed.
  • win/WebKit2.vcproj:
6:13 PM Changeset in webkit [80916] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9124537> Crashes during layout tests due to overrelease of AVFoundation objects.

Rubber-stamped by Eric Carlsson.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):

6:13 PM Changeset in webkit [80915] by mrowe@apple.com
  • 10 edits in trunk

Adopt the LLVM Compiler for debug builds.

Rubber-stamped by Adam Roben and Sam Weinig.

5:53 PM Rebaseline edited by mihaip@chromium.org
(diff)
5:49 PM Changeset in webkit [80914] by levin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Rollout the chromium deps roll as it adds a dependency on a header
that the bots building for WebKit don't seem to have.

Specifically gfx\gl\gl_context_egl.cc depends on d3dcompiler.h

  • DEPS:
5:46 PM Changeset in webkit [80913] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
5:45 PM Changeset in webkit [80912] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix. Add SharedMemoryCache to the vcproj.

  • win/WebKit2.vcproj:
5:41 PM Changeset in webkit [80911] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix prototype-inheritance-expected result due to two changes:

http://src.chromium.org/viewvc/chrome?view=rev&revision=77888 removed "google"
http://trac.webkit.org/changeset/80846 added WebKitAnimation/WebKitAnimationList

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
5:35 PM Changeset in webkit [80910] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • loader/icon/IconDatabase.h: Make this guy public.
5:23 PM Changeset in webkit [80909] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?

5:21 PM Changeset in webkit [80908] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit/win

More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216

  • WebCoreStatistics.cpp:
  • WebIconDatabase.cpp:
5:07 PM Changeset in webkit [80907] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Correct return type of WebClipboard::readImage.
https://bugs.webkit.org/show_bug.cgi?id=56234

Update the return type to reflect that we are returning a blob of PNG
data, not a bitmap.

  • public/WebClipboard.h: (WebKit::WebClipboard::readImage):
5:05 PM Changeset in webkit [80906] by Dimitri Glazkov
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
https://bugs.webkit.org/show_bug.cgi?id=56231

  • JavaScriptCore.gypi: Added project_dir variable.
  • gyp/JavaScriptCore.gyp: Changed to use project_dir, rather than DEPTH/JavaScriptCore.
  • gyp/generate-dtrace-header.sh: Changed to use project_dir.
4:45 PM Changeset in webkit [80905] by beidson@apple.com
  • 6 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.

../WebCore:

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::databasePath): Added to the virtual base.

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::isOpen): Ditto.

../WebKit/qt:

Reviewed by attempt at build fix!

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()

4:39 PM Changeset in webkit [80904] by levin@chromium.org
  • 7 edits in trunk

Source/WebKit/chromium: Update chromium deps to pick up the skia roll.

  • DEPS:

LayoutTests: Update some baselines due to Skia update in Chromium.
Filed http://crbug.com/75820 about the odd look of the results (but
the odd look previously existed).

  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
4:34 PM Changeset in webkit [80903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=56198
Fix conditional which had an int for one case and a pointer for another.

No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
4:29 PM Changeset in webkit [80902] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Windows build fix.

  • history/HistoryItem.cpp:
  • loader/icon/IconDatabaseBase.cpp:
4:25 PM Changeset in webkit [80901] by ap@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-03-11 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=56222
A window remains frozen if web process crashes during printing

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setComplexTextInputEnabled):
  • UIProcess/WebPageProxy.h: Moved setAutodisplay code into WKPrintingView.
  • UIProcess/API/mac/WKPrintingView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Keep a reference to the actual WKView, so that we can manipulate how it displays, even if page goes away.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView initWithFrameProxy:WebKit::view:]): (-[WKPrintingView _setAutodisplay:]): (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Move setAutodisplay here.
4:17 PM Changeset in webkit [80900] by beidson@apple.com
  • 13 edits
    2 adds
    1 delete in trunk/Source

<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.

../WebCore:

Reviewed by Sam Weinig.

Project file stuff:

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
  • loader/icon/IconDatabaseBase.cpp: Added.

(WebCore::IconDatabaseBase::iconURLForPageURL):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):

  • loader/icon/IconDatabaseBase.h: Added.

(WebCore::IconDatabaseBase::IconDatabaseBase):
(WebCore::IconDatabaseBase::~IconDatabaseBase):
(WebCore::IconDatabaseBase::setEnabled):
(WebCore::IconDatabaseBase::isEnabled):
(WebCore::IconDatabaseBase::defaultIcon):
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::pageURLMappingCount):
(WebCore::IconDatabaseBase::retainedPageURLCount):
(WebCore::IconDatabaseBase::iconRecordCount):
(WebCore::IconDatabaseBase::iconRecordCountWithData):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::shouldStopThreadActivity):
(WebCore::IconDatabaseBase::open):
(WebCore::IconDatabaseBase::close):
(WebCore::IconDatabaseBase::removeAllIcons):
(WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
(WebCore::IconDatabaseBase::setClient):

  • loader/icon/IconDatabaseNone.cpp: Removed.

../WebKit/mac:

Reviewed by Anders Carlsson

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
(-[WebIconDatabase _startUpIconDatabase]): Ditto.
(importToWebCoreFormat):

4:12 PM Changeset in webkit [80899] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a shared memory cache to the web process
https://bugs.webkit.org/show_bug.cgi?id=56232

Add a very simple shared memory cache to the web process, so that we don't have to allocate and
free memory over and over when painting.

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::resize):
  • Shared/ShareableBitmap.h: (WebKit::ShareableBitmap::numBytesNeededForBitmapSize): (WebKit::ShareableBitmap::sizeInBytes): Rename numBytesForSize to numBytesNeededForBitmapSize.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update): Always send back a DidUpdate message, even if we didn't use the update info. This is needed so that the web process knows when the UI process is done with the shared memory inside the update info struct.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate):
  • WebProcess/WebPage/DrawingArea.messages.in: DidUpdate now takes a boolean.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::sharedMemoryCache): Add shared memory cache.

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Return the shared memory to the cache.

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
display now takes an extra boolean.

(WebKit::DrawingAreaImpl::didUpdate):
Return the shared memory to the cache.

(WebKit::DrawingAreaImpl::display):
If useSharedMemoryCache is true, get shared memory from the cache.

  • WebProcess/WebPage/SharedMemoryCache.cpp: Added. (WebKit::SharedMemoryCache::acquireSharedMemory): If the memory we currently hold on to is big enough, return it.

(WebKit::SharedMemoryCache::releaseSharedMemory):
If we're already holding on to shared memory, evict it if the returned
shared memory object is bigger than the one we currently hold.

(WebKit::SharedMemoryCache::clearCacheTimerFired):
Null out the shared memory object.

4:07 PM Changeset in webkit [80898] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878

  • page/PageGroup.h: Declare this method, even if the definition will end up being empty.
3:57 PM Changeset in webkit [80897] by Michael Nordman
  • 2 edits in trunk/Source/WebCore

2011-03-11 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Adding the '~' to the dtor (duh).

No new tests.

  • storage/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
3:44 PM Changeset in webkit [80896] by ericu@chromium.org
  • 4 edits
    1 copy
    12 adds in trunk/LayoutTests

2010-3-11 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Add tests for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44363

Fix small bugs in the utility functions and add setFileContents().

  • fast/filesystem/resources/file-writer-utils.js:

Port the GC Blob test over to the new FileWriter utilities.

  • fast/filesystem/file-writer-gc-blob-expected.txt:
  • fast/filesystem/file-writer-gc-blob.html:
  • fast/filesystem/resources/file-writer-gc-blob.js: Copied from LayoutTests/fast/filesystem/file-writer-gc-blob.html.

Add tests for progress events and overlapping writes [via seek].

  • fast/filesystem/file-writer-events-expected.txt: Added.
  • fast/filesystem/file-writer-events.html: Added.
  • fast/filesystem/resources/file-writer-events.js: Added.
  • fast/filesystem/file-writer-write-overlapped-expected.txt: Added.
  • fast/filesystem/file-writer-write-overlapped.html: Added.
  • fast/filesystem/resources/file-writer-write-overlapped.js: Added.

Worker versions of the above tests.

  • fast/filesystem/workers/file-writer-events-expected.txt: Added.
  • fast/filesystem/workers/file-writer-events.html: Added.
  • fast/filesystem/workers/file-writer-gc-blob-expected.html: Added.
  • fast/filesystem/workers/file-writer-gc-blob.html: Added.
  • fast/filesystem/workers/file-writer-write-overlapped-expected.html: Added.
  • fast/filesystem/workers/file-writer-write-overlapped.html: Added.
3:41 PM Changeset in webkit [80895] by carol.szabo@nokia.com
  • 7 edits in trunk/Source/WebCore

2011-03-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Introduced double linkage between a CounterNode and its display renderer.

use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065

No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.

  • rendering/CounterNode.cpp: Introduced new member "m_owner" to store the renderer that has the style directives that produce the CounterNode. Repurposed m_renderer to reffer to the RenderCounter that shows the CounterNode. (WebCore::CounterNode::CounterNode): Updated member initialization. (WebCore::CounterNode::create): (WebCore::CounterNode::resetRenderer): (WebCore::CounterNode::resetRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::removeChild): (WebCore::CounterNode::insertAfter): No functional changes. (WebCore::showTreeAndMark): Added flushing to ensure that the output is complete.
  • rendering/CounterNode.h: (WebCore::CounterNode::owner): Renamed from renderer() (WebCore::CounterNode::renderer): (WebCore::CounterNode::setRenderer): Added new accessors for the display renderer.
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed comments. No functional changes. (WebCore::RenderCounter::~RenderCounter): Made sure that the CounterNode that this renderers displays is detached from this. (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): Added code to update m_renderer on the displayed CounterNode. (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): No change, just kept code in line with the changes above. (showCounterRendererTree): Added fflush to ensure complete display.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h: Removed unneeded invalidateCounters related functions.
3:39 PM Changeset in webkit [80894] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add missing unit tests to TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143

  • tests/TilingDataTest.cpp: (WebCore::TEST):
3:34 PM Changeset in webkit [80893] by Dimitri Glazkov
  • 9 edits
    2 adds in trunk/Source/WebCore

2011-03-11 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Introduce lookup-table based approach for applying CSS properties.
The aim is to be a starting point for refactoring
CSSStyleSelector::applyProperty() into more readable, maintainable code.
https://bugs.webkit.org/show_bug.cgi?id=54707

No new behavior / covered by existing tests.

  • css/CSSStyleApplyProperty.cpp: Added. (WebCore::ApplyPropertyNull): Class that provides empty implementations of inherit, initial, value. (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): Class that calls the appropriate RenderStyle setters directly. (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase): Class for handling CSSProperty*Color. (WebCore::ApplyPropertyColor::ApplyPropertyColor): Class for handling CSSPropertyColor. (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty): Singleton initializer. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Constructor that bulds up the map from property id to apply-er objects.
  • css/CSSStyleApplyProperty.h: Added. (WebCore::CSSStyleApplyProperty::inherit): Handle the inherit case for a given property. (WebCore::CSSStyleApplyProperty::initial): Handle the initial case for a given property. (WebCore::CSSStyleApplyProperty::value): Apply a value to a given property. (WebCore::CSSStyleApplyProperty::implements): Returns true if the provided property id is implemented. (WebCore::CSSStyleApplyProperty::index): Private function to determine the index of a property the property map. (WebCore::CSSStyleApplyProperty::valid): Function to determine that a given property id is valid. (WebCore::CSSStyleApplyProperty::setPropertyValue): (WebCore::CSSStyleApplyProperty::propertyValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Get reference to the CSSStyleApplyProperty singleton. (WebCore::CSSStyleSelector::applyProperty): Now calls into CSSStyleApplyProperty for implemented property ids. Deleted color-related methods from the property id switch.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::style): Made public to allow access from CSSStyleApplyProperty. (WebCore::CSSStyleSelector::parentStyle): Made public to allow access from CSSStyleApplyProperty.
  • rendering/style/RenderStyle.h: Made CSSStyleApplyProperty a friend class. Necessary because it needs to access the private getters and setters on this clsass.
3:24 PM Changeset in webkit [80892] by beidson@apple.com
  • 46 edits
    21 adds in trunk

Reviewed and landed by Brady Eidson.

Source/WebCore:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.

On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.

All StorageTracker file operations are performed on one background thread with a task queue.

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html

storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp:

(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):

  • page/PageGroup.h:
  • platform/chromium/FileSystemChromium.cpp:

(WebCore::listDirectory):

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::listDirectory):

  • storage/LocalStorageTask.cpp:

(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):

  • storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):

  • storage/StorageAreaImpl.h:
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):

  • storage/StorageAreaSync.h:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):

  • storage/StorageNamespaceImpl.h:
  • storage/StorageTracker.cpp: Added.

(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):

  • storage/StorageTracker.h: Added.
  • storage/StorageTrackerClient.h: Added.

(WebCore::StorageTrackerClient::~StorageTrackerClient):

Source/WebKit:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespaceProxy::clearOriginForDeletion):
(WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceProxy::sync):

  • src/StorageNamespaceProxy.h:

Source/WebKit/mac:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

  • Storage/WebStorageManager.mm: Added.

(+[WebStorageManager sharedWebStorageManager]):
(-[WebStorageManager origins]):
(-[WebStorageManager deleteAllOrigins]):
(-[WebStorageManager deleteOrigin:]):
(-[WebStorageManager syncLocalStorage]):
(-[WebStorageManager syncFileSystemAndTrackerDatabase]):
(storageDirectoryPath):
(WebKitInitializeStorageIfNecessary):

  • Storage/WebStorageManagerInternal.h: Added.
  • Storage/WebStorageManagerPrivate.h: Added.
  • Storage/WebStorageTrackerClient.h: Added.
  • Storage/WebStorageTrackerClient.mm: Added.

(WebStorageTrackerClient::sharedWebStorageTrackerClient):
(WebStorageTrackerClient::WebStorageTrackerClient):
(WebStorageTrackerClient::~WebStorageTrackerClient):
(WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
(WebStorageTrackerClient::dispatchDidModifyOrigin):

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin databaseIdentifier]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):

  • WebCoreSupport/WebSecurityOriginPrivate.h:
  • WebKit.exp:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

Tools:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/LayoutTestController.cpp:

(syncLocalStorageCallback):
(observeStorageTrackerNotificationsCallback):
(deleteAllLocalStorageCallback):
(deleteLocalStorageForOriginCallback):
(originsWithLocalStorageCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/StorageTrackerDelegate.h: Added.
  • DumpRenderTree/StorageTrackerDelegate.mm: Added.

(-[StorageTrackerDelegate init]):
(-[StorageTrackerDelegate logNotifications:controller:]):
(-[StorageTrackerDelegate originModified:]):
(-[StorageTrackerDelegate dealloc]):
(-[StorageTrackerDelegate setControllerToNotifyDone:]):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(observeStorageTrackerNotifications):
(syncLocalStorage):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):
(allocateGlobalControllers):
(releaseGlobalControllers):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

LayoutTests:

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

  • platform/chromium/test_expectations.txt:
  • storage/domstorage/localstorage/storagetracker: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added.
3:19 PM Changeset in webkit [80891] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185

url-parsing.html appears to be causing the crashes in later tests.
Skipping the url-parsing.html test and unskipping the url-with-credential.html test.

Unreviewed.

  • platform/win/Skipped:
3:15 PM Changeset in webkit [80890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-11 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add an accessibilityIsIgnored method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=50969

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::accessibilityIsIgnored):
2:55 PM Changeset in webkit [80889] by rniwa@webkit.org
  • 5 edits
    12 deletes in trunk/LayoutTests

2011-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

drag-text-delay.html should be a dump as text test
https://bugs.webkit.org/show_bug.cgi?id=56223

Converted the test to a dump as text. Also reorganized the test code and added more descriptions.

  • editing/selection/drag-text-delay-expected.txt:
  • editing/selection/drag-text-delay.html:
  • platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/mac/editing/selection/drag-text-delay-expected.txt:
  • platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
  • platform/win/editing/selection/drag-text-delay-expected.png: Removed.
  • platform/win/editing/selection/drag-text-delay-expected.txt:
2:53 PM Changeset in webkit [80888] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaMethod does not correctly check for a null jstring for the method name
https://bugs.webkit.org/show_bug.cgi?id=56187

No new tests, simple typo fix.

  • bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod):
2:50 PM Changeset in webkit [80887] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):
2:44 PM Changeset in webkit [80886] by mihaip@chromium.org
  • 8 edits
    1 add
    1 delete in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Chromium Mac expectations update. Rebaseline some more tests after
r80582.

  • fast/repaint/text-emphasis-h-expected.checksum:
  • fast/repaint/text-emphasis-h-expected.png:
  • platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
2:20 PM Changeset in webkit [80885] by mihaip@chromium.org
  • 31 edits
    4 deletes in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Chromium Mac expectations update. Rebaseline some tests after r80582
(those that already had chromium-mac-leopard baselines).

  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
2:10 PM Changeset in webkit [80884] by jberlin@webkit.org
  • 5 edits
    1 add in trunk

Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
Process has finished launching.
https://bugs.webkit.org/show_bug.cgi?id=56208

Reviewed by Adam Roben.

Source/WebKit2:

Only send the message if the Web Process is valid.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::clearResourceCaches):

Tools:

  • TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.

(TestWebKitAPI::TEST):
Test that calling WKContextClearResourceCaches works with both options when called before
the Web Process is valid.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add the new test.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Ditto.

2:08 PM Changeset in webkit [80883] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=52987

Reviewed by Simon Fraser.

REGRESSION: Overflowing columns not repainted correctly

Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not
sufficient, since blocks paint their own columns.

Added fast/multicol/scrolling-overflow.html

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):

LayoutTests:

  • fast/multicol/scrolling-overflow.html: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/mac/fast/multicol/scrolling-overflow-expected.txt: Added.
1:59 PM Changeset in webkit [80882] by Dimitri Glazkov
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56217

  • gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory

to the scripts.

  • gyp/generate-derived-sources.sh: Changed to use passed directory.
  • gyp/generate-dtrace-header.sh: Ditto.
1:34 PM Changeset in webkit [80881] by mihaip@chromium.org
  • 6 edits in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Mac and Chromium expectations update. Remove failing expectations for
tests that no longer fail. Rebaseline fast/overflow/
overflow-rtl-vertical.html and fast/lists/008-vertical.html after
r80755.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:
1:25 PM Changeset in webkit [80880] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Set canvasUsesAcceleratedDrawing setting to be off(false) by default
https://bugs.webkit.org/show_bug.cgi?id=56215

No new tests. Does not affect behavior. Just keeping the setting off by default.

  • page/Settings.cpp: (WebCore::Settings::Settings):
1:22 PM Changeset in webkit [80879] by mihaip@chromium.org
  • 2 edits
    4 moves in trunk/LayoutTests

2011-03-11 Mihai Parparita <mihaip@chromium.org>

Update Chromium expectations. Remove some commented out lines and
promote some expectatiosn from chromium-mac to mac-leopard, so that
those tests pass on chromium Snow Leopard (and mac Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum.
  • platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png.
  • platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum.
  • platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png.
1:21 PM Changeset in webkit [80878] by aestes@apple.com
  • 5 edits
    4 adds in trunk

2011-03-11 Andy Estes <aestes@apple.com>

Reviewed by David Hyatt.

Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174


Table cells ignore their specified size and collapse to fit their
children. When a descendent with percentage height is present before
the table is first laid out, the descendent is sized based on the
specified size of the table cell. However, when the child isn't present
when the table is first laid out, the table cell ignores its specified
size and collapses down to 0. Then, when the child div is added in a
separate run loop iteration, it is sized to be 100% of the collapsed
cell height instead of 100% of the cell's specified height. We should
not get different layouts depending on the timing of tree construction.


Fix this by clearing intrinsic padding before calculating the table
cell's override height when we detect a child that should flex the
table cell.

Test: fast/table/dynamic-descendant-percentage-height.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear intrinsic padding before setting the override size.
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Call setOverrideSizeFromRowHeight() instead of setOverrideSize().

2011-03-11 Andy Estes <aestes@apple.com>

Reviewed by David Hyatt.

Table cells with dynamically added percentage height descendants do not
grow in size if the table has already been laid out.
https://bugs.webkit.org/show_bug.cgi?id=56174

  • fast/table/dynamic-descendant-percentage-height.html: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
1:15 PM Changeset in webkit [80877] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/css/CSSParser.cpp

Fix Windows build bustage.

1:09 PM Changeset in webkit [80876] by Michael Nordman
  • 10 edits
    1 add in trunk/Source/WebCore

2011-03-11 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

Add SQLCallbackWrapper
Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
https://bugs.webkit.org/show_bug.cgi?id=55919

No new tests, existing tests apply.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/SQLCallbackWrapper.h: Added. (WebCore::SQLCallbackWrapper::SQLCallbackWrapper): (WebCore::SQLCallbackWrapper::clear): (WebCore::SQLCallbackWrapper::unwrap): (WebCore::SQLCallbackWrapper::hasCallback): (WebCore::SQLCallbackWrapper::safeRelease):
  • storage/SQLStatement.cpp: (WebCore::SQLStatement::create): (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::performCallback):
  • storage/SQLStatement.h: (WebCore::SQLStatement::hasStatementCallback): (WebCore::SQLStatement::hasStatementErrorCallback):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase): (WebCore::SQLTransaction::deliverTransactionCallback): (WebCore::SQLTransaction::deliverStatementCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::deliverSuccessCallback): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback):
  • storage/SQLTransaction.h:
12:52 PM Changeset in webkit [80875] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't paint more than 60 times per second
https://bugs.webkit.org/show_bug.cgi?id=56206
<rdar://problem/9085989>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired.

(WebKit::DrawingAreaImpl::didUpdate):
Call displayTimerFired instead of display.

(WebKit::DrawingAreaImpl::displayTimerFired):
If we're asked to paint again less than 1/60th of a second after we've already painted,
defer painting.

(WebKit::DrawingAreaImpl::display):
Update m_lastDisplayTime.

12:48 PM Changeset in webkit [80874] by eric.carlson@apple.com
  • 7 edits
    5 adds in trunk/Source

2011-03-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.

No new tests, existing media tests cover this.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC. (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace. (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto. (WebCore::MediaPlayer::inMediaDocument): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.

2011-03-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8955589> Adopt AVFoundation media back end on Lion.

No new tests, existing media tests cover this.

  • JavaScriptCore.exp: Export cancelCallOnMainThread
  • wtf/Platform.h: Define WTF_USE_AVFOUNDATION.
12:27 PM Changeset in webkit [80873] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56205
m_restrictions needs to allow multiple values (a bitfield)

HTMLMediaElement::m_restrictions needs to hold multiple values, so
change BehaviorRestrictions to an unsigned typedef and rename the
existing enum BehaviorRestrictionFlags.

  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::setBehaviorRestrictions):
12:23 PM Changeset in webkit [80872] by Dimitri Glazkov
  • 12 edits in trunk/LayoutTests

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

[GTK] Update expectations after r80857.
https://bugs.webkit.org/show_bug.cgi?id=55972

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
12:13 PM Changeset in webkit [80871] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47206

Reviewed by Dan Bernstein.

Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
properly constructed.

Added fast/css-generated-content/table-row-before-after.html

Source/WebCore:

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

  • rendering/RenderTableRow.h:

LayoutTests:

  • fast/css-generated-content/table-row-before-after.html: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added.
12:00 PM Changeset in webkit [80870] by jamesr@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80869 - 2011-03-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209

This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateContentsRecursive):

TBR=jamesr@google.com
BUG=75563

11:59 AM Changeset in webkit [80869] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
https://bugs.webkit.org/show_bug.cgi?id=56209

This matches the behavior prior to r80482. No test since the only changes in
behavior are avoiding work on invisible layers, which is unobservable,
and fixing a crash due to bug 56153.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateContentsRecursive):
11:56 AM Changeset in webkit [80868] by hyatt@apple.com
  • 31 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47159

Reviewed by Simon Fraser.

CSS2.1 failures in background position parsing.

Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid
when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
it to understand what the first component was.

For individual property parsing using background-position-x/y, I added new functions that just handle that without
worrying about the other component.

In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple
backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers
has been changed to always consider a layer empty if it has no image set, even if other properties are set.

A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position
parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style
should actually include the additional values when no image is set though, so that should perhaps be the subject of a
follow-up bug.

Added fast/backgrounds/background-position-parsing.html

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):

  • css/CSSParser.h:
  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::cullEmptyLayers):

LayoutTests:

  • fast/backgrounds/background-position-1.html:
  • fast/backgrounds/background-position-parsing.html: Added.
  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
  • fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
  • fast/backgrounds/resources/diamond.png: Added.
  • fast/backgrounds/resources/ring.png: Added.
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/mac/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/mac/fast/backgrounds/bgCompositeCopy-expected.png:
  • platform/mac/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize03-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
11:50 AM Changeset in webkit [80867] by vangelis@chromium.org
  • 4 edits
    4 adds in trunk

2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding a test for rotated large layers.
https://bugs.webkit.org/show_bug.cgi?id=55984

  • platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/huge-layer-rotated.html: Added.

2011-03-11 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=55984

Test: platform/chromium/compositing/huge-layer-rotated.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
11:18 AM Changeset in webkit [80866] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52468

Added WIN32 to the ifdef controlling whether animations are applied in normal or
reverse order. On Mac, animations used to be applied in reverse, but
<rdar://problem/7095638> fixed this in the release after Snow Leopard.
But that patch has not be applied to the Safari Windows SDK yet. For now
I've made Windows use the reverse order logig. <rdar://problem/9112233> is
tracking the inclusion of the patch on Windows.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
11:11 AM Changeset in webkit [80865] by Dimitri Glazkov
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56207

  • JavaScriptCore.gypi: Added Tracing.d to the sources.
  • gyp/generate-dtrace-header.sh: Added.
  • gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them),

and added DTrace header generating step.

10:58 AM Changeset in webkit [80864] by Adam Roben
  • 4 edits
    3 copies
    1 add
    1 delete in trunk/Tools

Make it possible to view all leaks from a build at once in Leaks Viewer

You can now give Leaks Viewer the URL of a build results page (e.g.,
<http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
will load all the leaks files from that build.

Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
files from a particular build at once, rather than one at a time

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.

(LeaksLoader): Initialize our properties.
(LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
load it. Otherwise assume it's a build results page URL and start fetching the leaks files
from that page.
(LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
so it can provide feedback. Then load each one and pass it to the client.
(LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
it into a DOM, pull out all the links to leaks files, and load each one.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.

(LeaksParser): Initialize our worker.
(LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.

This code mostly came from Worker.js.
(LeaksParserWorker): Initialize our profile.
(LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
profile.
(LeaksParserWorker.prototype._parseLeaks):
(LeaksParserWorker.prototype._createNode):
(LeaksParserWorker.prototype._incorporateLeaks):
Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
version of createProfile which adds to this.profile instead of making a new profile each
time.
(onmessage): Parse the file and send back the new profile.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#loading-indicator):
(#spinner):
(#loading-indicator-label):
Tweaked styles to accomodate a longer label.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.loaded): Set up a loader and parser.

(LeaksViewer.get filesLeftToParse):
(LeaksViewer.set filesLeftToParse):
Added these simple accessors.

(LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
(LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
the parser.
(LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
tell the ProfilerAgent and mark that we're done loading. (Code came from the old
_loadLeaksFromURL function).
(LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
(LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
loading indicator, including the number of files being loaded.
(LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
(LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
(LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
_loadingIndicatorText.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.

(getResource): Moved here from LeaksViewer.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by

LeaksParserWorker.js.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS

files, added a #loading-indicator-label element, and tweaked the prompt wording.

10:57 AM Changeset in webkit [80863] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger a build when build.webkit.org's HTML files are modified

Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
directories that shouldn't trigger builds. Re-sorted the list.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added a test to cover the above change.

10:47 AM Changeset in webkit [80862] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-11 Avi Drissman <avi@google.com>

Reviewed by Tony Chang.

Fix missing initialization of new member variables.
https://bugs.webkit.org/show_bug.cgi?id=50969

  • public/WebMenuItemInfo.h: (WebKit::WebMenuItemInfo::WebMenuItemInfo):
10:29 AM Changeset in webkit [80861] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355

Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.

However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.

This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.

I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.

Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does the right thing whether we are just before a token or waiting for a script. Now that we may yield before a token or before a script, this may be called while paused.
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  • page/FrameView.h: (WebCore::FrameView::hasEverPainted): Added.
10:24 AM Changeset in webkit [80860] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] Entering fullscreen and leaving it may hide the cursor of the application.
https://bugs.webkit.org/show_bug.cgi?id=56181

We need to stop the auto hide cursor timer when closing the widget otherwise the timer
might get fired and therefore hide the cursor even when the fullscreen widget is closed.

  • WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::closeEvent):
10:12 AM Changeset in webkit [80859] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dimitri Glazkov <Dimitri Glazkov>

Fix crashes in dom/html/level2/html/HTMLInputElement*.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,

because e can certainly be a null.

9:59 AM Changeset in webkit [80858] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Choke text-decoration when entering shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=56044

No new tests, because the functionality can't be tested yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
9:55 AM Changeset in webkit [80857] by Dimitri Glazkov
  • 13 edits in trunk

2011-03-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972

Update test results, because they are now laying out timeline consistently.

  • media/audio-repaint-expected.txt: Updated.
  • platform/mac/media/audio-controls-rendering-expected.checksum: Ditto.
  • platform/mac/media/audio-controls-rendering-expected.png: Ditto.
  • platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
  • platform/mac/media/audio-repaint-expected.checksum: Ditto.
  • platform/mac/media/audio-repaint-expected.png: Ditto.

2011-03-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=55972

Instead of poking at the time display elements all the way from RenderMedia,
let the standard layout cycle take care of things. Move the logic of calculating
when to collapse the time display elements into a custom renderer, since
this is not something that can be accomplished with CSS.

Also, the logic of keeping the timeline slider at least 100px needed refreshing,
since it didn't actually keep it at 100px.

  • html/shadow/MediaControls.cpp: Moved the logic of determining visibility

of time display elements to RenderMediaControlTimeDisplay, eliminating
updateTimeDisplayVisibility method.

  • html/shadow/MediaControls.h: Removed decl.
  • rendering/MediaControlElements.cpp: (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):

Added new renderer class.

(WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)

size-sensing logic, still using hard-coded values.

(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Removed m_isVisible member, which is no longer necessary.

(WebCore::MediaControlTimeDisplayElement::createRenderer): Added to

return the new renderer.

  • rendering/MediaControlElements.h: Adjusted decls.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at

media controls in layout.

9:28 AM Changeset in webkit [80856] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-03-11 Marco Peereboom <marco@peereboom.us>

Reviewed by Gustavo Noronha Silva.

Provide a knob to enable/disable DNS prefetching.
DNS prefetching is enabled by default.
https://bugs.webkit.org/show_bug.cgi?id=55973

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
9:19 AM Changeset in webkit [80855] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-03-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Start focusing updates to media controls, away from always updating everything.
https://bugs.webkit.org/show_bug.cgi?id=56038

For now, the new methods just call generic MediaControls::update.

Covered by existing tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset. (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute. (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume. (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls

accessor.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use

MediaControls::changedClosedCaptionsVisibility.

(WebCore::HTMLMediaElement::mediaControls): Added.
(WebCore::HTMLMediaElement::hasMediaControls): Added.

  • html/HTMLMediaElement.h: Added decls.
  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::reset): Added. (WebCore::MediaControls::changedMute): Added. (WebCore::MediaControls::changedVolume): Added. (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
  • html/shadow/MediaControls.h: Added decls.
9:09 AM Changeset in webkit [80854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Martin Robinson.

[GStreamer] When seeking webKitWebSrcStop release the frame but should not.
https://bugs.webkit.org/show_bug.cgi?id=55703

When calling webKitWebSrcStop in case of a seeking, the frame should not
be reset (the source hasn't change). The frame may be used to get the network
context. Some network stack (like Qt) are relaying on the network context
to work.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStop):
7:08 AM Changeset in webkit [80853] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Unreviewed.

Build fixes for GTK and Leopard.

  • bindings/gobject/GNUmakefile.am:
  • add missing WebKitAnimation* generated bindings
  • page/WebKitAnimation.idl:
  • use double in place of float (the core values are double anyway)
7:05 AM Changeset in webkit [80852] by Adam Roben
  • 5 edits in trunk/LayoutTests

Update Windows results after r80846

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
6:56 AM Changeset in webkit [80851] by Adam Roben
  • 2 edits in trunk/Tools

Roll out r80848

It was accidentally committed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._loadLeaksFromURL):

6:51 AM Changeset in webkit [80850] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

The crash is tracked by <http://webkit.org/b/56185>.

  • platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped

possibly-related websocket crashes.

6:51 AM Changeset in webkit [80849] by Adam Roben
  • 1 edit
    1 move in trunk/LayoutTests

Disable fast/text/large-text-composed-char-dos.html

It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.

  • fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.
6:49 AM Changeset in webkit [80848] by Adam Roben
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js

Work on fetching all leaks for a build

6:19 AM Changeset in webkit [80847] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-11 Dean Jackson <dino@apple.com>

Unreviewed build fix for QT.

  • WebCore.pro:
6:05 AM Changeset in webkit [80846] by dino@apple.com
  • 32 edits
    11 adds in trunk

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations

This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is a read-only API - a subsequent commit will add the ability
to scrub animations.

Test: animations/animation-api-1.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • All build settings updated for new files
  • bindings/js/JSBindingsAllInOne.cpp:
  • Include new custom files
  • bindings/js/JSWebKitAnimationCustom.cpp: Added. (WebCore::JSWebKitAnimation::iterationCount):
  • Custom property getter so that we can return INFINITY
  • bindings/js/JSWebKitAnimationListCustom.cpp: Added. (WebCore::JSWebKitAnimationList::markChildren):
  • Make sure WebKitAnimations are marked
  • bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added. (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
  • Custom property getter so that we can return INFINITY
  • dom/Element.cpp: (WebCore::Element::webkitGetAnimations):
  • dom/Element.h:
  • dom/Element.idl:
  • New API entry point
  • page/DOMWindow.idl:
  • Constructor definitions for WebKitAnimation and WebKitAnimationList
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::~AnimationBase):
  • Since AnimationBase can now live longer (if a WebKitAnimation is held in Javascript) we need to guard for the renderer having disappeared. (WebCore::AnimationBase::setElapsedTime): (WebCore::AnimationBase::play): (WebCore::AnimationBase::pause):
  • Stub implementations at present
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::animation):
  • Expose the Animation properties
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::animationsForRenderer): (WebCore::AnimationController::animationsForRenderer):
  • Builds the list of WebKitAnimations
  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • Make sure we clear the renderer if we are removing the animation (WebCore::CompositeAnimation::animations):
  • page/animation/CompositeAnimation.h:
  • page/animation/WebKitAnimation.cpp: Added. (WebCore::WebKitAnimation::WebKitAnimation): (WebCore::WebKitAnimation::name): (WebCore::WebKitAnimation::duration): (WebCore::WebKitAnimation::elapsedTime): (WebCore::WebKitAnimation::setElapsedTime): (WebCore::WebKitAnimation::delay): (WebCore::WebKitAnimation::iterationCount): (WebCore::WebKitAnimation::paused): (WebCore::WebKitAnimation::ended): (WebCore::WebKitAnimation::direction): (WebCore::WebKitAnimation::fillMode): (WebCore::WebKitAnimation::pause): (WebCore::WebKitAnimation::play):
  • The implementation of the new API. All the read-only parts are done, but elapsedTime, play() and pause() are stubs.
  • page/animation/WebKitAnimation.h: Added. (WebCore::WebKitAnimation::create): (WebCore::WebKitAnimation::~WebKitAnimation):
  • page/animation/WebKitAnimation.idl: Added.
  • page/animation/WebKitAnimationList.cpp: Added.
  • page/animation/WebKitAnimationList.h: Added.
  • page/animation/WebKitAnimationList.idl: Added.
  • Copies NodeList implementation

2011-03-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

https://bugs.webkit.org/show_bug.cgi?id=54151
Implement an API to play/pause/scrub animations

This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
APIs, exposed via Element.getWebKitAnimations(). This first pass
is read-only. One new layout test that examines animation
properties. Update existing layout tests for the new interfaces
on Window.

  • animations/animation-api-1-expected.txt: Added.
  • animations/animation-api-1.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
5:38 AM Changeset in webkit [80845] by loislo@chromium.org
  • 34 edits in trunk

2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end: number of files

2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce error argument for all the callbacks on frontend.
https://bugs.webkit.org/show_bug.cgi?id=56100

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console/console-dir-global.html:
  • inspector/elements/dom-agent-query-selector.html:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.stopTimeline):
5:26 AM Changeset in webkit [80844] by yurys@chromium.org
  • 34 edits
    2 copies
    2 adds in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp. (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::disconnect): (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::setFrontend): (WebCore::InjectedScriptHost::clearFrontend):
  • inspector/InjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::create): (WebCore::InjectedScriptManager::InjectedScriptManager): (WebCore::InjectedScriptManager::~InjectedScriptManager): (WebCore::InjectedScriptManager::disconnect): (WebCore::InjectedScriptManager::injectedScriptHost): (WebCore::InjectedScriptManager::injectedScriptForId): (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::releaseObjectGroup): (WebCore::InjectedScriptManager::injectedScriptSource): (WebCore::InjectedScriptManager::injectScript):
  • inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
4:50 AM Changeset in webkit [80843] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180

Skipping a couple of tests until the original issue is fixed.

  • platform/gtk/Skipped:
4:10 AM Changeset in webkit [80842] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
3:56 AM Changeset in webkit [80841] by sergio@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

Added new GTK+ test expectations.

  • platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
  • platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.png: Added.
  • platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
  • platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
  • platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
3:23 AM Changeset in webkit [80840] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hover over elements in Elements panel does not highlight nodes
https://bugs.webkit.org/show_bug.cgi?id=56121

In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
for these 16px when computing the test point coordinates.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
2:53 AM Changeset in webkit [80839] by yurys@chromium.org
  • 33 edits
    4 deletes in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Roll out r80837.

2:47 AM Changeset in webkit [80838] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.

  • inspector/report-API-errors.html:
2:37 AM Changeset in webkit [80837] by yurys@chromium.org
  • 33 edits
    2 copies
    2 adds in trunk

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
https://bugs.webkit.org/show_bug.cgi?id=56173

Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp. (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::InjectedScriptManager::createInjectedScript): (WebCore::InjectedScriptManager::discardInjectedScript): (WebCore::InjectedScriptManager::injectedScriptFor): (WebCore::InjectedScriptManager::canAccessInspectedWindow):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::~InjectedScriptHost): (WebCore::InjectedScriptHost::disconnect): (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init): (WebCore::InjectedScriptHost::setFrontend): (WebCore::InjectedScriptHost::clearFrontend):
  • inspector/InjectedScriptManager.cpp: Added. (WebCore::InjectedScriptManager::create): (WebCore::InjectedScriptManager::InjectedScriptManager): (WebCore::InjectedScriptManager::~InjectedScriptManager): (WebCore::InjectedScriptManager::disconnect): (WebCore::InjectedScriptManager::injectedScriptHost): (WebCore::InjectedScriptManager::injectedScriptForId): (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::discardInjectedScripts): (WebCore::InjectedScriptManager::releaseObjectGroup): (WebCore::InjectedScriptManager::injectedScriptSource): (WebCore::InjectedScriptManager::injectScript):
  • inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
2:26 AM Changeset in webkit [80836] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] close-web-view emitted on disposed WebView
https://bugs.webkit.org/show_bug.cgi?id=55932

  • WebCoreSupport/ChromeClientGtk.cpp: (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib source before destruction of the ChromeClient.
2:26 AM Changeset in webkit [80835] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-11 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipping two test cases that are failing on GTK debug bots.

  • platform/gtk/Skipped:
2:04 AM Changeset in webkit [80834] by hans@chromium.org
  • 5 edits
    1 move
    1 add in trunk/Source/WebCore

2011-03-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Make IDBBackingStore abstract
https://bugs.webkit.org/show_bug.cgi?id=56013

Make IDBBackingStore abstract to allow for multiple implementations.
Move the SQLite implementation to IDBSQLiteBackingStore.

No new tests: refactoring only.

  • WebCore.gypi:
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::~IDBBackingStore):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore): (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore): (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::getDatabaseSchemaVersion): (WebCore::migrateDatabase): (WebCore::IDBSQLiteBackingStore::open): (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData): (WebCore::IDBSQLiteBackingStore::getObjectStores): (WebCore::IDBSQLiteBackingStore::createObjectStore): (WebCore::doDelete): (WebCore::IDBSQLiteBackingStore::deleteObjectStore): (WebCore::whereSyntaxForKey): (WebCore::bindKeyToQuery): (WebCore::lowerCursorWhereFragment): (WebCore::upperCursorWhereFragment): (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord): (WebCore::bindKeyToQueryWithNulls): (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::clearObjectStore): (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber): (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore): (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord): (WebCore::IDBSQLiteBackingStore::getIndexes): (WebCore::IDBSQLiteBackingStore::createIndex): (WebCore::IDBSQLiteBackingStore::deleteIndex): (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord): (WebCore::IDBSQLiteBackingStore::getObjectViaIndex): (WebCore::keyFromQuery): (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBSQLiteBackingStore::keyExistsInIndex): (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor): (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor): (WebCore::IDBSQLiteBackingStore::openIndexCursor): (WebCore::IDBSQLiteBackingStore::createTransaction):
  • storage/IDBSQLiteBackingStore.h: Added.
1:44 AM Changeset in webkit [80833] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build error fix.

[EFL] Fix build break when SHARED_CORE is ON
https://bugs.webkit.org/show_bug.cgi?id=56155

  • platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/efl/ContextMenuItemEfl.cpp: (WebCore::ContextMenuItem::nativeMenuItem): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem):
1:28 AM Changeset in webkit [80832] by caseq@chromium.org
  • 9 edits
    1 add in trunk

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764

  • mark interruptionForPolicyChangeError as cancellation
  • do not log resource cancelation as an error
  • always push resource to front-end before console message, so front-end can use resource info while formatting message.
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::didFailLoading):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::stopLoadingForPolicyChange):

2011-03-11 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resource load cancellation is reported to console as an error
https://bugs.webkit.org/show_bug.cgi?id=55764

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download)
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors.
  • http/tests/inspector/resources/empty.zip: Added.
1:02 AM Changeset in webkit [80831] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
https://bugs.webkit.org/show_bug.cgi?id=56096

No new tests, as this is a refactoring.

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane):
  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.FrameTreeElement): (WebInspector.FrameResourceTreeElement): (WebInspector.DatabaseTreeElement): (WebInspector.DatabaseTableTreeElement): (WebInspector.DOMStorageTreeElement): (WebInspector.CookieTreeElement): (WebInspector.ApplicationCacheTreeElement): (WebInspector.ResourceRevisionTreeElement):
  • inspector/front-end/utilities.js: (Element.prototype.removeStyleClass): (Element.prototype.addStyleClass): (Element.prototype.hasStyleClass):
12:20 AM Changeset in webkit [80830] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-03-11 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

kill hung lighttpd processes on the chromium win bot
https://bugs.webkit.org/show_bug.cgi?id=56152

Sometimes this process doesn't exit and it holds on to
a log file that we can't delete or copy, causing the tests
to go red.

  • BuildSlaveSupport/win/kill-old-processes:
12:17 AM Changeset in webkit [80829] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9120161> WKPageRestoreFromSessionState does not set the pending API request URL.

Reviewed by Alice Liu.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item
as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will
be done by our call to loadURL elsewhere in the function.

12:11 AM Changeset in webkit [80828] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-11 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

[Chromium] missing HTMLInputElement::setValueForUser() to tests
https://bugs.webkit.org/show_bug.cgi?id=55854

  • platform/chromium/test_expectations.txt: Removed onchange-setvalueforuser.html

2011-03-11 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

[Chromium] missing HTMLInputElement::setValueForUser() to tests
https://bugs.webkit.org/show_bug.cgi?id=55854

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setValueForUser): Added.
  • DumpRenderTree/chromium/LayoutTestController.h:
12:10 AM Changeset in webkit [80827] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-11 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip
tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
on GTK again after being unskipped by accident in r80738.

  • platform/gtk/Skipped:
12:06 AM Changeset in webkit [80826] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-11 Brian Salomon <bsalomon@google.com>

Reviewed by Kenneth Russell.

Adds GrContext flush call to PlatformContextSkia destructor.

Calls GrContext flush with int parameter instead of bool due to skia
revision.

No new tests needed.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
Note: See TracTimeline for information about the timeline view.