Timeline


and

03/22/11:

23:44 Changeset [81753] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] skia image encoders should use <wtf/Vector.h>
https://bugs.webkit.org/show_bug.cgi?id=56893

No new tests. Covered by existing canvas.toDataURL tests.

  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.h:
22:42 Changeset [81752] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

Unskipped some tests, now that https://bugs.webkit.org/show_bug.cgi?id=54490
is fixed.

Rubber-stamped by Beth Dakin.

  • platform/win/Skipped:
22:21 Changeset [81751] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts
panel on Windows, and many inspector regression tests are failing
https://bugs.webkit.org/show_bug.cgi?id=54490


The bug was caused by two different classes using the same name (Recompiler).

  • debugger/Debugger.cpp:
  • runtime/JSGlobalData.cpp: (WTF::Recompiler::operator()): Put Recompiler in an anonymous namespace, so our two recompilers' inline functions don't stomp each other at link time.
22:15 Changeset [81750] by mihaip@chromium.org
  • 1 edit
    82 moves
    1 add
    41 deletes in trunk/LayoutTests

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Fix baselines for svg/W3C-I18N for Chromium Snow Leopard. Mac SL
baselines were added with r81168, so the Chromium ones only need to
be in chromium-mac-leopard/ (so that they don't override them). The
chromium-mac/ text baselines can be deleted, since we can now
fall back on the mac-leopard/ ones added by r81176.

  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
21:51 Changeset [81749] by mihaip@chromium.org
  • 1 edit
    90 moves
    90 adds in trunk/LayoutTests

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Add Snow Leopard baselines for fast/html/details* tests added by r81035
(should work for both Mac and Chromium-Mac). Promote current
chromium-mac baselines to mac-leopard, since they work for both on
Leopard.

  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.checksum.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.png.
  • platform/mac-leopard/fast/html/details-open1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.checksum.
  • platform/mac-leopard/fast/html/details-open1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.png.
  • platform/mac-leopard/fast/html/details-open2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.checksum.
  • platform/mac-leopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/mac-leopard/fast/html/details-open3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.checksum.
  • platform/mac-leopard/fast/html/details-open3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.png.
  • platform/mac-leopard/fast/html/details-open4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.checksum.
  • platform/mac-leopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/mac-leopard/fast/html/details-open5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.checksum.
  • platform/mac-leopard/fast/html/details-open5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.png.
  • platform/mac-leopard/fast/html/details-open6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.checksum.
  • platform/mac-leopard/fast/html/details-open6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.png.
  • platform/mac-leopard/fast/html/details-position-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.checksum.
  • platform/mac-leopard/fast/html/details-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.checksum.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.png.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/mac/fast/html/details-open1-expected.checksum: Added.
  • platform/mac/fast/html/details-open1-expected.png: Added.
  • platform/mac/fast/html/details-open2-expected.checksum: Added.
  • platform/mac/fast/html/details-open2-expected.png: Added.
  • platform/mac/fast/html/details-open3-expected.checksum: Added.
  • platform/mac/fast/html/details-open3-expected.png: Added.
  • platform/mac/fast/html/details-open4-expected.checksum: Added.
  • platform/mac/fast/html/details-open4-expected.png: Added.
  • platform/mac/fast/html/details-open5-expected.checksum: Added.
  • platform/mac/fast/html/details-open5-expected.png: Added.
  • platform/mac/fast/html/details-open6-expected.checksum: Added.
  • platform/mac/fast/html/details-open6-expected.png: Added.
  • platform/mac/fast/html/details-position-expected.checksum: Added.
  • platform/mac/fast/html/details-position-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/mac/fast/html/details-writing-mode-expected.png: Added.
21:28 Changeset [81748] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 81648
BUG=76784

20:44 Changeset [81747] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Move the cellWidthChanged bit out of RenderObject and back down into RenderTableCell in order to
free up a bit for another performance optimization I have planned.

Reviewed by Beth Dakin.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setHasColumns):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::cellWidthChanged):
(WebCore::RenderTableCell::setCellWidthChanged):

20:27 Changeset [81746] by hyatt@apple.com
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56892

Reviewed by Dan Bernstein.

Adding floats to an empty block is O(n2).

If you just add floats back to back to an empty block, the addition is essentially O(n2)
once the floats move below your current line position. This is because we repeatedly ask for the
available width for the line from scratch every time we add a float, regardless of whether the
float even vertically intersected our current line position.

Change positionNewFloatOnLine to update left and right line offsets intelligently and to only
do it based off the single new float that just got added.

This fix cuts the IE MazeSolver time in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

20:15 Changeset [81745] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=56890 It is possible to calculate a
NaN value for "value" in ScrollbarThemeMac::paint()
-and corresponding-
<rdar://problem/9160621>

Reviewed by Sam Weinig.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

20:09 Changeset [81744] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-22 Ojan Vafai <ojan@chromium.org>

Add a chromium expectation for this test. V8's exception logging
is more specific than JSC's.

  • platform/chromium/fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
18:45 Changeset [81743] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove identity from dragTargetDragEnter() function signature
https://bugs.webkit.org/show_bug.cgi?id=56875

First part of 3-sided patch. Add new function signature sans identity.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter):
  • src/WebViewImpl.h:
18:44 Changeset [81742] by ojan@chromium.org
  • 18 edits
    4 adds in trunk

2011-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/pseudo-any-expected.txt: Added.
  • fast/css/pseudo-any.html: Added.
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
  • fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
  • fast/dom/SelectorAPI/unknown-pseudo.html: Added.

2011-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

For now, match the Mozilla implementation with respect to specificity
and only allowing simple selectors. Both of these are likely to change
pending discussion on www-style@.

Tests: fast/css/pseudo-any.html

fast/dom/SelectorAPI/unknown-pseudo.html

  • css/CSSGrammar.y: Create simple_selector_list. This is exactly like selector_list except it only allows simple selectors and creates a new vector instead of a reusable one since there can be multiple in one rule.
  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::createFloatingSelectorVector): (WebCore::CSSParser::sinkFloatingSelectorVector):
  • css/CSSParser.h:
  • css/CSSParserValues.cpp: (WebCore::CSSParserSelector::adoptSelectorVector):
  • css/CSSParserValues.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::selectorText): (WebCore::CSSSelector::setSelectorList): (WebCore::CSSSelector::RareData::RareData): (WebCore::CSSSelector::RareData::~RareData): These need to be moved into the cpp file so that we can have an OwnPtr<CSSSelectorList> in CSSSelector::RareData.
  • css/CSSSelector.h: (WebCore::CSSSelector::selectorList):
  • css/CSSSelectorList.cpp: (WebCore::forEachTagSelector):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector):
  • css/tokenizer.flex:
18:27 Changeset [81741] by mihaip@chromium.org
  • 1 edit
    45 deletes in trunk/LayoutTests

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Remove duplicated test expectations for details tests (expectations were
added to the mac/ directory with r81062, so chromium-mac ones are no
longer necessary).

  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Removed.
18:24 Changeset [81740] by commit-queue@webkit.org
  • 17 edits in trunk/Source

2011-03-22 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=56431

For the accelerated compositing case, only prepare the texture if it
has been updated since the last composite. For the non-accelerated case, make sure to
grab a copy of the image buffer and paint from that if the backbuffer
would be cleared.

In both cases, make sure to clear the context's backbuffer before the
first operation that uses it.

No new tests. It seems to be difficult/impossible to trigger an early
compositing operation in DumpRenderTree, making this hard to
test automatically. However, Chromium and Safari (Mac) have been
tested manually on the webgl conformance test for this.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::makePresentationCopy): (WebCore::HTMLCanvasElement::clearPresentationCopy):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLContextAttributes.cpp: (WebCore::WebGLContextAttributes::preserveDrawingBuffer): (WebCore::WebGLContextAttributes::setPreserveDrawingBuffer):
  • html/canvas/WebGLContextAttributes.h:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::markLayerComposited): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::readPixels):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty): (WebCore::WebGLLayerChromium::textureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::layerComposited):

2011-03-22 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=56431

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::markContextChanged): (WebCore::GraphicsContext3DInternal::markLayerComposited): (WebCore::GraphicsContext3DInternal::layerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • src/GraphicsContext3DInternal.h:
18:19 Changeset [81739] by weinig@apple.com
  • 9 edits in trunk/Source

Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
<rdar://problem/8944718>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • DerivedSources.make:

Remove generation of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.

Source/WebCore:

  • DerivedSources.make:

Remove generation of HeaderDetection.h.

  • WebCore.xcodeproj/project.pbxproj:

Remove HeaderDetection.h.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

Replace use of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER with USE(WK_SCROLLBAR_PAINTER).

18:19 Changeset [81738] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-22 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=56488
Some transitions/animations tests fail assertion in AnimationBase::updateStateMachine

Turning some tests back on after r81722.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • unskipping animations/suspend-resume-animation-events.html compositing/transitions/scale-transition-no-start.html compositing/transitions/singular-scale-transition.html
18:13 Changeset [81737] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Properly reset VideoLayerChromium textures after lost renderer context
https://bugs.webkit.org/show_bug.cgi?id=56514

The VideoLayerChromium textures were still mapped to the old
renderer's context when LayerRendererChromium was being recreated
i.e. when GPU process is killed. This patch allows VideoLayerChromium
it recreate textures in the new context when the old renderer is lost.
Patch also does a bit of refactoring and code clean-up.

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::~VideoLayerChromium): (WebCore::VideoLayerChromium::cleanupResources): (WebCore::VideoLayerChromium::updateContentsIfDirty): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::computeVisibleSize): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA): (WebCore::VideoLayerChromium::resetFrameParameters): (WebCore::VideoLayerChromium::saveCurrentFrame):
  • platform/graphics/chromium/VideoLayerChromium.h:
18:11 Changeset [81736] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should export the headers needed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=56883

  • WebCore.gypi:
  • gyp/WebCore.gyp:
    • Export a couple more headers.
    • Remove FIXME comments for things we've already fixed.
18:08 Changeset [81735] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach update-webkit about gyp
https://bugs.webkit.org/show_bug.cgi?id=56881

This makes it possible for someone who builds from Xcode
to just run update-webkit --gyp and have the project files
generated after update automatically.

I also added a stand-alone "generate-project-files" script
wrapping Source/gyp/configure. This makes running gyp simpler
since most people will not have gyp or Source/gyp in their path.

  • Scripts/build-webkit:
  • Scripts/generate-project-files: Added.
  • Scripts/update-webkit:
18:05 Changeset [81734] by slewis@apple.com
  • 3 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=56798
Wrap autorelease pools around calls that can have pathological memory growth on Membuster.
Only wrap the main runloop because some background threads are not expected to call into
objc and an autorelease pool could mask bugs.

Reviewed by Simon Fraser.

  • Platform/mac/RunLoopMac.mm:

(RunLoop::performWork):
(RunLoop::TimerBase::timerFired):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):

17:57 Changeset [81733] by commit-queue@webkit.org
  • 21 edits
    4 adds in trunk

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

This test twice retrieves lists of origins with application cache.
First, after deleting all application cache and after adding an iframe with an
application cache.

  • http/tests/appcache/origins-with-appcache-expected.txt: Added.
  • http/tests/appcache/origins-with-appcache.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

Added test that exercises WebCore API to get origins with application cache.

Test: http/tests/appcache/origins-with-appcache.html

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]):

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

  • DumpRenderTree/LayoutTestController.cpp: (originsWithApplicationCacheCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers. (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers. (LayoutTestController::originsWithApplicationCache): (LayoutTestController::originsWithLocalStorage):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
17:33 Changeset [81732] by andersca@apple.com
  • 5 edits in trunk/Source

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879

  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromPropertyLists): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.


  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::pluginSupportsExtension): Add a new helper function.

(WebKit::WebFrameLoaderClient::objectContentType):
If we can't find the MIME for an extension, explicitly check if there's a plugin that claims to
handle the given extension.

17:28 Changeset [81731] by simonjam@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-03-22 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium gpu tests after r81715.

  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.png: Added.
17:26 Changeset [81730] by cevans@google.com
  • 3 edits
    6 copies in branches/chromium/696

Merge 81611
BUG=75801

17:24 Changeset [81729] by jam@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Make WebTextCheckingResult&apos;s members be public in preparation for converting it to a struct
https://bugs.webkit.org/show_bug.cgi?id=56857

  • DEPS:
  • public/WebTextCheckingResult.h:
17:23 Changeset [81728] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 81689
BUG=76646

17:21 Changeset [81727] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-22 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=56242
transitions/interrupted-accelerated-transition.html was failing

Unskipping this after r81722

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
17:21 Changeset [81726] by loki@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-22 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add DFG module to build system (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=56845

17:07 Changeset [81725] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] New resolve url tests don't pass on Chromium. Skipping them.
https://bugs.webkit.org/show_bug.cgi?id=56800

  • platform/chromium/test_expectations.txt: Skip all tests in http/tests/filesystem/workers. They can't run in test_shell, and are instead run in Chromium's ui_tests.
17:04 Changeset [81724] by carol.szabo@nokia.com
  • 7 edits in trunk/Source/WebCore

2011-03-22 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Introduced double linkage between a CounterNode and its display renderer.

use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065

No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.

  • rendering/CounterNode.cpp: Introduced new member "m_owner" to store the renderer that has the style directives that produce the CounterNode. Repurposed m_renderer to reffer to the RenderCounter that shows the CounterNode. (WebCore::CounterNode::CounterNode): Updated member initialization. (WebCore::CounterNode::create): (WebCore::CounterNode::addRenderer): (WebCore::CounterNode::removeRenderer): Introduced to manage the renderer list associated wit this CounterNode. (WebCore::CounterNode::resetRenderers): This is the old resetRenderer. Renamed to take into account that there may be more than one renderer to a CounterNode. (WebCore::CounterNode::resetThisAndDescendantsRenderers): This is the old resetRenderers renamed for clarity. (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): No functional changes. (WebCore::showTreeAndMark): Added flushing to ensure that the output is complete.
  • rendering/CounterNode.h: (WebCore::CounterNode::owner): Renamed from renderer()
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed comments. No functional changes. (WebCore::RenderCounter::~RenderCounter): Made sure that the CounterNode that this renderers displays is detached from this. (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): Changed to maintain the bidirectional relationship with the displayed CounterNode. Also made "invalidate" private as it should be used only by CounterNode. (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): No change, just kept code in line with the changes above. (showCounterRendererTree): Added fflush to ensure complete display.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h: Removed unneeded invalidateCounters related functions.
17:00 Changeset [81723] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-22 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Rename the synchronous icon database messages to be prefixed with "synchronous"

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::synchronousIconDataForPageURL): (WebKit::WebIconDatabase::synchronousIconURLForPageURL): (WebKit::WebIconDatabase::synchronousIconDataKnownForIconURL): (WebKit::WebIconDatabase::synchronousLoadDecisionForIconURL):
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabase.messages.in:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: (WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
16:52 Changeset [81722] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

2011-03-22 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56242
Interrupted accelerated animations/transitions were causing
subsequent animations to not start (because they were stuck
waiting for a response from the compositing layer). I renamed
the instance variable that indicates whether or not to
notify animations of start time, from m_waitingForStartTimeResponse
to m_waitingForAsyncStartNotification, so that it makes more sense.
The actual bug fix was changing the logic so that the flag is reset
when the list of waiting animations becomes empty. I mistakenly committed
the bad logic in r81613.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
  • Always set paused time as we enter the paused state
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
  • reset the waiting flag when the list is empty (rather than not empty) (WebCore::AnimationControllerPrivate::startTimeResponse):
  • page/animation/AnimationControllerPrivate.h:
  • rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification
16:43 Changeset [81721] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Loading a new tab does not dismiss Lookup
<rdar://problem/9138391>

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
Hide the dictionary popup when moving the WKView out of a window.

16:30 Changeset [81720] by cevans@google.com
  • 24 edits
    4 copies in branches/chromium/696

Merge 81018
BUG=75436

16:29 Changeset [81719] by beidson@apple.com
  • 10 edits in trunk/Source

<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread

Reviewed by Sam Weinig.

../WebCore:

  • loader/icon/IconDatabase.cpp:

Add a dummy client implementation for non-Mac, non-Win ports:
(WebCore::DefaultIconDatabaseClient::performImport):
(WebCore::DefaultIconDatabaseClient::didImportIconURLForPageURL):
(WebCore::DefaultIconDatabaseClient::didImportIconDataForPageURL):
(WebCore::DefaultIconDatabaseClient::didChangeIconForPageURL):
(WebCore::DefaultIconDatabaseClient::didRemoveAllIcons):
(WebCore::DefaultIconDatabaseClient::didFinishURLImport):
(WebCore::defaultClient):

Either call the client directly when on the main thread, or use the dispatch functions below
if on the background thread:
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::removeAllIconsOnThread):

Add a very targeted WorkItem interface for dispatching client calls on the main thread:
(WebCore::ClientWorkItem::ClientWorkItem):
(WebCore::ClientWorkItem::~ClientWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::performWork):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::performWork):
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem):
(WebCore::RemovedAllIconsWorkItem::performWork):
(WebCore::performWorkItem):

Use the client WorkItem interface to perform these callbacks on the main thread:
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseClient.h:

../WebKit/mac:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebIconDatabaseClient.mm:

(WebIconDatabaseClient::didRemoveAllIcons):
(WebIconDatabaseClient::didImportIconURLForPageURL):
(WebIconDatabaseClient::didImportIconDataForPageURL):
(WebIconDatabaseClient::didChangeIconForPageURL):
(WebIconDatabaseClient::didFinishURLImport):

../WebKit/win:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebIconDatabase.cpp:

(WebIconDatabase::performImport):
(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::didImportIconDataForPageURL):
(WebIconDatabase::didChangeIconForPageURL):
(WebIconDatabase::didFinishURLImport):

  • WebIconDatabase.h:
16:29 Changeset [81718] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81683.
http://trac.webkit.org/changeset/81683
https://bugs.webkit.org/show_bug.cgi?id=56872

Crashing in some tests (Requested by weinig on #webkit).

  • win/lib/WebKitSystemInterface.lib:
16:23 Changeset [81717] by eric@webkit.org
  • 4 edits in trunk

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
https://bugs.webkit.org/show_bug.cgi?id=56877

Found a couple missing Private headers while trying to make WebCore build.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
https://bugs.webkit.org/show_bug.cgi?id=56877

build-webkit is a cesspool. This change just hacks in --gyp support for Mac.
Eventually we'll want to support gyp-generated projects in a more general manner.

  • Scripts/build-webkit:
16:21 Changeset [81716] by hyatt@apple.com
  • 10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56869

Reviewed by Simon Fraser.

Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
a little faster than having to access the information from the RenderStyle's sub-structure.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::logicalScroll):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::styleWillChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::setHorizontalWritingMode):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::scrollbarsChanged):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::verticalPositionForBox):

16:17 Changeset [81715] by simon.fraser@apple.com
  • 5 edits
    8 adds in trunk

2011-03-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Incorrect rendering of composited element with negative z-index child
https://bugs.webkit.org/show_bug.cgi?id=56846

When a composited element has a child with negative z-index, we make
a separate layer for that element's foreground content. This layer
was positioned incorrectly (but the content happened to paint at
the right location), resulting in right/bottom clipping.

Fix this, remove the little-used graphicsLayerToContentsCoordinates()
contentsToGraphicsLayerCoordinates() methods, and optimize incremental
repaints in the foreground and mask layers.

Tests: compositing/geometry/foreground-layer.html

compositing/geometry/repaint-foreground-layer.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints which fall outside the layer bounds, so callers don't have to, and to avoid unnecessary layer commits.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If we have a foreground layer inside a clipping layer, the foreground layer's offset is zero, since the clipping layer is its parent.

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
Also do incremental repaints of the foreground and mask layers.

(WebCore::RenderLayerBacking::paintContents): It was incorrect to always
use compositedBounds() to compute the painting offset, since that's
per-RenderLayerBacking, but a single RenderLayerBacking can have different
GraphicsLayers with different offsets (e.g. the foreground layer).
Instead, use offsetFromRenderer(), which gives has the correct offset.

  • rendering/RenderLayerBacking.h: Remove unused methods.
16:14 Changeset [81714] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/696

Merge 81643
BUG=76031

16:10 Changeset [81713] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/696

Merge 81536
BUG=76198

15:45 Changeset [81712] by abarth@webkit.org
  • 2 edits in trunk

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

gyp/configure shouldn&apos;t require GYP to be in your path
https://bugs.webkit.org/show_bug.cgi?id=56873

Now that GYP is on Source/ThirdParty/gyp, we can just use that copy
instead of requiring GYP to be in the user's path.

  • Source/gyp/configure:
15:43 Changeset [81711] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Use default-output instead of default-input to get hardware sample-rate
https://bugs.webkit.org/show_bug.cgi?id=56858

No new tests since audio API is not yet implemented.

  • platform/audio/mac/AudioDestinationMac.cpp: (WebCore::AudioDestination::hardwareSampleRate):
15:42 Changeset [81710] by psolanki@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

2011-03-22 Pratik Solanki <psolanki@apple.com>

Reviewed by David Kilzer.

Implement -connection:didReceiveDataArray: NSURLConnection delegate method
https://bugs.webkit.org/show_bug.cgi?id=56838

Add experimental support for the didReceiveDataArray callback on
NSURLConnection. A RessourceHandleClient indicates its ability to
handle this callback by returning true from supportsDataArray() method.
Currently only SubresourceLoader uses this so we get the benefit for
CSS, JS and image loads. For other clients we call didReceiveData with
the CFData contents as before.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::supportsDataArray):
  • loader/cf/SubresourceLoaderCF.cpp: Added. (WebCore::SubresourceLoader::didReceiveDataArray):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveDataArray):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::buffer):
  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::copyDataArrayAndClear):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::supportsDataArray): (WebCore::ResourceHandleClient::didReceiveDataArray):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
15:36 Changeset [81709] by abarth@webkit.org
  • 1 edit
    552 adds in trunk

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add GYP to Source/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=56870

We probably don't need all the test files, but it seems cleaner to just
check in the whole GYP tree. GYP is BSD licensed, so it is compatible
with the WebKit license.

  • Source/ThirdParty/gyp: Added.
15:09 Changeset [81708] by eric@webkit.org
  • 6 edits
    4 copies
    3 moves in trunk/Source

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptCore.xcodeproj
from a JavaScriptCore directory outside of Source.

  • gyp/JavaScriptCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptGlue.xcodeproj
from a JavaScriptGlue directory outside of Source.

  • gyp/JavaScriptGlue.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated WebCore.xcodeproj
from a WebCore directory outside of Source.

  • gyp/WebCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.
14:57 Changeset [81707] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WebKit2 build.

  • WebCore.exp.in:

Export a symbol needed by WebKit2.

14:51 Changeset [81706] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the remaining steps to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56864

These steps match the normal build. After this patch, I believe the
WebCore GYP build is complete.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • gyp/copy-inspector-resources.sh: Added.
14:41 Changeset [81705] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Microsoft Silverlight playback shows artifacts
https://bugs.webkit.org/show_bug.cgi?id=56863
<rdar://problem/9103136>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paint): If the plug-in is transparent, clear the dirty rect before painting.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the MakeTransparentIfBackgroundAttributeExists quirk for Silverlight plug-ins.
  • Shared/Plugins/PluginQuirks.h: Add MakeTransparentIfBackgroundAttributeExists quirk.
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_SetValue): Handle NPPVpluginTransparentBool.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isTransparent to false.

(WebKit::NetscapePlugin::setIsTransparent):
Set m_isTransparent.

(WebKit::NetscapePlugin::initialize):
If the plug-in has the MakeTransparentIfBackgroundAttributeExists quirk, make it transparent
if there's a 'background' attribute.

(WebKit::NetscapePlugin::isTransparent):
Add getter.

  • WebProcess/Plugins/Plugin.h: Add isTransparent().
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::paint): Always copy the plug-in backing store to the plug-in proxy backing store.

(WebKit::PluginProxy::isTransparent):
Add getter that should never be called.

(WebKit::PluginProxy::update):
Always copy the plug-in backing store to the plug-in proxy backing store.

14:33 Changeset [81704] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
added to Page::scrollableAreaSet()

Reviewed by Simon Fraser.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::disconnectFromPage):

14:33 Changeset [81703] by simonjam@chromium.org
  • 2 edits
    103 adds in trunk/LayoutTests

2011-03-22 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium tests after r81684.

  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:32 Changeset [81702] by crogers@google.com
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-03-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add high-quality band-limited audio resampling algorithm
https://bugs.webkit.org/show_bug.cgi?id=56692

No new tests since audio API is not yet implemented.

  • platform/audio/SincResampler.cpp: Added. (WebCore::SincResampler::SincResampler): (WebCore::SincResampler::initializeKernel): (WebCore::SincResampler::consumeSource): (WebCore::SincResampler::process):
  • platform/audio/SincResampler.h: Added.
14:28 Changeset [81701] by eric@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Profiling Configuration to JavaScriptCore gyp build
https://bugs.webkit.org/show_bug.cgi?id=56862

It appears this is identical to Release, but I suspect
there is someone/thing who uses the Profiling target
so we're adding it for completeness.

  • gyp/JavaScriptCore.gyp:
14:17 Changeset [81700] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt

Update computed style results.

14:13 Changeset [81699] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

Update computed style results.

14:12 Changeset [81698] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

Update computed style results.

14:10 Changeset [81697] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

Update computed style results.

14:10 Changeset [81696] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt

Update computed style results.

14:07 Changeset [81695] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build without help from normal WebCore build
https://bugs.webkit.org/show_bug.cgi?id=56860

Before this patch, the WebCore GYP build wasn't generating the derived
sources quite right because the ENABLE macros were not being
communicated to the "Derived Sources" target.

This patch also adds the "Copy Forwarding and ICU Headers" as well as
the "Streamline Inspector Source" steps, which are present in the
normal build. Unlike the normal build, these steps occur in a new
target, called "WebCore Support", which is less than aesthetically
beautiful. Hopefully we'll be able to move them into the WebCore
target proper in the future, but that will likely require some GYP
changes.

This patch probably could have been broken down into a couple smaller
patches, but that doesn't seem necessary.

  • WebCore.gypi:
    • This file appears to no longer exist.
  • gyp/WebCore.gyp:
  • gyp/copy-forwarding-and-icu-headers.sh: Added.
  • gyp/streamline-inspector-source.sh: Added.
14:05 Changeset [81694] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove os_win32_files variable from the GYP build
https://bugs.webkit.org/show_bug.cgi?id=56804

Now that our understanding of GYP is sufficiently advanced, we don't
need os_win32_files any more. (Turns out Eric was right, as he always
is.)

14:02 Changeset [81693] by abarth@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build of JavaScriptCore should be able to link from an empty WebKitBuild directory
https://bugs.webkit.org/show_bug.cgi?id=56803

Previously, we thought we should generate the derived source files in
the shared intermediate build products directory, but there are
assumptions built into other parts of the Mac build system that the
derived source files will be generated in a particular subdirectory of
the build products directory.

This patch is a partial revert of the change that moved the derived
source files to the shared intermediate directory. After this patch,
the GYP build can build JavaScriptCore without help from the main
normal build system.

  • JavaScriptCore.gypi:
  • gyp/JavaScriptCore.gyp:
  • gyp/generate-derived-sources.sh:
  • gyp/generate-dtrace-header.sh:
13:41 Changeset [81692] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-03-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Have WebKit push acceleratedDrawing preferences to settings
https://bugs.webkit.org/show_bug.cgi?id=56792

  • WebView/WebView.mm:
13:18 Changeset [81691] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=56859

Reviewed by Simon Fraser.

Floats in the floating object list occur in the order that they are positioned. This means
that for a given vertical offset, the last left object in the list that intersects that offset
will be the rightmost float. There is no need to check any previous floats, since they have to be
further left than that rightmost float. The same rules hold true for right-aligned floats.

Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
they encounter a float that intersects the vertical range.

This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

13:13 Changeset [81690] by ddkilzer@apple.com
  • 3 edits in trunk/Tools

<http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode

Reviewed by Joseph Pecoraro.

  • Scripts/build-webkit: Updated usage statement to include

--dsym.

  • Scripts/webkitdirs.pm: Added $generateDsym variable.

(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added. Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added. Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.

12:21 Changeset [81689] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
https://bugs.webkit.org/show_bug.cgi?id=56794

  • svg/filters/feDisplacementMap-crash-test-expected.txt: Added.
  • svg/filters/feDisplacementMap-crash-test.xhtml: Added.

2011-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
https://bugs.webkit.org/show_bug.cgi?id=56794

Test: svg/filters/feDisplacementMap-crash-test.xhtml

  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
12:21 Changeset [81688] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/CMakeLists.txt

Fix EFL bustage.

12:18 Changeset [81687] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Leopard build bustage.

12:17 Changeset [81686] by jcivelli@chromium.org
  • 10 edits
    7 adds in trunk/Source

2011-03-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::Vector::contains):

2011-03-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Relanding:
Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:16 Changeset [81685] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-22 Huahui Wu <mediadependent@gmail.com>

Reviewed by Steve Block.

[Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
https://bugs.webkit.org/show_bug.cgi?id=56763

No new tests as no new functionality is exposed.

  • platform/PlatformTouchEvent.h:
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
12:03 Changeset [81684] by hyatt@apple.com
  • 32 edits
    68 adds in trunk

Source/WebCore: Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Reviewed by Simon Fraser.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

Added new tests in fast/block/lineboxcontain

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSLineBoxContainValue.cpp: Added.

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
(WebCore::CSSLineBoxContainValue::cssText):

  • css/CSSLineBoxContainValue.h: Added.

(WebCore::CSSLineBoxContainValue::create):
(WebCore::CSSLineBoxContainValue::value):
(WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseLineBoxContain):

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.h:

(WebCore::CSSValue::isCSSLineBoxContainValue):

  • css/CSSValueKeywords.in:
  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

  • rendering/RenderInline.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::width):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
(WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineBoxContain):
(WebCore::InheritedFlags::setLineBoxContain):
(WebCore::InheritedFlags::initialLineBoxContain):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=56388

Reviewed by Simon Fraser.

Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

  • fast/block/lineboxcontain: Added.
  • fast/block/lineboxcontain/block-font.html: Added.
  • fast/block/lineboxcontain/block-glyphs-replaced.html: Added.
  • fast/block/lineboxcontain/block-glyphs.html: Added.
  • fast/block/lineboxcontain/block-replaced.html: Added.
  • fast/block/lineboxcontain/block.html: Added.
  • fast/block/lineboxcontain/font-replaced.html: Added.
  • fast/block/lineboxcontain/font.html: Added.
  • fast/block/lineboxcontain/glyphs.html: Added.
  • fast/block/lineboxcontain/inline-box-replaced.html: Added.
  • fast/block/lineboxcontain/inline-box-vertical.html: Added.
  • fast/block/lineboxcontain/inline-box.html: Added.
  • fast/block/lineboxcontain/inline-replaced.html: Added.
  • fast/block/lineboxcontain/inline.html: Added.
  • fast/block/lineboxcontain/none.html: Added.
  • fast/block/lineboxcontain/replaced.html: Added.
  • platform/mac/fast/block/lineboxcontain: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.txt: Added.
12:03 Changeset [81683] by weinig@apple.com
  • 2 edits in trunk/WebKitLibraries

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Adam Roben.

"Windows edition".

  • win/lib/WebKitSystemInterface.lib:
11:52 Changeset [81682] by loki@webkit.org
  • 15 edits in trunk/Source/JavaScriptCore

2011-03-22 Gabor Loki <loki@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix a bunch of typos in DFG.
https://bugs.webkit.org/show_bug.cgi?id=56813

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::parse):
  • dfg/DFGGenerationInfo.h: (JSC::DFG::GenerationInfo::setSpilled):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump):
  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::setupStubArguments):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.h:
  • dfg/DFGRegisterBank.h: (JSC::DFG::RegisterBank::allocate):
  • dfg/DFGScoreBoard.h: (JSC::DFG::ScoreBoard::~ScoreBoard): (JSC::DFG::ScoreBoard::allocate):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.h:
11:48 Changeset [81681] by weinig@apple.com
  • 3 edits in trunk/WebKitLibraries

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Brady Eidson.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:40 Changeset [81680] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when calling PluginProxy::evaluate on a destroyed plug-in
https://bugs.webkit.org/show_bug.cgi?id=56848
<rdar://problem/9168975>

Return early if the NPObject doesn't exist anymore.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::evaluate):
11:26 Changeset [81679] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
<rdar://problem/8823874>
https://bugs.webkit.org/show_bug.cgi?id=56847

Reviewed by Adam Roben.

  • Shared/mac/WebEventFactory.mm:

(WebKit::currentMouseButton):
(WebKit::mouseButtonForEvent):
Add mouse button for mouseEnter/Exit events. [NSEvent buttonNumber] doesn't seem to give the right result
for these events, but getting the currentMouseButton does work.

10:58 Changeset [81678] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk

Merging r81668

10:33 Changeset [81677] by commit-queue@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81664.
http://trac.webkit.org/changeset/81664
https://bugs.webkit.org/show_bug.cgi?id=56840

Rolling out followups to 81653 with expectations. (Requested
by pfeldman on #webkit).

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Removed.
10:27 Changeset [81676] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove Gears from Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=56808

Gears has been removed from Chromium 12. Remove Gears drag drop support
from WebKit. That work lead to http://webkit.org/b/25916, a proposal to
add native file drag drop, and its subsequent standardization in HTML5.

  • public/WebBindings.h:
  • public/WebView.h:
  • src/WebBindings.cpp: (WebKit::getRangeImpl): FIXME note added.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragLeave): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
10:09 Changeset [81675] by pfeldman@chromium.org
  • 3 edits
    4 deletes in trunk

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
http://trac.webkit.org/changeset/81653
https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • fast/forms/listbox-bidi-align.html: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Removed.

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
http://trac.webkit.org/changeset/81653
https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
09:59 Changeset [81674] by pfeldman@chromium.org
  • 5 edits
    3 deletes in trunk

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/protocol/database-agent-expected.txt: Removed.
  • inspector/protocol/database-agent.html: Removed.
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Removed.
09:47 LayoutTestDashboards edited by mihaip@chromium.org
(diff)
09:46 LayoutTestDashboards edited by mihaip@chromium.org
(diff)
09:25 Changeset [81673] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-03-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
https://bugs.webkit.org/show_bug.cgi?id=56747

Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::showProfilesPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showAndEnableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
09:21 Changeset [81672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-22 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
https://bugs.webkit.org/show_bug.cgi?id=56824

On desktop OpenGL substitute in renderbufferStorage:

  • GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
  • GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
  • GL_RGBA for GL_RGBA4 and GL_RGBA565
  • GL_RGB for RGB5_A1.

Tests: fast/canvas/webgl/uninitialized-test.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::renderbufferStorage):
09:16 Changeset [81671] by dglazkov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Move volume slider positioning logic to a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=56498

No functional change, covered by existing tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
  • rendering/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added. (WebCore::RenderMediaVolumeSliderContainer::layout): Added. (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates. (WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added. (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
  • rendering/MediaControlElements.h: Changed corresponding decls.
09:03 Changeset [81670] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Change return values with better one in ewk_setting's functions
https://bugs.webkit.org/show_bug.cgi?id=56819

In ewk_settings_cache_directory_path_set_xxx, they return false value
when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get): (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
08:49 Changeset [81669] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::getViewportGLWidget): Check if we actually have a QWebPageClient before dereferencing it.

2011-03-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138

  • tests/qwebpage/tst_qwebpage.cpp: (webGLScreenshotWithoutView): (tst_QWebPage::acceleratedWebGLScreenshotWithoutView): (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView): Render a QWebPage (with and without accelerated compositing) with a WebGL context that has no owning view. Shouldn't crash.
07:57 Changeset [81668] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Applications that include WebKit headers fail to build when using strict warnings
because the signature for webkit_application_cache_get_maximum_size is missing a
'void' to make it explicit it takes no arguments.

  • webkit/webkitapplicationcache.h:
07:37 Changeset [81667] by aroben@apple.com
  • 3 edits in trunk/Tools

Make Leopard Debug bots and Windows XP Debug (Tests) core builders

These bots are consistently green again.

Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
core builders

Rubber-stamped by Antti Koivisto.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Loosened the regexps for Leopard and Windows.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated expectations.

07:11 Changeset [81666] by aroben@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows expected failure results after r81625

The failure is tracked by <http://webkit.org/b/56829>.

  • platform/win/fast/css/percentage-non-integer-expected.checksum: Added.
  • platform/win/fast/css/percentage-non-integer-expected.png: Added.
  • platform/win/fast/css/percentage-non-integer-expected.txt: Added.
07:07 Changeset [81665] by aroben@apple.com
  • 4 edits in trunk/LayoutTests

Fix new http tests added in r81635 on Windows

  • http/tests/cache/post-redirect-get.php:
  • http/tests/cache/post-with-cached-subresources.php:
  • http/tests/cache/resources/post-image-to-verify.php:

Pull in portabilityLayer.php, which implements sys_get_temp_dir for PHP 4.

06:52 Changeset [81664] by aroben@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for new test added in r81653

Windows differs from Mac due to a different scrollbar width within the listboxes.

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.
06:50 Changeset [81663] by pfeldman@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document DOM domain types and protocol methods.
https://bugs.webkit.org/show_bug.cgi?id=56807

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapNode):
  • inspector/InjectedScript.h:
  • inspector/Inspector.json:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode):
06:49 Changeset [81662] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Update Windows results for new test added in r81652

The checked-in results were trying to show that Windows would fail this test, but weren't
quite accurate. Even with these new results Windows still fails the test; the failure is
tracked by <http://webkit.org/b/56828>.

  • platform/win/fast/forms/reset-autofilled-expected.txt:
06:32 Changeset [81661] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Update expectations.

  • platform/qt/Skipped:# Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled()
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.checksum: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.png: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt: Updated.
06:05 Changeset [81660] by antonm@chromium.org
  • 1 edit in branches/chromium/696/Source/WebCore/bindings/v8/V8GCController.cpp

Temporary disable object grouping for some types of objects.

BUG=crbug.com/73441

06:02 Changeset [81659] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip a new test that relies on unimplemented LayoutTestController functionality in WTR

  • platform/mac-wk2/Skipped: Added fast/forms/reset-autofilled.html.
05:21 Changeset [81658] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

2011-03-22 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

Add void to function without parameters
https://bugs.webkit.org/show_bug.cgi?id=56821

  • ewk/ewk_cookies.cpp: (ewk_cookies_clear): (ewk_cookies_policy_get):
  • ewk/ewk_cookies.h:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get): (ewk_settings_web_database_path_get): (ewk_settings_proxy_uri_get): (ewk_settings_default_user_agent_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (ewk_view_dpi_get):
04:54 Changeset [81657] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update of database-agent test expectations.
Empty line added at the end.

  • inspector/protocol/database-agent-expected.txt:
04:44 Changeset [81656] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-22 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, Skipped one test failing because of the same reason.

[GTK] Some test results are one pixel different between the x86_64 and i386 bots
https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skip fast/css/percentage-non-integer.html.
03:49 Changeset [81655] by abarth@webkit.org
  • 10 edits in trunk/Source

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptCore.gyp with information mined from
JavaScriptCore.xcodeproj.

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptGlue.gyp with information mined from
JavaScriptGlue.xcodeproj.

  • gyp/JavaScriptGlue.gyp:
  • gyp/JavaScriptGlue.gypi:

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update WebCore.gyp with information mined from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
03:36 Changeset [81654] by loislo@chromium.org
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for database-agent test.

  • inspector/protocol/database-agent-expected.txt:
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Copied from LayoutTests/inspector/protocol/database-agent-expected.txt.
03:14 Changeset [81653] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-22 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

  • fast/forms/listbox-bidi-align.html: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.

2011-03-22 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

Test: fast/forms/listbox-bidi-align.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
02:48 Changeset [81652] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-03-22 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
https://bugs.webkit.org/show_bug.cgi?id=56802

  • fast/forms/reset-autofilled-expected.txt: Added.
  • fast/forms/reset-autofilled.html: Added.
  • platform/chromium/fast/forms/reset-autofilled-expected.txt: Added.
  • platform/win/fast/forms/reset-autofilled-expected.txt: Added.

2011-03-22 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
In service of https://code.google.com/p/chromium/issues/detail?id=70037
https://bugs.webkit.org/show_bug.cgi?id=56802

Test: fast/forms/reset-autofilled.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset): Clear the autofilled flag.
02:42 Changeset [81651] by loislo@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

  • inspector/protocol/database-agent-expected.txt: Added.
  • inspector/protocol/database-agent.html: Added.

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

Test: inspector/protocol/database-agent.html

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):
02:21 Changeset [81650] by loislo@chromium.org
  • 10 edits in trunk

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::enable): (WebCore::InspectorConsoleAgent::disable):
  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated): (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
  • inspector/front-end/inspector.js:
00:43 Changeset [81649] by tkent@chromium.org
  • 9 edits in trunk/Source

2011-03-22 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367

Introduce clampToInteger(unsigned).

  • wtf/MathExtras.h: (clampToInteger): Added.

2011-03-22 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367

Because the default value of the maximum fractional digits of NSNumberFormatter
and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
localized representation. This bug affects only in Mac and Chromium.

To fix this bug,

  • Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
  • NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces() instead of parseToDoubleForNumberType().

No automated tests because the behavior is locale-dependent. This change
updates a manual test.

  • html/NumberInputType.cpp: (WebCore::NumberInputType::visibleValue): Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional part length to formatLocalizedNumber().
  • manual-tests/input-number-localization.html: Update the test to cover this change.
  • platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
  • platform/text/LocalizedNumberICU.cpp: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
  • platform/text/LocalizedNumberNone.cpp: (WebCore::formatLocalizedNumber):
  • platform/text/mac/LocalizedNumberMac.mm: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().

03/21/11:

23:58 Writing Reftests edited by hayato@chromium.org
(diff)
23:29 LayoutTestDashboards created by ojan@chromium.org
23:27 Changeset [81648] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Anonymous blocks need isRenderBlock cast check. Also, need
to allow display BOX for flexible boxes.
https://bugs.webkit.org/show_bug.cgi?id=56709

Test: accessibility/anchor-linked-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): remove specific fix in r81088 which is no longer needed.
  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast check.

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when searching up the render tree
for an anchor element in accessibility code.
https://bugs.webkit.org/show_bug.cgi?id=56709

  • accessibility/anchor-linked-anonymous-block-crash-expected.txt: Added.
  • accessibility/anchor-linked-anonymous-block-crash.html: Added.
23:25 WikiStart edited by ojan@chromium.org
(diff)
22:39 Changeset [81647] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptCore.gyp:
    • Also, remove jsc.cpp from the excluded list because it's not part of the jsc_files variable instead of the javascriptcore_files variable.

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptGlue.gyp:
22:24 Changeset [81646] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updating Chromium test expectataions.

  • platform/chromium/test_expectations.txt:
22:21 Changeset [81645] by pfeldman@chromium.org
  • 4 edits in trunk/Tools

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81597.
http://trac.webkit.org/changeset/81597
https://bugs.webkit.org/show_bug.cgi?id=56801

Change results in lots of unexpected flaky on the dashboard.
(Requested by pfeldman on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
21:59 Changeset [81644] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-03-21 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

Add the first reftest so that we can make sure that reftests won't cause
any issues on all buildbots.
This patch will also act as a sample reftest which a Wiki page will refer.

https://bugs.webkit.org/show_bug.cgi?id=56450

  • fast/harness/font-weight-bold-expected.html: Added.
  • fast/harness/font-weight-bold.html: Added.
21:32 Changeset [81643] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when adjusting position for inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=56300

  • fast/inline/inline-box-adjust-position-crash-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash.html: Added.
  • fast/inline/inline-box-adjust-position-crash2-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash2.html: Added.

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Revert small change made in r78846 of replacing move with positionLineBox
in the adjusting position function for inline box.
https://bugs.webkit.org/show_bug.cgi?id=56300

The change in r78846 caused positioning line boxes during the step of adjusting
position for inline box, thereby causing line boxes to be nuked. This happens as
part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
Later on, we do the positioning of line boxes again later in that function. This
causes use of removed inline box leading to crash. Also, it is unnecessary to do
this twice.

Tests: fast/inline/inline-box-adjust-position-crash.html

fast/inline/inline-box-adjust-position-crash2.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition):
21:18 Changeset [81642] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4.0

Merging r81641

21:14 Changeset [81641] by alex@webkit.org
  • 4 edits in trunk

2011-03-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • configure.ac:

2011-03-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • NEWS:
20:35 Changeset [81640] by commit-queue@webkit.org
  • 14 edits
    10 adds in trunk

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Note that these tests do not run as part of new-run-webkit-tests,
but rather in Chromium's ui_test. I've run them locally and confirmed
they pass; a subsequent Chromium change will be submitted to run them
on the Chromium build bots.

  • http/tests/filesystem/resources/fs-worker-common.js: Added.
  • http/tests/filesystem/resources/fs-worker-test-util.js: Added. Copied from fast/filesystem/resources for use by HTTP tests.
  • http/tests/filesystem/script-tests/resolve-uri.js: Updated to be used either in window or worker context.
  • http/tests/filesystem/workers/resolve-url-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync.html: Added.
  • http/tests/filesystem/workers/resolve-url.html: Added.
  • http/tests/filesystem/workers/script-tests/TEMPLATE.html: Added.
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added.

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Tests: http/tests/filesystem/workers/resolve-url-sync.html

http/tests/filesystem/workers/resolve-url.html

  • fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::readFileSystem): Add support for workers.
  • fileapi/LocalFileSystem.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::resolveLocalFileSystemURL): (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Pass "create" bool through to allow opening
a filesystem without allowing creation.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker):
  • src/WebWorkerBase.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
  • src/WorkerFileSystemCallbacksBridge.h:
20:28 Changeset [81639] by levin@chromium.org
  • 11 edits in trunk

2011-03-21 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
https://bugs.webkit.org/show_bug.cgi?id=24683

  • http/tests/xmlhttprequest/workers/referer-expected.txt: Fixed expectations now that this works correctly.
  • http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Ditto.

2011-03-21 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
https://bugs.webkit.org/show_bug.cgi?id=24683

Tests: http/tests/xmlhttprequest/workers/referer.html

http/tests/xmlhttprequest/workers/shared-worker-referer.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer. (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto. (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
  • loader/DocumentThreadableLoader.h: Ditto.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
  • loader/ResourceLoadScheduler.h: Ditto.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
  • loader/WorkerThreadableLoader.h:
20:15 Changeset [81638] by commit-queue@webkit.org
  • 2 edits in trunk

2011-03-21 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Add exception handling when PORT was missing.
https://bugs.webkit.org/show_bug.cgi?id=56728

  • Source/CMakeLists.txt:
20:06 Changeset [81637] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-21 Ilya Sherman <isherman@chromium.org>

Reviewed by James Robinson.

Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Clients should instead call into WebFormControlElement::isEnabled().
https://bugs.webkit.org/show_bug.cgi?id=56364

  • public/WebInputElement.h: Removed isEnabledFormControl().
  • src/WebInputElement.cpp: Removed isEnabledFormControl().
19:35 Changeset [81636] by simonjam@chromium.org
  • 6 edits
    1 copy in trunk/LayoutTests

2011-03-21 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline win/linux after r81625.

  • platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/percentage-non-integer-expected.txt.
  • platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.txt:
19:32 Changeset [81635] by japhet@chromium.org
  • 10 edits
    5 adds in trunk

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Tests for https://bugs.webkit.org/show_bug.cgi?id=38690.

  • http/tests/cache/post-redirect-get-expected.txt: Added.
  • http/tests/cache/post-redirect-get.php: Added.
  • http/tests/cache/post-with-cached-subresources-expected.txt: Added.
  • http/tests/cache/post-with-cached-subresources.php: Added.
  • http/tests/cache/resources/post-image-to-verify.php: Added.

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Do not check the DocumentLoader's request cache policy
in determining whether we should force revalidation of a cached
subresource. If the main resource received headers telling it not
to cache, that policy will be propagated to subresources.

The previous behavior is left in behind a flag in Settings, since
QuickLook depends on it.

https://bugs.webkit.org/show_bug.cgi?id=38690

Tests: http/tests/cache/post-redirect-get.php

http/tests/cache/post-with-cached-subresources.php

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): (WebCore::FrameLoader::loadPostRequest):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseQuickLookResourceCachingQuirks): (WebCore::Settings::useQuickLookResourceCachingQuirks):

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Expose a preference to use caching quirks for QuickLook,
and use it if the QuickLook framework is loaded.

https://bugs.webkit.org/show_bug.cgi?id=38690

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (useQuickLookQuirks): (+[WebPreferences initialize]): (-[WebPreferences useQuickLookResourceCachingQuirks]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
18:17 Changeset [81634] by mrobinson@webkit.org
  • 5 edits
    6 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81611

18:15 Changeset [81633] by mrobinson@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81536

18:15 Changeset [81632] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Remove dependency on default font from data-transfer-items.html
https://bugs.webkit.org/show_bug.cgi?id=56791

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
17:58 Changeset [81631] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783

  • Platform/mac/Logging.mac.mm:
17:50 Changeset [81630] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebCore

Merging r81589

17:49 Changeset [81629] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4.0/Source

Merging r81587

17:47 Changeset [81628] by beidson@apple.com
  • 3 edits
    3 adds in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.

Reviewed by Brian Weinstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannel):

  • Platform/Logging.h:
  • Platform/mac/Logging.mac.mm: Added.

(WebKit::initializeLogChannel):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize logging if necessary.

  • WebKit2.xcodeproj/project.pbxproj:
17:33 Changeset [81627] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4.0/Source

Merging 81575

17:29 Changeset [81626] by mrobinson@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.4.0/Source/JavaScriptCore

Merging 81525

17:24 Changeset [81625] by commit-queue@webkit.org
  • 14 edits in trunk

2011-03-21 Rik Cabanier <cabanier@gmail.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-21 Rik Cabanier <cabanier@adobe.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
17:16 Changeset [81624] by abarth@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
https://bugs.webkit.org/show_bug.cgi?id=56780

The reason we couldn't resolve this warning in the GYP build was that
the normal build disables this warning specifically for this file.
This patch takes the same approach as the previous patch to
WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
(rather than a build system configuration).

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Remove the special-case for this file.
  • gyp/JavaScriptCore.gyp:
    • Remove the work-around for this issue.
  • wtf/Assertions.cpp:
    • Add a pragma disabling this warning for this file.
17:14 Changeset [81623] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WebCoreExportFileGenerator to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56778

This target mirrors the eponymous target from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • generate-webcore-export-file-generator.sh: Added.
17:11 Changeset [81622] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
https://bugs.webkit.org/show_bug.cgi?id=56782
<rdar://problem/9151993>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Factored out code for resending an event and moved it to WKView.
  • UIProcess/API/mac/WKView.mm: (-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier to just do that in _resendKeyDownEvent:. (-[WKView keyDown:]): Ditto. (-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we are not already resending an event - it would be too confusing if we ever had to do that, but looks like this never happens.
  • UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.
17:11 Changeset [81621] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn't crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/JavaScriptCore.gyp:

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn&apos;t crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/WebCore.gyp:
17:03 Changeset [81620] by dcheng@chromium.org
  • 10 edits in trunk

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=56330

Update the layout test to take into account that the actual contents of the clipboard
are exposed in a paste via DataTransferItems now.
Also fix the flakiness in the layout test.

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
  • platform/chromium/test_expectations.txt:

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=56330

Support retrieving clipboard data in a paste through DataTransferItems.

Test: editing/pasteboard/data-transfer-items.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::createFromPasteboard): (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString):
  • platform/chromium/DataTransferItemChromium.h:
  • platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::addPasteboardItem):
  • platform/chromium/DataTransferItemsChromium.h:
16:34 Changeset [81619] by cfleizach@apple.com
  • 5 edits in trunk/Source

AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734

Reviewed by Darin Adler.

../WebCore:

WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

../WebKit/mac:

Implement showContextMenu() so accessibility related code can call this
independent of whether WK1 or WK2 is running.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::showContextMenu):

16:19 Changeset [81618] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable/disable a GestureReocognizer framework

https://bugs.webkit.org/show_bug.cgi?id=49345

  • wtf/Platform.h:

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Add Support to WebCore to optionally call a platform-specific gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=49345

Added an ability for the EventHandler to invoke an optional platform
specific gesture recognizer.

No tests added because the change should be functionally invisible.

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
  • platform/PlatformGestureRecognizer.cpp: Added. (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::create):
  • platform/PlatformGestureRecognizer.h: Added.

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable a platform specific GestureReocognizer framework in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=49345

  • features.gypi:
16:11 Changeset [81617] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in fails to load contextual menu
https://bugs.webkit.org/show_bug.cgi?id=56777
<rdar://problem/8979033>

Open a Carbon resource map and make it the current map when calling NP_Initialize.

  • Platform/Module.cpp: (WebKit::Module::Module): Initialize m_bundleResourceMap to -1.
  • Platform/Module.h: Add m_bundleResourceMap.
  • Platform/mac/ModuleMac.mm: (WebKit::Module::unload): Close the resource map.

(WebKit::Module::bundleResourceMap):
Open a resource map if necessary.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad): Get the resource map and make it current before calling NP_Initialize.
15:56 Changeset [81616] by mrobinson@webkit.org
  • 1 edit
    1 add in releases/WebKitGTK/webkit-1.4.0

Adding svnmerge.py metadata file to the release branch

15:56 Changeset [81615] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Plug-in process crashes if it fails to load a plug-in module
https://bugs.webkit.org/show_bug.cgi?id=56775

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.
15:17 Changeset [81614] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-21 Tony Chang <tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] remove devtools_html's dependency on WebKit.gypi
https://bugs.webkit.org/show_bug.cgi?id=56661

We want to depend on the values in the gypi file, not the gypi file
itself. Actually, if someone edits a gypi file, s/he should re-run
gyp to pick up the new dependencies.

It turns out that this doesn't matter much for this target anymore
since we pull the .js dependencies from the inspector html file.

  • WebKit.gyp: cleanup dependencies
  • scripts/generate_devtools_html.py: remove unused param
15:05 Changeset [81613] by dino@apple.com
  • 8 edits
    2 adds in trunk

2011-03-21 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

AnimationBase had a custom linked-list/self-pointer for keeping
track of animations that needed to be notified of style updates
and start progress. This caused problems when AnimationBase was
destroyed, since the pointer wasn't managed in any way. I replaced
these pointers with HashSets and moved the code that removes animations
from the sets into AnimationControllerPrivate, where it belongs.
CompositeAnimation is also more careful to tell AnimationControllerPrivate
when it no longer needs to keep track of waiting animations.

This should stop the style updates being called on non-active animations
(which was the cause of the state machine error here) and should also
stop a few of the related flakey test failures and occasional crashes.

Test: animations/body-removal-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::~AnimationBase):
  • Remove the linked-list
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::styleAvailable): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::startTimeResponse): (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
  • New method to remove animations from the waiting lists
  • page/animation/AnimationControllerPrivate.h:
  • use a HashSet rather than an AnimationBase* pointer.
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • remove the animations and transitions from the lists when we know they are no longer active (rather than waiting for the AnimationBase to do it when destructing)

2011-03-21 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

Add a test that triggers the assertion by removing the <body>
element and re-inserting it.

While not directly related to this bug, the
transform-origin-vs-functions test would occasionally fail because it
depended on the order of events being fired. The update to the way
animations are keeping their state triggered this more often. Now the
output is sorted before finishing the test.

  • animations/3d/transform-origin-vs-functions.html:
  • animations/body-removal-crash.html: Added.
  • platform/mac/animations/body-removal-crash-expected.checksum: Added.
  • platform/mac/animations/body-removal-crash-expected.png: Added.
  • platform/mac/animations/body-removal-crash-expected.txt: Added.
14:58 Changeset [81612] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, add flaky and failing tests after r81597.

  • platform/chromium/test_expectations.txt:
14:51 Changeset [81611] by jschuh@chromium.org
  • 5 edits
    6 adds in trunk

2011-03-21 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
https://bugs.webkit.org/show_bug.cgi?id=56690

  • fast/dom/insertedIntoDocument-child-expected.txt: Added.
  • fast/dom/insertedIntoDocument-child.html: Added.
  • fast/dom/insertedIntoDocument-iframe-expected.txt: Added.
  • fast/dom/insertedIntoDocument-iframe.html: Added.
  • fast/dom/insertedIntoDocument-sibling-expected.txt: Added.
  • fast/dom/insertedIntoDocument-sibling.html: Added.

2011-03-21 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
https://bugs.webkit.org/show_bug.cgi?id=56690

Tests: fast/dom/insertedIntoDocument-child.html

fast/dom/insertedIntoDocument-iframe.html
fast/dom/insertedIntoDocument-sibling.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument):
14:44 Changeset [81610] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add new files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56766

14:41 Changeset [81609] by commit-queue@webkit.org
  • 10 edits
    7 deletes in trunk/Source

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
http://trac.webkit.org/changeset/81377
https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • wtf/Vector.h:

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
http://trac.webkit.org/changeset/81377
https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h:
  • public/WebVector.h: (WebKit::WebVector::operator[]):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp:
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Removed.
  • tests/data/pageserialization/awesome.png: Removed.
  • tests/data/pageserialization/embed_iframe.html: Removed.
  • tests/data/pageserialization/object_iframe.html: Removed.
  • tests/data/pageserialization/simple_iframe.html: Removed.
  • tests/data/pageserialization/simple_page.html: Removed.
  • tests/data/pageserialization/top_frame.html: Removed.
14:39 Changeset [81608] by tony@chromium.org
  • 4 edits
    11 deletes in trunk/LayoutTests

2011-03-21 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Convert fake-drag into a dumpAsText test and remove 1s timeout
https://bugs.webkit.org/show_bug.cgi?id=56674

This test was added with eventSender, so there was no leapForward
at the time. Also convert to dumpAsText while I'm here.

  • editing/selection/fake-drag.html:
  • platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.png: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.txt:
14:19 Changeset [81607] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: skipping new inspector test on GTK unless harness is fixed.

  • platform/gtk/Skipped:
13:54 Changeset [81606] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix failing tests on the WebKit2 bots.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

13:05 Changeset [81605] by levin@chromium.org
  • 3 edits in trunk/Source/WebCore

SubresourceLoader should expose a way to set the outgoing referer/origin
https://bugs.webkit.org/show_bug.cgi?id=55903

Reviewed by Adam Barth.

No new tests as no new functionality is exposed.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/SubresourceLoader.h:
13:03 Changeset [81604] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in loads controller at top of movie not bottom
https://bugs.webkit.org/show_bug.cgi?id=56764
<rdar://problem/8979037>

Create a layer with geometryFlipped set and add the plug-in layer as a sublayer,
matching WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
13:01 Changeset [81603] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
12:57 Changeset [81602] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-21 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=56762

Add preferences for WebSecurityEnabled, UniversalAccessFromFileURLsAllowed
and FileAccessFromFileURLsAllowed.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebSecurityEnabled): (WKPreferencesGetWebSecurityEnabled): (WKPreferencesSetUniversalAccessFromFileURLsAllowed): (WKPreferencesGetUniversalAccessFromFileURLsAllowed): (WKPreferencesSetFileAccessFromFileURLsAllowed): (WKPreferencesGetFileAccessFromFileURLsAllowed):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:49 Changeset [81601] by commit-queue@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=56578

Fixed and re-enabled http/tests/inspector/network tests

  • http/tests/inspector/network/network-size.html: Renamed from LayoutTests/http/tests/inspector/network/network-size.html-disabled.
  • http/tests/inspector/network/network-timing.html: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html-disabled.
12:47 Changeset [81600] by commit-queue@webkit.org
  • 18 edits in trunk

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

Restore the expected result before r79953. r79953 changed behavior slightly in function
finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
or after this patch.

  • platform/mac/editing/selection/designmode-no-caret-expected.txt:

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebCore.exp.in:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
  • dom/Node.cpp: (WebCore::Node::isContentEditable):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
  • page/DragController.cpp: (WebCore::DragController::operationForLoad):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::setEditable): (WebCore::Page::isEditable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_editable): (webkit_web_view_set_editable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • Api/qwebpage.cpp: (QWebPage::setContentEditable): (QWebPage::isContentEditable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebFrame.cpp: (wxWebFrame::MakeEditable): (wxWebFrame::IsEditable):
12:37 Changeset [81599] by ericu@chromium.org
  • 8 edits in trunk/Source

2011-03-21 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704

  • fileapi/DOMFileSystemSync.cpp (DOMFileSystemSync::createFile) (class GetPathHelper): Added, to look up path before creating File.
  • fileapi/DOMFileSystem.cpp (DOMFileSystem::createFile) (GetPathCallback): Added, to look up path before creating File.
  • platform/FileMetadata.h (struct FileMetadata): Added new field platformPath.

2011-03-21 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704

  • src/WebFileSystemCallbacksImpl.cpp: (WebFileSystemCallbacksImpl::didReadMetadata) Pass new platformPath member through.
  • src/WorkerFileSystemCallbacksBridge.cpp: (CrossThreadCopierBase) Copy new platformPath member.
  • public/WebFileInfo.h: (struct WebFileInfo) Add new platformPath member.
12:28 Changeset [81598] by aroben@apple.com
  • 2 edits in trunk/Tools

Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
to the master.
(RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
since we're running on the build master, not the slave. Instead, turn the raw source of
actual.html which the build slave uploaded into an HTML log.

12:10 Changeset [81597] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-03-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: run tests in ascending alphabetical order per dir
https://bugs.webkit.org/show_bug.cgi?id=56760

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
12:08 Changeset [81596] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
https://bugs.webkit.org/show_bug.cgi?id=56458

Enabling the feature by default for chromium builds.

  • features.gypi:

2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
https://bugs.webkit.org/show_bug.cgi?id=56458

Adding options to enable the media stream API feature in Chromium.

  • Scripts/build-webkit:
12:05 Changeset [81595] by jamesr@google.com
  • 2 edits in branches/chromium/696/LayoutTests

Merge 81538 - 2011-03-18 James Robinson <jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:

TBR=jamesr@google.com

11:41 Changeset [81594] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove old DrawingArea and LayerHostingView code from WKView.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):
(-[WKView hitTest:]):
(-[WKView WebKit::]):

11:33 Changeset [81593] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-21 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Need WebKit2 API for creating a page with a specific main frame name
https://bugs.webkit.org/show_bug.cgi?id=56759

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h: Add mainFrameName to creation parameters.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:]): (-[WKView initWithFrame:contextRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:mainFrameName:]): Add new initializer which takes a main frame name.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMainFrameName): (WebKit::WebPageProxy::creationParameters):
  • UIProcess/WebPageProxy.h: Store the main frame name for initialization/re-initialization.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::createMainFrame):
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Pass the name to main frame creation.
11:20 Changeset [81592] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-03-21 Dominic Cooney <dominicc@google.com>

Reviewed by Jeremy Orlow.

Adds a regression test for MediaQueryList listener callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=56166

  • fast/media/media-query-list-callback-expected.txt: Added.
  • fast/media/media-query-list-callback.html: Added.
  • fast/media/resources/media-query-list-callback-frame.html: Added.

2011-03-21 Dominic Cooney <dominicc@google.com>

Reviewed by Jeremy Orlow.

Establishes a V8 context before executing MediaQueryList callbacks.
https://bugs.webkit.org/show_bug.cgi?id=56166

MediaQueryList listener callbacks didn't establish a V8 context
before running script, causing crashes on C++-only
callstacks (such as user resizing, printing, etc.) I believe this
could also be contrived to execute media query list listener
callbacks across domain.

Test: fast/media/media-query-list-callback.html

  • css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged):
10:25 Changeset [81591] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Add QNetworkReplyHandler::wasAborted()

Instead of checking if the ResourceHandle is null everywhere,
use a wasAborted() method to make the code readable.

  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyHandler::wasAborted):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::uploadProgress):
10:11 Changeset [81590] by cfleizach@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

platform/mac/accessibility/aria-table-with-colspan-cells.html is failing on the Leopard Release tester
https://bugs.webkit.org/show_bug.cgi?id=56523

Reviewed by Darin Adler.

List and table functionality is not present on Leopard and should be skipped.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/platform/mac/accessibility: Removed.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Removed.
10:11 Changeset [81589] by christian@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=56201

Reviewed by Martin Robinson.

  • platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf

if there is no image.

09:40 Changeset [81588] by qi.2.zhang@nokia.com
  • 4 edits in trunk/Tools

2011-03-21 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=56323

Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
"--stdout" or "--stderr" option.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::processArgsLine): (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setRedirectOutputFileName): (WebCore::DumpRenderTree::setRedirectErrorFileName):
  • DumpRenderTree/qt/main.cpp: (isOption): (takeOptionValue): (printUsage): (main):
09:32 Changeset [81587] by mario@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
https://bugs.webkit.org/show_bug.cgi?id=56737

Only consider parent objects not ignoring accessibility.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: (webkitAccessibleHyperlinkGetStartIndex): Look for the parent object not ignoring accessibility for the current hyperlink. (webkitAccessibleHyperlinkGetEndIndex): Ditto.

2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
https://bugs.webkit.org/show_bug.cgi?id=56737

  • tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also check offsets for hyperlinks inside <span> nodes.
09:18 WebKitGTK edited by mrobinson@webkit.org
(diff)
09:14 Changeset [81586] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix exceptions on the buildbot due to my last change

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.

09:00 Changeset [81585] by aroben@apple.com
  • 2 edits in trunk/Tools

Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
logs.
(RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
the build master. This will correctly treat it as HTML.

08:49 Changeset [81584] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove handling of QNetworkAccessManager::UnknownOperation

Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
Custom verb requests are using CustomOperation already, so this was dead code.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::start):
08:41 Changeset [81583] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Fix multiple-definition linker warnings on Windows

  • WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is

already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
file.

08:28 Changeset [81582] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Clean up QNetworkReplyHandler::release()

Since QNetworkReplyHandler no longer uses queued connections to
the QNetworkReply, it's not necessary to mess with the event
queue when releasing a reply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
08:19 Changeset [81581] by aroben@apple.com
  • 3 edits in trunk/LayoutTests

Skip another asserting animations test

<http://webkit.org/b/56488> tracks the failure

  • platform/mac/Skipped:
  • platform/win/Skipped:
08:06 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
07:40 Changeset [81580] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added a test for transfer size for chunked encoding type.

  • http/tests/inspector/network/network-size-chunked.html: Added.
  • http/tests/inspector/network/network-size-expected-chunked.txt: Added.
  • http/tests/inspector/network/resources/resource.php:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

Test: http/tests/inspector/network/network-size-chunked.html

  • inspector/Inspector.idl:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.increaseTransferSize):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::forwardData):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer):

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
07:36 Changeset [81579] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

2011-03-21 Hao Zheng <zhenghao@google.com>

Reviewed by Darin Adler.

Bug 15713: Rollout r72533 completely.
https://bugs.webkit.org/show_bug.cgi?id=15713

r72599 only rolled out the checksum files, which caused mismatch
between checksum and png. Some png files had been
rolled out by some other changes, so rollout the remaining png.

  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-linux/fast/doctypes/002-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-expected.png:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/lists/007-vertical-expected.png:
  • platform/chromium-linux/fast/lists/008-vertical-expected.png:
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/doctypes/002-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-expected.png:
  • platform/chromium-win/fast/lists/003-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
07:21 Changeset [81578] by krit@webkit.org
  • 5 edits
    36 adds in trunk

2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
https://bugs.webkit.org/show_bug.cgi?id=54538

SVG spec: http://www.w3.org/TR/SVG/struct.html#UseElement
Quotation for referenced <symbol>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these attributes will be transferred to the generated 'svg'."
Quotation for referenced <svg>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these values will override the corresponding attributes
on the 'svg' in the generated tree."
For above quotations, we should treat 'use' element as referencing
'use' element, just like Firefox 3.6 and Opera 11, instead of
corrensponding 'use' element.

Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg

svg/custom/use-transfer-width-height-properties-to-svg1.svg
svg/custom/use-transfer-width-height-properties-to-svg2.svg
svg/custom/use-transfer-width-height-properties-to-symbol.svg
svg/custom/use-transfer-width-height-properties-to-symbol1.svg
svg/custom/use-transfer-width-height-properties-to-symbol2.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::SVGElementInstance):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::create): (WebCore::SVGElementInstance::correspondingUseElement): (WebCore::SVGElementInstance::directUseElement): (WebCore::SVGElementInstance::clearUseElements):
  • svg/SVGUseElement.cpp: (WebCore::updateContainerSize): (WebCore::SVGUseElement::updateContainerSizes): (WebCore::dumpInstanceTree): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::buildInstanceTree):

2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
https://bugs.webkit.org/show_bug.cgi?id=54538

Test cases for transfering width/height properties from
'use' element to 'svg' and 'symbol' elements.
See: http://www.w3.org/TR/SVG/struct.html#UseElement

  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2.svg: Added.
06:54 Changeset [81577] by loki@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Extend constant pool to be able to store 16 bit instructions with a constant
https://bugs.webkit.org/show_bug.cgi?id=46796

Reviewed by Csaba Osztrogonác.

The putShortWithConstantInt function inserts a 16 bit instruction which
refers a 32 bits constant or literal. This is a vital function for those
target which loads a PC relative value with a 16 bit instruction (like
Thumb-2 instruction set and SH4 architecture).

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):

  • assembler/AssemblerBufferWithConstantPool.h:
03:53 Changeset [81576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-21 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Pavel Feldman.

Fix build break when inspector is enabled.
https://bugs.webkit.org/show_bug.cgi?id=56735

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).
02:33 Changeset [81575] by philn@webkit.org
  • 4 edits in trunk/Source

2011-03-21 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK distcheck build fix.

  • GNUmakefile.am:
01:20 Changeset [81574] by jchaffraix@webkit.org
  • 3 edits in trunk

2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

  • fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
  • fast/css/webkit-empty-transform-preserve3d-crash.html: Added.

2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

Test: fast/css/webkit-empty-transform-preserve3d-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the rest of the code and check that the RenderBox has a layer to avoid crashing on the layer() call.
00:56 Changeset [81573] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move cookie processing and appcache from DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=56713

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  • inspector/front-end/CookieItemsView.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.buildCookiesFromString): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.eventListeners):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update):
00:54 Changeset [81572] by pfeldman@chromium.org
  • 29 edits in trunk/Source/WebCore

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector.json to valid JSON types.
https://bugs.webkit.org/show_bug.cgi?id=56651

This change migrates inspector from long to int as
dom, storage, database and other id types.

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightDOMNode):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::addRule): (WebCore::InspectorCSSAgent::elementForId):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::bind): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::loadEventFired): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::characterDataModified): (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults): (WebCore::InspectorDOMAgent::copyNode): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h: (WebCore::InspectorDOMStorageResource::id):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseId): (WebCore::InspectorDatabaseAgent::databaseForId):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::id):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::setInitialContent): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket):
  • inspector/generate-inspector-idl:
00:44 Changeset [81571] by pfeldman@chromium.org
  • 9 edits in trunk

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/report-protocol-errors-expected.txt:

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightFrame):
  • inspector/InspectorAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::pointerAsId): (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrame): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::frameForId): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
00:42 Changeset [81570] by pfeldman@chromium.org
  • 27 edits in trunk

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56681

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpCallArguments):
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56681

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::inspect):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::releaseObject):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::releaseObjectGroup):
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.inspect):
00:24 Changeset [81569] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselined Chromium expectations.

  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt: Added.

03/20/11:

22:59 Changeset [81568] by pfeldman@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-03-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: removing stale Chromium expectations.

  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Removed.
16:30 Changeset [81567] by levin@chromium.org
  • 60 edits
    4 moves in trunk

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • API/JSClassRef.h:
  • API/OpaqueJSString.h:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Atomics.h:
  • wtf/CMakeLists.txt:
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::crossThreadCopy):
  • wtf/ThreadSafeRefCounted.h: Copied from wtf/ThreadSafeShared.h. (WTF::ThreadSafeRefCountedBase::ThreadSafeRefCountedBase): (WTF::ThreadSafeRefCountedBase::ref): (WTF::ThreadSafeRefCountedBase::refCount): (WTF::ThreadSafeRefCountedBase::derefBase): (WTF::ThreadSafeRefCounted::ThreadSafeRefCounted):
  • wtf/ThreadSafeShared.h: Removed.
  • wtf/Threading.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • gyp/JavaScriptGlue.gypi:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • bindings/v8/SerializedScriptValue.h:
  • dom/Document.cpp:
  • dom/default/PlatformMessagePortChannel.h:
  • fileapi/FileThread.h:
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::create): (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didSendData): (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse): (WebCore::ThreadableLoaderClientWrapper::didReceiveData): (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  • page/SecurityOrigin.h:
  • platform/CrossThreadCopier.h:
  • platform/network/BlobData.h:
  • platform/network/cf/SocketStreamHandle.h:
  • storage/AbstractDatabase.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseCallback.h:
  • storage/DatabaseThread.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/SQLError.h:
  • storage/SQLResultSet.h:
  • storage/SQLStatement.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • workers/DefaultSharedWorkerRepository.cpp:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • Platform/CoreIPC/Connection.h:
  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/ThreadLauncher.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • src/PlatformMessagePortChannel.h:
  • src/WebWorkerBase.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • Scripts/do-webcore-rename:
15:25 Changeset [81566] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add http/tests/appcache/origin-delete.html to the Skipped list for WebKit2,
since layoutTestController.clearAllApplicationCaches is not yet implemented
by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
13:07 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:40 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:32 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:31 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
03:25 Changeset [81565] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-03-20 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean up redirection logic in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=56717

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Use resetState() when constructing QNRH as well.

(WebCore::QNetworkReplyHandler::resetState):
Delete (deferred) the m_reply if one exists (only when redirecting.)

(WebCore::QNetworkReplyHandler::finish):
Return early when redirecting.

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
Move the redirection logic from sendResponseIfNeeded() into a
separate redirect() method.

03/19/11:

20:39 Changeset [81564] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Dan Bernstein.

Add stub to LayoutTestControllerGtk.cpp to fix GTK build
https://bugs.webkit.org/show_bug.cgi?id=56719

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
17:57 Changeset [81563] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Remove StringImpl::computeHash()
https://bugs.webkit.org/show_bug.cgi?id=49894

Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.

  • wtf/text/AtomicString.cpp: (WTF::CStringTranslator::hash): (WTF::UCharBufferTranslator::hash): (WTF::HashAndCharactersTranslator::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::setHash): (WTF::StringImpl::hash):
15:36 Changeset [81562] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()

The function doesn't ignore anything, thus it shouldn't have an imperative name.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::shouldIgnoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
15:18 Changeset [81561] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Kill layer violation FIXME in ResourceHandleQt.

We were including qwebframe_p.h from WebKit/qt for no reason.

  • platform/network/qt/ResourceHandleQt.cpp:
15:15 Changeset [81560] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Refactor handling of deferred loads
https://bugs.webkit.org/show_bug.cgi?id=56715

Split QNetworkReplyHandler's "load mode" into two parameters
instead of trying to fit the deferral mechanism into it.

Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadingDeferred): (WebCore::QNetworkReplyHandler::resumeDeferredLoad): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::resetState):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::platformSetDefersLoading):
15:08 Changeset [81559] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

15:07 Changeset [81558] by mrowe@apple.com
  • 1 copy in tags/Safari-533.21.1

New tag.

14:28 Changeset [81557] by commit-queue@webkit.org
  • 26 edits
    4 adds in trunk

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

This test creates an Application Cache for the DRT origin, deletes it for the origin,
and verifies that the Application Cache has obsolete status.

  • http/tests/appcache/origin-delete-expected.txt: Added.
  • http/tests/appcache/origin-delete.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

To delete all Application Cache for an origin, we must obsolete all
in-memory cache groups for that origin. If a cache group isn't in memory,
then it must be deleted from disk. The previous implementation correctly
removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
when the DocumentLoader was destroyed.

Test: http/tests/appcache/origin-delete.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::clearStorageID): (WebCore::ApplicationCache::deleteCacheForOrigin):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

Use new ApplicationCache API to delete all cache for an origin.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteOrigin:]):

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin instead of ApplicationCacheStorage::deleteEntriesForOrigin. (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

  • DumpRenderTree/LayoutTestController.cpp: (clearApplicationCacheForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs. (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
13:11 Changeset [81556] by gyuyoung.kim@samsung.com
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-03-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy GeolocationServiceEfl. cpp | h
https://bugs.webkit.org/show_bug.cgi?id=56710

Add dummy GeolocationServiceEfl.cpp | h to platform/efl.

  • CMakeListsEfl.txt:
  • platform/efl/GeolocationServiceEfl.cpp: Added. (WebCore::GeolocationServiceEfl::create): (WebCore::GeolocationServiceEfl::GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::startUpdating): (WebCore::GeolocationServiceEfl::stopUpdating): (WebCore::GeolocationServiceEfl::suspend): (WebCore::GeolocationServiceEfl::resume): (WebCore::GeolocationServiceEfl::lastPosition): (WebCore::GeolocationServiceEfl::lastError):
  • platform/efl/GeolocationServiceEfl.h: Added.
13:09 Changeset [81555] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Unreviewed, rolling out r81551.
http://trac.webkit.org/changeset/81551
https://bugs.webkit.org/show_bug.cgi?id=55336

Broke some storage tests on Win32.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
12:22 Changeset [81554] by simonjam@chromium.org
  • 3 edits
    6 deletes in trunk/LayoutTests

2011-03-19 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81528.

  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
12:07 Changeset [81553] by andreas.kling@nokia.com
  • 18 edits in trunk/Source

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712

  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::positionUpdated):

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::selectionRectForSimpleText):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::paint):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::DnsPrefetchHelper): (WebCore::DnsPrefetchHelper::lookup):
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaSliderTrack):
11:35 Changeset [81552] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
https://bugs.webkit.org/show_bug.cgi?id=56711

Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
ownership of the reply is transferred to the receiving slot.

  • Api/qwebpage.cpp:
10:55 Changeset [81551] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
and GetFileAttributesEx() so we can share the code with WinCE.

  • platform/win/FileSystemWin.cpp: (WebCore::createFileHandle): (WebCore::getFileInformation): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
07:25 Changeset [81550] by xan@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify GObjectEventListener
https://bugs.webkit.org/show_bug.cgi?id=56698

Get rid of special case for DOMWindow, since it's also an
EventTarget.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): remove DOMWindow special casing. (WebCore::GObjectEventListener::~GObjectEventListener): ditto. (WebCore::GObjectEventListener::gobjectDestroyed):
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): ditto. (WebCore::GObjectEventListener::removeEventListener): ditto.
06:08 Changeset [81549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-19 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=56195
Fix conditional which had an int for one case and a pointer for another.
Similar fix as https://bugs.webkit.org/show_bug.cgi?id=56198

No new tests. Fix compilation on Solaris 10 with Sun Studio C++

  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
04:42 Changeset [81548] by paroga@webkit.org
  • 26 edits in trunk/Source

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
  • wtf/StringHasher.h: (WTF::StringHasher::computeHash): (WTF::StringHasher::hashMemory):
  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents):
  • dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):

03/18/11:

21:52 Changeset [81547] by mitz@apple.com
  • 3 edits in trunk/Tools

Revised build fix for r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
20:58 Changeset [81546] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/56688> Fix clang static analyzer warning in WebCoreViewFactory.m

Reviewed by Anders Carlsson.

Fixes the following static analyzer warning:

Source/WebCore/page/mac/WebCoreViewFactory.m:45:5: warning: Returning 'self' while it is not set to the result of '[(super or self) init...]'

return self;

  • page/mac/WebCoreViewFactory.m:

(-[WebCoreViewFactory init]): Assign the result of [super init]
to self.

19:18 Changeset [81545] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the WinCairo build.

  • win/WebKit2.vcproj:
19:17 Changeset [81544] by jamesr@google.com
  • 206 edits
    2 adds in trunk/LayoutTests

2011-03-18 James Robinson <jamesr@chromium.org>

Update chromium win pixel baselines for tests with justified text for r81528

  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-win/css1/text_properties/text_align-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.checksum:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.checksum:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.png:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.checksum:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.checksum:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.checksum:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.checksum:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.checksum:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.checksum:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png:
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum:
  • platform/chromium-win/svg/text/bidi-text-query-expected.png:
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum:
  • platform/chromium-win/svg/text/bidi-tspans-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium/test_expectations.txt:
18:40 Changeset [81543] by cevans@google.com
  • 7 edits in branches/chromium/696

Merge 81399
BUG=74653

18:04 Changeset [81542] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/696

Merge 81088
BUG=75347

18:02 Changeset [81541] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/696

Merge 80773
BUG=75347

17:51 Changeset [81540] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build
https://bugs.webkit.org/show_bug.cgi?id=56696

After this patch, the WebCore GYP build successfully compiles and
links. I haven't trying executing it yet.

  • WebCore.gypi:
    • DOMMouseEvent should be included as part of the Objective-C bindings.
  • WebCore.xcodeproj/project.pbxproj:
    • RenderSVGPath.cpp was mistakenly included directly in the project instead of being built by RenderSVGAllInOne.
  • gyp/WebCore.gyp:
    • Exclude some more files from the build. These files are absent in the normal build. I didn't see them earlier because the dead code stripping was hiding them. (They're probably unreferenced.)
    • Switch to using RenderSVGAllInOne. I'm not entirely sure if this part of the patch is necessary, but it matches the normal build more closely.
  • platform/mac/WebCoreObjCExtras.mm:
    • The normal build passes the -Wdeprecated-declarations flag when compiling this file. The GYP folks explicitly do not want to add that feature to GYP, and there does not appear to be a way to remove the deprecated call from this file.
  • rendering/svg/RenderSVGAllInOne.cpp:
    • Add RenderSVGPath.cpp, which was missing previously.
17:48 Changeset [81539] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should (almost!) link
https://bugs.webkit.org/show_bug.cgi?id=56689

This patch is a grab-bag of small changes to bring the WebCore GYP
build down to two link errors or one compile error (take your pick).
We might need a GYP change to get this last file to compile, however.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
17:31 Changeset [81538] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-03-18 James Robinson <jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:
17:15 Changeset [81537] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
https://bugs.webkit.org/show_bug.cgi?id=56505

Added a test to edit contents of hr and datagrid and object's fallback content.

  • editing/editability/ignored-content-expected.txt: Added.
  • editing/editability/ignored-content.html: Added.

2011-03-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Add a test for r81266 and fix HTML Editing for fallback contents in object element
https://bugs.webkit.org/show_bug.cgi?id=56505

The bug was caused by canHaveChildrenForEditing's always returning false even when
object element used fallback content. Fixed the bug by adding a check.

Test: editing/editability/ignored-content.html

  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
17:05 Changeset [81536] by aestes@apple.com
  • 5 edits
    2 adds in trunk

2011-03-18 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=56380

  • fast/parser/fragment-foreign-content-context-expected.txt: Added.
  • fast/parser/fragment-foreign-content-context.html: Added.

2011-03-18 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

REGRESSION (r80231): Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=56380


Fix two issues with parsing a fragment that has a foreign content
element as its context element. The first issue is that the parser will
initially be in the InForeignContentMode insertion mode when processing
the first tag in the fragment in this case so one call site needs to
change from currentElement() to currentNode(). The second issue is that
when we changed fragments from using a fake HTML root element to a
DocumentFragment we broke checks that assumed the root element was in
the HTML namespace. Fix this by claiming that the DocumentFragment is
also in the HTML namespace.

Test: fast/parser/fragment-foreign-content-context.html

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
  • html/parser/HTMLElementStack.h: (WebCore::isInHTMLNamespace):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag):
16:36 Changeset [81535] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Empty gray page after going back from a PDF
https://bugs.webkit.org/show_bug.cgi?id=56694
<rdar://problem/8811854>

Update m_frameHasCustomRepresentation when loading a page that's in the page cache.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
16:36 Changeset [81534] by mrowe@apple.com
  • 2 edits in branches/safari-533.21-branch/WebCore

Merge r80787.

16:36 Changeset [81533] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.21-branch

Merge r79689.

16:30 Changeset [81532] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Martin Robinson <mrobinson@igalia.com>

[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180

  • platform/gtk/Skipped: Unskip tests which should now be passing since this bug is fixed.
16:24 Changeset [81531] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WebKit2 Windows Release Tests] media tests crashing in QuickTime on apple-windows-8.
https://bugs.webkit.org/show_bug.cgi?id=56653

Unreviewed, skipping media/video-load-readyState.html since that has been crashing
on the last 3 runs.

  • platform/win-wk2/Skipped:
16:19 Changeset [81530] by jamesr@google.com
  • 4 edits in branches/chromium/696

Merge 81528 - 2011-03-18 James Robinson <jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):

TBR=jamesr@google.com
BUG=75169

16:15 Changeset [81529] by mrowe@apple.com
  • 5 edits in branches/safari-533.21-branch

Versioning.

16:14 Changeset [81528] by jamesr@google.com
  • 4 edits in trunk

2011-03-18 James Robinson <jamesr@chromium.org>

[chromium] Add tests that will need a rebaseline on windows to expectations

2011-03-18 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(78846) [chromium] Justified text renders at incorrect offsets on windows
https://bugs.webkit.org/show_bug.cgi?id=56629

Preserves offsets as absolute floating point offsets and rounds to
advances at the last possible second. I can't prove to myself that
this is sound but it seems to work on the test cases I've constructed.

Will probably change the pixel tests on chromium windows given that we
were horribly broken before this patch.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
16:11 Changeset [81527] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

16:08 Changeset [81526] by lforschler@apple.com
  • 1 copy in tags/Safari-534.26

New tag.

16:07 Changeset [81525] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-03-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

[GTK] JSC crashes in 32bit Release bots after r80743
https://bugs.webkit.org/show_bug.cgi?id=56180


The crash was caused by referencing GC memory from a GC destructor. This
is not safe because destruction time / order is not guaranteed.

  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::create): (JSC::ProfileGenerator::ProfileGenerator): (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
  • profiler/ProfileGenerator.h: (JSC::ProfileGenerator::origin): Made ExecState* the first argument, to match the rest of this class and JSC.


Use a JSGlobalObject* instead of an ExecState* with an indirect reference
to a JSGlobalObject* to track our origin. This is simpler and more
efficient, and it removes the destruction order dependency that was causing
our crash.

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): Updated for change to JSGlobalObject*. (JSC::Profiler::stopProfiling): New function for stopping all profiles for a given global object. This is more straight-forward than multiplexing through the old function.

(JSC::dispatchFunctionToProfiles): Updated for change to JSGlobalObject*.

  • profiler/Profiler.h: Ditto.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): Ditto.
16:06 Changeset [81524] by mrowe@apple.com
  • 1 copy in branches/safari-533.21-branch

New branch.

16:06 Changeset [81523] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80668
BUG=75374

16:02 Changeset [81522] by dcheng@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Daniel Cheng <dcheng@chromium.org>

Reviewed by David Levin.

Fix incorrect test onpaste-text-html-types.html
https://bugs.webkit.org/show_bug.cgi?id=56621

The test was checking for the presence of "Text" in event.clipboardData.types,
but per http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/024956.html,
this should not be the case.

  • editing/pasteboard/onpaste-text-html-types.html:
15:53 Changeset [81521] by cevans@google.com
  • 3 edits in branches/chromium/696/Source/WebCore

Merge 80798
BUG=73899

15:41 Changeset [81520] by simonjam@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-18 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81489.

  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
15:32 Changeset [81519] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when sending a sync message ends up invalidating the connection
https://bugs.webkit.org/show_bug.cgi?id=56686
<rdar://problem/9048781>

Guard against a null client.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
15:20 Changeset [81518] by rniwa@webkit.org
  • 8 edits in trunk

2011-03-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=56599

Re-enabled the test on non-Mac platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(81374, 81384): editing/deleting/5206311-1.html hits assertion on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=56599

Debug build fix.

  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): If the original position was a position before a node, then we can't necessarily instantiate a position inside the node.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): Even if s and e were not null, container nodes of s and e could be null. Exit early in those cases as well.
15:14 Changeset [81517] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC bindings to the WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56671

It turns out we generate a bunch of ObjC bindings files that we don't
actually build. I've manually synced the list of ObjC derived source
files to match the existing list. This brings us down to 19 link
errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
15:05 Changeset [81516] by cevans@google.com
  • 2 edits
    12 copies in branches/chromium/696

Merge 80682
BUG=61502

14:55 Changeset [81515] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-03-18 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Split JSC related configurations from WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=56624

No new tests, just splitting jsc related configuration.

  • CMakeLists.txt:
  • UseJSC.cmake: Added.
14:50 Changeset [81514] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=56685
webarchive/test-link-rel-icon.html is now flaky

Rubberstamped by Adam Roben.

  • platform/mac/Skipped:
14:48 Changeset [81513] by enne@google.com
  • 3 edits in branches/chromium/696/Source/WebKit/chromium

Merge 81395 - 2011-03-17 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:

TBR=enne@google.com

14:44 Changeset [81512] by senorblanco@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

2011-03-18 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

One last attempt at rebaselining these tests (now that I know how
the --gpu flag works).

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
14:17 Changeset [81511] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <senorblanco@chromium.org>

Unreviewed; more test baselines.

Update the checksums I forgot to update in r81504.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum:
14:15 Changeset [81510] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-18 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] make devtool concatenation targets conditional based on debug_devtools
https://bugs.webkit.org/show_bug.cgi?id=56667

We don't want to run these targets when debug_devtools=1 because it
will overwrite the devtools.js and devtools.css files copied by
inspector_resources. On Linux, this triggers a warning because
there are two commands that target the same output file when
debug_devtools=1.

I also removed the 'sources' lines since I don't think they do
anything for actions.

  • WebKit.gyp:
14:03 Changeset [81509] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
13:59 Changeset [81508] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, re-enable some stable tests and add a flaky one.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [81507] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Benjamin Poulain.

[Qt][WK2] Need a way to debug the web process after the UI process dies
https://bugs.webkit.org/show_bug.cgi?id=56116

Allow the web process to outlive it's parent process
in debug builds if the QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS
environment variable is set.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess): Used getenv since the prctl call is already in a Linux-only block and the implementation in this file is a candidate for sharing across ports in the future.
13:29 Changeset [81506] by cevans@google.com
  • 1 edit in branches/chromium/696/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595

13:28 Changeset [81505] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/html/CollectionCache.h

Merge 80802
BUG=73595
Review URL: http://codereview.chromium.org/6713045

13:18 Changeset [81504] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2011-03-18 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

New GPU baselines for shadow quality improved by http://trac.webkit.org/changeset/81489.

  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
13:04 Changeset [81503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Remove unused method FontFallbackList::fontDataForCharacters()
https://bugs.webkit.org/show_bug.cgi?id=56657

  • platform/graphics/Font.h:
  • platform/graphics/FontFallbackList.cpp:
  • platform/graphics/FontFallbackList.h:
13:04 Changeset [81502] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.4.0

Branching for the 1.4.0 GTK+ stable release.

13:03 Changeset [81501] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-03-18 Andreas Kling <kling@webkit.org>

Reverting accidental changes in r81498.

12:58 Changeset [81500] by aroben@apple.com
  • 2 edits in trunk/Tools

Windows build fix

  • WebKitTestRunner/config.h: Add a missing #endif.
12:49 Changeset [81499] by loislo@chromium.org
  • 7 edits in trunk

2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename console agent events.
https://bugs.webkit.org/show_bug.cgi?id=56646

addConsoleMessage -> consoleMessage
updateConsoleMessageExpiredCount -> consoleMessageExpiredCountUpdate
updateConsoleMessageRepeatCount -> consoleMessageRepeatCountUpdate

WebCore:

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessage): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageExpiredCountUpdate): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdate):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
12:46 Changeset [81498] by andreas.kling@nokia.com
  • 5 edits in trunk

2011-03-18 Andreas Kling <kling@webkit.org>

Unbreak Qt build after r81494.

  • WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
12:38 Changeset [81497] by senorblanco@chromium.org
  • 166 edits
    14 adds in trunk/LayoutTests

2011-03-18 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

New baselines for shadow quality improved by http://trac.webkit.org/changeset/81489.

  • platform/chromium-linux/compositing/geometry: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-linux/compositing/iframes: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-linux/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-expected.png:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.checksum:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-linux/svg/css/shadow-changes-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-win/compositing/geometry: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/chromium-win/compositing/iframes: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.png:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.checksum:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.checksum:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.checksum:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.checksum:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/shadow-changes-expected.checksum:
  • platform/chromium-win/svg/css/shadow-changes-expected.png:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.checksum:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium/test_expectations.txt:
12:36 Changeset [81496] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build. This was really Adam Roben's fault. I swear!

  • WebKitTestRunner/config.h:
12:28 Changeset [81495] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
http://trac.webkit.org/changeset/81487
https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text-expected.txt: Removed.
  • inspector/styles/get-set-stylesheet-text.html: Removed.
  • inspector/styles/resources/get-set-stylesheet-text.css: Removed.
  • inspector/styles/styles-new-API.html:

2011-03-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81487.
http://trac.webkit.org/changeset/81487
https://bugs.webkit.org/show_bug.cgi?id=56662

"Breaks inspector/styles/styles-add-blank-property.html"
(Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyles):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):
12:24 Changeset [81494] by weinig@apple.com
  • 9 edits
    1 move
    2 adds in trunk/Tools

2011-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Pixel tests don't work in WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=56630

Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
built-in snapshotting instead of using the window server on the Mac.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::didReceiveMessage): (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::setPixelResult): (WTR::InjectedBundle::shouldDumpPixels):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): Take the snapshot in the bundle and send it to the UIProcess for dumping.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cg: Added.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm. (WTR::createCGContextFromImage): (WTR::computeMD5HashStringForContext): (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/mac/TestInvocationMac.mm: Removed. Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
  • WebKitTestRunner/win/TestInvocationWin.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Keep stub for Cairo build.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added. Add CG configuration.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files.
12:15 Changeset [81493] by darin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Command-period does not stop load when page has focus in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56601

  • UIProcess/API/mac/WKView.mm: (-[WKView doCommandBySelector:]): If called outside interpretKeyEvents, call through to super. (-[WKView insertText:]): Assert that we are inside interpretKeyEvents. (-[WKView unmarkText]): Ditto. (-[WKView setMarkedText:selectedRange:]): Ditto. (-[WKView _interceptKeyEvent:]): Set a flag to indicate we are inside interpretKeyEvents for use by the above.
12:10 Changeset [81492] by aroben@apple.com
  • 2 edits in trunk/Tools

Don't allow Leaks Viewer's vertical scrollbar to cover up long function names

Rubber-stamped by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
overflow-y:overlay so that the scrollbar doesn't overlay the content.

12:03 Changeset [81491] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[chromium] Add some test expectations missing from r81489.

  • platform/chromium/test_expectations.txt:
12:00 Changeset [81490] by aroben@apple.com
  • 2 edits in trunk/Tools

Don't ellipsize long or indented function names in Leaks Viewer

Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
scrollbar

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(.data-grid .data-container):
(.data-grid td > div, .data-grid th > div):
Allow the contents to extend to the right.

11:14 Changeset [81489] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-18 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=50112
https://bugs.webkit.org/show_bug.cgi?id=51989
https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/chromium/test_expectations.txt:

2011-03-18 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Canvas shadow is not working with drawImage
https://bugs.webkit.org/show_bug.cgi?id=55506

Patch also fixes shadow blur quality and color.
Affects Chromium win/linux. Also fixes the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=50112
https://bugs.webkit.org/show_bug.cgi?id=51989
https://bugs.webkit.org/show_bug.cgi?id=55410
No tests were added, impact is already covered by multiple layout tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
11:11 Changeset [81488] by jberlin@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

Web Inspector: inspector/elements/mutate-unknown-node.html is flakey.
https://bugs.webkit.org/show_bug.cgi?id=56457

Unreviewed, disable the test and remove it from the Qt Skipped list because this test is
also being flakey on Windows.

  • inspector/elements/mutate-unknown-node.html: Removed.
  • inspector/elements/mutate-unknown-node.html-disabled: Copied from inspector/elements/mutate-unknown-node.html.
  • platform/qt/Skipped:
10:55 Changeset [81487] by apavlov@chromium.org
  • 10 edits
    3 adds in trunk

2011-03-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310

Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
"styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
by CSSAgent.getStyleSheet() anymore.

Test: inspector/styles/get-set-stylesheet-text.html

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text-expected.txt: Added.
  • inspector/styles/get-set-stylesheet-text.html: Added.
  • inspector/styles/resources/get-set-stylesheet-text.css: Added. (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles/styles-new-API.html:
10:25 Changeset [81486] by xan@webkit.org
  • 8 edits in trunk/Source

Source/WebCore:

2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649

Add explicit EventTarget API to add/remove event listeners instead
of using GSignal, which due to internal limitations in glib makes
us preemptively add listeners for all event types.

  • bindings/gobject/GObjectEventListener.cpp: add new addEventListener/removeEventListener methods, and small refactoring to store an EventTarget internally instead of a DOM node, which is more generic and can be reused in more cases.
  • bindings/gobject/GObjectEventListener.h: ditto.
  • bindings/gobject/WebKitDOMEventTarget.cpp: (webkit_dom_event_target_add_event_listener): new iface method to add an event listener. (webkit_dom_event_target_remove_event_listener): new iface method to remove an event listener.
  • bindings/gobject/WebKitDOMEventTarget.h: add new iface methods.
  • bindings/scripts/CodeGeneratorGObject.pm: change code generation accordingly.

Source/WebKit/gtk:

2011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] On-demand event-listeners for DOM event signals
https://bugs.webkit.org/show_bug.cgi?id=49649

  • tests/testdomdomwindow.c: update unit tests for new APIs. (load_event_callback): ditto. (test_dom_domview_signals): ditto. (load_status_callback): ditto.
10:07 Changeset [81485] by kerz@chromium.org
  • 2 edits in branches/chromium/648/Source/WebKit/chromium

Merge 76889 - 2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

This addresses a regression introduced by r75784, as described in:
https://bugs.webkit.org/show_bug.cgi?id=53176

The problem is that originalEndContainer and originalEndOffset was
meant to capture the end of the document, but was being assigned after
a call to searchRange->setStart() (when scoping is restarted), which can
result in the Range being collapsed to start (thereby assigning the
wrong value to the Container/Offset pair).

This code is never triggered by layout tests, but I'm adding a regressiono
test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6708026

10:07 Changeset [81484] by beidson@apple.com
  • 28 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase

Reviewed by Sam Weinig.

../WebCore:

-Update the synchronous method names to be prefixed with "synchronous."
-Call asynchronous versions of the appropriate methods if the IconDatabase supports them.

Update icon database calls to be prefixed with "synchronous":

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabaseBase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabaseBase::synchronousIconForPageURL):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::readIconForPageURLFromDisk):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::synchronousIconURLForPageURL):

Add nascent support for an asynchronous icon database mode:

  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::create):
(WebCore::EnumCallback::~EnumCallback):
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::create):
(WebCore::ObjectCallback::~ObjectCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):
(WebCore::IconDatabaseBase::supportsAsynchronousMode):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::iconDataForIconURL):

Add interfaces to use the asynchronous versions of certain IconDatabase calls:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::iconLoadDecisionAvailable):
(WebCore::iconLoadDecisionCallback):
(WebCore::DocumentLoader::getIconLoadDecisionForIconURL):
(WebCore::DocumentLoader::continueIconLoadWithDecision):
(WebCore::iconDataCallback):
(WebCore::DocumentLoader::getIconDataForIconURL):

  • loader/DocumentLoader.h:

Break "startIconLoader" into two pieces so it can be used from both the synchronous and asynchronous
icon database modes:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::iconLoadDecisionReceived):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::continueIconLoadWithDecision):

  • loader/FrameLoader.h:
  • WebCore.exp.in:

../WebKit/efl:

Update already-used function names:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

../WebKit/gtk:

Update already-used function names:

  • webkit/webkiticondatabase.cpp:

(webkit_icon_database_get_icon_uri):
(webkit_icon_database_get_icon_pixbuf):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_icon_uri):

../WebKit/mac:

Update already-used function names:

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):

  • WebView/WebView.mm:

(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

../WebKit/qt:

Update already-used function names:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):

../WebKit/win:

Update already-used function names:

  • WebIconDatabase.cpp:

(WebIconDatabase::iconForURL):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::hasIconForURL):

../WebKit2:

-Update the synchronous method names to be prefixed with "synchronous."
-Add empty implementations for the asynchronous accessors.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::synchronousLoadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::supportsAsynchronousMode):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::iconDataForIconURL):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
09:56 Changeset [81483] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::NativeExecutable::NativeExecutable): (JSC::VPtrHackExecutable::VPtrHackExecutable): (JSC::ScriptExecutable::ScriptExecutable): Use a raw pointer instead of PassRefPtr, like JSString does, since JSGlobalData owns the singleton exectuable structure.
09:50 Changeset [81482] by aroben@apple.com
  • 2 edits
    1 add in trunk/Tools

Fix some leaks in DRT seen on the leaks bot

Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
setWillSendRequestClearHeaderCallback in DRT are leaky

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:

(addURLToRedirectCallback):
(setWillSendRequestClearHeaderCallback):
Use OwnArrayPtr to cause the strings to be deleted.

09:49 Changeset [81481] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix a NSURLCredential leak seen on the leaks bot

Fixes <http://webkit.org/b/56637> -[SynchronousLoader
connection:didReceiveAuthenticationChallenge:] is leaky

Reviewed by John Sullivan.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
cause the NSURLCredential to be released.

09:48 Changeset [81480] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: add missing brace to the generated Inspector.idl.

  • inspector/generate-inspector-idl:
09:42 Changeset [81479] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/Source/WebCore

2011-03-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate from Inspector.idl to InspectorAPI.json for protocol schema definition meta bug.
https://bugs.webkit.org/show_bug.cgi?id=56294

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • inspector/Inspector.idl: Removed.
  • inspector/Inspector.json: Added.
  • inspector/generate-inspector-idl: Added.
09:40 Changeset [81478] by alex@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Fixed compilation after r80925.

  • GNUmakefile.am:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: Added. (WebKit::WebFullScreenManagerProxy::enterFullScreen): (WebKit::WebFullScreenManagerProxy::exitFullScreen): (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): (WebKit::WebFullScreenManagerProxy::getFullScreenRect):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Added. (WebKit::WebFullScreenManagerGtk::WebFullScreenManagerGtk): (WebKit::WebFullScreenManager::create): (WebKit::WebFullScreenManagerGtk::setRootFullScreenLayer): (WebKit::WebFullScreenManagerGtk::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerGtk::beginExitFullScreenAnimation):
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Added.
09:36 Changeset [81477] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

inspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=56633

Unreviewed, skip command-line-api-inspect.html instead of command-line-api.html, since the
former appears to be causing the latter (and probably console-clear.html as well) to time
out.

  • platform/win-wk2/Skipped:
  • platform/win-wk2/inspector: Removed.
  • platform/win-wk2/inspector/console: Removed.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Removed.
09:36 Changeset [81476] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-03-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed compilation after r81208.

  • GNUmakefile.am:
09:09 Changeset [81475] by sergio@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-03-18 Sergio Villar Senin <svillar@igalia.com>

Added new GTK+ test expectations.

  • platform/gtk/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt: Added.
08:51 Changeset [81474] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-03-18 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

Remove unnecessary brackets around my email address.

  • Scripts/webkitpy/common/config/committers.py:
08:42 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
08:41 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
08:31 Changeset [81473] by jberlin@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Two inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release (WebKit2
Tests).
https://bugs.webkit.org/show_bug.cgi?id=56632

Unreviewed, landing expected failing results in order to get the Windows 7 Release
WebKit2 bots green.

  • platform/win-wk2/http: Added.
  • platform/win-wk2/http/tests: Added.
  • platform/win-wk2/http/tests/inspector-enabled: Added.
  • platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Added.
  • platform/win-wk2/inspector: Added.
  • platform/win-wk2/inspector/console: Added.
  • platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Added.
08:29 Changeset [81472] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)

08:27 Changeset [81471] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-18 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] console.log not being exposed to QmlViewer
https://bugs.webkit.org/show_bug.cgi?id=56536

The documentation is bogus the feature does not exist.

  • declarative/qdeclarativewebview.cpp:
08:21 Changeset [81470] by podivilov@chromium.org
  • 12 edits in trunk/Source

2011-03-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643

We would like to enable debugger/profiler from frontend side only.
However, when user clicks "Start Debugging JavaScript" in Safari, we
need to enable debugger when frontend is opened or re-opened for the
same page. The idea is to store debugger-enabled setting in session
storage and check it on frontend load.

  • inspector/InspectorFrontendClient.h: (WebCore::InspectorFrontendClient::saveSessionSetting): (WebCore::InspectorFrontendClient::loadSessionSetting):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::saveSessionSetting): (WebCore::InspectorFrontendHost::loadSessionSetting):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:

2011-03-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting): (-[WebInspectorWindowController inspectorClient]):

2011-03-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting):
  • WebCoreSupport/WebInspectorClient.h:
07:31 Changeset [81469] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, suppress editing/deleting/5206311-1.html crashes on Mac Debug

  • platform/chromium/test_expectations.txt:
07:28 Changeset [81468] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-18 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable GraphicsContext3D only when the window surface support OpenGL
https://bugs.webkit.org/show_bug.cgi?id=56555

Allow creation of WebGLRenderingContext in the HTMLCanvasElement
only if accelerated compositing is enabled. In GraphicsContext3D,
while blitting the surface check that viewport hasn't changed from
creation and painter is associated to the viewport.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getViewportGLWidget): (WebCore::GraphicsContext3DInternal::paint):
07:11 Changeset [81467] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
06:48 Changeset [81466] by apavlov@chromium.org
  • 51 edits
    2 adds in trunk/LayoutTests

2011-03-18 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, rebaseline GPU tests after r81414

  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.checksum:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
05:08 Changeset [81465] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only

Rubber-stamped by Jon Honeycutt.

Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.

  • Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what

each target-specific .xcconfig file should import.

04:18 Changeset [81464] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, fix custom expectation after r81438

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
03:26 Changeset [81463] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console doesn&apos;t scroll when multiline expression is being evaluated
https://bugs.webkit.org/show_bug.cgi?id=56639

Always scoll in the console when command result is received.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage):
03:09 Changeset [81462] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium test_expectations.txt.

There was a duplicate for inspector/mutate-unknown-node.html

  • platform/chromium/test_expectations.txt:
02:36 Changeset [81461] by caseq@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-03-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

http/tests/inspector/resource-parameters.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55867

Fixed test flakiness by not finishing test before proper resource arrives.

  • http/tests/inspector/resource-parameters.html: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html-disabled.
02:14 Changeset [81460] by aroben@apple.com
  • 1 edit
    2 deletes in trunk/Tools

Remove some files I accidentally added in r81454

  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
  • WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
02:12 Changeset [81459] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: cleanup Web Inspector expectations.
https://bugs.webkit.org/show_bug.cgi?id=56635

Many Inspector tests are passing now but they still have expectations.
I've removed unnecessary expectations and grouped the remainings.

  • platform/chromium/test_expectations.txt:
02:08 Changeset [81458] by aroben@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows WebKit2 expected failure results for a media test

The failure is tracked by <http://webkit.org/b/56636>.

  • platform/win-wk2/media/controls-without-preload-expected.txt: Added.
02:07 Changeset [81457] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip some timing out tests in WebKit2 on Windows

Tracked by <http://webkit.org/b/56633> and <http://webkit.org/b/56634>.

  • platform/win-wk2/Skipped: Added inspector/console/command-line-api.html and

http/tests/xmlhttprequest/cross-origin-authorization.html.

02:05 Changeset [81456] by aroben@apple.com
  • 1 edit
    12 adds in trunk/LayoutTests

Add expected failure results for WebKit2 tests failing on Windows due to font differences

<http://webkit.org/b/56617> tracks the failures.

  • platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-wk2/svg/text/bidi-text-query-expected.txt: Added.
02:03 Changeset [81455] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test in that is probably causing the next test to crash in WebKit2

<http://webkit.org/b/55780> tracks the failure.

  • platform/win-wk2/Skipped: Skip platform/win/plugins/draws-gradient.html instead of

platform/win/plugins/get-value-netscape-window.html. The former was probably causing the
latter to crash.

02:01 Changeset [81454] by aroben@apple.com
  • 1 edit
    1 move
    3 adds in trunk

Disable a flakey inspector test

<http://webkit.org/b/56565> tracks the failure.

  • inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Renamed from LayoutTests/inspector/elements/elements-panel-xhtml-structure.xhtml.
00:39 Changeset [81453] by aroben@apple.com
  • 2 edits in trunk/Tools

Ignore an NSNumberFormatter leak on SnowLeopard

  • Scripts/old-run-webkit-tests:

(countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
getObjectValue:forString:errorDescription:].

00:37 Changeset [81452] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a CFNumber leak seen on the leaks bot

Reviewed by Gavin Barraclough.

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.

00:34 Changeset [81451] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/648

Merge 80797
BUG=73595
Review URL: http://codereview.chromium.org/6709024

00:26 Changeset [81450] by cevans@google.com
  • 6 edits
    6 copies in branches/chromium/696

Merge 80797
BUG=73595

00:19 Changeset [81449] by aroben@apple.com
  • 2 edits in trunk/Tools

Fix a leak beneath LayoutTestController::authenticateSession seen on the bots

Rubber-stamped by Mark Rowe.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
released.

00:09 Changeset [81448] by aroben@apple.com
  • 2 edits in trunk/Tools

Address a review comment I missed in r81445

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
leaked bytes to speed up searching on long lines.

00:01 Changeset [81447] by aroben@apple.com
  • 2 edits in trunk/Tools

Mark leaky builds orange, even if all regression tests passed

Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
build.webkit.org when all tests pass even though there are still leaks

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
be marked orange if this build step generates warnings.

Note: See TracTimeline for information about the timeline view.