Timeline


and

03/23/11:

23:48 Changeset [81854] by commit-queue@webkit.org

2011-03-23 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] WebBindings{.h,.cpp}: should use consistent argument naming
https://bugs.webkit.org/show_bug.cgi?id=56898

Address FIXME I noted/added in r81676. Wanted to just copy/paste the checking
code from elsewhere in the file, but inconsistent argument naming made it more
difficult than it need be, so first step: use consistent naming.

  • public/WebBindings.h:
  • src/WebBindings.cpp: (WebKit::WebBindings::construct): (WebKit::WebBindings::enumerate): (WebKit::WebBindings::evaluate): (WebKit::WebBindings::evaluateHelper): (WebKit::WebBindings::getProperty): (WebKit::WebBindings::hasMethod): (WebKit::WebBindings::hasProperty): (WebKit::WebBindings::invoke): (WebKit::WebBindings::invokeDefault): (WebKit::WebBindings::releaseObject): (WebKit::WebBindings::removeProperty): (WebKit::WebBindings::retainObject): (WebKit::WebBindings::setException): (WebKit::WebBindings::setProperty): (WebKit::WebBindings::unregisterObject): (WebKit::WebBindings::extractIdentifierData): (WebKit::getRangeImpl): (WebKit::getElementImpl): (WebKit::makeIntArrayImpl): (WebKit::WebBindings::getRange): (WebKit::WebBindings::makeIntArray):
21:02 Changeset [81853] by lforschler@apple.com

Versioning.

20:55 Changeset [81852] by lforschler@apple.com

New tag.

20:48 Changeset [81851] by tkent@chromium.org

[Chromium] Force to make validation bubble DIV position:absolute
https://bugs.webkit.org/show_bug.cgi?id=56901

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/forms/interactive-validation-crash-by-style-override.html

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree): Add position:absolute

because we need to move the validation message to a good position.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):

LayoutTests:

  • fast/forms/interactive-validation-crash-by-style-override-expected.txt: Added.
  • fast/forms/interactive-validation-crash-by-style-override.html: Added.
  • platform/gtk/Skipped: Skip the new test because the interactive validation feature is not enabled.
  • platform/mac/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
20:22 Changeset [81850] by ojan@chromium.org

2011-03-23 Ojan Vafai <ojan@chromium.org>

Add failing result for WebKit2. All tests that require
focus fail on WebKit2. See https://bugs.webkit.org/show_bug.cgi?id=56988.

  • platform/mac-wk2/fast/css/pseudo-any-expected.txt: Added.
20:18 Changeset [81849] by commit-queue@webkit.org

2011-03-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by Ojan Vafai.

flex/bison tokens and grammar for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=54412

Only the 'errors' tests pass as ultimately intended right now. As of this
patch, none of the actual calculations are expected to work, since only
the lexing/grammar stage is present.

  • css3/calc/calc-errors-expected.txt: Added.
  • css3/calc/calc-errors.html: Added.
  • css3/calc/minmax-errors-expected.txt: Added.
  • css3/calc/minmax-errors.html: Added.
  • css3/calc/simple-calcs-expected.txt: Added.
  • css3/calc/simple-calcs.html: Added.
  • css3/calc/simple-minmax-expected.txt: Added.
  • css3/calc/simple-minmax.html: Added.

2011-03-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by Ojan Vafai.

flex/bison tokens and grammar for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=54412

Tests: css3/calc/calc-errors.html

css3/calc/minmax-errors.html
css3/calc/simple-calcs.html
css3/calc/simple-minmax.html

  • css/CSSGrammar.y:
  • css/CSSParserValues.cpp: (WebCore::CSSParserValueList::insertValueAt): (WebCore::CSSParserValueList::extend):
  • css/CSSParserValues.h:
  • css/tokenizer.flex:
20:10 Changeset [81848] by commit-queue@webkit.org

2011-03-23 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
https://bugs.webkit.org/show_bug.cgi?id=56961

  • http/tests/filesystem/resolve-uri-expected.txt:
  • http/tests/filesystem/script-tests/resolve-uri.js: Added three tests to exercise SECURITY_ERR: (runWrongDomain): (runWrongPort): (runWrongScheme): And updated four tests to test error codes: (runBogusURL): (runWrongProtocol): (runNotEnoughSlashes): (runNotEnoughSlashes2):
  • http/tests/filesystem/workers/resolve-url-expected.txt:
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt:
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added three tests to exercise SECURITY_ERR: (runWrongDomain): (runWrongPort): (runWrongScheme): And updated four tests to test error codes: (runBogusURL): (runWrongProtocol): (runNotEnoughSlashes): (runNotEnoughSlashes2):

2011-03-23 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
https://bugs.webkit.org/show_bug.cgi?id=56961

See error code listing in the Files & Directories spec:
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-LocalFileSystemSync-resolveLocalFileSystemSyncURL

Note that the spec currently only specifies errors for the sync
version; I've used the same codes for the async version.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURL):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::resolveLocalFileSystemURL): (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
19:53 Changeset [81847] by commit-queue@webkit.org

2011-03-23 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • platform/mac-wk2/Skipped: Enable autocorrection tests for WK2.

2011-03-23 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
major changes:

  1. All but one autocorrection related message is synchronous. Since dismissing autocorrection panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function is introduced to ensure all editing commands occur in correct order.
  1. Additional condition variable is needed to implement dismissCorrectionPanelSoon(). To improve maintainability, CorrectionPanel class is introduced to manage the internal state related to correction panel. This change is applied to both WK1 and WK2.
  1. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow editor to know when to handle ESC key event. Now this is handled internally in AppKit, so EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
  1. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can access object via WebView or WKView.
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired): (WebCore::Editor::dismissCorrectionPanel): (WebCore::Editor::dismissCorrectionPanelSoon): (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::showCorrectionPanel): (WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
  • manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
  • page/EditorClient.h:

2011-03-23 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • WebKit.xcodeproj/project.pbxproj:

2011-03-23 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

  • WebCoreSupport/CorrectionPanel.h: Added. (CorrectionPanel::isShowing):
  • WebCoreSupport/CorrectionPanel.mm: Added. (correctionBubbleType): (CorrectionPanel::CorrectionPanel): (CorrectionPanel::~CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::recordAutocorrectionResponse):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::showCorrectionPanel): (WebEditorClient::dismissCorrectionPanel): (WebEditorClient::dismissCorrectionPanelSoon): (WebEditorClient::recordAutocorrectionResponse):
  • WebView/WebView.mm: (-[WebView handleCorrectionPanelResult:]):
  • WebView/WebViewPrivate.h:

2011-03-23 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Hook up new AppKit autocorrection UI with WK2.
https://bugs.webkit.org/show_bug.cgi?id=56055
<rdar://problem/8947463>

Please see WebCore/ChangeLog for detail.

The calls to AppKit are implemented in PageClientImpl. Other changes are necessary for the
plumbing work.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::showCorrectionPanel): (WebKit::PageClientImpl::dismissCorrectionPanel): (WebKit::PageClientImpl::dismissCorrectionPanelSoon): (WebKit::PageClientImpl::recordAutocorrectionResponse):
  • UIProcess/API/mac/WKView.mm: (-[WKView spellCheckerDocumentTag]): (-[WKView handleCorrectionPanelResult:]):
  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::showCorrectionPanel): (WebKit::WebPageProxy::dismissCorrectionPanel): (WebKit::WebPageProxy::dismissCorrectionPanelSoon): (WebKit::WebPageProxy::recordAutocorrectionResponse): (WebKit::WebPageProxy::handleCorrectionPanelResult):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/CorrectionPanel.h: Added. (WebKit::CorrectionPanel::isShowing):
  • UIProcess/mac/CorrectionPanel.mm: Added. (correctionBubbleType): (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::~CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismiss): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::recordAutocorrectionResponse):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::showCorrectionPanel): (WebKit::WebEditorClient::dismissCorrectionPanel): (WebKit::WebEditorClient::dismissCorrectionPanelSoon): (WebKit::WebEditorClient::recordAutocorrectionResponse):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::handleCorrectionPanelResult):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
19:43 Changeset [81846] by jcivelli@chromium.org

2011-03-23 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Relanding:
Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
19:34 Changeset [81845] by ojan@chromium.org

2011-03-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

move :not over to using selectorList instead of simpleSelector
https://bugs.webkit.org/show_bug.cgi?id=56894

Saves memory and simplifies code.

No new tests since existing tests cover this code.

  • css/CSSGrammar.y: Also removed extranenous calls to updateLastSelectorLineAndPosition in simple_selector_list. These happened to work, but are only actually needed in selector_list.
  • css/CSSParserValues.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificityForOneSelector): Removed null-check. The parser null-checks, I don't see why we need to here. (WebCore::CSSSelector::selectorText): Ditto. (WebCore::CSSSelector::setArgument): (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
  • css/CSSSelectorList.cpp: (WebCore::forEachTagSelector):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector): (WebCore::collectFeaturesFromList):
19:25 Changeset [81844] by carol.szabo@nokia.com

2011-03-23 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

This test verifies the correct update of a second renderer that
displays the same CounterNode.

Assertion and incorrect rendering of counters.
https://bugs.webkit.org/show_bug.cgi?id=56896

  • fast/css/counters/2displays-expected.txt: Added.
  • fast/css/counters/2displays.html: Added.

2011-03-23 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Made sure that renderers displaying counters are invalidated upon
counter destruction.

Assertion and incorrect rendering of counters.
https://bugs.webkit.org/show_bug.cgi?id=56896

Test: fast/css/counters/2displays.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::~CounterNode): Added to make sure that its display renderers are always reset when the node is deleted. (WebCore::CounterNode::resetRenderers): Fixed bug that would prevent reset of second and subsequent display renderers.
  • rendering/CounterNode.h:
  • rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeWithoutMapRemoval): removed unnecessary calls to resetRenderers() as the CounterNode destructor takes care of that now.
19:03 Changeset [81843] by lforschler@apple.com

Merge r81832.

19:02 Changeset [81842] by lforschler@apple.com

Merge r81831.

18:59 Changeset [81841] by lforschler@apple.com

Merge r81745.

18:57 Changeset [81840] by lforschler@apple.com

Merge r81680.

18:54 Changeset [81839] by lforschler@apple.com

Merge r81622.

18:54 Changeset [81838] by commit-queue@webkit.org

2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Darin Adler.

Media Stream API: fix the order of the options in build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=56949

Fix the order of the options in build-webkit.

  • Scripts/build-webkit:
18:52 Changeset [81837] by lforschler@apple.com

Merge r81600.

18:44 Changeset [81836] by bweinstein@apple.com

WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add functions that need to be exported.

  • WebCore.exp.in:

Source/WebKit2:

Call through to HTMLMediaElement functions to manage the WebCore media cache.

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManager::clearCacheForHostname):
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames):

18:33 Changeset [81835] by commit-queue@webkit.org

2011-03-23 Robert Kroeger <rjkroege@chromium.org>

Reviewed by James Robinson.

Correct use of ENABLE() Macro

In http://trac.webkit.org/changeset/81618, I mis-used the ENABLE()
macro. This patch corrects.

https://bugs.webkit.org/show_bug.cgi?id=56964

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
18:13 Changeset [81834] by commit-queue@webkit.org

2011-03-23 Adam Klein <adamk@chromium.org>

Reviewed by Mihai Parparita.

Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
https://bugs.webkit.org/show_bug.cgi?id=56884

This option will be utilized by Chromium's ui_tests to allow
referencing js-test-resources from a layout test over HTTP.

  • Scripts/new-run-webkit-httpd: Added --layout_tests_dir option.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Plumbed through as layout_tests_dir param.
17:58 Changeset [81833] by jer.noble@apple.com

2011-03-23 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Scrubbing <video> with HTTP Live Stream resizes element to 0x0
https://bugs.webkit.org/show_bug.cgi?id=55702

QTKit will occasionally set the natural size of a QTMovie to 0x0 while scrubbing
an HTTP Live Stream. So we will cache the last valid value returned by QTKit
and use that as our naturalSize until a new valid value is returned.

Unfortunately, QTKit will also fail to generate a notification when the natural size
changes, so we are forced to cache the natural size from within naturalSize(), which
is a const function, necessitating a const_cast to set m_cachedNaturalSize.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Added m_cachedNaturalSize.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_cachedNaturalSize. (WebCore::MediaPlayerPrivateQTKit::naturalSize):
17:50 Changeset [81832] by ap@apple.com

Build fix.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed a stray parenthesis.
17:48 Changeset [81831] by ap@apple.com

Reviewed by Maciej Stachowiak.

REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading()
https://bugs.webkit.org/show_bug.cgi?id=56978
<rdar://problem/9041670>

No new tests, because there is no known way to reproduce.

Removed strange code that was trying to stop a non-loading provisional document loader and
even its subframes (?!). Added assertions to catch it if we can actually be loading here in
some sense.
Rewrote a condition for clarity - starting with r43148, it was acting as an opposite of a
recursion guard (but that didn't cause immediate problems then).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
17:38 Changeset [81830] by beidson@apple.com

Attempt to fix the build for platforms that have the icon database
disabled but still provide settings API for it...?

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::defaultDatabaseFilename):

17:21 Changeset [81829] by kbr@google.com

2011-03-23 Kenneth Russell <kbr@google.com>

Rolled forward Chromium DEPS again to fix DumpRenderTree build
failure caused by r81821.

  • DEPS:
17:21 Changeset [81828] by lforschler@apple.com

Versioning.

17:21 Changeset [81827] by enrica@apple.com

Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
https://bugs.webkit.org/show_bug.cgi?id=56974
<rdar://problem/8284642>

Reviewed by Alexey Proskuryakov.

This fixes a regression introduced by http://trac.webkit.org/changeset/61794
where readSelectionFromPasteboard was accidentally removed.
This method and writeSelectionToPasteboard are needed to support Mac OS X
services.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
(-[WebHTMLView readSelectionFromPasteboard:]): Added.

17:20 Changeset [81826] by mrowe@apple.com

Fix the build.

  • WebCore.exp.in: Export the new version of IconDatabase::open.
17:06 Changeset [81825] by mrowe@apple.com

<rdar://problem/7959320> Threads that use APIs above the BSD layer must be registered with the Obj-C GC.

Reviewed by Darin Adler.

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

16:56 Changeset [81824] by beidson@apple.com

Change IconDatabase opening to allow for arbitrary filenames
https://bugs.webkit.org/show_bug.cgi?id=56977

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::open):

  • loader/icon/IconDatabaseBase.h:
  • loader/icon/IconDatabaseClient.h:

../WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):

../WebKit/gtk:

  • webkit/webkiticondatabase.cpp:

(webkit_icon_database_set_path):

../WebKit/mac:

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase _startUpIconDatabase]):

../WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::setIconDatabasePath):

../WebKit/win:

  • WebIconDatabase.cpp:

(WebIconDatabase::startUpIconDatabase):

16:56 Changeset [81823] by kbr@google.com

2011-03-23 Kenneth Russell <kbr@google.com>

Rolled forward Chromium DEPS to fix build breakage after r81821.

  • DEPS:
16:48 Changeset [81822] by xji@chromium.org

2011-03-23 Xiaomei Ji <xji@chromium.org>

Rebaseline chromium-mac after r81807.

  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:24 Changeset [81821] by kbr@google.com

2011-03-23 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=56947

Removed the WebRuntimeFeatures setting for WebGL. WebGL support is
now controlled exclusively through the page's Settings.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

2011-03-23 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] WebGLRenderingContext and other DOMWindow properties should remain if WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=56947

Removed the RuntimeEnabledFeatures setting for WebGL and the
EnabledAtRuntime extended attribute from the WebGL-related
properties on the DOMWindow. WebGL support is now controlled
exclusively through the page's Settings.

No new tests; tested manually in Chromium with --disable-webgl
command line argument and blacklist.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.idl:
16:23 Changeset [81820] by xji@chromium.org

2011-03-23 Xiaomei Ji <xji@chromium.org>

Rebaseline after r81807.

  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
16:19 Changeset [81819] by jeffm@apple.com

2011-03-23 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add WKBundleSetHostAllowsAnyHTTPSCertificate() for Windows
https://bugs.webkit.org/show_bug.cgi?id=56972


This is the WebKit2 equivalent to the WebKit1 API IWebMutableURLRequest::setAllowsAnyHTTPSCertificate().

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetHostAllowsAnyHTTPSCertificate): Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetHostAllowsAnyHTTPSCertificate().
  • WebProcess/InjectedBundle/InjectedBundle.h: Added setHostAllowsAnyHTTPSCertificate().
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added, should never be called.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: (WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): Added.
16:01 Changeset [81818] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Rebaseline transitions/default-timing-function.html for Chromium Snow
Leopard.

  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.checksum: Copied from LayoutTests/platform/chromium-mac/transitions/default-timing-function-expected.checksum.
  • platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Copied from LayoutTests/platform/chromium-mac/transitions/default-timing-function-expected.png.
  • platform/chromium-mac/transitions/default-timing-function-expected.checksum:
  • platform/chromium-mac/transitions/default-timing-function-expected.png:
  • platform/chromium/test_expectations.txt:
15:41 Changeset [81817] by mrobinson@webkit.org

2011-03-23 Martin Robinson <mrobinson@igalia.com>

[GTK] fast/overflow/horizontal-scroll-after-back.html fails
https://bugs.webkit.org/show_bug.cgi?id=56966

  • platform/gtk/Skipped: Skip this test on GTK+ until the fix is in.
15:39 Changeset [81816] by hyatt@apple.com

Unreviewed, rolling out r81802.
http://trac.webkit.org/changeset/81802
https://bugs.webkit.org/show_bug.cgi?id=56963

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-23
Broke a layout test, and this fix is not trivial. (Requested
by dhyatt on #webkit).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

15:34 Changeset [81815] by dpranke@chromium.org

2011-03-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: run tests in ascending alphabetical order per
dir. This is a second attempt at the fix; the first attempt, in
r81597, broke the behavior on the old-inline and old-threads
worker models.

https://bugs.webkit.org/show_bug.cgi?id=56760

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
15:29 Changeset [81814] by weinig@apple.com

Roll out r81593 Need WebKit2 API for creating a page with a specific main frame name

Reviewed by Anders Carlsson.

This API is not necessary.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createMainFrame):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

15:23 Changeset [81813] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Update expectations for one SVG and two media tests for Chromium Snow
Leopard.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png.
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
15:04 Changeset [81812] by commit-queue@webkit.org

2011-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

REGRESSION(81035): crash in RenderDetails::removeChild
https://bugs.webkit.org/show_bug.cgi?id=56773

  • fast/html/details-children-merge-crash-expected.txt: Added.
  • fast/html/details-children-merge-crash.html: Added.

2011-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

REGRESSION(81035): crash in RenderDetails::removeChild
https://bugs.webkit.org/show_bug.cgi?id=56773

Test: fast/html/details-children-merge-crash.html

Preventing merging of RenderDetails's anonymous children.

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):

Fixing RenderDetails::removeChild and cleaning m_marker in RenderDetails::destroy.

  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::destroy): (WebCore::RenderDetails::removeChild):
15:03 Changeset [81811] by kbalazs@webkit.org

2011-03-23 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[WK2] Handle keyboard and mouse events on X11
https://bugs.webkit.org/show_bug.cgi?id=56103

Propagate keyboard and mouse events to the plugin
as XEvent's.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::initializeXEvent): (WebKit::xTimeStamp): (WebKit::xKeyModifiers): (WebKit::setCommonMouseEventFields): (WebKit::setXMotionEventFields): (WebKit::setXButtonEventFields): (WebKit::setXCrossingEventFields): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::setXKeyEventFields): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
15:02 Changeset [81810] by mario@webkit.org

2011-03-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
https://bugs.webkit.org/show_bug.cgi?id=56953

Print the string for the detail of 'property-change' signal.

  • DumpRenderTree/gtk/AccessibilityCallbacks.cpp: (axObjectEventListener): Print the detail string.
14:46 Changeset [81809] by mrowe@apple.com

New branch.

14:36 Changeset [81808] by xji@chromium.org

2011-03-23 Xiaomei Ji <xji@chromium.org>

Add fast/css/bidi-override-in-anonymous-block.html as expected to fail after r81807.

  • platform/chromium/test_expectations.txt:
14:27 Changeset [81807] by xji@chromium.org

2011-03-23 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Preserve unicode-bidi:bidi-override in anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=21440

unicode-bidi:bidi-override should be preserved in anonymous block
according to http://www.w3.org/TR/CSS21/visuren.html#propdef-unicode-bidi.

Introduce a helper function RenderStyle()::createAnonymousStyle() which
creates a default RenderStyle, inherits the inherited style from parent,
and inherit unicode-bidi:bidi-override from parent.
And replace the style creation when anonymous block is created.

Note: the TABLE releated anonymous blocks are untouched, including:
TABLE, TABLE_CELL, TABLE_ROW, TABLE_ROW_GROUP anonymous blocks created in
RenderObject, RenderTable, RenderTableRow, and RenderTableSection,
due to the expected behavior is not clear.
Please refer to https://bugs.webkit.org/show_bug.cgi?id=56594.


Test: fast/css/bidi-override-in-anonymous-block.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::createAnonymousBlock): (WebCore::RenderBlock::createAnonymousColumnsBlock): (WebCore::RenderBlock::createAnonymousColumnSpanBlock):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildIgnoringContinuation):
  • rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::createRubyBase): (WebCore::RenderRubyRun::staticCreateRubyRun):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::createAnonymousStyle):
  • rendering/style/RenderStyle.h:

2011-03-23 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Preserve unicode-bidi:bidi-override in anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=21440

  • fast/css/bidi-override-in-anonymous-block.html: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
14:24 Changeset [81806] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Group Snow Leopard failures for bug 56962.

  • platform/chromium/test_expectations.txt:
14:21 Changeset [81805] by mrowe@apple.com

Stop setting OTHER_OPTIONS in JavaScriptCore's Makefile.

It's not necessary to pass "-target All" as xcodebuild always builds the
first target in the project unless otherwise specified. The presence of
that option also breaks "make clean" since that results in both the
-target and -alltargets options being passed to xcodebuild.

  • Makefile:
14:06 Changeset [81804] by inferno@chromium.org

2011-03-23 Abhishek Arya <inferno@chromium.org>

Unreviewed. Replace shockwave plugin with test netscape in recent
timing out test plugins/change-widget-and-click-crash.html.

  • plugins/change-widget-and-click-crash.html:
14:05 Changeset [81803] by commit-queue@webkit.org

2011-03-23 George Guo <George.Guo@nokia.com>

Reviewed by Darin Adler.

Webkit warning: converting to 'unsigned int' from 'double'
https://bugs.webkit.org/show_bug.cgi?id=56865

With -Werr enabled, this cause the build failure on RedHat Linux.
Add a cast helped.

  • Source/JavaScriptCore/runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
13:39 Changeset [81802] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56909

Reviewed by Dan Bernstein.

Add a simplified normal flow layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.

Currently there is an optimized code path for positioned objects, but as soon as
we encounter a normal flow object in the containing block chain, we lose the
optimization.

This patch adds a new type of style difference called SimplifiedLayout that is
returned when only overflow needs to be recomputed. Whenever opacity changes or
a transform changes, this is the hint returned now instead of a full layout.

In addition, when positioned objects need layout and start marking up the
containing block chain, we now propagate the fact that the layout is simplified
all the way up to the root, even when we encounter normal flow containing
blocks.

The layoutOnlyPositionedObjects function has been renamed to simplifiedLayout()
and is now used for all of these cases (in addition to what it handled before).

No new tests, since existing tests covered this very well (especially the opacity
and transforms repaint tests in fast/repaint).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::adjustStyleDifference):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

13:34 Changeset [81801] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Fix more tests for Chromium Snow Leopard by promoting chromium-mac/
results to mac-leopard/ where possible.

  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum.
  • platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum.
  • platform/chromium-mac-leopard/fast/box-shadow/box-shadow-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Removed.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Removed.
  • platform/chromium-mac/css1/units/length_units-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/mac-leopard/css1/text_properties/text_indent-expected.checksum:
  • platform/mac-leopard/css1/text_properties/text_indent-expected.png:
  • platform/mac-leopard/css1/units/length_units-expected.checksum:
  • platform/mac-leopard/css1/units/length_units-expected.png:
  • platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum.
  • platform/mac-leopard/fast/css-generated-content/table-row-before-after-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png.
  • platform/mac-leopard/fast/multicol/scrolling-overflow-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum.
  • platform/mac-leopard/fast/multicol/scrolling-overflow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png.
  • platform/mac/css1/text_properties/text_indent-expected.checksum:
  • platform/mac/css1/text_properties/text_indent-expected.png:
  • platform/mac/css1/units/length_units-expected.checksum:
  • platform/mac/css1/units/length_units-expected.png:
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.checksum:
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.png:
13:17 Changeset [81800] by bweinstein@apple.com

Skip plugins/change-widget-and-click-crash.html on WebKit2, because
WebKit2 doesn't have an implementation of eventSender yet.

  • platform/mac-wk2/Skipped:
13:13 Changeset [81799] by commit-queue@webkit.org

2011-03-23 Tyler Close <tjclose@chromium.org>

Reviewed by Jeremy Orlow.

Fix ambiguous method call in V8 IDL generated code for DOMStringList callback parameter
https://bugs.webkit.org/show_bug.cgi?id=56950

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::callbackWithStringList):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_string_list):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::callbackWithStringList):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithStringList:]):
  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithStringList):
  • bindings/scripts/test/V8/V8TestCallback.h:
13:10 Changeset [81798] by andersca@apple.com

2011-03-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Connection::SyncMessageState::processIncomingMessage should ignore whether the message is sync or not
https://bugs.webkit.org/show_bug.cgi?id=56954

This is so we'll eventually be able to send sync messages that aren't processed immediately if the
destination is waiting for a reply to another synchronous message.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::processIncomingMessage): Only check for the DispatchMessageWhenWaitingForSyncReply flag.

(CoreIPC::Connection::sendSyncMessage):
Add both DispatchMessageWhenWaitingForSyncReply and SyncMessage to the message ID.

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::sendSync): (CoreIPC::Connection::deprecatedSendSync): No need to add SyncMessage here anymore.
13:04 Changeset [81797] by crogers@google.com

2011-03-23 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add API to retrieve the audio hardware sample-rate
https://bugs.webkit.org/show_bug.cgi?id=56882

  • public/WebAudioDevice.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::audioHardwareSampleRate):
  • src/AudioDestinationChromium.cpp: (WebCore::AudioDestination::hardwareSampleRate):
12:52 Changeset [81796] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Fix fast/table for Chromium Snow Leopard by promoting the chromium-mac/
baselines to mac-leopard/.

  • platform/mac-leopard/fast/table/dynamic-descendant-percentage-height-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum.
  • platform/mac-leopard/fast/table/dynamic-descendant-percentage-height-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png.
  • platform/mac-leopard/fast/table/relative-position-containment-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-containment-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-containment-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-containment-expected.png.
  • platform/mac-leopard/fast/table/relative-position-offsets-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-offsets-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-offsets-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-offsets-expected.png.
  • platform/mac-leopard/fast/table/relative-position-stacking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-stacking-expected.checksum.
  • platform/mac-leopard/fast/table/relative-position-stacking-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/relative-position-stacking-expected.png.
12:35 Changeset [81795] by inferno@chromium.org

2011-03-23 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Add refptr for widget. Mutations can happen within the event handler.
https://bugs.webkit.org/show_bug.cgi?id=56774

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent):

2011-03-23 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Add refptr for widget. Mutations can happen within the event handler.
https://bugs.webkit.org/show_bug.cgi?id=56774

Test: plugins/change-widget-and-click-crash.html

  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):

2011-03-23 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Add test for crash when modifying a widget object within an event handler.
https://bugs.webkit.org/show_bug.cgi?id=56774

  • plugins/change-widget-and-click-crash-expected.txt: Added.
  • plugins/change-widget-and-click-crash.html: Added.
12:32 Changeset [81794] by inferno@chromium.org

2011-03-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when casting a text fragment of an input box
to combine text.
https://bugs.webkit.org/show_bug.cgi?id=56358

  • fast/text/input-box-text-fragment-combine-text-crash-expected.txt: Added.
  • fast/text/input-box-text-fragment-combine-text-crash.html: Added.

2011-03-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Add combine text cast checks since style property is insufficient
in telling object types.
https://bugs.webkit.org/show_bug.cgi?id=56358

Test: fast/text/input-box-text-fragment-combine-text-crash.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):
12:29 Changeset [81793] by andreas.kling@nokia.com

2011-03-23 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] "Unwavering" HTML5 game freezes the web page.
https://bugs.webkit.org/show_bug.cgi?id=56944

For canvas's getImageData() API, we don't want to make a deep-copy of
the pixels, which is the case on Qt's "raster" graphics system.

To work around this, we trick QPixmap::toImage() into giving us the
QPixmap's backing QImage by temporarily pointing the paint engine to
a null paint device.

  • platform/graphics/qt/ImageBufferData.h:
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::toQImage): Added, returns the ImageBufferData as a QImage, avoiding a backend deep-copy if possible. (WebCore::ImageBuffer::platformTransformColorSpace): (WebCore::getImageData):
12:13 Changeset [81792] by commit-queue@webkit.org

2011-03-23 Viet-Trung Luu <viettrungluu@chromium.org>

Reviewed by Tony Chang.

[chromium] Add FormatPlainText to WebClipboard::Format enumeration.
https://bugs.webkit.org/show_bug.cgi?id=56868

Chromium's WebClipboard::isFormatAvailable() will be correspondingly
extended.

  • platform/chromium/PasteboardPrivate.h: Add corresponding enum entry.

This part of the change is inert and should have no effect.

2011-03-23 Viet-Trung Luu <viettrungluu@chromium.org>

Reviewed by Tony Chang.

[chromium] Add FormatPlainText to WebClipboard::Format enumeration.
https://bugs.webkit.org/show_bug.cgi?id=56868

Chromium's WebClipboard::isFormatAvailable() will be correspondingly
extended.

  • public/WebClipboard.h:
  • src/AssertMatchingEnums.cpp:
11:39 Changeset [81791] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Update Chromium Snow Leopard baselines for SVG tests after r81168.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/scrollbar-expected.png.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/carto.net/selectionlist-expected.png.
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/image-small-width-height-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.txt.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-text-query-expected.txt.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.png.
  • platform/chromium-mac-leopard/svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/text/bidi-tspans-expected.txt.
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-align-02-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-align-02-b-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-fonts-02-t-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-text-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-text-01-b-expected.png.
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum.
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/text-tspan-01-b-expected.png.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
11:31 Changeset [81790] by bweinstein@apple.com

Qt Build Fix.

  • DerivedSources.pro:
11:26 Changeset [81789] by commit-queue@webkit.org

2011-03-23 Tyler Close <tjclose@chromium.org>

Reviewed by Jeremy Orlow.

run-bindings-tests reference files are out of sync with CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=56934

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::createStructure): (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): (WebCore::JSTestInterface::createPrototype):
  • bindings/scripts/test/JS/JSTestInterface.h: (WebCore::JSTestInterface::createStructure): (WebCore::JSTestInterfacePrototype::createStructure):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListenerConstructor::createStructure): (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListener::createPrototype):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::createStructure): (WebCore::JSTestMediaQueryListListenerPrototype::createStructure):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::createStructure): (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObj::createPrototype):
  • bindings/scripts/test/JS/JSTestObj.h: (WebCore::JSTestObj::createStructure): (WebCore::JSTestObjPrototype::createStructure):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore::JSTestSerializedScriptValueInterface::createStructure): (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
  • bindings/scripts/test/V8/V8TestCallback.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
11:17 Changeset [81788] by bweinstein@apple.com

WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878
<rdar://problem/9082503>

Reviewed by Darin Adler.

Project File Fun:

  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:


Derived Sources and API fun:

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:


  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Add a case for MediaCache messages.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Ditto.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the WebMediaCacheManagerProxy member variable.
(WebKit::WebContext::~WebContext): Invalidate the WebMediaCacheManagerProxy.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for MediaCache messages.

  • UIProcess/WebContext.h:

(WebKit::WebContext::mediaCacheManagerProxy):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetMediaCacheManager): Returns the context's WebMediaCacheManager.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKMediaCacheManager.cpp: Added.

(WKMediaCacheManagerGetTypeID): Returns the WebMediaCacheManagerProxy type.
(WKMediaCacheManagerGetHostnamesWithMediaCache): Calls down to the WebMediaCacheManagerProxy.
(WKMediaCacheManagerClearCacheForHostname): Ditto.
(WKMediaCacheManagerClearCacheForAllHostnames): Ditto.

  • UIProcess/API/C/WKMediaCacheManager.h: Added.
  • UIProcess/WebMediaCacheManagerProxy.cpp: Added.

(WebKit::WebMediaCacheManagerProxy::create):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::~WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::invalidate):
(WebKit::WebMediaCacheManagerProxy::didReceiveMessage):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache): Process the WebProcess response,

and call the callback.

(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): Call through to the WebProcess.
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames): Call through to the WebProcess.

  • UIProcess/WebMediaCacheManagerProxy.h: Added.

(WebKit::WebMediaCacheManagerProxy::clearContext):
(WebKit::WebMediaCacheManagerProxy::type):

  • UIProcess/WebMediaCacheManagerProxy.messages.in: Added.
  • WebProcess/MediaCache: Added.
  • WebProcess/MediaCache/WebMediaCacheManager.cpp: Added.

(WebKit::WebMediaCacheManager::shared):
(WebKit::WebMediaCacheManager::WebMediaCacheManager):
(WebKit::WebMediaCacheManager::didReceiveMessage):
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): Added a FIXME to call through to WebCore.
(WebKit::WebMediaCacheManager::clearCacheForHostname): Ditto.
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Ditto.

  • WebProcess/MediaCache/WebMediaCacheManager.h: Added.
  • WebProcess/MediaCache/WebMediaCacheManager.messages.in: Added.
10:58 Changeset [81787] by dbates@webkit.org

2011-03-23 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Rename HTMLFrameSetElement::{noresize, frameborder, and frameBorderSet}
to conform to the WebKit Code style guidelines
https://bugs.webkit.org/show_bug.cgi?id=56871

No functionality changed. So, no new tests.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): (WebCore::HTMLFrameSetElement::defaultEventHandler):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasFrameBorder): (WebCore::HTMLFrameSetElement::noResize):
10:43 Changeset [81786] by inferno@chromium.org

2011-03-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when accessing entries in the percent
height descendant map.
https://bugs.webkit.org/show_bug.cgi?id=56902

  • fast/block/percent-height-descendant-not-removed-crash-expected.txt: Added.
  • fast/block/percent-height-descendant-not-removed-crash.html: Added.

2011-03-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Replace height with logicalHeight when removing items from
gPercentHeightDescendantMap so that it is writing mode aware.
https://bugs.webkit.org/show_bug.cgi?id=56902

Test: fast/block/percent-height-descendant-not-removed-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleDidChange):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
10:39 Changeset [81785] by mrobinson@webkit.org

2011-03-23 Martin Robinson <mrobinson@igalia.com>

Rebaseline a GTK+ result after r81684.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:36 Changeset [81784] by andersca@apple.com

Fix clang build.

  • inspector/DOMNodeHighlighter.cpp:

Remove an unused function.

10:32 Changeset [81783] by mihaip@chromium.org

2011-03-23 Mihai Parparita <mihaip@chromium.org>

Update pixel results for Snow Leopard after r80755. Where possible,
chromium-mac results were promoted to mac-leopard, except for cases
where Chromium behavior due to bug 52335 or form control rendering.

  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/margin-collapse/103-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Removed.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Removed.
  • platform/chromium-mac/fast/lists/008-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Removed.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Removed.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
  • platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
  • platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
  • platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1601-c547-indent-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
  • platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
  • platform/mac-leopard/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png:
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png:
  • platform/mac-leopard/fast/css/ex-after-font-variant-expected.checksum:
  • platform/mac-leopard/fast/css/ex-after-font-variant-expected.png:
  • platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/mac-leopard/fast/css/non-standard-checkbox-size-expected.png:
  • platform/mac-leopard/fast/lists/008-expected.checksum:
  • platform/mac-leopard/fast/lists/008-expected.png:
  • platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/mac-leopard/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac-leopard/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac-leopard/fast/overflow/overflow-rtl-expected.png:
  • platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/mac-leopard/fast/replaced/width100percent-radio-expected.checksum:
  • platform/mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • platform/mac-leopard/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
  • platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
  • platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
  • platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum:
  • platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png:
  • platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.png:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png:
  • platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum:
  • platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:
  • platform/mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-2-expected.png:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/mac/editing/selection/caret-ltr-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-expected.png:
  • platform/mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/mac/editing/selection/caret-ltr-right-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-right-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-right-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/css/ex-after-font-variant-expected.checksum:
  • platform/mac/fast/css/ex-after-font-variant-expected.png:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.png:
  • platform/mac/fast/lists/008-expected.checksum:
  • platform/mac/fast/lists/008-expected.png:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/mac/fast/replaced/width100percent-radio-expected.checksum:
  • platform/mac/fast/replaced/width100percent-radio-expected.png:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.png:
10:26 Changeset [81782] by beidson@apple.com

2011-03-22 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add asynchronous load decision call to WebKit2 IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=56887

Clear the callback when it's made:

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueIconLoadWithDecision):

Don't load icons when using new-style icon database if in private browsing:

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueIconLoadWithDecision):


Enhance the IconDatabase callbacks to have an ID and inherit from a common base:

  • loader/icon/IconDatabaseBase.h: (WebCore::CallbackBase::~CallbackBase): (WebCore::CallbackBase::callbackID): (WebCore::CallbackBase::CallbackBase): (WebCore::CallbackBase::context): (WebCore::CallbackBase::generateCallbackID): (WebCore::EnumCallback::performCallback): (WebCore::EnumCallback::EnumCallback): (WebCore::ObjectCallback::performCallback): (WebCore::ObjectCallback::ObjectCallback):

2011-03-22 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add asynchronous load decision call to WebKit2 IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=56887

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): In the future, get the actual load decision from the database. For now, always message "IconLoadNo" back to the WebProcess.
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabase.messages.in:


  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: (WebKit::WebIconDatabaseProxy::loadDecisionForIconURL): Message the UIProcess for the load decision. (WebKit::WebIconDatabaseProxy::receivedIconLoadDecision): Callback into WebCore with the received load decision.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in:
10:02 Changeset [81781] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: Remove DebuggerScript.js from Chromium resource bundle.
https://bugs.webkit.org/show_bug.cgi?id=56916

  • DEPS: bump up Chromium dependency to the revision where no references to the DebuggerScript.js resource are left.
  • WebKit.grd:
09:49 Changeset [81780] by podivilov@chromium.org

2011-03-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move scripts concatenation logic to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=56756

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._requestContent): (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent):
09:47 Changeset [81779] by commit-queue@webkit.org

2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API: add a flag to RuntimeEnabledFeatures.
https://bugs.webkit.org/show_bug.cgi?id=56921

Add a flag to RuntimeEnabledFeatures to check if the Media Stream API is enabled at runtime.

Tests for the Media Stream API will be provided by the bug 56587.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::mediaStreamEnabled): (WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled): (WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
09:38 Changeset [81778] by carol.szabo@nokia.com

2011-03-23 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Added new test to expose failure to correctly find the
before/after container when creating a CSS counter.

CSS 2.1 failure: various before-after-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=47207

  • fast/css/counters/complex-before-expected.txt: Added.
  • fast/css/counters/complex-before.html: Added.

2011-03-23 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Modified RenderCounter::originalText() to correctly attach
the created counter to the before/after container even when
that is not the RenderCounter's direct parent.

CSS 2.1 failure: various before-after-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=47207

Test: fast/css/counters/complex-before.html

  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText):
09:21 Changeset [81777] by gyuyoung.kim@samsung.com

2011-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add play / pause button to media control
https://bugs.webkit.org/show_bug.cgi?id=55463

Add play|pause button to media control.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::edjeGroupFromFormType): (WebCore::RenderThemeEfl::emitMediaButtonSignal): Added. (WebCore::RenderThemeEfl::paintMediaPlayButton):
  • platform/efl/RenderThemeEfl.h:

2011-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add play / pause button to media control
https://bugs.webkit.org/show_bug.cgi?id=55463

Add play|pause button to media control.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Added.
  • DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Added.
  • DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Added.
09:03 Changeset [81776] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: remove inspectNode method from WebDevToolsAgent
https://bugs.webkit.org/show_bug.cgi?id=56926

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
08:54 Changeset [81775] by commit-queue@webkit.org

2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit rendering problem when maximizing and doing a back
https://bugs.webkit.org/show_bug.cgi?id=56669

Contents of the page are not re-sized on going back after
maximizing. ContentsResized() is not getting called. Hence old
document width and height are used. Corrected this behaviour by
calling setBoundsSize() which calls contentsSize().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open):

2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit rendering problem when maximizing and doing a back
https://bugs.webkit.org/show_bug.cgi?id=56669

Added an auto test.
Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::rendering):
08:04 Changeset [81774] by podivilov@chromium.org

2011-03-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for formating source files in debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=56558

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.get scripts):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._reset):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.scriptLocationToSourceLocation): (WebInspector.SourceFile.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceFile): (WebInspector.FormattedSourceFile.prototype.scriptLocationToSourceLocation): (WebInspector.FormattedSourceFile.prototype.sourceLocationToScriptLocation): (WebInspector.FormattedSourceFile.prototype._didRequestContent):
07:04 Changeset [81773] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use unsigned char instead of char when storing script source
https://bugs.webkit.org/show_bug.cgi?id=56920

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptSource):
  • inspector/InjectedScriptSource.js: whitespace change to trigger compilation
  • inspector/xxd.pl:
  • xml/XMLViewer.xsl:
06:56 Changeset [81772] by kov@webkit.org

2011-03-23 Luca Ferretti <lferrett@gnome.org>

Rubber-stamped by Gustavo Noronha.

Italian translation update.

  • it.po: Updated.
06:22 Changeset [81771] by loislo@chromium.org

2011-03-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move node searching and node highlight related methods from InspectorAgent to InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=56912

The next functions were moved:

setSearchingForNode
highlightDOMNode
hideDOMNodeHighlight
highlightFrame
hideFrameHighlight
mouseDidMoveOverElement
handleMousePress

The code which does real highlight in Graphic context was moved to new files DOMNodeHighlighter.*

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMNodeHighlighter.cpp: Added. (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  • inspector/DOMNodeHighlighter.h: Added.
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::hideHighlight):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::clearFrontend): (WebCore::InspectorDOMAgent::handleMousePress): (WebCore::InspectorDOMAgent::mouseDidMoveOverElement): (WebCore::InspectorDOMAgent::searchingForNodeInPage): (WebCore::InspectorDOMAgent::setSearchingForNode): (WebCore::InspectorDOMAgent::highlight): (WebCore::InspectorDOMAgent::highlightDOMNode): (WebCore::InspectorDOMAgent::highlightFrame): (WebCore::InspectorDOMAgent::hideHighlight): (WebCore::InspectorDOMAgent::drawNodeHighlight):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideDOMNodeHighlight): (WebCore::InspectorDOMAgent::hideFrameHighlight):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorAgent): (WebCore::InstrumentingAgents::setInspectorAgent):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.js: (WebInspector.highlightDOMNode):
06:19 Changeset [81770] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r81768 which broke compilation on Win.

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.xsl:
06:11 Changeset [81769] by ossy@webkit.org

[Qt] Update expected files after r81684.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
05:56 Changeset [81768] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer
https://bugs.webkit.org/show_bug.cgi?id=56919

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLViewer.xsl: whitespace change to trigger compilation.
05:52 Changeset [81767] by podivilov@chromium.org

2011-03-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move content loading logic to a new SourceFile class.
https://bugs.webkit.org/show_bug.cgi?id=56748

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
  • inspector/front-end/SourceFile.js: Added. (WebInspector.SourceFile): (WebInspector.SourceFile.prototype.addScript): (WebInspector.SourceFile.prototype.requestContent): (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype.reload): (WebInspector.SourceFile.prototype._requestContent): (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.SourceFile.prototype._loadScriptContent): (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent): (WebInspector.SourceFile.prototype._didRequestContent): (WebInspector.SourceFile.prototype._hasPendingResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
05:41 Changeset [81766] by podivilov@chromium.org

2011-03-23 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix compilation broken by r81758.

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
05:35 Changeset [81765] by pfeldman@chromium.org

2011-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: define array types properly in the Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=56915

  • inspector/Inspector.json:
  • inspector/generate-inspector-idl:
04:34 Changeset [81764] by pfeldman@chromium.org

2011-03-23 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: bring back Vector::contains that was removed as a part of roll back.

  • wtf/Vector.h: (WTF::::contains):
04:09 Changeset [81763] by pfeldman@chromium.org

2011-03-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81686.
http://trac.webkit.org/changeset/81686
https://bugs.webkit.org/show_bug.cgi?id=56914

Breaks webkit_tests in Chromium again. (Requested by pfeldman
on #webkit).

  • wtf/Vector.h:

2011-03-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81686.
http://trac.webkit.org/changeset/81686
https://bugs.webkit.org/show_bug.cgi?id=56914

Breaks webkit_tests in Chromium again. (Requested by pfeldman
on #webkit).

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h:
  • public/WebVector.h: (WebKit::WebVector::operator[]):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp:
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Removed.
  • tests/data/pageserialization/awesome.png: Removed.
  • tests/data/pageserialization/embed_iframe.html: Removed.
  • tests/data/pageserialization/object_iframe.html: Removed.
  • tests/data/pageserialization/simple_iframe.html: Removed.
  • tests/data/pageserialization/simple_page.html: Removed.
  • tests/data/pageserialization/top_frame.html: Removed.
04:09 Changeset [81762] by yurys@chromium.org

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843

  • inspector/front-end/WebKit.qrc:

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:

2011-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
03:53 BuildingQtOnLinux edited by benjamin.poulain@nokia.com
(diff)
03:33 Changeset [81761] by podivilov@chromium.org

2011-03-23 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Add a star while editing a source code
https://bugs.webkit.org/show_bug.cgi?id=56743

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing): (WebInspector.SourceFrame.prototype._registerShortcuts): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing): (WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
03:30 Changeset [81760] by podivilov@chromium.org

2011-03-23 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Scrolling and navigation is not smooth on a script with many long lines
https://bugs.webkit.org/show_bug.cgi?id=56559

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines): (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines): (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
03:17 Changeset [81759] by abarth@webkit.org

2011-03-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JavaScriptCore GYP build should work on a case-sensitive file system
https://bugs.webkit.org/show_bug.cgi?id=56911

The issue is that there are two UString.h headers, one named UString.h
and one named ustring.h. This patch excludes ustring.h from the header
map to avoid confusion. While I was editing this part of the GYP file,
I cleaned up the exclude rules to be more modern.

  • gyp/JavaScriptCore.gyp:
03:09 Changeset [81758] by yurys@chromium.org

2011-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843

DebuggerScript.js is now translated into a char[] array before inspector compilation.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptSource):
  • inspector/InjectedScriptSource.js: whitespace change to trigger InjectedScriptSource.h generation.
  • inspector/xxd.pl:

2011-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
https://bugs.webkit.org/show_bug.cgi?id=56843

  • public/WebDevToolsAgentClient.h: the script source is now compiled along with the inspector code.
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach):
02:49 Changeset [81757] by yurys@chromium.org

2011-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: remove obsolete methods from WebDevToolsAgentClient.h
https://bugs.webkit.org/show_bug.cgi?id=56897

  • public/WebDevToolsAgentClient.h:
00:34 Changeset [81756] by mrowe@apple.com

Fix the 32-bit build.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::initializeNewContext):

00:21 Changeset [81755] by cfleizach@apple.com

2011-03-23 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

REGRESSION: WK2: AX: PDF in Safari no longer accessible.
https://bugs.webkit.org/show_bug.cgi?id=56849

The WKView needs to know when to return the WKPDFView and when to return
the remote web process connection.

  • UIProcess/API/mac/PDFViewController.h: (WebKit::PDFViewController::pdfView):
  • UIProcess/API/mac/WKView.mm: (-[WKView accessibilityFocusedUIElement]): (-[WKView accessibilityHitTest:]): (-[WKView accessibilityAttributeValue:]):
00:16 Changeset [81754] by abarth@webkit.org

2011-03-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should default to Production configuration
https://bugs.webkit.org/show_bug.cgi?id=56899

  • Source/gyp/common.gypi:

03/22/11:

23:44 Changeset [81753] by commit-queue@webkit.org

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Ojan Vafai.

[chromium] skia image encoders should use <wtf/Vector.h>
https://bugs.webkit.org/show_bug.cgi?id=56893

No new tests. Covered by existing canvas.toDataURL tests.

  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.h:
22:42 Changeset [81752] by ggaren@apple.com

Unskipped some tests, now that https://bugs.webkit.org/show_bug.cgi?id=54490
is fixed.

Rubber-stamped by Beth Dakin.

  • platform/win/Skipped:
22:21 Changeset [81751] by ggaren@apple.com

2011-03-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (r78382): No scripts appear in the Web Inspector's Scripts
panel on Windows, and many inspector regression tests are failing
https://bugs.webkit.org/show_bug.cgi?id=54490


The bug was caused by two different classes using the same name (Recompiler).

  • debugger/Debugger.cpp:
  • runtime/JSGlobalData.cpp: (WTF::Recompiler::operator()): Put Recompiler in an anonymous namespace, so our two recompilers' inline functions don't stomp each other at link time.
22:15 Changeset [81750] by mihaip@chromium.org

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Fix baselines for svg/W3C-I18N for Chromium Snow Leopard. Mac SL
baselines were added with r81168, so the Chromium ones only need to
be in chromium-mac-leopard/ (so that they don't override them). The
chromium-mac/ text baselines can be deleted, since we can now
fall back on the mac-leopard/ ones added by r81176.

  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum.
  • platform/chromium-mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
21:51 Changeset [81749] by mihaip@chromium.org

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Add Snow Leopard baselines for fast/html/details* tests added by r81035
(should work for both Mac and Chromium-Mac). Promote current
chromium-mac baselines to mac-leopard, since they work for both on
Leopard.

  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-10-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-7-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-8-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum.
  • platform/mac-leopard/fast/html/details-add-summary-9-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary1-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary2-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary3-expected.png.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.checksum.
  • platform/mac-leopard/fast/html/details-no-summary4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-no-summary4-expected.png.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.checksum.
  • platform/mac-leopard/fast/html/details-open-javascript-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open-javascript-expected.png.
  • platform/mac-leopard/fast/html/details-open1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.checksum.
  • platform/mac-leopard/fast/html/details-open1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open1-expected.png.
  • platform/mac-leopard/fast/html/details-open2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.checksum.
  • platform/mac-leopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png.
  • platform/mac-leopard/fast/html/details-open3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.checksum.
  • platform/mac-leopard/fast/html/details-open3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open3-expected.png.
  • platform/mac-leopard/fast/html/details-open4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.checksum.
  • platform/mac-leopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png.
  • platform/mac-leopard/fast/html/details-open5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.checksum.
  • platform/mac-leopard/fast/html/details-open5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open5-expected.png.
  • platform/mac-leopard/fast/html/details-open6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.checksum.
  • platform/mac-leopard/fast/html/details-open6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open6-expected.png.
  • platform/mac-leopard/fast/html/details-position-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.checksum.
  • platform/mac-leopard/fast/html/details-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-position-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-5-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum.
  • platform/mac-leopard/fast/html/details-remove-summary-6-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-6-expected.png.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.checksum.
  • platform/mac-leopard/fast/html/details-writing-mode-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-writing-mode-expected.png.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/mac/fast/html/details-open1-expected.checksum: Added.
  • platform/mac/fast/html/details-open1-expected.png: Added.
  • platform/mac/fast/html/details-open2-expected.checksum: Added.
  • platform/mac/fast/html/details-open2-expected.png: Added.
  • platform/mac/fast/html/details-open3-expected.checksum: Added.
  • platform/mac/fast/html/details-open3-expected.png: Added.
  • platform/mac/fast/html/details-open4-expected.checksum: Added.
  • platform/mac/fast/html/details-open4-expected.png: Added.
  • platform/mac/fast/html/details-open5-expected.checksum: Added.
  • platform/mac/fast/html/details-open5-expected.png: Added.
  • platform/mac/fast/html/details-open6-expected.checksum: Added.
  • platform/mac/fast/html/details-open6-expected.png: Added.
  • platform/mac/fast/html/details-position-expected.checksum: Added.
  • platform/mac/fast/html/details-position-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/mac/fast/html/details-writing-mode-expected.png: Added.
21:28 Changeset [81748] by cevans@google.com

Merge 81648
BUG=76784

20:44 Changeset [81747] by hyatt@apple.com

Move the cellWidthChanged bit out of RenderObject and back down into RenderTableCell in order to
free up a bit for another performance optimization I have planned.

Reviewed by Beth Dakin.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setHasColumns):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::cellWidthChanged):
(WebCore::RenderTableCell::setCellWidthChanged):

20:27 Changeset [81746] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56892

Reviewed by Dan Bernstein.

Adding floats to an empty block is O(n2).

If you just add floats back to back to an empty block, the addition is essentially O(n2)
once the floats move below your current line position. This is because we repeatedly ask for the
available width for the line from scratch every time we add a float, regardless of whether the
float even vertically intersected our current line position.

Change positionNewFloatOnLine to update left and right line offsets intelligently and to only
do it based off the single new float that just got added.

This fix cuts the IE MazeSolver time in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

20:15 Changeset [81745] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=56890 It is possible to calculate a
NaN value for "value" in ScrollbarThemeMac::paint()
-and corresponding-
<rdar://problem/9160621>

Reviewed by Sam Weinig.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

20:09 Changeset [81744] by ojan@chromium.org

2011-03-22 Ojan Vafai <ojan@chromium.org>

Add a chromium expectation for this test. V8's exception logging
is more specific than JSC's.

  • platform/chromium/fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
18:45 Changeset [81743] by commit-queue@webkit.org

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove identity from dragTargetDragEnter() function signature
https://bugs.webkit.org/show_bug.cgi?id=56875

First part of 3-sided patch. Add new function signature sans identity.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter):
  • src/WebViewImpl.h:
18:44 Changeset [81742] by ojan@chromium.org

2011-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/pseudo-any-expected.txt: Added.
  • fast/css/pseudo-any.html: Added.
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector.html:
  • fast/dom/SelectorAPI/unknown-pseudo-expected.txt: Added.
  • fast/dom/SelectorAPI/unknown-pseudo.html: Added.

2011-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Antti Koivisto.

webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

For now, match the Mozilla implementation with respect to specificity
and only allowing simple selectors. Both of these are likely to change
pending discussion on www-style@.

Tests: fast/css/pseudo-any.html

fast/dom/SelectorAPI/unknown-pseudo.html

  • css/CSSGrammar.y: Create simple_selector_list. This is exactly like selector_list except it only allows simple selectors and creates a new vector instead of a reusable one since there can be multiple in one rule.
  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::createFloatingSelectorVector): (WebCore::CSSParser::sinkFloatingSelectorVector):
  • css/CSSParser.h:
  • css/CSSParserValues.cpp: (WebCore::CSSParserSelector::adoptSelectorVector):
  • css/CSSParserValues.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::selectorText): (WebCore::CSSSelector::setSelectorList): (WebCore::CSSSelector::RareData::RareData): (WebCore::CSSSelector::RareData::~RareData): These need to be moved into the cpp file so that we can have an OwnPtr<CSSSelectorList> in CSSSelector::RareData.
  • css/CSSSelector.h: (WebCore::CSSSelector::selectorList):
  • css/CSSSelectorList.cpp: (WebCore::forEachTagSelector):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector):
  • css/tokenizer.flex:
18:27 Changeset [81741] by mihaip@chromium.org

2011-03-22 Mihai Parparita <mihaip@chromium.org>

Remove duplicated test expectations for details tests (expectations were
added to the mac/ directory with r81062, so chromium-mac ones are no
longer necessary).

  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Removed.
18:24 Changeset [81740] by commit-queue@webkit.org

2011-03-22 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=56431

For the accelerated compositing case, only prepare the texture if it
has been updated since the last composite. For the non-accelerated case, make sure to
grab a copy of the image buffer and paint from that if the backbuffer
would be cleared.

In both cases, make sure to clear the context's backbuffer before the
first operation that uses it.

No new tests. It seems to be difficult/impossible to trigger an early
compositing operation in DumpRenderTree, making this hard to
test automatically. However, Chromium and Safari (Mac) have been
tested manually on the webgl conformance test for this.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::makePresentationCopy): (WebCore::HTMLCanvasElement::clearPresentationCopy):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLContextAttributes.cpp: (WebCore::WebGLContextAttributes::preserveDrawingBuffer): (WebCore::WebGLContextAttributes::setPreserveDrawingBuffer):
  • html/canvas/WebGLContextAttributes.h:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::markLayerComposited): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::readPixels):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty): (WebCore::WebGLLayerChromium::textureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::markLayerComposited): (WebCore::GraphicsContext3D::markContextChanged): (WebCore::GraphicsContext3D::layerComposited):

2011-03-22 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Add support for preserveDrawingBuffer context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=56431

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::markContextChanged): (WebCore::GraphicsContext3DInternal::markLayerComposited): (WebCore::GraphicsContext3DInternal::layerComposited): (WebCore::GraphicsContext3D::layerComposited):
  • src/GraphicsContext3DInternal.h:
18:19 Changeset [81739] by weinig@apple.com

Remove USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.
<rdar://problem/8944718>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • DerivedSources.make:

Remove generation of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER.

Source/WebCore:

  • DerivedSources.make:

Remove generation of HeaderDetection.h.

  • WebCore.xcodeproj/project.pbxproj:

Remove HeaderDetection.h.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

Replace use of USE_WK_SCROLLBAR_PAINTER_AND_CONTROLLER with USE(WK_SCROLLBAR_PAINTER).

18:19 Changeset [81738] by dino@apple.com

2011-03-22 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=56488
Some transitions/animations tests fail assertion in AnimationBase::updateStateMachine

Turning some tests back on after r81722.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • unskipping animations/suspend-resume-animation-events.html compositing/transitions/scale-transition-no-start.html compositing/transitions/singular-scale-transition.html
18:13 Changeset [81737] by commit-queue@webkit.org

2011-03-22 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Properly reset VideoLayerChromium textures after lost renderer context
https://bugs.webkit.org/show_bug.cgi?id=56514

The VideoLayerChromium textures were still mapped to the old
renderer's context when LayerRendererChromium was being recreated
i.e. when GPU process is killed. This patch allows VideoLayerChromium
it recreate textures in the new context when the old renderer is lost.
Patch also does a bit of refactoring and code clean-up.

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::~VideoLayerChromium): (WebCore::VideoLayerChromium::cleanupResources): (WebCore::VideoLayerChromium::updateContentsIfDirty): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::computeVisibleSize): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA): (WebCore::VideoLayerChromium::resetFrameParameters): (WebCore::VideoLayerChromium::saveCurrentFrame):
  • platform/graphics/chromium/VideoLayerChromium.h:
18:11 Changeset [81736] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should export the headers needed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=56883

  • WebCore.gypi:
  • gyp/WebCore.gyp:
    • Export a couple more headers.
    • Remove FIXME comments for things we've already fixed.
18:08 Changeset [81735] by abarth@webkit.org

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach update-webkit about gyp
https://bugs.webkit.org/show_bug.cgi?id=56881

This makes it possible for someone who builds from Xcode
to just run update-webkit --gyp and have the project files
generated after update automatically.

I also added a stand-alone "generate-project-files" script
wrapping Source/gyp/configure. This makes running gyp simpler
since most people will not have gyp or Source/gyp in their path.

  • Scripts/build-webkit:
  • Scripts/generate-project-files: Added.
  • Scripts/update-webkit:
18:05 Changeset [81734] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56798
Wrap autorelease pools around calls that can have pathological memory growth on Membuster.
Only wrap the main runloop because some background threads are not expected to call into
objc and an autorelease pool could mask bugs.

Reviewed by Simon Fraser.

  • Platform/mac/RunLoopMac.mm:

(RunLoop::performWork):
(RunLoop::TimerBase::timerFired):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):

17:57 Changeset [81733] by commit-queue@webkit.org

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

This test twice retrieves lists of origins with application cache.
First, after deleting all application cache and after adding an iframe with an
application cache.

  • http/tests/appcache/origins-with-appcache-expected.txt: Added.
  • http/tests/appcache/origins-with-appcache.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.html: Added.
  • http/tests/appcache/resources/origins-with-appcache-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

Added test that exercises WebCore API to get origins with application cache.

Test: http/tests/appcache/origins-with-appcache.html

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::getOriginsWithCache):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]):

2011-03-22 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add +[WebApplicationCache getOriginsWithCache]
https://bugs.webkit.org/show_bug.cgi?id=56722

  • DumpRenderTree/LayoutTestController.cpp: (originsWithApplicationCacheCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers. (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers. (LayoutTestController::originsWithApplicationCache): (LayoutTestController::originsWithLocalStorage):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub. (LayoutTestController::originsWithApplicationCache):
17:33 Changeset [81732] by andersca@apple.com

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879

  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromPropertyLists): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element.


  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::pluginSupportsExtension): Add a new helper function.

(WebKit::WebFrameLoaderClient::objectContentType):
If we can't find the MIME for an extension, explicitly check if there's a plugin that claims to
handle the given extension.

17:28 Changeset [81731] by simonjam@chromium.org

2011-03-22 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium gpu tests after r81715.

  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/repaint-foreground-layer-expected.png: Added.
17:26 Changeset [81730] by cevans@google.com

Merge 81611
BUG=75801

17:24 Changeset [81729] by jam@chromium.org

2011-03-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Make WebTextCheckingResult&apos;s members be public in preparation for converting it to a struct
https://bugs.webkit.org/show_bug.cgi?id=56857

  • DEPS:
  • public/WebTextCheckingResult.h:
17:23 Changeset [81728] by cevans@google.com

Merge 81689
BUG=76646

17:21 Changeset [81727] by dino@apple.com

2011-03-22 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=56242
transitions/interrupted-accelerated-transition.html was failing

Unskipping this after r81722

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
17:21 Changeset [81726] by loki@webkit.org

2011-03-22 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add DFG module to build system (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=56845

17:07 Changeset [81725] by commit-queue@webkit.org

2011-03-22 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] New resolve url tests don't pass on Chromium. Skipping them.
https://bugs.webkit.org/show_bug.cgi?id=56800

  • platform/chromium/test_expectations.txt: Skip all tests in http/tests/filesystem/workers. They can't run in test_shell, and are instead run in Chromium's ui_tests.
17:04 Changeset [81724] by carol.szabo@nokia.com

2011-03-22 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Introduced double linkage between a CounterNode and its display renderer.

use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065

No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.

  • rendering/CounterNode.cpp: Introduced new member "m_owner" to store the renderer that has the style directives that produce the CounterNode. Repurposed m_renderer to reffer to the RenderCounter that shows the CounterNode. (WebCore::CounterNode::CounterNode): Updated member initialization. (WebCore::CounterNode::create): (WebCore::CounterNode::addRenderer): (WebCore::CounterNode::removeRenderer): Introduced to manage the renderer list associated wit this CounterNode. (WebCore::CounterNode::resetRenderers): This is the old resetRenderer. Renamed to take into account that there may be more than one renderer to a CounterNode. (WebCore::CounterNode::resetThisAndDescendantsRenderers): This is the old resetRenderers renamed for clarity. (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): No functional changes. (WebCore::showTreeAndMark): Added flushing to ensure that the output is complete.
  • rendering/CounterNode.h: (WebCore::CounterNode::owner): Renamed from renderer()
  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed comments. No functional changes. (WebCore::RenderCounter::~RenderCounter): Made sure that the CounterNode that this renderers displays is detached from this. (WebCore::RenderCounter::originalText): (WebCore::RenderCounter::invalidate): Changed to maintain the bidirectional relationship with the displayed CounterNode. Also made "invalidate" private as it should be used only by CounterNode. (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): No change, just kept code in line with the changes above. (showCounterRendererTree): Added fflush to ensure complete display.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderObjectChildList.h: Removed unneeded invalidateCounters related functions.
17:00 Changeset [81723] by beidson@apple.com

2011-03-22 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Rename the synchronous icon database messages to be prefixed with "synchronous"

  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::synchronousIconDataForPageURL): (WebKit::WebIconDatabase::synchronousIconURLForPageURL): (WebKit::WebIconDatabase::synchronousIconDataKnownForIconURL): (WebKit::WebIconDatabase::synchronousLoadDecisionForIconURL):
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabase.messages.in:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: (WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
16:52 Changeset [81722] by dino@apple.com

2011-03-22 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56242
Interrupted accelerated animations/transitions were causing
subsequent animations to not start (because they were stuck
waiting for a response from the compositing layer). I renamed
the instance variable that indicates whether or not to
notify animations of start time, from m_waitingForStartTimeResponse
to m_waitingForAsyncStartNotification, so that it makes more sense.
The actual bug fix was changing the logic so that the flag is reset
when the list of waiting animations becomes empty. I mistakenly committed
the bad logic in r81613.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
  • Always set paused time as we enter the paused state
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
  • reset the waiting flag when the list is empty (rather than not empty) (WebCore::AnimationControllerPrivate::startTimeResponse):
  • page/animation/AnimationControllerPrivate.h:
  • rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification
16:43 Changeset [81721] by weinig@apple.com

Loading a new tab does not dismiss Lookup
<rdar://problem/9138391>

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
Hide the dictionary popup when moving the WKView out of a window.

16:30 Changeset [81720] by cevans@google.com

Merge 81018
BUG=75436

16:29 Changeset [81719] by beidson@apple.com

<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread

Reviewed by Sam Weinig.

../WebCore:

  • loader/icon/IconDatabase.cpp:

Add a dummy client implementation for non-Mac, non-Win ports:
(WebCore::DefaultIconDatabaseClient::performImport):
(WebCore::DefaultIconDatabaseClient::didImportIconURLForPageURL):
(WebCore::DefaultIconDatabaseClient::didImportIconDataForPageURL):
(WebCore::DefaultIconDatabaseClient::didChangeIconForPageURL):
(WebCore::DefaultIconDatabaseClient::didRemoveAllIcons):
(WebCore::DefaultIconDatabaseClient::didFinishURLImport):
(WebCore::defaultClient):

Either call the client directly when on the main thread, or use the dispatch functions below
if on the background thread:
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::removeAllIconsOnThread):

Add a very targeted WorkItem interface for dispatching client calls on the main thread:
(WebCore::ClientWorkItem::ClientWorkItem):
(WebCore::ClientWorkItem::~ClientWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconURLForPageURLWorkItem::performWork):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::performWork):
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem):
(WebCore::RemovedAllIconsWorkItem::performWork):
(WebCore::performWorkItem):

Use the client WorkItem interface to perform these callbacks on the main thread:
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseClient.h:

../WebKit/mac:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebIconDatabaseClient.mm:

(WebIconDatabaseClient::didRemoveAllIcons):
(WebIconDatabaseClient::didImportIconURLForPageURL):
(WebIconDatabaseClient::didImportIconDataForPageURL):
(WebIconDatabaseClient::didChangeIconForPageURL):
(WebIconDatabaseClient::didFinishURLImport):

../WebKit/win:

Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.

Update to the new IconDatabaseClient interface:

  • WebIconDatabase.cpp:

(WebIconDatabase::performImport):
(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::didImportIconDataForPageURL):
(WebIconDatabase::didChangeIconForPageURL):
(WebIconDatabase::didFinishURLImport):

  • WebIconDatabase.h:
16:29 Changeset [81718] by commit-queue@webkit.org

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81683.
http://trac.webkit.org/changeset/81683
https://bugs.webkit.org/show_bug.cgi?id=56872

Crashing in some tests (Requested by weinig on #webkit).

  • win/lib/WebKitSystemInterface.lib:
16:23 Changeset [81717] by eric@webkit.org

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
https://bugs.webkit.org/show_bug.cgi?id=56877

Found a couple missing Private headers while trying to make WebCore build.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support to build-webkit for building with gyp-generated project files
https://bugs.webkit.org/show_bug.cgi?id=56877

build-webkit is a cesspool. This change just hacks in --gyp support for Mac.
Eventually we'll want to support gyp-generated projects in a more general manner.

  • Scripts/build-webkit:
16:21 Changeset [81716] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56869

Reviewed by Simon Fraser.

Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
a little faster than having to access the information from the RenderStyle's sub-structure.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::logicalScroll):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::styleWillChange):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::setHorizontalWritingMode):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::scrollbarsChanged):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::verticalPositionForBox):

16:17 Changeset [81715] by simon.fraser@apple.com

2011-03-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Incorrect rendering of composited element with negative z-index child
https://bugs.webkit.org/show_bug.cgi?id=56846

When a composited element has a child with negative z-index, we make
a separate layer for that element's foreground content. This layer
was positioned incorrectly (but the content happened to paint at
the right location), resulting in right/bottom clipping.

Fix this, remove the little-used graphicsLayerToContentsCoordinates()
contentsToGraphicsLayerCoordinates() methods, and optimize incremental
repaints in the foreground and mask layers.

Tests: compositing/geometry/foreground-layer.html

compositing/geometry/repaint-foreground-layer.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints which fall outside the layer bounds, so callers don't have to, and to avoid unnecessary layer commits.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If we have a foreground layer inside a clipping layer, the foreground layer's offset is zero, since the clipping layer is its parent.

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
Also do incremental repaints of the foreground and mask layers.

(WebCore::RenderLayerBacking::paintContents): It was incorrect to always
use compositedBounds() to compute the painting offset, since that's
per-RenderLayerBacking, but a single RenderLayerBacking can have different
GraphicsLayers with different offsets (e.g. the foreground layer).
Instead, use offsetFromRenderer(), which gives has the correct offset.

  • rendering/RenderLayerBacking.h: Remove unused methods.
16:14 Changeset [81714] by cevans@google.com

Merge 81643
BUG=76031

16:10 Changeset [81713] by cevans@google.com

Merge 81536
BUG=76198

15:45 Changeset [81712] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

gyp/configure shouldn&apos;t require GYP to be in your path
https://bugs.webkit.org/show_bug.cgi?id=56873

Now that GYP is on Source/ThirdParty/gyp, we can just use that copy
instead of requiring GYP to be in the user's path.

  • Source/gyp/configure:
15:43 Changeset [81711] by crogers@google.com

2011-03-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Use default-output instead of default-input to get hardware sample-rate
https://bugs.webkit.org/show_bug.cgi?id=56858

No new tests since audio API is not yet implemented.

  • platform/audio/mac/AudioDestinationMac.cpp: (WebCore::AudioDestination::hardwareSampleRate):
15:42 Changeset [81710] by psolanki@apple.com

2011-03-22 Pratik Solanki <psolanki@apple.com>

Reviewed by David Kilzer.

Implement -connection:didReceiveDataArray: NSURLConnection delegate method
https://bugs.webkit.org/show_bug.cgi?id=56838

Add experimental support for the didReceiveDataArray callback on
NSURLConnection. A RessourceHandleClient indicates its ability to
handle this callback by returning true from supportsDataArray() method.
Currently only SubresourceLoader uses this so we get the benefit for
CSS, JS and image loads. For other clients we call didReceiveData with
the CFData contents as before.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::supportsDataArray):
  • loader/cf/SubresourceLoaderCF.cpp: Added. (WebCore::SubresourceLoader::didReceiveDataArray):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveDataArray):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::buffer):
  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::copyDataArrayAndClear):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::supportsDataArray): (WebCore::ResourceHandleClient::didReceiveDataArray):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
15:36 Changeset [81709] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add GYP to Source/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=56870

We probably don't need all the test files, but it seems cleaner to just
check in the whole GYP tree. GYP is BSD licensed, so it is compatible
with the WebKit license.

  • Source/ThirdParty/gyp: Added.
15:09 Changeset [81708] by eric@webkit.org

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptCore.xcodeproj
from a JavaScriptCore directory outside of Source.

  • gyp/JavaScriptCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated JavaScriptGlue.xcodeproj
from a JavaScriptGlue directory outside of Source.

  • gyp/JavaScriptGlue.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
https://bugs.webkit.org/show_bug.cgi?id=56867

This should make it possible to build the gyp-generated WebCore.xcodeproj
from a WebCore directory outside of Source.

  • gyp/WebCore.gyp:
  • gyp/run-if-exists.sh: Added.
  • gyp/update-info-plist.sh: Added.
14:57 Changeset [81707] by andersca@apple.com

Fix WebKit2 build.

  • WebCore.exp.in:

Export a symbol needed by WebKit2.

14:51 Changeset [81706] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the remaining steps to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56864

These steps match the normal build. After this patch, I believe the
WebCore GYP build is complete.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • gyp/copy-inspector-resources.sh: Added.
14:41 Changeset [81705] by andersca@apple.com

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Microsoft Silverlight playback shows artifacts
https://bugs.webkit.org/show_bug.cgi?id=56863
<rdar://problem/9103136>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paint): If the plug-in is transparent, clear the dirty rect before painting.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the MakeTransparentIfBackgroundAttributeExists quirk for Silverlight plug-ins.
  • Shared/Plugins/PluginQuirks.h: Add MakeTransparentIfBackgroundAttributeExists quirk.
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_SetValue): Handle NPPVpluginTransparentBool.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_isTransparent to false.

(WebKit::NetscapePlugin::setIsTransparent):
Set m_isTransparent.

(WebKit::NetscapePlugin::initialize):
If the plug-in has the MakeTransparentIfBackgroundAttributeExists quirk, make it transparent
if there's a 'background' attribute.

(WebKit::NetscapePlugin::isTransparent):
Add getter.

  • WebProcess/Plugins/Plugin.h: Add isTransparent().
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::paint): Always copy the plug-in backing store to the plug-in proxy backing store.

(WebKit::PluginProxy::isTransparent):
Add getter that should never be called.

(WebKit::PluginProxy::update):
Always copy the plug-in backing store to the plug-in proxy backing store.

14:33 Changeset [81704] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
added to Page::scrollableAreaSet()

Reviewed by Simon Fraser.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::disconnectFromPage):

14:33 Changeset [81703] by simonjam@chromium.org

2011-03-22 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline chromium tests after r81684.

  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/chromium-win/fast/block/lineboxcontain/replaced-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:32 Changeset [81702] by crogers@google.com

2011-03-22 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add high-quality band-limited audio resampling algorithm
https://bugs.webkit.org/show_bug.cgi?id=56692

No new tests since audio API is not yet implemented.

  • platform/audio/SincResampler.cpp: Added. (WebCore::SincResampler::SincResampler): (WebCore::SincResampler::initializeKernel): (WebCore::SincResampler::consumeSource): (WebCore::SincResampler::process):
  • platform/audio/SincResampler.h: Added.
14:28 Changeset [81701] by eric@webkit.org

2011-03-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Profiling Configuration to JavaScriptCore gyp build
https://bugs.webkit.org/show_bug.cgi?id=56862

It appears this is identical to Release, but I suspect
there is someone/thing who uses the Profiling target
so we're adding it for completeness.

  • gyp/JavaScriptCore.gyp:
14:17 Changeset [81700] by hyatt@apple.com

Update computed style results.

14:13 Changeset [81699] by hyatt@apple.com

Update computed style results.

14:12 Changeset [81698] by hyatt@apple.com

Update computed style results.

14:10 Changeset [81697] by hyatt@apple.com

Update computed style results.

14:10 Changeset [81696] by hyatt@apple.com

Update computed style results.

14:07 Changeset [81695] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build without help from normal WebCore build
https://bugs.webkit.org/show_bug.cgi?id=56860

Before this patch, the WebCore GYP build wasn't generating the derived
sources quite right because the ENABLE macros were not being
communicated to the "Derived Sources" target.

This patch also adds the "Copy Forwarding and ICU Headers" as well as
the "Streamline Inspector Source" steps, which are present in the
normal build. Unlike the normal build, these steps occur in a new
target, called "WebCore Support", which is less than aesthetically
beautiful. Hopefully we'll be able to move them into the WebCore
target proper in the future, but that will likely require some GYP
changes.

This patch probably could have been broken down into a couple smaller
patches, but that doesn't seem necessary.

  • WebCore.gypi:
    • This file appears to no longer exist.
  • gyp/WebCore.gyp:
  • gyp/copy-forwarding-and-icu-headers.sh: Added.
  • gyp/streamline-inspector-source.sh: Added.
14:05 Changeset [81694] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove os_win32_files variable from the GYP build
https://bugs.webkit.org/show_bug.cgi?id=56804

Now that our understanding of GYP is sufficiently advanced, we don't
need os_win32_files any more. (Turns out Eric was right, as he always
is.)

14:02 Changeset [81693] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build of JavaScriptCore should be able to link from an empty WebKitBuild directory
https://bugs.webkit.org/show_bug.cgi?id=56803

Previously, we thought we should generate the derived source files in
the shared intermediate build products directory, but there are
assumptions built into other parts of the Mac build system that the
derived source files will be generated in a particular subdirectory of
the build products directory.

This patch is a partial revert of the change that moved the derived
source files to the shared intermediate directory. After this patch,
the GYP build can build JavaScriptCore without help from the main
normal build system.

  • JavaScriptCore.gypi:
  • gyp/JavaScriptCore.gyp:
  • gyp/generate-derived-sources.sh:
  • gyp/generate-dtrace-header.sh:
13:41 Changeset [81692] by mdelaney@apple.com

2011-03-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Have WebKit push acceleratedDrawing preferences to settings
https://bugs.webkit.org/show_bug.cgi?id=56792

  • WebView/WebView.mm:
13:18 Changeset [81691] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56859

Reviewed by Simon Fraser.

Floats in the floating object list occur in the order that they are positioned. This means
that for a given vertical offset, the last left object in the list that intersects that offset
will be the rightmost float. There is no need to check any previous floats, since they have to be
further left than that rightmost float. The same rules hold true for right-aligned floats.

Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
they encounter a float that intersects the vertical range.

This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

13:13 Changeset [81690] by ddkilzer@apple.com

<http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode

Reviewed by Joseph Pecoraro.

  • Scripts/build-webkit: Updated usage statement to include

--dsym.

  • Scripts/webkitdirs.pm: Added $generateDsym variable.

(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added. Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added. Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.

12:21 Changeset [81689] by jschuh@chromium.org

2011-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
https://bugs.webkit.org/show_bug.cgi?id=56794

  • svg/filters/feDisplacementMap-crash-test-expected.txt: Added.
  • svg/filters/feDisplacementMap-crash-test.xhtml: Added.

2011-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

SVG displacement map should validate channel selections
https://bugs.webkit.org/show_bug.cgi?id=56794

Test: svg/filters/feDisplacementMap-crash-test.xhtml

  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
12:21 Changeset [81688] by hyatt@apple.com

Fix EFL bustage.

12:18 Changeset [81687] by hyatt@apple.com

Fix Leopard build bustage.

12:17 Changeset [81686] by jcivelli@chromium.org

2011-03-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::Vector::contains):

2011-03-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Relanding:
Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:16 Changeset [81685] by commit-queue@webkit.org

2011-03-22 Huahui Wu <mediadependent@gmail.com>

Reviewed by Steve Block.

[Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
https://bugs.webkit.org/show_bug.cgi?id=56763

No new tests as no new functionality is exposed.

  • platform/PlatformTouchEvent.h:
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
12:03 Changeset [81684] by hyatt@apple.com

Source/WebCore: Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Reviewed by Simon Fraser.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

Added new tests in fast/block/lineboxcontain

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSLineBoxContainValue.cpp: Added.

(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
(WebCore::CSSLineBoxContainValue::cssText):

  • css/CSSLineBoxContainValue.h: Added.

(WebCore::CSSLineBoxContainValue::create):
(WebCore::CSSLineBoxContainValue::value):
(WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseLineBoxContain):

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValue.h:

(WebCore::CSSValue::isCSSLineBoxContainValue):

  • css/CSSValueKeywords.in:
  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

  • rendering/RenderInline.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::width):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
(WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::lineBoxContain):
(WebCore::InheritedFlags::setLineBoxContain):
(WebCore::InheritedFlags::initialLineBoxContain):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=56388

Reviewed by Simon Fraser.

Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

  • fast/block/lineboxcontain: Added.
  • fast/block/lineboxcontain/block-font.html: Added.
  • fast/block/lineboxcontain/block-glyphs-replaced.html: Added.
  • fast/block/lineboxcontain/block-glyphs.html: Added.
  • fast/block/lineboxcontain/block-replaced.html: Added.
  • fast/block/lineboxcontain/block.html: Added.
  • fast/block/lineboxcontain/font-replaced.html: Added.
  • fast/block/lineboxcontain/font.html: Added.
  • fast/block/lineboxcontain/glyphs.html: Added.
  • fast/block/lineboxcontain/inline-box-replaced.html: Added.
  • fast/block/lineboxcontain/inline-box-vertical.html: Added.
  • fast/block/lineboxcontain/inline-box.html: Added.
  • fast/block/lineboxcontain/inline-replaced.html: Added.
  • fast/block/lineboxcontain/inline.html: Added.
  • fast/block/lineboxcontain/none.html: Added.
  • fast/block/lineboxcontain/replaced.html: Added.
  • platform/mac/fast/block/lineboxcontain: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/none-expected.txt: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.checksum: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.png: Added.
  • platform/mac/fast/block/lineboxcontain/replaced-expected.txt: Added.
12:03 Changeset [81683] by weinig@apple.com

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Adam Roben.

"Windows edition".

  • win/lib/WebKitSystemInterface.lib:
11:52 Changeset [81682] by loki@webkit.org

2011-03-22 Gabor Loki <loki@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix a bunch of typos in DFG.
https://bugs.webkit.org/show_bug.cgi?id=56813

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::parse):
  • dfg/DFGGenerationInfo.h: (JSC::DFG::GenerationInfo::setSpilled):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump):
  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::setupStubArguments):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.h:
  • dfg/DFGRegisterBank.h: (JSC::DFG::RegisterBank::allocate):
  • dfg/DFGScoreBoard.h: (JSC::DFG::ScoreBoard::~ScoreBoard): (JSC::DFG::ScoreBoard::allocate):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT.h:
11:48 Changeset [81681] by weinig@apple.com

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Brady Eidson.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:40 Changeset [81680] by andersca@apple.com

2011-03-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when calling PluginProxy::evaluate on a destroyed plug-in
https://bugs.webkit.org/show_bug.cgi?id=56848
<rdar://problem/9168975>

Return early if the NPObject doesn't exist anymore.

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::evaluate):
11:26 Changeset [81679] by weinig@apple.com

WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
<rdar://problem/8823874>
https://bugs.webkit.org/show_bug.cgi?id=56847

Reviewed by Adam Roben.

  • Shared/mac/WebEventFactory.mm:

(WebKit::currentMouseButton):
(WebKit::mouseButtonForEvent):
Add mouse button for mouseEnter/Exit events. [NSEvent buttonNumber] doesn't seem to give the right result
for these events, but getting the currentMouseButton does work.

10:58 Changeset [81678] by mrobinson@webkit.org

Merging r81668

10:33 Changeset [81677] by commit-queue@webkit.org

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81664.
http://trac.webkit.org/changeset/81664
https://bugs.webkit.org/show_bug.cgi?id=56840

Rolling out followups to 81653 with expectations. (Requested
by pfeldman on #webkit).

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Removed.
10:27 Changeset [81676] by commit-queue@webkit.org

2011-03-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

[chromium] Remove Gears from Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=56808

Gears has been removed from Chromium 12. Remove Gears drag drop support
from WebKit. That work lead to http://webkit.org/b/25916, a proposal to
add native file drag drop, and its subsequent standardization in HTML5.

  • public/WebBindings.h:
  • public/WebView.h:
  • src/WebBindings.cpp: (WebKit::getRangeImpl): FIXME note added.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragLeave): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
10:09 Changeset [81675] by pfeldman@chromium.org

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
http://trac.webkit.org/changeset/81653
https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • fast/forms/listbox-bidi-align.html: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Removed.

2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81653.
http://trac.webkit.org/changeset/81653
https://bugs.webkit.org/show_bug.cgi?id=56839

Breaks fast/text/drawBidiText.html on Chromium. (Requested by
pfeldman on #webkit).

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
09:59 Changeset [81674] by pfeldman@chromium.org

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

  • inspector/protocol/database-agent-expected.txt: Removed.
  • inspector/protocol/database-agent.html: Removed.
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Removed.
09:47 LayoutTestDashboards edited by mihaip@chromium.org
(diff)
09:46 LayoutTestDashboards edited by mihaip@chromium.org
(diff)
09:25 Changeset [81673] by podivilov@chromium.org

2011-03-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
https://bugs.webkit.org/show_bug.cgi?id=56747

Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::showProfilesPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showAndEnableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
09:21 Changeset [81672] by commit-queue@webkit.org

2011-03-22 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
https://bugs.webkit.org/show_bug.cgi?id=56824

On desktop OpenGL substitute in renderbufferStorage:

  • GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
  • GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
  • GL_RGBA for GL_RGBA4 and GL_RGBA565
  • GL_RGB for RGB5_A1.

Tests: fast/canvas/webgl/uninitialized-test.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::renderbufferStorage):
09:16 Changeset [81671] by dglazkov@chromium.org

2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Move volume slider positioning logic to a custom renderer.
https://bugs.webkit.org/show_bug.cgi?id=56498

No functional change, covered by existing tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
  • rendering/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added. (WebCore::RenderMediaVolumeSliderContainer::layout): Added. (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates. (WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added. (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
  • rendering/MediaControlElements.h: Changed corresponding decls.
09:03 Changeset [81670] by gyuyoung.kim@samsung.com

2011-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Change return values with better one in ewk_setting's functions
https://bugs.webkit.org/show_bug.cgi?id=56819

In ewk_settings_cache_directory_path_set_xxx, they return false value
when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get): (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
08:49 Changeset [81669] by commit-queue@webkit.org

2011-03-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::getViewportGLWidget): Check if we actually have a QWebPageClient before dereferencing it.

2011-03-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
https://bugs.webkit.org/show_bug.cgi?id=54138

  • tests/qwebpage/tst_qwebpage.cpp: (webGLScreenshotWithoutView): (tst_QWebPage::acceleratedWebGLScreenshotWithoutView): (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView): Render a QWebPage (with and without accelerated compositing) with a WebGL context that has no owning view. Shouldn't crash.
07:57 Changeset [81668] by kov@webkit.org

2011-03-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Applications that include WebKit headers fail to build when using strict warnings
because the signature for webkit_application_cache_get_maximum_size is missing a
'void' to make it explicit it takes no arguments.

  • webkit/webkitapplicationcache.h:
07:37 Changeset [81667] by aroben@apple.com

Make Leopard Debug bots and Windows XP Debug (Tests) core builders

These bots are consistently green again.

Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
core builders

Rubber-stamped by Antti Koivisto.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Loosened the regexps for Leopard and Windows.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated expectations.

07:11 Changeset [81666] by aroben@apple.com

Add Windows expected failure results after r81625

The failure is tracked by <http://webkit.org/b/56829>.

  • platform/win/fast/css/percentage-non-integer-expected.checksum: Added.
  • platform/win/fast/css/percentage-non-integer-expected.png: Added.
  • platform/win/fast/css/percentage-non-integer-expected.txt: Added.
07:07 Changeset [81665] by aroben@apple.com

Fix new http tests added in r81635 on Windows

  • http/tests/cache/post-redirect-get.php:
  • http/tests/cache/post-with-cached-subresources.php:
  • http/tests/cache/resources/post-image-to-verify.php:

Pull in portabilityLayer.php, which implements sys_get_temp_dir for PHP 4.

06:52 Changeset [81664] by aroben@apple.com

Add Windows results for new test added in r81653

Windows differs from Mac due to a different scrollbar width within the listboxes.

  • platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.
06:50 Changeset [81663] by pfeldman@chromium.org

2011-03-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: document DOM domain types and protocol methods.
https://bugs.webkit.org/show_bug.cgi?id=56807

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapNode):
  • inspector/InjectedScript.h:
  • inspector/Inspector.json:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode):
06:49 Changeset [81662] by aroben@apple.com

Update Windows results for new test added in r81652

The checked-in results were trying to show that Windows would fail this test, but weren't
quite accurate. Even with these new results Windows still fails the test; the failure is
tracked by <http://webkit.org/b/56828>.

  • platform/win/fast/forms/reset-autofilled-expected.txt:
06:32 Changeset [81661] by ossy@webkit.org

[Qt] Update expectations.

  • platform/qt/Skipped:# Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled()
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.checksum: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.png: Updated.
  • platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt: Updated.
06:05 Changeset [81660] by antonm@chromium.org

Temporary disable object grouping for some types of objects.

BUG=crbug.com/73441

06:02 Changeset [81659] by aroben@apple.com

Skip a new test that relies on unimplemented LayoutTestController functionality in WTR

  • platform/mac-wk2/Skipped: Added fast/forms/reset-autofilled.html.
05:21 Changeset [81658] by commit-queue@webkit.org

2011-03-22 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

Add void to function without parameters
https://bugs.webkit.org/show_bug.cgi?id=56821

  • ewk/ewk_cookies.cpp: (ewk_cookies_clear): (ewk_cookies_policy_get):
  • ewk/ewk_cookies.h:
  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get): (ewk_settings_web_database_path_get): (ewk_settings_proxy_uri_get): (ewk_settings_default_user_agent_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (ewk_view_dpi_get):
04:54 Changeset [81657] by loislo@chromium.org

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed update of database-agent test expectations.
Empty line added at the end.

  • inspector/protocol/database-agent-expected.txt:
04:44 Changeset [81656] by mario@webkit.org

2011-03-22 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, Skipped one test failing because of the same reason.

[GTK] Some test results are one pixel different between the x86_64 and i386 bots
https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skip fast/css/percentage-non-integer.html.
03:49 Changeset [81655] by abarth@webkit.org

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptCore.gyp with information mined from
JavaScriptCore.xcodeproj.

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update JavaScriptGlue.gyp with information mined from
JavaScriptGlue.xcodeproj.

  • gyp/JavaScriptGlue.gyp:
  • gyp/JavaScriptGlue.gypi:

2011-03-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Production configuration in GYP isn&apos;t set up correctly
https://bugs.webkit.org/show_bug.cgi?id=56786

Update WebCore.gyp with information mined from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
03:36 Changeset [81654] by loislo@chromium.org

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for database-agent test.

  • inspector/protocol/database-agent-expected.txt:
  • platform/chromium/inspector/protocol/database-agent-expected.txt: Copied from LayoutTests/inspector/protocol/database-agent-expected.txt.
03:14 Changeset [81653] by commit-queue@webkit.org

2011-03-22 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

  • fast/forms/listbox-bidi-align.html: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.

2011-03-22 Ofri Wolfus <ofri@google.com>

Reviewed by Eric Seidel.

RTL: Select elements with a size attribute are always left aligned.
https://bugs.webkit.org/show_bug.cgi?id=50928

Added support for alignment in RenderListBox.

Test: fast/forms/listbox-bidi-align.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.
02:48 Changeset [81652] by commit-queue@webkit.org

2011-03-22 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
https://bugs.webkit.org/show_bug.cgi?id=56802

  • fast/forms/reset-autofilled-expected.txt: Added.
  • fast/forms/reset-autofilled.html: Added.
  • platform/chromium/fast/forms/reset-autofilled-expected.txt: Added.
  • platform/win/fast/forms/reset-autofilled-expected.txt: Added.

2011-03-22 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Clear autofilled flag when reseting a form
In service of https://code.google.com/p/chromium/issues/detail?id=70037
https://bugs.webkit.org/show_bug.cgi?id=56802

Test: fast/forms/reset-autofilled.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset): Clear the autofilled flag.
02:42 Changeset [81651] by loislo@chromium.org

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

  • inspector/protocol/database-agent-expected.txt: Added.
  • inspector/protocol/database-agent.html: Added.

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. DatabaseAgent.
https://bugs.webkit.org/show_bug.cgi?id=56815

see protocol metabug:

  • All events should use notification wording, not command wording:

addDatabase was renamed to DatabaseOpened.

Test: inspector/protocol/database-agent.html

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):
02:21 Changeset [81650] by loislo@chromium.org

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:

2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol cleanup. ConsoleAgent.
https://bugs.webkit.org/show_bug.cgi?id=56806

renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
new method: disable()
deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::enable): (WebCore::InspectorConsoleAgent::disable):
  • inspector/InspectorConsoleAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated): (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
  • inspector/front-end/inspector.js:
00:43 Changeset [81649] by tkent@chromium.org

2011-03-22 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367

Introduce clampToInteger(unsigned).

  • wtf/MathExtras.h: (clampToInteger): Added.

2011-03-22 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

REGRESSION(r80096): Number type input unexpectedly rounds fractional values
https://bugs.webkit.org/show_bug.cgi?id=56367

Because the default value of the maximum fractional digits of NSNumberFormatter
and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
localized representation. This bug affects only in Mac and Chromium.

To fix this bug,

  • Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
  • NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces() instead of parseToDoubleForNumberType().

No automated tests because the behavior is locale-dependent. This change
updates a manual test.

  • html/NumberInputType.cpp: (WebCore::NumberInputType::visibleValue): Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional part length to formatLocalizedNumber().
  • manual-tests/input-number-localization.html: Update the test to cover this change.
  • platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
  • platform/text/LocalizedNumberICU.cpp: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
  • platform/text/LocalizedNumberNone.cpp: (WebCore::formatLocalizedNumber):
  • platform/text/mac/LocalizedNumberMac.mm: (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().

03/21/11:

23:58 Writing Reftests edited by hayato@chromium.org
(diff)
23:29 LayoutTestDashboards created by ojan@chromium.org
23:27 Changeset [81648] by inferno@chromium.org

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Anonymous blocks need isRenderBlock cast check. Also, need
to allow display BOX for flexible boxes.
https://bugs.webkit.org/show_bug.cgi?id=56709

Test: accessibility/anchor-linked-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): remove specific fix in r81088 which is no longer needed.
  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast check.

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when searching up the render tree
for an anchor element in accessibility code.
https://bugs.webkit.org/show_bug.cgi?id=56709

  • accessibility/anchor-linked-anonymous-block-crash-expected.txt: Added.
  • accessibility/anchor-linked-anonymous-block-crash.html: Added.
23:25 WikiStart edited by ojan@chromium.org
(diff)
22:39 Changeset [81647] by abarth@webkit.org

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptCore.gyp:
    • Also, remove jsc.cpp from the excluded list because it's not part of the jsc_files variable instead of the javascriptcore_files variable.

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

GYP build should not have include paths that point within the source tree
https://bugs.webkit.org/show_bug.cgi?id=56788

Turns out we don't need these include paths anymore now that we have
header maps working properly.

  • gyp/JavaScriptGlue.gyp:
22:24 Changeset [81646] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updating Chromium test expectataions.

  • platform/chromium/test_expectations.txt:
22:21 Changeset [81645] by pfeldman@chromium.org

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81597.
http://trac.webkit.org/changeset/81597
https://bugs.webkit.org/show_bug.cgi?id=56801

Change results in lots of unexpected flaky on the dashboard.
(Requested by pfeldman on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
21:59 Changeset [81644] by hayato@chromium.org

2011-03-21 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

Add the first reftest so that we can make sure that reftests won't cause
any issues on all buildbots.
This patch will also act as a sample reftest which a Wiki page will refer.

https://bugs.webkit.org/show_bug.cgi?id=56450

  • fast/harness/font-weight-bold-expected.html: Added.
  • fast/harness/font-weight-bold.html: Added.
21:32 Changeset [81643] by inferno@chromium.org

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when adjusting position for inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=56300

  • fast/inline/inline-box-adjust-position-crash-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash.html: Added.
  • fast/inline/inline-box-adjust-position-crash2-expected.txt: Added.
  • fast/inline/inline-box-adjust-position-crash2.html: Added.

2011-03-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Revert small change made in r78846 of replacing move with positionLineBox
in the adjusting position function for inline box.
https://bugs.webkit.org/show_bug.cgi?id=56300

The change in r78846 caused positioning line boxes during the step of adjusting
position for inline box, thereby causing line boxes to be nuked. This happens as
part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
Later on, we do the positioning of line boxes again later in that function. This
causes use of removed inline box leading to crash. Also, it is unnecessary to do
this twice.

Tests: fast/inline/inline-box-adjust-position-crash.html

fast/inline/inline-box-adjust-position-crash2.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition):
21:18 Changeset [81642] by mrobinson@webkit.org

Merging r81641

21:14 Changeset [81641] by alex@webkit.org

2011-03-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • configure.ac:

2011-03-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.13 release bump
https://bugs.webkit.org/show_bug.cgi?id=56795

Version bump for 1.3.13 and updated NEWS file with release notes.

  • NEWS:
20:35 Changeset [81640] by commit-queue@webkit.org

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Note that these tests do not run as part of new-run-webkit-tests,
but rather in Chromium's ui_test. I've run them locally and confirmed
they pass; a subsequent Chromium change will be submitted to run them
on the Chromium build bots.

  • http/tests/filesystem/resources/fs-worker-common.js: Added.
  • http/tests/filesystem/resources/fs-worker-test-util.js: Added. Copied from fast/filesystem/resources for use by HTTP tests.
  • http/tests/filesystem/script-tests/resolve-uri.js: Updated to be used either in window or worker context.
  • http/tests/filesystem/workers/resolve-url-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt: Added.
  • http/tests/filesystem/workers/resolve-url-sync.html: Added.
  • http/tests/filesystem/workers/resolve-url.html: Added.
  • http/tests/filesystem/workers/script-tests/TEMPLATE.html: Added.
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added.

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Tests: http/tests/filesystem/workers/resolve-url-sync.html

http/tests/filesystem/workers/resolve-url.html

  • fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::readFileSystem): Add support for workers.
  • fileapi/LocalFileSystem.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::resolveLocalFileSystemURL): (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

2011-03-21 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Pass "create" bool through to allow opening
a filesystem without allowing creation.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker):
  • src/WebWorkerBase.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
  • src/WorkerFileSystemCallbacksBridge.h:
20:28 Changeset [81639] by levin@chromium.org

2011-03-21 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
https://bugs.webkit.org/show_bug.cgi?id=24683

  • http/tests/xmlhttprequest/workers/referer-expected.txt: Fixed expectations now that this works correctly.
  • http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Ditto.

2011-03-21 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

XHR in Workers doesn't set the referrer correctly.
https://bugs.webkit.org/show_bug.cgi?id=24683

Tests: http/tests/xmlhttprequest/workers/referer.html

http/tests/xmlhttprequest/workers/shared-worker-referer.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer. (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer. (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto. (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
  • loader/DocumentThreadableLoader.h: Ditto.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
  • loader/ResourceLoadScheduler.h: Ditto.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
  • loader/WorkerThreadableLoader.h:
20:15 Changeset [81638] by commit-queue@webkit.org

2011-03-21 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[CMAKE] Add exception handling when PORT was missing.
https://bugs.webkit.org/show_bug.cgi?id=56728

  • Source/CMakeLists.txt:
20:06 Changeset [81637] by commit-queue@webkit.org

2011-03-21 Ilya Sherman <isherman@chromium.org>

Reviewed by James Robinson.

Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
Clients should instead call into WebFormControlElement::isEnabled().
https://bugs.webkit.org/show_bug.cgi?id=56364

  • public/WebInputElement.h: Removed isEnabledFormControl().
  • src/WebInputElement.cpp: Removed isEnabledFormControl().
19:35 Changeset [81636] by simonjam@chromium.org

2011-03-21 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline win/linux after r81625.

  • platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/percentage-non-integer-expected.txt.
  • platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.txt:
19:32 Changeset [81635] by japhet@chromium.org

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Tests for https://bugs.webkit.org/show_bug.cgi?id=38690.

  • http/tests/cache/post-redirect-get-expected.txt: Added.
  • http/tests/cache/post-redirect-get.php: Added.
  • http/tests/cache/post-with-cached-subresources-expected.txt: Added.
  • http/tests/cache/post-with-cached-subresources.php: Added.
  • http/tests/cache/resources/post-image-to-verify.php: Added.

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Do not check the DocumentLoader's request cache policy
in determining whether we should force revalidation of a cached
subresource. If the main resource received headers telling it not
to cache, that policy will be propagated to subresources.

The previous behavior is left in behind a flag in Settings, since
QuickLook depends on it.

https://bugs.webkit.org/show_bug.cgi?id=38690

Tests: http/tests/cache/post-redirect-get.php

http/tests/cache/post-with-cached-subresources.php

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): (WebCore::FrameLoader::loadPostRequest):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUseQuickLookResourceCachingQuirks): (WebCore::Settings::useQuickLookResourceCachingQuirks):

2011-03-21 Nate Chapin <japhet@chromium.org>

Reviewed by Brady Eidson.

Expose a preference to use caching quirks for QuickLook,
and use it if the QuickLook framework is loaded.

https://bugs.webkit.org/show_bug.cgi?id=38690

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (useQuickLookQuirks): (+[WebPreferences initialize]): (-[WebPreferences useQuickLookResourceCachingQuirks]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
18:17 Changeset [81634] by mrobinson@webkit.org

Merging r81611

18:15 Changeset [81633] by mrobinson@webkit.org

Merging r81536

18:15 Changeset [81632] by dcheng@chromium.org

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Remove dependency on default font from data-transfer-items.html
https://bugs.webkit.org/show_bug.cgi?id=56791

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
17:58 Changeset [81631] by beidson@apple.com

Fix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783

  • Platform/mac/Logging.mac.mm:
17:50 Changeset [81630] by mrobinson@webkit.org

Merging r81589

17:49 Changeset [81629] by mrobinson@webkit.org

Merging r81587

17:47 Changeset [81628] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.

Reviewed by Brian Weinstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannel):

  • Platform/Logging.h:
  • Platform/mac/Logging.mac.mm: Added.

(WebKit::initializeLogChannel):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize logging if necessary.

  • WebKit2.xcodeproj/project.pbxproj:
17:33 Changeset [81627] by mrobinson@webkit.org

Merging 81575

17:29 Changeset [81626] by mrobinson@webkit.org

Merging 81525

17:24 Changeset [81625] by commit-queue@webkit.org

2011-03-21 Rik Cabanier <cabanier@gmail.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-21 Rik Cabanier <cabanier@adobe.com>

Reviewed by James Robinson.

bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
17:16 Changeset [81624] by abarth@webkit.org

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
https://bugs.webkit.org/show_bug.cgi?id=56780

The reason we couldn't resolve this warning in the GYP build was that
the normal build disables this warning specifically for this file.
This patch takes the same approach as the previous patch to
WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
(rather than a build system configuration).

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Remove the special-case for this file.
  • gyp/JavaScriptCore.gyp:
    • Remove the work-around for this issue.
  • wtf/Assertions.cpp:
    • Add a pragma disabling this warning for this file.
17:14 Changeset [81623] by abarth@webkit.org

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WebCoreExportFileGenerator to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56778

This target mirrors the eponymous target from WebCore.xcodeproj.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • generate-webcore-export-file-generator.sh: Added.
17:11 Changeset [81622] by ap@apple.com

Reviewed by Darin Adler.

REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
https://bugs.webkit.org/show_bug.cgi?id=56782
<rdar://problem/9151993>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Factored out code for resending an event and moved it to WKView.
  • UIProcess/API/mac/WKView.mm: (-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier to just do that in _resendKeyDownEvent:. (-[WKView keyDown:]): Ditto. (-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we are not already resending an event - it would be too confusing if we ever had to do that, but looks like this never happens.
  • UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.
17:11 Changeset [81621] by abarth@webkit.org

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn't crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/JavaScriptCore.gyp:

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build shouldn&apos;t crash on startup
https://bugs.webkit.org/show_bug.cgi?id=56776

Debug builds shouldn't define NDEBUG. This same logic exists in the
project.pbxproj file.

  • gyp/WebCore.gyp:
17:03 Changeset [81620] by dcheng@chromium.org

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=56330

Update the layout test to take into account that the actual contents of the clipboard
are exposed in a paste via DataTransferItems now.
Also fix the flakiness in the layout test.

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/data-transfer-items.html:
  • platform/chromium/test_expectations.txt:

2011-03-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Implement glue between DataTransferItems and the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=56330

Support retrieving clipboard data in a paste through DataTransferItems.

Test: editing/pasteboard/data-transfer-items.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::items):
  • platform/chromium/DataTransferItemChromium.cpp: (WebCore::DataTransferItemChromium::createFromPasteboard): (WebCore::DataTransferItemChromium::create): (WebCore::DataTransferItemChromium::DataTransferItemChromium): (WebCore::DataTransferItemChromium::getAsString):
  • platform/chromium/DataTransferItemChromium.h:
  • platform/chromium/DataTransferItemsChromium.cpp: (WebCore::DataTransferItemsChromium::addPasteboardItem):
  • platform/chromium/DataTransferItemsChromium.h:
16:34 Changeset [81619] by cfleizach@apple.com

AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734

Reviewed by Darin Adler.

../WebCore:

WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

../WebKit/mac:

Implement showContextMenu() so accessibility related code can call this
independent of whether WK1 or WK2 is running.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::showContextMenu):

16:19 Changeset [81618] by commit-queue@webkit.org

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable/disable a GestureReocognizer framework

https://bugs.webkit.org/show_bug.cgi?id=49345

  • wtf/Platform.h:

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Add Support to WebCore to optionally call a platform-specific gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=49345

Added an ability for the EventHandler to invoke an optional platform
specific gesture recognizer.

No tests added because the change should be functionally invisible.

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:
  • platform/PlatformGestureRecognizer.cpp: Added. (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::create):
  • platform/PlatformGestureRecognizer.h: Added.

2011-03-21 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Antonio Gomes.

Flag to enable a platform specific GestureReocognizer framework in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=49345

  • features.gypi:
16:11 Changeset [81617] by andersca@apple.com

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in fails to load contextual menu
https://bugs.webkit.org/show_bug.cgi?id=56777
<rdar://problem/8979033>

Open a Carbon resource map and make it the current map when calling NP_Initialize.

  • Platform/Module.cpp: (WebKit::Module::Module): Initialize m_bundleResourceMap to -1.
  • Platform/Module.h: Add m_bundleResourceMap.
  • Platform/mac/ModuleMac.mm: (WebKit::Module::unload): Close the resource map.

(WebKit::Module::bundleResourceMap):
Open a resource map if necessary.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad): Get the resource map and make it current before calling NP_Initialize.
15:56 Changeset [81616] by mrobinson@webkit.org

Adding svnmerge.py metadata file to the release branch

15:56 Changeset [81615] by andersca@apple.com

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Plug-in process crashes if it fails to load a plug-in module
https://bugs.webkit.org/show_bug.cgi?id=56775

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.
15:17 Changeset [81614] by tony@chromium.org

2011-03-21 Tony Chang <tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] remove devtools_html's dependency on WebKit.gypi
https://bugs.webkit.org/show_bug.cgi?id=56661

We want to depend on the values in the gypi file, not the gypi file
itself. Actually, if someone edits a gypi file, s/he should re-run
gyp to pick up the new dependencies.

It turns out that this doesn't matter much for this target anymore
since we pull the .js dependencies from the inspector html file.

  • WebKit.gyp: cleanup dependencies
  • scripts/generate_devtools_html.py: remove unused param
15:05 Changeset [81613] by dino@apple.com

2011-03-21 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

AnimationBase had a custom linked-list/self-pointer for keeping
track of animations that needed to be notified of style updates
and start progress. This caused problems when AnimationBase was
destroyed, since the pointer wasn't managed in any way. I replaced
these pointers with HashSets and moved the code that removes animations
from the sets into AnimationControllerPrivate, where it belongs.
CompositeAnimation is also more careful to tell AnimationControllerPrivate
when it no longer needs to keep track of waiting animations.

This should stop the style updates being called on non-active animations
(which was the cause of the state machine error here) and should also
stop a few of the related flakey test failures and occasional crashes.

Test: animations/body-removal-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::~AnimationBase):
  • Remove the linked-list
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle): (WebCore::AnimationControllerPrivate::styleAvailable): (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse): (WebCore::AnimationControllerPrivate::startTimeResponse): (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
  • New method to remove animations from the waiting lists
  • page/animation/AnimationControllerPrivate.h:
  • use a HashSet rather than an AnimationBase* pointer.
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • remove the animations and transitions from the lists when we know they are no longer active (rather than waiting for the AnimationBase to do it when destructing)

2011-03-21 Dean Jackson <dino@apple.com>

Reviewed by Chris Marrin and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=56325
ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

Add a test that triggers the assertion by removing the <body>
element and re-inserting it.

While not directly related to this bug, the
transform-origin-vs-functions test would occasionally fail because it
depended on the order of events being fired. The update to the way
animations are keeping their state triggered this more often. Now the
output is sorted before finishing the test.

  • animations/3d/transform-origin-vs-functions.html:
  • animations/body-removal-crash.html: Added.
  • platform/mac/animations/body-removal-crash-expected.checksum: Added.
  • platform/mac/animations/body-removal-crash-expected.png: Added.
  • platform/mac/animations/body-removal-crash-expected.txt: Added.
14:58 Changeset [81612] by simonjam@chromium.org

2011-03-21 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, add flaky and failing tests after r81597.

  • platform/chromium/test_expectations.txt:
14:51 Changeset [81611] by jschuh@chromium.org

2011-03-21 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
https://bugs.webkit.org/show_bug.cgi?id=56690

  • fast/dom/insertedIntoDocument-child-expected.txt: Added.
  • fast/dom/insertedIntoDocument-child.html: Added.
  • fast/dom/insertedIntoDocument-iframe-expected.txt: Added.
  • fast/dom/insertedIntoDocument-iframe.html: Added.
  • fast/dom/insertedIntoDocument-sibling-expected.txt: Added.
  • fast/dom/insertedIntoDocument-sibling.html: Added.

2011-03-21 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Stop inserting when the parent is removed
https://bugs.webkit.org/show_bug.cgi?id=56690

Tests: fast/dom/insertedIntoDocument-child.html

fast/dom/insertedIntoDocument-iframe.html
fast/dom/insertedIntoDocument-sibling.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument):
14:44 Changeset [81610] by abarth@webkit.org

2011-03-21 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add new files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56766

14:41 Changeset [81609] by commit-queue@webkit.org

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
http://trac.webkit.org/changeset/81377
https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • wtf/Vector.h:

2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r81377.
http://trac.webkit.org/changeset/81377
https://bugs.webkit.org/show_bug.cgi?id=56765

WebPageSerializerTest.MultipleFrames is broken (Requested by
simonjam on #webkit).

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h:
  • public/WebVector.h: (WebKit::WebVector::operator[]):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp:
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Removed.
  • tests/data/pageserialization/awesome.png: Removed.
  • tests/data/pageserialization/embed_iframe.html: Removed.
  • tests/data/pageserialization/object_iframe.html: Removed.
  • tests/data/pageserialization/simple_iframe.html: Removed.
  • tests/data/pageserialization/simple_page.html: Removed.
  • tests/data/pageserialization/top_frame.html: Removed.
14:39 Changeset [81608] by tony@chromium.org

2011-03-21 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Convert fake-drag into a dumpAsText test and remove 1s timeout
https://bugs.webkit.org/show_bug.cgi?id=56674

This test was added with eventSender, so there was no leapForward
at the time. Also convert to dumpAsText while I'm here.

  • editing/selection/fake-drag.html:
  • platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.png: Removed.
  • platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
  • platform/mac/editing/selection/fake-drag-expected.png: Removed.
  • platform/mac/editing/selection/fake-drag-expected.txt:
14:19 Changeset [81607] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: skipping new inspector test on GTK unless harness is fixed.

  • platform/gtk/Skipped:
13:54 Changeset [81606] by weinig@apple.com

Fix failing tests on the WebKit2 bots.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

13:05 Changeset [81605] by levin@chromium.org

SubresourceLoader should expose a way to set the outgoing referer/origin
https://bugs.webkit.org/show_bug.cgi?id=55903

Reviewed by Adam Barth.

No new tests as no new functionality is exposed.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/SubresourceLoader.h:
13:03 Changeset [81604] by andersca@apple.com

2011-03-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

QT plug-in loads controller at top of movie not bottom
https://bugs.webkit.org/show_bug.cgi?id=56764
<rdar://problem/8979037>

Create a layer with geometryFlipped set and add the plug-in layer as a sublayer,
matching WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
13:01 Changeset [81603] by commit-queue@webkit.org

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-21 Daniel Sievers <sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
12:57 Changeset [81602] by weinig@apple.com

2011-03-21 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=56762

Add preferences for WebSecurityEnabled, UniversalAccessFromFileURLsAllowed
and FileAccessFromFileURLsAllowed.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebSecurityEnabled): (WKPreferencesGetWebSecurityEnabled): (WKPreferencesSetUniversalAccessFromFileURLsAllowed): (WKPreferencesGetUniversalAccessFromFileURLsAllowed): (WKPreferencesSetFileAccessFromFileURLsAllowed): (WKPreferencesGetFileAccessFromFileURLsAllowed):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:49 Changeset [81601] by commit-queue@webkit.org

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: http/tests/inspector/network tests sometimes fail on Leopard Intel Release (Tests) and SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=56578

Fixed and re-enabled http/tests/inspector/network tests

  • http/tests/inspector/network/network-size.html: Renamed from LayoutTests/http/tests/inspector/network/network-size.html-disabled.
  • http/tests/inspector/network/network-timing.html: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html-disabled.
12:47 Changeset [81600] by commit-queue@webkit.org

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

Restore the expected result before r79953. r79953 changed behavior slightly in function
finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
or after this patch.

  • platform/mac/editing/selection/designmode-no-caret-expected.txt:

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebCore.exp.in:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
  • dom/Node.cpp: (WebCore::Node::isContentEditable):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
  • page/DragController.cpp: (WebCore::DragController::operationForLoad):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::setEditable): (WebCore::Page::isEditable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_editable): (webkit_web_view_set_editable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • Api/qwebpage.cpp: (QWebPage::setContentEditable): (QWebPage::isContentEditable):

2011-03-21 Chang Shu <cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79953): Can't type in MS Outlook 2011
https://bugs.webkit.org/show_bug.cgi?id=56665

r79953 removed the WebView level editablity which is persistent no matter whether
underlying document itself is changed and editability gets lost. The resolution is to
set this WebView editable value to WebCore. This avoids the callback from WebCore to
WebKit which was the main goal in r79953 to improve performance.

  • WebFrame.cpp: (wxWebFrame::MakeEditable): (wxWebFrame::IsEditable):
12:37 Changeset [81599] by ericu@chromium.org

2011-03-21 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704

  • fileapi/DOMFileSystemSync.cpp (DOMFileSystemSync::createFile) (class GetPathHelper): Added, to look up path before creating File.
  • fileapi/DOMFileSystem.cpp (DOMFileSystem::createFile) (GetPathCallback): Added, to look up path before creating File.
  • platform/FileMetadata.h (struct FileMetadata): Added new field platformPath.

2011-03-21 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[fileapi/chromium] Fetch platform path using GetMetadata before creating File from FileEntry*
https://bugs.webkit.org/show_bug.cgi?id=56704

  • src/WebFileSystemCallbacksImpl.cpp: (WebFileSystemCallbacksImpl::didReadMetadata) Pass new platformPath member through.
  • src/WorkerFileSystemCallbacksBridge.cpp: (CrossThreadCopierBase) Copy new platformPath member.
  • public/WebFileInfo.h: (struct WebFileInfo) Add new platformPath member.
12:28 Changeset [81598] by aroben@apple.com

Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
to the master.
(RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
since we're running on the build master, not the slave. Instead, turn the raw source of
actual.html which the build slave uploaded into an HTML log.

12:10 Changeset [81597] by dpranke@chromium.org

2011-03-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: run tests in ascending alphabetical order per dir
https://bugs.webkit.org/show_bug.cgi?id=56760

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
12:08 Changeset [81596] by commit-queue@webkit.org

2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
https://bugs.webkit.org/show_bug.cgi?id=56458

Enabling the feature by default for chromium builds.

  • features.gypi:

2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Media Stream API patch 0: adding compilation guards.
https://bugs.webkit.org/show_bug.cgi?id=56458

Adding options to enable the media stream API feature in Chromium.

  • Scripts/build-webkit:
12:05 Changeset [81595] by jamesr@google.com

Merge 81538 - 2011-03-18 James Robinson <jamesr@chromium.org>

Fix expectation syntax for windows.

  • platform/chromium/test_expectations.txt:

TBR=jamesr@google.com

11:41 Changeset [81594] by weinig@apple.com

Remove old DrawingArea and LayerHostingView code from WKView.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):
(-[WKView hitTest:]):
(-[WKView WebKit::]):

11:33 Changeset [81593] by weinig@apple.com

2011-03-21 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Need WebKit2 API for creating a page with a specific main frame name
https://bugs.webkit.org/show_bug.cgi?id=56759

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h: Add mainFrameName to creation parameters.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:]): (-[WKView initWithFrame:contextRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:mainFrameName:]): Add new initializer which takes a main frame name.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMainFrameName): (WebKit::WebPageProxy::creationParameters):
  • UIProcess/WebPageProxy.h: Store the main frame name for initialization/re-initialization.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::createMainFrame):
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Pass the name to main frame creation.
11:20 Changeset [81592] by commit-queue@webkit.org

2011-03-21 Dominic Cooney <dominicc@google.com>

Reviewed by Jeremy Orlow.

Adds a regression test for MediaQueryList listener callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=56166

  • fast/media/media-query-list-callback-expected.txt: Added.
  • fast/media/media-query-list-callback.html: Added.
  • fast/media/resources/media-query-list-callback-frame.html: Added.

2011-03-21 Dominic Cooney <dominicc@google.com>

Reviewed by Jeremy Orlow.

Establishes a V8 context before executing MediaQueryList callbacks.
https://bugs.webkit.org/show_bug.cgi?id=56166

MediaQueryList listener callbacks didn't establish a V8 context
before running script, causing crashes on C++-only
callstacks (such as user resizing, printing, etc.) I believe this
could also be contrived to execute media query list listener
callbacks across domain.

Test: fast/media/media-query-list-callback.html

  • css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged):
10:25 Changeset [81591] by andreas.kling@nokia.com

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Add QNetworkReplyHandler::wasAborted()

Instead of checking if the ResourceHandle is null everywhere,
use a wasAborted() method to make the code readable.

  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyHandler::wasAborted):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::uploadProgress):
10:11 Changeset [81590] by cfleizach@apple.com

platform/mac/accessibility/aria-table-with-colspan-cells.html is failing on the Leopard Release tester
https://bugs.webkit.org/show_bug.cgi?id=56523

Reviewed by Darin Adler.

List and table functionality is not present on Leopard and should be skipped.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/platform/mac/accessibility: Removed.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Removed.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Removed.
10:11 Changeset [81589] by christian@webkit.org

WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=56201

Reviewed by Martin Robinson.

  • platform/graphics/gtk/ImageGtk.cpp: Don't attempt to make a pixbuf

if there is no image.

09:40 Changeset [81588] by qi.2.zhang@nokia.com

2011-03-21 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=56323

Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
"--stdout" or "--stderr" option.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::processArgsLine): (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setRedirectOutputFileName): (WebCore::DumpRenderTree::setRedirectErrorFileName):
  • DumpRenderTree/qt/main.cpp: (isOption): (takeOptionValue): (printUsage): (main):
09:32 Changeset [81587] by mario@webkit.org

2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
https://bugs.webkit.org/show_bug.cgi?id=56737

Only consider parent objects not ignoring accessibility.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: (webkitAccessibleHyperlinkGetStartIndex): Look for the parent object not ignoring accessibility for the current hyperlink. (webkitAccessibleHyperlinkGetEndIndex): Ditto.

2011-03-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
https://bugs.webkit.org/show_bug.cgi?id=56737

  • tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also check offsets for hyperlinks inside <span> nodes.
09:18 WebKitGTK edited by mrobinson@webkit.org
(diff)
09:14 Changeset [81586] by aroben@apple.com

Fix exceptions on the buildbot due to my last change

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.

09:00 Changeset [81585] by aroben@apple.com

Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file

Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
output as plain text

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
logs.
(RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
the build master. This will correctly treat it as HTML.

08:49 Changeset [81584] by andreas.kling@nokia.com

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove handling of QNetworkAccessManager::UnknownOperation

Now that Qt 4.7 is required we never have to fall back to UnknownOperation.
Custom verb requests are using CustomOperation already, so this was dead code.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::start):
08:41 Changeset [81583] by aroben@apple.com

Fix multiple-definition linker warnings on Windows

  • WebCore.vcproj/WebCore.vcproj: Exclude RenderSVGPath.cpp from the build, since it is

already being compiled via RenderingAllInOne.cpp. Let VS have its way with the rest of the
file.

08:28 Changeset [81582] by andreas.kling@nokia.com

2011-03-21 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Clean up QNetworkReplyHandler::release()

Since QNetworkReplyHandler no longer uses queued connections to
the QNetworkReply, it's not necessary to mess with the event
queue when releasing a reply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release):
08:19 Changeset [81581] by aroben@apple.com

Skip another asserting animations test

<http://webkit.org/b/56488> tracks the failure

  • platform/mac/Skipped:
  • platform/win/Skipped:
08:06 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
07:40 Changeset [81580] by commit-queue@webkit.org

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added a test for transfer size for chunked encoding type.

  • http/tests/inspector/network/network-size-chunked.html: Added.
  • http/tests/inspector/network/network-size-expected-chunked.txt: Added.
  • http/tests/inspector/network/resources/resource.php:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

Test: http/tests/inspector/network/network-size-chunked.html

  • inspector/Inspector.idl:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.increaseTransferSize):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::forwardData):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer):

2011-03-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector does not always show correct transfer size (for compressed/chunked data)
https://bugs.webkit.org/show_bug.cgi?id=56691

Added transfer size support in inspector for compressed data.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveData):
07:36 Changeset [81579] by commit-queue@webkit.org

2011-03-21 Hao Zheng <zhenghao@google.com>

Reviewed by Darin Adler.

Bug 15713: Rollout r72533 completely.
https://bugs.webkit.org/show_bug.cgi?id=15713

r72599 only rolled out the checksum files, which caused mismatch
between checksum and png. Some png files had been
rolled out by some other changes, so rollout the remaining png.

  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-linux/fast/doctypes/002-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-expected.png:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/lists/007-vertical-expected.png:
  • platform/chromium-linux/fast/lists/008-vertical-expected.png:
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/doctypes/002-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-expected.png:
  • platform/chromium-win/fast/lists/003-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
07:21 Changeset [81578] by krit@webkit.org

2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
https://bugs.webkit.org/show_bug.cgi?id=54538

SVG spec: http://www.w3.org/TR/SVG/struct.html#UseElement
Quotation for referenced <symbol>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these attributes will be transferred to the generated 'svg'."
Quotation for referenced <svg>: "If attributes 'width'
and/or 'height' are provided on the 'use' element, then
these values will override the corresponding attributes
on the 'svg' in the generated tree."
For above quotations, we should treat 'use' element as referencing
'use' element, just like Firefox 3.6 and Opera 11, instead of
corrensponding 'use' element.

Tests: svg/custom/use-transfer-width-height-properties-to-svg.svg

svg/custom/use-transfer-width-height-properties-to-svg1.svg
svg/custom/use-transfer-width-height-properties-to-svg2.svg
svg/custom/use-transfer-width-height-properties-to-symbol.svg
svg/custom/use-transfer-width-height-properties-to-symbol1.svg
svg/custom/use-transfer-width-height-properties-to-symbol2.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::SVGElementInstance):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::create): (WebCore::SVGElementInstance::correspondingUseElement): (WebCore::SVGElementInstance::directUseElement): (WebCore::SVGElementInstance::clearUseElements):
  • svg/SVGUseElement.cpp: (WebCore::updateContainerSize): (WebCore::SVGUseElement::updateContainerSizes): (WebCore::dumpInstanceTree): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::buildInstanceTree):

2011-03-21 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

symbol display <use> at wrong scale
https://bugs.webkit.org/show_bug.cgi?id=54538

Test cases for transfering width/height properties from
'use' element to 'svg' and 'symbol' elements.
See: http://www.w3.org/TR/SVG/struct.html#UseElement

  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/mac/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol1-expected.png: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.checksum: Added.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.png: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-svg2.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol1.svg: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Added.
  • svg/custom/use-transfer-width-height-properties-to-symbol2.svg: Added.
06:54 Changeset [81577] by loki@webkit.org

Extend constant pool to be able to store 16 bit instructions with a constant
https://bugs.webkit.org/show_bug.cgi?id=46796

Reviewed by Csaba Osztrogonác.

The putShortWithConstantInt function inserts a 16 bit instruction which
refers a 32 bits constant or literal. This is a vital function for those
target which loads a PC relative value with a 16 bit instruction (like
Thumb-2 instruction set and SH4 architecture).

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):

  • assembler/AssemblerBufferWithConstantPool.h:
03:53 Changeset [81576] by commit-queue@webkit.org

2011-03-21 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Pavel Feldman.

Fix build break when inspector is enabled.
https://bugs.webkit.org/show_bug.cgi?id=56735

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Add ENABLE(INSPECTOR).
02:33 Changeset [81575] by philn@webkit.org

2011-03-21 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK distcheck build fix.

  • GNUmakefile.am:
01:20 Changeset [81574] by jchaffraix@webkit.org

2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

  • fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
  • fast/css/webkit-empty-transform-preserve3d-crash.html: Added.

2011-03-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)

Test: fast/css/webkit-empty-transform-preserve3d-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation): Mimicked the rest of the code and check that the RenderBox has a layer to avoid crashing on the layer() call.
00:56 Changeset [81573] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move cookie processing and appcache from DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=56713

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  • inspector/front-end/CookieItemsView.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.buildCookiesFromString): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.eventListeners):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update):
00:54 Changeset [81572] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate Inspector.json to valid JSON types.
https://bugs.webkit.org/show_bug.cgi?id=56651

This change migrates inspector from long to int as
dom, storage, database and other id types.

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightDOMNode):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::addRule): (WebCore::InspectorCSSAgent::elementForId):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::addInspectedNode): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::bind): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::boundNodeId): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::setNodeName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::pushNodeToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::loadEventFired): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::characterDataModified): (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults): (WebCore::InspectorDOMAgent::copyNode): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h: (WebCore::InspectorDOMStorageResource::id):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseId): (WebCore::InspectorDatabaseAgent::databaseForId):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::id):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::setInitialContent): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket):
  • inspector/generate-inspector-idl:
00:44 Changeset [81571] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/report-protocol-errors-expected.txt:

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make frameId in network agent of type string, not unsigned long.
https://bugs.webkit.org/show_bug.cgi?id=56708

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::highlightFrame):
  • inspector/InspectorAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::pointerAsId): (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrame): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::frameForId): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addOrUpdateFrame):
00:42 Changeset [81570] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56681

  • http/tests/inspector/protocol-test.js: (initialize_ProtocolTest.InspectorTest.filterProps): (initialize_ProtocolTest.InspectorTest._dumpCallArguments):
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object id as string, not JSON struct in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=56681

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::inspect):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::inspectCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::releaseObject):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptForObjectId): (WebCore::InjectedScriptManager::releaseObjectGroup):
  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::releaseObject): (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluatedProperties): (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/PropertiesSidebarPane.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.inspect):
00:24 Changeset [81569] by pfeldman@chromium.org

2011-03-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselined Chromium expectations.

  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt: Added.

03/20/11:

22:59 Changeset [81568] by pfeldman@chromium.org

2011-03-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: removing stale Chromium expectations.

  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Removed.
16:30 Changeset [81567] by levin@chromium.org

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • API/JSClassRef.h:
  • API/OpaqueJSString.h:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Atomics.h:
  • wtf/CMakeLists.txt:
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::crossThreadCopy):
  • wtf/ThreadSafeRefCounted.h: Copied from wtf/ThreadSafeShared.h. (WTF::ThreadSafeRefCountedBase::ThreadSafeRefCountedBase): (WTF::ThreadSafeRefCountedBase::ref): (WTF::ThreadSafeRefCountedBase::refCount): (WTF::ThreadSafeRefCountedBase::derefBase): (WTF::ThreadSafeRefCounted::ThreadSafeRefCounted):
  • wtf/ThreadSafeShared.h: Removed.
  • wtf/Threading.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • gyp/JavaScriptGlue.gypi:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from ForwardingHeaders/wtf/ThreadSafeShared.h.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • bindings/v8/SerializedScriptValue.h:
  • dom/Document.cpp:
  • dom/default/PlatformMessagePortChannel.h:
  • fileapi/FileThread.h:
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::create): (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didSendData): (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse): (WebCore::ThreadableLoaderClientWrapper::didReceiveData): (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
  • page/SecurityOrigin.h:
  • platform/CrossThreadCopier.h:
  • platform/network/BlobData.h:
  • platform/network/cf/SocketStreamHandle.h:
  • storage/AbstractDatabase.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseCallback.h:
  • storage/DatabaseThread.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/SQLError.h:
  • storage/SQLResultSet.h:
  • storage/SQLStatement.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • workers/DefaultSharedWorkerRepository.cpp:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • Platform/CoreIPC/Connection.h:
  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/ThreadLauncher.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • src/PlatformMessagePortChannel.h:
  • src/WebWorkerBase.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.h:

2011-03-20 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

Rename ThreadSafeShared to ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=56714

No new tests. Exposes no new functionality.

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • Scripts/do-webcore-rename:
15:25 Changeset [81566] by weinig@apple.com

Add http/tests/appcache/origin-delete.html to the Skipped list for WebKit2,
since layoutTestController.clearAllApplicationCaches is not yet implemented
by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
13:07 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:40 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:32 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
12:31 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
03:25 Changeset [81565] by andreas.kling@nokia.com

2011-03-20 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean up redirection logic in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=56717

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Use resetState() when constructing QNRH as well.

(WebCore::QNetworkReplyHandler::resetState):
Delete (deferred) the m_reply if one exists (only when redirecting.)

(WebCore::QNetworkReplyHandler::finish):
Return early when redirecting.

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
Move the redirection logic from sendResponseIfNeeded() into a
separate redirect() method.

03/19/11:

20:39 Changeset [81564] by commit-queue@webkit.org

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Dan Bernstein.

Add stub to LayoutTestControllerGtk.cpp to fix GTK build
https://bugs.webkit.org/show_bug.cgi?id=56719

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
17:57 Changeset [81563] by paroga@webkit.org

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Remove StringImpl::computeHash()
https://bugs.webkit.org/show_bug.cgi?id=49894

Replace remainig StringImpl::computeHash with StringImpl::computeHashStringHasher.

  • wtf/text/AtomicString.cpp: (WTF::CStringTranslator::hash): (WTF::UCharBufferTranslator::hash): (WTF::HashAndCharactersTranslator::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::setHash): (WTF::StringImpl::hash):
15:36 Changeset [81562] by andreas.kling@nokia.com

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Rename ignoreHttpError() to shouldIgnoreHttpError()

The function doesn't ignore anything, thus it shouldn't have an imperative name.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::shouldIgnoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
15:18 Changeset [81561] by andreas.kling@nokia.com

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Kill layer violation FIXME in ResourceHandleQt.

We were including qwebframe_p.h from WebKit/qt for no reason.

  • platform/network/qt/ResourceHandleQt.cpp:
15:15 Changeset [81560] by andreas.kling@nokia.com

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Refactor handling of deferred loads
https://bugs.webkit.org/show_bug.cgi?id=56715

Split QNetworkReplyHandler's "load mode" into two parameters
instead of trying to fit the deferral mechanism into it.

Loads are now AsynchronousLoad (default) or SynchronousLoad (for sync XHR.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadingDeferred): (WebCore::QNetworkReplyHandler::resumeDeferredLoad): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::resetState):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::platformSetDefersLoading):
15:08 Changeset [81559] by mrowe@apple.com

Versioning.

15:07 Changeset [81558] by mrowe@apple.com

New tag.

14:28 Changeset [81557] by commit-queue@webkit.org

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

This test creates an Application Cache for the DRT origin, deletes it for the origin,
and verifies that the Application Cache has obsolete status.

  • http/tests/appcache/origin-delete-expected.txt: Added.
  • http/tests/appcache/origin-delete.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.html: Added.
  • http/tests/appcache/resources/origin-delete-iframe.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

To delete all Application Cache for an origin, we must obsolete all
in-memory cache groups for that origin. If a cache group isn't in memory,
then it must be deleted from disk. The previous implementation correctly
removed on-disk cache groups, but did not mark in-memory cache groups as obsolete.
This caused an assertion failure in ApplicationCacheStorage::cacheGroupDestroyed()
when the DocumentLoader was destroyed.

Test: http/tests/appcache/origin-delete.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::clearStorageID): (WebCore::ApplicationCache::deleteCacheForOrigin):
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::findInMemoryCacheGroup):
  • loader/appcache/ApplicationCacheStorage.h:

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

Use new ApplicationCache API to delete all cache for an origin.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteOrigin:]):

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: calling ApplicationCacheGroup::deleteCacheGroupsForOrigin instead of ApplicationCacheStorage::deleteEntriesForOrigin. (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):

2011-03-19 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
https://bugs.webkit.org/show_bug.cgi?id=56415

  • DumpRenderTree/LayoutTestController.cpp: (clearApplicationCacheForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs. (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub. (LayoutTestController::clearApplicationCacheForOrigin):
13:11 Changeset [81556] by gyuyoung.kim@samsung.com

2011-03-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy GeolocationServiceEfl. cpp | h
https://bugs.webkit.org/show_bug.cgi?id=56710

Add dummy GeolocationServiceEfl.cpp | h to platform/efl.

  • CMakeListsEfl.txt:
  • platform/efl/GeolocationServiceEfl.cpp: Added. (WebCore::GeolocationServiceEfl::create): (WebCore::GeolocationServiceEfl::GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::~GeolocationServiceEfl): (WebCore::GeolocationServiceEfl::startUpdating): (WebCore::GeolocationServiceEfl::stopUpdating): (WebCore::GeolocationServiceEfl::suspend): (WebCore::GeolocationServiceEfl::resume): (WebCore::GeolocationServiceEfl::lastPosition): (WebCore::GeolocationServiceEfl::lastError):
  • platform/efl/GeolocationServiceEfl.h: Added.
13:09 Changeset [81555] by paroga@webkit.org

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Unreviewed, rolling out r81551.
http://trac.webkit.org/changeset/81551
https://bugs.webkit.org/show_bug.cgi?id=55336

Broke some storage tests on Win32.

  • platform/win/FileSystemWin.cpp: (WebCore::statFile): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
12:22 Changeset [81554] by simonjam@chromium.org

2011-03-19 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, remove stale expectations for r81528.

  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
12:07 Changeset [81553] by andreas.kling@nokia.com

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712

  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
  • WebCoreSupport/GeolocationClientQt.cpp: (WebCore::GeolocationClientQt::positionUpdated):

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Remove support for Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=56712

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::selectionRectForSimpleText):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::paint):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::DnsPrefetchHelper): (WebCore::DnsPrefetchHelper::lookup):
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaSliderTrack):
11:35 Changeset [81552] by andreas.kling@nokia.com

2011-03-19 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
https://bugs.webkit.org/show_bug.cgi?id=56711

Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
ownership of the reply is transferred to the receiving slot.

  • Api/qwebpage.cpp:
10:55 Changeset [81551] by paroga@webkit.org

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Use GetFileInformationByHandle() in favour over _wstat64(), GetFileSizeEx()
and GetFileAttributesEx() so we can share the code with WinCE.

  • platform/win/FileSystemWin.cpp: (WebCore::createFileHandle): (WebCore::getFileInformation): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists):
07:25 Changeset [81550] by xan@webkit.org

2011-03-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Simplify GObjectEventListener
https://bugs.webkit.org/show_bug.cgi?id=56698

Get rid of special case for DOMWindow, since it's also an
EventTarget.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): remove DOMWindow special casing. (WebCore::GObjectEventListener::~GObjectEventListener): ditto. (WebCore::GObjectEventListener::gobjectDestroyed):
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): ditto. (WebCore::GObjectEventListener::removeEventListener): ditto.
06:08 Changeset [81549] by commit-queue@webkit.org

2011-03-19 Ben Taylor <bentaylor.solx86@gmail.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=56195
Fix conditional which had an int for one case and a pointer for another.
Similar fix as https://bugs.webkit.org/show_bug.cgi?id=56198

No new tests. Fix compilation on Solaris 10 with Sun Studio C++

  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
04:42 Changeset [81548] by paroga@webkit.org

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
  • wtf/StringHasher.h: (WTF::StringHasher::computeHash): (WTF::StringHasher::hashMemory):
  • wtf/text/StringHash.h: (WTF::CaseFoldingHash::hash):
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):

2011-03-19 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Rename WTF::StringHasher methods
https://bugs.webkit.org/show_bug.cgi?id=53532

Rename createHash to computeHash and createBlobHash to hashMemory.
Also add a using WTF::StringHasher in the header file.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents):
  • dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
  • platform/graphics/FontCache.cpp: (WebCore::computeHash):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
  • svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
Note: See TracTimeline for information about the timeline view.