Timeline



Apr 5, 2011:

11:50 PM Changeset in webkit [83025] by koz@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-04-05 James Kozianski <koz@chromium.org>

[chromium] Rebaseline images after r82969

Rebaseline for missed linux test in r83019.

  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed.
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
11:39 PM Changeset in webkit [83024] by ojan@chromium.org
  • 4 edits
    66 deletes in trunk/LayoutTests

2011-04-05 Shane Stephens <shanestephens@google.com>

Reviewed by Ojan Vafai.

[Chromium] Greening the Mac 10.5 and 10.6 trees.
https://bugs.webkit.org/show_bug.cgi?id=57924

Rebaselines a bunch of tests with differences due to text anti-aliasing.
(Prepared using rebaseline script)

  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/ruby-length-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/background-clip-values-expected.checksum: Added.
  • platform/mac/fast/css/background-clip-values-expected.png: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
  • platform/mac/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
  • platform/mac/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
  • platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/mac/media/controls-without-preload-expected.checksum: Added.
  • platform/mac/media/controls-without-preload-expected.png: Added.
11:29 PM Changeset in webkit [83023] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566

  • public/WebContextMenuData.h:
11:27 PM Changeset in webkit [83022] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
https://bugs.webkit.org/show_bug.cgi?id=57914

Reviewed by Cameron Zwarich.

Don't call adjustedDeferredRepaintDelay unnecessarily.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::adjustedDeferredRepaintDelay):

11:01 PM Changeset in webkit [83021] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r83007.
http://trac.webkit.org/changeset/83007
https://bugs.webkit.org/show_bug.cgi?id=57920

Broke WebFrameTest.FrameForEnteredContext on Chromium-win and
Chromium-mac (Requested by tkent on #webkit).

  • WebKit.gyp:
  • WebKit.gypi:
  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • tests/WebFrameTest.cpp: (WebKit::WebFrameTest::WebFrameTest): (WebKit::WebFrameTest::registerMockedURLLoad): (WebKit::WebFrameTest::serveRequests): (WebKit::TEST_F):
10:57 PM Changeset in webkit [83020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Update call to SkAdvancedTypefaceMetrics to new API.
https://bugs.webkit.org/show_bug.cgi?id=57887

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::emSizeInFontUnits):
10:57 PM Changeset in webkit [83019] by koz@chromium.org
  • 29 edits
    1 add
    40 deletes in trunk/LayoutTests

2011-04-05 James Kozianski <koz@chromium.org>

Rebaseline images after r82969
https://bugs.webkit.org/show_bug.cgi?id=57917

Rebaseline for r82969, which causes slight changes in rounded corner rendering.

  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/layers/video-layer-expected.checksum: Removed.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
  • platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.checksum: Removed.
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.checksum: Removed.
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum: Removed.
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.checksum: Removed.
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.checksum: Removed.
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Removed.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum: Removed.
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.checksum: Removed.
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Removed.
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win-xp/media/controls-after-reload-expected.checksum: Removed.
  • platform/chromium-win-xp/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-win-xp/media/controls-strict-expected.checksum: Removed.
  • platform/chromium-win-xp/media/controls-strict-expected.png: Removed.
  • platform/chromium-win-xp/media/controls-styling-expected.checksum: Removed.
  • platform/chromium-win-xp/media/controls-styling-expected.png: Removed.
  • platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Removed.
  • platform/chromium-win-xp/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-win-xp/media/video-controls-rendering-expected.checksum: Removed.
  • platform/chromium-win-xp/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.checksum: Removed.
  • platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-win/fast/forms/basic-selects-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.checksum: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
  • platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.checksum: Removed.
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum: Removed.
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum: Removed.
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.checksum: Removed.
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.checksum: Removed.
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum: Removed.
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.checksum: Removed.
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Removed.
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
10:21 PM Changeset in webkit [83018] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch to deps.

10:11 PM Changeset in webkit [83017] by tkent@chromium.org
  • 75 edits
    74 deletes in trunk/LayoutTests

2011-04-05 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectation images for a Skia rounded rectangle change (r83002).
https://bugs.webkit.org/show_bug.cgi?id=57907

  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
  • platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-win/fast/forms/basic-selects-expected.png:
  • platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
  • platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
9:35 PM Changeset in webkit [83016] by ap@apple.com
  • 5 edits in trunk/Source/WebCore

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Rename event dispatching functions after form event removal
https://bugs.webkit.org/show_bug.cgi?id=57908

  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer):
  • dom/Node.cpp: (WebCore::Node::dispatchChangeEvent): (WebCore::Node::dispatchInputEvent): (WebCore::Node::defaultEventHandler):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent): Renamed "events" to "event", since there is only one event to dispatch now.
8:58 PM Changeset in webkit [83015] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82978, r82999, and r83001.
http://trac.webkit.org/changeset/82978
http://trac.webkit.org/changeset/82999
http://trac.webkit.org/changeset/83001
https://bugs.webkit.org/show_bug.cgi?id=57913

Does not work in Python 2.5 (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
8:56 PM Changeset in webkit [83014] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

[Qt] DragControllerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40258

This patch does not require new test cases.

  • page/qt/DragControllerQt.cpp: (WebCore::DragController::dragOperation):
8:53 PM Changeset in webkit [83013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Update deprecated include: platform_canvas_win.h to platform_canvas.h.
https://bugs.webkit.org/show_bug.cgi?id=57896

  • platform/graphics/chromium/FontChromiumWin.cpp:
8:49 PM Changeset in webkit [83012] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Who likes export files? I do!
8:44 PM Changeset in webkit [83011] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-04-05 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Introduced the concept of opaque roots, in preparation for marking the DOM with them
https://bugs.webkit.org/show_bug.cgi?id=57903

  • collector/handles/HandleHeap.cpp: (JSC::isValidWeakHandle): Factored out a helper function for ASSERTs.

(JSC::WeakHandleOwner::~WeakHandleOwner): Moved from header to avoid
weak linkage problems.

(JSC::WeakHandleOwner::isReachableFromOpaqueRoots): New callback.
Currently unused.

(JSC::WeakHandleOwner::finalize): Switched from pure virtual to a
default empty implementation, since not all clients necessarily want
or need non-trivial finalizers.

(JSC::HandleHeap::markWeakHandles): Split updateWeakHandles into two
passes. The first pass marks all reachable weak handles. The second pass
finalizes all unreachable weak handles. This must be two passes because
we don't know the set of finalizable weak handles until we're done
marking all weak handles.

(JSC::HandleHeap::finalizeWeakHandles): Use new helper function.

  • collector/handles/HandleHeap.h: Ditto.
  • runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): (JSC::Heap::reset): Split out handle marking from handle finalization.
  • runtime/MarkStack.cpp: (JSC::MarkStack::reset):
  • runtime/MarkStack.h: (JSC::MarkStack::addOpaqueRoot): (JSC::MarkStack::containsOpaqueRoot): (JSC::MarkStack::opaqueRootCount): (JSC::HeapRootMarker::markStack): New helper functions for managing the set of opaque roots.
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::finalize): Renamed to match parent class declaration.
8:05 PM Changeset in webkit [83010] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleNumberOfPages):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::numberOfPages):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::numberOfPages):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7:20 PM Changeset in webkit [83009] by tony@chromium.org
  • 4 edits in trunk/Tools

2011-04-05 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
https://bugs.webkit.org/show_bug.cgi?id=57889

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
7:06 PM Changeset in webkit [83008] by koz@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 James Kozianski <koz@chromium.org>

Unreviewed, rolling out r82976.
http://trac.webkit.org/changeset/82976
https://bugs.webkit.org/show_bug.cgi?id=57566

Breaks chromium canary build

  • public/WebContextMenuData.h:
6:55 PM Changeset in webkit [83007] by aa@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-04-05 Aaron Boodman <aa@chromium.org>

Reviewed by Adam Barth.

Add ability to get frame from v8 context to chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57516

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrame::frameForV8Context):
6:28 PM Changeset in webkit [83006] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Leopard bots.

  • platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems

to have intended it.

6:00 PM Changeset in webkit [83005] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Leopard bots.

  • platform/mac/HTMLConverter.mm: Move declarations of new functions

inside the appropriate #if.

5:55 PM Changeset in webkit [83004] by Darin Adler
  • 11 edits in trunk/Source/WebKit2

2011-04-05 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

[Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
https://bugs.webkit.org/show_bug.cgi?id=57893
<rdar://problem/9130486>

  • UIProcess/API/mac/PageClientImpl.h: Added executeSavedCommandBySelector.
  • UIProcess/API/mac/PageClientImpl.mm: Renamed internal Objective-C classes to use the WebKit2 Objective-C class prefix, WK, rather than the WebKit1 Objective-C class prefix, Web. Removed some unneeded explicit WebKit namespace prefixes. (-[WKEditCommandObjC initWithWebEditCommandProxy:]): Removed unneeded WebKit namespace prefix. (-[WKEditCommandObjC command]): Ditto. (-[WKEditorUndoTargetObjC undoEditing:]): Updated for new class name. (-[WKEditorUndoTargetObjC redoEditing:]): Ditto. (WebKit::PageClientImpl::PageClientImpl): Ditto. (WebKit::PageClientImpl::registerEditCommand): Ditto. (WebKit::PageClientImpl::executeSavedCommandBySelector): Added.
  • UIProcess/API/mac/WKView.mm: Renamed internal Objective-C categories to use the WebKit2 Objective-C prefix, WK, rather than the WebKit1 Objective-C prefix, Web, or no prefix at all. Tweaked use of extern "C" a little. (-[WKView doCommandBySelector:]): Tweaked the comment. (-[WKView _executeSavedCommandBySelector:]): Added. For use when command is not handled by WebCore. (-[WKResponderChainSink initWithResponderChain:]): Added. Based on the WebResponderChainSink class in WebKit1. (-[WKResponderChainSink detach]): Added. (-[WKResponderChainSink didReceiveUnhandledCommand]): Added. (-[WKResponderChainSink noResponderFor:]): Added. (-[WKResponderChainSink doCommandBySelector:]): Added. (-[WKResponderChainSink tryToPerform:with:]): Added.
  • UIProcess/API/mac/WKViewInternal.h: Added declaration of _executeSavedCommandBySelector: method. Also removed unneeded includes.
  • UIProcess/PageClient.h: Added executeSavedCommandBySelector.
  • UIProcess/WebPageProxy.h: Added executeSavedCommandBySelector.
  • UIProcess/WebPageProxy.messages.in: Added ExecuteSavedCommandBySelector.
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm: Updated includes.
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::executeSavedCommandBySelector): Added.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::executeKeypressCommandsInternal): Send the synchronous ExecuteSavedCommandBySelector message when a command is not handled by WebCore.
5:31 PM Changeset in webkit [83003] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, temporarily mark two tests as more generally failing.

  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [83002] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-05 Adrienne Walker <enne@google.com>

Reviewed by Tony Chang.

Correctly set color when using skia's fillRoundedRect.
https://bugs.webkit.org/show_bug.cgi?id=57907

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRoundedRect):
5:28 PM Changeset in webkit [83001] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-04-05 Adam Barth <abarth@webkit.org>

Silly with statement, from the future!

  • Scripts/webkitpy/common/system/executive.py:
5:22 PM Changeset in webkit [83000] by ap@apple.com
  • 12 edits
    2 moves in trunk/Source

Reviewed by Darin Adler.

Move attributedStringFromRange down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=57905

4:54 PM Changeset in webkit [82999] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Don't use Exception.message because it's deprecated
https://bugs.webkit.org/show_bug.cgi?id=57892

Suppress the warning for now. When we move to Python 3, we might need
to something more dramatic.

  • Scripts/webkitpy/common/system/executive.py:
4:17 PM Changeset in webkit [82998] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-04-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Add builders.js to dashboard file list
https://bugs.webkit.org/show_bug.cgi?id=57899

Add file added by http://crrev.com/80538 to dashboard file list.

  • TestResultServer/handlers/dashboardhandler.py:
4:03 PM Changeset in webkit [82997] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Alexey Proskuryakov.

Some plug-in content is displayed upside down in Unity plug-in
https://bugs.webkit.org/show_bug.cgi?id=57895
<rdar://problem/9212003>

Create the flipped geometry layer in the web process instead of the plug-in process,
which matches what we do in WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize):
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: (WebKit::PluginProxy::pluginLayer):
3:59 PM Changeset in webkit [82996] by thakis@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-04-05 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Don't have 'using namespace' declarations in header files
https://bugs.webkit.org/show_bug.cgi?id=57882

  • src/EventListenerWrapper.cpp:
  • src/EventListenerWrapper.h:
  • src/VideoFrameChromiumImpl.h:
  • src/WebDOMEventListener.cpp:
  • src/WebDOMEventListenerPrivate.cpp:
  • src/WebDOMEventListenerPrivate.h: (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
3:50 PM Changeset in webkit [82995] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-05 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Rename variables in border drawing code for readability
https://bugs.webkit.org/show_bug.cgi?id=57894

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::drawBoxSideFromPath): (WebCore::RenderObject::drawArcForBoxSide):
3:48 PM Changeset in webkit [82994] by sfalken@apple.com
  • 3 edits in tags/Safari-534.27.1/Source/JavaScriptCore

Merge r82987.

3:43 PM Changeset in webkit [82993] by sfalken@apple.com
  • 5 edits in tags/Safari-534.27.1/Source

Versioning.

3:29 PM Changeset in webkit [82992] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Defer repaints during style recalc
https://bugs.webkit.org/show_bug.cgi?id=57886

Reviewed by Darin Adler.

This reduces the need to do (often expensive) platform surface invalidation.
We already do this during layout but style recalculation may trigger
invalidation as well.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

3:23 PM Changeset in webkit [82991] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-05 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

HTML5 Player Has no Fullscreen Mode
https://bugs.webkit.org/show_bug.cgi?id=57795

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API

supportsFullScreenForElement() before the old supportsFullScreenForNode() API.

3:10 PM Changeset in webkit [82990] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

3 tests fail on apple-macpro-6 (due to different JS MIME type) but not any other Leopard
slaves.
https://bugs.webkit.org/show_bug.cgi?id=56564

Skip fast/preloader/scan-body-from-head-script.html on Leopard to get the bots green.

  • platform/mac-leopard/Skipped:
3:07 PM Changeset in webkit [82989] by wjmaclean@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added wjmaclean@chromium.org to WebKit committers.

3:04 PM Changeset in webkit [82988] by kbalazs@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-05 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Darin Adler.

Build fix for YarrParser.h
https://bugs.webkit.org/show_bug.cgi?id=57822

  • yarr/YarrParser.h: (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
3:03 PM Changeset in webkit [82987] by sfalken@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Follow-up Windows build fix.
Don't skip react-to-vsprops-changes.py for all production builds,
only those initiated via JavaScriptCore.make.

3:01 PM Changeset in webkit [82986] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r82849): 85,000+ JSC-related leaks seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=57857

Whoops, accidentally removed a deref().

  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
2:59 PM Changeset in webkit [82985] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-05 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix data url's status and timing the network panel.
https://bugs.webkit.org/show_bug.cgi?id=53066

Added data url support for status of network resources.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isDataURL):
2:58 PM Changeset in webkit [82984] by sfalken@apple.com
  • 1 copy in tags/Safari-534.27.1

New tag.

2:53 PM Changeset in webkit [82983] by sfalken@apple.com
  • 3 edits
    7 adds in trunk/Source/JavaScriptCore

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add per-configuration vsprops files.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Removed inheritance from common.vsprops.

Set production environment variable before calling make.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops: Added.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops: Added.
2:25 PM Changeset in webkit [82982] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion failure when navigating quickly between file URLs
https://bugs.webkit.org/show_bug.cgi?id=57884
<rdar://problem/9080559>

Remove bogus assertion. The pending provisional sandbox extension can be
non-null if the current provisional load fails because we're about to load a new
page that also has a sandbox extension.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
2:20 PM Changeset in webkit [82981] by vitalyr@chromium.org
  • 4 edits in trunk

2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810

  • bindings/v8/V8GCController.cpp: (WebCore::GrouperVisitor::visitDOMWrapper):

2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810

  • platform/chromium/test_expectations.txt: Mark fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.
2:11 PM Changeset in webkit [82980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Grant the web process access to ~/Library/Preferences/com.apple.universalaccess.plist
https://bugs.webkit.org/show_bug.cgi?id=57879

The web process needs access to the unviersal access preferences to determine if full keyboard
access is enabled. I've filed <rdar://problem/9237619> which tracks reading this preference in the UI
process and sending it over to the web process whenever it changes.

  • WebProcess/com.apple.WebProcess.sb:
2:07 PM Changeset in webkit [82979] by bweinstein@apple.com
  • 4 edits in trunk/LayoutTests

[Windows] fast/blockflow/Kusa-Makura-background-canvas.html failing since introduction in r82903
https://bugs.webkit.org/show_bug.cgi?id=57880

Update Windows expected results (with pixel tests) to greenify the bots.

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
2:04 PM Changeset in webkit [82978] by morrita@google.com
  • 3 edits in trunk/Tools

2011-04-05 MORITA Hajime <morrita@google.com>

Reviewed by Adam Barth.

webkit-patch should print git's stderr when git svn dcommit fail
http://webkit.org/b/57861

  • Scripts/webkitpy/common/checkout/scm.py:
1:59 PM Changeset in webkit [82977] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows Tests] fast/dom/Window/window-property-descriptors.html failing since r82925.
https://bugs.webkit.org/show_bug.cgi?id=57881

Update the Windows-specific results to get the bots green.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

onformchange and onforminput were removed in r82925.

1:44 PM Changeset in webkit [82976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566

  • public/WebContextMenuData.h:
1:37 PM Changeset in webkit [82975] by tony@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2011-04-05 Tony Chang <tony@chromium.org>

Unreviewed, removing the chromium-win results causes this test to
start passing on chromium win and linux.

  • platform/chromium-win/fast/images/svg-as-tiled-background-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-as-tiled-background-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
1:34 PM Changeset in webkit [82974] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Add parentheses around && within
to avoid clang warning.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
1:26 PM Changeset in webkit [82973] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add two more entries to the sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=57875

Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition
ends up calling into ICU which accesses the dictionary.

Allow Mach access to com.apple.networkd since it's used by CFNetwork.

  • WebProcess/com.apple.WebProcess.sb:
1:03 PM Changeset in webkit [82972] by mihaip@chromium.org
  • 6 edits in trunk/Tools

2011-04-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Add --baseline-search-path to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56233

Add NRWT option to specify additional directories to look for baselines
(will be used by hardware GPU bots which will have local per-bot
expectations for some tests)

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:03 PM Changeset in webkit [82971] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

2011-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make caches window show more info about non-jsobject GC values
https://bugs.webkit.org/show_bug.cgi?id=57874

Add ClassInfo to the various internal JS types that currently
don't have any, and make the text for caches window show the
classname for non-JSObject instances.

  • runtime/Executable.cpp:
  • runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure): (JSC::NativeExecutable::NativeExecutable): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/Heap.cpp: (JSC::TypeCounter::typeName):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/ScopeChain.cpp:
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure):
  • runtime/StructureChain.cpp:
  • runtime/StructureChain.h: (JSC::StructureChain::createStructure):
1:02 PM Changeset in webkit [82970] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Invalidate callbacks if the WebPageProxy is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=57873
<rdar://problem/9059717>

Audit all function calls that take callbacks and make sure to invalidate the callbacks
if the web page is no longer valid.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInMainFrame): (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): (WebKit::WebPageProxy::getSourceForFrame): (WebKit::WebPageProxy::getContentsAsString): (WebKit::WebPageProxy::getSelectionOrContentsAsString): (WebKit::WebPageProxy::getMainResourceDataOfFrame): (WebKit::WebPageProxy::getResourceDataFromFrame): (WebKit::WebPageProxy::getWebArchiveOfFrame): (WebKit::WebPageProxy::forceRepaint): (WebKit::WebPageProxy::computePagesForPrinting): (WebKit::WebPageProxy::drawRectToPDF): (WebKit::WebPageProxy::drawPagesToPDF):
1:01 PM Changeset in webkit [82969] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-04 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Add a fast path for simple color backgrounds
https://bugs.webkit.org/show_bug.cgi?id=57773

Add a fast path for drawing simple color backgrounds. It's
faster to fill a path or rect than it is to set up a clip,
and then paint the rect.

No visible behavior change so no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
12:59 PM Changeset in webkit [82968] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-04-05 Patrick Gansterer <Patrick Gansterer>

Unreviewed EFL build fix for r82962.

  • CMakeListsEfl.txt:
12:39 PM Changeset in webkit [82967] by Adam Roben
  • 2 edits in trunk/Tools

Strip off /results.html from results URLs before trying to load leaks files from them

r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
files, rather than pointing to the directory that contains them. This is more convenient for
people browsing build.webkit.org, but confused Leaks Viewer.

Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
list don't work

Reviewed by Joseph Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.

12:33 PM Changeset in webkit [82966] by Adam Roben
  • 6 edits
    1 add in trunk/Source/WebKit2

Disable accelerated compositing on Windows machines that don't support it

This includes machines without the necessary graphics hardware, and machines without
WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots).

Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in
DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests)

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than
Windows, this always returns true.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related
preferences if the machine supports accelerated compositing.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it
if it can draw, and returns the result.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing.
  • WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added.

(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to
LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false.

  • win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files.
12:18 PM Changeset in webkit [82965] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-05 David Levin <levin@chromium.org>

Reviewed by Jian Li.

[chromium] send-sliced-dragged-file.html started to crash on chromium bots
https://bugs.webkit.org/show_bug.cgi?id=57539

  • platform/chromium/test_expectations.txt: Removed passing test as it has been fixed in the chromium network stack as of chromium r80114 and it was introduced in r79905 so no need to change the chromium deps since it is before the regression.
12:17 PM Changeset in webkit [82964] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, mark unexpectedly passing Linux Chromium tests as such.

  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [82963] by crogers@google.com
  • 22 edits
    7 adds in trunk/Source/WebCore

2011-04-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add support for offline audio rendering to AudioContext API
https://bugs.webkit.org/show_bug.cgi?id=57676

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::constructorCallback):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isOfflineAudioCompletionEvent):
  • dom/Event.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toAudioContext):
  • dom/EventTarget.h:
  • platform/audio/HRTFDatabaseLoader.cpp: (WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
  • platform/audio/HRTFDatabaseLoader.h: (WebCore::HRTFDatabaseLoader::loader):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createOfflineContext): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::constructCommon): (WebCore::AudioContext::document): (WebCore::AudioContext::scriptExecutionContext): (WebCore::AudioContext::toAudioContext): (WebCore::AudioContext::startRendering): (WebCore::AudioContext::fireCompletionEvent):
  • webaudio/AudioContext.h: (WebCore::AudioContext::isOfflineContext): (WebCore::AudioContext::eventTargetData): (WebCore::AudioContext::ensureEventTargetData): (WebCore::AudioContext::refEventTarget): (WebCore::AudioContext::derefEventTarget):
  • webaudio/AudioContext.idl:
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::AudioDestinationNode):
  • webaudio/AudioDestinationNode.h: (WebCore::AudioDestinationNode::reset): (WebCore::AudioDestinationNode::numberOfChannels):
  • webaudio/ConvolverNode.cpp: (WebCore::ConvolverNode::setBuffer):
  • webaudio/DefaultAudioDestinationNode.cpp: Added. (WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode): (WebCore::DefaultAudioDestinationNode::initialize): (WebCore::DefaultAudioDestinationNode::uninitialize): (WebCore::DefaultAudioDestinationNode::startRendering):
  • webaudio/DefaultAudioDestinationNode.h: Added. (WebCore::DefaultAudioDestinationNode::create): (WebCore::DefaultAudioDestinationNode::sampleRate):
  • webaudio/OfflineAudioCompletionEvent.cpp: Added. (WebCore::OfflineAudioCompletionEvent::create): (WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent): (WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent):
  • webaudio/OfflineAudioCompletionEvent.h: Added. (WebCore::OfflineAudioCompletionEvent::renderedBuffer):
  • webaudio/OfflineAudioCompletionEvent.idl: Added.
  • webaudio/OfflineAudioDestinationNode.cpp: Added. (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode): (WebCore::OfflineAudioDestinationNode::initialize): (WebCore::OfflineAudioDestinationNode::uninitialize): (WebCore::OfflineAudioDestinationNode::startRendering): (WebCore::OfflineAudioDestinationNode::renderEntry): (WebCore::OfflineAudioDestinationNode::render): (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch): (WebCore::OfflineAudioDestinationNode::notifyComplete):
  • webaudio/OfflineAudioDestinationNode.h: Added. (WebCore::OfflineAudioDestinationNode::create): (WebCore::OfflineAudioDestinationNode::sampleRate):
11:40 AM Changeset in webkit [82962] by Martin Robinson
  • 28 edits
    2 copies in trunk/Source

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

No new tests. This patch is only a code cleanup.

  • GNUmakefile.am:
  • platform/graphics/GraphicsContext.h: The platform context is no longer a cairo_t, but our new class the PlatformContextCairo.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
  • platform/graphics/cairo/FontCairo.cpp: Ditto.
  • platform/graphics/cairo/GradientCairo.cpp: Ditto.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical changes which now reference platformContext()->cr() to get the cairo_t.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the PlatformContextCairo instead of the cairo_t.
  • platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/PathCairo.cpp: Ditto.
  • platform/graphics/cairo/PlatformContextCairo.cpp: Added.
  • platform/graphics/cairo/PlatformContextCairo.h: Added.
  • platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
  • platform/graphics/gtk/IconGtk.cpp: Ditto.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out m_data with a private section containing the platform context instead of just a cairo_t.
  • platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: Ditto.

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.

  • webkit/webkitwebframe.cpp: (draw_page_callback):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw):

2011-04-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

  • WebFrame.cpp: (hdcFromContext): Modify this method to take PlatformContextCairo instead of a cairo_t. (WebFrame::spoolPage): Update to reflect new platform context. (WebFrame::spoolPages): Ditto.
  • WebFrame.h: Ditto.
11:36 AM Changeset in webkit [82961] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, mark some unexpectedly passing Chromium tests as such.

  • platform/chromium/test_expectations.txt:
11:01 AM Changeset in webkit [82960] by Adam Roben
  • 8 edits in trunk/Source/WebKit2

Make accelerated compositing work in WebKit2 on Windows

LayerTreeHostCAWin uses WKCACFView to render each frame to an image, then has
DrawingAreaImpl send that image over to the UI process (just like it does for
non-accelerated rendering). It's unfortunate that this requires reading every frame back
from the GPU into system memory. More efficient solutions can be explored in the future.

Fixes <http://webkit.org/b/45567>.

Reviewed by Anders Carlsson.

  • DerivedSources.make: Added $(WebKit2) to the VPATH so that DerivedSources.make can be

found when used as a target dependency. Added rules to generate a HeaderDetection.h file on
Windows. If we can find WebKitQuartzCoreAdditions headers, we define HAVE_WKQCA in
HeaderDetection.h.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostNeedsDisplay):

  • WebProcess/WebPage/DrawingAreaImpl.h:

Added setLayerHostNeedsDisplay. Lets the layer host tell the DrawingAreaImpl that it has a
new frame to render. This should only be called by layer hosts that participate in
DrawingAreaImpl's display mechanism.

  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create): Only try to instantiate LayerTreeHostCAWin if we have
WebKitQuartzCoreAdditions, since it depends on that library.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Removed code that forced accelerated compositing to be
disabled on Windows.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::registerDummyWindowClass): Registers the window class we use for the dummy window.
(WebKit::createDummyWindow): Creates the dummy window we pass to WKCACFView so that D3D can
determine the display mode, etc. (The window is never shown on screen.)
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Initialize new members.
(WebKit::LayerTreeHostCAWin::platformInitialize): Create our dummy window and view and
associate the two. We set ourselves as the view's context's user data so that
PlatformCALayer can get our AbstractCACFLayerTreeHost pointer as needed.
(WebKit::LayerTreeHostCAWin::invalidate): Cancel any pending flushes, tear down our view,
and destroy the dummy window if no other layer host is using it.
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Ask LayerChangesFlusher to call us back
soon to perform the flush.
(WebKit::LayerTreeHostCAWin::participatesInDisplay): Added. Returns true, since we render
each frame to an image.
(WebKit::LayerTreeHostCAWin::needsDisplay): Added. Returns true if it's now time to
displayReturns true if it's now time to display.
(WebKit::LayerTreeHostCAWin::timeUntilNextDisplay): Added. Returns how many seconds remain
before we need to display again.
(WebKit::size): Added. Helper function to get the size of a WKCACFImage.
(WebKit::toShareableBitmap): Added. Helper function to convert a WKCACFImage to a
ShareableBitmap.
(WebKit::LayerTreeHostCAWin::display): Added. Renders the next frame to an image and stuffs
the image into the UpdateInfo struct.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Added. Tells the view about the new size.
(WebKit::LayerTreeHostCAWin::forceRepaint): Added. Flushes any pending changes to the view.
(WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Added. WKCACFView calls this
whenever any changes made to the view or its layer tree have been flushed. Just calls
through to contextDidChange.
(WebKit::LayerTreeHostCAWin::contextDidChange): Added. Tells layers that they've started
animating, and tells the DrawingAreaImpl that we need to display again.
(WebKit::LayerTreeHostCAWin::rootLayer): Added. Gets the root layer's PlatformCALayer.
(WebKit::LayerTreeHostCAWin::addPendingAnimatedLayer): Added. Stores the layer so that we
can tell it animations have started the next time we get a contextDidChange callback.
(WebKit::LayerTreeHostCAWin::layerTreeDidChange): Added. Schedules a flush, unless we're
already in the process of flushing. This code came from WebCore::WKCACFViewLayerTreeHost.
(WebKit::LayerTreeHostCAWin::flushPendingLayerChangesNow): Added. Performs the flush. This
code was adapted from WebCore::WKCACFViewLayerTreeHost.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Wrapped this whole header in HAVE(WKQCA),

since this class only works when WebKitQuartzCoreAdditions is available. Added a bunch of
new members.

11:01 AM Changeset in webkit [82959] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Add a way for LayerTreeHost to participate in DrawingAreaImpl's normal display mechanism

When LayerTreeHost participates in display, it renders each frame into a bitmap.
DrawingAreaImpl sends the bitmap to the UI process in an Update message, just like in
non-accelerated compositing mode. The UI process never knows that accelerated compositing is
going on. (When LayerTreeHost does not participate in display, as on Mac, it is responsible
for getting bits from the web process to the UI process.)

No LayerTreeHost uses this mechanism (yet). This patch should cause no change in behavior.

Fixes <http://webkit.org/b/57792> LayerTreeHost needs a way to render frames to a bitmap

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): If the layer tree host participates in display,
perform a display (like in the non-accelerated case).
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): Don't send an
EnterAcceleratedCompositing message to the UI process if the layer tree host participates in
display. In that case, the UI process doesn't even need to know we're using accelerated
compositing in the web process.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Go through the normal display
mechanism if we have a layer tree host that participates in display.
(WebKit::DrawingAreaImpl::didUpdate): Don't ignore DidUpdate messages when we have a layer
tree host that participates in display.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): If the new layer tree host
participates in display, let the display timer continue to run and continue to expect
DidUpdate messages so that we don't interrupt the normal display mechanism. We still clear
out m_dirtyRegion, m_scrollRect, and m_scrollOffset, though, because the layer tree host is
still responsible for keeping track of those things even when it participates in display.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): If the outgoing layer tree host
was participating in display, just send another Update message instead of an
ExitAcceleratedCompositing message, since the UI process never even knew we were using
accelerated compositing.
(WebKit::DrawingAreaImpl::displayTimerFired): If we have a layer tree host that's
participating in display, ask it when it next needs to display when scheduling our timer.

(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
If we have a layer tree host that's participating in display, it will keep track of its own
dirty region, so ask it if it needs display rather than checking our own dirty region.

(WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in
display, don't bail out. Instead, tell it to display rather than asking the page to paint.
Moved the setting of updateInfo.viewSize earlier so that it will be set even when the layer
tree host is displaying. Other changes are just due to indentation.

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::participatesInDisplay):
(WebKit::LayerTreeHost::needsDisplay):
(WebKit::LayerTreeHost::timeUntilNextDisplay):
(WebKit::LayerTreeHost::display):
Stubbed out these functions. Derived classes can override them to participate in display.

10:49 AM Changeset in webkit [82958] by carol@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed.

Updated my info in committers.py

Scripts\webkitpy\common\config\committers.py

10:47 AM Changeset in webkit [82957] by carol@webkit.org
  • 2 edits in trunk/Tools

Unreviewed.

Updated my info in committers.py

Scripts\webkitpy\common\config\committers.py

10:40 AM Changeset in webkit [82956] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 David Dorwin <ddorwin@chromium.org>

Reviewed by David Levin.

Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=57400

Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid.
Accelerated compositing may be compiled in but disabled at runtime or for some elements.

Tests: Fullscreen layout tests on Chromium.

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): (WebCore::Document::webkitDidEnterFullScreenForElement): (WebCore::Document::webkitWillExitFullScreenForElement):
10:34 AM Changeset in webkit [82955] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-05 Adrienne Walker <enne@google.com>

Unreviewed, temporarily suppress Chromium failures for tests in r82947.

  • platform/chromium/test_expectations.txt:
10:32 AM Changeset in webkit [82954] by yurys@chromium.org
  • 1 edit
    8 adds in trunk/Websites/webkit.org

2011-04-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add Web Inspector stack trace, pause on exception and window.onerror
screenshots.

  • blog-files/inspector/stack-traces-img/1.png: Added.
  • blog-files/inspector/stack-traces-img/2.png: Added.
  • blog-files/inspector/stack-traces-img/3.png: Added.
  • blog-files/inspector/stack-traces-img/4.png: Added.
  • blog-files/inspector/stack-traces-img/5.png: Added.
  • blog-files/inspector/stack-traces-img/6.png: Added.
  • blog-files/inspector/stack-traces-img/button.png: Added.
10:28 AM Changeset in webkit [82953] by Nikolas Zimmermann
  • 3 edits
    2 adds in trunk

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721

  • svg/text/font-size-null-assertion-expected.txt: Added.
  • svg/text/font-size-null-assertion.svg: Added.

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721

Properly stop layout if all metrics object refer to zero-width/height characters,
which can happen for instance when using <text font-size="0">.

Test: svg/text/font-size-null-assertion.svg

  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): (WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
10:23 AM Changeset in webkit [82952] by morrita@google.com
  • 35 edits in trunk/Source

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
This change also added TextCheckerClient::requestCheckingOfString() should have
TextCheckingTypeMask as a parameter to control text checking type.

  • WebCore.exp.in:
  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::requestCheckingFor): Added a parameter. (WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object. (WebCore::SpellChecker::didCheck):
  • editing/SpellChecker.h:
  • loader/EmptyClients.h: (WebCore::EmptyTextCheckerClient::checkTextOfParagraph): (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
  • platform/text/TextCheckerClient.h:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Followed the signature change.

  • src/EditorClientImpl.h:
  • src/EditorClientImpl.cpp:
  • src/WebTextCheckingCompletionImpl.cpp

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/TextCheckerClientEnchant.h: (WebKit::TextCheckerClientEnchant::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
for requestCheckingOfString method.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (toCoreTextCheckingResults): (WebEditorClient::checkTextOfParagraph): (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]): (-[WebEditorSpellCheckResponder perform]): (WebEditorClient::requestCheckingOfString):
  • WebView/WebFrame.mm: (-[WebFrame markersForSelectionStartAsText]):
  • WebView/WebFramePrivate.h:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClientWinCE::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::requestCheckingOfString):

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::requestCheckingOfString):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::checkTextOfParagraph):
10:20 AM Changeset in webkit [82951] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Print stylesheet on nytimes.com loads too early
https://bugs.webkit.org/show_bug.cgi?id=57814

Reviewed by Sam Weinig.

Don't load resources with Very Low priority until there are no other resources to
load for the host (or until document is complete enough that we stop limiting requests).

No tests, this is difficult to observe reliably with our current testing infrastructure.
Verified working with Wireshark.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):

  • loader/ResourceLoadScheduler.h:
10:11 AM Changeset in webkit [82950] by steveblock@google.com
  • 6 edits
    1 copy
    1 move in trunk/Source/WebCore

2011-04-04 Steve Block <steveblock@google.com>

Reviewed by Dimitri Glazkov.

JavaInstance should be a pure interface
https://bugs.webkit.org/show_bug.cgi?id=55383

This patch fixes JavaInstance for V8 only.

It factors out a JavaInstance interface which does not use JNI
types. This will allow the Java bridge to be used with objects
that don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaInstanceJobject class which
implements the interface.

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/JobjectWrapper.h:
  • bridge/jni/v8/JNIUtilityPrivate.cpp: (JSC::Bindings::jvalueToJavaValue): (JSC::Bindings::javaValueToJvalue):
  • bridge/jni/v8/JavaInstanceJobjectV8.cpp: (JavaInstanceJobject::JavaInstanceJobject): (JavaInstanceJobject::~JavaInstanceJobject): (JavaInstanceJobject::begin): (JavaInstanceJobject::end): (JavaInstanceJobject::getClass): (JavaInstanceJobject::invokeMethod): (JavaInstanceJobject::getField):
  • bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h. (JSC::Bindings::JavaInstanceJobject::javaInstance):
  • bridge/jni/v8/JavaInstanceV8.h: (JSC::Bindings::JavaInstance::~JavaInstance):
10:10 AM Changeset in webkit [82949] by podivilov@chromium.org
  • 1 edit in branches/chromium/696/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 80710 - 2011-03-09 Alexander Pavlov <apavlov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren https://bugs.webkit.org/show_bug.cgi?id=56002 * inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6793043

10:01 AM Changeset in webkit [82948] by Dimitri Glazkov
  • 6 edits in trunk/Source/WebCore

2011-04-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57639

Refactoring, covered by existing tests.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here

from dispatchMouseEvent.

(WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method.

  • dom/EventDispatcher.h: Adjusted decls. (WebCore::EventDispatcher::node): Added.
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::create): Moved useful assertion here from

dispatchMouseEvent.

(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added.
(WebCore::MouseEventDispatchMediator::event): Added.
(WebCore::MouseEventDispatchMediator::dispatchEvent): Added.

  • dom/MouseEvent.h: (WebCore::MouseEvent::setRelatedTarget): Added.
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator.
9:38 AM Changeset in webkit [82947] by Nikolas Zimmermann
  • 7 edits
    8 adds in trunk

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831

Add text-tspan-02-b.svg from SVG 1.1 2nd edition, which was buggy.
Add reduced testcase, which exposes a bug with midpoint splitting, which is now fixed.

  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/mac/svg/text/text-midpoint-split-bug-expected.checksum: Added.
  • platform/mac/svg/text/text-midpoint-split-bug-expected.png: Added.
  • platform/mac/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg: Added.
  • svg/text/text-midpoint-split-bug.svg: Added.

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831

We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering.
While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and
should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler
to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the
required memory.

Example:
<text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text>


text: A B C D E F G H
rotate="10 20 30 30 30 50 50 50"

Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg

svg/text/text-midpoint-split-bug.svg

  • rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an (WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase.
  • rendering/svg/SVGTextLayoutAttributes.cpp: (WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization). (WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder. (WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto. (WebCore::safeValueAtPosition): Ditto. (Inline helper) (WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto.
  • rendering/svg/SVGTextLayoutAttributes.h: Ditto.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above. (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): (WebCore::processRenderSVGInlineText): (WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements): (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters): (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): (WebCore::fillListAtPosition): (WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition):
  • rendering/svg/SVGTextLayoutAttributesBuilder.h: (WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition):
9:34 AM Changeset in webkit [82946] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

DeleteButtonController is given invalid style
https://bugs.webkit.org/show_bug.cgi?id=57853

DeleteButtonController was assigned an invalid style that can lead to assertions
in debug builds. This matches up the code with its intent.

No new tests as this changes nothing on release builds.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
9:22 AM Changeset in webkit [82945] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Didn't mean to land this.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:value:]):

9:18 AM Changeset in webkit [82944] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] EditorQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40260

This patch does not require new test cases.

  • editing/qt/EditorQt.cpp:
8:55 AM Changeset in webkit [82943] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: go to line dialog highlights wrong line.
https://bugs.webkit.org/show_bug.cgi?id=57845

  • inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
8:36 AM Changeset in webkit [82942] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-05 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement CSSPropertyDirection in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=57608

No new tests required as no new functionality introduced.

  • css/CSSStyleApplyProperty.cpp: Add implementation class for CSSPropertyDirection
  • css/CSSStyleSelector.cpp: Remove existing implementation for CSSPropertyDirection
  • css/CSSStyleSelector.h: Add getter for element
8:21 AM Changeset in webkit [82941] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

Unreviewed. Update Qt specific expected results after r82925.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
8:10 AM Changeset in webkit [82940] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Steve Block.

Factoring the creation of 'FunctionOnly' callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=57760

This method creates a template from an existing functionality in V8GeolocationCustom.cpp
to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.

No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

  • bindings/v8/V8Utilities.cpp: (WebCore::throwTypeMismatchException):
  • bindings/v8/V8Utilities.h: (WebCore::createFunctionOnlyCallback):
  • bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):
8:07 AM Changeset in webkit [82939] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-04-05 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Laszlo Gombos.

[Qt] Make WebKitLibraries optional for building QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=57542

  • Scripts/build-webkit:
7:48 AM Changeset in webkit [82938] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-05 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MiniBrowser defaultUrl does not work
https://bugs.webkit.org/show_bug.cgi?id=57021

Match the behavior and coding of MiniBrowser to QtTestBrowser.

  • MiniBrowser/qt/main.cpp: (main):
7:23 AM Changeset in webkit [82937] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2011-04-05 Chang Shu <cshu@webkit.org>

Unreviewed.

Unskip passed tests after bugs 57572, 57568, 42540, 42692 have been resolved.

  • platform/qt-wk2/Skipped:
6:40 AM Changeset in webkit [82936] by alex
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Alejandro G. Castro <alex@igalia.com>

Another compilation fix after r82929 horrible patch merge.

  • UIProcess/WebPageProxy.messages.in:
6:39 AM Changeset in webkit [82935] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Switch from Vector<UChar> to StringBuilder in bindings/
https://bugs.webkit.org/show_bug.cgi?id=57838

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyInfo):
6:38 AM Changeset in webkit [82934] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Switch from Vector<UChar> to StringBuilder in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=57837

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition): (WebCore::AccessibilityObject::stringForVisiblePositionRange):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
6:26 AM Changeset in webkit [82933] by alex
  • 2 edits in trunk/Source/WebKit2

2011-04-05 Alejandro G. Castro <alex@igalia.com>

Fix compilation error after r82929.

  • WebProcess/WebPage/WebPage.h:
6:24 AM Changeset in webkit [82932] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Scripts with syntax errors are cropped in the UI
https://bugs.webkit.org/show_bug.cgi?id=57828

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessageToSource):
6:08 AM Changeset in webkit [82931] by Nikolas Zimmermann
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Cleanup StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=57836

Don't use PassRefPtr in local variables, properly store in RefPtrs and release on return.
Add a makeString() variant taking 9 arguments, needed by a follow-up patch.

  • wtf/text/StringConcatenate.h: (WTF::tryMakeString): (WTF::makeString):
6:07 AM Changeset in webkit [82930] by Laszlo Gombos
  • 2 edits in trunk/Tools

2011-04-05 Jade Han <jade.han@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Disable WebKitTestRunner for Symbian
https://bugs.webkit.org/show_bug.cgi?id=54977

This change is a preparation to enable building webkit2 for Symbian.
Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.

  • Tools.pro:
5:54 AM Changeset in webkit [82929] by alex
  • 13 edits
    2 adds in trunk/Source/WebKit2

2011-04-05 Amruth Raj <amruthraj@motorola.com>, Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230

Added functions to handle the generation of commands from the
keycodes.

  • GNUmakefile.am:
  • Scripts/webkit2/messages.py:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
  • UIProcess/gtk/WebView.cpp: (WebKit::backspaceCallback): (WebKit::selectAllCallback): (WebKit::cutClipboardCallback): (WebKit::copyClipboardCallback): (WebKit::pasteClipboardCallback): (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::deleteFromCursorCallback): (WebKit::moveCursorCallback): (WebKit::WebView::WebView): (WebKit::WebView::getEditorCommandsForKeyEvent):
  • UIProcess/gtk/WebView.h: (WebKit::WebView::addPendingEditorCommand):
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Added. (WebKit::WebEditorClient::getEditorCommandsForKeyEvent): (WebKit::WebEditorClient::executePendingEditorCommands): (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest):
5:52 AM Changeset in webkit [82928] by podivilov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add chromium-linux expectation for fast/ruby/overhang-vertical.html (the test changed in r82903).

  • platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Added.
5:43 AM Changeset in webkit [82927] by zoltan@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
https://bugs.webkit.org/show_bug.cgi?id=57832

Reviewed by Andreas Kling.

Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.

  • MiniBrowser/qt/UrlLoader.cpp:

(UrlLoader::UrlLoader):

5:04 AM Changeset in webkit [82926] by podivilov@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, revert bad rebaseline of english-lr-text-expected.html in r82918.

  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
4:45 AM Changeset in webkit [82925] by ap@apple.com
  • 26 edits
    6 deletes in trunk

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/forms/formchange-event-expected.txt: Removed.
  • fast/forms/formchange-event.html: Removed.
  • fast/forms/forminput-event-expected.txt: Removed.
  • fast/forms/forminput-event.html: Removed.
  • fast/forms/script-tests/formchange-event.js: Removed.
  • fast/forms/script-tests/forminput-event.js: Removed.

2011-04-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>

Covered by existing tests.

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp: (WebCore::Event::fromUserGesture):
  • dom/EventNames.h:
  • html/FormAssociatedElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLElement.h:
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::isEnumeratable):
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • html/HTMLInputElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::isEnumeratable):
  • html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::isEnumeratable):
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isEnumeratable):
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::isEnumeratable):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
4:28 AM Changeset in webkit [82924] by podivilov@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline Kusa-Makura-background-canvas.html on chromium-mac after r82903.

  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
4:08 AM Changeset in webkit [82923] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82915.
http://trac.webkit.org/changeset/82915
https://bugs.webkit.org/show_bug.cgi?id=57825

Broke 270 chromium tests on win and linux (Requested by
podivilov on #webkit).

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
4:07 AM Changeset in webkit [82922] by zoltan@webkit.org
  • 3 edits in trunk/Tools

2011-04-05 Zoltan Horvath <zoltan@webkit.org>

[Qt] Linux Release minimal build fix after r82919.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::loadURLListFromFile):
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::loadURLListFromFile):
3:58 AM Changeset in webkit [82921] by podivilov@chromium.org
  • 2 edits
    14 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove unnecessary checksum files for fast/ruby tests.

  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-length-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-runs-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/ruby-trailing-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
3:35 AM Changeset in webkit [82920] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/ruby/overhang* tests fail
https://bugs.webkit.org/show_bug.cgi?id=57824

  • platform/qt/Skipped:Add fast/ruby/overhang-horizontal.html and fast/ruby/overhang-vertical.html.
3:35 AM Changeset in webkit [82919] by zoltan@webkit.org
  • 5 edits in trunk/Tools

2011-04-05 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Andreas Kling.

[Qt] Make URL loader accessible from testbrowser's menus
https://bugs.webkit.org/show_bug.cgi?id=57823

Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadURLListFromFile): (BrowserWindow::~BrowserWindow):
  • MiniBrowser/qt/BrowserWindow.h:
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::loadURLListFromFile):
  • QtTestBrowser/launcherwindow.h:
3:26 AM Changeset in webkit [82918] by podivilov@chromium.org
  • 41 edits
    15 adds
    14 deletes in trunk/LayoutTests

2011-04-05 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update fast/ruby/* chromium expectations after r82903.

  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-length-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-runs-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-trailing-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/chromium-mac/fast/ruby/ruby-length-expected.png: Added.
  • platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Added.
  • platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Removed.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
  • platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png:
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-length-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-length-expected.png:
  • platform/chromium-win/fast/ruby/ruby-length-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-runs-expected.png:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.png:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-trailing-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/ruby-trailing-expected.png:
  • platform/chromium-win/fast/ruby/ruby-trailing-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
  • platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.txt:
2:38 AM Changeset in webkit [82917] by hans@chromium.org
  • 36 edits
    3 moves
    1 add
    1 delete in trunk/Source/WebKit/chromium

2011-04-05 Hans Wennborg <hans@chromium.org>

Reviewed by Adam Barth

Clean up IndexedDB WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57507

Rename the backend proxy files that didn't have Backend in their name.
Everything in WebKit should be in the WebKit namespace.
Put everything behind the feature flag so we're consistient.
Put the feature flag #if above includes.

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebKit::IDBCallbacksProxy::create): (WebKit::IDBCallbacksProxy::IDBCallbacksProxy): (WebKit::IDBCallbacksProxy::onError): (WebKit::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: (WebKit::IDBCursorBackendProxy::create): (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::create): (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::name): (WebKit::IDBDatabaseBackendProxy::version): (WebKit::IDBDatabaseBackendProxy::objectStoreNames): (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit::IDBDatabaseBackendProxy::setVersion): (WebKit::IDBDatabaseBackendProxy::transaction): (WebKit::IDBDatabaseBackendProxy::close): (WebKit::IDBDatabaseBackendProxy::open):
  • src/IDBDatabaseCallbacksProxy.cpp: (WebKit::IDBDatabaseCallbacksProxy::create): (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
  • src/IDBDatabaseCallbacksProxy.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebKit::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebKit::IDBIndexBackendProxy::create): (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::create): (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::name): (WebKit::IDBObjectStoreBackendProxy::keyPath): (WebKit::IDBObjectStoreBackendProxy::indexNames): (WebKit::IDBObjectStoreBackendProxy::get): (WebKit::IDBObjectStoreBackendProxy::put): (WebKit::IDBObjectStoreBackendProxy::deleteFunction): (WebKit::IDBObjectStoreBackendProxy::clear): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): (WebKit::IDBObjectStoreBackendProxy::openCursor):
  • src/IDBObjectStoreBackendProxy.h: Added.
  • src/IDBObjectStoreProxy.h: Removed.
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::create): (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h: (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::create): (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onError): (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
  • src/WebIDBKeyRange.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
2:27 AM Changeset in webkit [82916] by simonjam@chromium.org
  • 6 edits in trunk

2011-04-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Stop preload scanning CSS when it&apos;s impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664

  • fast/preloader/style-expected.txt:
  • fast/preloader/style.html: Updated to test invalid @import statements.

2011-04-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Stop preload scanning CSS when it&apos;s impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664

@import statements are only allowed at the beginning of a CSS file.
Only comments or @charset can precede them. After seeing anything else,
abort early so that we:

  • don't have to parse the rest of the CSS.
  • don't preload something that the regular parser won't load.
  • html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports. (WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule. (WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
  • html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.
2:17 AM Changeset in webkit [82915] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-05 Takayoshi Kochi <kochi@chromium.org>

Reviewed by Tony Chang.

[chromium] Specify 'sans-serif' as a fallback to the default UI font
'Arial' for non-latin UI scripts (e.g. CJK).
https://bugs.webkit.org/show_bug.cgi?id=55035

No new tests, because it may still fail if the system is not configured
properly to resolve 'sans-serif' to existing real font file, thus even
manual test is hard to systematically tell it is working properly.

  • rendering/RenderThemeChromiumSkia.cpp
2:06 AM Changeset in webkit [82914] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 Sailesh Agrawal <sail@chromium.org>

Reviewed by Darin Fisher.

Don't clear existing files if the user cancels the file chooser dialog.
https://bugs.webkit.org/show_bug.cgi?id=55200

  • src/WebFileChooserCompletionImpl.cpp: (WebKit::WebFileChooserCompletionImpl::didChooseFile):
1:41 AM Changeset in webkit [82913] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-05 Kent Tamura <tkent@chromium.org>

Update a test affected by the behavior change of r82908.
https://bugs.webkit.org/show_bug.cgi?id=57636

  • fast/forms/ValidityState-tooLong-textarea-expected.txt:
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js:
1:12 AM Changeset in webkit [82912] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 John Mellor <johnme@chromium.org>

Reviewed by Darin Fisher.

[chromium] Minor cleanup: simplify WebFrameImpl by using contentsToWindow instead of convertToContainingWindow.
https://bugs.webkit.org/show_bug.cgi?id=55681

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::scopeStringMatches):
1:07 AM Changeset in webkit [82911] by Philippe Normand
  • 15 edits in trunk/LayoutTests

2011-04-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r82903.

  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/gtk/fast/ruby/ruby-length-expected.txt:
  • platform/gtk/fast/ruby/ruby-run-break-expected.txt:
  • platform/gtk/fast/ruby/ruby-runs-expected.txt:
  • platform/gtk/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/gtk/fast/ruby/ruby-trailing-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/gtk/fast/ruby/rubyDOM-remove-text1-expected.txt:
12:53 AM Changeset in webkit [82910] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-05 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS: Rolled!
12:30 AM Changeset in webkit [82909] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-05 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Alexey Proskuryakov.

Improper use of &quot in video-can-play-type layout test
https://bugs.webkit.org/show_bug.cgi?id=57728

  • media/video-can-play-type.html:
12:27 AM Changeset in webkit [82908] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636

  • fast/forms/textarea-set-defaultvalue-after-value-expected.txt: Added.
  • fast/forms/textarea-set-defaultvalue-after-value.html: Added.

2011-04-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636

If the dirty flag is true, we shouldn't update the value when the
defaultValue is updated

Test: fast/forms/textarea-set-defaultvalue-after-value.html

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged): (WebCore::HTMLTextAreaElement::setDefaultValue):
12:25 AM Changeset in webkit [82907] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815

Unreviewed buildfix after r82906.

Add UNUSED_PARAM to resourceCachesToClear, because
it is only used within #if USE(CFURLCACHE) guard.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

Apr 4, 2011:

10:38 PM Changeset in webkit [82906] by weinig@apple.com
  • 22 edits
    1 delete in trunk

Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815

Reviewed by Brian Weinstein.

Source/WebKit2:

  • Remove WKContextClearResourceCaches and WKContextClearApplicationCache in favor of their more modern counterparts WKResourceCacheManagerClearCacheForAllOrigins and WKApplicationCacheManagerDeleteAllEntries.
  • Expand clearing functionality of WKResourceCacheManager by adding type of resources to clear.
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Remove clearing bools.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toResourceCachesToClear):
Update for new name of enum.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:

Remove WKContextClearResourceCaches and WKContextClearApplicationCache.

  • UIProcess/API/C/WKResourceCacheManager.cpp:

(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):

  • UIProcess/API/C/WKResourceCacheManager.h:

Add WKResourceCachesToClear enum and use it in the clearing functions.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.messages.in:

Remove clearing functions and setting of bools for clear on launch.

  • UIProcess/WebFullScreenManagerProxy.cpp:

Remove unnecessary #include.

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.messages.in:

Add enum parameter describing what type of caches to clear.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearResourceCaches):

  • WebProcess/WebProcess.h:

No longer need to use opaque type now that it is not a message receiver.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.

10:33 PM Changeset in webkit [82905] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

2011-04-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82876.
http://trac.webkit.org/changeset/82876
https://bugs.webkit.org/show_bug.cgi?id=57816

Caused a lot of test crashes (Requested by tkent on #webkit).

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::fastMallocMatchValidationValue): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree):
  • wtf/Platform.h:
10:26 PM Changeset in webkit [82904] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Kent Tamura <tkent@chromium.org>

Add a case label which was unexpectedly removed in r82899.
https://bugs.webkit.org/show_bug.cgi?id=50661

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
10:21 PM Changeset in webkit [82903] by mitz@apple.com
  • 50 edits
    8 adds in trunk

<rdar://problem/7709452> Implement Default Ruby Overhang Behavior
https://bugs.webkit.org/show_bug.cgi?id=49334

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal.html

fast/ruby/overhang-vertical.html

This is a first cut at ruby overhang. It allows ruby text to hang over other
text of equal or smaller size. Two notable omissions are that max preferred
width computation was not patched, so it will overshoot, and that overhang
ignores the width of the adjoining text runs.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
of ruby runs for overhang.
(WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
compensate for overhang.
(WebCore::RenderBlock::findNextLineBreak): When encountering
a ruby run, increase the line width to account for the fact that overhang will be
collapsed.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
the adjoining renderer is text with equal or smaller font size.

  • rendering/RenderRubyRun.h:

(WebCore::toRenderRubyRun):

LayoutTests:

  • fast/ruby/overhang-horizontal-expected.checksum: Added.
  • fast/ruby/overhang-horizontal-expected.png: Added.
  • fast/ruby/overhang-horizontal-expected.txt: Added.
  • fast/ruby/overhang-horizontal.html: Added.
  • fast/ruby/overhang-vertical-expected.checksum: Added.
  • fast/ruby/overhang-vertical-expected.png: Added.
  • fast/ruby/overhang-vertical-expected.txt: Added.
  • fast/ruby/overhang-vertical.html: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/english-lr-text-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.png:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/mac/fast/ruby/ruby-length-expected.checksum:
  • platform/mac/fast/ruby/ruby-length-expected.png:
  • platform/mac/fast/ruby/ruby-length-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac/fast/ruby/ruby-run-break-expected.png:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-expected.png:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum:
  • platform/mac/fast/ruby/ruby-trailing-expected.png:
  • platform/mac/fast/ruby/ruby-trailing-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
9:58 PM Changeset in webkit [82902] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, Chromium expectations update for tests broken after r82899.

  • platform/chromium/test_expectations.txt:
9:41 PM Changeset in webkit [82901] by morrita@google.com
  • 8 edits in trunk/LayoutTests

2011-04-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update following r82899.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
9:37 PM Changeset in webkit [82900] by ddkilzer@apple.com
  • 15 edits in trunk

<http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
  • platform/mac/WebCoreSystemInterface.h:

(wkSetHTTPPipeliningMaximumPriority): Added function pointer
declaration.

  • platform/mac/WebCoreSystemInterface.mm:

(wkSetHTTPPipeliningMaximumPriority): Added function pointer.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
pipelining priority.

  • platform/network/cf/ResourceRequestCFNet.h:

(WebCore::toResourceLoadPriority): Renamed from
mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to
to handle Unresolved case.
(WebCore::toHTTPPipeliningPriority): Renamed from
mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to
handle Unresolved case.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use toResourceLoadPriority().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
use toHTTPPipeliningPriority(). Moved
shouldForceHTTPPipeliningPriorityHigh() check into the argument
of toHTTPPipeliningPriority() instead of hard-coding a
now-incorrect value.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().

WebKitLibraries:

  • WebKitSystemInterface.h:

(WKSetHTTPPipeliningMaximumPriority): Added declaration.
(WKExtractWordDefinitionTokenRangeFromContextualString): Added
missing declaration from r81890.
(WKShowWordDefinitionWindow): Ditto.
(WKHideWordDefinitionWindow): Ditto.

  • libWebKitSystemInterfaceLeopard.a: Updated.
  • libWebKitSystemInterfaceSnowLeopard.a: Updated.
7:01 PM Changeset in webkit [82899] by morrita@google.com
  • 23 edits
    2 adds in trunk

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage):
  • html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren):
6:33 PM Changeset in webkit [82898] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-04-04 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

Stop JSCell.h from including Structure.h
https://bugs.webkit.org/show_bug.cgi?id=57809

  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject):
  • runtime/JSString.h:
  • runtime/ScopeChain.h:
  • runtime/Structure.h: (JSC::JSCell::isObject): (JSC::JSCell::isString): (JSC::JSCell::classInfo): (JSC::JSCell::createDummyStructure): (JSC::JSValue::needsThisConversion): (JSC::MarkStack::internalAppend):
  • runtime/StructureChain.h:
6:01 PM Changeset in webkit [82897] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Move to using FrameView::resize to handle changes in view size.

https://bugs.webkit.org/show_bug.cgi?id=57805

5:58 PM Changeset in webkit [82896] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Send NPCocoaEventFlagsChanged events
https://bugs.webkit.org/show_bug.cgi?id=57811
<rdar://problem/9215600>

  • Shared/WebEvent.h: (WebKit::WebEvent::capsLockKey): Add CapsLock modifier and getter.
  • Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent): Check for NSAlphaShiftKeyMask and set the CapsLockKey modifier.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::modifierFlags): Check for CapsLockKey and set NSAlphaShiftKeyMask.

(WebKit::isFlagsChangedEvent):
Return whether a given event is a Cocoa flags changed event.

(WebKit::initializeKeyboardEvent):
If this is a flags changed event, set the event type to NPCocoaEventFlagsChanged.

5:09 PM Changeset in webkit [82895] by Martin Robinson
  • 2 edits in trunk

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+ after r82876.

  • Source/autotools/symbols.filter: Update the symbol filter to include new symbols from WTF that DRT uses.
5:09 PM Changeset in webkit [82894] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Don't discard the backing stores of WKViews in the key window
https://bugs.webkit.org/show_bug.cgi?id=57808
<rdar://problem/9110793>
<rdar://problem/9194284>
<rdar://problem/9222216>

  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setBackingStoreIsDiscardable): Add empty stub.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isBackingStoreDiscardable to true.

(WebKit::DrawingAreaProxyImpl::setBackingStoreIsDiscardable):
Set m_isBackingStoreDiscardable and schedule or stop the discard backing store timer.

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
Don't start the timer if m_isBackingStoreDiscardable is false.

  • UIProcess/DrawingAreaProxyImpl.h: Add m_isBackingStoreDiscardable.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): Mark the backing store as discardable if the view is hidden or if the containing window is not active.
4:40 PM Changeset in webkit [82893] by enne@google.com
  • 3 edits
    53 adds
    1 delete in trunk/LayoutTests

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r82879.
http://trac.webkit.org/changeset/82879

Trying to fix 10.6 layout test expectations broke 10.5

  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
4:31 PM Changeset in webkit [82892] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-04-04 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] don't write .checksum files if a fallback platform has an embedded checksum
https://bugs.webkit.org/show_bug.cgi?id=57783

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
4:23 PM Changeset in webkit [82891] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-04-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Introduce EventDispatchMediator abstraction, which encapsulate all
non-trivial logic around firing a specific type of an event.
https://bugs.webkit.org/show_bug.cgi?id=57562

Refactoring, covered by existing tests.

  • dom/Event.cpp: (WebCore::EventDispatchMediator::EventDispatchMediator): Added. (WebCore::EventDispatchMediator::~EventDispatchMediator): Added. (WebCore::EventDispatchMediator::dispatchEvent): Added. (WebCore::EventDispatchMediator::event): Added.
  • dom/Event.h: Added decl.
  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
  • dom/EventDispatcher.h: Updated decls.
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added. (WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
  • dom/KeyboardEvent.h: Updated decls
  • dom/Node.cpp: (WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator. (WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
4:19 PM Changeset in webkit [82890] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Cairo] Memory leak in RefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=57758

No new tests. This just fixes a memory leak.

  • platform/graphics/cairo/RefPtrCairo.cpp: (WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
4:17 PM Changeset in webkit [82889] by enne@google.com
  • 23 edits
    2 deletes in trunk

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r82880.
http://trac.webkit.org/changeset/82880
https://bugs.webkit.org/show_bug.cgi?id=50661

Meter elements not rendered in Chromium Linux layout tests.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, rolling out r82880.
http://trac.webkit.org/changeset/82880
https://bugs.webkit.org/show_bug.cgi?id=50661

Meter elements not rendered in Chromium Linux layout tests

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::create): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Removed.
  • html/shadow/MeterShadowElement.h: Removed.
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valueRatio): (WebCore::RenderMeter::barPartRect): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::shadowAttached):
4:11 PM Changeset in webkit [82888] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix clang build.

4:08 PM Changeset in webkit [82887] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Adjust the list of flaky tests based on NRWT on webkit mac using
a 35 second timeout by default.

  • platform/mac/test_expectations.txt:
3:49 PM Changeset in webkit [82886] by commit-queue@webkit.org
  • 20 edits in trunk

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Updated expected results after this patch fixes the set contenteditable issue.

  • fast/dom/HTMLElement/set-false-expected.txt:
  • fast/dom/HTMLElement/set-false.html:
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
  • fast/dom/HTMLElement/set-true-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
which does NOT trigger layout and only checks the render style of usermodify. The latter
updates the layout first to make sure the render style syncs with DOM contenteditable
attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
are also updated in the patch. But a complete fix will follow up in bug 57244.

This patch fixes all the failed layout tests related to set contenteditable.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
  • dom/Node.cpp: (WebCore::Node::isContentEditable): (WebCore::Node::shouldUseInputMethod):
  • dom/Node.h:
  • html/HTMLElement.cpp:
  • html/HTMLElement.h:

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • src/WebNode.cpp: (WebKit::WebNode::isContentEditable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition):

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Ryosuke Niwa.

setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
3:37 PM Changeset in webkit [82885] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, run uninstall when cleaning to remove built files from WebKitBuild.

3:36 PM Changeset in webkit [82884] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove accidental change to Platform.h

3:33 PM Changeset in webkit [82883] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

2011-04-04 Jade Han <jade.han@nokia.com>

Reviewed by Csaba Osztrogonác.

Symbian build fix.
https://bugs.webkit.org/show_bug.cgi?id=54977

  • config.h:
3:25 PM Changeset in webkit [82882] by rolandsteiner@chromium.org
  • 15 edits
    2 adds in trunk/Source/WebCore

2011-04-04 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by NOBODY (OOPS!).

Bug 57689 - Extract scoping functionality from Document
https://bugs.webkit.org/show_bug.cgi?id=57689

Moved selfOnlyRef (renamed to guardRef), element ID, image map
and accesss key functionalities from Document to a new base
class TreeScope.

TreeShared: made removedLastRef protected

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::destroyScope): (WebCore::Document::getElementById): (WebCore::Document::childrenChanged): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::attach): (WebCore::Document::detach):
  • dom/Document.h: (WebCore::Node::Node):
  • dom/DocumentOrderedMap.cpp: (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h:
  • dom/DOMAllInOne.cpp:
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument):
  • dom/Node.h:
  • dom/TreeScope.cpp: Added.
  • dom/TreeScope.h: Added.
  • platform/TreeShared.h: (WebCore::TreeShared::removedLastRef): made protected
3:20 PM Changeset in webkit [82881] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Add WKIconDatabase* headers to the WebKit2 export for Windows:

  • win/WebKit2Generated.make:

Rubberstamped by Adam Roben.

3:15 PM Changeset in webkit [82880] by morrita@google.com
  • 23 edits
    2 adds in trunk

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.

  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2011-04-04 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter): (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimum-value): (meter::-webkit-meter-even-less-good-value):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::~HTMLMeterElement): (WebCore::HTMLMeterElement::parseMappedAttribute): (WebCore::HTMLMeterElement::attach): (WebCore::HTMLMeterElement::valueRatio): (WebCore::HTMLMeterElement::didElementStateChange): (WebCore::HTMLMeterElement::createShadowSubtree):
  • html/HTMLMeterElement.h:
  • html/shadow/MeterShadowElement.cpp: Added. (WebCore::MeterShadowElement::MeterShadowElement): (WebCore::MeterShadowElement::meterElement): (WebCore::MeterShadowElement::rendererIsNeeded): (WebCore::MeterBarElement::shadowPseudoId): (WebCore::MeterValueElement::shadowPseudoId): (WebCore::MeterValueElement::setWidthPercentage):
  • html/shadow/MeterShadowElement.h: Added. (WebCore::MeterBarElement::MeterBarElement): (WebCore::MeterBarElement::create): (WebCore::MeterValueElement::MeterValueElement): (WebCore::MeterValueElement::create):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::valueRatio):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::renderName): (WebCore::RenderMeter::isMeter): (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation): (WebCore::RenderMeter::canHaveChildren):
3:08 PM Changeset in webkit [82879] by enne@google.com
  • 3 edits
    1 add
    53 deletes in trunk/LayoutTests

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, update Chromium Snow Leopard image baselines.

These were all minor font-related image differences.

  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-position-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
3:07 PM Changeset in webkit [82878] by Martin Robinson
  • 16 edits
    7 adds in trunk

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517

  • configure.ac: Update configure.ac to ensure that GL/GLX headers exist.

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517

Add WebGL support for the GTK+ bits of WebCore.

No new tests. This will be covered by the existing WebGL tests once
the bots are capable of running WebGL tests.

  • GNUmakefile.am: Added new files required for WebGL support.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not yet support accelerated compositing.
  • platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as a framework for GTK+.
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo. (WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added. (WebCore::GraphicsContext3D::getImageData): Added. (WebCore::GraphicsContext3D::paintToCanvas): Added.
  • platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension functions dynamically. They have different names across the different vendors' GL implementations. (WebCore::lookupOpenGLFunctionAddress): Added (WebCore::openGLFunctionTable): Added (WebCore::initializeOpenGLShims): Added
  • platform/graphics/cairo/OpenGLShims.h: Added.
  • platform/graphics/gtk/DrawingBufferGtk.cpp: Added. (WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo. (WebCore::DrawingBuffer::~DrawingBuffer): Ditto. (WebCore::DrawingBuffer::didReset): Ditto. (WebCore::DrawingBuffer::platformColorBuffer): Ditto.
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added. (WebCore::GraphicsContext3D::create): Initial implementation. (WebCore::GraphicsContext3D::GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::makeContextCurrent): Ditto. (WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
  • platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added. (sharedDisplay): Added this shared display which is required by some display drivers. (WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers. (WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto. (WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto. (WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL context given the current environment. (WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer. (WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer. (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation. (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto. (WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
  • platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation. (WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than the private bits that are specific to the Apple port.

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517

Add support for toggling WebGL at runtime when it's enabled.

  • webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL is not enabled, it's a no-op. (webkit_web_settings_class_init): Update to support enable-webgl. (webkit_web_settings_set_property): Ditto. (webkit_web_settings_get_property): Ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Ditto.

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517

Add support to the DRT for turning on WebGL when a layout tests requests it.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
3:02 PM Changeset in webkit [82877] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a weak-handle-related leak in RegisterFile
https://bugs.webkit.org/show_bug.cgi?id=57793

  • interpreter/RegisterFile.cpp: Nixed leaky GlobalObjectNotifier.
  • interpreter/RegisterFile.h: (JSC::RegisterFile::GlobalObjectOwner::finalize): (JSC::RegisterFile::RegisterFile): Replaced GlobalObjectNotifier with a per-RegisterFile weak handle owner, which does not leak.
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::set): Allow set() to take a context argument, since RegisterFile now needs this. (Seems like it was an accidental omission all along.)
2:59 PM Changeset in webkit [82876] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-04-04 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502

This patch changes FAST_MALLOC_MATCH_VALIDATION with a general
corruption check that tags the beginning and end of all allocations
to check for write overflows and overwrites the contents of
memory on free in order to (hopefully) show up use-after-free issues
sooner.

We also turn it on by default for debug builds.

  • JavaScriptCore.exp:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate):
  • wtf/Platform.h:
2:40 PM Changeset in webkit [82875] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
https://bugs.webkit.org/show_bug.cgi?id=57790

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::updateWeakHandles): Updated for rename.
  • collector/handles/HandleHeap.h: Removed comment claiming that this function should only be called during teardown, because it's actually called after every GC pass.
  • runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): Updated for rename.
2:29 PM Changeset in webkit [82874] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Standardized handling of handles for immediate values
https://bugs.webkit.org/show_bug.cgi?id=57788

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Don't check for null or non-cell values here, because our write barrier guarantees that such values are not in the weak list.

(JSC::HandleHeap::writeBarrier): Standardized on checking for null before
checking for cell, and on using early return instead of if/else.

  • collector/handles/HandleHeap.h: (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): Ditto.
2:17 PM Changeset in webkit [82873] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

2011-04-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of WebContext::process() in more places
https://bugs.webkit.org/show_bug.cgi?id=57787

Migrate calls to WebContext::process() over to sendToAllProcesses and
sendToAllProcessesRelaunchingThemIfNecessary.

Add FIXMEs for things that need to be fixed in order to support multiple web processes.


  • UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel):
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
  • UIProcess/WebApplicationCacheManagerProxy.cpp: (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
  • UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): (WebKit::WebDatabaseManagerProxy::deleteAllDatabases): (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
  • UIProcess/WebGeolocationManagerProxy.cpp: (WebKit::WebGeolocationManagerProxy::providerDidChangePosition): (WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::getLoadDecisionForIconURL): (WebKit::WebIconDatabase::didFinishURLImport):
  • UIProcess/WebKeyValueStorageManagerProxy.cpp: (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
  • UIProcess/WebMediaCacheManagerProxy.cpp: (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): (WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::getCacheOrigins): (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin): (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
2:09 PM Changeset in webkit [82872] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786


Forgot to commit the file that actually removes the data member!


  • collector/handles/HandleHeap.h:
2:04 PM Changeset in webkit [82871] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786


We don't need a specific variable to indicate that we're in the middle
of the finalization phase, since m_nextToFinalize already does this.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier):
1:56 PM Changeset in webkit [82870] by ap@apple.com
  • 16 edits in trunk/Source

Reviewed by Dan Bernstein.

REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>

<rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys

  • UIProcess/API/mac/WKView.mm: (-[WKView flagsChanged:]): Ported from WebHTMLView. (-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]): AppKit isn't happy about attempts to interpret NSFlagsChanged, but WK2 lacked the check.
1:48 PM Changeset in webkit [82869] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build warning.

  • WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
1:45 PM Changeset in webkit [82868] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix, part III

  • WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
1:42 PM Changeset in webkit [82867] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build.

  • WebCore.exp.in:
1:40 PM Changeset in webkit [82866] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed Finalizer => WeakHandleOwner (in preparation for adding a reachability callback)
https://bugs.webkit.org/show_bug.cgi?id=57775


Also renamed noFinalizer => emptyWeakOwner, since this is really an
optimization for a weak owner with empty callbacks.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Updated for renames. Removed redundant initialization of m_nextToFinalize. Moved deletion check inside weak owner check, since the weak owner can't delete the node if there is no weak owner!
  • collector/handles/HandleHeap.h: (JSC::WeakHandleOwner::~WeakHandleOwner): (JSC::HandleHeap::makeWeak): Updated for renames.

(JSC::HandleHeap::hasWeakOwner): Changed getFinalizer to hasWeakOwner,
to clarify this function's role in assertions.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::weakOwner):
(JSC::HandleHeap::Node::weakOwnerContext):
(JSC::HandleHeap::Node::emptyWeakOwner):

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollectedNotifier):
  • interpreter/RegisterFile.h:
  • runtime/WeakGCMap.h:
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set): Updated for renames.
1:39 PM Changeset in webkit [82865] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-04 Adrienne Walker <enne@google.com>

Unreviewed, mark revoke-blob-url.html as CRASH for Chromium on Win.

  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [82864] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/696

Merge 82222 - 2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=57266

Add test for getComputedStyle(...).counterIncrement without a counter.

  • fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt: Added.
  • fast/css/getComputedStyle/counterIncrement-without-counter.html: Added.

2011-03-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=57266

Add null check to counterToCSSValue.

Test: fast/css/getComputedStyle/counterIncrement-without-counter.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::counterToCSSValue):

TBR=eae@chromium.org

1:35 PM Changeset in webkit [82863] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-04 David Dorwin <ddorwin@chromium.org>

Reviewed by David Levin.

Chromium Mac crashes when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=57483

Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.

  • WebCore.gyp/WebCore.gyp:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
1:32 PM Changeset in webkit [82862] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix, part II

  • WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and

PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).

1:27 PM Changeset in webkit [82861] by sfalken@apple.com
  • 9 edits in trunk

Remove unused AnalyzeWithLargeStack code from Windows build files
https://bugs.webkit.org/show_bug.cgi?id=57771

Reviewed by Adam Roben.

This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCorePreBuild.cmd:

Source/WebKit/win:

  • WebKit.vcproj/WebKitLibPreBuild.cmd:

Source/WebKit2:

  • win/WebKitPreBuild.cmd:

WebKitLibraries:

  • win/tools/vsprops/common.vsprops:
1:26 PM Changeset in webkit [82860] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

2011-04-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

[CG] Do not accelerate small canvases
https://bugs.webkit.org/show_bug.cgi?id=57596

No new tests. No outward behavior changes.

  • platform/graphics/cg/ImageBufferCG.cpp:
1:21 PM Changeset in webkit [82859] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private

so that WebKit can #include them.

1:14 PM Changeset in webkit [82858] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix WinCE build.

1:12 PM Changeset in webkit [82857] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to fix the Windows build.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::setShouldPaintNativeControls):

12:40 PM Changeset in webkit [82856] by andersca@apple.com
  • 5 edits in trunk/Source

2011-04-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make it easier to send a message to all processes in a context
https://bugs.webkit.org/show_bug.cgi?id=57776

Add WebContext::sendToAllProcesses and WebContext::sendToAllProcessesRelaunchingThemIfNecessary
as a first step towards getting rid of WebContext::process() and getting rid of a class of crashers
where WebContext::process() is null.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::initializeHistoryClient): (WebKit::WebContext::languageChanged): (WebKit::WebContext::setAlwaysUsesComplexTextCodePath): (WebKit::WebContext::registerURLSchemeAsEmptyDocument): (WebKit::WebContext::registerURLSchemeAsSecure): (WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme): (WebKit::WebContext::setCacheModel): (WebKit::WebContext::setDefaultRequestTimeoutInterval): (WebKit::WebContext::clearResourceCaches): (WebKit::WebContext::clearApplicationCache): (WebKit::WebContext::setEnhancedAccessibility): (WebKit::WebContext::startMemorySampler): Use sendToAllProcesses.

(WebKit::WebContext::stopMemorySampler):
Use sendToAllProcesses. This is a slight policy change where we now create a sandbox extension even
if there's no process around. Since this is a debugging tool it seems OK to do this.

  • UIProcess/WebContext.h: Get rid of hasValidProcess.

(WebKit::WebContext::sendToAllProcesses):
If we have a process and we can send messages to it, then do so.

(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
Relaunch the web process and send the message.

  • UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::deleteCookiesForHostname): (WebKit::WebCookieManagerProxy::deleteAllCookies): (WebKit::WebCookieManagerProxy::startObservingCookieChanges): (WebKit::WebCookieManagerProxy::stopObservingCookieChanges): (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Use sendToAllProcesses and sendToAllProcessesRelaunchingThemIfNecessary.
12:33 PM Changeset in webkit [82855] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Delete mt.dep files when doing a clean build due to .vsprops file changes

Apparently this is yet another file that Visual Studio can't figure out it needs to rebuild.

Fixes <http://webkit.org/b/57777> r82850 failed to build on Windows Debug (Build)

Reviewed by Brian Weinstein.

(main): Added dep to the list of extensions we look for when choosing files to delete.

12:33 PM Changeset in webkit [82854] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Move a teensy bit of non-Mac-specific code up to LayerTreeHostCA

Fixes <http://webkit.org/b/57774> LayerTreeHostCA should know how to flip the root layer

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize): Cross-platformized and moved some code here...

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize): ...from here.

12:30 PM Changeset in webkit [82853] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

WK2: Reproducible crash when dragging out of or over Safari window.
https://bugs.webkit.org/show_bug.cgi?id=57654
<rdar://problem/9139755>

Reviewed by Darin Adler.

AppKit does not retain the owner given to the pasteboard, therefore we
need to give the ownership of the retained pointer to NSPasteboard.
Also, dragImage will release the NSFilePromiseDragSource object, therefore
we retain it before calling dragImage to be able to control its lifetime.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage): Passing ownership
of the pointer to AppKit when providing the owner pointer to the NSPasteboard
object.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformDragEnded): Retaining the NSFilePromiseDragSource
since dragImage will release it.

12:19 PM Changeset in webkit [82852] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-30 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

WebKit2: No "open in preview" contextual menu item for PDFs
https://bugs.webkit.org/show_bug.cgi?id=57527

Add support for opening a PDF in the associated application from the
context menu.

  • UIProcess/API/mac/PDFViewController.mm: (_applicationInfoForMIMEType): Added, copied from WebKit/WebPDFView.mm (-[WKPDFView _openWithFinder:]): Added. (-[WKPDFView hitTest:]): Added, copied from WebKit/WebPDFView.mm. (-[WKPDFView menuForEvent:]): Added, adapted from WebKit/WebPDFVie.mm. (-[WKPDFView validateUserInterfaceItem:]): Added.
12:14 PM Changeset in webkit [82851] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement support for temporary files.

https://bugs.webkit.org/show_bug.cgi?id=57772

11:54 AM Changeset in webkit [82850] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix Windows build warning.
https://bugs.webkit.org/show_bug.cgi?id=57767

Reviewed by Brian Weinstein.

  • win/tools/vsprops/common.vsprops:
11:41 AM Changeset in webkit [82849] by oliver@apple.com
  • 34 edits in trunk/Source

2011-04-01 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695

Make StructureChain GC allocated, and make the various owners
mark it correctly.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures): (JSC::PolymorphicAccessStructureList::markAggregate): (JSC::Instruction::Instruction):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::markAggregate):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initPutByIdTransition):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
  • collector/handles/Handle.h: (JSC::HandleConverter::operator->): (JSC::HandleConverter::operator*):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jneq_ptr):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdChainList):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::getPolymorphicAccessStructureListSlot): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeChain):
  • runtime/JSObject.h: (JSC::JSObject::putDirectInternal): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::get): (JSC::JSPropertyNameIterator::markChildren):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):
  • runtime/JSZombie.h:
  • runtime/MarkStack.h: (JSC::MarkStack::append):
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::sweep):
  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition):
  • runtime/Structure.h: (JSC::Structure::markAggregate):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): (JSC::StructureChain::~StructureChain): (JSC::StructureChain::markChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::create): (JSC::StructureChain::createStructure):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->):

2011-04-01 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695

Update for new Structure marking function

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren):
11:29 AM Changeset in webkit [82848] by commit-queue@webkit.org
  • 13 edits in trunk

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572

Unskip passed tests.

  • platform/mac-wk2/Skipped:

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode): (WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
  • Shared/WebPreferencesStore.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAllowFileAccessFromFileURLs):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-04 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
11:00 AM Changeset in webkit [82847] by pfeldman@chromium.org
  • 13 edits in trunk

2011-04-04 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761

  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-pause-on-exception.html:

2011-04-04 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::setInitialScriptContent): (WebCore::InspectorResourceAgent::setInitialXHRContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/generate-inspector-idl:
10:47 AM Changeset in webkit [82846] by commit-queue@webkit.org
  • 2 edits in trunk

2011-04-04 Jon Lee <jonlee@apple.com>

Reviewed by Eric Seidel.

add some directories to .gitignore (and svn:ignore) when opening projects in xcode4
https://bugs.webkit.org/show_bug.cgi?id=57646

  • .gitignore: added xcode 4 related project and workspace directories that are not needed for checkin
10:32 AM Changeset in webkit [82845] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorRuntimeAgent should not depend on Page
https://bugs.webkit.org/show_bug.cgi?id=57759

Descendants of InspectorRuntimeAgent should implement a method providing access to the default
inspected state used for console evaluations.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents. (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::create): (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h: (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
10:29 AM Changeset in webkit [82844] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] DumpRenderTree breaks compilation in some uClibc environments
https://bugs.webkit.org/show_bug.cgi?id=57602

  • DumpRenderTree/qt/main.cpp: (get_backtrace):
10:05 AM Changeset in webkit [82843] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-04-04 Yong Li <yoli@rim.com>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=55969
Add a test that verifies history scroll position is restored
when WebKit goes forward from an unreachable URL error page.
(Error page handling is only supported by Qt DRT.)

  • platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt: Added.
  • platform/qt/fast/history/back-to-unreachable-url-then-forward.html: Added.
  • platform/qt/fast/history/resources/check-scroll-position.html: Added.

2011-04-04 Yong Li <yoli@rim.com>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=55969
Fix the issue that document state is not saved when
going backward and ending up with error page.

Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html

(For manual test, load a non-existent html first, then load
fast/history/resources/check-scroll-position.html, then go
back and go forward. If it doesn't show "SUCCESS" at the bottom
of the page, your browser has failed the test)

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
9:51 AM Changeset in webkit [82842] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix, add new LayoutTestController method stub to wx.

9:36 AM Changeset in webkit [82841] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a test from the win-wk2 skipped list that does not exist.

fast/js/navigator-mimeTypes-length.html was changed and moved to plugins in r71651.

  • platform/win-wk2/Skipped:
9:20 AM Changeset in webkit [82840] by jberlin@webkit.org
  • 1 edit
    13 adds in trunk/LayoutTests

[Windows 7 WebKit2 Release Tests] 6 tests failing since being removed from the mac-wk2
skipped list in r82625.
https://bugs.webkit.org/show_bug.cgi?id=57705

Unreviewed, addd win-wk2 expected results for the tests in order to get the bots green.

  • platform/win-wk2/editing: Added.
  • platform/win-wk2/editing/selection: Added.
  • platform/win-wk2/editing/selection/after-line-break-expected.txt: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/win-wk2/fast/repaint: Added.
  • platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

Apparently the pixel results are similar enough to the win expected pixel results that no
special pixel results need to be added for win-wk2.

  • platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
8:56 AM Changeset in webkit [82839] by beidson@apple.com
  • 11 edits
    2 adds in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=57683
Flesh out WK2 Icon Database API

Reviewed by Darin Adler.

For now the new API will add a client interface where the WK1 version used NSNotifications.

If we decide we'd like the granularity of specific callback functions later,
they can easily be added on.

Project file nonsense:

  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add a WKIconDatabaseClient and some new API:

  • UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):

  • UIProcess/API/C/WKIconDatabase.h:
  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryGetCGImageForURL): Renamed to "try" for subtle clarification.

  • UIProcess/API/C/cg/WKIconDatabaseCG.h:

Implementations for the new APIs:

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::retainIconForPageURL): Remove excessive logging.
(WebKit::WebIconDatabase::releaseIconForPageURL): Ditto.
(WebKit::WebIconDatabase::imageForPageURL):
(WebKit::WebIconDatabase::removeAllIcons):
(WebKit::WebIconDatabase::checkIntegrityBeforeOpening):
(WebKit::WebIconDatabase::initializeIconDatabaseClient):
(WebKit::WebIconDatabase::didImportIconURLForPageURL): Dispatch a client callback,

much like the WK1 API uses notifications.

(WebKit::WebIconDatabase::didImportIconDataForPageURL): Ditto.
(WebKit::WebIconDatabase::didChangeIconForPageURL): Ditto.
(WebKit::WebIconDatabase::didRemoveAllIcons): Ditto.

  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabaseClient.cpp: Added.

(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):

  • UIProcess/WebIconDatabaseClient.h: Added.
8:47 AM Changeset in webkit [82838] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark filesystem-reference.html as CRASH PASS on chromium.

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [82837] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix make distcheck for 1.4.0
https://bugs.webkit.org/show_bug.cgi?id=57750

Added a missing header file to the Makefile

  • GNUmakefile.am:
8:09 AM Changeset in webkit [82836] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove gradientLimit.svg and 2d.text.draw.align.end.ltr.html from test expectations.

  • platform/chromium/test_expectations.txt:
8:01 AM Changeset in webkit [82835] by Martin Robinson
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.4.0

Merging r81812

7:52 AM Changeset in webkit [82834] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4.0/Source/WebKit/gtk/po

Merging r81772

7:34 AM Changeset in webkit [82833] by Martin Robinson
  • 5 edits in trunk

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

  • http/tests/plugins/resources/dump-post.pl: Instead of just printing out the "keywords" parameter, print out the POSTDATA parameter as well. Printing "keywords" did not seem to work on the version of Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation using 'POSTDATA' is the correct way to print the entire POSTDATA for more recent versions of the module.
  • platform/gtk/Skipped: Unskip the test which is now passing.

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826

Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handlePostReadFile): Fix this method.
7:27 AM Changeset in webkit [82832] by caseq@chromium.org
  • 11 edits in trunk

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] add notifications on panels shown/hidden
https://bugs.webkit.org/show_bug.cgi?id=57752

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.showPanel):
  • http/tests/inspector/resources/extension-main.js: (showPanel):
  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-expected.txt:

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] add notifications on panels shown/hidden
https://bugs.webkit.org/show_bug.cgi?id=57752

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelImpl):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyPanelShown): (WebInspector.ExtensionServer.prototype.notifyPanelHidden):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide):
7:23 AM Changeset in webkit [82831] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=54633

Remove use of legacy editing positions when positioning keyboard-driven context
menus. Simplify the code greatly.

  • webkit/webkitwebview.cpp: (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates the context menu position. (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
7:17 AM Changeset in webkit [82830] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: search in resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=57631

Search in resources panel should trigger source frame content load.

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/SearchController.js: (WebInspector.SearchController.prototype.handleShortcut): (WebInspector.SearchController.prototype.focusSearchField):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype._ensureContentLoaded): (WebInspector.SourceFrame.prototype.performSearch):
7:15 AM Changeset in webkit [82829] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark xhr-breakpoints as CRASH PASS on chromium win debug.

  • platform/chromium/test_expectations.txt:
7:01 AM WebKitGTK edited by plaes@plaes.org
Updated outdated Gentoo information. (diff)
6:53 AM Changeset in webkit [82828] by eric@webkit.org
  • 9 edits
    1 add in trunk/Source/WebCore

2011-04-03 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split out UnicodeBidi enum into its own header (to allow use in platform)
https://bugs.webkit.org/show_bug.cgi?id=57722

unicode-bidi is a CSS concept. However the same concept is really needed throughout
the bidi code in platform as well. So I'm moving the enum to platform.
The only part of the enum which doesn't make much sense to platform/ is "normal".

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:
  • platform/text/UnicodeBidi.h: Added.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
6:40 AM Changeset in webkit [82827] by podivilov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, udpate chromium-linux test expectations after r82786.

  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
6:28 AM Changeset in webkit [82826] by podivilov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add chromium-linux expectation for the new test added in r82781.

  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
6:00 AM Changeset in webkit [82825] by podivilov@chromium.org
  • 1 edit
    45 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium-linux test expectations after r82783.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
5:40 AM Changeset in webkit [82824] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
https://bugs.webkit.org/show_bug.cgi?id=57749

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): (WebInspector.TextEditorMainPanel.prototype._paintLine):
5:04 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
4:52 AM Changeset in webkit [82823] by podivilov@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add chromium expectations for the new test added in r82781.

  • platform/chromium-mac-leopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
4:33 AM Changeset in webkit [82822] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
https://bugs.webkit.org/show_bug.cgi?id=48525

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
4:25 AM Changeset in webkit [82821] by mario@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-04 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Unskipped test and added GTK-specific new baseline.

  • platform/gtk/Skipped: Skipped passing test.
  • platform/gtk/accessibility/aria-roles-expected.txt: Added.
4:08 AM Changeset in webkit [82820] by podivilov@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove chromium expectations added by mistake in r82815.

  • platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Removed.
  • platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
4:01 AM Changeset in webkit [82819] by podivilov@chromium.org
  • 1 edit
    90 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, delete duplicate baselines added in r82812.

3:59 AM Changeset in webkit [82818] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
https://bugs.webkit.org/show_bug.cgi?id=57632

Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.appropriateSelectorFor):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.addBlankSection):
  • inspector/front-end/utilities.js:
3:56 AM Changeset in webkit [82817] by podivilov@chromium.org
  • 46 edits
    45 moves
    90 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix bad rebaseline in r82812.

3:27 AM Changeset in webkit [82816] by podivilov@chromium.org
  • 2 edits in trunk/Tools

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix exception in rebaseline tool.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3:18 AM Changeset in webkit [82815] by podivilov@chromium.org
  • 3 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, udpate chromium test expectations after r82786.

  • platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
3:10 AM Changeset in webkit [82814] by caseq@chromium.org
  • 6 edits in trunk

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Followup to an incomplete commit in r82806.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane): (WebInspector.ExtensionSidebarPane.prototype.setPage): (WebInspector.ExtensionSidebarPane.prototype._setObject):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onCreateSidebarPane): (WebInspector.ExtensionServer.prototype.createClientIframe): (WebInspector.ExtensionServer.prototype._onSetSidebarContent):

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Followup to an incomplete commit in r82806.

  • inspector/extensions/extensions.html:
3:06 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
3:04 AM Changeset in webkit [82813] by podivilov@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, add chromium test expectations for tests added in r82780.

  • platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
  • platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
  • platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
2:54 AM Changeset in webkit [82812] by podivilov@chromium.org
  • 91 edits
    34 copies
    103 adds
    45 deletes in trunk/LayoutTests

2011-04-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium tests after r82783.

2:44 AM Changeset in webkit [82811] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Qt minimal build.

  • inspector/InspectorFrontendChannel.h:
2:38 AM Webkit2Innards edited by kbalazs@webkit.org
(diff)
2:38 AM Changeset in webkit [82810] by yurys@chromium.org
  • 7 edits
    1 copy in trunk/Source/WebCore

2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Separate sendMessageToFrontend function
from InspectorClient to individual interface.
https://bugs.webkit.org/show_bug.cgi?id=57548

Refactoring - covered with existing inspector tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendChannel.h: Added. (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
2:20 AM Changeset in webkit [82809] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Nico Weber <thakis@chromium.org>

Reviewed by Eric Seidel.

Prefer a using directive over qualified names in LocalizedNumberICU.cpp
https://bugs.webkit.org/show_bug.cgi?id=57742

Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715

  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): (WebCore::numberFormatter): (WebCore::parseLocalizedNumber): (WebCore::formatLocalizedNumber):
2:14 AM Changeset in webkit [82808] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-04 Andrey Adaikin <aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Breakpoints in the gutter stay static while editing the text
https://bugs.webkit.org/show_bug.cgi?id=57616

2:03 AM Changeset in webkit [82807] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove obsolete doc generating code from CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=57748

  • inspector/CodeGeneratorInspector.pm:
1:56 AM Changeset in webkit [82806] by caseq@chromium.org
  • 8 edits in trunk

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622

Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
  • inspector/front-end/ExtensionAPISchema.json:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onSetSidebarPage):

2011-04-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622

Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
1:50 AM Changeset in webkit [82805] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-04-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Main loop sources are leaked in RunLoopGtk
https://bugs.webkit.org/show_bug.cgi?id=57618

  • Platform/RunLoop.h: (RunLoop::TimerBase::isRepeating):
  • Platform/gtk/RunLoopGtk.cpp: (RunLoop::~RunLoop): Make sure main loop is currently running before calling g_main_loop_quit(), RunLoop::stop() might have been called. (RunLoop::wakeUp): Use an idle source with default priority instead of a timeout one with a 0 interval. (RunLoop::TimerBase::clearTimerSource): New method to clear the timer. (RunLoop::TimerBase::destroyNotifyCallback): Destroy notify callback called when the source is destroyed to clear the timer. (RunLoop::TimerBase::timerFiredCallback): Use the same callback for repeating and no repeating timers. (RunLoop::TimerBase::start): g_source_attach() increments the source reference counter, so use GRefPtr to make sure the source is freed. (RunLoop::TimerBase::stop): Use clearTimerSource().
1:33 AM Changeset in webkit [82804] by loislo@chromium.org
  • 19 edits in trunk

2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce support of 'optional' flag for command arguments.
https://bugs.webkit.org/show_bug.cgi?id=57698

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors-expected.txt:

2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce support of 'optional' flag for command arguments.
https://bugs.webkit.org/show_bug.cgi?id=57698

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::reloadPage):
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::getResourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/generate-inspector-idl:
1:08 AM Changeset in webkit [82803] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-04-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
https://bugs.webkit.org/show_bug.cgi?id=57637

  • bindings/js/JSInjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::injectedScriptFor):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::canAccessInspectedWindow):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptManager.cpp: (WebCore::InjectedScriptManager::createForPage): (WebCore::InjectedScriptManager::createForWorker): (WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor and it depends on which type of context we're inspecting(worker or page). (WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
  • inspector/InjectedScriptManager.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
12:16 AM Changeset in webkit [82802] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-04 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

V8StringCallback.cpp requires V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=57699

No new tests required because of just adding header file.

  • bindings/scripts/CodeGeneratorV8.pm:

Apr 3, 2011:

11:41 PM Changeset in webkit [82801] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-03 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Adding a test of value sanitization for <input type=text>
https://bugs.webkit.org/show_bug.cgi?id=57737

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/script-tests/input-value-sanitization.js: Add tests for type=text.
10:40 PM Changeset in webkit [82800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Clean duplicated files in WebCore_Sources
https://bugs.webkit.org/show_bug.cgi?id=57741

No new tests, Only duplicated files were removed.

  • CMakeLists.txt:
9:13 PM Changeset in webkit [82799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Fix 2-space indentation introduced in bug 54706.
https://bugs.webkit.org/show_bug.cgi?id=57740

No new tests - whitespace changes only.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Convert 2-space indentation to 4-space indentation.
8:09 PM Changeset in webkit [82798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Make CSSStyleApplyProperty non-copyable
https://bugs.webkit.org/show_bug.cgi?id=57738

No new functionality added so no new tests required.

  • css/CSSStyleApplyProperty.h: Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
7:21 PM Changeset in webkit [82797] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

  • Shared/DictionaryPopupInfo.h:
7:13 PM Changeset in webkit [82796] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
https://bugs.webkit.org/show_bug.cgi?id=57739

Reviewed by Maciej Stachowiak.

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.

  • Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.

4:22 PM Changeset in webkit [82795] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
https://bugs.webkit.org/show_bug.cgi?id=57733

Reviewed by Maciej Stachowiak.

The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn't expect to be called between
tests, and it references the layout test controller, which is null.

  • page/Frame.cpp:

(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn't changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.

12:17 PM Changeset in webkit [82794] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Try to make this test more robust.

  • fast/blockflow/broken-ideographic-font.html: Ensure that the font has been loaded before

letting the test finish.

5:37 AM Changeset in webkit [82793] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Teach InlineIterator how to work from any root, not just a RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=57726

For implementing bidi-unicode: isolate, we need to be able to run the
bidi algorithm over a subtree of inlines, not just from a block root.
This is the first step in making this possible.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::root): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::appendRun):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
1:29 AM Changeset in webkit [82792] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-03 Eric Seidel <eric@webkit.org>

Reviewed by Dan Bernstein.

Split out handling of trailing spaces from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=57432

There is much more we could split out from this function, but this is a start.

I suspect this is very hot code. Hopefully the compiler will do the right thing.
If it doesn't the Chromium PLT bots will tell us.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::handleTrailingSpaces): (WebCore::RenderBlock::layoutInlineChildren):
12:54 AM Changeset in webkit [82791] by rniwa@webkit.org
  • 4 edits
    8 adds in trunk

2011-03-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771

The bug was caused by WebKit's not checking the existence of root editable element
in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
we should not run editing commands in a document without a body element editable because
doing so results in appending a non-body element to the document node.

Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
when there are no body element. Since StyleWithCSS is a document's state or property, we allow
execCommand('StyleWithCSS') even in a document without a body element.

WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
the selection when document.write("x") is ran and successfully inserts image.

Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.

Since Internet Explorer does not allow execCommand to run under design mode properly, we could
not test its behavior.

Tests: editing/editability/empty-document-delete.html

editing/editability/empty-document-justify-right.html
editing/editability/empty-document-stylewithcss.html
editing/execCommand/insert-image-with-selecting-document.html

  • editing/Editor.cpp: (WebCore::Editor::canEdit): Verify that the root editable element exists instead of just checking that selection endpoints are editable because selection endpoints could be document node without a body element in design mode and we don't want to consider such a document editable. (WebCore::Editor::canDelete): Ditto.
  • editing/EditorCommand.cpp: (WebCore::enabledInEditableText): Ditto. (WebCore::enabledInRichlyEditableText): Ditto. (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead of duplicating the code in order to fix the same bug.

2011-03-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771

Added tests to ensure WebKit does not crash when attempted to execute editing commands
in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
is executed with selection endpoints being document. WebKit should ignore such attempts
and should not crash.

  • editing/editability/empty-document-delete-expected.txt: Added.
  • editing/editability/empty-document-delete.html: Added.
  • editing/editability/empty-document-justify-right-expected.txt: Added.
  • editing/editability/empty-document-justify-right.html: Added.
  • editing/editability/empty-document-stylewithcss-expected.txt: Added.
  • editing/editability/empty-document-stylewithcss.html: Added.
  • editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
  • editing/execCommand/insert-image-with-selecting-document.html: Added.

Apr 2, 2011:

11:30 PM Changeset in webkit [82790] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated results showing a progression after r82787. The current time display
is now correctly collapsed because the timeline container is not wide enough.

  • platform/gtk/media/video-zoom-controls-expected.txt:
11:22 PM Changeset in webkit [82789] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated platform-specific results after r82787.

  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
10:40 PM Changeset in webkit [82788] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
https://bugs.webkit.org/show_bug.cgi?id=57719

Reviewed by Maciej Stachowiak.

r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
that the timeline container is the parent of the time display. This is not true
with the GTK media style, where the current time display is an inline box, and
thus wrapped in an anonymous flexible box. The code was incorrectly considering
the width of the anonymous box and deciding to hide the time display. Prior to
r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.

  • rendering/MediaControlElements.cpp:

(WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.

9:55 PM Changeset in webkit [82787] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-02 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0

By default, ICU includes |using namespace icu;| in its header files
for backwards compatibility. Clients can define
U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
classes with |icu::| makes this file compile no matter what
U_USING_ICU_NAMESPACE is set to.

https://bugs.webkit.org/show_bug.cgi?id=57715

  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale): (WebCore::numberFormatter): (WebCore::parseLocalizedNumber): (WebCore::formatLocalizedNumber):
6:47 PM Changeset in webkit [82786] by mitz@apple.com
  • 15 edits in trunk

Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

  • platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
6:43 PM Changeset in webkit [82785] by mitz@apple.com
  • 91 edits in trunk/LayoutTests

Updated platform-specific results after r82873.

  • platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-1-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-expected.txt:
  • platform/gtk/fast/html/details-no-summary1-expected.txt:
  • platform/gtk/fast/html/details-no-summary2-expected.txt:
  • platform/gtk/fast/html/details-no-summary3-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open1-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open3-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-open5-expected.txt:
  • platform/gtk/fast/html/details-open6-expected.txt:
  • platform/gtk/fast/html/details-position-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-expected.txt:
  • platform/qt/fast/html/details-no-summary1-expected.txt:
  • platform/qt/fast/html/details-no-summary2-expected.txt:
  • platform/qt/fast/html/details-no-summary3-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open1-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open3-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/html/details-open5-expected.txt:
  • platform/qt/fast/html/details-open6-expected.txt:
  • platform/qt/fast/html/details-position-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-expected.txt:
  • platform/qt/fast/html/details-writing-mode-expected.txt:
5:47 PM Changeset in webkit [82784] by Beth Dakin
  • 2 edits in trunk/Tools

For Dan!

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

5:34 PM Changeset in webkit [82783] by mitz@apple.com
  • 140 edits in trunk

<details> marker loses its margin
https://bugs.webkit.org/show_bug.cgi?id=57713

Reviewed by Beth Dakin.

Source/WebCore:

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
the marker location.

  • rendering/RenderDetails.h:

(WebCore::RenderDetails::renderName): Made private.
(WebCore::RenderDetails::isDetails): Ditto.

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
in the style, like RenderListMarker does.
(WebCore::RenderDetailsMarker::layout): Set the margins from the style.

LayoutTests:

  • platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.checksum:
  • platform/mac/fast/html/details-add-summary-1-expected.png:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.checksum:
  • platform/mac/fast/html/details-add-summary-10-expected.png:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.checksum:
  • platform/mac/fast/html/details-add-summary-2-expected.png:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.checksum:
  • platform/mac/fast/html/details-add-summary-3-expected.png:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.checksum:
  • platform/mac/fast/html/details-add-summary-4-expected.png:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.checksum:
  • platform/mac/fast/html/details-add-summary-5-expected.png:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.checksum:
  • platform/mac/fast/html/details-add-summary-6-expected.png:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.checksum:
  • platform/mac/fast/html/details-add-summary-7-expected.png:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.checksum:
  • platform/mac/fast/html/details-add-summary-8-expected.png:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.checksum:
  • platform/mac/fast/html/details-add-summary-9-expected.png:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.checksum:
  • platform/mac/fast/html/details-no-summary1-expected.png:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.checksum:
  • platform/mac/fast/html/details-no-summary2-expected.png:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.checksum:
  • platform/mac/fast/html/details-no-summary3-expected.png:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.checksum:
  • platform/mac/fast/html/details-no-summary4-expected.png:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.checksum:
  • platform/mac/fast/html/details-open-javascript-expected.png:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.checksum:
  • platform/mac/fast/html/details-open1-expected.png:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.checksum:
  • platform/mac/fast/html/details-open2-expected.png:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.checksum:
  • platform/mac/fast/html/details-open3-expected.png:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.checksum:
  • platform/mac/fast/html/details-open4-expected.png:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.checksum:
  • platform/mac/fast/html/details-open5-expected.png:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.checksum:
  • platform/mac/fast/html/details-open6-expected.png:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.checksum:
  • platform/mac/fast/html/details-position-expected.png:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-1-expected.png:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-2-expected.png:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-3-expected.png:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-4-expected.png:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-5-expected.png:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-6-expected.png:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.checksum:
  • platform/mac/fast/html/details-writing-mode-expected.png:
  • platform/mac/fast/html/details-writing-mode-expected.txt:
5:19 PM Changeset in webkit [82782] by Beth Dakin
  • 2 edits in trunk/Tools

Need to reset the scale, much like zoom.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Rubber-stamped by Geoff Garen.

5:01 PM Changeset in webkit [82781] by aestes@apple.com
  • 3 edits
    4 adds in trunk

2011-04-02 Andy Estes <aestes@apple.com>

Reviewed by Oliver Hunt.

REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518

Test: fast/images/imagemap-focus-ring-zero-outline-width.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.

2011-04-02 Andy Estes <aestes@apple.com>

Reviewed by Oliver Hunt.

REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518

  • fast/images/imagemap-focus-ring-zero-outline-width.html: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
4:46 PM Changeset in webkit [82780] by Beth Dakin
  • 13 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Source/WebKit2:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetScaleAtOrigin):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.

Add DRT support for the scaleWebView SPI.

  • DumpRenderTree/mac/EventSendingController.mm:

(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController scalePageBy:atX:andY:]):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::scalePageBy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
  • fast/dom/Element/scale-page-bounding-client-rect.html: Added.
  • fast/dom/Element/scale-page-client-rects-expected.txt: Added.
  • fast/dom/Element/scale-page-client-rects.html: Added.
  • fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
  • fast/dom/Range/scale-page-bounding-client-rect.html: Added.
  • fast/dom/Range/scale-page-client-rects-expected.txt: Added.
  • fast/dom/Range/scale-page-client-rects.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:19 PM Changeset in webkit [82779] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-02 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

"Search in Spotlight" broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57712

Proxy spotlight searching to the UIProcess.

  • UIProcess/WebPageProxy.messages.in: Add new message. Re-organize messages to put all mac specific ones together.
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::speak): (WebKit::WebPageProxy::searchWithSpotlight): Moved code to trigger spotlight here. Use WTF::String -> NSString conversion function instead of relying on the built in conversion since it doesn't always work in the UIProcess.
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: (WebKit::WebContextMenuClient::searchWithSpotlight): Post message to the UIProcess to do the searching.
3:36 PM Changeset in webkit [82778] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/9194541>

Reviewed by Sam Weinig.

New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().

  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
(WebCore::Range::getBorderAndTextQuads):

  • rendering/RenderObject.h:

(WebCore::adjustFloatPointForPageScale):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):

3:21 PM Changeset in webkit [82777] by mitz@apple.com
  • 15 edits in trunk

Reverted r82775 due to changes in <details> test results, which are
likely progressions.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a

LayoutTests:

  • platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
3:00 PM Changeset in webkit [82776] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-02 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Specify the certificate store in WKBundleSetClientCertificate()
https://bugs.webkit.org/show_bug.cgi?id=57707

Include the name of the system certificate store that the client certificate came from in WKBundleSetClientCertificate().

The PCCERT_CONTEXT for the client certificate we create from the message from the UI process doesn't contain enough information to actually use it in a request, we need to get the real certificate from the certificate store (which is typically the "MY" store).

  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: (WKBundleSetClientCertificate): Add certificateSystemStoreName to parameters.
  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Add certificateSystemStoreName to WKBundleSetClientCertificate() parameters.
  • WebProcess/InjectedBundle/InjectedBundle.h: Add certificateSystemStoreName to setClientCertificate() parameters.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: (WebKit::InjectedBundle::setClientCertificate): Read the real certificate from the certificate store.
2:37 PM Changeset in webkit [82775] by mitz@apple.com
  • 21 edits in trunk

Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

  • platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
1:56 PM Changeset in webkit [82774] by commit-queue@webkit.org
  • 7 edits in trunk

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • platform/gtk/Skipped: unskip test that accesses shadowRoot

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-02 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):
1:30 PM Changeset in webkit [82773] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-02 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Implement WKBundleFrameHasHorizontalScrollbar/WKBundleFrameHasVerticalScrollbar
<rdar://problem/9225772>
https://bugs.webkit.org/show_bug.cgi?id=57709

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameHasHorizontalScrollbar): (WKBundleFrameHasVerticalScrollbar):
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::hasHorizontalScrollbar): (WebKit::WebFrame::hasVerticalScrollbar):
  • WebProcess/WebPage/WebFrame.h:
12:22 PM Changeset in webkit [82772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-02 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Fix leaked pointer in FontGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=57307

Fix a memory leak.

No new functionality, so no new tests.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation. (WebCore::convertUniCharToUTF8):
8:08 AM Applications using WebKit edited by mandrake.lena@yandex.ru
(diff)
8:04 AM Applications using WebKit edited by mandrake.lena@yandex.ru
added new application LeechCraft with Webkit-based browser (diff)
5:15 AM Changeset in webkit [82771] by Patrick Gansterer
  • 10 edits in trunk/Tools

2011-04-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Remove AbstractStep._run_script and move script names to ports.py
https://bugs.webkit.org/show_bug.cgi?id=57704

Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/roll_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4:18 AM Changeset in webkit [82770] by Patrick Gansterer
  • 4 edits in trunk/Tools

2011-04-02 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Emulate shebang on Win32
https://bugs.webkit.org/show_bug.cgi?id=55927

Scripts on Windows work only if they are called with the explicit interpreter.
Read the first line of scripts to detect the correct executable.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
  • Scripts/webkitpy/common/system/executive_unittest.py:
12:48 AM Changeset in webkit [82769] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: we should be able to have in and out arguments of a command with same name.
https://bugs.webkit.org/show_bug.cgi?id=57701

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:

Apr 1, 2011:

11:52 PM Changeset in webkit [82768] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=57693
Skipped the windowless_plugin_paint_test.html layout test on Webkit Windows.

  • platform/win/Skipped:
11:02 PM Changeset in webkit [82767] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-01 Ilya Tikhonovsky <loislo@chromium.org>

Not reviewed trivial change.

Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
Followup change for r82281.
https://bugs.webkit.org/show_bug.cgi?id=57327

  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
10:20 PM Changeset in webkit [82766] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

apos entities shouldn't show up in ChangeLogs when using webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=57692

Previously, we were using BeautifulSoup to process XML from
bugs.webkit.org, but that's incorrect. We should be using
BeautifulStoneSoup to process the XML. We were getting the &apos;
entity wrong because &apos; is an XML entity but not an HTML entity.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
8:44 PM Changeset in webkit [82765] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-04-01 Dimitri Glazkov <Dimitri Glazkov>

Skip the test landed in r82758, since WebKitTestRunner doesn't implement
displayInvalidatedRegion.

  • platform/mac-wk2/Skipped: Skipped the test.
8:32 PM Changeset in webkit [82764] by msaboff@apple.com
  • 7 edits in trunk/Source/WebCore

2011-04-01 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Cached Resource Overhead Space Usage and Accounting Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=57488

Fixed windows test failures.
Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.

No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::hasCacheValidatorFields): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
7:43 PM Changeset in webkit [82763] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

2011-04-01 Jon Lee <jonlee@apple.com>

Reviewed by Darin Adler.

WebKit2: Type-to-select doesn't work in open <select> menu (53023)
https://bugs.webkit.org/show_bug.cgi?id=53023
<rdar://problem/8907678>

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: adding new setPopupMenuSelectedIndex message for windows platform
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::setPopupMenuSelectedIndex):
  • UIProcess/win/WebPopupMenuProxyWin.h: moving setFocusedIndex() into public method
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp: (WebKit::WebPopupMenu::updateFromElement): send message back to UIProcess to update the selected element
7:43 PM Changeset in webkit [82762] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Skipping fast/workers/dedicated-worker-lifecycle instead of
treating it as SLOW. It appears to be downright flaky.

https://bugs.webkit.org/show_bug.cgi?id=57678

  • platform/mac/test_expectations.txt:
7:42 PM Changeset in webkit [82761] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <abarth@webkit.org>

This test fails by timing out.

  • platform/chromium/test_expectations.txt:
7:23 PM Changeset in webkit [82760] by dpranke@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

fix bug number

7:18 PM Changeset in webkit [82759] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Suppress some flaky bidi- and editing-related test failures on
SL Mac NRWT runs. See:

https://bugs.webkit.org/show_bug.cgi?id=57662

  • platform/mac/test_expectations.txt:
7:03 PM Changeset in webkit [82758] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added. Added a layout test which verifies that a dynamically added plugin
receives a paint event. This test has to be skipped on chromium mac/linux and
on gtk and qt as it relies on support for the displayInvalidatedRegion function
in the LayoutTestController

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • plugins/windowless_plugin_paint_test-expected.txt: Added.
  • plugins/windowless_plugin_paint_test.html: Added.

2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.

Test: plugins/windowless_plugin_paint_test.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget):
6:45 PM Changeset in webkit [82757] by commit-queue@webkit.org
  • 7 edits in trunk

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • platform/gtk/Skipped:

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687

This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):
6:43 PM Changeset in webkit [82756] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed buildfix.

[Qt][WK2] Build Webkit2 using "-2" option on Qt
https://bugs.webkit.org/show_bug.cgi?id=55074

  • Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.

(The isWK2() function removes it from @ARGV, but not from @options.)

6:40 PM Changeset in webkit [82755] by commit-queue@webkit.org
  • 1 edit
    1 move in trunk/Tools

2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
https://bugs.webkit.org/show_bug.cgi?id=57666

  • MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
6:23 PM Changeset in webkit [82754] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-01 Adam Barth <abarth@webkit.org>

Attempt to fix the Chromium build using the great and powerful git.
This patch should be the remaining part of reverting Jeremy's ill-fated
refactoring.

  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStoreNames): (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::deleteObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::create): (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::name): (WebCore::IDBObjectStoreProxy::keyPath): (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::clear): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::deleteIndex): (WebCore::IDBObjectStoreProxy::openCursor):
5:55 PM Changeset in webkit [82753] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: fix feature detection, skipped platform lists on mac

We apparently never implemented the code to skip tests based on
what was compiled into DRT. Also, change the logic used to skip
platform directories to match what old-run-webkit-tests does:
skip every test not in a directory in the baseline search path.

https://bugs.webkit.org/show_bug.cgi?id=57662

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:40 PM Changeset in webkit [82752] by mrowe@apple.com
  • 5 edits in trunk/Tools

<http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed

Reviewed by Jon Honeycutt.

Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5:36 PM Changeset in webkit [82751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Mike Reed <reed@google.com>

Reviewed by James Robinson.

always use native font rendering on skia_gpu
fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
https://bugs.webkit.org/show_bug.cgi?id=57663

No new tests. existing rendering tests will exercise this

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
5:35 PM Changeset in webkit [82750] by abarth@webkit.org
  • 1 edit
    3 moves in trunk/Source/WebKit/chromium

2011-04-01 Adam Barth <abarth@webkit.org>

Move these files back to their old locations. I'm not sure why the
rollout didn't move them properly.

  • src/IDBDatabaseBackendProxy.cpp: Removed.
  • src/IDBDatabaseBackendProxy.h: Removed.
  • src/IDBDatabaseProxy.cpp: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp.
  • src/IDBDatabaseProxy.h: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
  • src/IDBObjectStoreBackendProxy.cpp: Removed.
  • src/IDBObjectStoreProxy.cpp: Copied from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp.
5:27 PM Changeset in webkit [82749] by ap@apple.com
  • 4 edits in trunk/Source

Reviewed by Darin Adler.

REGRESSION: Assertion failure when executing a complex custom key binding
https://bugs.webkit.org/show_bug.cgi?id=57681

Also completes the fix for
<rdar://problem/9063782> WebKit2: Text fields in Safari don't honor custom key bindings

  • UIProcess/API/mac/WKView.mm: (-[WKView hasMarkedText]): There is no need to execute saved commands when they can't possibly change the result.
5:09 PM Changeset in webkit [82748] by abarth@webkit.org
  • 38 edits
    1 add
    1 delete in trunk/Source/WebKit/chromium

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82738.
http://trac.webkit.org/changeset/82738
https://bugs.webkit.org/show_bug.cgi?id=57684

Broke storage/indexeddb/objectstore-autoincrement.html and
InjectIDBKey (Requested by abarth|gardening on #webkit).

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::create): (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::create): (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseCallbacksProxy.cpp: (WebCore::IDBDatabaseCallbacksProxy::create): (WebCore::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
  • src/IDBDatabaseCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStoreNames): (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::deleteObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction): (WebCore::IDBDatabaseProxy::close): (WebCore::IDBDatabaseProxy::open):
  • src/IDBDatabaseProxy.h: Renamed from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::create): (WebCore::IDBIndexBackendProxy::IDBIndexBackendProxy):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.h: Removed.
  • src/IDBObjectStoreProxy.cpp: Renamed from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp. (WebCore::IDBObjectStoreProxy::create): (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::name): (WebCore::IDBObjectStoreProxy::keyPath): (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::clear): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::deleteIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h: Added.
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::create): (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebCore::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h: (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/IDBTransactionCallbacksProxy.cpp: (WebCore::IDBTransactionCallbacksProxy::create): (WebCore::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onError): (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: (WebCore::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
  • src/WebIDBKeyRange.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
4:59 PM Changeset in webkit [82747] by abarth@webkit.org
  • 9 edits
    9 deletes in trunk

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82712, r82729, and r82746.
http://trac.webkit.org/changeset/82712
http://trac.webkit.org/changeset/82729
http://trac.webkit.org/changeset/82746
https://bugs.webkit.org/show_bug.cgi?id=57682

fast/frames/frame-programmatic-noresize.html is failing on
Windows bots. Will look into this offline. (Requested by dydx
on #webkit).

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::noResize):
  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h:

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82712, r82729, and r82746.
http://trac.webkit.org/changeset/82712
http://trac.webkit.org/changeset/82729
http://trac.webkit.org/changeset/82746
https://bugs.webkit.org/show_bug.cgi?id=57682

fast/frames/frame-programmatic-noresize.html is failing on
Windows bots. Will look into this offline. (Requested by dydx
on #webkit).

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Removed.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Removed.
  • fast/frames/frame-programmatic-noresize-expected.txt: Removed.
  • fast/frames/frame-programmatic-noresize.html: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Removed.
  • fast/frames/resources/frame-programmatic-resize.js: Removed.
  • platform/chromium/test_expectations.txt:
4:40 PM Changeset in webkit [82746] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <abarth@webkit.org>

Mark failing test as failing.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [82745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-01 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Build Webkit2 using "-2" option on Qt
https://bugs.webkit.org/show_bug.cgi?id=55074

  • Scripts/build-webkit:
4:33 PM Changeset in webkit [82744] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when calling WebPageProxy::setMemoryCacheClientCallsEnabled with an invalid Web Process
https://bugs.webkit.org/show_bug.cgi?id=57680
<rdar://problem/9202909>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Add an isValid check before sending

the message.

4:33 PM Changeset in webkit [82743] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-04-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r82708.
http://trac.webkit.org/changeset/82708
https://bugs.webkit.org/show_bug.cgi?id=53644

This tests fails consistently when run along with other tests

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/5408255-expected.checksum:
  • platform/gtk/editing/deleting/5408255-expected.png:
  • platform/gtk/editing/deleting/5408255-expected.txt:
4:19 PM Changeset in webkit [82742] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

4:19 PM Changeset in webkit [82741] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
https://bugs.webkit.org/show_bug.cgi?id=57656

We should initialize memory when constructing objects.

  • platform/text/StringWithDirection.h: (WebCore::StringWithDirection::StringWithDirection):
4:16 PM Changeset in webkit [82740] by mrowe@apple.com
  • 1 copy in tags/Safari-534.27

New tag.

4:12 PM Changeset in webkit [82739] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Update mac new-run-webkit-tests expectations with SLOW tests.

  • platform/mac/test_expectations.txt:
4:12 PM Changeset in webkit [82738] by jorlow@chromium.org
  • 38 edits
    3 moves
    1 add
    1 delete in trunk/Source/WebKit/chromium

2011-03-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Clean up IndexedDB WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57507

Rename the backend proxy files that didn't have Backend in their name.
Everything in WebKit should be in the WebKit namespace.
Put everything behind the feature flag so we're consistient.
Put the feature flag #if above includes.

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebKit::IDBCallbacksProxy::create): (WebKit::IDBCallbacksProxy::IDBCallbacksProxy): (WebKit::IDBCallbacksProxy::onError): (WebKit::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: (WebKit::IDBCursorBackendProxy::create): (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::create): (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy): (WebKit::IDBDatabaseBackendProxy::name): (WebKit::IDBDatabaseBackendProxy::version): (WebKit::IDBDatabaseBackendProxy::objectStoreNames): (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::deleteObjectStore): (WebKit::IDBDatabaseBackendProxy::setVersion): (WebKit::IDBDatabaseBackendProxy::transaction): (WebKit::IDBDatabaseBackendProxy::close): (WebKit::IDBDatabaseBackendProxy::open):
  • src/IDBDatabaseCallbacksProxy.cpp: (WebKit::IDBDatabaseCallbacksProxy::create): (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
  • src/IDBDatabaseCallbacksProxy.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): (WebKit::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebKit::IDBIndexBackendProxy::create): (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::create): (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy): (WebKit::IDBObjectStoreBackendProxy::name): (WebKit::IDBObjectStoreBackendProxy::keyPath): (WebKit::IDBObjectStoreBackendProxy::indexNames): (WebKit::IDBObjectStoreBackendProxy::get): (WebKit::IDBObjectStoreBackendProxy::put): (WebKit::IDBObjectStoreBackendProxy::deleteFunction): (WebKit::IDBObjectStoreBackendProxy::clear): (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index): (WebKit::IDBObjectStoreBackendProxy::deleteIndex): (WebKit::IDBObjectStoreBackendProxy::openCursor):
  • src/IDBObjectStoreBackendProxy.h: Added.
  • src/IDBObjectStoreProxy.h: Removed.
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::create): (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy): (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h: (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/IDBTransactionCallbacksProxy.cpp: (WebKit::IDBTransactionCallbacksProxy::create): (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onError): (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp:
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseCallbacksImpl.cpp: (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
  • src/WebIDBDatabaseCallbacksImpl.h:
  • src/WebIDBDatabaseError.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBIndexImpl.cpp:
  • src/WebIDBIndexImpl.h:
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath): (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKeyPath.cpp: (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
  • src/WebIDBKeyRange.cpp:
  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionCallbacksImpl.cpp:
  • src/WebIDBTransactionCallbacksImpl.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
4:07 PM Changeset in webkit [82737] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-31 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Save as PDF in Safari provides Untitled as default file name
https://bugs.webkit.org/show_bug.cgi?id=57529

Set the NSPrintOperation's jobTitle to the printing frame's title.

  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]):
4:05 PM Changeset in webkit [82736] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: remove spurious port version override in webkit.py
base.py provides a default implementation so this is just
breaking things.

https://bugs.webkit.org/show_bug.cgi?id=57667

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4:02 PM Changeset in webkit [82735] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <abarth@webkit.org>

Skip platform/mac/plugins/convert-point.html because it relies on code
that only exists in the test plugin for Apple's Mac port. We generally
ignore most of the tests in platform/mac, although we do run them to
detect crashes. In this case, however, the test does crash, but it
crashes in the test plug-in, which doesn't matter to us.

  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [82734] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

2011-04-01 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Roben.

Make view results on waterfall direct link to results.html
https://bugs.webkit.org/show_bug.cgi?id=57671

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
  • Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
3:53 PM Changeset in webkit [82733] by jer.noble@apple.com
  • 13 edits in trunk/Source

2011-04-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Link from PDF opens in a new tab instead of in the same tab
https://bugs.webkit.org/show_bug.cgi?id=57528

  • WebCore.exp.in: Export MouseEvent::create().

2011-04-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Link from PDF opens in a new tab instead of in the same tab
https://bugs.webkit.org/show_bug.cgi?id=57528

Notify the WebProcess that a link has been clicked so that the normal policy
lookup can occur.

  • Shared/WebEvent.cpp: (WebKit::WebEvent::WebEvent): Initialize ivars in the default constructor.
  • Shared/WebEvent.h: Add WebEvent::NoType to Type enum.
  • Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent): Ditto.
  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView PDFViewWillClickOnLink:withURL:]): Handle the delegate

function and override the PDFView default behavior.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Handle the new WebEvent::NoType enum. (WebKit::WebPageProxy::linkClicked): Added. Send event through to WebPage.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::linkClicked): Added. Call loadFrameRequest().
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added LinkClicked.
3:50 PM Changeset in webkit [82732] by weinig@apple.com
  • 3 edits in trunk/Tools

Fix windows build.

  • TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:

(TestWebKitAPI::flushMessages):

3:39 PM Changeset in webkit [82731] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary static keyword.

Reviewed by Adam "Keyword Slasher" Roben.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::adoptWK):

3:35 PM Changeset in webkit [82730] by weinig@apple.com
  • 13 edits in trunk

2011-04-01 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Add adoptWK to WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=57670

  • UIProcess/API/cpp/WKRetainPtr.h: (WebKit::adoptWK): Add shared implementation of adoptWK. Previously both WebKitTestRunner and TestWebKitAPI had separate versions of it.

2011-04-01 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Add adoptWK to WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=57670

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: (TestWebKitAPI::createSessionStateContainingFormData):
  • WebKitTestRunner/StringFunctions.h: Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
3:29 PM Changeset in webkit [82729] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Test assigning false to noResize instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=57668

Apparently the V8 bindings have a bug when assigning undefined to a
boolean attribute. I've filed
https://bugs.webkit.org/show_bug.cgi?id=57669 about that issue, which
I'll address in another patch (obviously with a test). In the
meantime, this patch changes this test to test "false" instead of
"undefined".

  • fast/frames/frame-programmatic-noresize-expected.txt:
  • fast/frames/frame-programmatic-noresize.html:
3:28 PM Changeset in webkit [82728] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-01 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Avoid decoding images twice in texImage2D
https://bugs.webkit.org/show_bug.cgi?id=51498

Make sure to redecode the image only if it's not opaque and texImage2D
wouldn't premultiply it anyway.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
3:19 PM Changeset in webkit [82727] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.

Reviewed by Adam Roben.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::shadowRoot):
Make judicious use of adoptWK().

3:12 PM Changeset in webkit [82726] by andersca@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Remove bogus ChangeLog entry.

3:11 PM Changeset in webkit [82725] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.

Reviewed by Timothy Hatcher.

  • Scripts/extract-localizable-strings:
3:02 PM Changeset in webkit [82724] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 82596
BUG=77690

2:55 PM Changeset in webkit [82723] by andersca@apple.com
  • 10 edits
    4 adds in trunk

2011-04-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Fix an unrelated bug found by the added test.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]): Make sure to always set destX and destY.

2011-04-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Add a missing break.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::convertPoint):

2011-04-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Shockwave plug-in doesn't accept mouse events
https://bugs.webkit.org/show_bug.cgi?id=57653
<rdar://problem/8483273>

Add test.

  • platform/mac/plugins/convert-point-expected.txt: Added.
  • platform/mac/plugins/convert-point.html: Added.

2011-02-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2:42 PM Changeset in webkit [82722] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build fix.

Define DEBUG_ALL for WinCairo debug builds so that the correct
labeled DLLs ("*_debug.dll") are linked for testing runs.

  • win/tools/vsprops/debug_wincairo.vsprops:
2:36 PM Changeset in webkit [82721] by commit-queue@webkit.org
  • 7 edits in trunk

2011-04-01 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • platform/gtk/Skipped: unskip test that accesses shadowRoot

2011-04-01 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-01 Dominic Cooney <dominicc@google.com>

Reviewed by Martin Robinson.

Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowRoot):
2:26 PM Changeset in webkit [82720] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit Mac build fix.

  • dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String to avoid ambiguity.
2:26 PM Changeset in webkit [82719] by weinig@apple.com
  • 10 edits in trunk

2011-04-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKitTestRunner needs layoutTestController.shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=57661

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Implement layoutTestController.shadowRoot for WebKit2.

2011-04-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKitTestRunner needs layoutTestController.shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=57661

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleGetRenderRect): (WKBundleNodeHandleGetElementBounds): (WKBundleNodeHandleCopyElementShadowRoot):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementShadowRoot):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Add accessor for the shadowRoot of an element in the bundle.
2:24 PM Changeset in webkit [82718] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some complexity from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57650


Eliminated pointer-tagging flags.


Tied being weak to having a finalizer (or at least a finalizer sentinel).

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::clearWeakPointers): Removed the special self-destroying flag. It was unused. If we bring it back, we'll probably use a shared autodeallocating finalizer instead.
  • collector/handles/HandleHeap.h: (JSC::HandleHeap::makeWeak): makeWeak and adding a finalizer are now a single, atomic operation -- this makes the relationship between finalizers and weak pointers clearer, and impossible to get wrong.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::handleHeap): No more flags.

(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak): Ditto above. We use a special sentienl
value in the finalizer slot to indicate that a handle is weak but doesn't
require an external function call for finalization.

2:11 PM Changeset in webkit [82717] by ap@apple.com
  • 23 edits
    1 add in trunk/Source

Reviewed by Darin Adler.

Make WebKit2 text input handling more like WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57649

2:08 PM Changeset in webkit [82716] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82711.
http://trac.webkit.org/changeset/82711
https://bugs.webkit.org/show_bug.cgi?id=57657

Made every test crash on XP and Win7 (Requested by
abarth|gardening on #webkit).

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
1:59 PM Changeset in webkit [82715] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

2011-04-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=57651

No new tests. This patch does not affect outward behavior.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isAccelerated):
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::isAccelerated):
1:32 PM Changeset in webkit [82714] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm

Fix the Mac build on Lion.

1:31 PM Changeset in webkit [82713] by Darin Adler
  • 388 edits in trunk/LayoutTests

Removed some more executable bits from files that don't need them.
These often creep in when someone is working on Windows, which uses
executable bits differently from Unix systems.

  • editing/execCommand/align-in-span.html: Removed property svn:executable.
  • editing/selection/extend-byline-withfloat.html: Removed property svn:executable.
  • fast/canvas/webgl/data-view-test.html: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/gray-ramp.png: Removed property svn:executable.
  • fast/canvas/webgl/resources/zero-alpha.png: Removed property svn:executable.
  • fast/css/inline-element-line-break.html: Removed property svn:executable.
  • fast/css/pseudo-element-line-break.html: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-inline-script-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-onbeforeload-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/async-write-expected.txt: Removed property svn:executable.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed property svn:executable.
  • fast/events/before-unload-remove-and-add-subframe.html: Removed property svn:executable.
  • fast/events/change-frame-focus.html: Removed property svn:executable.
  • fast/files/resources/binary-file: Removed property svn:executable.
  • fast/frames/iframe-reparenting.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-frame1.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-frame2.html: Removed property svn:executable.
  • fast/frames/resources/iframe-reparenting-iframe-content.html: Removed property svn:executable.
  • fast/harness/resources/cached-page-1.html: Removed property svn:executable.
  • fast/harness/resources/cached-page-2.html: Removed property svn:executable.
  • fast/harness/use-page-cache.html: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-fragment-expected.txt: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-fragment.html: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-pushstate-expected.txt: Removed property svn:executable.
  • fast/history/same-document-iframes-changing-pushstate.html: Removed property svn:executable.
  • fast/images/resources/cmyk-jpeg.jpg: Removed property svn:executable.
  • fast/inline/inline-position-top-align.html: Removed property svn:executable.
  • fast/inline/resources/gradient.png: Removed property svn:executable.
  • fast/js/script-tests/toInt32UInt32.js: Removed property svn:executable.
  • fast/lists/resources/dump-list.js: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-alphabetic.html: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed property svn:executable.
  • fast/lists/w3-css3-list-styles-numeric.html: Removed property svn:executable.
  • fast/parser/remove-misnested-iframe-in-beforeload-expected.txt: Removed property svn:executable.
  • fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt: Removed property svn:executable.
  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Removed property svn:executable.
  • fast/regex/script-tests/ecma-regex-examples.js: Removed property svn:executable.
  • fast/repaint/canvas-putImageData-expected.txt: Removed property svn:executable.
  • fast/repaint/canvas-putImageData.html: Removed property svn:executable.
  • http/tests/history/redirect-302.html: Removed property svn:executable.
  • http/tests/history/redirect-303.html: Removed property svn:executable.
  • http/tests/history/redirect-307.html: Removed property svn:executable.
  • http/tests/inspector/console-test.js: Removed property svn:executable.
  • http/tests/inspector/console-xhr-logging.html: Removed property svn:executable.
  • http/tests/inspector/elements-test.js: Removed property svn:executable.
  • http/tests/inspector/extensions-resources-redirect.html: Removed property svn:executable.
  • http/tests/inspector/extensions-resources-test.js: Removed property svn:executable.
  • http/tests/inspector/network-preflight-options.html: Removed property svn:executable.
  • http/tests/inspector/network/network-size-chunked.html: Removed property svn:executable.
  • http/tests/inspector/resource-parameters.html: Removed property svn:executable.
  • http/tests/inspector/resources-test.js: Removed property svn:executable.
  • http/tests/inspector/resources/iframe-from-different-domain-data.html: Removed property svn:executable.
  • http/tests/inspector/resources/resource-form-data-receiver-iframe.html: Removed property svn:executable.
  • http/tests/misc/async-and-defer-script-expected.txt: Removed property svn:executable.
  • http/tests/misc/script-async-expected.txt: Removed property svn:executable.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Removed property svn:executable.
  • http/tests/security/cross-origin-script-window-onerror.html: Removed property svn:executable.
  • http/tests/security/resources/cross-origin-script.txt: Removed property svn:executable.
  • inspector/audits/audits-test.js: Removed property svn:executable.
  • inspector/audits/resources/abe.png: Removed property svn:executable.
  • inspector/audits/resources/audits-script1.js: Removed property svn:executable.
  • inspector/audits/resources/audits-script2.js: Removed property svn:executable.
  • inspector/audits/resources/audits-style1.css: Removed property svn:executable.
  • inspector/console/console-assert.html: Removed property svn:executable.
  • inspector/console/console-dir.html: Removed property svn:executable.
  • inspector/console/console-dirxml.html: Removed property svn:executable.
  • inspector/console/console-format.html: Removed property svn:executable.
  • inspector/console/console-log-syntax-error.html: Removed property svn:executable.
  • inspector/console/console-nested-group.html: Removed property svn:executable.
  • inspector/console/console-substituted.html: Removed property svn:executable.
  • inspector/console/console-tests.html: Removed property svn:executable.
  • inspector/console/console-trace-in-eval.html: Removed property svn:executable.
  • inspector/console/console-trace.html: Removed property svn:executable.
  • inspector/console/console-uncaught-exception-in-eval.html: Removed property svn:executable.
  • inspector/console/console-uncaught-exception.html: Removed property svn:executable.
  • inspector/cookie-parser.html: Removed property svn:executable.
  • inspector/debugger/debugger-cyclic-ref.html: Removed property svn:executable.
  • inspector/debugger/debugger-expand-scope.html: Removed property svn:executable.
  • inspector/elements/elements-delete-inline-style-expected.txt: Removed property svn:executable.
  • inspector/elements/elements-delete-inline-style.html: Removed property svn:executable.
  • inspector/elements/elements-panel-search.html: Removed property svn:executable.
  • inspector/elements/elements-panel-structure.html: Removed property svn:executable.
  • inspector/evaluate-in-page.html: Removed property svn:executable.
  • inspector/extensions/extensions-audits-api.html: Removed property svn:executable.
  • inspector/extensions/extensions-audits.html: Removed property svn:executable.
  • inspector/extensions/extensions-eval.html: Removed property svn:executable.
  • inspector/extensions/extensions-events.html: Removed property svn:executable.
  • inspector/extensions/extensions-resources.html: Removed property svn:executable.
  • inspector/extensions/resources/abe.png: Removed property svn:executable.
  • inspector/extensions/resources/audits-style1.css: Removed property svn:executable.
  • inspector/styles/resources/styles-iframe-data.html: Removed property svn:executable.
  • inspector/styles/resources/styles-new-API-1.css: Removed property svn:executable.
  • inspector/styles/resources/styles-url-linkify-iframe.html: Removed property svn:executable.
  • inspector/styles/resources/styles-url-linkify.css: Removed property svn:executable.
  • inspector/styles/styles-disable-then-change-expected.txt: Removed property svn:executable.
  • inspector/styles/styles-disable-then-change.html: Removed property svn:executable.
  • inspector/styles/styles-iframe.html: Removed property svn:executable.
  • inspector/styles/styles-source-lines.html: Removed property svn:executable.
  • inspector/styles/styles-update-from-js-expected.txt: Removed property svn:executable.
  • inspector/styles/styles-update-from-js.html: Removed property svn:executable.
  • inspector/styles/styles-url-linkify.html: Removed property svn:executable.
  • inspector/utilities.html: Removed property svn:executable.
  • platform/chromium-linux/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.checksum: Removed property svn:executable.
  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Removed property svn:executable.
  • platform/chromium-linux/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-security-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/css/text-security-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png: Removed property svn:executable.
  • platform/chromium-mac/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Removed property svn:executable.
  • platform/chromium-win/editing/deleting/delete-br-013-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png: Removed property svn:executable.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.txt: Removed property svn:executable.
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/block-no-inflow-children-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/block-no-inflow-children-expected.txt: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Removed property svn:executable.
  • platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/platform/qt/fast/events/event-sender-keydown-frame-expected.checksum: Removed property svn:executable.
  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed property svn:executable.
  • platform/chromium/compositing/layout-width-change.html: Removed property svn:executable.
  • platform/chromium/html5lib/runner-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-eval-global-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Removed property svn:executable.
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Removed property svn:executable.
  • platform/chromium/test_expectations.txt: Removed property svn:executable.
  • platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/forms/text-style-color-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Removed property svn:executable.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-color-expected.txt: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.png: Removed property svn:executable.
  • platform/mac/fast/css/focus-ring-outline-width-expected.txt: Removed property svn:executable.
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.png: Removed property svn:executable.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.txt: Removed property svn:executable.
  • platform/win/accessibility/text-role-expected.txt: Removed property svn:executable.
  • platform/win/accessibility/text-role.html: Removed property svn:executable.
  • platform/win/fast/events/panScroll-nested-divs.html: Removed property svn:executable.
  • svg/custom/animate-use-crash.xhtml: Removed property svn:executable.
  • svg/filters/feColorMatrix-offset.svg: Removed property svn:executable.
  • transforms/2d/hindi-rotated.html: Removed property svn:executable.
1:07 PM Changeset in webkit [82712] by dbates@webkit.org
  • 8 edits
    9 adds in trunk

2011-04-01 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests: fast/frames/frame-inherit-noresize-from-frameset.html

fast/frames/frame-programmatic-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html

Implements support to programmatically allow and disallow frame resizing.

Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
attribute.

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this code path isn't performance critical. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo(). (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::updateFromElement): Added.
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  • rendering/RenderFrameSet.h:

2011-04-01 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.

Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
removing and adding the noresize attribute, respectively.

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <https://bugs.webkit.org/show_bug.cgi?id=57604>.
  • fast/frames/frame-programmatic-noresize-expected.txt: Added.
  • fast/frames/frame-programmatic-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
  • fast/frames/resources/frame-programmatic-resize.js: Added. (setTestFrameById): (deltaWidth): (shouldAllowFrameResize): (shouldDisallowFrameResize): (shouldDisallowFrameResizeAfterProcessingFrame): (shouldAllowFrameResizeAfterProcessingFrame): (checkTestFrameWidthEquals): (resizeTestFrameBy): (log): (description):
1:00 PM Changeset in webkit [82711] by msaboff@apple.com
  • 7 edits in trunk/Source/WebCore

2011-04-01 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Cached Resource Overhead Space Usage and Accounting Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=57488

Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.

No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setURL): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::hasCacheValidatorFields): (WebCore::ResourceResponseBase::date): (WebCore::ResourceResponseBase::age): (WebCore::ResourceResponseBase::expires): (WebCore::ResourceResponseBase::lastModified): (WebCore::ResourceResponseBase::lazyInit):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::platformLazyInit):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::memoryUsage):
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
12:59 PM Changeset in webkit [82710] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-01 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=57568

Update tests.

  • platform/mac-wk2/Skipped:

2011-04-01 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=57568

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetDatabaseQuota):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setDatabaseQuota):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

2011-04-01 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=57568

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setDatabaseQuota):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
12:57 PM Changeset in webkit [82709] by timothy@apple.com
  • 17 edits in trunk

Make momentum scroll event latching work in WebKit2 on Mac.

<rdar://problem/8751861>

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in: Remove _wkIsLatchingWheelEvent, add _wkGetNSEventMomentumPhase.
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Set m_useLatchedWheelEventNode based on the
event's momentumPhase.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::wheelEvent): Remove the setting of m_useLatchedWheelEventNode.
It is now done in EventHandler::handleWheelEvent.

  • platform/mac/WebCoreSystemInterface.h: Remove wkIsLatchingWheelEvent, add wkGetNSEventMomentumPhase.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/mac/WheelEventMac.mm:

(WebCore::momentumPhaseForEvent): Return a phase on older Mac system by using wkGetNSEventMomentumPhase.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.

Source/WebKit2:

  • Shared/mac/WebEventFactory.mm:

(WebKit::momentumPhaseForEvent): Return a phase on older Mac system by using WKGetNSEventMomentumPhase.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a: Updated to remove WKIsLatchingWheelEvent and add WKGetNSEventMomentumPhase.
  • libWebKitSystemInterfaceSnowLeopard.a: Ditto.
12:50 PM Changeset in webkit [82708] by Martin Robinson
  • 5 edits in trunk/LayoutTests

2011-04-01 Martin Robinson <mrobinson@igalia.com>

[GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644

Unskip this test and update the results, it appears to be passing now without any issue.

  • platform/gtk/Skipped: Unskip a test.
  • platform/gtk/editing/deleting/5408255-expected.checksum:
  • platform/gtk/editing/deleting/5408255-expected.png:
  • platform/gtk/editing/deleting/5408255-expected.txt:
12:50 PM Changeset in webkit [82707] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/696

Merge 82690
BUG=77940

12:36 PM Changeset in webkit [82706] by cevans@google.com
  • 5 edits in branches/chromium/696/Source/WebCore/platform/graphics/chromium

Merge 82624
BUG=76001

12:22 PM Changeset in webkit [82705] by dpranke@chromium.org
  • 18 edits in trunk/Tools

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

This patch completes the cleanup of
rebaseline-chromium-webkit-tests to work with all of the
variants of a platform (we can now rebaseline gpu- and non-gpu
files at the same time).

When the rebaselining is complete, any lines declared as
REBASELINE in the expectations file that matches a test that was
actually rebaselined will be deleted, even if only one of the
variants was actually rebaselined. This may cause odd problems,
but is better than where we're at today.

This change removes the -g flag and deprecates -w. The -g flag is gone
because GPU baselines are handled just like any other variant.
The -w flag is deprecated because this tool now only works
against the canaries, since that's the only place we have a full
set of bots. It will be trivial to change this to
build.webkit.org if we decide that's where we want them to be.

Also, this patch deletes a lot of cruft that is no longer needed
in the test_expectations code and the port-specific code.

https://bugs.webkit.org/show_bug.cgi?id=55191

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
12:18 PM Changeset in webkit [82704] by dpranke@chromium.org
  • 8 edits in trunk/Tools

2011-04-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

rebaseline-chromium-webkit-tests does not work correctly with
version-specific baselines. This patch updates the tool to use
all of the version-specific bots on the canaries, and will now
attempt to rebaseline all of the versions by default, although
it will not update both GPU and CPU versions.

Also, it will no longer modify the test_expectations.txt file
*at all*. You will have to manually delete the REBASELINE lines
after running the tool and determining that it did what you
wanted it to do. This should be fixed in a separate bug - see
webkit bug #55191.

https://bugs.webkit.org/show_bug.cgi?id=55608

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
12:08 PM Changeset in webkit [82703] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed WeakGCMap::deprecatedRemove because it was deprecated and unused
https://bugs.webkit.org/show_bug.cgi?id=57648

  • runtime/WeakGCMap.h:
12:04 PM Changeset in webkit [82702] by steveblock@google.com
  • 5 edits
    1 copy
    1 move in trunk/Source/WebCore

2011-04-01 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

JavaClass should be an interface and free of JNI types
https://bugs.webkit.org/show_bug.cgi?id=57533

This patch fixes JavaClass for V8 only.

It factors out a JavaClass interface which does not use JNI types.
This will allow the Java bridge to be used with objects that
don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaClassJobject class which
implements the interface.

No new tests, refactoring only.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bridge/jni/v8/JavaClassJobjectV8.cpp: (JavaClassJobject::JavaClassJobject): (JavaClassJobject::~JavaClassJobject): (JavaClassJobject::methodsNamed): (JavaClassJobject::fieldNamed):
  • bridge/jni/v8/JavaClassJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaClassV8.h.
  • bridge/jni/v8/JavaClassV8.h: (JSC::Bindings::JavaClass::~JavaClass):
  • bridge/jni/v8/JavaInstanceV8.cpp: (JavaInstance::getClass):
12:02 PM Changeset in webkit [82701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Jaehun Lim <ljaehun.lim@samsung.com>

Unreviewed build fix.

Fix build break when font backend is Pango.
Pango is missed in changeset 80589.

https://bugs.webkit.org/show_bug.cgi?id=57609

  • platform/graphics/pango/FontPlatformData.h: (WebCore::FontPlatformData::setOrientation):
11:45 AM Changeset in webkit [82700] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-01 Adam Barth <abarth@webkit.org>

Update expected results to document more passes.

  • platform/chromium/test_expectations.txt:
11:38 AM Changeset in webkit [82699] by morrita@google.com
  • 6 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <morrita@google.com>

Unreviewed expectations update which follows r82693.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
11:05 AM Changeset in webkit [82698] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82687.
http://trac.webkit.org/changeset/82687
https://bugs.webkit.org/show_bug.cgi?id=57643

This patch broke accessibility aria-treegrid test in Mac
(Requested by msanchez on #webkit).

  • accessibility/AccessibilityARIAGrid.cpp:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
10:49 AM Changeset in webkit [82697] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt: Removed property svn:executable.
  • http/tests/local/formdata/form-data-with-unknown-file-extension.html: Removed property svn:executable.
10:36 AM Changeset in webkit [82696] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Maintain the invariant that Lexer::m_current is set to -1 when at the end of the code buffer

Covered by existing tests.

Fixes <http://webkit.org/b/56699>.

Reviewed by Oliver Hunt.

  • parser/Lexer.h:

(JSC::Lexer::setOffset): Copied code from Lexer::shift to update m_current, because
supposedly the idiom that function uses is fast.

10:35 AM Changeset in webkit [82695] by Adam Roben
  • 3 edits in trunk/Source/WebKit/win

Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received

This will ensure we don't try to process any window messages after the window has been
destroyed.

Covered by existing tests.

Fixes <http://webkit.org/b/55054>.

Reviewed by Steve Falkenburg and John Sullivan.

  • WebView.cpp:

(WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
out the this pointer from the HWND.
(WebView::WebViewWndProc): Changed a runtime check into an assertion.

  • WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
10:33 AM Changeset in webkit [82694] by podivilov@chromium.org
  • 17 edits
    1 add in trunk/LayoutTests

2011-04-01 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, rebaseline chromium expectations for HTMLMeterElement tests updated in r82686.

  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
10:28 AM Changeset in webkit [82693] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <morrita@google.com>

Unreviewed unskipping. This will make some tests fail on GTK port, whoese
results should be updated using layout-test-results.zip compiled by the buildbot.

  • platform/gtk/Skipped:
10:25 AM Changeset in webkit [82692] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

Assertion failure (type == event.type()) after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=56228
<rdar://problem/8806106>

This partially un-confuses the UI process about key processing state after a web process
crash. It may not be pefect yet - sending a KeyUp to a new process that never saw a KeyDown
seems weird.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processDidCrash):
10:15 AM Changeset in webkit [82691] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2011-04-01 MORITA Hajime <morrita@google.com>

Unreviewed expectation/skip update that follows r82686.

  • Updated expectataions for gtk port.
  • Skipped some win tests whose expectations are need to be updated but the result isn't available from build.webit.org.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/win/Skipped:
10:12 AM Changeset in webkit [82690] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Andreas Kling.

Whenever a relayout is trigger for SVGPath, make sure
to clear its previous marker layout info. This helps
to prevent removed markers from being used.
https://bugs.webkit.org/show_bug.cgi?id=57492

Test: svg/dom/path-marker-removed-crash.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout):
  • rendering/svg/SVGMarkerLayoutInfo.cpp: (WebCore::SVGMarkerLayoutInfo::clear):
  • rendering/svg/SVGMarkerLayoutInfo.h:

2011-03-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Andreas Kling.

Tests that we do not crash when trying to paint a removed
svg marker element.
https://bugs.webkit.org/show_bug.cgi?id=57492

  • svg/dom/path-marker-removed-crash-expected.txt: Added.
  • svg/dom/path-marker-removed-crash.svg: Added.
9:48 AM Changeset in webkit [82689] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=55750
SVG <image> referenced by <use> is displayed incorrectly

Reintroduce old behaviour for valid base URI, for invalid
keep using document base URI.
Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.

Test: svg/custom/image-base-uri.svg

  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
9:37 AM Changeset in webkit [82688] by tony@chromium.org
  • 4 edits in trunk/Tools

2011-03-31 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] update the rebaseline tool to know about pngs with checksums
https://bugs.webkit.org/show_bug.cgi?id=57481

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
9:15 AM Changeset in webkit [82687] by mario@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

ARIA Grid tables should return GridRole in roleValue() method
https://bugs.webkit.org/show_bug.cgi?id=57614

This change does not need any test since it doesn't change anything
from the point of view of the consumers (Assistive Technoglogies).
It's just an internal change to simplify identifying HTML and ARIA
tables by calling to the AccessibilityObject::roleValue method.

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole): Removed unneeded comment.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to NSAccessibilityTableRole, to keep the same behaviour.
8:59 AM Changeset in webkit [82686] by morrita@google.com
  • 33 edits in trunk

2011-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
https://bugs.webkit.org/show_bug.cgi?id=56001

  • Simpflied some test cases which had vertical indicators.
  • Updated expectations due to shadow structure change
  • Skipped tetsts which need expectations update.
  • fast/dom/HTMLMeterElement/meter-element.html:
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

<meter> can only support horizontal indicator
https://bugs.webkit.org/show_bug.cgi?id=56001

  • Removed code which deals with the direction and left the horizontal path.
  • Removed "horizontal" from related names which is now redundant.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/html.css: (meter::-webkit-meter-bar): (meter::-webkit-meter-optimum-value): (meter::-webkit-meter-suboptimal-value): (meter::-webkit-meter-even-less-good-value):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): (WebCore::RenderMeter::updateFromElement): (WebCore::RenderMeter::layoutParts): (WebCore::RenderMeter::styleDidChange): (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): (WebCore::RenderMeter::valuePseudoId): (WebCore::RenderMeter::barPseudoId): (WebCore::RenderMeter::detachShadows): (WebCore::RenderMeter::updateShadows):
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsMeter):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::supportsMeter):
  • rendering/style/RenderStyleConstants.h:
8:26 AM Changeset in webkit [82685] by podivilov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-03-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix reveal line in formatted script.
https://bugs.webkit.org/show_bug.cgi?id=56941

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.canShowAnchorLocation): (WebInspector.NetworkPanel.prototype.showAnchorLocation):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.canShowAnchorLocation): (WebInspector.Panel.prototype.showAnchorLocation):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowAnchorLocation): (WebInspector.ResourcesPanel.prototype.showAnchorLocation): (WebInspector.ResourcesPanel.prototype.showResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.canShowAnchorLocation): (WebInspector.ScriptsPanel.prototype.showAnchorLocation): (WebInspector.ScriptsPanel.prototype._showSourceLine):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._createTextViewer):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._showAnchorLocation):
8:22 AM Changeset in webkit [82684] by Adam Roben
  • 2 edits
    1 move in trunk/LayoutTests

Disable inspector/debugger/debug-inlined-scripts.html

It is flaky. The flakiness is tracked by <http://webkit.org/b/56584>.

  • inspector/debugger/debug-inlined-scripts.html-disabled: Renamed from LayoutTests/inspector/debugger/debug-inlined-scripts.html.
  • platform/mac-wk2/Skipped: Removed the now-disabled test.
8:19 AM Changeset in webkit [82683] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make editScriptSource a Script's method.
https://bugs.webkit.org/show_bug.cgi?id=57615

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
8:17 AM Changeset in webkit [82682] by Adam Roben
  • 3 edits in trunk/Tools

Retrieve revision numbers from the build's got_revision property in Leaks Viewer

Previously, we were getting the revision of the first revision that triggered a build.
Choosing the last revision would have been more accurate. But got_revision is what is used
everywhere else on build.webkit.org, and should work even when there were no changes that
triggered a build (e.g., if someone clicked the Force Build button).

Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
recent builds list

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
property, rather than out of the first (i.e., earliest) change in the sourceStamp object.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:

(Array.prototype.first): Added this helper function to return the first element in an array
that matches the given predicate, or null if no such element exists.

8:13 AM Changeset in webkit [82681] by Adam Roben
  • 3 edits in trunk/Tools

Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs

Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
URL on its own line.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
progression, and added a new test that uses a short bug URL while I was at it.

7:10 AM Changeset in webkit [82680] by pfeldman@chromium.org
  • 4 edits in trunk

2011-04-01 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: event should have "data" attribute, not "body"
https://bugs.webkit.org/show_bug.cgi?id=57628

  • inspector/protocol/console-agent-expected.txt:

2011-04-01 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: event should have "data" attribute, not "body"
https://bugs.webkit.org/show_bug.cgi?id=57628

  • inspector/CodeGeneratorInspector.pm:
7:10 AM Changeset in webkit [82679] by Adam Roben
  • 3 edits in trunk/Tools

Mark .vcproj/.vsprops/.sln files as being Windows-only

Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
directories as Windows-only.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShoulBuildTest): Added test cases for the above.

6:58 AM Changeset in webkit [82678] by podivilov@chromium.org
  • 5 edits in trunk

2011-04-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=57610

  • inspector/debugger/xhr-breakpoints-expected.txt:
  • inspector/debugger/xhr-breakpoints.html:

2011-04-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=57610

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
6:44 AM Changeset in webkit [82677] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Cairo build fix

  • WebProcess/WebPage/LayerTreeHost.cpp: Only pull in the LayerTreeHostCA derived classes for

PLATFORM(CA) ports.

6:38 AM Changeset in webkit [82676] by carol.szabo@nokia.com
  • 5 edits
    1 add in trunk/Source/WebKit/qt

2011-04-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Benjamin Poulain.

Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.

Tiled painting still causes synchronous layout when
accelerated compositing and texture mapper are enabled
https://bugs.webkit.org/show_bug.cgi?id=56929

  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderRelativeCoords): (QWebFramePrivate::renderFrameWidgets):
  • Api/qwebframe_p.h:
6:26 AM Changeset in webkit [82675] by Adam Roben
  • 9 edits
    2 copies in trunk/Source/WebKit2

Split LayerTreeHostCA into a base class and derived Mac and Win classes

This will make it easier to customize the Mac and Windows implementations without adding too
many #ifdefs.

Fixes <http://webkit.org/b/57606> Windows and Mac should use separate LayerTreeHost classes

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Added LayerTreeHostCAMac.h.
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create): Create a LayerTreeHostCAMac on Mac, and LayerTreeHostCAWin
on Windows.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some code from here...
(WebKit::LayerTreeHostCA::initialize): ...to here. This function will be called after the
constructor returns, and thus can safely call functions that are pure virtual in this class
and its base class. We now pass our LayerTreeContext to platformInitialize so that our
derived classes can initialize it.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Removed Mac-specific code.

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush):
Removed platform* calls. Derived classes can just override these functions to do what they
need.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed Mac-specific pieces. Made some functions

virtual so that derived classes can override them.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Added.
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::create): Create and initialize a host.
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Simple constructor.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac): Moved code here from LayerTreeHostCA
destructor.
(WebKit::LayerTreeHostCAMac::platformInitialize): Removed direct uses of LayerTreeHostCA
data members.

(WebKit::LayerTreeHostCAMac::invalidate):
(WebKit::LayerTreeHostCAMac::sizeDidChange):
(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):
Renamed from platform*. Now call up to the base class.

(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Updated type.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::create): Create and initialize a host.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::~LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::platformInitialize):
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush):
Stubbed out.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added.
  • win/WebKit2.vcproj: Added LayerTreeHostCAWin.h
  • win/WebKit2Apple.vsprops: Added WebProcess/WebPage/ca/win to the include path.
6:14 AM Changeset in webkit [82674] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
https://bugs.webkit.org/show_bug.cgi?id=40522

Drive-by: fix inc/dec for numbers like ".5"

Test: inspector/styles/up-down-numerics-and-colors.html

WebCore:

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.createKeyEvent): Added arguments for key modifiers.
  • inspector/styles/up-down-numerics-and-colors-expected.txt: Added.
  • inspector/styles/up-down-numerics-and-colors.html: Added.
5:32 AM Changeset in webkit [82673] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] DragClientQt.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40425

  • WebCoreSupport/DragClientQt.h:
5:22 AM Changeset in webkit [82672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-04-01 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Synchronization between WebCore's ContextMenuItem.h and ewk_contextmenu.h
https://bugs.webkit.org/show_bug.cgi?id=57000

  • ewk/ewk_contextmenu.h:
4:12 AM Changeset in webkit [82671] by commit-queue@webkit.org
  • 4 edits
    1 add
    1 delete in trunk/Tools

2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Build MiniBrowser for Symbian
https://bugs.webkit.org/show_bug.cgi?id=56319

Have MiniBrowser reference it's own copy of useragentlist.txt instead
of copying QtTestBrowser's.
Remove Tools/MiniBrowser/DerivedSources.pro
This reduces complexity in the Tools scripts due to Symbian limitations.

  • DerivedSources.pro:
  • MiniBrowser/DerivedSources.pro: Removed.
  • MiniBrowser/MiniBrowser.qrc:
  • MiniBrowser/qt/MiniBrowser.pro:
  • Scripts/webkitdirs.pm:
3:51 AM Changeset in webkit [82670] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove dead code from Script.js.
https://bugs.webkit.org/show_bug.cgi?id=57454

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource):
3:45 AM Changeset in webkit [82669] by podivilov@chromium.org
  • 5 edits
    2 deletes in trunk

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82667.
http://trac.webkit.org/changeset/82667
https://bugs.webkit.org/show_bug.cgi?id=57612

Breaks Leopard layout tests (Requested by podivilov on
#webkit).

  • inspector/debugger/script-formatter-expected.txt: Removed.
  • inspector/debugger/script-formatter.html: Removed.
  • platform/chromium/test_expectations.txt:

2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r82667.
http://trac.webkit.org/changeset/82667
https://bugs.webkit.org/show_bug.cgi?id=57612

Breaks Leopard layout tests (Requested by podivilov on
#webkit).

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
3:26 AM Changeset in webkit [82668] by podivilov@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unused SourceFrameContent class.
https://bugs.webkit.org/show_bug.cgi?id=57453

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ResourceView.js: (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer):
  • inspector/front-end/SourceFrameContent.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:17 AM Changeset in webkit [82667] by podivilov@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447

  • inspector/debugger/script-formatter-expected.txt: Added.
  • inspector/debugger/script-formatter.html: Added.
  • platform/chromium/test_expectations.txt:

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for script formatter worker.
https://bugs.webkit.org/show_bug.cgi?id=57447

Test: inspector/debugger/script-formatter.html

  • GNUmakefile.am:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
2:53 AM Changeset in webkit [82666] by podivilov@chromium.org
  • 4 edits
    1 add in trunk/Source

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
https://bugs.webkit.org/show_bug.cgi?id=57446

  • inspector/front-end/ScriptFormatterWorker.js:

2011-03-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
https://bugs.webkit.org/show_bug.cgi?id=57446

  • WebKit.gyp:
  • scripts/inline_js_imports.py: Added.
2:32 AM Changeset in webkit [82665] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow file access from inspector page so inspector can use workers.
https://bugs.webkit.org/show_bug.cgi?id=57339

  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
1:59 AM Changeset in webkit [82664] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

2011-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes on attempt to log object with broken .toString
https://bugs.webkit.org/show_bug.cgi?id=57557

  • inspector/console/console-log-toString-object-expected.txt: Added.
  • inspector/console/console-log-toString-object.html: Added.

2011-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes on attempt to log object with broken .toString
https://bugs.webkit.org/show_bug.cgi?id=57557

If ScriptValue.toString causes a JavaScript exception, the exception is cleared
before returning from the toString method.

Test: inspector/console/console-log-toString-object.html

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::toString):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::toString):
1:56 AM Changeset in webkit [82663] by caseq@chromium.org
  • 9 edits in trunk

2011-03-31 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
https://bugs.webkit.org/show_bug.cgi?id=57466

  • removed documentWide parameter to querySelector[All]() (user document node id instead)
  • factor out document request logic within DOMAgent into separate method
  • add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
  • use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
  • minor style fixes in Inspector.json
  • more error logging
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype.pushNodeToFrontend): (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend): (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable): (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable): (WebInspector.DOMAgent.prototype.cancelSearch): (WebInspector.DOMAgent.prototype.querySelector): (WebInspector.DOMAgent.prototype.querySelectorAll):

2011-03-31 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
https://bugs.webkit.org/show_bug.cgi?id=57466

  • inspector/elements/dom-agent-query-selector.html: removed documentWide parameter to querySelectorAll
12:55 AM Changeset in webkit [82662] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-01 Kent Tamura <tkent@chromium.org>

Apply sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.