Timeline



Apr 30, 2011:

9:17 PM Changeset in webkit [85406] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Make RenderSVGResourceFilter take ownership of filter data when painting
https://bugs.webkit.org/show_bug.cgi?id=51524

  • svg/custom/filter-on-svgimage-expected.txt: Added.
  • svg/custom/filter-on-svgimage.svg: Added.

2011-04-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Make RenderSVGResourceFilter take ownership of filter data when painting
https://bugs.webkit.org/show_bug.cgi?id=51524

Test: svg/custom/filter-on-svgimage.svg

  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/svg/RenderSVGResourceFilter.h: (WebCore::FilterData::FilterData):
9:16 PM Changeset in webkit [85405] by abarth@webkit.org
  • 18 edits in trunk/Source

2011-04-30 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

Enable strict OwnPtr for GTK
https://bugs.webkit.org/show_bug.cgi?id=59861

  • wtf/OwnPtr.h:

2011-04-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428

Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
factory methods return a PassOwnPtr.

No new tests. This should not change functionality.

  • platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull): (WebCore::GeolocationService::create):
  • platform/GeolocationService.h:
  • platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::create):
  • platform/android/GeolocationServiceAndroid.h:
  • platform/efl/GeolocationServiceEfl.cpp: (WebCore::GeolocationServiceEfl::create):
  • platform/efl/GeolocationServiceEfl.h:
  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::appendPathToCairoContext):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): (WebCore::GraphicsContext::clip):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cairo/OwnPtrCairo.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::apply):
  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
  • platform/gtk/GeolocationServiceGtk.h:
  • platform/mock/GeolocationServiceMock.cpp: (WebCore::GeolocationServiceMock::create):
  • platform/mock/GeolocationServiceMock.h:
6:05 PM Changeset in webkit [85404] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix.

  • assembler/AssemblerBufferWithConstantPool.h:
4:59 PM Changeset in webkit [85403] by barraclough@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Bug 59869 - AssemblerBuffer cleanup - disambiguate size()

Reviewed by Oliver Hunt.

The method size() is called on the AssemblerBuffer both to acquire
the complete size of the code, and to get a position to use as a
label into the code. Instead, add an explicit 'label' method.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::codeSize):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::data):

  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::codeSize):
(JSC::MIPSAssembler::relocateJumps):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::executableCopy):
(JSC::SH4Assembler::oneShortOp):
(JSC::SH4Assembler::codeSize):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::codeSize):
(JSC::X86Assembler::X86InstructionFormatter::label):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

1:05 PM Component Model edited by Dimitri Glazkov
(diff)
10:34 AM BuildingGtk edited by mrobinson@webkit.org
(diff)
8:29 AM Changeset in webkit [85402] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector toolbar titles were 2px off.

  • inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):
5:18 AM Changeset in webkit [85401] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires layoutTestController.setAlwaysAcceptCookies on mac-wk2

<http://webkit.org/b/42778> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added

http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

5:16 AM Changeset in webkit [85400] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires eventSender.keyDown on mac-wk2

<http://webkit.org/b/42194> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added plugins/keyboard-events.html.
5:14 AM Changeset in webkit [85399] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires layoutTestController.overridePreference on mac-wk2

<http://webkit.org/b/42197> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added fast/canvas/webgl/framebuffer-object-attachment.html.
5:01 AM Changeset in webkit [85398] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a failing test on mac-wk2

I can't check in expected failure results because the results are slightly different each
time.

<http://webkit.org/b/59865> tracks the failure.

  • platform/mac-wk2/Skipped: Added transitions/transition-timing-function.html.
5:01 AM Changeset in webkit [85397] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky test on mac-wk2

<http://webkit.org/b/58990> tracks the failure.

  • platform/mac-wk2/Skipped: Added editing/undo/undo-iframe-location-change.html.
5:01 AM Changeset in webkit [85396] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove mac-wk2 expected failure results for an animation test

Looks like this started passing in r85340. (I hope it wasn't because animation-api-1.html,
which is now skipped, was causing this one to fail!)

Fixes <http://webkit.org/b/56528> <rdar://problem/9147568> REGRESSION (r80846):
animations/animation-controller-drt-api.html failing in WebKit2

  • platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Removed.
2:24 AM Changeset in webkit [85395] by mihaip@chromium.org
  • 15 edits in trunk/Source

2011-04-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

V8Proxy.h shouldn't include SecurityOrigin.h
https://bugs.webkit.org/show_bug.cgi?id=59859

Remove SecurityOrigin.h #include from V8Proxy.h. Touching
SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
chromium's DumpRenderTree).

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • css/CSSStyleSelector.cpp:
  • dom/XMLDocumentParserLibxml2.cpp:
  • html/HTMLLinkElement.cpp:
  • loader/SubframeLoader.cpp:
  • page/History.cpp:
  • storage/IDBFactory.cpp:
  • storage/StorageAreaImpl.cpp:

2011-04-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

V8Proxy.h shouldn't include SecurityOrigin.h
https://bugs.webkit.org/show_bug.cgi?id=59859

Add SecurityOrigin.h includes to places that were relying on transitive
includes.

  • src/ApplicationCacheHost.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
1:13 AM Changeset in webkit [85394] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add one more flakey test to the Skipped list.

  • platform/qt-mac/Skipped:
1:11 AM Changeset in webkit [85393] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit/win

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 2: WebKit
https://bugs.webkit.org/show_bug.cgi?id=59785

Initial implementation of full screen API on windows. No animation
occurs when entering or exiting full screen. Re-use existing window
classes (MediaPlayerPrivateFullscreenWindow) to host the webView.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::supportsFullScreenForElement): Call into WebView. (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController. (WebChromeClient::exitFullScreenForElement): Ditto.
  • WebFullScreenController.cpp: Added. (WebFullScreenController::Private::Private): Private data storage class. (WebFullScreenController::Private::~Private): (WebFullScreenController::Private::fullscreenClientWndProc): Handle window

message for full screen window.

(WebFullScreenController::WebFullScreenController):
(WebFullScreenController::~WebFullScreenController):
(WebFullScreenController::setElement): Added.
(WebFullScreenController::element): Added.
(WebFullScreenController::isFullScreen): Added.
(WebFullScreenController::enterFullScreen): Create and display full screen

window, moving webView as child window.

(WebFullScreenController::exitFullScreen): Destroy full screen window and

move webView back where we found it.

  • WebFullScreenController.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::keyDown): Handle the ESC key. (WebView::notifyPreferencesChanged): (WebView::supportsFullScreenForElement): Do not support full screen if

full screen preference is disabled, or if keyboard access is requested.

(WebView::isFullScreen): Added.
(WebView::fullScreenController): Added.

  • WebView.h:

Apr 29, 2011:

11:56 PM Changeset in webkit [85392] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r85355.
https://bugs.webkit.org/show_bug.cgi?id=59833

  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
10:48 PM Changeset in webkit [85391] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-29 Adam Barth <abarth@webkit.org>

Attempt to fix the Windows build.

10:20 PM Changeset in webkit [85390] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] Crash when navigating back
https://bugs.webkit.org/show_bug.cgi?id=59799

The innerNode management in WebKitHitTestResult was relying on the
old DOM bindings behavior where every DOM objects had to be
disposed by the caller. Now the objects are garbage collected by
WebKit when either the parent frame or document dies, so this is
not needed anymore. Update the code to simply take ownership of
the node, which effectively correctly balances the reference
count.

  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_dispose): call C++ dtors in private data. (webkit_hit_test_result_get_property): adatp to GRefPtr API. (webkit_hit_test_result_init): call C++ ctors in private data.
9:30 PM Changeset in webkit [85389] by jer.noble@apple.com
  • 11 edits
    4 adds in trunk/Source

2011-04-28 Jer Noble <jer.noble@apple.com>

Reviewed by Jon Honeycutt.

Implement FULLSCREEN_API on Windows, Part 1: Stubs
https://bugs.webkit.org/show_bug.cgi?id=59778

Create all the stubs necessary to for enabling FULLSCREEN_API
on Windows. This includes the COM interfaces for preferences and
for overriding full screen behavior in a UI Delegate.

  • Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling

full screen preference.

  • Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding

full screen behavior.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::supportsFullScreenForElement): Added. (WebChromeClient::enterFullScreenForElement): Added. (WebChromeClient::exitFullScreenForElement): Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
  • WebPreferences.cpp: (WebPreferences::isFullScreenEnabled): Added. Implements function

defined in IWebUIDelegatePrivate.

(WebPreferences::setFullScreenEnabled): Ditto.

  • WebPreferences.h:

2011-04-28 Jer Noble <jer.noble@apple.com>

Reviewed by Jon Honeycutt.

Implement FULLSCREEN_API on Windows, Part 1: Stubs
https://bugs.webkit.org/show_bug.cgi?id=59778

Add Windows specific stubs for WebKit2 full screen APIs.

  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: Added. (WebKit::WebFullScreenManagerProxy::enterFullScreen): Added stub. (WebKit::WebFullScreenManagerProxy::exitFullScreen): Added stub. (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Added stub. (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Added stub. (WebKit::WebFullScreenManagerProxy::getFullScreenRect): Added stub.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Added. (WebKit::WebFullScreenManager::create): Added. Returns a WebFullScreenManagerWin. (WebKit::WebFullScreenManagerWin::create): Added. (WebKit::WebFullScreenManagerWin::WebFullScreenManagerWin): Added. (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): Added. (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Added stub. (WebKit::WebFullScreenManagerWin::beginEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerWin::beginExitFullScreenAnimation): Added stub.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Added.
  • win/WebKit2.vcproj: Added new classes.
9:30 PM Changeset in webkit [85388] by abarth@webkit.org
  • 14 edits
    4 adds in trunk

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
https://bugs.webkit.org/show_bug.cgi?id=59850

Test that both function-eval and operator-eval are correctly blocked
and allowed according to the policy.

  • http/tests/security/contentSecurityPolicy/eval-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-blocked.html: Added.

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
https://bugs.webkit.org/show_bug.cgi?id=59850

ggaren recommend a different approach to this patch, essentially
installing a new function for function-eval and changing the AST
representation of operator-eval to call function-eval. However, I'm
not sure that approach is workable because the ASTBuilder doesn't know
about global objects, and there is added complication due to the cache.

This approach is more dynamic, adding a branch in EvalExecutable to
detect whether eval is current disabled in the lexical scope. The spec
is slightly unclear about whether we should return undefined or throw
an exception. I've asked Brandon to clarify the spec, but throwing an
exception seems natural.

  • JavaScriptCore.exp:
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::disableEval):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::isEvalEnabled):

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
https://bugs.webkit.org/show_bug.cgi?id=59850

Rather than have JavaScriptCore call back into WebCore to learn whether
eval is enabled, we push that bit of the policy into JavaScriptCore.

Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html

http/tests/security/contentSecurityPolicy/eval-blocked.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::disableEval):
  • bindings/js/ScriptController.h:
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::internalAllowEval): (WebCore::ContentSecurityPolicy::allowEval):
  • page/ContentSecurityPolicy.h:
9:18 PM Changeset in webkit [85387] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Add windows expected results for a new test.

  • platform/win/fast/forms/date-input-visible-strings-expected.txt: Added.
8:47 PM Changeset in webkit [85386] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Simon Fraser and Dan Bernstein.

WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
https://bugs.webkit.org/show_bug.cgi?id=59852
<rdar://problem/9314011>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromPropertyLists): Do what WebKit1 does (but in CF dialect). And yes, I've seen plists with both numbers and booleans used .
8:26 PM Changeset in webkit [85385] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

GTK build fix. Missed moving DateComponents and
adding LocalizedDate files for their build file.

  • GNUmakefile.list.am:
7:56 PM Changeset in webkit [85384] by abarth@webkit.org
  • 3 edits
    6 adds in trunk

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block @style
https://bugs.webkit.org/show_bug.cgi?id=59293

Testing makes perfect.

  • http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html.html: Added.

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block @style
https://bugs.webkit.org/show_bug.cgi?id=59293

This patch blocks @style when style-src doesn't have the
'unsafe-inline' token. This patch blocks the parsing of the attribute
itself. That feels vaguely like too low a level to interpose the
policy, but there didn't seem to be anywhere else natural to enforce
the policy.

Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html

http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
http/tests/security/contentSecurityPolicy/inline-style-on-html.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):
7:50 PM Changeset in webkit [85383] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

land-safely patches should show show their place in the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=59853

This complicated the "should we show the bubbles or the submit-to-ews button"
logic substantially. :( But now we'll show both the commit-queue position
as well as the submit-to-ews button for land-safely (cq+ only) patches.
Previously we would only show the submit-to-ews button.

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/templates/statusbubble.html:
7:41 PM Changeset in webkit [85382] by Joseph Pecoraro
  • 21 edits
    2 moves
    4 adds in trunk

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Allow Localized Date Strings for Date Input Fields
https://bugs.webkit.org/show_bug.cgi?id=59752

The render tree dump prints out the visible string
inside the <input> field.

  • fast/forms/date-input-visible-strings.html: Added.
  • platform/mac/fast/forms/date-input-visible-strings-expected.txt: Added.

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Allow Localized Date Strings for Date Input Fields
https://bugs.webkit.org/show_bug.cgi?id=59752

Test: fast/forms/date-input-visible-strings.html

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: update build files for moving DateComponents from WebCore/html to WebCore/platform and adding the LocalizedDate files.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::serialize): (WebCore::BaseDateAndTimeInputType::serializeWithComponents): (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds): InputType::serialize for a double value with date types is different for the month type because it assumes the incoming value is months instead of msecs (matching valueAsNumber in HTML5). So provide a more general serialization function, serializeWithComponents, that will always serialize a string correctly for the current type but taking in a DateComponents object. The default serialize, and new serializeWithMilliseconds, can fall back to this and allows an override point for the month type.
  • html/MonthInputType.cpp: (WebCore::MonthInputType::serializeWithMilliseconds): the month type is a case where the default serialize does not take msec, so provide an implementation for month which handles msec input.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::setValueAsDate): switch to serializeWithMilliseconds as the incoming date value is msec.
  • html/MonthInputType.cpp: (WebCore::MonthInputType::setValueAsDate): removed.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::visibleValue): allow localized formatting of a date value. (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): allow parsing for a formatted date value.
  • html/BaseDateAndTimeInputType.h:
  • platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp. Expose the Type enum so it can be used outside of the DateComponents class.
  • platform/text/LocalizedDate.h: Added.
  • platform/text/LocalizedDateNone.cpp: Added. (WebCore::formatLocalizedDate): Default implementation falls back to existing HTML5 date input value formatting.
  • html/BaseDateAndTimeInputType.h:
  • html/DateInputType.cpp: (WebCore::DateInputType::dateType):
  • html/DateInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::dateType):
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::dateType):
  • html/DateTimeLocalInputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::dateType):
  • html/MonthInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::dateType):
  • html/TimeInputType.h:
  • html/WeekInputType.cpp: (WebCore::WeekInputType::dateType):
  • html/WeekInputType.h: Accessors for the desired date type of a date input type. This allows the base class to write a generic algorithm.
7:22 PM Changeset in webkit [85381] by abarth@webkit.org
  • 5 edits
    4 adds in trunk

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block inline style from <style>
https://bugs.webkit.org/show_bug.cgi?id=59292

Testing makes perfect.

  • http/tests/security/contentSecurityPolicy/inline-style-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-blocked.html: Added.

2011-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block inline style from <style>
https://bugs.webkit.org/show_bug.cgi?id=59292

The spec has been updated to allow blocking of inline styles with
style-src. This will help folks defend against tricky CSS3 injections.

This patch covers the <style> case. The next patch will cover the
@style case.

Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html

http/tests/security/contentSecurityPolicy/inline-style-blocked.html

  • dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineStyle):
  • page/ContentSecurityPolicy.h:
7:17 PM Changeset in webkit [85380] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-29 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Adam Barth.

Add my name to contributers.
https://bugs.webkit.org/show_bug.cgi?id=59854

  • Scripts/webkitpy/common/config/committers.py:
6:31 PM Changeset in webkit [85379] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add tests using layoutTestController.setPrivateBrowsingEnabled to the WebKit2
skipped list. Covered by https://bugs.webkit.org/show_bug.cgi?id=59857

  • platform/mac-wk2/Skipped:
6:16 PM Changeset in webkit [85378] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-04-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378

Test: To follow in subsequent patch, including the wiring to expose the new settings to LayoutTests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking. (WebCore::FrameLoader::checkIfRunInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Check if the frame load is blocked due to mixed content and cancel it if so. The check was moved up so that it occurs before firing the load callbacks, to avoid any outgoing network hits or accounting. Redirects are handled because willSendRequest is called for each one in the chain.
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Handle the blocking of mixed-content plug-in loads. (WebCore::SubframeLoader::loadPlugin): Handle the blocking of mixed-content plug-in loads.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Handle the blocking of various loads due to mixed content conditions.
  • page/Settings.cpp: (WebCore::Settings::Settings): Permit mixed-content loads by default to avoid a change in behavior by default.
  • page/Settings.h: Add two new booleans to control blocking of mixed content (displaying and running thereof). (WebCore::Settings::setAllowDisplayOfInsecureContent): (WebCore::Settings::allowDisplayOfInsecureContent): (WebCore::Settings::setAllowRunningOfInsecureContent): (WebCore::Settings::allowRunningOfInsecureContent):

2011-04-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAllowDisplayOfInsecureContent): (WebKit::WebSettingsImpl::setAllowRunningOfInsecureContent):
  • src/WebSettingsImpl.h: Simple plumbing for the new boolean settings.
6:13 PM Changeset in webkit [85377] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Extract a function to obtain VisiblePosition from RenderText::positionForPoint
https://bugs.webkit.org/show_bug.cgi?id=59811

Extracted lineDirectionPointFitsInBox from positionForPoint.

  • rendering/RenderText.cpp: (WebCore::lineDirectionPointFitsInBox): (WebCore::RenderText::positionForPoint):
6:01 PM Changeset in webkit [85376] by bdakin@apple.com
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=59846
Scrolling causes rounded bottom window corners to become square
<rdar://problem/9234239>

Reviewed by Simon Fraser.

Keep track of the m_windowBottomCornerIntersectionRect in WKView.
Invalidate the rect before scrolling. And if the rect is non-zero during a
display, mask the corners, then set the rect to zero so that only displays that
happen right after a scroll bother to do this.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::scrollView):

  • UIProcess/API/mac/WKView.mm:

(-[WKView displayIfNeeded]):
(-[WKView _cacheWindowBottomCornerRect]):

  • UIProcess/API/mac/WKViewInternal.h:
5:57 PM Changeset in webkit [85375] by ggaren@apple.com
  • 8 edits
    2 adds in trunk

2011-04-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: r83938 abandons GC memory
https://bugs.webkit.org/show_bug.cgi?id=59604

This bug was caused by script and image elements waiting indefinitely
for their loads to finish.

  • bindings/js/JSNodeCustom.cpp: (WebCore::isReachableFromDOM): Don't test for the load event firing, since the load event doesn't fire in cases of canceled or errored loads. Instead, test hasPendingActivity().


Don't do this test at all for script elements because script elements
can't load while outside the document. (fast/dom/script-element-gc.html
verifies that this is correct.)

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::hasPendingActivity):
  • html/HTMLImageElement.h:
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): (WebCore::ImageLoader::hasPendingLoadEvent):
  • loader/ImageLoader.h: Added API for finding out if an image element has pending activity.
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest): All loads are supposed to end in data(allDataReceived = true) or error(), but in the edge case of a canceled load, all we get is a call to setRequest(0). Be sure to record that we're no longer loading in that case, otherwise our element will leak forever, waiting for its load to complete.

2011-04-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: r83938 abandons GC memory
https://bugs.webkit.org/show_bug.cgi?id=59604


Test an edge case of an image that has finished loading but has not yet
fired its load event.

  • fast/dom/gc-image-element-expected.txt: Added.
  • fast/dom/gc-image-element.html: Added.
5:23 PM Changeset in webkit [85374] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-29 Emil Eklund <eae@chromium.org>

Reviewed by Tony Chang.

Setting outerHTML should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=52686

Add test for setting Element.outerHTML.

  • fast/dom/set-outer-html-expected.txt: Added.
  • fast/dom/set-outer-html.html: Added.

2011-04-29 Emil Eklund <eae@chromium.org>

Reviewed by Tony Chang.

Setting outerHTML should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=52686

When setting outerHTML adjacent text nodes should be merged. This matches
the behavior of outerText and the IE implementation of outerHTML.

Test: fast/dom/set-outer-html.html

  • html/HTMLElement.cpp: (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML. (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
5:15 PM Changeset in webkit [85373] by eae@chromium.org
  • 5 edits
    1 delete in trunk

2011-04-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Onchange on text fields has an incoherent behavior
https://bugs.webkit.org/show_bug.cgi?id=57330

Add tests for typing and then deleting text from an empty field.

  • fast/events/onchange-text-form-field-expected.txt:
  • fast/events/onchange-text-form-field.html:
  • platform/gtk/fast/events/onchange-text-form-field-expected.txt: Removed.

2011-04-29 Emil A Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Onchange on text fields has an incoherent behavior
https://bugs.webkit.org/show_bug.cgi?id=57330

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): Initialize m_textAsOfLastFormControlChangeEvent to empty string rather than null for empty fields.
5:11 PM Changeset in webkit [85372] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=59847
Remove linkOffset from LinkBuffer

Reviewed by Oliver Hunt.

This is redundant since removal of recompilation for exception info.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compile):
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compileCTINativeCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

5:00 PM Changeset in webkit [85371] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Jia Pu <jpu@apple.com>

Reviewed by Sam Weinig.

[Mac] Scrolling WK2 window should dismiss autocorrection panel.
https://bugs.webkit.org/show_bug.cgi?id=59809
<rdar://problem/9317410>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidScroll): Dimiss autocorrection panel in this function.
4:38 PM Changeset in webkit [85370] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-29 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
https://bugs.webkit.org/show_bug.cgi?id=59772

  • Tools.pro:
4:30 PM Changeset in webkit [85369] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-29 Kenneth Russell <kbr@google.com>

Unreviewed build fix. Skip WebPageNewSerializerTest.cpp in Windows multi-DLL build.

  • WebKit.gyp:
4:28 PM Changeset in webkit [85368] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

WebKit2: Typing with Input methods still enters Roman characters in Safari search field frequently
https://bugs.webkit.org/show_bug.cgi?id=59829
<rdar://problem/9336907>

This patch regresses behavior somewhat in that inline input isn't discarded when something
happens in an inactive window. This doesn't work well in shipping Safari either.

  • UIProcess/API/mac/WKView.mm: (-[WKView _notifyInputContextAboutDiscardedComposition]): Added a method that calls -discardMarkedText with a safety check. (-[WKView setMarkedText:selectedRange:replacementRange:]): Use it. (-[WKView _updateTextInputStateIncludingSecureInputState:]): Use it. (-[WKView _resetTextInputState]): Use it.
4:20 PM Changeset in webkit [85367] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-29 Kenneth Russell <kbr@google.com>

Unreviewed. Merged in all downstream Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:17 PM Changeset in webkit [85366] by Chris Fleizach
  • 4 edits in trunk/Source/WebKit2

2011-04-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: Remote accessibility should build on snow leopard
https://bugs.webkit.org/show_bug.cgi?id=59767

  • UIProcess/API/mac/WKView.mm: (-[WKView _updateRemoteAccessibilityRegistration:]): (-[WKView viewDidMoveToWindow]): (-[WKView _setAccessibilityWebProcessToken:]):
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformInitialize): (WebKit::WebPage::registerUIProcessAccessibilityTokens):
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain):
4:13 PM Changeset in webkit [85365] by inferno@chromium.org
  • 5 edits
    12 adds in trunk/LayoutTests

2011-04-29 Abhishek Arya <inferno@chromium.org>

Unreviewed.


Chromium rebaselines for r85355.
https://bugs.webkit.org/show_bug.cgi?id=59833

  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:
4:12 PM Changeset in webkit [85364] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-29 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add protection for shared memory failing to allocate
<rdar://problem/9125287>
https://bugs.webkit.org/show_bug.cgi?id=59842

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Add logging in shared memory failure cases.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Guard against ShareableBitmap failing to create a shared memory backing.
3:37 PM Changeset in webkit [85363] by slewis@apple.com
  • 2 edits in trunk/Tools

Remove the production configuration guard since installs only happen in production anyway.
Works around a bug in Xcode

Rubber-stamped by Adam Roben.

  • DumpRenderTree/mac/PerlSupport/Makefile:
3:20 PM Changeset in webkit [85362] by evan@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-04-28 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] support components build on Linux
https://bugs.webkit.org/show_bug.cgi?id=59748

  • WebKit.gyp: adjust tests to not be Windows-specific.
  • public/WebCommon.h: add #defines to support Linux.
  • public/linux/WebFontRenderStyle.h: expose Linux-specific API.
  • tests/RunAllTests.cpp: adjust ifdefs to not be Windows-specific.
3:11 PM Component Model edited by Dimitri Glazkov
(diff)
2:55 PM Changeset in webkit [85361] by barraclough@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=59221
[RegexFuzz] Regression blocking testing

Reviewed by Oliver Hunt & Geoff Garen.

Source/JavaScriptCore:

Okay, so the bug here is that when, in the case of a TypeParentheticalAssertion
node, emitDisjunction recursively calls to itself to emit the nested disjunction
the value of parenthesesInputCountAlreadyChecked is bogus (doesn't take into
account the uncheck that has just taken place).

Also, the special handling given to countToCheck in the case of parenthetical
assertions is nonsense, delete it, along with the isParentheticalAssertion argument.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

LayoutTests:

Add new tests for parenthetical assertions.

  • fast/regex/assertion-expected.txt:
  • fast/regex/script-tests/assertion.js:
2:44 PM Changeset in webkit [85360] by Adam Roben
  • 9 edits in trunk

Ensure PHP's short_open_tag and log_errors settings are turned on

These are usually on by default, but you can't trust defaults!

Reviewed by Sam Weinig.

Tools:

Remove a PHP setting that is now provided by httpd.conf

r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
isn't dependent on paths that could be different on each user's machine).

  • Scripts/webkitperl/httpd.pm:

(getDefaultConfigForTestDirectory): Removed log_errors setting.

LayoutTests:

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/apache2-msys-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:

Added settings to turn on short_open_tag and log_errors.

2:43 PM Changeset in webkit [85359] by slewis@apple.com
  • 3 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=59776
<rdar://problem/9287113> REGRESSION: Safari cold/warm launch time 15% to 2x regression
On the first draw the WebProcess is just going to send us blank bits anyway so don't
pause waiting for the update. Continue drawing a blank window until the WebProcess
sends us the update.

Reviewed by Darin Adler.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::paint):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):

  • UIProcess/DrawingAreaProxyImpl.h:
2:41 PM Component Model edited by Dimitri Glazkov
(diff)
2:41 PM Component Model edited by Dimitri Glazkov
(diff)
2:32 PM Changeset in webkit [85358] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Ojan Vafai <ojan@chromium.org>

Inlude new expected results accidentally excluded from
http://trac.webkit.org/changeset/85346.

  • fast/harness/results-expected.txt:
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:14 PM Component Model edited by Dimitri Glazkov
(diff)
2:07 PM Component Model edited by Dimitri Glazkov
(diff)
1:56 PM Changeset in webkit [85357] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r85343.

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

1:42 PM Changeset in webkit [85356] by jonlee@apple.com
  • 12 edits in trunk/Source

2011-04-29 Jon Lee <jonlee@apple.com>

Reviewed by mitzpettel.

REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
https://bugs.webkit.org/show_bug.cgi?id=59721

Removing shouldClearSelectionWhenLosingWebPageFocus(). Reverting changelist 83814.

  • WebCore.exp.in:
  • editing/EditingBehavior.h:

2011-04-29 Jon Lee <jonlee@apple.com>

Reviewed by mitzpettel.

REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
https://bugs.webkit.org/show_bug.cgi?id=59721

When resigning first responder status, check to see if we need to maintain an inactive
selection in the web view. If we don't, we clear the selection.

This also reverts the change made in 83814, since that was a different attempt to solve this same issue.

  • UIProcess/API/C/WKPage.cpp: (WKPageSetMaintainsInactiveSelection): Export setMaintainsInactiveSelection()
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): Check and see if we need to maintain the selection in the view prior to resigning. If not, we clear the selection
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::clearSelection): Send message across process boundary (WebKit::WebPageProxy::setMaintainsInactiveSelection): Sets variable
  • UIProcess/WebPageProxy.h: New member variable to keep track of whether we need to maintain the current selection (WebKit::WebPageProxy::maintainsInactiveSelection): Returns variable
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setFocused): Reverting code to just set the focused bit instead of also clearing the selection (WebKit::WebPage::clearSelection):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: add new ClearSelection() message
1:38 PM Changeset in webkit [85355] by inferno@chromium.org
  • 6 edits
    16 adds in trunk

2011-04-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Allow only first table caption and destroy the remaining ones.
https://bugs.webkit.org/show_bug.cgi?id=58249

Previously, we were only laying out the first table caption.
However Table::layout didn't mark the other ones as not needing
layout. So after table layout completes, table is marked as not
needing layout with its other table caption still needing layout.
This causes incorrect layout root calculations and set it to a
node which is already getting deleted.

Tests: fast/table/dynamic-caption-add-before-child.xhtml

fast/table/dynamic-caption-add-remove-before-child.xhtml
fast/table/multiple-captions-crash.xhtml
fast/table/multiple-captions-crash2.xhtml
fast/table/multiple-captions-display.xhtml

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): when new caption or a before child caption is added, we need to explicitly trigger section recalc or otherwise layout won't catch it. (WebCore::RenderTable::removeChild): when child to be removed is m_caption, make sure to trigger style recalc on the table. (WebCore::RenderTable::recalcCaption): code to destroy captions other than the first one. (WebCore::RenderTable::recalcSections): call recalcCaption helper. Store the next sibling early since child can get destroyed in recalcCaption.
  • rendering/RenderTable.h:

2011-04-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash on

ASSERT(!m_layoutRoot->container()
!m_layoutRoot->container()->needsLayout())

when a table has two or more captions.
https://bugs.webkit.org/show_bug.cgi?id=58249

  • fast/table/dynamic-caption-add-before-child.xhtml: Added. Tests that before child caption becomes the first caption.
  • fast/table/dynamic-caption-add-remove-before-child.xhtml: Added. Tests that when we remove the before child caption, the original caption becomes the first caption and is drawn.
  • fast/table/multiple-captions-crash-expected.txt: Added.
  • fast/table/multiple-captions-crash.xhtml: Added. Tests that we do not crash when table has multiple captions and captions (other than the first one) have input elements added as their child.
  • fast/table/multiple-captions-crash2-expected.txt: Added.
  • fast/table/multiple-captions-crash2.xhtml: Added. Same as multiple-captions-crash.xhtml but this testcase does not have enclosing table tags for the captions.
  • fast/table/multiple-captions-display.xhtml: Added. Tests that only the first caption and captions with position fixed (display=BLOCK) are shown. Other captions are not added to table.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.checksum: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.png: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.txt: Rebaseline test because we do not allow captions other than the first one.
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt: Rebaseline test because we do not allow captions other than the first one.
1:29 PM Changeset in webkit [85354] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2011-04-29 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=59729

Another followup from adding ENABLE(ANIMATION_API). Fix
tests that mention webkitGetAnimations().

  • fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
12:46 PM Changeset in webkit [85353] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

  • DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
12:42 PM Changeset in webkit [85352] by jonlee@apple.com
  • 2 edits in trunk/Tools

2011-04-29 Jon Lee <jonlee@apple.com>

Unreviewed, Adding Jon Lee as a committer

  • Scripts/webkitpy/common/config/committers.py:
12:40 PM Changeset in webkit [85351] by jamesr@google.com
  • 5 edits in branches/chromium/742/Source/WebCore

Merge 84546 - 2011-04-21 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Fix artefacts in compositor HUD when resizing
https://bugs.webkit.org/show_bug.cgi?id=58969

HUD was using the tiler program and not setting the texture
transform. The HUD would thus draw with a texture transform based
on the last tile drawn, leading sometimes to distortion.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::headsUpDisplayProgram):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

TBR=commit-queue@webkit.org
BUG=81011
Review URL: http://codereview.chromium.org/6901134

12:32 PM Changeset in webkit [85350] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-29 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r85330.
http://trac.webkit.org/changeset/85330
https://bugs.webkit.org/show_bug.cgi?id=41311

Caused unexpected border rendering change on 500 tests on chromium linux.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
12:20 PM Changeset in webkit [85349] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r85343.

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::wndProc):
(WebCore::PluginView::snapshot):

12:19 PM Changeset in webkit [85348] by dino@apple.com
  • 14 edits in trunk/LayoutTests

2011-04-29 Dean Jackson <dino@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=59729

Followup from adding an ENABLE flag that is disabled by
default. Adjust broken test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
12:17 PM Changeset in webkit [85347] by ojan@chromium.org
  • 8 edits in trunk/Tools

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

fix pretty_patch_available and wdiff_available
https://bugs.webkit.org/show_bug.cgi?id=59761

These methods rely on the check_* method being called first.
This would only happen when we actually tried to compute a diff,
but computing the diff happens on a different process.

Also fix setting _wdiff_avialable to True by default.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
12:14 PM Changeset in webkit [85346] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-29 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

handle flaky failures
https://bugs.webkit.org/show_bug.cgi?id=59820

Handle that actual can be a space-separated list of results
when we do retries. Also, show expected flaky tests that pass
in the unexpected passes table.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
12:12 PM Changeset in webkit [85345] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Application cache doesn't work due to a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=59818
<rdar://problem/9346971>

Add a sandbox extension for the application cache directory.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode and decode the sandbox extension handle.
  • Shared/WebProcessCreationParameters.h: Add a applicationCacheDirectoryExtensionHandle member.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): If we have a non-empty application cache directory, create a sandbox extension and pass it to the creation parameters.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Create and consume a sandbox extension.
  • WebProcess/WebProcess.h: Add an m_applicationCachePathExtension member variable.
12:09 PM Changeset in webkit [85344] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-29 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

exclude skipped tests from the summarized results
https://bugs.webkit.org/show_bug.cgi?id=59813

If we find a need fo skipped tests later, we should either create
a skipped.json file or expose this some other way. As it is, the data
is unused and is hugely bloating the size of full_results.json.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
11:53 AM Changeset in webkit [85343] by Csaba Osztrogonác
  • 9 edits in trunk/Source

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

  • wtf/OwnPtr.h:

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
11:37 AM Changeset in webkit [85342] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-29 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: index with integer keys
https://bugs.webkit.org/show_bug.cgi?id=59794

  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt: Added.
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html: Added.
11:19 AM Changeset in webkit [85341] by Adam Roben
  • 2 edits in trunk/Tools

Make DumpRenderTreeSupport get installed when the default configuration is built

The default configuration is Production, but in that case the CONFIGURATION environment
variable is set to the empty string.

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't

already set so that later logic that depends on CONFIGURATION having that value will work.

11:15 AM Changeset in webkit [85340] by dino@apple.com
  • 22 edits in trunk

2011-04-29 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Add ENABLE macro for WebKitAnimation
https://bugs.webkit.org/show_bug.cgi?id=59729

Add new feature to toggle WebKit Animation API.

  • configure.ac:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • Configurations/FeatureDefines.xcconfig: for JavaScriptCore, WebCore, WebKit/mac, WebKit2
11:10 AM Changeset in webkit [85339] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Anders Carlsson <andersca@apple.com>

Reviewed by Brian Weinstein.

Crash when closing a tab that is unresponsive
https://bugs.webkit.org/show_bug.cgi?id=59810
<rdar://problem/9329133>

Back out r84643 - there was no rationale for this change, and it's causing crashes.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::processDidCrash):
11:00 AM Changeset in webkit [85338] by dino@apple.com
  • 3 edits
    3 adds in trunk

2011-04-29 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=59149
(Regression) Existing animations are not replaced when filling.

Hardware animations that fill forwards were not being correctly
replaced when the animation was removed. The actual animation
logic was working correctly, but it wasn't deleting the
CoreAnimation animation from the PlatformLayer. The fix was
to explicitly call endAnimation when disconnecting the animation
from its RenderObject.

Test: animations/3d/replace-filling-transform.html

  • page/animation/AnimationBase.h: (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared

2011-04-29 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=59149
(Regression) Existing animations are not replaced when filling.

Add a test that exercises the case where a hardware animation
is in a filling mode, then is replaced by a new animation.

  • animations/3d/replace-filling-transform-expected.txt: Added.
  • animations/3d/replace-filling-transform.html: Added.
  • animations/3d/replace-filling-transform-expected.png: Added.
10:34 AM Changeset in webkit [85337] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-29 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: indexes against autoincrementing keys
https://bugs.webkit.org/show_bug.cgi?id=59722

  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/autoincrement-indexes.html: Added.
10:29 AM Changeset in webkit [85336] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

[Qt] Remove WML tests from the Skipped list after r85256.

  • platform/qt/Skipped:
10:20 AM Changeset in webkit [85335] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests that we do not crash when inline text is removed and we
try to access layout attributes containing that inline text.
https://bugs.webkit.org/show_bug.cgi?id=59161

  • svg/text/inline-text-destroy-attributes-crash-expected.txt: Added.
  • svg/text/inline-text-destroy-attributes-crash.xhtml: Added.

2011-04-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

When svg inline text is getting destroyed, make sure to mark
its svg text ancestor as needing a positioning values update.
This helps to recalculate layout attributes and makes sure
that svg inline text is not used again.
https://bugs.webkit.org/show_bug.cgi?id=59161

Test: svg/text/inline-text-destroy-attributes-crash.xhtml

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::destroy):
  • rendering/svg/RenderSVGInlineText.h:
10:18 AM Changeset in webkit [85334] by weinig@apple.com
  • 2 edits in trunk/Tools

Make production the default build type for WebKitTestRunner, matching
all other projects.

Reviewed by Adam Roben.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:12 AM Changeset in webkit [85333] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add flakey tests to the Skipped list.

  • platform/qt-mac/Skipped:
9:57 AM Changeset in webkit [85332] by kevino@webkit.org
  • 6 edits in trunk

[wx] Unreviewed build fixes for recent changes in WebKit trunk and wxMSW.

9:53 AM Changeset in webkit [85331] by pfeldman@chromium.org
  • 1 edit
    2 adds in trunk/Websites/webkit.org

2011-04-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding image files for the blog post.

  • blog-files/inspector/remote-debugging-attached.png: Added.
  • blog-files/inspector/remote-debugging-discovery.png: Added.
9:48 AM Changeset in webkit [85330] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Mike Reed <reed@google.com>

Reviewed by Ojan Vafai.

Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311

This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
as that shows other issues/question unrelated to clipping.
https://bugs.webkit.org/show_bug.cgi?id=41311

No new tests. covered by existing layout tests

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
9:29 AM Changeset in webkit [85329] by Adam Roben
  • 3 edits in trunk/LayoutTests

Move some tests that time out in Debug from win-xp/Skipped to win/Skipped

This will help people who run tests in Debug on Windows 7.

  • platform/win-xp/Skipped: Moved two XHR tests from here...
  • platform/win/Skipped: ...to here.
9:19 AM Changeset in webkit [85328] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197

Add http/tests/inspector/network/ping.html, which uses overridePreference, to the mac-wk2
Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
9:15 AM Changeset in webkit [85327] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Mike Lawther <mikelawther@chromium.org>

Reviewed by Ojan Vafai.

Fix IR->SR typo in enum value (and resulting style fails)
https://bugs.webkit.org/show_bug.cgi?id=59779

No functionality change, so no new tests

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EShapeRendering):
9:02 AM Changeset in webkit [85326] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Pavel Feldman <pfeldman@google.com>

Not reviewed: skip new flaky inspector tests for resource tree model on GTK for now.

  • platform/gtk/Skipped:
8:56 AM Changeset in webkit [85325] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Pavel Feldman <pfeldman@google.com>

Not reviewed: skip flaky inspector tests for now.

  • platform/mac/Skipped:
8:35 AM Changeset in webkit [85324] by pfeldman@chromium.org
  • 5 edits
    6 adds in trunk

2011-04-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: CSS editing breaks when entering "color: rgb(1"
https://bugs.webkit.org/show_bug.cgi?id=59789

  • inspector/styles/styles-add-invalid-property-expected.txt: Added.
  • inspector/styles/styles-add-invalid-property.html: Added.
  • inspector/styles/styles-cancel-editing-expected.txt: Added.
  • inspector/styles/styles-cancel-editing.html: Added.
  • inspector/styles/styles-commit-editing-expected.txt: Added.
  • inspector/styles/styles-commit-editing.html: Added.

2011-04-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: CSS editing breaks when entering "color: rgb(1"
https://bugs.webkit.org/show_bug.cgi?id=59789

Tests: inspector/styles/styles-add-invalid-property.html

inspector/styles/styles-cancel-editing.html
inspector/styles/styles-commit-editing.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
7:39 AM Changeset in webkit [85323] by vestbo@webkit.org
  • 8 edits in trunk/Source

ENABLE(QT_BEARER) -> USE(QT_BEARER)

Reviewed by Simon Hausmann.

7:39 AM Changeset in webkit [85322] by vestbo@webkit.org
  • 5 edits in trunk/Source

ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)

Reviewed by Simon Hausmann.

6:15 AM Changeset in webkit [85321] by podivilov@chromium.org
  • 8 edits
    1 add in trunk

2011-04-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.navigate): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageLoaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/resources/test-navigation.html: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
6:06 AM Changeset in webkit [85320] by podivilov@chromium.org
  • 13 edits in trunk

2011-04-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: include script end line:column in scriptParsed parameters.
https://bugs.webkit.org/show_bug.cgi?id=59717

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/debugger-scripts.html:

2011-04-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: include script end line:column in scriptParsed parameters.
https://bugs.webkit.org/show_bug.cgi?id=59717

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h: (WebCore::InspectorDebuggerAgent::Script::Script):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  • inspector/front-end/Script.js: (WebInspector.Script):
5:36 AM Changeset in webkit [85319] by yurys@chromium.org
  • 27 edits in trunk

2011-04-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [protocol] Evaluate should expose thrown exception value
https://bugs.webkit.org/show_bug.cgi?id=59000

  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:

2011-04-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [protocol] Evaluate should expose thrown exception value
https://bugs.webkit.org/show_bug.cgi?id=59000

Each evaluation command may have either thrown or returned result. This is indicated
by wasThrown property in the protocol.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::makeEvalCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to the evaluation results.
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleCommandResult):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.evaluate):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
5:36 AM Changeset in webkit [85318] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename page as pageProxy in WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=59790

To avoid consufion between page client and page proxy. Also rename
some methods to webkitWebViewBase* for consistency.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseFinalize): (webkitWebViewBaseExpose): (webkitWebViewBaseDraw): (webkitWebViewBaseSizeAllocate): (webkitWebViewBaseFocusInEvent): (webkitWebViewBaseFocusOutEvent): (webkitWebViewBaseKeyPressEvent): (webkitWebViewBaseKeyReleaseEvent): (webkitWebViewBaseButtonPressEvent): (webkitWebViewBaseButtonReleaseEvent): (webkitWebViewBaseScrollEvent): (webkitWebViewBaseMotionNotifyEvent): (webkit_web_view_base_class_init): (webkitWebViewBaseCreate): (webkitWebViewBaseGetPage):
5:21 AM Changeset in webkit [85317] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85315.
http://trac.webkit.org/changeset/85315
https://bugs.webkit.org/show_bug.cgi?id=59792

Broke script-formatter.html test (Requested by podivilov on
#webkit).

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85315.
http://trac.webkit.org/changeset/85315
https://bugs.webkit.org/show_bug.cgi?id=59792

Broke script-formatter.html test (Requested by podivilov on
#webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
4:43 AM Changeset in webkit [85316] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
https://bugs.webkit.org/show_bug.cgi?id=58794

Added ping requests to network panel.

  • http/tests/inspector/network/ping-expected.txt: Added.
  • http/tests/inspector/network/ping.html: Added.

2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
https://bugs.webkit.org/show_bug.cgi?id=58794

Added ping requests to network panel.

Test: http/tests/inspector/network/ping.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueAfterPingLoader):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.refreshResource): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get formParameters): (WebInspector.Resource.prototype.requestContentType): (WebInspector.Resource.prototype.isPingRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PingLoader.h:
4:35 AM Changeset in webkit [85315] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.navigate): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageLoaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
https://bugs.webkit.org/show_bug.cgi?id=59476

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
3:23 AM Changeset in webkit [85314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: Fix network panel timing/size/headers tests.
https://bugs.webkit.org/show_bug.cgi?id=59696

  • src/js/Tests.js: (.TestSuite.prototype.testNetworkSize.finishResource): (.TestSuite.prototype.testNetworkSyncSize.finishResource): (.TestSuite.prototype.testNetworkRawHeadersText.finishResource): (.TestSuite.prototype.testNetworkTiming.finishResource):
2:55 AM Changeset in webkit [85313] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement UI client in minibrowser
https://bugs.webkit.org/show_bug.cgi?id=58416

It also allows to open more than one minibrowser window from the
command line.

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowFinalize): (browser_window_init): (browserWindowConstructed): (createNewPage): (showPage): (closePage): (runJavaScriptAlert): (browserWindowUIClientInit):
  • MiniBrowser/gtk/main.c: (loadURI): (main):
2:34 AM Changeset in webkit [85312] by pfeldman@chromium.org
  • 14 edits in trunk/Source

2011-04-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add "open link in new tab" action into the network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=59788

This change also distinguishes context menu items case between platforms.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent): (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
  • inspector/front-end/inspector.js: (WebInspector.openLinkExternallyLabel): (WebInspector.openResource): (WebInspector.useLowerCaseMenuTitles):

2011-04-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add "open link in new tab" action into the network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=59788

This change also distinguishes context menu items case between platforms.

  • src/js/DevTools.js:
2:32 AM Changeset in webkit [85311] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk/Tools

2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement page loader client in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=58024

A new class BrowserWindow has been added to implement the page
loader client. It makes supporting multiple windows easier. Window
title and url entry are now updated during the loading process.

  • MiniBrowser/gtk/BrowserWindow.c: Added. (activateUriEntryCallback): (goBackCallback): (goForwardCallback): (browserWindowFinalize): (browserWindowGetProperty): (browserWindowSetProperty): (browser_window_init): (browserWindowConstructed): (browser_window_class_init): (browserWindowUpdateTitle): (browserWindowSetTitle): (browserWindowSetLoadProgress): (browserWindowUpdateURL): (didStartProvisionalLoadForFrame): (didReceiveServerRedirectForProvisionalLoadForFrame): (didFailProvisionalLoadWithErrorForFrame): (didCommitLoadForFrame): (didFinishDocumentLoadForFrame): (didFinishLoadForFrame): (didFailLoadWithErrorForFrame): (didReceiveTitleForFrame): (didFirstLayoutForFrame): (didFirstVisuallyNonEmptyLayoutForFrame): (didRemoveFrameFromHierarchy): (didStartProgress): (didChangeProgress): (didFinishProgress): (didBecomeUnresponsive): (didBecomeResponsive): (browserWindowLoaderClientInit): (browser_window_new): (browser_window_get_view):
  • MiniBrowser/gtk/BrowserWindow.h: Added.
  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c: (createWindow):
2:31 AM Changeset in webkit [85310] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/Settings.js

Merge 85272 - 2011-04-28 Ilya Tikhonovsky <loislo@chromium.org> Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630. * inspector/front-end/Settings.js: (WebInspector.Settings):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/6903137

12:18 AM Changeset in webkit [85309] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix a crash after r85214.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkit_web_view_base_init): Add line to create the page client instance, removed by mistake in r85214.
12:07 AM Changeset in webkit [85308] by slewis@apple.com
  • 2 edits in trunk/Tools

http://bugs.webkit.org/show_bug.cgi?id=59743
<rdar://problem/9040413> Add an install target for production builds.

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/PerlSupport/Makefile:

Apr 28, 2011:

11:53 PM Changeset in webkit [85307] by Adam Roben
  • 2 edits in trunk/Tools

Stop and restart ATSServer before each test run on Leopard

This is to work around an ATSServer leak that eventually causes tests
to fail.

Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
(due to ATSServer leak)

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(StopATSServer):
(StartATSServer):
Added these new commands to stop and start ATSServer.

(TestFactory.init): Stop and start ATSServer on Leopard before running tests.

11:42 PM Changeset in webkit [85306] by Adam Roben
  • 2 edits in trunk/LayoutTests

Unskip some tests that were failing due to local issues on the bots that have been resolved

See <http://webkit.org/b/51807> for details.

  • platform/mac-leopard/Skipped:
10:38 PM Changeset in webkit [85305] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a failing custom font test on Leopard

<http://webkit.org/b/59780> tracks the failure.

  • platform/mac-leopard/Skipped: Added fast/css/custom-font-xheight.html.
10:22 PM Changeset in webkit [85304] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a timing-out canvas test on Leopard

<http://webkit.org/b/59777> tracks the failure.

  • platform/mac-leopard/Skipped: Added fast/canvas/canvas-largedraws.html.
10:19 PM Changeset in webkit [85303] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

2011-04-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Mask placement on composited layer is incorrect sometimes
https://bugs.webkit.org/show_bug.cgi?id=59775

The mask layer always has the same size as its owning GraphicsLayer,
so it needs to share the same offsetFromRenderer as well. This fixes
the offset at which the mask layer contents are painted in cases where
that offset is non-zero, for example when outline style bloats all of
the layer sizes.

Test: compositing/masks/layer-mask-placement.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
9:57 PM Changeset in webkit [85302] by ddkilzer@apple.com
  • 9 edits in trunk/Source/WebKit/mac

<http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods

Reviewed by Anders Carlsson.

  • History/WebHistory.mm:

(-[WebHistoryPrivate init]):

  • Misc/WebElementDictionary.mm:

(-[WebElementDictionary initWithHitTestResult:]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):

  • Plugins/WebPluginController.mm:

(-[WebPluginController initWithDocumentView:]):

  • Plugins/WebPluginRequest.m:

(-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):

  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditCommand initWithEditCommand:]):

  • WebCoreSupport/WebJavaScriptTextInputPanel.m:

(-[WebJavaScriptTextInputPanel initWithPrompt:text:]):

  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

9:52 PM Changeset in webkit [85301] by Adam Roben
  • 5 edits
    4 deletes in trunk/LayoutTests

Move some mac-snowleopard results back up to mac

  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
  • platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
9:12 PM Changeset in webkit [85300] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted r81319.

Rubber-stamped by Mark Rowe.

Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu

  • page/NavigatorBase.cpp:
9:07 PM Changeset in webkit [85299] by simon.fraser@apple.com
  • 7 edits
    3 adds in trunk

2011-04-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dirk Schulze.

1px box-shadow looks ugly
https://bugs.webkit.org/show_bug.cgi?id=58100
and
ShadowBlur incorrectly handles zero-sized blur radius in one axis
https://bugs.webkit.org/show_bug.cgi?id=59710

blurLayerImage() has issues at the edges if the blur radius
is one, so in that case bump the buffer size out by a pixel.
This results in a correct, symmetrical blur.

Also fix an issue noticed during testing where a zero
height or width radius would still blur on that axis,
because we clamp the kernel size to a minimum of two.

Test: fast/box-shadow/single-pixel-shadow.html

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage): Skip horizontal or vertial passes if the radius on that axis is zero. Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())" clause to the end of the loop, since it only needs to execute once after the first pass. (WebCore::ShadowBlur::blurredEdgeSize): New method to compute the width of the blurred edge (radius + extra pixel when necessary). (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::templateSize): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawInsetShadow): (WebCore::ShadowBlur::drawInsetShadowWithTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::drawLayerPieces): Use the result of blurredEdgeSize() rather than recomputing.
9:04 PM Changeset in webkit [85298] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip all fast/dom/shadow tests on Mac

They seem to be causing later tests to crash. See <http://webkit.org/b/59571>.

  • platform/mac/Skipped:
8:43 PM Changeset in webkit [85297] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

add Leopard NRWT bot to the scheduler
https://bugs.webkit.org/show_bug.cgi?id=59766

  • BuildSlaveSupport/build.webkit.org-config/config.json:
8:36 PM Changeset in webkit [85296] by yael.aharon@nokia.com
  • 3 edits
    4 adds in trunk

2011-04-28 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Beth Dakin.

CSS sibling selector (~) does not work with :target pseudo class
https://bugs.webkit.org/show_bug.cgi?id=26539

  • fast/css/pseudo-target-indirect-sibling-001-expected.txt: Added.
  • fast/css/pseudo-target-indirect-sibling-001.html: Added.
  • fast/css/pseudo-target-indirect-sibling-002-expected.txt: Added.
  • fast/css/pseudo-target-indirect-sibling-002.html: Added.

2011-04-28 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Beth Dakin.

CSS sibling selector (~) does not work with :target pseudo class
https://bugs.webkit.org/show_bug.cgi?id=26539

Allow style recalculation of forward siblings of elements with
forward positional rules.

Tests: fast/css/pseudo-target-indirect-sibling-001.html

fast/css/pseudo-target-indirect-sibling-002.html

  • dom/Element.cpp: (WebCore::Element::recalcStyle):
8:33 PM Changeset in webkit [85295] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-04-28 Kamil Blank <k.blank@samsung.com>

Reviewed by Antonio Gomes.

New API for executing Editor Commands: InsertText, InsertImage.
https://bugs.webkit.org/show_bug.cgi?id=54439

  • ewk/ewk_view.cpp: (_ewk_view_editor_command): Added value parameter. (ewk_view_execute_editor_command): Added.
  • ewk/ewk_view.h: New API added.
8:32 PM Changeset in webkit [85294] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix WebKitTestRunner build.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

The Derived Sources target needs a product name.

8:24 PM Changeset in webkit [85293] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-28 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Install testapi.js along side testapi
https://bugs.webkit.org/show_bug.cgi?id=59773

  • JavaScriptCore.xcodeproj/project.pbxproj: Add new build phase to copy testapi.js to install path of testapi on install.
8:19 PM Changeset in webkit [85292] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-04-28 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=59626

  • platform/graphics/chromium/Extensions3DChromium.h: (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):

2011-04-28 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=59626

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM): (WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
  • src/GraphicsContext3DChromium.cpp: (WebCore::SwapBuffersCompleteCallbackAdapter::~SwapBuffersCompleteCallbackAdapter): (WebCore::SwapBuffersCompleteCallbackAdapter::SwapBuffersCompleteCallbackAdapter): (WebCore::SwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete): (WebCore::SwapBuffersCompleteCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setSwapBuffersCompleteCallbackCHROMIUM):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp:
7:34 PM Changeset in webkit [85291] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. More flakiness.

  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [85290] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-28 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732

  • platform/chromium/test_expectations.txt: Add expectations for affected tests.

2011-04-28 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
7:25 PM Changeset in webkit [85289] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-28 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border width and related properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=59414

No new tests as no functionality added.

  • css/CSSStyleApplyProperty.cpp: Separated ApplyPropertyDefault into parent and child so that other classes could inherit the applyInheritValue and applyInitialValue methods only. This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().

Added ApplyPropertyWidth class for handling width based CSS properties.

  • css/CSSStyleSelector.cpp: Removed no-longer-required code for handling width based CSS properties.
  • css/CSSStyleSelector.h: Added a getter for m_rootElementStyle.
7:24 PM Changeset in webkit [85288] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-28 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

CSS counters in :before pseudo-elements do not always update
https://bugs.webkit.org/show_bug.cgi?id=38291

The previous bug was solved so just landing the test case to ensure that
we don't regress it.

  • fast/css/counters/counter-before-content-not-incremented-expected.txt: Added.
  • fast/css/counters/counter-before-content-not-incremented.html: Added.
7:19 PM Changeset in webkit [85287] by jam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-28 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix silly bug with WebPermissionClient
https://bugs.webkit.org/show_bug.cgi?id=59769

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins): (WebKit::FrameLoaderClientImpl::allowImages):
7:15 PM Changeset in webkit [85286] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-28 Kent Tamura <tkent@chromium.org>

Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
6:58 PM Changeset in webkit [85285] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Suppress GPU failures - bug 59768, and
some fast/repaint/shadow failures that are
probably just rebaselines.

  • platform/chromium/test_expectations.txt:
6:38 PM Changeset in webkit [85284] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [85283] by mrowe@apple.com
  • 2 edits in tags/Safari-534.32/Source/JavaScriptCore

Merge r85265.

6:01 PM Changeset in webkit [85282] by mrowe@apple.com
  • 1 copy in tags/Safari-534.32

New tag.

6:01 PM Changeset in webkit [85281] by mrowe@apple.com
  • 1 delete in tags/Safari-534.32

Let's try this again.

6:00 PM Changeset in webkit [85280] by mrobinson@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixed a typo in the ChangeLog entry for my previous commit

5:57 PM Changeset in webkit [85279] by mrobinson@webkit.org
  • 5 edits in trunk

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Text underline is not shadowed when text-shadow is enabled
https://bugs.webkit.org/show_bug.cgi?id=48074

Updated pixel results for this test. They were previously incorrect
because text underlines were not shadowed.

  • platform/gtk/fast/text/stroking-decorations-expected.png:

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Text underline is not shadowed when text-shadow is enabled
https://bugs.webkit.org/show_bug.cgi?id=48074

Use ShadowContext to enable shadows for text underlines. Also remove quite a bit
of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
originally copied from the CG GraphicsContext.

  • platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we can call it from a static helper function.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper. (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to call it multiple times when shadowing text underlines. (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext. (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset. (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
5:56 PM Changeset in webkit [85278] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

5:54 PM Changeset in webkit [85277] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup WebCore.xcodeproj a bit.

Rubber-stamped by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:

Added CompilerVersion.xcconfig and moved some JS bindings files into the
correct sub groups.

5:54 PM Changeset in webkit [85276] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
5:53 PM Changeset in webkit [85275] by mrowe@apple.com
  • 1 copy in tags/Safari-534.32

New tag.

5:48 PM Changeset in webkit [85274] by weinig@apple.com
  • 5 edits in trunk/Tools

Add install support for WebKitTestRunner.
<rdar://problem/9349055>

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Add missing CompilerVersion.xcconfig.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Add install path and tell it not to skip installation.

Add missing CompilerVersion.xcconfig.

5:41 PM Changeset in webkit [85273] by levin@chromium.org
  • 21 edits
    4 deletes in trunk

Remove IMAGE_RESIZER related code.
https://bugs.webkit.org/show_bug.cgi?id=59735

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • html/AsyncImageResizer.cpp: Removed.
  • html/AsyncImageResizer.h: Removed.
  • html/ImageResizerThread.cpp: Removed.
  • html/ImageResizerThread.h: Removed.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
5:36 PM Changeset in webkit [85272] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-28 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.

5:30 PM Changeset in webkit [85271] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=59763
DFG JIT - Unify FPRReg & FPRegisterID

Reviewed by Oliver Hunt.

(Following on from GPRReg/RegisterID unification).

  • dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::checkConsistency):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::GPRResult::lockedResult):
(JSC::DFG::FPRResult::lockedResult):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:

(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::iterator::regID):
(JSC::DFG::RegisterBank::iterator::debugName):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
5:27 PM Changeset in webkit [85270] by Chris Fleizach
  • 4 edits in trunk/WebKitLibraries

Allow remote accessibility API for WK2 to build on SnowLeopard.
<rdar://problem/9324507>

Reviewed by Maciej Stachowiak.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:19 PM Changeset in webkit [85269] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Rolling out revision 85258! I want to fix that bug a different way.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

Rubber-stamped by Sam Weinig.

5:11 PM Changeset in webkit [85268] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Original patch by Austin Jennings.

Reviewed by Gavin Barraclough.

<rdar://problem/9350288>
Update sandbox profile for extension changes

  • WebProcess/com.apple.WebProcess.sb:
5:10 PM Changeset in webkit [85267] by commit-queue@webkit.org
  • 12 edits
    8 adds in trunk

2011-04-28 Chang Shu <cshu@webkit.org>

Reviewed by Eric Seidel.

isContentEditable is not working properly with document.designMode
https://bugs.webkit.org/show_bug.cgi?id=53031

  1. Added test cases for checking isContentEditable with designMode.
  2. Added a new test case for setting contenteditable attribute to "inherit" as the original code will cause a crash.
  3. Ryosuke Niwa also helped to fix test cases under editing/style that cause infinite loop.
  • editing/style/iframe-onload-crash-mac.html:
  • editing/style/iframe-onload-crash-unix.html:
  • editing/style/iframe-onload-crash-win.html:
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt:
  • fast/dom/HTMLElement/attr-invalid-string.html:
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt: Added.
  • fast/dom/HTMLElement/iscontenteditable-designmodeon.html: Added.

2011-04-28 Chang Shu <cshu@webkit.org>

Reviewed by Eric Seidel.

isContentEditable is not working properly with document.designMode
https://bugs.webkit.org/show_bug.cgi?id=53031

The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
indicates that the element.isContentEditable relies on document.designMode if its
and its ancestors' contenteditable attributes are set to inherit.

  1. Sync document render style after document.designMode is changed.
  2. Removed the code that does unnecessary and incorrect handling for contenteditable attribute with "inherit" value.
  3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.

Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html

fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
fast/dom/HTMLElement/iscontenteditable-designmodeon.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument):
  • dom/Document.cpp: (WebCore::Document::setDesignMode):
  • dom/Node.cpp: (WebCore::Node::rendererIsEditable):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable):
5:06 PM Changeset in webkit [85266] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85101.
http://trac.webkit.org/changeset/85101
https://bugs.webkit.org/show_bug.cgi?id=59757

it'd be better to rollout the patch and do another one with

another property name. Current one will bring us to a problem
at first run after upgrade because it's type was changed from
int to string. (Requested by loislo on #webkit).

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
5:03 PM Changeset in webkit [85265] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Revert "<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called"

This reverts commit r85195. It was crashing DumpRenderTree on Lion.

  • wtf/mac/MainThreadMac.mm:

(WTF::postTimer):

4:59 PM Changeset in webkit [85264] by commit-queue@webkit.org
  • 5 edits in trunk

2011-04-28 Mike Reed <reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas
https://bugs.webkit.org/show_bug.cgi?id=59700

  • platform/chromium/test_expectations.txt:

2011-04-28 Mike Reed <reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas -- skia only
https://bugs.webkit.org/show_bug.cgi?id=59700

Test:
canvas/philip/tests/2d.shadow.alpha.3.html
canvas/philip/tests/2d.shadow.alpha.4.html
canvas/philip/tests/2d.shadow.alpha.5.html
fast/canvas/canvas-fillPath-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/css/text-input-with-webkit-border-radius.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/canvas/canvas-getImageData.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
4:54 PM Changeset in webkit [85263] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper

Reviewed by Chris Fleizach.

Previously, AXObjectCache::attachWrapper over-retained each
AccessibilityObjectWrapper it created, which is why
AXObjectCache::detachWrapper() contained an extra -release.

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::detachWrapper): Removed extra -release.
(WebCore::AXObjectCache::attachWrapper): Because setWrapper()
assigns to a RetainPtr<> instance variable, it doesn't need a +1
retained object passed in. Fix the leak by using a RetainPtr<>
for the AccessibilityObjectWrapper.

4:53 PM Changeset in webkit [85262] by weinig@apple.com
  • 2 edits in trunk/Tools

Make reading skipped files from additional platform
directories work in WebKit2 mode.

Reviewed by Adam Roben.

  • Scripts/old-run-webkit-tests:

(buildPlatformTestHierarchy): Simplify logic to always use the first
and last platforms in the build hierarchy as the test hierarchy, and to
insert the WebKit2 platform in the middle if it exists. Yum.

4:49 PM Changeset in webkit [85261] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-28 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Compute compositor fps value and history using the frameBegin timestamp
https://bugs.webkit.org/show_bug.cgi?id=59668

This change switches the compositor FPS meter to use the timestamp
of the beginning of the frame rather than the time we call
swapBuffers. When scheduling is correctly tied to vsync, we can
have highly variable times when we finish vsync and still have
stable frame rates.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::drawFPSCounter): (WebCore::CCHeadsUpDisplay::onFrameBegin): (WebCore::CCHeadsUpDisplay::onPresent):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
4:46 PM Changeset in webkit [85260] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

fast/harness/results.html failing in some configurations
https://bugs.webkit.org/show_bug.cgi?id=59750

  • fast/harness/resources/results-test.js:
4:44 PM Changeset in webkit [85259] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-28 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Right-clicking on a Flash movie in an iframe shows the browser context menu
https://bugs.webkit.org/show_bug.cgi?id=59760
<rdar://problem/9340541>

Move context menu event handling out into a separate function. Make sure to call
EventHandler::sendContextMenuEvent on the event handler belonging to the frame of the
node that was clicked, and not the main frame.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::handleContextMenuEvent): (WebKit::handleMouseEvent):
4:36 PM Changeset in webkit [85258] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=59759
Overflow:scroll regions with overlay scrollbars show full thumb instead of just a
track when there is nothing to scroll to
<rdar://problem/9282066>

Reviewed by Darin Adler.

Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is
nothing to scroll to. Just dividing them to get a knob proportion yields 1, which
is not right. Set the proportion to 0 in this case instead.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

4:36 PM Changeset in webkit [85257] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/9291132> Add support for -epub-prefixed properties

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/epub-properties.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.

  • css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,

-webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
text-transform, text-transform, word-break, and -webkit-writing-mode.

LayoutTests:

  • fast/css/epub-properties-expected.txt: Added.
  • fast/css/epub-properties.html: Added.
4:28 PM Changeset in webkit [85256] by abarth@webkit.org
  • 82 edits
    10 deletes in trunk

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove WML configuration option from the CMake build system.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove build system integration and test harness integration for WML.

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove WML tests. These tests do not appear to be run on
build.webkit.org because none of the bots on build.webkit.org enable
WML.

  • fast/wml: Removed.
  • fast/wml/br-element-in-table.wml: Removed.
  • fast/wml/br-element-in-text.wml: Removed.
  • fast/wml/card-element.wml: Removed.
  • fast/wml/case-sensitivity.wml: Removed.
  • fast/wml/cdata-section.wml: Removed.
  • fast/wml/comment.wml: Removed.
  • fast/wml/do-element-optional-attr.wml: Removed.
  • fast/wml/do-shadow.wml: Removed.
  • fast/wml/do-template.wml: Removed.
  • fast/wml/entity.wml: Removed.
  • fast/wml/err-event-binding-conflict.wml: Removed.
  • fast/wml/err-invalid-location-for-varref.wml: Removed.
  • fast/wml/err-invalid-tablecolumn-number.wml: Removed.
  • fast/wml/err-invalid-variable-name.wml: Removed.
  • fast/wml/err-multi-access.wml: Removed.
  • fast/wml/err-multi-http-equiv-in-meta.wml: Removed.
  • fast/wml/err-multi-name-in-meta.wml: Removed.
  • fast/wml/err-multi-timer.wml: Removed.
  • fast/wml/err-samename-do.wml: Removed.
  • fast/wml/err-unallowed-task-in-anchor.wml: Removed.
  • fast/wml/fieldset.wml: Removed.
  • fast/wml/html-fieldset-crash.html: Removed.
  • fast/wml/img-localsrc.wml: Removed.
  • fast/wml/img-src-localsrc-alt.wml: Removed.
  • fast/wml/img-src.wml: Removed.
  • fast/wml/input.wml: Removed.
  • fast/wml/p-align.wml: Removed.
  • fast/wml/p-mode.wml: Removed.
  • fast/wml/resources: Removed.
  • fast/wml/resources/fail.png: Removed.
  • fast/wml/resources/pass.png: Removed.
  • fast/wml/select.wml: Removed.
  • fast/wml/show-first-card.wml: Removed.
  • fast/wml/table-element-align-attribute-invalid.wml: Removed.
  • fast/wml/table-element-columns-attribute-invalid-number.wml: Removed.
  • fast/wml/table-element-columns-attribute-invalid.wml: Removed.
  • fast/wml/table-element-columns-attribute-missing.wml: Removed.
  • fast/wml/table-element-columns-attribute.wml: Removed.
  • fast/wml/table-element.wml: Removed.
  • fast/wml/task-noop-in-do.wml: Removed.
  • fast/wml/test.wml: Removed.
  • fast/wml/text-emphasis.wml: Removed.
  • fast/wml/validate-dtd.wml: Removed.
  • http/tests/wml: Removed.
  • http/tests/wml/access-target-domain-deny-expected.txt: Removed.
  • http/tests/wml/access-target-domain-deny.html: Removed.
  • http/tests/wml/access-target-expected.txt: Removed.
  • http/tests/wml/access-target-path-deny-expected.txt: Removed.
  • http/tests/wml/access-target-path-deny.html: Removed.
  • http/tests/wml/access-target.html: Removed.
  • http/tests/wml/go-task-get-method-accept-charset-expected.txt: Removed.
  • http/tests/wml/go-task-get-method-accept-charset.html: Removed.
  • http/tests/wml/go-task-get-method-expected.txt: Removed.
  • http/tests/wml/go-task-get-method.html: Removed.
  • http/tests/wml/go-task-post-method-accept-charset-expected.txt: Removed.
  • http/tests/wml/go-task-post-method-accept-charset.html: Removed.
  • http/tests/wml/go-task-post-method-expected.txt: Removed.
  • http/tests/wml/go-task-post-method.html: Removed.
  • http/tests/wml/post-data-to-server-expected.txt: Removed.
  • http/tests/wml/post-data-to-server.html: Removed.
  • http/tests/wml/resources: Removed.
  • http/tests/wml/resources/access-target-domain-deny.wml: Removed.
  • http/tests/wml/resources/access-target-path-deny.wml: Removed.
  • http/tests/wml/resources/access-target.wml: Removed.
  • http/tests/wml/resources/answer-utf8.cgi: Removed.
  • http/tests/wml/resources/answer.cgi: Removed.
  • http/tests/wml/resources/dumpVariables.cgi: Removed.
  • http/tests/wml/resources/locked-deck.wml: Removed.
  • http/tests/wml/resources/unreachable-domain.wml: Removed.
  • http/tests/wml/resources/unreachable-path.wml: Removed.
  • http/tests/wml/script-tests: Removed.
  • http/tests/wml/script-tests/TEMPLATE.html: Removed.
  • http/tests/wml/script-tests/access-target-domain-deny.js: Removed.
  • http/tests/wml/script-tests/access-target-path-deny.js: Removed.
  • http/tests/wml/script-tests/access-target.js: Removed.
  • http/tests/wml/script-tests/go-task-get-method-accept-charset.js: Removed.
  • http/tests/wml/script-tests/go-task-get-method.js: Removed.
  • http/tests/wml/script-tests/go-task-post-method-accept-charset.js: Removed.
  • http/tests/wml/script-tests/go-task-post-method.js: Removed.
  • http/tests/wml/script-tests/post-data-to-server.js: Removed.
  • http/tests/xmlviewer/dumpAsText/wml-expected.txt: Removed.
  • http/tests/xmlviewer/dumpAsText/wml.xml: Removed.
  • platform/mac-leopard/fast/wml: Removed.
  • platform/mac-leopard/fast/wml/html-fieldset-crash-expected.png: Removed.
  • platform/mac/fast/wml: Removed.
  • platform/mac/fast/wml/br-element-in-table-expected.png: Removed.
  • platform/mac/fast/wml/br-element-in-table-expected.txt: Removed.
  • platform/mac/fast/wml/br-element-in-text-expected.png: Removed.
  • platform/mac/fast/wml/br-element-in-text-expected.txt: Removed.
  • platform/mac/fast/wml/card-element-expected.png: Removed.
  • platform/mac/fast/wml/card-element-expected.txt: Removed.
  • platform/mac/fast/wml/case-sensitivity-expected.png: Removed.
  • platform/mac/fast/wml/case-sensitivity-expected.txt: Removed.
  • platform/mac/fast/wml/cdata-section-expected.png: Removed.
  • platform/mac/fast/wml/cdata-section-expected.txt: Removed.
  • platform/mac/fast/wml/comment-expected.png: Removed.
  • platform/mac/fast/wml/comment-expected.txt: Removed.
  • platform/mac/fast/wml/do-element-optional-attr-expected.png: Removed.
  • platform/mac/fast/wml/do-element-optional-attr-expected.txt: Removed.
  • platform/mac/fast/wml/do-shadow-expected.png: Removed.
  • platform/mac/fast/wml/do-shadow-expected.txt: Removed.
  • platform/mac/fast/wml/do-template-expected.png: Removed.
  • platform/mac/fast/wml/do-template-expected.txt: Removed.
  • platform/mac/fast/wml/entity-expected.png: Removed.
  • platform/mac/fast/wml/entity-expected.txt: Removed.
  • platform/mac/fast/wml/err-event-binding-conflict-expected.png: Removed.
  • platform/mac/fast/wml/err-event-binding-conflict-expected.txt: Removed.
  • platform/mac/fast/wml/err-invalid-location-for-varref-expected.png: Removed.
  • platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt: Removed.
  • platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.png: Removed.
  • platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.txt: Removed.
  • platform/mac/fast/wml/err-invalid-variable-name-expected.png: Removed.
  • platform/mac/fast/wml/err-invalid-variable-name-expected.txt: Removed.
  • platform/mac/fast/wml/err-multi-access-expected.png: Removed.
  • platform/mac/fast/wml/err-multi-access-expected.txt: Removed.
  • platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.png: Removed.
  • platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.txt: Removed.
  • platform/mac/fast/wml/err-multi-name-in-meta-expected.png: Removed.
  • platform/mac/fast/wml/err-multi-name-in-meta-expected.txt: Removed.
  • platform/mac/fast/wml/err-multi-timer-expected.png: Removed.
  • platform/mac/fast/wml/err-multi-timer-expected.txt: Removed.
  • platform/mac/fast/wml/err-samename-do-expected.png: Removed.
  • platform/mac/fast/wml/err-samename-do-expected.txt: Removed.
  • platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.png: Removed.
  • platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.txt: Removed.
  • platform/mac/fast/wml/fieldset-expected.png: Removed.
  • platform/mac/fast/wml/fieldset-expected.txt: Removed.
  • platform/mac/fast/wml/html-fieldset-crash-expected.png: Removed.
  • platform/mac/fast/wml/html-fieldset-crash-expected.txt: Removed.
  • platform/mac/fast/wml/img-localsrc-expected.png: Removed.
  • platform/mac/fast/wml/img-localsrc-expected.txt: Removed.
  • platform/mac/fast/wml/img-src-expected.png: Removed.
  • platform/mac/fast/wml/img-src-expected.txt: Removed.
  • platform/mac/fast/wml/img-src-localsrc-alt-expected.png: Removed.
  • platform/mac/fast/wml/img-src-localsrc-alt-expected.txt: Removed.
  • platform/mac/fast/wml/input-expected.png: Removed.
  • platform/mac/fast/wml/input-expected.txt: Removed.
  • platform/mac/fast/wml/p-align-expected.png: Removed.
  • platform/mac/fast/wml/p-align-expected.txt: Removed.
  • platform/mac/fast/wml/p-mode-expected.png: Removed.
  • platform/mac/fast/wml/p-mode-expected.txt: Removed.
  • platform/mac/fast/wml/select-expected.png: Removed.
  • platform/mac/fast/wml/select-expected.txt: Removed.
  • platform/mac/fast/wml/show-first-card-expected.png: Removed.
  • platform/mac/fast/wml/show-first-card-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-align-attribute-invalid-expected.png: Removed.
  • platform/mac/fast/wml/table-element-align-attribute-invalid-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-expected.png: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.png: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.png: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-missing-expected.png: Removed.
  • platform/mac/fast/wml/table-element-columns-attribute-missing-expected.txt: Removed.
  • platform/mac/fast/wml/table-element-expected.png: Removed.
  • platform/mac/fast/wml/table-element-expected.txt: Removed.
  • platform/mac/fast/wml/task-noop-in-do-expected.png: Removed.
  • platform/mac/fast/wml/task-noop-in-do-expected.txt: Removed.
  • platform/mac/fast/wml/test-expected.png: Removed.
  • platform/mac/fast/wml/test-expected.txt: Removed.
  • platform/mac/fast/wml/text-emphasis-expected.png: Removed.
  • platform/mac/fast/wml/text-emphasis-expected.txt: Removed.
  • platform/mac/fast/wml/validate-dtd-expected.png: Removed.
  • platform/mac/fast/wml/validate-dtd-expected.txt: Removed.
  • wml: Removed.
  • wml/access-target-deny-expected.txt: Removed.
  • wml/access-target-deny.html: Removed.
  • wml/access-target-expected.txt: Removed.
  • wml/access-target.html: Removed.
  • wml/enter-card-with-events-expected.txt: Removed.
  • wml/enter-card-with-events.html: Removed.
  • wml/enter-first-card-with-events-expected.txt: Removed.
  • wml/enter-first-card-with-events.html: Removed.
  • wml/go-task-get-method-external-deck-expected.txt: Removed.
  • wml/go-task-get-method-external-deck-with-href-expected.txt: Removed.
  • wml/go-task-get-method-external-deck-with-href.html: Removed.
  • wml/go-task-get-method-external-deck.html: Removed.
  • wml/go-task-get-method-same-deck-expected.txt: Removed.
  • wml/go-task-get-method-same-deck.html: Removed.
  • wml/input-format-expected.txt: Removed.
  • wml/input-format.html: Removed.
  • wml/newcontext-same-deck-expected.txt: Removed.
  • wml/newcontext-same-deck.html: Removed.
  • wml/onenterforward-event-expected.txt: Removed.
  • wml/onenterforward-event.html: Removed.
  • wml/onenterforward-inline-event-expected.txt: Removed.
  • wml/onenterforward-inline-event.html: Removed.
  • wml/ontimer-event-expected.txt: Removed.
  • wml/ontimer-event.html: Removed.
  • wml/ontimer-inline-event-expected.txt: Removed.
  • wml/ontimer-inline-event.html: Removed.
  • wml/option-element-onpick-expected.txt: Removed.
  • wml/option-element-onpick-recursion-expected.txt: Removed.
  • wml/option-element-onpick-recursion.html: Removed.
  • wml/option-element-onpick.html: Removed.
  • wml/resources: Removed.
  • wml/resources/WMLTestCase.js: Removed.
  • wml/resources/access-target-deny.wml: Removed.
  • wml/resources/access-target.wml: Removed.
  • wml/resources/enter-card-with-events.wml: Removed.
  • wml/resources/enter-first-card-with-events.wml: Removed.
  • wml/resources/external-deck.wml: Removed.
  • wml/resources/locked-deck.wml: Removed.
  • wml/resources/newcontext-same-deck.wml: Removed.
  • wml/resources/onenterforward-event.wml: Removed.
  • wml/resources/onenterforward-inline-event.wml: Removed.
  • wml/resources/ontimer-event.wml: Removed.
  • wml/resources/ontimer-inline-event.wml: Removed.
  • wml/resources/option-element-onpick-recursion.wml: Removed.
  • wml/resources/test-document.wml: Removed.
  • wml/script-tests: Removed.
  • wml/script-tests/TEMPLATE.html: Removed.
  • wml/script-tests/access-target-deny.js: Removed.
  • wml/script-tests/access-target.js: Removed.
  • wml/script-tests/enter-card-with-events.js: Removed.
  • wml/script-tests/enter-first-card-with-events.js: Removed.
  • wml/script-tests/go-task-get-method-external-deck-with-href.js: Removed.
  • wml/script-tests/go-task-get-method-external-deck.js: Removed.
  • wml/script-tests/go-task-get-method-same-deck.js: Removed.
  • wml/script-tests/input-format.js: Removed.
  • wml/script-tests/newcontext-same-deck.js: Removed.
  • wml/script-tests/onenterforward-event.js: Removed.
  • wml/script-tests/onenterforward-inline-event.js: Removed.
  • wml/script-tests/ontimer-event.js: Removed.
  • wml/script-tests/ontimer-inline-event.js: Removed.
  • wml/script-tests/option-element-onpick-recursion.js: Removed.
  • wml/script-tests/option-element-onpick.js: Removed.
  • wml/script-tests/select-element-variables.js: Removed.
  • wml/script-tests/variable-reference-invalid-character.js: Removed.
  • wml/script-tests/variable-reference-valid.js: Removed.
  • wml/select-element-variables-expected.txt: Removed.
  • wml/select-element-variables.html: Removed.
  • wml/variable-reference-invalid-character-expected.txt: Removed.
  • wml/variable-reference-invalid-character.html: Removed.
  • wml/variable-reference-valid-expected.txt: Removed.
  • wml/variable-reference-valid.html: Removed.

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove the WML configuration option from the Mac build system.

  • Configurations/FeatureDefines.xcconfig:

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove WML-related enumeration.

  • Interfaces/IWebFramePrivate.idl:

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove WML-related configuration options and private APIs.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.mm: (stringForMessageSource):
  • WebView/WebFramePrivate.h:
  • WebView/WebUIDelegatePrivate.h:

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

This patch removes WML from WebCore. After removing WML, there's a
bunch of twisted code that could be untwisted, but this patch contains
only the purely mechanical part of removing the feature.

There's been a lot of discussion on webkit-dev about whether we should
remove WML. In addition to those threads, we've had an informal poll
of the reviewers as well as an in-person discussion at the WebKit
contributor's meeting. Removing any feature is likely to make some
folks unhappy, but, on balance, removing WML appears to be the right
thing for the project to do at this time.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::linkAttribute): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/wml.css: Removed.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::isMediaDocument):
  • dom/Document.idl:
  • dom/InputElement.h:
  • dom/Node.cpp: (WebCore::Node::toInputElement):
  • dom/Node.h:
  • dom/OptionElement.cpp: (WebCore::toOptionElement): (WebCore::isOptionElement):
  • dom/OptionElement.h:
  • dom/OptionGroupElement.cpp: (WebCore::toOptionGroupElement): (WebCore::isOptionGroupElement):
  • dom/SelectElement.cpp: (WebCore::toSelectElement):
  • dom/SelectElement.h:
  • dom/Text.cpp: (WebCore::Text::attach):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::internalSubset): (WebCore::getEntityHandler):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::parseDtd):
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
  • features.pri:
  • history/BackForwardList.h:
  • history/BackForwardListImpl.cpp:
  • history/BackForwardListImpl.h:
  • history/PageCache.cpp: (WebCore::PageCache::canCachePageContainingThisFrame):
  • html/HTMLAnchorElement.h:
  • inspector/ConsoleMessage.cpp: (WebCore::messageSourceValue):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toString):
  • loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::loadDifferentDocumentItem): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoaderTypes.h:
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreDocumentState):
  • manual-tests/wml: Removed.
  • manual-tests/wml/StartTests.wml: Removed.
  • manual-tests/wml/a-br-element.wml: Removed.
  • manual-tests/wml/a-element.wml: Removed.
  • manual-tests/wml/a-img-element.wml: Removed.
  • manual-tests/wml/access-target.wml: Removed.
  • manual-tests/wml/anchor-br-element.wml: Removed.
  • manual-tests/wml/anchor-element.wml: Removed.
  • manual-tests/wml/anchor-img-element.wml: Removed.
  • manual-tests/wml/card-newcontext-attr.wml: Removed.
  • manual-tests/wml/card-onenterbackward.wml: Removed.
  • manual-tests/wml/card-onenterforward.wml: Removed.
  • manual-tests/wml/card-ontimer.wml: Removed.
  • manual-tests/wml/deck-access-control.wml: Removed.
  • manual-tests/wml/input-format.wml: Removed.
  • manual-tests/wml/onevent-go.wml: Removed.
  • manual-tests/wml/onevent-noop.wml: Removed.
  • manual-tests/wml/onevent-prev.wml: Removed.
  • manual-tests/wml/onevent-refresh.wml: Removed.
  • manual-tests/wml/onevent-shadow.wml: Removed.
  • manual-tests/wml/resources: Removed.
  • manual-tests/wml/resources/smiley.png: Removed.
  • manual-tests/wml/select-element.wml: Removed.
  • manual-tests/wml/select-onpick-event-crash.wml: Removed.
  • manual-tests/wml/select-onpick-event.wml: Removed.
  • manual-tests/wml/setvar-element.wml: Removed.
  • manual-tests/wml/targetdeck.wml: Removed.
  • manual-tests/wml/task-go-in-anchor.wml: Removed.
  • manual-tests/wml/task-prev-in-anchor.wml: Removed.
  • manual-tests/wml/task-refresh-in-anchor.wml: Removed.
  • manual-tests/wml/template-go.wml: Removed.
  • manual-tests/wml/template-ontimer.wml: Removed.
  • manual-tests/wml/timer.wml: Removed.
  • manual-tests/wml/variable-substitution.wml: Removed.
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix):
  • page/Console.h:
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Page.cpp:
  • page/Page.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/network/FormDataBuilder.h:
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
  • platform/wince/MIMETypeRegistryWinCE.cpp: (WebCore::initMIMETypeEntensionMap):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink):
  • rendering/RenderBox.cpp:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateFromElement):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::updateAltText):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isLegend): (WebCore::RenderObject::offsetParent):
  • wml: Removed.
  • wml/WMLAElement.cpp: Removed.
  • wml/WMLAElement.h: Removed.
  • wml/WMLAccessElement.cpp: Removed.
  • wml/WMLAccessElement.h: Removed.
  • wml/WMLAnchorElement.cpp: Removed.
  • wml/WMLAnchorElement.h: Removed.
  • wml/WMLAttributeNames.in: Removed.
  • wml/WMLBRElement.cpp: Removed.
  • wml/WMLBRElement.h: Removed.
  • wml/WMLCardElement.cpp: Removed.
  • wml/WMLCardElement.h: Removed.
  • wml/WMLDoElement.cpp: Removed.
  • wml/WMLDoElement.h: Removed.
  • wml/WMLDocument.cpp: Removed.
  • wml/WMLDocument.h: Removed.
  • wml/WMLElement.cpp: Removed.
  • wml/WMLElement.h: Removed.
  • wml/WMLErrorHandling.cpp: Removed.
  • wml/WMLErrorHandling.h: Removed.
  • wml/WMLEventHandlingElement.cpp: Removed.
  • wml/WMLEventHandlingElement.h: Removed.
  • wml/WMLFieldSetElement.cpp: Removed.
  • wml/WMLFieldSetElement.h: Removed.
  • wml/WMLFormControlElement.cpp: Removed.
  • wml/WMLFormControlElement.h: Removed.
  • wml/WMLGoElement.cpp: Removed.
  • wml/WMLGoElement.h: Removed.
  • wml/WMLImageElement.cpp: Removed.
  • wml/WMLImageElement.h: Removed.
  • wml/WMLImageLoader.cpp: Removed.
  • wml/WMLImageLoader.h: Removed.
  • wml/WMLInputElement.cpp: Removed.
  • wml/WMLInputElement.h: Removed.
  • wml/WMLInsertedLegendElement.cpp: Removed.
  • wml/WMLInsertedLegendElement.h: Removed.
  • wml/WMLIntrinsicEvent.cpp: Removed.
  • wml/WMLIntrinsicEvent.h: Removed.
  • wml/WMLIntrinsicEventHandler.cpp: Removed.
  • wml/WMLIntrinsicEventHandler.h: Removed.
  • wml/WMLMetaElement.cpp: Removed.
  • wml/WMLMetaElement.h: Removed.
  • wml/WMLNoopElement.cpp: Removed.
  • wml/WMLNoopElement.h: Removed.
  • wml/WMLOnEventElement.cpp: Removed.
  • wml/WMLOnEventElement.h: Removed.
  • wml/WMLOptGroupElement.cpp: Removed.
  • wml/WMLOptGroupElement.h: Removed.
  • wml/WMLOptionElement.cpp: Removed.
  • wml/WMLOptionElement.h: Removed.
  • wml/WMLPElement.cpp: Removed.
  • wml/WMLPElement.h: Removed.
  • wml/WMLPageState.cpp: Removed.
  • wml/WMLPageState.h: Removed.
  • wml/WMLPostfieldElement.cpp: Removed.
  • wml/WMLPostfieldElement.h: Removed.
  • wml/WMLPrevElement.cpp: Removed.
  • wml/WMLPrevElement.h: Removed.
  • wml/WMLRefreshElement.cpp: Removed.
  • wml/WMLRefreshElement.h: Removed.
  • wml/WMLSelectElement.cpp: Removed.
  • wml/WMLSelectElement.h: Removed.
  • wml/WMLSetvarElement.cpp: Removed.
  • wml/WMLSetvarElement.h: Removed.
  • wml/WMLTableElement.cpp: Removed.
  • wml/WMLTableElement.h: Removed.
  • wml/WMLTagNames.in: Removed.
  • wml/WMLTaskElement.cpp: Removed.
  • wml/WMLTaskElement.h: Removed.
  • wml/WMLTemplateElement.cpp: Removed.
  • wml/WMLTemplateElement.h: Removed.
  • wml/WMLTimerElement.cpp: Removed.
  • wml/WMLTimerElement.h: Removed.
  • wml/WMLVariables.cpp: Removed.
  • wml/WMLVariables.h: Removed.

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678

Remove WML-related code in WebKit2.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
  • WebProcess/WebPage/WebBackForwardListProxy.h:
4:14 PM Changeset in webkit [85255] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

use a hierarchical data structure to store results json
https://bugs.webkit.org/show_bug.cgi?id=59736

Instead of a map from test name to results dict, we now store a hierarchical
data structure.

Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
New:
{ foo: {

bar: {

baz.html: results_dict,
baz2.html: results_dict } } }

This cut ~52% of the size of times_ms.json. I expect it will cut
30-40% of full_results.json and unexpected_results.json.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Using os.sep was just wrong since relative_test_filename canonicalizes separators.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py: Instead of plumbing through the change to all of the rebaselineserver python and JS, just convert to the old format after reading in the json.
4:12 PM Changeset in webkit [85254] by ojan@chromium.org
  • 11 edits in trunk

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

use a hierarchical data structure to store results json
https://bugs.webkit.org/show_bug.cgi?id=59736

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

use a hierarchical data structure to store results json
https://bugs.webkit.org/show_bug.cgi?id=59736

Instead of a map from test name to results dict, we now store a hierarchical
data structure.

Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
New:
{ foo: {

bar: {

baz.html: results_dict,
baz2.html: results_dict } } }

This cut ~52% of the size of times_ms.json. I expect it will cut
30-40% of full_results.json and unexpected_results.json.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Using os.sep was just wrong since relative_test_filename canonicalizes separators.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py: Instead of plumbing through the change to all of the rebaselineserver python and JS, just convert to the old format after reading in the json.
4:04 PM Changeset in webkit [85253] by levin@chromium.org
  • 15 edits
    3 deletes in trunk/Source

2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85233 and r85235.
http://trac.webkit.org/changeset/85233
http://trac.webkit.org/changeset/85235
https://bugs.webkit.org/show_bug.cgi?id=59754

Causes issues with jsc. (Requested by dave_levin on #webkit).

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::ExecutablePool):
  • parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • wtf/CMakeLists.txt:
  • wtf/RefCounted.h: (WTF::RefCountedBase::ref): (WTF::RefCountedBase::hasOneRef): (WTF::RefCountedBase::refCount): (WTF::RefCountedBase::derefBase):
  • wtf/SizeLimits.cpp:
  • wtf/ThreadRestrictionVerifier.h: Removed.
  • wtf/text/CString.h: (WTF::CStringBuffer::CStringBuffer):

2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85233 and r85235.
http://trac.webkit.org/changeset/85233
http://trac.webkit.org/changeset/85235
https://bugs.webkit.org/show_bug.cgi?id=59754

Causes issues with jsc. (Requested by dave_levin on #webkit).

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.

2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85233 and r85235.
http://trac.webkit.org/changeset/85233
http://trac.webkit.org/changeset/85235
https://bugs.webkit.org/show_bug.cgi?id=59754

Causes issues with jsc. (Requested by dave_levin on #webkit).

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::readFromDatabase):
4:01 PM Changeset in webkit [85252] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

WebKit2: Frequent crashes in acceptsFirstMouse
https://bugs.webkit.org/show_bug.cgi?id=59746
<rdar://problem/9281270>

The crash occurred when connection was null (and it can become null at any time).

Added checks for the proxy being valid in all sync calls that lacked such.
WebPageProxy::isValid() is not the same as WebProcessProxy::isValid(), but existing checks
looked at the former, so I used that.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): (WebKit::WebPageProxy::getSelectedText): (WebKit::WebPageProxy::gestureWillBegin): (WebKit::WebPageProxy::createSnapshotOfVisibleContent):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setComposition): (WebKit::WebPageProxy::confirmComposition): (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection): (WebKit::WebPageProxy::insertText): (WebKit::WebPageProxy::getMarkedRange): (WebKit::WebPageProxy::getSelectedRange): (WebKit::WebPageProxy::getAttributedSubstringFromRange): (WebKit::WebPageProxy::characterIndexForPoint): (WebKit::WebPageProxy::firstRectForCharacterRange): (WebKit::WebPageProxy::executeKeypressCommands): (WebKit::WebPageProxy::writeSelectionToPasteboard): (WebKit::WebPageProxy::readSelectionFromPasteboard): (WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent): (WebKit::WebPageProxy::acceptsFirstMouse):
3:59 PM Changeset in webkit [85251] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-04-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS bubbles should show "submit to ews" button if they've not been processed
https://bugs.webkit.org/show_bug.cgi?id=59751

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/submittoews.py:
  • QueueStatusServer/templates/statusbubble.html:
  • QueueStatusServer/templates/submittoews.html:
3:33 PM Changeset in webkit [85250] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
https://bugs.webkit.org/show_bug.cgi?id=59747

Reviewed by Timothy Hatcher.

Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWebInspector:]):
(-[WebInspectorWindowController showErrorConsole:]):
(-[WebInspectorWindowController toggleDebuggingJavaScript:]):
(-[WebInspectorWindowController toggleProfilingJavaScript:]):
(-[WebInspectorWindowController validateUserInterfaceItem:]):

3:31 PM Changeset in webkit [85249] by barraclough@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

Bug 59740 - DFG JIT - Unify GPRReg & RegisterID

Reviewed by Oliver Hunt.

Currently we use a mix of enum values throughout the DFG JIT to represent
gpr registers - the RegisterID provided by the MacroAssembler, and the
GPRReg enum giving the sequential register set over which the RegisterBank
allocates. Unify the two.

Patch to unify FPRReg in a similar fashion will follow.

(JSC::DFG::next):
(JSC::DFG::FPRBankInfo::toRegister):
(JSC::DFG::FPRBankInfo::toIndex):

  • dfg/DFGGPRInfo.h: Added.

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::bitOp):
(JSC::DFG::JITCodeGenerator::shiftOp):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::DoubleOperand::gpr):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::gpr):
(JSC::DFG::GPRResult::lockedResult):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::preserveReturnAddressAfterCall):
(JSC::DFG::JITCompiler::restoreReturnAddressBeforeReturn):
(JSC::DFG::JITCompiler::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::JITCompiler::emitPutToCallFrameHeader):
(JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
(JSC::DFG::JITCompiler::addressForGlobalVar):
(JSC::DFG::JITCompiler::addressFor):
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:

(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::allocate):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::release):
(JSC::DFG::RegisterBank::lock):
(JSC::DFG::RegisterBank::unlock):
(JSC::DFG::RegisterBank::isLocked):
(JSC::DFG::RegisterBank::name):
(JSC::DFG::RegisterBank::iterator::name):
(JSC::DFG::RegisterBank::iterator::isLocked):
(JSC::DFG::RegisterBank::iterator::release):
(JSC::DFG::RegisterBank::iterator::gpr):
(JSC::DFG::RegisterBank::iterator::debugName):
(JSC::DFG::RegisterBank::iterator::operator++):
(JSC::DFG::RegisterBank::iterator::operator!=):
(JSC::DFG::RegisterBank::iterator::index):
(JSC::DFG::RegisterBank::iterator::iterator):
(JSC::DFG::RegisterBank::begin):
(JSC::DFG::RegisterBank::end):
(JSC::DFG::RegisterBank::isLockedAtIndex):
(JSC::DFG::RegisterBank::nameAtIndex):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::~ScoreBoard):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateIntegerOperand::gpr):

3:31 PM Changeset in webkit [85248] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer

Reviewed by Dan Bernstein.

  • WebView/WebFullScreenController.mm:

(-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
Use a RetainPtr to hold the CALayer and to fix the leak.

3:22 PM Changeset in webkit [85247] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-04-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS Bubbles should show commit-queue position when patch is in the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=59744

This was actually just a 2 line change to statusbubble.py.
I also cleaned up statusbubble.html a little while I was there
(the links are now actual <a> tags and have hover).

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/templates/statusbubble.html:
3:18 PM Changeset in webkit [85246] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

add a mac leopard release NRWT bot
https://bugs.webkit.org/show_bug.cgi?id=59733

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:05 PM Changeset in webkit [85245] by bweinstein@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

Mac side of: WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>

Reviewed by Timothy Hatcher.

Implement docking of the Web Inspector on Mac. This matches the Windows (WK1 and WK2) closely,
where the inspector and the inspected view are siblings.

  • UIProcess/API/C/mac: Added.
  • UIProcess/API/C/mac/WKInspectorMac.h: Added.
  • UIProcess/API/mac/PageClientImpl.h:

(WebKit::PageClientImpl::wkView): Returns the WKView.

  • UIProcess/PageClient.h:
  • UIProcess/WebInspectorProxy.h: The inspected view is now a WebInspectorWKView, so we can override tag.
  • UIProcess/WebPageProxy.h: Added a getter for the WKView.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Calls through to WebInspectorProxy::inspectedViewFrameDidChange.
(-[WebInspectorWKView tag]): Returns a constant defined in WKInspectorMac.h.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WebInspectorWKView instead of a WKView.
(WebKit::WebInspectorProxy::platformClose): Removed a FIXME that isn't needed anymore (we always detach before closing).
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Place our inspector and the inspected view next to each other, assuming the

bottom of the inspector is at the Y origin.

(WebKit::WebInspectorProxy::platformAttach): Listen for changes to the inspected view's frame, and move the inspectorView from the

detached inspector window to the superview of the inspected view (to make the inspector and inspected view siblings).

(WebKit::WebInspectorProxy::platformDetach): Stop listening for changes to the inspected view's frame, and move the inspectorView

back to the detached inspector window. We also resize the inspected view to take up the space the inspector took up before
(assuming the bottom of the inspector was at the Y origin).

(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Resize the inspector's view, and call inspectedViewFrameDidChange (which

syncs the inspector and the inspected view), and call setNeedsDisplay on both views.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::wkView):

  • WebKit2.xcodeproj/project.pbxproj: Add a new file.
3:03 PM Changeset in webkit [85244] by abarth@webkit.org
  • 17 edits
    13 adds in trunk/Source

2011-04-28 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Introducing a new class that allows serialization of a page back
to HTML/XML with all its sub-frames and also retrieves the page's
resources.
Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=58947

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • dom/Document.cpp: (WebCore::Document::suggestedMIMEType):
  • dom/Document.h:
  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::appendCustomAttributes): (WebCore::MarkupAccumulator::appendElement):
  • editing/MarkupAccumulator.h:
  • html/parser/HTMLMetaCharsetParser.cpp: (WebCore::HTMLMetaCharsetParser::processMeta): (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
  • html/parser/HTMLMetaCharsetParser.h:
  • page/PageSerializer.cpp: Added.
  • page/PageSerializer.h: Added.

2011-04-28 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Introducing a new API to serialize a WebView back to HTML.
https://bugs.webkit.org/show_bug.cgi?id=58947

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize):
  • tests/WebPageNewSerializerTest.cpp: Added.
  • tests/data/pageserializer: Added.
  • tests/data/pageserializer/blank_frames.html: Added.
  • tests/data/pageserializer/blue_background.png: Added.
  • tests/data/pageserializer/css_test_page.html: Added.
  • tests/data/pageserializer/green_background.png: Added.
  • tests/data/pageserializer/iframe.html: Added.
  • tests/data/pageserializer/iframe2.html: Added.
  • tests/data/pageserializer/import_style_from_link.css: Added.
  • tests/data/pageserializer/import_styles.css: Added.
  • tests/data/pageserializer/link_styles.css: Added.
  • tests/data/pageserializer/ol-dot.png: Added.
  • tests/data/pageserializer/orange_background.png: Added.
  • tests/data/pageserializer/purple_background.png: Added.
  • tests/data/pageserializer/red_background.png: Added.
  • tests/data/pageserializer/simple.xhtml: Added.
  • tests/data/pageserializer/top_frame.html: Added.
  • tests/data/pageserializer/ul-dot.png: Added.
  • tests/data/pageserializer/yellow_background.png: Added.
3:01 PM Changeset in webkit [85243] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Crash under WKPageCreateSnapshotOfVisibleContent if there is no response from the Web Process
in the allotted time.
https://bugs.webkit.org/show_bug.cgi?id=59738

Reviewed by Darin Adler.

If the handle is null, don't try to create a ShareableBitmap and then a WebImage out of it.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createSnapshotOfVisibleContent):

2:43 PM Changeset in webkit [85242] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-28 Ojan Vafai <ojan@chromium.org>

Avoid crashing when running new-run-webkit-tests outside of
version control.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
2:40 PM Changeset in webkit [85241] by jam@chromium.org
  • 10 edits
    1 add in trunk/Source/WebKit/chromium

2011-04-28 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add a WebPermissionClient to be used for checking permissions of features
https://bugs.webkit.org/show_bug.cgi?id=59720

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowPlugins): (WebKit::WebFrameClient::didNotAllowPlugins): (WebKit::WebFrameClient::allowImages): (WebKit::WebFrameClient::allowScript): (WebKit::WebFrameClient::allowDatabase): (WebKit::WebFrameClient::didNotAllowScript):
  • public/WebPermissionClient.h: Added. (WebKit::WebPermissionClient::allowDatabase): (WebKit::WebPermissionClient::allowImages): (WebKit::WebPermissionClient::allowPlugins): (WebKit::WebPermissionClient::allowScript): (WebKit::WebPermissionClient::allowScriptExtension): (WebKit::WebPermissionClient::allowReadFromClipboard): (WebKit::WebPermissionClient::allowWriteToClipboard): (WebKit::WebPermissionClient::didNotAllowPlugins): (WebKit::WebPermissionClient::didNotAllowScript): (WebKit::WebPermissionClient::~WebPermissionClient):
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didEndEditing):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking): (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins): (WebKit::FrameLoaderClientImpl::allowImages): (WebKit::FrameLoaderClientImpl::didNotAllowScript): (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::enableContinuousSpellChecking):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setAutoFillClient): (WebKit::WebViewImpl::setPermissionClient): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::permissionClient):
2:37 PM Changeset in webkit [85240] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove evil addressOfStructure() function
https://bugs.webkit.org/show_bug.cgi?id=59739

Remove the addressOfStructure function from JSCell, and update
callsites to use the same logic as testPrototype()

  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList):
  • runtime/JSCell.h:
2:21 PM Changeset in webkit [85239] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-28 Kenneth Russell <kbr@google.com>

Unreviewed fix for Windows multi-DLL build.

  • WebKit.gyp:
2:12 PM Changeset in webkit [85238] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createIndex should fail if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=58365

  • storage/indexeddb/mozilla/create-index-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/create-index-null-name.html: Added.

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createIndex should fail if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=58365

Test: storage/indexeddb/mozilla/create-index-null-name.html

  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::createIndex):
2:02 PM Changeset in webkit [85237] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects

Addresses review comment from Darin Adler.

  • WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]): Use a local variable and -release
instead of -autorelease.

2:01 PM Changeset in webkit [85236] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Clean up testPrototype()
https://bugs.webkit.org/show_bug.cgi?id=59734

Remove direct pointer to the inside of a GC object and just do
the indirect load manually. Doesn't effect sunspider but does
clean up the code quite a bit, and simplifies the handling of
GC values.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::testPrototype):
1:54 PM Changeset in webkit [85235] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

  • wtf/RefCounted.h: Fix inverted ifdef.
1:49 PM Changeset in webkit [85234] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail if second (key) parameter is null
https://bugs.webkit.org/show_bug.cgi?id=58613

Added one test and fixed another that relied on old (broken) behavior
when passing null in second parameter.

  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail if second (key) parameter is null
https://bugs.webkit.org/show_bug.cgi?id=58613

If key arg is not specified, prpKey ends up as a null pointer in ::put().
However, if the key arg is specified but is null, prpKey ends up as a
valid IDBKey which has a null key type. As it happens, we need to be able
to detect the difference between these cases (the key arg is optional but
if specified must not be null).

Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put):
1:46 PM Changeset in webkit [85233] by levin@chromium.org
  • 15 edits
    3 adds in trunk/Source

Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Darin Adler.

Source/JavaScriptCore:

(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider): Ditto.

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp): Ditto.

  • wtf/CMakeLists.txt: Added new files to the build.
  • wtf/ThreadRestrictionVerifier.h: Added.

Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):

  • wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
  • wtf/text/CString.h:

(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium's test_shell (bug 58093).

Source/JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.

Source/WebCore:

No new functionality exposed so no new tests. (The change is basically adding
more testing.)

  • ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.

1:43 PM Changeset in webkit [85232] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Darin Fisher.

Port Mozilla's IndexedDB tests: versionchange event
https://bugs.webkit.org/show_bug.cgi?id=58738

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/versionchange-expected.txt: Added.
  • storage/indexeddb/mozilla/versionchange.html: Added.
1:20 PM Changeset in webkit [85231] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix a thinko - separateRealmLabel is not an NSImageView.

  • Panels/WebAuthenticationPanel.h:
1:14 PM Changeset in webkit [85230] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects

Reviewed by Dan Bernstein.

  • WebView/WebPDFView.mm:

(-[WebPDFView menuForEvent:]): Call -autorelease after copying
each NSMenuItem. Regressed in r9566 for Bug 3711.

1:00 PM Changeset in webkit [85229] by xan@webkit.org
  • 4 edits in trunk

2011-04-28 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

  • GNUmakefile.am:
12:54 PM Changeset in webkit [85228] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-28 Xan Lopez <xlopez@igalia.com>

Unreviewed attempt to fix the build.

  • GNUmakefile.am: add -lpthread.
12:42 PM Changeset in webkit [85227] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-28 Kenneth Russell <kbr@google.com>

Unreviewed test expectations update. Marked flaky and crashing tests.

  • platform/chromium/test_expectations.txt:
12:29 PM Changeset in webkit [85226] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Only need a single implementation of testPrototype
https://bugs.webkit.org/show_bug.cgi?id=59724

Remove excess copy of identical testPrototype() code

  • jit/JITPropertyAccess.cpp: (JSC::JIT::testPrototype):
  • jit/JITPropertyAccess32_64.cpp:
12:18 PM Changeset in webkit [85225] by xan@webkit.org
  • 4 edits
    1 add in trunk

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Add a pkg-config file for JavaScriptCoreGTK+.

  • configure.ac: generate the final pkg-config file from our .in file.

Source/WebKit/gtk:

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Add a pkg-config file for JavaScriptCoreGTK+.

  • GNUmakefile.am: take care of the pkg-config file.
  • javascriptcoregtk.pc.in: Added.
12:14 PM Changeset in webkit [85224] by xan@webkit.org
  • 9 edits in trunk

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Build JavaScriptCore as a libtool shared library instead of a
private convenience library.

  • GNUmakefile.am: remove convenience library definition for jsc.

Source/JavaScriptCore:

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Build JavaScriptCore as a libtool shared library instead of a
private convenience library.

  • GNUmakefile.am: define new jsc library and adapt to new name for javascriptcore target.
  • GNUmakefile.list.am: ditto.

Source/WebKit/gtk:

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Build JavaScriptCore as a libtool shared library instead of a
private convenience library.

  • GNUmakefile.am: adapt to new name for javascriptcore target.

Source/WebKit2:

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Build JavaScriptCore as a libtool shared library instead of a
private convenience library.

  • GNUmakefile.am: adapt to new name for javascriptcore target.
12:12 PM Changeset in webkit [85223] by beidson@apple.com
  • 12 edits
    2 adds in trunk/Source/WebKit2

<rdar://problem/8773946> and https://bugs.webkit.org/show_bug.cgi?id=59614
Client certificate authentication in WebKit2

Reviewed by Sam Weinig.

Project-file stuff:

  • WebKit2.xcodeproj/project.pbxproj:

Allow WKCredentials to store certificates:

  • UIProcess/Authentication/WebCredential.cpp:

(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::certificateInfo):

  • UIProcess/Authentication/WebCredential.h:

(WebKit::WebCredential::create):

  • UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreateWithCertificateInfo):

  • UIProcess/API/C/WKCredential.h:

Pass the certificate info over the wire to the WebProcess:

  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

Change the WebProcess to prefer certificate info over basic credentials when responding to a challenge:

  • WebProcess/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Stub for platforms other than Mac,

as only Mac can currently respond to challenges with certificates.

(WebKit::AuthenticationManager::useCredentialForChallenge):

  • WebProcess/Authentication/AuthenticationManager.h:
  • WebProcess/Authentication/AuthenticationManager.messages.in:
  • WebProcess/Authentication/mac: Added.
  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm: Added.

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Recreate the identity and certificate

chain and respond to the challenge with it.

Add a newly required #include:

  • UIProcess/API/C/WKAuthenticationChallenge.cpp:
  • UIProcess/Authentication/AuthenticationDecisionListener.cpp:
12:11 PM Changeset in webkit [85222] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

fix python printing test
https://bugs.webkit.org/show_bug.cgi?id=59719

Now that we run scm commands in summarize_results, --verbose prints
debug logging to stderr.

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
12:10 PM Changeset in webkit [85221] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-28 ojab <ojab@ojab.ru>

Reviewed by Martin Robinson.

Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore'
https://bugs.webkit.org/show_bug.cgi?id=59585

  • webkit/webkitwebviewprivate.h:
12:03 PM Changeset in webkit [85220] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-28 Kenneth Russell <kbr@google.com>

Unreviewed build fix for Web Audio with strict OwnPtr.

  • platform/audio/HRTFDatabaseLoader.cpp: (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
11:59 AM Changeset in webkit [85219] by xan@webkit.org
  • 2 edits in trunk

2011-04-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove C++0x compat mode warnings for GCC >= 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=59718

Hardcode -Wno-c++0x-compat for the default compiler (if version >=
4.6.0) until our codebase is ready.

  • configure.ac: do that.
11:58 AM Changeset in webkit [85218] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Momentum scroll tweak for WebKit.
https://bugs.webkit.org/show_bug.cgi?id=59723
<rdar://problem/9259933>

Reviewed by Beth Dakin.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.

11:48 AM Changeset in webkit [85217] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Tony Chang <tony@chromium.org>

Fix description in recently added test results.

  • storage/indexeddb/mozilla/key-requirements-expected.txt:
11:43 AM Changeset in webkit [85216] by Dimitri Glazkov
  • 3 edits
    1 delete in trunk

2011-04-28 Dominic Cooney <dominicc@chromium.org>

Reviewed by Geoffrey Garen.

Walk shadow hosts as well as parent nodes when finding opaque roots.
https://bugs.webkit.org/show_bug.cgi?id=59571

Remove expectation of failure.

  • platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Removed.

2011-04-28 Dominic Cooney <dominicc@chromium.org>

Reviewed by Geoffrey Garen.

Walk shadow hosts as well as parent nodes when finding opaque roots.
https://bugs.webkit.org/show_bug.cgi?id=59571

Test: fast/dom/shadow/gc-shadow.html

  • bindings/js/JSDOMBinding.h: (WebCore::root):
11:39 AM Changeset in webkit [85215] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-28 Dimitri Glazkov <Dimitri Glazkov>

Added the test results, missed in r85209.

  • platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.
11:37 AM Changeset in webkit [85214] by mrobinson@webkit.org
  • 9 edits
    2 adds in trunk/Source

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Click counting logic should be shared between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715

Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
into WebCore so that WebKit1 and WebKit2 can share the code.

No new tests. This is covered by fast/events/click-count.html.

  • GNUmakefile.list.am: Added new files.
  • platform/gtk/GtkClickCounter.cpp: Added. (WebCore::GtkClickCounter::GtkClickCounter): Added. (WebCore::GtkClickCounter::reset): Added. (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added. (WebCore::getEventTime): Added. (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
  • platform/gtk/GtkClickCounter.h: Added.

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Click counting logic should be shared between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715

Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
This allows the code to be shared between WebKit1 and WebKit2.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling the WebView private data directly.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Call into GtkClickCounter now. (webkit_web_view_init): Remove private member intialization.
  • webkit/webkitwebviewprivate.h: Remove unneeded private members.

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Click counting logic should be shared between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715

Use the GtkClickCounter instead of doing click counting manually. This means that
the code will now be shared between WebKit1 and WebKit2.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkit_web_view_base_init): Remove private member initialization. (webViewButtonPressEvent): Call into GtkClickCounter.
11:13 AM Changeset in webkit [85213] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):

11:08 AM Changeset in webkit [85212] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Allow specifying CSS property aliases in CSSPropertyNames.in files
https://bugs.webkit.org/show_bug.cgi?id=59712

Reviewed by Simon Fraser.

  • css/CSSParser.cpp:

(WebCore::cssPropertyID): Removed code to handle some aliases

  • css/CSSPropertyNames.in: Added aliases no longer handled in code.
  • css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as

defining an alias, and add an appropriate entry to the gperf file.

10:57 AM Changeset in webkit [85211] by mdelaney@apple.com
  • 1 edit
    3 adds
    3 deletes in trunk/LayoutTests

2011-04-28 Matthew Delaney <mdelaney@apple.com>

Reviewed by Brian Weinstein.

Push canvas tests' expected results down from platform/mac and into platform/mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=59654

  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
10:55 AM Changeset in webkit [85210] by ojan@chromium.org
  • 8 edits in trunk

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

link to tests at a specific revision in the results.html file
https://bugs.webkit.org/show_bug.cgi?id=59711

This matches old-run-webkit-tests.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:

2011-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

link to tests at a specific revision in the results.html file
https://bugs.webkit.org/show_bug.cgi?id=59711

  • Scripts/webkitpy/common/checkout/scm.py: Add a method to get the head svn revision.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Include the svn revision in the results json.
10:52 AM Changeset in webkit [85209] by Dimitri Glazkov
  • 4 edits in trunk/LayoutTests

2011-04-28 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Unskip fast/dom/shadow/gc-shadow.html on Mac with expected failure
https://bugs.webkit.org/show_bug.cgi?id=59647

  • fast/dom/shadow/gc-shadow.html: Actually GC the shadow roots now.
  • fast/dom/shadow/gc-shadow-expected.txt: Updated.
  • platform/mac/Skipped: Unskip gc-shadow.html.
  • platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.
10:49 AM Changeset in webkit [85208] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Build fix after r85197.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webViewExpose): Use cr.get() here. (webViewDraw): Small clean up.
10:49 AM Changeset in webkit [85207] by commit-queue@webkit.org
  • 6 edits in trunk

2011-04-28 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Soup] does not load css stylesheets without content-type
https://bugs.webkit.org/show_bug.cgi?id=59697

  • platform/gtk/Skipped: Enable now passing tests:
    • http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html
    • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html

2011-04-28 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Soup] does not load css stylesheets without content-type
https://bugs.webkit.org/show_bug.cgi?id=59697

When sniffing content type, do not replace http Content-Type header in
soup message anymore, but keep sniffed content type in a separate
variable.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::contentSniffedCallback):
  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::sniffedContentType): (WebCore::ResourceResponse::setSniffedContentType):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
10:40 AM Changeset in webkit [85206] by yael.aharon@nokia.com
  • 5 edits in trunk/Source

2011-04-28 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
https://bugs.webkit.org/show_bug.cgi?id=59704

No new tests, just code cleanup.

  • WebCore.pri:

2011-04-28 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
https://bugs.webkit.org/show_bug.cgi?id=59704

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
  • WebCoreSupport/QtFallbackWebPopup.h:
10:31 AM Changeset in webkit [85205] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update expected results for a hyphenation test

  • platform/mac/fast/text/hyphenate-limit-before-after-expected.txt:
10:20 AM Changeset in webkit [85204] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "Pretty print" source frame context menu item.
https://bugs.webkit.org/show_bug.cgi?id=59709

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
10:14 AM Changeset in webkit [85203] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add failing test to Leopard skipped list.
Will track using https://bugs.webkit.org/show_bug.cgi?id=51807

  • platform/mac-leopard/Skipped:
10:07 AM Changeset in webkit [85202] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another crashing shadow DOM test

<http://webkit.org/b/59708> tracks the failure. Maybe it will eventually be duped to
<http://webkit.org/b/59571>.

  • platform/mac/Skipped: Added fast/dom/shadow/nodetype.html.
10:01 AM Changeset in webkit [85201] by commit-queue@webkit.org
  • 18 edits in trunk/LayoutTests

2011-04-28 Leon Scroggins <scroggo@google.com>

Reviewed by Steve Block.

Rebaseline tests which look different due to a change in skia gradient calculations.
https://bugs.webkit.org/show_bug.cgi?id=59132

  • platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.png:
  • platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.png:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium-win/fast/gradients/background-clipped-expected.png:
  • platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/chromium/test_expectations.txt:
9:56 AM Changeset in webkit [85200] by Carlos Garcia Campos
  • 5 edits in trunk

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Sam Weinig.

[GTK] Remove WKURLCreateWithURL()
https://bugs.webkit.org/show_bug.cgi?id=59691

The name is a bit confusing and there's already
WKURLCreateWithUTF8CString() in the C API.

  • UIProcess/API/C/gtk/WKView.cpp:
  • UIProcess/API/C/gtk/WKView.h:

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Sam Weinig.

[GTK] Remove WKURLCreateWithURL()
https://bugs.webkit.org/show_bug.cgi?id=59691

Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().

  • MiniBrowser/gtk/main.c: (activateUriEntryCallback): (main):
9:53 AM Changeset in webkit [85199] by Carlos Garcia Campos
  • 7 edits
    1 copy in trunk/Source/WebKit2

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make WebKitWebViewBase public in the API
https://bugs.webkit.org/show_bug.cgi?id=59689

Add WebKitWebViewBasePrivate.h and move WebKitWebViewBase inernal
methods to it. Rename get_type() method, since it's part of the
public API and should follow gtk coding style.

  • GNUmakefile.am: Add WebKitWebViewBasePrivate.h.
  • UIProcess/API/C/gtk/WKView.cpp: Use WebKitWebViewBasePrivate.h.
  • UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseFinalize): (webkit_web_view_base_init): (webViewSizeAllocate): (webViewFocusInEvent): (webViewFocusOutEvent): (webViewKeyPressEvent): (webViewKeyReleaseEvent): (webkit_web_view_base_class_init):
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Copied from Source/WebKit2/UIProcess/API/C/gtk/WKView.cpp.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Use WebKitWebViewBasePrivate.h.
9:48 AM Changeset in webkit [85198] by Carlos Garcia Campos
  • 6 edits
    2 moves in trunk/Source/WebKit2

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move WebView to UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=59686

And rename it as PageClientImpl, since it's a page client
implementation, not a web view.

  • GNUmakefile.am:
  • UIProcess/API/C/gtk/WKView.cpp:
  • UIProcess/API/gtk/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebView.cpp. (WebKit::backspaceCallback): (WebKit::selectAllCallback): (WebKit::cutClipboardCallback): (WebKit::copyClipboardCallback): (WebKit::pasteClipboardCallback): (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::deleteFromCursorCallback): (WebKit::moveCursorCallback): (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::~PageClientImpl): (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): (WebKit::PageClientImpl::createDrawingAreaProxy): (WebKit::PageClientImpl::setViewNeedsDisplay): (WebKit::PageClientImpl::displayView): (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow): (WebKit::PageClientImpl::PageClientImpl::processDidCrash): (WebKit::PageClientImpl::didRelaunchProcess): (WebKit::PageClientImpl::takeFocus): (WebKit::PageClientImpl::toolTipChanged): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::clearAllEditCommands): (WebKit::PageClientImpl::canUndoRedo): (WebKit::PageClientImpl::executeUndoRedo): (WebKit::PageClientImpl::convertToDeviceSpace): (WebKit::PageClientImpl::convertToUserSpace): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::didNotHandleKeyEvent): (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing): (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::customRepresentationZoomFactor): (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): (WebKit::PageClientImpl::pageClosed): (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): (WebKit::PageClientImpl::flashBackingStoreUpdates): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
  • UIProcess/API/gtk/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/gtk/WebView.h. (WebKit::PageClientImpl::create): (WebKit::PageClientImpl::addPendingEditorCommand): (WebKit::PageClientImpl::userSpaceScaleFactor):
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseInit): (webkitWebViewBaseCreate):
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:
9:44 AM Changeset in webkit [85197] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use the WebPage object in WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=59683

It simplifies the implementation of the event callbacks. Remove
also all the methods from the page client that are no longer
needed.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseInit): (webViewExpose): (webViewDraw): (webViewSizeAllocate): (webViewFocusInEvent): (webViewFocusOutEvent): (webViewKeyPressEvent): (webViewKeyReleaseEvent): (webViewButtonPressEvent): (webViewButtonReleaseEvent): (webViewScrollEvent): (webViewMotionNotifyEvent):
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::createDrawingAreaProxy):
  • UIProcess/gtk/WebView.h:
9:39 AM Changeset in webkit [85196] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create the page client in the view widget
https://bugs.webkit.org/show_bug.cgi?id=59679

  • UIProcess/API/C/gtk/WKView.cpp: (WKViewCreate): Simply create a new view widget and return it. (WKViewGetPage): Use webkitWebViewBaseGetPage().
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseFinalize): Use finalize instead of dispose to make sure it's called only once, and release the private struct too. (webkitWebViewBaseInit): Create the page client. (webkitWebViewBaseClassInit): Don't use GObject private data structure. (webkitWebViewBaseCreate): New method to create a WebKitWebViewBase for a given context and page group. (webkitWebViewBaseGetWebViewInstance): (webkitWebViewBaseGetPage):
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::page): Get the page from the view widget. (WebKit::WebView::handleFocusInEvent): Ditto. (WebKit::WebView::handleFocusOutEvent): Ditto. (WebKit::WebView::WebView): Page client is now created with a view widget. (WebKit::WebView::paint): Get the page from the view widget. (WebKit::WebView::setSize): Ditto. (WebKit::WebView::handleKeyboardEvent): Ditto. (WebKit::WebView::handleMouseEvent): Ditto. (WebKit::WebView::handleWheelEvent): Ditto. (WebKit::WebView::close): Ditto. (WebKit::WebView::createDrawingAreaProxy): Ditto.
  • UIProcess/gtk/WebView.h: (WebKit::WebView::create): The page client will be created as private by the view widget, so it doesn't need to be ref counted, use PassOwnPtr instead of PassRefPtr.
9:38 AM Changeset in webkit [85195] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called

Reviewed by Simon Fraser.

  • wtf/mac/MainThreadMac.mm:

(WTF::postTimer): Use RetainPtr to plug the leak.

9:37 AM Changeset in webkit [85194] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-28 Pavel Feldman <pfeldman@google.com>

Not reviewed: skipping new inspector tests on Mac while I'm looking into it.

  • platform/mac/Skipped:
9:32 AM Changeset in webkit [85193] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] PlatformWebView should be the view widget
https://bugs.webkit.org/show_bug.cgi?id=59676

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseGetPage): Return the page of the view.
  • UIProcess/API/gtk/WebKitWebViewBase.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Map PlatformWebView to WebKitWebViewBase instead of the page client.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Use the view widget directly. (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): Ditto. (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Ditto.
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::createDrawingAreaProxy): Pass the view widget to the DrawingAreaProxy constructor instead of the page client.
  • UIProcess/gtk/WebView.h: Remove getWebViewWindow() which is no longer needed.
9:28 AM Changeset in webkit [85192] by Carlos Garcia Campos
  • 6 edits in trunk

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] WKView should be a GtkWidget
https://bugs.webkit.org/show_bug.cgi?id=59603

  • UIProcess/API/C/gtk/WKAPICastGtk.h: Map WKViewRef to WebKitWebViewBase instead of WebView.
  • UIProcess/API/C/gtk/WKView.h: Remove WKViewGetWindow().
  • UIProcess/API/C/gtk/WKView.cpp: (WKViewCreate): Return the view instead of the page client. (WKViewGetPage): Use WebKitWebViewBase API to get the page client containing the page.

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] WKView should be a GtkWidget
https://bugs.webkit.org/show_bug.cgi?id=59603

Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.

  • MiniBrowser/gtk/main.c: (createWindow): (main):
9:18 AM Changeset in webkit [85191] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-04-28 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Speech input button layout issues with padding and border.
https://bugs.webkit.org/show_bug.cgi?id=59613

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent):
9:12 AM Changeset in webkit [85190] by satish@chromium.org
  • 5 edits in trunk

2011-04-28 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Speech input button layout issues with padding and border.
https://bugs.webkit.org/show_bug.cgi?id=59613

  • fast/speech/input-text-speechbutton-expected.txt:
  • fast/speech/input-text-speechbutton.html: Updated to test with padding.

2011-04-28 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Speech input button layout issues with padding and border.
https://bugs.webkit.org/show_bug.cgi?id=59613

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent):
9:07 AM Changeset in webkit [85189] by weinig@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

2011-04-27 Sam Weinig <sam@webkit.org>

Reviewed by David Kilzer.

Add way to install testapi in production builds
https://bugs.webkit.org/show_bug.cgi?id=59674

  • Configurations/TestAPI.xcconfig: Copied from Configurations/JavaScriptCore.xcconfig. Add configuration file for TestAPI. In addition to name, we now specify an install path and allow SKIP_INSTALL to be overridden by setting FORCE_TOOL_INSTALL.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove in-project build settings and add missing configuration files. Added missing CompilerVersion.xcconfig file.
9:04 AM Changeset in webkit [85188] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Check whether to use native scrollbars at run time
https://bugs.webkit.org/show_bug.cgi?id=59694

It's currently decided at build time depending on whether webkit2
build is enabled or not. That makes imposible to build both
webkit1 and webkit2 using the same libWebCore.

  • GNUmakefile.am:
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::createScrollbar):
8:56 AM Changeset in webkit [85187] by Chris Fleizach
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add new expected results for GTK platform.

ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648

  • platform/gtk/accessibility/aria-fallback-roles-expected.txt: Added.
8:45 AM Changeset in webkit [85186] by pfeldman@chromium.org
  • 6 edits in trunk/LayoutTests

2011-04-28 Pavel Feldman <pfeldman@google.com>

Not reviewed: unflake new inspector tests.

  • http/tests/inspector/resource-tree/resource-tree-reload.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap):
8:38 AM Changeset in webkit [85185] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

accessibility/aria-fallback-roles.html failing on Windows since introduction in r85157.
https://bugs.webkit.org/show_bug.cgi?id=59701

Add Windows-specific results to get the bots green.

  • platform/win/accessibility/aria-fallback-roles-expected.txt: Added.
8:08 AM Changeset in webkit [85184] by pfeldman@chromium.org
  • 5 edits
    21 adds
    2 deletes in trunk

2011-04-28 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add ResourceTreeModel tests.
https://bugs.webkit.org/show_bug.cgi?id=59616

  • http/tests/inspector/resource-tree-model-expected.txt: Removed.
  • http/tests/inspector/resource-tree-model.html: Removed.
  • http/tests/inspector/resource-tree/resource-tree-document-url-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-document-url.html: Added.
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html: Added.
  • http/tests/inspector/resource-tree/resource-tree-reload-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-reload.html: Added.
  • http/tests/inspector/resource-tree/resource-tree-test.js: Added. (initialize_ResourceTreeTest.InspectorTest.dumpResources): (initialize_ResourceTreeTest.InspectorTest.dumpResources.comparator): (initialize_ResourceTreeTest.InspectorTest.dumpResourcesURLMap): (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree): (initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreLoaded.callbackWrapper): (initialize_ResourceTreeTest.InspectorTest.runAfterResourcesAreLoaded): (initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything): (initialize_ResourceTreeTest):
  • http/tests/inspector/resource-tree/resources/dummy-iframe.html: Added.
  • http/tests/inspector/resource-tree/resources/resource-tree-frame-navigate-iframe-after.html: Added.
  • http/tests/inspector/resource-tree/resources/resource-tree-frame-navigate-iframe-before.html: Added.
  • http/tests/inspector/resource-tree/resources/resource-tree-reload-iframe.html: Added.
  • http/tests/inspector/resource-tree/resources/script-initial.js: Added. (foo):
  • http/tests/inspector/resource-tree/resources/script-navigated.js: Added. (foo):
  • http/tests/inspector/resource-tree/resources/styles-initial-2.css: Added. (html):
  • http/tests/inspector/resource-tree/resources/styles-initial.css: Added. (html):
  • http/tests/inspector/resource-tree/resources/styles-navigated.css: Added. (html):
  • platform/win/Skipped:

2011-04-28 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add ResourceTreeModel tests.
https://bugs.webkit.org/show_bug.cgi?id=59616

Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html

http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
http/tests/inspector/resource-tree/resource-tree-reload.html

  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.frontendReused): (WebInspector.ResourceTreeModel.prototype._addFrame): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._frameDetached): (WebInspector.ResourceTreeModel.prototype._onResourceUpdated): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype._frameAdded): (WebInspector.ResourcesPanel.prototype._frameDetached): (WebInspector.ResourcesPanel.prototype._frameNavigated): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.frameNavigated):
7:59 AM Changeset in webkit [85183] by mnaganov@chromium.org
  • 7 edits in trunk

2011-04-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=59592

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand): (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute): (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid): (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete): (WebInspector.DetailedHeapshotView.prototype.changeView):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotPathFinder.prototype.findNext): (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter): (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath): (WebInspector.HeapSnapshotPathFinder.prototype._pathToString): (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
  • inspector/front-end/heapProfiler.css: (div.retaining-paths-view td.path-column div:hover):

2011-04-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=59592

  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest):
7:53 AM Changeset in webkit [85182] by mnaganov@chromium.org
  • 5 edits
    2 adds in trunk

2011-04-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
https://bugs.webkit.org/show_bug.cgi?id=59454

Test: inspector/profiler/heap-snapshot-loader.html

  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotLoader): (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets): (WebInspector.HeapSnapshotLoader.prototype.finishLoading): (WebInspector.HeapSnapshotLoader.prototype._parseNodes): (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray): (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):

2011-04-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
https://bugs.webkit.org/show_bug.cgi?id=59454

  • inspector/profiler/heap-snapshot-loader-expected.txt: Added.
  • inspector/profiler/heap-snapshot-loader.html: Added.
  • inspector/profiler/heap-snapshot-test.js: (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock): (initialize_HeapSnapshotTest):
7:23 AM Changeset in webkit [85181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-28 ojab <ojab@ojab.ru>

Reviewed by David Levin.

Fix build with libpng-1.5.1
https://bugs.webkit.org/show_bug.cgi?id=59607

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::readColorProfile):
7:18 AM Changeset in webkit [85180] by zherczeg@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Optimizing gaussian blur filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=59447

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-04-28
Reviewed by Nikolas Zimmermann.

This patch contains two sub-routines, one for speeding up
alpha channel only gaussian blur (by 2.5 times) and one
for speeding up all channel blur (by 4 times).

The common code is also redesigned to better fit for platform
specific code. This means large chunks of code was moved to
different files, and all platform specific files are added to
all build systems.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::apply):

  • platform/graphics/filters/FEGaussianBlur.h:

(WebCore::FEGaussianBlur::kernelPosition):
(WebCore::FEGaussianBlur::platformApply):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):
(WebCore::FELighting::drawLighting):

  • platform/graphics/filters/FELighting.h:

(WebCore::FELighting::platformApply):

  • platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.

(WebCore::WTF_ALIGNED):
(WebCore::feGaussianBlurConstantsForNeon):

  • platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.

(WebCore::FEGaussianBlur::platformApplyNeon):

  • platform/graphics/filters/arm/FELightingNEON.cpp:

(WebCore::WTF_ALIGNED):
(WebCore::FELighting::getPowerCoefficients):

  • platform/graphics/filters/arm/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

6:03 AM Changeset in webkit [85179] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide a hotkey for script pause
https://bugs.webkit.org/show_bug.cgi?id=59593

In fact, F8 works as a hotkey, but this fact was not reflected
in the shortcut help popup.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts):
5:58 AM Changeset in webkit [85178] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-04-28 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: readonly and read/write transactions
https://bugs.webkit.org/show_bug.cgi?id=59465

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt: Added.
  • storage/indexeddb/mozilla/readonly-transactions.html: Added.
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt: Added.
  • storage/indexeddb/mozilla/readwrite-transactions.html: Added.
4:42 AM Changeset in webkit [85177] by rgabor@webkit.org
  • 4 edits
    2 adds in trunk

2011-04-28 Gabor Rapcsanyi <rgabor@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add ARM specific Skipped list
https://bugs.webkit.org/show_bug.cgi?id=59680

  • platform/qt-arm/Skipped: Added.

2011-04-28 Gabor Rapcsanyi <rgabor@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Add ARM specific Skipped list
https://bugs.webkit.org/show_bug.cgi?id=59680

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:
4:14 AM Changeset in webkit [85176] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginStream should play nice with strict OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59675

These failures appear when enabling strict OwnPtr on Qt.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::PluginStream): (WebCore::PluginStream::didReceiveData):
2:53 AM Changeset in webkit [85175] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/inspector.css

Merge 84910 - 2011-04-26 Pavel Feldman <pfeldman@google.com> Reviewed by Yury Semikhatsky. Web Inspector: close button is off in docked mode on a mac. https://bugs.webkit.org/show_bug.cgi?id=59453 * inspector/front-end/inspector.css: (.toolbar-item.close-left):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6883222

2:47 AM Changeset in webkit [85174] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/InspectorDOMAgent.cpp

Merge 85047 - 2011-04-27 Pavel Feldman <pfeldman@google.com> Reviewed by Yury Semikhatsky. Web Inspector: opening bookmarklet disconnects DOM agent. https://bugs.webkit.org/show_bug.cgi?id=59588 * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6880269

2:37 AM Changeset in webkit [85173] by apavlov@chromium.org
  • 4 edits in branches/chromium/742/Source/WebCore/inspector/front-end

Merge 84909 - 2011-04-26 Pavel Feldman <pfeldman@google.com> Web Inspector: New Style is not working (UI glitch) https://bugs.webkit.org/show_bug.cgi?id=59451 * inspector/front-end/AuditRules.js: * inspector/front-end/CSSStyleModel.js: * inspector/front-end/DOMAgent.js: * inspector/front-end/StylesSidebarPane.js:
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6893091

2:06 AM Changeset in webkit [85172] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-26 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
https://bugs.webkit.org/show_bug.cgi?id=59326

Concrete CachedResource successors for stylesheets and scripts
can decode their content better than the generic approach we use.

  • inspector/InspectorPageAgent.cpp: (WebCore::decodeSharedBuffer): (WebCore::prepareCachedResourceBuffer): (WebCore::cachedResourceDecoded): (WebCore::InspectorPageAgent::resourceContent): (WebCore::InspectorPageAgent::resourceData):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::originalStyleSheetText):
12:48 AM Changeset in webkit [85171] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-28 Jon Lee <jonlee@apple.com>

Reviewed by Simon Fraser.

REGRESSION: white overlay scrollbars on apple.com/startpage
https://bugs.webkit.org/show_bug.cgi?id=59540
<rdar://problem/9338653>

Now we look at the document background in addition to the <body> element,
and blend those colors in with the base background of the frame view to
arrive at our aggregate color. This provides a better result to determine
overlay scrollbar style.

  • page/Frame.cpp: (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
  • platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
12:06 AM Changeset in webkit [85170] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59369

[Qt] Qt specific expected result is unnecessary after r85163.

  • platform/qt/fast/events/mouseout-dead-node-expected.txt: Removed.

Apr 27, 2011:

11:56 PM Changeset in webkit [85169] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656

This patch is an attempt to fix the clang build. Clang can't seem to
cope with OwnPtrs to classes declared in an anonymous namespace because
OwnPtr's copy constructor isn't defined (but would need to be defined
in this translation unit).

  • platform/leveldb/LevelDBDatabase.cpp:
11:46 PM Changeset in webkit [85168] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Change cursor to LAZY_NATIVE_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=59411

Enable LAZY_NATIVE_CURSOR on EFL build.

No test added because functionality is unchanged.

  • CMakeListsEfl.txt: Add Cursor.cpp
  • platform/Cursor.h: (WebCore::Cursor::Cursor):
  • platform/efl/CursorEfl.cpp: (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::getCursorString): (WebCore::Cursor::ensurePlatformCursor):
  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setCursor):
11:35 PM Changeset in webkit [85167] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict OwnPtrs for Chromium
https://bugs.webkit.org/show_bug.cgi?id=59666

  • wtf/OwnPtr.h:
11:23 PM Changeset in webkit [85166] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Adam Barth <abarth@webkit.org>

Build fix from the future. Another trival strict OwnPtr fixes. This
is the last futuristic build fix I can detect with my time traveling
abilities.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::initializeNewContext):
11:21 PM Changeset in webkit [85165] by commit-queue@webkit.org
  • 20 edits in trunk/Source

2011-04-27 Dmitry Lomov <dslomov@google.com>

Reviewed by David Levin.

CrossThreadCopier should not have a default specialization for raw pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Removed the ablity to pass raw pointers cross-thread
Added and applied annotations for doing that

  • fileapi/FileReader.cpp: (WebCore::FileReader::readInternal): (WebCore::FileReader::abort):
  • fileapi/FileStreamProxy.cpp: (WebCore::FileStreamProxy::startOnFileThread): (WebCore::FileStreamProxy::stopOnFileThread): (WebCore::FileStreamProxy::getSize): (WebCore::FileStreamProxy::getSizeOnFileThread): (WebCore::FileStreamProxy::openForRead): (WebCore::FileStreamProxy::openForReadOnFileThread): (WebCore::FileStreamProxy::openForWrite): (WebCore::FileStreamProxy::openForWriteOnFileThread): (WebCore::FileStreamProxy::close): (WebCore::FileStreamProxy::read): (WebCore::FileStreamProxy::readOnFileThread): (WebCore::FileStreamProxy::write): (WebCore::FileStreamProxy::writeOnFileThread): (WebCore::FileStreamProxy::truncate): (WebCore::FileStreamProxy::truncateOnFileThread):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
  • page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::triggerReadFromDatabase): (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
  • platform/CrossThreadCopier.h: (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper): (WebCore::AllowCrossThreadAccessWrapper::value): (WebCore::AllowCrossThreadAccess): (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper): (WebCore::AllowExtendedLifetimeWrapper::value): (WebCore::AllowExtendedLifetime):
  • platform/graphics/chromium/cc/CCCompletionEvent.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::deleteIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::clear):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel): (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge): (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::send): (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount): (WebCore::WorkerThreadableWebSocketChannel::Bridge::close): (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):

2011-04-27 Dmitry Lomov <dslomov@google.com>

Reviewed by David Levin.

CrossThreadCopier should not have a default specialization for raw pointers
https://bugs.webkit.org/show_bug.cgi?id=59234
Removed the ablity to pass raw pointers cross-thread
Added and applied annotations for doing that

  • src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::connect): (WebKit::WebSharedWorkerImpl::connectTask):
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject): (WebKit::WebWorkerBase::postExceptionToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::confirmMessageFromWorkerObject): (WebKit::WebWorkerBase::reportPendingActivity): (WebKit::WebWorkerBase::workerContextClosed): (WebKit::WebWorkerBase::workerContextDestroyed):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::startWorkerContext): (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::workerObjectDestroyed): (WebKit::WebWorkerClientImpl::postMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::reportPendingActivity):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContext):
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
  • src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate): (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
  • tests/CCThreadTest.cpp: (WebCore::TEST):
11:16 PM Changeset in webkit [85164] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-27 Adam Barth <abarth@webkit.org>

Two build fixes from the future. (Trivial strict OwnPtr fixes.)

  • page/Frame.cpp: (WebCore::Frame::setTiledBackingStoreEnabled):
  • platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver):
11:15 PM Changeset in webkit [85163] by commit-queue@webkit.org
  • 2 edits
    1 add
    7 deletes in trunk/LayoutTests

2011-04-27 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59369

  • fast/events/mouseout-dead-node-expected.txt: Added.
  • fast/events/mouseout-dead-node.html: Change to use dumpAsText.
  • platform/chromium-linux/fast/events/mouseout-dead-node-expected.png: Removed.
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.png: Removed.
  • platform/chromium-win/fast/events/mouseout-dead-node-expected.txt: Removed.
  • platform/gtk/fast/events/mouseout-dead-node-expected.txt: Removed.
  • platform/mac-leopard/fast/events/mouseout-dead-node-expected.png: Removed.
  • platform/mac/fast/events/mouseout-dead-node-expected.png: Removed.
  • platform/mac/fast/events/mouseout-dead-node-expected.txt: Removed.
11:08 PM Changeset in webkit [85162] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Fix five strict PassOwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59640

  • css/MediaList.cpp: (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText): (WebCore::MediaList::appendMedium):
  • css/MediaQuery.h:
  • dom/MessagePort.cpp: (WebCore::MessagePort::disentanglePorts): (WebCore::MessagePort::entanglePorts):
  • inspector/InspectorStyleSheet.cpp: (ParsedStyleSheet::setText):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::adjustMeterStyle):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
10:59 PM Changeset in webkit [85161] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Chromium test failures after r85142
https://bugs.webkit.org/show_bug.cgi?id=59673

Unreviewed. Temporarily suppress test failures.

  • platform/chromium/test_expectations.txt:
10:53 PM Changeset in webkit [85160] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

Log more information when http/tests/xmlhttprequest/basic-auth.html fails
https://bugs.webkit.org/show_bug.cgi?id=59651

Very basic, but it's better than nothing.

  • http/tests/xmlhttprequest/basic-auth.html:
10:49 PM Changeset in webkit [85159] by mrowe@apple.com
  • 2 edits in tags/Safari-534.31.2/Source/WebCore

Merge r85147.

10:49 PM Changeset in webkit [85158] by mrowe@apple.com
  • 5 edits in tags/Safari-534.31.2/Source

Versioning.

10:43 PM Changeset in webkit [85157] by Chris Fleizach
  • 3 edits
    2 adds in trunk

2011-04-27 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

<rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648

  • accessibility/aria-fallback-roles.html: Added.
  • platform/mac/accessibility/aria-fallback-roles-expected.txt: Added.

2011-04-27 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

<rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
https://bugs.webkit.org/show_bug.cgi?id=59648

Test: accessibility/aria-fallback-roles.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
10:41 PM Changeset in webkit [85156] by mrowe@apple.com
  • 1 copy in tags/Safari-534.31.2

New tag.

10:38 PM Changeset in webkit [85155] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

error_log.txt should include PHP errors
https://bugs.webkit.org/show_bug.cgi?id=59643

Turns out this was really easy after I finally learned
enough about PHP to do it...

I'm adding this in hopes of better tracking down
our random http failures.

  • Scripts/webkitperl/httpd.pm:
10:19 PM Changeset in webkit [85154] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: creating unique index and updating indexNames
https://bugs.webkit.org/show_bug.cgi?id=59631

  • storage/indexeddb/mozilla/create-index-unique-expected.txt: Added.
  • storage/indexeddb/mozilla/create-index-unique.html: Added.
10:18 PM Changeset in webkit [85153] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Should call done() from unexpectedErrorCallback so failing IndexedDB tests don't time out
https://bugs.webkit.org/show_bug.cgi?id=59569

  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (unexpectedBlockedCallback):
10:03 PM Changeset in webkit [85152] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: creating and deleting indexes
https://bugs.webkit.org/show_bug.cgi?id=59635

  • storage/indexeddb/mozilla/remove-index-expected.txt: Added.
  • storage/indexeddb/mozilla/remove-index.html: Added.
9:59 PM Changeset in webkit [85151] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: get() and put() basics
https://bugs.webkit.org/show_bug.cgi?id=59468

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/put-get-values-expected.txt: Added.
  • storage/indexeddb/mozilla/put-get-values.html: Added.
9:55 PM Changeset in webkit [85150] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: index cursors
https://bugs.webkit.org/show_bug.cgi?id=59472

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/object-cursors-expected.txt: Added.
  • storage/indexeddb/mozilla/object-cursors.html: Added.
9:40 PM Changeset in webkit [85149] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: event.target.source in success callbacks
https://bugs.webkit.org/show_bug.cgi?id=59632

  • storage/indexeddb/mozilla/event-source-expected.txt: Added.
  • storage/indexeddb/mozilla/event-source.html: Added.
9:37 PM Changeset in webkit [85148] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: event.target.result after add() and put()
https://bugs.webkit.org/show_bug.cgi?id=59634

  • storage/indexeddb/mozilla/key-requirements-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements.html: Added.
9:32 PM Changeset in webkit [85147] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=59671
Race condition with scrollbar animations and closing a page can cause a crash in
WebCore::FrameView::setVisibleScrollerThumbRect + 15
-and corresponding-
<rdar://problem/9329253>

Reviewed by Dan Bernstein.

It is definitely possible for Page to be null here. So we should null-check it!
And we should not ASSERT.

  • page/FrameView.cpp:

(WebCore::FrameView::didCompleteRubberBand):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::setVisibleScrollerThumbRect):

9:27 PM Changeset in webkit [85146] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Ryosuke Niwa <rniwa@webkit.org>

WinCE build fix after r85143.

  • platform/graphics/wince/FontWinCE.cpp: (WebCore::TextRunComponent::TextRunComponent):
9:11 PM Changeset in webkit [85145] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB object store deleting entry should fail if key is null
https://bugs.webkit.org/show_bug.cgi?id=58614

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html: Added.

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB object store delete should fail if key is null
https://bugs.webkit.org/show_bug.cgi?id=58614

Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
8:35 PM Changeset in webkit [85144] by eric.carlson@apple.com
  • 2 edits
    1 add
    7 deletes in trunk/LayoutTests

2011-04-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

audio-no-installed-engines.html media test has unnecessary pixel results
https://bugs.webkit.org/show_bug.cgi?id=59456

Convert audio-no-installed-engines.html results from pixel to text.

  • media/audio-no-installed-engines-expected.txt: Added.
  • media/audio-no-installed-engines.html:
  • platform/chromium-linux/media/audio-no-installed-engines-expected.png: Removed.
  • platform/chromium-win/media/audio-no-installed-engines-expected.png: Removed.
  • platform/chromium-win/media/audio-no-installed-engines-expected.txt: Removed.
  • platform/gtk/media/audio-no-installed-engines-expected.txt: Removed.
  • platform/mac-leopard/media/audio-no-installed-engines-expected.png: Removed.
  • platform/mac/media/audio-no-installed-engines-expected.png: Removed.
  • platform/mac/media/audio-no-installed-engines-expected.txt: Removed.
8:20 PM Changeset in webkit [85143] by eric@webkit.org
  • 17 edits in trunk/Source

2011-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Should have an easy way to construct starting BidiStatus for a paragraph root
https://bugs.webkit.org/show_bug.cgi?id=59226

Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
I've made this a constructor for BidiStatus instead.

As part of this effort I added a direction() accessor for TextRun and got
rid of the old m_rtl bool. This is part of the generic effort in the
Bidi code to replace old bool usage with the superior TextDirection enum
(this generally makes the code cleaner).

As part of this replacement effort I found several places which were
assuming LTR (by passing rtl=false) when they probably want to use
the current text direction. I suspect that LTR vs. RTL may affect
string width in the case of ligatures. It's unclear.

This is almost entirely a mechanical change.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText):
  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::direction): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::setDirection):
  • platform/text/BidiResolver.h: (WebCore::BidiStatus::BidiStatus):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::determineStartPosition):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth): (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::constructTextRun):
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::constructTextRun):
8:18 PM Changeset in webkit [85142] by robert@webkit.org
  • 10 edits
    6 adds in trunk

2011-04-27 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965

  • fast/dom/Window/get-set-properties-expected.txt:
  • fast/dom/Window/get-set-properties.html:
  • fast/dom/Window/window-property-shadowing-expected.txt:
  • fast/dom/Window/window-property-shadowing.html:
  • fast/js/var-declarations-shadowing-expected.txt:
  • fast/js/var-declarations-shadowing.html:
  • http/tests/history/cross-origin-replace-history-object-child-expected.txt: Added.
  • http/tests/history/cross-origin-replace-history-object-child.html: Added.
  • http/tests/history/cross-origin-replace-history-object-expected.txt: Added.
  • http/tests/history/cross-origin-replace-history-object.html: Added.
  • http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html: Added.
  • http/tests/history/resources/cross-origin-replaces-history-object-iframe.html: Added.
  • http/tests/security/cross-frame-access-put-expected.txt: Note that a window property with the DoNotCheckDomainSecurityOnGet attribute generates two cross-origin JS warnings. Amended expected results to include the additional extra warning for the history object.

2011-04-27 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

Allow shadowing of history object
https://bugs.webkit.org/show_bug.cgi?id=55965

Tests: http/tests/history/cross-origin-replace-history-object-child.html

http/tests/history/cross-origin-replace-history-object.html

  • page/DOMWindow.idl:
8:07 PM Changeset in webkit [85141] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix some
Chromium Mac Leopard failures.

  • platform/chromium/test_expectations.txt:
7:45 PM Changeset in webkit [85140] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix Chromium Mac SL Debug
expectations, few miscellaneous other expectations.

  • platform/chromium/test_expectations.txt:
7:02 PM Changeset in webkit [85139] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: clear()
https://bugs.webkit.org/show_bug.cgi?id=59498

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/clear-expected.txt: Added.
  • storage/indexeddb/mozilla/clear.html: Added.
6:54 PM Changeset in webkit [85138] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style should flags spacing errors for braces on the same line.
https://bugs.webkit.org/show_bug.cgi?id=59665

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check and fixed some test cases to not trigger this error since it isn't what they are verifying.
6:49 PM Changeset in webkit [85137] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style error for spaces after periods in a comment has a bad error
message and warns about end of line spaces.
https://bugs.webkit.org/show_bug.cgi?id=59663

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line

and changed the error messages.

6:43 PM Changeset in webkit [85136] by jamesr@google.com
  • 7 edits in trunk/Source

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159

Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159

Explicitly update and sync the compositing layer data structures for all frames in the tree before entering the
composite operation so that lazily updated state doesn't mutate the GraphicsLayer tree while compositing.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
6:42 PM Changeset in webkit [85135] by jamesr@google.com
  • 7 edits in trunk/Source

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia):

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::getFrameAtIndex):
  • src/WebImageSkia.cpp: (WebKit::WebImage::fromData):
6:31 PM Changeset in webkit [85134] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: add twice failure
https://bugs.webkit.org/show_bug.cgi?id=59492

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt: Added.
  • storage/indexeddb/mozilla/add-twice-failure.html: Added.
6:22 PM Changeset in webkit [85133] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-27 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
https://bugs.webkit.org/show_bug.cgi?id=59641

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
6:07 PM Changeset in webkit [85132] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Unreviewed. Fixed more breakage in test_expectations.txt caused by
my previous checkin, caught with --lint-test-files thanks to dpranke.

  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [85131] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Motivated by Alexey Proskuryakov.

  • bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more

informative, since it confused Alexey and me.

5:59 PM Changeset in webkit [85130] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Andy Estes <aestes@apple.com>

Skip fast/blockflow/broken-ideographic-font.html on Leopard.

  • platform/mac-leopard/Skipped:
5:57 PM Changeset in webkit [85129] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Unreviewed, test expectation updates.

  • Marked media/video-controls-transformed.html as failing generally.
  • Fixed malformed bug ID in last update.
  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [85128] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Unreviewed, test expectation updates.

  • Added a couple of flaky tests.
  • Filed bugs for a preexisting and a new failure.
  • Rebaselined fast/lists/003-vertical.html on Mac.
  • platform/chromium-mac/fast/lists/003-vertical-expected.txt:
  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [85127] by ggaren@apple.com
  • 5 edits in trunk/Source/WebCore

2011-04-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=59646

Made the cssValueRoots map per-world, instead of a global. When we deallocate
a world, we need to clear all entries in the map for that world, since
the finalizers that would otherwise clear those entries don't run. The
simplest way to do this is just to make the world own the map.


  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSValueOwner::finalize):
  • bindings/js/JSDOMBinding.h:
5:17 PM Changeset in webkit [85126] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Make GraphicsContext3DChromium play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59659

Attempt #2. Hopefully this time I won't make everything crash.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
5:05 PM Changeset in webkit [85125] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-27 Ojan Vafai <ojan@chromium.org>

remove assertion now that platform/mac-tiger no longer exists
https://bugs.webkit.org/show_bug.cgi?id=59660

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5:04 PM Changeset in webkit [85124] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Dirk Pranke <dpranke@chromium.org>

Unreviewed, update w/ failing tests and remove a bunch of
passing mac tests.

  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [85123] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

remove test that didn't make sense
https://bugs.webkit.org/show_bug.cgi?id=59658

It was artifically saying the test wasn't expected to pass,
but the expectations string was empty. The case of unexpected
passes with a real expectations string is tested later in the
same test.

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4:52 PM Changeset in webkit [85122] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Fix OwnPtr issues in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=59656

I didn't do an exhaustive review of this code, but I fixed the problems
caught by turning on strict OwnPtr and all their antecedents. This
patch is entirely tighter bookkeeping. There shouldn't be any actual
behavior change.

  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::LevelDBDatabase): (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::createIterator):
  • platform/leveldb/LevelDBDatabase.h:
  • platform/leveldb/LevelDBIterator.cpp: (WebCore::LevelDBIterator::LevelDBIterator):
  • platform/leveldb/LevelDBIterator.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore): (WebCore::IDBLevelDBBackingStore::open): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::findGreatestKeyLessThan): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo):
  • storage/IDBLevelDBBackingStore.h:
4:48 PM Changeset in webkit [85121] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: bad keypath
https://bugs.webkit.org/show_bug.cgi?id=59497

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/bad-keypath-expected.txt: Added.
  • storage/indexeddb/mozilla/bad-keypath.html: Added.
4:45 PM Changeset in webkit [85120] by weinig@apple.com
  • 12 edits in trunk

2011-04-27 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

WebKit2 needs to notify the client when a plugin fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59657

Add didFailToInitializePlugin client function and call it when a plugin
fails to initialize.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::initializePlugin):

2011-04-27 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

WebKit2 needs to notify the client when a plugin fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59657

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Add stubs.
4:17 PM Changeset in webkit [85119] by weinig@apple.com
  • 4 edits in trunk/Tools

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Levin.

Add a few more missing options to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59567

Add support for:

--threaded
--gc-between-tests
--complex-text

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:09 PM Changeset in webkit [85118] by morrita@google.com
  • 9 edits
    1 add in trunk/Source/WebCore

2011-04-19 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
https://bugs.webkit.org/show_bug.cgi?id=58113

  • Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
  • Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
  • Now MarkerMapVectorPair is no longer used.

No new tests, No behavior change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentMarker.h:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersForNode): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::setRenderedRectForMarker): (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • dom/RenderedDocumentMarker.h: Added. (WebCore::RenderedDocumentMarker::RenderedDocumentMarker): (WebCore::RenderedDocumentMarker::isRendered): (WebCore::RenderedDocumentMarker::contains): (WebCore::RenderedDocumentMarker::setRenderedRect): (WebCore::RenderedDocumentMarker::renderedRect): (WebCore::RenderedDocumentMarker::invalidate): (WebCore::RenderedDocumentMarker::invalidMarkerRect):
4:06 PM Changeset in webkit [85117] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add ability to remove keys from weakmap API
https://bugs.webkit.org/show_bug.cgi?id=59645

Add JSWeakObjectMapRemove API

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWeakObjectMapRefPrivate.h:
  • JavaScriptCore.exp:
4:01 PM Changeset in webkit [85116] by jamesr@google.com
  • 7 edits in trunk/Source/WebCore

2011-04-27 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r85112.
http://trac.webkit.org/changeset/85112
https://bugs.webkit.org/show_bug.cgi?id=59159

Broke mac compile

  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):
  • page/FrameView.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
3:57 PM Changeset in webkit [85115] by mrowe@apple.com
  • 2 edits in trunk/Tools

Build fix.

Fix an OwnPtr-related issue that was missed before the strictness was turned on.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest):

3:56 PM April 2011 Meeting/Threading edited by levin@chromium.org
(diff)
3:56 PM SuccessfulPortHowTo edited by dbates@webkit.org
Fix typo; "wkdirs.pm" => "webkitdirs.pm". (diff)
3:53 PM Changeset in webkit [85114] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
3:50 PM Changeset in webkit [85113] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).

  • platform/network/ResourceHandleClient.h:
3:41 PM Changeset in webkit [85112] by jamesr@google.com
  • 7 edits in trunk/Source/WebCore

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Ensure compositing layers are up to date before entering doComposite
https://bugs.webkit.org/show_bug.cgi?id=59159

Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
GraphicsLayerClient::paintContents() implementations).

  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):

Add an optional CompositingUpdateType parameter.

  • page/FrameView.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::dirtyZOrderLists): (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
  • rendering/RenderLayerCompositor.h: Fix a typo in CompositingUpdateType Pait->Paint
3:39 PM Changeset in webkit [85111] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-27 Ojan Vafai <ojan@chromium.org>

Forgot to upload the new times_ms.json file after splitting
it out from full_results.json.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
3:34 PM Changeset in webkit [85110] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

[chromium] Rebaseline direct-image-compositing.html after r85011
https://bugs.webkit.org/show_bug.cgi?id=59624

Unreviewed. It looks like the previous image result for this
layout test was checked in from a Debug rather than Release build
and was affected by bug 58587.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [85109] by psolanki@apple.com
  • 11 edits in trunk/Source

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

Source/WebCore:

Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
willCacheResponse/shouldCacheResponse.

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.h:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::willCacheResponse):
(WebCore::ResourceHandleClient::shouldCacheResponse):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willCacheResponse):

Source/WebKit2:

Add PLATFORM(WIN) ifdef around shouldCacheResponse.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:28 PM Changeset in webkit [85108] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-27 Ojan Vafai <ojan@chromium.org>

Fix snafu in generating the JSON for the chromium tests.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3:24 PM Changeset in webkit [85107] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-27 Ojan Vafai <ojan@chromium.org>

Fix bad merge. This broke the chromium tests generating JSON files.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3:24 PM Changeset in webkit [85106] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Dirk Pranke <dpranke@chromium.org>

Unreviewed, update w/ failing tests.

  • platform/chromium/test_expectations.txt:
3:12 PM Changeset in webkit [85105] by mrowe@apple.com
  • 2 edits in trunk/Tools

Don't look for results in a location that no longer exists.

Rubber-stamped by Geoff Garen.

  • Scripts/old-run-webkit-tests:
3:12 PM Changeset in webkit [85104] by mrowe@apple.com
  • 2 edits
    2 deletes in trunk

Remove some files that are no longer relevant.

Rubber-stamped by Geoff Garen.

WebKitLibraries:

  • libWebKitSystemInterfaceTiger.a: Removed.

LayoutTests:

  • platform/mac-tiger: Removed.
3:10 PM Changeset in webkit [85103] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.

  • platform/qt-mac/Skipped:
3:06 PM Changeset in webkit [85102] by vrk@chromium.org
  • 25 edits
    17 adds in trunk/LayoutTests

2011-04-27 Victoria Kirst <vrk@chromium.org>

Unreviewed.

[chromium] Rebaseline and add baselines for a few media layout tests
and update test_expectations.txt.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-transformed-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-win/media/video-transformed-expected.png: Added.
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/test_expectations.txt:
3:00 PM Changeset in webkit [85101] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Brian Weinstein.

Web Inspector: Stop on Exception state does not persist.

A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
https://bugs.webkit.org/show_bug.cgi?id=59630

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2:53 PM Changeset in webkit [85100] by enne@google.com
  • 4 edits
    4 deletes in trunk

2011-04-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rollout r85075 (scissor rect changes)
https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Removed.
  • compositing/flat-with-transformed-child.html: Removed.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-04-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rollout r85075 (scissor rect changes)
https://bugs.webkit.org/show_bug.cgi?id=59020

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2:50 PM Changeset in webkit [85099] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.

  • platform/qt-mac/Skipped:
2:45 PM Changeset in webkit [85098] by adamk@chromium.org
  • 1 edit in branches/chromium/742/Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp

Reviewed by Adam Barth.

Remove currently-spurious ASSERTs in WTF's random number generator for Chromium M12 branch
https://bugs.webkit.org/show_bug.cgi?id=59633

2:41 PM Changeset in webkit [85097] by enne@google.com
  • 2 edits in trunk/Tools

2011-04-27 Adrienne Walker <enne@google.com>

Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing

  • Scripts/webkitpy/common/config/committers.py:
2:35 PM Changeset in webkit [85096] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Add more failing tests to the Skipped list.

  • platform/qt-mac/Skipped:
2:27 PM Changeset in webkit [85095] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

only include failures in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=59256

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
2:25 PM Changeset in webkit [85094] by abarth@webkit.org
  • 22 edits in trunk/Source/WebCore

2011-04-27 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Fix strict OwnPtr issues seen in about 30 more files
https://bugs.webkit.org/show_bug.cgi?id=59615

  • bindings/js/JSCallbackData.h: (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
  • bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
  • css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr, adoptPtr, and release.
  • dom/MessageEvent.cpp: (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr, and release.
  • dom/MessagePortChannel.cpp: (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
  • dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
  • dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::create): Use adoptPtr.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::detach): Use nullptr.
  • inspector/InspectorAgent.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr. (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr. (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): Use adoptPtr.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
  • page/FrameActionScheduler.cpp: (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayer::create): Use adoptPtr. (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr. (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr. (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr. (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr. (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr. (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr. (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr. (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr. (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed explicit initializations of OwnPtr members to 0. Use adoptPtr.
  • workers/SharedWorkerContext.cpp: (WebCore::createConnectEvent): Use adoptPtr.
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished): Use nullptr.
2:22 PM Changeset in webkit [85093] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

remove unneeded TestWebWidget class
https://bugs.webkit.org/show_bug.cgi?id=59573

  • tests/PopupMenuTest.cpp:
2:21 PM Changeset in webkit [85092] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, update flat-with-transformed-child expectations.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [85091] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Follow-up Leopard build fix.

  • Carbon/HIViewAdapter.m:

(_webkit_NSView_setNeedsDisplayInRect):

2:19 PM April 2011 Meeting/Threading edited by jchaffraix@webkit.org
Added a better formatting (s/ (diff)
2:17 PM Changeset in webkit [85090] by enrica@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

Reviewed by Darin Adler.

Source/WebCore:

When we are looking for wrapping elements that are presentational, we should
include elements that have a non transparent background color only if they
are not blocks.

Test: editing/pasteboard/do-not-copy-body-color.html

  • editing/markup.cpp:

(WebCore::isElementPresentational):

LayoutTests:

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.
2:13 PM Unifying the build system created by jchaffraix@webkit.org
Dumped my notes
2:11 PM Changeset in webkit [85089] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-04-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

address aesthetic concerns for results.html format brought up at webkit meeting
https://bugs.webkit.org/show_bug.cgi?id=59625

-remove background-color
-lowercase expected/actual results types to reduce overall width
-let the test name (first column) wrap

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
2:05 PM Changeset in webkit [85088] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Hang if a sync message handler invalidates the connection
https://bugs.webkit.org/show_bug.cgi?id=59627

If dispatching incoming messages while waiting for the sync reply caused the connection to be invalidated,
we need to return early or we'll wait forever.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForSyncReply):
2:04 PM Changeset in webkit [85087] by ojan@chromium.org
  • 7 edits in trunk/Tools

2011-04-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

move times into their own json file
https://bugs.webkit.org/show_bug.cgi?id=59239

The test runtimes are the only case where we need an entry for
every test that was run, including passing tests. Move them into
their own json file so we can prune the other json files to only
include failing tests.

Use a trie-like data structure to hold the tests to avoid including
full test paths. This cuts 52% of the filesize. The end result is ~700k
pre-gzip.

  • Scripts/webkitpy/common/net/resultsjsonparser.py: Exclude times from the parsed TestResults.
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
2:03 PM Changeset in webkit [85086] by Nate Chapin
  • 2 edits in branches/chromium/742/Source/WebCore

Merge 84732:

2011-04-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
2:01 PM Changeset in webkit [85085] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=59484

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/global-data-expected.txt: Added.
  • storage/indexeddb/mozilla/global-data.html: Added.
  • storage/indexeddb/mozilla/objectstorenames-expected.txt: Added.
  • storage/indexeddb/mozilla/objectstorenames.html: Added.
1:58 PM Changeset in webkit [85084] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict mode for OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428

This patch enables strict mode for OwnPtr on PLATFORM(MAC) only.

  • wtf/OwnPtr.h:
1:57 PM Changeset in webkit [85083] by andersca@apple.com
  • 4 edits in trunk/Tools

More casts and more clang++ build fixes.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

1:56 PM April 2011 Meeting edited by jchaffraix@webkit.org
Added a "unifying the build system" page for some notes (diff)
1:54 PM Changeset in webkit [85082] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2011-04-27 Dimitri Glazkov <Dimitri Glazkov>

Skip crashing/failing shadow DOM tests until they are fixed.
https://bugs.webkit.org/show_bug.cgi?id=59571

  • platform/gtk/Skipped: Added failing tests.
  • platform/mac/Skipped: Ditto.
1:50 PM April 2011 Meeting edited by mahesh.kulkarni@nokia.com
(diff)
1:50 PM Changeset in webkit [85081] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit/mac

More clang++ 32-bit build fixes.

  • Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
(-[CarbonWindowAdapter setContentView:]):
(-[CarbonWindowAdapter _handleContentBoundsChanged]):

  • Carbon/HIViewAdapter.m:

(_webkit_NSView_setNeedsDisplayInRect):

  • Panels/WebAuthenticationPanel.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(getCarbonEvent):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scrollRectIntoView):

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory accessibilityConvertScreenRect:]):

  • WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController windowDidEnterFullscreen:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _hitViewForEvent:]):
(coreGraphicsScreenPointForAppKitScreenPoint):

  • WebView/WebPDFView.mm:

(-[WebPDFView setScrollPoint:]):

1:48 PM April 2011 Meeting/WebKit2 edited by jchaffraix@webkit.org
Dumped my notes about WebKit2 (diff)
1:44 PM Changeset in webkit [85080] by tony@chromium.org
  • 8 edits
    1 add in trunk/Tools

2011-04-27 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

lazily autoinstall thirdparty python libraries
https://bugs.webkit.org/show_bug.cgi?id=55723

This helps by only having pywebsocket installed when the bots run. It
doesn't help much for devs since webkit-patch pulls in almost everything.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/thirdparty/init.py: Add an import hook so we can install based on

the import command rather than just installing everything.

  • Scripts/webkitpy/thirdparty/init_unittest.py: Added.
1:43 PM Changeset in webkit [85079] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Add all failing tests to the Skipped list.

  • platform/qt-mac/Skipped:
1:33 PM Changeset in webkit [85078] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-27 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: createObjectStore basics
https://bugs.webkit.org/show_bug.cgi?id=59486

  • storage/indexeddb/mozilla: Added.
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt: Added.
  • storage/indexeddb/mozilla/create-objectstore-basics.html: Added.
1:32 PM Changeset in webkit [85077] by Dimitri Glazkov
  • 10 edits in trunk

2011-04-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Antti Koivisto.

Teach sub-selector chains about shadow descendants
https://bugs.webkit.org/show_bug.cgi?id=58342

  • fast/css/unknown-pseudo-element-matching-expected.txt: Updated expectations.
  • fast/css/unknown-pseudo-element-matching.html: Added new tests.

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Antti Koivisto.

Teach sub-selector chains about shadow descendants
https://bugs.webkit.org/show_bug.cgi?id=58342

The primary change is to the logic of parsing specifiers:
1) The shadow descendant selectors (those specifiers that are unknown
pseudo element selectors) are always kept at the top of the chain.
2) The sub-selectors after shadow descendant selectors are stashed right
behind the sub-selector, but not at the end of the chain.
3) Other sub-selectors are appended at the end of the chain.

  • css/CSSGrammar.y: Changed specifier_list collection to use new

CSSParser::updateSpecifier helper.

  • css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to

look for the last ShadowDescendant relation in the chain of selectors,
because the next selector after it is the one that should get the
element name.

(WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from

CSSGrammar.y. The new logic adjusts the selector chain to allow
shadow descendant selectors have sub-selectors (and have multiple shadow
descendants in the chain).

  • css/CSSParser.h: Added decl.
  • css/CSSParserValues.cpp: (WebCore::CSSParserSelector::insertTagHistory): Added. (WebCore::CSSParserSelector::appendTagHistory): Aded.
  • css/CSSParserValues.h: Added decls.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added

shadow descendant selector match check, since now there could be many
of them in the selector chain.

1:25 PM Changeset in webkit [85076] by Girish Ramakrishnan
  • 2 edits in trunk/Tools

2011-04-27 Girish Ramakrishnan <Girish Ramakrishnan>

Add my IRC nick.

  • Scripts/webkitpy/common/config/committers.py:
1:21 PM Changeset in webkit [85075] by enne@google.com
  • 4 edits
    4 adds in trunk

2011-04-20 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Added.
  • compositing/flat-with-transformed-child.html: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-04-20 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020

mapRect is the incorrect transform here. The parent scissor rect
needs to be projected into layer space instead.

Test: compositing/flat-with-transformed-child.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
12:51 PM Changeset in webkit [85074] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Rebaseline some tests which differ on the bots after r85066.

  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
12:40 PM Changeset in webkit [85073] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Web Inspector: regression in inspector/console/console-dir.html after r85054
https://bugs.webkit.org/show_bug.cgi?id=59620

Unreviewed. Missed updating chromium-specific expectations in earlier rebaseline.

  • platform/chromium/inspector/console/console-dir-expected.txt:
12:17 PM Changeset in webkit [85072] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

[chromium] Rebaseline direct-image-compositing.html after r85011
https://bugs.webkit.org/show_bug.cgi?id=59624

  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
11:58 AM Changeset in webkit [85071] by tony@chromium.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

2011-04-27 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] add a build target to make a zip file with the inspector debug files
https://bugs.webkit.org/show_bug.cgi?id=56656

  • WebKit.gyp: Add target
  • scripts/concatenate_css_files.py: Pass in a string of html rather

than a filename

  • scripts/concatenate_js_files.py: Same as above
  • scripts/generate_devtools_html.py: Refactor main into a helper function
  • scripts/generate_devtools_zip.py: Added.
11:52 AM Changeset in webkit [85070] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

  • Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
  • platform/mac/SoftLinking.h:
  • platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
11:44 AM Changeset in webkit [85069] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

Cleanup CSSStyleApplyProperty.cpp
https://bugs.webkit.org/show_bug.cgi?id=59623

As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
Use typedefs instead of repating the function pointer declarations in a few places.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): (WebCore::ApplyPropertyColor::ApplyPropertyColor): (WebCore::ApplyPropertyColor::applyInheritValue): (WebCore::ApplyPropertyColor::applyInitialValue): (WebCore::ApplyPropertyColor::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
11:35 AM Changeset in webkit [85068] by ojan@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-04-27 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

change style guide to pre-increment in for-loops
https://bugs.webkit.org/show_bug.cgi?id=59619

This matches what a number of reviewers have been asking
for in code reviews.

  • coding/coding-style.html:
11:29 AM Changeset in webkit [85067] by mitz@apple.com
  • 5 edits
    3 adds in trunk

<rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59622

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/borders/border-image-trumps-radius.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
image, then border radius is ignored, so no bleed avoidance is needed.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
(WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.

  • rendering/RenderObject.h:

LayoutTests:

  • fast/borders/border-image-trumps-radius-expected.png: Added.
  • fast/borders/border-image-trumps-radius-expected.txt: Added.
  • fast/borders/border-image-trumps-radius.html: Added.
11:21 AM Changeset in webkit [85066] by mrobinson@webkit.org
  • 5 edits
    1 add in trunk

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Menulists do not follow text direction when rendering options with right-to-left text
https://bugs.webkit.org/show_bug.cgi?id=54038

  • platform/gtk/Skipped: Unskip passing test.
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Menulists do not follow text direction when rendering options with right-to-left text
https://bugs.webkit.org/show_bug.cgi?id=54038

Fix rendering of menulists that contain right-to-left text. Text direction
inside a menulist now follows the alignment of its contents.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true. (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false.
11:16 AM Changeset in webkit [85065] by eric@webkit.org
  • 9 edits in trunk/Tools

2011-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
https://bugs.webkit.org/show_bug.cgi?id=59545

To do this, I needed a way to look up contributors by irc-name
(since anyone in #webkit who might use this command may not be a committer).
To lookup contributors, I had to make Contributor a real object.
Which led me to redesign parts of committers.py...
and finally fix one spot in changelog.py where we wanted to be
looking up contributors and not committers.

Overall a pretty simple fix, once you wade through the yak-hair.

This may not prevent *all* possible ways that bugs would get assigned
to webkit.review.bot. If we don't recognize the requester we will
go through the previous code path (which shouldn't change the assignee
on the bug from the default as far as I can tell).

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
11:15 AM Changeset in webkit [85064] by mrobinson@webkit.org
  • 10 edits in trunk

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/copy-standalone-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=53645

Unskip the test and add new expected results for it.

  • platform/gtk/Skipped: Unskip this test as it is now passing.
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.checksum:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.png:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/copy-standalone-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=53645

When writing an image to the clipboard, also write the URL and title
into the markup and URL portion. This change also abstracts a helper
imageToMarkup into markup.{cpp/h} from several different locations
throughout the platform layer.

  • editing/markup.h: Added new function definition.
  • editing/markup.cpp: (WebCore::imageToMarkup): Add this function which turns an image URL and element into some markup representing that image, while preserving non-src attributes.
  • platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper to markup.cpp.
  • platform/gtk/PasteboardGtk.cpp: (WebCore::getURLForImageNode): Add this helper which gets the appropriate image URL for a variety of image tag types. (WebCore::Pasteboard::writeImage): Write the image URL and title to the markup and URL portions of the clipboard. This will ensure that images paste properly back into WebKit.
  • platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the one from markup.h
11:09 AM Changeset in webkit [85063] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-27 Kenneth Russell <kbr@google.com>

Not reviewed. Rebaseline test to get the tree green.

Web Inspector: regression in inspector/console/console-dir.html after r85054
https://bugs.webkit.org/show_bug.cgi?id=59620

  • inspector/console/console-dir-expected.txt:
10:55 AM Changeset in webkit [85062] by yi.4.shen@nokia.com
  • 7 edits
    4 adds in trunk

2011-04-27 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin.

  • Source/WebKit.pro: Add platformplugin path to the SUBDIRS.

2011-04-27 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Exempting directory WebKit/qt/symbian/platformplugin from style guide.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:

2011-04-27 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin.

  • QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
  • symbian/platformplugin: Added.
  • symbian/platformplugin/WebPlugin.cpp: Added. (ItemListDelegate::ItemListDelegate): (ItemListDelegate::paint): (Popup::Popup): (Popup::resizeEvent): (Popup::populateList): (Popup::onItemSelected): (Popup::updateSelectionsBeforeDialogClosing): (Popup::updateAndClose): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleSelectionPopup::MultipleSelectionPopup): (WebNotificationPresenter::showNotification): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • symbian/platformplugin/WebPlugin.h: Added. (Popup::preSelectedIndices): (Popup::listWidget): (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter):
  • symbian/platformplugin/platformplugin.pro: Added.
  • symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebTouchModifier::~QWebTouchModifier): (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
10:42 AM Changeset in webkit [85061] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84987.
http://trac.webkit.org/changeset/84987
https://bugs.webkit.org/show_bug.cgi?id=59618

Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).

  • platform/gtk/Skipped:

2011-04-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84987.
http://trac.webkit.org/changeset/84987
https://bugs.webkit.org/show_bug.cgi?id=59618

Caused crashes on the GTK+ debug bots. (Requested by mrobinson
on #webkit).

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
10:27 AM April 2011 Meeting/Threading edited by jchaffraix@webkit.org
Fixed the section to make it more obvious what were the topics (diff)
10:24 AM Changeset in webkit [85060] by leviw@chromium.org
  • 49 edits
    1 add in trunk/LayoutTests

2011-04-27 Levi Weintraub <leviw@chromium.org>

new baselines needed after r85011
https://bugs.webkit.org/show_bug.cgi?id=59581

  • platform/chromium-linux/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/chromium-win/fast/block/float/029-expected.txt:
  • platform/chromium-win/fast/block/float/031-expected.txt:
  • platform/chromium-win/fast/block/float/clamped-right-float-expected.txt:
  • platform/chromium-win/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/chromium-win/fast/block/float/nested-clearance-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/062-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/063-expected.txt:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.txt:
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-win/fast/inline/inline-box-background-expected.txt:
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.txt:
  • platform/chromium-win/fast/text/whitespace/012-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/chromium/test_expectations.txt:
10:23 AM Changeset in webkit [85059] by Carlos Garcia Campos
  • 3 edits
    2 moves
    1 add in trunk/Source/WebKit2

2011-04-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move WebViewWidget to UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=59594

API files should be under the API directory. This view widget will
be used by both C and gtk high level API, so it has been renamed
to WebKitWebViewBase.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.cpp. (webkitWebViewBaseRealize): (webkitWebViewBaseContainerAdd): (webkitWebViewBaseDispose): (webkitWebViewBaseInit): (webViewExpose): (webViewDraw): (webViewSizeAllocate): (webViewFocusInEvent): (webViewFocusOutEvent): (webViewKeyPressEvent): (webViewKeyReleaseEvent): (getEventTime): (webViewButtonPressEvent): (webViewButtonReleaseEvent): (webViewScrollEvent): (webViewMotionNotifyEvent): (webkitWebViewBaseClassInit): (webkitWebViewBaseGetType): (webkitWebViewBaseGetWebViewInstance): (webkitWebViewBaseSetWebViewInstance): (webkitWebViewBaseGetIMContext):
  • UIProcess/API/gtk/WebKitWebViewBase.h: Renamed from Source/WebKit2/UIProcess/gtk/WebViewWidget.h.
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::WebView):
9:50 AM Changeset in webkit [85058] by steveblock@google.com
  • 3 edits
    9 deletes in trunk

2011-04-27 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

This is to avoid the maintenance burden until the Android port is
fully upstreamed.

  • Source/Android.mk: Removed.

2011-04-27 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

This is to avoid the maintenance burden until the Android port is
fully upstreamed.

  • Android.mk: Removed.
  • Android.v8.wtf.mk: Removed.

2011-04-27 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

This is to avoid the maintenance burden until the Android port is
fully upstreamed.

No new tests, build change only.

  • Android.derived.jscbindings.mk: Removed.
  • Android.derived.mk: Removed.
  • Android.derived.v8bindings.mk: Removed.
  • Android.jscbindings.mk: Removed.
  • Android.mk: Removed.
  • Android.v8bindings.mk: Removed.
9:47 AM Changeset in webkit [85057] by darin@apple.com
  • 1 edit
    5 deletes in trunk/LayoutTests
  • platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-actual.checksum: Removed.
  • platform/chromium-mac/fast/forms/select-empty-option-height.checksum: Removed.
  • platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Removed.
9:22 AM Changeset in webkit [85056] by darin@apple.com
  • 7 edits in trunk/Source/WebCore

2011-04-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Somehow about:blank gets into the icon database
https://bugs.webkit.org/show_bug.cgi?id=58067
rdar://problem/6751446

Implemented the policy Brady suggested, where only http and https URLs can
be associated with and icon, guarding both on the way in to the database,
and on the way out.

  • loader/icon/IconDatabase.cpp: (WebCore::pageCanHaveIcon): Added. (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon instead of just checking for an empty URL. (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto. (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into two separate assertions and added a third. (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
  • platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file. (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name, overloaded it to work on both UChar and char, and added an assertion to it. Also moved this to the top of the file and made the UChar version usable in the shared code used even by Google. (WebCore::KURL::invalidate): Updated for name change. (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of toASCIILower since it's faster. (WebCore::KURL::parse): Updated for name changes. (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower since it's faster. (WebCore::protocolIsInHTTPFamily): Added.
  • platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily to protocolIsInHTTPFamily and added a version that works on a string. Kept the old name as an inline function so we don't have to rename all the cal sites now.
  • platform/KURLGoogle.cpp: Renamed as above. (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename. (WebCore::KURLGooglePrivate::setUtf8): Ditto. (WebCore::KURLGooglePrivate::setAscii): Ditto. (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto. (WebCore::KURLGooglePrivate::copyTo): Ditto. (WebCore::KURL::KURL): Ditto. (WebCore::KURL::protocolIsInHTTPFamily): Ditto. (WebCore::KURL::invalidate): Ditto.
  • platform/KURLGooglePrivate.h: Ditto.
  • WebCore.exp.in: Updated for above changes.
9:12 AM Changeset in webkit [85055] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

Update the Windows-XP-specific platform results after r85011 and r85052 to get the bots green.

  • platform/win-xp/fast/text/emphasis-expected.txt:
  • platform/win-xp/fast/text/emphasis-vertical-expected.txt:
9:00 AM Changeset in webkit [85054] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: browser crash on evaluation of 'throw undefined'
https://bugs.webkit.org/show_bug.cgi?id=59611

  • inspector/console/console-eval-throw-undefined-expected.txt: Added.
  • inspector/console/console-eval-throw-undefined.html: Added.

2011-04-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: browser crash on evaluation of 'throw undefined'
https://bugs.webkit.org/show_bug.cgi?id=59611

Test: inspector/console/console-eval-throw-undefined.html

  • inspector/InjectedScriptSource.js: use try/catch to protect from exception during conversion of another exception to string.
8:51 AM April 2011 Meeting/Threading edited by Csaba Osztrogonác
typo fix (diff)
8:44 AM Changeset in webkit [85053] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Migrate to Debian Squeeze
https://bugs.webkit.org/show_bug.cgi?id=59609

  • platform/qt/Skipped: Add failing tests until fix.
    • fast/workers/storage/use-same-database-in-page-and-workers.html
    • svg/W3C-SVG-1.1/struct-image-06-t.svg
    • http/tests/loading/preload-slow-loading.php
    • http/tests/security/contentSecurityPolicy/media-src-allowed.html
    • http/tests/security/contentSecurityPolicy/media-src-blocked.html
8:10 AM Changeset in webkit [85052] by jberlin@webkit.org
  • 10 edits in trunk/LayoutTests

Update the Windows-specific platform results after r85011 to get the bots green.

  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/text/emphasis-expected.txt:
  • platform/win/fast/text/emphasis-vertical-expected.txt:
8:10 AM Changeset in webkit [85051] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

2011-04-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
inspector is closed.

  • WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient. There is only one reference to it from WebInspectorFrontendClient which is held by the inspector front-end page.

Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
(-[WebInspectorWindowController initWithInspectedWebView:]):
(-[WebInspectorWindowController close]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController setAttachedWindowHeight:]):
(-[WebInspectorWindowController destroyInspectorView:]):

8:05 AM April 2011 Meeting/Threading edited by jchaffraix@webkit.org
Dumped my notes on the session (diff)
7:51 AM Changeset in webkit [85050] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: rebaselining inspector test.

  • inspector/extensions/extensions-events-expected.txt:
7:18 AM Changeset in webkit [85049] by jeffm@apple.com
  • 2 edits in trunk/Tools

Correct my IRC nickname.

  • Scripts/webkitpy/common/config/committers.py:
5:37 AM Changeset in webkit [85048] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: clicking bookmarklet multiplies resources panel entries.
https://bugs.webkit.org/show_bug.cgi?id=59590

  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.appendResource):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
4:58 AM Changeset in webkit [85047] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: opening bookmarklet disconnects DOM agent.
https://bugs.webkit.org/show_bug.cgi?id=59588

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
4:45 AM Changeset in webkit [85046] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix compiler warnings about uninitialized variables
https://bugs.webkit.org/show_bug.cgi?id=59599

Build fix. No new tests.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewObjectStoreId): (WebCore::getNewIndexId):
4:11 AM Changeset in webkit [85045] by hans@chromium.org
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-04-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Move LevelDB key coding routines to separate file
https://bugs.webkit.org/show_bug.cgi?id=59452

Move all routines concerned with encoding, decoding and comparison of
LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
IDBLevelDBCoding.cpp.

This makes IDBLevelDBBackingStore.cpp easier to work with, and will
allow for unit testing of the coding routines.

No new functionality, no new tests.

  • WebCore.gypi:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::compareKeys): (WebCore::compareIndexKeys): (WebCore::Comparator::compare): (WebCore::setUpMetadata): (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData): (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::getIndexes): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
  • storage/IDBLevelDBCoding.cpp: Added. (WebCore::IDBLevelDBCoding::encodeByte): (WebCore::IDBLevelDBCoding::maxIDBKey): (WebCore::IDBLevelDBCoding::minIDBKey): (WebCore::IDBLevelDBCoding::encodeInt): (WebCore::IDBLevelDBCoding::decodeInt): (WebCore::IDBLevelDBCoding::encodeVarInt): (WebCore::IDBLevelDBCoding::decodeVarInt): (WebCore::IDBLevelDBCoding::encodeString): (WebCore::IDBLevelDBCoding::decodeString): (WebCore::IDBLevelDBCoding::encodeStringWithLength): (WebCore::IDBLevelDBCoding::decodeStringWithLength): (WebCore::IDBLevelDBCoding::encodeDouble): (WebCore::IDBLevelDBCoding::decodeDouble): (WebCore::IDBLevelDBCoding::encodeIDBKey): (WebCore::IDBLevelDBCoding::decodeIDBKey): (WebCore::IDBLevelDBCoding::extractEncodedIDBKey): (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): (WebCore::IDBLevelDBCoding::compare): (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix): (WebCore::IDBLevelDBCoding::KeyPrefix::decode): (WebCore::IDBLevelDBCoding::KeyPrefix::encode): (WebCore::IDBLevelDBCoding::KeyPrefix::compare): (WebCore::IDBLevelDBCoding::KeyPrefix::type): (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode): (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode): (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode): (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare): (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode): (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId): (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare): (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey): (WebCore::IDBLevelDBCoding::IndexNamesKey::decode): (WebCore::IDBLevelDBCoding::IndexNamesKey::encode): (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey): (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode): (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode): (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey): (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey): (WebCore::IDBLevelDBCoding::IndexDataKey::decode): (WebCore::IDBLevelDBCoding::IndexDataKey::encode): (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexDataKey::compare): (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId): (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId): (WebCore::IDBLevelDBCoding::IndexDataKey::indexId): (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
  • storage/IDBLevelDBCoding.h: Added. (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin): (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName): (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
3:22 AM Changeset in webkit [85044] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 32-bit build after r85036.

  • wtf/Platform.h: USE(PLUGIN_HOST_PROCESS) is only true for 64-bit.
3:14 AM Changeset in webkit [85043] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-27 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Darin Adler.

Change the email used on bugzilla
https://bugs.webkit.org/show_bug.cgi?id=59582

  • Scripts/webkitpy/common/config/committers.py:
3:00 AM Changeset in webkit [85042] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expose exception details when script is paused on exception
https://bugs.webkit.org/show_bug.cgi?id=59591

When script is paused on an exception, the exception value is added as <exception>
property in the local scope and the breakpoint details message says
"Paused on excepion: '<exception to strin value>'."

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused):
3:00 AM Changeset in webkit [85041] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix after r85036.

Readd non-dead code.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

2:48 AM Changeset in webkit [85040] by koz@chromium.org
  • 3 edits
    1 copy
    1 add in trunk/Tools

2011-04-27 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

Extract map from port to builder name.
https://bugs.webkit.org/show_bug.cgi?id=58301

  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/builders.py: Added.
  • Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/factory.py:
2:42 AM Changeset in webkit [85039] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Add proxy support to GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=58852

Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.

  • GNUmakefile.am:
  • GtkLauncher/main.c: (main):
2:26 AM Changeset in webkit [85038] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-27 Annie Sullivan <sullivan@chromium.org>

Reviewed by David Levin.

Adding myself as a Chromium contributor to committers.py.

https://bugs.webkit.org/show_bug.cgi?id=59576

  • Scripts/webkitpy/common/config/committers.py:
2:21 AM Changeset in webkit [85037] by mrowe@apple.com
  • 36 edits in trunk

Remove some obsolete Xcode configuration settings.

Reviewed by Timothy Hatcher.

2:21 AM Changeset in webkit [85036] by mrowe@apple.com
  • 169 edits in trunk

Remove some dead code.

Rubber-stamped by Timothy Hatcher.

1:55 AM Changeset in webkit [85035] by yurys@chromium.org
  • 19 edits in trunk/Source/WebCore

2011-04-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [protocol] Paused event should expose exception value that caused it
https://bugs.webkit.org/show_bug.cgi?id=58996

Debug.pause event now contains an optional reference to the exception
object in case script execution is paused on a JavaScript exception.

Also JavaScript call frames are passed directly into the injected script when
we need to wrap them for passing to the front-end. This change breaks cyclic
dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidPause):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::breakProgram): (WebCore::ScriptDebugServer::editScriptSource): (WebCore::ScriptDebugServer::breakProgramCallback): (WebCore::ScriptDebugServer::handleV8DebugEvent):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::wrapCallFrames):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::init):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::wrapCallFrames): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue): (WebCore::InspectorDebuggerAgent::clear):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController):
1:34 AM Changeset in webkit [85034] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: implement incremental CSS editing in the structure view.
https://bugs.webkit.org/show_bug.cgi?id=59455

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
1:15 AM Changeset in webkit [85033] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Skip another test on GTK+ because we are still missing frame loader delegate output
in the DRT.

  • platform/gtk/Skipped: Update skipped list.
1:11 AM Changeset in webkit [85032] by mrobinson@webkit.org
  • 54 edits
    3 adds in trunk/LayoutTests

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Update GTK+ specific expected results after r85011.

  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/gtk/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/gtk/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/block/float/008-expected.txt:
  • platform/gtk/fast/block/float/029-expected.txt:
  • platform/gtk/fast/block/float/031-expected.txt:
  • platform/gtk/fast/block/float/033-expected.txt:
  • platform/gtk/fast/block/float/035-expected.txt:
  • platform/gtk/fast/block/float/clamped-right-float-expected.txt:
  • platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt:
  • platform/gtk/fast/block/float/nested-clearance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/062-expected.txt:
  • platform/gtk/fast/block/margin-collapse/063-expected.txt:
  • platform/gtk/fast/blockflow/block-level-images-expected.png:
  • platform/gtk/fast/blockflow/block-level-images-expected.txt:
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/gtk/fast/borders/bidi-012-expected.png:
  • platform/gtk/fast/borders/bidi-012-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/css/color-correction-on-background-image-expected.txt:
  • platform/gtk/fast/css/h1-in-section-elements-expected.png:
  • platform/gtk/fast/css/h1-in-section-elements-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/gtk/fast/lists/003-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.png: Added.
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/gtk/fast/repaint/box-shadow-h-expected.txt:
  • platform/gtk/fast/repaint/box-shadow-v-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
  • platform/gtk/fast/text/emphasis-vertical-expected.txt:
  • platform/gtk/fast/text/whitespace/012-expected.txt:
  • platform/gtk/plugins/resize-from-plugin-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.txt:
1:07 AM Changeset in webkit [85031] by mrobinson@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

2011-04-27 Martin Robinson <mrobinson@igalia.com>

Skip a failing test. Add GTK+-specific results for another and organize
the Skipped file a bit. Remove platform-specific results for a test which
is now a text dumping test.

  • platform/gtk/Skipped: Organize and skip a new test.
  • platform/gtk/fast/events/keydown-1-expected.png: Removed.
  • platform/gtk/fast/events/keydown-1-expected.txt: Removed.
  • platform/gtk/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
12:37 AM Changeset in webkit [85030] by mihaip@chromium.org
  • 28 edits in trunk/Source

2011-04-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Frame.h shouldn't include Document.h
https://bugs.webkit.org/show_bug.cgi?id=59560

Frame can use a forward-declared Document if we move
Frame::displayStringModifiedByEncoding's implementation out of the
header.

Size #includes Size * #includes

Before: page/Frame.h: 0.746 653 487.138

dom/Document.h: 0.220 1306 287.320

After: page/Frame.h: 0.646 653 421.838

dom/Document.h: 0.220 1189 261.580

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp:
  • bindings/generic/BindingSecurityBase.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • dom/CharacterData.cpp:
  • dom/UserTypingGestureIndicator.cpp:
  • editing/chromium/SelectionControllerChromium.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/PingLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/appcache/DOMApplicationCache.cpp:
  • loader/cache/CachedResourceRequest.cpp:
  • page/Frame.cpp: (WebCore::Frame::displayStringModifiedByEncoding):
  • page/Frame.h:
  • page/Geolocation.cpp:
  • page/Location.cpp:
  • page/Navigator.cpp:
  • page/PageGroupLoadDeferrer.cpp:
  • page/PerformanceTiming.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

2011-04-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Frame.h shouldn't include Document.h
https://bugs.webkit.org/show_bug.cgi?id=59560

Add Document.h #includes for files that were relying on transitive
#includes via Frame.h.

  • src/LocalFileSystemChromium.cpp:
  • src/StorageEventDispatcherImpl.cpp:
  • src/WebFrameImpl.h:
  • src/WebWorkerBase.cpp:
12:18 AM Changeset in webkit [85029] by Csaba Osztrogonác
  • 57 edits
    3 adds in trunk/LayoutTests

Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573

Update Qt specific expected results after r85011.

  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/qt/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/qt/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/block/float/008-expected.png:
  • platform/qt/fast/block/float/008-expected.txt:
  • platform/qt/fast/block/float/029-expected.txt:
  • platform/qt/fast/block/float/031-expected.txt:
  • platform/qt/fast/block/float/033-expected.png:
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/035-expected.png:
  • platform/qt/fast/block/float/035-expected.txt:
  • platform/qt/fast/block/float/clamped-right-float-expected.txt:
  • platform/qt/fast/block/float/nested-clearance-expected.txt:
  • platform/qt/fast/block/margin-collapse/062-expected.txt:
  • platform/qt/fast/block/margin-collapse/063-expected.txt:
  • platform/qt/fast/blockflow/block-level-images-expected.png:
  • platform/qt/fast/blockflow/block-level-images-expected.txt:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.png:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/qt/fast/borders/bidi-012-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/qt/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/qt/fast/text/whitespace/012-expected.png: Added.
  • platform/qt/fast/text/whitespace/012-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.png:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug72359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_table_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_align_right-expected.txt:
12:15 AM Changeset in webkit [85028] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Kenneth Russell.

OwnPtr assignment operator should be private
https://bugs.webkit.org/show_bug.cgi?id=59487

Unfortunately we can't remove the copy constructor because of some
detail about gcc. (The issue is documented in a comment already.)

  • wtf/OwnPtr.h:
12:04 AM Changeset in webkit [85027] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377

This cleans up some strict OwnPtr<> violations around text and box shadow data. ShadowData's linked list data
structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): (WebCore::PropertyWrapperShadow::PropertyWrapperShadow): (WebCore::PropertyWrapperShadow::blend):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): (WebCore::RenderStyle::setBoxShadow):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textShadow):
  • rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData):
  • rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::next): (WebCore::ShadowData::setNext):
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

Apr 26, 2011:

11:59 PM Changeset in webkit [85026] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

Update Qt specific expected files after r85009.

  • platform/qt/fast/replaced/table-percent-height-expected.txt:
11:52 PM Changeset in webkit [85025] by Csaba Osztrogonác
  • 113 edits
    1 copy
    22 adds in trunk/LayoutTests

[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

Update Qt specific expected files after r85009.

  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/editing/selection/5240265-expected.png:
  • platform/qt/editing/selection/5240265-expected.txt:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.txt:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/qt/fast/css/continuationCrash-expected.png:
  • platform/qt/fast/css/continuationCrash-expected.txt:
  • platform/qt/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/qt/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/qt/fast/forms/basic-buttons-expected.png: Added.
  • platform/qt/fast/forms/basic-buttons-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.png:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/blankbuttons-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug4429-expected.png.
  • platform/qt/fast/forms/blankbuttons-expected.txt:
  • platform/qt/fast/forms/button-align-expected.png: Added.
  • platform/qt/fast/forms/button-align-expected.txt:
  • platform/qt/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/qt/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/qt/fast/forms/button-generated-content-expected.png: Added.
  • platform/qt/fast/forms/button-generated-content-expected.txt:
  • platform/qt/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/qt/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/qt/fast/forms/button-line-break-expected.txt:
  • platform/qt/fast/forms/button-positioned-expected.png: Added.
  • platform/qt/fast/forms/button-positioned-expected.txt:
  • platform/qt/fast/forms/button-sizes-expected.png: Added.
  • platform/qt/fast/forms/button-sizes-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.png: Added.
  • platform/qt/fast/forms/button-style-color-expected.txt:
  • platform/qt/fast/forms/button-table-styles-expected.png: Added.
  • platform/qt/fast/forms/button-table-styles-expected.txt:
  • platform/qt/fast/forms/button-text-transform-expected.png: Added.
  • platform/qt/fast/forms/button-text-transform-expected.txt:
  • platform/qt/fast/forms/control-clip-overflow-expected.png: Added.
  • platform/qt/fast/forms/control-clip-overflow-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/formmove3-expected.png: Added.
  • platform/qt/fast/forms/formmove3-expected.txt:
  • platform/qt/fast/forms/input-button-sizes-expected.png:
  • platform/qt/fast/forms/input-button-sizes-expected.txt:
  • platform/qt/fast/forms/select-baseline-expected.png: Added.
  • platform/qt/fast/forms/select-baseline-expected.txt:
  • platform/qt/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/qt/fast/forms/targeted-frame-submission-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/width100percent-button-expected.png:
  • platform/qt/fast/replaced/width100percent-button-expected.txt:
  • platform/qt/fast/selectors/064-expected.png:
  • platform/qt/fast/selectors/064-expected.txt:
  • platform/qt/fast/table/append-cells2-expected.png:
  • platform/qt/fast/table/append-cells2-expected.txt:
  • platform/qt/fast/table/remove-td-display-none-expected.png:
  • platform/qt/fast/table/remove-td-display-none-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png: Added.
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug138725-expected.png:
  • platform/qt/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26178-expected.png:
  • platform/qt/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.png:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug39209-expected.png:
  • platform/qt/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4429-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51727-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug52505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug52506-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60749-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug68912-expected.png:
  • platform/qt/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
11:36 PM Changeset in webkit [85024] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-26 David Grogan <dgrogan@chromium.org>

Reviewed by David Levin.

Adding myself to Chromium contributors list in committers.py
https://bugs.webkit.org/show_bug.cgi?id=59565

  • Scripts/webkitpy/common/config/committers.py:
11:32 PM Changeset in webkit [85023] by jcivelli@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-26 Jay Civelli <jcivelli@chromium.org>

Reviewed by Eric Seidel.

Typedefing the shared timer function.
https://bugs.webkit.org/show_bug.cgi?id=59564

  • public/WebKitClient.h: (WebKit::WebKitClient::setSharedTimerFiredFunction):
11:16 PM Changeset in webkit [85022] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

And yet more failures resulting from r85011

  • platform/chromium/test_expectations.txt:
11:09 PM Changeset in webkit [85021] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Suppress more failures resulting from r85011

  • platform/chromium/test_expectations.txt:
11:08 PM Changeset in webkit [85020] by levin@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-04-26 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Fix some strict PassOwnPtr issues in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=59563

  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  • platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1):
  • platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): (WebCore::newStreamingTextDecoderUTF16BE):
  • platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined):
  • platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):
10:54 PM Changeset in webkit [85019] by commit-queue@webkit.org
  • 13 edits in trunk

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544

Unskip passed tests and place failing tests for other reasons to other sections.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544

Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleAddOriginAccessWhitelistEntry): (WKBundleRemoveOriginAccessWhitelistEntry): (WKBundleResetOriginAccessWhitelists):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::addOriginAccessWhitelistEntry): (WebKit::InjectedBundle::removeOriginAccessWhitelistEntry): (WebKit::InjectedBundle::resetOriginAccessWhitelists):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=42544

Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::addOriginAccessWhitelistEntry): (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10:37 PM Changeset in webkit [85018] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Suppress failures resulting from r85011 - probably just needs
new baselines.

  • platform/chromium/test_expectations.txt:
10:30 PM Changeset in webkit [85017] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-04-26 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Expose skia gpu canvas rendering as a runtime flag
https://bugs.webkit.org/show_bug.cgi?id=58683
Replace the SKIA_GPU compile flag by the pre-existing
acceleratedDrawingEnabled flag. Most code changes are trivial:
compile-time conditionals on SKIA_GPU were either replaced with
a run-time check, or a compile time check on USE(SKIA)

No new tests. Covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Added check for the acceleratedDrawing flag.
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): On Skia builds, this methos now receives a bool arg to turn on GPU-accelerated skia rendering (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::grContext):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::prepareForSoftwareDraw): (WebCore::PlatformContextSkia::prepareForHardwareDraw): (WebCore::PlatformContextSkia::syncSoftwareCanvas): (WebCore::PlatformContextSkia::markDirtyRect):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::accelerationMode): (WebCore::PlatformContextSkia::useGPU): (WebCore::PlatformContextSkia::useSkiaGPU):
10:11 PM Changeset in webkit [85016] by pfeldman@chromium.org
  • 3 edits
    1 move in trunk

2011-04-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: restore inspector test disabled in r84913.

Test: http/tests/inspector-enabled/dom-storage-open.html

  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::clearFrontend):
10:07 PM Changeset in webkit [85015] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-04-26 Ami Fischman <fischman@google.com>

Reviewed by David Levin.

Fix media/video-controls-transformed.html layouttest to compute the click
location of the play button instead of hard-coding pixel values that have
been wrong for a long time. Start expecting the test to pass in chromium
(it's currently Skipped on all platforms).
https://bugs.webkit.org/show_bug.cgi?id=58590

  • media/video-controls-transformed.html:
  • platform/chromium/test_expectations.txt:
9:55 PM Changeset in webkit [85014] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Update w/ more flakiness.

  • platform/chromium/test_expectations.txt:
9:49 PM Changeset in webkit [85013] by commit-queue@webkit.org
  • 5 edits
    5 adds in trunk

2011-04-26 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

[Chromium] Vertical positions are off for some Arabic glyphs on Linux
https://bugs.webkit.org/show_bug.cgi?id=59182

Add a test for checking vertical offsets of Arabic script shaping.
The font which is used in the test was created from scratch.

  • platform/chromium-linux/fast/text/international/arabic-vertical-offset-expected.png: Added.
  • platform/chromium-linux/fast/text/international/arabic-vertical-offset-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/arabic-vertical-offset.html: Added.
  • platform/chromium-linux/fast/text/international/resources/font-for-arabic-offset-test.ttf: Added.

2011-04-26 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

[Chromium] Vertical positions are off for some Arabic glyphs on Linux
https://bugs.webkit.org/show_bug.cgi?id=59182

Use vertical offsets of the shaping results.

Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): Added initialization of m_startingY. (WebCore::ComplexTextController::nextScriptRun): Followed the change in handling positions. (WebCore::ComplexTextController::deleteGlyphArrays): Ditto. (WebCore::ComplexTextController::createGlyphArrays): Ditto. (WebCore::ComplexTextController::resetGlyphArrays): Ditto. (WebCore::ComplexTextController::setGlyphPositions): Changed to use vertical offsets as same as horizontal offsets.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Removed m_xPositions and Added m_positions and m_startingY. (WebCore::ComplexTextController::positions): Added.
  • platform/graphics/chromium/FontLinux.cpp: Followed the change in ComplexTextController. (WebCore::Font::drawComplexText): Ditto. (WebCore::Font::floatWidthForComplexText): Ditto. (WebCore::glyphIndexForXPositionInScriptRun): Ditto. (WebCore::Font::offsetForPositionForComplexText): Ditto. (WebCore::Font::selectionRectForComplexText): Ditto.
9:44 PM Changeset in webkit [85012] by tony@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-04-26 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Fix http/tests/security/cross-frame-access-document-direct.html timeout in chromium
https://bugs.webkit.org/show_bug.cgi?id=59376

  • http/tests/security/cross-frame-access-document-direct.html: Include a try/catch for invalid access.
  • platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt: Added. Chromium includes a console.log

statement of the invalid access.

  • platform/chromium/test_expectations.txt: Remove passing test.
9:33 PM Changeset in webkit [85011] by leviw@chromium.org
  • 54 edits
    4 adds in trunk

2011-04-26 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573

Always expanding the root render object to enclose overhanging floats.

  • fast/backgrounds/size/contain-and-cover-expected.txt:
  • fast/block/float/float-overhangs-root.html: Added.
  • platform/mac/compositing/direct-image-compositing-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/mac/fast/block/float/008-expected.txt:
  • platform/mac/fast/block/float/029-expected.txt:
  • platform/mac/fast/block/float/031-expected.txt:
  • platform/mac/fast/block/float/033-expected.txt:
  • platform/mac/fast/block/float/035-expected.txt:
  • platform/mac/fast/block/float/clamped-right-float-expected.txt:
  • platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt:
  • platform/mac/fast/block/float/float-overhangs-root-expected.checksum: Added.
  • platform/mac/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/mac/fast/block/float/float-overhangs-root-expected.txt: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.txt:
  • platform/mac/fast/block/margin-collapse/062-expected.txt:
  • platform/mac/fast/block/margin-collapse/063-expected.txt:
  • platform/mac/fast/blockflow/block-level-images-expected.txt:
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/mac/fast/borders/bidi-012-expected.txt:
  • platform/mac/fast/box-shadow/basic-shadows-expected.txt:
  • platform/mac/fast/css/color-correction-on-background-image-expected.txt:
  • platform/mac/fast/css/h1-in-section-elements-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/inline/inline-box-background-expected.txt:
  • platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/mac/fast/repaint/box-shadow-h-expected.txt:
  • platform/mac/fast/repaint/box-shadow-v-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt:
  • platform/mac/fast/text/emphasis-expected.txt:
  • platform/mac/fast/text/emphasis-vertical-expected.txt:
  • platform/mac/fast/text/whitespace/012-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_right-expected.txt:

2011-04-26 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Root element should establish a new block formatting context
https://bugs.webkit.org/show_bug.cgi?id=54573

Always expanding the root renderer to include overhanging floats.

Test: fast/block/float/float-overhangs-root.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
9:31 PM Changeset in webkit [85010] by jamesr@google.com
  • 1 edit
    1 add in branches/chromium/742

2011-04-26 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add codereview.settings to the 742 branch so drover works properly
https://bugs.webkit.org/show_bug.cgi?id=59578

  • codereview.settings: Added.
9:29 PM Changeset in webkit [85009] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-26 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

Added qtwebkit layout test for the button line break fix (Bug 50521).

[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

  • platform/qt/fast/forms/button-line-break-expected.txt: Added.
  • platform/qt/fast/forms/button-line-break.html: Added.

2011-04-26 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Improper rendering of <button> tag when it contains a <br>
https://bugs.webkit.org/show_bug.cgi?id=50521

Test: platform/qt/fast/forms/button-line-break.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding):
9:10 PM Changeset in webkit [85008] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-04-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Tor Arne Vestbø.

Added instructions on how to work from behind proxy
and detailed the instructions refering to rebasing.
Windows build instructions do not work if you are behind a proxy
or have a Temp directory that you do not own directly.
https://bugs.webkit.org/show_bug.cgi?id=57246

  • building/tools.html:
8:50 PM Changeset in webkit [85007] by Chris Fleizach
  • 5 edits in trunk

2011-04-26 Chris Fleizach <Chris Fleizach>

Reviewed by Adele Peterson.

AX: Add more text marker routines to DRT
https://bugs.webkit.org/show_bug.cgi?id=58949

  • platform/mac/accessibility/textmarker-string-for-range-expected.txt: Added.
  • platform/mac/accessibility/textmarker-string-for-range.html: Added.

2011-04-26 Chris Fleizach <Chris Fleizach>

Reviewed by Adele Peterson.

AX: Add more text marker routines to DRT
https://bugs.webkit.org/show_bug.cgi?id=58949

Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
stringForMarkerRange.

  • DumpRenderTree/AccessibilityUIElement.cpp: (nextTextMarkerCallback): (previousTextMarkerCallback): (stringForTextMarkerRangeCallback): (AccessibilityUIElement::previousTextMarker): (AccessibilityUIElement::nextTextMarker): (AccessibilityUIElement::stringForTextMarkerRange): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::previousTextMarker): (AccessibilityUIElement::nextTextMarker): (AccessibilityUIElement::stringForTextMarkerRange):
8:30 PM Changeset in webkit [85006] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, even more expectations change for flaky tests.

  • platform/chromium/test_expectations.txt:
8:14 PM Changeset in webkit [85005] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change for flaky and passing tests.

  • platform/chromium/test_expectations.txt:
7:09 PM Changeset in webkit [85004] by jamesr@google.com
  • 3 edits in branches/chromium/742/Source/WebCore

Merge 85002 - 2011-04-26 James Robinson <jamesr@chromium.org> Reviewed by Kenneth Russell. [chromium] Only reset tiles if the LayerRendererChromium is actually changing https://bugs.webkit.org/show_bug.cgi?id=59572 http://trac.webkit.org/changeset/84981/ caused us to reset the tiles when LayerRendererChromium was set. We set this pointer every frame and should only reset the tiles if the new LayerRendererChromium is different from the old one (indicating a context loss), not just reset on every frame. * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setLayerRenderer): * platform/graphics/chromium/LayerTilerChromium.h:
TBR=jamesr@google.com
BUG=78880

7:07 PM Changeset in webkit [85003] by mitz@apple.com
  • 10 edits in trunk

Build fix.

Source/JavaScriptGlue:

  • Configurations/CompilerVersion.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/CompilerVersion.xcconfig:

Source/WebKit2:

  • Configurations/CompilerVersion.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
7:06 PM Changeset in webkit [85002] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

2011-04-26 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Only reset tiles if the LayerRendererChromium is actually changing
https://bugs.webkit.org/show_bug.cgi?id=59572

http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
when LayerRendererChromium was set. We set this pointer every frame
and should only reset the tiles if the new LayerRendererChromium is
different from the old one (indicating a context loss), not just reset
on every frame.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setLayerRenderer):
  • platform/graphics/chromium/LayerTilerChromium.h:
7:00 PM Changeset in webkit [85001] by dpranke@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebKit/chromium

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r84982.
http://trac.webkit.org/changeset/84982
https://bugs.webkit.org/show_bug.cgi?id=59558

re-land r84951

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebWidget.h:
  • public/mac/WebSubstringUtil.h: Added.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): (WebKit::WebFrameImpl::characterIndexForPoint):
  • src/WebFrameImpl.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::compositionRange): (WebKit::WebPopupMenuImpl::caretOrSelectionRange):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::compositionRange): (WebKit::WebViewImpl::caretOrSelectionRange):
  • src/WebViewImpl.h:
  • src/mac/WebSubstringUtil.mm: Added. (WebKit::WebSubstringUtil::attributedSubstringInRange):
6:41 PM Changeset in webkit [85000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84977.
http://trac.webkit.org/changeset/84977
https://bugs.webkit.org/show_bug.cgi?id=59568

caused crashes on the SL WK2 bots (Requested by jessieberlin
on #webkit).

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
6:28 PM Changeset in webkit [84999] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>

Reviewed by Eric Seidel.

Test case for: beginElement broken by setAttribute
https://bugs.webkit.org/show_bug.cgi?id=26019

  • svg/animations/animate-beginElementAt-expected.txt: Added.
  • svg/animations/animate-beginElementAt.svg: Added.
  • svg/animations/animate-dynamic-update-attributeName-expected.txt: Nice side effect of the patch, we are now fully passing this test.

2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>

Reviewed by Eric Seidel.

beginElement broken by setAttribute
https://bugs.webkit.org/show_bug.cgi?id=26019

Test: svg/animations/animate-beginElementAt.svg

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::attributeChanged): Reset the animation state here as the rest of the code reads it and would still think we are animating when we are not.
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
6:19 PM Changeset in webkit [84998] by ggaren@apple.com
  • 5 edits in trunk/LayoutTests

Fixed a few flaky tests, noticed while working on new-run-webkit-tests.

Reviewed by Oliver Hunt.

  • accessibility/image-link.html: Wait until the load event fires before

traversing the AX tree, since the the tree will be different after our
subresources load.

  • fast/dom/StyleSheet/detached-style-pi-expected.txt:
  • fast/dom/StyleSheet/detached-style-pi.xhtml: Wait until the load event

fires before traversing the style tree, since the the tree will be
different after our subresources load.

  • platform/mac/test_expectations.txt: Expect success for two extra tests,

since they pass when you have the right fonts.

6:16 PM Changeset in webkit [84997] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Fix 32-bit clang build.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::windowCoversAnyScreen):

  • UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel init]):

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::flipScreenYCoordinate):
(WebKit::computeFakeWindowBoundsRect):

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityHitTest:]):

6:15 PM Changeset in webkit [84996] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84989.
http://trac.webkit.org/changeset/84989
https://bugs.webkit.org/show_bug.cgi?id=59566

REGRESSION (r84989): Lots of vertical text tests failing on
windows (Requested by weinig on #webkit).

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
6:14 PM Changeset in webkit [84995] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Remove tests that are passing.

  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [84994] by kevino@webkit.org
  • 7 edits
    6 adds in trunk

Rubberstamped by Eric Seidel.

Enable waf to be used to build other ports
https://bugs.webkit.org/show_bug.cgi?id=58213

5:55 PM Changeset in webkit [84993] by jamesr@google.com
  • 2 edits in branches/chromium/742/Source/WebCore

Merge 84981 - 2011-04-26 James Robinson <jamesr@chromium.org> Reviewed by Kenneth Russell. [chromium] Clear out LayerTilerChromium's tiles on lost context https://bugs.webkit.org/show_bug.cgi?id=59233 Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are no longer valid since they exist in the previous LayerRendererChromium. Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests. * platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer):
TBR=jamesr@google.com
BUG=78880

5:53 PM Changeset in webkit [84992] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Try again:

Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310

Reviewed by Eric Seidel.

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
5:51 PM Changeset in webkit [84991] by weinig@apple.com
  • 41 edits
    31 deletes in trunk

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • Scripts/build-webkit: Remove feature.
  • iExploder/iexploder-1.3.2/htdocs/htmltags.in:
  • iExploder/iexploder-1.7.2/src/html-tags/webkit: Remove from fuzzer.

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • Configurations/FeatureDefines.xcconfig: Remove feature.

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • features.gypi: Remove feature.

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • Configurations/FeatureDefines.xcconfig: Remove feature.

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDataGridColumnListCustom.cpp: Removed.
  • bindings/js/JSDataGridDataSource.cpp: Removed.
  • bindings/js/JSDataGridDataSource.h: Removed.
  • bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
  • bindings/v8/V8DataGridDataSource.cpp: Removed.
  • bindings/v8/V8DataGridDataSource.h: Removed.
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/html.css: (input, textarea, keygen, select, button, isindex): (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
  • features.pri:
  • html/DOMDataGridDataSource.cpp: Removed.
  • html/DOMDataGridDataSource.h: Removed.
  • html/DataGridColumn.cpp: Removed.
  • html/DataGridColumn.h: Removed.
  • html/DataGridColumn.idl: Removed.
  • html/DataGridColumnList.cpp: Removed.
  • html/DataGridColumnList.h: Removed.
  • html/DataGridColumnList.idl: Removed.
  • html/DataGridDataSource.h: Removed.
  • html/HTMLDataGridCellElement.cpp: Removed.
  • html/HTMLDataGridCellElement.h: Removed.
  • html/HTMLDataGridCellElement.idl: Removed.
  • html/HTMLDataGridColElement.cpp: Removed.
  • html/HTMLDataGridColElement.h: Removed.
  • html/HTMLDataGridColElement.idl: Removed.
  • html/HTMLDataGridElement.cpp: Removed.
  • html/HTMLDataGridElement.h: Removed.
  • html/HTMLDataGridElement.idl: Removed.
  • html/HTMLDataGridRowElement.cpp: Removed.
  • html/HTMLDataGridRowElement.h: Removed.
  • html/HTMLDataGridRowElement.idl: Removed.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::ieForbidsInsertHTML):
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
  • rendering/RenderDataGrid.cpp: Removed.
  • rendering/RenderDataGrid.h: Removed.
  • rendering/RenderingAllInOne.cpp:

2011-04-26 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove Datagrid from the tree
https://bugs.webkit.org/show_bug.cgi?id=59543

  • Configurations/FeatureDefines.xcconfig: Remove feature.
5:29 PM Changeset in webkit [84990] by bfulgham@webkit.org
  • 7 edits in trunk

2011-04-26 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Implement a transparent WebView under Windows. This feature
allows the user to create small web-based applications, similar
to the dashboard on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=58300

  • Interfaces/IWebViewPrivate.idl: Add new set/get accessors to change the state of a WebView into a Layered Window, or back into a standard window.
  • Interfaces/WebKit.idl: touch to force clean build
  • WebView.cpp: (WebView::WebView): Set layered window state in constructor. (WebView::updateBackingStore): Cleanup old bitmap when finished. (WebView::performLayeredWindowUpdate): New method to do the work of calling ::UpdateLayeredWindow for the WebView with proper alpha blending. (WebView::paint): Small change to prevent accelerated compositing when using a layered window. DirectX is not compatible with ::UpdateLayeredWindow (at least currently). (WebView::WebViewWndProc): Adjust main window procedure to avoid painting a default background on a layered window (this is handled by Windows during compositing), and to deal with paint messages properly in the layered window case. (WebView::active): The layered window is not a child window, so the active state logic is slightly different. (WebView::setUsesLayeredWindow): New set method for layered stated. When called, it will convert a WebView into a Layered Window. (WebView::usesLayeredWindow): Accessor
  • WebView.h: (WebView::setUsesLayeredWindow): Declare new accessor (WebView::usesLayeredWindow): Declare new accessor

2011-04-26 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Update WinLauncher with command-line arguments to allow the
transparency to be tested. Use --transparent to create a
transparent view. Use --desktop to have the view fill the
desktop area of the screen.
https://bugs.webkit.org/show_bug.cgi?id=58300

  • WinLauncher/WinLauncher.cpp: (usesLayeredWebView): New method to indicate that the program is running with layered windows (alpha-blended transparent windows). (shouldUseFullDesktop): New method to indicate that the program is running across the full desktop (less any task bars.) (resizeSubViews): Layered window mode doesn't have any winapi child windows, so this routine is exited early for that case. (subclassForLayeredWindow): Subclass the window so we can override its defaut message loop. (computeFullDesktopFrame): Convenience function to get the desktop region and update the frame dimensions appropriately. (_tWinMain): Updated to accept the new '--transparent' and '--desktop' arguments. (InitInstance): Modified to exit early for the transparent background case. WebKit will construct our primary window (with appropriate settings) so we don't need to create one ourselves. (WndProc): (TransparentWndProc): New message loop for transparent windows, since they need special handling to support dragging.
5:17 PM April 2011 Meeting edited by adam.bergkvist@ericsson.com
(diff)
5:17 PM Changeset in webkit [84989] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-04-26 Chun-Lung Huang <alvincl.huang@gmail.com>

Reviewed by Adele Peterson.

On WebKit (Windows), glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=48459

This platform dependent patch makes WebKit (Windows) show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.
Some layout tests images:
http://www.flickr.com/photos/burorly/sets/72157625585506341/

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
5:15 PM Changeset in webkit [84988] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

2011-04-26 Jer Noble <jer.noble@apple.com>

Reviewed by Brady Eidson.

HTML5 video fullscreen transition causes an audio stutter
https://bugs.webkit.org/show_bug.cgi?id=59544

AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer
from its AVPlayer. Since you shouldn't necessarily have to destroy the
layer to render it invisible, instead just set the layer as hidden.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
5:07 PM Changeset in webkit [84987] by mrobinson@webkit.org
  • 4 edits in trunk

2011-04-26 Alejandro G. Castro <alex@igalia.com>

Remove gtk specific render expectations after the tests were
converted in text tests (r84873).

  • platform/gtk/animations/animation-drt-api-expected.txt: Removed.
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.

2011-04-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] flaky crash storage/open-database-set-empty-version.html
https://bugs.webkit.org/show_bug.cgi?id=58988

Construct the security origin directly instead of getting it from the WebKitWebFrame object.
This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
some inconsistent state.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.
5:06 PM Changeset in webkit [84986] by enne@google.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-26 Adrienne Walker <enne@google.com>

Reviewed by Geoffrey Garen.

Fix incorrect use of OwnPtr<T*> in GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=59559

  • runtime/GCActivityCallback.h:
5:05 PM Changeset in webkit [84985] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-26 Alexandre MAzari <amazari@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement LayoutTestController::setPluginsEnabled
https://bugs.webkit.org/show_bug.cgi?id=59184

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
5:01 PM Changeset in webkit [84984] by alex
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-04-26 Alejandro G. Castro <alex@igalia.com>

Remove gtk specific render expectations after the tests were
converted in text tests (r84873).

  • platform/gtk/animations/animation-drt-api-expected.txt: Removed.
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
5:01 PM April 2011 Meeting edited by adam.bergkvist@ericsson.com
(diff)
4:57 PM Changeset in webkit [84983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-26 Christian Dywan <christian@lanedo.com>

Reviewed by Eric Seidel.

Extra separator after Select All in context menu
https://bugs.webkit.org/show_bug.cgi?id=54092

  • page/ContextMenuController.cpp: Move separator to non-GTK+

port guards since it is for the spelling options menu
which the GTK+ port doesn't use.

4:53 PM Changeset in webkit [84982] by dpranke@chromium.org
  • 10 edits
    2 deletes in trunk/Source/WebKit/chromium

2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r84951.
http://trac.webkit.org/changeset/84951
https://bugs.webkit.org/show_bug.cgi?id=59558

"breaks chromium compile" (Requested by dpranke on #webkit).

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebWidget.h:
  • public/mac/WebSubstringUtil.h: Removed.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange):
  • src/WebFrameImpl.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • src/mac/WebSubstringUtil.mm: Removed.
4:51 PM Changeset in webkit [84981] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-26 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clear out LayerTilerChromium's tiles on lost context
https://bugs.webkit.org/show_bug.cgi?id=59233

Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset. In this case the tiles are
no longer valid since they exist in the previous LayerRendererChromium.

Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.

  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer):
4:43 PM Changeset in webkit [84980] by commit-queue@webkit.org
  • 10 edits in trunk

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572

Remove the unnecessary code that updates preference.

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::decode):
  • Shared/WebPreferencesStore.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAllowUniversalAccessFromFileURLs):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAllowUniversalAccessFromFileURLs): (WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Laszlo Gombos.

WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572

Remove the unnecessary code that updates preference.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
4:35 PM Changeset in webkit [84979] by mrobinson@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

2011-04-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK] Flash in divs with overflow: auto is not positioned and clipped properly
https://bugs.webkit.org/show_bug.cgi?id=57644

Manual test: plugins/windowed-in-iframe-2.html

  • manual-tests/plugins/windowed-in-iframe-2.html: Added.
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
  • plugins/PluginView.h: Added helper method to set the allocation and clip.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting the allocation immediately. Bring this method into sync with the implementation in the Qt port. (WebCore::PluginView::updateWidgetAllocationAndClip): Added. (WebCore::PluginView::plugAddedCallback): Call the new helper method.
4:31 PM Changeset in webkit [84978] by mrobinson@webkit.org
  • 5 edits in trunk

2011-04-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
https://bugs.webkit.org/show_bug.cgi?id=58818

  • platform/gtk/Skipped: Unskip a test which is no longer crashing.

2011-04-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] fast/block/float/overhanging-tall-block.html crashes in the bots
https://bugs.webkit.org/show_bug.cgi?id=58818

Prevent allocating scratch buffers larger than the target GdkDrawable
when creating a WidgetRenderingContext. This prevents incredibly large
widgets from crashing the X Server. This change also allowed greatly
simplifying the way that the painting offset is calculated.

  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap larger than the target GdkDrawable. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the blit by looking at the location of the target rect itself, rather than delaying the calculation up to this point. (WebCore::WidgetRenderingContext::calculateClipRect): Added. (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper. (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto. (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto. (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto. (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto. (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto. (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
  • platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add a member to store the IntSize mapping from the coordinates of the target to the coordinates of the scratch buffer.
4:31 PM Changeset in webkit [84977] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Daniel Bates.

Unused but set variable warning in MacroAssembelX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): do not declare the label variable if we are not going to use it. (JSC::MacroAssemblerX86_64::tailRecursiveCall): ditto. (JSC::MacroAssemblerX86_64::makeTailRecursiveCall): ditto.
4:26 PM Changeset in webkit [84976] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-26 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Respect charset in handleDataURL
https://bugs.webkit.org/show_bug.cgi?id=47746

Original patch by Kwang Yul Seo <skyul@company100.net>

We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
returns an empty string because encoding name is not specified.

Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.

This change fixes over 130 layout tests when running GTK port with cURL network backend.

  • platform/network/DataURL.cpp: (WebCore::handleDataURL):
4:20 PM Changeset in webkit [84975] by mario@webkit.org
  • 6 edits
    1 copy in trunk

2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] accessibility/aria-combobox-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=59399

Unskip the test and provide expectations for Mac and GTK.

  • accessibility/aria-combobox.html: Do not check roles to be the right ones, print them and leave the check for the expected file.
  • platform/gtk/Skipped: Unskip the test.
  • platform/gtk/accessibility/aria-combobox-expected.txt: New.
  • platform/mac/accessibility/aria-combobox-expected.txt: Updated.

2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] accessibility/aria-combobox-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=59399

Implement isExpanded(), as it's used in the layout test.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): Implemented.
4:18 PM Changeset in webkit [84974] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-04-26 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
https://bugs.webkit.org/show_bug.cgi?id=56946

Deployed the missing resource for Symbian platform.

  • tests/qwebframe/qwebframe.pro:
4:18 PM Changeset in webkit [84973] by enne@google.com
  • 2 edits in trunk/Tools

2011-04-26 Adrienne Walker <enne@google.com>

Reviewed by Kent Tamura.

[chromium] Fix memory leak in DRT due to OwnPtr<T*>
https://bugs.webkit.org/show_bug.cgi?id=59489

  • DumpRenderTree/chromium/WebViewHost.h:
4:17 PM Changeset in webkit [84972] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

2011-04-26 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Update signals description
https://bugs.webkit.org/show_bug.cgi?id=56904

Add, fix signals description that are emitted by evas_object_smart_callcabck_call in
ewk_view, ewk_frame, ewk_contextmenu.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.h:
4:15 PM Changeset in webkit [84971] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang++ build.

You can never have too many casts!

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::accessibilityConvertScreenRect):

4:12 PM Changeset in webkit [84970] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Docked Inspector doesn't behave well if inspected web view isn't at 0,0
https://bugs.webkit.org/show_bug.cgi?id=59554
<rdar://problem/9341188>

Reviewed by Steve Falkenburg.

Use GetWindowRect and ScreenToClient to properly place our inspector and inspected
web views instead of using GetClientRect. We need to correctly handle the case where
the inspected web view isn't at 0, 0.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

4:11 PM Changeset in webkit [84969] by crogers@google.com
  • 5 edits in trunk/Source/WebCore

2011-04-26 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix web audio build on mac port
https://bugs.webkit.org/show_bug.cgi?id=59355

No new tests since audio API is not yet implemented.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • webaudio/AudioContext.idl:
4:02 PM April 2011 Meeting edited by thakis@chromium.org
(diff)
4:01 PM Changeset in webkit [84968] by crogers@google.com
  • 7 edits
    2 adds in trunk/Source/WebCore

2011-04-26 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add FFTFrame implementation for FFmpeg
https://bugs.webkit.org/show_bug.cgi?id=59408

No new tests since audio API is not yet implemented.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:
  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/ffmpeg: Added.
  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): (WebCore::FFTFrame::contextForSize):
  • platform/audio/mac/FFTFrameMac.cpp:
  • webaudio/ConvolverNode.cpp:
3:59 PM Changeset in webkit [84967] by dcheng@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-26 Daniel Cheng <dcheng@chromium.org>

Reviewed by Eric Seidel.

[chromium] Implement EditorClient::canCopyCut and EditorClient::canPaste
https://bugs.webkit.org/show_bug.cgi?id=59264

  • public/WebViewClient.h: (WebKit::WebViewClient::canTriggerClipboardRead): (WebKit::WebViewClient::canTriggerClipboardWrite):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
3:58 PM Changeset in webkit [84966] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement isChecked in DRT
https://bugs.webkit.org/show_bug.cgi?id=59385

  • platform/gtk/Skipped: Unskip the layout test accessibility/aria-checkbox-checked.html.

2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement isChecked in DRT
https://bugs.webkit.org/show_bug.cgi?id=59385

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked): Implemented.
3:47 PM Changeset in webkit [84965] by alex
  • 2 edits in trunk/Tools

2011-04-26 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r84949.
http://trac.webkit.org/changeset/84949
https://bugs.webkit.org/show_bug.cgi?id=58852

Broke GTK+ compilation

  • GtkLauncher/main.c: (main):
3:17 PM UsingGitWithWebKit edited by dbates@webkit.org
Remove warning about first-time webkit-patch use since we hopefully … (diff)
3:10 PM Changeset in webkit [84964] by alex
  • 2 edits in trunk/LayoutTests

2011-04-26 Alejandro G. Castro <alex@igalia.com>

Skipped insecure-css-in-iframe.html, we are missing
didRunInsecureContent notification.

  • platform/gtk/Skipped:
3:00 PM Changeset in webkit [84963] by Csaba Osztrogonác
  • 1 edit
    61 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.

  • platform/qt/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/qt/fast/backgrounds/background-leakage-expected.txt: Added.
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/qt/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/qt/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/qt/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
  • platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
  • platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
  • platform/qt/fast/borders/bidi-002-expected.png: Added.
  • platform/qt/fast/borders/bidi-002-expected.txt: Added.
  • platform/qt/fast/borders/bidi-009a-expected.png: Added.
  • platform/qt/fast/borders/bidi-009a-expected.txt: Added.
  • platform/qt/fast/borders/bidi-012-expected.png: Added.
  • platform/qt/fast/borders/bidi-012-expected.txt: Added.
  • platform/qt/fast/borders/border-radius-different-width-001-expected.png: Added.
  • platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Added.
  • platform/qt/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/qt/fast/borders/border-radius-inset-outset-expected.txt: Added.
  • platform/qt/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/qt/fast/borders/mixed-border-styles-expected.txt: Added.
  • platform/qt/fast/borders/mixed-border-styles-radius-expected.png: Added.
  • platform/qt/fast/borders/mixed-border-styles-radius-expected.txt: Added.
  • platform/qt/fast/borders/table-borders-expected.png: Added.
  • platform/qt/fast/borders/table-borders-expected.txt: Added.
  • platform/qt/fast/borders/webkit-border-radius-expected.png: Added.
  • platform/qt/fast/borders/webkit-border-radius-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
  • platform/qt/fast/forms/select-background-none-expected.png: Added.
  • platform/qt/fast/forms/select-background-none-expected.txt: Added.
  • platform/qt/fast/html/details-add-child-1-expected.png: Added.
  • platform/qt/fast/html/details-add-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-child-2-expected.png: Added.
  • platform/qt/fast/html/details-add-child-2-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/qt/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/qt/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/qt/fast/html/details-remove-child-1-expected.png: Added.
  • platform/qt/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-remove-child-2-expected.png: Added.
  • platform/qt/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/qt/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/qt/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
  • platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
  • platform/qt/fast/table/auto-100-percent-width-expected.png: Added.
  • platform/qt/fast/table/auto-100-percent-width-expected.txt: Added.
  • platform/qt/fast/text/zero-font-size-expected.png: Added.
  • platform/qt/fast/text/zero-font-size-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/qt/svg/filters/feDropShadow-expected.png: Added.
  • platform/qt/svg/filters/feDropShadow-expected.txt: Added.
2:52 PM Changeset in webkit [84962] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Not reviewed.

Flaky Test: fast/loader/file-protocol-fragment.html
https://bugs.webkit.org/show_bug.cgi?id=59488

  • fast/loader/file-protocol-fragment.html:
2:49 PM Changeset in webkit [84961] by simon.fraser@apple.com
  • 19 edits
    1 add
    6 deletes in trunk/LayoutTests

2011-04-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Daniel Bates.

Convert some transition tests to use the pause API, and more cleanup
https://bugs.webkit.org/show_bug.cgi?id=59490

  • animations/animation-drt-api.html: Fail message was the same as the pass message (doh!).
  • platform/chromium-linux/transitions/transition-drt-api-expected.png: Removed.
  • platform/chromium-win/transitions/transition-drt-api-expected.png: Removed.
  • platform/chromium-win/transitions/transition-drt-api-expected.txt: Removed.
  • platform/gtk/transitions/transition-drt-api-expected.txt: Removed.
  • platform/mac/transitions/transition-drt-api-expected.png: Removed.
  • platform/mac/transitions/transition-drt-api-expected.txt: Removed.
  • transitions/transition-drt-api-expected.txt: Added.
  • transitions/transition-drt-api.html: Made into a text test.
  • transitions/font-family-during-transition.html: Use the pause API.
  • transitions/transition-drt-api-delay.html: General cleanup.
  • transitions/bad-transition-shorthand-crash.html: Shorten the test.
  • transitions/border-radius-transition.html:
  • transitions/default-timing-function.html:
  • transitions/interrupt-zero-duration.html: Remove style attribute
  • transitions/color-transition-premultiplied.html:
  • transitions/transition-timing-function-expected.txt:
  • transitions/transition-timing-function.html: Use pause API.
  • transitions/inherit-other-props.html:
  • transitions/transform-op-list-match.html: Whitespace.
  • transitions/opacity-transition-zindex.html: Add FIXME.
  • transitions/transition-shorthand-delay-expected.txt:
  • transitions/transition-shorthand-delay.html:
  • transitions/zero-duration-with-non-zero-delay-start-expected.txt:
  • transitions/zero-duration-with-non-zero-delay-start.html: Use runTransitionTest().
2:44 PM Changeset in webkit [84960] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-26 Evan Martin <evan@chromium.org>

Unreviewed, Chrome/Mac build fix.

  • WebKit.gypi: Remove extra file. (I removed a subtraction, but forgot to remove the corresponding addition that the subtraction was counteracting.)
2:43 PM Changeset in webkit [84959] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2011-04-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

[Windows and Leopard Tests] media/invalid-media-url-crash.html failing since r84762
https://bugs.webkit.org/show_bug.cgi?id=59324


Use a properly invalid URL, instead of http:aa. This also allows the test to
be unskipped on SL.

  • media/invalid-media-url-crash.html:
  • platform/mac-snowleopard/Skipped:
2:37 PM Changeset in webkit [84958] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Add a newline at the end of SVGFEDropShadowElement.idl.

  • svg/SVGFEDropShadowElement.idl:
2:29 PM Changeset in webkit [84957] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: fast/css/table-border-spacing.html is flaky in Debug.
2:21 PM Changeset in webkit [84956] by mihaip@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

InlineBox.h shouldn't include RenderBR.h
https://bugs.webkit.org/show_bug.cgi?id=59480

Per bug 59348 RenderBR.h is a "top header" by include * size, because
InlineBox.h includes it. There's no reason why it has to.

  • rendering/InlineBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.h:
2:21 PM Changeset in webkit [84955] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-26 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

sheriff-bot should have a create-bug command
https://bugs.webkit.org/show_bug.cgi?id=59491

This patch has some stderr unittest spew, but I will
fix it after my live demo.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2:15 PM Changeset in webkit [84954] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
I should do.

  • bindings/js/JSDOMBinding.h:

(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
2:12 PM Changeset in webkit [84953] by evan@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-26 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] refactor duplicated list of test source files
https://bugs.webkit.org/show_bug.cgi?id=59478

The platform-specific unit test files were listed twice in
WebKit.gyp: once for the components build, once for the normal
build. Refactor this into the unified webkit_unittest_files
variable. (It appears the omission of WebPageSerializerTest
in one instance was an oversight.)

  • WebKit.gyp:
  • WebKit.gypi:
2:06 PM Changeset in webkit [84952] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):

2:06 PM Changeset in webkit [84951] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebKit/chromium

2011-04-26 Robert Sesek <rsesek@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation
https://bugs.webkit.org/show_bug.cgi?id=54969

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebWidget.h:
  • public/mac/WebSubstringUtil.h: Added.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Return the result rect in window coordinates (WebKit::WebFrameImpl::characterIndexForPoint): New method on WebFrame
  • src/WebFrameImpl.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::compositionRange): New method on WebWidget; empty impl (WebKit::WebPopupMenuImpl::caretOrSelectionRange): New method on WebWidget; empty impl
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::compositionRange): New method on WebWidget (WebKit::WebViewImpl::caretOrSelectionRange): New method on WebWidget
  • src/WebViewImpl.h:
  • src/mac/WebSubstringUtil.mm: Added. (WebKit::WebSubstringUtil::attributedSubstringInRange):
2:01 PM Changeset in webkit [84950] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Roll r84945 back in with infinite recursion removed.

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
1:58 PM Changeset in webkit [84949] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-26 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Add proxy support to GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=58852

Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.

  • GtkLauncher/main.c: (main):
1:57 PM April 2011 Meeting edited by jeffm@apple.com
(diff)
1:46 PM Changeset in webkit [84948] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium/test_expectations.txt: Mark a test that seems to be passing IMAGE CRASH (I don't trust it enough yet to remove the CRASH).
1:38 PM April 2011 Meeting edited by luiz@webkit.org
(diff)
1:30 PM Changeset in webkit [84947] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Rollout previous patch. It broke stuff.

  • bindings/js/JSDOMBinding.h:

(WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
(WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
(WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
(WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:
1:24 PM Changeset in webkit [84946] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Add Qt specific expected result for new test introduced in r84930.

  • platform/qt/fast/loader/file-protocol-fragment-expected.txt: Added.
1:22 PM Changeset in webkit [84945] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
https://bugs.webkit.org/show_bug.cgi?id=59310

Reviewed by Maciej Stachowiak.

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::createStructure):
(WebCore::JSDOMWrapper::JSDOMWrapper):
Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.

  • bindings/scripts/CodeGeneratorJS.pm:

Make JSDOMWrapper the base class.

1:20 PM Changeset in webkit [84944] by mitz@apple.com
  • 17 edits
    10 adds in trunk

Choose the compiler based on the Xcode version for Snow Leopard debug builds.

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig: Added.

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
1:05 PM Changeset in webkit [84943] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

editing/text-iterator/findString.html passes on Leopard after r84750, so remove the expected
failing results to get the bots green.

  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.
12:35 PM Changeset in webkit [84942] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows Tests] media/invalid-media-url-crash.html failing since r84726.
https://bugs.webkit.org/show_bug.cgi?id=59324

The test is timing out on all of the Windows bots, so skip it to get them green.

  • platform/win/Skipped:
12:14 PM April 2011 Meeting/Threading edited by levin@chromium.org
(diff)
12:13 PM April 2011 Meeting/Threading edited by levin@chromium.org
Initial set of notes. (diff)
12:05 PM Changeset in webkit [84941] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

Not reviewed.

Add fast/loader/file-protocol-fragment.html to WebKit2 skip list
(uses layoutTestController.dumpResourceLoadCallbacks).

  • platform/mac-wk2/Skipped:
11:58 AM Changeset in webkit [84940] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-26 Adrienne Walker <enne@google.com>

Reviewed by Geoffrey Garen.

Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
https://bugs.webkit.org/show_bug.cgi?id=59469

  • platform/chromium/TraceEvent.h: (WebCore::internal::ScopeTracer::ScopeTracer):
11:57 AM Changeset in webkit [84939] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Tracking yet more flaky tests.
11:53 AM Changeset in webkit [84938] by dimich@chromium.org
  • 3 edits
    2 adds
    16 deletes in trunk/LayoutTests

2011-04-26 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

Convert fast/frames/contentWindow_Frame.html and fast/frames/contentWindow_IFrame.html to 'dumpAsText'
https://bugs.webkit.org/show_bug.cgi?id=59436

  • fast/frames/contentWindow_Frame-expected.txt: Added.
  • fast/frames/contentWindow_Frame.html:
  • fast/frames/contentWindow_iFrame-expected.txt: Added.
  • fast/frames/contentWindow_iFrame.html:
  • platform/chromium-linux/fast/frames/contentWindow_Frame-expected.png: Removed.
  • platform/chromium-linux/fast/frames/contentWindow_iFrame-expected.png: Removed.
  • platform/chromium-win/fast/frames/contentWindow_Frame-expected.png: Removed.
  • platform/chromium-win/fast/frames/contentWindow_Frame-expected.txt: Removed.
  • platform/chromium-win/fast/frames/contentWindow_iFrame-expected.png: Removed.
  • platform/chromium-win/fast/frames/contentWindow_iFrame-expected.txt: Removed.
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt: Removed.
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt: Removed.
  • platform/mac-leopard/fast/frames/contentWindow_Frame-expected.png: Removed.
  • platform/mac-leopard/fast/frames/contentWindow_iFrame-expected.png: Removed.
  • platform/mac/fast/frames/contentWindow_Frame-expected.png: Removed.
  • platform/mac/fast/frames/contentWindow_Frame-expected.txt: Removed.
  • platform/mac/fast/frames/contentWindow_iFrame-expected.png: Removed.
  • platform/mac/fast/frames/contentWindow_iFrame-expected.txt: Removed.
  • platform/qt/fast/frames/contentWindow_Frame-expected.txt: Removed.
  • platform/qt/fast/frames/contentWindow_iFrame-expected.txt: Removed.
11:52 AM April 2011 Meeting edited by rniwa@webkit.org
Added geoff- to the attendee list (diff)
11:44 AM Changeset in webkit [84937] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-26 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by David Levin.

Adding myself as a Chromium contributors to committers.py.

https://bugs.webkit.org/show_bug.cgi?id=59444

  • Scripts/webkitpy/common/config/committers.py:
11:43 AM Changeset in webkit [84936] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Add a few flaky tests.
11:31 AM Changeset in webkit [84935] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Add failing expectations for new test introduced in r84930.
11:31 AM April 2011 Meeting edited by rolandsteiner@chromium.org
(diff)
11:31 AM Changeset in webkit [84934] by ggaren@apple.com
  • 9 edits in trunk/Source

2011-04-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425


SunSpider reports no change.


Not needed anymore, since weak handles have finalizers.

  • runtime/JSString.cpp: (JSC::JSString::resolveRope): (JSC::JSString::resolveRopeSlowCase): (JSC::JSString::outOfMemory): (JSC::JSString::substringFromRope): (JSC::JSString::replaceCharacter): Updated for removal of union.
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::~JSString): (JSC::RopeBuilder::appendStringInConstruct): (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): No need for union or special constructor anymore.

2011-04-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Nixed special finalizer handling for WebCore strings
https://bugs.webkit.org/show_bug.cgi?id=59425

Not needed anymore, since weak handles have finalizers.

  • WebCore.exp.in: Exports!
  • bindings/js/DOMWrapperWorld.cpp: (WebCore::JSStringOwner::finalize): (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer, so we don't need special treatment anymore.
  • bindings/js/DOMWrapperWorld.h: (WebCore::JSStringOwner::JSStringOwner): (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T> instead of a WeakGCMap, so we can specify a custom finalizer.
  • bindings/js/JSDOMBinding.cpp: (WebCore::jsStringSlowCase):
  • bindings/js/JSDOMBinding.h: (WebCore::jsString): Updated for string map change.
11:27 AM April 2011 Meeting edited by psolanki@apple.com
(diff)
11:23 AM Changeset in webkit [84933] by abarth@webkit.org
  • 11 edits in trunk/Source/WebKit/chromium

2011-04-26 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Moar strict OwnPtr fixes for WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=59437

This patch fixes all but two strict OwnPtr issues in WebKit/chromium.

  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::setExtraData): (WebKit::WebDataSourceImpl::setNextPluginLoadObserver): (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebDataSourceImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgent::interruptAndDispatch):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printBegin):
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::createWebMediaPlayer): (WebKit::WebMediaPlayerClientImpl::loadInternal):
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
  • src/WebStorageEventDispatcherImpl.cpp: (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::settings): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
11:21 AM April 2011 Meeting edited by hayato@chromium.org
(diff)
11:13 AM April 2011 Meeting edited by noam.rosenthal@nokia.com
(diff)
11:13 AM Changeset in webkit [84932] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining

Reviewed by Antti Koivisto.

To enable HTTP pipelining post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::readBooleanPreference): Re-added. Originally added in
r76756 and removed in r84120.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
HTTP pipelining if use default is set to true. Added macro
guards to match those in ResourceRequestMac.mm.

11:11 AM WebKit Team edited by keishi@webkit.org
(diff)
11:07 AM April 2011 Meeting edited by mrobinson@webkit.org
(diff)
11:03 AM Changeset in webkit [84931] by dbates@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-04-26 Daniel Bates <dbates@webkit.org>

Add expected results for GTK and Qt ports for the test panScroll-click-hyperlink.html
(added in <http://trac.webkit.org/changeset/84922>).

  • platform/gtk/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected failure results since this port doesn't build with pan scrolling enabled.
  • platform/qt-win/fast: Added.
  • platform/qt-win/fast/events: Added.
  • platform/qt-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/qt/fast/events/panScroll-click-hyperlink-expected.txt: Added; expected failure results since the port for the Linux platform doesn't build with pan scrolling enabled.
10:58 AM Fingerprinting edited by simon.fraser@apple.com
(diff)
10:56 AM Changeset in webkit [84930] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Source/WebCore: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463
<rdar://problem/9231130>

Reviewed by Adele Peterson.

Some clients expect file: resources to be unique based on fragment identifier.
Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only

Test: fast/loader/file-protocol-fragment.html

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):

LayoutTests: Don't strip fragments from file: urls in memory cache
https://bugs.webkit.org/show_bug.cgi?id=59463

Reviewed by Adele Peterson.

  • fast/loader/file-protocol-fragment-expected.txt: Added.
  • fast/loader/file-protocol-fragment.html: Added.
10:40 AM Changeset in webkit [84929] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Added expectations for new test fast/events/panScroll-click-hyperlink.html. Added a flaky test.
10:33 AM Changeset in webkit [84928] by yi.4.shen@nokia.com
  • 5 edits in trunk/Source/WebKit/qt

2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix: QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918

Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.

  • declarative/plugin.cpp: Bump up required version to 4.7.4+ (WebKitQmlPlugin::registerTypes):
  • declarative/qdeclarativewebview.cpp: ditto
  • declarative/qdeclarativewebview_p.h: ditto
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
10:26 AM April 2011 Meeting/Threading edited by levin@chromium.org
(diff)
10:24 AM April 2011 Meeting/Threading created by levin@chromium.org
10:23 AM April 2011 Meeting edited by levin@chromium.org
(diff)
10:22 AM Changeset in webkit [84927] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Add some failing and flaky tests.
10:21 AM Changeset in webkit [84926] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DumpRenderTree/chromium should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59458

All these changes are pretty straight forward.

  • DumpRenderTree/chromium/CppBoundClass.cpp: (GetterPropertyCallback::GetterPropertyCallback): (CppBoundClass::bindGetterCallback):
  • DumpRenderTree/chromium/CppBoundClass.h: (CppBoundClass::bindProperty): (CppBoundClass::bindFallbackCallback): (CppBoundClass::bindFallbackMethod):
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestEventPrinter::createDRTPrinter): (TestEventPrinter::createTestShellPrinter):
  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createMainWindow): (TestShell::createDRTDevToolsClient):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClientMock): (WebViewHost::speechInputController): (WebViewHost::deviceOrientationClientMock): (WebViewHost::reset): (WebViewHost::navigate): (WebViewHost::setPendingExtraData): (WebViewHost::canvas):
  • DumpRenderTree/chromium/WebViewHost.h:
10:19 AM Changeset in webkit [84925] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2011-04-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Fix path to transition-test-helpers.js in a test that is skipped
on Mac but not Windows.

  • compositing/animation/animated-composited-inside-hidden.html:
10:16 AM Changeset in webkit [84924] by Adam Roben
  • 2 edits in trunk/Tools

Make DRT/win log loading errors the same way DRT/mac does

Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
<rdar://problem/5064234>, which has long since been fixed, and then made this function match
-[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.

10:16 AM Changeset in webkit [84923] by levin@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix more strict OwnPtr in WebCore (round N).
https://bugs.webkit.org/show_bug.cgi?id=59464

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::attach):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::terminate):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::preflightFailure):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerScriptLoader::load):

10:12 AM Changeset in webkit [84922] by dbates@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-26 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Add layout test to ensure we don't regress clicking when exiting pan scrolling
https://bugs.webkit.org/show_bug.cgi?id=58702

On ports that build with PAN_SCROLLING enabled (includes all Windows ports at
the time of writing), ensure that a mouse click is ignored when in pan scroll mode.

This test is expected to fail on ports either built with PAN_SCROLLING disabled
or don't support pan scrolling. In particular, this test is expected to fail on
the Apple Mac and Chromium Mac port.

  • fast/events/panScroll-click-hyperlink.html: Added.
  • platform/mac/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
10:10 AM April 2011 Meeting edited by adamk@chromium.org
(diff)
10:09 AM Changeset in webkit [84921] by tony@chromium.org
  • 16 edits in trunk/Source

2011-04-26 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Change linux ifdefs for Chromium to Unix instead, allowing
new Unix ports to be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=59297

No new tests, just changing preprocessor defines.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • dom/SelectElement.cpp:
  • loader/cache/CachedFont.cpp:
  • page/EventHandler.cpp:
  • page/chromium/EventHandlerChromium.cpp:
  • platform/Scrollbar.cpp:
  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/skia/FontCustomPlatformData.cpp:
  • platform/graphics/skia/FontCustomPlatformData.h:

2011-04-26 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Change linux ifdefs for Chromium to Unix instead, allowing
new Unix ports to be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=59297

  • src/PlatformBridge.cpp:
  • src/WebFrameImpl.cpp:
  • src/WebViewImpl.cpp:
10:03 AM April 2011 Meeting edited by mlilek@apple.com
(diff)
10:01 AM Changeset in webkit [84920] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 John Knottenbelt <jknotten@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Adjust expectation for animations/play-state.html
https://bugs.webkit.org/show_bug.cgi?id=59441

  • platform/chromium/test_expectations.txt:
9:54 AM April 2011 Meeting edited by toyoshim@chromium.org
(diff)
9:50 AM April 2011 Meeting edited by hayato@chromium.org
(diff)
9:48 AM April 2011 Meeting edited by hayato@chromium.org
(diff)
9:41 AM April 2011 Meeting edited by yutak@chromium.org
(diff)
9:40 AM Changeset in webkit [84919] by rniwa@webkit.org
  • 5 edits in trunk

2011-04-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111

Added a test to move left and right within Arabic numerals and Arabic letters.

We still fail to set the position offset properly when we moving to the left from before B
to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
and numerals respectively. This bug is to be fixed in the followup bugs.

  • editing/selection/move-left-right-expected.txt:
  • editing/selection/move-left-right.html:

2011-04-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111

Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.

The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.

Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 123 CBA abc to 123 CBA abc (there is no offset between 3 and C).

Test cases are added to editing/selection/move-left-right.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
9:33 AM April 2011 Meeting edited by tonikitoo@webkit.org
(diff)
9:30 AM Changeset in webkit [84918] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test_expectations update.

Updated expectations for newly-failing tests.

  • platform/chromium/test_expectations.txt:
9:05 AM April 2011 Meeting edited by jonlee@apple.com
(diff)
9:00 AM Changeset in webkit [84917] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test_expectations update.

Remove duplicate expectations.

  • platform/chromium/test_expectations.txt:
8:56 AM April 2011 Meeting edited by krit@webkit.org
(diff)
8:49 AM April 2011 Meeting edited by chris.mumford@palm.com
(diff)
8:37 AM April 2011 Meeting edited by Laszlo Gombos
(diff)
8:36 AM Changeset in webkit [84916] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-26 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Partial revert of http://trac.webkit.org/changeset/84893, since it
triggered a large number of layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=59459

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
8:32 AM Changeset in webkit [84915] by mitz@apple.com
  • 2 edits in trunk/Tools

REGRESSION (84876): build-webkit produces an error message
https://bugs.webkit.org/show_bug.cgi?id=59460

  • Scripts/webkitdirs.pm:
8:15 AM April 2011 Meeting edited by alex
(diff)
8:13 AM Changeset in webkit [84914] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Enable compile-time flag for LevelDB
https://bugs.webkit.org/show_bug.cgi?id=59457

Set ENABLE_LEVELDB=1 in features.gypi.

  • features.gypi:
8:11 AM Changeset in webkit [84913] by pfeldman@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-04-26 Pavel Feldman <pfeldman@google.com>

Not reviewed: disable failing inspector test while I'm finding a better way to test what it does.

  • http/tests/inspector-enabled/dom-storage-open.html-disabled: Renamed from LayoutTests/http/tests/inspector-enabled/dom-storage-open.html.
7:58 AM April 2011 Meeting edited by dgrogan@chromium.org
(diff)
7:50 AM April 2011 Meeting edited by alexis.menard@openbossa.org
(diff)
7:47 AM Changeset in webkit [84912] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-04-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Fix timestamp comparison in check-for-weak-vtables-and-externals
https://bugs.webkit.org/show_bug.cgi?id=59416

We should only re-run the check-for-weak-vtables-and-externals script
if the executable is more recent than the last run.

  • Scripts/check-for-weak-vtables-and-externals:
7:40 AM Changeset in webkit [84911] by loki@webkit.org
  • 10 edits
    6 adds in trunk/Source

2011-04-26 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903

Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.

The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/ParallelJobs.h: Added. (WTF::ParallelJobs::ParallelJobs): (WTF::ParallelJobs::numberOfJobs): (WTF::ParallelJobs::parameterForJob): (WTF::ParallelJobs::executeJobs):
  • wtf/ParallelJobsGeneric.cpp: Added. (WTF::ParallelEnvironment::ThreadPrivate::tryLockFor): (WTF::ParallelEnvironment::ThreadPrivate::executeJob): (WTF::ParallelEnvironment::ThreadPrivate::waitForFinish): (WTF::ParallelEnvironment::ThreadPrivate::workerThread):
  • wtf/ParallelJobsGeneric.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs): (WTF::ParallelEnvironment::ThreadPrivate::ThreadPrivate): (WTF::ParallelEnvironment::ThreadPrivate::create):
  • wtf/ParallelJobsLibdispatch.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs):
  • wtf/ParallelJobsOpenMP.h: Added. (WTF::ParallelEnvironment::ParallelEnvironment): (WTF::ParallelEnvironment::numberOfJobs): (WTF::ParallelEnvironment::parameterForJob): (WTF::ParallelEnvironment::executeJobs):
  • wtf/Platform.h:
  • wtf/wtf.pri:

2011-04-26 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Speeding up SVG filters with multicore (SMP) support
https://bugs.webkit.org/show_bug.cgi?id=43903

Some SVG filters execute a huge number of pixel manipulations, which
cannot be sped up by graphics accelerators, since their algorithm is
too complex. Using the power of Symmetric Multi Processing (SMP) we
can split up a task to smaller (data independent) tasks, which can be
executed independently.

The ParallelJobs framework provides a simple way for distributed
programming. The framework is based on WebKit's threading infrastructure,
Open Multi-Processing's (OpenMP) API, and libdispatch API.

  • ForwardingHeaders/wtf/ParallelJobs.h: Added.
  • platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::PaintingData::PaintingData): (WebCore::FETurbulence::noise2D): (WebCore::FETurbulence::calculateTurbulenceValueForPoint): (WebCore::FETurbulence::fillRegion): (WebCore::FETurbulence::fillRegionWorker): (WebCore::FETurbulence::apply):
  • platform/graphics/filters/FETurbulence.h:
7:27 AM Changeset in webkit [84910] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-26 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: close button is off in docked mode on a mac.
https://bugs.webkit.org/show_bug.cgi?id=59453

  • inspector/front-end/inspector.css: (.toolbar-item.close-left):
7:23 AM Changeset in webkit [84909] by pfeldman@chromium.org
  • 8 edits in trunk

2011-04-26 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: New Style is not working (UI glitch)
https://bugs.webkit.org/show_bug.cgi?id=59451

  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::setFrontend):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype._documentElementId):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMNode.prototype.documentElement):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.PageDispatcher.prototype.frameDetached):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._createNewRule):
7:03 AM Changeset in webkit [84908] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • Platform/Region.cpp: Need to include stdio.h for printf

(at least in my Qt-Linux environment).

6:51 AM April 2011 Meeting edited by keishi@webkit.org
(diff)
6:39 AM April 2011 Meeting edited by jeffm@apple.com
(diff)
6:36 AM Changeset in webkit [84907] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] layoutTestController.overridePreference() is already implemented.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Unskip now passing tests:
    • fast/events/pageshow-pagehide-on-back-cached.html
    • fast/events/pageshow-pagehide-on-back-cached-with-frames.html
6:19 AM Changeset in webkit [84906] by Csaba Osztrogonác
  • 8 edits in trunk

[Qt] Implement LayoutTestController::setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=59439

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-04-26
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAutofilled):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setAutofilled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
5:48 AM April 2011 Meeting edited by rafaelw@chromium.org
(diff)
5:25 AM Changeset in webkit [84905] by pfeldman@chromium.org
  • 7 edits in trunk

2011-04-26 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce DOMStorage::enable and disable.
https://bugs.webkit.org/show_bug.cgi?id=59445

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::restore): (WebCore::InspectorDOMStorageAgent::enable): (WebCore::InspectorDOMStorageAgent::disable):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._reset):
  • inspector/front-end/inspector.js:
5:14 AM April 2011 Meeting edited by demarchi@webkit.org
(diff)
4:35 AM Changeset in webkit [84904] by pfeldman@chromium.org
  • 14 edits in trunk/Source/WebCore

2011-04-26 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
https://bugs.webkit.org/show_bug.cgi?id=59440

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::setFrontend): (WebCore::InspectorPageAgent::frameNavigated):
  • inspector/InspectorPageAgent.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype._onLoadEventFired): (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModelResourceBinding): (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane): (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._inspectedURLChanged): (WebInspector.ExtensionServer.prototype.initExtensions):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onLoadEventFired): (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired): (WebInspector.NetworkPanel.prototype._frameNavigated):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._frameDetached): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.PageDispatcher): (WebInspector.PageDispatcher.prototype.domContentEventFired): (WebInspector.PageDispatcher.prototype.loadEventFired): (WebInspector.PageDispatcher.prototype.frameNavigated): (WebInspector.PageDispatcher.prototype.frameDetached):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._onLoadEventFired): (WebInspector.ResourcesPanel.prototype._frameNavigated):
  • inspector/front-end/inspector.js:
4:31 AM Changeset in webkit [84903] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[WK2] editing/pasteboard/paste-before-tab-span.html introdueced in r84885, but
it doesn't work with WK2 because of missing eventSender.keyDown() implementation.

  • platform/mac-wk2/Skipped: Add editing/pasteboard/paste-before-tab-span.html until fix.
3:46 AM Changeset in webkit [84902] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-26 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Remove passing tests from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=59443

  • platform/chromium/test_expectations.txt:
3:35 AM Changeset in webkit [84901] by Csaba Osztrogonác
  • 8 edits in trunk/Source/WebCore

Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
because it broke transitions/multiple-text-shadow-transition.html

Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59377

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blend):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textShadow):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::~StyleRareInheritedData):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

3:08 AM Changeset in webkit [84900] by mihaip@chromium.org
  • 8 edits in trunk/Source

2011-04-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418

We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • gyp/generate-derived-sources.sh:

2011-04-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418

We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.

  • WebCore.xcodeproj/project.pbxproj:
  • gyp/generate-derived-sources.sh:

2011-04-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Turn off make built-in implicit rules for derived sources makefile
https://bugs.webkit.org/show_bug.cgi?id=59418

We don't use any of make's built-in implicit rules, turning them off
speeds up parsing of the makefile.

  • WebKit2.xcodeproj/project.pbxproj:
2:57 AM Changeset in webkit [84899] by leo.yang@torchmobile.com.cn
  • 3 edits
    2 adds in trunk

2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313

Test case to verify webkit doesn't crash when a <use> element
is pending on resource and the document is not well-formed.
Test passes if no crash occurs in debug mode.

  • svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
  • svg/custom/use-crash-in-non-wellformed-document.svg: Added.

2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

ASSERT failure in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=59313

In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
was wrong because the document may not be well-formed.

This patch asserts the element is not pending on resource or the
document is not well-formed.

Test: svg/custom/use-crash-in-non-wellformed-document.svg

  • svg/SVGUseElement.cpp: (WebCore::isWellFormedDocument): (WebCore::SVGUseElement::insertedIntoDocument):
2:41 AM Changeset in webkit [84898] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-26 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
https://bugs.webkit.org/show_bug.cgi?id=59438

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._changeView):
1:38 AM Changeset in webkit [84897] by commit-queue@webkit.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

2011-04-26 Chang Shu <cshu@webkit.org>

Reviewed by Sam Weinig.

Convert fast/dom/keydown-1.html to dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=59390

  • fast/events/keydown-1-expected.txt: Added.
  • fast/events/keydown-1.html:
  • platform/mac/fast/events/keydown-1-expected.png: Removed.
  • platform/mac/fast/events/keydown-1-expected.txt: Removed.
1:37 AM Changeset in webkit [84896] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r84785.

  • UIProcess/gtk/WebInspectorGtk.cpp: (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
1:33 AM Changeset in webkit [84895] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r84886

  • Platform/gtk/RunLoopGtk.cpp: Include WorkItem.h
1:31 AM Changeset in webkit [84894] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-26 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Chromium DevTools: recognize WebP as a valid mimetype in the Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59332

  • src/js/DevTools.js:
12:43 AM Changeset in webkit [84893] by abarth@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-04-26 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

WebKit/chromium should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59434

This fixes about half the issues.

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::initialize):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::loadResourceSynchronously):
  • src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::connect):
12:31 AM Changeset in webkit [84892] by levin@chromium.org
  • 15 edits in trunk/Source/WebCore

Fix a few OwnPtr strict errors in WebCore headers.
https://bugs.webkit.org/show_bug.cgi?id=59431

Reviewed by Adam Barth.

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::create):

  • dom/ScriptRunner.h:

(WebCore::ScriptRunner::create):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::create):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):

  • rendering/svg/SVGResources.h:

(WebCore::SVGResources::ClipperFilterMaskerData::create):
(WebCore::SVGResources::MarkerData::create):
(WebCore::SVGResources::FillStrokeData::create):

  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::close):

  • workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::create):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::Task::create):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownStartTask::create):

12:30 AM Changeset in webkit [84891] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-26 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

Fix last strict OwnPtr violation under svg/...
https://bugs.webkit.org/show_bug.cgi?id=59429

  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removePendingResource):
12:29 AM April 2011 Meeting edited by aestes@apple.com
(diff)
12:27 AM Changeset in webkit [84890] by abarth@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-04-26 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Fix more strict OwnPtr violations in WebCore
https://bugs.webkit.org/show_bug.cgi?id=59433

These manifest in the Chromium build.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::editScriptSource):
  • bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::speechInput):
  • platform/PlatformGestureRecognizer.cpp: (WebCore::PlatformGestureRecognizer::create):
  • platform/PlatformGestureRecognizer.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create):
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::decodeHelper):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::decode):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::decodeAtIndex):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::decode):
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::addOpenDatabase):
12:18 AM Changeset in webkit [84889] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362

We don't need Qt specific expected file after r84817.

  • platform/qt/fast/events/onloadFrameCrash-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.