Timeline



May 3, 2011:

11:45 PM Changeset in webkit [85722] by yurys@chromium.org
  • 6 edits
    2 adds in trunk

2011-05-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
​https://bugs.webkit.org/show_bug.cgi?id=60031

  • inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Added.
  • inspector/elements/elements-inspect-iframe-from-different-domain.html: Added.

2011-05-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
​https://bugs.webkit.org/show_bug.cgi?id=60031

Inspected object type evaluation has moved into native bindings. This way it doesn't
depend on the current JS context.

Test: inspector/elements/elements-inspect-iframe-from-different-domain.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish real undefined values from HTMLAllCollection (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed value
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback): (WebCore::V8InjectedScriptHost::typeCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
11:36 PM Changeset in webkit [85721] by psolanki@apple.com
  • 8 edits in trunk/Source

Part of WebCore should use CFNetwork-based loader on Mac
​https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

Source/WebCore:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
up some warnings and #if USE(CFNETWORK) around code.

  • platform/mac/CookieJar.mm:
  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::notifyCookiesChanged):

  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/mac/CookieStorageMac.mm:

Source/WebKit2:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one.

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

11:25 PM Changeset in webkit [85720] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-03 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
​https://bugs.webkit.org/show_bug.cgi?id=59929

No new tests. Covered by existing layout tests

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Initialized for accelerated canvas if either the accelerated2dCanvas or the legacyAccelerated2dCanvas flags are enabled
  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): This is where the code goes to implement the functionality for the legacy vs current acceleration paths for the 2D canvas. Currently, this is a no-op, and always select the legacy path. This is temporary until we are ready to sort the GPU layout tests (rebasline vs. bug)
  • page/Settings.cpp: Added new flage for legacyAccelerated2dCanvas (WebCore::Settings::Settings): (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
  • page/Settings.h: (WebCore::Settings::legacyAccelerated2dCanvasEnabled):

2011-05-03 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
​https://bugs.webkit.org/show_bug.cgi?id=59929
Added new flag for enabling the legacy accelerated 2d canvas
The flag is not yet functional with this change.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setLegacyAccelerated2dCanvasEnabled):
  • src/WebSettingsImpl.h:
11:21 PM Changeset in webkit [85719] by jer.noble@apple.com
  • 7 edits in trunk

2011-04-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
​https://bugs.webkit.org/show_bug.cgi?id=59798

  • wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.

2011-04-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
​https://bugs.webkit.org/show_bug.cgi?id=59798

  • WebCore.vcproj/WebCore.vcproj: Add missing full screen related

files to the project.

2011-04-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
​https://bugs.webkit.org/show_bug.cgi?id=59798

  • win/tools/vsprops/FeatureDefines.vsprops: Set ENABLE_FULLSCREEN_API to true.
11:08 PM Changeset in webkit [85718] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-03 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Eric Seidel.

Unused but set variable warning in MacroAssemberX86_64
​https://bugs.webkit.org/show_bug.cgi?id=59482

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
10:46 PM Changeset in webkit [85717] by hclam@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

More 0 to nullptr.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D):
  • src/WebAudioBus.cpp: (WebKit::WebAudioBus::release):
  • src/WebBlobData.cpp: (WebKit::WebBlobData::reset):
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
10:30 PM Changeset in webkit [85716] by hclam@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

More places from 0 to nullptr.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create):
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia):
  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::createIterator):
  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale):
10:07 PM Changeset in webkit [85715] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after updating this test in r85676.

  • platform/mac/fast/text/ligature-subdivision-expected.txt:
9:59 PM Changeset in webkit [85714] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Quick suppresion for layout test failures.

  • platform/chromium/test_expectations.txt:
9:52 PM Changeset in webkit [85713] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Using nullptr instead of 0. This makes visual studio happy.

  • storage/IDBTransactionBackendInterface.h:
8:54 PM Changeset in webkit [85712] by dpranke@chromium.org
  • 3 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

  • platform/chromium-linux/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Removed.
  • platform/chromium-win/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-012-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/block/float/float-overhangs-root-expected.png:
8:36 PM Changeset in webkit [85711] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
​https://bugs.webkit.org/show_bug.cgi?id=59774

No new tests required as on new functionality.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyColor::applyValue): Added template parameter "inheritColorFromParent = false". (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Use template parameter where appropriate.
8:15 PM Changeset in webkit [85710] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Xan Lopez.

[CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
​https://bugs.webkit.org/show_bug.cgi?id=60041

Hardcode -Wno-c++0x-compat for the default compiler (if version >=
4.6.0) until our codebase is ready. This is the same as done for
autotools.

  • Source/cmake/WebKitHelpers.cmake: ditto.
8:13 PM Changeset in webkit [85709] by dpranke@chromium.org
  • 11 edits
    1 add
    2 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/forms/basic-selects-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/test_expectations.txt:
8:07 PM Changeset in webkit [85708] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85624.
​http://trac.webkit.org/changeset/85624

The same command is used also for make_names.pl, which breaks
the build.

  • Source/cmake/OptionsCommon.cmake: ditto.
7:48 PM Changeset in webkit [85707] by dpranke@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change and new baselines.

  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/test_expectations.txt:
7:34 PM Changeset in webkit [85706] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium/test_expectations.txt:
7:20 PM Changeset in webkit [85705] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.

Reviewed by Darin Adler.

Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

7:14 PM Changeset in webkit [85704] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
7:08 PM Changeset in webkit [85703] by jam@chromium.org
  • 8 edits in trunk/Source/WebKit/chromium

2011-05-03 John Abd-El-Malek <​jam@chromium.org>

Reviewed by James Robinson.

[chromium] Go through WebPermissionClient for local storage access. Also cleanup left over code from previous WebPermissionClient change.
​https://bugs.webkit.org/show_bug.cgi?id=60066

  • public/WebFrameClient.h:
  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowLocalStorage):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins): (WebKit::FrameLoaderClientImpl::allowImages): (WebKit::FrameLoaderClientImpl::didNotAllowScript): (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
6:59 PM Changeset in webkit [85702] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [85701] by dpranke@chromium.org
  • 2 edits
    4 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, remove obsolete baselines.

  • platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [85700] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make malloc validation useful
​https://bugs.webkit.org/show_bug.cgi?id=57502

Reland this patch (rolled out in 82905) without
turning it on by default.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate):
6:28 PM Changeset in webkit [85699] by jer.noble@apple.com
  • 15 edits
    1 copy
    1 move
    1 add
    1 delete in trunk/Source

2011-05-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59845

Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
and WebKit2. WebFullScreenController now uses a Client class to request work on its
behalf by WebKit and WebKit2. MediaPlayerPrivateFullscreenWindow now only creates a
CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
problems, and because a CALayerHost is overkill if the window is only drawing black to
its client area.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create

m_layerHost in the constructor.

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is

not present, fill the window with black in WM_PAINT.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
  • platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
  • platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h (WebCore::FullScreenControllerClient::~FullScreenControllerClient):

2011-05-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59845

Implementation of WebFullScreenController has been moved into WebCore, and
required virutal functions of WebFullScreenControllerClient have been added to
WebView. These functions are mostly simple accessors of existing ivars, but
m_fullScreenElement and its accessors have also been added to WebView.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::enterFullScreenForElement):
  • WebFullScreenController.cpp: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::setFullScreenElement): Added accessor. (WebVIew::fullScreenElement): Ditto. (WebView::fullScreenClientWindow): Ditto. (WebView::fullScreenClientParentWindow): Ditto. (WebView::fullScreenClientSetParentWindow): Ditto. (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document. (WebView::fullScreenClientDidEnterFullScreen): Ditto. (WebView::fullScreenClientWillExitFullScreen): Ditto. (WebView::fullScreenClientDidExitFullScreen): Ditto.
  • WebView.h:

2011-05-02 Jer Noble <​jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59845

Implement a similar full screen mode to WebKit; Re-use the same
full screen window class used in WebKit in the new WebFullScreenController.
No animations (yet), so many of the stubs remain unimplemented.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen

mode if caught.

(WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
(WebKit::WebView::fullScreenClientWindow): Added accessor.
(WebKit::WebView::fullScreenClientParentWindow): Ditto.
(WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
(WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
(WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
(WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
(WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.

  • UIProcess/win/WebView.h:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: (WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to

WebFullScreenController.

(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onKeyEvent): Handle the escape key and exit

full screen mode when detected.

(WebKit::WebView::fullScreenWindowController): Added.

  • UIProcess/win/WebView.h:
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root

full screen layer if it gets detached.

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
  • win/WebKit2.vcproj:
6:14 PM Changeset in webkit [85698] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations triaging.

  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [85697] by beidson@apple.com
  • 7 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.

Reviewed by Sam Weinig.

../WebCore:

Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:

(WebCore::Image::getCGImageArray):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getCGImageArray):

../WebKit2:

Expose a CFArrayRef of CGImageRefs as API for CG platforms:

  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryCopyCGImageArrayForURL):

  • UIProcess/API/C/cg/WKIconDatabaseCG.h:
5:38 PM Changeset in webkit [85696] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

5:38 PM Changeset in webkit [85695] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

findNextLineBreak splits InlineIterator into 3 pieces
​https://bugs.webkit.org/show_bug.cgi?id=60082

Avoid splitting InlineIterator into 3 variables with inter-dependencies.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::fastIncrementInTextNode): Added. (WebCore::InlineIterator::previousInSameNode): Added.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
5:36 PM Changeset in webkit [85694] by Lucas Forschler
  • 1 copy in tags/Safari-534.33

New tag.

5:31 PM Changeset in webkit [85693] by dino@apple.com
  • 3 edits
    3 adds in trunk

2011-05-03 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
​https://bugs.webkit.org/show_bug.cgi?id=60062

CompositeAnimation was replacing any existing
transition as a new one was created. However, it wasn't
clearing the lists in AnimationControllerPrivate that
signal when a hardware animation starts. Rather than
simple removing the existing transition, we now tell
AnimationControllerPrivate that is has gone.

Test: transitions/3d/interrupted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

2011-05-03 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
​https://bugs.webkit.org/show_bug.cgi?id=60062

  • transitions/3d/interrupted-transition-expected.txt: Added.
  • transitions/3d/interrupted-transition.html: Added.
5:23 PM Changeset in webkit [85692] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-05-03 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline queue server to handle hierarchical test results
​https://bugs.webkit.org/show_bug.cgi?id=60063

Update test result parsing done by the rebaseline queue server to handle
the hierarchical test result output that is generated as of r85254.

  • RebaselineQueueServer/templates/builder-queue-edit.html:
4:59 PM Changeset in webkit [85691] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit/win

REGRESSION(r84990): Nightly builds don't launch on Windows
​https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>

Reviewed by Steve Falkenburg.

Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.

  • Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
  • Interfaces/WebKit.idl: Touch to force a rebuild.
4:51 PM Changeset in webkit [85690] by hclam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Adding rebaseline for recent changes for mac.

  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
4:46 PM Changeset in webkit [85689] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-03 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
​https://bugs.webkit.org/show_bug.cgi?id=60083

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcessWithItem): (WebKit::WebPageProxy::tryClose): (WebKit::WebPageProxy::loadURL): (WebKit::WebPageProxy::loadURLRequest): (WebKit::WebPageProxy::loadHTMLString): (WebKit::WebPageProxy::loadAlternateHTMLString): (WebKit::WebPageProxy::loadPlainTextString): (WebKit::WebPageProxy::stopLoading): (WebKit::WebPageProxy::reload): (WebKit::WebPageProxy::goForward): (WebKit::WebPageProxy::goBack): (WebKit::WebPageProxy::goToBackForwardItem): Start responsiveness timer for load start/stop and close.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer): (WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer): Add simple RAII class to ensure the StopResponsivenessTimer is called.

(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Sends a message back to the UIProcess to indicate the WebProcess
is still responsive.

4:45 PM Changeset in webkit [85688] by hclam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-03 Enrica Casucci <​enrica@apple.com>

Reviewed by Ryosuke Niwa.

Crash in SpellingCorrectionController::respondToChangedSelection.
​https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

  • editing/selection/undo-crash-expected.txt: Added.
  • editing/selection/undo-crash.html: Added.
4:40 PM Changeset in webkit [85687] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Crash in SpellingCorrectionController::respondToChangedSelection.
​https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.

Tests: editing/selection/undo-crash.html

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::respondToChangedSelection):

LayoutTests:

  • editing/selection/undo-crash-expected.txt: Added.
  • editing/selection/undo-crash.html: Added.
4:35 PM Changeset in webkit [85686] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Incorrect line number dumping
​https://bugs.webkit.org/show_bug.cgi?id=60074

[Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails
​https://bugs.webkit.org/show_bug.cgi?id=60076

  • platform/qt-wk2/Skipped: Add a couple of failing tests.
4:28 PM Changeset in webkit [85685] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Refactor computeInlineDirectionPositionsForLine into smaller functions
​https://bugs.webkit.org/show_bug.cgi?id=60072

Split three functions off from computeInlineDirectionPositionsForLine
to improve its readability.

No new tests since this is just moving code around.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::setMarginsForRubyRun): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
4:25 PM Changeset in webkit [85684] by ddkilzer@apple.com
  • 6 edits in trunk/Source

<​http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

  • Interfaces/IWebViewPrivate.idl:

(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.

  • WebView.cpp:

(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.

  • WebView.h:

(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

4:20 PM Changeset in webkit [85683] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Tony Chang <​tony@chromium.org>

Add a bug number for a recent regression to test_expectations.txt.

  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [85682] by hclam@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
4:14 PM Changeset in webkit [85681] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

Conditionalize compositing tiled layer size-constraining logic to older
OSes.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::constrainedSize):
4:08 PM Changeset in webkit [85680] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Allow access keys to be used in shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59979

Move access key methods and members back to Document from TreeScope.
Also traverse into shadow trees when building the access key map.

No new tests. (refactoring)

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::getElementByAccessKey): (WebCore::Document::buildAccessKeyMap): (WebCore::Document::invalidateAccessKeyMap):
  • dom/Document.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::destroyTreeScopeData):
  • dom/TreeScope.h:
4:03 PM Changeset in webkit [85679] by kerz@chromium.org
  • 1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

fixing chrome continuous webkit tests after bad test-expectations merge

4:00 PM Changeset in webkit [85678] by hclam@chromium.org
  • 1 edit
    11 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations for new tests.

  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.
3:33 PM Changeset in webkit [85677] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
​https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

3:30 PM Changeset in webkit [85676] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

  • platform/mac/fast/text/script-tests/ligature-subdivision.js:
3:29 PM Changeset in webkit [85675] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Tony Chang <​tony@chromium.org>

Update results for fast/harness/results.html. We shouldn't be
ignoring these failures :(

  • fast/harness/results-expected.txt:
  • platform/chromium/test_expectations.txt:
3:25 PM Changeset in webkit [85674] by tony@chromium.org
  • 25 edits in trunk/LayoutTests

2011-05-03 Tony Chang <​tony@chromium.org>

Update chromium linux test results after r85013. The vertical
positioning of the glyphs have improved.

  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [85673] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Anton Muhin <​antonm@chromium.org>

Reviewed by Yury Semikhatsky.

[v8] remove an ASSERT from grouping logic
​https://bugs.webkit.org/show_bug.cgi?id=60024

This ASSERT was exploratory. Alas, right now I am aware of no easy way to
repro it. Removing for now for greener bots.

No new tests, only an ASSERT removal.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId):
3:20 PM Changeset in webkit [85672] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-03 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

webkit-patch post-commits HEAD.. throws an exception
​https://bugs.webkit.org/show_bug.cgi?id=60027

  • Scripts/webkitpy/common/checkout/scm/git.py:
3:16 PM Changeset in webkit [85671] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
​https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <​igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogonác.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

  • platform/qt/Skipped:
3:16 PM Changeset in webkit [85670] by luiz@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

[Qt] Layout tests may timeout if loadFinished receives false
​https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:14 PM Changeset in webkit [85669] by rniwa@webkit.org
  • 5 edits
    16 adds in trunk

2011-05-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
​https://bugs.webkit.org/show_bug.cgi?id=60000

Added pixel tests to ensure WebKit doesn't create a selection that spans across
the shadow DOM boundary of a readonly input element. Also rebaselined a test that
previously exhibited this behavior.

  • editing/selection/resources/select-across-readonly-input.js: Added. (moveMouseToMiddleOfElement):
  • editing/selection/select-across-readonly-input-1.html: Added.
  • editing/selection/select-across-readonly-input-2.html: Added.
  • editing/selection/select-across-readonly-input-3.html: Added.
  • editing/selection/select-across-readonly-input-4.html: Added.
  • editing/selection/select-across-readonly-input-5.html: Added.
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:

2011-05-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
​https://bugs.webkit.org/show_bug.cgi?id=60000

The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
in its validation process.

Tests: editing/selection/select-across-readonly-input-1.html

editing/selection/select-across-readonly-input-2.html
editing/selection/select-across-readonly-input-3.html
editing/selection/select-across-readonly-input-4.html
editing/selection/select-across-readonly-input-5.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
  • editing/VisibleSelection.h:
3:11 PM Changeset in webkit [85668] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split out layoutRunsAndFloats from layoutInlineChildren
​https://bugs.webkit.org/show_bug.cgi?id=60052

No new tests, just moving code here. There should be
no change in behavior.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
3:05 PM Changeset in webkit [85667] by luiz@webkit.org
  • 2 edits in trunk/Tools

[Qt] Layout tests may timeout if loadFinished receives false
​https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:05 PM Changeset in webkit [85666] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Add expectation to suppress new failure.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [85665] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, rolling out r85659.
​http://trac.webkit.org/changeset/85659
​https://bugs.webkit.org/show_bug.cgi?id=59977

restarting isn't working correctly

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:47 PM Changeset in webkit [85664] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
​https://bugs.webkit.org/show_bug.cgi?id=59638

  • platform/qt-wk2/Skipped: Add failing tests until fix.
2:40 PM Changeset in webkit [85663] by hclam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
​https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

  • fast/canvas/canvas-resize-after-paint-expected.txt: Added.
  • fast/canvas/canvas-resize-after-paint.html: Added.
2:33 PM Changeset in webkit [85662] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

2:21 PM Changeset in webkit [85661] by jamesr@google.com
  • 5 edits
    2 adds in trunk

2011-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
​https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

  • fast/canvas/canvas-resize-after-paint-expected.txt: Added.
  • fast/canvas/canvas-resize-after-paint.html: Added.

2011-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
​https://bugs.webkit.org/show_bug.cgi?id=59965

Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

Test: fast/canvas/canvas-resize-after-paint.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):

Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::setLayerRenderer):

Add a null check for m_drawingBuffer

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):

Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
this is unnecessary.

2:21 PM Changeset in webkit [85660] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Tony Chang <​tony@chromium.org>

Unreviewed, rolling the version of chromium to r83922.

  • DEPS:
2:18 PM Changeset in webkit [85659] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: fix http server startup/shutdown

Previous versions of the code had three problems that made startup
and shutdown flaky. The first is that it would throw exceptions
if it couldn't delete stale log files, which was overly
paranoid. The second is that some of the exceptions weren't
defined properly. The third, and most important, is that it was
using urllib to check if ports were available, which was leaving
sockets in a half-closed state, and keeping ports from being
reused. By switching to raw sockets, we are able to now reliably
restart.

This change also switches the code to using Executives to stop
processes, which will let us delete a bunch of code in the
port/* implementations and fix a weird layering problem in a
subsequent patch.

​https://bugs.webkit.org/show_bug.cgi?id=59977

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:14 PM Changeset in webkit [85658] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

fix failing printing_unittest on win32
​https://bugs.webkit.org/show_bug.cgi?id=59963

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1:57 PM Changeset in webkit [85657] by caio.oliveira@openbossa.org
  • 2 edits
    1 add in trunk/Websites/bugs.webkit.org

2011-05-03 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

Add tests to PrettyPatch
​https://bugs.webkit.org/show_bug.cgi?id=57298

Verify that 'prettify' parse the right number of files and parts
(add/remove/shared) by checking a set of patches available in
bugs.webkit.org.

  • PrettyPatch/PrettyPatch.rb: exported a couple a globals with statistics information for our test script.
  • PrettyPatch/PrettyPatch_test.rb: Added.
1:55 PM Changeset in webkit [85656] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Add some missing virtual keywords on derived-class destructors

Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

  • WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and

WebInspectorFrontendClient destructors explicitly virtual.

1:54 PM Changeset in webkit [85655] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-03 Jeff Miller <​jeffm@apple.com>

Reviewed by Darin Adler.

Unreachable URL is lost when canceling load of a new page
​https://bugs.webkit.org/show_bug.cgi?id=60057
<rdar://problem/9049135>


When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
so we can restore it if the page load fails.

  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value. (WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
  • UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.
1:51 PM Changeset in webkit [85654] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

store results.html options in localstorage
​https://bugs.webkit.org/show_bug.cgi?id=60048

This makes options persistent per-domain. It's not perfect,
but it should make it possible to have preferences for how
people would like the results.html page to render.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
1:51 PM Changeset in webkit [85653] by Adam Roben
  • 20 edits in trunk

Fix most strict PassOwnPtr violations on Windows

Fixes <​http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled

Reviewed by Anders Carlsson.

Source/WebCore:

  • loader/EmptyClients.h:
  • platform/GeolocationService.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/mock/GeolocationServiceMock.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeSafari.cpp:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now

that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)

  • FullscreenVideoController.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebInspectorClient.cpp:
  • WebHistory.cpp:
  • WebHistoryItem.cpp:
  • WebView.cpp:

Source/WebKit2:

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::writeEventHandler): Use nullptr.

Tools:

  • WebKitAPITest/Test.h: Use adoptPtr.
1:49 PM Changeset in webkit [85652] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

Extract LineInfo class
​https://bugs.webkit.org/show_bug.cgi?id=60044

Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
layout information about a line. This simplifies function signatures and clears up initialization.

No new tests as this is refactoring.

  • rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineInfo::LineInfo): (WebCore::LineInfo::isFirstLine): (WebCore::LineInfo::isLastLine): (WebCore::LineInfo::isEmpty): (WebCore::LineInfo::previousLineBrokeCleanly): (WebCore::LineInfo::setFirstLine): (WebCore::LineInfo::setLastLine): (WebCore::LineInfo::setEmpty): (WebCore::LineInfo::setPreviousLineBrokeCleanly): (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):
1:39 PM Changeset in webkit [85651] by leandro@webkit.org
  • 4 edits in trunk

2011-05-03 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

  • Source/cmake/OptionsEfl.cmake: Find zlib.

2011-05-03 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

  • CMakeListsEfl.txt: Append zlib libraries.
1:35 PM Changeset in webkit [85650] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Update node list cache count on the containing TreeScope rather than the Document
​https://bugs.webkit.org/show_bug.cgi?id=59983

Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.

No new tests. (refactoring)

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
1:33 PM Changeset in webkit [85649] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
​https://bugs.webkit.org/show_bug.cgi?id=60046

Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::TrailingObjects::TrailingObjects): (WebCore::TrailingObjects::setTrailingWhitespace): (WebCore::TrailingObjects::clear): (WebCore::TrailingObjects::appendBoxIfNeeded): (WebCore::TrailingObjects::addMidpoints): (WebCore::RenderBlock::findNextLineBreak):
1:29 PM Changeset in webkit [85648] by commit-queue@webkit.org
  • 9 edits
    2 copies
    3 adds in trunk

2011-05-03 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58448

Remove data-transfer-items.html from Qt skipped tests and create an expected
result file for data-transfer-items.html test. The need to create a expected result
file is because the test presuppose that the type of the first element in
DataTransferItems list is a html but when Qt selects a data, it first copies a text
and then it copies the html, so for Qt expected test file the first element is a
text and the second one is a html.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Added.

2011-05-03 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
​https://bugs.webkit.org/show_bug.cgi?id=58448

Implement initial support to DataTransferItems. DataTransferItems are used to
hold data for drag and drop operations. DataTransferItems hold a list of
DataTransferItem objects each of which holds an item being dragged.

  • WebCore.pro:
  • dom/DataTransferItems.idl:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/DataTransferItemsChromium.h:
  • platform/qt/ClipboardQt.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::items):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/qt/DataTransferItemQt.cpp: Added. (WebCore::DataTransferItem::create): (WebCore::DataTransferItemQt::createFromPasteboard): (WebCore::DataTransferItemQt::create): (WebCore::DataTransferItemQt::DataTransferItemQt): (WebCore::DataTransferItemQt::getAsString): (WebCore::DataTransferItemQt::getAsFile):
  • platform/qt/DataTransferItemQt.h: Added.
  • platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp. (WebCore::DataTransferItemsQt::create): (WebCore::DataTransferItemsQt::DataTransferItemsQt): (WebCore::DataTransferItemsQt::addPasteboardItem):
  • platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
1:22 PM Changeset in webkit [85647] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

2011-05-03 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

Add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
1:16 PM Changeset in webkit [85646] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

new baseline for SVG test.

  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Added.
1:11 PM Changeset in webkit [85645] by hclam@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

New baseline for GPU layout tests.

  • platform/chromium-gpu-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-gpu-mac/animations/3d/state-at-end-event-transform-expected.png: Added.
1:08 PM Changeset in webkit [85644] by commit-queue@webkit.org
  • 17 edits in trunk/Source

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

No new tests, refactoring only.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::insertedIntoTree): (WebCore::Element::removedFromTree): (WebCore::Element::attach): (WebCore::Element::detach): (WebCore::Element::recalcStyle): (WebCore::Element::shadowRoot): (WebCore::Element::ensureShadowRoot): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::setTreeScopeRecursively): (WebCore::shadowRoot): (WebCore::Node::setDocumentRecursively): (WebCore::NodeRendererFactory::findVisualParent): Updated all the call sites for shadowRoot and ensureShadowRoot in the 2 previous classes.
  • dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
  • dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
  • html/HTMLDetailsElement.cpp:
  • html/HTMLSummaryElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

  • src/WebElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

  • DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
​https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.
1:07 PM Changeset in webkit [85643] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-05-03 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement mediaSliderTrack
​https://bugs.webkit.org/show_bug.cgi?id=59998

Implement paintMediaSliderTrack.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::paintMediaSliderTrack):
  • platform/efl/RenderThemeEfl.h:
1:03 PM Changeset in webkit [85642] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
​https://bugs.webkit.org/show_bug.cgi?id=60023

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.aggregates): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotNodesProvider):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
12:52 PM Changeset in webkit [85641] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
​https://bugs.webkit.org/show_bug.cgi?id=60029

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset): (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
12:51 PM Changeset in webkit [85640] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-05-03 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtDeclarative Webview element has a fixed white background
​https://bugs.webkit.org/show_bug.cgi?id=40918

QProperty REVISION feature is not present in certain Qt Trunk clones.
These builds report their version as 4.8.0, and therefore break on the
prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
the existance of Q_REVISION.

  • declarative/plugin.cpp: (WebKitQmlPlugin::registerTypes):
  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
12:50 PM Changeset in webkit [85639] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping test timing out in the GTK 64-bit bot.

  • platform/gtk/Skipped: Skipped media/video-volume-slider.html.
12:47 PM Changeset in webkit [85638] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

improve styling of options menu in results.html file

  • fast/harness/results.html:
12:42 PM Changeset in webkit [85637] by hclam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

New baseline and add test expectation to suppress failure.

  • platform/chromium-gpu-win/animations/3d/replace-filling-transform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:34 PM Changeset in webkit [85636] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

Don't include the test itself in expanded test results
​https://bugs.webkit.org/show_bug.cgi?id=60051

When loading from local disk, we can't force it to render as
plain text, which causes the page to actually run. Also,
the extra clutter of another iframe is probably not worth it.

If we decide we want this later, we can add it back in as a
preference that's off by default.

  • fast/harness/results.html:
12:31 PM Changeset in webkit [85635] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Test expectation for a slow test to avoid flakiness.

  • platform/chromium/test_expectations.txt:
12:25 PM Changeset in webkit [85634] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

Fix test that broke after adding CSS animations.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
12:19 PM Changeset in webkit [85633] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [85632] by hclam@chromium.org
  • 4 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-05-03 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
12:11 PM Changeset in webkit [85631] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-03 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursor update updates indexes
​https://bugs.webkit.org/show_bug.cgi?id=59995

This test creates an object store, adds both a unique and a non-unique index,
adds a record, opens a cursor, changes the record, and verifies that both
indexes correctly updated to reflect the modified record.

  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html: Added.
11:45 AM Changeset in webkit [85630] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-05-03 James Robinson <​jamesr@chromium.org>

Remove stale expectations for animations/3d in chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
11:45 AM Changeset in webkit [85629] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>

Reviewed by Dan Bernstein.

When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::updateArrowPlacement):

11:43 AM Changeset in webkit [85628] by jamesr@google.com
  • 4 edits in trunk

2011-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
​https://bugs.webkit.org/show_bug.cgi?id=59839

Ignore animations/3d when run in CPU mode as these are compositor tests.

  • platform/chromium/test_expectations.txt:

2011-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
​https://bugs.webkit.org/show_bug.cgi?id=59839

Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
11:42 AM Changeset in webkit [85627] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/696

Merge 84270 - 2011-04-19 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
​https://bugs.webkit.org/show_bug.cgi?id=58419

Added new test for cross-iframe focus changes on plugin clicks.

  • plugins/mouse-click-iframe-to-plugin-expected.txt: Added.
  • plugins/mouse-click-iframe-to-plugin.html: Added.

2011-04-19 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
​https://bugs.webkit.org/show_bug.cgi?id=58419

Switched to using FocusController when moving focus to a plugin
so that cross-frame focus changes are handled correctly.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent):

TBR=​commit-queue@webkit.org

11:18 AM Changeset in webkit [85626] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

make pixel zooming in results.html file less jarring
​https://bugs.webkit.org/show_bug.cgi?id=60038

-Hide zoomed images when you mouse out of the document or
mouseover an iframe.
-Handle the case where the zoomed images overlap the actual images.

  • fast/harness/results.html:
11:15 AM Changeset in webkit [85625] by demarchi@webkit.org
  • 2 edits in trunk/Tools

2011-05-03 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85471.
​http://trac.webkit.org/changeset/85471
​https://bugs.webkit.org/show_bug.cgi?id=59922

The rule of thumb in EFL is that you init in all the places
you use it. So, if in your application you call ecore_evas_*
functions, you have to call ecore_evas_init() first.

  • EWebLauncher/main.c: always call *_init() functions when you use that namespace. (quit): (main):
11:10 AM Changeset in webkit [85624] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

[CMAKE] Unreviewed build fix for gcc >= 4.6

Same fix as done in r84123. CMake explicitly pass the arguments to
make_names.pl, so let's make them the same.

  • Source/cmake/OptionsCommon.cmake: ditto.
11:00 AM Changeset in webkit [85623] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>

Reviewed by Dan Bernstein.

Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.

Source/WebCore:

Added fast/inline/skipped-whitespace-client-rect.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteQuads):

LayoutTests:

Added fast/inline/skipped-whitespace-client-rect.html

  • fast/inline/skipped-whitespace-client-rect-expected.txt: Added.
  • fast/inline/skipped-whitespace-client-rect.html: Added.
10:43 AM Changeset in webkit [85622] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
10:34 AM Changeset in webkit [85621] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-03 Xan Lopez <​xlopez@igalia.com>

Reviewed by Anders Carlsson.

Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
​https://bugs.webkit.org/show_bug.cgi?id=59261

Use unary '+' to force proper type detection in template arguments
with GCC 4.6.0. See bug report for more details.

  • runtime/Structure.cpp: (JSC::StructureTransitionTable::remove): Use '+' to force precise type detection. (JSC::StructureTransitionTable::add): ditto.
  • runtime/Structure.h: (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.
10:27 AM Changeset in webkit [85620] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • page/Settings.cpp:
10:20 AM Changeset in webkit [85619] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59974 - Update image map on the containing TreeScope rather than the Document
​https://bugs.webkit.org/show_bug.cgi?id=59974

No new tests. (reefactoring)

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): (WebCore::HTMLMapElement::insertedIntoDocument): (WebCore::HTMLMapElement::removedFromDocument):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageMap):
10:18 AM Changeset in webkit [85618] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • loader/HistoryController.cpp:
10:17 AM Changeset in webkit [85617] by rolandsteiner@chromium.org
  • 25 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
​https://bugs.webkit.org/show_bug.cgi?id=59966

No new tests. (refactoring)

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::elementsFromAttribute): (WebCore::AccessibilityRenderObject::activeDescendant):
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  • css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): (WebCore::CSSCursorImageValue::cachedImage):
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/Element.h: (WebCore::Element::updateId):
  • dom/Node.cpp: (WebCore::Node::querySelector):
  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::resetFormOwner):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dataList):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::control):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::glyphElement):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getElementById):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::viewTarget):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::targetElement):
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate):
10:14 AM Changeset in webkit [85616] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • css/StyleMedia.cpp:
10:11 AM Changeset in webkit [85615] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Prune #includes from FrameView.h (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=59957

Reviewed by Anders Carlsson.

  • page/FrameView.h:

Prune #includes.

  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • page/win/FrameCGWin.cpp:
  • platform/Scrollbar.cpp:

Add not necessary #includes.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Add now necessary forward declaration.

9:45 AM Changeset in webkit [85614] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <​ojan@chromium.org>

Fix test accidentally modified in ​http://trac.webkit.org/changeset/85610.

  • fullscreen/full-screen-zIndex.html:
9:42 AM Changeset in webkit [85613] by Dimitri Glazkov
  • 5 edits in branches/chromium/742

Merge 84587 - 2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=59053

  • fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
  • fast/events/shadow-boundary-crossing.html: Added new sub-test.

2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=59053

Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost

explicitly.

TBR=Dimitri Glazkov
Review URL: ​http://codereview.chromium.org/6914018

9:39 AM Changeset in webkit [85612] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-05-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

remove no longer used method
​https://bugs.webkit.org/show_bug.cgi?id=59981

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
9:33 AM Changeset in webkit [85611] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitLibraries

Part 1 of 2: <​http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
<rdar://problem/8924448>

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added declaration.
(wkSetHTTPPipeliningMaximumPriority): Added declaration.
(wkSetHTTPPipeliningPriority): Added declaration.

  • win/lib/WebKitSystemInterface.lib: Updated.
9:30 AM Changeset in webkit [85610] by ojan@chromium.org
  • 7 edits in trunk

2011-05-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=59978

Add a checkbox to switch between image toggling (default)
and just showing results for expected/actual images.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:

2011-05-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=59978

Output -diffs.html files. This matches old-run-webkit-tests.
In theory, we could use data urls in the results.html file, but
data urls don't currently have access to local files.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
9:25 AM Changeset in webkit [85609] by tony@chromium.org
  • 7 edits in trunk/Tools

2011-05-02 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] remove some obsolete references to .checksum files
​https://bugs.webkit.org/show_bug.cgi?id=59971

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:22 AM Changeset in webkit [85608] by satish@chromium.org
  • 7 edits
    1 delete in trunk/LayoutTests

2011-05-03 Satish Sampath <​satish@chromium.org>

Unreviewed, update test expectations for chromium.

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
9:21 AM Changeset in webkit [85607] by adamk@chromium.org
  • 4 edits in trunk

2011-05-02 Adam Klein <​adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
​https://bugs.webkit.org/show_bug.cgi?id=59992

  • .gitignore: Ignore new chromium/crypto directory.

2011-05-02 Adam Klein <​adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
​https://bugs.webkit.org/show_bug.cgi?id=59992

  • DEPS:
9:18 AM Changeset in webkit [85606] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
​https://bugs.webkit.org/show_bug.cgi?id=60026

Return a wrapper for Node in toV8(Node*) when called with a node of type
SHADOW_ROOT_NODE instead of entering infinite recursion.

  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
8:41 AM Changeset in webkit [85605] by jberlin@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Revert r85550 and r85575.

Rubber-stamped by Adam Roben.

Variables cannot be exported via the .def file. Instead, they should be annotated with
JS_EXPORTDATA.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):

  • runtime/Structure.h:

(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

8:14 AM April 2011 Meeting edited by vestbo@webkit.org
(diff)
8:05 AM Changeset in webkit [85604] by satish@chromium.org
  • 12 edits in trunk/LayoutTests

2011-05-03 Satish Sampath <​satish@chromium.org>

Reviewed by Tony Gentilcore.

Rebaseline speech input layout test expectations for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=59742

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium/test_expectations.txt:
6:54 AM Changeset in webkit [85603] by Adam Roben
  • 43 edits in trunk

Allow implicit conversion from nullptr_t to PassOwnPtr

This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
strict PassOwnPtr mode.

Fixes <​http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.

  • wtf/MessageQueue.h:

(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
Use the new implicit conversion.

Source/WebCore:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • bindings/js/ScheduledAction.cpp:
  • css/CSSStyleSelector.cpp:
  • css/MediaList.cpp:
  • css/MediaQueryMatcher.cpp:
  • css/SVGCSSStyleSelector.cpp:
  • dom/MessagePort.cpp:
  • html/InputType.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • page/ContextMenuController.cpp:
  • page/Page.cpp:
  • platform/PlatformGestureRecognizer.cpp:
  • platform/PurgeableBuffer.h:
  • platform/graphics/ImageBuffer.h:
  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/mac/PurgeableBufferMac.cpp:
  • platform/text/RegularExpression.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:
  • rendering/style/ShadowData.cpp:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/svg/RenderSVGResourcePattern.cpp:

Source/WebKit/chromium:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • src/WebMediaPlayerClientImpl.cpp:

Source/WebKit/mac:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • History/WebHistory.mm:
  • Plugins/WebNetscapePluginEventHandler.mm:
  • WebView/WebView.mm:

Source/WebKit2:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • Platform/CoreIPC/Connection.cpp:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebPage/DrawingArea.cpp:

Tools:

Take advantage of implicit nullptr_t -> PassOwnPtr conversion

  • DumpRenderTree/chromium/CppBoundClass.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
6:37 AM Changeset in webkit [85602] by apavlov@chromium.org
  • 2 edits in branches/chromium/742/Source/WebCore/inspector/front-end

Merge 85415 - 2011-05-01 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: address stack frame scriptName -> url rename in timeline panel.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/6914017

6:25 AM Changeset in webkit [85601] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix inspector status bar image glyph reference in network panel.

  • inspector/front-end/networkPanel.css: (.network-larger-resources-status-bar-item .glyph):
6:11 AM Changeset in webkit [85600] by yurys@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-03 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Provide Chromium test expectaions for new test.

  • platform/chromium/inspector/console/console-log-document-proto-expected.txt: Added.
6:10 AM Changeset in webkit [85599] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rebaseline inspector test.

  • inspector/storage-panel-dom-storage-expected.txt:
  • inspector/storage-panel-dom-storage.html:
6:02 AM Changeset in webkit [85598] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to ARM specific Skipped list

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
5:56 AM Changeset in webkit [85597] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger agent to DOMDebugger.
​https://bugs.webkit.org/show_bug.cgi?id=60019

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  • inspector/generate-inspector-idl:
5:48 AM Changeset in webkit [85596] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
​https://bugs.webkit.org/show_bug.cgi?id=60014

  • inspector/console/console-log-document-proto-expected.txt: Added.
  • inspector/console/console-log-document-proto.html: Added.
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/console/console-log-toString-object.html:

2011-05-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
​https://bugs.webkit.org/show_bug.cgi?id=60014

Test: inspector/console/console-log-document-proto.html

  • inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
2:53 AM Changeset in webkit [85595] by Carlos Garcia Campos
  • 5 edits in trunk

2011-05-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59695

  • GNUmakefile.am:
  • configure.ac:

2011-05-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
​https://bugs.webkit.org/show_bug.cgi?id=59695

  • GNUmakefile.am:
2:30 AM Changeset in webkit [85594] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <​pnormand@igalia.com>

Unreviewed, unskip now passing test.

[GTK] media/video-controls-transformed.html fails
​https://bugs.webkit.org/show_bug.cgi?id=50706

  • platform/gtk/Skipped:
2:17 AM Changeset in webkit [85593] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fixed typo in inspector style.

  • inspector/front-end/inspector.css: (.status-bar-item > .glyph):
2:13 AM Changeset in webkit [85592] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Not reviewed: re-applied r85589.

  • src/js/DevTools.js: (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
2:01 AM Changeset in webkit [85591] by pfeldman@chromium.org
  • 4 edits in trunk/Source

2011-05-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: revision history storage is too slow.
​https://bugs.webkit.org/show_bug.cgi?id=59939

It turns out that iterating localStorage keys is very
expensive (results in slow inspector start), refactor revision
history in order not to rely upon that operation.

1:55 AM Changeset in webkit [85590] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, needed rebaseline after revision r85499.

  • platform/gtk/fast/replaced/table-percent-height-expected.txt:
1:00 AM Changeset in webkit [85589] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [remote debugging] use document.title to set window name.
​https://bugs.webkit.org/show_bug.cgi?id=60012

  • src/js/DevTools.js: (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
12:54 AM Changeset in webkit [85588] by pfeldman@chromium.org
  • 6 edits
    2 adds
    8 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine toolbar icon images.
​https://bugs.webkit.org/show_bug.cgi?id=59931

  • WebCore.gypi:
  • inspector/front-end/Images/auditsIcon.png: Removed.
  • inspector/front-end/Images/consoleIcon.png: Removed.
  • inspector/front-end/Images/elementsIcon.png: Removed.
  • inspector/front-end/Images/networkIcon.png: Removed.
  • inspector/front-end/Images/profilesIcon.png: Removed.
  • inspector/front-end/Images/resourcesIcon.png: Removed.
  • inspector/front-end/Images/scriptsIcon.png: Removed.
  • inspector/front-end/Images/timelineIcon.png: Removed.
  • inspector/front-end/Images/toolbarIcons.png: Added.
  • inspector/front-end/Images/toolbarIconsSmall.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.toolbar-icon): (#toolbar-dropdown .toolbar-icon): (.toolbar-item:active .toolbar-icon): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.toolbar-item.elements .toolbar-icon): (.toolbar-item.resources .toolbar-icon): (#toolbar-dropdown .toolbar-item.resources .toolbar-icon): (.toolbar-item.network .toolbar-icon): (#toolbar-dropdown .toolbar-item.network .toolbar-icon): (.toolbar-item.scripts .toolbar-icon): (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon): (.toolbar-item.timeline .toolbar-icon): (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon): (.toolbar-item.profiles .toolbar-icon): (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon): (.toolbar-item.audits .toolbar-icon): (#toolbar-dropdown .toolbar-item.audits .toolbar-icon): (.toolbar-item.console .toolbar-icon): (#toolbar-dropdown .toolbar-item.console .toolbar-icon): (.status-bar-item > .glyph):
12:52 AM Changeset in webkit [85587] by pfeldman@chromium.org
  • 5 edits
    1 add
    21 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine status bar button glyphs.
​https://bugs.webkit.org/show_bug.cgi?id=59885

  • WebCore.gypi:
  • inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
  • inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
  • inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
  • inspector/front-end/Images/consoleButtonGlyph.png: Removed.
  • inspector/front-end/Images/dockButtonGlyph.png: Removed.
  • inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
  • inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
  • inspector/front-end/Images/excludeButtonGlyph.png: Removed.
  • inspector/front-end/Images/focusButtonGlyph.png: Removed.
  • inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
  • inspector/front-end/Images/gearButtonGlyph.png: Removed.
  • inspector/front-end/Images/helpButtonGlyph.png: Removed.
  • inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
  • inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
  • inspector/front-end/Images/percentButtonGlyph.png: Removed.
  • inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
  • inspector/front-end/Images/recordButtonGlyph.png: Removed.
  • inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
  • inspector/front-end/Images/reloadButtonGlyph.png: Removed.
  • inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
  • inspector/front-end/Images/undockButtonGlyph.png: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.status-bar-item > .glyph): (#dock-status-bar-item .glyph): (body.detached #dock-status-bar-item .glyph): (#console-status-bar-item .glyph): (.clear-status-bar-item .glyph): (button.enable-toggle-status-bar-item .glyph): (button.enable-toggle-status-bar-item.toggled-on .glyph): (.scripts-pause-on-exceptions-status-bar-item .glyph): (.scripts-toggle-pretty-print-status-bar-item .glyph): (.toggle-breakpoints .glyph): (.toggle-breakpoints.toggled-on .glyph): (.resources-larger-resources-status-bar-item .glyph): (.timeline-filter-status-bar-item .glyph): (.garbage-collect-status-bar-item .glyph): (.record-profile-status-bar-item .glyph): (.record-profile-status-bar-item.toggled-on .glyph): (.heap-snapshot-status-bar-item .glyph): (.node-search-status-bar-item .glyph): (.percent-time-status-bar-item .glyph): (.focus-profile-node-status-bar-item .glyph): (.exclude-profile-node-status-bar-item .glyph): (.reset-profile-status-bar-item .glyph): (.delete-storage-status-bar-item .glyph): (.refresh-storage-status-bar-item .glyph):
  • inspector/front-end/inspector.js:

May 2, 2011:

11:04 PM Changeset in webkit [85586] by Simon Fraser
  • 3 edits
    2 adds in trunk

2011-05-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Possible crash when removing elements with reflections
​https://bugs.webkit.org/show_bug.cgi?id=60009

RenderLayer's destructor deleted its z-order list Vector pointers
before removing the reflection layer. However, the reflection cleanup
code could call back into the RenderLayer to dirty z-order lists,
so move reflection cleanup to before z-order vector deletion.

The test crashes when run manually a few times with MallocScribble enabled,
but I was not able to create a test that crashed reliably.

Test: fast/reflections/remove-reflection-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
10:07 PM Changeset in webkit [85585] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-02 Ian Henderson <​ianh@apple.com>

Reviewed by Dan Bernstein.

CSS !important not respected by JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=60007

  • fast/css/important-js-override-expected.txt: Added.
  • fast/css/important-js-override.html: Added.

2011-05-02 Ian Henderson <​ianh@apple.com>

Reviewed by Dan Bernstein.

CSS !important not respected by JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=60007

The addParsedProperty and addParsedProperties methods were subtly
different. The former did not check for !important before setting the
given property.

Change addParsedProperties to call addParsedProperty and move the
relevant code. The one other caller of this method, in
editing/markup.cpp, probably wanted this behavior anyway.

Test: fast/css/important-js-override.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
10:02 PM Changeset in webkit [85584] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-05-02 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] White screen displays when using MiniBrowser with DrawingAreaImpl
​https://bugs.webkit.org/show_bug.cgi?id=60003

When using DrawingAreaImpl, we need to properly pass the viewSize to the WebPage.
Otherwise, the dirty rect will always be empty and we will not draw.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::viewSize):
9:45 PM Changeset in webkit [85583] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Compiler warning in Tools/MiniBrowser/main.c
​https://bugs.webkit.org/show_bug.cgi?id=59986

Remove a compiler warning.

  • MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers from complaining.
9:03 PM Changeset in webkit [85582] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:03 PM Changeset in webkit [85581] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-02 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Style error fix.

  • WebCoreSupport/ChromeClientEfl.cpp:
8:57 PM Changeset in webkit [85580] by hclam@chromium.org
  • 1 edit
    28 adds in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

New baselines for SVG tests for Chromium Leopard build.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
8:54 PM Changeset in webkit [85579] by Dimitri Glazkov
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r85578.
​http://trac.webkit.org/changeset/85578
​https://bugs.webkit.org/show_bug.cgi?id=59976

The test needs more lovin'. Voluntary rollout.

  • media/video-document-click-expected.txt: Removed.
  • media/video-document-click.html: Removed.
7:28 PM Changeset in webkit [85578] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add layout tests for clicking in media documents.
​https://bugs.webkit.org/show_bug.cgi?id=59976

  • media/video-document-click-expected.txt: Added.
  • media/video-document-click.html: Added.
7:22 PM Changeset in webkit [85577] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Ben Wells <​benwells@chromium.org>

Reviewed by Simon Fraser.

Cleanup variable usage in RenderObject.cpp paintOutline()
​https://bugs.webkit.org/show_bug.cgi?id=59911

No new tests for this, there should be no change in behaviour.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
7:03 PM Changeset in webkit [85576] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash that was introduced in r85515.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchSyncMessage):
If didReceiveSyncMessage returns ManualReply, the client took ownership of the reply
encoder so we must leak it to avoid a double-free.

7:00 PM Changeset in webkit [85575] by jberlin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove an assertion that Windows was hitting on launch.

Rubber-stamped by Oliver Hunt.

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):

  • runtime/Structure.h:

(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

6:51 PM Changeset in webkit [85574] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: adding and removing values
​https://bugs.webkit.org/show_bug.cgi?id=59953

  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-remove-values.html: Added.
6:48 PM Changeset in webkit [85573] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

The web process locks up when the plug-in process crashes
​https://bugs.webkit.org/show_bug.cgi?id=59999
<rdar://problem/8889303>

Add a hash map from plug-in paths to CoreIPC connections to PluginProcessConnectionManager.
Add PluginProcessConnectionManager::pluginProcessCrashed and make it look up the corresponding
CoreIPC connection and call postConnectionDidCloseOnConnectionWorkQueue on it.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
  • Platform/CoreIPC/Connection.h:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): (WebKit::PluginProcessConnectionManager::removePluginProcessConnection): (WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed):
6:46 PM Changeset in webkit [85572] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by James Robinson.

REGRESSION(r84672): showTree doesn't work for input/textarea elements
​https://bugs.webkit.org/show_bug.cgi?id=60001

When shadow is null, try retrieving the inner element of a render text control.

  • dom/Node.cpp: (WebCore::traverseTreeAndMark):
6:34 PM Changeset in webkit [85571] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix Windows build.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
6:19 PM Changeset in webkit [85570] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Dispatch the PluginProcessCrashed on the connection work queue
​https://bugs.webkit.org/show_bug.cgi?id=59996

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Add the web process as a queue client.

(WebKit::WebProcess::terminate):
Remove the web process as a queue client.

(WebKit::WebProcess::willProcessMessageOnClientRunLoop):
Try calling willProcessWebProcessMessageOnClientRunLoop.

  • WebProcess/WebProcess.messages.in: Add the DispatchOnConnectionQueue attribute to PluginProcessCrashed.
6:12 PM Changeset in webkit [85569] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Send a PluginProcessCrashed message to all web processes when a plug-in crashes
​https://bugs.webkit.org/show_bug.cgi?id=59994

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose): Iterate over all contexts and send PluginProcessCrashed to all web processes in each context.

(WebKit::PluginProcessProxy::didFinishLaunching):
Call setShouldCloseConnectionOnMachExceptions on the CoreIPC connection.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed): Add empty stub.
  • WebProcess/WebProcess.messages.in: Add message.
6:04 PM Changeset in webkit [85568] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2

Reviewed by Geoff Garen.

  • Configurations/CompilerVersion.xcconfig:
6:02 PM Changeset in webkit [85567] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Plug-in not completely repainted after a crash
​https://bugs.webkit.org/show_bug.cgi?id=59991

Call Widget::invalidate().

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginProcessCrashed):
5:53 PM Changeset in webkit [85566] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make PluginProcessConnectionManager a member of WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=59989

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::pluginProcessConnectionManager):
5:43 PM Changeset in webkit [85565] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Expectation for new test.

  • platform/chromium/test_expectations.txt:
5:36 PM Changeset in webkit [85564] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item index when URLs are filtered from back/forward list

Reviewed by Brady Eidson.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): We need to update the current index to account for filtered items
for all items before the current item in the array.

5:28 PM Changeset in webkit [85563] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:26 PM Changeset in webkit [85562] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/742

Merge 85335
BUG=80255
Review URL: ​http://codereview.chromium.org/6913012

5:24 PM Changeset in webkit [85561] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

5:20 PM Changeset in webkit [85560] by Joseph Pecoraro
  • 3 edits
    3 adds in trunk

2011-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Respect fixed text-indent on ::-webkit-input-placeholder
​https://bugs.webkit.org/show_bug.cgi?id=59825

Placeholder text does not appear in the render tree
dumps, so this is a pixel test for the position of
the placeholder affected by text-indent.

  • fast/forms/input-placeholder-text-indent.html: Added.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.txt: Added.

2011-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Respect fixed text-indent on ::-webkit-input-placeholder
​https://bugs.webkit.org/show_bug.cgi?id=59825

Test: fast/forms/input-placeholder-text-indent.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): indent by a fixed text-indent size specified on the placeholder style.
5:17 PM Changeset in webkit [85559] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 84085
BUG=79595

5:14 PM Changeset in webkit [85558] by cevans@google.com
  • 4 edits
    16 copies in branches/chromium/742

Merge 85355
BUG=79075
Review URL: ​http://codereview.chromium.org/6913011

5:12 PM Changeset in webkit [85557] by cevans@google.com
  • 4 edits
    16 copies in branches/chromium/696

Merge 85355
BUG=79075

5:10 PM Changeset in webkit [85556] by ericu@chromium.org
  • 6 edits in trunk

2011-05-02 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Eric Seidel.

Some FileWriter progress events should be queued
​https://bugs.webkit.org/show_bug.cgi?id=50846

  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h: Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.

2011-05-02 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Eric Seidel.

Some FileWriter progress events should be queued
​https://bugs.webkit.org/show_bug.cgi?id=50846

  • fast/filesystem/resources/file-writer-events.js: (onWrite): Expect readyState at onwrite to be DONE now, not WRITING.
  • fast/filesystem/resources/file-writer-utils.js: Switch to using onwrite, now that it works.
4:57 PM Changeset in webkit [85555] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 84300
BUG=79055

4:51 PM Changeset in webkit [85554] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/696

Merge 83690
BUG=78948

4:51 PM Changeset in webkit [85553] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursor mutation in object store
​https://bugs.webkit.org/show_bug.cgi?id=59933

This is a test case *adapted* from a test in Mozilla's IndexedDB
test suite. The original test checked cursor mutation while iterating
an index cursor (tracked as bug 59822). This test checks whether the
cursor mutation is successfully recognized while iterating a straight
objectstore cursor. Specifically, it deletes a record that's already
been iterated, then adds a record to the objectstore during iteration,
then checks that no records were skipped and that the added record is
eventually found during iteration.

  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt: Added.
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html: Added.
4:44 PM Changeset in webkit [85552] by rniwa@webkit.org
  • 4 edits in branches/chromium/742

Merge 84919 - 2011-04-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
​https://bugs.webkit.org/show_bug.cgi?id=49111

Added a test to move left and right within Arabic numerals and Arabic letters.

We still fail to set the position offset properly when we moving to the left from before B
to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
and numerals respectively. This bug is to be fixed in the followup bugs.

  • editing/selection/move-left-right-expected.txt:
  • editing/selection/move-left-right.html:

2011-04-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
​https://bugs.webkit.org/show_bug.cgi?id=49111

Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.

The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.

Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 123 CBA abc to 123 CBA abc (there is no offset between 3 and C).

Test cases are added to editing/selection/move-left-right.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

Review URL: ​http://codereview.chromium.org/6911017

4:43 PM Changeset in webkit [85551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Jia Pu <​jpu@apple.com>

Reviewed by Alexey Proskuryakov.

[Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
​https://bugs.webkit.org/show_bug.cgi?id=59836
<rdar://problem/9275983>

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::truncatedStringForLookupMenuItem): (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
4:42 PM Changeset in webkit [85550] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

4:41 PM Changeset in webkit [85549] by beidson@apple.com
  • 6 edits in trunk/Source

<rdar://problem/9340945> and ​https://bugs.webkit.org/show_bug.cgi?id=59973
In Aperture, a WebView might be dealloc'ed before it finishes loading.

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.

  • platform/RuntimeApplicationChecks.h:

../WebKit/mac:

  • WebView/WebView.mm:

(needsSelfRetainWhileLoadingQuirk):
(-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
(-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
(-[WebView _didFailLoadWithError:forFrame:]): Ditto.
(-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.

4:40 PM Changeset in webkit [85548] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add runtests_unittest.py
​https://bugs.webkit.org/show_bug.cgi?id=59955

I forgot to add this file in a previous patch.

  • Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
4:38 PM Changeset in webkit [85547] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 84422
BUG=78327
Review URL: ​http://codereview.chromium.org/6909014

4:36 PM Changeset in webkit [85546] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 84422
BUG=78327

4:28 PM Changeset in webkit [85545] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected result after r85499.

  • platform/qt/fast/replaced/table-percent-height-expected.png:
  • platform/qt/fast/replaced/table-percent-height-expected.txt:
4:25 PM Changeset in webkit [85544] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/742

Merge 85406
BUG=67923
Review URL: ​http://codereview.chromium.org/6907011

4:23 PM Changeset in webkit [85543] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 85406
BUG=67923

4:22 PM Changeset in webkit [85542] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Test expectation for new test.

  • platform/chromium/test_expectations.txt:
4:19 PM Changeset in webkit [85541] by msaboff@apple.com
  • 5 edits in trunk

2011-05-02 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

crash in JSC::RegExp::match
​https://bugs.webkit.org/show_bug.cgi?id=58922

New tests to check for proper clearing and chaining of backtrack
data labels.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:

2011-05-02 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

crash in JSC::RegExp::match
​https://bugs.webkit.org/show_bug.cgi?id=58922

Cleared chained backtrack data label when linking label even if that
label doesn't chain itself. This is needed so that subsequent
backtrack data labels point to the next outer paren and not within
the current paren.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
4:18 PM Changeset in webkit [85540] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Avoid wasted cycles updating paths when popping the context stack
​https://bugs.webkit.org/show_bug.cgi?id=59967

CanvasRenderingContext2D has to map the current path through
transforms whenever the context stack is popped, which creates
a lot of platform path objects. Avoid extra work here when the
path is empty, or when the transform is identity.

  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
4:13 PM Changeset in webkit [85539] by enne@google.com
  • 8 edits in trunk/LayoutTests

2011-05-02 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, rebaseline small scrollbar image differences after r85527
​https://bugs.webkit.org/show_bug.cgi?id=58907

This could be tickling the same bug that is showing up in bug 58587.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
4:12 PM Changeset in webkit [85538] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:05 PM Changeset in webkit [85537] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Change the testing EWS to log failures explicitly to avoid an infinite loop.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4:04 PM Changeset in webkit [85536] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:46 PM Changeset in webkit [85535] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Text does not split on white space when typing to the edge of window.
​https://bugs.webkit.org/show_bug.cgi?id=59968
<rdar://problem/9112683>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: editing/inserting/typing-at-end-of-line.html

This is a regression introduced when we converted the line box tree to
floating point in r78846. In findNextLineBreak, there was still one place where
the character width was treated as int and truncated and we were inconsistent
in the way we treated a character that did not fit entirely in the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

  • editing/inserting/typing-at-end-of-line.html: Added.
  • platform/mac/editing/inserting/typing-at-end-of-line-expected.txt: Added.
3:40 PM Changeset in webkit [85534] by hclam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Test expectations for Chromium Mac port.

  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [85533] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Tiny bit of heap cleanup.

Reviewed by Oliver Hunt.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::contains): Tightened up an assertion and a comment.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Moved inlines out of the class
definition, for better clarity.

3:37 PM Changeset in webkit [85532] by tony@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-05-02 Tony Chang <​tony@chromium.org>

Remove unused files.

  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed. This file differs from

the value in the png file, but I assume that the png is correct (more recently generated).

  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Removed.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Removed.
  • platform/mac/fast/table/multiple-captions-display-expected.checksum: Removed.
3:30 PM Changeset in webkit [85531] by enne@google.com
  • 2 edits in trunk/Tools

2011-05-02 Adrienne Walker <​enne@google.com>

Unreviewed, fix misspelled contributor name.

  • Scripts/webkitpy/common/config/committers.py:
3:28 PM Changeset in webkit [85530] by cevans@google.com
  • 1 edit
    7 copies
    5 deletes in branches/chromium/742

Merge 85436
BUG=75696
Review URL: ​http://codereview.chromium.org/6911011

3:23 PM Changeset in webkit [85529] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected result after r85499.

  • platform/qt/fast/replaced/table-percent-height-expected.png:
  • platform/qt/fast/replaced/table-percent-height-expected.txt:
3:20 PM Changeset in webkit [85528] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-05-02 Chang Shu <​cshu@webkit.org>

Reviewed by Martin Robinson.

[GTK][Qt] fast/events/keydown-1.html fails
​https://bugs.webkit.org/show_bug.cgi?id=59586

Replace mac-specific keys with cross-platform keys to make the test
pass on GTK and Qt platforms.

  • fast/events/keydown-1.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:13 PM Changeset in webkit [85527] by enne@google.com
  • 5 edits
    4 adds in trunk

2011-04-27 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

Add test for multiple invalidations of the same size.
​https://bugs.webkit.org/show_bug.cgi?id=58907

This tests a bug in Chromium where canvas state was not being properly
reset between draw calls and a cached canvas of the same size was
being used to paint into that retained incorrect state.

  • compositing/repaint/same-size-invalidation-expected.txt: Added.
  • compositing/repaint/same-size-invalidation.html: Added.
  • platform/chromium-gpu/compositing/repaint/same-size-invalidation-expected.png: Added.

2011-04-19 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
​https://bugs.webkit.org/show_bug.cgi?id=58907

Additionally, move the context save/restore logic to a place where it
will reset the translation added in LayerTilerChromium.

Test: compositing/repaint/same-size-invalidation.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
  • platform/graphics/chromium/PlatformCanvas.h:
3:04 PM Changeset in webkit [85526] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

Unreviewed buildfix after r85343.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

2:55 PM Changeset in webkit [85525] by hclam@chromium.org
  • 21 edits
    41 adds
    1 delete in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Add test expectations for SVG changes.

  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
2:43 PM Changeset in webkit [85524] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

cr-linux-ews should run tests
​https://bugs.webkit.org/show_bug.cgi?id=59272

This patch turns on testing for the cr-linux-ews. Yay!

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
2:36 PM Changeset in webkit [85523] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-05-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Correct marking of interpreter data in mixed mode builds
​https://bugs.webkit.org/show_bug.cgi?id=59962

We had a few places in mixed mode builds where we would not
track data used by the interpreter for marking. This patch
corrects the problem and adds a number of assertions to catch
live Structures being collected.

  • JavaScriptCore.exp:
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::addStructureStubInfo): (JSC::CodeBlock::addGlobalResolveInfo):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitDirectPutById):
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap):
  • runtime/Structure.h: (JSC::Structure::typeInfo): (JSC::Structure::previousID): (JSC::Structure::propertyStorageCapacity): (JSC::Structure::propertyStorageSize): (JSC::Structure::get): (JSC::Structure::materializePropertyMapIfNecessary):
2:18 PM Changeset in webkit [85522] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Add test expectations to accomodate new tests.

  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [85521] by xan@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Use native NullPtr when using GCC 4.6.0 and C++0x
​https://bugs.webkit.org/show_bug.cgi?id=59252

GCC 4.6.0 has nullptr support, use it when possible.

  • wtf/NullPtr.cpp: include config.h to pull in Platform.h before NullPtr.h, since we need the GCC_VERSION_AT_LEAST definition.
  • wtf/NullPtr.h: check for GCC >= 4.6.0 and C++0x in order to use native nullptr.
2:05 PM Changeset in webkit [85520] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Adjust test expectations.

  • platform/chromium/test_expectations.txt:
2:04 PM Changeset in webkit [85519] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Handle DispatchOnConnectionQueue for asynchronous messages
​https://bugs.webkit.org/show_bug.cgi?id=59959

If any asynchronous messages have the DispatchOnConnectionQueue attribute,
create a new willProcess{Receiver}MessageOnClientRunLoop.

  • Scripts/webkit2/messages.py:
  • Fix a regex bug where we would only parse attributes on synchronous messages.
  • Collect messages with the dispatch_on_connection_queue flag set. We only handle asynchronous messages currently; sync message support will be added when/if the need arises.
  • Scripts/webkit2/messages_unittest.py: Update test.
2:04 PM Changeset in webkit [85518] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85483.
​http://trac.webkit.org/changeset/85483
​https://bugs.webkit.org/show_bug.cgi?id=59958

Causes media test failures. (Requested by eric_carlson on
#webkit).

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::updatePlayState):
  • html/HTMLMediaElement.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): (WebCore::MediaPlayerPrivateAVFoundation::load): (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): (WebCore::MediaPlayerPrivateAVFoundation::paint): (WebCore::MediaPlayerPrivateAVFoundation::duration): (WebCore::MediaPlayerPrivateAVFoundation::seeking): (WebCore::MediaPlayerPrivateAVFoundation::updateStates): (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): (WebCore::MediaPlayerPrivateAVFoundation::repaint): (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
1:49 PM Changeset in webkit [85517] by hclam@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: inline autoincrement key added on put
​https://bugs.webkit.org/show_bug.cgi?id=59936

  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
1:45 PM Changeset in webkit [85516] by Martin Robinson
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <​mrobinson@igalia.com>

Incorporate a review comment that I mistakenly omitted from my last commit.

  • DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
1:37 PM Changeset in webkit [85515] by abarth@webkit.org
  • 18 edits in trunk/Source

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59924

  • css/CSSGrammar.y:
  • platform/graphics/mac/SimpleFontDataMac.mm:
    • Memory management for the font cache is somewhat... complext. This will require some careful thought to sort out.

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59924

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedFrame):
  • WebView/WebView.mm: (-[WebView _injectMailQuirksScript]): (-[WebView _injectOutlookQuirksScript]): (toStringVector):

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59924

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::dispatchSyncMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::releaseArguments):
    • The memory management for this class is very strange. I wrote a large comment. Hopefully a kind soul will come by and fix it.
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::unload):
  • UIProcess/API/mac/WKView.mm: (-[WKView _setFindIndicator:fadeOut:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::toStringVector):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop):
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
1:32 PM Changeset in webkit [85514] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: inline autoincrement key added on put
​https://bugs.webkit.org/show_bug.cgi?id=59936

  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
1:28 PM Changeset in webkit [85513] by kerz@chromium.org
  • 5 edits in branches/chromium/742

Merge 85264 - 2011-04-28 Mike Reed <​reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas
​https://bugs.webkit.org/show_bug.cgi?id=59700

  • platform/chromium/test_expectations.txt:

2011-04-28 Mike Reed <​reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas -- skia only
​https://bugs.webkit.org/show_bug.cgi?id=59700

Test:
canvas/philip/tests/2d.shadow.alpha.3.html
canvas/philip/tests/2d.shadow.alpha.4.html
canvas/philip/tests/2d.shadow.alpha.5.html
fast/canvas/canvas-fillPath-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/css/text-input-with-webkit-border-radius.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/canvas/canvas-getImageData.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6913001

1:23 PM Changeset in webkit [85512] by leviw@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-05-02 Levi Weintraub <​leviw@chromium.org>

Reviewed by Eric Seidel.

showLineTree/showLineTreeForThis would make working with the line box tree easier
​https://bugs.webkit.org/show_bug.cgi?id=59662

Adding a showLineTree/showLineTreeForThis method to help visualize and debug
the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.

No new tests since this is a debugging feature only and not compiled in release.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::showLineTreeForThis): (WebCore::InlineBox::showLineTreeAndMark): (WebCore::InlineBox::showBox): (showLineTree):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::showLineTreeAndMark):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::showBox):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::showLineTreeAndMark):
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderTreeForThis): (WebCore::RenderObject::showLineTreeForThis): (showTree): (showLineTree):
  • rendering/RenderObject.h:
1:20 PM Changeset in webkit [85511] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewd. Build fix.

Adjust test expectations to make build bots happy.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [85510] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
​https://bugs.webkit.org/show_bug.cgi?id=59917

Since default event handlers are not retargeted, we should always attempt ancestor
traversal to find out whether the event.

  • html/MediaDocument.cpp: (WebCore::ancestorVideoElement): Added ancestor-traversing helper. (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
1:02 PM Changeset in webkit [85509] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS should report the list of unexpected failures
​https://bugs.webkit.org/show_bug.cgi?id=59923

We cache the results of the first layout test results run on the task
so the EWS can grab them later. Another option is to include them in
the exception that's thrown, but this approach seemed slightly more
aesthetic.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
12:55 PM Changeset in webkit [85508] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Pages with accelerated compositing do not redraw unless scrolled
​https://bugs.webkit.org/show_bug.cgi?id=59851

Added a setNeedDisplay on the non-composited content layer after
the size is changed so it paints the full size of the layer. Called
only for the areas newly exposed, if any.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::sizeDidChange):
12:50 PM Changeset in webkit [85507] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/mac/WebCoreSystemInterface.h:
12:49 PM Changeset in webkit [85506] by hclam@chromium.org
  • 108 edits
    1 copy
    14 adds
    1 delete in trunk/LayoutTests

2011-05-02 Alpha Lam <​hclam@chromium.org>

Not reviewed. Build fix.

Rebaseline SVG layout tests for chromium port.

  • platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/editing/style/block-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/table-selection-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-linux/svg/text/textPathBoundsBug-expected.png:
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/chromium-mac/editing/style/block-style-003-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-mac/editing/style/table-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/textPathBoundsBug-expected.png.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png:
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.png:
  • platform/chromium-win/editing/style/block-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/table-selection-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
12:43 PM Changeset in webkit [85505] by tony@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk

2011-05-02 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

convert manual-tests/bugzilla-6821.html to a layout test
​https://bugs.webkit.org/show_bug.cgi?id=59404

  • fast/css/hover-update-expected.txt: Added.
  • fast/css/hover-update.html: Added.

2011-05-02 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

convert manual-tests/bugzilla-6821.html to a layout test
​https://bugs.webkit.org/show_bug.cgi?id=59404

Test: fast/css/hover-update.html

  • manual-tests/bugzilla-6821.html: Removed.
12:42 PM Changeset in webkit [85504] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add base case for a test-running EWS
​https://bugs.webkit.org/show_bug.cgi?id=59920

Later I will subclass this to run the Chromium Linux EWS.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
12:41 PM Changeset in webkit [85503] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Need a way to handle CoreIPC messages on the connection work queue
​https://bugs.webkit.org/show_bug.cgi?id=59954

Add a Connection::QueueClient abstract class. This class has a single pure virtual
member function, willProcessMessageOnClientRunLoop which should return true if the message
should be forwarded to the next Connection::QueueClient in the list or Connection::Client's
run loop for processing and false otherwise. Users of Connection can use addQueueClient to
add clients and all messages will be dispatched to the queue clients first.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::processIncomingMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::QueueClient::~QueueClient):
12:24 PM Changeset in webkit [85502] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-05-02 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

WebKit2 thinks the web process is unresponsive when a plugin displays a context menu
​https://bugs.webkit.org/show_bug.cgi?id=59124
<rdar://problem/9318600>


This is the Windows version of <​https://bugs.webkit.org/show_bug.cgi?id=58943>.

Since we have no control over how long a plugin will take to handle an event, we need
to tell the UI process to stop its responsive timer when we're about to send an event
to the plugin. The downside of doing this is that if the plugin does become unresponsive,
the user won't know this immediately until they click on the web page again. At that point,
if the web process is unresponsive because of a hung plugin, the responsiveness timer will fire.


We're only doing this on Windows currently when running plugins in the web process (Anders fixed
bug 58943 in a different way when running plugins in a separate plugin process on the Mac).

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::willSendEventToPlugin): Added, not used when running plugins in a separate process.
  • PluginProcess/PluginControllerProxy.h: Added willSendEventToPlugin().
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::stopResponsivenessTimer): Added.
  • UIProcess/WebPageProxy.h: Added stopResponsivenessTimer().
  • UIProcess/WebPageProxy.messages.in: Added StopResponsivenessTimer message.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: (WebKit::NetscapePlugin::platformPaint): Tell our controller when we're about to send an event to the plugin. (WebKit::NetscapePlugin::platformHandleMouseEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Ditto.
  • WebProcess/Plugins/PluginController.h: Added willSendEventToPlugin().
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::willSendEventToPlugin): Added, tell the UI process to stop its responsiveness timer.
  • WebProcess/Plugins/PluginView.h: Added willSendEventToPlugin().
12:11 PM Changeset in webkit [85501] by weinig@apple.com
  • 16 edits in trunk/Source/WebCore

2011-05-02 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune ApplicationServices.h out of the headers
​https://bugs.webkit.org/show_bug.cgi?id=59952

More forward declares are better.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
12:09 PM Changeset in webkit [85500] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Remove passing tests after rebaselines from r85365.

  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [85499] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
​https://bugs.webkit.org/show_bug.cgi?id=58006

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
<​http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
table cell as the immediate containing block, but any case where all containing block ancestors
up to and including a table cell are auto-or-percent height.

LayoutTests:

  • fast/replaced/table-percent-height-expected.txt: Updated.
  • fast/replaced/table-percent-height.html: Added a test case with a replaced object nested in an

auto-height block inside a table cell.

11:38 AM Changeset in webkit [85498] by andersca@apple.com
  • 3 edits in trunk/Tools

Build fix.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
11:30 AM Changeset in webkit [85497] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=59950
Clean up AssemblerBuffer to use a Vector internally.

Reviewed by Oliver Hunt.

AssemblerBuffer handles reallocing a byte array itself - stop that.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::~AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::isAligned):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::putByteUnchecked):
(JSC::AssemblerBuffer::putByte):
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putShort):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::putInt64):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::executableCopy):
(JSC::AssemblerBuffer::rewindToLabel):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):

11:20 AM Changeset in webkit [85496] by jeffm@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Avoid potential buffer overflow in WTFLog() and WTFLogVerbose()
​https://bugs.webkit.org/show_bug.cgi?id=59949

Reviewed by Alexy Proskuryakov.

  • wtf/Assertions.cpp: Check for 0 or empty format string in WTFLog() and WTFLogVerbose().
11:14 AM Changeset in webkit [85495] by dbates@webkit.org
  • 2 edits
    1 move
    1 add in trunk

2011-05-02 Daniel Bates <​dbates@webkit.org>

Reviewed by Sam Weinig.

Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
​https://bugs.webkit.org/show_bug.cgi?id=59379

Make onblur-remove.html a DRT test. As of 04/25/2011 this test fails. See bug #59379
for more details.

  • fast/events/onblur-remove-expected.txt: Added; expected failure results.
  • fast/events/onblur-remove.html: Copied from Source/WebCore/manual-tests/onblur-remove.html.

2011-05-02 Daniel Bates <​dbates@webkit.org>

Reviewed by Sam Weinig.

Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
​https://bugs.webkit.org/show_bug.cgi?id=59379

Move manual test onblur-remove.html to LayoutTests/fast/events.

Test: fast/events/onblur-remove.html

  • manual-tests/onblur-remove.html: Removed.
11:09 AM Changeset in webkit [85494] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/742

MERGE 85090 - 2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

2011-04-27 Enrica Casucci <​enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
​https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

​http://crbug.com/80498

11:04 AM Changeset in webkit [85493] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej Stachowiak.

Plug-in failed to initialize message should be called when Java fails to initialize
​https://bugs.webkit.org/show_bug.cgi?id=59856


To match the WebKit1 behavior, WebKit2 should dispatch the plug-in failed
to initialize message when we can't instantiate the Java plug-in.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
10:55 AM Changeset in webkit [85492] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-05-02 Sailesh Agrawal <​sail@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Mac: Add scrollbar overlay drawing functions
​https://bugs.webkit.org/show_bug.cgi?id=59741

These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • WebCore.gypi:
  • platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
  • platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added. (LookUpNSScrollerImpClass): (LookUpNSScrollerImpPairClass): (ScrollbarControlSizeToNSControlSize): (wkScrollbarPainterUsesOverlayScrollers): (wkScrollbarPainterIsHorizontal): (wkScrollbarPainterKnobAlpha): (wkScrollbarPainterSetOverlayState): (wkScrollbarPainterPaint): (wkScrollbarMinimumThumbLength): (wkScrollbarPainterSetDelegate): (wkScrollbarPainterTrackAlpha): (wkMakeScrollbarPainter): (wkScrollbarThickness): (wkScrollbarMinimumTotalLengthNeededForThumb): (wkVerticalScrollbarPainterForController): (wkHorizontalScrollbarPainterForController): (wkMakeScrollbarReplacementPainter): (wkSetPainterForPainterController): (wkSetScrollbarPainterControllerStyle): (wkScrollbarPainterKnobRect): (wkSetScrollbarPainterKnobAlpha): (wkSetScrollbarPainterTrackAlpha): (wkSetScrollbarPainterKnobStyle): (wkMakeScrollbarPainterController): (wkContentAreaScrolled): (wkContentAreaWillPaint): (wkMouseEnteredContentArea): (wkMouseExitedContentArea): (wkMouseMovedInContentArea): (wkWillStartLiveResize): (wkContentAreaResized): (wkWillEndLiveResize): (wkContentAreaDidShow): (wkContentAreaDidHide): (wkDidBeginScrollGesture): (wkDidEndScrollGesture): (wkScrollbarPainterForceFlashScrollers): (IsScrollbarOverlayAPIAvailable):
10:55 AM Changeset in webkit [85491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-02 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium windows build is broken due to r85395
​https://bugs.webkit.org/show_bug.cgi?id=59945

Include SecurityOrigin.h in IDBFactoryBackendProxy.cpp

  • src/IDBFactoryBackendProxy.cpp:
10:54 AM Changeset in webkit [85490] by thakis@chromium.org
  • 2 edits in trunk/Tools

2011-05-02 Nico Weber <​thakis@chromium.org>

Reviewed by Mihai Parparita.

Add --no-webkit2 to the output of "build-webkit -h"
​https://bugs.webkit.org/show_bug.cgi?id=59942

  • Scripts/build-webkit:
10:53 AM Changeset in webkit [85489] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-02 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement Length based CSS properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=59314

No new tests as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyLength::ApplyPropertyLength): Added this class to handle all length types. Property specific behavior is handled through set of boolean parameters. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added calls to set up entries for the newly added length properties.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property implementations mow implemented in CSSStyleApplyProperty.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::rootElementStyle): Expose m_rootElementStyle via getter.
10:52 AM Changeset in webkit [85488] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
​https://bugs.webkit.org/show_bug.cgi?id=59828

No new tests required, no functional change because seeking to time zero before playback
begins has no effect.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches

HAVE_METADATA.

10:43 AM Changeset in webkit [85487] by Martin Robinson
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=59943

Disable the Ubuntu overlay scrollbar while testing, by injecting the
LIBOVERLAY_SCROLLBAR=0 environment variable.

  • Scripts/old-run-webkit-tests:
10:42 AM Changeset in webkit [85486] by kerz@chromium.org
  • 4 edits in branches/chromium/742

Merge 85290 - 2011-04-28 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
​https://bugs.webkit.org/show_bug.cgi?id=59732

  • platform/chromium/test_expectations.txt: Add expectations for affected tests.

2011-04-28 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
​https://bugs.webkit.org/show_bug.cgi?id=59732

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/6880352

10:39 AM Changeset in webkit [85485] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix extra whitespace in license in FocusDirection.h.

Reviewed by Gavin Barraclough.

  • page/FocusDirection.h:
10:35 AM Changeset in webkit [85484] by weinig@apple.com
  • 25 edits in trunk/Source

2011-05-02 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
​https://bugs.webkit.org/show_bug.cgi?id=59907

  • Plugins/WebBaseNetscapePluginView.mm:
  • WebView/WebFrame.mm: Add now missing SecurityOrigin.h #includes.

2011-05-02 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
​https://bugs.webkit.org/show_bug.cgi?id=59907

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setSecurityOrigin):
  • page/DOMWindow.h: Remove #includes of SecurityOrigin and MessagePort by forward declaring and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget #include that was getting added by MessagePort.h.
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/ScriptController.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/parser/XSSFilter.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • loader/MainResourceLoader.cpp:
  • page/DragController.cpp:
  • page/EventSource.cpp:
  • page/Location.cpp:
  • websockets/WebSocket.cpp:
  • xml/XSLTProcessorLibxslt.cpp: Add now missing SecurityOrigin.h #includes.

2011-05-02 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
​https://bugs.webkit.org/show_bug.cgi?id=59907

  • WebProcess/WebPage/WebFrame.cpp: Add now missing SecurityOrigin.h #include.
10:21 AM Changeset in webkit [85483] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
​https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Tested manually with manual-tests/media-elements/video-preload.html.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'

because we need to have media data loaded to seek.

(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.

  • html/HTMLMediaElement.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove

m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.

(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.

Move all preload logic to setPreload, call it from here.

(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to

setPreload, call it.

(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is

unlikely to be correct and isn't worth caching.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus

to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache

width, height, hasVideo, etc.

(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done

in derived classes.

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create

AVAsset and AVPlayerItem here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_videoFrameHasDrawn.

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from

videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset

if necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when

the buffer is full.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the

AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset

when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before

we have allocated the AVPlayerItem.

9:52 AM Changeset in webkit [85482] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

StringImpl::endsWith has some insane code
​https://bugs.webkit.org/show_bug.cgi?id=59900

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::endsWith):
    • m_data shadows a member variable of the same name.
9:23 AM Changeset in webkit [85481] by Martin Robinson
  • 4 edits in trunk

2011-05-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] editing/selection/select-out-of-editable.html failing after r83967
​https://bugs.webkit.org/show_bug.cgi?id=58667

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-05-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] editing/selection/select-out-of-editable.html failing after r83967
​https://bugs.webkit.org/show_bug.cgi?id=58667

Do not trigger mouse down events when the EventSender knows that a mouse button is
already down. These type of situations can confuse Xvfb and cause dragging failures.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not trigger another mouse button down event if the mouse button is already down. This can interfere with drags in Xvfb.
9:19 AM WebKitGtkLayoutTests edited by Martin Robinson
Made the package list more readable and remove DejaVu fonts. (diff)
9:13 AM Changeset in webkit [85480] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
​https://bugs.webkit.org/show_bug.cgi?id=59932

Use gdk_window_get_width() and gdk_window_get_height() if
available, instead of the deprecated gdk_drawable_get_size().

No new tests, build fix only.

  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext):
9:09 AM Changeset in webkit [85479] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
​https://bugs.webkit.org/show_bug.cgi?id=58657

Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.

  • platform/win-xp/Skipped:
9:04 AM Changeset in webkit [85478] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
​https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Test manually with manual-tests/media-elements/video-preload.html.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"

attribute when preload is not "auto".

(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
(WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
(WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have

a QTMovie.

8:59 AM Changeset in webkit [85477] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Update an exptected file after r85474.

  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
8:55 AM Changeset in webkit [85476] by eric.carlson@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

2011-04-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
​https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Manual test manual-tests/media-elements/video-preload.html added.

  • manual-tests/media-elements/video-preload.html: Added. New manual test for media element

'preload' attribute because it is not possible to detect if a media engine supports
"preload=metadata" in a way that lets us have per-platform layout test results.

7:29 AM Changeset in webkit [85475] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] Media tests relying on video-paint-test.js are still flaky
​https://bugs.webkit.org/show_bug.cgi?id=59934

Dump the render tree after the video completed the seek. This is
to avoid flake happening in the control slider not always being at
beginning of the timeline.

  • media/video-paint-test.js: (init.document.addEventListener.): (init):
7:27 AM Changeset in webkit [85474] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-02 Zsolt Fehér <​h490267@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

DRT sideeffect revealed by r71268
​https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped: Unskip svg/custom/text-zoom.xhtml

2011-05-02 Zsolt Fehér <​h490267@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

DRT sideeffect revealed by r71268.
​https://bugs.webkit.org/show_bug.cgi?id=48958

Reset QWebSettings::ZoomTextOnly attribute before all tests.

Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
PageZoomFactor too. It should be done before resetsettings()
to guarantee resetting QWebSettings::ZoomTextOnly correctly.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
7:24 AM Changeset in webkit [85473] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

  • platform/gtk/Skipped: Skip tables/mozilla_expected_failures/bugs/bug85016.html
5:13 AM Changeset in webkit [85472] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Tools

2011-05-02 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85469.
​http://trac.webkit.org/changeset/85469
​https://bugs.webkit.org/show_bug.cgi?id=59928

Broke webkitpy-tests on Windows 7, GTK and Qt. (Requested by
bbandix on #webkit).

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4:03 AM Changeset in webkit [85471] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Tomasz Morawski <​t.morawski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

Cleanup EFL initialization/shutdown in the EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=59922

Removed ecore_evas_init and edje_init form main function due to they
are also called in the ewk_init. Moved ewk_shutdown to quit function.

  • EWebLauncher/main.c: (quit): (main):
3:54 AM Changeset in webkit [85470] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, re-enable websocket tests on GTK. they moved over to a
real http server and most of the flakiness went away.

  • platform/gtk/Skipped:
3:51 AM Changeset in webkit [85469] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add base case for a test-running EWS
​https://bugs.webkit.org/show_bug.cgi?id=59920

Later I will subclass this to run the Chromium Linux EWS.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3:02 AM Changeset in webkit [85468] by Philippe Normand
  • 1 edit
    46 adds in trunk/LayoutTests

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
  • platform/gtk/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/gtk/fast/html/details-add-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-add-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-add-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/gtk/fast/table/auto-100-percent-width-expected.png: Added.
  • platform/gtk/fast/table/auto-100-percent-width-expected.txt: Added.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/gtk/fast/table/multiple-captions-display-expected.png: Added.
  • platform/gtk/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/gtk/fast/text/selection-rect-rounding-expected.png: Added.
  • platform/gtk/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/gtk/svg/filters/feDropShadow-expected.png: Added.
  • platform/gtk/svg/filters/feDropShadow-expected.txt: Added.
2:37 AM Changeset in webkit [85467] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix for ARM after r85448

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::loadBranchTarget):

2:09 AM Changeset in webkit [85466] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline after r85355.

  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
1:11 AM Changeset in webkit [85465] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add the ability to skip python and perl unit tests on EC2
​https://bugs.webkit.org/show_bug.cgi?id=59918

  • Scripts/webkitpy/common/config/ports.py:
    • This is slightly ugly, but it's useful...
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
12:56 AM Changeset in webkit [85464] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch --non-interactive is incompatible with new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=59919

new-run-webkit-tests doesn't support --wait-for-httpd (because it
always waits for HTTPD, as I understand things). It turns out we're
not really using this flag for anything, so we should just remove it.

  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
12:53 AM Changeset in webkit [85463] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-05-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

The bots should learn from expected failures without having to retry
​https://bugs.webkit.org/show_bug.cgi?id=59279

Rather than re-trying the whole patch, we can just check whether we now
expect the failures we see with the patch applied, saving a lot of time.

This patch also teaches the CommitQueue how to reject patches even
when the tree is red using the new unexpected_failures() method on
ExpectedFailures.

Finally in testing we found a bug in ExpectedFailures where it would
"trust" results which had many many failures, due to using an
equal sign instead of a less-than sign.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
  • Scripts/webkitpy/tool/bot/expectedfailures.py
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
  • Scripts/webkitpy/tool/bot/patchanalysistask.py
12:17 AM Changeset in webkit [85462] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

workspace.py fails to import ScriptError
​https://bugs.webkit.org/show_bug.cgi?id=59915

If the workspace fails to create a zip, webkitpy crashes instead of
handling the error as expected.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:

May 1, 2011:

11:29 PM Changeset in webkit [85461] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Adam Barth <​abarth@webkit.org>

Remove unadvertantly added file.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11:18 PM Changeset in webkit [85460] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

expectedfailures.py should report the unexpected failures when asked
​https://bugs.webkit.org/show_bug.cgi?id=59916

This information is useful when the EWS runs tests.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
11:14 PM Changeset in webkit [85459] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

JSONTestResult needs to handle multiple results
​https://bugs.webkit.org/show_bug.cgi?id=59269

This case occurs when a test is flaky because NRWT will run the test
twice and report both results as "actual."

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
10:59 PM Changeset in webkit [85458] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Carlson.

Regression(r74787): Media document mouse click and double-click
events should be checked on target node only and not its descendants.
​https://bugs.webkit.org/show_bug.cgi?id=59886

  • html/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
10:44 PM Changeset in webkit [85457] by bweinstein@apple.com
  • 7 edits in trunk/Source/WebKit2

WebKit2: Crash closing tab with docked Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>

Reviewed by Dan Bernstein.

When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.

This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

10:21 PM Changeset in webkit [85456] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Strict-mode only reserved words not reserved
​https://bugs.webkit.org/show_bug.cgi?id=55342

Fix line number tracking when we rollback the lexer.

  • parser/JSParser.cpp: (JSC::JSParser::parseSourceElements):
9:51 PM Changeset in webkit [85455] by oliver@apple.com
  • 4 edits in trunk

2011-05-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 Strict mode does not allow getter and setter for same propId
​https://bugs.webkit.org/show_bug.cgi?id=57295

Update for correct results

  • fast/js/mozilla/strict/11.1.5-expected.txt:

2011-05-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 Strict mode does not allow getter and setter for same propId
​https://bugs.webkit.org/show_bug.cgi?id=57295

Simplify and correct the logic for strict mode object literals.

  • parser/JSParser.cpp: (JSC::JSParser::parseStrictObjectLiteral):
7:57 PM Changeset in webkit [85454] by oliver@apple.com
  • 6 edits in trunk

2011-05-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Assigning to function identifier under strict should throw
​https://bugs.webkit.org/show_bug.cgi?id=59289

Add test case for correct behaviour, and update mozilla test results to reflect
the correct result.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/mozilla/strict/assign-to-callee-name-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-05-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Assigning to function identifier under strict should throw
​https://bugs.webkit.org/show_bug.cgi?id=59289

Add logic to StaticScopeObject to ensure we don't silently consume
writes to constant properties.

  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put):
6:55 PM Changeset in webkit [85453] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Polish CSP host and port matching
​https://bugs.webkit.org/show_bug.cgi?id=59899

Test two host wildcard cases.

  • http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html: Added.

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Polish CSP host and port matching
​https://bugs.webkit.org/show_bug.cgi?id=59899

Finish last two details of host and port matching. I don't think the
default port handling is testable with our current testing
infrastructure.

Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html

http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPSource::hostMatches): (WebCore::CSPSource::portMatches):
6:46 PM Changeset in webkit [85452] by abarth@webkit.org
  • 7 edits
    2 moves in trunk/Tools

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move checkout/api.py to checkout/checkout.py
​https://bugs.webkit.org/show_bug.cgi?id=59906

This is more consistent with Python style.

  • Scripts/webkitpy/common/checkout/init.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/tool/main.py:
6:44 PM Changeset in webkit [85451] by abarth@webkit.org
  • 4 edits
    6 adds in trunk

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP default-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58641

Test that default-src controls some scripting policy and that
script-src, if present, overrides default-src. In principle, we could
test the interaction of default-src with every other directive, but
that seems like overkill.

  • http/tests/security/contentSecurityPolicy/default-src-inline-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-overrides-default-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html: Added.

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP default-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58641

Add support for default-src. The default-src provides a default policy
for every directive that sends in "-src". If the more-specific
directive is present, it takes precedence. I also took this
opportunity to refactor the internals of ContentSecurityPolicy a bit to
reduce duplicate code.

Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html

http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::checkEval): (WebCore::ContentSecurityPolicy::operativeDirective): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowInlineStyle): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
6:34 PM Changeset in webkit [85450] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

scm.py should be split into many pieces
​https://bugs.webkit.org/show_bug.cgi?id=59908

Forgot an AuthenticationError import.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
6:27 PM Changeset in webkit [85449] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk/Tools

2011-05-01 Arno Renevier <​arno@renevier.net>

Reviewed by Eric Seidel.

wrong exception raised in Lighttpd start method
​https://bugs.webkit.org/show_bug.cgi?id=59283

raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted

  • Scripts/webkitpy/layout_tests/port/http_server.py:
6:04 PM Changeset in webkit [85448] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer

Reviewed by Sam Weinig.

Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::label):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):

6:03 PM Changeset in webkit [85447] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Arno Renevier <​arno@renevier.net>

Reviewed by Eric Seidel.

wrong exception raised in Lighttpd start method
​https://bugs.webkit.org/show_bug.cgi?id=59283

raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted

  • Scripts/webkitpy/layout_tests/port/http_server.py:
5:58 PM Changeset in webkit [85446] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make most scm.py tests pass in preparation for splitting them up
​https://bugs.webkit.org/show_bug.cgi?id=59904

There is one remaining failure:
webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
which identifies a difference between the SVN and Git versions of the
SCM api. I'm not going to bother fixing that until we split out all
the tests.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
5:33 PM Changeset in webkit [85445] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Enable strict mode for OwnPtr and PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59428

  • wtf/OwnPtr.h:
5:19 PM Changeset in webkit [85444] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix windows build.

  • WebFrame.cpp:
5:15 PM Changeset in webkit [85443] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85440.

  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
4:56 PM Changeset in webkit [85442] by weinig@apple.com
  • 20 edits in trunk/Source

2011-05-01 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
​https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

2011-05-01 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
​https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptDebugServer.cpp:
  • editing/Editor.h:
  • inspector/InspectorClient.cpp:
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.h:
  • page/Console.cpp:
  • xml/XMLTreeViewer.cpp:
  • xml/XMLTreeViewer.h:

2011-05-01 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
​https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebPage/WebPage.cpp:
4:53 PM Changeset in webkit [85441] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
  • DumpRenderTree/win/UIDelegate.cpp: Ditto.
4:44 PM Changeset in webkit [85440] by Patrick Gansterer
  • 5 edits in trunk

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • WebView.cpp: (WebView::paint):

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
  • DumpRenderTree/win/UIDelegate.cpp: (DRTUndoManager::DRTUndoManager): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager):
4:29 PM Changeset in webkit [85439] by Patrick Gansterer
  • 5 edits in trunk/Source/WebKit2

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::startDragDrop):
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: (WebKit::WebDragClient::startDrag):
  • WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
4:09 PM Changeset in webkit [85438] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie):
3:53 PM Changeset in webkit [85437] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
3:45 PM Changeset in webkit [85436] by jschuh@chromium.org
  • 3 edits
    5 moves
    2 adds in trunk

2011-05-01 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

History::stateObjectAdded should check origin via SecurityOrigin::canRequest
​https://bugs.webkit.org/show_bug.cgi?id=59840

  • fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-in-data-url-denied.html: Added.
  • fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Removed.
  • fast/loader/stateobjects/replacestate-base-illegal.html: Removed.
  • fast/loader/stateobjects/replacestate-base-legal-expected.txt: Removed.
  • fast/loader/stateobjects/replacestate-base-legal.html: Removed.
  • fast/loader/stateobjects/resources/replacestate-base-pass.html: Removed.
  • http/tests/navigation/replacestate-base-illegal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal-expected.txt.
  • http/tests/navigation/replacestate-base-illegal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal.html.
  • http/tests/navigation/replacestate-base-legal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal-expected.txt.
  • http/tests/navigation/replacestate-base-legal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal.html.
  • http/tests/navigation/resources/replacestate-base-pass.html: Copied from LayoutTests/fast/loader/stateobjects/resources/replacestate-base-pass.html.

2011-05-01 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

History::stateObjectAdded should check origin via SecurityOrigin::canRequest
​https://bugs.webkit.org/show_bug.cgi?id=59840

Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html

http/tests/navigation/replacestate-base-illegal.html
http/tests/navigation/replacestate-base-legal.html

  • page/History.cpp: (WebCore::History::stateObjectAdded):
3:42 PM Changeset in webkit [85435] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext):
3:30 PM Changeset in webkit [85434] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable strict OwnPtr for PLATFORM(WIN)
​https://bugs.webkit.org/show_bug.cgi?id=59881

  • wtf/OwnPtr.h:
3:28 PM Changeset in webkit [85433] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

[WINCE] Fix OwnPtr strict issues
​https://bugs.webkit.org/show_bug.cgi?id=59898

  • page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontData::create): (WebCore::FontPlatformPrivateData::FontPlatformData::hfont): (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle): (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::SharedBitmap):
3:20 PM Changeset in webkit [85432] by barraclough@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.

Reviewed by Sam Weinig.

The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).

Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::patch):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):

2:15 PM Changeset in webkit [85431] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Can't open document from skydrive.com in Microsoft Word
​https://bugs.webkit.org/show_bug.cgi?id=59891
<rdar://problem/9354285>

Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks):
1:47 PM Changeset in webkit [85430] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't try to create a backing store for a 0x0 plug-in
​https://bugs.webkit.org/show_bug.cgi?id=59887

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
1:26 PM Changeset in webkit [85429] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-01 Chao-ying Fu <​fu@mips.com>

Reviewed by Eric Seidel.

Fix MIPS build due to the split of "Condition" enum
​https://bugs.webkit.org/show_bug.cgi?id=59407

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::debugOffset):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::compare32):
12:46 PM Changeset in webkit [85428] by rniwa@webkit.org
  • 6 edits in trunk/Source

2011-05-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
​https://bugs.webkit.org/show_bug.cgi?id=59837

Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)

  • WebCore.exp.in:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

2011-05-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
​https://bugs.webkit.org/show_bug.cgi?id=59837

Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
12:20 PM Changeset in webkit [85427] by eric@webkit.org
  • 2 edits
    2 moves
    2 adds in trunk/Tools

2011-05-01 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move scm.py into its own module in preparation for splitting it up
​https://bugs.webkit.org/show_bug.cgi?id=59884

  • Scripts/webkitpy/common/checkout/scm/init.py: Added.
  • Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
  • Scripts/webkitpy/test/main.py:
12:15 PM Changeset in webkit [85426] by commit-queue@webkit.org
  • 2 edits in trunk

2011-05-01 ojab <​ojab@ojab.ru>

Reviewed by Eric Seidel.

--disable-video-track if --disable-video
​https://bugs.webkit.org/show_bug.cgi?id=59605

  • configure.ac:
12:10 PM Changeset in webkit [85425] by rniwa@webkit.org
  • 6 edits in trunk/Source

2011-05-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
​https://bugs.webkit.org/show_bug.cgi?id=59835

Moved currentKeyboardEvent.

  • WebCore.exp.in:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

2011-05-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
​https://bugs.webkit.org/show_bug.cgi?id=59835

Moved currentKeyboardEvent.

  • WebView/WebHTMLView.mm: (currentKeyboardEvent): (-[WebHTMLView becomeFirstResponder]):
11:58 AM Changeset in webkit [85424] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch fails when not run from root
​https://bugs.webkit.org/show_bug.cgi?id=59882

We need to set the CWD when running svn so that svn interprets file
paths relative to the root of the working copy.

  • Scripts/webkitpy/common/checkout/scm.py:
11:42 AM Changeset in webkit [85423] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 ojab <​ojab@ojab.ru>

Reviewed by Eric Seidel.

Fix build with --disable-video --enable-fullscreen-api
​https://bugs.webkit.org/show_bug.cgi?id=59698

  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet):
11:35 AM Changeset in webkit [85422] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-01 Jeff Timanus <​twiz@chromium.org>

Reviewed by Eric Seidel.

Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
​https://bugs.webkit.org/show_bug.cgi?id=59041

Test:css2.1/t140201-c533-bgimage-00-a.html

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
11:02 AM Changeset in webkit [85421] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Sandbox violation by WebProcess for DownloadAssessment.plist
​https://bugs.webkit.org/show_bug.cgi?id=59879
<rdar://problem/9326041>

  • WebProcess/com.apple.WebProcess.sb: Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist
10:47 AM Changeset in webkit [85420] by Patrick Gansterer
  • 13 edits in trunk/Source

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in windows build
​https://bugs.webkit.org/show_bug.cgi?id=59878

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
  • platform/graphics/win/WKCAImageQueue.cpp: (WebCore::WKCAImageQueue::WKCAImageQueue):
  • platform/win/CursorWin.cpp: (WebCore::createSharedCursor):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in windows build
​https://bugs.webkit.org/show_bug.cgi?id=59878

  • FullscreenVideoController.cpp: (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::createHUDWindow):
  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight):
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag):
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter):
  • WebView.cpp: (WebView::close): (WebView::paint): (WebView::handleMouseEvent): (WebView::registerEmbeddedViewMIMEType):
10:43 AM Changeset in webkit [85419] by Patrick Gansterer
  • 5 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
​https://bugs.webkit.org/show_bug.cgi?id=59876

Also pass the size "as reference" instead of "as value".

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::paint):
10:30 AM Changeset in webkit [85418] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-01 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

getComputedStyle() returns unitless values for some properties that require units
​https://bugs.webkit.org/show_bug.cgi?id=55111

Add test to verify that getComputedStyle returns length properties with a unit.

  • fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-length-unit.html: Added.

2011-05-01 Emil A Eklund <​eae@chromium.org>

Reviewed by Eric Seidel.

getComputedStyle() returns unitless values for some properties that require units
​https://bugs.webkit.org/show_bug.cgi?id=55111

Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective

Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
10:25 AM Changeset in webkit [85417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Young Han Lee <​joybro@company100.net>

Reviewed by Eric Seidel.

Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
​https://bugs.webkit.org/show_bug.cgi?id=59608

TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h

No new functionality, no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::TextureMapperGL):
10:08 AM Changeset in webkit [85416] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2011-05-01 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

CSS3 nth-child(n) selector fails
​https://bugs.webkit.org/show_bug.cgi?id=56943

  • fast/css/nth-child-n-expected.txt: Added.
  • fast/css/nth-child-n.html: Added.

2011-05-01 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

CSS3 nth-child(n) selector fails
​https://bugs.webkit.org/show_bug.cgi?id=56943

Regression from r75158.
"n" is a valid parameter to nth() and should be allowed.

Test: fast/css/nth-child-n.html

  • css/CSSParser.cpp: (WebCore::isValidNthToken):
9:09 AM Changeset in webkit [85415] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-01 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: address stack frame scriptName -> url rename in timeline panel.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
9:07 AM Changeset in webkit [85414] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

2011-05-01 Chris Fleizach <Chris Fleizach>

Reviewed by Maciej Stachowiak.

Crash in AccessibilityRenderObject while viewing PDFs in iframes
​https://bugs.webkit.org/show_bug.cgi?id=59629

Could not reproduce this crash, but it's quite clear how it could happen.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityHitTest):
7:38 AM Changeset in webkit [85413] by Nikolas Zimmermann
  • 14 edits
    6 adds in trunk

2011-05-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

LEAK: SVGElement leaks when detaching it in a pending resource state
​https://bugs.webkit.org/show_bug.cgi?id=59072

Add testcase that used to leak, the leaks bot will assure they won't in future.

  • svg/custom/pending-resource-leak-2-expected.txt: Added.
  • svg/custom/pending-resource-leak-2.svg: Added.
  • svg/custom/pending-resource-leak-3-expected.txt: Added.
  • svg/custom/pending-resource-leak-3.svg: Added.
  • svg/custom/pending-resource-leak-expected.txt: Added.
  • svg/custom/pending-resource-leak.svg: Added.

2011-05-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

LEAK: SVGElement leaks when detaching it in a pending resource state
​https://bugs.webkit.org/show_bug.cgi?id=59072

Make the pending resources set non-refcounted again. We made it refcounted a while ago
to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
Fix the underlying problem, by removing all pending resources referencing to a particular
SVGElement, upon its destruction or upon removing it from the document.

Example: <rect fill="url(#foo)" id="rect">
When we try to render the rect, the foo paint server can't be found and thus "foo" will be
added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
itself from the pending resource set, and a ref count to the "rect" would be released.
If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
it and the associated document alive.

Tests: svg/custom/pending-resource-leak-2.svg

svg/custom/pending-resource-leak-3.svg
svg/custom/pending-resource-leak.svg

These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.

  • rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  • rendering/svg/SVGResources.cpp: (WebCore::registerPendingResource):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::hasPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removePendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::hasPendingResources): (WebCore::SVGElementRareData::setHasPendingResources):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::removedFromDocument): (WebCore::SVGStyledElement::hasPendingResources): (WebCore::SVGStyledElement::setHasPendingResources):
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::needsPendingResourceHandling): (WebCore::SVGStyledElement::buildPendingResource):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildPendingResource):
  • svg/SVGUseElement.h:
7:12 AM Changeset in webkit [85412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Rafael Brandao <​rafael.lobo@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] build-webkit warning Inspector.idl is missing
​https://bugs.webkit.org/show_bug.cgi?id=59047

Added variable_out to pipe output from one compiler to another,
and then forced the output to be added to the sources.

  • CodeGenerators.pri:
2:19 AM Changeset in webkit [85411] by mitz@apple.com
  • 5 edits
    3 adds in trunk

<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
​https://bugs.webkit.org/show_bug.cgi?id=56658

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/selection-rect-rounding.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.

LayoutTests:

  • fast/text/selection-rect-rounding.html: Added.
  • platform/mac/fast/text/selection-rect-rounding-expected.png: Added.
  • platform/mac/fast/text/selection-rect-rounding-expected.txt: Added.
1:09 AM Changeset in webkit [85410] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <​ike@apple.com>

Reviewed by Maciej Stachowiak.

Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
​https://bugs.webkit.org/show_bug.cgi?id=59873

These rules have been obsoleted by <rdar://problem/9301520> and
<rdar://problem/9181468>.

  • WebProcess/com.apple.WebProcess.sb:
12:45 AM Changeset in webkit [85409] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <​ike@apple.com>

Reviewed by Maciej Stachowiak.

Simplify WebProcess sandbox with homedir-relative path filters.
​https://bugs.webkit.org/show_bug.cgi?id=59872

  • WebProcess/com.apple.WebProcess.sb:
12:28 AM Changeset in webkit [85408] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <​ike@apple.com>

Reviewed by Maciej Stachowiak.

On-demand VPN support for sandboxed WebProcess.
<rdar://problem/8994181>

  • WebProcess/com.apple.WebProcess.sb:
12:10 AM Changeset in webkit [85407] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-30 Ivan Krstić <​ike@apple.com>

Reviewed by Sam Weinig.

Reindent WebProcess sandbox to standard scheme style
​https://bugs.webkit.org/show_bug.cgi?id=59870

  • WebProcess/com.apple.WebProcess.sb:

Apr 30, 2011:

9:17 PM Changeset in webkit [85406] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Make RenderSVGResourceFilter take ownership of filter data when painting
​https://bugs.webkit.org/show_bug.cgi?id=51524

  • svg/custom/filter-on-svgimage-expected.txt: Added.
  • svg/custom/filter-on-svgimage.svg: Added.

2011-04-30 Justin Schuh <​jschuh@chromium.org>

Reviewed by Dirk Schulze.

Make RenderSVGResourceFilter take ownership of filter data when painting
​https://bugs.webkit.org/show_bug.cgi?id=51524

Test: svg/custom/filter-on-svgimage.svg

  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/svg/RenderSVGResourceFilter.h: (WebCore::FilterData::FilterData):
9:16 PM Changeset in webkit [85405] by abarth@webkit.org
  • 18 edits in trunk/Source

2011-04-30 Adam Barth <​abarth@webkit.org>

Reviewed by Adam Barth.

Enable strict OwnPtr for GTK
​https://bugs.webkit.org/show_bug.cgi?id=59861

  • wtf/OwnPtr.h:

2011-04-30 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

Enable strict mode for OwnPtr and PassOwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=59428

Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
factory methods return a PassOwnPtr.

No new tests. This should not change functionality.

  • platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull): (WebCore::GeolocationService::create):
  • platform/GeolocationService.h:
  • platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::create):
  • platform/android/GeolocationServiceAndroid.h:
  • platform/efl/GeolocationServiceEfl.cpp: (WebCore::GeolocationServiceEfl::create):
  • platform/efl/GeolocationServiceEfl.h:
  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::appendPathToCairoContext):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): (WebCore::GraphicsContext::clip):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cairo/OwnPtrCairo.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::apply):
  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
  • platform/gtk/GeolocationServiceGtk.h:
  • platform/mock/GeolocationServiceMock.cpp: (WebCore::GeolocationServiceMock::create):
  • platform/mock/GeolocationServiceMock.h:
6:05 PM Changeset in webkit [85404] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix.

  • assembler/AssemblerBufferWithConstantPool.h:
4:59 PM Changeset in webkit [85403] by barraclough@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Bug 59869 - AssemblerBuffer cleanup - disambiguate size()

Reviewed by Oliver Hunt.

The method size() is called on the AssemblerBuffer both to acquire
the complete size of the code, and to get a position to use as a
label into the code. Instead, add an explicit 'label' method.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::codeSize):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::data):

  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::codeSize):
(JSC::MIPSAssembler::relocateJumps):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::executableCopy):
(JSC::SH4Assembler::oneShortOp):
(JSC::SH4Assembler::codeSize):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::codeSize):
(JSC::X86Assembler::X86InstructionFormatter::label):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

1:05 PM Component Model edited by Dimitri Glazkov
(diff)
10:34 AM BuildingGtk edited by Martin Robinson
(diff)
8:29 AM Changeset in webkit [85402] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-30 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector toolbar titles were 2px off.

  • inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):
5:18 AM Changeset in webkit [85401] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires layoutTestController.setAlwaysAcceptCookies on mac-wk2

<​http://webkit.org/b/42778> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added

http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

5:16 AM Changeset in webkit [85400] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires eventSender.keyDown on mac-wk2

<​http://webkit.org/b/42194> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added plugins/keyboard-events.html.
5:14 AM Changeset in webkit [85399] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip another test that requires layoutTestController.overridePreference on mac-wk2

<​http://webkit.org/b/42197> tracks implementing this feature.

  • platform/mac-wk2/Skipped: Added fast/canvas/webgl/framebuffer-object-attachment.html.
5:01 AM Changeset in webkit [85398] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a failing test on mac-wk2

I can't check in expected failure results because the results are slightly different each
time.

<​http://webkit.org/b/59865> tracks the failure.

  • platform/mac-wk2/Skipped: Added transitions/transition-timing-function.html.
5:01 AM Changeset in webkit [85397] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky test on mac-wk2

<​http://webkit.org/b/58990> tracks the failure.

  • platform/mac-wk2/Skipped: Added editing/undo/undo-iframe-location-change.html.
5:01 AM Changeset in webkit [85396] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove mac-wk2 expected failure results for an animation test

Looks like this started passing in r85340. (I hope it wasn't because animation-api-1.html,
which is now skipped, was causing this one to fail!)

Fixes <​http://webkit.org/b/56528> <rdar://problem/9147568> REGRESSION (r80846):
animations/animation-controller-drt-api.html failing in WebKit2

  • platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Removed.
2:24 AM Changeset in webkit [85395] by mihaip@chromium.org
  • 15 edits in trunk/Source

2011-04-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

V8Proxy.h shouldn't include SecurityOrigin.h
​https://bugs.webkit.org/show_bug.cgi?id=59859

Remove SecurityOrigin.h #include from V8Proxy.h. Touching
SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
chromium's DumpRenderTree).

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • css/CSSStyleSelector.cpp:
  • dom/XMLDocumentParserLibxml2.cpp:
  • html/HTMLLinkElement.cpp:
  • loader/SubframeLoader.cpp:
  • page/History.cpp:
  • storage/IDBFactory.cpp:
  • storage/StorageAreaImpl.cpp:

2011-04-30 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

V8Proxy.h shouldn't include SecurityOrigin.h
​https://bugs.webkit.org/show_bug.cgi?id=59859

Add SecurityOrigin.h includes to places that were relying on transitive
includes.

  • src/ApplicationCacheHost.cpp:
  • src/WebGeolocationPermissionRequest.cpp:
1:13 AM Changeset in webkit [85394] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add one more flakey test to the Skipped list.

  • platform/qt-mac/Skipped:
1:11 AM Changeset in webkit [85393] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit/win

2011-04-29 Jer Noble <​jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 2: WebKit
​https://bugs.webkit.org/show_bug.cgi?id=59785

Initial implementation of full screen API on windows. No animation
occurs when entering or exiting full screen. Re-use existing window
classes (MediaPlayerPrivateFullscreenWindow) to host the webView.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::supportsFullScreenForElement): Call into WebView. (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController. (WebChromeClient::exitFullScreenForElement): Ditto.
  • WebFullScreenController.cpp: Added. (WebFullScreenController::Private::Private): Private data storage class. (WebFullScreenController::Private::~Private): (WebFullScreenController::Private::fullscreenClientWndProc): Handle window

message for full screen window.

(WebFullScreenController::WebFullScreenController):
(WebFullScreenController::~WebFullScreenController):
(WebFullScreenController::setElement): Added.
(WebFullScreenController::element): Added.
(WebFullScreenController::isFullScreen): Added.
(WebFullScreenController::enterFullScreen): Create and display full screen

window, moving webView as child window.

(WebFullScreenController::exitFullScreen): Destroy full screen window and

move webView back where we found it.

  • WebFullScreenController.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::keyDown): Handle the ESC key. (WebView::notifyPreferencesChanged): (WebView::supportsFullScreenForElement): Do not support full screen if

full screen preference is disabled, or if keyboard access is requested.

(WebView::isFullScreen): Added.
(WebView::fullScreenController): Added.

  • WebView.h:

Apr 29, 2011:

11:56 PM Changeset in webkit [85392] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r85355.
​https://bugs.webkit.org/show_bug.cgi?id=59833

  • platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:
10:48 PM Changeset in webkit [85391] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-29 Adam Barth <​abarth@webkit.org>

Attempt to fix the Windows build.

10:20 PM Changeset in webkit [85390] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-04-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] Crash when navigating back
​https://bugs.webkit.org/show_bug.cgi?id=59799

The innerNode management in WebKitHitTestResult was relying on the
old DOM bindings behavior where every DOM objects had to be
disposed by the caller. Now the objects are garbage collected by
WebKit when either the parent frame or document dies, so this is
not needed anymore. Update the code to simply take ownership of
the node, which effectively correctly balances the reference
count.

  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_dispose): call C++ dtors in private data. (webkit_hit_test_result_get_property): adatp to GRefPtr API. (webkit_hit_test_result_init): call C++ ctors in private data.
9:30 PM Changeset in webkit [85389] by jer.noble@apple.com
  • 11 edits
    4 adds in trunk/Source

2011-04-28 Jer Noble <​jer.noble@apple.com>

Reviewed by Jon Honeycutt.

Implement FULLSCREEN_API on Windows, Part 1: Stubs
​https://bugs.webkit.org/show_bug.cgi?id=59778

Create all the stubs necessary to for enabling FULLSCREEN_API
on Windows. This includes the COM interfaces for preferences and
for overriding full screen behavior in a UI Delegate.

  • Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling

full screen preference.

  • Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding

full screen behavior.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::supportsFullScreenForElement): Added. (WebChromeClient::enterFullScreenForElement): Added. (WebChromeClient::exitFullScreenForElement): Added.
  • WebCoreSupport/WebChromeClient.h:
  • WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
  • WebPreferences.cpp: (WebPreferences::isFullScreenEnabled): Added. Implements function

defined in IWebUIDelegatePrivate.

(WebPreferences::setFullScreenEnabled): Ditto.

  • WebPreferences.h:

2011-04-28 Jer Noble <​jer.noble@apple.com>

Reviewed by Jon Honeycutt.

Implement FULLSCREEN_API on Windows, Part 1: Stubs
​https://bugs.webkit.org/show_bug.cgi?id=59778

Add Windows specific stubs for WebKit2 full screen APIs.

  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: Added. (WebKit::WebFullScreenManagerProxy::enterFullScreen): Added stub. (WebKit::WebFullScreenManagerProxy::exitFullScreen): Added stub. (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Added stub. (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Added stub. (WebKit::WebFullScreenManagerProxy::getFullScreenRect): Added stub.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Added. (WebKit::WebFullScreenManager::create): Added. Returns a WebFullScreenManagerWin. (WebKit::WebFullScreenManagerWin::create): Added. (WebKit::WebFullScreenManagerWin::WebFullScreenManagerWin): Added. (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): Added. (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Added stub. (WebKit::WebFullScreenManagerWin::beginEnterFullScreenAnimation): Added stub. (WebKit::WebFullScreenManagerWin::beginExitFullScreenAnimation): Added stub.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Added.
  • win/WebKit2.vcproj: Added new classes.
9:30 PM Changeset in webkit [85388] by abarth@webkit.org
  • 14 edits
    4 adds in trunk

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
​https://bugs.webkit.org/show_bug.cgi?id=59850

Test that both function-eval and operator-eval are correctly blocked
and allowed according to the policy.

  • http/tests/security/contentSecurityPolicy/eval-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-blocked.html: Added.

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
​https://bugs.webkit.org/show_bug.cgi?id=59850

ggaren recommend a different approach to this patch, essentially
installing a new function for function-eval and changing the AST
representation of operator-eval to call function-eval. However, I'm
not sure that approach is workable because the ASTBuilder doesn't know
about global objects, and there is added complication due to the cache.

This approach is more dynamic, adding a branch in EvalExecutable to
detect whether eval is current disabled in the lexical scope. The spec
is slightly unclear about whether we should return undefined or throw
an exception. I've asked Brandon to clarify the spec, but throwing an
exception seems natural.

  • JavaScriptCore.exp:
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::disableEval):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::isEvalEnabled):

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP script-src should block eval
​https://bugs.webkit.org/show_bug.cgi?id=59850

Rather than have JavaScriptCore call back into WebCore to learn whether
eval is enabled, we push that bit of the policy into JavaScriptCore.

Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html

http/tests/security/contentSecurityPolicy/eval-blocked.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::disableEval):
  • bindings/js/ScriptController.h:
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::internalAllowEval): (WebCore::ContentSecurityPolicy::allowEval):
  • page/ContentSecurityPolicy.h:
9:18 PM Changeset in webkit [85387] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed. Add windows expected results for a new test.

  • platform/win/fast/forms/date-input-visible-strings-expected.txt: Added.
8:47 PM Changeset in webkit [85386] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Simon Fraser and Dan Bernstein.

WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=59852
<rdar://problem/9314011>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginInfoFromPropertyLists): Do what WebKit1 does (but in CF dialect). And yes, I've seen plists with both numbers and booleans used .
8:26 PM Changeset in webkit [85385] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

GTK build fix. Missed moving DateComponents and
adding LocalizedDate files for their build file.

  • GNUmakefile.list.am:
7:56 PM Changeset in webkit [85384] by abarth@webkit.org
  • 3 edits
    6 adds in trunk

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block @style
​https://bugs.webkit.org/show_bug.cgi?id=59293

Testing makes perfect.

  • http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html.html: Added.

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block @style
​https://bugs.webkit.org/show_bug.cgi?id=59293

This patch blocks @style when style-src doesn't have the
'unsafe-inline' token. This patch blocks the parsing of the attribute
itself. That feels vaguely like too low a level to interpose the
policy, but there didn't seem to be anywhere else natural to enforce
the policy.

Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html

http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
http/tests/security/contentSecurityPolicy/inline-style-on-html.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute):
7:50 PM Changeset in webkit [85383] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

land-safely patches should show show their place in the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=59853

This complicated the "should we show the bubbles or the submit-to-ews button"
logic substantially. :( But now we'll show both the commit-queue position
as well as the submit-to-ews button for land-safely (cq+ only) patches.
Previously we would only show the submit-to-ews button.

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/templates/statusbubble.html:
7:41 PM Changeset in webkit [85382] by Joseph Pecoraro
  • 21 edits
    2 moves
    4 adds in trunk

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Allow Localized Date Strings for Date Input Fields
​https://bugs.webkit.org/show_bug.cgi?id=59752

The render tree dump prints out the visible string
inside the <input> field.

  • fast/forms/date-input-visible-strings.html: Added.
  • platform/mac/fast/forms/date-input-visible-strings-expected.txt: Added.

2011-04-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Allow Localized Date Strings for Date Input Fields
​https://bugs.webkit.org/show_bug.cgi?id=59752

Test: fast/forms/date-input-visible-strings.html

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: update build files for moving DateComponents from WebCore/html to WebCore/platform and adding the LocalizedDate files.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::serialize): (WebCore::BaseDateAndTimeInputType::serializeWithComponents): (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds): InputType::serialize for a double value with date types is different for the month type because it assumes the incoming value is months instead of msecs (matching valueAsNumber in HTML5). So provide a more general serialization function, serializeWithComponents, that will always serialize a string correctly for the current type but taking in a DateComponents object. The default serialize, and new serializeWithMilliseconds, can fall back to this and allows an override point for the month type.
  • html/MonthInputType.cpp: (WebCore::MonthInputType::serializeWithMilliseconds): the month type is a case where the default serialize does not take msec, so provide an implementation for month which handles msec input.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::setValueAsDate): switch to serializeWithMilliseconds as the incoming date value is msec.
  • html/MonthInputType.cpp: (WebCore::MonthInputType::setValueAsDate): removed.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::visibleValue): allow localized formatting of a date value. (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue): allow parsing for a formatted date value.
  • html/BaseDateAndTimeInputType.h:
  • platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp. Expose the Type enum so it can be used outside of the DateComponents class.
  • platform/text/LocalizedDate.h: Added.
  • platform/text/LocalizedDateNone.cpp: Added. (WebCore::formatLocalizedDate): Default implementation falls back to existing HTML5 date input value formatting.
  • html/BaseDateAndTimeInputType.h:
  • html/DateInputType.cpp: (WebCore::DateInputType::dateType):
  • html/DateInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::dateType):
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::dateType):
  • html/DateTimeLocalInputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::dateType):
  • html/MonthInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::dateType):
  • html/TimeInputType.h:
  • html/WeekInputType.cpp: (WebCore::WeekInputType::dateType):
  • html/WeekInputType.h: Accessors for the desired date type of a date input type. This allows the base class to write a generic algorithm.
7:22 PM Changeset in webkit [85381] by abarth@webkit.org
  • 5 edits
    4 adds in trunk

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block inline style from <style>
​https://bugs.webkit.org/show_bug.cgi?id=59292

Testing makes perfect.

  • http/tests/security/contentSecurityPolicy/inline-style-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-blocked.html: Added.

2011-04-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

style-src should block inline style from <style>
​https://bugs.webkit.org/show_bug.cgi?id=59292

The spec has been updated to allow blocking of inline styles with
style-src. This will help folks defend against tricky CSS3 injections.

This patch covers the <style> case. The next patch will cover the
@style case.

Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html

http/tests/security/contentSecurityPolicy/inline-style-blocked.html

  • dom/StyleElement.cpp: (WebCore::StyleElement::createSheet):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowInlineStyle):
  • page/ContentSecurityPolicy.h:
7:17 PM Changeset in webkit [85380] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-29 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Adam Barth.

Add my name to contributers.
​https://bugs.webkit.org/show_bug.cgi?id=59854

  • Scripts/webkitpy/common/config/committers.py:
6:31 PM Changeset in webkit [85379] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add tests using layoutTestController.setPrivateBrowsingEnabled to the WebKit2
skipped list. Covered by ​https://bugs.webkit.org/show_bug.cgi?id=59857

  • platform/mac-wk2/Skipped:
6:16 PM Changeset in webkit [85378] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-04-29 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
​https://bugs.webkit.org/show_bug.cgi?id=58378

Test: To follow in subsequent patch, including the wiring to expose the new settings to LayoutTests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking. (WebCore::FrameLoader::checkIfRunInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Check if the frame load is blocked due to mixed content and cancel it if so. The check was moved up so that it occurs before firing the load callbacks, to avoid any outgoing network hits or accounting. Redirects are handled because willSendRequest is called for each one in the chain.
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Handle the blocking of mixed-content plug-in loads. (WebCore::SubframeLoader::loadPlugin): Handle the blocking of mixed-content plug-in loads.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Handle the blocking of various loads due to mixed content conditions.
  • page/Settings.cpp: (WebCore::Settings::Settings): Permit mixed-content loads by default to avoid a change in behavior by default.
  • page/Settings.h: Add two new booleans to control blocking of mixed content (displaying and running thereof). (WebCore::Settings::setAllowDisplayOfInsecureContent): (WebCore::Settings::allowDisplayOfInsecureContent): (WebCore::Settings::setAllowRunningOfInsecureContent): (WebCore::Settings::allowRunningOfInsecureContent):

2011-04-29 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
​https://bugs.webkit.org/show_bug.cgi?id=58378

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAllowDisplayOfInsecureContent): (WebKit::WebSettingsImpl::setAllowRunningOfInsecureContent):
  • src/WebSettingsImpl.h: Simple plumbing for the new boolean settings.
6:13 PM Changeset in webkit [85377] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Extract a function to obtain VisiblePosition from RenderText::positionForPoint
​https://bugs.webkit.org/show_bug.cgi?id=59811

Extracted lineDirectionPointFitsInBox from positionForPoint.

  • rendering/RenderText.cpp: (WebCore::lineDirectionPointFitsInBox): (WebCore::RenderText::positionForPoint):
6:01 PM Changeset in webkit [85376] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=59846
Scrolling causes rounded bottom window corners to become square
<rdar://problem/9234239>

Reviewed by Simon Fraser.

Keep track of the m_windowBottomCornerIntersectionRect in WKView.
Invalidate the rect before scrolling. And if the rect is non-zero during a
display, mask the corners, then set the rect to zero so that only displays that
happen right after a scroll bother to do this.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::scrollView):

  • UIProcess/API/mac/WKView.mm:

(-[WKView displayIfNeeded]):
(-[WKView _cacheWindowBottomCornerRect]):

  • UIProcess/API/mac/WKViewInternal.h:
5:57 PM Changeset in webkit [85375] by ggaren@apple.com
  • 8 edits
    2 adds in trunk

2011-04-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: r83938 abandons GC memory
​https://bugs.webkit.org/show_bug.cgi?id=59604

This bug was caused by script and image elements waiting indefinitely
for their loads to finish.

  • bindings/js/JSNodeCustom.cpp: (WebCore::isReachableFromDOM): Don't test for the load event firing, since the load event doesn't fire in cases of canceled or errored loads. Instead, test hasPendingActivity().


Don't do this test at all for script elements because script elements
can't load while outside the document. (fast/dom/script-element-gc.html
verifies that this is correct.)

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::hasPendingActivity):
  • html/HTMLImageElement.h:
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): (WebCore::ImageLoader::hasPendingLoadEvent):
  • loader/ImageLoader.h: Added API for finding out if an image element has pending activity.
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest): All loads are supposed to end in data(allDataReceived = true) or error(), but in the edge case of a canceled load, all we get is a call to setRequest(0). Be sure to record that we're no longer loading in that case, otherwise our element will leak forever, waiting for its load to complete.

2011-04-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: r83938 abandons GC memory
​https://bugs.webkit.org/show_bug.cgi?id=59604


Test an edge case of an image that has finished loading but has not yet
fired its load event.

  • fast/dom/gc-image-element-expected.txt: Added.
  • fast/dom/gc-image-element.html: Added.
5:23 PM Changeset in webkit [85374] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-29 Emil Eklund <​eae@chromium.org>

Reviewed by Tony Chang.

Setting outerHTML should merge text nodes
​https://bugs.webkit.org/show_bug.cgi?id=52686

Add test for setting Element.outerHTML.

  • fast/dom/set-outer-html-expected.txt: Added.
  • fast/dom/set-outer-html.html: Added.

2011-04-29 Emil Eklund <​eae@chromium.org>

Reviewed by Tony Chang.

Setting outerHTML should merge text nodes
​https://bugs.webkit.org/show_bug.cgi?id=52686

When setting outerHTML adjacent text nodes should be merged. This matches
the behavior of outerText and the IE implementation of outerHTML.

Test: fast/dom/set-outer-html.html

  • html/HTMLElement.cpp: (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML. (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
5:15 PM Changeset in webkit [85373] by eae@chromium.org
  • 5 edits
    1 delete in trunk

2011-04-29 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

Onchange on text fields has an incoherent behavior
​https://bugs.webkit.org/show_bug.cgi?id=57330

Add tests for typing and then deleting text from an empty field.

  • fast/events/onchange-text-form-field-expected.txt:
  • fast/events/onchange-text-form-field.html:
  • platform/gtk/fast/events/onchange-text-form-field-expected.txt: Removed.

2011-04-29 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

Onchange on text fields has an incoherent behavior
​https://bugs.webkit.org/show_bug.cgi?id=57330

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::insertedIntoDocument): Initialize m_textAsOfLastFormControlChangeEvent to empty string rather than null for empty fields.
5:11 PM Changeset in webkit [85372] by barraclough@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=59847
Remove linkOffset from LinkBuffer

Reviewed by Oliver Hunt.

This is redundant since removal of recompilation for exception info.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compile):
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compileCTINativeCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

5:00 PM Changeset in webkit [85371] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Jia Pu <​jpu@apple.com>

Reviewed by Sam Weinig.

[Mac] Scrolling WK2 window should dismiss autocorrection panel.
​https://bugs.webkit.org/show_bug.cgi?id=59809
<rdar://problem/9317410>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidScroll): Dimiss autocorrection panel in this function.
4:38 PM Changeset in webkit [85370] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-29 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
​https://bugs.webkit.org/show_bug.cgi?id=59772

  • Tools.pro:
4:30 PM Changeset in webkit [85369] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-29 Kenneth Russell <​kbr@google.com>

Unreviewed build fix. Skip WebPageNewSerializerTest.cpp in Windows multi-DLL build.

  • WebKit.gyp:
4:28 PM Changeset in webkit [85368] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

WebKit2: Typing with Input methods still enters Roman characters in Safari search field frequently
​https://bugs.webkit.org/show_bug.cgi?id=59829
<rdar://problem/9336907>

This patch regresses behavior somewhat in that inline input isn't discarded when something
happens in an inactive window. This doesn't work well in shipping Safari either.

  • UIProcess/API/mac/WKView.mm: (-[WKView _notifyInputContextAboutDiscardedComposition]): Added a method that calls -discardMarkedText with a safety check. (-[WKView setMarkedText:selectedRange:replacementRange:]): Use it. (-[WKView _updateTextInputStateIncludingSecureInputState:]): Use it. (-[WKView _resetTextInputState]): Use it.
4:20 PM Changeset in webkit [85367] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-29 Kenneth Russell <​kbr@google.com>

Unreviewed. Merged in all downstream Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:17 PM Changeset in webkit [85366] by Chris Fleizach
  • 4 edits in trunk/Source/WebKit2

2011-04-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: Remote accessibility should build on snow leopard
​https://bugs.webkit.org/show_bug.cgi?id=59767

  • UIProcess/API/mac/WKView.mm: (-[WKView _updateRemoteAccessibilityRegistration:]): (-[WKView viewDidMoveToWindow]): (-[WKView _setAccessibilityWebProcessToken:]):
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformInitialize): (WebKit::WebPage::registerUIProcessAccessibilityTokens):
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain):
4:13 PM Changeset in webkit [85365] by inferno@chromium.org
  • 5 edits
    12 adds in trunk/LayoutTests

2011-04-29 Abhishek Arya <​inferno@chromium.org>

Unreviewed.


Chromium rebaselines for r85355.
​https://bugs.webkit.org/show_bug.cgi?id=59833

  • platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-linux/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.png: Added.
  • platform/chromium-win/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:
4:12 PM Changeset in webkit [85364] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-29 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Add protection for shared memory failing to allocate
<rdar://problem/9125287>
​https://bugs.webkit.org/show_bug.cgi?id=59842

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Add logging in shared memory failure cases.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Guard against ShareableBitmap failing to create a shared memory backing.
3:37 PM Changeset in webkit [85363] by Stephanie Lewis
  • 2 edits in trunk/Tools

Remove the production configuration guard since installs only happen in production anyway.
Works around a bug in Xcode

Rubber-stamped by Adam Roben.

  • DumpRenderTree/mac/PerlSupport/Makefile:
3:20 PM Changeset in webkit [85362] by evan@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-04-28 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] support components build on Linux
​https://bugs.webkit.org/show_bug.cgi?id=59748

  • WebKit.gyp: adjust tests to not be Windows-specific.
  • public/WebCommon.h: add #defines to support Linux.
  • public/linux/WebFontRenderStyle.h: expose Linux-specific API.
  • tests/RunAllTests.cpp: adjust ifdefs to not be Windows-specific.
3:11 PM Component Model edited by Dimitri Glazkov
(diff)
2:55 PM Changeset in webkit [85361] by barraclough@apple.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=59221
[RegexFuzz] Regression blocking testing

Reviewed by Oliver Hunt & Geoff Garen.

Source/JavaScriptCore:

Okay, so the bug here is that when, in the case of a TypeParentheticalAssertion
node, emitDisjunction recursively calls to itself to emit the nested disjunction
the value of parenthesesInputCountAlreadyChecked is bogus (doesn't take into
account the uncheck that has just taken place).

Also, the special handling given to countToCheck in the case of parenthetical
assertions is nonsense, delete it, along with the isParentheticalAssertion argument.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

LayoutTests:

Add new tests for parenthetical assertions.

  • fast/regex/assertion-expected.txt:
  • fast/regex/script-tests/assertion.js:
2:44 PM Changeset in webkit [85360] by Adam Roben
  • 9 edits in trunk

Ensure PHP's short_open_tag and log_errors settings are turned on

These are usually on by default, but you can't trust defaults!

Reviewed by Sam Weinig.

Tools:

Remove a PHP setting that is now provided by httpd.conf

r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
isn't dependent on paths that could be different on each user's machine).

  • Scripts/webkitperl/httpd.pm:

(getDefaultConfigForTestDirectory): Removed log_errors setting.

LayoutTests:

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/apache2-msys-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:

Added settings to turn on short_open_tag and log_errors.

2:43 PM Changeset in webkit [85359] by Stephanie Lewis
  • 3 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=59776
<rdar://problem/9287113> REGRESSION: Safari cold/warm launch time 15% to 2x regression
On the first draw the WebProcess is just going to send us blank bits anyway so don't
pause waiting for the update. Continue drawing a blank window until the WebProcess
sends us the update.

Reviewed by Darin Adler.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::paint):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):

  • UIProcess/DrawingAreaProxyImpl.h:
2:41 PM Component Model edited by Dimitri Glazkov
(diff)
2:41 PM Component Model edited by Dimitri Glazkov
(diff)
2:32 PM Changeset in webkit [85358] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Ojan Vafai <​ojan@chromium.org>

Inlude new expected results accidentally excluded from
​http://trac.webkit.org/changeset/85346.

  • fast/harness/results-expected.txt:
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:21 PM Component Model edited by Dimitri Glazkov
(diff)
2:14 PM Component Model edited by Dimitri Glazkov
(diff)
2:07 PM Component Model edited by Dimitri Glazkov
(diff)
1:56 PM Changeset in webkit [85357] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r85343.

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

1:42 PM Changeset in webkit [85356] by jonlee@apple.com
  • 12 edits in trunk/Source

2011-04-29 Jon Lee <​jonlee@apple.com>

Reviewed by mitzpettel.

REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
​https://bugs.webkit.org/show_bug.cgi?id=59721

Removing shouldClearSelectionWhenLosingWebPageFocus(). Reverting changelist 83814.

  • WebCore.exp.in:
  • editing/EditingBehavior.h:

2011-04-29 Jon Lee <​jonlee@apple.com>

Reviewed by mitzpettel.

REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
<rdar://problem/9327332>
​https://bugs.webkit.org/show_bug.cgi?id=59721

When resigning first responder status, check to see if we need to maintain an inactive
selection in the web view. If we don't, we clear the selection.

This also reverts the change made in 83814, since that was a different attempt to solve this same issue.

  • UIProcess/API/C/WKPage.cpp: (WKPageSetMaintainsInactiveSelection): Export setMaintainsInactiveSelection()
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): Check and see if we need to maintain the selection in the view prior to resigning. If not, we clear the selection
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::clearSelection): Send message across process boundary (WebKit::WebPageProxy::setMaintainsInactiveSelection): Sets variable
  • UIProcess/WebPageProxy.h: New member variable to keep track of whether we need to maintain the current selection (WebKit::WebPageProxy::maintainsInactiveSelection): Returns variable
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setFocused): Reverting code to just set the focused bit instead of also clearing the selection (WebKit::WebPage::clearSelection):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: add new ClearSelection() message
1:38 PM Changeset in webkit [85355] by inferno@chromium.org
  • 6 edits
    16 adds in trunk

2011-04-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Allow only first table caption and destroy the remaining ones.
​https://bugs.webkit.org/show_bug.cgi?id=58249

Previously, we were only laying out the first table caption.
However Table::layout didn't mark the other ones as not needing
layout. So after table layout completes, table is marked as not
needing layout with its other table caption still needing layout.
This causes incorrect layout root calculations and set it to a
node which is already getting deleted.

Tests: fast/table/dynamic-caption-add-before-child.xhtml

fast/table/dynamic-caption-add-remove-before-child.xhtml
fast/table/multiple-captions-crash.xhtml
fast/table/multiple-captions-crash2.xhtml
fast/table/multiple-captions-display.xhtml

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): when new caption or a before child caption is added, we need to explicitly trigger section recalc or otherwise layout won't catch it. (WebCore::RenderTable::removeChild): when child to be removed is m_caption, make sure to trigger style recalc on the table. (WebCore::RenderTable::recalcCaption): code to destroy captions other than the first one. (WebCore::RenderTable::recalcSections): call recalcCaption helper. Store the next sibling early since child can get destroyed in recalcCaption.
  • rendering/RenderTable.h:

2011-04-21 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash on

ASSERT(!m_layoutRoot->container()
!m_layoutRoot->container()->needsLayout())

when a table has two or more captions.
​https://bugs.webkit.org/show_bug.cgi?id=58249

  • fast/table/dynamic-caption-add-before-child.xhtml: Added. Tests that before child caption becomes the first caption.
  • fast/table/dynamic-caption-add-remove-before-child.xhtml: Added. Tests that when we remove the before child caption, the original caption becomes the first caption and is drawn.
  • fast/table/multiple-captions-crash-expected.txt: Added.
  • fast/table/multiple-captions-crash.xhtml: Added. Tests that we do not crash when table has multiple captions and captions (other than the first one) have input elements added as their child.
  • fast/table/multiple-captions-crash2-expected.txt: Added.
  • fast/table/multiple-captions-crash2.xhtml: Added. Same as multiple-captions-crash.xhtml but this testcase does not have enclosing table tags for the captions.
  • fast/table/multiple-captions-display.xhtml: Added. Tests that only the first caption and captions with position fixed (display=BLOCK) are shown. Other captions are not added to table.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.checksum: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.png: Added.
  • platform/mac/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/mac/fast/table/prepend-in-anonymous-table-expected.txt: Rebaseline test because we do not allow captions other than the first one.
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt: Rebaseline test because we do not allow captions other than the first one.
1:29 PM Changeset in webkit [85354] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2011-04-29 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=59729

Another followup from adding ENABLE(ANIMATION_API). Fix
tests that mention webkitGetAnimations().

  • fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
12:46 PM Changeset in webkit [85353] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove WML
​https://bugs.webkit.org/show_bug.cgi?id=59678

  • DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
12:42 PM Changeset in webkit [85352] by jonlee@apple.com
  • 2 edits in trunk/Tools

2011-04-29 Jon Lee <​jonlee@apple.com>

Unreviewed, Adding Jon Lee as a committer

  • Scripts/webkitpy/common/config/committers.py:
12:40 PM Changeset in webkit [85351] by jamesr@google.com
  • 5 edits in branches/chromium/742/Source/WebCore

Merge 84546 - 2011-04-21 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Fix artefacts in compositor HUD when resizing
​https://bugs.webkit.org/show_bug.cgi?id=58969

HUD was using the tiler program and not setting the texture
transform. The HUD would thus draw with a texture transform based
on the last tile drawn, leading sometimes to distortion.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::headsUpDisplayProgram):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

TBR=​commit-queue@webkit.org
BUG=81011
Review URL: ​http://codereview.chromium.org/6901134

12:32 PM Changeset in webkit [85350] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-29 James Robinson <​jamesr@chromium.org>

Unreviewed, rolling out r85330.
​http://trac.webkit.org/changeset/85330
​https://bugs.webkit.org/show_bug.cgi?id=41311

Caused unexpected border rendering change on 500 tests on chromium linux.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
12:20 PM Changeset in webkit [85349] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix after r85343.

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::wndProc):
(WebCore::PluginView::snapshot):

12:19 PM Changeset in webkit [85348] by dino@apple.com
  • 14 edits in trunk/LayoutTests

2011-04-29 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=59729

Followup from adding an ENABLE flag that is disabled by
default. Adjust broken test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
12:17 PM Changeset in webkit [85347] by ojan@chromium.org
  • 8 edits in trunk/Tools

2011-04-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

fix pretty_patch_available and wdiff_available
​https://bugs.webkit.org/show_bug.cgi?id=59761

These methods rely on the check_* method being called first.
This would only happen when we actually tried to compute a diff,
but computing the diff happens on a different process.

Also fix setting _wdiff_avialable to True by default.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
12:14 PM Changeset in webkit [85346] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-29 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

handle flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=59820

Handle that actual can be a space-separated list of results
when we do retries. Also, show expected flaky tests that pass
in the unexpected passes table.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
12:12 PM Changeset in webkit [85345] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-04-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Application cache doesn't work due to a sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=59818
<rdar://problem/9346971>

Add a sandbox extension for the application cache directory.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode and decode the sandbox extension handle.
  • Shared/WebProcessCreationParameters.h: Add a applicationCacheDirectoryExtensionHandle member.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): If we have a non-empty application cache directory, create a sandbox extension and pass it to the creation parameters.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Create and consume a sandbox extension.
  • WebProcess/WebProcess.h: Add an m_applicationCachePathExtension member variable.
12:09 PM Changeset in webkit [85344] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-29 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

exclude skipped tests from the summarized results
​https://bugs.webkit.org/show_bug.cgi?id=59813

If we find a need fo skipped tests later, we should either create
a skipped.json file or expose this some other way. As it is, the data
is unused and is hugely bloating the size of full_results.json.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
11:53 AM Changeset in webkit [85343] by Csaba Osztrogonác
  • 9 edits in trunk/Source

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

  • wtf/OwnPtr.h:

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData):
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):

2011-04-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Enable strict OwnPtr for Qt
​https://bugs.webkit.org/show_bug.cgi?id=59667

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
11:37 AM Changeset in webkit [85342] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-29 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: index with integer keys
​https://bugs.webkit.org/show_bug.cgi?id=59794

  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt: Added.
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html: Added.
11:19 AM Changeset in webkit [85341] by Adam Roben
  • 2 edits in trunk/Tools

Make DumpRenderTreeSupport get installed when the default configuration is built

The default configuration is Production, but in that case the CONFIGURATION environment
variable is set to the empty string.

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't

already set so that later logic that depends on CONFIGURATION having that value will work.

11:15 AM Changeset in webkit [85340] by dino@apple.com
  • 22 edits in trunk

2011-04-29 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

Add ENABLE macro for WebKitAnimation
​https://bugs.webkit.org/show_bug.cgi?id=59729

Add new feature to toggle WebKit Animation API.

  • configure.ac:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • Configurations/FeatureDefines.xcconfig: for JavaScriptCore, WebCore, WebKit/mac, WebKit2
11:10 AM Changeset in webkit [85339] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Brian Weinstein.

Crash when closing a tab that is unresponsive
​https://bugs.webkit.org/show_bug.cgi?id=59810
<rdar://problem/9329133>

Back out r84643 - there was no rationale for this change, and it's causing crashes.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::processDidCrash):
11:00 AM Changeset in webkit [85338] by dino@apple.com
  • 3 edits
    3 adds in trunk

2011-04-29 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=59149
(Regression) Existing animations are not replaced when filling.

Hardware animations that fill forwards were not being correctly
replaced when the animation was removed. The actual animation
logic was working correctly, but it wasn't deleting the
CoreAnimation animation from the PlatformLayer. The fix was
to explicitly call endAnimation when disconnecting the animation
from its RenderObject.

Test: animations/3d/replace-filling-transform.html

  • page/animation/AnimationBase.h: (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared

2011-04-29 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=59149
(Regression) Existing animations are not replaced when filling.

Add a test that exercises the case where a hardware animation
is in a filling mode, then is replaced by a new animation.

  • animations/3d/replace-filling-transform-expected.txt: Added.
  • animations/3d/replace-filling-transform.html: Added.
  • animations/3d/replace-filling-transform-expected.png: Added.
10:34 AM Changeset in webkit [85337] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-04-29 Mark Pilgrim <​pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: indexes against autoincrementing keys
​https://bugs.webkit.org/show_bug.cgi?id=59722

  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/autoincrement-indexes.html: Added.
10:29 AM Changeset in webkit [85336] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Remove WML
​https://bugs.webkit.org/show_bug.cgi?id=59678

[Qt] Remove WML tests from the Skipped list after r85256.

  • platform/qt/Skipped:
10:20 AM Changeset in webkit [85335] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-28 Abhishek Arya <​inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests that we do not crash when inline text is removed and we
try to access layout attributes containing that inline text.
​https://bugs.webkit.org/show_bug.cgi?id=59161

  • svg/text/inline-text-destroy-attributes-crash-expected.txt: Added.
  • svg/text/inline-text-destroy-attributes-crash.xhtml: Added.

2011-04-29 Abhishek Arya <​inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

When svg inline text is getting destroyed, make sure to mark
its svg text ancestor as needing a positioning values update.
This helps to recalculate layout attributes and makes sure
that svg inline text is not used again.
​https://bugs.webkit.org/show_bug.cgi?id=59161

Test: svg/text/inline-text-destroy-attributes-crash.xhtml

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::destroy):
  • rendering/svg/RenderSVGInlineText.h:
10:18 AM Changeset in webkit [85334] by weinig@apple.com
  • 2 edits in trunk/Tools

Make production the default build type for WebKitTestRunner, matching
all other projects.

Reviewed by Adam Roben.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:12 AM Changeset in webkit [85333] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add flakey tests to the Skipped list.

  • platform/qt-mac/Skipped:
9:57 AM Changeset in webkit [85332] by kevino@webkit.org
  • 6 edits in trunk

[wx] Unreviewed build fixes for recent changes in WebKit trunk and wxMSW.

9:53 AM Changeset in webkit [85331] by pfeldman@chromium.org
  • 1 edit
    2 adds in trunk/Websites/webkit.org

2011-04-29 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: adding image files for the blog post.

  • blog-files/inspector/remote-debugging-attached.png: Added.
  • blog-files/inspector/remote-debugging-discovery.png: Added.
9:48 AM Changeset in webkit [85330] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Mike Reed <​reed@google.com>

Reviewed by Ojan Vafai.

Skia: Need to implement GraphicsContext::clipConvexPolygon()
​https://bugs.webkit.org/show_bug.cgi?id=41311

This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
as that shows other issues/question unrelated to clipping.
​https://bugs.webkit.org/show_bug.cgi?id=41311

No new tests. covered by existing layout tests

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
9:29 AM Changeset in webkit [85329] by Adam Roben
  • 3 edits in trunk/LayoutTests

Move some tests that time out in Debug from win-xp/Skipped to win/Skipped

This will help people who run tests in Debug on Windows 7.

  • platform/win-xp/Skipped: Moved two XHR tests from here...
  • platform/win/Skipped: ...to here.
9:19 AM Changeset in webkit [85328] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference.
​https://bugs.webkit.org/show_bug.cgi?id=42197

Add http/tests/inspector/network/ping.html, which uses overridePreference, to the mac-wk2
Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
9:15 AM Changeset in webkit [85327] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-29 Mike Lawther <​mikelawther@chromium.org>

Reviewed by Ojan Vafai.

Fix IR->SR typo in enum value (and resulting style fails)
​https://bugs.webkit.org/show_bug.cgi?id=59779

No functionality change, so no new tests

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EShapeRendering):
9:02 AM Changeset in webkit [85326] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Not reviewed: skip new flaky inspector tests for resource tree model on GTK for now.

  • platform/gtk/Skipped:
8:56 AM Changeset in webkit [85325] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Not reviewed: skip flaky inspector tests for now.

  • platform/mac/Skipped:
8:35 AM Changeset in webkit [85324] by pfeldman@chromium.org
  • 5 edits
    6 adds in trunk

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: CSS editing breaks when entering "color: rgb(1"
​https://bugs.webkit.org/show_bug.cgi?id=59789

  • inspector/styles/styles-add-invalid-property-expected.txt: Added.
  • inspector/styles/styles-add-invalid-property.html: Added.
  • inspector/styles/styles-cancel-editing-expected.txt: Added.
  • inspector/styles/styles-cancel-editing.html: Added.
  • inspector/styles/styles-commit-editing-expected.txt: Added.
  • inspector/styles/styles-commit-editing.html: Added.

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: CSS editing breaks when entering "color: rgb(1"
​https://bugs.webkit.org/show_bug.cgi?id=59789

Tests: inspector/styles/styles-add-invalid-property.html

inspector/styles/styles-cancel-editing.html
inspector/styles/styles-commit-editing.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
7:39 AM Changeset in webkit [85323] by vestbo@webkit.org
  • 8 edits in trunk/Source

ENABLE(QT_BEARER) -> USE(QT_BEARER)

Reviewed by Simon Hausmann.

7:39 AM Changeset in webkit [85322] by vestbo@webkit.org
  • 5 edits in trunk/Source

ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)

Reviewed by Simon Hausmann.

6:15 AM Changeset in webkit [85321] by podivilov@chromium.org
  • 8 edits
    1 add in trunk

2011-04-29 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=59476

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.navigate): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageLoaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/resources/test-navigation.html: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-29 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=59476

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
6:06 AM Changeset in webkit [85320] by podivilov@chromium.org
  • 13 edits in trunk

2011-04-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: include script end line:column in scriptParsed parameters.
​https://bugs.webkit.org/show_bug.cgi?id=59717

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/debugger-scripts.html:

2011-04-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: include script end line:column in scriptParsed parameters.
​https://bugs.webkit.org/show_bug.cgi?id=59717

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h: (WebCore::InspectorDebuggerAgent::Script::Script):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
  • inspector/front-end/Script.js: (WebInspector.Script):
5:36 AM Changeset in webkit [85319] by yurys@chromium.org
  • 27 edits in trunk

2011-04-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [protocol] Evaluate should expose thrown exception value
​https://bugs.webkit.org/show_bug.cgi?id=59000

  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-eval-global-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:

2011-04-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [protocol] Evaluate should expose thrown exception value
​https://bugs.webkit.org/show_bug.cgi?id=59000

Each evaluation command may have either thrown or returned result. This is indicated
by wasThrown property in the protocol.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::makeEvalCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to the evaluation results.
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.evaluated): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleCommandResult):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.evaluate):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
5:36 AM Changeset in webkit [85318] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename page as pageProxy in WebKitWebViewBase
​https://bugs.webkit.org/show_bug.cgi?id=59790

To avoid consufion between page client and page proxy. Also rename
some methods to webkitWebViewBase* for consistency.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseFinalize): (webkitWebViewBaseExpose): (webkitWebViewBaseDraw): (webkitWebViewBaseSizeAllocate): (webkitWebViewBaseFocusInEvent): (webkitWebViewBaseFocusOutEvent): (webkitWebViewBaseKeyPressEvent): (webkitWebViewBaseKeyReleaseEvent): (webkitWebViewBaseButtonPressEvent): (webkitWebViewBaseButtonReleaseEvent): (webkitWebViewBaseScrollEvent): (webkitWebViewBaseMotionNotifyEvent): (webkit_web_view_base_class_init): (webkitWebViewBaseCreate): (webkitWebViewBaseGetPage):
5:21 AM Changeset in webkit [85317] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85315.
​http://trac.webkit.org/changeset/85315
​https://bugs.webkit.org/show_bug.cgi?id=59792

Broke script-formatter.html test (Requested by podivilov on
#webkit).

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r85315.
​http://trac.webkit.org/changeset/85315
​https://bugs.webkit.org/show_bug.cgi?id=59792

Broke script-formatter.html test (Requested by podivilov on
#webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
4:43 AM Changeset in webkit [85316] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

2011-04-29 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
​https://bugs.webkit.org/show_bug.cgi?id=58794

Added ping requests to network panel.

  • http/tests/inspector/network/ping-expected.txt: Added.
  • http/tests/inspector/network/ping.html: Added.

2011-04-29 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
​https://bugs.webkit.org/show_bug.cgi?id=58794

Added ping requests to network panel.

Test: http/tests/inspector/network/ping.html

  • English.lproj/localizedStrings.js:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueAfterPingLoader):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.refreshResource): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get formParameters): (WebInspector.Resource.prototype.requestContentType): (WebInspector.Resource.prototype.isPingRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PingLoader.h:
4:35 AM Changeset in webkit [85315] by podivilov@chromium.org
  • 7 edits in trunk

2011-04-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=59476

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.navigate): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageLoaded): (initialize_InspectorTest.InspectorTest.runWhenPageLoads): ():
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-28 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
​https://bugs.webkit.org/show_bug.cgi?id=59476

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.PresentationBreakpoint.prototype.serialize):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset):
3:23 AM Changeset in webkit [85314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-29 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: Fix network panel timing/size/headers tests.
​https://bugs.webkit.org/show_bug.cgi?id=59696

  • src/js/Tests.js: (.TestSuite.prototype.testNetworkSize.finishResource): (.TestSuite.prototype.testNetworkSyncSize.finishResource): (.TestSuite.prototype.testNetworkRawHeadersText.finishResource): (.TestSuite.prototype.testNetworkTiming.finishResource):
2:55 AM Changeset in webkit [85313] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

2011-04-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement UI client in minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=58416

It also allows to open more than one minibrowser window from the
command line.

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowFinalize): (browser_window_init): (browserWindowConstructed): (createNewPage): (showPage): (closePage): (runJavaScriptAlert): (browserWindowUIClientInit):
  • MiniBrowser/gtk/main.c: (loadURI): (main):
2:34 AM Changeset in webkit [85312] by pfeldman@chromium.org
  • 14 edits in trunk/Source

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add "open link in new tab" action into the network and resources panels.
​https://bugs.webkit.org/show_bug.cgi?id=59788

This change also distinguishes context menu items case between platforms.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: (WebInspector.DOMBreakpointsSidebarPane):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._contextMenuEventFired): (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent): (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
  • inspector/front-end/inspector.js: (WebInspector.openLinkExternallyLabel): (WebInspector.openResource): (WebInspector.useLowerCaseMenuTitles):

2011-04-29 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add "open link in new tab" action into the network and resources panels.
​https://bugs.webkit.org/show_bug.cgi?id=59788

This change also distinguishes context menu items case between platforms.

  • src/js/DevTools.js:
2:32 AM Changeset in webkit [85311] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk/Tools

2011-04-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement page loader client in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=58024

A new class BrowserWindow has been added to implement the page
loader client. It makes supporting multiple windows easier. Window
title and url entry are now updated during the loading process.

  • MiniBrowser/gtk/BrowserWindow.c: Added. (activateUriEntryCallback): (goBackCallback): (goForwardCallback): (browserWindowFinalize): (browserWindowGetProperty): (browserWindowSetProperty): (browser_window_init): (browserWindowConstructed): (browser_window_class_init): (browserWindowUpdateTitle): (browserWindowSetTitle): (browserWindowSetLoadProgress): (browserWindowUpdateURL): (didStartProvisionalLoadForFrame): (didReceiveServerRedirectForProvisionalLoadForFrame): (didFailProvisionalLoadWithErrorForFrame): (didCommitLoadForFrame): (didFinishDocumentLoadForFrame): (didFinishLoadForFrame): (didFailLoadWithErrorForFrame): (didReceiveTitleForFrame): (didFirstLayoutForFrame): (didFirstVisuallyNonEmptyLayoutForFrame): (didRemoveFrameFromHierarchy): (didStartProgress): (didChangeProgress): (didFinishProgress): (didBecomeUnresponsive): (didBecomeResponsive): (browserWindowLoaderClientInit): (browser_window_new): (browser_window_get_view):
  • MiniBrowser/gtk/BrowserWindow.h: Added.
  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c: (createWindow):
2:31 AM Changeset in webkit [85310] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/Settings.js

Merge 85272 - 2011-04-28 Ilya Tikhonovsky <​loislo@chromium.org> Unreviewed trivial one-line fix inspired by wrong patch for ​https://bugs.webkit.org/show_bug.cgi?id=59630. * inspector/front-end/Settings.js: (WebInspector.Settings):
TBR=​loislo@chromium.org
Review URL: ​http://codereview.chromium.org/6903137

12:18 AM Changeset in webkit [85309] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix a crash after r85214.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkit_web_view_base_init): Add line to create the page client instance, removed by mistake in r85214.
12:07 AM Changeset in webkit [85308] by Stephanie Lewis
  • 2 edits in trunk/Tools

​http://bugs.webkit.org/show_bug.cgi?id=59743
<rdar://problem/9040413> Add an install target for production builds.

Reviewed by Mark Rowe.

  • DumpRenderTree/mac/PerlSupport/Makefile:
Note: See TracTimeline for information about the timeline view.