Timeline


and

05/08/11:

21:37 Changeset [86043] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r86042.
http://trac.webkit.org/changeset/86042

The change contains an incorrect specification.

  • platform/chromium/test_expectations.txt:
21:19 Changeset [86042] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <morrita@google.com>

Unreviewed marking flaky test (insecure-plugin-in-iframe.html)

  • platform/chromium/test_expectations.txt:
20:29 Changeset [86041] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
https://bugs.webkit.org/show_bug.cgi?id=60376

Added tests to ensure selectstart event is fired when a user selects all contents
and script can prevent such selection change in selectstart's event handler.

  • fast/events/selectstart-on-selectall-expected.txt: Added.
  • fast/events/selectstart-on-selectall.html: Added.
  • fast/events/selectstart-prevent-selectall-expected.txt: Added.
  • fast/events/selectstart-prevent-selectall.html: Added.

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
https://bugs.webkit.org/show_bug.cgi?id=60376

Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
document, editable region, or text control.

Tests: editing/selection/selectstart-on-selectall.html

editing/selection/selectstart-prevent-selectall.html

  • dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is input element or textarea element when the current selection is inside a shadow DOM, and the root editable element if it's inside a non-shadow editable region, and the body element otherwise.
  • html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer declared in Node.
19:16 Changeset [86040] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-08 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
https://bugs.webkit.org/show_bug.cgi?id=60249

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setColumnBreakInside): Assert that supported values are used.
17:40 Changeset [86039] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a DragCaretController from FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60273

Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
DragCaretController and FrameSelection and provides functions to paint caret.

Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.

  • WebCore.exp.in:
  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Added. (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true. (WebCore::DragCaretController::isContentRichlyEditable): Added. (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase. (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection. (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController. (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification. (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved and respondToNodeModification. Note that the position DragCaretController holds is equivalent to FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position, we used to execute the first if clause and cleared render tree selection and DOM tree selection. This is exactly what new DragCaretController::nodeWillBeRemoved does. (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions. (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection. (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned. Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if FrameSelection's start was not null. (WebCore::caretRendersInsideNode): Moved; Made static local. (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer. (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer. (WebCore::DragCaretController::caretRenderer): Ditto. (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments. (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*. (WebCore::CaretBase::caretRepaintRect): Ditto. (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect, and shouldRepaintCaret with extra arguments. (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable. (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect. (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect. (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret. (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret. (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for DragCaretController. (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
  • editing/FrameSelection.h: (WebCore::CaretBase::localCaretRectForPainting): Added. (WebCore::DragCaretController::isContentEditable): Added. (WebCore::DragCaretController::hasCaret): Added. (WebCore::DragCaretController::caretPosition): Added. (WebCore::DragCaretController::clear): Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): Uses DragCaretController. (WebCore::DragController::dispatchTextInputEventFor): Ditto. (WebCore::DragController::concludeEditDrag): Ditto. (WebCore::DragController::placeDragCaret): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
  • page/Page.h: (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
14:49 Changeset [86038] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86037.
http://trac.webkit.org/changeset/86037
https://bugs.webkit.org/show_bug.cgi?id=60453

broke Windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
14:30 Changeset [86037] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Update the WKSI libraries.

Rubber-stamped by Alice Liu.

  • win/lib/WebKitSystemInterface.lib:
13:56 Changeset [86036] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Make JSRetainPtr work with JSGlobalContextRefs.
https://bugs.webkit.org/show_bug.cgi?id=60452

Reviewed by Dan Bernstein.

Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.

  • API/JSRetainPtr.h:

(JSRetain):
(JSRelease):

13:24 Changeset [86035] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More rebaselines for r86028.

  • platform/chromium-linux/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.txt:
13:13 Changeset [86034] by imasaki@chromium.org
  • 5 edits in trunk/LayoutTests

2011-05-08 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Eric Seidel.

[Chromium] add rebaseline for video-volume-slider for GPU.
https://bugs.webkit.org/show_bug.cgi?id=60427

These tests are failing due to text.
http://code.google.com/p/chromium/issues/detail?id=81482

  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:
12:47 Changeset [86033] by inferno@chromium.org
  • 15 edits
    6 adds
    2 deletes in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More chromium rebaseline for r86028.

  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-expected.png:
  • platform/chromium-linux/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-linux/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-linux/fast/text/trailing-white-space-expected.png:
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.txt:
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.txt:
  • platform/chromium/test_expectations.txt:
11:58 Changeset [86032] by inferno@chromium.org
  • 108 edits
    4 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r86028.

  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/chromium/test_expectations.txt:
11:53 Changeset [86031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-08 Kamil Blank <k.blank@samsung.com>

Reviewed by Antonio Gomes.

Added new commands to be called by ewk_view_editor_command.
Due to this change ewk_view_select_* functions have been removed.
https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_view.cpp: (ewk_view_execute_editor_command):
  • ewk/ewk_view.h:
10:36 Changeset [86030] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated a platform-specific expected result again after r86028.

  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
10:13 Changeset [86029] by mitz@apple.com
  • 48 edits in trunk/LayoutTests

Updated some platform-specific expected results after r86028.

  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/text/justified-selection-at-edge-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.txt:
  • platform/qt/fast/text/justify-nbsp-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
09:27 Changeset [86028] by mitz@apple.com
  • 63 edits in trunk

<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
https://bugs.webkit.org/show_bug.cgi?id=60432

Reviewed by Darin Adler.

Source/WebCore:

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
variable is a (truncated) int anyway.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
so that the right amount is added to the total width. Also changed to use an early return.

LayoutTests:

  • fast/text/justify-nbsp-expected.png:
  • fast/text/justify-nbsp-expected.txt:
  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.png:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
09:09 Changeset [86027] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:
05:18 Changeset [86026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
https://bugs.webkit.org/show_bug.cgi?id=58556

Tests: fast/canvas/webgl/gl-teximage.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):

05/07/11:

23:47 Changeset [86025] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Reverted unintended changes in r86024

23:42 Changeset [86024] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
https://bugs.webkit.org/show_bug.cgi?id=60443

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/replaced/table-percent-height-positioned.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
doesn’t affect the table cell’s height).

LayoutTests:

  • fast/replaced/table-percent-height-positioned-expected.png: Added.
  • fast/replaced/table-percent-height-positioned-expected.txt: Added.
  • fast/replaced/table-percent-height-positioned.html: Added.
22:20 Changeset [86023] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-07 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Cleanup unexpected test passes in the gpu webkit tests
https://bugs.webkit.org/show_bug.cgi?id=60393

  • platform/chromium/test_expectations.txt:
21:42 Changeset [86022] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overlay fades out instead of disappearing immediately

Reviewed by Timothy Hatcher.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::hideFindUI): Do not fade out the overlay.

21:42 Changeset [86021] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Avoid copying a header file into the WebKit2 framework wrapper.

  • WebKit2.xcodeproj/project.pbxproj: Corrected the target membership of HTTPCookieAcceptPolicy.h.
19:50 Changeset [86020] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Testing EWS spins on patches with a large number of failures
https://bugs.webkit.org/show_bug.cgi?id=60441

In cases where the tree has a small number of persistent failures but a
patch has a large number of failures, we weren't believing any results.
That lead to us retrying the patch forever while we waited for
trustworthy results that would never come.

This patch loosens the semantics of unexpected_failures to return a
subset (rather than the exact set) of unexpected failures. In the case
where the tree has a bounded number of failures and the patch has an
unbounded number of failures, we can accurately compute such a subset
and reject the patch.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
18:25 Changeset [86019] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows WebKit2 Release Tests]
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing since r85795.
https://bugs.webkit.org/show_bug.cgi?id=60442

Add win-wk2 failing expected results to get the bots green.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
18:09 Changeset [86018] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
17:58 Changeset [86017] by inferno@chromium.org
  • 5 edits in trunk/Source

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
http://trac.webkit.org/changeset/85974
https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
http://trac.webkit.org/changeset/85974
https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
17:49 Changeset [86016] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
16:46 Changeset [86015] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled

Add another test (fast/events/popup-blocked-from-mousemove.html) to the mac-wk2 Skipped list
to get the bots green.

  • platform/mac-wk2/Skipped:
16:39 Changeset [86014] by dbates@webkit.org
  • 1 edit in trunk/Source/WebKit/efl/ChangeLog

2011-05-07 Daniel Bates <dbates@webkit.org>

Update title of bug in change log entry for changeset <http://trac.webkit.org/changeset/86012>
so as to be consistent with the name of the bug in <https://bugs.webkit.org/show_bug.cgi?id=60151>.

16:37 Changeset [86013] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Add willPerformClientRedirect to the user-gesture tests.

  • fast/frames/location-redirect-user-gesture-expected.txt:
  • fast/frames/meta-refresh-user-gesture-expected.txt:

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Create a UserGestureIndicator when calling the clientRedirected callback.

  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer):

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
(For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willPerformClientRedirect): (WebViewHost::didStartProvisionalLoad):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
16:34 Changeset [86012] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-07 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Daniel Bates.

[EFL] Remove ewk_tile_unused_cache_free function form public api
https://bugs.webkit.org/show_bug.cgi?id=60151

The ewk_tile_unused_cache_free function should be only called by
ewk_tile_unused_cache_unref function. Calling this function without
considering reference counting may lead to fatal results.

  • ewk/ewk_tiled_model.c: (_ewk_tile_unused_cache_free): (ewk_tile_unused_cache_unref):
  • ewk/ewk_tiled_model.h:
16:34 Changeset [86011] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
introduction in r85669.
https://bugs.webkit.org/show_bug.cgi?id=60272

Add expected failing text results to get the bots green.

Note: these tests still need pixel results to be generated both for mac-wk2 and win-wk2.

  • platform/mac-wk2/editing/selection: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt: Added.
16:15 Changeset [86010] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

2011-05-07 Daniel Bates <dbates@webkit.org>

Update change log entry for changeset <http://trac.webkit.org/changeset/86009> to
explain that this was an attempt to fix the build after changeset 86007
<http://trac.webkit.org/changeset/86007> (bug #60438).

16:08 Changeset [86009] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-05-07 Daniel Bates <dbates@webkit.org>

Remove some more references to isTiger(), which was removed in changeset 86007
<http://trac.webkit.org/changeset/86007> (bug #60438).

  • Scripts/old-run-webkit-tests:
    • Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and file local variable.
15:59 Changeset [86008] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-07 Dawit Alemayehu <adawit@kde.org>

Reviewed by Daniel Bates.

Fix compile with GCC 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60380

Remove unused local variable from code.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch):
12:56 Changeset [86007] by psolanki@apple.com
  • 5 edits in trunk/Tools

Remove references to Tiger in scripts
https://bugs.webkit.org/show_bug.cgi?id=60438

Reviewed by Darin Adler.

Remove isTiger() and all of the code that depends on it.

  • Scripts/build-webkit:
  • Scripts/ensure-valid-python:
  • Scripts/gdb-safari:
  • Scripts/webkitdirs.pm:
07:36 Changeset [86006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-07 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Adam Roben.

[Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961
https://bugs.webkit.org/show_bug.cgi?id=60420

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: (WebKit::NetscapePlugin::platformVisibilityDidChange):
00:52 Changeset [86005] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 85586
BUG=81348
Review URL: http://codereview.chromium.org/6953015

00:32 Changeset [86004] by cevans@google.com
  • 2 edits
    14 copies in branches/chromium/742

Merge 85876
BUG=72832
Review URL: http://codereview.chromium.org/6952018

00:17 Changeset [86003] by cevans@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/rendering

Merge 85705
BUG=79746
Review URL: http://codereview.chromium.org/6948015

00:08 Changeset [86002] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when sending a wheel event to a node with no shadow ancestor node
https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>

Reviewed by Alice Liu.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.

05/06/11:

23:12 Changeset [86001] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/742

Merge 85964
BUG=72832
Review URL: http://codereview.chromium.org/6949014

22:49 Changeset [86000] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Forgot it since my last svg rebaseline r85981.

  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
22:02 Changeset [85999] by inferno@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines for r85990

  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
21:24 Changeset [85998] by tkent@chromium.org
  • 32 edits
    2 deletes in trunk/Source

2011-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=60262

  • Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement and TextFieldInputType.
  • Change the return type of Node::toInputElement(): InputElement* -> HTMLInputElement*

No new tests. This change should not change the existing behaviour.

  • CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
  • GNUmakefile.list.am: ditto.
  • WebCore.exp.in: Add symbols of functions exposed to WebKit.
  • WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textMarkerDataForVisiblePosition): Follow the return type change of Node::toInputElement().
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isPasswordField): ditto. (WebCore::AccessibilityRenderObject::isIndeterminate): ditto. (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto. (WebCore::AccessibilityRenderObject::isChecked): ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
  • dom/CheckedRadioButtons.cpp: (WebCore::CheckedRadioButtons::removeButton): ditto.
  • dom/DOMAllInOne.cpp: Remove InputElement.h.
  • dom/InputElement.cpp: Removed.
  • dom/InputElement.h: Removed.
  • dom/Node.cpp: (WebCore::Node::toInputElement): Change the return type from InputElement* to HTMLInputElement*.
  • dom/Node.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::formControlName): (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::size): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer): (WebCore::HTMLInputElement::setDefaultName): (WebCore::HTMLInputElement::maxLength): (WebCore::HTMLInputElement::cacheSelection): (WebCore::formatCodes): Moved from InputElement. (WebCore::cursorPositionToMaskIndex): ditto. (WebCore::HTMLInputElement::isConformToInputMask): ditto. (WebCore::HTMLInputElement::validateInputMask): ditto. (WebCore::HTMLInputElement::setWapInputFormat): ditto. (WebCore::HTMLInputElement::notifyFormStateChanged): ditto. (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto. (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
  • html/HTMLInputElement.h:
    • Add data members which were defined in InputElementData.
    • Make some functions public because the public interface InputElement is removed.
    • Make some functions non-virtual because they don't override corresponding virtual functions of InputElement anymore.

(WebCore::HTMLInputElement::toInputElement):

Follow the return type change of Node::toInputElement().

(WebCore::HTMLInputElement::isIndeterminate):
(WebCore::HTMLInputElement::isAutofilled):
(WebCore::HTMLInputElement::supportsMaxLength):
(WebCore::HTMLInputElement::cachedSelectionStart):
(WebCore::HTMLInputElement::cachedSelectionEnd):

  • html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
  • html/InputType.cpp: (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
  • html/InputType.h: Update for the above.
  • html/TextFieldInputType.cpp: (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp. (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength(). (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Move the code from InputElement::handleBeforeTextInsertedEvent().
  • html/TextFieldInputType.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp:
    • Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
    • Follow the return type change of inputElement().

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):

Make sure node() is an HTMLInputElement instance.

(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
(WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
(WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
(WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::startSearchEventTimer):
(WebCore::RenderTextControlSingleLine::searchEventTimerFired):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTextControlSingleLine.h: Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isChecked): Follow the return type change of Node::toInputElement(). (WebCore::RenderTheme::isIndeterminate): ditto. (WebCore::RenderTheme::shouldHaveSpinButton): Change the parameter type: InputElement* -> HTMLInputElement*.
  • rendering/RenderTheme.h: ditto.

2011-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=60262

  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength. (WebKit::toWebInputElement): Follow the return type change of Node::toInputElement().

2011-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=60262

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Follow the return type change of Node::toInputElement(). (DumpRenderTreeSupportGtk::setValueForUser): ditto.

2011-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Eliminate WebCore/dom/InputElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=60262

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAutofilled): Follow the return type change of Node::toInputElement().
20:51 Changeset [85997] by cevans@google.com
  • 14 edits
    2 copies in branches/chromium/742

Merge 85823
BUG=64046
Review URL: http://codereview.chromium.org/6955016

20:45 Changeset [85996] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/742

Merge 85926
BUG=80608
Review URL: http://codereview.chromium.org/6949013

20:26 Changeset [85995] by cevans@google.com
  • 11 edits
    2 copies in branches/chromium/696

Merge 85926
BUG=80608

20:19 Changeset [85994] by cevans@google.com
  • 12 edits
    2 copies in branches/chromium/696

Merge 85823
BUG=64046

19:13 Changeset [85993] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
https://bugs.webkit.org/show_bug.cgi?id=60402

  • http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only.html: Added.

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement "Report-Only" mode for CSP
https://bugs.webkit.org/show_bug.cgi?id=60402

This mode lets web sites try out CSP by getting violation reports (and
console spam) without actually changing the behavior of their web sites.

Test: http/tests/security/contentSecurityPolicy/report-only.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h:
18:18 Changeset [85992] by imasaki@chromium.org
  • 8 edits in trunk/LayoutTests

2011-05-06 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline to chromium for video-layer.
https://bugs.webkit.org/show_bug.cgi?id=60423

These expected files are produced by the rebaseline tool.
http://code.google.com/p/chromium/issues/detail?id=81833

  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium/test_expectations.txt:
17:56 Changeset [85991] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/LayoutTests

2011-05-06 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

[chromium] Rebaseline needed for media/audio-repaint
https://bugs.webkit.org/show_bug.cgi?id=60416

  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
17:52 Changeset [85990] by bdakin@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60421
Custom scrollbars nested inside an overlay scrollbar overflow region end up
painting twice
-and corresponding-
<rdar://problem/9389072>

Reviewed by Darin Adler.

Source/WebCore:

Be sure not to paint custom css scrollbars during the special overlay-scrollbar
painting pass.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):

LayoutTests:

  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • scrollbars/scrollbars-on-positioned-content.html: Added.
17:50 WebKit Team edited by rniwa@webkit.org
Adding "Core DOM" and "Event Handling" to my area of knowledge (diff)
17:47 Changeset [85989] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-05-06 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Add utility for converting SkCanvas to CGContext
https://bugs.webkit.org/show_bug.cgi?id=59808

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The BitLockerSkia utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

Each time the CGContext is retrieved, it is rebuilt.
This permits the caller to modify the same canvas
between calls.

This change adds utilities but does not modify any
existing code. For now, there are no callers to these
utilities, so there is no functional change.

No new tests.

  • platform/graphics/skia/BitLockerSkia.cpp: Added. (WebCore::SkMatrixToCGAffineTransform): Conversion utility. (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas. (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up. (WebCore::BitLockerSkia::release): Internal private helper. (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
  • platform/graphics/skia/BitLockerSkia.h: Added.
17:11 Changeset [85988] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-06 David Grogan <dgrogan@chromium.org>

Reviewed by Eric Seidel.

update link to message about mac 64bit git binaries
https://bugs.webkit.org/show_bug.cgi?id=60411

The original message implied (correctly, at-the-time) that
http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
binaries. The new message notes that they do. This might prevent someone
else from spending a few minutes confused.

  • Scripts/webkitpy/common/checkout/scm/git.py:
16:29 Changeset [85987] by mrobinson@webkit.org
  • 6 edits
    2 adds in trunk/Source

2011-05-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract coordinate system translation code from WebKit into WebCore.
This will allow the code to be shared between WebKit and WebKit2. The code
now lives in a new GtkUtilities.cpp helper file.

  • GNUmakefile.list.am: Added GtkUtilities to the source list.
  • platform/gtk/GtkUtilities.cpp: Added. (WebCore::convertWidgetRectToScreenRect):
  • platform/gtk/GtkUtilities.h: Added.

2011-05-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
https://bugs.webkit.org/show_bug.cgi?id=55960

Abstract the code to translate from widget space to screen space into
a helper method in WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities. (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):

2011-05-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [WebKit2] WebView::windowToScreen needs an implementation
https://bugs.webkit.org/show_bug.cgi?id=55960

Add an implementation of PageClient::windowToScreen for GTK+ WebKit2 using
the newly abstracted widget to screen coordinate translation code in WebCore.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::windowToScreen): Added implementation.
16:12 Changeset [85986] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Disable platform/win/plugins/visibility-hidden.html.

  • platform/chromium/test_expectations.txt:
16:07 Changeset [85985] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove some unnecessary static methods in ResourceHandleSoup.

No new tests. This is only a small cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly. (WebCore::gotHeadersCallback):Ditto. (WebCore::contentSniffedCallback):Ditto. (WebCore::sendRequestCallback):Ditto. (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
16:06 Changeset [85984] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] ResourceHandles are leaked on 304 responses
https://bugs.webkit.org/show_bug.cgi?id=60413

Always call cleanupSoupRequestOperation, even when the request was not
canceled. Before the code would call didFinishLoading and then never clean up
the request.

No new tests. This simply fixes a memory leak.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
15:50 Changeset [85983] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Simplify the PluginInfoStore interface
https://bugs.webkit.org/show_bug.cgi?id=60406

Just expose a single API for getting a list of plug-ins from the info store,
PluginInfoStore::plugins and remove PluginInfoStore::getPlugins and PluginInfoStore::getPluginPaths.

Also, change the WebContext::pluginInfoStore() getter to return a reference.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): (WebKit::WebContext::getPluginPath):
  • UIProcess/WebContext.h: (WebKit::WebContext::pluginInfoStore):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType):
15:38 Changeset [85982] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-05-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: crashes in race with crashing DRT
https://bugs.webkit.org/show_bug.cgi?id=60238

This fixes a race where if we wrote the URL to DRT and
DRT crashed immediately, we could get a broken pipe
error back during the write() and not handle it correctly,
causing NRWT to also crash.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:16 Changeset [85981] by inferno@chromium.org
  • 61 edits
    28 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines for r85926.
https://bugs.webkit.org/show_bug.cgi?id=60356

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
  • platform/chromium-mac/svg/filters/feTile-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
15:08 Changeset [85980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

14:52 Changeset [85979] by inferno@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r85964, r85971 and r85967.

  • platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:17 Changeset [85978] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-06 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make more PluginInfoStore member functions static
https://bugs.webkit.org/show_bug.cgi?id=60401

This is a first step towards making PluginInfoStore thread safe.

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
14:12 Changeset [85977] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • fast/events/popup-blocked-from-mousemove-expected.txt: Added.
  • fast/events/popup-blocked-from-mousemove.html: Added.

2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
14:06 Changeset [85976] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Fix error due to duplicate entry.

  • platform/chromium/test_expectations.txt:
14:03 Changeset [85975] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60301

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60301

This CSP directive is not in the CSP spec. This patch is somewhat of
an experiment to see whether this feature is useful. Based on our
implementation experience, we will coordinate with folks via the W3C to
see if this makes sense to add to the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
13:52 Changeset [85974] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
13:29 Changeset [85973] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Fix two warnings of unused variables.
https://bugs.webkit.org/show_bug.cgi?id=60370

Remove two unused local variable from the code.

No new tests, the existing ones should cover.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateNextProgressTime):
13:13 Changeset [85972] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
https://bugs.webkit.org/show_bug.cgi?id=60384

  • platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
    • Boo different error messages.
  • platform/chromium/test_expectations.txt:
    • Test progression.

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Wire up CSP's eval blocking to V8's new API
https://bugs.webkit.org/show_bug.cgi?id=60384

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval):
13:07 Changeset [85971] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.
12:22 Changeset [85970] by enne@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-06 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rebaseline changes after r85959
https://bugs.webkit.org/show_bug.cgi?id=59020

  • platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:17 Changeset [85969] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a --skip-integrationtests mode to test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=60354

These two test suites account for 2/3 of test-webkitpy's running time
because they're not actually unit tests. They're integration tests.
This patch adds the ability to skip integration tests by passing a
command line argument to test-webkitpy. The buildbots will continue to
run these integration tests to make sure they don't regress. This
option is for use by developers when working on parts of the code that
are well-covered by unit tests.

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
  • Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
12:14 Changeset [85968] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[results.html] label the zoomed pixel containers (expected, actual, diff)
https://bugs.webkit.org/show_bug.cgi?id=60383

  • fast/harness/results.html:
12:10 Changeset [85967] by joepeck@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-06 Joseph Pecoraro <joepeck@webkit.org>

Unreviewed. Add pixel results for mac.

  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.
12:09 Changeset [85966] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium]: Reland using WebPermissionClient for checking indexed db usage
https://bugs.webkit.org/show_bug.cgi?id=60386

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
12:05 Changeset [85965] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-06 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Add baselines to chromium for video-source-error that reflect the fact that
chromium does not support mp4.

[chromium] Rebaseline needed for video-source-error
https://bugs.webkit.org/show_bug.cgi?id=60292

  • platform/chromium/media/video-source-error-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:50 Changeset [85964] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank

Reviewed by Dan Bernstein.

Make simplified layout skip from a positioned object out to its containing block. There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.

Source/WebCore:

Added fast/block/positioning/hiding-inside-relpositioned-inline.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

  • fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
11:49 Changeset [85963] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: move selection test into the text area branch.

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu):
11:48 Changeset [85962] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a

missing #import.

11:41 Changeset [85961] by aroben@apple.com
  • 18 edits
    3 adds in trunk

Show/hide windowed plugins according to the plugin element's visibility CSS property

Fixes <http://webkit.org/b/60285> <rdar://problem/9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed

Reviewed by Anders Carlsson.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::isPluginVisible):

  • PluginProcess/PluginControllerProxy.h:

Stubbed out.

  • Shared/win/WindowGeometry.cpp:

(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):

  • Shared/win/WindowGeometry.h:

Added visible member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::visibilityDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Added. Calls through to platform-specific code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformVisibilityDidChange):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.

  • WebProcess/Plugins/Plugin.h: Added visibilityDidChange.
  • WebProcess/Plugins/PluginController.h: Added isPluginVisible.
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::visibilityDidChange):

  • WebProcess/Plugins/PluginProxy.h:

Stubbed out.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.

(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.

  • WebProcess/Plugins/PluginView.h: Updated for PluginController changes.

LayoutTests:

Add a test that shows that windowed plugins with visibility:hidden do not appear on screen

I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.

  • platform/win/plugins/visibility-hidden-expected.png: Added.
  • platform/win/plugins/visibility-hidden-expected.txt: Added.
  • platform/win/plugins/visibility-hidden.html: Added.
11:35 Changeset [85960] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The results.zip generated by the Chromium EWS are too big
https://bugs.webkit.org/show_bug.cgi?id=60352

Currently results.zip created by the Chromium EWS bot contain roughly
1000 tests that we expect to fail. These test results are not helpful
to contributors.

There are several approaches to solving this problem:

1) We could be more selective about which files to include in the zip.
2) We could ask new-run-webkit-tests not to generate results for

expected failures.

3) We could ask new-run-webkit-tests not to run tests that we expect to

fail.

This patch takes approach (3). Currently, we're ignoring the outcome
of failing tests anyway, so there's not much point in actually running
them. As a side benefit, this will speed up the test run by about 6%.
In the future, we might revisit this decision and choose another
approach.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
10:41 Changeset [85959] by enne@google.com
  • 4 edits
    4 adds in trunk

2011-05-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020

  • compositing/flat-with-transformed-child-expected.txt: Added.
  • compositing/flat-with-transformed-child.html: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect scissor rect for layers that render into a rendersurface
https://bugs.webkit.org/show_bug.cgi?id=59020

Allow for empty scissor rects, which implies scissoring to the render
surface. The previous code and previous patch on this bug both didn't
take into account that the scissor rect should be the render surface
and not the projection of the layer itself, because child layers
aren't necessarily contained within the bounds of their superlayer.

Test: compositing/flat-with-transformed-child.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
10:30 Changeset [85958] by aroben@apple.com
  • 15 edits
    2 adds in trunk/Source/WebKit2

Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message

This will make it easier to add more info to this message in the future (like whether the
window is visible).

Fixes <http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious

Reviewed by Anders Carlsson.

  • Scripts/webkit2/messages.py:

(struct_or_class): Added WindowGeometry to the list of structs.

  • Shared/win/WindowGeometry.cpp: Added.
  • Shared/win/WindowGeometry.h: Added.
  • win/WebKit2.vcproj: Added new files.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.

10:22 Changeset [85957] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

[results.html] zoomed pixel results should not be antialiased
https://bugs.webkit.org/show_bug.cgi?id=60330

-Use canvas instead of CSS zoom.
-Only zoom the part of the image we need to show.
-Make pixel zooming mostly work in Firefox.
-Increase the zoom from 3x to 6x.

  • fast/harness/results.html:
10:22 Changeset [85956] by ddkilzer@apple.com
  • 4 edits in trunk/Source

Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings

Reviewed by Jon Honeycutt.

This fixes an Xcode 4 warning about using obsolete settings.

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Removed

GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

10:12 Changeset [85955] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Lazily allocate ScrollAnimator in ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=60327

Avoid allocating the ScrollAnimator up-front, because we
create lots of ScrollableAreas via RenderLayer, and we should
only need the animator when scrolling.

  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::ScrollableArea): (WebCore::ScrollableArea::scrollAnimator): (WebCore::ScrollableArea::scroll): (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation): (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation): (WebCore::ScrollableArea::handleWheelEvent): (WebCore::ScrollableArea::handleGestureEvent):
  • platform/ScrollableArea.h:
10:04 Changeset [85954] by inferno@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85919.
http://trac.webkit.org/changeset/85919
https://bugs.webkit.org/show_bug.cgi?id=60378

broke chromium database tests (Requested by inferno-sec on
#webkit).

  • public/WebPermissionClient.h:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
09:55 Changeset [85953] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement NetscapePlugin::platformPaint for GTK platform
https://bugs.webkit.org/show_bug.cgi?id=60368

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::NetscapePlugin::platformPaint):
09:37 Changeset [85952] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.4

Create the 1.4 stable branch

09:03 Changeset [85951] by carlosgc@webkit.org
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Share PluginInfoStore implementation between Qt and GTK ports
https://bugs.webkit.org/show_bug.cgi?id=60366

  • GNUmakefile.am:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Removed.
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Renamed from Source/WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.pro:
08:51 Changeset [85950] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, fix parse errors in test_expectations.

I will annotate bug 60356 so that this case gets looked at.

  • platform/chromium/test_expectations.txt:
08:23 Changeset [85949] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
https://bugs.webkit.org/show_bug.cgi?id=60304
<rdar://problem/9392609>

Don't assume that the only time the media controls UI may need to change is on a
network state change, readyState changes can be significant as well.

Tested manually because we don't have any live streams to test in DRT.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay. (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay. (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElement.h:
  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::reset): Ditto. (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
  • html/shadow/MediaControlRootElementChromium.h:
  • html/shadow/MediaControls.h:
08:06 Changeset [85948] by aroben@apple.com
  • 3 deletes in trunk/LayoutTests/platform/win/plugins

Roll out r85946

I didn't mean to commit it!

08:04 Changeset [85947] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit/win

Touch WebKit.idl to fix the build

I needed this on my own machine. Maybe others will need it, too.

  • Interfaces/WebKit.idl:
08:02 Changeset [85946] by aroben@apple.com
  • 3 adds in trunk/LayoutTests/platform/win/plugins

Add a test for visibility:hidden for plugins

07:46 Changeset [85945] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-06 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix with gcc 4.6.0 on linux and c++0x support.

std::tr1::has_trivial_constructor is in <tr1/memory>.

  • wtf/TypeTraits.h:
07:35 Changeset [85944] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Andreas Kling <andreas.kling@nokia.com>

Unreviewed Qt 4.8 build fix.

  • WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can enable it after the 4.8 bots are updated with the full QRawFont APIs.
06:48 Changeset [85943] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
https://bugs.webkit.org/show_bug.cgi?id=60319

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
06:24 Changeset [85942] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use qt-arm platform instead of qt-linux on ARM platform.

Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:
03:51 Changeset [85941] by ossy@webkit.org
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

[Qt]fast/events/backspace-navigates-back.html fails
https://bugs.webkit.org/show_bug.cgi?id=60349

  • platform/mac-wk2/Skipped: Add fast/events/backspace-navigates-back.html because of missing layoutTestController.setEditingBehavior().
  • platform/qt-arm/Skipped: Add fast/events/backspace-navigates-back.html.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-mac/Skipped: Add fast/events/backspace-navigates-back.html.
02:17 Changeset [85940] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-06 Philippe Normand <pnormand@igalia.com>

Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081

Skip media/video-controls-visible-audio-only.html that now
requires shadowRoot support.

  • platform/win/Skipped:
01:58 Changeset [85939] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-06 Joe Mason <jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8. Relative urls should not be expanded.
https://bugs.webkit.org/show_bug.cgi?id=57138

  • http/tests/websocket/tests/url-with-nonascii-query-expected.txt: Added.
  • http/tests/websocket/tests/url-with-nonascii-query.html: Added.
  • http/tests/websocket/tests/url-parsing-expected.txt: Failure message for relative url has changed since it is no longer expanded.

2011-05-06 Joe Mason <jmason@rim.com>

Reviewed by Adam Barth.

WebSocket urls should always be encoded as UTF-8.
https://bugs.webkit.org/show_bug.cgi?id=57138

Change WebSocket::connect to take the raw URL string and parse it
internally using the simple KURL constructor, which expects an absolute
UTF-8 encoded URL. This ensures that all code that creates a WebSocket
goes through this method instead of completeURL.

Test: http/tests/websocket/tests/url-with-nonascii-query.html

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
  • websockets/WebSocket.h:
01:42 Changeset [85938] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60339

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialColorSpace): Add initialColorSpace() static method.
01:33 Changeset [85937] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <morrita@google.com>

Unreviewed, marking tests whose expectations became obsolete since r85926.

  • platform/chromium/test_expectations.txt:
01:27 Changeset [85936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setPageBreakInside() reject unsupported enum values.
https://bugs.webkit.org/show_bug.cgi?id=60235

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setPageBreakInside): Assert that only supported values are used.
01:17 Changeset [85935] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Move burden of checking for BJustify box alignment into RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=60246

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case logic checking for BJUSTIFY and use existing macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBoxAlign): Assert valid values are used.
01:00 Changeset [85934] by philn@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

Layout tests shouldn't have to hard code media controller element locations
https://bugs.webkit.org/show_bug.cgi?id=28220

New mediaControlsButtonCoordinates() function to get the middle
coordinates of a media controls button. This avoids hardcoding
positions in the tests.

Also unskipped the affected GTK media tests now passing.

  • media/audio-delete-while-step-button-clicked.html:
  • media/video-controls-transformed.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (mediaControlsButtonCoordinates):
  • platform/gtk/Skipped:
00:48 Changeset [85933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
https://bugs.webkit.org/show_bug.cgi?id=60338

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
00:47 Changeset [85932] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking. (send-form-data-with-sliced-file.html)

  • platform/chromium/test_expectations.txt:
00:45 Changeset [85931] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85860.

  • UIProcess/API/gtk/PageClientImpl.h: Fix typo.
00:43 Changeset [85930] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking. (resource-tree-frame-navigate.html)

  • platform/chromium/test_expectations.txt:
00:39 Changeset [85929] by ossy@webkit.org
  • 4 edits
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/mac-wk2/Skipped:
    • Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
  • platform/qt-arm/Skipped:
    • Add fast/css/hover-update.html, because it fails intermittently.
    • Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
  • platform/qt-wk2/Skipped:
    • Add new but failing test: editing/pasteboard/paste-placeholder-input.html
00:35 Changeset [85928] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix with gcc 4.6 and c++0x support.
https://bugs.webkit.org/show_bug.cgi?id=60284

When enabling support of c++0x the compilation fails because of an
ambiguous overload error. In this code when constructing the pair
we use the new c++0x rvalue reference feature (&&). It means we are
calling String(const WTF::AtomicString&) which becomes ambiguous because
it has an overload WTF::String::String(const WTF::String&) and usually one
with the native port string type (e.g. QString). In this code we want the
String version because the pair store Strings.

No new tests, build fix.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::create):
00:33 Changeset [85927] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

Add an option to NRWT to skip failing tests
https://bugs.webkit.org/show_bug.cgi?id=60295

This option is similar to the way old-run-webkit-tests works. We're
planning to use this option on the testing EWS bots because they don't
use information from failing tests yet.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
00:33 Changeset [85926] by cdn@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-06 Cris Neckar <cdn@chromium.org>

Reviewed by Dirk Schulze.

Change maxEffectRect to a FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=59551

  • svg/filters/filter-after-transform-crash-expected.txt: Added.
  • svg/filters/filter-after-transform-crash.svg: Added.

2011-05-06 Cris Neckar <cdn@chromium.org>

Reviewed by Dirk Schulze.

Tests for crash when a transform is applied to certain filters.
https://bugs.webkit.org/show_bug.cgi?id=59551

Test: svg/filters/filter-after-transform-crash.svg

  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::determineAbsolutePaintRect):
  • platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  • platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  • platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
  • platform/graphics/filters/FELighting.h: (WebCore::FELighting::determineAbsolutePaintRect):
  • platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
  • platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::isFilterSizeValid): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::maxEffectRect): (WebCore::FilterEffect::setMaxEffectRect):
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
00:27 Changeset [85925] by philn@webkit.org
  • 38 edits in trunk

Tools:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

shadowPseudoId support in the various LayoutTestController
implementations.

  • DumpRenderTree/LayoutTestController.cpp: (shadowPseudoIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::shadowPseudoId):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowPseudoId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

WebKit2:

2011-05-05 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleShadowPseudoId):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot): (WebKit::InjectedBundleNodeHandle::elementShadowPseudoId):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

WebKit/win:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOMCoreClasses.cpp: (DOMElement::shadowPseudoId):
  • DOMCoreClasses.h:

WebKit/qt:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKit/mac:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowPseudoId]):
  • DOM/WebDOMOperationsPrivate.h:

WebKit/gtk:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowPseudoId):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

WebKit/chromium:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::shadowPseudoId):

LayoutTests:

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Dimitri Glazkov.

Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034

  • media/video-controls-transformed.html: Refactored to use the pseudoShadowId() LayoutTestController method.
00:19 Changeset [85924] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-06 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking. (test_boolean_expr.html)

  • platform/chromium/test_expectations.txt:
00:11 Changeset [85923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-06 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Use cast to convert primitive value to FontSmoothingMode.
https://bugs.webkit.org/show_bug.cgi?id=60242

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use cast to convert primitive value to FontSmoothingMode.
00:06 Changeset [85922] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-06 Adam Barth <abarth@webkit.org>

EWS can't reject patches
https://bugs.webkit.org/show_bug.cgi?id=60345

We're supposed to use patch.id() for the attachment ID, silly.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

05/05/11:

23:46 Changeset [85921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSPropertySpeak use the correct macro.
https://bugs.webkit.org/show_bug.cgi?id=60335

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
23:44 Changeset [85920] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking.

  • platform/chromium/test_expectations.txt:
23:25 Changeset [85919] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Make IndexedDB code use WebPermissionClient API
https://bugs.webkit.org/show_bug.cgi?id=60340

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
23:22 Changeset [85918] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

<rdar://problem/9390864>
https://bugs.webkit.org/show_bug.cgi?id=60343
Crash on Recovery System when trying to load page that includes media element

Automated test not possible, tested manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if

AVFoundation and CoreMedia are installed.

  • platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to

SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.

23:06 Changeset [85917] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed attempt to error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
22:38 Changeset [85916] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
20:44 Changeset [85915] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
20:36 Changeset [85914] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed addding skip line for full-screen-stacking-context.html.

  • platform/chromium/test_expectations.txt:
19:29 Changeset [85913] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Live streams sometimes won't play with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748

Tested manually because we don't have any live streams to test in DRT.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume

AVFoundation will notify us when internal states change.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver

a RetainPtr

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
19:18 Changeset [85912] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Ojan Vafai <ojan@chromium.org>

Now that win has a failing result, chromium-win needs to
have the passing result. http://trac.webkit.org/changeset/85911

  • platform/chromium/fast/harness/results-expected.txt: Added.
19:04 Changeset [85911] by ojan@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2011-05-05 Ojan Vafai <ojan@chromium.org>

Move failing result as it appears to be failing on all Apple Win platforms.

  • platform/win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/win-7sp0/fast/harness/results-expected.txt.
18:43 Changeset [85910] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Evan Martin <evan@chromium.org>

Unreviewed, just skipping a test.

New test fast/events/backspace-nagivates-back fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=60311

Skip this test until Antonoi has time to look at it.

  • platform/qt-linux/Skipped:
18:37 Changeset [85909] by jcivelli@chromium.org
  • 9 edits
    2 adds in trunk/Source

2011-05-05 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Added convenience methods to convert from a byte to hex ASCII digit
characters and vice-versa.
https://bugs.webkit.org/show_bug.cgi?id=59834

  • wtf/ASCIICType.h: (WTF::toASCIIHexValue): (WTF::lowerNibbleToASCIIHexDigit): (WTF::upperNibbleToASCIIHexDigit):

2011-05-05 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding quoted-printable encoding/decoding capabilities.
This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=59834

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/QuotedPrintable.cpp: Added.
  • platform/text/QuotedPrintable.h: Added.
18:00 Changeset [85908] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

REGRESSION (r85689): Unresponsive timer firing when closing background tabs
<rdar://problem/9385988>
https://bugs.webkit.org/show_bug.cgi?id=60325

When calling WKPageTryClose(), if the page close succeeded, the notification to stop
the responsiveness timer would be dropped because the page was closed by the time it
got to the UIProcess.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::closePage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add parameter to closePage stipulating whether or not to stop the responsiveness timer.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): (WebKit::WebPage::sendClose): Instead of sending a StopResponsivenessTimer message after sending the ClosePage message, add a bit to the ClosePage message.
17:52 Changeset [85907] by jer.noble@apple.com
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, partial rollout of r85843 and r85824. r85897 made these expected results unnecessary.

  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Removed.
17:48 Changeset [85906] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

Fixed typos in a comment

17:28 Changeset [85905] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-05 Steve Lacey <sjl@chromium.org>

Reviewed by Ojan Vafai.

Fix generation of results html file by passing relative path to scm
methods.
Generate diff images for results html file.

https://bugs.webkit.org/show_bug.cgi?id=60086

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
17:19 Changeset [85904] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Jian Li.

[Chromium] Remove non-flaky tests (BUGCR81682, BUGCR80067)
and skip one unsupported test in test expectation file (BUGCR59399).
https://bugs.webkit.org/show_bug.cgi?id=60282

The skipped test is a cliking test that is specific to Mac and we
(Chrome Video Stack team) decided not to support it.

  • platform/chromium/test_expectations.txt:
17:12 Changeset [85903] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

Implement document.innerHTML
https://bugs.webkit.org/show_bug.cgi?id=60316

ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
for fragment parsing. This assertion will become invalid when
document.innerHTML is implemented, which is the only case where HTML5
specifies that a fragment will not have a context element.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
17:12 Changeset [85902] by kevino@webkit.org
  • 5 edits in trunk

[wx] Unreviewed build fixes after recent trunk changes.

17:09 Changeset [85901] by mitz@apple.com
  • 11 edits in trunk

Source/WebCore: WebCore part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
check in Core Animation.

  • platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac: WebKit part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

Source/WebKit2: WebKit2 part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

WebKitLibraries: WebKitSystemInterface part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebKitSystemInterface.h: Added WKExecutableWasLinkedOnOrBeforeSnowLeopard().
16:56 Changeset [85900] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 (Mac): Background tabs/windows can force themselves to the front
<rdar://problem/9386346>
https://bugs.webkit.org/show_bug.cgi?id=60315

  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): It is incorrect for us to call Chrome::focus() here, which could bring a window/tab to the front. Calling focusNSView() was only necessary because in WebKit we must inform the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
16:54 Changeset [85899] by commit-queue@webkit.org
  • 58 edits
    7 deletes in trunk/LayoutTests

2011-05-05 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Seidel.

Rebaseline various media tests after absolute positioning change. This rebaseline also
fixes outstanding minor pixel diffs.

[chromium] Rebaseline various media tests after controls absolute positioning changes
https://bugs.webkit.org/show_bug.cgi?id=60230

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-strict-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-styling-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.txt: Removed.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
16:34 Changeset [85898] by aestes@apple.com
  • 2 edits in trunk/Tools

2011-05-05 Andy Estes <aestes@apple.com>

Reviewed by Daniel Bates.

update-webkit should handle Internal using a different VCS than OpenSource.
https://bugs.webkit.org/show_bug.cgi?id=60310

isGit() and isSVN() cache their results, so Internal will always be
updated using the VCS commands used for OpenSource. If Internal uses a
different VCS, this will fail. Fix this by calling isGitDirectory() and
isSVNDirectory() instead, which do not cache their results.

  • Scripts/update-webkit:
16:07 Changeset [85897] by jer.noble@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Tony Chang.

full-screen-stacking-context-expected.txt should be under platform/mac
https://bugs.webkit.org/show_bug.cgi?id=60236

Make the text output of full screen pixel tests platform agnostic.

  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-zIndex-expected.txt:
  • platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Removed.
15:42 Changeset [85896] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: revamp integration tests incl. tests for servers
https://bugs.webkit.org/show_bug.cgi?id=59985

This change adds the ability to run "integration tests" that
depend on (and affect) the local environment on your machine.
These tests can be run manually by invoking python on the
test file in question and passing the '-i' flag, but are
not run automatically as part of test-webkitpy.

Integration tests are identified by being methods named as
"integration_test_*" instead of "test_*", and we use a
custom TestLoader instead of the default one provided by
unittest.

This change also adds a protected "_default_to_apache" method
to the port object so we can do the right thing when starting
and stopping web servers with less mechanism.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
15:39 Changeset [85895] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173

  • platform/chromium/test_expectations.txt: Adding expected failures for the the switch to Ganesh

2011-05-05 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173

  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Flipping the switch to make Skia the default for the accelerated 2d canvas
15:38 Changeset [85894] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101

  • fast/parser/close-while-stopping-expected.txt: Added.
  • fast/parser/close-while-stopping.html: Added.

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101

Test: fast/parser/close-while-stopping.html

15:23 Changeset [85893] by evan@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-03 Evan Martin <evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731

Add a test that verifies that pressing backspace goes back on Mac
and Windows but does not go back on Linux.

  • fast/events/backspace-navigates-back-expected.txt: Added.
  • fast/events/backspace-navigates-back.html: Added.

2011-04-28 Evan Martin <evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731

Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
Linux, and test for it in the default backspace handler.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultBackspaceEventHandler):
15:14 Changeset [85892] by hclam@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-05-05 Alpha Lam <hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations.

  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
15:10 Changeset [85891] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Russell.

Framebuffer object is being created twice
https://bugs.webkit.org/show_bug.cgi?id=60207

Does not create more than one opengl framebuffer

  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gtk/DrawingBufferGtk.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
15:09 Changeset [85890] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Every RenderLayer registers itself as a ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=59650

Rather than registering every RenderLayer as a ScrollableArea
on layer creation, only register RenderLayers which are overflow-
scrollable. Use the m_scrollableAreaPage pointer to keep track
of whether we've registered to avoid excess work.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollsOverflow): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
15:06 Changeset [85889] by aroben@apple.com
  • 4 edits in trunk

Update pixel results for draws-gradient.html to have an alpha channel

These pixel results were generated in r71418, when DRT was changed not to use an alpha
channel for pixel results. DRT was changed back to using an alpha channel in r71516, but
these pixel results were never updated. Now that DRT ensures that the alpha channel is
filled with constant opacity, we can safely update these pixel results without negatively
affecting their appearance. (The draws-gradient plugin uses ::GradientFill, which fills the
alpha channel with 0, so the plugin would have shown up as fully transparent in the pixel
results if DRT didn't modify the alpha channel.)

Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
generated due to alpha channel weirdness

Reviewed by Sam Weinig.

LayoutTests:

  • platform/win/platform/win/plugins/draws-gradient-expected.png: Regenerated. Looks the same

as before, but with an alpha channel.

Tools:

Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows

DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
alpha channel will even get filled with zeros (like when ::GradientFill is used). To
safeguard against this, we fill the alpha channel with constant full opacity after the
WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
results need an alpha channel, too.)

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
constant full opacity.
(createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
in a CGContext or cairo_surface.

15:05 Changeset [85888] by aroben@apple.com
  • 6 edits in trunk/Tools

Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner

Passing true tells the test harness to dump pixels even though we're not dumping a render
tree.

Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
WebKitTestRunner doesn't result in pixel results being generated

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels

argument to dumpAsText.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for dumpAsText change.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows

developers.

15:04 Changeset [85887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] Add method to disable plugins under WK2
https://bugs.webkit.org/show_bug.cgi?id=57796

  • config.h: Allow PLUGIN_ARCHITECTURE_UNSUPPORTED to be defined on build command line
14:59 Changeset [85886] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Steve Falkenburg.

Workaround iTunes' incorrect registry entry for .m4a extensions.
https://bugs.webkit.org/show_bug.cgi?id=60229

No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
The test failed to catch this regression because the build bots haven't installed iTunes.

Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.

  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
14:57 Changeset [85885] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Minor rebaselines for gtk after my r85876.

  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
14:49 Changeset [85884] by tony@chromium.org
  • 1 edit
    10 deletes in trunk/LayoutTests

2011-05-05 Tony Chang <tony@chromium.org>

Remove google-chrome-linux results. We're switching the official
builders from hardy to lucid and want to clear the old hardy based
results.

  • platform/google-chrome-linux32/css1: Removed.
  • platform/google-chrome-linux32/css2.1: Removed.
  • platform/google-chrome-linux32/editing: Removed.
  • platform/google-chrome-linux32/fast: Removed.
  • platform/google-chrome-linux32/plugins: Removed.
  • platform/google-chrome-linux32/svg: Removed.
  • platform/google-chrome-linux32/tables: Removed.
  • platform/google-chrome-linux32/transforms: Removed.
  • platform/google-chrome-linux64/fast: Removed.
  • platform/google-chrome-linux64/svg: Removed.
14:49 Changeset [85883] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

14:42 Changeset [85882] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Minor rebaselines for qt after my r85876.

  • platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
14:42 Changeset [85881] by lforschler@apple.com
  • 1 copy in tags/Safari-534.34

New tag.

14:41 Changeset [85880] by dpranke@chromium.org
  • 6 edits in trunk

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Modify the chromium expectations so that you no longer need to
specify both the operating system and the version. I.e., you
don't need "MAC LEOPARD", just "LEOPARD".

  • platform/chromium/test_expectations.txt:

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge os, version fields in test config
https://bugs.webkit.org/show_bug.cgi?id=60004

This change removes the 'o/s' field from the TestConfiguration
object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
the expectations file to macros that expand to the version names
for each platform.

This means that you can once again put any subset of the
operating system versions on a single line, e.g.:

BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL

This change will break any existing test_expectations.txt
file that uses the "OS-VERSION" macros, which are no longer
needed. It turns out they were never needed, as just VERSION
by itself was sufficient. The test_expectations.txt file should
be updated accordingly prior to landing this change.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
14:26 Changeset [85879] by tony@chromium.org
  • 17 edits
    6 copies
    13 adds in trunk

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
https://bugs.webkit.org/show_bug.cgi?id=60287

Rebase tests that have Thai or Hindi glyphs. We have different
results for x86_64 (lucid) and x86 (hardy) because the fonts have
changed. Since it's only a handful of tests, seems ok to have
separate baselines (also, hardy is going away real soon now).

  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png.
  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/complex-text-opacity-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/danda-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.txt: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.png:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux/fast/text/international/danda-space-expected.txt:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
https://bugs.webkit.org/show_bug.cgi?id=60287

The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
packages on Lucid. There are actually multiple Thai fonts in the
package, so I just picked one.

  • DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig):
14:14 Changeset [85878] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When an underlay surface is active, paint normal web contents in a transparency layer
https://bugs.webkit.org/show_bug.cgi?id=60296

In order for the page contents to correctly blend with the underlay, the page contents
needs to be painted in a transparency layer.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
14:13 Changeset [85877] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
https://bugs.webkit.org/show_bug.cgi?id=60290

It used to be that google-chrome-32 was hardy32, google-chrome-64 was
hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
lucid64. Because of that, google-chrome-64 used to skip the
chromium-linux-x86_64 results since they were more incorrect.

Now that we're switching to lucid for google-chrome, we want
google-chrome-64 to fall back to chromium-linux-x86_64.

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
14:07 Changeset [85876] by inferno@chromium.org
  • 4 edits
    14 adds in trunk

2011-05-05 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

When style changes for a RenderBlock and we lose our ability to intrude into
floats in the next siblings block (e.g a position change), make sure to mark
our childs with floats for layout and iterate through our next sibling block
chain to see which ones contain the float that also exists in our floating
objects list and clear those using markAllDescendantsWithFloatsForLayout.
https://bugs.webkit.org/show_bug.cgi?id=56299

Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html

fast/block/float/float-not-removed-from-next-sibling.html
fast/block/float/float-not-removed-from-next-sibling2.html
fast/block/float/float-not-removed-from-next-sibling3.html
fast/block/float/float-not-removed-from-next-sibling4.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
  • rendering/RenderBlock.h:

2011-05-04 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to add overflow from a float not in the
descendant list and whose renderer is already removed.
https://bugs.webkit.org/show_bug.cgi?id=56299

  • fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
  • fast/block/float/float-not-removed-from-next-sibling.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
13:55 Changeset [85875] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
https://bugs.webkit.org/show_bug.cgi?id=60002

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
13:31 Changeset [85874] by bweinstein@apple.com
  • 6 edits in trunk/Source

Source/WebCore: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Make a needed function public and export it.

  • WebCore.exp.in: Export constrainedAttaechedWindowHeight.
  • inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.

Source/WebKit2: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Before we place the inspector and the inspected views, make sure that we have constrained the height
of the docked inspector. Putting the code here covers both when the inspector is initially attached
and when a window with the docked inspector is resized.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Constrain the height before laying out the views.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Ditto.

13:30 Changeset [85873] by tonyg@chromium.org
  • 6 edits in trunk

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
https://bugs.webkit.org/show_bug.cgi?id=59448

  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/webtiming-origins-expected.txt:

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
https://bugs.webkit.org/show_bug.cgi?id=59448

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart):
13:21 Changeset [85872] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Block callbacks delivered during destruction
https://bugs.webkit.org/show_bug.cgi?id=60291
<rdar://problem/9382942>

No new tests, tested by existing tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call

setIgnoreLoadStateChanges(true) to cancel all callbacks.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if

m_ignoreLoadStateChanges is true.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.

Don't call updateStates after calling loadedTimeRangesChanged, it already does it.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
13:18 Changeset [85871] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should reject patches which fail ewses
https://bugs.webkit.org/show_bug.cgi?id=47534

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
13:13 Changeset [85870] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=57621

  • Source/sync.profile:

2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=57621

13:04 Changeset [85869] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Darin Adler.

Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).

Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

12:21 Changeset [85868] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
https://bugs.webkit.org/show_bug.cgi?id=60257

No new tests. This is just a build fix.

  • bindings/js/JSDOMBinding.cpp:

2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
https://bugs.webkit.org/show_bug.cgi?id=60257

  • webkit/webkitglobals.cpp: (webkitInit):
12:05 Changeset [85867] by commit-queue@webkit.org
  • 11 edits in trunk

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

Unskip passed tests.

  • platform/qt-wk2/Skipped:

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

Added private constructors for class QGraphicsWKView and QWKPage to support
WKPageGroupRef.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::~QGraphicsWKView): (QGraphicsWKView::init):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::QWKPage): (QWKPage::~QWKPage): (QWKPage::init):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

  1. Call QGraphicsWKView constructor with pageGroupRef.
  2. Disable setFontFamily calls as it breaks Qt test fonts.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView):
11:22 Changeset [85866] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-05 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
11:17 Changeset [85865] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/9369746>

This change implements "preload=metadata" for the AVFoundation backend.
Tested manually with manual-tests/media-elements/video-preload.html.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'

because we need to have media data loaded to seek.

(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.

  • html/HTMLMediaElement.h:
  • manual-tests/media-elements/video-preload.html: Make changing urls work.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove

m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.

(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.

Move all preload logic to setPreload, call it from here.

(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to

setPreload, call it.

(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is

unlikely to be correct and isn't worth caching. Use invalidTime() function.

(WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus

to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
without one. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache

width, height, hasVideo, etc.

(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done

in derived classes.

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create

AVAsset and AVPlayerItem here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_videoFrameHasDrawn.

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from

videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset

if necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when

the buffer is full.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the

AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset

when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before

we have allocated the AVPlayerItem.

11:14 Changeset [85864] by rniwa@webkit.org
  • 88 edits
    5 moves in trunk/Source

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds): (WebKit::WebViewImpl::caretOrSelectionRange): (WebKit::WebViewImpl::clearFocusedNode):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • Api/qwebframe.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • webkit/webkitwebview.cpp: (getLocationForKeyboardGeneratedContextMenu):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebDOMSelection.cpp:
  • WebDOMSelection.h:
  • WebKitSupport/EditorClientWx.cpp:
  • WebView.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
  • WebView/WebView.mm:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • bindings/objc/ExceptionHandlers.h:
  • css/CSSStyleSelector.cpp:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
  • dom/Document.cpp:
  • dom/InputElement.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:
  • editing/EditingAllInOne.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::Editor::canCopy): (WebCore::Editor::canDelete): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeSelectionAfterCommand): (WebCore::Editor::respondToChangedSelection):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeDeleteToMark): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  • editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp. (WebCore::FrameSelection::FrameSelection): (WebCore::FrameSelection::moveTo): (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::nodeWillBeRemoved): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWillBeReplaced): (WebCore::FrameSelection::setIsDirectional): (WebCore::FrameSelection::directionOfEnclosingBlock): (WebCore::FrameSelection::willBeModified): (WebCore::FrameSelection::positionForPlatform): (WebCore::FrameSelection::startForPlatform): (WebCore::FrameSelection::endForPlatform): (WebCore::FrameSelection::modifyExtendingRight): (WebCore::FrameSelection::modifyExtendingForward): (WebCore::FrameSelection::modifyMovingRight): (WebCore::FrameSelection::modifyMovingForward): (WebCore::FrameSelection::modifyExtendingLeft): (WebCore::FrameSelection::modifyExtendingBackward): (WebCore::FrameSelection::modifyMovingLeft): (WebCore::FrameSelection::modifyMovingBackward): (WebCore::FrameSelection::modify): (WebCore::FrameSelection::xPosForVerticalArrowNavigation): (WebCore::FrameSelection::clear): (WebCore::FrameSelection::setStart): (WebCore::FrameSelection::setEnd): (WebCore::FrameSelection::setBase): (WebCore::FrameSelection::setExtent): (WebCore::FrameSelection::setCaretRectNeedsUpdate): (WebCore::FrameSelection::updateCaretRect): (WebCore::FrameSelection::caretRenderer): (WebCore::FrameSelection::localCaretRect): (WebCore::FrameSelection::absoluteBoundsForLocalRect): (WebCore::FrameSelection::absoluteCaretBounds): (WebCore::FrameSelection::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::shouldRepaintCaret): (WebCore::FrameSelection::invalidateCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::FrameSelection::debugRenderer): (WebCore::FrameSelection::contains): (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): (WebCore::FrameSelection::selectAll): (WebCore::FrameSelection::setSelectedRange): (WebCore::FrameSelection::isInPasswordField): (WebCore::FrameSelection::caretRendersInsideNode): (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::pageActivationChanged): (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive): (WebCore::FrameSelection::setUseSecureKeyboardEntry): (WebCore::FrameSelection::setFocused): (WebCore::FrameSelection::isFocusedAndActive): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisible): (WebCore::FrameSelection::clearCaretRectIfNeeded): (WebCore::FrameSelection::caretBlinkTimerFired): (WebCore::FrameSelection::notifyRendererOfSelectionChange): (WebCore::FrameSelection::setFocusedNodeIfNeeded): (WebCore::FrameSelection::paintDragCaret): (WebCore::FrameSelection::copyTypingStyle): (WebCore::FrameSelection::shouldDeleteSelection): (WebCore::FrameSelection::bounds): (WebCore::FrameSelection::getClippedVisibleTextRectangles): (WebCore::FrameSelection::currentForm): (WebCore::FrameSelection::revealSelection): (WebCore::FrameSelection::setSelectionFromNone): (WebCore::FrameSelection::shouldChangeSelection): (WebCore::FrameSelection::formatForDebugger): (WebCore::FrameSelection::showTreeForThis): (showTree):
  • editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h. (WebCore::FrameSelection::typingStyle): (WebCore::FrameSelection::clearTypingStyle): (WebCore::FrameSelection::setTypingStyle): (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/ModifySelectionListLevel.cpp:
  • editing/RemoveFormatCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SelectionController.cpp: Removed.
  • editing/SelectionController.h: Removed.
  • editing/SetSelectionCommand.cpp: (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
  • editing/SetSelectionCommand.h: (WebCore::SetSelectionCommand::create):
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/chromium/SelectionControllerChromium.cpp: Removed.
  • editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/gtk/SelectionControllerGtk.cpp: Removed.
  • editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages):
  • editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/mac/SelectionControllerMac.mm: Removed.
  • editing/qt/EditorQt.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::type): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode):
  • page/DragController.cpp: (WebCore::DragController::dragIsMove):
  • page/DragController.h:
  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): (WebCore::setNonDirectionalSelectionIfNeeded): (WebCore::EventHandler::sendContextMenuEventForKey): (WebCore::EventHandler::handleKeyboardSelectionMovement):
  • page/EventHandler.h:
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::selection):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::dragCaretController):
  • page/chromium/DragControllerChromium.cpp:
  • page/chromium/EventHandlerChromium.cpp:
  • page/win/DragControllerWin.cpp:
  • page/win/EventHandlerWin.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::paintCaret):
  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderLayer.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTreeAsText.cpp:
  • svg/SVGSVGElement.cpp:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
11:01 Changeset [85863] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::cachedResponseDataForURL): Stub out
implementation for cURL networking case.

10:54 Changeset [85862] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] unreviewed build correction.

  • platform/network/curl/ResourceRequest.h:

Stub out the new pipelined http logic for cURL.

10:49 Changeset [85861] by joepeck@webkit.org
  • 2 edits in trunk/Tools

2011-05-05 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Add --only-webkit option to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=60245

  • Scripts/build-webkit: If --only-webkit was specified just build the WebKit project, and not its dependencies.
09:57 Changeset [85860] by jeffm@apple.com
  • 15 edits in trunk

2011-05-05 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=60203

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Stub out didNotHandleWheelEvent callback.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback. (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.

2011-05-05 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=60203


Remove Windows-specific WebPageProxy::wheelEventNotHandled() member function and use
didNotHandleWheelEvent callback in WKPageUIClient instead. It turns out that just
resending the wheel event to the parent window doesn't provide the client with enough context
to know that WebKit has already attempted to handle the event.

  • UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleWheelEventCallback typedef and didNotHandleWheelEvent to WKPageUIClient.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::didNotHandleWheelEvent): Added, but not implemented.
  • UIProcess/API/gtk/PageClientImpl.h: Added didNotHandleWheelEvent().
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):Stubbed out didNotHandleWheelEvent callback.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Call didNotHandleWheelEvent in WKPageUIClient if wheel event is not handled.
  • UIProcess/WebPageProxy.h: Removed wheelEventNotHandled().


  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::implementsDidNotHandleWheelEvent): Added. (WebKit::WebUIClient::didNotHandleWheelEvent): Added.
  • UIProcess/WebUIClient.h: Added implementsDidNotHandleWheelEvent() and didNotHandleWheelEvent().
  • UIProcess/win/WebPageProxyWin.cpp: Removed wheelEventNotHandled().
09:40 Changeset [85859] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Return correct GTK version for NPNVToolkit
https://bugs.webkit.org/show_bug.cgi?id=60275

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Return always 2 for NPNVToolkit in GTK platform.
09:38 Changeset [85858] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: searching for node does not result in bringToFront call.
https://bugs.webkit.org/show_bug.cgi?id=60222

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateFocusedNode):
09:07 Changeset [85857] by abarth@webkit.org
  • 2 edits in trunk

2011-05-05 Adam Barth <abarth@webkit.org>

Remove a couple stray mentions of WML that I missed before.

  • configure.ac:
09:01 Changeset [85856] by carlosgc@webkit.org
  • 9 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make native events code more consistent
https://bugs.webkit.org/show_bug.cgi?id=60258

Make all other native events code follow the current keyboard
events approach: use a GOwnPtr for the native event, and use
const GdkEvent* in the API. We need to implement the copy
constructors for native events to copy the gdk events with
gdk_event_copy().

  • Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
  • Shared/NativeWebWheelEvent.h: (WebKit::NativeWebWheelEvent::nativeEvent):
  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
  • Shared/gtk/NativeWebMouseEventGtk.cpp: (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • Shared/gtk/NativeWebWheelEventGtk.cpp: (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
  • Shared/gtk/WebEventFactory.cpp: (WebKit::buttonForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
08:44 Changeset [85855] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 and the build is not done
with c++0x support we need to deactivate warnings about compatibility.
Some WebKit types have names which conflicts with upcoming c++0x
types. If QtWebKit is built with c++0x support, WebKit has code to
fallback to the standard type rather than the WebKit implementation.
For example nullptr will be the one of the std if build options turns on
c++0x support.

  • Source/WebKit.pri:

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 or later we don't want to deactivate
the c++0x support because it works.

08:40 Changeset [85854] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Module::load() should return true when g_module_open() returns a valid pointer
https://bugs.webkit.org/show_bug.cgi?id=60261

  • Platform/gtk/ModuleGtk.cpp: (WebKit::Module::load):
08:39 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
08:20 Changeset [85853] by andreas.kling@nokia.com
  • 12 edits in trunk/Source/WebCore

2011-05-05 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Implement the fast font path for Qt.
https://bugs.webkit.org/show_bug.cgi?id=51106

Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
rendering and measurement of simple text.

Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
classes are fully integrated into the Qt 4.8 release branch.

  • WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
  • platform/graphics/Font.cpp: (WebCore::Font::drawText): Disable fast font path for stroked text, and when painting text with a shadow. (Qt-only) (WebCore::Font::codePath): Try to use fast font path in more cases.
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont to use for rendering a given string. Goes through QTextLayout to find the best font based on the original QFont query. (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::rawFont):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
  • platform/graphics/qt/FontQt.cpp: (WebCore::fillPenForContext): (WebCore::strokePenForContext): (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon to share code between complex and simple font rendering paths. (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
  • platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we have no way of knowing the pitch. (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter(). (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes(). (WebCore::SimpleFontData::scaledFontData): Added, based on other ports. (WebCore::SimpleFontData::smallCapsFontData): Ditto. (WebCore::SimpleFontData::emphasisMarkFontData): Ditto. (WebCore::SimpleFontData::platformBoundsForGlyph): Stub. (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics. (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
08:11 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
08:11 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
08:09 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
07:15 Changeset [85852] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skip inspector/console/console-shadow-dom-access.html (crashes in debug)
https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped:
07:14 Changeset [85851] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addUserStyleSheet):

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustProgressBarStyle): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::adjustSliderThumbStyle):
06:36 QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
06:35 QtWebKitPlatformSupport created by alexis.menard@openbossa.org
06:31 QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
06:20 Changeset [85850] by loislo@chromium.org
  • 14 edits
    2 moves in trunk/Source/WebCore

2011-05-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger to DOMDebugger.

https://bugs.webkit.org/show_bug.cgi?id=60256
InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
browserDebugger => domDebugger

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::DOMDebuggerAgent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp. (WebCore::InspectorDOMDebuggerAgent::create): (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled): (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled): (WebCore::InspectorDOMDebuggerAgent::disable): (WebCore::InspectorDOMDebuggerAgent::clearFrontend): (WebCore::InspectorDOMDebuggerAgent::discardBindings): (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint): (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorDOMDebuggerAgent::clear):
  • inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
06:06 QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
06:05 QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
05:14 Changeset [85849] by caseq@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for shadow DOM access in the console API
https://bugs.webkit.org/show_bug.cgi?id=60192

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNode):
  • inspector/console/console-shadow-dom-access-expected.txt: Added.
  • inspector/console/console-shadow-dom-access.html: Added.
03:58 Changeset [85848] by philn@webkit.org
  • 1 edit
    14 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt: Added.
03:41 Changeset [85847] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show only Console and Scripts panels in worker inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=60159

  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.isWorkerFrontend):
  • inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
02:17 Changeset [85846] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, marking flaky tests.

  • platform/chromium/test_expectations.txt:
01:44 Changeset [85845] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r85817.
http://trac.webkit.org/changeset/85817

It looks these lines are mis-skipped.

  • platform/chromium/test_expectations.txt:
01:36 Changeset [85844] by hans@chromium.org
  • 4 edits
    1 add in trunk/Source

2011-05-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
https://bugs.webkit.org/show_bug.cgi?id=59692

Fix some embarrassing bugs uncovered by unit tests.

No new functionality, but this is now covered by unit tests in the Chromium WebKit port.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::decodeInt): (WebCore::IDBLevelDBCoding::decodeVarInt):

2011-05-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
https://bugs.webkit.org/show_bug.cgi?id=59692

Add unit tests for the basic key coding functions used by the LevelDB back-end.

  • WebKit.gypi:
  • tests/IDBLevelDBCodingTest.cpp: Added. (IDBLevelDBCoding::TEST):
01:25 Changeset [85843] by philn@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new fullscreen test.

  • platform/gtk/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Added.
01:12 Changeset [85842] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, fixed a syntax error on expectations file.

  • platform/chromium/test_expectations.txt:
00:57 Changeset [85841] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85808.

  • Shared/NativeWebWheelEvent.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
00:25 Changeset [85840] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed expectations update for MAC GPU flakiness.

  • video-zoom-controls.html: Added IMAGE
  • media/controls-without-preload.html, media/controls-styling.html, media/controls-strict.html, media/controls-after-reload.html Added TEXT
  • platform/chromium/test_expectations.txt:
00:00 Changeset [85839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Young Han Lee <joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60251

No new tests. Build fix.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

05/04/11:

23:48 Changeset [85838] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
23:41 Changeset [85837] by jcivelli@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

2011-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding a utility class to read a SharedBuffer line by line.
https://bugs.webkit.org/show_bug.cgi?id=59946

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SharedBufferCRLFLineReader.cpp: Added.
  • platform/SharedBufferCRLFLineReader.h: Added.
23:32 Changeset [85836] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

r85835 skipped too much. narrowed skipped target.

  • platform/chromium/test_expectations.txt:
23:29 Changeset [85835] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed marking failing gpu tests:

  • controls-without-preload.html, controls-after-reload.html, controls-strict.html, controls-styling.html
  • platform/chromium/test_expectations.txt:
22:57 Changeset [85834] by commit-queue@webkit.org
  • 3 edits
    8 deletes in trunk

2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85788.
http://trac.webkit.org/changeset/85788
https://bugs.webkit.org/show_bug.cgi?id=60250

svg/text/text-block-child-crash.xhtml asserts (Requested by
Ossy on #webkit).

  • svg/custom/display-table-caption-foreignObject-expected.txt: Removed.
  • svg/custom/display-table-caption-foreignObject.svg: Removed.
  • svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Removed.
  • svg/custom/display-table-caption-inherit-foreignObject.xhtml: Removed.
  • svg/custom/display-table-caption-inherit-text-expected.txt: Removed.
  • svg/custom/display-table-caption-inherit-text.xhtml: Removed.
  • svg/custom/display-table-caption-text-expected.txt: Removed.
  • svg/custom/display-table-caption-text.svg: Removed.

2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85788.
http://trac.webkit.org/changeset/85788
https://bugs.webkit.org/show_bug.cgi?id=60250

svg/text/text-block-child-crash.xhtml asserts (Requested by
Ossy on #webkit).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
22:43 Changeset [85833] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed unit test skip (startPostAndWaitOnCondition)
which fails on Windows 7. See bug 60248 for tracking.

  • tests/CCThreadTest.cpp: (WebCore::TEST):
22:04 Changeset [85832] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

GTK build fix attempt after r85823

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
  • webkit/webkitwebview.cpp: (WebKit::kit):
21:54 Changeset [85831] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/win

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Windows build fix attempt after r85823

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
  • WebView.cpp: (kit):
21:43 Changeset [85830] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Marking at r85822 was not enough. Re-marked it.

  • platform/chromium/test_expectations.txt:
21:35 Changeset [85829] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed flaky marking to full-screen-stacking-context.html.

  • platform/chromium/test_expectations.txt:
21:22 Changeset [85828] by kerz@chromium.org
  • 1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

getting chromium continuous branch builder tests working again

20:55 Changeset [85827] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more missing imports from scm refactor
https://bugs.webkit.org/show_bug.cgi?id=60239

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
20:07 Changeset [85826] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make more member functions in EventHandler private
https://bugs.webkit.org/show_bug.cgi?id=60200

Reduced the number of public member functions in EventHandler.

  • WebCore.exp.in:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
  • page/EventHandler.h: (WebCore::EventHandler::mouseDownMayStartSelect):
20:03 Changeset [85825] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

Adds a regression test for composited content changing from transform-style: preserve-3d to flat.

  • compositing/repaint/transform-style-change-expected.png: Added.
  • compositing/repaint/transform-style-change-expected.txt: Added.
  • compositing/repaint/transform-style-change.html: Added.

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
the order back and adds a regression test.

Test: compositing/repaint/transform-style-change.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
19:42 Changeset [85824] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update.

  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Added.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Added.
19:36 Changeset [85823] by cdn@chromium.org
  • 32 edits
    2 adds in trunk

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests whether a style media specifier inside an svg image will crash.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • fast/media/media-svg-crash-expected.txt: Added.
  • fast/media/media-svg-crash.html: Added.

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

Test: fast/media/media-svg-crash.html

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::webView):
  • page/ChromeClient.h:
  • page/brew/ChromeClientBrew.h: (WebCore::ChromeClientBrew::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getWebView):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::webView):
  • src/ChromeClientImpl.h:
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
  • src/PlatformBridge.cpp: (WebCore::toWebWidgetClient):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::fromPage):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
  • WebView/WebFrame.mm: (kit):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientWinCE.h: (WebKit::ChromeClientWinCE::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::webView):
19:32 Changeset [85822] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed skipping text-block-child-crash.xhtml

  • platform/chromium/test_expectations.txt:
19:24 Changeset [85821] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot is having more exception trouble
https://bugs.webkit.org/show_bug.cgi?id=60233

A webpage-forced build was causing SB to throw an exception.
We've long had this bug, but we just didn't notice it until now.

In debugging this I found we fetch an absurd amount of data now
that we use buildbot's json (instead of xmlrpc), so I added
the filter=1 parameter to reduce it a little. That required
me to handle the case where filter=1 would strip
result=0 in some cases (it's unclear why it does that).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
19:08 Changeset [85820] by ojan@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Commit failing result. It's not clear to me why this test is failing.
There's nothing platform specific about it, it doesn't depend on the
system environment and it's not failing on the chromium win7 bot.

Committing this for now to green the tree.

  • platform/win-7sp0/fast/harness/results-expected.txt: Added.
19:07 Changeset [85819] by xan@webkit.org
  • 2 edits in trunk

2011-05-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix warnings in webkit.m4 with autoconf 2.68
https://bugs.webkit.org/show_bug.cgi?id=60189

Use AC_LANG_SOURCE when passing source code to AC_COMPILE_IFELSE
to remove warnings.

  • Source/autotools/webkit.m4: ditto.
18:16 Changeset [85818] by joepeck@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-04 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

  • editing/pasteboard/paste-placeholder-input-expected.txt: Added.
  • editing/pasteboard/paste-placeholder-input.html: Added.

2011-05-04 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

When deleting all the text inside the input a placeholder <br>
element was inserted for the selection point. However, when
pasting, the test run computes the -webkit-user-select for the
<br> element, instead of what would be the text inside the
<input> and incorrectly disallows selection and prevented
the paste.

Test: editing/pasteboard/paste-placeholder-input.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip <br> elements above us as those are likely placeholder elements.
17:49 Changeset [85817] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed marking flaky tests.

  • platform/chromium/test_expectations.txt:
17:43 Changeset [85816] by cdn@chromium.org
  • 2 edits in trunk/Tools

2011-05-04 Cris Neckar <cdn@chromium.org>

Unreviewed, Adding Cris Neckar as a committer

  • Scripts/webkitpy/common/config/committers.py:
17:43 Changeset [85815] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Windows build of WebKit GTK needs to be able to find SystemInfo.h
https://bugs.webkit.org/show_bug.cgi?id=60221

  • GNUmakefile.am: add Source/WebCore/platform/win to the paths searched for headers, since Source/WebCore/platform/win/SystemInfo.h header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp on Windows.
17:42 Changeset [85814] by vangelis@chromium.org
  • 7 edits
    5 adds in trunk

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new layout test for perpendicular layers.
https://bugs.webkit.org/show_bug.cgi?id=59255

  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/compositing/perpendicular-layer-sorting.html: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Improve sorting of layers in hierarchies that preserve-3d
by testing for overlapping regions between layer pairs and doing a
topological sort to determine the right order.
https://bugs.webkit.org/show_bug.cgi?id=59255

Test: platform/chromium/compositing/perpendicular-layer-sorting.html

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::clearRenderSurface):
  • platform/graphics/chromium/cc/CCLayerSorter.cpp: Added. (WebCore::perpProduct): (WebCore::innerProduct): (WebCore::pointInColinearEdge): (WebCore::edgeEdgeTest): (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector): (WebCore::CCLayerSorter::LayerIntersector::go): (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::checkZDiff): (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint): (WebCore::CCLayerSorter::CCLayerSorter): (WebCore::CCLayerSorter::checkOverlap): (WebCore::CCLayerSorter::createGraphNodes): (WebCore::CCLayerSorter::createGraphEdges): (WebCore::CCLayerSorter::removeEdgeFromList): (WebCore::CCLayerSorter::sort):
  • platform/graphics/chromium/cc/CCLayerSorter.h: Added. (WebCore::CCLayerSorter::GraphNode::GraphNode): (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
17:23 Changeset [85813] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Geoffrey Garen.

Port MachineStackMarker.cpp to Windows x64
https://bugs.webkit.org/show_bug.cgi?id=60216

  • heap/MachineStackMarker.cpp: (JSC::getPlatformThreadRegisters): the CONTEXT struct is usable also on 64-bit Windows. (JSC::otherThreadStackPointer): return the Rsp register on Windows x64.
17:09 Changeset [85812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Link libjavascriptcoregtk on Windows with winmm.dll
https://bugs.webkit.org/show_bug.cgi?id=60215

  • GNUmakefile.am:
17:07 Changeset [85811] by jer.noble@apple.com
  • 9 edits
    3 adds in trunk

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

  • fullscreen/full-screen-stacking-context-expected.txt: Added.
  • fullscreen/full-screen-stacking-context.html: Added.
  • platform/mac/fullscreen/full-screen-stacking-context-expected.png: Added.

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

Because a fullscreen element may be in a stacking context with a lower z-index than
a sibling stacking context, those higher contexts would sometimes "pop" through the
full screen renderer. To facilitate eliminating all the stacking contexts aside from
the full screen renderer, added a new pseudo-class specific to video or audio full
screen elements. Then, added a new UA rule which resets the z-index and opacities of
all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
identity checking of HTMLMediaElements, added isMediaElement() virtual function to
Element and HTMLMediaElement.

Test: fullscreen/full-screen-stacking-context.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument. (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument. (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
  • css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
  • css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,

which were missing the -webkit prefix.

(:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.

  • dom/Element.h: (WebCore::Element::isMediaElement): Added, returns false.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
  • rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
17:01 Changeset [85810] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Split findNextLineBreak into a LineBreaker class
https://bugs.webkit.org/show_bug.cgi?id=60209

Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
nearly no state, but subsequent patches will move some of the local variables used throughout
the nextLineBreak function into member variables to simplify breaking off helper functions from
the bloated function.

No new tests since this is just moving code around.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::LineBreaker::LineBreaker): (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor. (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto. (WebCore::RenderBlock::LineBreaker::clear): Ditto.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): (WebCore::RenderBlock::LineBreaker::reset): (WebCore::RenderBlock::LineBreaker::nextLineBreak):
16:56 Changeset [85809] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Hide the entire table if all failures are expected
https://bugs.webkit.org/show_bug.cgi?id=60225

If in a port that uses expected results and all failures are expected,
hide the table as well as the rows when hiding expected failures.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
16:49 Changeset [85808] by jeffm@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Send unhandled wheel events to parent window on Windows
https://bugs.webkit.org/show_bug.cgi?id=60220

Keep track of wheel events using NativeWebWheelEvent instead of WebWheelEvent in WebPageProxy
so we can send the native event to the parent window if WebKit doesn't handle it.

  • UIProcess/API/mac/WKView.mm: Use NativeWebWheelEvent instead of WebWheelEvent.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::wheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Removed initialization of obsolete m_processingWheelEvent member variable. (WebKit::coalesceWheelEvents): Use NativeWebWheelEvent instead of WebWheelEvent and add a note that this won't work if we ever enable MERGE_WHEEL_EVENTS. (WebKit::WebPageProxy::handleWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent, keep track of the current event in m_currentlyProcessedWheelEvent. (WebKit::WebPageProxy::didReceiveEvent): Call wheelEventNotHandled() on Windows if wheel event is not handled. (WebKit::WebPageProxy::processDidCrash): Clear out m_currentlyProcessedWheelEvent.
  • UIProcess/WebPageProxy.h: Change handleWheelEvent() to take a NativeWebWheelEvent, added wheelEventNotHandled() on Windows, remove m_processingWheelEvent, add m_currentlyProcessedWheelEvent.
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::wheelEventNotHandled): Added.


  • UIProcess/win/WebView.cpp: (WebKit::WebView::onWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
16:46 Changeset [85807] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: odd result order
https://bugs.webkit.org/show_bug.cgi?id=60193

This test uses setTimeout to check that the result property of
asynchronous requests persists into the setTimeout callback.

  • storage/indexeddb/mozilla/odd-result-order-expected.txt: Added.
  • storage/indexeddb/mozilla/odd-result-order.html: Added.
16:42 Changeset [85806] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add bundle API for making a page paint as the background of another page
https://bugs.webkit.org/show_bug.cgi?id=60227

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetUnderlayPage): Call WebPage::setUnderlayPage.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Null out the underlay page.

(WebKit::WebPage::layoutIfNeeded):
Layout the underlay page if necessary.

(WebKit::WebPage::drawRect):
Draw the underlay page.

16:36 Changeset [85805] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium/test_expectations.txt:
16:34 Changeset [85804] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-04 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added error check for _ewk_init_body result.
https://bugs.webkit.org/show_bug.cgi?id=60149

The ewk_init function should be failed when _ewk_init_body function
return false.

  • ewk/ewk_main.cpp: (ewk_init):
16:26 Changeset [85803] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

  • WebProcess.pro: Add Symbian OS capabilities to web process executable. Also enable data paging flag and prevent application's icon from showing up in the application grid.

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

  • MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.
16:22 Changeset [85802] by eric@webkit.org
  • 8 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The testing EWS bots should upload layout-test-results.zip to bugs after failures
https://bugs.webkit.org/show_bug.cgi?id=60223

This required sharing a bit of code between the commit-queue
(which already knew how to do this) and the new EWS testing bots.

In the process I also cleaned up EWS testing a little and
removed some dead code from the commit-queue.

  • Scripts/webkitpy/common/config/committervalidator.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
16:08 Changeset [85801] by japhet@chromium.org
  • 3 edits in branches/chromium/742/Source/WebKit/chromium

2011-05-04 Nate Chapin <japhet@chromium.org>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
15:55 Changeset [85800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Adam Barth.

Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
https://bugs.webkit.org/show_bug.cgi?id=58579

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::error):
15:54 Changeset [85799] by alexis.menard@openbossa.org
  • 8 edits in trunk/Source

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just unused.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

  • dom/Node.cpp: (WebCore::Node::removeEventListener):
  • platform/DateComponents.cpp: (WebCore::DateComponents::parseTime):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords):
  • storage/StorageMap.cpp: (WebCore::StorageMap::importItem):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
15:50 Changeset [85798] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] put flaky tests into their own table
https://bugs.webkit.org/show_bug.cgi?id=60214

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
15:45 Changeset [85797] by koz@chromium.org
  • 6 edits in trunk/Tools

2011-05-04 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Add method to make a Port able to retrieve TestOutputSets from its builders.
https://bugs.webkit.org/show_bug.cgi?id=58211

This will be used in the new rebaseline script - TestOutputs are
potential new baselines.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
15:44 Changeset [85796] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] fix apply options on page load
https://bugs.webkit.org/show_bug.cgi?id=60217

This broke when we started storing options in localstorage.
Also fixes regressions exposed by fixing this.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
15:32 Changeset [85795] by aroben@apple.com
  • 13 edits in trunk/Source/WebKit2

Clip and reposition windowed plugins when the UI process paints

This ensures that their geometry updates in sync with the rest of the page.

Most of this patch is just plumbing the scheduleWindowedPluginGeometryUpdate and
scheduleChildWindowGeometryUpdate calls through from NetscapePlugin all the way over to
WebView. I've tried to call out the other parts below.

Fixes <http://webkit.org/b/60210> <rdar://problem/8483441> REGRESSION (WebKit2): Windowed
plugins don't scroll at the same speed as the rest of the page

Reviewed by Darin Adler and Anders Carlsson.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
Added plumbing.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Update child windows before painting so that they will stay
in sync with the rest of the page.
(WebKit::WebView::scheduleChildWindowGeometryUpdate): Add this update information to the
set of geometries to update on the next paint.
(WebKit::setWindowRegion): Moved this helper function here from NetscapePluginWin.cpp.
(WebKit::WebView::updateChildWindowGeometries): Update the size, position, and clip rects of
all the child windows with scheduled geometry updates.

  • UIProcess/win/WebView.h: Added new members to track and update child window geometries.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPostInitialize): Don't show the window immediately. Let the
UI process take care of it.
(WebKit::NetscapePlugin::platformGeometryDidChange): Don't update the window's position or
clip rect. Let the UI process take care of it.

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Added plumbing.

15:20 Changeset [85794] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:]
https://bugs.webkit.org/show_bug.cgi?id=52009
<rdar://problem/8829746>

Add and implement WKViewSetDrawsTransparentBackground on windows.

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetDrawsTransparentBackground): (WKViewDrawsTransparentBackground): Call through to the WebPageProxy object.
  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebView.cpp: (WebKit::drawPageBackground): Don't fill the rect with white if WebPageProxy::drawsBackground() or WebPageProxy::drawsTransparentBackground() returns false. Because of limitations in Win32, both drawsBackground and drawsTransparentBackground are pretty much equivalent.

(WebKit::WebView::paint):
Pass the WebPageProxy object to drawPageBackground.

15:08 Changeset [85793] by mrobinson@webkit.org
  • 2 edits in trunk

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Fix the WebKitGTK+ build.

  • configure.ac: Added option parsing code for loading touch icons.
15:02 Changeset [85792] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

sheriff-bot can't parse results.html
https://bugs.webkit.org/show_bug.cgi?id=60196

The problem was that the NRWT bots are currently core
and so sheriff-bot was trying to diagnose failures on
them. It was trying to parse their results.html file
and BeautifulSoup was throwing an exception.

It seems our version of BeautifulSoup was quite old
and unable to handle <script> tags correctly.
This moves us to 3.2 which doesn't seem to have this bug.

  • Scripts/webkitpy/thirdparty/BeautifulSoup.py:
14:52 Changeset [85791] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::lastChildConsideringContinuation):
14:46 Changeset [85790] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Dimitri Glazkov <dglazkov@chromium.org>

Sort xcodeproj files.

The WebCore.xcodeproj got out of sorts again.

  • WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
14:42 Changeset [85789] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Adam Barth.

Warning fix.

  • bindings/js/DOMObjectHashTableMap.h: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
14:32 Changeset [85788] by rwlbuis@webkit.org
  • 3 edits
    8 adds in trunk

2011-05-04 Rob Buis <rbuis@rim.com>

Reviewed by Darin Adler.

NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
14:32 Changeset [85787] by japhet@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-04 Nate Chapin <japhet@chromium.org>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
14:12 Changeset [85786] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS test logging less verbose
https://bugs.webkit.org/show_bug.cgi?id=60201

This should help us generate less than a hundred MB of logs per hour.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
14:02 Changeset [85785] by commit-queue@webkit.org
  • 55 edits
    2 adds in trunk

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

  • Configurations/FeatureDefines.xcconfig:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Parsed and populated apple-touch-icon url to FrameLoaderClient.
Changed favicon to be a type of icon.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::iconURL): (WebCore::Document::setIconURL):
  • dom/Document.h:
  • dom/IconURL.cpp: Added. (WebCore::toIconIndex):
  • dom/IconURL.h: Added. (WebCore::IconURL::IconURL):
  • features.pri:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isEnabledViaScript):
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconURL): (WebCore::DocumentLoader::setIconURL):
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): (WebCore::FrameLoader::getDefaultIconURL): (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/FrameLoaderClientImpl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidChangeIcons):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.
Added WebIconURL and WebIconType responding the new IconURL and IconType.
Supported to get the multiple icon urls.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Disable touch icon by default.

  • Scripts/build-webkit:
13:40 Changeset [85784] by luiz@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed build fix.

Skipping test http/tests/navigation/response204.html for Mac, Win and GTK.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
13:33 Changeset [85783] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Can't save a link from "Save Linked File to Download" popup menu
https://bugs.webkit.org/show_bug.cgi?id=60190
<rdar://problem/9367927>

Make sure that suggestedFilenameForResourceWithURL and resourceDataForFrame both look
in the cache if the resource can't be found in the current web page. This matches WebKit1.

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::suggestedFilenameForResourceWithURL): Call WebPage::cachedSuggestedFilenameForURL if we can't find a resource in the page.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::resourceDataForFrame): Move code out from getResourceDataFromFrame.

(WebKit::WebPage::getResourceDataFromFrame):
Call resourceDataForFrame first and then cachedResponseDataForURL.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

  • WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.


  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

13:26 Changeset [85782] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update bug numbers in media related test cases.
https://bugs.webkit.org/show_bug.cgi?id=60078

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
13:17 Changeset [85781] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
https://bugs.webkit.org/show_bug.cgi?id=60191

Skip replaceSublayer when there is no superlayer rather than asserting.
This is probably not a problem and happens when restructuring the layer
tree. Avoiding this crash will allow us to get more testing.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
13:08 Changeset [85780] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2011-05-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

WebKit2 flashes if entering and exiting compositing rapidly
https://bugs.webkit.org/show_bug.cgi?id=60198

If a page enters then immediately leaves compositing mode, the
DrawingAreaImpl would send a message to the UI process that it
had entered compositing even after all the layers had been torn
down. Fix this by never sending the 'enter' message if we're
waiting for the 'exit' timer to fire.

Also fix an assertion in the UI process caused by sending mismatched
'enter' and 'leave' messages by keeping track of which messages
we've sent.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::layerHostDidFlushLayers): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
  • WebProcess/WebPage/DrawingAreaImpl.h: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModePending):
12:37 Changeset [85779] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081

Add another test for the shadow dom to the Windows Skipped list to get the bots green.

  • platform/win/Skipped:
12:26 Changeset [85778] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Don't show actual failure type column for ports that don't use expectations files
https://bugs.webkit.org/show_bug.cgi?id=60199

For the most part, the links shown tell you what type of failure it is.
The only case where we lose some information here is for a test that
failed one run, but passed or had a different failure on retry.i
We should probably put those tests in their own table anyways.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
12:20 Changeset [85777] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

2011-05-04 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Add gpu acceleration flags to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=60168
Adding support for command line flags
enable-accelerated-2d-canvas an
enable-accelerated-drawing in DumpRenderTree.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setLegacyAccelerated2dCanvasEnabled): (TestShell::setAcceleratedDrawingEnabled):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
12:19 Changeset [85776] by ademar.reis@openbossa.org
  • 2 edits in trunk/Tools

2011-05-04 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] run-qtwebkit-tests misses exec bit
https://bugs.webkit.org/show_bug.cgi?id=60188

Also removing an unecessary import (mostly to let this bugfix goes
through the system, as this is just a chmod).

  • Scripts/run-qtwebkit-tests:
12:07 Changeset [85775] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipped inspector/elements/shadow-dom.html on win.
https://bugs.webkit.org/show_bug.cgi?id=60195

  • platform/win/Skipped:
12:04 Changeset [85774] by luiz@webkit.org
  • 4 edits
    4 adds in trunk

[Qt] Qt WebKit updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=42529

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Ignoring http responses which have status code equal to 204 (No Content)
or 205 (Reset Content).

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

LayoutTests:

Responses which have status code equal to 204 should be ignored.

  • http/tests/navigation/response204-expected.txt: Added.
  • http/tests/navigation/response204.html: Added.
  • http/tests/navigation/resources/response204.pl: Added.
12:01 Changeset [85773] by mrobinson@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
method, just use extern declarations to avoid having to declare it in the header.
This will prevent having to include glib.h in RenderThemeGtk.h, which is included
in many C++ files.

No new tests. This is just a build fix.

  • platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
  • platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and gtkEntry() public because they are now accessed externally from getStockIcon().
  • platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls. (WebCore::getStockIconForWidgetType):
  • platform/gtk/RenderThemeGtk3.cpp: Ditto. (WebCore::getStockIconForWidgetType):
12:00 Changeset [85772] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Fix signals emitted in FakeReply used in autotests
https://bugs.webkit.org/show_bug.cgi?id=60049

The signals emitted for each case of FakeReply were swapped (error case
emitting metaDataChanged() and redirect case emitting error()). Emitting
readyRead() is not necessary.

  • tests/qwebframe/tst_qwebframe.cpp: (FakeReply::FakeReply): Choose the different continue function for each case of FakeReply. This removes the need of the if-statement in timeout() and let us replace timeout() with two simpler functions.

(FakeReply::continueRedirect):
(FakeReply::continueError):
Continuation cases, emitting the minimal set of signals needed for each case.

11:56 Changeset [85771] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9366557> Various crashes due to bad DFG codegen at canalplus.fr

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes): Removed a stray line of
code that accidentally survived the conversion to a switch statement,
causing a lot of important code not to run most of the time.

Since this is not a trivial finger-picking mistake, I will not call it a
typo.

LayoutTests:

  • fast/js/trivial-functions-expected.txt: Added.
  • fast/js/trivial-functions.html: Added.
11:55 Changeset [85770] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

  • storage/indexeddb/mozilla/open-database-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/open-database-null-name.html: Added.

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

Test: storage/indexeddb/mozilla/open-database-null-name.html

Combination problem: Bug in IDL didn't pass null values to .cpp layer,
then .cpp layer didn't check for null value anyway.

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open): check for null name
  • storage/IDBFactory.idl: pass null name as null
11:50 Changeset [85769] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Improve styling on the toolbar. Make the background opaque.

  • fast/harness/results.html:
11:49 Changeset [85768] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Fix import of ircproxy module to actually import the module. I don't
really understand how this code could have worked before.

  • Scripts/webkitpy/common/host.py:
11:39 Changeset [85767] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Entering full screen fails >= second time on Vimeo.com.
https://bugs.webkit.org/show_bug.cgi?id=60143

Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
at the end of an animation, if it determined that the RenderFullScreen would still require
a layer even when not animating.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Clear the renderer's layer.
11:24 Changeset [85766] by hclam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations for Linux.

  • platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
  • platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
11:22 Changeset [85765] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

  • inspector/elements/shadow-dom-expected.txt:
  • inspector/elements/shadow-dom.html:
11:03 Changeset [85764] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in svn property in r85756.

  • Shared/mac/NativeWebWheelEventMac.mm: Added property svn:eol-style. Removed property snv:eol-style.
11:02 Changeset [85763] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Andreas Kling.

[Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=60172

  • MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser (BrowserWindow::BrowserWindow):
11:00 Changeset [85762] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Part 2 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Reviewed by Adam Barth.

  • Configurations/Base.xcconfig:

(GCC_TREAT_WARNINGS_AS_ERRORS): Set to YES.

11:00 Changeset [85761] by ddkilzer@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Part 1 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Merge ANGLE upstream commits r572, r573, r574, r575.

This unblocks enabling -Werror on ANGLE. Since all changes are
in the upstream repository, they may be safely overwritten
during the next ANGLE update.

  • src/compiler/ConstantUnion.h:

(ConstantUnion::operator==): Added a default case.

  • src/compiler/Intermediate.cpp:

(TIntermBinary::promote): Added parentheses.

  • src/compiler/ParseHelper.cpp:

(TParseContext::precisionErrorCheck): Added a default case.

  • src/compiler/PoolAlloc.cpp:

(TAllocation::checkGuardBlock): Changed '%u' to '%lu' for size_t
variable. Put for loop inside #ifdef GUARD_BLOCKS/#endif macros
to fix tautological-compare warning.
(TAllocation::checkAllocList): Added newline to end of file.

10:50 Changeset [85760] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
https://bugs.webkit.org/show_bug.cgi?id=59849

When attempting to unwind the graphics state stack in the
CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
to create a new ImageBuffer.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::existingDrawingContext):
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
10:47 Changeset [85759] by jcivelli@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Ojan Vafai.

Send the char events to the select popup if one is showing to fix
a bug were pressing a letter would not select the matching option.
https://bugs.webkit.org/show_bug.cgi?id=47769

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
  • src/WebViewImpl.h:
10:46 Changeset [85758] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

  • inspector/elements/shadow-dom-expected.txt:
  • inspector/elements/shadow-dom.html:
10:37 Changeset [85757] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] bucket crashes/timeouts into their own test lists
https://bugs.webkit.org/show_bug.cgi?id=60181

Also, don't show the "expected to fail but passed" table for ports
that don't use an expectation file.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
10:29 Changeset [85756] by jeffm@apple.com
  • 5 edits
    5 adds in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add NativeWebWheelEvent class
https://bugs.webkit.org/show_bug.cgi?id=60182


This will be needed soon when we start notifying the UI process that a mouse wheel event wasn't handled by WebKit.

  • GNUmakefile.am: Added NativeWebWheelEventGtk.cpp and NativeWebWheelEvent.h.
  • Shared/NativeWebWheelEvent.h: Added. (WebKit::NativeWebWheelEvent::nativeEvent): Added.
  • Shared/gtk/NativeWebWheelEventGtk.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/mac/NativeWebWheelEventMac.mm: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/qt/NativeWebWheelEventQt.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/win/NativeWebWheelEventWin.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):Added.
  • WebKit2.pro: Added NativeWebWheelEventQt.cpp and NativeWebWheelEvent.h.
  • WebKit2.xcodeproj/project.pbxproj: Added NativeWebWheelEventMac.mm and NativeWebWheelEvent.h.
  • win/WebKit2.vcproj: Added NativeWebWheelEventWin.cpp and NativeWebWheelEvent.h.
09:59 Changeset [85755] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Anders Carlsson.

ArgumentDecoder should use aligned memory for its internal copy of data
https://bugs.webkit.org/show_bug.cgi?id=59960

Since we check for memory alignment when unpacking primitive types from the buffer,
insure alignment of the base address.
As uint64_t is the largest type we use in Argument encoder/decoder, use 8 byte alignment.

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::~ArgumentDecoder): free m_alignedBase (CoreIPC::roundUpToAlignment): move this up in the source file (CoreIPC::ArgumentDecoder::initialize): m_buffer is now guaranteed sizeof(uint64_t) aligned
  • Platform/CoreIPC/ArgumentDecoder.h: add m_alignedBase member which needs to be freed in d'tor
09:58 Changeset [85754] by aroben@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Make ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible

Fixes <http://webkit.org/b/57269> <rdar://problem/9198788> REGRESSION (r82151): Every WKView
paint now makes an extra copy of the painted bits

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h:
  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::createCopyOnWriteCopy):
Added this new function. Creates a copy-on-write copy of the first |size| bytes of the
original SharedMemory.

  • Shared/ShareableBitmap.h: Added createCGImage helper function.
  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::makeCGImageCopy): Don't compile this version of this function on
Windows; we'll provide our own implementation since CGBitmapContextCreateImage isn't smart
enough to make a copy-on-write copy on Windows.
(WebKit::ShareableBitmap::makeCGImage): Moved some code from here...
(WebKit::ShareableBitmap::createCGImage): ...to this new function.

  • Shared/cg/win/ShareableBitmapCGWin.cpp: Added.

(WebKit::derefSharedMemory): This function is called when the CGDataProvider is finalized.
All we have to do is deref the SharedMemory that was backing the CGDataProvider.
(WebKit::ShareableBitmap::makeCGImageCopy): Create a copy-on-write copy of the image data
when possible. We use the copy-on-write copy to back this ShareableBitmap from here on out,
and use the original SharedMemory to back the CGImage. This should prevent future
modifications to the ShareableBitmap from affecting the CGImage. If we can't make a
copy-on-write copy, we fall back to just copying the data normally.

  • win/WebKit2.vcproj: Added ShareableBitmapCGWin.cpp.
09:53 Changeset [85753] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Let transparent windowless plugins draw into a graphics context with an alpha channel

Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows

I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.

09:28 Changeset [85752] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Attempt to resolve flakiness on windows.

  • inspector/elements/shadow-dom.html:
08:07 Changeset [85751] by caseq@chromium.org
  • 12 edits
    2 adds in trunk

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

Test: inspector/elements/shadow-dom.html

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::isContainerNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype.inShadowTree): (WebInspector.DOMNode.prototype._setShadowRootPayload): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMAgent.prototype._shadowRootUpdated): (WebInspector.DOMDispatcher.prototype.searchResults): (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._nodeUpdated): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css: (#elements-content .dom-shadow-root): (.outline-disclosure li .webkit-html-tag.shadow):
  • inspector/front-end/utilities.js:

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId):
  • inspector/elements/shadow-dom-expected.txt: Added.
  • inspector/elements/shadow-dom.html: Added.
07:55 Changeset [85750] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=60164

Use Array#length to get the number of elements in an array. Array#count
was added in Ruby 1.8.7, but Leopard have Ruby 1.8.6.

  • PrettyPatch/PrettyPatch.rb:
07:31 Changeset [85749] by aroben@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Another attempted build fix

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added a return statement. And made a tweak based on a suggestion from Anders Carlsson.

07:25 Changeset [85748] by aroben@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix Leopard, Qt, and probably others

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Try to get the compiler not to instantiate these function templates unnecessarily.

07:25 Changeset [85747] by ademar.reis@openbossa.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed: Adding myself to the committers' list.

07:11 Changeset [85746] by aroben@apple.com
  • 8 edits in trunk/Source

Disallow equality comparisons between [Pass]OwnPtrs

If you have two OwnPtrs that are equal, you've already lost. (Unless you're doing something
really sneaky, in which case you should stop!)

Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error

Reviewed by Anders Carlsson and Antti Koivisto.

Source/JavaScriptCore:

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added private equality operators that fail to compile when used. (When not used, the
compiler will skip over them because they are function templates.)

Source/WebCore:

Remove an unnecessary OwnPtr equality check in XSLT code

  • dom/Document.cpp:

(WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
we're safe.)

Source/WebKit2:

Remove WebPageProxy::setDrawingArea

It is unused. It also does a useless equality comparison between OwnPtrs; if they are equal,
we've already lost.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

Removed setDrawingArea.

(WebKit::WebPageProxy::drawingArea):
(WebKit::WebPageProxy::backForwardList):
Made these functions const while I was at it.

06:57 Changeset [85745] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk/Source/WebCore

2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
https://bugs.webkit.org/show_bug.cgi?id=56922

Add the basic outlines of the page controller, the per-frame controller and the embedder
client interface for the Media Stream API. Provide methods to handle the situations
where a frame is detached from the page or transferred between pages.

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Frame.h: (WebCore::Frame::mediaStreamFrameController):
  • page/MediaStreamClient.h: Added. (WebCore::MediaStreamClient::~MediaStreamClient):
  • page/MediaStreamController.cpp: Added. (WebCore::MediaStreamController::Request::Request): (WebCore::MediaStreamController::Request::localId): (WebCore::MediaStreamController::Request::frameController): (WebCore::MediaStreamController::MediaStreamController): (WebCore::MediaStreamController::~MediaStreamController): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest):
  • page/MediaStreamController.h: Added.
  • page/MediaStreamFrameController.cpp: Added. (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::Request::~Request): (WebCore::MediaStreamFrameController::Request::scriptExecutionContext): (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest): (WebCore::MediaStreamFrameController::RequestMap::abort): (WebCore::MediaStreamFrameController::RequestMap::abortAll): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::~MediaStreamFrameController): (WebCore::MediaStreamFrameController::securityOrigin): (WebCore::MediaStreamFrameController::scriptExecutionContext): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::disconnectPage): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::transferToNewPage):
  • page/MediaStreamFrameController.h: Added.
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
  • page/Page.h: (WebCore::Page::mediaStreamController):
06:48 Changeset [85744] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
https://bugs.webkit.org/show_bug.cgi?id=60150

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
06:46 Changeset [85743] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

  • platform/qt/Skipped: Unskip http/tests/websocket/tests.
06:36 Changeset [85742] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Dominic Battre <battre@chromium.org>

Reviewed by Tony Gentilcore.

Fix missing header in case SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=60153

  • dom/EventDispatcher.cpp:
06:26 WebKit Team edited by ademar.reis@openbossa.org
(diff)
06:25 Changeset [85741] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Initialize viewport argument in ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=60147

viewport computation logic can't be worked correctly because viewport argument
isn't initialized. So, we need to initialize viewport argument.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
06:18 Changeset [85740] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip fast/dom/Geolocation/argument-types.html crashing
on GTK.

[GTK] fast/dom/Geolocation/argument-types.html flaky crash on 32-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=60158

  • platform/gtk/Skipped:
06:14 Changeset [85739] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: readyState
https://bugs.webkit.org/show_bug.cgi?id=60069

Checks the value of the request.readyState property during and
after opening a database, setting the version, creating a datastore,
adding a record, and retrieving a record.

  • storage/indexeddb/mozilla/readyState-expected.txt: Added.
  • storage/indexeddb/mozilla/readyState.html: Added.
06:06 Changeset [85738] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
https://bugs.webkit.org/show_bug.cgi?id=60006

No new tests as no functionality added. Simple rename only.

  • css/CSSStyleApplyProperty.cpp: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
  • css/CSSStyleApplyProperty.h: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
06:03 Changeset [85737] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Cleanup conditionals in findNextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=60117

Simplified conditional statements in findNextLineBreak.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
05:44 Changeset [85736] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60114

No new tests as no functionality changes.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
05:39 Changeset [85735] by mihaip@chromium.org
  • 11 edits in trunk/Tools

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
https://bugs.webkit.org/show_bug.cgi?id=60088

Makes --new-baseline put new baselines into the first entry in the
baseline search path, including any additional directories passed in via
--additional-platform-directory.

Simplifies baseline_path() by making it return the first entry in the
baseline search path instead of requiring each port to have an
implementation (should not result in any behavior change).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
05:24 Changeset [85734] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070

Applications using our API and our autotests subclass QNetworkReply as part of providing a
custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.

The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
indicating that it is finished. When there's no finished signal (synchronous) we set the
dynamic property once we get the reply.

This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): Connect the finished signal to the new setFinished() slot.

(WebCore::QNetworkReplyWrapper::synchronousLoad):
Since we don't get the finished signal for synchronous loads, set the dynamic property
before processing it.

(WebCore::QNetworkReplyWrapper::resetConnections):
Do not reset the connection to setFinished().

(WebCore::QNetworkReplyWrapper::setFinished):
Set the dynamic property in the reply.

(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::start):
Change to use wrapper's isFinished() instead of asking the reply directly.

  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyWrapper::isFinished): Checks the dynamic property of the reply.
  • platform/network/qt/QtMIMETypeSniffer.cpp: (QtMIMETypeSniffer::sniff): Use the dynamic property to check if the reply is finished.
04:58 Changeset [85733] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r85669.

  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
04:51 Changeset [85732] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
https://bugs.webkit.org/show_bug.cgi?id=60080

No functional change, just moving code.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxesFromBidiRuns): (WebCore::RenderBlock::layoutRunsAndFloats):
04:42 Changeset [85731] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove unused function FontPlatformData::pixelSize()
https://bugs.webkit.org/show_bug.cgi?id=60156

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::pixelSize): Removed.
04:35 Changeset [85730] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=60011

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove reundant check for auto table layout.
04:34 Changeset [85729] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Gavin Barraclough.

JITArithmetic.cpp produces a warning on a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=60060

Just properly use what we already have converted.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):
04:08 Changeset [85728] by mihaip@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.

Remove double-free checks for bug 56124
https://bugs.webkit.org/show_bug.cgi?id=60037

Antti's speculative fix for bug 56124 (r84151) appears to have worked,
these CRASH() calls are not triggering anymore.

  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector):
  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):
03:44 Changeset [85727] by abarth@webkit.org
  • 12 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix circular dependency in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=60075

These functions don't belong in bugzilla.py. They only exist there
because they are old. Really, these functions shouldn't be free
functions at all, but that's a patch for another day.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/bugzilla/init.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/upload.py:
02:41 Changeset [85726] by satish@chromium.org
  • 6 edits in trunk

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
01:33 Changeset [85725] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Geoffrey Garen.

JITPropertyAccess produces a unused but set variable warning in gcc 4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=60050

This patch fix a compilation warning. The new warning scenario -Wunused-but-set-variable
in gcc 4.6.0 is included in -Wall and therefore stops the compilation when warnings are treated
as errors. The patch introduces a new macro ASSERT_JIT_OFFSET_UNUSED and ASSERT_WITH_MESSAGE_UNUSED
which copy the idea of ASSERT_UNUSED.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
  • wtf/Assertions.h: (assertWithMessageUnused):
00:03 Changeset [85724] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix.

  • bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
00:00 Changeset [85723] by psolanki@apple.com
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=60141 Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit

Reviewed by Dan Bernstein.

  • Scripts/build-webkit:
Note: See TracTimeline for information about the timeline view.