Timeline


and

05/11/11:

23:00 Changeset [86313] by commit-queue@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-11 Srinivasulu Chereddy <Srinivasulu.Chereddy@nokia.com>

Reviewed by Eric Seidel.

[Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list
https://bugs.webkit.org/show_bug.cgi?id=60654

  • platform/qt/Skipped:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added.
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt/transforms/svg-vs-css-expected.png: Added.
  • platform/qt/transforms/svg-vs-css-expected.txt: Added.
22:45 Changeset [86312] by leviw@chromium.org
  • 5 edits in trunk/Source

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

No new tests as this is a simple rename

  • page/FrameView.cpp: (WebCore::FrameView::create):
  • platform/Widget.h: (WebCore::Widget::location): (WebCore::Widget::resize):

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
22:40 Changeset [86311] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

  • editing/pasteboard/paste-removing-iframe-expected.txt: Added.
  • editing/pasteboard/paste-removing-iframe.html: Added.
  • editing/pasteboard/resources/paste-removing-iframe-child.html: Added.

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

Added missing null check.

Test: editing/pasteboard/paste-removing-iframe.html

  • editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection):
22:35 Changeset [86310] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Brian Salomon <bsalomon@google.com>

Reviewed by Eric Seidel.

Handle case when GrContext creation fails
https://bugs.webkit.org/show_bug.cgi?id=60410

Exercised by all canvas tests when DRT is run with skia-gpu

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext):
22:31 Changeset [86309] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Pratik Solanki <psolanki@apple.com>

Reviewed by Andreas Kling.

Remove empty class CallbackGuard
https://bugs.webkit.org/show_bug.cgi?id=60610

CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
22:13 Changeset [86308] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60609

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations.
22:09 Changeset [86307] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2011-05-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Some elements in meter-styles.html are hiding its content part with non-content-area.
https://bugs.webkit.org/show_bug.cgi?id=58149

  • Resized the border and padding values
  • Gave "-webkit-appearance: none" to test that is intended to be painted using shadows.
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
21:48 Changeset [86306] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement more clipping functions for wxWebKit.

https://bugs.webkit.org/show_bug.cgi?id=60662

20:55 Changeset [86305] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • WebCore.exp.in: Export restoreScrollPositionAndViewState()

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
20:38 Changeset [86304] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-11 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

WebKit does not build with GCCE
https://bugs.webkit.org/show_bug.cgi?id=60667

Allow compile WebKit with GCCE

  • wtf/Alignment.h:
  • wtf/Platform.h:
20:17 Changeset [86303] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFillLayer and its progeny to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60596

Changing integers passed into paintFillLayer and other derivatives to IntRects
and IntSizes that reflect their function.

No new tests since this is just refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
19:53 Changeset [86302] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable strict PassOwnPtr on Mac
https://bugs.webkit.org/show_bug.cgi?id=60684

This should build cleanly now.

  • wtf/PassOwnPtr.h:
19:16 Changeset [86301] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Use mapTexSubImage2D for tile uploads if available
https://bugs.webkit.org/show_bug.cgi?id=60008

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
  • platform/graphics/chromium/LayerTilerChromium.h:
18:26 Changeset [86300] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Protect JSC from WebCore executing JS during JS wrapper finalization
https://bugs.webkit.org/show_bug.cgi?id=60672
<rdar://problem/9350997>

Detect when we're trying to execute JS during GC and prevent the
execution from happening. We also assert that this isn't happening
as it implies incorrect behaviour of an object's destructor.

  • JavaScriptCore.exp:
  • heap/Heap.cpp:
  • heap/Heap.h: (JSC::Heap::isBusy):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy):
18:20 Changeset [86299] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implements a disable appearance for Media Elements of Qt port.
https://bugs.webkit.org/show_bug.cgi?id=60561

Implements a disable appearance for the media controls of the Qt port
when the media is not yet available.

  • platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb):
18:18 Changeset [86298] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

  • fast/forms/resources/ValidityState-typeMismatch-email.js:
  • fast/forms/ValidityState-typeMismatch-email-expected.txt:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

Follow the updated specification.

  • html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
18:11 Changeset [86297] by cdn@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Cris Neckar <cdn@chromium.org>

Reviewed by David Levin.

Adding Cris Neckar to the Webkit Security Group site.
https://bugs.webkit.org/show_bug.cgi?id=60668

  • security/security-group-members.html:
17:58 Changeset [86296] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

WebKit2 doesn't build on Mac with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60655

  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership.
17:54 Changeset [86295] by jpu@apple.com
  • 19 edits
    3 adds in trunk

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

See WebCore/ChangeLog for detail.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

This patch intends to alleviate the issue of repetitively applying the same autocorrection
when user delete and retype the same word at the same location. This scenario is especially
common when autocorrection modifies the first letter of the word.

This patch consists following major changes:

  1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that precedes a deleted autocorrection. If the user later types the same original word at after this whitespace, the autocorrection will not be applied again.
  2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the autocorrection that has just been deleted.
  3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress autocorrection when necessary.
  4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text after the whitespace.

Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html

  • dom/DocumentMarker.h: Added new marker type DeletedAutocorrection. (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting

the original string if we are deleting an autocorrection.

(WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.

  • editing/DeleteSelectionCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining

when to suppress an autocorrection into SpellingCorrectionController.

(WebCore::Editor::deletedAutocorrectionAtPosition):

  • editing/Editor.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition): (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  • editing/visible_units.cpp: (WebCore::isStartOfWord):
  • editing/visible_units.h:
  • manual-tests/autocorrection/spell-checking-after-reversion.html:
17:49 Changeset [86294] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Enable gc mark validation in temporarily in release builds
https://bugs.webkit.org/show_bug.cgi?id=60678

Make it easier to turn the gc mark validation on and off, and
temporarily turn it on for all builds.

  • heap/MarkStack.cpp:
  • heap/MarkStack.h: (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
  • runtime/WriteBarrier.h: (JSC::MarkStack::appendValues):
  • wtf/Platform.h:
17:45 Changeset [86293] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com
https://bugs.webkit.org/show_bug.cgi?id=60677

Reviewed by Darin Adler.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
animation, if the new scroll offset computed here is different from the current scroll offset.

17:39 Changeset [86292] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Add test cases and update the result.

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Fixes a bug that patternMismatch returns a wrong result if

  • a whole value matches to a pattern,
  • a sub-string of the value also matches to the pattern, and
  • the sub-string matching has priority.
  • html/BaseTextInputType.cpp: (WebCore::BaseTextInputType::patternMismatch): Enclose the specified pattern with ( and )$.
17:29 Changeset [86291] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Prevented DOMFileSystemBase from imposing file naming restrictions on
external file systems.

https://bugs.webkit.org/show_bug.cgi?id=60583

There are no new tests for this change since it requires the presence
of external file system provider which is specific to the platform host
process. Chromium implementation will test this within its extension API
test suite.

  • fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):
17:28 Changeset [86290] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
  • loader/ResourceLoadScheduler.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
17:17 Changeset [86289] by jcivelli@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-05-11 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding a Content-Type parser. This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=60637

(WebCore::ScriptController::disableEval):

  • platform/network/ContentTypeParser.cpp: Added.
  • platform/network/ContentTypeParser.h: Added.
17:04 Changeset [86288] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Teach validate-committer-lists how to validate committers bugzilla_email()
https://bugs.webkit.org/show_bug.cgi?id=60651

It turns out we currently have 9 committers with invalid values for their
bugzilla_email field (meaning we don't know what email is their bugzilla account).
"Alexander Kellett" <lypanov@mac.com>
"Andre Boule" <aboule@apple.com>
"Cameron McCormack" <cam@webkit.org>
"Chris Petersen" <cpetersen@apple.com>
"Eli Fidler" <eli@staikos.net>
"Matt Lilek" <webkit@mattlilek.com>
"Pierre d'Herbemont" <pdherbemont@free.fr>
"Scott Violet" <sky@chromium.org>
"Adam Treat" <treat@kde.org>

Most of those haven't committed in a very long time, so it's not suprising
that we haven't noticed that their bugzilla emails are bogus.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
16:52 Changeset [86287] by levin@chromium.org
  • 16 edits
    1 add in trunk

https://bugs.webkit.org/show_bug.cgi?id=59561
Switch TestWebKitAPI to GTest

Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11
Reviewed by David Levin.

Fixes Makefiles and WinCairo build as well

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:
  • Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
  • Source/ThirdParty/gtest/xcode/Makefile: Added.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Makefile:
  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

16:52 Changeset [86286] by ademar.reis@openbossa.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Mark Rowe.

Update Qt/Nokia Security contacts
https://bugs.webkit.org/show_bug.cgi?id=60650

Ademar (me) replaced Simon as the release manager and primary security
contact for QtWebKit. See:
http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html

  • security/security-group-members.html:
16:49 Changeset [86285] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Only encode the session parameter if it is valid.
(WebKit::WebProcessCreationParameters::decode):
Don't try to decode a null session data.

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
16:42 Changeset [86284] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Kilzer.

Remove wml directory from include lists
https://bugs.webkit.org/show_bug.cgi?id=60646

Remove wml dir from CMake, Autotools and qmake build systems since WML
was removed in r85256.

No new tests since no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pri:
16:28 Changeset [86283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Move EFL-specific file to CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=60642

Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
calls, since they depend on lists that now may change inside a port
like WebCore_USER_AGENT_STYLE_SHEETS.

No new tests since no change in functionality.

  • CMakeLists.txt: remove css file specific to EFL port.
  • CMakeListsEfl.txt: move file here.
16:21 Changeset [86282] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Add Luke Macpherson to committers.py as a Contributor
https://bugs.webkit.org/show_bug.cgi?id=60639

  • Scripts/webkitpy/common/config/committers.py:
16:16 Changeset [86281] by jpu@apple.com
  • 6 edits in trunk/Source

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
16:09 Changeset [86280] by inferno@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More rebaselines after r86261.

  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:58 Changeset [86279] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Return empty Favicon URL instead of default one when the frame isn't top level one
https://bugs.webkit.org/show_bug.cgi?id=60527
This issue was discovered by chromium browser test.

  • dom/Document.cpp: (WebCore::Document::setIconURL): Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): Restored original logic, the empty URL should be returned instead of default one. The client (at least chromium) may rely on the returned value to decided whether the favicon should be changed.
15:50 Changeset [86278] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need
to prevent WebGL from running too far ahead of the GPU process. The current
throttling mechanism relies on prepareTexture being called for every WebGL frame.
However, in a non-requestAnimFrame application, multiple frames might get created
before the compositor runs and calls prepareTexture on the surface.

To address this, we post a task that calls a special rate limiting GL extension on
the WebGL context after every WebGL "frame." When the compositor runs, it calls
prepareTexture as usual.

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::setIsAnimating): (WebCore::LayerRendererChromium::isAnimating):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask): (WebCore::WebGLLayerChromiumRateLimitTask::run): (WebCore::WebGLLayerChromiumRateLimitTask::cancel): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::~WebGLLayerChromium): (WebCore::WebGLLayerChromium::setTextureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::context):

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

Tell LayerRendererChromium when the requestAnimFrame-callbacks are running.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
15:44 Changeset [86277] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines after r86261.

  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
15:11 Changeset [86276] by noam.rosenthal@nokia.com
  • 19 edits in trunk/Source

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).

  1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
  2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
  3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
  • Api/qwebframe.cpp: (QWebFramePrivate::renderCompositedLayers):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::attachRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::scroll): (WebCore::TextureMapperNodeClientQt::setTextureMapper): (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect): (WebCore::TextureMapperNodeClientQt::syncRootLayer): (WebCore::TextureMapperNodeClientQt::rootNode): (WebCore::PageClientQWidget::setRootGraphicsLayer): (WebCore::PageClientQWidget::syncLayers): (WebCore::PageClientQWidget::~PageClientQWidget): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::syncLayersTimeout):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation
mechanism happens inside TextureMapper, and we interpolate right before we paint.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper): (WebCore::GraphicsLayerTextureMapper::syncCompositingState): (WebCore::GraphicsLayerTextureMapper::addAnimation): (WebCore::GraphicsLayerTextureMapper::pauseAnimation): (WebCore::GraphicsLayerTextureMapper::removeAnimation): (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired):
  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations): (WebCore::normalizedAnimationValue): (WebCore::TextureMapperNode::applyOpacityAnimation): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction): (WebCore::applyTimingFunction): (WebCore::TextureMapperNode::applyTransformAnimation): (WebCore::TextureMapperNode::applyAnimationFrame): (WebCore::TextureMapperNode::applyAnimation): (WebCore::TextureMapperNode::hasRunningOpacityAnimation): (WebCore::TextureMapperNode::hasRunningTransformAnimation): (WebCore::TextureMapperNode::syncAnimations): (WebCore::copyTimingFunction): (WebCore::copyAnimationValue): (WebCore::TextureMapperAnimation::TextureMapperAnimation):
  • platform/graphics/texmap/TextureMapperNode.h: (WebCore::TextureMapperAnimation::create):
14:58 Changeset [86275] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

No new tests as functionality is the same.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DBase):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create):
14:53 Changeset [86274] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Attempt to fix Chromium Mac build.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
14:35 Changeset [86273] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

[Qt] Extract code to set mouse event modifiers into common function
https://bugs.webkit.org/show_bug.cgi?id=60649

Consolidate code to set the keyboard modifiers for a mouse event into a common
function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount)
and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code.

No functionality was changed. So, no new tests.

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers().
14:33 Changeset [86272] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60591

Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect.

No new tests since there is no functionality change.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
14:25 Changeset [86271] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
14:18 Changeset [86270] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Frequent crashes beneath WebCore::ScriptElement::prepareScript
https://bugs.webkit.org/show_bug.cgi?id=60559

Reviewed by Eric Seidel.

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::runScript):
Add null check and explanation that we are keeping the ASSERT to help
track down the cause and produce a test.

14:17 Changeset [86269] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 5/12: Implement the new TextureMapper functions for the Qt backend.
This allow non-rectangular clipping, some stub functions, and getting a unique
id for an image.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapperQt::beginClip): (WebCore::TextureMapperQt::endClip): (WebCore::TextureMapperQt::viewportSize): (WebCore::TextureMapperQt::setGraphicsContext): (WebCore::TextureMapperQt::graphicsContext): (WebCore::TextureMapperQt::drawTexture): (WebCore::TextureMapperQt::beginPainting): (WebCore::TextureMapperQt::endPainting): (WebCore::RGBA32PremultimpliedBufferQt::beginPaint): (WebCore::uidForImage):
  • platform/graphics/qt/TextureMapperQt.h:
14:14 Changeset [86268] by noam.rosenthal@nokia.com
  • 4 edits in trunk

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
attributes.

  • Api/qwebsettings.cpp: (qt_networkAccessAllowed): (QWebSettingsPrivate::apply):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the build script to enable 3D rendering by default for Qt.

  • Scripts/build-webkit:
14:11 Changeset [86267] by bweinstein@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r86161): WKPreferences API test failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=60658

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

14:09 Changeset [86266] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 3/12: TextureMapper shouldn't depend on OpenGL, but rather only allow the GL backend when
OpenGL is present.

No new tests. This is a build fix.

  • WebCore.pri:
  • WebCore.pro:
14:06 Changeset [86265] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 2/12: Add a few functions to the TextureMapper API, allowing:

  1. an entry/exit point for painting (beginPaint/endPaint)
  2. Clipping with a matrix, since we use stencil instead of scissors
  3. Draw a texture directly with an ID
  4. Remove offset, since we're using real tiling
  5. numberOfBytes calculation for textures, for memory management

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::destroy): (WebCore::BitmapTexture::allowOfflineTextureUpload): (WebCore::BitmapTexture::bpp): (WebCore::BitmapTexture::numberOfBytes): (WebCore::TextureMapper::viewportSize): (WebCore::TextureMapper::setViewportSize): (WebCore::TextureMapper::allowPartialUpdates): (WebCore::TextureMapper::isOpenGLBacked): (WebCore::TextureMapper::setTransform): (WebCore::TextureMapper::transform): (WebCore::TextureMapper::beginPainting): (WebCore::TextureMapper::endPainting):
14:02 Changeset [86264] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 1/12: Change the TextureMapperPlatformLayer API to allow a 3D-context or a
media player to decide how to paint into the TextureMapper, rather than mandate specific
types of platform layers.

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayer.h:
13:55 Changeset [86263] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

<rdar://problem/9331651> REGRESSION: RPRVT grows by 1MB / sec @ dvd2blu.com

Reviewed by Oliver Hunt.

SunSpider reports no change.

This bug was caused by changing Structure and Executable to being GC
objects, and by a long-standing bug that would thrash the global object
between dictionary and non-dictionary states.

  • runtime/BatchedTransitionOptimizer.h:

(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): Don't
eagerly transition to dictionary -- this can cause pathological dictionary
churn, and it's not necessary, since objects know how to automatically
transition to dictionary when necessary.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Be sure to report
extra cost from compilation, because it can be quite high. This is especially
important for program code, since DOM timers can repeatedly allocate
program code without allocating any other objects.

  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect): Don't transition to the uncacheable state
if the thing we're trying to remove doesn't exist. This can happen during
compilation, since the compiler needs to ensure that no pre-existing
conflicting definitions exist for certain declarations.

13:55 Changeset [86262] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Flesh out RenderLayer's ScrollableArea implementation a little more
https://bugs.webkit.org/show_bug.cgi?id=60593

Override a few more ScrollableArea methods on RenderLayer
as a baby-step towards animating overflow div scrolling.

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::visibleContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollPosition): (WebCore::RenderLayer::minimumScrollPosition): (WebCore::RenderLayer::maximumScrollPosition): (WebCore::RenderLayer::visibleContentRect): (WebCore::RenderLayer::overhangAmount): (WebCore::RenderLayer::didCompleteRubberBand):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::shouldSuspendScrollAnimations):
13:54 Changeset [86261] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/9421781> Slider thumb draws upside-down in WebKit2
<rdar://problem/9418025> Slider thumb has odd appearance

Fix two issues drawing the slider thumb.

To fix <rdar://problem/9421781>, if we detect that we're in WebKit2
by virtual of the FrameView not having a documentView, then flip
the graphics context.

To fix <rdar://problem/9418025>, we call -drawInteriorWithFrame:inView:
rather than -drawWithFrame:inView: so that AppKit doesn't draw a section
of track behind the thumb.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
13:54 Changeset [86260] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86087 - 2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7011006

13:30 Changeset [86259] by aroben@apple.com
  • 3 edits
    2 adds in trunk

Don't notify the plugin when a targeted javascript: URL request completes

This matches Mozilla and WebKit1.

Fixes <http://webkit.org/b/60568> <rdar://problem/8610657> REGRESSION (WebKit2): Flash
plugin doesn't appear on a hanes.com page

Test: plugins/get-targeted-javascript-url.html

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest): Don't call back to the plugin if the
request had a target.

LayoutTests:

Test what happens when a plugin makes a targeted javascript: request

  • plugins/get-targeted-javascript-url-expected.txt: Added.
  • plugins/get-targeted-javascript-url.html: Added.

(startTest): Tell the plugin to make two targeted javascript: requests. One calls a function
with a return value, the other calls a function with no return value.
(finishTest): Check that both functions were called, and that we either didn't get an
NPP_URLNotify call (like in Mozilla, WebKit1, and WebKit2), or got an NPP_URLNotify call
with NPRES_DONE (like in Chrome).

13:13 Changeset [86258] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-flaky test (video-layer-crash) from
the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=60634

  • platform/chromium/test_expectations.txt:
13:10 Changeset [86257] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make mark stack validation functions do something useful in a release build
https://bugs.webkit.org/show_bug.cgi?id=60645

Turn ASSERTs into actual if(...) CRASH(); statements.

  • heap/MarkStack.cpp: (JSC::MarkStack::validateValue):
13:08 Changeset [86256] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[SnowLeopard WebKit2 Tests] fast/frames/flattening/frameset-flattening-subframesets.html
flakey.
https://bugs.webkit.org/show_bug.cgi?id=60648

Add the test to the mac-wk2 Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
12:51 Changeset [86255] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
12:36 Changeset [86254] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try once more to fix the WinCairo build.

  • platform/graphics/cairo/CairoUtilities.h: Include GraphicsTypes.h with a relative include rather than a system include.
12:28 Changeset [86253] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix copy&paste error in comment.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): the value is stored in regT2, not regT1.
12:12 Changeset [86252] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
https://bugs.webkit.org/show_bug.cgi?id=60521

First steps towards making the results JSON all hierarchical.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
12:03 Changeset [86251] by weinig@apple.com
  • 32 edits
    1 add in trunk/Source

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • Api/qwebelement.cpp:

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Proxy.cpp:
  • dom/ScriptExecutionContext.h:
  • html/HTMLFormElement.cpp:
  • html/parser/XSSFilter.cpp:
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::Console::~Console):
  • page/Console.h:
  • page/ConsoleTypes.h: Added.
  • page/ContentSecurityPolicy.cpp:
  • page/Geolocation.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp:
12:00 Changeset [86250] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Removing now unnecessary Chromium suppressions.

  • platform/chromium/test_expectations.txt:
11:38 Changeset [86249] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

WebKit2 should tell app that is unresponsive in more cases
<rdar://problem/9110151>
https://bugs.webkit.org/show_bug.cgi?id=60608

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Invoke the responsiveness time when forcing a backing store update to catch the cases of activating tabs, resizing the window, etc.
11:35 Changeset [86248] by dglazkov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r85650.
http://trac.webkit.org/changeset/85650
https://bugs.webkit.org/show_bug.cgi?id=59983

Triggers m_numNodeListCaches > 0 assert in gc-heavy sites.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
11:10 Changeset [86247] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try to fix the WinCairo build.

  • Shared/ShareableBitmap.h: Correctly include RefPtrCairo here and guard it with USE(CAIRO) instead of PLATFORM(CAIRO).
10:58 Changeset [86246] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Build fix, adding new LayoutTestController method stubs.

10:41 Changeset [86245] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Video track sometimes fails to draw.
https://bugs.webkit.org/show_bug.cgi?id=60635
<rdar://problem/9281951>

No new tests, covered by existing pixel tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a

recalculation, and media engine notification, the next time the state machine runs.

10:31 Changeset [86244] by aroben@apple.com
  • 6 edits in trunk/Source

WinCE build fixes for strict PassOwnPtr

Source/JavaScriptCore:

  • wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault): Use adoptPtr.

Source/WebCore:

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::clipBitmap):
Use nullptr instead of 0.

  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Keep LOOSE_PASS_OWN_PTR turned on for

this file until SimpleFontData::scaledFontData is dealt with on all platforms.

  • platform/text/wince/TextCodecWinCE.cpp:

(WebCore::newTextCodecWinCE): Use adoptPtr.

09:59 Changeset [86243] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

Unskip passed tests.

  • platform/qt/Skipped:

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
The value is checked at EventHandler.cpp:2527 (r86166).

Function keyTextForKeyEvent is partially implemented and can be enhanced in
a need-base.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
09:56 Changeset [86242] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Use case-insensitive comparisons when checking plugin filenames on Windows

Windows paths are nearly always case-insensitive.

I couldn't think of a good way to test this.

Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
should not

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
checking plugin filenames.

09:45 Changeset [86241] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r86228.

  • platform/qt-mac/Skipped: Add failing editing tets.
09:45 Changeset [86240] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=60631>
<rdar://problem/9420520>

Reviewed by Darin Adler.

WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation [60631]

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
Call clearPendingAPIRequestURL().

09:42 Changeset [86239] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[MIPS] Fix compilation of the MIPS JIT

Include the MIPSAssembler.h first to indirectly include
AssemblerBuffer.h before the AbstractMacroAssembler.h. This
order is used for the ARM and X86 MacroAssembler*.h.

  • assembler/MacroAssemblerMIPS.h:
09:40 Changeset [86238] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium suppressions.

  • platform/chromium/test_expectations.txt:
09:16 Changeset [86237] by aroben@apple.com
  • 6 edits in trunk/Source

Turn on strict PassOwnPtr on Windows

Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

Source/WebCore:

  • platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this

file until SimpleFontData::scaledFontData is dealt with on all platforms.

Source/WebKit2:

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:

(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.

09:06 Changeset [86236] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed update after r86230.

  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt-mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
09:05 Changeset [86235] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Some skipped editing tests actually work and just need rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=60469

Unskip some editing tests that actually work.

  • platform/qt/Skipped:
08:24 Changeset [86234] by jchaffraix@webkit.org
  • 11 edits
    9 adds in trunk

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

Tests for: XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

  • fast/xpath/xpath-result-eventlistener-crash-expected.txt: Added.
  • fast/xpath/xpath-result-eventlistener-crash.html: Added. Test that an event listener registered on an XPATH result snapshots' node does not crash. This case was already fixed prior to this change. However it is better to keep it as a regression test.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html: Added. Test that an XPath snapshot result keeps its node wrapper alive.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html: Added. Test that an XPath iterator result keeps its node wrapper alive.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html: Added. Test that other XPath result that holds nodes keeps their wrapper alive.

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

The change added a custom mark function for JSC. V8 was already properly
marking the nodes so no change were done on the V8 side.

Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
fast/xpath/xpath-result-eventlistener-crash.html
fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html

  • Android.jscbindings.mk:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added the new file to our build systems.
  • bindings/js/JSXPathResultCustom.cpp: Added. (WebCore::JSXPathResult::markChildren): Added code to mark the XPathResult snapshot's nodes.
  • xml/XPathResult.h: (WebCore::XPathResult::value): Exposed this getter so that we can mark our XPathValue.
  • xml/XPathResult.idl: Told the IDL parser that we now need a custom mark function.
08:12 Changeset [86233] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.originsWithLocalStorage.

Add two more storage tracker tests (added in r86205) to the mac-wk2 Skipped list to get the
bots green.

  • platform/mac-wk2/Skipped:
08:08 Changeset [86232] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] deadlock in gstreamer video player when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=58548

Block data flow towards the pipeline branch to remove to avoid
potential deadlocks during the PAUSED->READY transitions of the
elements to remove.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::exitFullscreen):
07:48 Changeset [86231] by jberlin@webkit.org
  • 11 edits in trunk

[WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
about the usage for both the origin overall and the database in question.
https://bugs.webkit.org/show_bug.cgi?id=60573

Reviewed by Darin Adler.

Source/WebKit2:

Add the currentOriginUsage parameter.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::exceededDatabaseQuota):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::exceededDatabaseQuota):

07:39 Changeset [86230] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Expected results for 2d-transforms new test
https://bugs.webkit.org/show_bug.cgi?id=60565

Patch by Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com> on 2011-05-11
Reviewed by Csaba Osztrogonác.

Added expected results for 1 new 2d-transforms test.

  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt/Skipped: Unskip now passing test.
07:23 Changeset [86229] by senorblanco@chromium.org
  • 2 edits in trunk/Tools

2011-05-10 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Adding myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=60587

  • Scripts/webkitpy/common/config/committers.py:
07:04 Changeset [86228] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove fixed_layout structure in ewk_view
https://bugs.webkit.org/show_bug.cgi?id=60615

Remove unnecessary fixed_layout structure. The ewk_view_fixed_layout_size_set/get()
use WebCore's functions directly.

  • ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set): (ewk_view_fixed_layout_size_get):
05:19 Changeset [86227] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Tomasz Morawski <t.morawski@samsung.com>

Rubber-stamped by Daniel Bates.

Added missing DATABASE macro
https://bugs.webkit.org/show_bug.cgi?id=60437

  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get):
04:30 Changeset [86226] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Csaba Osztrogonác.

queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
https://bugs.webkit.org/show_bug.cgi?id=60614

AppEngine has a result limit of 1000. We hit that when trying
to find out how many patches the style-queue (and other queues)
have passed in the last 30 days. So lets display 1000+ instead
of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)

I also made the status pages show "never" instead of just "ago" when we
haven't seen a pass or boot message in the last 1000 messages.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/templates/queuestatus.html:
02:45 Changeset [86225] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kent Tamura <tkent@chromium.org>

The tests added by r86224 don't work on WebKit2/mac.

  • platform/mac-wk2/Skipped:
02:11 Changeset [86224] by tkent@chromium.org
  • 10 edits
    11 adds in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

  • fast/forms/resources/common.js: Added. Helper functions for fast/forms.
  • fast/forms/validation-message-on-checkbox-expected.txt: Added.
  • fast/forms/validation-message-on-checkbox.html: Added.
  • fast/forms/validation-message-on-listbox-expected.txt: Added.
  • fast/forms/validation-message-on-listbox.html: Added.
  • fast/forms/validation-message-on-menulist-expected.txt: Added.
  • fast/forms/validation-message-on-menulist.html: Added.
  • fast/forms/validation-message-on-radio-expected.txt: Added.
  • fast/forms/validation-message-on-radio.html: Added.
  • fast/forms/validation-message-on-textarea-expected.txt: Added.
  • fast/forms/validation-message-on-textarea.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/validation-message-appearance-expected.png: Updated.
  • platform/mac/fast/forms/validation-message-appearance-expected.txt: Updated.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

Tests: fast/forms/validation-message-on-checkbox.html

fast/forms/validation-message-on-listbox.html
fast/forms/validation-message-on-menulist.html
fast/forms/validation-message-on-radio.html
fast/forms/validation-message-on-textarea.html

  • css/html.css: (::-webkit-validation-bubble-message): Add white-space:normal in order not to inherit white-space:pre for <select>.
  • html/ValidationMessage.cpp: (WebCore::adjustBubblePosition): Adjust the bubble position.
    • The top of the bubble should be same as the bottom of the target control.
    • The left of the bubble should be same as the left of the target control. But If the left+32 is larger than the center of the target control, left+32 should be at the center of the target control. But the left position should not be less than 0.

(WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition().

01:32 Changeset [86223] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot shouldn't spam bugs when it can't figure out who to blame
https://bugs.webkit.org/show_bug.cgi?id=60613

This patch limits the number of bugs sheriffbot will spam to three.
Ideally, we'd come up with some smarter huerstics, but hopefully this
will cut down on the bugmail spam for slow bots.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
00:11 Changeset [86222] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
https://bugs.webkit.org/show_bug.cgi?id=60592

Refactoring, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderFlexibleBox.h:

05/10/11:

23:41 Changeset [86221] by yurys@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that browser doesn't crash if alert() arguments conversion throws to an exception
https://bugs.webkit.org/show_bug.cgi?id=60541

  • inspector/console/alert-toString-exception-expected.txt: Added.
  • inspector/console/alert-toString-exception.html: Added.
  • platform/chromium/inspector/console/alert-toString-exception-expected.txt: Added.
23:41 Changeset [86220] by slewis@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

Revert accidental JavaScriptCore change in http://trac.webkit.org/changeset/86130

  • Configurations/JavaScriptCore.xcconfig:
23:12 Changeset [86219] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().
23:07 Changeset [86218] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr patch.

  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData):
23:03 Changeset [86217] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBufferFromRange): (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
  • platform/audio/HRTFElevation.cpp: (WebCore::HRTFElevation::createForSubject): (WebCore::HRTFElevation::createByInterpolatingSlices):
  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Reverb.cpp: (WebCore::Reverb::initialize):
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource): (WebCore::createBusFromInMemoryAudioFile):
22:56 Changeset [86216] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <abarth@webkit.org>

Build fix for font data madness. I've had to whitelist this on several
ports. They need to all be fixed at once.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
22:35 Changeset [86215] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines.

  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
22:34 Changeset [86214] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX for !ENABLE(TEXT_CARET) after r86039

  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::paintDragCaret): Added
UNUSED_PARAM(frame) for !ENABLE(TEXT_CARET).

22:32 Changeset [86213] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS bots should be robust against test-webkitpy hangs
https://bugs.webkit.org/show_bug.cgi?id=60579

Added a killAfterTimeout subroutine, which takes a child_pid
and timeout, and will setup a watchdog process to kill that child
after the timeout. killAfterTimeout will waitpid on the child.

  • EWSTools/start-queue.sh:
22:25 Changeset [86212] by morrita@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/editing

Merge 86132 - 2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

TBR=levin@chromium.org
BUG=82238
Review URL: http://codereview.chromium.org/7005023

22:21 Changeset [86211] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-10 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
https://bugs.webkit.org/show_bug.cgi?id=60502

Other platforms to follow.

  • wtf/PassOwnPtr.h:
21:59 Changeset [86210] by morrita@google.com
  • 2 edits in trunk/Tools

2011-05-10 MORITA Hajime <morrita@google.com>

Unreviewed, moved myself to the reviewers list.

  • Scripts/webkitpy/common/config/committers.py:
21:50 WebKit Team edited by morrita@google.com
(diff)
19:29 Changeset [86209] by ggaren@apple.com
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

2011-05-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier
https://bugs.webkit.org/show_bug.cgi?id=60532

  • heap/Handle.h: Moved HandleTypes to its own header because that's the WebKit style, and it was necessary to resolve a circular dependency between Handle.h and WriteBarrier.h.
  • heap/Heap.h: (JSC::Heap::writeBarrier): Added an inline no-op writeBarrier(), to verify that all the code is in the right place.
  • heap/MarkStack.h: Moved WriteBarrier operations to WriteBarrier.h to resolve a circular dependency.
  • runtime/ArgList.h:
  • runtime/JSCell.h: #include WriteBarrier.h since we don't get it for free anymore.
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): Call the real writeBarrier() function, now that it exists.
  • runtime/SmallStrings.h: Removed a stray #include to resolve a circular dependency.
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::set): (JSC::MarkStack::append): (JSC::MarkStack::appendValues): Updated to match the changes above.
19:28 Changeset [86208] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clean up setLayerRenderer() calls in LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=60524

This refactors the way LayerRendererChromium calls setLayerRenderer on its layers in a few ways to clean things
up:

*) Move the pre-paint call to setLayerRenderer from updatePropertiesAndRenderSurfaces() to paintLayerContents().

updatePropertiesAndRenderSurfaces() does too much and the layer renderer pointer only has to be up to date to do
the actual paint. Longer term we won't need to call this at all in order to call paint and this call will just
go away.

*) Tweaks updateCompositorResourcesRecursive() to be slightly shorter and less error-prone.
*) Explicitly set the LayerRendererChromium for each layer in the tree when transfering the root layer (used

during lost context). LayerChromium::setLayerRenderer checks if the new LayerRendererChromium is different
by comparing the pointer value to the old one. This check will be incorrect if there are multiple lost
contexts between a setLayerRenderer() call and a new LayerRendererChromium happens to be allocated at the
same address as the old one. An explicit call to setLayerRenderer() for every layer in the tree fixes this
since when this function is called the new and old LayerRendererChromium are still live and so they cannot
live at the same address.

The first two changes are purely refactors and do not change behavior. The third issue can't be tested via a
layout test directly as we don't have a way to induce a lost context on the compositor in a layout test.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::clearLayerRendererRecursive): (WebCore::LayerRendererChromium::transferRootLayer): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
19:18 Changeset [86207] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

19:11 Changeset [86206] by oliver@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-10 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Assertion failure in JSC::Structure::typeInfo when reloading weather.com video page
https://bugs.webkit.org/show_bug.cgi?id=60580

The plugin object map was incorrect trying to implement a weak map itself using
destructors. Switch to a WeakGCMap and the problem is fixed.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::~JSNPObject):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateJSObject): (WebKit::NPRuntimeObjectMap::invalidate):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
18:53 Changeset [86205] by commit-queue@webkit.org
  • 18 edits
    4 adds in trunk

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Added.

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html

storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html

Use SQLiteFileSystem::getDatabaseFileSize to get actual usage by
an origin's local storage db. Factored out code that retrieves
path of local storage db.

  • WebCore.exp.in: Sorted alphabetically StorageTracker's mangled function names.
  • storage/StorageTracker.cpp: (WebCore::StorageTracker::syncDeleteOrigin): Uses helper function to get path of origin's db (WebCore::StorageTracker::databasePathForOrigin): New helper function. that gets the path of an origin's local storage db from StorageTracker. (WebCore::StorageTracker::diskUsageForOrigin): New API.
  • storage/StorageTracker.h:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

  • DumpRenderTree/LayoutTestController.cpp: (localStorageDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
18:47 Changeset [86204] by commit-queue@webkit.org
  • 22 edits
    6 adds in trunk

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

  • http/tests/appcache/origin-usage-expected.txt: Added.
  • http/tests/appcache/origin-usage.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.manifest: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

ApplicationCacheStorage already provides an API to get per-origin
disk usage. This should be exposed through WebCore::ApplicationCache
to not be dependent on storage implementation.

Test: http/tests/appcache/origin-usage.html

  • WebCore.exp.in:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::diskUsageForOrigin):
  • loader/appcache/ApplicationCache.h:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added test that loads two frames with ~15Kb image, checks usage,
deletes app cache, verifies usage is 0.

  • DumpRenderTree/LayoutTestController.cpp: (applicationCacheDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::LayoutTestController): (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
18:44 Changeset [86203] by demarchi@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, adding Rafael Antognolli as a committer.

  • Scripts/webkitpy/common/config/committers.py:
18:34 Changeset [86202] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-10 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add some aggressive GC validation to debug builds.
https://bugs.webkit.org/show_bug.cgi?id=60601

When assertions are enabled we now do some validity checking
of objects being added to the mark stack.

  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo): (JSC::PolymorphicAccessStructureList::visitAggregate):
  • heap/MarkStack.cpp: (JSC::MarkStack::validateSet): (JSC::MarkStack::validateValue):
  • heap/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
18:24 Changeset [86201] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-05-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h: Add plumbing for new settings to Chromium DRT.
17:46 Changeset [86200] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Protect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
https://bugs.webkit.org/show_bug.cgi?id=60594
<rdar://problem/9203259>

Reviewed by Alexey Proskuryakov.

No tests since we don't have any bots testing CFNETWORK_DATA_ARRAY_CALLBACK.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): The didReceiveData()
callback on client can result in the load being cancelled. This results in the delegate
(self) being freed. Protect self during the loop so we can check for m_handle and safely
return without crashing.

17:33 Changeset [86199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Chris Guillory <chris.guillory@google.com>

Reviewed by James Robinson.

[ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint.
https://bugs.webkit.org/show_bug.cgi?id=59848

To test this I plan to make the non-printing device (BitmapPlatformDevice) fail
when EndPlatformPaint doesn't matchup with BeginPlatformPaint.
http://codereview.chromium.org/6949012/

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
17:19 Changeset [86198] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Yet more quarantine related sandbox denial when downloading files
<rdar://problem/9397494>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb:
17:10 Changeset [86197] by commit-queue@webkit.org
  • 23 edits
    1 delete in trunk/Source/WebCore

2011-05-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86195.
http://trac.webkit.org/changeset/86195
https://bugs.webkit.org/show_bug.cgi?id=60597

LayerOffset is a really bad name (Requested by smfr on
#webkit).

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Removed.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
17:06 Changeset [86196] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert x,y and width,height pairs to IntPoint and IntSize for RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=60409

Convert RenderLayer to use IntPoint for x,y pairs and IntSize for offsets and sizes.

Refactoring, covered by existing tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollTo): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::scrollWidth): (WebCore::RenderLayer::scrollHeight): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::x): (WebCore::RenderLayer::y): (WebCore::RenderLayer::setLocation): (WebCore::RenderLayer::width): (WebCore::RenderLayer::height): (WebCore::RenderLayer::size): (WebCore::RenderLayer::setWidth): (WebCore::RenderLayer::setHeight): (WebCore::RenderLayer::scrolledContentOffset): (WebCore::RenderLayer::scrollXOffset): (WebCore::RenderLayer::scrollYOffset): (WebCore::RenderLayer::scrollOffset): (WebCore::RenderLayer::scrollToXOffset): (WebCore::RenderLayer::scrollToYOffset): (WebCore::RenderLayer::relativePositionOffset):
16:45 Changeset [86195] by leviw@chromium.org
  • 23 edits
    1 add in trunk/Source/WebCore

2011-05-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Create LayerOffset class
https://bugs.webkit.org/show_bug.cgi?id=60490

Adding a LayerOffset class that will replace existing usage of tx/ty.
LayerOffset is necessary since these values are commonly used as both
a size and a point. Updating paintIntoRect to use this new class.

No new tests since this doesn't change any behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Added. (WebCore::LayerOffset::LayerOffset): (WebCore::LayerOffset::x): (WebCore::LayerOffset::y): (WebCore::LayerOffset::setX): (WebCore::LayerOffset::setY): (WebCore::LayerOffset::toSize): (WebCore::LayerOffset::toPoint): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-): (WebCore::operator==): (WebCore::operator!=):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
16:37 Changeset [86194] by jam@chromium.org
  • 2 edits in branches/chromium/742/Source/WebKit/chromium

Revert 79703 - 2011-02-15 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

TBR=brettw@chromium.org
BUG=81878
Review URL: http://codereview.chromium.org/7005016

16:32 Changeset [86193] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Make member variables of CaretBase private
https://bugs.webkit.org/show_bug.cgi?id=60454

Moved m_absCaretBounds, m_absoluteCaretRepaintBounds, m_absCaretBoundsDirty, and m_caretPaint back
from CaretBase to FrameSelection because they are only used in FrameSelection, and made the rest
of member variables in CaretBase private.

  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Takes CaretVisibility as an argument. (WebCore::DragCaretController::DragCaretController): (WebCore::FrameSelection::FrameSelection): Initializes m_absCaretBoundsDirty and m_caretPaint now that they are part of FrameSelection again. (WebCore::DragCaretController::setCaretPosition): (WebCore::FrameSelection::setSelection): (WebCore::CaretBase::clearCaretRect): Extracted from updateCaretRect. (WebCore::CaretBase::updateCaretRect): No longer clears caret; all call sites (namely setCaretPosition and localCaretRect) that used to call updateCaretRect now need to call clearCaretRect or updateCaretRect based on some conditions. (WebCore::FrameSelection::localCaretRect): (WebCore::CaretBase::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::paintCaret): Only calls CaretBase::paintCaret if m_caretPaint is true. (WebCore::CaretBase::paintCaret): Removed an early exit for when m_caretPaint is false since m_caretPaint has been moved from CaretBase to FrameSelection. (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisibility): Takes CaretVisibility instead of bool. (WebCore::FrameSelection::caretBlinkTimerFired):
  • editing/FrameSelection.h: (WebCore::CaretBase::fastLocalCaretRect): Added; replaces localCaretRectForPainting. (WebCore::CaretBase::shouldUpdateCaretRect): Added. (WebCore::CaretBase::setCaretRectNeedsUpdate): Added. (WebCore::CaretBase::setCaretVisibility): Added. (WebCore::CaretBase::caretIsVisible): Added. (WebCore::FrameSelection::setCaretRectNeedsUpdate): Added.
16:28 Changeset [86192] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-10 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
https://bugs.webkit.org/show_bug.cgi?id=58854

Regression test for http://crbug.com/79539.

  • http/tests/filesystem/no-cache-filesystem-url-expected.txt: Added.
  • http/tests/filesystem/no-cache-filesystem-url.html: Added.
16:24 Changeset [86191] by enrica@apple.com
  • 2 edits in trunk/Tools

Added my name to the reviewers list and removed my name from
to committer-only list.

Reviewed by Beth Dakin.

  • Scripts/webkitpy/common/config/committers.py:
16:14 WebKit Team edited by enrica@apple.com
(diff)
16:01 Changeset [86190] by jpu@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself as commiter.

15:57 Changeset [86189] by jamesr@google.com
  • 8 edits in trunk/Source/WebCore

2011-05-10 James Robinson <jamesr@chromium.org>

Reviewed by Nate Chapin.

[chromium] Use parent/child terms for compositor tree structures consistently instead of superlayer/sublayer
https://bugs.webkit.org/show_bug.cgi?id=60588

GraphicsLayer uses parent/child terminology for tree structure, as does CCLayerImpl. LayerChromium was using
superlayer/sublayer terms, inherited from this code's branching from the platform/graphics/win/CACF code. The
mixed terminology is confusing and parent/child is more common, so this unifies everything to use parent/child.

No new tests, refactor only.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToCanvas): (WebCore::GraphicsLayerChromium::setContentsToMedia): (WebCore::GraphicsLayerChromium::hostLayerForChildren): (WebCore::GraphicsLayerChromium::layerForParent): (WebCore::GraphicsLayerChromium::updateChildList): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::setupContentsLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::addChild): (WebCore::LayerChromium::insertChild): (WebCore::LayerChromium::removeFromParent): (WebCore::LayerChromium::removeChild): (WebCore::LayerChromium::replaceChild): (WebCore::LayerChromium::indexOfChild): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllChildren): (WebCore::LayerChromium::setChildren): (WebCore::LayerChromium::parent): (WebCore::LayerChromium::dumpLayer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::children): (WebCore::LayerChromium::setParent): (WebCore::LayerChromium::numChildren):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive): (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::descendantsDrawsContent):
  • platform/graphics/chromium/cc/CCLayerImpl.h:
15:45 Changeset [86188] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Switch RenderBoxModelObject::paintNinePieceImage to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60586

Switch paintNinePieceImage to take an IntRect instead of four ints representing an IntRect!

No new tests as this is simply refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage): (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
15:44 Changeset [86187] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-10 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Coalesced wheel events should be saved to hand back to the client on unhandled return
https://bugs.webkit.org/show_bug.cgi?id=60584

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): (WebKit::canCoalesce): (WebKit::coalesce): (WebKit::coalescedWheelEvent): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::processDidCrash): Reworks coalescing/merging code to happen on didReceiveEvent rather than in handleWheelEvent. This means we now store the pending events in a queue, and pull them out when we can.
  • UIProcess/WebPageProxy.h: Change single event containers to contain all pending/merged/coalesced events and remove unused flag.
15:43 Changeset [86186] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
https://bugs.webkit.org/show_bug.cgi?id=60531

Remove the (unused) _isAnimating ivar and replace it with two ivars: _isEnteringFullScreen and
_isExitingFullScreen. These will ensure each is only called once per full screen request, and
that if one exit/enter request interrupts another, that the required functions are called in
order.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Removed _isAnimating. (-[WKFullScreenWindowController exitFullScreen]): Ditto. (-[WKFullScreenWindowController beganEnterFullScreenAnimation]): Gate on _isEnteringFullScreen. Check _isExitingFullScreen

and call [self finishedExitFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Gate on _isEnteringFullScreen.
(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Gate on _isExitingFullScreen. Check _isEnteringFullScreen

and call [self finishedEnterFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Gate on _isExitingFullScreen.

15:38 Changeset [86185] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
https://bugs.webkit.org/show_bug.cgi?id=60278

  • fullscreen/full-screen-remove-children-expected.txt: Added.
  • fullscreen/full-screen-remove-children.html: Added.
  • fullscreen/full-screen-test.js: Fixed an exception when running in Safari.

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
https://bugs.webkit.org/show_bug.cgi?id=60278

Handle the removal of a full screen element from within Node::willRemove() instead
of Document::nodeWillBeRemoved(). The new function Document::fullScreenElementWillBeRemoved() will
be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().

Test: fullscreen/full-screen-remove-children.html

  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element. (WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::willRemove): Check to see if this is the current full screen element.
15:37 Changeset [86184] by bdakin@apple.com
  • 15 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=60582
Crash switching overlay/non-overlay scrollbar preference still possible
-and corresponding-
<rdar://problem/9323983>

Reviewed by Darin Adler.

Source/WebCore:

This patch prevents any work from being done on pages that are in the page cache
when the preference is switched.

When the Document is going into or coming out of the page cache, have the
FrameView inactivate or activate the Page's ScrollAnimators as appropriate.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

Iterate through the Page's ScrollableAreas setting the active state of the
ScrollAnimators.

  • page/FrameView.cpp:

(WebCore::FrameView::setAnimatorsAreActive):

  • page/FrameView.h:

ScrollAnimator has a new bit -- m_isActive. Right now m_isActive is always true
unless the ScrollAnimator belongs to a ScrollableArea that is in the page cache.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::setIsActive):
(WebCore::ScrollAnimator::isActive):

ScrollAnimatorMac has a new bit -- m_needsScrollerStyleUpdate. This is set to true
when a ScrollAnimator is inactive and has received the
updateScrollerStyleForNewRecommendedScrollerStyle delegate notification. It
prevents any work from being done for this delegate until the ScrollAnimator
becomes active again.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorMac::needsScrollerStyleUpdate):

This delegate method has been re-factored into ScrollAnimatorMac::
updateScrollerStyle(). This way the meat of the function can be called by both the
delegate and ScrollAnimatorMac::setIsActive()

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

This override of ScrollAnimator::setIsActive() calls the base class, and then calls updateScrollerStyle() if needsScrollerStyleUpdate() is set to true.
(WebCore::ScrollAnimatorMac::setIsActive):

This is mostly the same as the old delegate method. Key differences are that if
the ScrollAnimator is inactive, we now setNeedsScrollerStyleUpdate(true) and
return early. We also only call scrollableArea()->scrollbarStyleChanged() if
needsScrollerStyleUpdate() is false since in the true case when we are restoring
from the page cache, this would be duplicated work.
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

New WKSystemInterface function is needed to retrieve the scrollbar style.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

15:15 Changeset [86183] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-05-10 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Windows clients need to know if the page overlay is installed
https://bugs.webkit.org/show_bug.cgi?id=60562
<rdar://problem/8940164>


Until we move all the UI for find on page into WebKit on Windows (specifically, drawing the find bouncy),
WebKit clients need to know whether WebKit is drawing the page overlay or not. Keep track of this in
the WebPageProxy in the UI process and provide a WebKit2 API to retrieve this information.

  • UIProcess/API/C/win/WKView.cpp: (WKViewIsPageOverlayInstalled): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewIsPageOverlayInstalled().


  • UIProcess/PageClient.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.messages.in: Added DidInstallOrUninstallPageOverlay.
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::didInstallOrUninstallPageOverlay): Added.


  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): Initialize m_pageOverlayInstalled. (WebKit::WebView::didInstallOrUninstallPageOverlay): Added.
  • UIProcess/win/WebView.h: Added didInstallOrUninstallPageOverlay() and m_pageOverlayInstalled. (WebKit::WebView::pageOverlayInstalled): Added.


  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Send message to UI process to tell it the page overlay is installed. (WebKit::WebPage::uninstallPageOverlay): Send message to UI process to tell it the page overlay is uninstalled.
15:11 WebKit Team edited by senorblanco@chromium.org
(diff)
14:53 Changeset [86182] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
https://bugs.webkit.org/show_bug.cgi?id=60502

Technically there are a few bits in here that weren't reviewed by Dave,
but close enough for government work. This patch all fixes the
remaining strict PassOwnPtr violations on Chromium Linux.

  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
14:43 Changeset [86181] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 84611 - <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

  • media/audio-controls-do-not-fade-out-expected.txt: Added.
  • media/audio-controls-do-not-fade-out.html: Added.

TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7005009

14:19 Changeset [86180] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

In my patch to fix https://bugs.webkit.org/show_bug.cgi?id=60572 I committed without having saved ChangeLog and code comments that are critical to explain the bug and the code change.

Whoops! Here they are.

13:26 Changeset [86179] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9343191> and https://bugs.webkit.org/show_bug.cgi?id=60572

Reviewed by Alice Liu.

No new tests - There's no way to reproduce the truly bizarre things Canon does in their app
that would reasonably fit in to our testing infrastructure.

Add a timer to Settings and instead of calling setLoadsImagesAutomaticallyInAllFrames right
away when this pref changes, call it on a 0-delay:

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):

  • page/Settings.h:
12:37 Changeset [86178] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
https://bugs.webkit.org/show_bug.cgi?id=59990

No new tests. This is covered by existing pixel tests.

  • platform/gtk/GtkVersioning.c: (getGdkDrawableSize): Added this helper method.
  • platform/gtk/GtkVersioning.h: Added helper method declaration.
  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Call into the helper if there is actually a GdkDrawable. If not, disable the sanity check.
12:33 Changeset [86177] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-05-10 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ WebKit2 build. Add a CredentialsStorage stub for libsoup.

  • GNUmakefile.list.am: Add stub to source list.
  • platform/network/soup/CredentialStorageSoup.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Added stub. (WebCore::CredentialStorage::get):
12:24 Changeset [86176] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Dan Bernstein.

Second attempts at a fix for this bug. Instead of removing the dirtying (which turned out to be needed in a few cases),
make dirtyLinesFromChangedChild mark a child as needing layout when it has to recur to the parent. Because the method already
aborts the recursion if selfNeedsLayout() is set on the parent, this has the effect of stopping the O(n2) pathological
behavior, since you can use the selfNeedsLayout() bit to understand that you've dirtied the lines already.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

12:23 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:57 Changeset [86175] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
https://bugs.webkit.org/show_bug.cgi?id=60567
<rdar://problem/9377845>

It is possible to receive an incoming sync reply that is for a request we don't know about.
This could happen if the sync message send timed out for example.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingSyncReply):
11:57 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:32 Changeset [86174] by mrobinson@webkit.org
  • 11 edits in trunk/Source

2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
https://bugs.webkit.org/show_bug.cgi?id=60293

No new tests. This is covered by current pixel tests.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyCairoImageSurface): Abstract the code from WebCore::ImageBuffer::copyImage into this helper which creates a deep copy of a Cairo image surface.
  • platform/graphics/cairo/CairoUtilities.h: Added declaration.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::copyImage): Use the new helper.
  • platform/graphics/cairo/ImageCairo.cpp: Abstract some of this logic into the new drawSurfaceToContext method on PlatformContextCairo. (WebCore::BitmapImage::draw):
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::drawPatternToCairoContext): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext): Added.
  • platform/graphics/cairo/PlatformContextCairo.h: Added declarations.

2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
https://bugs.webkit.org/show_bug.cgi?id=60293

  • GNUmakefile.am: Remove ShareableBitmapGtk in favor of ShareableBitmapCairo.
  • Shared/ShareableBitmap.h: Added a couple Cairo-specific declarations.
  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): Added. (WebKit::ShareableBitmap::paint): Added. (WebKit::ShareableBitmap::createCairoSurface): Added. (WebKit::ShareableBitmap::releaseSurfaceData): Added.
11:30 Changeset [86173] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/JavaScriptCore/wtf/FastMalloc.cpp

Merge 86106
BUG=82152
Review URL: http://codereview.chromium.org/7000002

11:28 Changeset [86172] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • platform/network/qt/CredentialStorageQt.cpp:

(WebCore::CredentialStorage::get):
Add stub.

11:12 Changeset [86171] by tony@chromium.org
  • 8 edits
    1 add
    1 delete in trunk

2011-05-10 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
https://bugs.webkit.org/show_bug.cgi?id=60079

Update the expected results.

  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
  • platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-05-10 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
https://bugs.webkit.org/show_bug.cgi?id=60079

Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
value pair.

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
11:04 Changeset [86170] by imasaki@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-05-10 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaselines for video-layer-crash.
https://bugs.webkit.org/show_bug.cgi?id=60548

Chromium bug is http://crbug.com/60744. Expected images need to be
updated because they are incorrect. The cause of this image change
cannot be easily determined at present because the test has been
broken for so long.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Added.
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
11:04 Changeset [86169] by andersca@apple.com
  • 14 edits in trunk/Source

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
https://bugs.webkit.org/show_bug.cgi?id=60560
<rdar://problem/9338693>

Add symbols required by WebKit2.

  • WebCore.exp.in:

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
https://bugs.webkit.org/show_bug.cgi?id=60560

Implement NPN_GetAuthenticationInfo.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::getAuthenticationInfo): Send a GetAuthenticationInfo message to the web process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::initializeProtectionSpace): Initialize a WebCore::ProtectionSpace object from NPAPI parameters.

(WebKit::NPN_GetAuthenticationInfo):
Make a ProtectionSpace object and then call NetscapePlugin::getAuthenticationInfo.
Finally, copy the username/password and pass them back to the plug-in.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::getAuthenticationInfo): Call the plug-in controller.
  • WebProcess/Plugins/PluginController.h: Add getAuthenticationInfo pure virtual member function.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::getAuthenticationInfo): Call the real plug-in controller's getAuthenticationInfo member function.
  • WebProcess/Plugins/PluginProxy.messages.in: Add GetAuthenticationInfo message.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::getAuthenticationInfo): Try to get the authentication info from the credential storage. Failing that, get it from the persistent credential storage.
10:46 Changeset [86168] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Styles sidebar is not updated upon changes in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60320

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
10:37 Changeset [86167] by jamesr@google.com
  • 25 edits
    16 deletes in branches/chromium/742

Revert 79985 - 2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
mutations take affect, but don't affect other renderers which shared the SVGPaint object before.

  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
  • svg/animations/animate-color-fill-currentColor-expected.txt: Added.
  • svg/animations/animate-color-fill-currentColor.html: Added.
  • svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
  • svg/custom/SVGPaint-mutate-attribute.svg: Added.
  • svg/custom/SVGPaint-mutate-inline-style.svg: Added.
  • svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
  • svg/dom/SVGPaint-expected.txt: Same for SVGPaint.

2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Wrong handling of currentColor on inherit
https://bugs.webkit.org/show_bug.cgi?id=38102

Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).

<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.

In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.

A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)

Add several new tests covering the patch.

Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg

svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg

  • GNUMakefile.am: Add CSSMutableValue.h
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
  • css/CSSMutableStyleDeclaration.h: Add destructor.
  • css/CSSMutableValue.h: Added. (WebCore::CSSMutableValue::CSSMutableValue): (WebCore::CSSMutableValue::~CSSMutableValue): (WebCore::CSSMutableValue::isMutableValue): (WebCore::CSSMutableValue::node): (WebCore::CSSMutableValue::setNode): (WebCore::CSSMutableValue::setNeedsStyleRecalc):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
  • css/CSSValue.h: (WebCore::CSSValue::isMutableValue): Return false, default.
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
  • rendering/style/SVGRenderStyle.h: Ditto. (WebCore::SVGRenderStyle::initialFillOpacity): (WebCore::SVGRenderStyle::initialFillPaintType): (WebCore::SVGRenderStyle::initialFillPaintColor): (WebCore::SVGRenderStyle::initialFillPaintUri): (WebCore::SVGRenderStyle::initialStrokeOpacity): (WebCore::SVGRenderStyle::initialStrokePaintType): (WebCore::SVGRenderStyle::initialStrokePaintColor): (WebCore::SVGRenderStyle::initialStrokePaintUri): (WebCore::SVGRenderStyle::initialStrokeMiterLimit): (WebCore::SVGRenderStyle::initialStopOpacity): (WebCore::SVGRenderStyle::initialFloodOpacity): (WebCore::SVGRenderStyle::setFillPaint): (WebCore::SVGRenderStyle::setStrokePaint): (WebCore::SVGRenderStyle::fillPaintType): (WebCore::SVGRenderStyle::fillPaintColor): (WebCore::SVGRenderStyle::fillPaintUri): (WebCore::SVGRenderStyle::strokePaintType): (WebCore::SVGRenderStyle::strokePaintColor): (WebCore::SVGRenderStyle::strokePaintUri): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
  • rendering/style/SVGRenderStyleDefs.cpp: Ditto. (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto. (WebCore::requestPaintingResource):
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
  • rendering/svg/SVGResources.cpp: Ditto. (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources):
  • svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object. (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor):
  • svg/SVGColor.h:
  • svg/SVGPaint.cpp: Ditto. (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
  • svg/SVGPaint.h:

TBR=kerz@chromium.org
BUG=80880
Review URL: http://codereview.chromium.org/7002001

10:36 Changeset [86166] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-10 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=60554

  • editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms.html:
  • platform/chromium-linux/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
10:28 Changeset [86165] by levin@chromium.org
  • 9 edits in trunk/Tools

2011-05-10 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
https://bugs.webkit.org/show_bug.cgi?id=60466

  • Scripts/webkitpy/style/checker.py: (unrelated) style fix.
  • Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since that property was removed.
  • Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line filtering for errors.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to verify that the line filtering is turned off.
  • Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors and remove the unused file_path parameter.
  • Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the line filtering is turned off (and fix test_no_error).
  • Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering of errors based on the lines changed in the patch.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off the filtering.
10:26 Changeset [86164] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
10:08 Changeset [86163] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Files that load quickly sometimes won't play.
https://bugs.webkit.org/show_bug.cgi?id=60556
<rdar://problem/9330567>

No new tests, this failure is very difficult to reproduce on some machines. The fix was
verified manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates

to dispatchNotification so it is more obvious which state changes call it.

(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to

dispatchNotification.

(WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after

processing "size changed" notification so we detect all state changes. Consolidate
calls to updateStates here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in

a debug build.

09:57 Changeset [86162] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/742

Merge 86160 - Fix null ptr crash from r85876

BUG=72832
Review URL: http://codereview.chromium.org/6999012

09:46 Changeset [86161] by aroben@apple.com
  • 3 edits in trunk/Source/WebKit2

Use FontSmoothingLevelWindows by default on Windows

Fixes <http://webkit.org/b/60557> REGRESSION (r86077): Web Inspector uses CG font rendering
in WebKit2 on Windows

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Added and deployed a new DEFAULT_WEBKIT_FONT_SMOOTHING_LEVEL

macro to let Windows have a different default font smoothing level from other platforms.

  • UIProcess/API/C/WKPreferencesPrivate.h: Updated the comment about the default font

smoothing level.

09:40 Changeset [86160] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Add containsFloats call to hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537

Test: fast/block/float/no-overhanging-float-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats):

2011-05-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash due to wrong result from
hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537

  • fast/block/float/no-overhanging-float-crash-expected.txt: Added.
  • fast/block/float/no-overhanging-float-crash.html: Added.
09:22 Changeset [86159] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Drop obsolete test code for the Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=60471

  • src/js/Tests.js:
09:22 Changeset [86158] by ademar.reis@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Increment QtWebKit trunk version to 4.10.0
https://bugs.webkit.org/show_bug.cgi?id=60549

QtWebKit-2.2 (branched) will be 4.9.0, so we need to
increase the trunk version by 1.

  • qt_webkit_version.pri:
08:50 Changeset [86157] by aroben@apple.com
  • 9 edits
    2 deletes in trunk

Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows

Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:

(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
WindowedPluginTest::testHarnessWindow function.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:

(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
created for.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
WindowedPluginTest, and initialized new members.
(WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
(WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
then clean up and tell the test harness we're done.
(WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
(WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
window becomes visible.
(WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
if it was hidden at the start of the test.
(WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
This should cause our window to become visible and our window region to get set. When we get
a WM_WINDOWPOSCHANGED message, we can finally finish the test.
(WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
(WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
"startTest".
(WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:

(WindowedPluginTest::testHarnessWindow):

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:

Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.

LayoutTests:

  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Updated

for new test output that doesn't claim anything about the window's position.

  • platform/win/plugins/window-region-is-set-to-clip-rect.html: Hide the plugin initially,

and tell the plugin when the load event has fired.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
08:48 Changeset [86156] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/workers/wrapper-map-gc.html, because it crashes intermittently.
08:43 Changeset [86155] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/dom/Geolocation/window-close-crash.html.
08:32 Changeset [86154] by ademar.reis@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] tst_QWebPage creates temporary files in the current working dir
https://bugs.webkit.org/show_bug.cgi?id=60497

tst_QWebPage was using QDir::currentPath when creating temporary dirs
and leaving them after the test was run. I basically borrowed the fix
from tst_QDeclarativeWebView.

  • tests/qwebpage/tst_qwebpage.cpp: (removeRecursive): (tst_QWebPage::tmpDirPath): (tst_QWebPage::cleanupFiles): (tst_QWebPage::database): (tst_QWebPage::multiplePageGroupsAndLocalStorage):
08:25 Changeset [86153] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Antonio Gomes.

Warning fix on PluginPackage.cpp.
https://bugs.webkit.org/show_bug.cgi?id=60371

Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
Let's use a struct rather than an array so we can pass everything to StringHasher.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
07:56 Changeset [86152] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
https://bugs.webkit.org/show_bug.cgi?id=60551

  • WebCore.pro: Disable the line that enables HAVE_QRAWFONT if the feature is found. Added a comment about why.
07:39 Changeset [86151] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Fix video-play-stall-before-metadata.

A stalled event won't be sent until no progress has happened for 3
seconds. Make sure that the connection is still open for at least that long.
https://bugs.webkit.org/show_bug.cgi?id=60306

  • http/tests/media/video-load-and-stall.cgi:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • platform/chromium/test_expectations.txt:
06:56 Changeset [86150] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

One more unreviewed typo fix after r86148. :(

  • platform/qt-4.8/Skipped:
06:54 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
06:51 Changeset [86149] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86148.

  • platform/qt-4.8/Skipped:
06:48 Changeset [86148] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
http://trac.webkit.org/changeset/86143

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped:
    • Add http/tests/security/xss-DENIED-xsl-document.xml
    • Add http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html
06:43 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
06:22 Changeset [86147] by caseq@chromium.org
  • 4 edits in trunk

2011-05-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
https://bugs.webkit.org/show_bug.cgi?id=60266

  • bindings/objc/DOM.mm: (kitClass): return DOMNode class for shadow root node

2011-05-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped: removed suppression of console-shadow-dom-access.html
05:55 Changeset [86146] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[WK2] eventSender.keyDown is unimplemented

Move fast/forms/radio-group-keyboard-change-event.html from qt-wk2/Skipped to
mac-wk2/Skipped, because it isn't Qt specific bug, but general WK2 specific one.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
05:42 Changeset [86145] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt][Mac] Add platform specific expected result for plugins/plugin-javascript-access.html,
which is same as the platform independent one, but differs from the general Qt specific.

  • platform/qt-mac/plugins: Added.
  • platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Added.
05:33 Changeset [86144] by benm@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Fix build in WebCore/xml/XSLTProcessorLibxslt.cpp
https://bugs.webkit.org/show_bug.cgi?id=60478

No new tests), build fix only.

  • xml/XSLTProcessorLibxslt.cpp: Add CString.h include.
05:30 Changeset [86143] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

It is a general Qt related bug, so we should add it to qt/Skipped instead of all Skipped list.

  • platform/qt-arm/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-linux/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-mac/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt/Skipped: Add fast/events/backspace-navigates-back.html.
05:14 Changeset [86142] by ossy@webkit.org
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed.

Move plugins/plugin-javascript-access-expected.txt from qt-linux platform
to qt, because it should be used by qt-4.8, qt-arm Linux platforms too.

  • platform/qt-linux/plugins: Removed.
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/qt/plugins/plugin-javascript-access-expected.txt: Copied from LayoutTests/platform/qt-linux/plugins/plugin-javascript-access-expected.txt.
04:56 Changeset [86141] by ossy@webkit.org
  • 4 edits
    2 adds in trunk

[Qt] Add new qt-4.8 platform for layout testing
https://bugs.webkit.org/show_bug.cgi?id=60544

Reviewed by Kenneth Rohde Christiansen.

Tools:

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

LayoutTests:

  • platform/qt-4.8/Skipped: Added.
04:24 Changeset [86140] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtRawFont support should check based on feature, not version
https://bugs.webkit.org/show_bug.cgi?id=60513

Build fix - no tests added.

  • WebCore.pro:
01:59 Changeset [86139] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] eventSender.keyDown is unimplemented

  • platform/qt-wk2/Skipped: Add fast/forms/radio-group-keyboard-change-event.html.
01:49 Styling Form Controls edited by tkent@chromium.org
How to remove spin buttons (diff)
01:46 Changeset [86138] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/qt-mac/Skipped: Add plugins/embed-prefers-plugins-for-images.html.
01:34 Changeset [86137] by ossy@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed fix.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

r86124 implemented unmarkText() and it fixed a test,
which doesn't need Qt specific expected failure anymore.

  • platform/qt/fast/events/ime-composition-events-001-expected.txt: Removed.
01:27 Changeset [86136] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Build fix: include ExceptionCode
https://bugs.webkit.org/show_bug.cgi?id=60538

  • bindings/js/JSDOMBinding.cpp:
01:19 Changeset [86135] by tonyg@chromium.org
  • 64 edits in trunk/Source

2011-05-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
https://bugs.webkit.org/show_bug.cgi?id=60388

These were all found using the include-what-you-use clang plugin.

  • css/CSSFontFaceSrcValue.h:
  • css/CSSImageGeneratorValue.h:
  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.cpp:
  • css/CSSPrimitiveValueCache.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/RGBColor.cpp:
  • css/RGBColor.h:
  • dom/EventTarget.h:
  • dom/ExceptionBase.cpp:
  • dom/ExceptionBase.h:
  • dom/MessagePort.cpp:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/SelectElement.cpp:
  • dom/SelectElement.h:
  • dom/TextEvent.cpp:
  • dom/TextEvent.h:
  • dom/Touch.cpp:
  • dom/Touch.h:
  • dom/TouchEvent.cpp:
  • dom/TouchEvent.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyBlockElementCommand.h:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/EditCommand.h:
  • editing/Editor.h:
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.h:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • html/HTMLSelectElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • loader/appcache/DOMApplicationCache.cpp:
  • page/EventSource.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/svg/RenderSVGInlineText.cpp:
  • svg/SVGMatrix.h:
  • websockets/WebSocket.cpp:
  • workers/AbstractWorker.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XPathExpression.cpp:

2011-05-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
https://bugs.webkit.org/show_bug.cgi?id=60388

  • WebProcess/FullScreen/WebFullScreenManager.cpp:
01:13 Changeset [86134] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-10 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking (video-controls-rendering.html)

  • platform/chromium/test_expectations.txt:
00:52 Changeset [86133] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Adam Barth <abarth@webkit.org>

Attempt to fix the clang build.

  • src/WebDevToolsAgentImpl.cpp:
00:46 Changeset [86132] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

05/09/11:

22:41 Changeset [86131] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the LLVM Compiler build.

  • page/EventHandler.h:
22:23 Changeset [86130] by weinig@apple.com
  • 15 edits in trunk

Unreviewed, rolling out r86108.
http://trac.webkit.org/changeset/86108
https://bugs.webkit.org/show_bug.cgi?id=60533

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-05-09
Broke makefile based builds and Cairo (Requested by weinig on
#webkit).

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:

(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

21:48 Changeset [86129] by dcheng@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-05-09 Daniel Cheng <dcheng@chromium.org>

Fix the build.

Really add the file this time.

  • page/DragState.h: Added. (WebCore::DragState::DragState):
21:33 Changeset [86128] by dcheng@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-05-09 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Refactor RenderObject::draggableNode.
https://bugs.webkit.org/show_bug.cgi?id=60503

This patch lays the ground for refactoring the drag start logic. It moves draggableNode to
DragController to avoid the awkward plumbing of calling DragController from RenderObject and
also moves EventHandlerDragState out from EventHandler so it can be shared between
EventHandler and DragController where appropriate.

No new tests since there should be no behavior change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::mayStartDragAtEventLocation):
  • page/DragController.h:
  • page/DragState.h: Added. (WebCore::DragState::DragState):
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
20:58 Writing Reftests edited by hayato@chromium.org
(diff)
20:24 Changeset [86127] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/page/animation/CompositeAnimation.cpp

Merge 85693
BUG=82096
Review URL: http://codereview.chromium.org/6994006

19:40 Changeset [86126] by hayato@chromium.org
  • 5 edits in trunk/Tools

2011-05-09 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

Skip reftests if pixel tests are disabled.

https://bugs.webkit.org/show_bug.cgi?id=59078

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19:23 Changeset [86125] by mrobinson@webkit.org
  • 4 edits in trunk

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Update the results for a test after r86102. This test was susceptible to
scrollbar race conditions and r86102 changed timing slightly.

  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Fix a test after r86102. Scrollbars update asynchronously, so we
must check the adjustments after a short delay.

  • tests/testwebview.c: (quit_after_short_delay_cb): Add a short delay before checking adjustments. (test_webkit_web_view_grab_focus): Ditto.
19:11 Changeset [86124] by commit-queue@webkit.org
  • 8 edits in trunk

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

Unskipped passed test.

  • platform/qt/Skipped:

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::confirmComposition):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::unmarkText):
  • DumpRenderTree/qt/TextInputControllerQt.h:
19:05 Changeset [86123] by lforschler@apple.com
  • 5 edits in tags/Safari-534.34.4/Source

Versioning to match updated WebBrowser.

19:01 Changeset [86122] by lforschler@apple.com
  • 1 copy in tags/Safari-534.34.4

New tag.

18:55 Changeset [86121] by imasaki@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-09 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline images for video-controls-rendering.
https://bugs.webkit.org/show_bug.cgi?id=60517

Chromium bug is http://crbug.com/82033. These rebaselines are necessary
due to unrelated bug (http://crbug.com/74102). We are checking in bad
baselines for the time being so that we ensure no other problems occur.
This test will fail when above bug (http://crbug.com/74102) is fixed.
At that time, we will checkin correct baselines.

  • platform/chromium-gpu-linux/media/video-controls-rendering -expected.png: Added.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:52 Changeset [86120] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Enable casting between CSSPrimitiveValue and FontWeight enum
https://bugs.webkit.org/show_bug.cgi?id=60516

No new tests added as no functionality changed.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Implement cast from FontWeight to CSSPrimitiveValue. (WebCore::CSSPrimitiveValue::operator FontWeight): Implement cast from CSSPrimitiveValue to FontWeight
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use new cast to reduce code size. Flatten switch inside if.
18:50 Changeset [86119] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

[chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
https://bugs.webkit.org/show_bug.cgi?id=60520

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
18:38 Changeset [86118] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Fix build, for real.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment):
18:30 Changeset [86117] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r85984

18:28 Changeset [86116] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix..

Fix GTK+3.x build.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment): the adjustment is in adjustmentWatcher() now. (getVerticalAdjustment): ditto.
18:09 Changeset [86115] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Simon Fraser <simon.fraser@apple.com>

Move IconURL.* into the dom grouping.

  • WebCore.xcodeproj/project.pbxproj:
18:01 Changeset [86114] by mrobinson@webkit.org
  • 4 edits
    1 add in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84979

17:59 Changeset [86113] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84123

17:58 Changeset [86112] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85221

17:57 Changeset [86111] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

Merging r85219

17:56 Changeset [86110] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85390

17:25 Changeset [86109] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

2011-05-08 Jeremy Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=60449

  • fullscreen/full-screen-remove-sibling-expected.txt: Added.
  • fullscreen/full-screen-remove-sibling.html: Added.

2011-05-08 Jeremy Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=60449

Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
coalesce anonymous children.

Test: fullscreen/full-screen-remove-sibling.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
17:17 Changeset [86108] by levin@chromium.org
  • 15 edits in trunk

Switch TestWebKitAPI to GTest
https://bugs.webkit.org/show_bug.cgi?id=59561

Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-09
Reviewed by Sam Weinig.

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

16:50 Changeset [86107] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): (-[WebFullScreenController exitFullscreen]):

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The beganExitFullScreenAnimation method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
16:45 Changeset [86106] by darin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-09 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

http://bugs.webkit.org/show_bug.cgi?id=60509
Wrong type used for return value from strlen

  • wtf/FastMalloc.cpp: (WTF::fastStrDup): Use size_t. Also don't bother checking for failure since fastMalloc won't return if it fails.
16:41 Changeset [86105] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r84706): Crazy rendering of vimeo.com after exiting fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=60512

Initialize m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
16:37 Changeset [86104] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r86039): DragCaretController doesn't draw caret
https://bugs.webkit.org/show_bug.cgi?id=60505

Removed an early exit in setCaretPosition introduced by r86039.
Also replaced calls to containerNode by deprecatedNode since rendering code doesn't
support container node for rendering caret.

  • editing/FrameSelection.cpp: (WebCore::DragCaretController::setCaretPosition):
16:31 Changeset [86103] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

A WKView with plug-ins paints white when first moved into a window
https://bugs.webkit.org/show_bug.cgi?id=60511

Reviewed by Darin Adler.

The UI process’s wait for DidUpdateBackingStoreState would always time out because the Web process
was blocked on a synchronous message the UI process trying to get the connections for plug-ins in
the view. This is avoided by deferring the call to Page::setCanStartMedia().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize the new m_setCanStartMediaTimer.
(WebKit::WebPage::setCanStartMediaTimerFired): Added. Calls setCanStartMedia(true) when the timer
fires.
(WebKit::WebPage::setIsInWindow): When going out of a window, stop the timer. When going into a
window, start it.

  • WebProcess/WebPage/WebPage.h:
16:24 Changeset [86102] by mrobinson@webkit.org
  • 14 edits
    2 adds in trunk/Source

2011-04-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
https://bugs.webkit.org/show_bug.cgi?id=59821

Completely remove the ability for WebKit to set GtkAdjustments on ScrollViews
and, consequently, Scrollbars. Handling adjustment updates can now be managed
in WebKit.

No new tests. This is covered by existing Scrollbar tests.

  • platform/ScrollView.cpp: platformInit and platformDestroy can now be shared between ScrollView.cpp and ScrollViewGtk.cpp.
  • platform/ScrollView.h: Remove unused methods.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::create): No longer need to pass in the adjustment. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): Update the comments here.
  • platform/gtk/MainFrameScrollbarGtk.h: Lots of code removal.
  • platform/gtk/ScrollViewGtk.cpp: Ditto. (WebCore::ScrollView::createScrollbar): Ditto. (WebCore::ScrollView::setScrollbarModes): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: This file needs the GRefPtrGtk.h include now that it doesn't receive it transitively.

2011-04-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
https://bugs.webkit.org/show_bug.cgi?id=59821

Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
them to WebCore to manage. This simplifies the code quite a bit and should be less
crash prone in the future.

  • GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
  • WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member. (WebKit::ChromeClient::ChromeClient) Initialize the new member. (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments. (WebKit::ChromeClient::contentsSizeChanged): Ditto. (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there is no main frame, so do an early return in that case.
  • WebCoreSupport/ChromeClientGtk.h: Add the new member. (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into WebCore. (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::postCommitFrameViewSetup):
  • WebCoreSupport/GtkAdjustmentWatcher.cpp: Added. (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher): (WebKit::updateAdjustmentFromScrollbar): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars): (WebKit::updateAdjustmentCallback): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): (WebKit::adjustmentValueChangedCallback): (WebKit::setAdjustment): (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment): (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment): (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
  • WebCoreSupport/GtkAdjustmentWatcher.h: Added. (WebKit::GtkAdjustmentWatcher::horizontalAdjustment): (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
  • webkit/webkitwebview.cpp: (setHorizontalAdjustment): (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher. (getHorizontalAdjustment): Ditto. (getVerticalAdjustment): Ditto. (webkit_web_view_size_allocate): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Ditto. (webkit_web_view_init): Ditto.
  • webkit/webkitwebviewprivate.h: Ditto.
16:08 Changeset [86101] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when sending a sync message to a crashed web process
https://bugs.webkit.org/show_bug.cgi?id=60514
<rdar://problem/9281270>

Change WebProcessProxy::sendSync to return false if there's no connection.

Audit all WebProcessProxy::sendSync call sites to initialize reply parameters.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): (WebKit::WebPageProxy::getSelectedText): (WebKit::WebPageProxy::gestureWillBegin):
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::sendSync):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::insertText): (WebKit::WebPageProxy::getMarkedRange): (WebKit::WebPageProxy::getSelectedRange): (WebKit::WebPageProxy::characterIndexForPoint): (WebKit::WebPageProxy::executeKeypressCommands): (WebKit::WebPageProxy::writeSelectionToPasteboard): (WebKit::WebPageProxy::readSelectionFromPasteboard):
16:05 Changeset [86100] by abarth@webkit.org
  • 9 edits
    5 adds in trunk

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

Test that the function constructor is properly blocked.

  • http/tests/security/contentSecurityPolicy/function-constructor-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked.html: Added.
  • platform/chromium/test_expectations.txt:

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

When eval is disabled, we need to block the use of the function
constructor. However, the WebCore JSC bindings call the function
constructor directly to create inline event listeners. To support that
use, this patch adds an entrypoint that bypasses the check for whether
eval is enabled.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h:

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

Tests: http/tests/security/contentSecurityPolicy/function-constructor-allowed.html

http/tests/security/contentSecurityPolicy/function-constructor-blocked.html

  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
    • Update call site to the new entrypoint.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject):
    • Add some comments about the rediculousness of this implementation.
16:02 Changeset [86099] by crogers@google.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-05-09 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
https://bugs.webkit.org/show_bug.cgi?id=60396

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DenormalDisabler.h: Added. (WebCore::DenormalDisabler::DenormalDisabler): (WebCore::DenormalDisabler::~DenormalDisabler): (WebCore::DenormalDisabler::getCSR): (WebCore::DenormalDisabler::setCSR):
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::provideInput):
15:53 Changeset [86098] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Style cleanups in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=60504

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): Use m_ for member variables, and

use class initializer list.

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::marginWidthForChild): Pull out common code used in calc*PrefWidths
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo): Rewrite uses of FlexBoxIterator into for statements

rather than while loops.

(WebCore::RenderFlexibleBox::layoutHorizontalBox): ditto
(WebCore::RenderFlexibleBox::layoutVerticalBox): ditto
(WebCore::RenderFlexibleBox::applyLineClamp):
(WebCore::RenderFlexibleBox::allowedChildFlex): Rename variables w/h to width/height.

15:49 Changeset [86097] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Create a plug-in's MIME types preferences plist if it doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=57204
<rdar://problem/9195048>

Spawn a plug-in process and let it create the plist. For now, we'll do this on the
main thread since it's a rare one-time computation and we have an API function,
WKFrameCanShowMIMEType, which would have to block anyway.

  • PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain): If -createPluginMIMETypesPreferences is one of the command line argument keys, the plug-in path will be the argument value. Call NetscapePluginModule::createPluginMIMETypesPreferences to create the preferences file and then exit.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::contentsOfPropertyListAtURL): Move code to read a property list out into a helper function.

(WebKit::getMIMETypesFromPluginBundle):
If there's no property list file, try to create one.

(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):
Load the plug-in, find the BP_CreatePluginMIMETypesPreferences and call it.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::createPropertyListFile): Spawn a plug-in process and pass the -createPluginMIMETypesPreferences flag to it and then wait for it to exit.
15:47 Changeset [86096] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-09 Robert Hogan <robert@webkit.org>

Unreviewed, update test expectations.

Update platform-specific results after r86086

The unix test NPAPI plugin now supports the png mime type.

https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt:
15:36 Changeset [86095] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove unflaky media-related tests from test expectation.
https://bugs.webkit.org/show_bug.cgi?id=60500

Chromium bug is http://crbug.com/81660.

  • platform/chromium/test_expectations.txt:
15:29 Changeset [86094] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebKit/chromium

2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86091.
http://trac.webkit.org/changeset/86091
https://bugs.webkit.org/show_bug.cgi?id=60510

Broke Chromium win release build. (Requested by dave_levin on
#webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
15:27 Changeset [86093] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Abstract line deletion code into a function
https://bugs.webkit.org/show_bug.cgi?id=60501

No change in behavior, thus no testing.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine):
15:14 Changeset [86092] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

Cleared some stray executable bits on source files.

  • bindings/js/WorkerScriptDebugServer.cpp: Removed property svn:executable.
  • bindings/js/WorkerScriptDebugServer.h: Removed property svn:executable.
15:04 Changeset [86091] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-09 Tao Bai <michaelbai@chromium.org>

Reviewed by David Levin.

Handle the touch icon.
https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added a parameter to favIconURL() to specify the type of icon need to
return.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
14:56 Changeset [86090] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] DRT eventSender.addTouchPoint method is not setting the start position
https://bugs.webkit.org/show_bug.cgi?id=60487

When adding a new touch point, the start position of this point needs to be set.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint):
14:47 Changeset [86089] by andersca@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move EnvironmentVariables out into its own .cpp file
https://bugs.webkit.org/show_bug.cgi?id=60507

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp: Added. (WebKit::EnvironmentVariables::EnvironmentVariables): (WebKit::EnvironmentVariables::~EnvironmentVariables): (WebKit::EnvironmentVariables::set): (WebKit::EnvironmentVariables::get): (WebKit::EnvironmentVariables::appendValue): (WebKit::EnvironmentVariables::valueIfVariableHasName): (WebKit::EnvironmentVariables::createStringForVariable): (WebKit::EnvironmentVariables::copyEnvironmentVariables):
  • UIProcess/Launcher/mac/EnvironmentVariables.h: Added. (WebKit::EnvironmentVariables::environmentPointer):
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
14:42 Changeset [86088] by arv@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

  • fast/forms/radio-group-keyboard-change-event-expected.txt: Added.
  • fast/forms/radio-group-keyboard-change-event.html: Added.

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

Test: fast/forms/radio-group-keyboard-change-event.html

  • html/RadioInputType.cpp: (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click

event. The simulated click event will check it for us but more importantly it will fire the "change" event as
expected.

14:20 Changeset [86087] by abarth@webkit.org
  • 2 edits
    2 adds in trunk

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

14:09 Changeset [86086] by robert@webkit.org
  • 5 edits in trunk

2011-05-09 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-09 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
13:22 Changeset [86085] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove canvas usage of roundToDevicePixels
https://bugs.webkit.org/show_bug.cgi?id=60331

No new tests. This could only affect canvases at non-integral scale factors. Our tests only run in 1.0x.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
13:20 Changeset [86084] by xan@webkit.org
  • 2 edits in trunk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix logic in GCC version detection, it was reversed.

  • configure.ac:
12:57 Changeset [86083] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-09 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • Source/WebKit.pri:

2011-05-09 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • WebCore.pri:
12:49 Changeset [86082] by chang.shu@nokia.com
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <cshu@webkit.org>

Unreviewed.

Expected result for editing/inserting/insert-bg-font.html can be shared
https://bugs.webkit.org/show_bug.cgi?id=60498

  • editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
  • platform/gtk/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/qt/Skipped:
12:40 Changeset [86081] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Simple small-caps text is displayed in uniform size.
https://bugs.webkit.org/show_bug.cgi?id=60492

Covered by existing tests.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): In the FontPlatformData constructor used by SimpleFontData::scaledFontData(), pass the pixel size to both QFont and QRawFont to make small caps and emphasis marks have the correct size when rendered through the fast font path.
12:32 Changeset [86080] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-09 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make DumpRenderTree build in components for linux
https://bugs.webkit.org/show_bug.cgi?id=60491

  • WebKit.gyp: move some code that was in a Windows-only block to be used on all platforms.
12:32 Changeset [86079] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86075.
http://trac.webkit.org/changeset/86075
https://bugs.webkit.org/show_bug.cgi?id=60495

broke windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
12:22 Changeset [86078] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Remove unused FontPlatformData functions.
https://bugs.webkit.org/show_bug.cgi?id=60485

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::bold): Removed. (WebCore::FontPlatformData::family): Removed. (WebCore::FontPlatformData::italic): Removed. (WebCore::FontPlatformData::smallCaps): Removed.
12:20 Changeset [86077] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Always set the font rendering mode based on preference values

WebPage::platformInitialize and WebPage::platformPreferencesDidChange were fighting over the
font rendering mode. The platformInitialize code predates preference-based font rendering
mode support, and is now redundant and incorrect.

Fixes <http://webkit.org/b/60494> WebKit2 uses GDI text instead of CG text when
FontSmoothing preference is set to kWKFontSmoothingLevelNoSubpixelAntiAliasing in a .plist
on disk

Reviewed by Sam Weinig.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Removed code to set the font rendering mode.
platformPreferencesDidChange will take care of this for us.

12:07 Changeset [86076] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Clean up NetscapePluginModule::getPluginInfo
https://bugs.webkit.org/show_bug.cgi?id=60486

Make all 'get' functions take a PluginInfoStore::Plugin reference, since getPluginInfoFromPropertyLists
is going to need it to know the path and plug-in architecture.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::getPluginInfoFromCarbonResources): (WebKit::NetscapePluginModule::getPluginInfo):
12:04 Changeset [86075] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Take 2 on updating the WKSI libraries.

  • win/lib/WebKitSystemInterface.lib:
11:58 Changeset [86074] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9005982> REGRESSION (r85780): Flash of white when a WKView with composited content moves on-screen
https://bugs.webkit.org/show_bug.cgi?id=60488

Reviewed by Darin Adler.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Update m_compositingAccordingToProxyMessages,
since the DidUpdateBackingStoreState message also changes the compositing state in the proxy.

11:54 Changeset [86073] by inferno@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

2011-05-09 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines for r86065.

  • platform/chromium-linux/platform/gtk: Added.
  • platform/chromium-linux/platform/gtk/fonts: Added.
  • platform/chromium-linux/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac-leopard/platform: Added.
  • platform/chromium-mac-leopard/platform/gtk: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk: Added.
  • platform/chromium-mac/platform/gtk/fonts: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium-win/platform/gtk: Added.
  • platform/chromium-win/platform/gtk/fonts: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:26 Changeset [86072] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Add invalid file handle check.

https://bugs.webkit.org/show_bug.cgi?id=60483

11:23 Changeset [86071] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Update the popup menu code to grab the native control and initialize the
event handler properly.

https://bugs.webkit.org/show_bug.cgi?id=60482

11:20 Changeset [86070] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Make sure other controls adjust the rect to handle transforms, and turn off the
adjustment in 2.9.2+ where it is handled internally by wx.

Also add a couple drawing and focus handling fixes for text fields and menulist controls.

https://bugs.webkit.org/show_bug.cgi?id=60481

11:18 Changeset [86069] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Style fix: Function names must begin with lowercase letter and should not use "get".
https://bugs.webkit.org/show_bug.cgi?id=60475

  • dom/Document.cpp: (WebCore::Document::webkitVisibilityState):
  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString): Renamed.
  • page/PageVisibilityState.h:
11:14 Changeset [86068] by kevino@webkit.org
  • 3 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Create empty event handler to avoid new mouse capture assert added in wx 2.9 on wxMSW.

https://bugs.webkit.org/show_bug.cgi?id=60480

11:13 Changeset [86067] by abarth@webkit.org
  • 40 edits in trunk/Source

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60461

Fix many, many PassOwnPtr nits.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::detach):
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacks::didOpenFileSystem): (WebCore::ResolveURICallbacks::didOpenFileSystem):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayer::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::createRenderSurface):
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create):
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::TrackerRemoveOpenDatabaseTask::create):
  • storage/chromium/SQLTransactionClientChromium.cpp: (WebCore::NotifyDatabaseChangedTask::create):

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60461

Fixed many, many PassOwnPtr nits.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::transaction):
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index):
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::create): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::connect):
  • src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::create):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::DebuggerTask::DebuggerTask): (WebKit::DebuggerTask::~DebuggerTask): (WebKit::DebuggerTask::run): (WebKit::WebDevToolsAgent::interruptAndDispatch):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::deleteFunction):
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::open):
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::deleteFunction): (WebKit::WebIDBObjectStoreImpl::clear): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::setCallbacks):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDevToolsAgentClient):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContext):
  • src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
11:04 Changeset [86066] by chang.shu@nokia.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <cshu@webkit.org>

Unreviewed.

[Qt] editing/inserting/5803706-1.html has the incorrect expected result
https://bugs.webkit.org/show_bug.cgi?id=60479

  • platform/qt/editing/inserting/5803706-1-expected.txt: Removed.
10:52 WikiStart edited by ademar.reis@openbossa.org
(diff)
10:52 Changeset [86065] by mrobinson@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Add a pixel result for platform/gtk/fonts/fontconfig-synthetic-bold.html.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
10:51 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
10:47 Changeset [86064] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Soup] Clean up error handling in ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=60436

Instead of repeating the ResourceError creation twice, abstract
it into a helper method.

No new tests. This is a code cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::soupErrorShouldCauseLoadFailure): Added. (WebCore::convertSoupErrorToResourceError): Added. (WebCore::sendRequestCallback): Use the new helpers. (WebCore::readCallback): Ditto.
10:32 Changeset [86063] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Pull jsonresults_unittest test cases out into separate test methods.
https://bugs.webkit.org/show_bug.cgi?id=60418

  • TestResultServer/model/jsonresults_unittest.py:
10:29 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
10:19 Changeset [86062] by eric@webkit.org
  • 2 edits
    1 add in trunk/Websites/webkit.org

2011-05-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add guidelines for feature addition to webkit.org (per disccusion at contributor meeting)
https://bugs.webkit.org/show_bug.cgi?id=59672

  • coding/adding-features.html: Added.
  • nav.inc:
10:13 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
09:32 Changeset [86061] by inferno@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Add a crash test for r85964.
https://bugs.webkit.org/show_bug.cgi?id=59473

  • fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
  • fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.
09:29 Changeset [86060] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r85869): Restore dirty line logic in RenderInline::destroy.
https://bugs.webkit.org/show_bug.cgi?id=60448

Test: fast/inline/inline-destroy-dirty-lines-crash.html

  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):

2011-05-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not when failing to dirty lines while removing
a inline.
https://bugs.webkit.org/show_bug.cgi?id=60448

  • fast/inline/inline-destroy-dirty-lines-crash-expected.txt: Added.
  • fast/inline/inline-destroy-dirty-lines-crash.html: Added.
09:15 Changeset [86059] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip 2 more flaky svg tests failing by one pixel in
32-bits Debug, see bug 39022.

  • platform/gtk/Skipped:
08:38 Changeset [86058] by alex@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] WidgetGtk setFocus can not access directly the widget in WK2
https://bugs.webkit.org/show_bug.cgi?id=60016

Added code to check the situation where we do not have direct
access to the widget. We use the page to grab the focus which
would send a request to the UIProcess in WK2.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
08:27 BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
08:23 Changeset [86057] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <andreas.kling@nokia.com>

Unreviewed. Re-skip two failing inspector tests on Qt.

They still fail in the bot's environment for whatever reason.

  • platform/qt/Skipped:
08:00 Changeset [86056] by aroben@apple.com
  • 3 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Automatically touch WebKit.idl whenever any other WebKit1 IDL file changes

Fixes <http://webkit.org/b/60468> WebKit.idl needs to be manually touched whenever any other
WebKit1 IDL file changes to avoid build errors

Reviewed by Tim Hatcher.

Updated for script rename.

  • JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Renamed

from react-to-vsprops-changes.py.
(top level): Moved a constant here from main.
(main): Moved most code from here to react_to_vsprops_changes. Added a call to the new
react_to_webkit1_interface_changes function.
(react_to_vsprops_changes): Moved code here from main. Updated to use the
TOP_LEVEL_DIRECTORY global. Moved some code from here to mtime_of_newest_file_matching_globa
and touch_if_older_than.
(react_to_webkit1_interface_changes): Added. Touches WebKit.idl if any other WebKit1 IDL
file has changed.
(mtime_of_newest_file_matching_glob): Added. Code came from main.
(touch_if_older_than): Added. Code came from main.

07:58 Changeset [86055] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
https://bugs.webkit.org/show_bug.cgi?id=60387

Update the expected results for the argument types after the lastest updates
in the getUserMedia specification. The test has been disabled temporarily
and will be re-enabled by 60177 since some exceptions are risen after parsing
the provided options.

  • fast/dom/MediaStream/argument-types-expected.txt:
  • fast/dom/MediaStream/script-tests/argument-types.js: (ObjectThrowingException.prototype.toString):
  • platform/chromium/test_expectations.txt:

2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
https://bugs.webkit.org/show_bug.cgi?id=60387

Perform the required changes to support rising exceptions in the
navigator.getUserMedia method. This is required by the latest changes in the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::V8Navigator::webkitGetUserMediaCallback):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/Navigator.h:
  • page/Navigator.idl:
07:13 Changeset [86054] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Qt 4.8 fix.

  • WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
07:06 Changeset [86053] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Minor skiplist cleanup.

Unskip two inspector tests that aren't failing.
Added explanation for why http/tests/misc/redirect-to-external-url.html is skipped.

  • platform/qt/Skipped:
07:06 Changeset [86052] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Windows project file fix after r86047

  • WebCore.vcproj/WebCore.vcproj: Added missing closing tags.
06:51 Changeset [86051] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
https://bugs.webkit.org/show_bug.cgi?id=60417

Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
instead of the PlatformCALayer everywhere.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
06:41 Changeset [86050] by rwlbuis@webkit.org
  • 78 edits in trunk/Source/WebCore

2011-05-09 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
https://bugs.webkit.org/show_bug.cgi?id=22576

Add tag name ASSERTs in SVG Element constructors.

No new tests, since no change in behaviour.

04:22 Changeset [86049] by mahesh.kulkarni@nokia.com
  • 4 edits in trunk

2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60458

Update all pages with Mock position/error/permission.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition):

2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60458

Unskipping fast/dom/Geolocation/window-close-crash.html.

  • platform/qt/Skipped:
04:17 Changeset [86048] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] one skipped 2d-transforms layout test passes on Qt Linux - skip list to be updated
https://bugs.webkit.org/show_bug.cgi?id=60399

  • platform/qt/Skipped:
04:00 Changeset [86047] by commit-queue@webkit.org
  • 33 edits
    13 adds in trunk

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • fast/events/page-visibility-iframe-delete-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-delete-test.html: Added.
  • fast/events/page-visibility-iframe-move-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-move-test.html: Added.
  • fast/events/page-visibility-iframe-propagation-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-propagation-test.html: Added.
  • fast/events/page-visibility-transition-test-expected.txt: Added.
  • fast/events/page-visibility-transition-test.html: Added.
  • fast/events/resources/page-visibility-iframe-delete-test-frame.html: Added.
  • fast/events/resources/page-visibility-iframe-move-new-page.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

Tests: fast/events/page-visibility-iframe-delete-test.html

fast/events/page-visibility-iframe-move-test.html
fast/events/page-visibility-iframe-propagation-test.html
fast/events/page-visibility-transition-test.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::visibilityState): (WebCore::Document::webkitVisibilityState): (WebCore::Document::webkitIsVisible): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:
  • page/Frame.cpp: (WebCore::Frame::dispatchVisibilityStateChangeEvent):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setVisibilityState): (WebCore::Page::visibilityState):
  • page/Page.h:
  • page/PageVisibilityState.cpp: Added. (WebCore::GetPageVisibilityStateString):
  • page/PageVisibilityState.h: Added.

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • WebKit.gyp:
  • public/WebPageVisibilityState.h: Added.
  • public/WebView.h: (WebKit::WebView::setVisibilityState):
  • public/WebViewClient.h: (WebKit::WebViewClient::visibilityState):
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setVisibilityState):
  • src/WebViewImpl.h:

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • DumpRenderTree/LayoutTestController.cpp: (setPageVisibilityCallback): (resetPageVisibilityCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::setPageVisibility): (LayoutTestController::resetPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::resetPageVisibility): (LayoutTestController::setPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.h:
03:55 Changeset [86046] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Venkat Penukonda <venkat.2.penukonda@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt]6 of the skipped canvas layout tests pass on Qt Linux
https://bugs.webkit.org/show_bug.cgi?id=60382

  • platform/qt/Skipped: Removed passing canvas tests
03:48 Changeset [86045] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

Build fix for WebKit 2 on Qt

Reviewed by Andreas Kling.

Qt treats warnings as errors so it does not build with unused variables. This patch removed two unused variable in WebKit 2.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::createTiles):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

02:19 Changeset [86044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement expanding CSS border properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60456

No new tests added as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Create CSS border expanding property handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property handlers that are no longer needed.

05/08/11:

21:37 Changeset [86043] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r86042.
http://trac.webkit.org/changeset/86042

The change contains an incorrect specification.

  • platform/chromium/test_expectations.txt:
21:19 Changeset [86042] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-08 MORITA Hajime <morrita@google.com>

Unreviewed marking flaky test (insecure-plugin-in-iframe.html)

  • platform/chromium/test_expectations.txt:
20:29 Changeset [86041] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
https://bugs.webkit.org/show_bug.cgi?id=60376

Added tests to ensure selectstart event is fired when a user selects all contents
and script can prevent such selection change in selectstart's event handler.

  • fast/events/selectstart-on-selectall-expected.txt: Added.
  • fast/events/selectstart-on-selectall.html: Added.
  • fast/events/selectstart-prevent-selectall-expected.txt: Added.
  • fast/events/selectstart-prevent-selectall.html: Added.

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

selectstart event does not fire when selection is made via select all
https://bugs.webkit.org/show_bug.cgi?id=60376

Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
document, editable region, or text control.

Tests: editing/selection/selectstart-on-selectall.html

editing/selection/selectstart-prevent-selectall.html

  • dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is input element or textarea element when the current selection is inside a shadow DOM, and the root editable element if it's inside a non-shadow editable region, and the body element otherwise.
  • html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer declared in Node.
19:16 Changeset [86040] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-08 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
https://bugs.webkit.org/show_bug.cgi?id=60249

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove special-case code and use appropriate macro.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setColumnBreakInside): Assert that supported values are used.
17:40 Changeset [86039] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a DragCaretController from FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60273

Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
DragCaretController and FrameSelection and provides functions to paint caret.

Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.

  • WebCore.exp.in:
  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Added. (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true. (WebCore::DragCaretController::isContentRichlyEditable): Added. (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase. (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection. (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController. (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification. (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved and respondToNodeModification. Note that the position DragCaretController holds is equivalent to FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position, we used to execute the first if clause and cleared render tree selection and DOM tree selection. This is exactly what new DragCaretController::nodeWillBeRemoved does. (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions. (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection. (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned. Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if FrameSelection's start was not null. (WebCore::caretRendersInsideNode): Moved; Made static local. (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer. (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer. (WebCore::DragCaretController::caretRenderer): Ditto. (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments. (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*. (WebCore::CaretBase::caretRepaintRect): Ditto. (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect, and shouldRepaintCaret with extra arguments. (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable. (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect. (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect. (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret. (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret. (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for DragCaretController. (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
  • editing/FrameSelection.h: (WebCore::CaretBase::localCaretRectForPainting): Added. (WebCore::DragCaretController::isContentEditable): Added. (WebCore::DragCaretController::hasCaret): Added. (WebCore::DragCaretController::caretPosition): Added. (WebCore::DragCaretController::clear): Added.
  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): Uses DragCaretController. (WebCore::DragController::dispatchTextInputEventFor): Ditto. (WebCore::DragController::concludeEditDrag): Ditto. (WebCore::DragController::placeDragCaret): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
  • page/Page.h: (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
14:49 Changeset [86038] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86037.
http://trac.webkit.org/changeset/86037
https://bugs.webkit.org/show_bug.cgi?id=60453

broke Windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
14:30 Changeset [86037] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Update the WKSI libraries.

Rubber-stamped by Alice Liu.

  • win/lib/WebKitSystemInterface.lib:
13:56 Changeset [86036] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Make JSRetainPtr work with JSGlobalContextRefs.
https://bugs.webkit.org/show_bug.cgi?id=60452

Reviewed by Dan Bernstein.

Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.

  • API/JSRetainPtr.h:

(JSRetain):
(JSRelease):

13:24 Changeset [86035] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More rebaselines for r86028.

  • platform/chromium-linux/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.txt:
13:13 Changeset [86034] by imasaki@chromium.org
  • 5 edits in trunk/LayoutTests

2011-05-08 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Eric Seidel.

[Chromium] add rebaseline for video-volume-slider for GPU.
https://bugs.webkit.org/show_bug.cgi?id=60427

These tests are failing due to text.
http://code.google.com/p/chromium/issues/detail?id=81482

  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:
12:47 Changeset [86033] by inferno@chromium.org
  • 15 edits
    6 adds
    2 deletes in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More chromium rebaseline for r86028.

  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-expected.png:
  • platform/chromium-linux/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-linux/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-linux/fast/text/trailing-white-space-expected.png:
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.txt:
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.txt:
  • platform/chromium/test_expectations.txt:
11:58 Changeset [86032] by inferno@chromium.org
  • 108 edits
    4 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium Rebaselines for r86028.

  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/chromium/test_expectations.txt:
11:53 Changeset [86031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-08 Kamil Blank <k.blank@samsung.com>

Reviewed by Antonio Gomes.

Added new commands to be called by ewk_view_editor_command.
Due to this change ewk_view_select_* functions have been removed.
https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_view.cpp: (ewk_view_execute_editor_command):
  • ewk/ewk_view.h:
10:36 Changeset [86030] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated a platform-specific expected result again after r86028.

  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
10:13 Changeset [86029] by mitz@apple.com
  • 48 edits in trunk/LayoutTests

Updated some platform-specific expected results after r86028.

  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/text/justified-selection-at-edge-expected.txt:
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.txt:
  • platform/qt/fast/text/justify-nbsp-expected.txt:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
09:27 Changeset [86028] by mitz@apple.com
  • 63 edits in trunk

<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
https://bugs.webkit.org/show_bug.cgi?id=60432

Reviewed by Darin Adler.

Source/WebCore:

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
variable is a (truncated) int anyway.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
so that the right amount is added to the total width. Also changed to use an early return.

LayoutTests:

  • fast/text/justify-nbsp-expected.png:
  • fast/text/justify-nbsp-expected.txt:
  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.png:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
09:09 Changeset [86027] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:
05:18 Changeset [86026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
https://bugs.webkit.org/show_bug.cgi?id=58556

Tests: fast/canvas/webgl/gl-teximage.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):

05/07/11:

23:47 Changeset [86025] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Reverted unintended changes in r86024

23:42 Changeset [86024] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
https://bugs.webkit.org/show_bug.cgi?id=60443

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/replaced/table-percent-height-positioned.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
doesn’t affect the table cell’s height).

LayoutTests:

  • fast/replaced/table-percent-height-positioned-expected.png: Added.
  • fast/replaced/table-percent-height-positioned-expected.txt: Added.
  • fast/replaced/table-percent-height-positioned.html: Added.
22:20 Changeset [86023] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-07 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Cleanup unexpected test passes in the gpu webkit tests
https://bugs.webkit.org/show_bug.cgi?id=60393

  • platform/chromium/test_expectations.txt:
21:42 Changeset [86022] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overlay fades out instead of disappearing immediately

Reviewed by Timothy Hatcher.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::hideFindUI): Do not fade out the overlay.

21:42 Changeset [86021] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Avoid copying a header file into the WebKit2 framework wrapper.

  • WebKit2.xcodeproj/project.pbxproj: Corrected the target membership of HTTPCookieAcceptPolicy.h.
19:50 Changeset [86020] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Testing EWS spins on patches with a large number of failures
https://bugs.webkit.org/show_bug.cgi?id=60441

In cases where the tree has a small number of persistent failures but a
patch has a large number of failures, we weren't believing any results.
That lead to us retrying the patch forever while we waited for
trustworthy results that would never come.

This patch loosens the semantics of unexpected_failures to return a
subset (rather than the exact set) of unexpected failures. In the case
where the tree has a bounded number of failures and the patch has an
unbounded number of failures, we can accurately compute such a subset
and reject the patch.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
18:25 Changeset [86019] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows WebKit2 Release Tests]
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing since r85795.
https://bugs.webkit.org/show_bug.cgi?id=60442

Add win-wk2 failing expected results to get the bots green.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
18:09 Changeset [86018] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445

caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
17:58 Changeset [86017] by inferno@chromium.org
  • 5 edits in trunk/Source

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
http://trac.webkit.org/changeset/85974
https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):

2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85974.
http://trac.webkit.org/changeset/85974
https://bugs.webkit.org/show_bug.cgi?id=60444

broke browser tests (Requested by inferno-sec on #webkit).

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
17:49 Changeset [86016] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
16:46 Changeset [86015] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled

Add another test (fast/events/popup-blocked-from-mousemove.html) to the mac-wk2 Skipped list
to get the bots green.

  • platform/mac-wk2/Skipped:
16:39 Changeset [86014] by dbates@webkit.org
  • 1 edit in trunk/Source/WebKit/efl/ChangeLog

2011-05-07 Daniel Bates <dbates@webkit.org>

Update title of bug in change log entry for changeset <http://trac.webkit.org/changeset/86012>
so as to be consistent with the name of the bug in <https://bugs.webkit.org/show_bug.cgi?id=60151>.

16:37 Changeset [86013] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Add willPerformClientRedirect to the user-gesture tests.

  • fast/frames/location-redirect-user-gesture-expected.txt:
  • fast/frames/meta-refresh-user-gesture-expected.txt:

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Create a UserGestureIndicator when calling the clientRedirected callback.

  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer):

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):

2011-05-07 Joe Mason <jmason@rim.com>

Reviewed by Daniel Bates.

FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
https://bugs.webkit.org/show_bug.cgi?id=52211

Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
(For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willPerformClientRedirect): (WebViewHost::didStartProvisionalLoad):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
16:34 Changeset [86012] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-07 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Daniel Bates.

[EFL] Remove ewk_tile_unused_cache_free function form public api
https://bugs.webkit.org/show_bug.cgi?id=60151

The ewk_tile_unused_cache_free function should be only called by
ewk_tile_unused_cache_unref function. Calling this function without
considering reference counting may lead to fatal results.

  • ewk/ewk_tiled_model.c: (_ewk_tile_unused_cache_free): (ewk_tile_unused_cache_unref):
  • ewk/ewk_tiled_model.h:
16:34 Changeset [86011] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
introduction in r85669.
https://bugs.webkit.org/show_bug.cgi?id=60272

Add expected failing text results to get the bots green.

Note: these tests still need pixel results to be generated both for mac-wk2 and win-wk2.

  • platform/mac-wk2/editing/selection: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt: Added.
16:15 Changeset [86010] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

2011-05-07 Daniel Bates <dbates@webkit.org>

Update change log entry for changeset <http://trac.webkit.org/changeset/86009> to
explain that this was an attempt to fix the build after changeset 86007
<http://trac.webkit.org/changeset/86007> (bug #60438).

16:08 Changeset [86009] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-05-07 Daniel Bates <dbates@webkit.org>

Remove some more references to isTiger(), which was removed in changeset 86007
<http://trac.webkit.org/changeset/86007> (bug #60438).

  • Scripts/old-run-webkit-tests:
    • Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and file local variable.
15:59 Changeset [86008] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-07 Dawit Alemayehu <adawit@kde.org>

Reviewed by Daniel Bates.

Fix compile with GCC 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60380

Remove unused local variable from code.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch):
12:56 Changeset [86007] by psolanki@apple.com
  • 5 edits in trunk/Tools

Remove references to Tiger in scripts
https://bugs.webkit.org/show_bug.cgi?id=60438

Reviewed by Darin Adler.

Remove isTiger() and all of the code that depends on it.

  • Scripts/build-webkit:
  • Scripts/ensure-valid-python:
  • Scripts/gdb-safari:
  • Scripts/webkitdirs.pm:
07:36 Changeset [86006] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-07 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Adam Roben.

[Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961
https://bugs.webkit.org/show_bug.cgi?id=60420

  • WebProcess/Plugins/Netscape/NetscapePluginNone.cpp: (WebKit::NetscapePlugin::platformVisibilityDidChange):
00:52 Changeset [86005] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 85586
BUG=81348
Review URL: http://codereview.chromium.org/6953015

00:32 Changeset [86004] by cevans@google.com
  • 2 edits
    14 copies in branches/chromium/742

Merge 85876
BUG=72832
Review URL: http://codereview.chromium.org/6952018

00:17 Changeset [86003] by cevans@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/rendering

Merge 85705
BUG=79746
Review URL: http://codereview.chromium.org/6948015

00:08 Changeset [86002] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when sending a wheel event to a node with no shadow ancestor node
https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>

Reviewed by Alice Liu.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.

Note: See TracTimeline for information about the timeline view.