Timeline



May 13, 2011:

10:22 PM Changeset in webkit [86480] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • ewk/ewk_history.cpp:
9:42 PM Changeset in webkit [86479] by dcheng@chromium.org
  • 1 edit
    3 deletes in branches/chromium/742

Revert 86470 - Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/6973064

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/6973070

9:20 PM Changeset in webkit [86478] by ap@apple.com
  • 5 edits
    3 adds in trunk

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

  • http/tests/appcache/interrupted-update-expected.txt: Added.
  • http/tests/appcache/interrupted-update.html: Added.
  • http/tests/appcache/resources/interrupted-update.manifest: Added.
  • http/tests/appcache/main-resource-redirect.html:
  • http/tests/appcache/non-html.xhtml: Now that we dispatch an error even when aborting a load due to navigation, error event handler was getting called after notifyDone().

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

Test: http/tests/appcache/interrupted-update.html

The reason was two-fold:
1) Cache group state wasn't fully reset after a failed cache update (or an initial load).
2) The cache group is not deleted until after after the navigation (from autorelease pool),
so the failed and sorry old version was picked up by cache selection algorithm.

The latter is more of a surprising behavior than a problem in itself. Keeping an appcache in
memory for reload is generally a good thing for performance.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Added a FIXME about half-baked state resetting code that sent me looking for a wrong fix originally. (WebCore::ApplicationCacheGroup::stopLoadingInFrame): Stopped load is an update failure like any other, so we should call cacheUpdateFailed(), which knows how to reset state.
6:18 PM Changeset in webkit [86477] by enrica@apple.com
  • 13 edits in trunk/Source

REGRESSION (WK2): Can't drag and drop a link or image from Safari to Desktop
https://bugs.webkit.org/show_bug.cgi?id=60819
<rdar://problem/9370689>

Reviewed by Darin Adler and Brian Weinstein.

Source/WebCore:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.
It also fixes a regression introduced by r70914, that was causing the content of the
shortcut files to be corrupted. Using ascii() to convert from String to CString was
causing '\n' and '\r' to be replaced with '?'.

  • platform/DragData.h:
  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fileDescriptorFormat): Moved from ClipboardWin.cpp.
(WebCore::fileContentFormatZero): Moved from ClipboardWin.cpp.
(WebCore::getFileDescriptorData): Serialize FileDescriptor type.
(WebCore::getFileContentData): Serialize FileContent type.
(WebCore::setFileDescriptorData): Deserialize FileDescriptor type.
(WebCore::setFileContentData): Deserialize FileContent type.
(WebCore::setCFData): Added missing initialization of the tymed field
that was causing the cfHDrop format not to be deserialized correctly.

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::createGlobalHDropContent): Changed ascii() to latin1().
(WebCore::ClipboardWin::writeURL):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::getDragFileDescriptorData):
(WebCore::DragData::getDragFileContentData):

Source/WebKit2:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.

  • Platform/CoreIPC/Arguments.h: Added support for messages with 10 arguments.

(CoreIPC::Arguments10::Arguments10):
(CoreIPC::Arguments10::encode):
(CoreIPC::Arguments10::decode):
(CoreIPC::In):
(CoreIPC::Out):

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added support for memebers with 10 arguments.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startDragDrop):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp:

(WebKit::WebDragClient::startDrag):

6:05 PM Changeset in webkit [86476] by andersca@apple.com
  • 9 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

5:55 PM Changeset in webkit [86475] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Fix the build.

Add includes that the builders are suddenly complaining about...

  • page/DragState.h:
5:24 PM Changeset in webkit [86474] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Disable failing test on chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
5:03 PM Changeset in webkit [86473] by msaboff@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-13 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Backing store may not get discarded due to stopped timer
https://bugs.webkit.org/show_bug.cgi?id=60816

Changed the backing store timer to restart if it has been stopped.
The evaluation is done when the view's state is changed.
This change appears to be worth ~3MB (one backing store worth)
during memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
4:31 PM Changeset in webkit [86472] by dcheng@chromium.org
  • 9 edits
    2 adds in trunk

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
https://bugs.webkit.org/show_bug.cgi?id=59409

Add a new test to test drag start edge cases on Mac (because of a non-zero text drag delay)
as well as rebase an existing test.

  • fast/css/user-drag-none.html: Text nodes are no longer draggable.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt: Added.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html: Added.

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
https://bugs.webkit.org/show_bug.cgi?id=59409

Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
defined in the spec. Among other things:

  • draggableNode() no longer returns text nodes when dragging anchors.
  • When starting a drag over an image in a selection, prefer to drag the selection.
  • Several redundant hit tests have been removed.
  • Minor refactoring to make the logic easier to follow.

Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html

  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::startDrag):
  • page/DragController.h:
  • page/DragState.h: (WebCore::DragState::shouldDispatchEvents):
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateDragSourceActionsAllowed): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::ExactlyOneBitSet): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
4:16 PM Changeset in webkit [86471] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

4:09 PM Changeset in webkit [86470] by dcheng@chromium.org
  • 1 edit
    3 copies in branches/chromium/742

Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/6973064

4:07 PM Changeset in webkit [86469] by oliver@apple.com
  • 66 edits in trunk/Source

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSCell.cpp: (JSC::slowValidateCell):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
  • runtime/Structure.h: (JSC::JSCell::classInfo):
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
  • wtf/Assertions.h:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):
3:56 PM Changeset in webkit [86468] by andersca@apple.com
  • 2 edits in trunk/Tools

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
3:37 PM Changeset in webkit [86467] by andersca@apple.com
  • 22 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

In NetscapePluginStream::sendJavaScriptStream, we were incorrectly passing the result URL
to the stream, instead of the result. Also, store the request URL in the NetscapePluginStream object
to avoid sending it over the wire.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::didEvaluateJavaScript):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::loadURL): (WebKit::NetscapePlugin::didEvaluateJavaScript): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::NetscapePluginStream): (WebKit::NetscapePluginStream::sendJavaScriptStream):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h: (WebKit::NetscapePluginStream::create):
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::didEvaluateJavaScript):
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest):

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • plugins/get-url-with-javascript-url-expected.txt: Added.
  • plugins/get-url-with-javascript-url.html: Added.

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am: Add files.
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added. (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL): (GetURLWithJavaScriptURL::NPP_New): (GetURLWithJavaScriptURL::NPP_NewStream): (GetURLWithJavaScriptURL::NPP_DestroyStream): (GetURLWithJavaScriptURL::NPP_WriteReady): (GetURLWithJavaScriptURL::NPP_Write):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_URLNotify): call the PluginTest NPP wrappers.
3:32 PM Changeset in webkit [86466] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: remove objectstore
https://bugs.webkit.org/show_bug.cgi?id=60768

This test creates an objectstore, populates it with 100 records,
deletes the objectstore, and checks that the objectStoreNames array
is updated properly at each step.

  • storage/indexeddb/mozilla/remove-objectstore-expected.txt: Added.
  • storage/indexeddb/mozilla/remove-objectstore.html: Added.
3:30 PM Changeset in webkit [86465] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Removed chromium border-fit-lines.html suppression as it seems to pass now. Unreviewed.

  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [86464] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
3:00 PM Changeset in webkit [86463] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Mikhail Naganov <mnaganov@chromium.org>

Web Inspector: Unreviewed image glyph position fix in CSS after r85588.

  • inspector/front-end/heapProfiler.css: (.heapshot-help-status-bar-item .glyph):
2:48 PM HighLevelOverview edited by levin@chromium.org
(diff)
2:44 PM Changeset in webkit [86462] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
https://bugs.webkit.org/show_bug.cgi?id=60784

Test that we block popup windows from inside sandbox.

  • http/tests/security/no-popup-from-sandbox-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top.html: Added.
  • http/tests/security/no-popup-from-sandbox.html: Added.

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
https://bugs.webkit.org/show_bug.cgi?id=60784

Previously, we weren't implementing this requirement from the spec:

"This flag also prevents content from creating new auxiliary browsing
contexts, e.g. using the target attribute or the window.open() method."

Tests: http/tests/security/no-popup-from-sandbox-top.html

http/tests/security/no-popup-from-sandbox.html

  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::checkNewWindowPolicy):
2:35 PM Changeset in webkit [86461] by rniwa@webkit.org
  • 5 edits
    8 adds in trunk

2011-05-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
https://bugs.webkit.org/show_bug.cgi?id=60600

Added tests to ensure WebKit does not fire click event when the target node
is removed in mouseup event.

  • fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-deep.html: Added.
  • fast/events/remove-target-in-mouseup-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback.html: Added.
  • fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-twice.html: Added.
  • fast/events/remove-target-in-mouseup.html: Added.

2011-05-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
https://bugs.webkit.org/show_bug.cgi?id=60600

Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
from the document. New behavior matches Internet Explorer and Firefox.

Tests: fast/events/remove-target-in-mouseup-deep.html

fast/events/remove-target-in-mouseup-insertback.html
fast/events/remove-target-in-mouseup-twice.html
fast/events/remove-target-in-mouseup.html

  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved. (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
  • page/EventHandler.cpp: (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode or one of its ancestor is removed from the document.
  • page/EventHandler.h:
1:59 PM Changeset in webkit [86460] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Joseph Pecoraro.

Hide appcache status bar items
https://bugs.webkit.org/show_bug.cgi?id=60799

We have a number of non-trivial bugs that make these more misleading than helpful to developers.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): Just hide the items for now. Removing all support code would be complicated, and not helpful.
1:46 PM Changeset in webkit [86459] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-05-13 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Make some page() member functions const
https://bugs.webkit.org/show_bug.cgi?id=60794

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Make page() const.
  • UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::page): Make page() const.
  • UIProcess/WebInspectorProxy.h: (WebKit::WebInspectorProxy::page): Make page() const.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
1:40 PM Changeset in webkit [86458] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=60785

  • http/tests/security/no-indexeddb-from-sandbox-expected.txt: Added.
  • http/tests/security/no-indexeddb-from-sandbox.html: Added.

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=60785

We're supposed to return a null indexedDB factory when inside an iframe
sandbox.

Test: http/tests/security/no-indexeddb-from-sandbox.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
1:22 PM Changeset in webkit [86457] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: indexes with keys and key ranges
https://bugs.webkit.org/show_bug.cgi?id=60733

This megatest creates an object store with several rows of data,
creates indexes on each key, then iterates each index in a variety
of ways (keys, key ranges, etc).

  • storage/indexeddb/mozilla/indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/indexes.html: Added.
12:54 PM Changeset in webkit [86456] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Load plugins in the order they're found

Fixes <http://webkit.org/b/60788> <rdar://problem/9435787> REGRESSION (r69790): WebKit2
doesn't prefer plugins in the additional plugins directory

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::addFromVector):
Changed to use a ListHashSet instead of a HashSet to store the plugin paths.

12:54 PM Changeset in webkit [86455] by Adam Roben
  • 4 edits in trunk/Source/WebCore

Fix manual tests that got broken by the move of WebCore into Source

  • manual-tests/plugins/object-clipping.html:
  • manual-tests/pointer-events.html:
  • manual-tests/video-waiting-seeking.html:

Updated some paths.

12:48 PM Changeset in webkit [86454] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-13 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
https://bugs.webkit.org/show_bug.cgi?id=60738

Remove supression for previously failing compositor tests.

  • platform/chromium/test_expectations.txt:

2011-05-13 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
https://bugs.webkit.org/show_bug.cgi?id=60738

Bind texture before setting its filtering state.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateFromPixels):
12:40 PM Changeset in webkit [86453] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=60787
Add some assertions to ApplicationCacheGroup

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto. (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before resetting it. (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or resource hanging around. (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
12:28 PM Changeset in webkit [86452] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-13 Tao Bai <michaelbai@chromium.org>

Reviewed by Darin Fisher.

Handle the touch icon.
https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added method iconURLs() to specify the type of icon need to return.
The favIconURL() is deprecated and will be removed later.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL): (WebKit::WebIconURL::iconType): (WebKit::WebIconURL::iconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
12:09 PM Changeset in webkit [86451] by weinig@apple.com
  • 64 edits
    1 add in trunk/Source

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • src/AutoFillPopupMenuClient.cpp:
  • src/PlatformBridge.cpp:
  • src/WebPopupMenuImpl.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • Api/qgraphicswebview.cpp:
  • WebCoreSupport/ChromeClientQt.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/GtkAdjustmentWatcher.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebDragClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebFrame.cpp: (WebFrame::setPrinting):
  • WebView.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebView/WebClipView.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Replace #includes in FrameView.h of Frame.h and Page.h with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityScrollView.cpp:
  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • css/MediaQueryMatcher.cpp:
  • dom/Range.cpp:
  • editing/SpellingCorrectionController.cpp:
  • history/CachedFrame.cpp:
  • html/HTMLBodyElement.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/parser/HTMLParserScheduler.cpp:
  • page/AdjustViewSizeOrNot.h: Added.
  • page/EditorClient.h:
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
  • page/FrameView.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
  • page/chromium/FrameChromium.cpp:
  • page/win/FrameCGWin.cpp:
  • page/win/FrameWin.cpp:
  • platform/efl/PopupMenuEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/gtk/WidgetGtk.cpp:
  • plugins/IFrameShimSupport.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderFrameBase.cpp:
  • rendering/RenderIFrame.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderWidget.cpp:
  • svg/SVGSVGElement.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
11:21 AM Changeset in webkit [86450] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress crasher in chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
11:21 AM Changeset in webkit [86449] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-13 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCollapsedBorder to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60739

Updating the last offending paint function that takes four ints
instead of an IntRect.

No new tests as this is simple refactoring.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
11:17 AM Changeset in webkit [86448] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-13 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r75823): Revert initialization back to the first RenderBlock
in the parent chain.
https://bugs.webkit.org/show_bug.cgi?id=60780

Test: fast/block/float/float-not-removed-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): In r75823, I forgot to initialize parentBlock, when the original code did and Hyatt did mention in c#5. Now, initializing parentBlock to the first RenderBlock in the parent chain.

2011-05-13 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to access a deleted float.
https://bugs.webkit.org/show_bug.cgi?id=60780

  • fast/block/float/float-not-removed-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-crash.html: Added.
11:11 AM Changeset in webkit [86447] by robert@webkit.org
  • 9 edits
    2 adds in trunk

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
11:00 AM Changeset in webkit [86446] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TextEditor should support editing a range.
https://bugs.webkit.org/show_bug.cgi?id=59688

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype.setEditableRange): (WebInspector.TextEditorMainPanel.prototype.clearEditableRange): (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.set readOnly): (WebInspector.TextEditorMainChunk.prototype.get readOnly): (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
  • inspector/front-end/textViewer.css: (.text-editor-read-only):
10:36 AM Changeset in webkit [86445] by Adam Roben
  • 3 edits in trunk/Tools

Exclude the Leopard NRWT bot from the core builder set

Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
in the core builder set.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
regexps.

10:36 AM Changeset in webkit [86444] by Adam Roben
  • 2 edits in trunk/Tools

Group all the NRWT bots together

This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
bots are experimental, it seems best not to clutter up the non-experimental bots with
experimental ones.

Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
on build.webkit.org

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the

Chromium testers, which also use new-run-webkit-tests.

10:25 AM Changeset in webkit [86443] by podivilov@chromium.org
  • 7 edits in trunk

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=60263

  • inspector/debugger/resources/obfuscated.js: (formatted1): (formatted2):
  • inspector/debugger/script-formatter.html:

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=60263

Source mapping is broken for script chunks that are already formatted at the beginning
and at the end of the script (see script-formatter.html).

  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype._didFormatContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.originalToFormatted): (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage): (HTMLScriptFormatter.prototype.format):
  • inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.SourceMappingForFormattedSourceFile): (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine): (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
10:24 AM Changeset in webkit [86442] by Adam Roben
  • 5 edits
    5 adds in trunk

Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect changes

r79167 moved some code from setFrameRect to setBoundsSize, including a call to
frameRectsChanged. This was done because positionScrollbarLayers, which is called by
frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
frame rect changes.

This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
to be called at different times from frameRectsChanged. Then it restores the
frameRectsChanged call to setFrameRect, which fixes the bug.

Test: platform/win/plugins/iframe-inside-overflow.html

Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
plugins in Google Reader don't move when the article list is scrolled

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
call frameRectsChanged here when our frame rect hasn't changed.
(WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
in r79167.
(WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
positionScrollbarLayers to be called.
(WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.

Tools:

Add a plugin test that dumps the plugin window's rect

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.

(DumpWindowRect::DumpWindowRect): Just call up to the base class.
(DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
harness window and log it.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.

LayoutTests:

Add a test for windowed plugins inside iframes inside scrolled overflow areas

  • platform/win/plugins/iframe-inside-overflow-expected.txt: Added.
  • platform/win/plugins/iframe-inside-overflow.html: Added.

(loaded): Scrolls the div and tells the plugin to start its test (which will cause its
window rect to be logged).

  • platform/win/plugins/resources/dump-window-rect-iframe.html: Added.
10:24 AM Changeset in webkit [86441] by Adam Roben
  • 3 edits
    2 adds in trunk/Tools

Move code required for most tests of plugin window geometry into a base class

WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
having all the trickiness in a shared base class, writing new window geometry tests will be
much easier.

Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
WindowGeometryTest base class. Most of the code from this class was moved to the new base
class.
(WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
This is called by the base class when it is safe to check the window's geometry. Note that
the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
just vestigial code from an earlier version of this test.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new

WindowGeometryTest class.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from

WindowRegionIsSetToClipRect.
(WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
Subclasses can implement that function to perform their own tests.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
9:58 AM Changeset in webkit [86440] by robert@webkit.org
  • 3 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

Make fast/dom/object-embed-plugin-scripting.html compatible with non-Mac ports

https://bugs.webkit.org/show_bug.cgi?id=59930

  • fast/dom/resources/articles.m4a: Removed.
  • platform/chromium/test_expectations.txt: Unskip object-embed-plugin-scripting.html on Linux
  • platform/qt/Skipped: Unskip object-embed-plugin-scripting.html
  • plugins/object-embed-plugin-scripting-expected.txt: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting-expected.txt.
  • plugins/object-embed-plugin-scripting.html: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting.html.
  • plugins/resources/apple.gif: Added.
9:56 AM Changeset in webkit [86439] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-13 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Don't destroy a null FcPattern when failing to do a FontConfig match.
This crashes, and there's nothing FcDestroy could do with a null
pointer even if it didn't crash.
https://bugs.webkit.org/show_bug.cgi?id=60777

  • src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
9:55 AM Changeset in webkit [86438] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC.

Reviewed by nobody, build fix.

qobject_cast<> requires the class to be exported on MSVC,
removing it since the code that needs it is commented out for
the same reason.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::elementAreaAt):

9:54 AM Changeset in webkit [86437] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.

Reviewed by nobody, build fix.

  • tests/tests.pro:
9:40 AM HighLevelOverview edited by levin@chromium.org
(diff)
9:22 AM SourceDirectory created by levin@chromium.org
9:00 AM Changeset in webkit [86436] by mrobinson@webkit.org
  • 8 edits
    2 adds in trunk/Source

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
almost directly moved from the WebKit layer.

No new tests. This is covered by the editing tests.

  • GNUmakefile.list.am:
  • platform/gtk/KeyBindingTranslator.cpp: Added. (WebCore::backspaceCallback):Added. (WebCore::selectAllCallback):Added. (WebCore::cutClipboardCallback):Added. (WebCore::copyClipboardCallback):Added. (WebCore::pasteClipboardCallback):Added. (WebCore::toggleOverwriteCallback):Added. (WebCore::popupMenuCallback):Added. (WebCore::showHelpCallback):Added. (WebCore::deleteFromCursorCallback):Added. (WebCore::moveCursorCallback):Added. (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added. (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
  • platform/gtk/KeyBindingTranslator.h: Added. (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that the command vector now contains WTF::string. (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class. (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code. (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
  • UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
9:00 AM Changeset in webkit [86435] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-13 Steve VanDeBogart <vandebo@chromium.org>

Unreviewed.

Update expectations for GPU tests that use shadows after fix (Skia rev 1297).
https://bugs.webkit.org/show_bug.cgi?id=60742

  • platform/chromium/test_expectations.txt:
8:26 AM Changeset in webkit [86434] by zherczeg@webkit.org
  • 3 edits in trunk/Tools

2011-05-13 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Csaba Osztrogonác.

Missing 2nd #EOF if WebProcess is killed.
https://bugs.webkit.org/show_bug.cgi?id=60761

If the WebProcess is killed, only one #EOF is yielded
by WebKitTestRunner. However, run-webkit-test wait for
a second #EOF, which signals the finishing of pixel dump.
Since this never happens, run-webkit-test waits forever.

  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
8:09 AM Changeset in webkit [86433] by zecke@webkit.org
  • 3 edits in trunk/Source/WebCore

[android] Forward declare types for PlatformWidget and DragImage

https://bugs.webkit.org/show_bug.cgi?id=59890

This is fixing the compilation of files that include Widget.h or
DragImage.h.

8:09 AM Changeset in webkit [86432] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[android] OS(ANDROID) does not imply PLATFORM(ANDROID)

https://bugs.webkit.org/show_bug.cgi?id=59888

It is possible to build QtWebKit and others for OS(ANDROID). Let
the buildsystem decide which platform is to be build.

7:59 AM Changeset in webkit [86431] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped: Add 4 failing tests.
7:56 AM Changeset in webkit [86430] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix incremental html highlight.
https://bugs.webkit.org/show_bug.cgi?id=60163

SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
initialCondition object via condition link). This all worked because of another bug in tokenizers registry
that always returned new tokenizer object.
For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
state from string. That's why we need tokenizers to be truly stateless.

  • inspector/front-end/DOMSyntaxHighlighter.js: (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._highlightLines):
7:48 AM Changeset in webkit [86429] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[NRWT] chromium-linux tests shouldn't run on other platforms
https://bugs.webkit.org/show_bug.cgi?id=60162

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-13
Reviewed by Csaba Osztrogonác.

Remove _tests_for_other_platforms defs because r82753
implemented it properly in the baseclass in webkit.py.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
7:38 AM Changeset in webkit [86428] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Build fix after r86418

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Made the destructor public so that this class can be used with
[Pass]OwnPtr.

7:32 AM Changeset in webkit [86427] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped:
7:00 AM Changeset in webkit [86426] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
6:29 AM Changeset in webkit [86425] by hans@chromium.org
  • 4 edits in trunk/Source

2011-05-11 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
https://bugs.webkit.org/show_bug.cgi?id=60623

Fix the code for comparing two int64_t variables.
Also remove faulty line in ObjectStoreNamesKey::encode which was
uncovered by the unit test in this patch.

Very hard to cover with layout tests; covered by unit test.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::compareInts): (WebCore::IDBLevelDBCoding::KeyPrefix::compare): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): (WebCore::IDBLevelDBCoding::IndexDataKey::compare):

2011-05-11 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
https://bugs.webkit.org/show_bug.cgi?id=60623

Unit test for comparison of encoded keys.

  • tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
5:08 AM Changeset in webkit [86424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Darin Adler.

GraphicsContext3DQt.cpp fails to compile
https://bugs.webkit.org/show_bug.cgi?id=60740

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Change order of initializers.
3:34 AM Changeset in webkit [86423] by antonm@chromium.org
  • 1 edit
    23 adds in trunk/LayoutTests

2011-02-08 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611

This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.

Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
  • dom/Document.h:
3:21 AM Changeset in webkit [86422] by hans@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Add test for veryfing that transaction roll-back works, even with a
previously opened cursor still around.

  • storage/indexeddb/transaction-rollback-expected.txt: Added.
  • storage/indexeddb/transaction-rollback.html: Added.

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Let the IDBTransactionbackendImpl keep track of all open cursors, and
"close" them (i.e. finalizing the underlying SQLiteStatement) before
committing or rolling back the transaction. This fixes the problem
with opened cursors preventing transaction rollback.

Test: storage/indexeddb/transaction-rollback.html

  • storage/IDBBackingStore.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::close):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBSQLiteBackingStore.cpp:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::registerOpenCursor): (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h: (WebCore::IDBTransactionBackendInterface::registerOpenCursor): (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Implement two new methods in IDBTransactionBackendInterface.

  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::registerOpenCursor): (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
  • src/IDBTransactionBackendProxy.h:
2:56 AM Changeset in webkit [86421] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move ewk_view_dpi_get() to ewk_util.cpp
https://bugs.webkit.org/show_bug.cgi?id=60753

Move ewk_view_dpi_get() to ewk_util.cpp

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp: (ewk_util_dpi_get):
  • ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute):
1:39 AM Changeset in webkit [86420] by sergio@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r86352.

  • platform/gtk/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/gtk/svg/custom/stroke-opacity-update-expected.txt: Added.
1:29 AM Changeset in webkit [86419] by sergio@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations.

  • platform/gtk/fast/borders/outline-alpha-block-expected.png:
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.png:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-update-expected.png:
  • platform/gtk/svg/custom/fill-opacity-update-expected.txt:
12:37 AM Changeset in webkit [86418] by Patrick Gansterer
  • 21 edits in trunk/Source

2011-05-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::loadWithNextMediaEngine):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::create):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

2011-05-13 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h:
12:20 AM Changeset in webkit [86417] by ap@apple.com
  • 11 edits in trunk

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Unreviewed test changes.

Web Inspector: Show Error Messages for Application Cache Errors
https://bugs.webkit.org/show_bug.cgi?id=41642

  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Pavel Feldman.

Web Inspector: Show Error Messages for Application Cache Errors
https://bugs.webkit.org/show_bug.cgi?id=41642

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota): Added console error logging.

May 12, 2011:

11:23 PM Changeset in webkit [86416] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Fixes for warnings and other minor cleanups when we enable USE_CFNETWORK on Mac.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfStreamError):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::allowsAnyHTTPSCertificateHosts): (WebCore::clientCerts): (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didSendBodyData): (WebCore::shouldUseCredentialStorageCallback): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willLoadFromCache):
11:16 PM Changeset in webkit [86415] by psolanki@apple.com
  • 9 edits in trunk/Source

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Implement ResourceHandle::schedule()/unschedule() based on CF for Mac.

  • WebCore.exp.in:
  • platform/cf/SchedulePair.h:
  • platform/mac/SchedulePairMac.mm:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::schedule): (WebCore::ResourceHandle::unschedule):

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Use CFRunLoop when using CFNetwork.

  • WebView/WebView.mm: (-[WebView scheduleInRunLoop:forMode:]): (-[WebView unscheduleFromRunLoop:forMode:]):

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Use CFRunLoop when using CFNetwork.

  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformInitialize):
10:37 PM Changeset in webkit [86414] by psolanki@apple.com
  • 13 edits in trunk/Source

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Implement mac specific Authentication functions when using CFNetwork.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::authenticationClient): (WebCore::createCF): (WebCore::core):
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/AuthenticationChallenge.h:
  • platform/network/mac/AuthenticationMac.mm: (WebCore::core): (WebCore::mac):
  • platform/network/mac/CredentialStorageMac.mm:

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Include AuthenticationCF.h header file.

  • Misc/WebDownload.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
10:25 PM Changeset in webkit [86413] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Converted the new tests to be text tests with pixel results
(using dumpAsText(true)).
Updated test_expectations comments to be more helpful and accurate and split
new expectations into two groups for skia / chromium-mac as chromium-mac can be
rebaselined now.

  • fast/borders/outline-alpha-block-expected.txt: Added.
  • fast/borders/outline-alpha-block.html:
  • fast/borders/outline-alpha-inline-expected.txt: Added.
  • fast/borders/outline-alpha-inline.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
  • platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
9:59 PM Changeset in webkit [86412] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-12 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove unused option of EWeblauncher
https://bugs.webkit.org/show_bug.cgi?id=60747

Remove sudo-workaround option.
This option is not used and make other option wrong.

  • EWebLauncher/main.c:
9:45 PM Changeset in webkit [86411] by Lucas Forschler
  • 2 edits in trunk/Tools

2011-05-12 Lucas Forschler <Lucas Forschler>

Reviewed by Stephanie Lewis.

Fix config.json to address missing WK2 builder/tester config.
Fix naming of machines (xserve not macpro)

  • BuildSlaveSupport/build.webkit.org-config/config.json:
8:13 PM Changeset in webkit [86410] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add a WebSetting to control DNS prefetch
https://bugs.webkit.org/show_bug.cgi?id=60736

DNS prefetch got disabled in Chrome accidentially in
http://trac.webkit.org/changeset/74041. This patch adds a WebSettings
API so we can enable it again.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDNSPrefetchingEnabled):
  • src/WebSettingsImpl.h:
7:11 PM Changeset in webkit [86409] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

WebProcess sandbox denies file:/// accesses after you navigate to a nonexistent file
<rdar://problem/9427752>
https://bugs.webkit.org/show_bug.cgi?id=60745

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Don't attempt to re-use a non-existent committed sandbox extension. This can happen when the previous load was file: url, but did not require an extension, such as an error page.
6:52 PM Changeset in webkit [86408] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-12 David Grogan <dgrogan@chromium.org>

Reviewed by Darin Adler.

make layout tests in storage/domstorage/events more deterministic
https://bugs.webkit.org/show_bug.cgi?id=60299

Instead of counting the number of storage events fired between two
setTimeout(0) events, specify the number of events to wait for and wait up to
1 second for them.

  • storage/domstorage/events/resources/eventTestHarness.js: (runAfterNStorageEvents): (countStorageEvents.onTimeout): (countStorageEvents): (testStorages.allDone):
  • storage/domstorage/events/script-tests/basic-body-attribute.js: (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/basic-setattribute.js: (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/basic.js: (test): (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/case-sensitive.js: (test): (step1): (step2):
  • storage/domstorage/events/script-tests/documentURI.js: (test): (step1): (step2):
6:50 PM Changeset in webkit [86407] by adele@apple.com
  • 8 edits
    1 add in trunk/Source

Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
https://bugs.webkit.org/show_bug.cgi?id=60685

Reviewed by Darin Adler and Adam Barth.

Source/WebCore:

Detect the Solar Walk application so we can add targeted parser quirks.

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsSolarWalk):
  • platform/RuntimeApplicationChecks.h:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added Misc/SolarWalkQuirksUserScript.js and copy it to Resources during the build phase.

Source/WebKit/mac:

Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.

  • Misc/SolarWalkQuirksUserScript.js: Added.
  • WebView/WebView.mm:

(needsSolarWalkQuirksScript):
(leakSolarWalkQuirksUserScriptContents):
(-[WebView _injectSolarWalkQuirksScript]):
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

6:19 PM Changeset in webkit [86406] by jpu@apple.com
  • 11 edits in trunk/Source

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712

Changed wording in some tests to reflect AppKit UI change.

  • manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
  • manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712
<rdar://problem/9427970>

Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
returns. So we don't need to use the condition to coordinate between these two function. In fact,
all callbacks are delivered on main thread. We don't really need any locking here.

Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
been removed.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dismissCorrectionPanelSoon):

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712
<rdar://problem/9427970>

Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
returns. So we don't need to use the condition to coordinate between these two function. In fact,
all callbacks are delivered on main thread. We don't really need any locking here.

Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
been removed.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismiss): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
5:33 PM Changeset in webkit [86405] by kerz@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/page/Settings.cpp

Fixing chromium issue http://crbug.com/82482 - DNS pre-resolution was disabled in Webkit - Fix only for Chromium 742 branch

5:25 PM Changeset in webkit [86404] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Daniel Bates <dbates@rim.com>

Attempt to fix the build after changeset 86391<http://trac.webkit.org/changeset/86391>
(https://bugs.webkit.org/show_bug.cgi?id=60681).

  • page/PluginHalter.cpp: (WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr so it becomes 0 when assigned to another variable.
5:19 PM Changeset in webkit [86403] by commit-queue@webkit.org
  • 3 edits in trunk

2011-05-12 Gregg Tavares <gman@chromium.org>

Reviewed by Kenneth Russell.

Add option to select GraphicsContext3D implementation.
https://bugs.webkit.org/show_bug.cgi?id=60297

  • Source/WebKit/chromium/DEPS:
  • Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:
5:17 PM Changeset in webkit [86402] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations tweaks for chromium.

  • platform/chromium/test_expectations.txt:
5:06 PM Changeset in webkit [86401] by Patrick Gansterer
  • 12 edits in trunk/Source/WebCore

2011-05-12 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename SimpleFontData::scaledFontData to createScaledFontData
https://bugs.webkit.org/show_bug.cgi?id=60723

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/pango/SimpleFontDataPango.cpp:
  • platform/graphics/qt/SimpleFontDataQt.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp:
  • platform/graphics/wince/SimpleFontDataWinCE.cpp:
  • platform/graphics/wx/SimpleFontDataWx.cpp:
5:05 PM Changeset in webkit [86400] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Switch paintOutline to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60718

Switching paintOutline to use an IntRect instead of 4 ints.

No new tests as this is just refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::paint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
5:01 PM Changeset in webkit [86399] by tkent@chromium.org
  • 5 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

2011-05-12 Kent Tamura <tkent@chromium.org>

[Chromium] Update test expectations for r86224.

  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Removed.
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [86398] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Address review comment by Dan Bernstein.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

4:45 PM Changeset in webkit [86397] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-12 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when a plug-in tries to load a resource from the application cache
https://bugs.webkit.org/show_bug.cgi?id=60735
<rdar://problem/8216142>

When loading application cache resources from disk, we would never restore the
HTTP status code, which means that resources would always have a 0 status code.
This led to the plug-in stream loader canceling the load, something which the application
cache loading machinery couldn't deal and thus would crash.

Fix the reading of the HTTP status code, and make the loader more robust against
application cache loads being canceled.

Unfortunately, I couldn't come up with a test for this because I couldn't find a reliable way
to force the application cache to be read from disk, so all resources would have valid values.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::loadCache):
4:35 PM Changeset in webkit [86396] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptGlue

<http://webkit.org/b/60710> JavaScriptGlue should compile with -Wmissing-prototypes

Reviewed by Geoffrey Garen.

Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.

This also fixes the following compiler warning:

JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]

JSGlobalData* getThreadGlobalData()


  • Configurations/Base.xcconfig: Set

GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.

  • JSUtils.cpp:

(getThreadGlobalData): Made static.

4:30 PM Changeset in webkit [86395] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-12 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize
https://bugs.webkit.org/show_bug.cgi?id=60585

Refactoring, covered by existing tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionLineBox):
  • rendering/RenderBox.h: (WebCore::RenderBox::setLogicalLocation): (WebCore::RenderBox::setLogicalSize): (WebCore::RenderBox::setLocation):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::positionFrames): (WebCore::RenderFrameSet::positionFramesWithFlattening):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::adjustLogicalHeightForCaption): (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::layoutRootBox):
4:27 PM Changeset in webkit [86394] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-12 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] show-composited-layer-tree crashes on null ptr deref
https://bugs.webkit.org/show_bug.cgi?id=60734

The tiler is created lazily, so it won't not be around for the first
dumpLayerProperties call.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::dumpLayerProperties):
4:21 PM Changeset in webkit [86393] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:19 PM Changeset in webkit [86392] by Lucas Forschler
  • 1 copy in tags/Safari-534.35

New tag.

4:06 PM Changeset in webkit [86391] by Patrick Gansterer
  • 10 edits in trunk/Source

2011-05-12 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.

  • WebCore.exp.in:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
  • page/Page.h:
  • page/PluginHalter.cpp: (WebCore::PluginHalter::PluginHalter):
  • page/PluginHalter.h:

2011-05-12 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2011-05-12 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

  • WebView.cpp: (WebView::initWithFrame):
3:34 PM Changeset in webkit [86390] by dbates@webkit.org
  • 8 edits
    9 adds in trunk

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Adele Peterson.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.

Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
removing and adding the noresize attribute, respectively.

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <https://bugs.webkit.org/show_bug.cgi?id=57604>.
  • fast/frames/frame-programmatic-noresize-expected.txt: Added.
  • fast/frames/frame-programmatic-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
  • fast/frames/resources/frame-programmatic-resize.js: Added. (setTestFrameById): (deltaWidth): (shouldAllowFrameResize): (shouldDisallowFrameResize): (shouldDisallowFrameResizeAfterProcessingFrame): (shouldAllowFrameResizeAfterProcessingFrame): (checkTestFrameWidthEquals): (resizeTestFrameBy): (log): (description):

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Adele Peterson.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests: fast/frames/frame-inherit-noresize-from-frameset.html

fast/frames/frame-programmatic-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html

Implements support to programmatically allow and disallow frame resizing.

Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
attribute.

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this code path isn't performance critical. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo(). (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::updateFromElement): Added.
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  • rendering/RenderFrameSet.h:
3:31 PM Changeset in webkit [86389] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
https://bugs.webkit.org/show_bug.cgi?id=60640

Pass by const reference instead of by value for consistency reasons.

Refactoring, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderFlexibleBox.h: Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead
3:29 PM Changeset in webkit [86388] by mitz@apple.com
  • 2 edits in trunk

Corrected Radar links

3:28 PM Changeset in webkit [86387] by mitz@apple.com
  • 5 edits in trunk

Source/WebCore: <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
https://bugs.webkit.org/show_bug.cgi?id=60730

Reviewed by Sam Weinig.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::isWordStartMatch): Consider all positions before a CJK ideograph as
word starts.

LayoutTests: Updated results for <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
https://bugs.webkit.org/show_bug.cgi?id=60730

Reviewed by Sam Weinig.

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
3:20 PM Changeset in webkit [86386] by Lucas Forschler
  • 2 edits in trunk/Tools

2011-05-12 Lucas Forschler <Lucas Forschler>

Reviewed by Stephanie Lewis.

Add SnowLeopard Debug builder and Test bot.
apple-xserve-8 = SL Debug Tester.
apple-xserve-9 = SL Debug Builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:15 PM Changeset in webkit [86385] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxDecorationWithSize to IntRect
https://bugs.webkit.org/show_bug.cgi?id=60679

Switching paintBoxDecorationWithSize to take an IntRect instead of 4 ints.

No new tests as this is simple refactoring.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Cleaning up amazingly confusing logic. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBox.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
3:00 PM Changeset in webkit [86384] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxShadow to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60713

Switching paintBoxShadow from taking four ints to taking an IntRect.

No new tests since this is refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
2:56 PM Changeset in webkit [86383] by Patrick Gansterer
  • 9 edits
    1 add in trunk/Source

2011-05-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394

This portion of the change introduces a PassTraits template, which
is used to enable takeFirst() to work for a Deque holding OwnPtrs,
and optimize it for a Deque holding RefPtrs. In the future it can
be deployed elsewhere to make our data structures work better with
our smart pointers.

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Deque.h: (WTF::::takeFirst):
  • wtf/PassTraits.h: Added. (WTF::PassTraits::transfer):

2011-05-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394

Properly fix this (formerly rolled out for breaking the build). I think the original
failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::create): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::XMLDocumentParser::XMLDocumentParser):
2:50 PM Changeset in webkit [86382] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-12 Adam Barth <abarth@webkit.org>

This patch disables sheriffbot's bug postings. He's just been way too
spammy recently due to test flakiness.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2:43 PM Changeset in webkit [86381] by dbates@webkit.org
  • 4 edits in trunk

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Fixes an issue where a platform mouse event corresponding to mouse button A
may be associated with the wrong WebCore mouse button when the event occurs
while pressing and holding a mouse button B, where A != B.

For example, a person clicks the middle mouse button while pressing and holding
the left mouse button. Then we dispatch the following DOM events: mouse down for
left button, mouse down for left button, mouse up for left button. But, we should
have dispatched: mouse down for left button, mouse down for middle button, mouse up
for middle button.

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventTypeAndMouseButtonFromQEvent): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventTypeAndMouseButtonFromQEvent() to determine the WebCore mouse event type and button from the platform-specific event.

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Remove test case fast/events/fire-mousedown-while-pressing-mouse-button.html
from the Skipped list since it now passes.

  • platform/qt/Skipped:
2:17 PM Changeset in webkit [86380] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2: Implement plugin quirk for Mozilla user agent for older Flash
https://bugs.webkit.org/show_bug.cgi?id=60726
<rdar://problem/8470824>

Reviewed by Adam Roben.

Implement the quirk for versions of Flash before v10 that only request windowless plugins
if we use a Mozilla user agent.

  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:

(WebKit::NetscapePluginModule::determineQuirks): If we have a plugin that handles the

"application/x-shockwave-flash" MIME type with a version less than 10, tell it to use
the Mozilla user agent.

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent): Add an early return if the plugin uses the Mozilla user

agent.

  • win/WebKit2.vcproj: Add PluginQuirks.h.
2:13 PM Changeset in webkit [86379] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-12 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

PluginView::invalidateRect doesn't work for transformed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=60727
<rdar://problem/9331244>

Ask the RenderObject to repaint the plug-in instead of using invalidateContentsAndWindow.
This matches what we do in WebKit1.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::invalidateRect):
2:12 PM Changeset in webkit [86378] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
2:05 PM Changeset in webkit [86377] by leviw@chromium.org
  • 15 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintMask and paintMaskImages off of ints
https://bugs.webkit.org/show_bug.cgi?id=60578

Primarily switching paintMask and paintMaskImages to use IntSize and IntRect respectively.
In the process of that:

  • added an "expand" function to IntRect that allows you to add an IntSize or pair of integers to the size portion of an IntRect.
  • changed borderFitAdjust to take an IntRect. It modifies only the x and width attributes.

No new tests since this refactoring.

  • platform/graphics/IntRect.h: (WebCore::IntRect::expand): Added for convenience.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::borderFitAdjust):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBox.h: (WebCore::RenderBox::borderFitAdjust):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask):
  • rendering/RenderTableCell.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
1:56 PM Changeset in webkit [86376] by commit-queue@webkit.org
  • 37 edits
    1 copy
    55 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/execCommand tests that are working
https://bugs.webkit.org/show_bug.cgi?id=60717

Also based on digging of Zsolt Fehér.

  • platform/qt/Skipped:
  • platform/qt/editing/execCommand/4580583-1-expected.png: Added.
  • platform/qt/editing/execCommand/4580583-1-expected.txt:
  • platform/qt/editing/execCommand/4580583-2-expected.png: Added.
  • platform/qt/editing/execCommand/4580583-2-expected.txt:
  • platform/qt/editing/execCommand/4641880-1-expected.png: Added.
  • platform/qt/editing/execCommand/4641880-1-expected.txt:
  • platform/qt/editing/execCommand/4641880-2-expected.png: Added.
  • platform/qt/editing/execCommand/4641880-2-expected.txt:
  • platform/qt/editing/execCommand/4747450-expected.png: Added.
  • platform/qt/editing/execCommand/4747450-expected.txt:
  • platform/qt/editing/execCommand/4786404-1-expected.png: Added.
  • platform/qt/editing/execCommand/4786404-2-expected.png: Added.
  • platform/qt/editing/execCommand/4916402-expected.png: Added.
  • platform/qt/editing/execCommand/4916402-expected.txt:
  • platform/qt/editing/execCommand/4916541-expected.png: Added.
  • platform/qt/editing/execCommand/4916541-expected.txt:
  • platform/qt/editing/execCommand/4924441-expected.png: Added.
  • platform/qt/editing/execCommand/4924441-expected.txt:
  • platform/qt/editing/execCommand/5049671-expected.png: Added.
  • platform/qt/editing/execCommand/5062376-expected.png: Added.
  • platform/qt/editing/execCommand/5062376-expected.txt:
  • platform/qt/editing/execCommand/5080333-1-expected.png: Added.
  • platform/qt/editing/execCommand/5080333-1-expected.txt:
  • platform/qt/editing/execCommand/5080333-2-expected.png: Added.
  • platform/qt/editing/execCommand/5080333-2-expected.txt:
  • platform/qt/editing/execCommand/5136770-expected.png: Added.
  • platform/qt/editing/execCommand/5136770-expected.txt:
  • platform/qt/editing/execCommand/5138441-expected.png: Added.
  • platform/qt/editing/execCommand/5138441-expected.txt:
  • platform/qt/editing/execCommand/5142012-1-expected.png: Added.
  • platform/qt/editing/execCommand/5142012-1-expected.txt:
  • platform/qt/editing/execCommand/5142012-2-expected.png: Added.
  • platform/qt/editing/execCommand/5142012-2-expected.txt:
  • platform/qt/editing/execCommand/5190926-expected.png: Added.
  • platform/qt/editing/execCommand/5190926-expected.txt:
  • platform/qt/editing/execCommand/5481523-expected.png: Added.
  • platform/qt/editing/execCommand/5481523-expected.txt: Added.
  • platform/qt/editing/execCommand/5482023-expected.png: Added.
  • platform/qt/editing/execCommand/5482023-expected.txt: Added.
  • platform/qt/editing/execCommand/5569741-expected.png: Added.
  • platform/qt/editing/execCommand/5569741-expected.txt: Added.
  • platform/qt/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/qt/editing/execCommand/find-after-replace-expected.png: Added.
  • platform/qt/editing/execCommand/find-after-replace-expected.txt:
  • platform/qt/editing/execCommand/findString-2-expected.png: Added.
  • platform/qt/editing/execCommand/findString-2-expected.txt:
  • platform/qt/editing/execCommand/findString-expected.png: Added.
  • platform/qt/editing/execCommand/findString-expected.txt:
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.png: Added.
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
  • platform/qt/editing/execCommand/indent-empty-root-expected.png: Added.
  • platform/qt/editing/execCommand/indent-empty-root-expected.txt:
  • platform/qt/editing/execCommand/indent-list-item-expected.png: Added.
  • platform/qt/editing/execCommand/indent-list-item-expected.txt:
  • platform/qt/editing/execCommand/indent-selection-expected.png: Added.
  • platform/qt/editing/execCommand/indent-selection-expected.txt:
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
  • platform/qt/editing/execCommand/insert-list-with-id-expected.png: Added.
  • platform/qt/editing/execCommand/insert-list-with-id-expected.txt:
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/qt/editing/execCommand/insertImage-expected.png: Added.
  • platform/qt/editing/execCommand/insertImage-expected.txt:
  • platform/qt/editing/execCommand/nsresponder-indent-expected.png: Added.
  • platform/qt/editing/execCommand/nsresponder-indent-expected.txt: Added.
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.png: Added.
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test1-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test2-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test3-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test4-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-selection-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-selection-expected.txt:
  • platform/qt/editing/execCommand/paste-1-expected.png: Added.
  • platform/qt/editing/execCommand/paste-1-expected.txt:
  • platform/qt/editing/execCommand/paste-2-expected.png: Added.
  • platform/qt/editing/execCommand/paste-2-expected.txt:
  • platform/qt/editing/execCommand/print-expected.png: Added.
  • platform/qt/editing/execCommand/print-expected.txt:
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png: Added.
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
  • platform/qt/editing/execCommand/remove-list-item-1-expected.png: Added.
  • platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
  • platform/qt/editing/execCommand/selectAll-expected.png: Added.
  • platform/qt/editing/execCommand/selectAll-expected.txt:
1:50 PM Changeset in webkit [86375] by Patrick Gansterer
  • 12 edits in trunk/Source/WebCore

2011-05-12 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

SimpleFontData::scaledFontData should return a PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60657

Let scaledFontData return a PassOwnPtr instead of a raw pointer
to make SimpleFontData build without LOOSE_PASS_OWN_PTR.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::scaledFontData):
1:39 PM Changeset in webkit [86374] by commit-queue@webkit.org
  • 9 edits
    15 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/pasteboard tests that are working
https://bugs.webkit.org/show_bug.cgi?id=60707

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/4076267-2-expected.png: Added.
  • platform/qt/editing/pasteboard/4076267-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4076267-expected.png: Added.
  • platform/qt/editing/pasteboard/4076267-expected.txt: Added.
  • platform/qt/editing/pasteboard/4806874-expected.png: Added.
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/5387578-expected.png: Added.
  • platform/qt/editing/pasteboard/5387578-expected.txt:
  • platform/qt/editing/pasteboard/bad-placeholder-expected.png: Added.
  • platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/qt/editing/pasteboard/smart-paste-008-expected.txt: Added.
1:05 PM Changeset in webkit [86373] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
1:01 PM Changeset in webkit [86372] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [86371] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failure when requesting that storage be deleted for an origin without storage.
https://bugs.webkit.org/show_bug.cgi?id=60709

Reviewed by Darin Adler.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::syncDeleteOrigin):
If the path to the storage location for the givin origin is empty, return early instead of
asserting.

12:12 PM Changeset in webkit [86370] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Add option to unconditionally enable/disable a feature
https://bugs.webkit.org/show_bug.cgi?id=60643

Create an argument to be used in WEBKIT_FEATURE macro, allowing a port
to enable a feature without showing to user that it can be disabled.
This is useful if a port needs an option to be always ON/OFF and
changing it will break the build.

This way it's possible to add mandatory features to each port without
touching the cmakeconfig.cmake file.

  • Source/cmake/WebKitFeatures.cmake:
12:10 PM Changeset in webkit [86369] by jberlin@webkit.org
  • 7 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Darin Adler.

Source/WebCore:

Make sure any Private Browsing session is based off the default session.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit2:

Properly handle the case where there is no serialized default storage session by not trying
to encode or decode 0, while still making sure to decode any valid storage session.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
Only encode the storage session if there is one to encode.
(WebKit::WebProcessCreationParameters::decode):
Only decode the storage session there is one to decode.

  • Shared/WebProcessCreationParameters.h:

WebKitLibraries:

Update WKSI with the changes to wkCreatePrivateStorageSession.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:53 AM Changeset in webkit [86368] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
11:45 AM Changeset in webkit [86367] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for chromium.

  • platform/chromium/test_expectations.txt:
11:34 AM Changeset in webkit [86366] by jeffm@apple.com
  • 2 edits in trunk/Source/ThirdParty

Ignore Visual Studio *.user files.

  • gtest/msvc: Added property svn:ignore.
11:33 AM Changeset in webkit [86365] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
https://bugs.webkit.org/show_bug.cgi?id=15479

Finally remove resolveStyle, it is not used anymore.

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
11:29 AM Changeset in webkit [86364] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r65868): createContextualFragment does not work with <style>
https://bugs.webkit.org/show_bug.cgi?id=60155

These test results match Firefox.

  • fast/parser/style-in-create-contextual-fragment-expected.txt: Added.
  • fast/parser/style-in-create-contextual-fragment-head-expected.txt: Added.
  • fast/parser/style-in-create-contextual-fragment-head.html: Added.
  • fast/parser/style-in-create-contextual-fragment.html: Added.

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r65868): createContextualFragment does not work with <style>
https://bugs.webkit.org/show_bug.cgi?id=60155

createContextualFragment doesn't have a spec, so it's hard to tell what
we're supposed to do exactly. This patch appears to make our behavior
more like Firefox and should fix the compat issue with this site.

Tests: fast/parser/style-in-create-contextual-fragment-head.html

fast/parser/style-in-create-contextual-fragment.html

  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
11:28 AM Changeset in webkit [86363] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-12 David Grogan <dgrogan@chromium.org>

Reviewed by Nate Chapin.

IndexedDB: fix up database-quota.html layout test
https://bugs.webkit.org/show_bug.cgi?id=60519

Remove commitAndContinue idiom; translate some missed instances of
event.code to event.target.errorCode from bug 54331

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
11:25 AM Changeset in webkit [86362] by jam@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h

Fix mismatched virtual function from previous checkin

11:24 AM Changeset in webkit [86361] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-12 Martin Robinson <mrobinson@igalia.com>

Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
bot which appears to be more sensitive to timing issues than the
other bots.

  • tests/testwebview.c: Add another short pause waiting for adjustments to update.
11:21 AM Changeset in webkit [86360] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit inserts base, link, meta, style, and title elements into an editable region
when pasting table cells from Excel
https://bugs.webkit.org/show_bug.cgi?id=60644

Added a test to ensure WebKit strips the said elements prior to inserting HTML.

  • editing/pasteboard/paste-head-contents-expected.txt: Added.
  • editing/pasteboard/paste-head-contents.html: Added.

2011-05-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit inserts base, link, meta, style, and title elements into an editable region
when pasting table cells from Excel
https://bugs.webkit.org/show_bug.cgi?id=60644

Strip base, link, meta, style, and tile elements from the fragment to be pasted prior
to the merge. We don't have to strip these elements in performTrivialReplace because
the function only handles a fragment that consists of exactly one text node.

Test: editing/pasteboard/paste-head-contents.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::removeHeadContents): Added. (WebCore::ReplaceSelectionCommand::doApply): Calls removeHeadContents before handing style spans.
11:06 AM Changeset in webkit [86359] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Switch calculateBackgroundImageGeometry to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60671

Replacing the four ints passed into calculateBackgroundImageGeometry with an IntRect.

No new tests since this is just refactoring.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h:
10:56 AM Changeset in webkit [86358] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

2011-05-08 Abhishek Arya <inferno@chromium.org> and Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

  • fast/css/counters/element-removal-crash-expected.txt: Added.
  • fast/css/counters/element-removal-crash.xhtml: Added.
10:35 AM Changeset in webkit [86357] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

Rebaseline editing/inserting tests that work
https://bugs.webkit.org/show_bug.cgi?id=60702

  • platform/qt/Skipped:
  • platform/qt/editing/inserting/4278698-expected.png: Added.
  • platform/qt/editing/inserting/4278698-expected.txt:
  • platform/qt/editing/inserting/editable-html-element-expected.png: Added.
  • platform/qt/editing/inserting/editable-html-element-expected.txt:
  • platform/qt/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/qt/editing/inserting/editing-empty-divs-expected.txt:
  • platform/qt/editing/inserting/insert-div-023-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-023-expected.txt:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.png: Added.
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Added.
10:33 AM Changeset in webkit [86356] by jam@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-05-11 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Make openFileSystem check for permission first
https://bugs.webkit.org/show_bug.cgi?id=60683

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::allowFileSystem):
  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowFileSystem):
  • src/LocalFileSystemChromium.cpp: (WebCore::openFileSystemNotAllowed): (WebCore::openFileSystemHelper):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::allowFileSystem):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowFileSystem):
10:19 AM Changeset in webkit [86355] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Merge ApplyPropertyExpanding and ApplyPropertyExpandingSuppressValue classes using template.
https://bugs.webkit.org/show_bug.cgi?id=60691

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyExpanding::applyValue): Use new template parameter to early exit if needed. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Specify template parameters for ApplyPropertyExpanding.
10:07 AM Changeset in webkit [86354] by bweinstein@apple.com
  • 10 edits
    3 adds in trunk

Source/WebKit2: After relaunching an unresponsive web process, web page stops responding to mouse movement
https://bugs.webkit.org/show_bug.cgi?id=60669
<rdar://problem/9409934>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash): Set m_processingMouseMoveEvent to false when the WebProcess

crashes.

Tools: After relaunching an unresponsive web process, web page stops responding to mouse movement
https://bugs.webkit.org/show_bug.cgi?id=60669
<rdar://problem/9409934>

Reviewed by Anders Carlsson.

This test follows the steps needed to reproduce this bug:
1) Hang the web process
2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3) Kill and restart the WebProcess
4) Move the mouse

We are testing that we receive mouse move events after the WebProcess has restarted.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
(TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
(TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.

(TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
(TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):

  • TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.

Add new files.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:
10:03 AM Changeset in webkit [86353] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-12 Simon Fraser <Simon Fraser>

Followup to r86351; give the vectors some inline capacity
to avoid heap allocations in most cases.

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
9:57 AM Changeset in webkit [86352] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-05-12 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
https://bugs.webkit.org/show_bug.cgi?id=59941

Improve test to not need a click. Offer a stroke-opacity variant as well.

  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Added.
  • svg/custom/fill-opacity-update.svg:
  • svg/custom/stroke-opacity-update.svg: Added.
9:38 AM Changeset in webkit [86351] by Simon Fraser
  • 5 edits
    2 adds in trunk

2011-05-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Mismatched multiple box-shadows do not transition as expected
https://bugs.webkit.org/show_bug.cgi?id=60137

When animating between two sets of shadows of different lengths, we need
to walk the ShadowData list backwards, since it stores the shadows in
reverse order relative to the CSS (so that painting is back-to-front).

This progresses the behavior of the transitions/multiple-shadow-transitions.html
test, which is given new expected results.

Test: transitions/mismatched-shadow-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::shadowListLength): Utility to walk the list of ShadowData and count the number of shadows. (WebCore::shadowForBlending): Return a ShadowData* that is useful as a blending target, based on the shadow type, and whether it's a -webkit-box-shadow. (WebCore::PropertyWrapperShadow::blend): Call one of the specialized blend methods. (WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists): Fast path for shadow blending, when the list lengths match, or both are single or null shadows. (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists): Slower path that builds vectors for each list to reverse them.
9:11 AM Changeset in webkit [86350] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
9:03 AM Changeset in webkit [86349] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-12 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Added initialization/shutdown for ecore_file library
https://bugs.webkit.org/show_bug.cgi?id=60457

Added initialization and shuthown for ecore_file library and replaced
realpath function to ecore_file_realpath.

  • EWebLauncher/main.c: (quit): (findThemePath): (main):
9:02 AM Changeset in webkit [86348] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
8:45 AM Changeset in webkit [86347] by Adam Roben
  • 2 edits in trunk/Source/ThirdParty

Windows production build fix

  • gtest/msvc/gtest-md.vcproj: Fix the OutputDirectory and IntermediateDirectory attributes

for all configurations.

8:41 AM Changeset in webkit [86346] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Fixed typo.

  • platform/chromium/test_expectations.txt:
8:40 AM Changeset in webkit [86345] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
8:33 AM Changeset in webkit [86344] by Philippe Normand
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/gtk/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt: Added.
  • platform/gtk/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt: Added.
  • platform/gtk/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/gtk/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • platform/gtk/svg/custom/fill-opacity-update-expected.png: Added.
  • platform/gtk/svg/custom/fill-opacity-update-expected.txt: Added.
8:19 AM Changeset in webkit [86343] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Attempted WinCairo build fix after r86169, part II

  • platform/network/curl/CredentialStorageCurl.cpp: Added a missing #include.
8:08 AM Changeset in webkit [86342] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium GPU suppressions.

  • platform/chromium/test_expectations.txt:
8:03 AM Changeset in webkit [86341] by Adam Roben
  • 4 edits in trunk/LayoutTests

Update Windows results after r86315

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
7:46 AM Changeset in webkit [86340] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Fix linker warnings in Production builds

  • WebCore.vcproj/WebCore.vcproj: Exclude JSSVGFEDropShadowElement.cpp from the build in the

Production configuration, just like in the other configurations. Let VS resort some files
(again).

7:36 AM Changeset in webkit [86339] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Roben.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555

Follow-up fix for the 3 editing/deleting tests crashing on GTK,
Leopard and Windows XP. Don't create the Range if the start of the
selection has no next position.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
7:20 AM Changeset in webkit [86338] by Adam Roben
  • 2 edits
    1 add in trunk/Source/WebCore

Attempted WinCairo build fix after r86169

  • WebCore.vcproj/WebCore.vcproj: Added CredentialStorageCurl.cpp. Also let VS do what it

wants.

  • platform/network/curl/CredentialStorageCurl.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage): Stubbed out.

7:13 AM Changeset in webkit [86337] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Build fixes after r86325

  • editing/SpellingCorrectionController.cpp:
  • editing/SpellingCorrectionController.h:

Added missing declarations/#includes.

7:10 AM Changeset in webkit [86336] by Adam Roben
  • 3 edits
    1 add in trunk/Source

A little gtest cleanup after r86287

Source/ThirdParty:

  • gtest/msvc/gtest-md.vcproj: Added Debug_All and Production configurations to match our

other projects. (At some point all the settings should be moved into .vsprops files to match
our other projects, too.)

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:
    • Move gtest into the Tools folder
    • Make gtest build just before TestWebKitAPIGenerated
    • Use gtest's new Debug_All and Production configurations as appropriate
6:58 AM Changeset in webkit [86335] by Nikolas Zimmermann
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works.

6:51 AM Changeset in webkit [86334] by Nikolas Zimmermann
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before.

6:49 AM Changeset in webkit [86333] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::listDirectory):
6:30 AM Changeset in webkit [86332] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/

  • html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData):
5:32 AM Changeset in webkit [86331] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-12 Rob Buis <rwlbuis@gmail.com>

Reviewed by Eric Seidel.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
https://bugs.webkit.org/show_bug.cgi?id=59941

Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.

Test: svg/custom/fill-opacity-update.svg

  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
5:07 AM Changeset in webkit [86330] by Nikolas Zimmermann
  • 33 edits
    1 add in trunk/Source

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator.
Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary
object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting
N strings using operator+, this leads to N-1 reallocations.

Replace this with a flexible operator+ implementation, that avoids these reallocations.
When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..)
a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays
creation of the final string, until operator String() is invoked.

template<typename T>
StringAppend<String, T> operator+(const String& string1, T string2)
{

return StringAppend<String, T>(string1, string2);

}

template<typename U, typename V, typename W>
StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2)
{

return StringAppend<U, StringAppend<V, W> >(string1, string2);

}

When concatting three strings - "String a, b, c; String result = a + b + c;" following happens:
first a StringAppend<String, String> object is created by operator+(const String& string1, String string2).
Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns
a StringAppend<String, StringAppend<String, String> > object.
Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the
final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us
against too big string allocations, etc.

Note that the second template, defines a recursive way to concat an arbitary number of strings
into a single String with just one allocation.

  • GNUmakefile.list.am: Add StringOperators.h to build.
  • JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols.
  • JavaScriptCore.gypi: Add StringOperators.h to build.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file.
  • wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file.
  • wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file. (WTF::StringAppend::StringAppend): (WTF::StringAppend::operator String): (WTF::StringAppend::operator AtomicString): (WTF::StringAppend::writeTo): (WTF::StringAppend::length): (WTF::operator+):
  • wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append(). (WTF::emptyString): Add new shared empty string free function.
  • wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file.

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::handleElementAttributes):
  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::search):
  • html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData):
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • page/Location.cpp: (WebCore::Location::search): (WebCore::Location::hash):
  • page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::copyCFStreamDescription):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::search): (WebCore::WorkerLocation::hash):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type.
  • src/WebHTTPLoadInfo.cpp: (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first.
  • tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+. (IDBLevelDBCoding::TEST):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • AccessibleBase.cpp: (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
4:15 AM Changeset in webkit [86329] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-12 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=60367

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::layerTreeAsText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=60367

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:51 AM Changeset in webkit [86328] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that eval can access scoped variables in console
https://bugs.webkit.org/show_bug.cgi?id=60547

  • inspector/console/console-eval-scoped-expected.txt: Added.
  • inspector/console/console-eval-scoped.html: Added.
3:48 AM Changeset in webkit [86327] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-05-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move agents from InspectorAgent to InspectorController
https://bugs.webkit.org/show_bug.cgi?id=60359

All inspector agents are now created and owned by InspectorController which
in turned is owned by the inspected Page. InspectorInstrumentation gets access
to the instrumenting agents by means of InspectorAgent::instrumentingAgents().

In addition to managing inspector agents lifetime InspectorController sets
InspectorFronted on the agents when the front-end is connected.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::clearFrontend):
  • inspector/InspectorAgent.h: all accessors to other agents were removed along with the agents themselves from InspectorAgent. Every agent that depends on some other agents receives pointers to them explicitely in its constructor. All access to the agents from WebCore should go through InspectorInstrumentation which retrieves corresponding agents using InstrumentingAgents structure which represents the set of active agents. (WebCore::InspectorAgent::instrumentingAgents):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::highlightedNode): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::resume):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  • page/Page.cpp: (WebCore::Page::~Page): we send two notifications when inspected Page is being destroyed: one to the inspector instrumentation and another one to the InspectorController which is owned by the Page.
3:38 AM Changeset in webkit [86326] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Tony Gentilcore <tonyg@chromium.org>

Build fix: include ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=60694

  • dom/Range.cpp:
3:31 AM Changeset in webkit [86325] by tonyg@chromium.org
  • 80 edits in trunk/Source

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • dom/DocumentMarkerController.cpp:
  • dom/Position.cpp:
  • dom/PositionIterator.cpp:
  • dom/Range.cpp:
  • editing/ApplyBlockElementCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • editing/FrameSelection.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/IndentOutdentCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SpellChecker.h:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SpellingCorrectionController.h:
  • editing/TextCheckingHelper.cpp:
  • editing/TextIterator.h:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • editing/visible_units.cpp:
  • editing/visible_units.h:
  • fileapi/DOMFileSystem.cpp:
  • fileapi/DirectoryReaderSync.cpp:
  • fileapi/DirectoryReaderSync.h:
  • fileapi/FileEntry.h:
  • fileapi/FileWriter.h:
  • fileapi/FileWriterBase.h:
  • fileapi/FileWriterSync.h:
  • history/CachedFrame.cpp:
  • history/CachedPage.cpp:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • history/PageCache.h:
  • loader/HistoryController.h:
  • loader/PingLoader.h:
  • loader/ResourceLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedResourceRequest.h:
  • loader/cache/MemoryCache.h:
  • notifications/Notification.cpp:
  • notifications/Notification.h:
  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/DOMSelection.cpp:
  • page/DOMTimer.h:
  • page/DOMWindow.cpp:
  • page/EventHandler.cpp:
  • page/FocusController.h:
  • page/Geolocation.cpp:
  • page/Geolocation.h:
  • page/History.cpp:
  • rendering/RenderListBox.cpp:
  • workers/WorkerContext.cpp:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • src/WebHistoryItem.cpp:
  • src/WebNotification.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/mac/WebSubstringUtil.mm:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • WebView/WebFrame.mm:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • WebProcess/WebPage/mac/WebPageMac.mm:
2:54 AM Changeset in webkit [86324] by Csaba Osztrogonác
  • 2 edits
    14 adds in trunk/LayoutTests

Add new expected files after r86313.

  • platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt-arm/transforms/svg-vs-css-expected.txt: Added.
  • platform/qt-mac/Skipped: Add plugins/get-targeted-javascript-url.html because of missing plugin.getURLNotify() implementation
  • platform/qt-mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt-mac/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt-mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt-mac/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt-mac/transforms/svg-vs-css-expected.txt: Added.
2:16 AM Changeset in webkit [86323] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r86307.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png:
1:14 AM Changeset in webkit [86322] by yutak@chromium.org
  • 5 edits in trunk/LayoutTests

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Qt test expectations affected in r86320.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:05 AM Changeset in webkit [86321] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed, another attempt of build fix.

  • websockets/CloseEvent.h:
  • websockets/CloseEvent.idl:
12:58 AM Changeset in webkit [86320] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed, trying to fix Qt minimal compile.

  • websockets/CloseEvent.idl:
12:42 AM Changeset in webkit [86319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 ojab <ojab@ojab.ru>

Reviewed by Eric Seidel.

Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=60542

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:36 AM Changeset in webkit [86318] by Philippe Normand
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix.

  • wtf/Platform.h:
12:32 AM Changeset in webkit [86317] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-05-12 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Fix the build with ENABLE_PLUGIN_PROCESS
https://bugs.webkit.org/show_bug.cgi?id=60628

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Move the call to pluginController->isAcceleratedCompositingEnabled() to a #ifdef block.
  • WebProcess/Plugins/PluginProxy.h: Add include for <WebCore/IntRect.h>.
12:31 AM Changeset in webkit [86316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Arm debug build failing on ARMAssembler::debugOffset()
https://bugs.webkit.org/show_bug.cgi?id=60688

Related to svn rev 85523

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::debugOffset):
12:06 AM Changeset in webkit [86315] by yutak@chromium.org
  • 22 edits
    4 adds in trunk

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket add new event: CloseEvent
https://bugs.webkit.org/show_bug.cgi?id=35573

Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
I modified the test close-event.html slightly so that it passes on Chromium.
I also updated a few test results that are affected by this change.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt: Added.
  • http/tests/websocket/tests/close-event.html: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket add new event: CloseEvent
https://bugs.webkit.org/show_bug.cgi?id=35573

Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
I added CloseEvent constructor to DOMWindow, so it can be referred
in the new test (close-event.html).

Test: http/tests/websocket/tests/close-event.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isCloseEvent):
  • dom/Event.h:
  • page/DOMWindow.idl: Add CloseEvent constructor.
  • websockets/CloseEvent.h: Added. (WebCore::CloseEvent::isCloseEvent): (WebCore::CloseEvent::create): (WebCore::CloseEvent::initCloseEvent): (WebCore::CloseEvent::wasClean): (WebCore::CloseEvent::CloseEvent):
  • websockets/CloseEvent.idl: Added.
  • websockets/WebSocket.cpp: (WebCore::WebSocket::didClose):
12:04 AM Changeset in webkit [86314] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

  • fast/borders/outline-alpha-block.html: Added.
  • fast/borders/outline-alpha-inline.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/mac/fast/borders/outline-alpha-block-expected.txt: Added.
  • platform/mac/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/mac/fast/borders/outline-alpha-inline-expected.txt: Added.
  • platform/mac/fast/box-shadow/box-shadow-radius-expected.png: Rebaselined as this test had rgba outlines.
  • platform/mac/fast/layers/self-painting-outline-expected.png: Rebaselined as this test had rgba outlines.

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Tests: fast/borders/outline-alpha-block.html

fast/borders/outline-alpha-inline.html

Updated baseline images for tests with rgba outlines:

fast/box-shadow/box-shadow-radius.html
fast/layers/self-painting-outline.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):

May 11, 2011:

11:00 PM Changeset in webkit [86313] by commit-queue@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-11 Srinivasulu Chereddy <Srinivasulu.Chereddy@nokia.com>

Reviewed by Eric Seidel.

[Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list
https://bugs.webkit.org/show_bug.cgi?id=60654

  • platform/qt/Skipped:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added.
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt/transforms/svg-vs-css-expected.png: Added.
  • platform/qt/transforms/svg-vs-css-expected.txt: Added.
10:45 PM Changeset in webkit [86312] by leviw@chromium.org
  • 5 edits in trunk/Source

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

No new tests as this is a simple rename

  • page/FrameView.cpp: (WebCore::FrameView::create):
  • platform/Widget.h: (WebCore::Widget::location): (WebCore::Widget::resize):

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
10:40 PM Changeset in webkit [86311] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

  • editing/pasteboard/paste-removing-iframe-expected.txt: Added.
  • editing/pasteboard/paste-removing-iframe.html: Added.
  • editing/pasteboard/resources/paste-removing-iframe-child.html: Added.

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

Added missing null check.

Test: editing/pasteboard/paste-removing-iframe.html

  • editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection):
10:35 PM Changeset in webkit [86310] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Brian Salomon <bsalomon@google.com>

Reviewed by Eric Seidel.

Handle case when GrContext creation fails
https://bugs.webkit.org/show_bug.cgi?id=60410

Exercised by all canvas tests when DRT is run with skia-gpu

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext):
10:31 PM Changeset in webkit [86309] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Pratik Solanki <psolanki@apple.com>

Reviewed by Andreas Kling.

Remove empty class CallbackGuard
https://bugs.webkit.org/show_bug.cgi?id=60610

CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
10:13 PM Changeset in webkit [86308] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60609

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations.
10:09 PM Changeset in webkit [86307] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2011-05-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Some elements in meter-styles.html are hiding its content part with non-content-area.
https://bugs.webkit.org/show_bug.cgi?id=58149

  • Resized the border and padding values
  • Gave "-webkit-appearance: none" to test that is intended to be painted using shadows.
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
9:48 PM Changeset in webkit [86306] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement more clipping functions for wxWebKit.

https://bugs.webkit.org/show_bug.cgi?id=60662

8:55 PM Changeset in webkit [86305] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • WebCore.exp.in: Export restoreScrollPositionAndViewState()

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
8:38 PM Changeset in webkit [86304] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-11 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

WebKit does not build with GCCE
https://bugs.webkit.org/show_bug.cgi?id=60667

Allow compile WebKit with GCCE

  • wtf/Alignment.h:
  • wtf/Platform.h:
8:17 PM Changeset in webkit [86303] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFillLayer and its progeny to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60596

Changing integers passed into paintFillLayer and other derivatives to IntRects
and IntSizes that reflect their function.

No new tests since this is just refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
7:53 PM Changeset in webkit [86302] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable strict PassOwnPtr on Mac
https://bugs.webkit.org/show_bug.cgi?id=60684

This should build cleanly now.

  • wtf/PassOwnPtr.h:
7:16 PM Changeset in webkit [86301] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Use mapTexSubImage2D for tile uploads if available
https://bugs.webkit.org/show_bug.cgi?id=60008

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
  • platform/graphics/chromium/LayerTilerChromium.h:
6:26 PM Changeset in webkit [86300] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Protect JSC from WebCore executing JS during JS wrapper finalization
https://bugs.webkit.org/show_bug.cgi?id=60672
<rdar://problem/9350997>

Detect when we're trying to execute JS during GC and prevent the
execution from happening. We also assert that this isn't happening
as it implies incorrect behaviour of an object's destructor.

  • JavaScriptCore.exp:
  • heap/Heap.cpp:
  • heap/Heap.h: (JSC::Heap::isBusy):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy):
6:20 PM Changeset in webkit [86299] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implements a disable appearance for Media Elements of Qt port.
https://bugs.webkit.org/show_bug.cgi?id=60561

Implements a disable appearance for the media controls of the Qt port
when the media is not yet available.

  • platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb):
6:18 PM Changeset in webkit [86298] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

  • fast/forms/resources/ValidityState-typeMismatch-email.js:
  • fast/forms/ValidityState-typeMismatch-email-expected.txt:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

Follow the updated specification.

  • html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
6:11 PM Changeset in webkit [86297] by cdn@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Cris Neckar <cdn@chromium.org>

Reviewed by David Levin.

Adding Cris Neckar to the Webkit Security Group site.
https://bugs.webkit.org/show_bug.cgi?id=60668

  • security/security-group-members.html:
5:58 PM Changeset in webkit [86296] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

WebKit2 doesn't build on Mac with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60655

  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership.
5:54 PM Changeset in webkit [86295] by jpu@apple.com
  • 19 edits
    3 adds in trunk

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

See WebCore/ChangeLog for detail.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

This patch intends to alleviate the issue of repetitively applying the same autocorrection
when user delete and retype the same word at the same location. This scenario is especially
common when autocorrection modifies the first letter of the word.

This patch consists following major changes:

  1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that precedes a deleted autocorrection. If the user later types the same original word at after this whitespace, the autocorrection will not be applied again.
  2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the autocorrection that has just been deleted.
  3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress autocorrection when necessary.
  4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text after the whitespace.

Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html

  • dom/DocumentMarker.h: Added new marker type DeletedAutocorrection. (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting

the original string if we are deleting an autocorrection.

(WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.

  • editing/DeleteSelectionCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining

when to suppress an autocorrection into SpellingCorrectionController.

(WebCore::Editor::deletedAutocorrectionAtPosition):

  • editing/Editor.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition): (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  • editing/visible_units.cpp: (WebCore::isStartOfWord):
  • editing/visible_units.h:
  • manual-tests/autocorrection/spell-checking-after-reversion.html:
5:49 PM Changeset in webkit [86294] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Enable gc mark validation in temporarily in release builds
https://bugs.webkit.org/show_bug.cgi?id=60678

Make it easier to turn the gc mark validation on and off, and
temporarily turn it on for all builds.

  • heap/MarkStack.cpp:
  • heap/MarkStack.h: (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
  • runtime/WriteBarrier.h: (JSC::MarkStack::appendValues):
  • wtf/Platform.h:
5:45 PM Changeset in webkit [86293] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com
https://bugs.webkit.org/show_bug.cgi?id=60677

Reviewed by Darin Adler.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
animation, if the new scroll offset computed here is different from the current scroll offset.

5:39 PM Changeset in webkit [86292] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Add test cases and update the result.

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Fixes a bug that patternMismatch returns a wrong result if

  • a whole value matches to a pattern,
  • a sub-string of the value also matches to the pattern, and
  • the sub-string matching has priority.
  • html/BaseTextInputType.cpp: (WebCore::BaseTextInputType::patternMismatch): Enclose the specified pattern with ( and )$.
5:29 PM Changeset in webkit [86291] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Prevented DOMFileSystemBase from imposing file naming restrictions on
external file systems.

https://bugs.webkit.org/show_bug.cgi?id=60583

There are no new tests for this change since it requires the presence
of external file system provider which is specific to the platform host
process. Chromium implementation will test this within its extension API
test suite.

  • fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):
5:28 PM Changeset in webkit [86290] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
  • loader/ResourceLoadScheduler.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
5:17 PM Changeset in webkit [86289] by jcivelli@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-05-11 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding a Content-Type parser. This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=60637

(WebCore::ScriptController::disableEval):

  • platform/network/ContentTypeParser.cpp: Added.
  • platform/network/ContentTypeParser.h: Added.
5:04 PM Changeset in webkit [86288] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Teach validate-committer-lists how to validate committers bugzilla_email()
https://bugs.webkit.org/show_bug.cgi?id=60651

It turns out we currently have 9 committers with invalid values for their
bugzilla_email field (meaning we don't know what email is their bugzilla account).
"Alexander Kellett" <lypanov@mac.com>
"Andre Boule" <aboule@apple.com>
"Cameron McCormack" <cam@webkit.org>
"Chris Petersen" <cpetersen@apple.com>
"Eli Fidler" <eli@staikos.net>
"Matt Lilek" <webkit@mattlilek.com>
"Pierre d'Herbemont" <pdherbemont@free.fr>
"Scott Violet" <sky@chromium.org>
"Adam Treat" <treat@kde.org>

Most of those haven't committed in a very long time, so it's not suprising
that we haven't noticed that their bugzilla emails are bogus.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4:52 PM Changeset in webkit [86287] by levin@chromium.org
  • 16 edits
    1 add in trunk

https://bugs.webkit.org/show_bug.cgi?id=59561
Switch TestWebKitAPI to GTest

Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11
Reviewed by David Levin.

Fixes Makefiles and WinCairo build as well

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:
  • Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
  • Source/ThirdParty/gtest/xcode/Makefile: Added.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Makefile:
  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

4:52 PM Changeset in webkit [86286] by Ademar Reis
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Mark Rowe.

Update Qt/Nokia Security contacts
https://bugs.webkit.org/show_bug.cgi?id=60650

Ademar (me) replaced Simon as the release manager and primary security
contact for QtWebKit. See:
http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html

  • security/security-group-members.html:
4:49 PM Changeset in webkit [86285] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Only encode the session parameter if it is valid.
(WebKit::WebProcessCreationParameters::decode):
Don't try to decode a null session data.

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
4:42 PM Changeset in webkit [86284] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Kilzer.

Remove wml directory from include lists
https://bugs.webkit.org/show_bug.cgi?id=60646

Remove wml dir from CMake, Autotools and qmake build systems since WML
was removed in r85256.

No new tests since no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pri:
4:28 PM Changeset in webkit [86283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Move EFL-specific file to CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=60642

Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
calls, since they depend on lists that now may change inside a port
like WebCore_USER_AGENT_STYLE_SHEETS.

No new tests since no change in functionality.

  • CMakeLists.txt: remove css file specific to EFL port.
  • CMakeListsEfl.txt: move file here.
4:21 PM Changeset in webkit [86282] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Add Luke Macpherson to committers.py as a Contributor
https://bugs.webkit.org/show_bug.cgi?id=60639

  • Scripts/webkitpy/common/config/committers.py:
4:16 PM Changeset in webkit [86281] by jpu@apple.com
  • 6 edits in trunk/Source

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
4:09 PM Changeset in webkit [86280] by inferno@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More rebaselines after r86261.

  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:58 PM Changeset in webkit [86279] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Return empty Favicon URL instead of default one when the frame isn't top level one
https://bugs.webkit.org/show_bug.cgi?id=60527
This issue was discovered by chromium browser test.

  • dom/Document.cpp: (WebCore::Document::setIconURL): Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): Restored original logic, the empty URL should be returned instead of default one. The client (at least chromium) may rely on the returned value to decided whether the favicon should be changed.
3:50 PM Changeset in webkit [86278] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need
to prevent WebGL from running too far ahead of the GPU process. The current
throttling mechanism relies on prepareTexture being called for every WebGL frame.
However, in a non-requestAnimFrame application, multiple frames might get created
before the compositor runs and calls prepareTexture on the surface.

To address this, we post a task that calls a special rate limiting GL extension on
the WebGL context after every WebGL "frame." When the compositor runs, it calls
prepareTexture as usual.

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::setIsAnimating): (WebCore::LayerRendererChromium::isAnimating):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask): (WebCore::WebGLLayerChromiumRateLimitTask::run): (WebCore::WebGLLayerChromiumRateLimitTask::cancel): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::~WebGLLayerChromium): (WebCore::WebGLLayerChromium::setTextureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::context):

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

Tell LayerRendererChromium when the requestAnimFrame-callbacks are running.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
3:44 PM Changeset in webkit [86277] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines after r86261.

  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
3:11 PM Changeset in webkit [86276] by noam.rosenthal@nokia.com
  • 19 edits in trunk/Source

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).

  1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
  2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
  3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
  • Api/qwebframe.cpp: (QWebFramePrivate::renderCompositedLayers):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::attachRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::scroll): (WebCore::TextureMapperNodeClientQt::setTextureMapper): (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect): (WebCore::TextureMapperNodeClientQt::syncRootLayer): (WebCore::TextureMapperNodeClientQt::rootNode): (WebCore::PageClientQWidget::setRootGraphicsLayer): (WebCore::PageClientQWidget::syncLayers): (WebCore::PageClientQWidget::~PageClientQWidget): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::syncLayersTimeout):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation
mechanism happens inside TextureMapper, and we interpolate right before we paint.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper): (WebCore::GraphicsLayerTextureMapper::syncCompositingState): (WebCore::GraphicsLayerTextureMapper::addAnimation): (WebCore::GraphicsLayerTextureMapper::pauseAnimation): (WebCore::GraphicsLayerTextureMapper::removeAnimation): (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired):
  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations): (WebCore::normalizedAnimationValue): (WebCore::TextureMapperNode::applyOpacityAnimation): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction): (WebCore::applyTimingFunction): (WebCore::TextureMapperNode::applyTransformAnimation): (WebCore::TextureMapperNode::applyAnimationFrame): (WebCore::TextureMapperNode::applyAnimation): (WebCore::TextureMapperNode::hasRunningOpacityAnimation): (WebCore::TextureMapperNode::hasRunningTransformAnimation): (WebCore::TextureMapperNode::syncAnimations): (WebCore::copyTimingFunction): (WebCore::copyAnimationValue): (WebCore::TextureMapperAnimation::TextureMapperAnimation):
  • platform/graphics/texmap/TextureMapperNode.h: (WebCore::TextureMapperAnimation::create):
2:58 PM Changeset in webkit [86275] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

No new tests as functionality is the same.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DBase):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create):
2:53 PM Changeset in webkit [86274] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <Simon Fraser>

Attempt to fix Chromium Mac build.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
2:35 PM Changeset in webkit [86273] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

[Qt] Extract code to set mouse event modifiers into common function
https://bugs.webkit.org/show_bug.cgi?id=60649

Consolidate code to set the keyboard modifiers for a mouse event into a common
function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount)
and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code.

No functionality was changed. So, no new tests.

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers().
2:33 PM Changeset in webkit [86272] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60591

Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect.

No new tests since there is no functionality change.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
2:25 PM Changeset in webkit [86271] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
2:18 PM Changeset in webkit [86270] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Frequent crashes beneath WebCore::ScriptElement::prepareScript
https://bugs.webkit.org/show_bug.cgi?id=60559

Reviewed by Eric Seidel.

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::runScript):
Add null check and explanation that we are keeping the ASSERT to help
track down the cause and produce a test.

2:17 PM Changeset in webkit [86269] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 5/12: Implement the new TextureMapper functions for the Qt backend.
This allow non-rectangular clipping, some stub functions, and getting a unique
id for an image.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapperQt::beginClip): (WebCore::TextureMapperQt::endClip): (WebCore::TextureMapperQt::viewportSize): (WebCore::TextureMapperQt::setGraphicsContext): (WebCore::TextureMapperQt::graphicsContext): (WebCore::TextureMapperQt::drawTexture): (WebCore::TextureMapperQt::beginPainting): (WebCore::TextureMapperQt::endPainting): (WebCore::RGBA32PremultimpliedBufferQt::beginPaint): (WebCore::uidForImage):
  • platform/graphics/qt/TextureMapperQt.h:
2:14 PM Changeset in webkit [86268] by noam.rosenthal@nokia.com
  • 4 edits in trunk

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
attributes.

  • Api/qwebsettings.cpp: (qt_networkAccessAllowed): (QWebSettingsPrivate::apply):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the build script to enable 3D rendering by default for Qt.

  • Scripts/build-webkit:
2:11 PM Changeset in webkit [86267] by bweinstein@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r86161): WKPreferences API test failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=60658

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

2:09 PM Changeset in webkit [86266] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 3/12: TextureMapper shouldn't depend on OpenGL, but rather only allow the GL backend when
OpenGL is present.

No new tests. This is a build fix.

  • WebCore.pri:
  • WebCore.pro:
2:06 PM Changeset in webkit [86265] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 2/12: Add a few functions to the TextureMapper API, allowing:

  1. an entry/exit point for painting (beginPaint/endPaint)
  2. Clipping with a matrix, since we use stencil instead of scissors
  3. Draw a texture directly with an ID
  4. Remove offset, since we're using real tiling
  5. numberOfBytes calculation for textures, for memory management

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::destroy): (WebCore::BitmapTexture::allowOfflineTextureUpload): (WebCore::BitmapTexture::bpp): (WebCore::BitmapTexture::numberOfBytes): (WebCore::TextureMapper::viewportSize): (WebCore::TextureMapper::setViewportSize): (WebCore::TextureMapper::allowPartialUpdates): (WebCore::TextureMapper::isOpenGLBacked): (WebCore::TextureMapper::setTransform): (WebCore::TextureMapper::transform): (WebCore::TextureMapper::beginPainting): (WebCore::TextureMapper::endPainting):
2:02 PM Changeset in webkit [86264] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 1/12: Change the TextureMapperPlatformLayer API to allow a 3D-context or a
media player to decide how to paint into the TextureMapper, rather than mandate specific
types of platform layers.

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayer.h:
1:55 PM Changeset in webkit [86263] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

<rdar://problem/9331651> REGRESSION: RPRVT grows by 1MB / sec @ dvd2blu.com

Reviewed by Oliver Hunt.

SunSpider reports no change.

This bug was caused by changing Structure and Executable to being GC
objects, and by a long-standing bug that would thrash the global object
between dictionary and non-dictionary states.

  • runtime/BatchedTransitionOptimizer.h:

(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): Don't
eagerly transition to dictionary -- this can cause pathological dictionary
churn, and it's not necessary, since objects know how to automatically
transition to dictionary when necessary.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Be sure to report
extra cost from compilation, because it can be quite high. This is especially
important for program code, since DOM timers can repeatedly allocate
program code without allocating any other objects.

  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect): Don't transition to the uncacheable state
if the thing we're trying to remove doesn't exist. This can happen during
compilation, since the compiler needs to ensure that no pre-existing
conflicting definitions exist for certain declarations.

1:55 PM Changeset in webkit [86262] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Flesh out RenderLayer's ScrollableArea implementation a little more
https://bugs.webkit.org/show_bug.cgi?id=60593

Override a few more ScrollableArea methods on RenderLayer
as a baby-step towards animating overflow div scrolling.

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::visibleContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollPosition): (WebCore::RenderLayer::minimumScrollPosition): (WebCore::RenderLayer::maximumScrollPosition): (WebCore::RenderLayer::visibleContentRect): (WebCore::RenderLayer::overhangAmount): (WebCore::RenderLayer::didCompleteRubberBand):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::shouldSuspendScrollAnimations):
1:54 PM Changeset in webkit [86261] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

<rdar://problem/9421781> Slider thumb draws upside-down in WebKit2
<rdar://problem/9418025> Slider thumb has odd appearance

Fix two issues drawing the slider thumb.

To fix <rdar://problem/9421781>, if we detect that we're in WebKit2
by virtual of the FrameView not having a documentView, then flip
the graphics context.

To fix <rdar://problem/9418025>, we call -drawInteriorWithFrame:inView:
rather than -drawWithFrame:inView: so that AppKit doesn't draw a section
of track behind the thumb.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
1:54 PM Changeset in webkit [86260] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86087 - 2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7011006

1:30 PM Changeset in webkit [86259] by Adam Roben
  • 3 edits
    2 adds in trunk

Don't notify the plugin when a targeted javascript: URL request completes

This matches Mozilla and WebKit1.

Fixes <http://webkit.org/b/60568> <rdar://problem/8610657> REGRESSION (WebKit2): Flash
plugin doesn't appear on a hanes.com page

Test: plugins/get-targeted-javascript-url.html

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest): Don't call back to the plugin if the
request had a target.

LayoutTests:

Test what happens when a plugin makes a targeted javascript: request

  • plugins/get-targeted-javascript-url-expected.txt: Added.
  • plugins/get-targeted-javascript-url.html: Added.

(startTest): Tell the plugin to make two targeted javascript: requests. One calls a function
with a return value, the other calls a function with no return value.
(finishTest): Check that both functions were called, and that we either didn't get an
NPP_URLNotify call (like in Mozilla, WebKit1, and WebKit2), or got an NPP_URLNotify call
with NPRES_DONE (like in Chrome).

1:13 PM Changeset in webkit [86258] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-flaky test (video-layer-crash) from
the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=60634

  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [86257] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make mark stack validation functions do something useful in a release build
https://bugs.webkit.org/show_bug.cgi?id=60645

Turn ASSERTs into actual if(...) CRASH(); statements.

  • heap/MarkStack.cpp: (JSC::MarkStack::validateValue):
1:08 PM Changeset in webkit [86256] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[SnowLeopard WebKit2 Tests] fast/frames/flattening/frameset-flattening-subframesets.html
flakey.
https://bugs.webkit.org/show_bug.cgi?id=60648

Add the test to the mac-wk2 Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
12:51 PM Changeset in webkit [86255] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
12:36 PM Changeset in webkit [86254] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try once more to fix the WinCairo build.

  • platform/graphics/cairo/CairoUtilities.h: Include GraphicsTypes.h with a relative include rather than a system include.
12:28 PM Changeset in webkit [86253] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix copy&paste error in comment.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): the value is stored in regT2, not regT1.
12:12 PM Changeset in webkit [86252] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
https://bugs.webkit.org/show_bug.cgi?id=60521

First steps towards making the results JSON all hierarchical.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
12:03 PM Changeset in webkit [86251] by weinig@apple.com
  • 32 edits
    1 add in trunk/Source

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • Api/qwebelement.cpp:

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Proxy.cpp:
  • dom/ScriptExecutionContext.h:
  • html/HTMLFormElement.cpp:
  • html/parser/XSSFilter.cpp:
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::Console::~Console):
  • page/Console.h:
  • page/ConsoleTypes.h: Added.
  • page/ContentSecurityPolicy.cpp:
  • page/Geolocation.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp:
12:00 PM Changeset in webkit [86250] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Removing now unnecessary Chromium suppressions.

  • platform/chromium/test_expectations.txt:
11:38 AM Changeset in webkit [86249] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

WebKit2 should tell app that is unresponsive in more cases
<rdar://problem/9110151>
https://bugs.webkit.org/show_bug.cgi?id=60608

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Invoke the responsiveness time when forcing a backing store update to catch the cases of activating tabs, resizing the window, etc.
11:35 AM Changeset in webkit [86248] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-05-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r85650.
http://trac.webkit.org/changeset/85650
https://bugs.webkit.org/show_bug.cgi?id=59983

Triggers m_numNodeListCaches > 0 assert in gc-heavy sites.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
11:10 AM Changeset in webkit [86247] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try to fix the WinCairo build.

  • Shared/ShareableBitmap.h: Correctly include RefPtrCairo here and guard it with USE(CAIRO) instead of PLATFORM(CAIRO).
10:58 AM Changeset in webkit [86246] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Build fix, adding new LayoutTestController method stubs.

10:41 AM Changeset in webkit [86245] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Video track sometimes fails to draw.
https://bugs.webkit.org/show_bug.cgi?id=60635
<rdar://problem/9281951>

No new tests, covered by existing pixel tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a

recalculation, and media engine notification, the next time the state machine runs.

10:31 AM Changeset in webkit [86244] by Adam Roben
  • 6 edits in trunk/Source

WinCE build fixes for strict PassOwnPtr

Source/JavaScriptCore:

  • wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault): Use adoptPtr.

Source/WebCore:

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::clipBitmap):
Use nullptr instead of 0.

  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Keep LOOSE_PASS_OWN_PTR turned on for

this file until SimpleFontData::scaledFontData is dealt with on all platforms.

  • platform/text/wince/TextCodecWinCE.cpp:

(WebCore::newTextCodecWinCE): Use adoptPtr.

9:59 AM Changeset in webkit [86243] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

Unskip passed tests.

  • platform/qt/Skipped:

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
The value is checked at EventHandler.cpp:2527 (r86166).

Function keyTextForKeyEvent is partially implemented and can be enhanced in
a need-base.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
9:56 AM Changeset in webkit [86242] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Use case-insensitive comparisons when checking plugin filenames on Windows

Windows paths are nearly always case-insensitive.

I couldn't think of a good way to test this.

Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
should not

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
checking plugin filenames.

9:45 AM Changeset in webkit [86241] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r86228.

  • platform/qt-mac/Skipped: Add failing editing tets.
9:45 AM Changeset in webkit [86240] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=60631>
<rdar://problem/9420520>

Reviewed by Darin Adler.

WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation [60631]

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
Call clearPendingAPIRequestURL().

9:42 AM Changeset in webkit [86239] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[MIPS] Fix compilation of the MIPS JIT

Include the MIPSAssembler.h first to indirectly include
AssemblerBuffer.h before the AbstractMacroAssembler.h. This
order is used for the ARM and X86 MacroAssembler*.h.

  • assembler/MacroAssemblerMIPS.h:
9:40 AM Changeset in webkit [86238] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium suppressions.

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [86237] by Adam Roben
  • 6 edits in trunk/Source

Turn on strict PassOwnPtr on Windows

Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

Source/WebCore:

  • platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this

file until SimpleFontData::scaledFontData is dealt with on all platforms.

Source/WebKit2:

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:

(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.

9:06 AM Changeset in webkit [86236] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed update after r86230.

  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt-mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
9:05 AM Changeset in webkit [86235] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Some skipped editing tests actually work and just need rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=60469

Unskip some editing tests that actually work.

  • platform/qt/Skipped:
8:24 AM Changeset in webkit [86234] by jchaffraix@webkit.org
  • 11 edits
    9 adds in trunk

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

Tests for: XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

  • fast/xpath/xpath-result-eventlistener-crash-expected.txt: Added.
  • fast/xpath/xpath-result-eventlistener-crash.html: Added. Test that an event listener registered on an XPATH result snapshots' node does not crash. This case was already fixed prior to this change. However it is better to keep it as a regression test.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html: Added. Test that an XPath snapshot result keeps its node wrapper alive.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html: Added. Test that an XPath iterator result keeps its node wrapper alive.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html: Added. Test that other XPath result that holds nodes keeps their wrapper alive.

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

The change added a custom mark function for JSC. V8 was already properly
marking the nodes so no change were done on the V8 side.

Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
fast/xpath/xpath-result-eventlistener-crash.html
fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html

  • Android.jscbindings.mk:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added the new file to our build systems.
  • bindings/js/JSXPathResultCustom.cpp: Added. (WebCore::JSXPathResult::markChildren): Added code to mark the XPathResult snapshot's nodes.
  • xml/XPathResult.h: (WebCore::XPathResult::value): Exposed this getter so that we can mark our XPathValue.
  • xml/XPathResult.idl: Told the IDL parser that we now need a custom mark function.
8:12 AM Changeset in webkit [86233] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.originsWithLocalStorage.

Add two more storage tracker tests (added in r86205) to the mac-wk2 Skipped list to get the
bots green.

  • platform/mac-wk2/Skipped:
8:08 AM Changeset in webkit [86232] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] deadlock in gstreamer video player when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=58548

Block data flow towards the pipeline branch to remove to avoid
potential deadlocks during the PAUSED->READY transitions of the
elements to remove.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::exitFullscreen):
7:48 AM Changeset in webkit [86231] by jberlin@webkit.org
  • 11 edits in trunk

[WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
about the usage for both the origin overall and the database in question.
https://bugs.webkit.org/show_bug.cgi?id=60573

Reviewed by Darin Adler.

Source/WebKit2:

Add the currentOriginUsage parameter.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::exceededDatabaseQuota):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::exceededDatabaseQuota):

7:39 AM Changeset in webkit [86230] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Expected results for 2d-transforms new test
https://bugs.webkit.org/show_bug.cgi?id=60565

Patch by Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com> on 2011-05-11
Reviewed by Csaba Osztrogonác.

Added expected results for 1 new 2d-transforms test.

  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt/Skipped: Unskip now passing test.
7:23 AM Changeset in webkit [86229] by senorblanco@chromium.org
  • 2 edits in trunk/Tools

2011-05-10 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Adding myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=60587

  • Scripts/webkitpy/common/config/committers.py:
7:04 AM Changeset in webkit [86228] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove fixed_layout structure in ewk_view
https://bugs.webkit.org/show_bug.cgi?id=60615

Remove unnecessary fixed_layout structure. The ewk_view_fixed_layout_size_set/get()
use WebCore's functions directly.

  • ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set): (ewk_view_fixed_layout_size_get):
5:19 AM Changeset in webkit [86227] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Tomasz Morawski <t.morawski@samsung.com>

Rubber-stamped by Daniel Bates.

Added missing DATABASE macro
https://bugs.webkit.org/show_bug.cgi?id=60437

  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get):
4:30 AM Changeset in webkit [86226] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Csaba Osztrogonác.

queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
https://bugs.webkit.org/show_bug.cgi?id=60614

AppEngine has a result limit of 1000. We hit that when trying
to find out how many patches the style-queue (and other queues)
have passed in the last 30 days. So lets display 1000+ instead
of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)

I also made the status pages show "never" instead of just "ago" when we
haven't seen a pass or boot message in the last 1000 messages.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/templates/queuestatus.html:
2:45 AM Changeset in webkit [86225] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kent Tamura <tkent@chromium.org>

The tests added by r86224 don't work on WebKit2/mac.

  • platform/mac-wk2/Skipped:
2:11 AM Changeset in webkit [86224] by tkent@chromium.org
  • 10 edits
    11 adds in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

  • fast/forms/resources/common.js: Added. Helper functions for fast/forms.
  • fast/forms/validation-message-on-checkbox-expected.txt: Added.
  • fast/forms/validation-message-on-checkbox.html: Added.
  • fast/forms/validation-message-on-listbox-expected.txt: Added.
  • fast/forms/validation-message-on-listbox.html: Added.
  • fast/forms/validation-message-on-menulist-expected.txt: Added.
  • fast/forms/validation-message-on-menulist.html: Added.
  • fast/forms/validation-message-on-radio-expected.txt: Added.
  • fast/forms/validation-message-on-radio.html: Added.
  • fast/forms/validation-message-on-textarea-expected.txt: Added.
  • fast/forms/validation-message-on-textarea.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/validation-message-appearance-expected.png: Updated.
  • platform/mac/fast/forms/validation-message-appearance-expected.txt: Updated.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

Tests: fast/forms/validation-message-on-checkbox.html

fast/forms/validation-message-on-listbox.html
fast/forms/validation-message-on-menulist.html
fast/forms/validation-message-on-radio.html
fast/forms/validation-message-on-textarea.html

  • css/html.css: (::-webkit-validation-bubble-message): Add white-space:normal in order not to inherit white-space:pre for <select>.
  • html/ValidationMessage.cpp: (WebCore::adjustBubblePosition): Adjust the bubble position.
    • The top of the bubble should be same as the bottom of the target control.
    • The left of the bubble should be same as the left of the target control. But If the left+32 is larger than the center of the target control, left+32 should be at the center of the target control. But the left position should not be less than 0.

(WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition().

1:32 AM Changeset in webkit [86223] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot shouldn't spam bugs when it can't figure out who to blame
https://bugs.webkit.org/show_bug.cgi?id=60613

This patch limits the number of bugs sheriffbot will spam to three.
Ideally, we'd come up with some smarter huerstics, but hopefully this
will cut down on the bugmail spam for slow bots.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
12:11 AM Changeset in webkit [86222] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
https://bugs.webkit.org/show_bug.cgi?id=60592

Refactoring, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderFlexibleBox.h:

May 10, 2011:

11:41 PM Changeset in webkit [86221] by yurys@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that browser doesn't crash if alert() arguments conversion throws to an exception
https://bugs.webkit.org/show_bug.cgi?id=60541

  • inspector/console/alert-toString-exception-expected.txt: Added.
  • inspector/console/alert-toString-exception.html: Added.
  • platform/chromium/inspector/console/alert-toString-exception-expected.txt: Added.
11:41 PM Changeset in webkit [86220] by slewis@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

Revert accidental JavaScriptCore change in http://trac.webkit.org/changeset/86130

  • Configurations/JavaScriptCore.xcconfig:
11:12 PM Changeset in webkit [86219] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().
11:07 PM Changeset in webkit [86218] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr patch.

  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData):
11:03 PM Changeset in webkit [86217] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed buildfix for strict OwnPtr.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBufferFromRange): (WebCore::AudioBus::createBySampleRateConverting): (WebCore::AudioBus::createByMixingToMono):
  • platform/audio/HRTFElevation.cpp: (WebCore::HRTFElevation::createForSubject): (WebCore::HRTFElevation::createByInterpolatingSlices):
  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Reverb.cpp: (WebCore::Reverb::initialize):
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource): (WebCore::createBusFromInMemoryAudioFile):
10:56 PM Changeset in webkit [86216] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <abarth@webkit.org>

Build fix for font data madness. I've had to whitelist this on several
ports. They need to all be fixed at once.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
10:35 PM Changeset in webkit [86215] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines.

  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
10:34 PM Changeset in webkit [86214] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX for !ENABLE(TEXT_CARET) after r86039

  • editing/FrameSelection.cpp:

(WebCore::DragCaretController::paintDragCaret): Added
UNUSED_PARAM(frame) for !ENABLE(TEXT_CARET).

10:32 PM Changeset in webkit [86213] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

EWS bots should be robust against test-webkitpy hangs
https://bugs.webkit.org/show_bug.cgi?id=60579

Added a killAfterTimeout subroutine, which takes a child_pid
and timeout, and will setup a watchdog process to kill that child
after the timeout. killAfterTimeout will waitpid on the child.

  • EWSTools/start-queue.sh:
10:25 PM Changeset in webkit [86212] by morrita@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/editing

Merge 86132 - 2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

TBR=levin@chromium.org
BUG=82238
Review URL: http://codereview.chromium.org/7005023

10:21 PM Changeset in webkit [86211] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-10 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
https://bugs.webkit.org/show_bug.cgi?id=60502

Other platforms to follow.

  • wtf/PassOwnPtr.h:
9:59 PM Changeset in webkit [86210] by morrita@google.com
  • 2 edits in trunk/Tools

2011-05-10 MORITA Hajime <morrita@google.com>

Unreviewed, moved myself to the reviewers list.

  • Scripts/webkitpy/common/config/committers.py:
9:50 PM WebKit Team edited by morrita@google.com
(diff)
7:29 PM Changeset in webkit [86209] by ggaren@apple.com
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

2011-05-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed up some #include dependencies so the WriteBarrier class can actually call Heap::writeBarrier
https://bugs.webkit.org/show_bug.cgi?id=60532

  • heap/Handle.h: Moved HandleTypes to its own header because that's the WebKit style, and it was necessary to resolve a circular dependency between Handle.h and WriteBarrier.h.
  • heap/Heap.h: (JSC::Heap::writeBarrier): Added an inline no-op writeBarrier(), to verify that all the code is in the right place.
  • heap/MarkStack.h: Moved WriteBarrier operations to WriteBarrier.h to resolve a circular dependency.
  • runtime/ArgList.h:
  • runtime/JSCell.h: #include WriteBarrier.h since we don't get it for free anymore.
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): Call the real writeBarrier() function, now that it exists.
  • runtime/SmallStrings.h: Removed a stray #include to resolve a circular dependency.
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::set): (JSC::MarkStack::append): (JSC::MarkStack::appendValues): Updated to match the changes above.
7:28 PM Changeset in webkit [86208] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clean up setLayerRenderer() calls in LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=60524

This refactors the way LayerRendererChromium calls setLayerRenderer on its layers in a few ways to clean things
up:

*) Move the pre-paint call to setLayerRenderer from updatePropertiesAndRenderSurfaces() to paintLayerContents().

updatePropertiesAndRenderSurfaces() does too much and the layer renderer pointer only has to be up to date to do
the actual paint. Longer term we won't need to call this at all in order to call paint and this call will just
go away.

*) Tweaks updateCompositorResourcesRecursive() to be slightly shorter and less error-prone.
*) Explicitly set the LayerRendererChromium for each layer in the tree when transfering the root layer (used

during lost context). LayerChromium::setLayerRenderer checks if the new LayerRendererChromium is different
by comparing the pointer value to the old one. This check will be incorrect if there are multiple lost
contexts between a setLayerRenderer() call and a new LayerRendererChromium happens to be allocated at the
same address as the old one. An explicit call to setLayerRenderer() for every layer in the tree fixes this
since when this function is called the new and old LayerRendererChromium are still live and so they cannot
live at the same address.

The first two changes are purely refactors and do not change behavior. The third issue can't be tested via a
layout test directly as we don't have a way to induce a lost context on the compositor in a layout test.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::clearLayerRendererRecursive): (WebCore::LayerRendererChromium::transferRootLayer): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
7:18 PM Changeset in webkit [86207] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

7:11 PM Changeset in webkit [86206] by oliver@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-10 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Assertion failure in JSC::Structure::typeInfo when reloading weather.com video page
https://bugs.webkit.org/show_bug.cgi?id=60580

The plugin object map was incorrect trying to implement a weak map itself using
destructors. Switch to a WeakGCMap and the problem is fixed.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::~JSNPObject):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateJSObject): (WebKit::NPRuntimeObjectMap::invalidate):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
6:53 PM Changeset in webkit [86205] by commit-queue@webkit.org
  • 18 edits
    4 adds in trunk

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Added.
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Added.

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html

storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html

Use SQLiteFileSystem::getDatabaseFileSize to get actual usage by
an origin's local storage db. Factored out code that retrieves
path of local storage db.

  • WebCore.exp.in: Sorted alphabetically StorageTracker's mangled function names.
  • storage/StorageTracker.cpp: (WebCore::StorageTracker::syncDeleteOrigin): Uses helper function to get path of origin's db (WebCore::StorageTracker::databasePathForOrigin): New helper function. that gets the path of an origin's local storage db from StorageTracker. (WebCore::StorageTracker::diskUsageForOrigin): New API.
  • storage/StorageTracker.h:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by David Levin.

StorageTracker should report actual local storage usage on disk
https://bugs.webkit.org/show_bug.cgi?id=60558

  • DumpRenderTree/LayoutTestController.cpp: (localStorageDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::localStorageDiskUsageForOrigin):
6:47 PM Changeset in webkit [86204] by commit-queue@webkit.org
  • 22 edits
    6 adds in trunk

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

  • http/tests/appcache/origin-usage-expected.txt: Added.
  • http/tests/appcache/origin-usage.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-1.manifest: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.html: Added.
  • http/tests/appcache/resources/origin-usage-iframe-2.manifest: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

ApplicationCacheStorage already provides an API to get per-origin
disk usage. This should be exposed through WebCore::ApplicationCache
to not be dependent on storage implementation.

Test: http/tests/appcache/origin-usage.html

  • WebCore.exp.in:
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::diskUsageForOrigin):
  • loader/appcache/ApplicationCache.h:

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added Mac port API.

  • WebCoreSupport/WebApplicationCache.h:
  • WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache diskUsageForOrigin:]):

2011-05-10 Anton D'Auria <adauria@apple.com>

Reviewed by Alexey Proskuryakov.

Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Added test that loads two frames with ~15Kb image, checks usage,
deletes app cache, verifies usage is 0.

  • DumpRenderTree/LayoutTestController.cpp: (applicationCacheDiskUsageForOriginCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. (LayoutTestController::LayoutTestController): (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. (LayoutTestController::applicationCacheDiskUsageForOrigin):
6:44 PM Changeset in webkit [86203] by demarchi@webkit.org
  • 2 edits in trunk/Tools

2011-05-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, adding Rafael Antognolli as a committer.

  • Scripts/webkitpy/common/config/committers.py:
6:34 PM Changeset in webkit [86202] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-10 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add some aggressive GC validation to debug builds.
https://bugs.webkit.org/show_bug.cgi?id=60601

When assertions are enabled we now do some validity checking
of objects being added to the mark stack.

  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo): (JSC::PolymorphicAccessStructureList::visitAggregate):
  • heap/MarkStack.cpp: (JSC::MarkStack::validateSet): (JSC::MarkStack::validateValue):
  • heap/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
6:24 PM Changeset in webkit [86201] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-05-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h: Add plumbing for new settings to Chromium DRT.
5:46 PM Changeset in webkit [86200] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Protect self in [WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]
https://bugs.webkit.org/show_bug.cgi?id=60594
<rdar://problem/9203259>

Reviewed by Alexey Proskuryakov.

No tests since we don't have any bots testing CFNETWORK_DATA_ARRAY_CALLBACK.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): The didReceiveData()
callback on client can result in the load being cancelled. This results in the delegate
(self) being freed. Protect self during the loop so we can check for m_handle and safely
return without crashing.

5:33 PM Changeset in webkit [86199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Chris Guillory <chris.guillory@google.com>

Reviewed by James Robinson.

[ChromiumWin] Font::drawComplexText calls EndPlatformPaint without calling BeginPlatformPaint.
https://bugs.webkit.org/show_bug.cgi?id=59848

To test this I plan to make the non-printing device (BitmapPlatformDevice) fail
when EndPlatformPaint doesn't matchup with BeginPlatformPaint.
http://codereview.chromium.org/6949012/

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawComplexText):
5:19 PM Changeset in webkit [86198] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Yet more quarantine related sandbox denial when downloading files
<rdar://problem/9397494>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb:
5:10 PM Changeset in webkit [86197] by commit-queue@webkit.org
  • 23 edits
    1 delete in trunk/Source/WebCore

2011-05-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86195.
http://trac.webkit.org/changeset/86195
https://bugs.webkit.org/show_bug.cgi?id=60597

LayerOffset is a really bad name (Requested by smfr on
#webkit).

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Removed.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
5:06 PM Changeset in webkit [86196] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert x,y and width,height pairs to IntPoint and IntSize for RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=60409

Convert RenderLayer to use IntPoint for x,y pairs and IntSize for offsets and sizes.

Refactoring, covered by existing tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollTo): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::scrollWidth): (WebCore::RenderLayer::scrollHeight): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::x): (WebCore::RenderLayer::y): (WebCore::RenderLayer::setLocation): (WebCore::RenderLayer::width): (WebCore::RenderLayer::height): (WebCore::RenderLayer::size): (WebCore::RenderLayer::setWidth): (WebCore::RenderLayer::setHeight): (WebCore::RenderLayer::scrolledContentOffset): (WebCore::RenderLayer::scrollXOffset): (WebCore::RenderLayer::scrollYOffset): (WebCore::RenderLayer::scrollOffset): (WebCore::RenderLayer::scrollToXOffset): (WebCore::RenderLayer::scrollToYOffset): (WebCore::RenderLayer::relativePositionOffset):
4:45 PM Changeset in webkit [86195] by leviw@chromium.org
  • 23 edits
    1 add in trunk/Source/WebCore

2011-05-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Create LayerOffset class
https://bugs.webkit.org/show_bug.cgi?id=60490

Adding a LayerOffset class that will replace existing usage of tx/ty.
LayerOffset is necessary since these values are commonly used as both
a size and a point. Updating paintIntoRect to use this new class.

No new tests since this doesn't change any behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • platform/graphics/LayerOffset.h: Added. (WebCore::LayerOffset::LayerOffset): (WebCore::LayerOffset::x): (WebCore::LayerOffset::y): (WebCore::LayerOffset::setX): (WebCore::LayerOffset::setY): (WebCore::LayerOffset::toSize): (WebCore::LayerOffset::toPoint): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-): (WebCore::operator==): (WebCore::operator!=):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
4:37 PM Changeset in webkit [86194] by jam@chromium.org
  • 2 edits in branches/chromium/742/Source/WebKit/chromium

Revert 79703 - 2011-02-15 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

TBR=brettw@chromium.org
BUG=81878
Review URL: http://codereview.chromium.org/7005016

4:32 PM Changeset in webkit [86193] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Make member variables of CaretBase private
https://bugs.webkit.org/show_bug.cgi?id=60454

Moved m_absCaretBounds, m_absoluteCaretRepaintBounds, m_absCaretBoundsDirty, and m_caretPaint back
from CaretBase to FrameSelection because they are only used in FrameSelection, and made the rest
of member variables in CaretBase private.

  • editing/FrameSelection.cpp: (WebCore::CaretBase::CaretBase): Takes CaretVisibility as an argument. (WebCore::DragCaretController::DragCaretController): (WebCore::FrameSelection::FrameSelection): Initializes m_absCaretBoundsDirty and m_caretPaint now that they are part of FrameSelection again. (WebCore::DragCaretController::setCaretPosition): (WebCore::FrameSelection::setSelection): (WebCore::CaretBase::clearCaretRect): Extracted from updateCaretRect. (WebCore::CaretBase::updateCaretRect): No longer clears caret; all call sites (namely setCaretPosition and localCaretRect) that used to call updateCaretRect now need to call clearCaretRect or updateCaretRect based on some conditions. (WebCore::FrameSelection::localCaretRect): (WebCore::CaretBase::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::paintCaret): Only calls CaretBase::paintCaret if m_caretPaint is true. (WebCore::CaretBase::paintCaret): Removed an early exit for when m_caretPaint is false since m_caretPaint has been moved from CaretBase to FrameSelection. (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisibility): Takes CaretVisibility instead of bool. (WebCore::FrameSelection::caretBlinkTimerFired):
  • editing/FrameSelection.h: (WebCore::CaretBase::fastLocalCaretRect): Added; replaces localCaretRectForPainting. (WebCore::CaretBase::shouldUpdateCaretRect): Added. (WebCore::CaretBase::setCaretRectNeedsUpdate): Added. (WebCore::CaretBase::setCaretVisibility): Added. (WebCore::CaretBase::caretIsVisible): Added. (WebCore::FrameSelection::setCaretRectNeedsUpdate): Added.
4:28 PM Changeset in webkit [86192] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-10 Adam Klein <adamk@chromium.org>

Reviewed by David Levin.

LayoutTest demonstrating that filesystem: URLs are not cached in WebKit
https://bugs.webkit.org/show_bug.cgi?id=58854

Regression test for http://crbug.com/79539.

  • http/tests/filesystem/no-cache-filesystem-url-expected.txt: Added.
  • http/tests/filesystem/no-cache-filesystem-url.html: Added.
4:24 PM Changeset in webkit [86191] by enrica@apple.com
  • 2 edits in trunk/Tools

Added my name to the reviewers list and removed my name from
to committer-only list.

Reviewed by Beth Dakin.

  • Scripts/webkitpy/common/config/committers.py:
4:14 PM WebKit Team edited by enrica@apple.com
(diff)
4:01 PM Changeset in webkit [86190] by jpu@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Added myself as commiter.

3:57 PM Changeset in webkit [86189] by jamesr@google.com
  • 8 edits in trunk/Source/WebCore

2011-05-10 James Robinson <jamesr@chromium.org>

Reviewed by Nate Chapin.

[chromium] Use parent/child terms for compositor tree structures consistently instead of superlayer/sublayer
https://bugs.webkit.org/show_bug.cgi?id=60588

GraphicsLayer uses parent/child terminology for tree structure, as does CCLayerImpl. LayerChromium was using
superlayer/sublayer terms, inherited from this code's branching from the platform/graphics/win/CACF code. The
mixed terminology is confusing and parent/child is more common, so this unifies everything to use parent/child.

No new tests, refactor only.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToCanvas): (WebCore::GraphicsLayerChromium::setContentsToMedia): (WebCore::GraphicsLayerChromium::hostLayerForChildren): (WebCore::GraphicsLayerChromium::layerForParent): (WebCore::GraphicsLayerChromium::updateChildList): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::setupContentsLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::addChild): (WebCore::LayerChromium::insertChild): (WebCore::LayerChromium::removeFromParent): (WebCore::LayerChromium::removeChild): (WebCore::LayerChromium::replaceChild): (WebCore::LayerChromium::indexOfChild): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllChildren): (WebCore::LayerChromium::setChildren): (WebCore::LayerChromium::parent): (WebCore::LayerChromium::dumpLayer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::children): (WebCore::LayerChromium::setParent): (WebCore::LayerChromium::numChildren):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive): (WebCore::LayerRendererChromium::dumpRenderSurfaces):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::descendantsDrawsContent):
  • platform/graphics/chromium/cc/CCLayerImpl.h:
3:45 PM Changeset in webkit [86188] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Switch RenderBoxModelObject::paintNinePieceImage to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60586

Switch paintNinePieceImage to take an IntRect instead of four ints representing an IntRect!

No new tests as this is simply refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage): (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
3:44 PM Changeset in webkit [86187] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-10 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Coalesced wheel events should be saved to hand back to the client on unhandled return
https://bugs.webkit.org/show_bug.cgi?id=60584

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): (WebKit::canCoalesce): (WebKit::coalesce): (WebKit::coalescedWheelEvent): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::processDidCrash): Reworks coalescing/merging code to happen on didReceiveEvent rather than in handleWheelEvent. This means we now store the pending events in a queue, and pull them out when we can.
  • UIProcess/WebPageProxy.h: Change single event containers to contain all pending/merged/coalesced events and remove unused flag.
3:43 PM Changeset in webkit [86186] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
https://bugs.webkit.org/show_bug.cgi?id=60531

Remove the (unused) _isAnimating ivar and replace it with two ivars: _isEnteringFullScreen and
_isExitingFullScreen. These will ensure each is only called once per full screen request, and
that if one exit/enter request interrupts another, that the required functions are called in
order.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Removed _isAnimating. (-[WKFullScreenWindowController exitFullScreen]): Ditto. (-[WKFullScreenWindowController beganEnterFullScreenAnimation]): Gate on _isEnteringFullScreen. Check _isExitingFullScreen

and call [self finishedExitFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Gate on _isEnteringFullScreen.
(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Gate on _isExitingFullScreen. Check _isEnteringFullScreen

and call [self finishedEnterFullScreenAnimation:] if necessary.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Gate on _isExitingFullScreen.

3:38 PM Changeset in webkit [86185] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
https://bugs.webkit.org/show_bug.cgi?id=60278

  • fullscreen/full-screen-remove-children-expected.txt: Added.
  • fullscreen/full-screen-remove-children.html: Added.
  • fullscreen/full-screen-test.js: Fixed an exception when running in Safari.

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Removing the full screen element via parent.innerHTML="" does not result in a webkitfullscreenchange event.
https://bugs.webkit.org/show_bug.cgi?id=60278

Handle the removal of a full screen element from within Node::willRemove() instead
of Document::nodeWillBeRemoved(). The new function Document::fullScreenElementWillBeRemoved() will
be called by Node::willRemove() to handle those changes which used to occur in nodeWillBeRemoved().

Test: fullscreen/full-screen-remove-children.html

  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved): Removed the code checking for the full screen element. (WebCore::Document::fullScreenElementWillBeRemoved): Added, moved from nodeWillBeRemoved.
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::willRemove): Check to see if this is the current full screen element.
3:37 PM Changeset in webkit [86184] by Beth Dakin
  • 15 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=60582
Crash switching overlay/non-overlay scrollbar preference still possible
-and corresponding-
<rdar://problem/9323983>

Reviewed by Darin Adler.

Source/WebCore:

This patch prevents any work from being done on pages that are in the page cache
when the preference is switched.

When the Document is going into or coming out of the page cache, have the
FrameView inactivate or activate the Page's ScrollAnimators as appropriate.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

Iterate through the Page's ScrollableAreas setting the active state of the
ScrollAnimators.

  • page/FrameView.cpp:

(WebCore::FrameView::setAnimatorsAreActive):

  • page/FrameView.h:

ScrollAnimator has a new bit -- m_isActive. Right now m_isActive is always true
unless the ScrollAnimator belongs to a ScrollableArea that is in the page cache.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::setIsActive):
(WebCore::ScrollAnimator::isActive):

ScrollAnimatorMac has a new bit -- m_needsScrollerStyleUpdate. This is set to true
when a ScrollAnimator is inactive and has received the
updateScrollerStyleForNewRecommendedScrollerStyle delegate notification. It
prevents any work from being done for this delegate until the ScrollAnimator
becomes active again.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::setNeedsScrollerStyleUpdate):
(WebCore::ScrollAnimatorMac::needsScrollerStyleUpdate):

This delegate method has been re-factored into ScrollAnimatorMac::
updateScrollerStyle(). This way the meat of the function can be called by both the
delegate and ScrollAnimatorMac::setIsActive()

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):

This override of ScrollAnimator::setIsActive() calls the base class, and then calls updateScrollerStyle() if needsScrollerStyleUpdate() is set to true.
(WebCore::ScrollAnimatorMac::setIsActive):

This is mostly the same as the old delegate method. Key differences are that if
the ScrollAnimator is inactive, we now setNeedsScrollerStyleUpdate(true) and
return early. We also only call scrollableArea()->scrollbarStyleChanged() if
needsScrollerStyleUpdate() is false since in the true case when we are restoring
from the page cache, this would be duplicated work.
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

New WKSystemInterface function is needed to retrieve the scrollbar style.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:15 PM Changeset in webkit [86183] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-05-10 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Windows clients need to know if the page overlay is installed
https://bugs.webkit.org/show_bug.cgi?id=60562
<rdar://problem/8940164>


Until we move all the UI for find on page into WebKit on Windows (specifically, drawing the find bouncy),
WebKit clients need to know whether WebKit is drawing the page overlay or not. Keep track of this in
the WebPageProxy in the UI process and provide a WebKit2 API to retrieve this information.

  • UIProcess/API/C/win/WKView.cpp: (WKViewIsPageOverlayInstalled): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewIsPageOverlayInstalled().


  • UIProcess/PageClient.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.h: Added didInstallOrUninstallPageOverlay().
  • UIProcess/WebPageProxy.messages.in: Added DidInstallOrUninstallPageOverlay.
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::didInstallOrUninstallPageOverlay): Added.


  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): Initialize m_pageOverlayInstalled. (WebKit::WebView::didInstallOrUninstallPageOverlay): Added.
  • UIProcess/win/WebView.h: Added didInstallOrUninstallPageOverlay() and m_pageOverlayInstalled. (WebKit::WebView::pageOverlayInstalled): Added.


  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Send message to UI process to tell it the page overlay is installed. (WebKit::WebPage::uninstallPageOverlay): Send message to UI process to tell it the page overlay is uninstalled.
3:11 PM WebKit Team edited by senorblanco@chromium.org
(diff)
2:53 PM Changeset in webkit [86182] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-10 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict PassOwnPtr on Chromium
https://bugs.webkit.org/show_bug.cgi?id=60502

Technically there are a few bits in here that weren't reviewed by Dave,
but close enough for government work. This patch all fixes the
remaining strict PassOwnPtr violations on Chromium Linux.

  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2:43 PM Changeset in webkit [86181] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 84611 - <rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

  • media/audio-controls-do-not-fade-out-expected.txt: Added.
  • media/audio-controls-do-not-fade-out.html: Added.

TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7005009

2:19 PM Changeset in webkit [86180] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

In my patch to fix https://bugs.webkit.org/show_bug.cgi?id=60572 I committed without having saved ChangeLog and code comments that are critical to explain the bug and the code change.

Whoops! Here they are.

1:26 PM Changeset in webkit [86179] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9343191> and https://bugs.webkit.org/show_bug.cgi?id=60572

Reviewed by Alice Liu.

No new tests - There's no way to reproduce the truly bizarre things Canon does in their app
that would reasonably fit in to our testing infrastructure.

Add a timer to Settings and instead of calling setLoadsImagesAutomaticallyInAllFrames right
away when this pref changes, call it on a 0-delay:

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::loadsImagesAutomaticallyTimerFired):

  • page/Settings.h:
12:37 PM Changeset in webkit [86178] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK][WebKit2] GTK+ 2.x widget rendering fails after r85480
https://bugs.webkit.org/show_bug.cgi?id=59990

No new tests. This is covered by existing pixel tests.

  • platform/gtk/GtkVersioning.c: (getGdkDrawableSize): Added this helper method.
  • platform/gtk/GtkVersioning.h: Added helper method declaration.
  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Call into the helper if there is actually a GdkDrawable. If not, disable the sanity check.
12:33 PM Changeset in webkit [86177] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-05-10 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ WebKit2 build. Add a CredentialsStorage stub for libsoup.

  • GNUmakefile.list.am: Add stub to source list.
  • platform/network/soup/CredentialStorageSoup.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Added stub. (WebCore::CredentialStorage::get):
12:24 PM Changeset in webkit [86176] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): This conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Dan Bernstein.

Second attempts at a fix for this bug. Instead of removing the dirtying (which turned out to be needed in a few cases),
make dirtyLinesFromChangedChild mark a child as needing layout when it has to recur to the parent. Because the method already
aborts the recursion if selfNeedsLayout() is set on the parent, this has the effect of stopping the O(n2) pathological
behavior, since you can use the selfNeedsLayout() bit to understand that you've dirtied the lines already.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

12:23 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:57 AM Changeset in webkit [86175] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Remove incorrect ASSERTs from CoreIPC::Connection::processIncomingSyncReply
https://bugs.webkit.org/show_bug.cgi?id=60567
<rdar://problem/9377845>

It is possible to receive an incoming sync reply that is for a request we don't know about.
This could happen if the sync message send timed out for example.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingSyncReply):
11:57 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:32 AM Changeset in webkit [86174] by mrobinson@webkit.org
  • 11 edits in trunk/Source

2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
https://bugs.webkit.org/show_bug.cgi?id=60293

No new tests. This is covered by current pixel tests.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyCairoImageSurface): Abstract the code from WebCore::ImageBuffer::copyImage into this helper which creates a deep copy of a Cairo image surface.
  • platform/graphics/cairo/CairoUtilities.h: Added declaration.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::copyImage): Use the new helper.
  • platform/graphics/cairo/ImageCairo.cpp: Abstract some of this logic into the new drawSurfaceToContext method on PlatformContextCairo. (WebCore::BitmapImage::draw):
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::drawPatternToCairoContext): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext): Added.
  • platform/graphics/cairo/PlatformContextCairo.h: Added declarations.

2011-05-05 Brent Fulgham <bfulgham@webkit.org> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[Cairo][WebKit2] Add an implementation of ShareableBitmap for Cairo
https://bugs.webkit.org/show_bug.cgi?id=60293

  • GNUmakefile.am: Remove ShareableBitmapGtk in favor of ShareableBitmapCairo.
  • Shared/ShareableBitmap.h: Added a couple Cairo-specific declarations.
  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): Added. (WebKit::ShareableBitmap::paint): Added. (WebKit::ShareableBitmap::createCairoSurface): Added. (WebKit::ShareableBitmap::releaseSurfaceData): Added.
11:30 AM Changeset in webkit [86173] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/JavaScriptCore/wtf/FastMalloc.cpp

Merge 86106
BUG=82152
Review URL: http://codereview.chromium.org/7000002

11:28 AM Changeset in webkit [86172] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix Qt build.

  • platform/network/qt/CredentialStorageQt.cpp:

(WebCore::CredentialStorage::get):
Add stub.

11:12 AM Changeset in webkit [86171] by tony@chromium.org
  • 8 edits
    1 add
    1 delete in trunk

2011-05-10 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
https://bugs.webkit.org/show_bug.cgi?id=60079

Update the expected results.

  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html:
  • platform/chromium-linux/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-05-10 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

REGRESSION(r85013): platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html is failing
https://bugs.webkit.org/show_bug.cgi?id=60079

Set resultingNumPoints = 0 so that harfbuzz uses the design coordinate
value pair.

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint): Just return HB_Err_Ok with resultingNumPoints = 0.
11:04 AM Changeset in webkit [86170] by imasaki@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-05-10 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaselines for video-layer-crash.
https://bugs.webkit.org/show_bug.cgi?id=60548

Chromium bug is http://crbug.com/60744. Expected images need to be
updated because they are incorrect. The cause of this image change
cannot be easily determined at present because the test has been
broken for so long.

  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Added.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Added.
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
11:04 AM Changeset in webkit [86169] by andersca@apple.com
  • 14 edits in trunk/Source

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
https://bugs.webkit.org/show_bug.cgi?id=60560
<rdar://problem/9338693>

Add symbols required by WebKit2.

  • WebCore.exp.in:

2011-05-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Extra sign in required to view video on MobileMe Gallery album
https://bugs.webkit.org/show_bug.cgi?id=60560

Implement NPN_GetAuthenticationInfo.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::getAuthenticationInfo): Send a GetAuthenticationInfo message to the web process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::initializeProtectionSpace): Initialize a WebCore::ProtectionSpace object from NPAPI parameters.

(WebKit::NPN_GetAuthenticationInfo):
Make a ProtectionSpace object and then call NetscapePlugin::getAuthenticationInfo.
Finally, copy the username/password and pass them back to the plug-in.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::getAuthenticationInfo): Call the plug-in controller.
  • WebProcess/Plugins/PluginController.h: Add getAuthenticationInfo pure virtual member function.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::getAuthenticationInfo): Call the real plug-in controller's getAuthenticationInfo member function.
  • WebProcess/Plugins/PluginProxy.messages.in: Add GetAuthenticationInfo message.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::getAuthenticationInfo): Try to get the authentication info from the credential storage. Failing that, get it from the persistent credential storage.
10:46 AM Changeset in webkit [86168] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Styles sidebar is not updated upon changes in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60320

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
10:37 AM Changeset in webkit [86167] by jamesr@google.com
  • 25 edits
    16 deletes in branches/chromium/742

Revert 79985 - 2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
mutations take affect, but don't affect other renderers which shared the SVGPaint object before.

  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
  • platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
  • svg/animations/animate-color-fill-currentColor-expected.txt: Added.
  • svg/animations/animate-color-fill-currentColor.html: Added.
  • svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
  • svg/custom/SVGPaint-mutate-attribute.svg: Added.
  • svg/custom/SVGPaint-mutate-inline-style.svg: Added.
  • svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
  • svg/dom/SVGPaint-expected.txt: Same for SVGPaint.

2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800

Wrong handling of currentColor on inherit
https://bugs.webkit.org/show_bug.cgi?id=38102

Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).

<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.

In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.

A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)

Add several new tests covering the patch.

Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg

svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg

  • GNUMakefile.am: Add CSSMutableValue.h
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
  • css/CSSMutableStyleDeclaration.h: Add destructor.
  • css/CSSMutableValue.h: Added. (WebCore::CSSMutableValue::CSSMutableValue): (WebCore::CSSMutableValue::~CSSMutableValue): (WebCore::CSSMutableValue::isMutableValue): (WebCore::CSSMutableValue::node): (WebCore::CSSMutableValue::setNode): (WebCore::CSSMutableValue::setNeedsStyleRecalc):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
  • css/CSSValue.h: (WebCore::CSSValue::isMutableValue): Return false, default.
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
  • rendering/style/SVGRenderStyle.h: Ditto. (WebCore::SVGRenderStyle::initialFillOpacity): (WebCore::SVGRenderStyle::initialFillPaintType): (WebCore::SVGRenderStyle::initialFillPaintColor): (WebCore::SVGRenderStyle::initialFillPaintUri): (WebCore::SVGRenderStyle::initialStrokeOpacity): (WebCore::SVGRenderStyle::initialStrokePaintType): (WebCore::SVGRenderStyle::initialStrokePaintColor): (WebCore::SVGRenderStyle::initialStrokePaintUri): (WebCore::SVGRenderStyle::initialStrokeMiterLimit): (WebCore::SVGRenderStyle::initialStopOpacity): (WebCore::SVGRenderStyle::initialFloodOpacity): (WebCore::SVGRenderStyle::setFillPaint): (WebCore::SVGRenderStyle::setStrokePaint): (WebCore::SVGRenderStyle::fillPaintType): (WebCore::SVGRenderStyle::fillPaintColor): (WebCore::SVGRenderStyle::fillPaintUri): (WebCore::SVGRenderStyle::strokePaintType): (WebCore::SVGRenderStyle::strokePaintColor): (WebCore::SVGRenderStyle::strokePaintUri): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
  • rendering/style/SVGRenderStyleDefs.cpp: Ditto. (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: Ditto.
  • rendering/svg/RenderSVGResource.cpp: Ditto. (WebCore::requestPaintingResource):
  • rendering/svg/RenderSVGResourceClipper.cpp: Ditto. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
  • rendering/svg/SVGResources.cpp: Ditto. (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources):
  • svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object. (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor):
  • svg/SVGColor.h:
  • svg/SVGPaint.cpp: Ditto. (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
  • svg/SVGPaint.h:

TBR=kerz@chromium.org
BUG=80880
Review URL: http://codereview.chromium.org/7002001

10:36 AM Changeset in webkit [86166] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-10 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

Convert editing/inserting/typing-tab-designmode-forms.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=60554

  • editing/inserting/typing-tab-designmode-forms-expected.txt: Added.
  • editing/inserting/typing-tab-designmode-forms.html:
  • platform/chromium-linux/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-win/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/gtk/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
  • platform/mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt: Removed.
10:28 AM Changeset in webkit [86165] by levin@chromium.org
  • 9 edits in trunk/Tools

2011-05-10 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
https://bugs.webkit.org/show_bug.cgi?id=60466

  • Scripts/webkitpy/style/checker.py: (unrelated) style fix.
  • Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since that property was removed.
  • Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line filtering for errors.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to verify that the line filtering is turned off.
  • Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors and remove the unused file_path parameter.
  • Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the line filtering is turned off (and fix test_no_error).
  • Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering of errors based on the lines changed in the patch.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off the filtering.
10:26 AM Changeset in webkit [86164] by brettw@chromium.org
  • 5 edits in trunk/Source

2011-05-06 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Use a File object to store the downloaded file reference rather than
just the path. This keeps the file and permissions in scope (using the
already-existing blob system) so the browser won't delete the file
when the load is complete. Instead, the file will be cleaned up when
the request objects are deleted.
https://bugs.webkit.org/show_bug.cgi?id=60281

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadedFile): (WebCore::ResourceResponse::setDownloadedFile):
10:08 AM Changeset in webkit [86163] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-10 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Files that load quickly sometimes won't play.
https://bugs.webkit.org/show_bug.cgi?id=60556
<rdar://problem/9330567>

No new tests, this failure is very difficult to reproduce on some machines. The fix was
verified manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::playabilityKnown): Move the call to updateStates

to dispatchNotification so it is more obvious which state changes call it.

(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Correct logging typo.
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Move updateStates call to

dispatchNotification.

(WebCore::MediaPlayerPrivateAVFoundation::rateChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call updateStates after

processing "size changed" notification so we detect all state changes. Consolidate
calls to updateStates here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Name the video layer in

a debug build.

9:57 AM Changeset in webkit [86162] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/742

Merge 86160 - Fix null ptr crash from r85876

BUG=72832
Review URL: http://codereview.chromium.org/6999012

9:46 AM Changeset in webkit [86161] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Use FontSmoothingLevelWindows by default on Windows

Fixes <http://webkit.org/b/60557> REGRESSION (r86077): Web Inspector uses CG font rendering
in WebKit2 on Windows

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Added and deployed a new DEFAULT_WEBKIT_FONT_SMOOTHING_LEVEL

macro to let Windows have a different default font smoothing level from other platforms.

  • UIProcess/API/C/WKPreferencesPrivate.h: Updated the comment about the default font

smoothing level.

9:40 AM Changeset in webkit [86160] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Add containsFloats call to hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537

Test: fast/block/float/no-overhanging-float-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats):

2011-05-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash due to wrong result from
hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537

  • fast/block/float/no-overhanging-float-crash-expected.txt: Added.
  • fast/block/float/no-overhanging-float-crash.html: Added.
9:22 AM Changeset in webkit [86159] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Drop obsolete test code for the Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=60471

  • src/js/Tests.js:
9:22 AM Changeset in webkit [86158] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] Increment QtWebKit trunk version to 4.10.0
https://bugs.webkit.org/show_bug.cgi?id=60549

QtWebKit-2.2 (branched) will be 4.9.0, so we need to
increase the trunk version by 1.

  • qt_webkit_version.pri:
8:50 AM Changeset in webkit [86157] by Adam Roben
  • 9 edits
    2 deletes in trunk

Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows

Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Anders Carlsson.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:

(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
WindowedPluginTest::testHarnessWindow function.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:

(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
created for.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
WindowedPluginTest, and initialized new members.
(WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
(WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
then clean up and tell the test harness we're done.
(WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
(WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
window becomes visible.
(WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
if it was hidden at the start of the test.
(WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
This should cause our window to become visible and our window region to get set. When we get
a WM_WINDOWPOSCHANGED message, we can finally finish the test.
(WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
(WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
"startTest".
(WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:

(WindowedPluginTest::testHarnessWindow):

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:

Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.

LayoutTests:

  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Updated

for new test output that doesn't claim anything about the window's position.

  • platform/win/plugins/window-region-is-set-to-clip-rect.html: Hide the plugin initially,

and tell the plugin when the load event has fired.

  • platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
  • platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
8:48 AM Changeset in webkit [86156] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/workers/wrapper-map-gc.html, because it crashes intermittently.
8:43 AM Changeset in webkit [86155] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt-arm/Skipped: Add fast/dom/Geolocation/window-close-crash.html.
8:32 AM Changeset in webkit [86154] by Ademar Reis
  • 2 edits in trunk/Source/WebKit/qt

2011-05-10 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] tst_QWebPage creates temporary files in the current working dir
https://bugs.webkit.org/show_bug.cgi?id=60497

tst_QWebPage was using QDir::currentPath when creating temporary dirs
and leaving them after the test was run. I basically borrowed the fix
from tst_QDeclarativeWebView.

  • tests/qwebpage/tst_qwebpage.cpp: (removeRecursive): (tst_QWebPage::tmpDirPath): (tst_QWebPage::cleanupFiles): (tst_QWebPage::database): (tst_QWebPage::multiplePageGroupsAndLocalStorage):
8:25 AM Changeset in webkit [86153] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Antonio Gomes.

Warning fix on PluginPackage.cpp.
https://bugs.webkit.org/show_bug.cgi?id=60371

Warning fix on conversion from time_t to unsigned on Linux with GCC 4.6.0.
Let's use a struct rather than an array so we can pass everything to StringHasher.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
7:56 AM Changeset in webkit [86152] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Disable HAVE_QRAWFONT until Qt API stabilizes.
https://bugs.webkit.org/show_bug.cgi?id=60551

  • WebCore.pro: Disable the line that enables HAVE_QRAWFONT if the feature is found. Added a comment about why.
7:39 AM Changeset in webkit [86151] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-05-10 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Fix video-play-stall-before-metadata.

A stalled event won't be sent until no progress has happened for 3
seconds. Make sure that the connection is still open for at least that long.
https://bugs.webkit.org/show_bug.cgi?id=60306

  • http/tests/media/video-load-and-stall.cgi:
  • http/tests/media/video-play-stall-before-meta-data.html:
  • platform/chromium/test_expectations.txt:
6:56 AM Changeset in webkit [86150] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

One more unreviewed typo fix after r86148. :(

  • platform/qt-4.8/Skipped:
6:54 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
6:51 AM Changeset in webkit [86149] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86148.

  • platform/qt-4.8/Skipped:
6:48 AM Changeset in webkit [86148] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
http://trac.webkit.org/changeset/86143

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped:
    • Add http/tests/security/xss-DENIED-xsl-document.xml
    • Add http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html
6:43 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
6:22 AM Changeset in webkit [86147] by caseq@chromium.org
  • 4 edits in trunk

2011-05-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
https://bugs.webkit.org/show_bug.cgi?id=60266

  • bindings/objc/DOM.mm: (kitClass): return DOMNode class for shadow root node

2011-05-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Sam Weinig.

Web Inspector: inspector/console/console-shadow-dom-access.html crashes on mac debug
https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped: removed suppression of console-shadow-dom-access.html
5:55 AM Changeset in webkit [86146] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[WK2] eventSender.keyDown is unimplemented

Move fast/forms/radio-group-keyboard-change-event.html from qt-wk2/Skipped to
mac-wk2/Skipped, because it isn't Qt specific bug, but general WK2 specific one.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
5:42 AM Changeset in webkit [86145] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt][Mac] Add platform specific expected result for plugins/plugin-javascript-access.html,
which is same as the platform independent one, but differs from the general Qt specific.

  • platform/qt-mac/plugins: Added.
  • platform/qt-mac/plugins/plugin-javascript-access-expected.txt: Added.
5:33 AM Changeset in webkit [86144] by benm@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-10 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Fix build in WebCore/xml/XSLTProcessorLibxslt.cpp
https://bugs.webkit.org/show_bug.cgi?id=60478

No new tests), build fix only.

  • xml/XSLTProcessorLibxslt.cpp: Add CString.h include.
5:30 AM Changeset in webkit [86143] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

It is a general Qt related bug, so we should add it to qt/Skipped instead of all Skipped list.

  • platform/qt-arm/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-linux/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt-mac/Skipped: Remove fast/events/backspace-navigates-back.html.
  • platform/qt/Skipped: Add fast/events/backspace-navigates-back.html.
5:14 AM Changeset in webkit [86142] by Csaba Osztrogonác
  • 1 edit
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed.

Move plugins/plugin-javascript-access-expected.txt from qt-linux platform
to qt, because it should be used by qt-4.8, qt-arm Linux platforms too.

  • platform/qt-linux/plugins: Removed.
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt: Removed.
  • platform/qt/plugins/plugin-javascript-access-expected.txt: Copied from LayoutTests/platform/qt-linux/plugins/plugin-javascript-access-expected.txt.
4:56 AM Changeset in webkit [86141] by Csaba Osztrogonác
  • 4 edits
    2 adds in trunk

[Qt] Add new qt-4.8 platform for layout testing
https://bugs.webkit.org/show_bug.cgi?id=60544

Reviewed by Kenneth Rohde Christiansen.

Tools:

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitdirs.pm:

LayoutTests:

  • platform/qt-4.8/Skipped: Added.
4:24 AM Changeset in webkit [86140] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtRawFont support should check based on feature, not version
https://bugs.webkit.org/show_bug.cgi?id=60513

Build fix - no tests added.

  • WebCore.pro:
1:59 AM Changeset in webkit [86139] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] eventSender.keyDown is unimplemented

  • platform/qt-wk2/Skipped: Add fast/forms/radio-group-keyboard-change-event.html.
1:49 AM Styling Form Controls edited by tkent@chromium.org
How to remove spin buttons (diff)
1:46 AM Changeset in webkit [86138] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/qt-mac/Skipped: Add plugins/embed-prefers-plugins-for-images.html.
1:34 AM Changeset in webkit [86137] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed fix.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

r86124 implemented unmarkText() and it fixed a test,
which doesn't need Qt specific expected failure anymore.

  • platform/qt/fast/events/ime-composition-events-001-expected.txt: Removed.
1:27 AM Changeset in webkit [86136] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Build fix: include ExceptionCode
https://bugs.webkit.org/show_bug.cgi?id=60538

  • bindings/js/JSDOMBinding.cpp:
1:19 AM Changeset in webkit [86135] by tonyg@chromium.org
  • 64 edits in trunk/Source

2011-05-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
https://bugs.webkit.org/show_bug.cgi?id=60388

These were all found using the include-what-you-use clang plugin.

  • css/CSSFontFaceSrcValue.h:
  • css/CSSImageGeneratorValue.h:
  • css/CSSParser.h:
  • css/CSSPrimitiveValueCache.cpp:
  • css/CSSPrimitiveValueCache.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/RGBColor.cpp:
  • css/RGBColor.h:
  • dom/EventTarget.h:
  • dom/ExceptionBase.cpp:
  • dom/ExceptionBase.h:
  • dom/MessagePort.cpp:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/SelectElement.cpp:
  • dom/SelectElement.h:
  • dom/TextEvent.cpp:
  • dom/TextEvent.h:
  • dom/Touch.cpp:
  • dom/Touch.h:
  • dom/TouchEvent.cpp:
  • dom/TouchEvent.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyBlockElementCommand.h:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/EditCommand.h:
  • editing/Editor.h:
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.h:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • html/HTMLSelectElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • loader/appcache/DOMApplicationCache.cpp:
  • page/EventSource.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/svg/RenderSVGInlineText.cpp:
  • svg/SVGMatrix.h:
  • websockets/WebSocket.cpp:
  • workers/AbstractWorker.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XPathExpression.cpp:

2011-05-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Fix some unnecessary includes in headers
https://bugs.webkit.org/show_bug.cgi?id=60388

  • WebProcess/FullScreen/WebFullScreenManager.cpp:
1:13 AM Changeset in webkit [86134] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-10 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking (video-controls-rendering.html)

  • platform/chromium/test_expectations.txt:
12:52 AM Changeset in webkit [86133] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-10 Adam Barth <abarth@webkit.org>

Attempt to fix the clang build.

  • src/WebDevToolsAgentImpl.cpp:
12:46 AM Changeset in webkit [86132] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

REGRESSION(r73886): Frequent crashes in replaceSelectionWithFragment
https://bugs.webkit.org/show_bug.cgi?id=60090

SpellChecker uses TextCheckerClient, which belongs Page object,
which is possibly destroyed during SpellChecker's lifetime.
This change added to a guard before using TextCheckerClient to
ensure it being live.

No new tests, this is a speculative fix for a real crash.

  • editing/Editor.cpp: (WebCore::Editor::Editor):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::canCheckAsynchronously): (WebCore::SpellChecker::requestCheckingFor):
  • editing/SpellChecker.h:

May 9, 2011:

10:41 PM Changeset in webkit [86131] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the LLVM Compiler build.

  • page/EventHandler.h:
10:23 PM Changeset in webkit [86130] by weinig@apple.com
  • 15 edits in trunk

Unreviewed, rolling out r86108.
http://trac.webkit.org/changeset/86108
https://bugs.webkit.org/show_bug.cgi?id=60533

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-05-09
Broke makefile based builds and Cairo (Requested by weinig on
#webkit).

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:

(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

9:48 PM Changeset in webkit [86129] by dcheng@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-05-09 Daniel Cheng <dcheng@chromium.org>

Fix the build.

Really add the file this time.

  • page/DragState.h: Added. (WebCore::DragState::DragState):
9:33 PM Changeset in webkit [86128] by dcheng@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-05-09 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Refactor RenderObject::draggableNode.
https://bugs.webkit.org/show_bug.cgi?id=60503

This patch lays the ground for refactoring the drag start logic. It moves draggableNode to
DragController to avoid the awkward plumbing of calling DragController from RenderObject and
also moves EventHandlerDragState out from EventHandler so it can be shared between
EventHandler and DragController where appropriate.

No new tests since there should be no behavior change.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::mayStartDragAtEventLocation):
  • page/DragController.h:
  • page/DragState.h: Added. (WebCore::DragState::DragState):
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
8:58 PM Writing Reftests edited by hayato@chromium.org
(diff)
8:24 PM Changeset in webkit [86127] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/page/animation/CompositeAnimation.cpp

Merge 85693
BUG=82096
Review URL: http://codereview.chromium.org/6994006

7:40 PM Changeset in webkit [86126] by hayato@chromium.org
  • 5 edits in trunk/Tools

2011-05-09 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

Skip reftests if pixel tests are disabled.

https://bugs.webkit.org/show_bug.cgi?id=59078

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
7:23 PM Changeset in webkit [86125] by mrobinson@webkit.org
  • 4 edits in trunk

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Update the results for a test after r86102. This test was susceptible to
scrollbar race conditions and r86102 changed timing slightly.

  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Fix a test after r86102. Scrollbars update asynchronously, so we
must check the adjustments after a short delay.

  • tests/testwebview.c: (quit_after_short_delay_cb): Add a short delay before checking adjustments. (test_webkit_web_view_grab_focus): Ditto.
7:11 PM Changeset in webkit [86124] by commit-queue@webkit.org
  • 8 edits in trunk

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

Unskipped passed test.

  • platform/qt/Skipped:

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::confirmComposition):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-09 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DumpRenderTreeQt needs an implementation of unmarkText
https://bugs.webkit.org/show_bug.cgi?id=60499

The implementation is similar to gtk.

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::unmarkText):
  • DumpRenderTree/qt/TextInputControllerQt.h:
7:05 PM Changeset in webkit [86123] by Lucas Forschler
  • 5 edits in tags/Safari-534.34.4/Source

Versioning to match updated WebBrowser.

7:01 PM Changeset in webkit [86122] by Lucas Forschler
  • 1 copy in tags/Safari-534.34.4

New tag.

6:55 PM Changeset in webkit [86121] by imasaki@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-09 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Add rebaseline images for video-controls-rendering.
https://bugs.webkit.org/show_bug.cgi?id=60517

Chromium bug is http://crbug.com/82033. These rebaselines are necessary
due to unrelated bug (http://crbug.com/74102). We are checking in bad
baselines for the time being so that we ensure no other problems occur.
This test will fail when above bug (http://crbug.com/74102) is fixed.
At that time, we will checkin correct baselines.

  • platform/chromium-gpu-linux/media/video-controls-rendering -expected.png: Added.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:52 PM Changeset in webkit [86120] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Enable casting between CSSPrimitiveValue and FontWeight enum
https://bugs.webkit.org/show_bug.cgi?id=60516

No new tests added as no functionality changed.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Implement cast from FontWeight to CSSPrimitiveValue. (WebCore::CSSPrimitiveValue::operator FontWeight): Implement cast from CSSPrimitiveValue to FontWeight
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use new cast to reduce code size. Flatten switch inside if.
6:50 PM Changeset in webkit [86119] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

[chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
https://bugs.webkit.org/show_bug.cgi?id=60520

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
6:38 PM Changeset in webkit [86118] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Fix build, for real.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment):
6:30 PM Changeset in webkit [86117] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r85984

6:28 PM Changeset in webkit [86116] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix..

Fix GTK+3.x build.

  • webkit/webkitwebview.cpp: (getHorizontalAdjustment): the adjustment is in adjustmentWatcher() now. (getVerticalAdjustment): ditto.
6:09 PM Changeset in webkit [86115] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-09 Simon Fraser <Simon Fraser>

Move IconURL.* into the dom grouping.

  • WebCore.xcodeproj/project.pbxproj:
6:01 PM Changeset in webkit [86114] by mrobinson@webkit.org
  • 4 edits
    1 add in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84979

5:59 PM Changeset in webkit [86113] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84123

5:58 PM Changeset in webkit [86112] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85221

5:57 PM Changeset in webkit [86111] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

Merging r85219

5:56 PM Changeset in webkit [86110] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r85390

5:25 PM Changeset in webkit [86109] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

2011-05-08 Jeremy Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=60449

  • fullscreen/full-screen-remove-sibling-expected.txt: Added.
  • fullscreen/full-screen-remove-sibling.html: Added.

2011-05-08 Jeremy Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Full-screen video disappears behind black screen with scrollbar, followed by crash at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=60449

Make RenderFullScreen a non-anonymous block, so that it does not get deleted when a parent attempts to
coalesce anonymous children.

Test: fullscreen/full-screen-remove-sibling.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
5:17 PM Changeset in webkit [86108] by levin@chromium.org
  • 15 edits in trunk

Switch TestWebKitAPI to GTest
https://bugs.webkit.org/show_bug.cgi?id=59561

Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-09
Reviewed by Sam Weinig.

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

4:50 PM Changeset in webkit [86107] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): (-[WebFullScreenController exitFullscreen]):

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
https://bugs.webkit.org/show_bug.cgi?id=60496

When animating into and out of full screen, order out and back in the original webView window,
disabling animations when necessary. The beganExitFullScreenAnimation method was targeting the wrong window,
as the webView is hosted in the full screen window when we ask for it's parent window.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
4:45 PM Changeset in webkit [86106] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-09 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

http://bugs.webkit.org/show_bug.cgi?id=60509
Wrong type used for return value from strlen

  • wtf/FastMalloc.cpp: (WTF::fastStrDup): Use size_t. Also don't bother checking for failure since fastMalloc won't return if it fails.
4:41 PM Changeset in webkit [86105] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Jeremy Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r84706): Crazy rendering of vimeo.com after exiting fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=60512

Initialize m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
4:37 PM Changeset in webkit [86104] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r86039): DragCaretController doesn't draw caret
https://bugs.webkit.org/show_bug.cgi?id=60505

Removed an early exit in setCaretPosition introduced by r86039.
Also replaced calls to containerNode by deprecatedNode since rendering code doesn't
support container node for rendering caret.

  • editing/FrameSelection.cpp: (WebCore::DragCaretController::setCaretPosition):
4:31 PM Changeset in webkit [86103] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

A WKView with plug-ins paints white when first moved into a window
https://bugs.webkit.org/show_bug.cgi?id=60511

Reviewed by Darin Adler.

The UI process’s wait for DidUpdateBackingStoreState would always time out because the Web process
was blocked on a synchronous message the UI process trying to get the connections for plug-ins in
the view. This is avoided by deferring the call to Page::setCanStartMedia().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize the new m_setCanStartMediaTimer.
(WebKit::WebPage::setCanStartMediaTimerFired): Added. Calls setCanStartMedia(true) when the timer
fires.
(WebKit::WebPage::setIsInWindow): When going out of a window, stop the timer. When going into a
window, start it.

  • WebProcess/WebPage/WebPage.h:
4:24 PM Changeset in webkit [86102] by mrobinson@webkit.org
  • 14 edits
    2 adds in trunk/Source

2011-04-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
https://bugs.webkit.org/show_bug.cgi?id=59821

Completely remove the ability for WebKit to set GtkAdjustments on ScrollViews
and, consequently, Scrollbars. Handling adjustment updates can now be managed
in WebKit.

No new tests. This is covered by existing Scrollbar tests.

  • platform/ScrollView.cpp: platformInit and platformDestroy can now be shared between ScrollView.cpp and ScrollViewGtk.cpp.
  • platform/ScrollView.h: Remove unused methods.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::create): No longer need to pass in the adjustment. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): Update the comments here.
  • platform/gtk/MainFrameScrollbarGtk.h: Lots of code removal.
  • platform/gtk/ScrollViewGtk.cpp: Ditto. (WebCore::ScrollView::createScrollbar): Ditto. (WebCore::ScrollView::setScrollbarModes): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: This file needs the GRefPtrGtk.h include now that it doesn't receive it transitively.

2011-04-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Untangle GtkAdjustments from WebCore
https://bugs.webkit.org/show_bug.cgi?id=59821

Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
them to WebCore to manage. This simplifies the code quite a bit and should be less
crash prone in the future.

  • GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
  • WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member. (WebKit::ChromeClient::ChromeClient) Initialize the new member. (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments. (WebKit::ChromeClient::contentsSizeChanged): Ditto. (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there is no main frame, so do an early return in that case.
  • WebCoreSupport/ChromeClientGtk.h: Add the new member. (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into WebCore. (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::postCommitFrameViewSetup):
  • WebCoreSupport/GtkAdjustmentWatcher.cpp: Added. (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher): (WebKit::updateAdjustmentFromScrollbar): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars): (WebKit::updateAdjustmentCallback): (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): (WebKit::adjustmentValueChangedCallback): (WebKit::setAdjustment): (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment): (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment): (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
  • WebCoreSupport/GtkAdjustmentWatcher.h: Added. (WebKit::GtkAdjustmentWatcher::horizontalAdjustment): (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
  • webkit/webkitwebview.cpp: (setHorizontalAdjustment): (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher. (getHorizontalAdjustment): Ditto. (getVerticalAdjustment): Ditto. (webkit_web_view_size_allocate): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Ditto. (webkit_web_view_init): Ditto.
  • webkit/webkitwebviewprivate.h: Ditto.
4:08 PM Changeset in webkit [86101] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when sending a sync message to a crashed web process
https://bugs.webkit.org/show_bug.cgi?id=60514
<rdar://problem/9281270>

Change WebProcessProxy::sendSync to return false if there's no connection.

Audit all WebProcessProxy::sendSync call sites to initialize reply parameters.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): (WebKit::WebPageProxy::getSelectedText): (WebKit::WebPageProxy::gestureWillBegin):
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::sendSync):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::insertText): (WebKit::WebPageProxy::getMarkedRange): (WebKit::WebPageProxy::getSelectedRange): (WebKit::WebPageProxy::characterIndexForPoint): (WebKit::WebPageProxy::executeKeypressCommands): (WebKit::WebPageProxy::writeSelectionToPasteboard): (WebKit::WebPageProxy::readSelectionFromPasteboard):
4:05 PM Changeset in webkit [86100] by abarth@webkit.org
  • 9 edits
    5 adds in trunk

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

Test that the function constructor is properly blocked.

  • http/tests/security/contentSecurityPolicy/function-constructor-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/function-constructor-blocked.html: Added.
  • platform/chromium/test_expectations.txt:

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

When eval is disabled, we need to block the use of the function
constructor. However, the WebCore JSC bindings call the function
constructor directly to create inline event listeners. To support that
use, this patch adds an entrypoint that bypasses the check for whether
eval is enabled.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h:

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block Function constructor
https://bugs.webkit.org/show_bug.cgi?id=60240

Tests: http/tests/security/contentSecurityPolicy/function-constructor-allowed.html

http/tests/security/contentSecurityPolicy/function-constructor-blocked.html

  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
    • Update call site to the new entrypoint.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::prepareListenerObject):
    • Add some comments about the rediculousness of this implementation.
4:02 PM Changeset in webkit [86099] by crogers@google.com
  • 4 edits
    1 add in trunk/Source/WebCore

2011-05-09 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RAII-style DenormalDisabler class to disable denormals which hurt audio performance
https://bugs.webkit.org/show_bug.cgi?id=60396

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DenormalDisabler.h: Added. (WebCore::DenormalDisabler::DenormalDisabler): (WebCore::DenormalDisabler::~DenormalDisabler): (WebCore::DenormalDisabler::getCSR): (WebCore::DenormalDisabler::setCSR):
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::provideInput):
3:53 PM Changeset in webkit [86098] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Style cleanups in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=60504

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): Use m_ for member variables, and

use class initializer list.

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::marginWidthForChild): Pull out common code used in calc*PrefWidths
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo): Rewrite uses of FlexBoxIterator into for statements

rather than while loops.

(WebCore::RenderFlexibleBox::layoutHorizontalBox): ditto
(WebCore::RenderFlexibleBox::layoutVerticalBox): ditto
(WebCore::RenderFlexibleBox::applyLineClamp):
(WebCore::RenderFlexibleBox::allowedChildFlex): Rename variables w/h to width/height.

3:49 PM Changeset in webkit [86097] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Create a plug-in's MIME types preferences plist if it doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=57204
<rdar://problem/9195048>

Spawn a plug-in process and let it create the plist. For now, we'll do this on the
main thread since it's a rare one-time computation and we have an API function,
WKFrameCanShowMIMEType, which would have to block anyway.

  • PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain): If -createPluginMIMETypesPreferences is one of the command line argument keys, the plug-in path will be the argument value. Call NetscapePluginModule::createPluginMIMETypesPreferences to create the preferences file and then exit.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::contentsOfPropertyListAtURL): Move code to read a property list out into a helper function.

(WebKit::getMIMETypesFromPluginBundle):
If there's no property list file, try to create one.

(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):
Load the plug-in, find the BP_CreatePluginMIMETypesPreferences and call it.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::createPropertyListFile): Spawn a plug-in process and pass the -createPluginMIMETypesPreferences flag to it and then wait for it to exit.
3:47 PM Changeset in webkit [86096] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-09 Robert Hogan <robert@webkit.org>

Unreviewed, update test expectations.

Update platform-specific results after r86086

The unix test NPAPI plugin now supports the png mime type.

https://bugs.webkit.org/show_bug.cgi?id=57137

  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt-linux/plugins/plugin-javascript-access-expected.txt:
3:36 PM Changeset in webkit [86095] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove unflaky media-related tests from test expectation.
https://bugs.webkit.org/show_bug.cgi?id=60500

Chromium bug is http://crbug.com/81660.

  • platform/chromium/test_expectations.txt:
3:29 PM Changeset in webkit [86094] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebKit/chromium

2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86091.
http://trac.webkit.org/changeset/86091
https://bugs.webkit.org/show_bug.cgi?id=60510

Broke Chromium win release build. (Requested by dave_levin on
#webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
3:27 PM Changeset in webkit [86093] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-09 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Abstract line deletion code into a function
https://bugs.webkit.org/show_bug.cgi?id=60501

No change in behavior, thus no testing.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine):
3:14 PM Changeset in webkit [86092] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Cleared some stray executable bits on source files.

  • bindings/js/WorkerScriptDebugServer.cpp: Removed property svn:executable.
  • bindings/js/WorkerScriptDebugServer.h: Removed property svn:executable.
3:04 PM Changeset in webkit [86091] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-09 Tao Bai <michaelbai@chromium.org>

Reviewed by David Levin.

Handle the touch icon.
https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added a parameter to favIconURL() to specify the type of icon need to
return.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
2:56 PM Changeset in webkit [86090] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] DRT eventSender.addTouchPoint method is not setting the start position
https://bugs.webkit.org/show_bug.cgi?id=60487

When adding a new touch point, the start position of this point needs to be set.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint):
2:47 PM Changeset in webkit [86089] by andersca@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move EnvironmentVariables out into its own .cpp file
https://bugs.webkit.org/show_bug.cgi?id=60507

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp: Added. (WebKit::EnvironmentVariables::EnvironmentVariables): (WebKit::EnvironmentVariables::~EnvironmentVariables): (WebKit::EnvironmentVariables::set): (WebKit::EnvironmentVariables::get): (WebKit::EnvironmentVariables::appendValue): (WebKit::EnvironmentVariables::valueIfVariableHasName): (WebKit::EnvironmentVariables::createStringForVariable): (WebKit::EnvironmentVariables::copyEnvironmentVariables):
  • UIProcess/Launcher/mac/EnvironmentVariables.h: Added. (WebKit::EnvironmentVariables::environmentPointer):
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
2:42 PM Changeset in webkit [86088] by arv@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

  • fast/forms/radio-group-keyboard-change-event-expected.txt: Added.
  • fast/forms/radio-group-keyboard-change-event.html: Added.

2011-05-09 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

radiogroup: onchange not detected when triggered by keyboard
https://bugs.webkit.org/show_bug.cgi?id=32013

Test: fast/forms/radio-group-keyboard-change-event.html

  • html/RadioInputType.cpp: (WebCore::RadioInputType::handleKeydownEvent): Ensure that we do not check the radio input before we simulate the click

event. The simulated click event will check it for us but more importantly it will fire the "change" event as
expected.

2:20 PM Changeset in webkit [86087] by abarth@webkit.org
  • 2 edits
    2 adds in trunk

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

2:09 PM Changeset in webkit [86086] by robert@webkit.org
  • 5 edits in trunk

2011-05-09 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-09 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=57137

Unskip plugins/embed-prefers-plugins-for-images.html

Add image/png mime-type to test netscape plugin on Unix.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
1:22 PM Changeset in webkit [86085] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove canvas usage of roundToDevicePixels
https://bugs.webkit.org/show_bug.cgi?id=60331

No new tests. This could only affect canvases at non-integral scale factors. Our tests only run in 1.0x.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
1:20 PM Changeset in webkit [86084] by xan@webkit.org
  • 2 edits in trunk

2011-05-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix logic in GCC version detection, it was reversed.

  • configure.ac:
12:57 PM Changeset in webkit [86083] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-09 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • Source/WebKit.pri:

2011-05-09 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix the build on Embedded Linux.
https://bugs.webkit.org/show_bug.cgi?id=60347

qpa is the name for lighthouse but the old name for Qt for Embedded Linux should
still be used in order to build properly.

  • WebCore.pri:
12:49 PM Changeset in webkit [86082] by chang.shu@nokia.com
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <cshu@webkit.org>

Unreviewed.

Expected result for editing/inserting/insert-bg-font.html can be shared
https://bugs.webkit.org/show_bug.cgi?id=60498

  • editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
  • platform/gtk/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-bg-font-expected.txt: Removed.
  • platform/qt/Skipped:
12:40 PM Changeset in webkit [86081] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Simple small-caps text is displayed in uniform size.
https://bugs.webkit.org/show_bug.cgi?id=60492

Covered by existing tests.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): In the FontPlatformData constructor used by SimpleFontData::scaledFontData(), pass the pixel size to both QFont and QRawFont to make small caps and emphasis marks have the correct size when rendered through the fast font path.
12:32 PM Changeset in webkit [86080] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-09 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make DumpRenderTree build in components for linux
https://bugs.webkit.org/show_bug.cgi?id=60491

  • WebKit.gyp: move some code that was in a Windows-only block to be used on all platforms.
12:32 PM Changeset in webkit [86079] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86075.
http://trac.webkit.org/changeset/86075
https://bugs.webkit.org/show_bug.cgi?id=60495

broke windows tests (Requested by jessieberlin on #webkit).

  • win/lib/WebKitSystemInterface.lib:
12:22 PM Changeset in webkit [86078] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-09 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Remove unused FontPlatformData functions.
https://bugs.webkit.org/show_bug.cgi?id=60485

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::bold): Removed. (WebCore::FontPlatformData::family): Removed. (WebCore::FontPlatformData::italic): Removed. (WebCore::FontPlatformData::smallCaps): Removed.
12:20 PM Changeset in webkit [86077] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Always set the font rendering mode based on preference values

WebPage::platformInitialize and WebPage::platformPreferencesDidChange were fighting over the
font rendering mode. The platformInitialize code predates preference-based font rendering
mode support, and is now redundant and incorrect.

Fixes <http://webkit.org/b/60494> WebKit2 uses GDI text instead of CG text when
FontSmoothing preference is set to kWKFontSmoothingLevelNoSubpixelAntiAliasing in a .plist
on disk

Reviewed by Sam Weinig.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Removed code to set the font rendering mode.
platformPreferencesDidChange will take care of this for us.

12:07 PM Changeset in webkit [86076] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-09 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Clean up NetscapePluginModule::getPluginInfo
https://bugs.webkit.org/show_bug.cgi?id=60486

Make all 'get' functions take a PluginInfoStore::Plugin reference, since getPluginInfoFromPropertyLists
is going to need it to know the path and plug-in architecture.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::getPluginInfoFromCarbonResources): (WebKit::NetscapePluginModule::getPluginInfo):
12:04 PM Changeset in webkit [86075] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Take 2 on updating the WKSI libraries.

  • win/lib/WebKitSystemInterface.lib:
11:58 AM Changeset in webkit [86074] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9005982> REGRESSION (r85780): Flash of white when a WKView with composited content moves on-screen
https://bugs.webkit.org/show_bug.cgi?id=60488

Reviewed by Darin Adler.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Update m_compositingAccordingToProxyMessages,
since the DidUpdateBackingStoreState message also changes the compositing state in the proxy.

11:54 AM Changeset in webkit [86073] by inferno@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

2011-05-09 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines for r86065.

  • platform/chromium-linux/platform/gtk: Added.
  • platform/chromium-linux/platform/gtk/fonts: Added.
  • platform/chromium-linux/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac-leopard/platform: Added.
  • platform/chromium-mac-leopard/platform/gtk: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts: Added.
  • platform/chromium-mac-leopard/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk: Added.
  • platform/chromium-mac/platform/gtk/fonts: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-mac/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium-win/platform/gtk: Added.
  • platform/chromium-win/platform/gtk/fonts: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
  • platform/chromium-win/platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [86072] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Add invalid file handle check.

https://bugs.webkit.org/show_bug.cgi?id=60483

11:23 AM Changeset in webkit [86071] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Update the popup menu code to grab the native control and initialize the
event handler properly.

https://bugs.webkit.org/show_bug.cgi?id=60482

11:20 AM Changeset in webkit [86070] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Make sure other controls adjust the rect to handle transforms, and turn off the
adjustment in 2.9.2+ where it is handled internally by wx.

Also add a couple drawing and focus handling fixes for text fields and menulist controls.

https://bugs.webkit.org/show_bug.cgi?id=60481

11:18 AM Changeset in webkit [86069] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Style fix: Function names must begin with lowercase letter and should not use "get".
https://bugs.webkit.org/show_bug.cgi?id=60475

  • dom/Document.cpp: (WebCore::Document::webkitVisibilityState):
  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString): Renamed.
  • page/PageVisibilityState.h:
11:14 AM Changeset in webkit [86068] by kevino@webkit.org
  • 3 edits in trunk/Source/WebKit/wx

Reviewed by Kevin Ollivier.

Create empty event handler to avoid new mouse capture assert added in wx 2.9 on wxMSW.

https://bugs.webkit.org/show_bug.cgi?id=60480

11:13 AM Changeset in webkit [86067] by abarth@webkit.org
  • 40 edits in trunk/Source

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60461

Fix many, many PassOwnPtr nits.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::detach):
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacks::didOpenFileSystem): (WebCore::ResolveURICallbacks::didOpenFileSystem):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayer::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::createRenderSurface):
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create):
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::TrackerRemoveOpenDatabaseTask::create):
  • storage/chromium/SQLTransactionClientChromium.cpp: (WebCore::NotifyDatabaseChangedTask::create):

2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make Chromium build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60461

Fixed many, many PassOwnPtr nits.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
  • src/IDBDatabaseBackendProxy.cpp: (WebKit::IDBDatabaseBackendProxy::createObjectStore): (WebKit::IDBDatabaseBackendProxy::transaction):
  • src/IDBObjectStoreBackendProxy.cpp: (WebKit::IDBObjectStoreBackendProxy::createIndex): (WebKit::IDBObjectStoreBackendProxy::index):
  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::objectStore):
  • src/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::create): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::connect):
  • src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::create):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::DebuggerTask::DebuggerTask): (WebKit::DebuggerTask::~DebuggerTask): (WebKit::DebuggerTask::run): (WebKit::WebDevToolsAgent::interruptAndDispatch):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
  • src/WebIDBCallbacksImpl.cpp: (WebKit::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::deleteFunction):
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::open):
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::deleteFunction): (WebKit::WebIDBObjectStoreImpl::clear): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::setCallbacks):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDevToolsAgentClient):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContext):
  • src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread): (WebKit::WorkerFileWriterCallbacksBridge::didWrite): (WebKit::WorkerFileWriterCallbacksBridge::didFail): (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
11:04 AM Changeset in webkit [86066] by chang.shu@nokia.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-09 Chang Shu <cshu@webkit.org>

Unreviewed.

[Qt] editing/inserting/5803706-1.html has the incorrect expected result
https://bugs.webkit.org/show_bug.cgi?id=60479

  • platform/qt/editing/inserting/5803706-1-expected.txt: Removed.
10:52 AM WikiStart edited by Ademar Reis
(diff)
10:52 AM Changeset in webkit [86065] by mrobinson@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-09 Martin Robinson <mrobinson@igalia.com>

Add a pixel result for platform/gtk/fonts/fontconfig-synthetic-bold.html.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.png: Added.
10:51 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:47 AM Changeset in webkit [86064] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Soup] Clean up error handling in ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=60436

Instead of repeating the ResourceError creation twice, abstract
it into a helper method.

No new tests. This is a code cleanup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::soupErrorShouldCauseLoadFailure): Added. (WebCore::convertSoupErrorToResourceError): Added. (WebCore::sendRequestCallback): Use the new helpers. (WebCore::readCallback): Ditto.
10:32 AM Changeset in webkit [86063] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-09 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Pull jsonresults_unittest test cases out into separate test methods.
https://bugs.webkit.org/show_bug.cgi?id=60418

  • TestResultServer/model/jsonresults_unittest.py:
10:29 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:19 AM Changeset in webkit [86062] by eric@webkit.org
  • 2 edits
    1 add in trunk/Websites/webkit.org

2011-05-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add guidelines for feature addition to webkit.org (per disccusion at contributor meeting)
https://bugs.webkit.org/show_bug.cgi?id=59672

  • coding/adding-features.html: Added.
  • nav.inc:
10:13 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
9:32 AM Changeset in webkit [86061] by inferno@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Add a crash test for r85964.
https://bugs.webkit.org/show_bug.cgi?id=59473

  • fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
  • fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.
9:29 AM Changeset in webkit [86060] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r85869): Restore dirty line logic in RenderInline::destroy.
https://bugs.webkit.org/show_bug.cgi?id=60448

Test: fast/inline/inline-destroy-dirty-lines-crash.html

  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):

2011-05-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not when failing to dirty lines while removing
a inline.
https://bugs.webkit.org/show_bug.cgi?id=60448

  • fast/inline/inline-destroy-dirty-lines-crash-expected.txt: Added.
  • fast/inline/inline-destroy-dirty-lines-crash.html: Added.
9:15 AM Changeset in webkit [86059] by alex
  • 2 edits in trunk/LayoutTests

2011-05-09 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip 2 more flaky svg tests failing by one pixel in
32-bits Debug, see bug 39022.

  • platform/gtk/Skipped:
8:38 AM Changeset in webkit [86058] by alex
  • 2 edits in trunk/Source/WebCore

2011-05-09 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] WidgetGtk setFocus can not access directly the widget in WK2
https://bugs.webkit.org/show_bug.cgi?id=60016

Added code to check the situation where we do not have direct
access to the widget. We use the page to grab the focus which
would send a request to the UIProcess in WK2.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
8:27 AM BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
8:23 AM Changeset in webkit [86057] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <andreas.kling@nokia.com>

Unreviewed. Re-skip two failing inspector tests on Qt.

They still fail in the bot's environment for whatever reason.

  • platform/qt/Skipped:
8:00 AM Changeset in webkit [86056] by Adam Roben
  • 3 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Automatically touch WebKit.idl whenever any other WebKit1 IDL file changes

Fixes <http://webkit.org/b/60468> WebKit.idl needs to be manually touched whenever any other
WebKit1 IDL file changes to avoid build errors

Reviewed by Tim Hatcher.

Updated for script rename.

  • JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Renamed

from react-to-vsprops-changes.py.
(top level): Moved a constant here from main.
(main): Moved most code from here to react_to_vsprops_changes. Added a call to the new
react_to_webkit1_interface_changes function.
(react_to_vsprops_changes): Moved code here from main. Updated to use the
TOP_LEVEL_DIRECTORY global. Moved some code from here to mtime_of_newest_file_matching_globa
and touch_if_older_than.
(react_to_webkit1_interface_changes): Added. Touches WebKit.idl if any other WebKit1 IDL
file has changed.
(mtime_of_newest_file_matching_glob): Added. Code came from main.
(touch_if_older_than): Added. Code came from main.

7:58 AM Changeset in webkit [86055] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
https://bugs.webkit.org/show_bug.cgi?id=60387

Update the expected results for the argument types after the lastest updates
in the getUserMedia specification. The test has been disabled temporarily
and will be re-enabled by 60177 since some exceptions are risen after parsing
the provided options.

  • fast/dom/MediaStream/argument-types-expected.txt:
  • fast/dom/MediaStream/script-tests/argument-types.js: (ObjectThrowingException.prototype.toString):
  • platform/chromium/test_expectations.txt:

2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add exception raising to the getUserMedia method.
https://bugs.webkit.org/show_bug.cgi?id=60387

Perform the required changes to support rising exceptions in the
navigator.getUserMedia method. This is required by the latest changes in the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
  • bindings/v8/custom/V8NavigatorCustom.cpp: (WebCore::V8Navigator::webkitGetUserMediaCallback):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/Navigator.h:
  • page/Navigator.idl:
7:13 AM Changeset in webkit [86054] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed Qt 4.8 fix.

  • WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
7:06 AM Changeset in webkit [86053] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-09 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Minor skiplist cleanup.

Unskip two inspector tests that aren't failing.
Added explanation for why http/tests/misc/redirect-to-external-url.html is skipped.

  • platform/qt/Skipped:
7:06 AM Changeset in webkit [86052] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows project file fix after r86047

  • WebCore.vcproj/WebCore.vcproj: Added missing closing tags.
6:51 AM Changeset in webkit [86051] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-06 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
https://bugs.webkit.org/show_bug.cgi?id=60417

Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
instead of the PlatformCALayer everywhere.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
6:41 AM Changeset in webkit [86050] by rwlbuis@webkit.org
  • 78 edits in trunk/Source/WebCore

2011-05-09 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
https://bugs.webkit.org/show_bug.cgi?id=22576

Add tag name ASSERTs in SVG Element constructors.

No new tests, since no change in behaviour.

4:22 AM Changeset in webkit [86049] by mahesh.kulkarni@nokia.com
  • 4 edits in trunk

2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60458

Update all pages with Mock position/error/permission.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationError): (LayoutTestController::setMockGeolocationPosition):

2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] fix fast/dom/Geolocation/window-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60458

Unskipping fast/dom/Geolocation/window-close-crash.html.

  • platform/qt/Skipped:
4:17 AM Changeset in webkit [86048] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] one skipped 2d-transforms layout test passes on Qt Linux - skip list to be updated
https://bugs.webkit.org/show_bug.cgi?id=60399

  • platform/qt/Skipped:
4:00 AM Changeset in webkit [86047] by commit-queue@webkit.org
  • 33 edits
    13 adds in trunk

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • fast/events/page-visibility-iframe-delete-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-delete-test.html: Added.
  • fast/events/page-visibility-iframe-move-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-move-test.html: Added.
  • fast/events/page-visibility-iframe-propagation-test-expected.txt: Added.
  • fast/events/page-visibility-iframe-propagation-test.html: Added.
  • fast/events/page-visibility-transition-test-expected.txt: Added.
  • fast/events/page-visibility-transition-test.html: Added.
  • fast/events/resources/page-visibility-iframe-delete-test-frame.html: Added.
  • fast/events/resources/page-visibility-iframe-move-new-page.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

Tests: fast/events/page-visibility-iframe-delete-test.html

fast/events/page-visibility-iframe-move-test.html
fast/events/page-visibility-iframe-propagation-test.html
fast/events/page-visibility-transition-test.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::visibilityState): (WebCore::Document::webkitVisibilityState): (WebCore::Document::webkitIsVisible): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:
  • page/Frame.cpp: (WebCore::Frame::dispatchVisibilityStateChangeEvent):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setVisibilityState): (WebCore::Page::visibilityState):
  • page/Page.h:
  • page/PageVisibilityState.cpp: Added. (WebCore::GetPageVisibilityStateString):
  • page/PageVisibilityState.h: Added.

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • WebKit.gyp:
  • public/WebPageVisibilityState.h: Added.
  • public/WebView.h: (WebKit::WebView::setVisibilityState):
  • public/WebViewClient.h: (WebKit::WebViewClient::visibilityState):
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setVisibilityState):
  • src/WebViewImpl.h:

2011-05-09 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Implement Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=54181

  • DumpRenderTree/LayoutTestController.cpp: (setPageVisibilityCallback): (resetPageVisibilityCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::setPageVisibility): (LayoutTestController::resetPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::resetPageVisibility): (LayoutTestController::setPageVisibility):
  • DumpRenderTree/chromium/LayoutTestController.h:
3:55 AM Changeset in webkit [86046] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-09 Venkat Penukonda <venkat.2.penukonda@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt]6 of the skipped canvas layout tests pass on Qt Linux
https://bugs.webkit.org/show_bug.cgi?id=60382

  • platform/qt/Skipped: Removed passing canvas tests
3:48 AM Changeset in webkit [86045] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

Build fix for WebKit 2 on Qt

Reviewed by Andreas Kling.

Qt treats warnings as errors so it does not build with unused variables. This patch removed two unused variable in WebKit 2.

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::createTiles):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

2:19 AM Changeset in webkit [86044] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement expanding CSS border properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60456

No new tests added as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Create CSS border expanding property handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property handlers that are no longer needed.
Note: See TracTimeline for information about the timeline view.