Timeline


and

05/15/11:

23:52 Changeset [86533] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachCurrentPage): (QGraphicsWebView::setPage):
  • Api/qwebpage.cpp: (QWebPage::setView):
23:46 Changeset [86532] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::GraphicsLayerQt): (WebCore::GraphicsLayer::create):
23:41 Changeset [86531] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/text/qt/TextCodecQt.cpp: (WebCore::newTextCodecQt):
23:36 Changeset [86530] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::release): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::start):
23:30 Changeset [86529] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doEnd):
23:21 Changeset [86528] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-15 Adam Barth <abarth@webkit.org>

Enable strict PassOwnPtr on Qt. (Build fixes to follow.)

  • wtf/PassOwnPtr.h:
23:15 Changeset [86527] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-15 MORITA Hajime <morrita@google.com>

Unreviewed an expectation update.

  • platform/gtk/fast/html/details-add-child-2-expected.txt:
22:59 Changeset [86526] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

Add a test that ensures <output>, <meter> and <progress> are not focused.
Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

  • fast/forms/focus-with-display-block-expected.txt: Added.
  • fast/forms/focus-with-display-block.html: Added.
  • platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

HTMLFormControlElement::isFocusable() returns true when the element is
visible as a block element. However, for output, meter, and progress
elements, the function should not return true unless they have
tabindex attributes. Override supportsFocus() of these elements to
apply the result of Node::supportsFocus() because it takes care of
whether the element has tabindex or not.

Test: fast/forms/focus-with-display-block.html

  • html/HTMLFormControlElement.h: Made supportsFocus() protected.
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::supportsFocus): Added.
  • html/HTMLMeterElement.h:
  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::supportsFocus): Added.
  • html/HTMLOutputElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::supportsFocus): Added.
  • html/HTMLProgressElement.h:
22:44 Changeset [86525] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

22:31 Changeset [86524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-15 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
https://bugs.webkit.org/show_bug.cgi?id=60864

Implemented reuse of BackingStore's in
DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
matches the size of the existing BackingStore.
Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
These changes reduces memory usage up to 10MB on memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
22:10 Changeset [86523] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason


(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))


I'm basically rolling out http://trac.webkit.org/changeset/49786 because

(a) it created this performance problem


and


(b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
was committed in http://trac.webkit.org/changeset/53439.


Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't create a new window every time we destroy a frame.
20:29 Changeset [86522] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Pass the window NPObject identifier in the plug-in creation parameters
https://bugs.webkit.org/show_bug.cgi?id=60865

This avoids a synchronous call when the plug-in wants to get the NPObject that
corresponds to the window.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): Change this to take the PluginCreationParameters. Initialize the window NPObject.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Just return the window NPObject; it's already been initialized.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Add the window NPObject ID.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin): Pass the creation parameters to PluginControllerProxy::initialize.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Initialize the window NPObject ID.
  • WebProcess/Plugins/PluginProxy.messages.in: Remove the GetWindowScriptNPObject message.
19:55 Changeset [86521] by morrita@google.com
  • 15 edits
    2 copies
    12 adds in trunk

2011-05-12 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

  • fast/html/details-add-details-child-1.html: Added.
  • fast/html/details-add-details-child-2.html: Added.
  • fast/html/details-nested-1.html: Added.
  • fast/html/details-nested-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.txt: Added.
  • platform/mac/fast/html/details-nested-2-expected.png: Added.
  • platform/mac/fast/html/details-nested-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:

2011-05-12 MORITA Hajime <morrita@google.com>

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

Introduced ShadowContentSelector to collect and forward content
children for each ShadowContentElement. ShadowRoot collects child
nodes of its host (we call these children "content children"), and
the descendant ShadowContentElement pulls that these content
children and put it under its child during
ShadowContentElement::attach().

Content children no longer create its renderer during its normal
attach() phase (called "light" phase). And they create it during
attach() as a content children instead (called "forwarded phase").
These phases are detected by NodeRendererFactory and represented
as NodeRendererFactory::AttachPhase value AttachContentLight and
AttachContentForwarded.

Tests: fast/html/details-add-details-child-1.html

fast/html/details-add-details-child-2.html
fast/html/details-nested-1.html
fast/html/details-nested-2.html

  • dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/ShadowRoot.cpp: (WebCore::forceReattach): (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance): (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor): (WebCore::ShadowContentElement::attach): (WebCore::ShadowRoot::recalcStyle): (WebCore::ShadowRoot::activeContentContainer): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::attach):
  • dom/ShadowRoot.h:
  • html/shadow/ShadowContentElement.h: (WebCore::ShadowContentElement::rendererIsNeeded):
  • rendering/RenderDetails.cpp:
  • rendering/RenderDetails.h:
19:46 Changeset [86520] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-05-13 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
https://bugs.webkit.org/show_bug.cgi?id=57088

Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::resolveTextCheckingTypeMask):
  • editing/Editor.h:
  • platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel
18:44 Changeset [86519] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-15 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.
18:35 Changeset [86518] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed. Remove expectation of gc-shadow.html flakiness.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [86517] by dominicc@chromium.org
  • 2 edits in trunk/Tools

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
17:53 Changeset [86516] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Pass the document URL and toplevel document URL when creating a plug-in
https://bugs.webkit.org/show_bug.cgi?id=60863

This is the first of a series of patches intended to reduce the IPC traffic
during plug-in instantiation.

  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Parameters::encode): Encode the URLs.

(WebKit::Plugin::Parameters::decode):
Decode the URLs.

  • WebProcess/Plugins/Plugin.h: Add the document and toplevel document URLs.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Initialize the document and toplevel document URLs.
16:54 Changeset [86515] by dbates@webkit.org
  • 6 edits in trunk/Tools

2011-05-15 Daniel Bates <dbates@webkit.org>

Reviewed by Chris Jerdonek.

svn-apply can't handle Git diff that only changes executable bit
https://bugs.webkit.org/show_bug.cgi?id=60848

Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
that only has an executable bit change.

  • Scripts/VCSUtils.pm:
    • Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().

(parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.

  • Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
  • Scripts/svn-unapply: (patch): Ditto.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated expected results for test cases to account for numTextChunks.
    • Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
    • Added test case "Git: file that only has an executable bit change".
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
    • Updated expected results for test cases to account for numTextChunks.
16:20 Changeset [86514] by rwlbuis@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-15 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
https://bugs.webkit.org/show_bug.cgi?id=16614

Include testcase from the bug to prevent future regression (right now we pass both full testcase
and this reduction).

  • platform/mac/svg/custom/small-rect-scale-expected.png: Added.
  • platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
  • svg/custom/small-rect-scale.svg: Added.
16:02 Changeset [86513] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix windows build.

  • TestWebKitAPI/win/main.cpp:

(main):

15:49 Changeset [86512] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r86509.

  • platform/qt/Skipped:
15:41 Changeset [86511] by weinig@apple.com
  • 6 edits in trunk/Tools

2011-05-15 Sam Weinig <sam@webkit.org>

Reviewed by David Levin.

Make API tester more gtest friendly
https://bugs.webkit.org/show_bug.cgi?id=60859

  • Scripts/run-api-tests: Numerous changes:
  • Remove logic to run tests one at a time.
  • Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us.
  • Forward stdout from the test tool to stdout, even in non-verbose runs.
  • Run test tool from the current working directory instead of the root webkit directory.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources.
  • TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run):
  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point.
15:31 Changeset [86510] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/JSFunction.cpp: Made the host function stub cache weak --

otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

11:43 Changeset [86509] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just skipping a test.

  • platform/qt/Skipped: inspector/console/console-long-eval-crash.html
10:34 Changeset [86508] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Unreviewed, just skipping a test.

New test fails on some of the SnowLeopard bots.

  • platform/mac-snowleopard/Skipped:
09:57 Changeset [86507] by loislo@chromium.org
  • 10 edits
    2 adds in trunk

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
09:18 Changeset [86506] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Test: http/tests/media/video-cross-site.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction

to prevent cross-domain references from being followed.

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Add test for cross-domain QuickTime reference movie and test.

  • http/tests/media/resources/cross-site-reference.mov: Added.
  • http/tests/media/video-cross-site-expected.txt: Added.
  • http/tests/media/video-cross-site.html: Added.
  • platform/chromium/test_expectations.txt: Skipped, QuickTime reference movies not supported.
  • platform/gtk/Skipped: Ditto.
07:07 Changeset [86505] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
06:49 Changeset [86504] by robert@webkit.org
  • 9 edits
    1 add in trunk

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
04:40 Changeset [86503] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-15 Arno Renevier <arno@renevier.net>

Reviewed by Darin Adler.

remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=60775

No new tests. This change only impacts compilation.

  • html/HTMLFrameElementBase.cpp:

05/14/11:

23:41 Changeset [86502] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Fix strokeArc and fillRoundedRect drawing, and add clipPath support.

https://bugs.webkit.org/show_bug.cgi?id=60847

22:39 Changeset [86501] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

2011-05-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

HTTP video-on-demand streams frequently have live stream UI
https://bugs.webkit.org/show_bug.cgi?id=60849
<rdar://problem/9440502>

No new tests, we don't currently have tests for http live streams. Changes verified manually.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Reset the media controls so

a duration change which identifies a format will be picked up.

(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): New, reset media controls

so they can be reconfigured for the media file characteristics.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::characteristicChanged): New, pass through to the element.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerCharacteristicChanged):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setHasVideo): Call characteristicChanged when

setting changes.

(WebCore::MediaPlayerPrivateAVFoundation::setHasAudio): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::setHasClosedCaptions): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Move the duration

change notification logic to invalidateCachedDuration.

(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration): New, invalidate

the cached duration and notify the element when it changes.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Call invalidateCachedDuration

for the DurationChanged notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Define DurationChanged.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't check asset or

item duration until they have been loaded.

(WebCore::itemKVOProperties): Listen for duration change.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with

duration change notification.

18:51 Changeset [86500] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when trying to parse an invalid font family
value of 'inherit' or 'initial' in a font face rule.
https://bugs.webkit.org/show_bug.cgi?id=60837

  • fast/css/invalid-font-family-in-font-face-crash-expected.txt: Added.
  • fast/css/invalid-font-family-in-font-face-crash.html: Added.

2011-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

As per spec, only allow one font family name in a font face rule.
Other things like initial value, inherited value or multiple names
are discarded.
https://bugs.webkit.org/show_bug.cgi?id=60837

Test: fast/css/invalid-font-family-in-font-face-crash.html

  • css/CSSParser.cpp: (WebCore::CSSParser::createFontFaceRule):
15:10 Changeset [86499] by oliver@apple.com
  • 66 edits in trunk/Source

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSCell.cpp: (JSC::slowValidateCell):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
  • runtime/Structure.h: (JSC::JSCell::classInfo):
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
  • wtf/Assertions.h:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):
14:44 Changeset [86498] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Anders Carlsson.

Make Qt bindings GC safe
https://bugs.webkit.org/show_bug.cgi?id=60841

Trying to do cache management by using "this" as a key from a GC
object's destructor leads to a violation of GC semantics. Make
the qt bindings use a Weak<> handle for finalization.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
  • bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethodData::finalize):
14:23 Changeset [86497] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-14 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

WebKit2: Smart cut&paste is broken
https://bugs.webkit.org/show_bug.cgi?id=60840
<rdar://problem/9439927>

  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): Match WK1 - this default defaults to YES if not present.
13:48 Changeset [86496] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/test_expectations.txt:
13:41 Changeset [86495] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

WKView does not draw after forced repaint before the first update
https://bugs.webkit.org/show_bug.cgi?id=60845

Reviewed by Alice Liu.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint): Added.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::waitForBackingStoreUpdateOnNextPaint): Set m_hasReceivedFirstUpdate
to true, ensuring that paint() will wait for an update if needed.

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint): Call DrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint().

13:00 Changeset [86494] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Document the WantsMozillaUserAgent quirk and make it Windows specific
https://bugs.webkit.org/show_bug.cgi?id=60843

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::userAgent):
11:40 Changeset [86493] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-14 Arno Renevier <arno@renevier.net>

Reviewed by Martin Robinson.

make run-gtk-tests executable
https://bugs.webkit.org/show_bug.cgi?id=59278

  • Scripts/run-gtk-tests:
11:15 Changeset [86492] by dcheng@chromium.org
  • 1 edit
    3 copies in branches/chromium/742

Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7018002

11:10 Changeset [86491] by rniwa@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-05-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564

Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.

As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:

HTML: applet, br, embed, frame, frameset, hr (unless has children), img, input, keygen,

meter, object (unless uses fallback content), output, progress, select, and textarea.

No new tests are added since this change cannot be tested directly.

  • dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
  • dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
  • dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
  • dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
  • dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
  • editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
  • editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
  • html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
  • html/HTMLButtonElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
  • html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
  • html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
  • html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
  • html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
  • html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Added; returns true iff it has children.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::canContainRangeEndPoint): Added; returns true iff it uses fallback content.
11:10 Changeset [86490] by andersca@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/qt/Skipped:

Add plugins/get-url-notify-with-url-that-fails-to-load.html to the skipped list.

11:06 Changeset [86489] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Consolidate plug-in creation parameters to a single struct
https://bugs.webkit.org/show_bug.cgi?id=60839

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::create): (WebKit::PluginControllerProxy::PluginControllerProxy):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: Added. (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Added.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin):
  • PluginProcess/WebProcessConnection.h:
  • PluginProcess/WebProcessConnection.messages.in:
  • Scripts/webkit2/messages.py:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):
10:29 Changeset [86488] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

2011-05-14 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
https://bugs.webkit.org/show_bug.cgi?id=60142

  • fullscreen/video-controls-override-expected.txt: Added.
  • fullscreen/video-controls-override.html: Added.

2011-05-14 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen causes <video> element inline controls to become visible
https://bugs.webkit.org/show_bug.cgi?id=60142

Create a queue of elements who must be targeted with webkitfullscreenchange events. Instead of dispatching
a single event with whatever the current value of m_fullScreenElement is (which may have been cleared, or
changed since the timer was asked to fire), dispatch one event for each entry in the queue.

Test: fullscreen/video-controls-override.html

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Push current full screen element onto the

webkitfullscreenchange event delay queue.

(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::fullScreenElementRemoved): Ditto.
(WebCore::Document::fullScreenChangeDelayTimerFired): Empty the queue, dispatching a

webkitfullscreenchange event for each entry.

  • dom/Document.h:
09:31 Changeset [86487] by andersca@apple.com
  • 10 edits
    3 adds in trunk

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

  • platform/gtk/Skipped: Add test to Skipped list since it apparently crashes.
  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-14 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

09:17 Changeset [86486] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-14 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flashing window frame and graphical glitches after exiting full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60825

A layer-backed WebView throws an exception when moved from a layer-backed parent view
to a non-layer-backed one, so make the WebView a child of the content view, instead of
the animation view. There is an unrelated fix in beganExitFullScreen, which was calling
finishedExitFullScreenAnimation: instead of finishedEnterFullScreenAnimation: when
notifications come out of order.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Add the _webView

to the full screen window's content view, instead of the _animationView.

(-[WKFullScreenWindowController beganExitFullScreenAnimation]): Call

finishedEnterFullScreenAnimation: instead of finishedExitFullScreenAnimation:.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): Add the

_layerHostingView to the contentView, instead of the animationView.

07:56 Changeset [86485] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Buildfix for SharedTimerWx.cpp
https://bugs.webkit.org/show_bug.cgi?id=60829

  • platform/wx/SharedTimerWx.cpp: (WebCore::WebKitTimer::WebKitTimer): We can't call the constructor of a base class in the body of the constructor.
02:39 Changeset [86484] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-14 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r86477.

Remove the global namespace prefix from GlobalLock/GlobalUnlock.

  • platform/win/ClipboardUtilitiesWin.cpp:
01:48 Changeset [86483] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]fast/events/remove-target-in-mouseup* tests fail
https://bugs.webkit.org/show_bug.cgi?id=60833

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834

  • platform/qt/Skipped: Add failing tests.
01:02 Changeset [86482] by ossy@webkit.org
  • 66 edits in trunk/Source

Unreviewed, rolling out r86469 and r86471, because they made hundreds tests crash on Qt.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Source/JavaScriptCore:

(JSC::DebuggerActivation::visitChildren):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp:

(JSC::Arguments::visitChildren):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):

  • runtime/Executable.h:

(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

  • runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

  • runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

  • runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSCell::JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

  • runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildren):

  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildren):

  • runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC::Structure::createStructure):
(JSC::JSCell::classInfo):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrier::WriteBarrier):

  • wtf/Assertions.h:

Source/WebCore:

  • bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildren):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildren):

  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildren):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildren):

  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildren):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildren):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildren):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

  • bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildren):

  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildren):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildren):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildren):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildren):

  • bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildren):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildren):

  • bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildren):

  • bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildren):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildren):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildren):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):

  • bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::invalidate):
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):

00:24 Changeset [86481] by ossy@webkit.org
  • 9 edits
    3 deletes in trunk

Unreviewed, rolling out r86476.
http://trac.webkit.org/changeset/86476
https://bugs.webkit.org/show_bug.cgi?id=60832

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-05-14
It made plugins/get-url-notify-with-url-that-fails-to-
load.html crash on GTK (Requested by Ossy on #webkit).

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::stop):
(WebKit::NetscapePluginStream::notifyAndDestroyStream):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

LayoutTests:

  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Removed.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Removed.

05/13/11:

22:22 Changeset [86480] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • ewk/ewk_history.cpp:
21:42 Changeset [86479] by dcheng@chromium.org
  • 1 edit
    3 deletes in branches/chromium/742

Revert 86470 - Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/6973064

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/6973070

21:20 Changeset [86478] by ap@apple.com
  • 5 edits
    3 adds in trunk

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

  • http/tests/appcache/interrupted-update-expected.txt: Added.
  • http/tests/appcache/interrupted-update.html: Added.
  • http/tests/appcache/resources/interrupted-update.manifest: Added.
  • http/tests/appcache/main-resource-redirect.html:
  • http/tests/appcache/non-html.xhtml: Now that we dispatch an error even when aborting a load due to navigation, error event handler was getting called after notifyDone().

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

HTML5 Application Cache Update Failures on Page Refresh
https://bugs.webkit.org/show_bug.cgi?id=60598
<rdar://problem/9418639>

Test: http/tests/appcache/interrupted-update.html

The reason was two-fold:
1) Cache group state wasn't fully reset after a failed cache update (or an initial load).
2) The cache group is not deleted until after after the navigation (from autorelease pool),
so the failed and sorry old version was picked up by cache selection algorithm.

The latter is more of a surprising behavior than a problem in itself. Keeping an appcache in
memory for reload is generally a good thing for performance.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Added a FIXME about half-baked state resetting code that sent me looking for a wrong fix originally. (WebCore::ApplicationCacheGroup::stopLoadingInFrame): Stopped load is an update failure like any other, so we should call cacheUpdateFailed(), which knows how to reset state.
18:18 Changeset [86477] by enrica@apple.com
  • 13 edits in trunk/Source

REGRESSION (WK2): Can't drag and drop a link or image from Safari to Desktop
https://bugs.webkit.org/show_bug.cgi?id=60819
<rdar://problem/9370689>

Reviewed by Darin Adler and Brian Weinstein.

Source/WebCore:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.
It also fixes a regression introduced by r70914, that was causing the content of the
shortcut files to be corrupted. Using ascii() to convert from String to CString was
causing '\n' and '\r' to be replaced with '?'.

  • platform/DragData.h:
  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fileDescriptorFormat): Moved from ClipboardWin.cpp.
(WebCore::fileContentFormatZero): Moved from ClipboardWin.cpp.
(WebCore::getFileDescriptorData): Serialize FileDescriptor type.
(WebCore::getFileContentData): Serialize FileContent type.
(WebCore::setFileDescriptorData): Deserialize FileDescriptor type.
(WebCore::setFileContentData): Deserialize FileContent type.
(WebCore::setCFData): Added missing initialization of the tymed field
that was causing the cfHDrop format not to be deserialized correctly.

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::createGlobalHDropContent): Changed ascii() to latin1().
(WebCore::ClipboardWin::writeURL):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::getDragFileDescriptorData):
(WebCore::DragData::getDragFileContentData):

Source/WebKit2:

To support drag-and-drop to the desktop and other windows applications,
we need to support the fileDescriptor and fileContentZero clipboard formats.
This patch adds the support for serializing these types across the process boundary.

  • Platform/CoreIPC/Arguments.h: Added support for messages with 10 arguments.

(CoreIPC::Arguments10::Arguments10):
(CoreIPC::Arguments10::encode):
(CoreIPC::Arguments10::decode):
(CoreIPC::In):
(CoreIPC::Out):

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added support for memebers with 10 arguments.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startDragDrop):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp:

(WebKit::WebDragClient::startDrag):

18:05 Changeset [86476] by andersca@apple.com
  • 9 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad): (GetURLNotifyWithURLThatFailsToLoad::NPP_New): (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

Add test.

  • plugins/get-url-notify-with-url-that-fails-to-load-expected.txt: Added.
  • plugins/get-url-notify-with-url-that-fails-to-load.html: Added.

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
https://bugs.webkit.org/show_bug.cgi?id=60823
<rdar://problem/9430386>

If a plug-in stream fails to load before it's been started, we won't destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop): Call notifyAndDestroyStream which will call NPP_URLNotify if necessary, and also destroy the stream.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Pass the request URL to NPP_URLNotify, matching other browsers.

17:55 Changeset [86475] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Fix the build.

Add includes that the builders are suddenly complaining about...

  • page/DragState.h:
17:24 Changeset [86474] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Disable failing test on chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
17:03 Changeset [86473] by msaboff@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-13 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Backing store may not get discarded due to stopped timer
https://bugs.webkit.org/show_bug.cgi?id=60816

Changed the backing store timer to restart if it has been stopped.
The evaluation is done when the view's state is changed.
This change appears to be worth ~3MB (one backing store worth)
during memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange):
16:31 Changeset [86472] by dcheng@chromium.org
  • 9 edits
    2 adds in trunk

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
https://bugs.webkit.org/show_bug.cgi?id=59409

Add a new test to test drag start edge cases on Mac (because of a non-zero text drag delay)
as well as rebase an existing test.

  • fast/css/user-drag-none.html: Text nodes are no longer draggable.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt: Added.
  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html: Added.

2011-05-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Improve drag start logic
https://bugs.webkit.org/show_bug.cgi?id=59409

Rewrite and simplify the dragging logic to better match IE, Firefox, and the behavior
defined in the spec. Among other things:

  • draggableNode() no longer returns text nodes when dragging anchors.
  • When starting a drag over an image in a selection, prefer to drag the selection.
  • Several redundant hit tests have been removed.
  • Minor refactoring to make the logic easier to follow.

Test: platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html

  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::draggableNode): (WebCore::DragController::startDrag):
  • page/DragController.h:
  • page/DragState.h: (WebCore::DragState::shouldDispatchEvents):
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateDragSourceActionsAllowed): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::ExactlyOneBitSet): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
16:16 Changeset [86471] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

16:09 Changeset [86470] by dcheng@chromium.org
  • 1 edit
    3 copies in branches/chromium/742

Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/inline/nested-top-alignment.html: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/6973064

16:07 Changeset [86469] by oliver@apple.com
  • 66 edits in trunk/Source

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This patch makes the checks performed under GC_VALIDATION
much more aggressive, and adds the checks to more places
in order to allow us to catch GC bugs much closer to the
point of failure.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedSpace.cpp:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h:
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSCell.cpp: (JSC::slowValidateCell):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::unvalidatedStructure): (JSC::JSCell::JSCell::JSCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): (JSC::slowValidateCell):
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::visitChildren):
  • runtime/Structure.h: (JSC::JSCell::classInfo):
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h:
  • runtime/WriteBarrier.h: (JSC::validateCell): (JSC::JSCell): (JSC::JSGlobalObject): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::setMayBeNull): (JSC::WriteBarrierBase::setEarlyValue): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::unvalidatedGet): (JSC::WriteBarrier::WriteBarrier):
  • wtf/Assertions.h:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

This makes GC_VALIDATION much more aggressive in webcore,
adding logic to every visitChildren method to ensure that
the structure still has correct flags.

Additionally every function generated for the dom bindings
makes use of the new GC_VALIDATION object assertions to further
ensure that the object appears to be sensible.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContext::visitChildren):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContext::visitChildren):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): (WebCore::JSDOMGlobalObject::setInjectedScript):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXPathResultCustom.cpp: (WebCore::JSXPathResult::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:

2011-05-13 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make GC validation more aggressive
https://bugs.webkit.org/show_bug.cgi?id=60802

Add GC_VALIDATION calls to all the JSNPObject methods.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): (WebKit::JSNPObject::callMethod): (WebKit::JSNPObject::callObject): (WebKit::JSNPObject::callConstructor): (WebKit::JSNPObject::getCallData): (WebKit::JSNPObject::getConstructData): (WebKit::JSNPObject::getOwnPropertySlot): (WebKit::JSNPObject::getOwnPropertyDescriptor): (WebKit::JSNPObject::put): (WebKit::JSNPObject::getOwnPropertyNames): (WebKit::JSNPObject::propertyGetter): (WebKit::JSNPObject::methodGetter):
15:56 Changeset [86468] by andersca@apple.com
  • 2 edits in trunk/Tools

Build fix.

  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
15:37 Changeset [86467] by andersca@apple.com
  • 22 edits
    3 adds in trunk

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

In NetscapePluginStream::sendJavaScriptStream, we were incorrectly passing the result URL
to the stream, instead of the result. Also, store the request URL in the NetscapePluginStream object
to avoid sending it over the wire.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::didEvaluateJavaScript):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::loadURL): (WebKit::NetscapePlugin::didEvaluateJavaScript): (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::NetscapePluginStream): (WebKit::NetscapePluginStream::sendJavaScriptStream):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h: (WebKit::NetscapePluginStream::create):
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::didEvaluateJavaScript):
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest):

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • plugins/get-url-with-javascript-url-expected.txt: Added.
  • plugins/get-url-with-javascript-url.html: Added.

2011-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

NPN_GetURL with a javascript: URL doesn't send back the result in the stream
https://bugs.webkit.org/show_bug.cgi?id=60810

Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am: Add files.
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added. (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL): (GetURLWithJavaScriptURL::NPP_New): (GetURLWithJavaScriptURL::NPP_NewStream): (GetURLWithJavaScriptURL::NPP_DestroyStream): (GetURLWithJavaScriptURL::NPP_WriteReady): (GetURLWithJavaScriptURL::NPP_Write):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_URLNotify): call the PluginTest NPP wrappers.
15:32 Changeset [86466] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: remove objectstore
https://bugs.webkit.org/show_bug.cgi?id=60768

This test creates an objectstore, populates it with 100 records,
deletes the objectstore, and checks that the objectStoreNames array
is updated properly at each step.

  • storage/indexeddb/mozilla/remove-objectstore-expected.txt: Added.
  • storage/indexeddb/mozilla/remove-objectstore.html: Added.
15:30 Changeset [86465] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Removed chromium border-fit-lines.html suppression as it seems to pass now. Unreviewed.

  • platform/chromium/test_expectations.txt:
15:09 Changeset [86464] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86447.
http://trac.webkit.org/changeset/86447
https://bugs.webkit.org/show_bug.cgi?id=60809

"Broke some uses of EventSender object on Qt" (Requested by
mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
15:00 Changeset [86463] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Mikhail Naganov <mnaganov@chromium.org>

Web Inspector: Unreviewed image glyph position fix in CSS after r85588.

  • inspector/front-end/heapProfiler.css: (.heapshot-help-status-bar-item .glyph):
14:48 HighLevelOverview edited by levin@chromium.org
(diff)
14:44 Changeset [86462] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
https://bugs.webkit.org/show_bug.cgi?id=60784

Test that we block popup windows from inside sandbox.

  • http/tests/security/no-popup-from-sandbox-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top-expected.txt: Added.
  • http/tests/security/no-popup-from-sandbox-top.html: Added.
  • http/tests/security/no-popup-from-sandbox.html: Added.

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

iframe sandbox doesn't properly block popups
https://bugs.webkit.org/show_bug.cgi?id=60784

Previously, we weren't implementing this requirement from the spec:

"This flag also prevents content from creating new auxiliary browsing
contexts, e.g. using the target attribute or the window.open() method."

Tests: http/tests/security/no-popup-from-sandbox-top.html

http/tests/security/no-popup-from-sandbox.html

  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::checkNewWindowPolicy):
14:35 Changeset [86461] by rniwa@webkit.org
  • 5 edits
    8 adds in trunk

2011-05-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
https://bugs.webkit.org/show_bug.cgi?id=60600

Added tests to ensure WebKit does not fire click event when the target node
is removed in mouseup event.

  • fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-deep.html: Added.
  • fast/events/remove-target-in-mouseup-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-insertback.html: Added.
  • fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
  • fast/events/remove-target-in-mouseup-twice.html: Added.
  • fast/events/remove-target-in-mouseup.html: Added.

2011-05-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

click event shouldn't fire when the target is ever removed in mouseup
https://bugs.webkit.org/show_bug.cgi?id=60600

Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
from the document. New behavior matches Internet Explorer and Firefox.

Tests: fast/events/remove-target-in-mouseup-deep.html

fast/events/remove-target-in-mouseup-insertback.html
fast/events/remove-target-in-mouseup-twice.html
fast/events/remove-target-in-mouseup.html

  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved. (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
  • page/EventHandler.cpp: (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode or one of its ancestor is removed from the document.
  • page/EventHandler.h:
13:59 Changeset [86460] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Joseph Pecoraro.

Hide appcache status bar items
https://bugs.webkit.org/show_bug.cgi?id=60799

We have a number of non-trivial bugs that make these more misleading than helpful to developers.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): Just hide the items for now. Removing all support code would be complicated, and not helpful.
13:46 Changeset [86459] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-05-13 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Make some page() member functions const
https://bugs.webkit.org/show_bug.cgi?id=60794

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Make page() const.
  • UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::page): Make page() const.
  • UIProcess/WebInspectorProxy.h: (WebKit::WebInspectorProxy::page): Make page() const.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
13:40 Changeset [86458] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=60785

  • http/tests/security/no-indexeddb-from-sandbox-expected.txt: Added.
  • http/tests/security/no-indexeddb-from-sandbox.html: Added.

2011-05-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

indexedDB is visible inside iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=60785

We're supposed to return a null indexedDB factory when inside an iframe
sandbox.

Test: http/tests/security/no-indexeddb-from-sandbox.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
13:22 Changeset [86457] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: indexes with keys and key ranges
https://bugs.webkit.org/show_bug.cgi?id=60733

This megatest creates an object store with several rows of data,
creates indexes on each key, then iterates each index in a variety
of ways (keys, key ranges, etc).

  • storage/indexeddb/mozilla/indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/indexes.html: Added.
12:54 Changeset [86456] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Load plugins in the order they're found

Fixes <http://webkit.org/b/60788> <rdar://problem/9435787> REGRESSION (r69790): WebKit2
doesn't prefer plugins in the additional plugins directory

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::addFromVector):
Changed to use a ListHashSet instead of a HashSet to store the plugin paths.

12:54 Changeset [86455] by aroben@apple.com
  • 4 edits in trunk/Source/WebCore

Fix manual tests that got broken by the move of WebCore into Source

  • manual-tests/plugins/object-clipping.html:
  • manual-tests/pointer-events.html:
  • manual-tests/video-waiting-seeking.html:

Updated some paths.

12:48 Changeset [86454] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-13 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
https://bugs.webkit.org/show_bug.cgi?id=60738

Remove supression for previously failing compositor tests.

  • platform/chromium/test_expectations.txt:

2011-05-13 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] compositing tests are failing
https://bugs.webkit.org/show_bug.cgi?id=60738

Bind texture before setting its filtering state.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateFromPixels):
12:40 Changeset [86453] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=60787
Add some assertions to ApplicationCacheGroup

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow. (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto. (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before resetting it. (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or resource hanging around. (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
12:28 Changeset [86452] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source/WebKit/chromium

2011-05-13 Tao Bai <michaelbai@chromium.org>

Reviewed by Darin Fisher.

Handle the touch icon.
https://bugs.webkit.org/show_bug.cgi?id=60247

Added WebIconURL for the corresponding IconURL.
Added method iconURLs() to specify the type of icon need to return.
The favIconURL() is deprecated and will be removed later.

  • WebKit.gyp:
  • features.gypi:
  • public/WebFrame.h:
  • public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
  • public/WebIconURL.h: Added. (WebKit::WebIconURL::WebIconURL): (WebKit::WebIconURL::iconType): (WebKit::WebIconURL::iconURL):
  • src/AssertMatchingEnums.cpp:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::favIconURL):
  • src/WebFrameImpl.h:
12:09 Changeset [86451] by weinig@apple.com
  • 64 edits
    1 add in trunk/Source

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • src/AutoFillPopupMenuClient.cpp:
  • src/PlatformBridge.cpp:
  • src/WebPopupMenuImpl.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • Api/qgraphicswebview.cpp:
  • WebCoreSupport/ChromeClientQt.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/GtkAdjustmentWatcher.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebDragClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebFrame.cpp: (WebFrame::setPrinting):
  • WebView.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebView/WebClipView.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Replace #includes in FrameView.h of Frame.h and Page.h with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityScrollView.cpp:
  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • css/MediaQueryMatcher.cpp:
  • dom/Range.cpp:
  • editing/SpellingCorrectionController.cpp:
  • history/CachedFrame.cpp:
  • html/HTMLBodyElement.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/parser/HTMLParserScheduler.cpp:
  • page/AdjustViewSizeOrNot.h: Added.
  • page/EditorClient.h:
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
  • page/FrameView.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
  • page/chromium/FrameChromium.cpp:
  • page/win/FrameCGWin.cpp:
  • page/win/FrameWin.cpp:
  • platform/efl/PopupMenuEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/gtk/WidgetGtk.cpp:
  • plugins/IFrameShimSupport.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderFrameBase.cpp:
  • rendering/RenderIFrame.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderWidget.cpp:
  • svg/SVGSVGElement.cpp:

2011-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748

  • Update files that were depending on FrameView.h #including Frame.h or Page.h.
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
11:21 Changeset [86450] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress crasher in chromium. Unreviewed.

  • platform/chromium/test_expectations.txt:
11:21 Changeset [86449] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-13 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCollapsedBorder to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60739

Updating the last offending paint function that takes four ints
instead of an IntRect.

No new tests as this is simple refactoring.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
11:17 Changeset [86448] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-13 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Regression(r75823): Revert initialization back to the first RenderBlock
in the parent chain.
https://bugs.webkit.org/show_bug.cgi?id=60780

Test: fast/block/float/float-not-removed-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): In r75823, I forgot to initialize parentBlock, when the original code did and Hyatt did mention in c#5. Now, initializing parentBlock to the first RenderBlock in the parent chain.

2011-05-13 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to access a deleted float.
https://bugs.webkit.org/show_bug.cgi?id=60780

  • fast/block/float/float-not-removed-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-crash.html: Added.
11:11 Changeset [86447] by robert@webkit.org
  • 9 edits
    2 adds in trunk

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-13 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
11:00 Changeset [86446] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TextEditor should support editing a range.
https://bugs.webkit.org/show_bug.cgi?id=59688

  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype.setEditableRange): (WebInspector.TextEditorMainPanel.prototype.clearEditableRange): (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.set readOnly): (WebInspector.TextEditorMainChunk.prototype.get readOnly): (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
  • inspector/front-end/textViewer.css: (.text-editor-read-only):
10:36 Changeset [86445] by aroben@apple.com
  • 3 edits in trunk/Tools

Exclude the Leopard NRWT bot from the core builder set

Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot.init): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
in the core builder set.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
regexps.

10:36 Changeset [86444] by aroben@apple.com
  • 2 edits in trunk/Tools

Group all the NRWT bots together

This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
bots are experimental, it seems best not to clutter up the non-experimental bots with
experimental ones.

Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
on build.webkit.org

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the

Chromium testers, which also use new-run-webkit-tests.

10:25 Changeset [86443] by podivilov@chromium.org
  • 7 edits in trunk

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=60263

  • inspector/debugger/resources/obfuscated.js: (formatted1): (formatted2):
  • inspector/debugger/script-formatter.html:

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix source mapping for formatted scripts.
https://bugs.webkit.org/show_bug.cgi?id=60263

Source mapping is broken for script chunks that are already formatted at the beginning
and at the end of the script (see script-formatter.html).

  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype._didFormatContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.originalToFormatted): (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage): (HTMLScriptFormatter.prototype.format):
  • inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.SourceMappingForFormattedSourceFile): (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine): (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
10:24 Changeset [86442] by aroben@apple.com
  • 5 edits
    5 adds in trunk

Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect changes

r79167 moved some code from setFrameRect to setBoundsSize, including a call to
frameRectsChanged. This was done because positionScrollbarLayers, which is called by
frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
frame rect changes.

This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
to be called at different times from frameRectsChanged. Then it restores the
frameRectsChanged call to setFrameRect, which fixes the bug.

Test: platform/win/plugins/iframe-inside-overflow.html

Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
plugins in Google Reader don't move when the article list is scrolled

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
call frameRectsChanged here when our frame rect hasn't changed.
(WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
in r79167.
(WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
positionScrollbarLayers to be called.
(WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.

Tools:

Add a plugin test that dumps the plugin window's rect

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.

(DumpWindowRect::DumpWindowRect): Just call up to the base class.
(DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
harness window and log it.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.

LayoutTests:

Add a test for windowed plugins inside iframes inside scrolled overflow areas

  • platform/win/plugins/iframe-inside-overflow-expected.txt: Added.
  • platform/win/plugins/iframe-inside-overflow.html: Added.

(loaded): Scrolls the div and tells the plugin to start its test (which will cause its
window rect to be logged).

  • platform/win/plugins/resources/dump-window-rect-iframe.html: Added.
10:24 Changeset [86441] by aroben@apple.com
  • 3 edits
    2 adds in trunk/Tools

Move code required for most tests of plugin window geometry into a base class

WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
having all the trickiness in a shared base class, writing new window geometry tests will be
much easier.

Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
WindowGeometryTest base class. Most of the code from this class was moved to the new base
class.
(WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
This is called by the base class when it is safe to check the window's geometry. Note that
the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
just vestigial code from an earlier version of this test.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new

WindowGeometryTest class.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from

WindowRegionIsSetToClipRect.
(WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
Subclasses can implement that function to perform their own tests.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
09:58 Changeset [86440] by robert@webkit.org
  • 3 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

Make fast/dom/object-embed-plugin-scripting.html compatible with non-Mac ports

https://bugs.webkit.org/show_bug.cgi?id=59930

  • fast/dom/resources/articles.m4a: Removed.
  • platform/chromium/test_expectations.txt: Unskip object-embed-plugin-scripting.html on Linux
  • platform/qt/Skipped: Unskip object-embed-plugin-scripting.html
  • plugins/object-embed-plugin-scripting-expected.txt: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting-expected.txt.
  • plugins/object-embed-plugin-scripting.html: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting.html.
  • plugins/resources/apple.gif: Added.
09:56 Changeset [86439] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-13 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Don't destroy a null FcPattern when failing to do a FontConfig match.
This crashes, and there's nothing FcDestroy could do with a null
pointer even if it didn't crash.
https://bugs.webkit.org/show_bug.cgi?id=60777

  • src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
09:55 Changeset [86438] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC.

Reviewed by nobody, build fix.

qobject_cast<> requires the class to be exported on MSVC,
removing it since the code that needs it is commented out for
the same reason.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::elementAreaAt):

09:54 Changeset [86437] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.

Reviewed by nobody, build fix.

  • tests/tests.pro:
09:40 HighLevelOverview edited by levin@chromium.org
(diff)
09:22 SourceDirectory created by levin@chromium.org
09:00 Changeset [86436] by mrobinson@webkit.org
  • 8 edits
    2 adds in trunk/Source

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
almost directly moved from the WebKit layer.

No new tests. This is covered by the editing tests.

  • GNUmakefile.list.am:
  • platform/gtk/KeyBindingTranslator.cpp: Added. (WebCore::backspaceCallback):Added. (WebCore::selectAllCallback):Added. (WebCore::cutClipboardCallback):Added. (WebCore::copyClipboardCallback):Added. (WebCore::pasteClipboardCallback):Added. (WebCore::toggleOverwriteCallback):Added. (WebCore::popupMenuCallback):Added. (WebCore::showHelpCallback):Added. (WebCore::deleteFromCursorCallback):Added. (WebCore::moveCursorCallback):Added. (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added. (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
  • platform/gtk/KeyBindingTranslator.h: Added. (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that the command vector now contains WTF::string. (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class. (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.

2011-05-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59765

Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
class we can now share the code with WebKit2.

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code. (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
  • UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
09:00 Changeset [86435] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-13 Steve VanDeBogart <vandebo@chromium.org>

Unreviewed.

Update expectations for GPU tests that use shadows after fix (Skia rev 1297).
https://bugs.webkit.org/show_bug.cgi?id=60742

  • platform/chromium/test_expectations.txt:
08:26 Changeset [86434] by zherczeg@webkit.org
  • 3 edits in trunk/Tools

2011-05-13 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Csaba Osztrogonác.

Missing 2nd #EOF if WebProcess is killed.
https://bugs.webkit.org/show_bug.cgi?id=60761

If the WebProcess is killed, only one #EOF is yielded
by WebKitTestRunner. However, run-webkit-test wait for
a second #EOF, which signals the finishing of pixel dump.
Since this never happens, run-webkit-test waits forever.

  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dump): (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/TestInvocation.h:
08:09 Changeset [86433] by zecke@webkit.org
  • 3 edits in trunk/Source/WebCore

[android] Forward declare types for PlatformWidget and DragImage

https://bugs.webkit.org/show_bug.cgi?id=59890

This is fixing the compilation of files that include Widget.h or
DragImage.h.

08:09 Changeset [86432] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[android] OS(ANDROID) does not imply PLATFORM(ANDROID)

https://bugs.webkit.org/show_bug.cgi?id=59888

It is possible to build QtWebKit and others for OS(ANDROID). Let
the buildsystem decide which platform is to be build.

07:59 Changeset [86431] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped: Add 4 failing tests.
07:56 Changeset [86430] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix incremental html highlight.
https://bugs.webkit.org/show_bug.cgi?id=60163

SourceTokenizers for html, js, and css are declared to be stateless. However they store some state in
various ways (like using _internalJavaScriptTokenizer field in html tokenizer, or modifying "static"
initialCondition object via condition link). This all worked because of another bug in tokenizers registry
that always returned new tokenizer object.
For incremental highlighting, we need to be able to stringify tokenizers state and then restore the
state from string. That's why we need tokenizers to be truly stateless.

  • inspector/front-end/DOMSyntaxHighlighter.js: (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.createInitialCondition): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype.get _internalJavaScriptTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.get _internalCSSTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.createInitialCondition):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._highlightLines):
07:48 Changeset [86429] by ossy@webkit.org
  • 4 edits in trunk/Tools

[NRWT] chromium-linux tests shouldn't run on other platforms
https://bugs.webkit.org/show_bug.cgi?id=60162

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-13
Reviewed by Csaba Osztrogonác.

Remove _tests_for_other_platforms defs because r82753
implemented it properly in the baseclass in webkit.py.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
07:38 Changeset [86428] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r86418

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Made the destructor public so that this class can be used with
[Pass]OwnPtr.

07:32 Changeset [86427] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-wk2/Skipped:
07:00 Changeset [86426] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
06:29 Changeset [86425] by hans@chromium.org
  • 4 edits in trunk/Source

2011-05-11 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
https://bugs.webkit.org/show_bug.cgi?id=60623

Fix the code for comparing two int64_t variables.
Also remove faulty line in ObjectStoreNamesKey::encode which was
uncovered by the unit test in this patch.

Very hard to cover with layout tests; covered by unit test.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::compareInts): (WebCore::IDBLevelDBCoding::KeyPrefix::compare): (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare): (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare): (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode): (WebCore::IDBLevelDBCoding::IndexNamesKey::compare): (WebCore::IDBLevelDBCoding::IndexDataKey::compare):

2011-05-11 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Fix integer comparison bug in LevelDB coding routines
https://bugs.webkit.org/show_bug.cgi?id=60623

Unit test for comparison of encoded keys.

  • tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
05:08 Changeset [86424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-13 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Darin Adler.

GraphicsContext3DQt.cpp fails to compile
https://bugs.webkit.org/show_bug.cgi?id=60740

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Change order of initializers.
03:34 Changeset [86423] by antonm@chromium.org
  • 1 edit
    23 adds in trunk/LayoutTests

2011-02-08 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611

This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.

Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
  • dom/Document.h:
03:21 Changeset [86422] by hans@chromium.org
  • 13 edits
    2 adds in trunk

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Add test for veryfing that transaction roll-back works, even with a
previously opened cursor still around.

  • storage/indexeddb/transaction-rollback-expected.txt: Added.
  • storage/indexeddb/transaction-rollback.html: Added.

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Let the IDBTransactionbackendImpl keep track of all open cursors, and
"close" them (i.e. finalizing the underlying SQLiteStatement) before
committing or rolling back the transaction. This fixes the problem
with opened cursors preventing transaction rollback.

Test: storage/indexeddb/transaction-rollback.html

  • storage/IDBBackingStore.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::close):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBSQLiteBackingStore.cpp:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::registerOpenCursor): (WebCore::IDBTransactionBackendImpl::unregisterOpenCursor): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::closeOpenCursors):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h: (WebCore::IDBTransactionBackendInterface::registerOpenCursor): (WebCore::IDBTransactionBackendInterface::unregisterOpenCursor):

2011-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Transaction rollback prevented by open SQLite statement
https://bugs.webkit.org/show_bug.cgi?id=60032

Implement two new methods in IDBTransactionBackendInterface.

  • src/IDBTransactionBackendProxy.cpp: (WebKit::IDBTransactionBackendProxy::registerOpenCursor): (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
  • src/IDBTransactionBackendProxy.h:
02:56 Changeset [86421] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-05-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move ewk_view_dpi_get() to ewk_util.cpp
https://bugs.webkit.org/show_bug.cgi?id=60753

Move ewk_view_dpi_get() to ewk_util.cpp

  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp: (ewk_util_dpi_get):
  • ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute):
01:39 Changeset [86420] by sergio@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r86352.

  • platform/gtk/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/gtk/svg/custom/stroke-opacity-update-expected.txt: Added.
01:29 Changeset [86419] by sergio@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-13 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations.

  • platform/gtk/fast/borders/outline-alpha-block-expected.png:
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.png:
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-update-expected.png:
  • platform/gtk/svg/custom/fill-opacity-update-expected.txt:
00:37 Changeset [86418] by paroga@webkit.org
  • 21 edits in trunk/Source

2011-05-13 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::loadWithNextMediaEngine):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::create):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::create):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::create):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::create):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

2011-05-13 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=59466

Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
Also fix the templete argument of OwnPtr for the m_private member variable.

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h:
00:20 Changeset [86417] by ap@apple.com
  • 11 edits in trunk

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Unreviewed test changes.

Web Inspector: Show Error Messages for Application Cache Errors
https://bugs.webkit.org/show_bug.cgi?id=41642

  • http/tests/appcache/404-resource-expected.txt:
  • http/tests/appcache/manifest-redirect-expected.txt:
  • http/tests/appcache/origin-quota-expected.txt:
  • http/tests/appcache/resource-redirect-2-expected.txt:
  • http/tests/appcache/resource-redirect-expected.txt:
  • http/tests/appcache/wrong-content-type-expected.txt:
  • http/tests/appcache/wrong-signature-2-expected.txt:
  • http/tests/appcache/wrong-signature-expected.txt:

2011-05-13 Alexey Proskuryakov <ap@apple.com>

Reviewed by Pavel Feldman.

Web Inspector: Show Error Messages for Application Cache Errors
https://bugs.webkit.org/show_bug.cgi?id=41642

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota): Added console error logging.

05/12/11:

23:23 Changeset [86416] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Fixes for warnings and other minor cleanups when we enable USE_CFNETWORK on Mac.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfStreamError):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::allowsAnyHTTPSCertificateHosts): (WebCore::clientCerts): (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didSendBodyData): (WebCore::shouldUseCredentialStorageCallback): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willLoadFromCache):
23:16 Changeset [86415] by psolanki@apple.com
  • 9 edits in trunk/Source

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Implement ResourceHandle::schedule()/unschedule() based on CF for Mac.

  • WebCore.exp.in:
  • platform/cf/SchedulePair.h:
  • platform/mac/SchedulePairMac.mm:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::schedule): (WebCore::ResourceHandle::unschedule):

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Use CFRunLoop when using CFNetwork.

  • WebView/WebView.mm: (-[WebView scheduleInRunLoop:forMode:]): (-[WebView unscheduleFromRunLoop:forMode:]):

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Use CFRunLoop when using CFNetwork.

  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformInitialize):
22:37 Changeset [86414] by psolanki@apple.com
  • 13 edits in trunk/Source

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Implement mac specific Authentication functions when using CFNetwork.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::authenticationClient): (WebCore::createCF): (WebCore::core):
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/AuthenticationChallenge.h:
  • platform/network/mac/AuthenticationMac.mm: (WebCore::core): (WebCore::mac):
  • platform/network/mac/CredentialStorageMac.mm:

2011-05-12 Pratik Solanki <psolanki@apple.com>

Reviewed by Antti Koivisto.

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Include AuthenticationCF.h header file.

  • Misc/WebDownload.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
22:25 Changeset [86413] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Converted the new tests to be text tests with pixel results
(using dumpAsText(true)).
Updated test_expectations comments to be more helpful and accurate and split
new expectations into two groups for skia / chromium-mac as chromium-mac can be
rebaselined now.

  • fast/borders/outline-alpha-block-expected.txt: Added.
  • fast/borders/outline-alpha-block.html:
  • fast/borders/outline-alpha-inline-expected.txt: Added.
  • fast/borders/outline-alpha-inline.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/outline-alpha-block-expected.txt: Removed.
  • platform/mac/fast/borders/outline-alpha-inline-expected.txt: Removed.

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Added FIXMEs near temporary $if !USE(SKIA)s, referencing bug 60342.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
21:59 Changeset [86412] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-12 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove unused option of EWeblauncher
https://bugs.webkit.org/show_bug.cgi?id=60747

Remove sudo-workaround option.
This option is not used and make other option wrong.

  • EWebLauncher/main.c:
21:45 Changeset [86411] by lforschler@apple.com
  • 2 edits in trunk/Tools

2011-05-12 Lucas Forschler <lforschler@apple.com>

Reviewed by Stephanie Lewis.

Fix config.json to address missing WK2 builder/tester config.
Fix naming of machines (xserve not macpro)

  • BuildSlaveSupport/build.webkit.org-config/config.json:
20:13 Changeset [86410] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add a WebSetting to control DNS prefetch
https://bugs.webkit.org/show_bug.cgi?id=60736

DNS prefetch got disabled in Chrome accidentially in
http://trac.webkit.org/changeset/74041. This patch adds a WebSettings
API so we can enable it again.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setDNSPrefetchingEnabled):
  • src/WebSettingsImpl.h:
19:11 Changeset [86409] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

WebProcess sandbox denies file:/// accesses after you navigate to a nonexistent file
<rdar://problem/9427752>
https://bugs.webkit.org/show_bug.cgi?id=60745

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Don't attempt to re-use a non-existent committed sandbox extension. This can happen when the previous load was file: url, but did not require an extension, such as an error page.
18:52 Changeset [86408] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-12 David Grogan <dgrogan@chromium.org>

Reviewed by Darin Adler.

make layout tests in storage/domstorage/events more deterministic
https://bugs.webkit.org/show_bug.cgi?id=60299

Instead of counting the number of storage events fired between two
setTimeout(0) events, specify the number of events to wait for and wait up to
1 second for them.

  • storage/domstorage/events/resources/eventTestHarness.js: (runAfterNStorageEvents): (countStorageEvents.onTimeout): (countStorageEvents): (testStorages.allDone):
  • storage/domstorage/events/script-tests/basic-body-attribute.js: (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/basic-setattribute.js: (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/basic.js: (test): (step1): (step2): (step3): (step4): (step5):
  • storage/domstorage/events/script-tests/case-sensitive.js: (test): (step1): (step2):
  • storage/domstorage/events/script-tests/documentURI.js: (test): (step1): (step2):
18:50 Changeset [86407] by adele@apple.com
  • 8 edits
    1 add in trunk/Source

Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
https://bugs.webkit.org/show_bug.cgi?id=60685

Reviewed by Darin Adler and Adam Barth.

Source/WebCore:

Detect the Solar Walk application so we can add targeted parser quirks.

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsSolarWalk):
  • platform/RuntimeApplicationChecks.h:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added Misc/SolarWalkQuirksUserScript.js and copy it to Resources during the build phase.

Source/WebKit/mac:

Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.

  • Misc/SolarWalkQuirksUserScript.js: Added.
  • WebView/WebView.mm:

(needsSolarWalkQuirksScript):
(leakSolarWalkQuirksUserScriptContents):
(-[WebView _injectSolarWalkQuirksScript]):
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

18:19 Changeset [86406] by jpu@apple.com
  • 11 edits in trunk/Source

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712

Changed wording in some tests to reflect AppKit UI change.

  • manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
  • manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712
<rdar://problem/9427970>

Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
returns. So we don't need to use the condition to coordinate between these two function. In fact,
all callbacks are delivered on main thread. We don't really need any locking here.

Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
been removed.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dismissCorrectionPanelSoon):

2011-05-12 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Regression caused by changeset 86281
https://bugs.webkit.org/show_bug.cgi?id=60712
<rdar://problem/9427970>

Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
returns. So we don't need to use the condition to coordinate between these two function. In fact,
all callbacks are delivered on main thread. We don't really need any locking here.

Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
been removed.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismiss): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
17:33 Changeset [86405] by kerz@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/page/Settings.cpp

Fixing chromium issue http://crbug.com/82482 - DNS pre-resolution was disabled in Webkit - Fix only for Chromium 742 branch

17:25 Changeset [86404] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Daniel Bates <dbates@rim.com>

Attempt to fix the build after changeset 86391<http://trac.webkit.org/changeset/86391>
(https://bugs.webkit.org/show_bug.cgi?id=60681).

  • page/PluginHalter.cpp: (WebCore::PluginHalter::PluginHalter): Substitute m_client for client in ASSERT_ARG since client is now of type PassOwnPtr so it becomes 0 when assigned to another variable.
17:19 Changeset [86403] by commit-queue@webkit.org
  • 3 edits in trunk

2011-05-12 Gregg Tavares <gman@chromium.org>

Reviewed by Kenneth Russell.

Add option to select GraphicsContext3D implementation.
https://bugs.webkit.org/show_bug.cgi?id=60297

  • Source/WebKit/chromium/DEPS:
  • Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:
17:17 Changeset [86402] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations tweaks for chromium.

  • platform/chromium/test_expectations.txt:
17:06 Changeset [86401] by paroga@webkit.org
  • 12 edits in trunk/Source/WebCore

2011-05-12 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Rename SimpleFontData::scaledFontData to createScaledFontData
https://bugs.webkit.org/show_bug.cgi?id=60723

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/pango/SimpleFontDataPango.cpp:
  • platform/graphics/qt/SimpleFontDataQt.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp:
  • platform/graphics/wince/SimpleFontDataWinCE.cpp:
  • platform/graphics/wx/SimpleFontDataWx.cpp:
17:05 Changeset [86400] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Switch paintOutline to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60718

Switching paintOutline to use an IntRect instead of 4 ints.

No new tests as this is just refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::paint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
17:01 Changeset [86399] by tkent@chromium.org
  • 5 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

2011-05-12 Kent Tamura <tkent@chromium.org>

[Chromium] Update test expectations for r86224.

  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Removed.
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt.
  • platform/chromium/test_expectations.txt:
16:53 Changeset [86398] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Address review comment by Dan Bernstein.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

16:45 Changeset [86397] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-12 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when a plug-in tries to load a resource from the application cache
https://bugs.webkit.org/show_bug.cgi?id=60735
<rdar://problem/8216142>

When loading application cache resources from disk, we would never restore the
HTTP status code, which means that resources would always have a 0 status code.
This led to the plug-in stream loader canceling the load, something which the application
cache loading machinery couldn't deal and thus would crash.

Fix the reading of the HTTP status code, and make the loader more robust against
application cache loads being canceled.

Unfortunately, I couldn't come up with a test for this because I couldn't find a reliable way
to force the application cache to be read from disk, so all resources would have valid values.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::loadCache):
16:35 Changeset [86396] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptGlue

<http://webkit.org/b/60710> JavaScriptGlue should compile with -Wmissing-prototypes

Reviewed by Geoffrey Garen.

Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.

This also fixes the following compiler warning:

JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]

JSGlobalData* getThreadGlobalData()


  • Configurations/Base.xcconfig: Set

GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.

  • JSUtils.cpp:

(getThreadGlobalData): Made static.

16:30 Changeset [86395] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-12 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize
https://bugs.webkit.org/show_bug.cgi?id=60585

Refactoring, covered by existing tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionLineBox):
  • rendering/RenderBox.h: (WebCore::RenderBox::setLogicalLocation): (WebCore::RenderBox::setLogicalSize): (WebCore::RenderBox::setLocation):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::positionFrames): (WebCore::RenderFrameSet::positionFramesWithFlattening):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::adjustLogicalHeightForCaption): (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::layoutRootBox):
16:27 Changeset [86394] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-12 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] show-composited-layer-tree crashes on null ptr deref
https://bugs.webkit.org/show_bug.cgi?id=60734

The tiler is created lazily, so it won't not be around for the first
dumpLayerProperties call.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::dumpLayerProperties):
16:21 Changeset [86393] by lforschler@apple.com
  • 5 edits in trunk/Source

Versioning.

16:19 Changeset [86392] by lforschler@apple.com
  • 1 copy in tags/Safari-534.35

New tag.

16:06 Changeset [86391] by paroga@webkit.org
  • 10 edits in trunk/Source

2011-05-12 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.

  • WebCore.exp.in:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
  • page/Page.h:
  • page/PluginHalter.cpp: (WebCore::PluginHalter::PluginHalter):
  • page/PluginHalter.h:

2011-05-12 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2011-05-12 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681

  • WebView.cpp: (WebView::initWithFrame):
15:34 Changeset [86390] by dbates@webkit.org
  • 8 edits
    9 adds in trunk

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Adele Peterson.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.

Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
removing and adding the noresize attribute, respectively.

  • fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
  • fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <https://bugs.webkit.org/show_bug.cgi?id=57604>.
  • fast/frames/frame-programmatic-noresize-expected.txt: Added.
  • fast/frames/frame-programmatic-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
  • fast/frames/resources/frame-programmatic-resize.js: Added. (setTestFrameById): (deltaWidth): (shouldAllowFrameResize): (shouldDisallowFrameResize): (shouldDisallowFrameResizeAfterProcessingFrame): (shouldAllowFrameResizeAfterProcessingFrame): (checkTestFrameWidthEquals): (resizeTestFrameBy): (log): (description):

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Adele Peterson.

Frame's noResize attribute can not be set by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=14845

Tests: fast/frames/frame-inherit-noresize-from-frameset.html

fast/frames/frame-programmatic-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html

Implements support to programmatically allow and disallow frame resizing.

Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
attribute.

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this code path isn't performance critical. (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo(). (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::updateFromElement): Added.
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
  • rendering/RenderFrameSet.h:
15:31 Changeset [86389] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
https://bugs.webkit.org/show_bug.cgi?id=60640

Pass by const reference instead of by value for consistency reasons.

Refactoring, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderFlexibleBox.h: Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead
15:29 Changeset [86388] by mitz@apple.com
  • 2 edits in trunk

Corrected Radar links

15:28 Changeset [86387] by mitz@apple.com
  • 5 edits in trunk

Source/WebCore: <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
https://bugs.webkit.org/show_bug.cgi?id=60730

Reviewed by Sam Weinig.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::isWordStartMatch): Consider all positions before a CJK ideograph as
word starts.

LayoutTests: Updated results for <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
https://bugs.webkit.org/show_bug.cgi?id=60730

Reviewed by Sam Weinig.

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
15:20 Changeset [86386] by lforschler@apple.com
  • 2 edits in trunk/Tools

2011-05-12 Lucas Forschler <lforschler@apple.com>

Reviewed by Stephanie Lewis.

Add SnowLeopard Debug builder and Test bot.
apple-xserve-8 = SL Debug Tester.
apple-xserve-9 = SL Debug Builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:15 Changeset [86385] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxDecorationWithSize to IntRect
https://bugs.webkit.org/show_bug.cgi?id=60679

Switching paintBoxDecorationWithSize to take an IntRect instead of 4 ints.

No new tests as this is simple refactoring.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Cleaning up amazingly confusing logic. (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBox.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
15:00 Changeset [86384] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxShadow to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60713

Switching paintBoxShadow from taking four ints to taking an IntRect.

No new tests since this is refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
14:56 Changeset [86383] by paroga@webkit.org
  • 9 edits
    1 add in trunk/Source

2011-05-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394

This portion of the change introduces a PassTraits template, which
is used to enable takeFirst() to work for a Deque holding OwnPtrs,
and optimize it for a Deque holding RefPtrs. In the future it can
be deployed elsewhere to make our data structures work better with
our smart pointers.

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Deque.h: (WTF::::takeFirst):
  • wtf/PassTraits.h: Added. (WTF::PassTraits::transfer):

2011-05-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=59394

Properly fix this (formerly rolled out for breaking the build). I think the original
failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::create): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::XMLDocumentParser::XMLDocumentParser):
14:50 Changeset [86382] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-12 Adam Barth <abarth@webkit.org>

This patch disables sheriffbot's bug postings. He's just been way too
spammy recently due to test flakiness.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
14:43 Changeset [86381] by dbates@webkit.org
  • 4 edits in trunk

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Fixes an issue where a platform mouse event corresponding to mouse button A
may be associated with the wrong WebCore mouse button when the event occurs
while pressing and holding a mouse button B, where A != B.

For example, a person clicks the middle mouse button while pressing and holding
the left mouse button. Then we dispatch the following DOM events: mouse down for
left button, mouse down for left button, mouse up for left button. But, we should
have dispatched: mouse down for left button, mouse down for middle button, mouse up
for middle button.

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventTypeAndMouseButtonFromQEvent): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventTypeAndMouseButtonFromQEvent() to determine the WebCore mouse event type and button from the platform-specific event.

2011-05-12 Daniel Bates <dbates@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
https://bugs.webkit.org/show_bug.cgi?id=58863

Remove test case fast/events/fire-mousedown-while-pressing-mouse-button.html
from the Skipped list since it now passes.

  • platform/qt/Skipped:
14:17 Changeset [86380] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2: Implement plugin quirk for Mozilla user agent for older Flash
https://bugs.webkit.org/show_bug.cgi?id=60726
<rdar://problem/8470824>

Reviewed by Adam Roben.

Implement the quirk for versions of Flash before v10 that only request windowless plugins
if we use a Mozilla user agent.

  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:

(WebKit::NetscapePluginModule::determineQuirks): If we have a plugin that handles the

"application/x-shockwave-flash" MIME type with a version less than 10, tell it to use
the Mozilla user agent.

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent): Add an early return if the plugin uses the Mozilla user

agent.

  • win/WebKit2.vcproj: Add PluginQuirks.h.
14:13 Changeset [86379] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-12 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

PluginView::invalidateRect doesn't work for transformed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=60727
<rdar://problem/9331244>

Ask the RenderObject to repaint the plug-in instead of using invalidateContentsAndWindow.
This matches what we do in WebKit1.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::invalidateRect):
14:12 Changeset [86378] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
14:05 Changeset [86377] by leviw@chromium.org
  • 15 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintMask and paintMaskImages off of ints
https://bugs.webkit.org/show_bug.cgi?id=60578

Primarily switching paintMask and paintMaskImages to use IntSize and IntRect respectively.
In the process of that:

  • added an "expand" function to IntRect that allows you to add an IntSize or pair of integers to the size portion of an IntRect.
  • changed borderFitAdjust to take an IntRect. It modifies only the x and width attributes.

No new tests since this refactoring.

  • platform/graphics/IntRect.h: (WebCore::IntRect::expand): Added for convenience.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::borderFitAdjust):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBox.h: (WebCore::RenderBox::borderFitAdjust):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask):
  • rendering/RenderTableCell.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
13:56 Changeset [86376] by commit-queue@webkit.org
  • 37 edits
    1 copy
    55 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/execCommand tests that are working
https://bugs.webkit.org/show_bug.cgi?id=60717

Also based on digging of Zsolt Fehér.

  • platform/qt/Skipped:
  • platform/qt/editing/execCommand/4580583-1-expected.png: Added.
  • platform/qt/editing/execCommand/4580583-1-expected.txt:
  • platform/qt/editing/execCommand/4580583-2-expected.png: Added.
  • platform/qt/editing/execCommand/4580583-2-expected.txt:
  • platform/qt/editing/execCommand/4641880-1-expected.png: Added.
  • platform/qt/editing/execCommand/4641880-1-expected.txt:
  • platform/qt/editing/execCommand/4641880-2-expected.png: Added.
  • platform/qt/editing/execCommand/4641880-2-expected.txt:
  • platform/qt/editing/execCommand/4747450-expected.png: Added.
  • platform/qt/editing/execCommand/4747450-expected.txt:
  • platform/qt/editing/execCommand/4786404-1-expected.png: Added.
  • platform/qt/editing/execCommand/4786404-2-expected.png: Added.
  • platform/qt/editing/execCommand/4916402-expected.png: Added.
  • platform/qt/editing/execCommand/4916402-expected.txt:
  • platform/qt/editing/execCommand/4916541-expected.png: Added.
  • platform/qt/editing/execCommand/4916541-expected.txt:
  • platform/qt/editing/execCommand/4924441-expected.png: Added.
  • platform/qt/editing/execCommand/4924441-expected.txt:
  • platform/qt/editing/execCommand/5049671-expected.png: Added.
  • platform/qt/editing/execCommand/5062376-expected.png: Added.
  • platform/qt/editing/execCommand/5062376-expected.txt:
  • platform/qt/editing/execCommand/5080333-1-expected.png: Added.
  • platform/qt/editing/execCommand/5080333-1-expected.txt:
  • platform/qt/editing/execCommand/5080333-2-expected.png: Added.
  • platform/qt/editing/execCommand/5080333-2-expected.txt:
  • platform/qt/editing/execCommand/5136770-expected.png: Added.
  • platform/qt/editing/execCommand/5136770-expected.txt:
  • platform/qt/editing/execCommand/5138441-expected.png: Added.
  • platform/qt/editing/execCommand/5138441-expected.txt:
  • platform/qt/editing/execCommand/5142012-1-expected.png: Added.
  • platform/qt/editing/execCommand/5142012-1-expected.txt:
  • platform/qt/editing/execCommand/5142012-2-expected.png: Added.
  • platform/qt/editing/execCommand/5142012-2-expected.txt:
  • platform/qt/editing/execCommand/5190926-expected.png: Added.
  • platform/qt/editing/execCommand/5190926-expected.txt:
  • platform/qt/editing/execCommand/5481523-expected.png: Added.
  • platform/qt/editing/execCommand/5481523-expected.txt: Added.
  • platform/qt/editing/execCommand/5482023-expected.png: Added.
  • platform/qt/editing/execCommand/5482023-expected.txt: Added.
  • platform/qt/editing/execCommand/5569741-expected.png: Added.
  • platform/qt/editing/execCommand/5569741-expected.txt: Added.
  • platform/qt/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/qt/editing/execCommand/find-after-replace-expected.png: Added.
  • platform/qt/editing/execCommand/find-after-replace-expected.txt:
  • platform/qt/editing/execCommand/findString-2-expected.png: Added.
  • platform/qt/editing/execCommand/findString-2-expected.txt:
  • platform/qt/editing/execCommand/findString-expected.png: Added.
  • platform/qt/editing/execCommand/findString-expected.txt:
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.png: Added.
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
  • platform/qt/editing/execCommand/indent-empty-root-expected.png: Added.
  • platform/qt/editing/execCommand/indent-empty-root-expected.txt:
  • platform/qt/editing/execCommand/indent-list-item-expected.png: Added.
  • platform/qt/editing/execCommand/indent-list-item-expected.txt:
  • platform/qt/editing/execCommand/indent-selection-expected.png: Added.
  • platform/qt/editing/execCommand/indent-selection-expected.txt:
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
  • platform/qt/editing/execCommand/insert-list-with-id-expected.png: Added.
  • platform/qt/editing/execCommand/insert-list-with-id-expected.txt:
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/qt/editing/execCommand/insertImage-expected.png: Added.
  • platform/qt/editing/execCommand/insertImage-expected.txt:
  • platform/qt/editing/execCommand/nsresponder-indent-expected.png: Added.
  • platform/qt/editing/execCommand/nsresponder-indent-expected.txt: Added.
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.png: Added.
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test1-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test2-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test3-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test4-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
  • platform/qt/editing/execCommand/outdent-selection-expected.png: Added.
  • platform/qt/editing/execCommand/outdent-selection-expected.txt:
  • platform/qt/editing/execCommand/paste-1-expected.png: Added.
  • platform/qt/editing/execCommand/paste-1-expected.txt:
  • platform/qt/editing/execCommand/paste-2-expected.png: Added.
  • platform/qt/editing/execCommand/paste-2-expected.txt:
  • platform/qt/editing/execCommand/print-expected.png: Added.
  • platform/qt/editing/execCommand/print-expected.txt:
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png: Added.
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
  • platform/qt/editing/execCommand/remove-list-item-1-expected.png: Added.
  • platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
  • platform/qt/editing/execCommand/selectAll-expected.png: Added.
  • platform/qt/editing/execCommand/selectAll-expected.txt:
13:50 Changeset [86375] by paroga@webkit.org
  • 12 edits in trunk/Source/WebCore

2011-05-12 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

SimpleFontData::scaledFontData should return a PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60657

Let scaledFontData return a PassOwnPtr instead of a raw pointer
to make SimpleFontData build without LOOSE_PASS_OWN_PTR.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::scaledFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::scaledFontData):
13:39 Changeset [86374] by commit-queue@webkit.org
  • 9 edits
    15 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/pasteboard tests that are working
https://bugs.webkit.org/show_bug.cgi?id=60707

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/4076267-2-expected.png: Added.
  • platform/qt/editing/pasteboard/4076267-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4076267-expected.png: Added.
  • platform/qt/editing/pasteboard/4076267-expected.txt: Added.
  • platform/qt/editing/pasteboard/4806874-expected.png: Added.
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/5387578-expected.png: Added.
  • platform/qt/editing/pasteboard/5387578-expected.txt:
  • platform/qt/editing/pasteboard/bad-placeholder-expected.png: Added.
  • platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png: Added.
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-008-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-text-008-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-008-expected.png: Added.
  • platform/qt/editing/pasteboard/smart-paste-008-expected.txt: Added.
13:05 Changeset [86373] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
13:01 Changeset [86372] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
12:14 Changeset [86371] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failure when requesting that storage be deleted for an origin without storage.
https://bugs.webkit.org/show_bug.cgi?id=60709

Reviewed by Darin Adler.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::syncDeleteOrigin):
If the path to the storage location for the givin origin is empty, return early instead of
asserting.

12:12 Changeset [86370] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Add option to unconditionally enable/disable a feature
https://bugs.webkit.org/show_bug.cgi?id=60643

Create an argument to be used in WEBKIT_FEATURE macro, allowing a port
to enable a feature without showing to user that it can be disabled.
This is useful if a port needs an option to be always ON/OFF and
changing it will break the build.

This way it's possible to add mandatory features to each port without
touching the cmakeconfig.cmake file.

  • Source/cmake/WebKitFeatures.cmake:
12:10 Changeset [86369] by jberlin@webkit.org
  • 7 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Darin Adler.

Source/WebCore:

Make sure any Private Browsing session is based off the default session.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

Source/WebKit2:

Properly handle the case where there is no serialized default storage session by not trying
to encode or decode 0, while still making sure to decode any valid storage session.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
Only encode the storage session if there is one to encode.
(WebKit::WebProcessCreationParameters::decode):
Only decode the storage session there is one to decode.

  • Shared/WebProcessCreationParameters.h:

WebKitLibraries:

Update WKSI with the changes to wkCreatePrivateStorageSession.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:53 Changeset [86368] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for Chromium.

  • platform/chromium/test_expectations.txt:
11:45 Changeset [86367] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for chromium.

  • platform/chromium/test_expectations.txt:
11:34 Changeset [86366] by jeffm@apple.com
  • 2 edits in trunk/Source/ThirdParty

Ignore Visual Studio *.user files.

  • gtest/msvc: Added property svn:ignore.
11:33 Changeset [86365] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
https://bugs.webkit.org/show_bug.cgi?id=15479

Finally remove resolveStyle, it is not used anymore.

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
11:29 Changeset [86364] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r65868): createContextualFragment does not work with <style>
https://bugs.webkit.org/show_bug.cgi?id=60155

These test results match Firefox.

  • fast/parser/style-in-create-contextual-fragment-expected.txt: Added.
  • fast/parser/style-in-create-contextual-fragment-head-expected.txt: Added.
  • fast/parser/style-in-create-contextual-fragment-head.html: Added.
  • fast/parser/style-in-create-contextual-fragment.html: Added.

2011-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r65868): createContextualFragment does not work with <style>
https://bugs.webkit.org/show_bug.cgi?id=60155

createContextualFragment doesn't have a spec, so it's hard to tell what
we're supposed to do exactly. This patch appears to make our behavior
more like Firefox and should fix the compat issue with this site.

Tests: fast/parser/style-in-create-contextual-fragment-head.html

fast/parser/style-in-create-contextual-fragment.html

  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
11:28 Changeset [86363] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-12 David Grogan <dgrogan@chromium.org>

Reviewed by Nate Chapin.

IndexedDB: fix up database-quota.html layout test
https://bugs.webkit.org/show_bug.cgi?id=60519

Remove commitAndContinue idiom; translate some missed instances of
event.code to event.target.errorCode from bug 54331

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
11:25 Changeset [86362] by jam@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h

Fix mismatched virtual function from previous checkin

11:24 Changeset [86361] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-12 Martin Robinson <mrobinson@igalia.com>

Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
bot which appears to be more sensitive to timing issues than the
other bots.

  • tests/testwebview.c: Add another short pause waiting for adjustments to update.
11:21 Changeset [86360] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit inserts base, link, meta, style, and title elements into an editable region
when pasting table cells from Excel
https://bugs.webkit.org/show_bug.cgi?id=60644

Added a test to ensure WebKit strips the said elements prior to inserting HTML.

  • editing/pasteboard/paste-head-contents-expected.txt: Added.
  • editing/pasteboard/paste-head-contents.html: Added.

2011-05-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit inserts base, link, meta, style, and title elements into an editable region
when pasting table cells from Excel
https://bugs.webkit.org/show_bug.cgi?id=60644

Strip base, link, meta, style, and tile elements from the fragment to be pasted prior
to the merge. We don't have to strip these elements in performTrivialReplace because
the function only handles a fragment that consists of exactly one text node.

Test: editing/pasteboard/paste-head-contents.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::removeHeadContents): Added. (WebCore::ReplaceSelectionCommand::doApply): Calls removeHeadContents before handing style spans.
11:06 Changeset [86359] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-12 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Switch calculateBackgroundImageGeometry to use IntRect
https://bugs.webkit.org/show_bug.cgi?id=60671

Replacing the four ints passed into calculateBackgroundImageGeometry with an IntRect.

No new tests since this is just refactoring.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h:
10:56 Changeset [86358] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

2011-05-08 Abhishek Arya <inferno@chromium.org> and Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

  • fast/css/counters/element-removal-crash-expected.txt: Added.
  • fast/css/counters/element-removal-crash.xhtml: Added.
10:35 Changeset [86357] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk/LayoutTests

2011-05-12 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

Rebaseline editing/inserting tests that work
https://bugs.webkit.org/show_bug.cgi?id=60702

  • platform/qt/Skipped:
  • platform/qt/editing/inserting/4278698-expected.png: Added.
  • platform/qt/editing/inserting/4278698-expected.txt:
  • platform/qt/editing/inserting/editable-html-element-expected.png: Added.
  • platform/qt/editing/inserting/editable-html-element-expected.txt:
  • platform/qt/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/qt/editing/inserting/editing-empty-divs-expected.txt:
  • platform/qt/editing/inserting/insert-div-023-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-023-expected.txt:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.png: Added.
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Added.
10:33 Changeset [86356] by jam@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

2011-05-11 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Make openFileSystem check for permission first
https://bugs.webkit.org/show_bug.cgi?id=60683

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::allowFileSystem):
  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowFileSystem):
  • src/LocalFileSystemChromium.cpp: (WebCore::openFileSystemNotAllowed): (WebCore::openFileSystemHelper):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::allowFileSystem):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowFileSystem):
10:19 Changeset [86355] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Merge ApplyPropertyExpanding and ApplyPropertyExpandingSuppressValue classes using template.
https://bugs.webkit.org/show_bug.cgi?id=60691

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyExpanding::applyValue): Use new template parameter to early exit if needed. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Specify template parameters for ApplyPropertyExpanding.
10:07 Changeset [86354] by bweinstein@apple.com
  • 10 edits
    3 adds in trunk

Source/WebKit2: After relaunching an unresponsive web process, web page stops responding to mouse movement
https://bugs.webkit.org/show_bug.cgi?id=60669
<rdar://problem/9409934>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash): Set m_processingMouseMoveEvent to false when the WebProcess

crashes.

Tools: After relaunching an unresponsive web process, web page stops responding to mouse movement
https://bugs.webkit.org/show_bug.cgi?id=60669
<rdar://problem/9409934>

Reviewed by Anders Carlsson.

This test follows the steps needed to reproduce this bug:
1) Hang the web process
2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3) Kill and restart the WebProcess
4) Move the mouse

We are testing that we receive mouse move events after the WebProcess has restarted.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
(TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
(TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.

(TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
(TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):

  • TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.

Add new files.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:
10:03 Changeset [86353] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-12 Simon Fraser <simon.fraser@apple.com>

Followup to r86351; give the vectors some inline capacity
to avoid heap allocations in most cases.

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
09:57 Changeset [86352] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-05-12 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
https://bugs.webkit.org/show_bug.cgi?id=59941

Improve test to not need a click. Offer a stroke-opacity variant as well.

  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.txt:
  • platform/mac/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/mac/svg/custom/stroke-opacity-update-expected.txt: Added.
  • svg/custom/fill-opacity-update.svg:
  • svg/custom/stroke-opacity-update.svg: Added.
09:38 Changeset [86351] by simon.fraser@apple.com
  • 5 edits
    2 adds in trunk

2011-05-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Mismatched multiple box-shadows do not transition as expected
https://bugs.webkit.org/show_bug.cgi?id=60137

When animating between two sets of shadows of different lengths, we need
to walk the ShadowData list backwards, since it stores the shadows in
reverse order relative to the CSS (so that painting is back-to-front).

This progresses the behavior of the transitions/multiple-shadow-transitions.html
test, which is given new expected results.

Test: transitions/mismatched-shadow-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::shadowListLength): Utility to walk the list of ShadowData and count the number of shadows. (WebCore::shadowForBlending): Return a ShadowData* that is useful as a blending target, based on the shadow type, and whether it's a -webkit-box-shadow. (WebCore::PropertyWrapperShadow::blend): Call one of the specialized blend methods. (WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists): Fast path for shadow blending, when the list lengths match, or both are single or null shadows. (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists): Slower path that builds vectors for each list to reverse them.
09:11 Changeset [86350] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
09:03 Changeset [86349] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-12 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Added initialization/shutdown for ecore_file library
https://bugs.webkit.org/show_bug.cgi?id=60457

Added initialization and shuthown for ecore_file library and replaced
realpath function to ecore_file_realpath.

  • EWebLauncher/main.c: (quit): (findThemePath): (main):
09:02 Changeset [86348] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
08:45 Changeset [86347] by aroben@apple.com
  • 2 edits in trunk/Source/ThirdParty

Windows production build fix

  • gtest/msvc/gtest-md.vcproj: Fix the OutputDirectory and IntermediateDirectory attributes

for all configurations.

08:41 Changeset [86346] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Fixed typo.

  • platform/chromium/test_expectations.txt:
08:40 Changeset [86345] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium expectations.

  • platform/chromium/test_expectations.txt:
08:33 Changeset [86344] by philn@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/gtk/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/gtk/fast/borders/outline-alpha-block-expected.txt: Added.
  • platform/gtk/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/gtk/fast/borders/outline-alpha-inline-expected.txt: Added.
  • platform/gtk/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/gtk/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • platform/gtk/svg/custom/fill-opacity-update-expected.png: Added.
  • platform/gtk/svg/custom/fill-opacity-update-expected.txt: Added.
08:19 Changeset [86343] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted WinCairo build fix after r86169, part II

  • platform/network/curl/CredentialStorageCurl.cpp: Added a missing #include.
08:08 Changeset [86342] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-12 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium GPU suppressions.

  • platform/chromium/test_expectations.txt:
08:03 Changeset [86341] by aroben@apple.com
  • 4 edits in trunk/LayoutTests

Update Windows results after r86315

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
07:46 Changeset [86340] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Fix linker warnings in Production builds

  • WebCore.vcproj/WebCore.vcproj: Exclude JSSVGFEDropShadowElement.cpp from the build in the

Production configuration, just like in the other configurations. Let VS resort some files
(again).

07:36 Changeset [86339] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Roben.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555

Follow-up fix for the 3 editing/deleting tests crashing on GTK,
Leopard and Windows XP. Don't create the Range if the start of the
selection has no next position.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
07:20 Changeset [86338] by aroben@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

Attempted WinCairo build fix after r86169

  • WebCore.vcproj/WebCore.vcproj: Added CredentialStorageCurl.cpp. Also let VS do what it

wants.

  • platform/network/curl/CredentialStorageCurl.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage): Stubbed out.

07:13 Changeset [86337] by aroben@apple.com
  • 3 edits in trunk/Source/WebCore

Build fixes after r86325

  • editing/SpellingCorrectionController.cpp:
  • editing/SpellingCorrectionController.h:

Added missing declarations/#includes.

07:10 Changeset [86336] by aroben@apple.com
  • 3 edits
    1 add in trunk/Source

A little gtest cleanup after r86287

Source/ThirdParty:

  • gtest/msvc/gtest-md.vcproj: Added Debug_All and Production configurations to match our

other projects. (At some point all the settings should be moved into .vsprops files to match
our other projects, too.)

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:
    • Move gtest into the Tools folder
    • Make gtest build just before TestWebKitAPIGenerated
    • Use gtest's new Debug_All and Production configurations as appropriate
06:58 Changeset [86335] by zimmermann@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works.

06:51 Changeset [86334] by zimmermann@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before.

06:49 Changeset [86333] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::listDirectory):
06:30 Changeset [86332] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/

  • html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData):
05:32 Changeset [86331] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-12 Rob Buis <rwlbuis@gmail.com>

Reviewed by Eric Seidel.

REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
https://bugs.webkit.org/show_bug.cgi?id=59941

Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.

Test: svg/custom/fill-opacity-update.svg

  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
05:07 Changeset [86330] by zimmermann@webkit.org
  • 33 edits
    1 add in trunk/Source

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator.
Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary
object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting
N strings using operator+, this leads to N-1 reallocations.

Replace this with a flexible operator+ implementation, that avoids these reallocations.
When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..)
a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays
creation of the final string, until operator String() is invoked.

template<typename T>
StringAppend<String, T> operator+(const String& string1, T string2)
{

return StringAppend<String, T>(string1, string2);

}

template<typename U, typename V, typename W>
StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2)
{

return StringAppend<U, StringAppend<V, W> >(string1, string2);

}

When concatting three strings - "String a, b, c; String result = a + b + c;" following happens:
first a StringAppend<String, String> object is created by operator+(const String& string1, String string2).
Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns
a StringAppend<String, StringAppend<String, String> > object.
Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the
final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us
against too big string allocations, etc.

Note that the second template, defines a recursive way to concat an arbitary number of strings
into a single String with just one allocation.

  • GNUmakefile.list.am: Add StringOperators.h to build.
  • JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols.
  • JavaScriptCore.gypi: Add StringOperators.h to build.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file.
  • wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file.
  • wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file. (WTF::StringAppend::StringAppend): (WTF::StringAppend::operator String): (WTF::StringAppend::operator AtomicString): (WTF::StringAppend::writeTo): (WTF::StringAppend::length): (WTF::operator+):
  • wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append(). (WTF::emptyString): Add new shared empty string free function.
  • wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file.

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::handleElementAttributes):
  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::search):
  • html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData):
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • page/Location.cpp: (WebCore::Location::search): (WebCore::Location::hash):
  • page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::copyCFStreamDescription):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::search): (WebCore::WorkerLocation::hash):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type.
  • src/WebHTTPLoadInfo.cpp: (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first.
  • tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+. (IDBLevelDBCoding::TEST):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):

2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

  • AccessibleBase.cpp: (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
04:15 Changeset [86329] by commit-queue@webkit.org
  • 6 edits in trunk

2011-05-12 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=60367

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::layerTreeAsText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement layoutTestController.layerTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=60367

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:51 Changeset [86328] by yurys@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that eval can access scoped variables in console
https://bugs.webkit.org/show_bug.cgi?id=60547

  • inspector/console/console-eval-scoped-expected.txt: Added.
  • inspector/console/console-eval-scoped.html: Added.
03:48 Changeset [86327] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-05-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move agents from InspectorAgent to InspectorController
https://bugs.webkit.org/show_bug.cgi?id=60359

All inspector agents are now created and owned by InspectorController which
in turned is owned by the inspected Page. InspectorInstrumentation gets access
to the instrumenting agents by means of InspectorAgent::instrumentingAgents().

In addition to managing inspector agents lifetime InspectorController sets
InspectorFronted on the agents when the front-end is connected.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::clearFrontend):
  • inspector/InspectorAgent.h: all accessors to other agents were removed along with the agents themselves from InspectorAgent. Every agent that depends on some other agents receives pointers to them explicitely in its constructor. All access to the agents from WebCore should go through InspectorInstrumentation which retrieves corresponding agents using InstrumentingAgents structure which represents the set of active agents. (WebCore::InspectorAgent::instrumentingAgents):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::highlightedNode): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::resume):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  • page/Page.cpp: (WebCore::Page::~Page): we send two notifications when inspected Page is being destroyed: one to the inspector instrumentation and another one to the InspectorController which is owned by the Page.
03:38 Changeset [86326] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Tony Gentilcore <tonyg@chromium.org>

Build fix: include ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=60694

  • dom/Range.cpp:
03:31 Changeset [86325] by tonyg@chromium.org
  • 80 edits in trunk/Source

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • dom/DocumentMarkerController.cpp:
  • dom/Position.cpp:
  • dom/PositionIterator.cpp:
  • dom/Range.cpp:
  • editing/ApplyBlockElementCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • editing/FrameSelection.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/IndentOutdentCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SpellChecker.h:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SpellingCorrectionController.h:
  • editing/TextCheckingHelper.cpp:
  • editing/TextIterator.h:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • editing/visible_units.cpp:
  • editing/visible_units.h:
  • fileapi/DOMFileSystem.cpp:
  • fileapi/DirectoryReaderSync.cpp:
  • fileapi/DirectoryReaderSync.h:
  • fileapi/FileEntry.h:
  • fileapi/FileWriter.h:
  • fileapi/FileWriterBase.h:
  • fileapi/FileWriterSync.h:
  • history/CachedFrame.cpp:
  • history/CachedPage.cpp:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • history/PageCache.h:
  • loader/HistoryController.h:
  • loader/PingLoader.h:
  • loader/ResourceLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedResourceRequest.cpp:
  • loader/cache/CachedResourceRequest.h:
  • loader/cache/MemoryCache.h:
  • notifications/Notification.cpp:
  • notifications/Notification.h:
  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/DOMSelection.cpp:
  • page/DOMTimer.h:
  • page/DOMWindow.cpp:
  • page/EventHandler.cpp:
  • page/FocusController.h:
  • page/Geolocation.cpp:
  • page/Geolocation.h:
  • page/History.cpp:
  • rendering/RenderListBox.cpp:
  • workers/WorkerContext.cpp:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • src/WebHistoryItem.cpp:
  • src/WebNotification.cpp:
  • src/WebTextCheckingCompletionImpl.cpp:
  • src/mac/WebSubstringUtil.mm:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • WebView/WebFrame.mm:

2011-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Perform some forward declarations suggested by include-what-you-use
https://bugs.webkit.org/show_bug.cgi?id=60545

  • WebProcess/WebPage/mac/WebPageMac.mm:
02:54 Changeset [86324] by ossy@webkit.org
  • 2 edits
    14 adds in trunk/LayoutTests

Add new expected files after r86313.

  • platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt-arm/transforms/svg-vs-css-expected.txt: Added.
  • platform/qt-mac/Skipped: Add plugins/get-targeted-javascript-url.html because of missing plugin.getURLNotify() implementation
  • platform/qt-mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt-mac/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt-mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt-mac/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt-mac/transforms/svg-vs-css-expected.txt: Added.
02:16 Changeset [86323] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r86307.

  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png:
01:14 Changeset [86322] by yutak@chromium.org
  • 5 edits in trunk/LayoutTests

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Qt test expectations affected in r86320.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
01:05 Changeset [86321] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed, another attempt of build fix.

  • websockets/CloseEvent.h:
  • websockets/CloseEvent.idl:
00:58 Changeset [86320] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Unreviewed, trying to fix Qt minimal compile.

  • websockets/CloseEvent.idl:
00:42 Changeset [86319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-12 ojab <ojab@ojab.ru>

Reviewed by Eric Seidel.

Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=60542

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
00:36 Changeset [86318] by philn@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix.

  • wtf/Platform.h:
00:32 Changeset [86317] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-05-12 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Fix the build with ENABLE_PLUGIN_PROCESS
https://bugs.webkit.org/show_bug.cgi?id=60628

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Move the call to pluginController->isAcceleratedCompositingEnabled() to a #ifdef block.
  • WebProcess/Plugins/PluginProxy.h: Add include for <WebCore/IntRect.h>.
00:31 Changeset [86316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-12 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Arm debug build failing on ARMAssembler::debugOffset()
https://bugs.webkit.org/show_bug.cgi?id=60688

Related to svn rev 85523

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::debugOffset):
00:06 Changeset [86315] by yutak@chromium.org
  • 22 edits
    4 adds in trunk

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket add new event: CloseEvent
https://bugs.webkit.org/show_bug.cgi?id=35573

Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
I modified the test close-event.html slightly so that it passes on Chromium.
I also updated a few test results that are affected by this change.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt: Added.
  • http/tests/websocket/tests/close-event.html: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:

2011-05-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket add new event: CloseEvent
https://bugs.webkit.org/show_bug.cgi?id=35573

Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
I added CloseEvent constructor to DOMWindow, so it can be referred
in the new test (close-event.html).

Test: http/tests/websocket/tests/close-event.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isCloseEvent):
  • dom/Event.h:
  • page/DOMWindow.idl: Add CloseEvent constructor.
  • websockets/CloseEvent.h: Added. (WebCore::CloseEvent::isCloseEvent): (WebCore::CloseEvent::create): (WebCore::CloseEvent::initCloseEvent): (WebCore::CloseEvent::wasClean): (WebCore::CloseEvent::CloseEvent):
  • websockets/CloseEvent.idl: Added.
  • websockets/WebSocket.cpp: (WebCore::WebSocket::didClose):
00:04 Changeset [86314] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

  • fast/borders/outline-alpha-block.html: Added.
  • fast/borders/outline-alpha-inline.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/mac/fast/borders/outline-alpha-block-expected.txt: Added.
  • platform/mac/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/mac/fast/borders/outline-alpha-inline-expected.txt: Added.
  • platform/mac/fast/box-shadow/box-shadow-radius-expected.png: Rebaselined as this test had rgba outlines.
  • platform/mac/fast/layers/self-painting-outline-expected.png: Rebaselined as this test had rgba outlines.

2011-05-12 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

RGBA colors in outlines show overpainting at the corners
https://bugs.webkit.org/show_bug.cgi?id=58999

Tests: fast/borders/outline-alpha-block.html

fast/borders/outline-alpha-inline.html

Updated baseline images for tests with rgba outlines:

fast/box-shadow/box-shadow-radius.html
fast/layers/self-painting-outline.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):

05/11/11:

23:00 Changeset [86313] by commit-queue@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

2011-05-11 Srinivasulu Chereddy <Srinivasulu.Chereddy@nokia.com>

Reviewed by Eric Seidel.

[Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list
https://bugs.webkit.org/show_bug.cgi?id=60654

  • platform/qt/Skipped:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added.
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added.
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/qt/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.png: Added.
  • platform/qt/transforms/no_transform_hit_testing-expected.txt: Added.
  • platform/qt/transforms/svg-vs-css-expected.png: Added.
  • platform/qt/transforms/svg-vs-css-expected.txt: Added.
22:45 Changeset [86312] by leviw@chromium.org
  • 5 edits in trunk/Source

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

No new tests as this is a simple rename

  • page/FrameView.cpp: (WebCore::FrameView::create):
  • platform/Widget.h: (WebCore::Widget::location): (WebCore::Widget::resize):

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Rename Widget::pos()
https://bugs.webkit.org/show_bug.cgi?id=60575

Renaming Widget::pos() to the more-descriptive location().

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
22:40 Changeset [86311] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

  • editing/pasteboard/paste-removing-iframe-expected.txt: Added.
  • editing/pasteboard/paste-removing-iframe.html: Added.
  • editing/pasteboard/resources/paste-removing-iframe-child.html: Added.

2011-05-10 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Crashes if the document inside iframe is removed during pasting some text into it.
https://bugs.webkit.org/show_bug.cgi?id=60534

Added missing null check.

Test: editing/pasteboard/paste-removing-iframe.html

  • editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection):
22:35 Changeset [86310] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Brian Salomon <bsalomon@google.com>

Reviewed by Eric Seidel.

Handle case when GrContext creation fails
https://bugs.webkit.org/show_bug.cgi?id=60410

Exercised by all canvas tests when DRT is run with skia-gpu

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext):
22:31 Changeset [86309] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Pratik Solanki <psolanki@apple.com>

Reviewed by Andreas Kling.

Remove empty class CallbackGuard
https://bugs.webkit.org/show_bug.cgi?id=60610

CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
22:13 Changeset [86308] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60609

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations.
22:09 Changeset [86307] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2011-05-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Some elements in meter-styles.html are hiding its content part with non-content-area.
https://bugs.webkit.org/show_bug.cgi?id=58149

  • Resized the border and padding values
  • Gave "-webkit-appearance: none" to test that is intended to be painted using shadows.
  • fast/dom/HTMLMeterElement/meter-styles.html:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
21:48 Changeset [86306] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Implement more clipping functions for wxWebKit.

https://bugs.webkit.org/show_bug.cgi?id=60662

20:55 Changeset [86305] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • WebCore.exp.in: Export restoreScrollPositionAndViewState()

2011-05-11 Damian Kaleta <dkaleta@apple.com>

Reviewed by Brady Eidson.

Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history
https://bugs.webkit.org/show_bug.cgi?id=60674

  • UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
20:38 Changeset [86304] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-11 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

WebKit does not build with GCCE
https://bugs.webkit.org/show_bug.cgi?id=60667

Allow compile WebKit with GCCE

  • wtf/Alignment.h:
  • wtf/Platform.h:
20:17 Changeset [86303] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFillLayer and its progeny to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60596

Changing integers passed into paintFillLayer and other derivatives to IntRects
and IntSizes that reflect their function.

No new tests since this is just refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
19:53 Changeset [86302] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable strict PassOwnPtr on Mac
https://bugs.webkit.org/show_bug.cgi?id=60684

This should build cleanly now.

  • wtf/PassOwnPtr.h:
19:16 Changeset [86301] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Use mapTexSubImage2D for tile uploads if available
https://bugs.webkit.org/show_bug.cgi?id=60008

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
  • platform/graphics/chromium/LayerTilerChromium.h:
18:26 Changeset [86300] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Protect JSC from WebCore executing JS during JS wrapper finalization
https://bugs.webkit.org/show_bug.cgi?id=60672
<rdar://problem/9350997>

Detect when we're trying to execute JS during GC and prevent the
execution from happening. We also assert that this isn't happening
as it implies incorrect behaviour of an object's destructor.

  • JavaScriptCore.exp:
  • heap/Heap.cpp:
  • heap/Heap.h: (JSC::Heap::isBusy):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy):
18:20 Changeset [86299] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implements a disable appearance for Media Elements of Qt port.
https://bugs.webkit.org/show_bug.cgi?id=60561

Implements a disable appearance for the media controls of the Qt port
when the media is not yet available.

  • platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb):
18:18 Changeset [86298] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

  • fast/forms/resources/ValidityState-typeMismatch-email.js:
  • fast/forms/ValidityState-typeMismatch-email-expected.txt:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

input type=email is too strict
https://bugs.webkit.org/show_bug.cgi?id=55988

Follow the updated specification.

  • html/EmailInputType.cpp: Update the pattern to allow a domain part without periods.
18:11 Changeset [86297] by cdn@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Cris Neckar <cdn@chromium.org>

Reviewed by David Levin.

Adding Cris Neckar to the Webkit Security Group site.
https://bugs.webkit.org/show_bug.cgi?id=60668

  • security/security-group-members.html:
17:58 Changeset [86296] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

WebKit2 doesn't build on Mac with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60655

  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership.
17:54 Changeset [86295] by jpu@apple.com
  • 19 edits
    3 adds in trunk

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

See WebCore/ChangeLog for detail.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
  • platform/mac/editing/spelling/delete-autocorrected-word-2.html: Added.

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection persists after deleting and retyping the same word at same location.
https://bugs.webkit.org/show_bug.cgi?id=60555
<rdar://problem/9373915>

This patch intends to alleviate the issue of repetitively applying the same autocorrection
when user delete and retype the same word at the same location. This scenario is especially
common when autocorrection modifies the first letter of the word.

This patch consists following major changes:

  1. Added a new marker type, DeletedAutocorrection. This marker is added to the whitespace that precedes a deleted autocorrection. If the user later types the same original word at after this whitespace, the autocorrection will not be applied again.
  2. In DeleteSelectionCommand, added code to notify SpellingCorrectionController about the autocorrection that has just been deleted.
  3. In Editor and SpellingCorrectionController, added code to apply the marker and to suppress autocorrection when necessary.
  4. The change in CompositeEditCommand::replaceTextInNode is necessary for preserving markers. Otherwise, we will loose the DeletedAutocorrection on the whitespace, when inserting text after the whitespace.

Test: platform/mac/editing/spelling/delete-autocorrected-word-2.html

  • dom/DocumentMarker.h: Added new marker type DeletedAutocorrection. (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): Support querying multiple marker types.
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodeAndPreserveMarkers): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection): Extracting

the original string if we are deleting an autocorrection.

(WebCore::DeleteSelectionCommand::doApply): Notify editor about the deleted autocorrection and its position.

  • editing/DeleteSelectionCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Moved all logic of determining

when to suppress an autocorrection into SpellingCorrectionController.

(WebCore::Editor::deletedAutocorrectionAtPosition):

  • editing/Editor.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::deletedAutocorrectionAtPosition): (WebCore::SpellingCorrectionController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
  • editing/visible_units.cpp: (WebCore::isStartOfWord):
  • editing/visible_units.h:
  • manual-tests/autocorrection/spell-checking-after-reversion.html:
17:49 Changeset [86294] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Enable gc mark validation in temporarily in release builds
https://bugs.webkit.org/show_bug.cgi?id=60678

Make it easier to turn the gc mark validation on and off, and
temporarily turn it on for all builds.

  • heap/MarkStack.cpp:
  • heap/MarkStack.h: (JSC::MarkStack::append): (JSC::MarkStack::internalAppend):
  • runtime/WriteBarrier.h: (JSC::MarkStack::appendValues):
  • wtf/Platform.h:
17:45 Changeset [86293] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9414874> Layout unnecessarily interrupts smooth scrolling at msnbc.com
https://bugs.webkit.org/show_bug.cgi?id=60677

Reviewed by Darin Adler.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Only perform an immediate scroll, aborting any running
animation, if the new scroll offset computed here is different from the current scroll offset.

17:39 Changeset [86292] by tkent@chromium.org
  • 5 edits in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Add test cases and update the result.

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

<input pattern="1|10" value="10"> doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=60619

Fixes a bug that patternMismatch returns a wrong result if

  • a whole value matches to a pattern,
  • a sub-string of the value also matches to the pattern, and
  • the sub-string matching has priority.
  • html/BaseTextInputType.cpp: (WebCore::BaseTextInputType::patternMismatch): Enclose the specified pattern with ( and )$.
17:29 Changeset [86291] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by David Levin.

Prevented DOMFileSystemBase from imposing file naming restrictions on
external file systems.

https://bugs.webkit.org/show_bug.cgi?id=60583

There are no new tests for this change since it requires the presence
of external file system provider which is specific to the platform host
process. Chromium implementation will test this within its extension API
test suite.

  • fileapi/DOMFileSystemBase.cpp: (WebCore::pathToAbsolutePath): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory):
17:28 Changeset [86290] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
  • loader/ResourceLoadScheduler.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
17:17 Changeset [86289] by jcivelli@chromium.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-05-11 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding a Content-Type parser. This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=60637

(WebCore::ScriptController::disableEval):

  • platform/network/ContentTypeParser.cpp: Added.
  • platform/network/ContentTypeParser.h: Added.
17:04 Changeset [86288] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Teach validate-committer-lists how to validate committers bugzilla_email()
https://bugs.webkit.org/show_bug.cgi?id=60651

It turns out we currently have 9 committers with invalid values for their
bugzilla_email field (meaning we don't know what email is their bugzilla account).
"Alexander Kellett" <lypanov@mac.com>
"Andre Boule" <aboule@apple.com>
"Cameron McCormack" <cam@webkit.org>
"Chris Petersen" <cpetersen@apple.com>
"Eli Fidler" <eli@staikos.net>
"Matt Lilek" <webkit@mattlilek.com>
"Pierre d'Herbemont" <pdherbemont@free.fr>
"Scott Violet" <sky@chromium.org>
"Adam Treat" <treat@kde.org>

Most of those haven't committed in a very long time, so it's not suprising
that we haven't noticed that their bugzilla emails are bogus.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
16:52 Changeset [86287] by levin@chromium.org
  • 16 edits
    1 add in trunk

https://bugs.webkit.org/show_bug.cgi?id=59561
Switch TestWebKitAPI to GTest

Patch by Dmitry Lomov <dslomov@google.com> on 2011-05-11
Reviewed by David Levin.

Fixes Makefiles and WinCairo build as well

.:

  • Source/ThirdParty/gtest/README.WebKit:
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj:
  • Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
  • Source/ThirdParty/gtest/xcode/Makefile: Added.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.sln:

Tools:

  • Makefile:
  • Scripts/build-api-tests:
  • Scripts/run-api-tests:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/Test.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::runAllTests):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):

16:52 Changeset [86286] by ademar.reis@openbossa.org
  • 2 edits in trunk/Websites/webkit.org

2011-05-11 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Mark Rowe.

Update Qt/Nokia Security contacts
https://bugs.webkit.org/show_bug.cgi?id=60650

Ademar (me) replaced Simon as the release manager and primary security
contact for QtWebKit. See:
http://lists.webkit.org/mailman/private.cgi/webkit-security/2011-February/000584.html

  • security/security-group-members.html:
16:49 Changeset [86285] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Only encode the session parameter if it is valid.
(WebKit::WebProcessCreationParameters::decode):
Don't try to decode a null session data.

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
16:42 Changeset [86284] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Kilzer.

Remove wml directory from include lists
https://bugs.webkit.org/show_bug.cgi?id=60646

Remove wml dir from CMake, Autotools and qmake build systems since WML
was removed in r85256.

No new tests since no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pri:
16:28 Changeset [86283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Move EFL-specific file to CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=60642

Move file EFL-specific file to the CMakeListsEfl.txt file. This implies
having to include CMakeLists${PORT}.txt before the ADD_CUSTOM_COMMAND
calls, since they depend on lists that now may change inside a port
like WebCore_USER_AGENT_STYLE_SHEETS.

No new tests since no change in functionality.

  • CMakeLists.txt: remove css file specific to EFL port.
  • CMakeListsEfl.txt: move file here.
16:21 Changeset [86282] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Add Luke Macpherson to committers.py as a Contributor
https://bugs.webkit.org/show_bug.cgi?id=60639

  • Scripts/webkitpy/common/config/committers.py:
16:16 Changeset [86281] by jpu@apple.com
  • 6 edits in trunk/Source

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • WebCoreSupport/CorrectionPanel.h:
  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement):

2011-05-11 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

CorrectionPanel sometimes hangs in dismissSoon().
https://bugs.webkit.org/show_bug.cgi?id=60599
<rdar://problem/9313628>

Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
for condition checking.

  • UIProcess/mac/CorrectionPanel.h:
  • UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::CorrectionPanel): (WebKit::CorrectionPanel::show): (WebKit::CorrectionPanel::dismissSoon): (WebKit::CorrectionPanel::dismissInternal): (WebKit::CorrectionPanel::handleAcceptedReplacement):
16:09 Changeset [86280] by inferno@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

More rebaselines after r86261.

  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:58 Changeset [86279] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Return empty Favicon URL instead of default one when the frame isn't top level one
https://bugs.webkit.org/show_bug.cgi?id=60527
This issue was discovered by chromium browser test.

  • dom/Document.cpp: (WebCore::Document::setIconURL): Restored original logic which was inadvertently flipped by http://trac.webkit.org/changeset/85785.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): Restored original logic, the empty URL should be returned instead of default one. The client (at least chromium) may rely on the returned value to decided whether the favicon should be changed.
15:50 Changeset [86278] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

When a WebGL layer is dirtied outside of a requestAnimFrame callback, we need
to prevent WebGL from running too far ahead of the GPU process. The current
throttling mechanism relies on prepareTexture being called for every WebGL frame.
However, in a non-requestAnimFrame application, multiple frames might get created
before the compositor runs and calls prepareTexture on the surface.

To address this, we post a task that calls a special rate limiting GL extension on
the WebGL context after every WebGL "frame." When the compositor runs, it calls
prepareTexture as usual.

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::setIsAnimating): (WebCore::LayerRendererChromium::isAnimating):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromiumRateLimitTask::WebGLLayerChromiumRateLimitTask): (WebCore::WebGLLayerChromiumRateLimitTask::run): (WebCore::WebGLLayerChromiumRateLimitTask::cancel): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::~WebGLLayerChromium): (WebCore::WebGLLayerChromium::setTextureUpdated): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: (WebCore::WebGLLayerChromium::context):

2011-05-11 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Make throttling of WebGL based on webgl frames, not compositor frames
https://bugs.webkit.org/show_bug.cgi?id=60508

Tell LayerRendererChromium when the requestAnimFrame-callbacks are running.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
15:44 Changeset [86277] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-11 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaselines after r86261.

  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
15:11 Changeset [86276] by noam.rosenthal@nokia.com
  • 19 edits in trunk/Source

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).

  1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
  2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
  3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
  • Api/qwebframe.cpp: (QWebFramePrivate::renderCompositedLayers):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::attachRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::scroll): (WebCore::TextureMapperNodeClientQt::setTextureMapper): (WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt): (WebCore::TextureMapperNodeClientQt::computeLastModifiedRect): (WebCore::TextureMapperNodeClientQt::syncRootLayer): (WebCore::TextureMapperNodeClientQt::rootNode): (WebCore::PageClientQWidget::setRootGraphicsLayer): (WebCore::PageClientQWidget::syncLayers): (WebCore::PageClientQWidget::~PageClientQWidget): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::syncLayersTimeout):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 12/12: Enable accelerated animations in texture-mapper. The entire interpolation
mechanism happens inside TextureMapper, and we interpolate right before we paint.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper): (WebCore::GraphicsLayerTextureMapper::syncCompositingState): (WebCore::GraphicsLayerTextureMapper::addAnimation): (WebCore::GraphicsLayerTextureMapper::pauseAnimation): (WebCore::GraphicsLayerTextureMapper::removeAnimation): (WebCore::GraphicsLayerTextureMapper::animationStartedTimerFired):
  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations): (WebCore::normalizedAnimationValue): (WebCore::TextureMapperNode::applyOpacityAnimation): (WebCore::solveEpsilon): (WebCore::solveCubicBezierFunction): (WebCore::solveStepsFunction): (WebCore::applyTimingFunction): (WebCore::TextureMapperNode::applyTransformAnimation): (WebCore::TextureMapperNode::applyAnimationFrame): (WebCore::TextureMapperNode::applyAnimation): (WebCore::TextureMapperNode::hasRunningOpacityAnimation): (WebCore::TextureMapperNode::hasRunningTransformAnimation): (WebCore::TextureMapperNode::syncAnimations): (WebCore::copyTimingFunction): (WebCore::copyAnimationValue): (WebCore::TextureMapperAnimation::TextureMapperAnimation):
  • platform/graphics/texmap/TextureMapperNode.h: (WebCore::TextureMapperAnimation::create):
14:58 Changeset [86275] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

No new tests as functionality is the same.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DBase):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):

2011-05-11 John Bauman <jbauman@chromium.org>

Reviewed by Kenneth Russell.

Don't send zeros in TexImage if GL implementation handles that
https://bugs.webkit.org/show_bug.cgi?id=60581

Chromium already handles zeroing textures upon creation, so don't
bother zeroing them in WebKit, as that causes some unnecessary memcpys
of zeros.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create):
14:53 Changeset [86274] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Attempt to fix Chromium Mac build.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
14:35 Changeset [86273] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

[Qt] Extract code to set mouse event modifiers into common function
https://bugs.webkit.org/show_bug.cgi?id=60649

Consolidate code to set the keyboard modifiers for a mouse event into a common
function that can be used by both PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount)
and PlatformMouseEvent(QInputEvent*, int clickCount) so as to remove duplicate code.

No functionality was changed. So, no new tests.

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::mouseEventModifiersFromQtKeyboardModifiers): Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventModifiersFromQtKeyboardModifiers().
14:33 Changeset [86272] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-05-11 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBoxModelObject::paintBorder to use IntRect instead of four ints
https://bugs.webkit.org/show_bug.cgi?id=60591

Switching RenderBoxModelObject::paintBorder to use IntRect instead of four ints representing a rect.

No new tests since there is no functionality change.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
14:25 Changeset [86271] by commit-queue@webkit.org
  • 17 edits in trunk

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • platform/network/ResourceHandle.h:
  • platform/network/cf/CookieStorageCFNet.cpp: (WebCore::currentCookieStorage): (WebCore::defaultCookieStorage):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::makeFinalRequest): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • WebView.cpp: (WebView::setCacheModel):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::decodeResourceRequest):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess):

2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660

REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
14:18 Changeset [86270] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Frequent crashes beneath WebCore::ScriptElement::prepareScript
https://bugs.webkit.org/show_bug.cgi?id=60559

Reviewed by Eric Seidel.

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::runScript):
Add null check and explanation that we are keeping the ASSERT to help
track down the cause and produce a test.

14:17 Changeset [86269] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 5/12: Implement the new TextureMapper functions for the Qt backend.
This allow non-rectangular clipping, some stub functions, and getting a unique
id for an image.

No new tests. Tests in LayoutTests/compositing cover this.

  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapperQt::beginClip): (WebCore::TextureMapperQt::endClip): (WebCore::TextureMapperQt::viewportSize): (WebCore::TextureMapperQt::setGraphicsContext): (WebCore::TextureMapperQt::graphicsContext): (WebCore::TextureMapperQt::drawTexture): (WebCore::TextureMapperQt::beginPainting): (WebCore::TextureMapperQt::endPainting): (WebCore::RGBA32PremultimpliedBufferQt::beginPaint): (WebCore::uidForImage):
  • platform/graphics/qt/TextureMapperQt.h:
14:14 Changeset [86268] by noam.rosenthal@nokia.com
  • 4 edits in trunk

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
attributes.

  • Api/qwebsettings.cpp: (qt_networkAccessAllowed): (QWebSettingsPrivate::apply):

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 4/12: Update the build script to enable 3D rendering by default for Qt.

  • Scripts/build-webkit:
14:11 Changeset [86267] by bweinstein@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r86161): WKPreferences API test failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=60658

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

14:09 Changeset [86266] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 3/12: TextureMapper shouldn't depend on OpenGL, but rather only allow the GL backend when
OpenGL is present.

No new tests. This is a build fix.

  • WebCore.pri:
  • WebCore.pro:
14:06 Changeset [86265] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 2/12: Add a few functions to the TextureMapper API, allowing:

  1. an entry/exit point for painting (beginPaint/endPaint)
  2. Clipping with a matrix, since we use stencil instead of scissors
  3. Draw a texture directly with an ID
  4. Remove offset, since we're using real tiling
  5. numberOfBytes calculation for textures, for memory management

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::destroy): (WebCore::BitmapTexture::allowOfflineTextureUpload): (WebCore::BitmapTexture::bpp): (WebCore::BitmapTexture::numberOfBytes): (WebCore::TextureMapper::viewportSize): (WebCore::TextureMapper::setViewportSize): (WebCore::TextureMapper::allowPartialUpdates): (WebCore::TextureMapper::isOpenGLBacked): (WebCore::TextureMapper::setTransform): (WebCore::TextureMapper::transform): (WebCore::TextureMapper::beginPainting): (WebCore::TextureMapper::endPainting):
14:02 Changeset [86264] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
https://bugs.webkit.org/show_bug.cgi?id=60439

Patch 1/12: Change the TextureMapperPlatformLayer API to allow a 3D-context or a
media player to decide how to paint into the TextureMapper, rather than mandate specific
types of platform layers.

No new tests. Tests in LayoutTests/compositing test this.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayer.h:
13:55 Changeset [86263] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

<rdar://problem/9331651> REGRESSION: RPRVT grows by 1MB / sec @ dvd2blu.com

Reviewed by Oliver Hunt.

SunSpider reports no change.

This bug was caused by changing Structure and Executable to being GC
objects, and by a long-standing bug that would thrash the global object
between dictionary and non-dictionary states.

  • runtime/BatchedTransitionOptimizer.h:

(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): Don't
eagerly transition to dictionary -- this can cause pathological dictionary
churn, and it's not necessary, since objects know how to automatically
transition to dictionary when necessary.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Be sure to report
extra cost from compilation, because it can be quite high. This is especially
important for program code, since DOM timers can repeatedly allocate
program code without allocating any other objects.

  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect): Don't transition to the uncacheable state
if the thing we're trying to remove doesn't exist. This can happen during
compilation, since the compiler needs to ensure that no pre-existing
conflicting definitions exist for certain declarations.

13:55 Changeset [86262] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Flesh out RenderLayer's ScrollableArea implementation a little more
https://bugs.webkit.org/show_bug.cgi?id=60593

Override a few more ScrollableArea methods on RenderLayer
as a baby-step towards animating overflow div scrolling.

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::visibleContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollPosition): (WebCore::RenderLayer::minimumScrollPosition): (WebCore::RenderLayer::maximumScrollPosition): (WebCore::RenderLayer::visibleContentRect): (WebCore::RenderLayer::overhangAmount): (WebCore::RenderLayer::didCompleteRubberBand):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::shouldSuspendScrollAnimations):
13:54 Changeset [86261] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/9421781> Slider thumb draws upside-down in WebKit2
<rdar://problem/9418025> Slider thumb has odd appearance

Fix two issues drawing the slider thumb.

To fix <rdar://problem/9421781>, if we detect that we're in WebKit2
by virtual of the FrameView not having a documentView, then flip
the graphics context.

To fix <rdar://problem/9418025>, we call -drawInteriorWithFrame:inView:
rather than -drawWithFrame:inView: so that AppKit doesn't draw a section
of track behind the thumb.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
13:54 Changeset [86260] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86087 - 2011-05-09 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSAuditor should be more selective about the <meta http-equivs> that it blocks
https://bugs.webkit.org/show_bug.cgi?id=60489

We don't need to filter most http-equiv attributes. This patch
introduces a blacklist for two that we probably do want to filter.
It's possible a whitelist would be more appropriate, but I'm inclined
to start with a blacklist and see how it works.

This patch will hopefully fix a false positive that is causing errors
with copy-and-pasted text in Gmail in some configurations (due to using
the <meta> tag to request UTF-8 encoding both in the pasted text and in
the page itself).

  • html/parser/XSSFilter.cpp: (WebCore::isNonCanonicalCharacter): (WebCore::canonicalize): (WebCore::isRequiredForInjection): (WebCore::hasName): (WebCore::findAttributeWithName): (WebCore::isNameOfInlineEventHandler): (WebCore::isDangerousHTTPEquiv):
    • This function is new in the patch and includes a blacklist of dangerous http-equivs. Many of the other functions listed here are just being moved from an anonymous namespace to use static for internal linkage.

(WebCore::containsJavaScriptURL):
(WebCore::decodeURL):
(WebCore::XSSFilter::eraseAttributeIfInjected):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7011006

13:30 Changeset [86259] by aroben@apple.com
  • 3 edits
    2 adds in trunk

Don't notify the plugin when a targeted javascript: URL request completes

This matches Mozilla and WebKit1.

Fixes <http://webkit.org/b/60568> <rdar://problem/8610657> REGRESSION (WebKit2): Flash
plugin doesn't appear on a hanes.com page

Test: plugins/get-targeted-javascript-url.html

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest): Don't call back to the plugin if the
request had a target.

LayoutTests:

Test what happens when a plugin makes a targeted javascript: request

  • plugins/get-targeted-javascript-url-expected.txt: Added.
  • plugins/get-targeted-javascript-url.html: Added.

(startTest): Tell the plugin to make two targeted javascript: requests. One calls a function
with a return value, the other calls a function with no return value.
(finishTest): Check that both functions were called, and that we either didn't get an
NPP_URLNotify call (like in Mozilla, WebKit1, and WebKit2), or got an NPP_URLNotify call
with NPRES_DONE (like in Chrome).

13:13 Changeset [86258] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-flaky test (video-layer-crash) from
the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=60634

  • platform/chromium/test_expectations.txt:
13:10 Changeset [86257] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make mark stack validation functions do something useful in a release build
https://bugs.webkit.org/show_bug.cgi?id=60645

Turn ASSERTs into actual if(...) CRASH(); statements.

  • heap/MarkStack.cpp: (JSC::MarkStack::validateValue):
13:08 Changeset [86256] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[SnowLeopard WebKit2 Tests] fast/frames/flattening/frameset-flattening-subframesets.html
flakey.
https://bugs.webkit.org/show_bug.cgi?id=60648

Add the test to the mac-wk2 Skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
12:51 Changeset [86255] by jberlin@webkit.org
  • 17 edits in trunk

[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a parameter for a serialized default storage session, used only on Windows.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

Take 3 after rolling out KB2465367 from my system.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
12:36 Changeset [86254] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try once more to fix the WinCairo build.

  • platform/graphics/cairo/CairoUtilities.h: Include GraphicsTypes.h with a relative include rather than a system include.
12:28 Changeset [86253] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix copy&paste error in comment.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): the value is stored in regT2, not regT1.
12:12 Changeset [86252] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
https://bugs.webkit.org/show_bug.cgi?id=60521

First steps towards making the results JSON all hierarchical.

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
12:03 Changeset [86251] by weinig@apple.com
  • 32 edits
    1 add in trunk/Source

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • Api/qwebelement.cpp:

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Stop including Console.h just to get Console enum types
https://bugs.webkit.org/show_bug.cgi?id=60607

Move MessageSource, MessageType and MessageLevel into its own
header and cleanup surrounding classes.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Proxy.cpp:
  • dom/ScriptExecutionContext.h:
  • html/HTMLFormElement.cpp:
  • html/parser/XSSFilter.cpp:
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/ChromeClient.h:
  • page/Console.cpp: (WebCore::Console::~Console):
  • page/Console.h:
  • page/ConsoleTypes.h: Added.
  • page/ContentSecurityPolicy.cpp:
  • page/Geolocation.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp:
12:00 Changeset [86250] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Removing now unnecessary Chromium suppressions.

  • platform/chromium/test_expectations.txt:
11:38 Changeset [86249] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

WebKit2 should tell app that is unresponsive in more cases
<rdar://problem/9110151>
https://bugs.webkit.org/show_bug.cgi?id=60608

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Invoke the responsiveness time when forcing a backing store update to catch the cases of activating tabs, resizing the window, etc.
11:35 Changeset [86248] by dglazkov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r85650.
http://trac.webkit.org/changeset/85650
https://bugs.webkit.org/show_bug.cgi?id=59983

Triggers m_numNodeListCaches > 0 assert in gc-heavy sites.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
11:10 Changeset [86247] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-11 Martin Robinson <mrobinson@igalia.com>

Try to fix the WinCairo build.

  • Shared/ShareableBitmap.h: Correctly include RefPtrCairo here and guard it with USE(CAIRO) instead of PLATFORM(CAIRO).
10:58 Changeset [86246] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Build fix, adding new LayoutTestController method stubs.

10:41 Changeset [86245] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Video track sometimes fails to draw.
https://bugs.webkit.org/show_bug.cgi?id=60635
<rdar://problem/9281951>

No new tests, covered by existing pixel tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Set display mode to "Unknown" to force a

recalculation, and media engine notification, the next time the state machine runs.

10:31 Changeset [86244] by aroben@apple.com
  • 6 edits in trunk/Source

WinCE build fixes for strict PassOwnPtr

Source/JavaScriptCore:

  • wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault): Use adoptPtr.

Source/WebCore:

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::clipBitmap):
Use nullptr instead of 0.

  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Keep LOOSE_PASS_OWN_PTR turned on for

this file until SimpleFontData::scaledFontData is dealt with on all platforms.

  • platform/text/wince/TextCodecWinCE.cpp:

(WebCore::newTextCodecWinCE): Use adoptPtr.

09:59 Changeset [86243] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

Unskip passed tests.

  • platform/qt/Skipped:

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
https://bugs.webkit.org/show_bug.cgi?id=60477

PlatformKeyboardEvent.m_text should be set to "\t" instead of leaving as null.
The value is checked at EventHandler.cpp:2527 (r86166).

Function keyTextForKeyEvent is partially implemented and can be enhanced in
a need-base.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
09:56 Changeset [86242] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Use case-insensitive comparisons when checking plugin filenames on Windows

Windows paths are nearly always case-insensitive.

I couldn't think of a good way to test this.

Fixes <http://webkit.org/b/60633> WebKit1 loads Windows Presentation Foundation plugin, but
should not

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::isPluginBlacklisted): Use equalIgnoringCase instead of == when
checking plugin filenames.

09:45 Changeset [86241] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r86228.

  • platform/qt-mac/Skipped: Add failing editing tets.
09:45 Changeset [86240] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=60631>
<rdar://problem/9420520>

Reviewed by Darin Adler.

WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation [60631]

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
Call clearPendingAPIRequestURL().

09:42 Changeset [86239] by zecke@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[MIPS] Fix compilation of the MIPS JIT

Include the MIPSAssembler.h first to indirectly include
AssemblerBuffer.h before the AbstractMacroAssembler.h. This
order is used for the ARM and X86 MacroAssembler*.h.

  • assembler/MacroAssemblerMIPS.h:
09:40 Changeset [86238] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Anton Muhin <antonnm@chromium.org>

Unreviewed.

Chromium suppressions.

  • platform/chromium/test_expectations.txt:
09:16 Changeset [86237] by aroben@apple.com
  • 6 edits in trunk/Source

Turn on strict PassOwnPtr on Windows

Fixes <http://webkit.org/b/60632> Windows should build with strict PassOwnPtr enabled

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

Source/WebCore:

  • platform/graphics/win/SimpleFontDataWin.cpp: Keep LOOSE_PASS_OWN_PTR turned on for this

file until SimpleFontData::scaledFontData is dealt with on all platforms.

Source/WebKit2:

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp:

(WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Use nullptr instead of 0.

09:06 Changeset [86236] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed update after r86230.

  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt-mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
09:05 Changeset [86235] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Some skipped editing tests actually work and just need rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=60469

Unskip some editing tests that actually work.

  • platform/qt/Skipped:
08:24 Changeset [86234] by jchaffraix@webkit.org
  • 11 edits
    9 adds in trunk

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

Tests for: XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

  • fast/xpath/xpath-result-eventlistener-crash-expected.txt: Added.
  • fast/xpath/xpath-result-eventlistener-crash.html: Added. Test that an event listener registered on an XPATH result snapshots' node does not crash. This case was already fixed prior to this change. However it is better to keep it as a regression test.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html: Added. Test that an XPath snapshot result keeps its node wrapper alive.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html: Added. Test that an XPath iterator result keeps its node wrapper alive.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt: Added.
  • fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html: Added. Test that other XPath result that holds nodes keeps their wrapper alive.

2011-05-11 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Geoffrey Garen.

XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

The change added a custom mark function for JSC. V8 was already properly
marking the nodes so no change were done on the V8 side.

Tests: fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html
fast/xpath/xpath-result-eventlistener-crash.html
fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html

  • Android.jscbindings.mk:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added the new file to our build systems.
  • bindings/js/JSXPathResultCustom.cpp: Added. (WebCore::JSXPathResult::markChildren): Added code to mark the XPathResult snapshot's nodes.
  • xml/XPathResult.h: (WebCore::XPathResult::value): Exposed this getter so that we can mark our XPathValue.
  • xml/XPathResult.idl: Told the IDL parser that we now need a custom mark function.
08:12 Changeset [86233] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.originsWithLocalStorage.

Add two more storage tracker tests (added in r86205) to the mac-wk2 Skipped list to get the
bots green.

  • platform/mac-wk2/Skipped:
08:08 Changeset [86232] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[Gtk+] deadlock in gstreamer video player when exiting fullscreen
https://bugs.webkit.org/show_bug.cgi?id=58548

Block data flow towards the pipeline branch to remove to avoid
potential deadlocks during the PAUSED->READY transitions of the
elements to remove.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::exitFullscreen):
07:48 Changeset [86231] by jberlin@webkit.org
  • 11 edits in trunk

[WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
about the usage for both the origin overall and the database in question.
https://bugs.webkit.org/show_bug.cgi?id=60573

Reviewed by Darin Adler.

Source/WebKit2:

Add the currentOriginUsage parameter.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::exceededDatabaseQuota):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::exceededDatabaseQuota):

07:39 Changeset [86230] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Expected results for 2d-transforms new test
https://bugs.webkit.org/show_bug.cgi?id=60565

Patch by Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com> on 2011-05-11
Reviewed by Csaba Osztrogonác.

Added expected results for 1 new 2d-transforms test.

  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
  • platform/qt/Skipped: Unskip now passing test.
07:23 Changeset [86229] by senorblanco@chromium.org
  • 2 edits in trunk/Tools

2011-05-10 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Adding myself as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=60587

  • Scripts/webkitpy/common/config/committers.py:
07:04 Changeset [86228] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove fixed_layout structure in ewk_view
https://bugs.webkit.org/show_bug.cgi?id=60615

Remove unnecessary fixed_layout structure. The ewk_view_fixed_layout_size_set/get()
use WebCore's functions directly.

  • ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set): (ewk_view_fixed_layout_size_get):
05:19 Changeset [86227] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-11 Tomasz Morawski <t.morawski@samsung.com>

Rubber-stamped by Daniel Bates.

Added missing DATABASE macro
https://bugs.webkit.org/show_bug.cgi?id=60437

  • ewk/ewk_settings.cpp: (ewk_settings_web_database_default_quota_get):
04:30 Changeset [86226] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Csaba Osztrogonác.

queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
https://bugs.webkit.org/show_bug.cgi?id=60614

AppEngine has a result limit of 1000. We hit that when trying
to find out how many patches the style-queue (and other queues)
have passed in the last 30 days. So lets display 1000+ instead
of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)

I also made the status pages show "never" instead of just "ago" when we
haven't seen a pass or boot message in the last 1000 messages.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/templates/queuestatus.html:
02:45 Changeset [86225] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-11 Kent Tamura <tkent@chromium.org>

The tests added by r86224 don't work on WebKit2/mac.

  • platform/mac-wk2/Skipped:
02:11 Changeset [86224] by tkent@chromium.org
  • 10 edits
    11 adds in trunk

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

  • fast/forms/resources/common.js: Added. Helper functions for fast/forms.
  • fast/forms/validation-message-on-checkbox-expected.txt: Added.
  • fast/forms/validation-message-on-checkbox.html: Added.
  • fast/forms/validation-message-on-listbox-expected.txt: Added.
  • fast/forms/validation-message-on-listbox.html: Added.
  • fast/forms/validation-message-on-menulist-expected.txt: Added.
  • fast/forms/validation-message-on-menulist.html: Added.
  • fast/forms/validation-message-on-radio-expected.txt: Added.
  • fast/forms/validation-message-on-radio.html: Added.
  • fast/forms/validation-message-on-textarea-expected.txt: Added.
  • fast/forms/validation-message-on-textarea.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/validation-message-appearance-expected.png: Updated.
  • platform/mac/fast/forms/validation-message-appearance-expected.txt: Updated.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

The position of validation message bubble is wrong for non text fields.
https://bugs.webkit.org/show_bug.cgi?id=60341

Tests: fast/forms/validation-message-on-checkbox.html

fast/forms/validation-message-on-listbox.html
fast/forms/validation-message-on-menulist.html
fast/forms/validation-message-on-radio.html
fast/forms/validation-message-on-textarea.html

  • css/html.css: (::-webkit-validation-bubble-message): Add white-space:normal in order not to inherit white-space:pre for <select>.
  • html/ValidationMessage.cpp: (WebCore::adjustBubblePosition): Adjust the bubble position.
    • The top of the bubble should be same as the bottom of the target control.
    • The left of the bubble should be same as the left of the target control. But If the left+32 is larger than the center of the target control, left+32 should be at the center of the target control. But the left position should not be less than 0.

(WebCore::ValidationMessage::buildBubbleTree): Call adjustBubblePosition().

01:32 Changeset [86223] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot shouldn't spam bugs when it can't figure out who to blame
https://bugs.webkit.org/show_bug.cgi?id=60613

This patch limits the number of bugs sheriffbot will spam to three.
Ideally, we'd come up with some smarter huerstics, but hopefully this
will cut down on the bugmail spam for slow bots.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
00:11 Changeset [86222] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-11 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderFlexibleBox to use IntPoint/IntSize instead of x,y/w,h pairs
https://bugs.webkit.org/show_bug.cgi?id=60592

Refactoring, covered by existing tests.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderFlexibleBox.h:
Note: See TracTimeline for information about the timeline view.