Timeline


and

05/19/11:

23:37 Changeset [86926] by commit-queue@webkit.org

2011-05-19 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
https://bugs.webkit.org/show_bug.cgi?id=61163

Manual test input-number-localization.html.
Because we can't assume any number formats in various WebKit ports.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
  • manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.
23:25 Changeset [86925] by ukai@chromium.org

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt: add BUGWK61169
22:31 Changeset [86924] by jer.noble@apple.com

2011-05-19 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
https://bugs.webkit.org/show_bug.cgi?id=56957

Guard against the parameter of setAnimating() matching the ivar value it's
setting, thus avoiding tearing down the renderer's layer backing.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating):

2011-05-19 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
https://bugs.webkit.org/show_bug.cgi?id=56957

In the WKFullscreenWindowController, when exiting accelerated compositing mode,
force a repaint, and don't actually remove the animation layer until the repaint
completes. Also, move back to parenting the WebView in a layer-backed view, and
work around the SnowLeopard bug which causes a crash in those situations. We no
longer need to do a bunch of work in finishedEnterFullScreenAnimation, because
the animation layer is "hiding" all the drawing happening in the webView underneath.

In the WebFullScreenManagerMac, when asked to tear down the root layer, instead
remove all its children, and set its contents to a flattened image of the full
screen element and its children. This helps patch over the time where everything
is re-rendering and helps give the appearance of continuousness in the animation.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]): (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): (exitCompositedModeRepaintCompleted): (-[WKFullScreenWindowController _page]): (-[WKFullScreenWindowController _manager]): (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
22:27 Changeset [86923] by loki@webkit.org

Fix ARM build after r86919

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::nop):

21:10 Changeset [86922] by commit-queue@webkit.org

2011-05-19 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

Detect hangs in run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=48043

  • Scripts/run-api-tests: Added test timeouts
19:39 Changeset [86921] by commit-queue@webkit.org

2011-05-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Adam Barth.

Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

Refactoring only so no new tests.

This patch fails short of one instance of deprecatedParserAddChild which will
require a refactoring of <input> shadow DOM to be removed.

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode. (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear up m_leafTextNode too.

(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::exitText):
Those methods were updated to use m_leafTextNode instead of m_currentNode.

  • dom/XMLDocumentParser.h: Changed the currentNode logic to use ContainerNode. Also fixed the style of the forward declarations.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): Removed the calls to deprecatedParserAddChild, changed the code to use m_leafTextNode when it made sense and used ContainerNode instead of Node for m_currentNode.
19:01 Changeset [86920] by commit-queue@webkit.org

2011-05-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

  • css3/images/optimize-contrast-canvas-expected.checksum: Added.
  • css3/images/optimize-contrast-canvas-expected.png: Added.
  • css3/images/optimize-contrast-canvas-expected.txt: Added.
  • css3/images/optimize-contrast-canvas.html: Added.
  • css3/images/optimize-contrast-image-expected.checksum: Added.
  • css3/images/optimize-contrast-image-expected.png: Added.
  • css3/images/optimize-contrast-image-expected.txt: Added.
  • css3/images/optimize-contrast-image.html: Added.

2011-05-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

Tests: css3/images/optimize-contrast-canvas.html

css3/images/optimize-contrast-image.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Added.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
18:33 Changeset [86919] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Randomise code starting location a little
https://bugs.webkit.org/show_bug.cgi?id=61161

Add a nop() function to the Assemblers so that we
can randomise code offsets slightly at no real cost.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::nop):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::nop):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::nop):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nop):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::nop):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::nop):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::nop):
  • assembler/X86Assembler.h: (JSC::X86Assembler::nop):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • runtime/WeakRandom.h: (JSC::WeakRandom::getUint32):
18:25 Changeset [86918] by lforschler@apple.com

Merge r86852.

18:18 Changeset [86917] by lforschler@apple.com

Merge r86851.

18:16 Changeset [86916] by lforschler@apple.com

Merge r86850.

18:13 Changeset [86915] by lforschler@apple.com

Merge r86827.

18:13 Changeset [86914] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
18:11 Changeset [86913] by lforschler@apple.com

Merge r86809.

18:04 Changeset [86912] by lforschler@apple.com

Merge r86785.

18:03 Changeset [86911] by jer.noble@apple.com

Unreviewed; added new test to gtk Skipped list.

  • platform/gtk/Skipped:
18:01 Changeset [86910] by jamesr@google.com

2011-05-19 James Robinson <jamesr@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=61159

Add a speculative null check to see if it reduces the crashrate.

http://code.google.com/p/chromium-os/issues/detail?id=15377

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
17:56 Changeset [86909] by lforschler@apple.com

Merge r86748.

17:20 Changeset [86908] by oliver@apple.com

Fix windows build.

17:12 Changeset [86907] by commit-queue@webkit.org

2011-05-19 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

run-api-tests should run one test per process
https://bugs.webkit.org/show_bug.cgi?id=61088

  • Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, return code, and parsing GTest output format.
16:46 Changeset [86906] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add guard pages to each end of the memory region used by the fixedvm allocator
https://bugs.webkit.org/show_bug.cgi?id=61150

Add mechanism to notify the OSAllocator that pages at either end of an
allocation should be considered guard pages. Update PageReservation,
PageAllocation, etc to handle this.

  • JavaScriptCore.exp:
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
  • wtf/OSAllocator.h:
  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::reserveAndCommit):
  • wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
  • wtf/PageAllocationAligned.h: (WTF::PageAllocationAligned::PageAllocationAligned):
  • wtf/PageBlock.h: (WTF::PageBlock::PageBlock):
  • wtf/PageReservation.h: (WTF::PageReservation::reserve): (WTF::PageReservation::reserveWithGuardPages):

Add a new function to make a reservation that will add guard
pages to the ends of an allocation.

(WTF::PageReservation::PageReservation):

16:43 Changeset [86905] by kbr@google.com

2011-05-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
https://bugs.webkit.org/show_bug.cgi?id=61091

  • compositing/webgl/webgl-no-alpha.html: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.txt: Added.

2011-05-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
https://bugs.webkit.org/show_bug.cgi?id=61091

Test: compositing/webgl/webgl-no-alpha.html

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::setHasAlpha):
16:17 Changeset [86904] by jer.noble@apple.com

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

  • media/video-src-invalid-poster-expected.txt: Added.
  • media/video-src-invalid-poster.html: Added.

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

Test: media/video-src-invalid-poster.html

In the case where no video sources are playable, update the display state and
renderer, allowing the poster image to display.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::waitForSourceChange):
15:53 Changeset [86903] by lforschler@apple.com

Merge r86820.

15:51 Changeset [86902] by lforschler@apple.com

Merge r86814.

15:46 Changeset [86901] by lforschler@apple.com

Merge r86806.

15:39 Changeset [86900] by lforschler@apple.com

Merge r86793.

15:29 Changeset [86899] by atwilson@chromium.org

2011-05-19 Andrew Wilson <atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying
https://bugs.webkit.org/show_bug.cgi?id=61130

  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js: Added test for "passing an array with an item at a really large index" to postMessage().

2011-05-19 Andrew Wilson <atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying.
https://bugs.webkit.org/show_bug.cgi?id=61130

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::fillMessagePortArray): Changed code to not pre-allocate the destination array.
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray): Changed code to not pre-allocate the destination array.
15:13 Changeset [86898] by andersca@apple.com

Address a review comment by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didUpdateHistoryTitle):

15:13 Changeset [86897] by lforschler@apple.com

Merge r86792.

15:10 Changeset [86896] by lforschler@apple.com

Merge r86783.

15:10 Changeset [86895] by andersca@apple.com

2011-05-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Hang UI appears when WebProcess isn't running
https://bugs.webkit.org/show_bug.cgi?id=61147
<rdar://problem/9413683>

This fixes two bugs:

  1. The HistoryClient related message handlers in WebContext could get invoked for pages that have been closed, and thus didn't have any subframes. Since we have a MESSAGE_CHECK that checks that the frame exists, we'd mark the currently dispatched message as invalid, which would end up calling Connection::Client::didReceiveInvalidMessage. Fix this by checking that the page exists first.
  1. In the call to WebProcessProxy::didReceiveInvalidMessage we'd first invalidate the CoreIPC connection to make sure that we won't get any further messages from this connection. We'd then go ahead and terminate the web process, but because we've already invalidated the CoreIPC connection we would never get the Connection::Client::didClose callback that would call WebPageProxy::processDidCrash. Fix this by explicitly calling WebProcessProxy::didClose. Also, add logging when we receive an invalid message
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveInvalidMessage):
15:08 Changeset [86894] by lforschler@apple.com

Merge r86781.

15:06 Changeset [86893] by bweinstein@apple.com

Crash when detaching Web Inspector when parent is in process of closing.
https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>

Reviewed by Adam Roben.

We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.

15:06 Changeset [86892] by inferno@chromium.org

Merge 86781
BUG=79075
Review URL: http://codereview.chromium.org/7048016

15:05 Changeset [86891] by lforschler@apple.com

Merge r86741.

15:00 Changeset [86890] by lforschler@apple.com

Versioning.

14:41 Changeset [86889] by lforschler@apple.com

rollout last change... merged the wrong changeset.

14:18 Changeset [86888] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
13:39 Changeset [86887] by robert@webkit.org

2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • platform/qt/Skipped:

2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_stream): (webkit_test_plugin_write_ready): (webkit_test_plugin_write):
13:36 Changeset [86886] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.


  • platform/chromium/test_expectations.txt:
13:26 Changeset [86885] by mrowe@apple.com

Move aside some old branches.

13:19 Changeset [86884] by lforschler@apple.com

Merge r86741.

13:18 Changeset [86883] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Executables release their JIT code as soon as they become dead
https://bugs.webkit.org/show_bug.cgi?id=61134

Add an ability to clear an Executable's jit code without requiring
it to be destroyed, and then call that from a finalizer.

  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::leak):
  • jit/JITCode.h: (JSC::JITCode::clear):
  • runtime/Executable.cpp: (JSC::ExecutableFinalizer::finalize): (JSC::ExecutableBase::executableFinalizer):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::clearExecutableCode):
13:18 Changeset [86882] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium gradient expectations update.

  • platform/chromium-linux-x86/fast/gradients: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
13:13 Changeset [86881] by lforschler@apple.com

Merge r86738.

13:11 Changeset [86880] by lforschler@apple.com

Merge r86737.

13:10 Changeset [86879] by dglazkov@chromium.org

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/harness/internals-object-expected.txt: Removed.
  • fast/harness/internals-object.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/Internals.cpp: Removed.
  • testing/Internals.h: Removed.
  • testing/Internals.idl: Removed.
  • testing/js/WebCoreTestSupport.cpp: Removed.
  • testing/js/WebCoreTestSupport.h: Removed.
  • testing/v8/WebCoreTestSupport.cpp: Removed.
  • testing/v8/WebCoreTestSupport.h: Removed.

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • WebKit.gyp:
  • public/WebTestingSupport.h: Removed.
  • src/WebTestingSupport.cpp: Removed.

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
13:05 Changeset [86878] by lforschler@apple.com

Merge r86734.

13:01 Changeset [86877] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

One more fix after r86869.

  • WebCore.exp.in: Made ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.
12:55 Changeset [86876] by lforschler@apple.com

Merge r86727.

12:45 Changeset [86875] by andersca@apple.com

Add two more symbols needed by the window.internals library.

  • WebCore.exp.in:
12:44 Changeset [86874] by lforschler@apple.com

Merge r86725.

12:26 Changeset [86873] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

Fix Leopard build after r86869.

  • WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.
12:24 Changeset [86872] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
12:05 Changeset [86871] by lforschler@apple.com

Versioning.

11:59 Changeset [86870] by robert@webkit.org

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
https://bugs.webkit.org/show_bug.cgi?id=60992

  • platform/qt/Skipped:

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
https://bugs.webkit.org/show_bug.cgi?id=60992

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • plugins/qt/PluginViewQt.cpp: (WebCore::getPluginDisplay):

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::getPluginDisplay):
11:54 Changeset [86869] by dglazkov@chromium.org

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/harness/internals-object-expected.txt: Added.
  • fast/harness/internals-object.html: Added.
  • platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

Test: fast/harness/internals-object.html

  • DerivedSources.make: Added support for generating from Internals.idl.
  • WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  • testing/Internals.cpp: Added.
  • testing/Internals.h: Added.
  • testing/Internals.idl: Added.
  • testing/js/WebCoreTestSupport.cpp: Added.
  • testing/js/WebCoreTestSupport.h: Added.
  • testing/v8/WebCoreTestSupport.cpp: Added.
  • testing/v8/WebCoreTestSupport.h: Added.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • WebKit.gyp: Added linking new webkit_test_support library.
  • public/WebTestingSupport.h: Added.
  • src/WebTestingSupport.cpp: Added.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
11:51 Changeset [86868] by rniwa@webkit.org

Merge 84265 - 2011-04-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=57061

The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
a significant performance regression.

Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
and prevents respondToNodeModification from clearing selection.

No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
isn't exposed to JavaScript.

  • dom/Range.cpp: (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of start and end nodes are same, we should never get an exception from compareBoundaryPoints. (WebCore::Range::setEnd): Ditto. (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints throws an exception. (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by compareBoundaryPoints. (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor. (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
  • dom/Range.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::respondToNodeModification):
  • editing/htmlediting.cpp: (WebCore::comparePositions): Calls compareBoundaryPoints.
  • editing/markup.cpp: (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document and neither are in a shadow DOM, it should never throw an exception.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception was thrown.

ISSUE=83197
TBR=rniwa@webkit.org

11:45 Changeset [86867] by inferno@chromium.org

Merge 86748
BUG=82516

11:43 Changeset [86866] by inferno@chromium.org

Merge 86748
BUG=82516
Review URL: http://codereview.chromium.org/7048008

11:43 Changeset [86865] by cdn@chromium.org

Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572
Review URL: http://codereview.chromium.org/7049017

11:40 Changeset [86864] by cdn@chromium.org

Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572

11:40 Changeset [86863] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

Accept XCode's decisions to keep modifying WebCore.xcodeproj.

  • WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.
11:39 Changeset [86862] by inferno@chromium.org

Merge 86448
BUG=82546
Review URL: http://codereview.chromium.org/7050016

11:39 Changeset [86861] by commit-queue@webkit.org

2011-05-19 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Darin Adler.

Fix GraphicsContext3DQt.cpp compile error
https://bugs.webkit.org/show_bug.cgi?id=61128

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): clear() m_internal OwnPtr.
11:38 Changeset [86860] by inferno@chromium.org

Merge 86448
BUG=82546

11:35 Changeset [86859] by inferno@chromium.org

Merge 86500
BUG=82633
Review URL: http://codereview.chromium.org/7033030

11:33 Changeset [86858] by inferno@chromium.org

Merge 86500
BUG=82633

11:31 Changeset [86857] by cdn@chromium.org

Merge 85977 - 2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189
Review URL: http://codereview.chromium.org/7051008

11:27 Changeset [86856] by cdn@chromium.org

Merge 85977 - 2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189

11:14 Changeset [86855] by commit-queue@webkit.org

2011-05-19 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Resizing columns in the network panel is weird
https://bugs.webkit.org/show_bug.cgi?id=55238

Makes network panel column resizing more usable by adding "first only" and "last only"
resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
remains default. Network panels datagrid is set to use method "last".

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get resizeMethod): (WebInspector.DataGrid.prototype.set resizeMethod): (WebInspector.DataGrid.prototype._resizerDragging):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable):
10:46 Changeset [86854] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

JoinTextNodesCommand is never used
https://bugs.webkit.org/show_bug.cgi?id=61089

Deleted JoinTextNodesCommand because it's never used.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditingAllInOne.cpp:
  • editing/JoinTextNodesCommand.cpp: Removed.
  • editing/JoinTextNodesCommand.h: Removed.
10:27 Changeset [86853] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Make Mac Leopard bot happy after r81176.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
10:22 Changeset [86852] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=61012

Added a test to ensure WebKit does not crash when inserting a content immediately after
a styled element inside a Mail blockquote. Regrettably the expected result is incorrect,
but it matches the behavior of WebKit before r83322.

  • editing/pasteboard/5065605-expected.txt: Reintroduced redundant style spans.
  • editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • editing/pasteboard/paste-after-inline-style-element-expected.txt: Added.
  • editing/pasteboard/paste-after-inline-style-element.html: Added.

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=61012

The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
being moved when the insertion position's container node is the node to split to. Fixed the crash
by not changing the insertion position in such a case.

Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
it's much better than crashing.

Test: editing/pasteboard/paste-after-inline-style-element.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
10:17 Changeset [86851] by cmarrin@apple.com

2011-05-18 Chris Marrin <cmarrin@apple.com>

Reviewed by Anders Carlsson.

Plug-ins at YouTube, cnn.com, nytimes vanish when their top/left is scrolled out of view when zoomed
https://bugs.webkit.org/show_bug.cgi?id=61101

Scale both bounding boxes sent to m_plugin->geometryDidChange(), not just the frameRect. This fools
the plugin into thinking it is drawing into an unscaled box with an unscaled view even when scaled.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::frame):Made this const so it can be used in clipRectInWindowCoordinates() (WebKit::PluginView::viewGeometryDidChange):Used IntRect::scale() rather than scaling by hand (WebKit::PluginView::clipRectInWindowCoordinates):Added scale of clipRect.
  • WebProcess/Plugins/PluginView.h:
10:15 Changeset [86850] by aroben@apple.com

Remove a redundant and broken data export

Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.
10:15 Changeset [86849] by lforschler@apple.com

New Branch.

09:51 Changeset [86848] by carlosgc@webkit.org

2011-05-19 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
https://bugs.webkit.org/show_bug.cgi?id=61113

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke): (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
09:33 Changeset [86847] by beidson@apple.com

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

09:28 Changeset [86846] by ossy@webkit.org

[Qt] Skip failing test after r86841.

  • platform/qt-arm/Skipped:
09:22 Changeset [86845] by darin@apple.com

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::markersHaveIdenticalDescription): Call description() function.

08:12 Changeset [86844] by ossy@webkit.org

[Qt] Skip failing tests after r86834.

  • platform/qt-arm/Skipped:
06:08 Changeset [86843] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 2 failing tests on GTK.

  • platform/gtk/Skipped: Skip http/tests/appcache/interrupted-update.html and http/tests/navigation/post-307-response.html
05:44 Changeset [86842] by commit-queue@webkit.org

2011-05-19 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: switch to Scripts panel is too slow
https://bugs.webkit.org/show_bug.cgi?id=61030

  • It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
  • Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates): (WebInspector.TextEditorMainPanel.prototype.endDomUpdates): (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype._createRow):
05:39 Changeset [86841] by ossy@webkit.org

[Qt] Implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=60015

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-05-19
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::scalePageBy):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped: Unskip fast/transforms/selection-bounds-in-transformed-view.html.
05:35 Changeset [86840] by ossy@webkit.org

[Qt] Skip failing tests after r86834.

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
05:13 Changeset [86839] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Not reviewed: inspector protocol tests fixed.

  • inspector/InjectedScriptSource.js:
05:03 Changeset [86838] by commit-queue@webkit.org

2011-05-19 David Grogan <dgrogan@chromium.org>

Reviewed by David Levin.

Make EventQueue post a Task to the task queue for each asynchronous event
https://bugs.webkit.org/show_bug.cgi?id=60790

Currently EventQueue queues up events to be fired asynchronously and
fires each of them when a single DOMTimer goes off. In the words of
dimich, "Having 2 queues will sooner or later cause problems with
ordering of tasks, termination, suspension and other things that all
require some control on how queues operate."

No new tests; this is just a refactoring to avoid potential future
problems.

  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::EventDispatcherTask::create): (WebCore::EventQueue::EventDispatcherTask::dispatchEvent): (WebCore::EventQueue::EventDispatcherTask::performTask): (WebCore::EventQueue::EventDispatcherTask::cancel): (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask): (WebCore::EventQueue::removeEvent): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::enqueueOrDispatchScrollEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents):
  • dom/EventQueue.h:
04:47 Changeset [86837] by yurys@chromium.org

2011-05-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
https://bugs.webkit.org/show_bug.cgi?id=60800

  • inspector/console/console-eval-blocked-expected.txt: Added.
  • inspector/console/console-eval-blocked.html: Added.

2011-05-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
https://bugs.webkit.org/show_bug.cgi?id=60800

Thanks to Adam Barth for providing JSC implementation!

InjectedScriptHost.evaluate is used to perform script evaluations for
inspector needs. This method is not affected by CSP and should fix inspector
on pages with CSP restrictions.

Test: inspector/console/console-eval-blocked.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::evaluate):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
04:10 Changeset [86836] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object class name as a part of RemoteObject mirror.
https://bugs.webkit.org/show_bug.cgi?id=61067

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
04:09 Changeset [86835] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "this" a part of callFrame, not scope in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=61057

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
04:04 Changeset [86834] by commit-queue@webkit.org

2011-05-19 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/style tests that are working
https://bugs.webkit.org/show_bug.cgi?id=61075

Also based on digging of Zsolt Fehér.

  • platform/qt/Skipped:
  • platform/qt/editing/style/5046875-1-expected.png: Added.
  • platform/qt/editing/style/5046875-1-expected.txt:
  • platform/qt/editing/style/5046875-2-expected.png: Added.
  • platform/qt/editing/style/5046875-2-expected.txt:
  • platform/qt/editing/style/5065910-expected.png: Added.
  • platform/qt/editing/style/5065910-expected.txt:
  • platform/qt/editing/style/5084241-expected.png: Added.
  • platform/qt/editing/style/5084241-expected.txt:
  • platform/qt/editing/style/5279521-expected.png: Added.
  • platform/qt/editing/style/5279521-expected.txt:
  • platform/qt/editing/style/block-style-004-expected.png: Added.
  • platform/qt/editing/style/block-style-005-expected.png: Added.
  • platform/qt/editing/style/block-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.txt:
  • platform/qt/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-002-expected.txt:
  • platform/qt/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-003-expected.txt:
  • platform/qt/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-004-expected.txt:
  • platform/qt/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-005-expected.txt:
  • platform/qt/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-006-expected.txt:
  • platform/qt/editing/style/create-block-for-style-007-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-007-expected.txt:
  • platform/qt/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-008-expected.txt:
  • platform/qt/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-009-expected.txt:
  • platform/qt/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-010-expected.txt:
  • platform/qt/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-011-expected.txt:
  • platform/qt/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-012-expected.txt:
  • platform/qt/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-013-expected.txt:
  • platform/qt/editing/style/font-family-with-space-expected.png: Added.
  • platform/qt/editing/style/font-family-with-space-expected.txt:
  • platform/qt/editing/style/fontsize-1-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-001-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-001-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-002-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-002-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-003-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-003-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-004-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-004-expected.txt:
  • platform/qt/editing/style/smoosh-styles-001-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-001-expected.txt:
  • platform/qt/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-003-expected.txt:
  • platform/qt/editing/style/style-3690704-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.txt:
  • platform/qt/editing/style/style-boundary-001-expected.png: Added.
  • platform/qt/editing/style/style-boundary-001-expected.txt:
  • platform/qt/editing/style/style-boundary-004-expected.png: Added.
  • platform/qt/editing/style/style-boundary-004-expected.txt:
  • platform/qt/editing/style/table-selection-expected.png: Added.
  • platform/qt/editing/style/table-selection-expected.txt:
03:23 Changeset [86833] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing GTK fullscreen test

https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped: Skip fullscreen/full-screen-keyboard-enabled.html
02:50 Changeset [86832] by tkent@chromium.org

2011-05-19 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
https://bugs.webkit.org/show_bug.cgi?id=60948

Update existing tests for the new behavior.

  • fast/forms/ValidityState-tooLong-input-expected.txt:
  • fast/forms/ValidityState-tooLong-textarea-expected.txt:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/ValidityState-tooLong-input.js:
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js:

2011-05-19 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
https://bugs.webkit.org/show_bug.cgi?id=60948

The specification has been updated so that tooLong should be true only
for user-edit values.

Introduce m_wasModifiedByUser flag to HTMLInputElement and
HTMLTextAreaElemnt. It is set to true when a renderer updates the
value, and is cleared when the value is updated by others.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Initialize m_wasModifiedByUser. (WebCore::HTMLInputElement::tooLong): Skip the check if m_wasModifiedByUser is false. (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser. (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::setValue): If sendChange is true, m_wasModifiedByUser should be true because sendChange is set in a case of form auto-fill. We assume a value set by form auto-fill is a kind of user-edit. (WebCore::HTMLInputElement::setValueFromRenderer): m_wasModifiedByUser should be true for the update by a renderer.
  • html/HTMLInputElement.h: Declare m_wasModifiedByUser.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initialize m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::updateValue): m_wasModifiedByUser should be true for the update by a renderer. (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::tooLong): Skip the check if m_wasModifiedByUser is false.
  • html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.
02:47 Changeset [86831] by yuzo@google.com

2011-05-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Leopard.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
02:45 Changeset [86830] by commit-queue@webkit.org

2011-05-19 David Barr <davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
https://bugs.webkit.org/show_bug.cgi?id=38788

  • fast/css/border-radius-non-negative-expected.txt: Added.
  • fast/css/border-radius-non-negative.html: Added.
  • platform/mac/fast/css/border-radius-non-negative-expected.png: Added.

2011-05-19 David Barr <davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
https://bugs.webkit.org/show_bug.cgi?id=38788

Ignore border-radius properties with negative values.

Test: fast/css/border-radius-non-negative.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderRadius):
02:33 Changeset [86829] by yutak@chromium.org

2011-05-19 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
https://bugs.webkit.org/show_bug.cgi?id=61034

Refactoring only. No new tests.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task to hold these pending events.
02:22 Changeset [86828] by commit-queue@webkit.org

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Added a test which ensures the IME candidate position is located
at suitable position.

  • platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
  • platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
  • platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Always adjusts the range to window relative coordinates.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition which excludes editable selectionRoot from adjusting.

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Call the focused frame's firstRectForCharacterRange() instead of the
main frame so that DRT behaves as the same as Chromium.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange):
02:21 Changeset [86827] by eae@chromium.org

2011-05-19 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
https://bugs.webkit.org/show_bug.cgi?id=60986

  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt:
  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html:

2011-05-19 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
https://bugs.webkit.org/show_bug.cgi?id=60986

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple): Don't restore selection if the multiple attribute hasn't changed.
02:19 Changeset [86826] by commit-queue@webkit.org

2011-05-19 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Simon Fraser.

Gradients not horizontal using 270deg with odd div width
https://bugs.webkit.org/show_bug.cgi?id=60157

When the angle of the linear gradient is 270, the endpoint should
be computed in the same way as for 0, 90, 180 cases since tan(270)
is undefined.

  • fast/gradients/css3-linear-right-angle-gradients-expected.txt: Added.
  • fast/gradients/css3-linear-right-angle-gradients.html: Added.
  • platform/mac/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
01:55 Changeset [86825] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, follow-up fix of the messages python unittests after r86812.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
https://bugs.webkit.org/show_bug.cgi?id=60872

  • Scripts/webkit2/messages_unittest.py:
01:16 Changeset [86824] by yuzo@google.com

2011-05-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Snow Leopard.

  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
00:28 Changeset [86823] by zimmermann@webkit.org

2011-05-19 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update mac pixel test baseline, had marginal differences in the filter results and the text selection rectangles since a while.
The baseline passes again on my 32bit and 64bit machine, using run-webkit-tests --tolerance 0.011 -p svg

  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-fonts-02-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.png:
  • platform/mac/svg/text/text-tref-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/text/text-ws-01-t-expected.png:
  • platform/mac/svg/text/text-ws-02-t-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
00:12 BuildingQtOnOSX edited by dominicc@chromium.org
Added note about installing the debug variant of the qt4-mac port, since … (diff)

05/18/11:

23:40 Changeset [86822] by ukai@chromium.org

2011-05-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=57048

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose): use loaderRunLoop to schedule streams on platform WIN
23:17 Changeset [86821] by loki@webkit.org

[Qt] Skip flaky timed out tests on ARM

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
23:16 Changeset [86820] by beidson@apple.com

As originally reviewed by Anders Carlsson.

<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Restore r86797 to how it was supposed to be using the appropriate #ifdef,
reverting the temporary r86814 in the process.

The #ifdef is BUILDING_ON_SNOW_LEOPARD, not BUILDING_ON_SNOWLEOPARD!

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

23:08 Changeset [86819] by morrita@google.com

2011-05-18 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fix clang build.

  • rendering/InlineTextBox.h:
21:08 Changeset [86818] by rniwa@webkit.org

2011-05-18 Ryosuke Niwa <rniwa@webkit.org>

Yet another rebaseline after r81176.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
21:02 Changeset [86817] by rniwa@webkit.org

2011-05-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

editing/pasteboard/paste-blockquote-into-blockquote-3.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61102

Converted the test.

  • editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote-3.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
20:21 Changeset [86816] by commit-queue@webkit.org

2011-05-18 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
https://bugs.webkit.org/show_bug.cgi?id=61010

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):

2011-05-18 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Add histograms for paint times
https://bugs.webkit.org/show_bug.cgi?id=61010

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImplContentPainter::paint):
19:41 Changeset [86815] by enne@google.com

2011-05-18 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix incorrect size when clipping image layer upload rects
https://bugs.webkit.org/show_bug.cgi?id=61105

The clipped destination and source rects should have the same size.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::updateTextureRect):
19:28 Changeset [86814] by beidson@apple.com

Fix the WK2 SnowLeopard layouttests (again) until I can explore on a SnowLeopard machine tomorrow.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

18:38 Changeset [86813] by morrita@google.com

2011-05-17 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
https://bugs.webkit.org/show_bug.cgi?id=56814

  • Moved DocumentMarker's member variables to private and added getters for them.
  • Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
  • Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController::addTextMatchMarker() because it accesses DocumentMarker internals.
  • Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
18:36 Changeset [86812] by darin@apple.com

2011-05-18 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
https://bugs.webkit.org/show_bug.cgi?id=60872

Eliminate the concept of SyncReplyMode and instead hand around ownership
of the reply decoder using an OwnPtr.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchSyncMessage): Eliminated comments that say the same things the code itself does. Removed code that handles the reply mode. Instead, pass the OwnPtr to the message handling function and make the call to sendSyncReply conditional on whether the reply encoder is still non-null.
  • Platform/CoreIPC/Connection.h: Removed SyncReplyMode. Made didReceiveSyncMessage return void, and take OwnPtr<ArgumentEncoder>& for the reply encoder.
  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Take an OwnPtr&. Replaced the call to adoptPtr with a call to release.
  • PluginProcess/PluginControllerProxy.h: Updated to take an OwnPtr& and not return SyncReplyMode.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::didReceiveSyncMessage): Ditto.
  • PluginProcess/WebProcessConnection.h: Ditto.
  • Scripts/webkit2/messages.py: Updated for changes to sync messages. Eliminated unneeded return types and use get() when apporopriate to call the handleMessage functions.
  • Scripts/webkit2/messages_unittest.py: Tried to update this too. I don't know how to run the test, though.
  • Shared/Plugins/NPObjectMessageReceiver.h: Updated to take an OwnPtr& and not return SyncReplyMode.
  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::didReceiveSyncMessage): Ditto.
  • Shared/Plugins/NPRemoteObjectMap.h: Ditto.
  • UIProcess/Downloads/DownloadProxy.h: Ditto.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveSyncMessage): Ditto.
  • UIProcess/WebContext.h: Ditto.
  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebFullScreenManagerProxy.h: Ditto.
  • UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::didReceiveSyncMessage): Ditto.
  • UIProcess/WebIconDatabase.h: Ditto.
  • UIProcess/WebInspectorProxy.h: Ditto.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveSyncMessage): Ditto.
  • UIProcess/WebProcessProxy.h: Ditto.
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: Added a missing include.
  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveSyncMessage): Updated to take an OwnPtr& and not return SyncReplyMode.
  • WebProcess/Plugins/PluginProcessConnection.h: Ditto.
  • WebProcess/Plugins/PluginProxy.h: Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveSyncMessage): Ditto.
  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveSyncMessage): Ditto.
  • WebProcess/WebProcess.h: Ditto.
18:31 Changeset [86811] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
18:15 Changeset [86810] by oliver@apple.com

2011-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

+[WebScriptObject throwException:] doesn't work when invoked from obj-c field access
https://bugs.webkit.org/show_bug.cgi?id=61100

The objc bindings were written to assume exceptions would
come from obj-c style exceptions, rather than throwException:
This code simply calls the global ObjcInstance mechanism for
transferring the reported exception.

  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::ObjcField::setValueToInstance):
17:45 Changeset [86809] by oliver@apple.com

2011-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=61064

Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
for its inline storage. This resolves the problem of GC occurring before
a subclass has initialised its anonymous storage.

  • runtime/JSObject.h:
17:38 Changeset [86808] by enne@google.com

2011-05-16 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Robustly handle mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=60934

Also, lazily create the temp buffer so that both the map and non-map
cases can use it.

  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
17:16 Changeset [86807] by eae@chromium.org

2011-05-18 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Change RenderTextControl::hitInnerTextElement to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61003

Covered by existing tests.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
17:10 Changeset [86806] by cfleizach@apple.com

WK2: VoiceOver cannot move focus into a web area programmatically
https://bugs.webkit.org/show_bug.cgi?id=60661

Reviewed by Maciej Stachowiak.

Source/WebCore:

Accessibility code relies on the ability to bring focus to the containing widget view.
In WK2, that message needs to be propagated to the UI process.

  • page/ChromeClient.h:

(WebCore::ChromeClient::makeFirstResponder):

  • page/mac/ChromeMac.mm:

(WebCore::Chrome::focusNSView):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::setFocus):

Source/WebKit2:

Add a makeFirstResponder method that will bring focus to the widget view within the UI
process.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::makeFirstResponder):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::makeFirstResponder):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::makeFirstResponder):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
16:53 Changeset [86805] by enne@google.com

2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Added.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
  • platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=60719

  • src/WebViewImpl.cpp:
16:43 Changeset [86804] by commit-queue@webkit.org

2011-05-18 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
https://bugs.webkit.org/show_bug.cgi?id=58609

One new test and one fix to an existing test that relied on the old
broken behavior.

  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Added.
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html: Added.
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:

2011-05-18 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB put() should fail adding to object store that uses
out-of-line keys and has no key generator and the key parameter
was not provided
https://bugs.webkit.org/show_bug.cgi?id=58609

Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
no key generator means that objectStore->autoIncrement() is false, and
key parameter was not provided means that prpKey will be a null pointer.
The combination of these 3 should throw a DATA_ERR.

Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html

  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put):
16:34 Changeset [86803] by commit-queue@webkit.org

2011-05-18 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Oliver Hunt.

[Qt] fast/encoding/yentest.html and yentest2.html fail
https://bugs.webkit.org/show_bug.cgi?id=39852

  • platform/qt/Skipped: Unskip passing tests.
16:28 Changeset [86802] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium test expectations update for details element (Windows).

  • platform/chromium/test_expectations.txt:
16:14 Changeset [86801] by crogers@google.com

2011-05-18 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

EqualPowerPanner is not using the correct azimuth range for stereo panning
https://bugs.webkit.org/show_bug.cgi?id=61085

No new tests since audio API is not yet implemented.

  • platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):
16:14 Changeset [86800] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update for SVG tests.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters: Added.
  • platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/dynamic-updates: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/filters: Added.
  • platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Added.
15:17 Changeset [86799] by brettw@chromium.org

2011-05-18 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Don't create empty file objects if no download file path is specified.
https://bugs.webkit.org/show_bug.cgi?id=60798

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::setDownloadFilePath):
15:10 Changeset [86798] by yi.4.shen@nokia.com

2011-05-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179

Unskip the fast/events/onsearch-enter.html test.

  • platform/qt/Skipped:

2011-05-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179

Fill the missing key text for the EnterKey event.

Tests: fast/events/onsearch-enter.html

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyTextForKeyEvent):

2011-05-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
https://bugs.webkit.org/show_bug.cgi?id=33179

Remove the implementation of the handleInputMethodKeydown, which introduces
a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Add more tests.
15:04 Changeset [86797] by beidson@apple.com

<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

  • Platform/unix/EnvironmentUtilities.cpp: Remove an unnecessary #include, as reviewed.
15:03 Changeset [86796] by lforschler@apple.com

rollout r86699.

14:58 Changeset [86795] by lforschler@apple.com

Versioning.

14:54 Changeset [86794] by lforschler@apple.com

New tag.

14:47 Changeset [86793] by timothy@apple.com

Update the the context menu to reflect the system search provider on Mac.

<rdar://problem/9198419>

Reviewed by Sam Weinig.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
create the string.

  • platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
create the web search context menu title.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle): Add a FIXME about using NSPerformService on Mac.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

14:46 Changeset [86792] by beidson@apple.com

<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

If the WebProcess or PluginProcess forks, it shouldn't pass WebKit2 shims along to the new process
in the DYLD_INSERT_LIBRARIES environment variable.

Add Environment Utilities helper to strip unwanted values from an environment variable:

  • Platform/unix/EnvironmentUtilities.cpp: Added.

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):

  • Platform/unix/EnvironmentUtilities.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Strip PluginProcessShim.dylib from DYLD_INSERT_LIBRARIES:

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

Strip WebProcessShim.dylib from DYLD_INSERT_LIBRARIES:

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Unprotect SnowLeopard now that it will behave and not spawn processes trying to use WebKit2 shims:

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

14:40 Changeset [86791] by rwlbuis@webkit.org

2011-05-18 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60721

Change <marker> renderer creation behaviour to always create the renderer. This fixes
the problem that no marker is rendered when display=none is set on the <marker>. The
specification states that display=none should have no influence on <marker> usage:
"The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
elements are available for referencing even when the ‘display’ property on the ‘marker’
element or any of its ancestors is set to none."

Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg

svg/custom/painting-marker-07-f-inherit.svg

  • svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::rendererIsNeeded):

2011-05-18 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Marker test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60721

Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
  • platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
  • svg/custom/painting-marker-07-f-inherit.svg: Added.
14:26 Changeset [86790] by commit-queue@webkit.org

2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
https://bugs.webkit.org/show_bug.cgi?id=60760

This test creates an hidden video element and make sure the loading works.

  • http/tests/media/media-can-load-when-hidden-expected.txt: Added.
  • http/tests/media/media-can-load-when-hidden.html: Added.

2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Eric Carlson.

MediaElements fails to load the data in some cases.
https://bugs.webkit.org/show_bug.cgi?id=60760

WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
that uses the ResourceHandle API to request data and pass it down. For
our builds it is absolutely essential that we have a NetworkingContext
available there, in order to get access to the QNetworkAccessManager.
No access means we basically cannot load the video. The WebSource gains
access to the NetworkingContext through a WebCore::Frame pointer it has.

MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
the WebCore::Frame to the WebKitWebSource in
mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
frameView() accessor to access the frame. However the frameView() member
is only set through the render tree's RenderVideo, which is rather unreliable
given that some sites create "fake" video tags initially that only become
visible later (or never).

A more reliable way is to simply use the document of the MediaPlayerClient,
which is provided at constructor time.

Test: http/tests/media/media-can-load-when-hidden.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
14:23 Changeset [86789] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Fixing previous Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
14:16 Changeset [86788] by enne@google.com

2011-05-18 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Check HUD texture reserve status before using texture
https://bugs.webkit.org/show_bug.cgi?id=61082

This only changes behavior behind a flag, so shouldn't impact any tests.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
14:04 Changeset [86787] by abarth@webkit.org

2011-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Delete WTFURL
https://bugs.webkit.org/show_bug.cgi?id=61084

It's been a year and we've failed to complete this project. It's time
to throw in the towel.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/url: Removed.
  • wtf/url/api: Removed.
  • wtf/url/api/ParsedURL.cpp: Removed.
  • wtf/url/api/ParsedURL.h: Removed.
  • wtf/url/api/URLString.h: Removed.
  • wtf/url/src: Removed.
  • wtf/url/src/RawURLBuffer.h: Removed.
  • wtf/url/src/URLBuffer.h: Removed.
  • wtf/url/src/URLCharacterTypes.cpp: Removed.
  • wtf/url/src/URLCharacterTypes.h: Removed.
  • wtf/url/src/URLComponent.h: Removed.
  • wtf/url/src/URLEscape.cpp: Removed.
  • wtf/url/src/URLEscape.h: Removed.
  • wtf/url/src/URLParser.h: Removed.
  • wtf/url/src/URLQueryCanonicalizer.h: Removed.
  • wtf/url/src/URLSegments.cpp: Removed.
  • wtf/url/src/URLSegments.h: Removed.
  • wtf/url/wtfurl.gyp: Removed.
13:51 Changeset [86786] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Another Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
13:41 Changeset [86785] by oliver@apple.com

2011-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
https://bugs.webkit.org/show_bug.cgi?id=61090

Remove the Structure-free JSGlobalObject constructor and instead always
pass the structure into the JSGlobalObject constructor.
Stop DebuggerActivation creating a new structure every time, and simply
use a single shared structure held by the GlobalData.

  • API/JSContextRef.cpp:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:

2011-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
https://bugs.webkit.org/show_bug.cgi?id=61090

Rather than having Constructor objects create their structure
as part of initialisation, we now pass their expected structure
in as an argument. This required fixing the few custom Constructors
and the code generator.

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Pass the Constructor objects structure in as an argument
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:
13:09 Changeset [86784] by jschuh@chromium.org

2011-05-18 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium tests expectations update for details element.

  • platform/chromium/test_expectations.txt:
12:54 Changeset [86783] by jonlee@apple.com

2011-05-18 Jon Lee <jonlee@apple.com>

Reviewed by Simon Fraser.

Crash in injected bundle client
https://bugs.webkit.org/show_bug.cgi?id=61086

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection): Check for existence of method in client prior to calling.
12:35 Changeset [86782] by arv@chromium.org

2011-05-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Expand layout test for testing the coords of a click on a label element
https://bugs.webkit.org/show_bug.cgi?id=61080

This expands the existing test to click on a label inside a scrolled element.

  • fast/events/simulated-click-coords-expected.txt:
  • fast/events/simulated-click-coords.html:
12:30 Changeset [86781] by inferno@chromium.org

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Beth Dakin.

Tests that we do not crash when prematurely calling removeChild,
followed by destroy call on table caption.
https://bugs.webkit.org/show_bug.cgi?id=61083

  • fast/table/table-captions-child-visible-crash-expected.txt: Added.
  • fast/table/table-captions-child-visible-crash.html: Added.

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Beth Dakin.

Remove removeChild on table caption since destroy call
already does that.
https://bugs.webkit.org/show_bug.cgi?id=61083

Test: fast/table/table-captions-child-visible-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcCaption):
11:42 Changeset [86780] by evan@chromium.org

2011-05-18 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] make action_derivedsourcesallinone.py quiet
https://bugs.webkit.org/show_bug.cgi?id=61081

In gyp, it's the responsibility of the build system to print what actions are doing;
for example, the compile command is generally silent, while the build system prints
"compiling".

Make this program behave like a compiler: silent on success.

  • WebCore.gyp/scripts/action_derivedsourcesallinone.py: delete a print statement.
11:28 Changeset [86779] by oliver@apple.com

2011-05-18 Oliver Hunt <oliver@apple.com>

Reviewed by Adam Roben.

Disable gc validation in release builds
https://bugs.webkit.org/show_bug.cgi?id=60680

Add back the NDEBUG check

  • wtf/Platform.h:
11:20 Changeset [86778] by ddkilzer@apple.com

<http://webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()

Reviewed by Joseph Pecoraro.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Use
toHTTPPipeliningPriority() to convert arguments passed to
wkSetHTTPPipeliningMaximumPriority() and
wkSetHTTPPipeliningMinimumFastLanePriority().

11:15 Changeset [86777] by commit-queue@webkit.org

2011-05-18 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

editing/style/apply-through-end-of-document.html is supposed to be dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=61077

  • editing/style/apply-through-end-of-document-expected.txt:
  • editing/style/apply-through-end-of-document.html:
  • platform/chromium-linux/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/chromium-win/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/chromium-win/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/mac-leopard/editing/style/apply-through-end-of-document-expected.png: Removed.
  • platform/mac/editing/style/apply-through-end-of-document-expected.png: Removed.
11:00 How to not mess up GC created by oliver@apple.com
work in progress
10:47 Changeset [86776] by arv@chromium.org

2011-05-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
https://bugs.webkit.org/show_bug.cgi?id=56606

This tests that clicking on a label for an input generates a click event on the input
with the same coordinates as the original click.

  • fast/events/simulated-click-coords-expected.txt: Added.
  • fast/events/simulated-click-coords.html: Added.

2011-05-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

event.clientX/clientY is 0/0 in a click generated through a label
https://bugs.webkit.org/show_bug.cgi?id=56606

This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
is a mouse event.

This makes us match Firefox and IE.

Test: fast/events/simulated-click-coords.html

  • dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
10:33 Changeset [86775] by zimmermann@webkit.org

2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sorted XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
10:19 WikiStart edited by oliver@apple.com
(diff)
10:19 WikiStart edited by oliver@apple.com
(diff)
10:15 Changeset [86774] by apavlov@chromium.org

2011-05-18 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Non-color CSS property values can get a color-picker
https://bugs.webkit.org/show_bug.cgi?id=61056

  • inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty): (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
10:01 Changeset [86773] by apavlov@chromium.org

Merge 86768 - 2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
https://bugs.webkit.org/show_bug.cgi?id=60811

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
  • inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7034027

09:58 WikiStart edited by oliver@apple.com
(diff)
09:43 QtWebKit edited by ademar.reis@openbossa.org
(diff)
09:43 QtWebKit edited by ademar.reis@openbossa.org
(diff)
09:42 QtWebKit edited by ademar.reis@openbossa.org
(diff)
09:41 QtWebKitSupportedStandards edited by ademar.reis@openbossa.org
(diff)
09:40 QtWebKitFeaturePlanning edited by ademar.reis@openbossa.org
(diff)
09:12 Changeset [86772] by psolanki@apple.com

2011-05-18 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Don't use DEFINE_STATIC_LOCAL with an unsigned
https://bugs.webkit.org/show_bug.cgi?id=61026

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here.
09:08 Changeset [86771] by rwlbuis@webkit.org

2011-05-18 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

  • css/CSSStyleSelector.cpp: (WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard): (WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard): (WebCore::isAcceptableForSVGElement): (WebCore::CSSStyleSelector::applyProperty):

2011-05-18 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

  • svg/custom/display-table-caption-foreignObject-expected.txt: Added.
  • svg/custom/display-table-caption-foreignObject.svg: Added.
  • svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Added.
  • svg/custom/display-table-caption-inherit-foreignObject.xhtml: Added.
  • svg/custom/display-table-caption-inherit-text-expected.txt: Added.
  • svg/custom/display-table-caption-inherit-text.xhtml: Added.
  • svg/custom/display-table-caption-text-expected.txt: Added.
  • svg/custom/display-table-caption-text.svg: Added.
09:02 Changeset [86770] by aroben@apple.com

Skip a new test that fails due to unimplemented WTR features

  • platform/mac-wk2/Skipped: Added http/tests/loading/nested_bad_objects.php.
08:58 Changeset [86769] by aroben@apple.com

Remove mac-wk2 expected failure results for a plugins test that I fixed in r86456

Fixes <http://webkit.org/b/57456> <rdar://problem/9209331>
plugins/embed-prefers-plugins-for-images.html failing on SnowLeopard Intel Release (WebKit2
Tests)

  • platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
  • platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed. We don't

need this extra passing result now that mac-wk2's failing result is gone.

08:52 Changeset [86768] by pfeldman@chromium.org

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
https://bugs.webkit.org/show_bug.cgi?id=60811

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
  • inspector/debugger/debugger-completions-on-call-frame.html: Added.

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
https://bugs.webkit.org/show_bug.cgi?id=60811

Test: inspector/debugger/debugger-completions-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):
08:47 Changeset [86767] by andreas.kling@nokia.com

2011-05-18 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
08:38 Changeset [86766] by aroben@apple.com

Add a new page to build.webkit.org to help find when tests started failing

The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
right now, but already shows some useful information. It's somewhat similar to webkit-patch
failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
little more convenient than either of them, though, because it's all done in the browser
(and thus it's easy to go directly to the relevant test results).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.

(Buildbot): This class represents a Buildbot server.
(Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Buildbot.prototype.builderNamed): Returns a Builder with the given name.
(Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
callback.
(Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
be implemented by a derived class that understands this server's build naming scheme.
(Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.

(Builder): This class represents one builder on the buildbot.
(Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
information about a particular test failure.
(Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
information about when tests started failing.
(Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
(Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
callback.
(Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
extracts all the failing tests listed in it, passing them to the callback.
(Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
build, merges them into the build history, and calls the callback telling it whether the
next build should be fetched to provide more information.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Added. Just some simple styles.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.

(createDefinitionList): Takes an array of pairs and turns them into a DL element.
(getResource): Wrapper around XMLHttpRequest.
(Array.prototype.findFirst): Finds the first element matching the given predicate and
returns it.
(Array.prototype.last): Returns the last element of the array.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.

(ViewController): This class contains the main logic for displaying the page.
(ViewController.loaded): Just calls through to parseHash.
(ViewController.parseHash): Either starts analyzing failures on a particular builder, or
shows the list of all testers so one can be chosen. This function is called when the page
loads and whenever we get a hashchange event.
(ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
as it is fetched. The display ends up grouping tests by when they started failing.
(ViewController._displayTesters): Gets the list of testers and displays it.

(ViewController._domForBuildName):
(ViewController._domForFailedTest):
Helper functions to create descriptions and links for a particular build or failed test.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.

(WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
(WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just

loads all the files and sets up a ViewController, which does the rest.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new

page.

08:35 Changeset [86765] by zimmermann@webkit.org

2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
https://bugs.webkit.org/show_bug.cgi?id=10749

Add tests for all elements using SVGAnimatedEnumeration in the SVG DOM API.

  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Update result, progression.
  • svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html: Added.
  • svg/dom/SVGAnimatedEnumeration-expected.txt:
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGClipPathElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEColorMatrixElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js: Added.
  • svg/dom/script-tests/SVGAnimatedEnumeration.js:
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: (executeTest):
  • svg/filters/feBlend-invalid-mode-expected.txt:
  • svg/filters/feComponentTransfer-style-crash-expected.txt:
  • svg/filters/feComponentTransfer-style-crash.xhtml:
  • svg/filters/feDisplacementMap-crash-test-expected.txt:
  • svg/filters/feDisplacementMap-crash-test.xhtml:

2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

All animated SVG enum properties are now ints
https://bugs.webkit.org/show_bug.cgi?id=10749

DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
(Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)

Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
Use the new SVGPropertyTraits everywhere in svg/.

This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
Example: <clipPath clipPathUnits="objectBoundingBox">
myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
We're now properly converting the enum values to strings.

Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:

  • SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
  • SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.

Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html

svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html

Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.

  • GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
  • platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
  • platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Ditto.
  • rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now. (WebCore::RenderSVGResourceClipper::clipPathUnits):
  • rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now. (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits):
  • rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform). (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h: Ditto.
  • rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  • rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now. (WebCore::RenderSVGResourceMarker::markerUnits):
  • rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now. (WebCore::RenderSVGResourceMasker::maskUnits): (WebCore::RenderSVGResourceMasker::maskContentUnits):
  • rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication. (WebCore::writeCommonGradientProperties):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto. (WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
  • svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType. (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
  • svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
  • svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
  • svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.

Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.

  • svg/SVGAnimatedInteger.idl: Ditto.
  • svg/SVGAnimatedNumber.idl: Ditto.
  • svg/SVGAnimatedString.idl: Ditto.
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec. (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.

It's not possible anymore for these values to go out of range.

  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()). (WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEBlendElement::build): Ditto.
  • svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()). (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.. (WebCore::SVGFEColorMatrixElement::build): Ditto.
  • svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()). (WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFECompositeElement::build): Ditto.
  • svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
  • svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()). (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync. (WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()). (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now. (WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()). (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFEMorphologyElement::build): Ditto.
  • svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()). (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now. (WebCore::SVGFETurbulenceElement::build): Ditto.
  • svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
  • svg/SVGFilterElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec. (WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
  • svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()). (WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special

as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.

(WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.

  • svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations. (WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'. (WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto. (WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
  • svg/SVGPatternElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
  • svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
  • svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
  • svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.

SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
the enums go out of range anymore (which lead to security bugs in the past).

(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param. (WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):
08:31 Changeset [86764] by kinuko@chromium.org

2011-05-18 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=59681

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/script-tests/storageinfo-request-quota.js: Added.
  • storage/storageinfo-request-quota-expected.txt: Added.
  • storage/storageinfo-request-quota.html: Added.

2011-05-18 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=59681

Test: storage/storageinfo-request-quota.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/StorageInfo.idl: Added requestQuota().
  • storage/StorageInfoQuotaCallback.idl: Added.
08:20 Changeset [86763] by reni@webkit.org

2011-05-18 Renata Hodovan <reni@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FEGaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=61049

The Gaussian blur filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is about 15% on dual-core machines.

Developed in cooperation with Gabor Loki and Zoltan Herczeg.

  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplyWorker): (WebCore::FEGaussianBlur::platformApply):
  • platform/graphics/filters/FEGaussianBlur.h:
08:06 Changeset [86762] by ossy@webkit.org

[Qt][WK2] Skip two failing tests.

  • platform/qt-wk2/Skipped:
08:04 Changeset [86761] by andreas.kling@nokia.com

2011-05-18 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Don't lie about supporting accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=61054

Until we have an implementation of LayerTreeHost, we shouldn't lie about it.

  • WebKit2.pro:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp: Added. (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
07:31 Changeset [86760] by pfeldman@chromium.org

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make parentId for frame optional.
https://bugs.webkit.org/show_bug.cgi?id=61032

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrame):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._addFrame):
07:27 Changeset [86759] by loki@webkit.org

2011-05-18 Gabor Loki <loki@webkit.org>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FELighting
https://bugs.webkit.org/show_bug.cgi?id=61048

The lighting filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 10-20% on dual-core machines.

Developed in cooperation with Zoltan Herczeg.

  • platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplyGenericPaint): (WebCore::FELighting::platformApplyGenericWorker): (WebCore::FELighting::platformApplyGeneric):
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp: (WebCore::FELighting::platformApplyNeonWorker):
  • platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):
07:12 Changeset [86758] by caio.oliveira@openbossa.org

2011-05-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
https://bugs.webkit.org/show_bug.cgi?id=60984

The code for converting objects to QVariantMap was causing exception,
that was "leaking" to the next evaluation. One situation was reading
the property 'localStorage' when we do not have a proper security
origin, which throws a SECURITY_ERR.

Now, we will simply not include on the QVariantMap those properties,
and make sure that we clean the exception if necessary.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariantMap): Extracted function that performs conversion from JSObject to a QVariantMap. This functions makes sure that exception is clean after its execution.

(JSC::Bindings::convertValueToQVariant):
Use the previous function. Add a comment explaining the choice of distance value.

07:11 Changeset [86757] by loislo@chromium.org

2011-05-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: scripts panel file selector element doesn't track keyboard events
https://bugs.webkit.org/show_bug.cgi?id=61047

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
07:01 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
06:50 Changeset [86756] by podivilov@chromium.org

2011-05-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
https://bugs.webkit.org/show_bug.cgi?id=60900

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h: (WebCore::ScriptDebugListener::Script::Script):
06:42 Changeset [86755] by zoltan@webkit.org

Remove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html

  • platform/mac-wk2/Skipped:
06:32 Changeset [86754] by apavlov@chromium.org

2011-05-18 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
https://bugs.webkit.org/show_bug.cgi?id=60966

  • inspector/styles/resources/styles-new-API-1.css:
  • inspector/styles/resources/styles-new-API-2.css: Copied from LayoutTests/inspector/styles/resources/styles-new-API-1.css. (@page): (@page :first): (#absent-id): (@font-face): (body):
  • inspector/styles/styles-new-API-expected.txt:

2011-05-18 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
https://bugs.webkit.org/show_bug.cgi?id=60966

Imported stylesheets didn't use to be returned by InspectorCSSAgent.

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getAllStyleSheets): (WebCore::InspectorCSSAgent::collectStyleSheets):
  • inspector/InspectorCSSAgent.h:
05:56 Changeset [86753] by zoltan@webkit.org

Add fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
eventSender.keyDown is unimplemented.

Reviewed by Csaba Osztrogonác.

  • platform/mac-wk2/Skipped:
05:04 Changeset [86752] by pfeldman@chromium.org

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
https://bugs.webkit.org/show_bug.cgi?id=61028

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
04:33 Changeset [86751] by commit-queue@webkit.org

2011-05-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86747.
http://trac.webkit.org/changeset/86747
https://bugs.webkit.org/show_bug.cgi?id=61039

Breaks JSC debugger tests. (Requested by pfeldman on #webkit).

  • inspector/InjectedScriptSource.js: ():
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
04:03 Changeset [86750] by yuzo@google.com

2011-05-18 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Removed duplcate entries added by r86749

  • platform/chromium/test_expectations.txt:
03:49 Changeset [86749] by yuzo@google.com

2011-05-18 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Since Chromium r85744, tests for <details> element pass on Mac and TEXT mismatch on Linux.

  • platform/chromium/test_expectations.txt:
03:45 Changeset [86748] by inferno@chromium.org

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Dirk Schulze.

Tests that we do not crash when trying to access a removed
smil element in animated elements list.
https://bugs.webkit.org/show_bug.cgi?id=60980

  • svg/animations/smil-element-not-removed-crash-expected.txt: Added.
  • svg/animations/smil-element-not-removed-crash.html: Added.

2011-05-18 Abhishek Arya <inferno@chromium.org>

Reviewed by Dirk Schulze.

When SMIL element is getting removed, make sure to remove it
from target's animation elements list.
https://bugs.webkit.org/show_bug.cgi?id=60980

Test: svg/animations/smil-element-not-removed-crash.html

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::~SVGSMILElement):
02:48 Changeset [86747] by pfeldman@chromium.org

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "Id" suffixes use consistent case.
https://bugs.webkit.org/show_bug.cgi?id=61028

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addMessageToConsole):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::parseLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._didEditScriptSource): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.scriptParsed): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript): (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId): (WebInspector.PresenationCallFrame):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.editSource):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.forceLoadContent): (WebInspector.SourceFile.prototype._concatenateScriptsContent): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector):
02:46 Changeset [86746] by mnaganov@chromium.org

2011-05-17 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
https://bugs.webkit.org/show_bug.cgi?id=60286

  • inspector/front-end/ProfilesPanel.js:

2011-05-17 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Enable detailed heap snapshots by default.
https://bugs.webkit.org/show_bug.cgi?id=60286

  • src/js/DevTools.js: ():
02:45 Changeset [86745] by pfeldman@chromium.org

2011-05-18 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
https://bugs.webkit.org/show_bug.cgi?id=60971

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showAnchorLocation.): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  • inspector/front-end/inspector.js: (WebInspector._showAnchorLocation):
02:33 Changeset [86744] by tkent@chromium.org

2011-05-18 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
https://bugs.webkit.org/show_bug.cgi?id=61021

Add test cases for the bug.

  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:

2011-05-18 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

valueMissing validity for <select> is lame when selecting a value by a key operation
https://bugs.webkit.org/show_bug.cgi?id=61021

We missed updating validity in case that SelectElement::defaultEventHandler
update selections. So, SelectElement::setSelectedIndex() updates validity.

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Remove unnecessary setNeedsValidityCheck() call. SelectElement::setSlectedIndex() calls it. (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
02:31 Changeset [86743] by mnaganov@chromium.org

2011-05-17 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Make retaining paths list of the Detailed
heap snapshots view resizable.
https://bugs.webkit.org/show_bug.cgi?id=60960

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.resize): (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging): (WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
  • inspector/front-end/heapProfiler.css:
02:10 Changeset [86742] by commit-queue@webkit.org

2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956

  • platform/qt/Skipped: Unskip fast/forms/onchange-setvalueforuser.html

2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setValueForUser):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement layoutTestController.setValueForUser()
https://bugs.webkit.org/show_bug.cgi?id=60956

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setValueForUser):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
00:38 Changeset [86741] by jer.noble@apple.com

2011-05-16 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60943

  • fullscreen/full-screen-keyboard-disabled-expected.txt: Added.
  • fullscreen/full-screen-keyboard-disabled.html: Added.
  • fullscreen/full-screen-keyboard-enabled-expected.txt: Added.
  • fullscreen/full-screen-keyboard-enabled.html: Added.

2011-05-16 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Disable keyboard input (with exceptions) in full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60943

Tests: fullscreen/full-screen-keyboard-disabled.html

fullscreen/full-screen-keyboard-enabled.html

  • page/EventHandler.cpp: (WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added. Implements the

list of allowed keyboard events in the proposed API.

(WebCore::EventHandler::keyEvent): Discard events which are not allowed in

full-screen mode.

  • page/EventHandler.h:
00:34 Changeset [86740] by gyuyoung.kim@samsung.com

2011-05-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix build break.

  • Source/cmake/WebKitMacros.cmake: Add -i option in order to include Lookup.h
00:19 Changeset [86739] by zimmermann@webkit.org

-2011-05-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Refactor TextRun creation
https://bugs.webkit.org/show_bug.cgi?id=60255

Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
the catch-it-all constructor, these helper functions are introduced, which hide the details of
creating a TextRun.

Furthermore it will be used to remove the platform layering violation, that TextRun stores
RenderObject pointers for the sake of SVG Fonts support, see bug 60254.

No change in functionaliy, no new tests.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
  • rendering/RenderBlock.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):

05/17/11:

23:16 Changeset [86738] by jer.noble@apple.com

2011-05-17 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=60982

The GraphicsLayer tree has unparented m_fullScreenRootLayer behind our backs, replacing the
tiled layer with a normal one. Instead of holding on to a specific layer, assume that the
w_rootLayer will only have 0 or 1 children, and if a child is present, then that is our full-
screen layer.

Additionally, check to see if the animating layer's presentationLayer is nil
before calling it; asking a nil object for a CATransform3D will give back a struct full of
garbage.

In WKFullScreenWindowController, when the exit animation completes, ignore the "completed"
parameter. This eliminates the possibility that the full screen window will end up left
on top of the screen if the animation is cancelled and a enter full screen animation isn't
forthcoming.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
23:12 Changeset [86737] by jer.noble@apple.com

2011-05-17 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60997

Updated the following tests with the new expectation that removing an element from the DOM will trigger
full screen mode to exit.

  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-ancestor.html:
  • fullscreen/full-screen-remove-children-expected.txt:
  • fullscreen/full-screen-remove-children.html:
  • fullscreen/full-screen-remove-expected.txt:
  • fullscreen/full-screen-remove.html:

2011-05-17 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=60997

Tests: fullscreen/full-screen-remove-ancestor.html

fullscreen/full-screen-remove-children.html
fullscreen/full-screen-remove.html

  • dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document

make sure to message the documentElement() as well.

(WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.

22:50 Changeset [86736] by ossy@webkit.org

[Qt] Skip failing tests on minor Qt platforms.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
22:22 Changeset [86735] by yuzo@google.com

2011-05-17 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests now pass:
fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html
fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html

  • platform/chromium/test_expectations.txt:
21:43 Changeset [86734] by mitz@apple.com

<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=61022

Reviewed by Alice Liu.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.

20:56 Changeset [86733] by yuzo@google.com

2011-05-17 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.

  • platform/chromium/test_expectations.txt:
20:50 Changeset [86732] by yutak@chromium.org

2011-05-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=60878

The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
expected results of tests that dump WebSocket.readyState.

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/handshake-error-expected.txt:
  • http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js: (ws.onclose):
  • http/tests/websocket/tests/script-tests/handshake-error.js: (ws.onclose):
  • http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/simple-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

2011-05-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=60878

No new tests are added because there is no change in functionality.

  • platform/network/SocketStreamHandleBase.h:
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:
20:47 Changeset [86731] by yuzo@google.com

2011-05-17 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

plugins/invalidate_rect.html now passes on Linux.

  • platform/chromium/test_expectations.txt:
20:23 Changeset [86730] by ggaren@apple.com

Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.

  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
20:07 Changeset [86729] by ggaren@apple.com

More attempts to work around the EFL build system being borken.

  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
20:03 Changeset [86728] by ggaren@apple.com

Try to fix the EFL build.

  • runtime/BooleanPrototype.cpp:
19:39 Changeset [86727] by ggaren@apple.com

Source/JavaScriptCore: Rolling back in r86653 with build fixed.

Reviewed by Gavin Barraclough and Oliver Hunt.

Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.

This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

  • create_hash_table: Added a special case for fromCharCode, since it uses

a custom "thunk generator".

  • heap/Heap.cpp:

(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.

  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):

  • runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):

  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):

  • runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):

  • runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):

  • runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h: Added new tables.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a

static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.

Even more global object properties can be made lazy, but that requires
more in-depth changes.

  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):

  • runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):

  • runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):

  • runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.

LayoutTests: Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Reviewed by Gavin Barraclough.

Added a few more expected failures, now that more code uses static hash
tables.

The fact that built-ins are not deletable, but should be, is covered by
https://bugs.webkit.org/show_bug.cgi?id=61014

  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
18:48 Changeset [86726] by morrita@google.com

2011-05-16 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] ShadowContentElement should be part of dom/
https://bugs.webkit.org/show_bug.cgi?id=59117

  • Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
  • Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
  • Added ShadowContentElement.cpp
  • Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
  • dom/Node.h: (WebCore::Node::forceReattach): Moved from static local function to share between classes.
  • dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::attach):
  • dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::isShadowBoundary): (WebCore::ShadowContentElement::rendererIsNeeded): (WebCore::ShadowContentElement::createRenderer):
  • dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor):
  • dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h. (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::recalcStyle):
  • html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsSummaryElement::DetailsSummaryElement):
  • html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement):
17:53 Changeset [86725] by cdn@chromium.org

2011-05-17 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
https://bugs.webkit.org/show_bug.cgi?id=61005

Test: http/tests/loading/nested_bad_objects.php

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2011-05-17 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when two nested image objects with invalid data are loaded.
https://bugs.webkit.org/show_bug.cgi?id=61005

  • http/tests/loading/nested_bad_objects-expected.txt: Added.
  • http/tests/loading/nested_bad_objects.php: Added.
17:29 Changeset [86724] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.

Rubberstamped by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put

SnowLeopard build guards around the shim install path.

17:21 Changeset [86723] by abarth@webkit.org

2011-05-17 Adam Barth <abarth@webkit.org>

Rubber-stamped by Simon Fraser.

Remove empty directory.

  • fast/inspector: Removed.
17:12 Changeset [86722] by crogers@google.com

2011-05-17 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
https://bugs.webkit.org/show_bug.cgi?id=60995

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: (WebCore::AudioNode::ref):
17:08 Changeset [86721] by commit-queue@webkit.org

2011-05-17 Tao Bai <michaelbai@chromium.org>

Reviewed by Darin Fisher.

Clear deprecated icon APIs from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=60989

  • public/WebFrame.h: Removed faviconURL()
  • public/WebFrameClient.h: Removed didChangeIcons()
  • src/FrameLoaderClientImpl.cpp:

Removed the code to support deprecated API

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

  • src/WebFrameImpl.cpp: Removed faviconURL()
  • src/WebFrameImpl.h: Removed faviconURL()
16:42 Changeset [86720] by beidson@apple.com

2011-05-17 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/9366728> and https://webkit.org/b/60796
Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]

Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
This change has the following benefits:

  • Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect themselves, check these variables as often, or ASSERT them.
  • ResourceLoader subclasses no longer have to call the base class ::didCancel
  • ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the cancellation is completed inside the last call.

No new tests - No change in behavior for previous tests, and new test would require API usage outside
the scope of DumpRenderTree.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
  • loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().

Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willCancel): (WebCore::MainResourceLoader::didCancel):
  • loader/MainResourceLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel() (WebCore::NetscapePlugInStreamLoader::willCancel): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/NetscapePlugInStreamLoader.h:

Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willCancel): (WebCore::SubresourceLoader::didCancel):
  • loader/SubresourceLoader.h:
16:39 Changeset [86719] by commit-queue@webkit.org

2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86668.
http://trac.webkit.org/changeset/86668
https://bugs.webkit.org/show_bug.cgi?id=61001

It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
#webkit).

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
16:21 Changeset [86718] by bweinstein@apple.com

Build fix after r86717.

  • UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget
16:15 Changeset [86717] by bweinstein@apple.com

WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/9090868>

Reviewed by Adam Roben.

Add API to set a custom drop target on a WKView.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the

custom one.

  • UIProcess/win/WebView.h:
16:10 Changeset [86716] by rniwa@webkit.org

2011-05-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=60998

Converted the tests.

  • editing/pasteboard/paste-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-2.html:
  • editing/pasteboard/paste-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-3.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
16:03 Changeset [86715] by rniwa@webkit.org

2011-05-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/paste-text-012.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=60996

Converted the test.

  • editing/pasteboard/paste-text-012-expected.txt: Added.
  • editing/pasteboard/paste-text-012.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.
15:49 Changeset [86714] by weinig@apple.com

2011-05-17 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add API to determine if a frame has any form elements without going to javascript
https://bugs.webkit.org/show_bug.cgi?id=60999

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameContainsAnyFormElements):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::containsAnyFormElements):
  • WebProcess/WebPage/WebFrame.h: Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine if there are any form elements.
15:34 Changeset [86713] by commit-queue@webkit.org

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Always set layerRenderer, even on non-drawn-layers
https://bugs.webkit.org/show_bug.cgi?id=60977

This is a defensive fixe for crbug.com/82799, in which
a RenderLayer could not prepare itself because its owning layerImpl
had no associated layerRenderer. The underlying issue is that we
sometimes put renderSurfaces onto the list that won't actually render.
For now, the priority is to reduce fragility so that invisible layers
dont lead to crashers. We do this by being more agressive about
binding CCLayerImpls to the LayerRenderer, doing it all the time rather
than only when we think it will get rendered.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents):
15:32 Changeset [86712] by weinig@apple.com

2011-05-17 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

JSGlobalContextRelease should not trigger a synchronous garbage collection
https://bugs.webkit.org/show_bug.cgi?id=60990

  • API/JSContextRef.cpp: Change synchronous call to collectAllGarbage to a call to trigger the activityCallback.
15:31 Changeset [86711] by cdn@chromium.org

Merge 86219 - 2011-05-10 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Fix a bug of WebFrameImpl::forms()
https://bugs.webkit.org/show_bug.cgi?id=60606

If document()->forms() contained non-HTML element, the second for
loop didn't stop.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().

BUG=82154
Review URL: http://codereview.chromium.org/7039019

15:07 Changeset [86710] by dcheng@chromium.org

2011-05-17 Daniel Cheng <dcheng@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Clipboard policy callbacks from EditorClientImpl are reversed
https://bugs.webkit.org/show_bug.cgi?id=60994

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
15:00 Changeset [86709] by robert@webkit.org

2011-05-17 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

Skip on qt-mac

http://bugs.webkit.org/show_bug.cgi?id=60838

  • platform/qt-mac/Skipped:
14:45 Changeset [86708] by andersca@apple.com

Fix the clang build.

  • rendering/RenderText.h:

(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.

14:33 Changeset [86707] by arv@chromium.org

2011-05-17 Erik Arvidsson <arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
https://bugs.webkit.org/show_bug.cgi?id=49509

This tests that an iframe is the activeElement when focus is inside that frame.

  • fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
  • fast/dom/HTMLDocument/active-element-frames.html: Added.

2011-05-17 Erik Arvidsson <arv@chromium.org>

Reviewed by Ryosuke Niwa.

document.activeElement doesn't point to the focused frame
https://bugs.webkit.org/show_bug.cgi?id=49509

This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.

Test: fast/dom/HTMLDocument/active-element-frames.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.
13:57 Changeset [86706] by robert@webkit.org

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

https://bugs.webkit.org/show_bug.cgi?id=54051

  • platform/qt/Skipped: Unskip plugins/invalidate_rect.html
  • platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

Add ChromeClientQt::allowsAcceleratedCompositing().

https://bugs.webkit.org/show_bug.cgi?id=54051

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
  • WebCoreSupport/ChromeClientQt.h:

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

plugins/invalidate_rect.html fails on linux ports

  • Make the unix test netscape plugin recognize the onPaintEvent and windowedPlugin parameters.

https://bugs.webkit.org/show_bug.cgi?id=54051

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::displayInvalidatedRegion):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event):
13:57 Changeset [86705] by eae@chromium.org

2011-05-17 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change nodeAtPoint to take IntPoint instead of int x, int y
https://bugs.webkit.org/show_bug.cgi?id=60663

Change nodeAtPoint to take a single const IntPoint& instead of a pair of
ints for the location.

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::flooredIntPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): (WebCore::RenderObject::nodeAtPoint):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
13:39 Changeset [86704] by atwilson@chromium.org

2011-05-17 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86647.
http://trac.webkit.org/changeset/86647
https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-17 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86647.
http://trac.webkit.org/changeset/86647
https://bugs.webkit.org/show_bug.cgi?id=56814

Broke tests downstream in Chromium

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
13:38 Changeset [86703] by atwilson@chromium.org

2011-05-17 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86656.
http://trac.webkit.org/changeset/86656

Broke tests downstream in Chromium

  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
13:30 Changeset [86702] by tony@chromium.org

2011-05-17 Tony Chang <tony@chromium.org>

Land linux 32 bit results.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:26 Changeset [86701] by atwilson@chromium.org

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
13:20 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
13:04 Changeset [86700] by commit-queue@webkit.org

2011-05-17 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030

  • fast/events/touch/document-create-touch-expected.txt:
  • fast/events/touch/script-tests/document-create-touch.js:

2011-05-17 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030

  • dom/Document.cpp: (WebCore::Document::createTouch):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Touch.cpp: (WebCore::Touch::Touch):
  • dom/Touch.h: (WebCore::Touch::create): (WebCore::Touch::webkitRadiusX): (WebCore::Touch::webkitRadiusY): (WebCore::Touch::webkitRotationAngle):
  • dom/Touch.idl:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::radiusX): (WebCore::PlatformTouchPoint::radiusY): (WebCore::PlatformTouchPoint::rotationAngle):

2011-05-17 Yufeng Shen <miletus@chromium.org>

Reviewed by Darin Fisher.

Make WebKit expose extra touch information
https://bugs.webkit.org/show_bug.cgi?id=59030

  • public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
  • src/WebInputEventConversion.cpp: (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
13:02 Changeset [86699] by oliver@apple.com

2011-05-16 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Reduce code size for inline cache
https://bugs.webkit.org/show_bug.cgi?id=60942

This patch introduces the concept of a "compact" address that
allows individual architectures to control the maximum offset
used for the inline path of get_by_id. This reduces the code
size of get_by_id by 3 bytes on x86 and x86_64 and slightly
improves performance on v8 tests.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::repatchCompact):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::repatchCompact):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::AbstractMacroAssembler::repatchCompact):
  • assembler/CodeLocation.h: (JSC::CodeLocationDataLabelCompact::CodeLocationDataLabelCompact): (JSC::CodeLocationCommon::dataLabelCompactAtOffset):
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::locationOf):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::repatchCompact):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::load32WithAddressOffsetPatch):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::repatchCompact):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::loadCompactWithAddressOffsetPatch):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithCompactAddressOffsetPatch):
  • assembler/RepatchBuffer.h: (JSC::RepatchBuffer::repatch):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::repatchCompact):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_mr_disp8): (JSC::X86Assembler::movq_mr_disp8): (JSC::X86Assembler::repatchCompact): (JSC::X86Assembler::setInt8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::patchGetByIdSelf):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID):
12:45 Changeset [86698] by eric@webkit.org

2011-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Add a LineLayoutState object to hold global state during line layout
https://bugs.webkit.org/show_bug.cgi?id=60113

Like LayoutState for layout(), LineLayoutState keeps track of global information
during an entire linebox tree layout pass (aka layoutInlineChildren).

For now it just holds isFullLayout and the logicalRepaintTop/Bottom.
It's possible we should hold the useRepaintBounds bool as well as
the startLine and endLine RootInlineBox pointers.

No change in behavior, thus no tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineLayoutState::LineLayoutState): (WebCore::LineLayoutState::markForFullLayout): (WebCore::LineLayoutState::isFullLayout): (WebCore::LineLayoutState::setRepaintRange): (WebCore::LineLayoutState::updateRepaintRangeFromBox): (WebCore::LineLayoutState::startLine): (WebCore::LineLayoutState::endLine): (WebCore::deleteLineRange): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkFloatsInCleanLine): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine):
12:35 Changeset [86697] by caio.oliveira@openbossa.org

2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
https://bugs.webkit.org/show_bug.cgi?id=60978

Backslash to escape newlines was confusing both prepare-ChangeLog and the
QtCreator highlight system.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::evalJSV): Remove usage of backslash to escape newlines in string literal.
12:29 Changeset [86696] by tony@chromium.org

2011-05-17 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=60895

Update the tools to handle the move. Lucid 32 results now go in
chromium-linux-x86 and the default platform on Linux is now x86_64.

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
  • Scripts/webkitpy/layout_tests/port/base.py: ditto
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
12:26 Changeset [86695] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
https://bugs.webkit.org/show_bug.cgi?id=54636

  • fast/images/imagemap-dynamic-area-updates-expected.txt: Added.
  • fast/images/imagemap-dynamic-area-updates.html: Added.
  • fast/images/script-tests/imagemap-dynamic-area-updates.js: Added. (setArea): (checkForArea):

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Area element doesn't update region when dynamically altered.
https://bugs.webkit.org/show_bug.cgi?id=54636

Recompute the clickable region after the "shape" or "coords" attribute
of an area element is changed.

Test: fast/images/imagemap-dynamic-area-updates.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): (WebCore::HTMLAreaElement::invalidateCachedRegion):
  • html/HTMLAreaElement.h:
12:00 Changeset [86694] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Initial support for favicons.
https://bugs.webkit.org/show_bug.cgi?id=58937

Add the following API to QWKContext:

  • void setIconDatabasePath(QString)
  • void iconChangedForPageURL(QUrl) [signal]
  • QIcon iconForPageURL(QUrl)

This is mostly analogous to the QWebSettings/QWebFrame icon API we had in WebKit1.

  • UIProcess/API/qt/ClientImpl.h: Added WKIconDatabaseClient methods.
  • UIProcess/API/qt/ClientImpl.cpp: (toQWKContext): Helper to cast from "void* clientInfo" to a QWKContext*. (qt_wk_didChangeIconForPageURL): Emits QWKContext::iconChangedForPageURL(QUrl). (qt_wk_didRemoveAllIcons): Stub.
  • UIProcess/API/qt/qwkcontext.h:
  • UIProcess/API/qt/qwkcontext_p.h:
  • UIProcess/API/qt/qwkcontext.cpp: (QWKContextPrivate::QWKContextPrivate): Set up and register a WKIconDatabaseClient. (QWKContext::QWKContext): Minor refactor to avoid code duplication in constructors. (QWKContext::setIconDatabasePath): Exactly what it sounds like. (QWKContext::iconForPageURL): Retrieves the favicon for a given page URL as a QIcon.
  • WebKit2API.pri: Add WKIconDatabase.cpp and WKIconDatabase.h to build.
12:00 Changeset [86693] by luiz@webkit.org

[Qt] Redirection of HTTP POST (3xx) incorrectly includes original POST data
https://bugs.webkit.org/show_bug.cgi?id=60440

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Makes sure that the HTTP headers Content-type and Content-length are not included in
the requests that do not have any content.

Tests: http/tests/navigation/post-301-response.html

http/tests/navigation/post-302-response.html
http/tests/navigation/post-303-response.html
http/tests/navigation/post-307-response.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendNetworkRequest):

LayoutTests:

These new tests check that no POST content is sent to the new URL after receiving http
status codes 301, 302 and 303, and checks that the POST content is sent to the new URL
after receiving a 307 http status code.

  • http/tests/navigation/post-301-response-expected.txt: Added.
  • http/tests/navigation/post-301-response.html: Added.
  • http/tests/navigation/post-302-response-expected.txt: Added.
  • http/tests/navigation/post-302-response.html: Added.
  • http/tests/navigation/post-303-response-expected.txt: Added.
  • http/tests/navigation/post-303-response.html: Added.
  • http/tests/navigation/post-307-response-expected.txt: Added.
  • http/tests/navigation/post-307-response.html: Added.
  • http/tests/navigation/resources/redirected-post-request-contents.php: Added.
  • http/tests/navigation/resources/redirection-response.php: Added.
11:57 Changeset [86692] by beidson@apple.com

Part 4 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

This patch actually hooks up the shim to the WebProcess shim callbacks, which messages these
4 calls up to the UIProcess and returns the result.

Note that this patch uncovered the fact that CoreIPC can't sync message out from a secondary thread,
so I filed https://bugs.webkit.org/show_bug.cgi?id=60975 as a followup to allow that.

  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::SecItemResponseData): Reorder the constructor arguments to be

a little cleaner.

  • Shared/mac/SecItemResponseData.h:

Call the shim callbacks for each method:

  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):

Implement the shim callbacks, which each marshall to the main thread, which then calls out to CoreIPC:

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatchingMainThread):
(WebKit::WebSecItemCopyMatching):
(WebKit::WebSecItemAddOnMainThread):
(WebKit::WebSecItemAdd):
(WebKit::WebSecItemUpdateOnMainThread):
(WebKit::WebSecItemUpdate):
(WebKit::WebSecItemDeleteOnMainThread):
(WebKit::WebSecItemDelete):

Add the 4 messages and their implementations in the UIProcess:

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebProcessProxyMac.mm: Added.

(WebKit::WebProcessProxy::secItemCopyMatching):
(WebKit::WebProcessProxy::secItemAdd):
(WebKit::WebProcessProxy::secItemUpdate):
(WebKit::WebProcessProxy::secItemDelete):

  • WebKit2.xcodeproj/project.pbxproj:
11:37 Changeset [86691] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] GraphicsLayerQtImpl: Remove an unused variable.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::paint):
11:16 Changeset [86690] by kerz@chromium.org

Merge 86290 - 2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Expose shouldBufferData to ThreadableLoaderOptions to be able to disable buffering of the
loaded resource.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest): Pass the shouldBufferData to the resource load scheduler, forcing it to true for the preflight request.
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Pass through shouldBufferData to SubresourceLoader::create
  • loader/ResourceLoadScheduler.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Set shouldBufferData on the newly created loader
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Add shouldBufferData to the options, defaulting to true.

2011-05-11 Antoine Labour <piman@chromium.org>

Reviewed by David Levin.

Don't buffer data for resources loaded by AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=60656

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7019016

11:08 Changeset [86689] by andersca@apple.com

2011-05-17 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Incomplete page painting at dropbox.com
https://bugs.webkit.org/show_bug.cgi?id=60974
<rdar://problem/9448213>

When we're exiting compositing mode and haven't sent an EnterAcceleratedCompositingMode
message to the UI process, we still need to send the updated bits to the ui process.


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
11:06 Changeset [86688] by beidson@apple.com

Part 3 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add CoreIPC stuff we'll need to marshall the SecItem calls to the UIProcess and back.

Teach ArgumentCodersCF about CFDateRef, SecKeychainItemRef, and generic CFTypeRefs:

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):

  • Shared/cf/ArgumentCodersCF.h:

Serializable object that contains the query CFDictionaryRef and optionally the
"attributesToMatch" CFDictionaryRef:

  • Shared/mac/SecItemRequestData.cpp: Added.

(WebKit::SecItemRequestData::SecItemRequestData):
(WebKit::SecItemRequestData::encode):
(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h: Added.

(WebKit::SecItemRequestData::query):
(WebKit::SecItemRequestData::attributesToMatch):

Serializable object that returns an OSStatus and optionally a "result object" CFTypeRef:

  • Shared/mac/SecItemResponseData.cpp: Added.

(WebKit::SecItemResponseData::SecItemResponseData):
(WebKit::SecItemResponseData::encode):
(WebKit::SecItemResponseData::decode):

  • Shared/mac/SecItemResponseData.h: Added.

(WebKit::SecItemResponseData::resultObject):
(WebKit::SecItemResponseData::resultCode):

  • WebKit2.xcodeproj/project.pbxproj:
10:49 Changeset [86687] by apavlov@chromium.org

Merge 86683 - 2011-05-17 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
https://bugs.webkit.org/show_bug.cgi?id=60970

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7037012

10:39 Changeset [86686] by beidson@apple.com

Part 2 of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Hookup some of the methods we plan to shim in the patch, but just have them call through
to the actual implementations for now.

Also stub-out the future shimmed versions of the methods.

  • WebProcess/mac/WebProcessShim.h: Add the methods to the shim callbacks.
  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecItemCopyMatching): Call through to the actual function for now.
(WebKit::shimSecItemAdd): Ditto.
(WebKit::shimSecItemUpdate): Ditto.
(WebKit::shimSecItemDelete): Ditto.
(WebKit::WebKitWebProcessShimInitialize): Copy over the shim callbacks.

  • WebKit2.xcodeproj/project.pbxproj: Link the shim to required frameworks.


  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebSecItemCopyMatching): Add placeholders for the future to-be-shimmed functions.
(WebKit::WebSecItemAdd): Ditto.
(WebKit::WebSecItemUpdate): Ditto.
(WebKit::WebSecItemDelete): Ditto.
(WebKit::WebProcess::initializeShim): Pass along those placeholders to the shim initializer.

10:38 Changeset [86685] by kerz@chromium.org

Revert 84311 - REGRESSION(r55762): Highlight color can't be copied in gmail.
https://bugs.webkit.org/show_bug.cgi?id=58925
<rdar://problem/9253057>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/pasteboard/copy-text-with-backgroundcolor.html

The changes of r55762 uncovered the underlying issue here. The markup fragment
placed in the pasteboard does not contain the background color style.
This occurs only if the selection is limited to a single text node, whereas if the
selection spans across multiple nodes, the style is preserved correctly.
The fix consists in changing the logic that decides whether we should include the wrapping
node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
on isElementPresentational to choose candidates to be the wrapping node.
I've extended it to accept nodes that have non fully transparent background colors.

  • editing/Editor.cpp:

(WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.

  • editing/Editor.h:
  • editing/markup.cpp:

(WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.

LayoutTests:

The following test checks that when we copy a text node surrounded by an element that
has non transparent background color we preserve the background color as well.

  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Added.
  • editing/pasteboard/copy-text-with-backgroundcolor.html: Added.

TBR=enrica@apple.com
Review URL: http://codereview.chromium.org/7031026

10:36 Changeset [86684] by kerz@chromium.org

Revert 85494 - MERGE 85090 - 2011-04-27 Enrica Casucci <enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

2011-04-27 Enrica Casucci <enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

http://crbug.com/80498

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6975019

10:27 Changeset [86683] by pfeldman@chromium.org

2011-05-17 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: navigating from elements panel does not show source view.
https://bugs.webkit.org/show_bug.cgi?id=60970

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
10:25 Changeset [86682] by commit-queue@webkit.org

2011-05-17 Sakamuri Ramakrishna <ramakrishna.sakamuri@nokia.com>

Reviewed by Andreas Kling.

[Qt] 4 of the skipped storage layout tests pass on Qt Linux- skip list to be modified
https://bugs.webkit.org/show_bug.cgi?id=60715

  • platform/qt/Skipped:
10:23 Changeset [86681] by antonm@chromium.org

2011-05-17 Anton Muhin <antonm@chromium.org>

Unreviewed.

Improving test expectations.

  • platform/chromium/test_expectations.txt:
10:16 Changeset [86680] by andreas.kling@nokia.com

2011-05-17 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
https://bugs.webkit.org/show_bug.cgi?id=40841

Test: compositing/animation/busy-indicator.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::TransformAnimationQt::getAnimatedProperty): (WebCore::OpacityAnimationQt::getAnimatedProperty): (WebCore::GraphicsLayerQt::addAnimation):

2011-05-17 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Node that have both an opacity and a transform animation on them seem not to fire.
https://bugs.webkit.org/show_bug.cgi?id=40841

  • compositing/animation/busy-indicator-no.png: Added.
  • compositing/animation/busy-indicator.html: Added.
  • compositing/animation/busy-indicator.png: Added.
  • compositing/animation/busy-indicator-expected.txt: Added.
10:13 Changeset [86679] by commit-queue@webkit.org

2011-05-17 Grace Kloba <klobag@chromium.org>

Reviewed by Kenneth Russell.

GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
https://bugs.webkit.org/show_bug.cgi?id=60965

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
10:12 Changeset [86678] by beidson@apple.com

Part one of <rdar://problem/8814289> and https://bugs.webkit.org/show_bug.cgi?id=60595
Mac WebKit2 WebProcess needs a shim to make prompts appear to be from the UIProcess

Reviewed by Anders Carlsson.

Add am empty shim for a new WebProcess shim and install it at launch.

Use the same Shim.xcconfig for both the web and plugin processes:

  • Configurations/PluginProcessShim.xcconfig: Removed.
  • Configurations/Shim.xcconfig: Copied from Configurations/PluginProcessShim.xcconfig.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.h: Add initializeShim() for Mac-only
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim): Initialize the (empty) shim callbacks.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Call initializeShim()

  • WebProcess/mac/WebProcessShim.h: Added.
  • WebProcess/mac/WebProcessShim.mm: Added.

(WebKit::WebKitWebProcessShimInitialize): Empty for now.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Install the Plugin Process shim for plugin processes

and the WebProcess shim for the web content process.

10:05 Changeset [86677] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Bot-matching rebaseline after r86675.

  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
09:57 Changeset [86676] by sullivan@apple.com

Loose end from fix for https://bugs.webkit.org/show_bug.cgi?id=60938

Reviewed by Adam Roben.

  • WebKit2.xcodeproj/project.pbxproj:

Made new header file "private" instead of "project" so clients can access it.

09:34 Changeset [86675] by commit-queue@webkit.org

2011-05-17 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] rebaseline skipped tests after r83871
https://bugs.webkit.org/show_bug.cgi?id=60961

Rebaseline tests after r83871 and remove them from Qt Skipped file.

  • platform/qt/Skipped:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/qt/http/tests/misc/error404-expected.txt:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
  • platform/qt/http/tests/misc/iframe404-expected.txt:
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/qt/http/tests/uri/css-href-expected.txt:
  • platform/qt/tables/layering/paint-test-layering-1-expected.txt:
  • platform/qt/tables/layering/paint-test-layering-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/qt/tables/mozilla/other/slashlogo-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
  • platform/qt/transitions/svg-text-shadow-transition-expected.txt:
09:24 Changeset [86674] by apavlov@chromium.org

2011-05-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Enter/Tab after editing a CSS property does not invoke editor on next field
https://bugs.webkit.org/show_bug.cgi?id=60962

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
09:03 Changeset [86673] by jberlin@webkit.org

WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197

Add fast/images/animated-gif-restored-from-bfcache.html to the mac-wk2 Skipped list to get
the bots green.

  • platform/mac-wk2/Skipped:
07:39 Changeset [86672] by podivilov@chromium.org

2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
http://trac.webkit.org/changeset/86660
https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86660.
http://trac.webkit.org/changeset/86660
https://bugs.webkit.org/show_bug.cgi?id=60958

broke search in console panel (Requested by podivilov on
#webkit).

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
06:29 Changeset [86671] by aroben@apple.com

Make run-api-tests work on Windows when there are spaces in the path

Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
spaces in the path to TestWebKitAPI.exe

Reviewed by David Levin.

  • Scripts/run-api-tests:

(runTestTool): Use the "direct object" form of system() to avoid having the path to
TestWebKitAPI.exe be split by the shell.

06:06 Changeset [86670] by alexis.menard@openbossa.org

2011-05-17 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix introduced by r86377.

  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
04:51 Changeset [86669] by yutak@chromium.org

2011-05-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper
https://bugs.webkit.org/show_bug.cgi?id=60945

Add ThreadableWebSocketChannelClientWrapper.cpp. Uninline methods in this class and
move these definitions into .cpp in order to allow further modifications in this class.

No new tests, as this is just refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Added. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::create): (WebCore::ThreadableWebSocketChannelClientWrapper::clearSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::setSyncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::syncMethodDone): (WebCore::ThreadableWebSocketChannelClientWrapper::sent): (WebCore::ThreadableWebSocketChannelClientWrapper::setSent): (WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount): (WebCore::ThreadableWebSocketChannelClientWrapper::clearClient): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
04:39 Changeset [86668] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
https://bugs.webkit.org/show_bug.cgi?id=60901

To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy):
04:36 Changeset [86667] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support shadowed text in fast font path.
https://bugs.webkit.org/show_bug.cgi?id=60462

  • platform/graphics/Font.cpp: (WebCore::Font::drawText): Remove complex path shortcut for shadowed text.
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawGlyphs): Paint shadows for simple text.
04:34 Changeset [86666] by andreas.kling@nokia.com

2011-05-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Construct GraphicsLayerQtImpl::State with correct values.
https://bugs.webkit.org/show_bug.cgi?id=60902

The GraphicsLayerQtImpl initial state should match the initial values
of the corresponding GraphicsLayer flags.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::State::State):
03:12 Changeset [86665] by hans@chromium.org

2011-05-12 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
https://bugs.webkit.org/show_bug.cgi?id=60697

Test that we can create a new index for which not all current records
have a key.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:

2011-05-12 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Index population should ignore records without key for index
https://bugs.webkit.org/show_bug.cgi?id=60697

When populating a new index, records which do not have a key on the
index's key path should be ignored.

  • storage/IDBObjectStoreBackendImpl.cpp:
02:46 Changeset [86664] by commit-queue@webkit.org

2011-05-17 Young Han Lee <joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60947

No new tests. Build fix.

  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapper::create):
  • platform/graphics/qt/TextureMapperQt.h: (WebCore::TextureMapperQt::create):
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):

2011-05-17 Young Han Lee <joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60947

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQWidget::setRootGraphicsLayer):
02:34 Changeset [86663] by apavlov@chromium.org

2011-05-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
https://bugs.webkit.org/show_bug.cgi?id=60890

  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:

2011-05-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Increment/decrement of very big CSS numeric values results in invalid CSS
https://bugs.webkit.org/show_bug.cgi?id=60890

  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.alteredFloatNumber): (WebInspector.StylePropertyTreeElement.prototype):
02:31 Changeset [86662] by yuzo@google.com

2011-05-17 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests are flaky on Linux.
fast/speech/input-appearance-numberandspeech.html
fast/speech/input-appearance-searchandspeech.html
fast/speech/input-appearance-speechbutton.html

  • platform/chromium/test_expectations.txt:
02:11 Changeset [86661] by yuzo@google.com

2011-05-17 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/js/mozilla/strict/eval-variable-environment.html now passes.

  • platform/chromium/test_expectations.txt:
01:59 Changeset [86660] by podivilov@chromium.org

2011-05-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
https://bugs.webkit.org/show_bug.cgi?id=54670

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-add.html:
  • http/tests/inspector/resource-tree/resource-tree-frame-navigate.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
00:37 Changeset [86659] by yutak@chromium.org

2011-05-16 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
https://bugs.webkit.org/show_bug.cgi?id=60880

  • http/tests/websocket/tests/handshake-error-expected.txt: Remove a carriage return in the first line.

2011-05-16 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketHandshake prints a carriage return to console
https://bugs.webkit.org/show_bug.cgi?id=60880

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine): WebSocketHandshake should not print a carriage return to console. To fix this, we first check whether the status line ends with CRLF. After that, we can print the first (lineLength - 2) characters of the status line which do not contain a carriage return.

05/16/11:

23:59 Changeset [86658] by yuzo@google.com

2011-05-16 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

http/tests/appcache/interrupted-update.html is flaky on win, mac, and linux.

  • platform/chromium/test_expectations.txt:
23:12 Changeset [86657] by commit-queue@webkit.org

2011-05-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86653.
http://trac.webkit.org/changeset/86653
https://bugs.webkit.org/show_bug.cgi?id=60944

"Caused regressions on Windows, OSX and EFL" (Requested by
yutak on #webkit).

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • create_hash_table:
  • heap/Heap.cpp: (JSC::TypeCounter::operator()):
  • interpreter/CallFrame.h: (JSC::ExecState::arrayTable): (JSC::ExecState::numberTable):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncJSCPrint):
  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot):
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
22:55 Changeset [86656] by morrita@google.com

2011-05-16 MORITA Hajime <morrita@google.com>

Unreviewed build fix for r86647, which broke SUPPORT_AUTOCORRECTION_PANEL.

  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
22:11 Changeset [86655] by yuzo@google.com

2011-05-16 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/hixie/perf/00{1,2}.xml now pass on Linux.

  • platform/chromium/test_expectations.txt:
21:26 Changeset [86654] by tkent@chromium.org

2011-05-16 Kent Tamura <tkent@chromium.org>

Fix Leopard build.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Use double instead of int.
21:08 Changeset [86653] by ggaren@apple.com

2011-05-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933


Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.


This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

  • create_hash_table: Added a special case for fromCharCode, since it uses a custom "thunk generator".
  • heap/Heap.cpp: (JSC::TypeCounter::operator()): Fixed a bug where the type counter would overcount objects that were owned through more than one mechanism because it was getting in the way of counting the results for this patch.
  • interpreter/CallFrame.h: (JSC::ExecState::arrayConstructorTable): (JSC::ExecState::arrayPrototypeTable): (JSC::ExecState::booleanPrototypeTable): (JSC::ExecState::dateConstructorTable): (JSC::ExecState::errorPrototypeTable): (JSC::ExecState::globalObjectTable): (JSC::ExecState::numberConstructorTable): (JSC::ExecState::numberPrototypeTable): (JSC::ExecState::objectPrototypeTable): (JSC::ExecState::regExpPrototypeTable): (JSC::ExecState::stringConstructorTable): Added new tables.
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::ArrayConstructor::getOwnPropertySlot): (JSC::ArrayConstructor::getOwnPropertyDescriptor):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::createStructure):
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::getOwnPropertySlot): (JSC::ArrayPrototype::getOwnPropertyDescriptor):
  • runtime/ArrayPrototype.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype): (JSC::BooleanPrototype::getOwnPropertySlot): (JSC::BooleanPrototype::getOwnPropertyDescriptor):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::createStructure):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): (JSC::DateConstructor::getOwnPropertySlot): (JSC::DateConstructor::getOwnPropertyDescriptor):
  • runtime/DateConstructor.h: (JSC::DateConstructor::createStructure):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype): (JSC::ErrorPrototype::getOwnPropertySlot): (JSC::ErrorPrototype::getOwnPropertyDescriptor):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::createStructure): Standardized these objects to use static tables for function properties.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
  • runtime/JSGlobalData.h: Added new tables.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::addStaticGlobals): (JSC::JSGlobalObject::getOwnPropertySlot): (JSC::JSGlobalObject::getOwnPropertyDescriptor):
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a static table for its global functions. This required uninlining some things to avoid a circular header dependency. However, those things probably shouldn't have been inlined in the first place.


Even more global object properties can be made lazy, but that requires
more in-depth changes.

  • runtime/MathObject.cpp:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::getOwnPropertySlot): (JSC::NumberConstructor::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype): (JSC::NumberPrototype::getOwnPropertySlot): (JSC::NumberPrototype::getOwnPropertyDescriptor):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::createStructure):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::put): (JSC::ObjectPrototype::getOwnPropertySlot): (JSC::ObjectPrototype::getOwnPropertyDescriptor):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::createStructure):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::RegExpPrototype::getOwnPropertySlot): (JSC::RegExpPrototype::getOwnPropertyDescriptor):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::createStructure):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): (JSC::StringConstructor::getOwnPropertySlot): (JSC::StringConstructor::getOwnPropertyDescriptor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::createStructure): Standardized these objects to use static tables for function properties.
19:51 Changeset [86652] by jamesr@google.com

2011-05-16 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Decouple LayerChromium/CCLayerImpl trees
https://bugs.webkit.org/show_bug.cgi?id=58830

Makes the CCLayerImpl tree self-hosting and provides an explicit step
to synchronize the LayerChromium tree to the CCLayerImpl tree.
Tested by compositing/ layout tests and by unit tests in WebKit/chromium.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::dumpLayer): (WebCore::LayerChromium::dumpLayerProperties): (WebCore::LayerChromium::createCCLayerImpl): (WebCore::LayerChromium::ccLayerImpl):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::id): (WebCore::LayerChromium::setCCLayerImpl):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::updateCompositorResourcesRecursive):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/TreeSynchronizer.cpp: Added. (WebCore::TreeSynchronizer::addCCLayerImplsToMapRecursive): (WebCore::TreeSynchronizer::synchronizeTreeRecursive): (WebCore::TreeSynchronizer::synchronizeTrees):
  • platform/graphics/chromium/TreeSynchronizer.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createCCLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::create):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::addChild): (WebCore::CCLayerImpl::removeFromParent): (WebCore::CCLayerImpl::removeAllChildren): (WebCore::CCLayerImpl::clearChildList): (WebCore::CCLayerImpl::descendantsDrawsContent): (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::updateCompositorResources):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::create): (WebCore::CCLayerImpl::parent): (WebCore::CCLayerImpl::children): (WebCore::CCLayerImpl::setMaskLayer): (WebCore::CCLayerImpl::maskLayer): (WebCore::CCLayerImpl::setReplicaLayer): (WebCore::CCLayerImpl::replicaLayer): (WebCore::CCLayerImpl::id): (WebCore::CCLayerImpl::owner): (WebCore::CCLayerImpl::setParent):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h: (WebCore::CCPluginLayerImpl::create):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h: (WebCore::CCVideoLayerImpl::create):

2011-05-16 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.
https://bugs.webkit.org/show_bug.cgi?id=58830

Add unit tests for the compositor's TreeSynchronizer.

  • WebKit.gypi:
  • tests/TreeSynchronizerTest.cpp: Added. (WebCore::MockCCLayerImpl::create): (WebCore::MockCCLayerImpl::~MockCCLayerImpl): (WebCore::MockCCLayerImpl::setCCLayerDestructionList): (WebCore::MockCCLayerImpl::MockCCLayerImpl): (WebCore::MockLayerChromium::create): (WebCore::MockLayerChromium::~MockLayerChromium): (WebCore::MockLayerChromium::createCCLayerImpl): (WebCore::MockLayerChromium::pushPropertiesTo): (WebCore::MockLayerChromium::MockLayerChromium): (WebCore::expectTreesAreIdentical): (WebCore::TEST):
19:49 Changeset [86651] by commit-queue@webkit.org

2011-05-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86648.
http://trac.webkit.org/changeset/86648
https://bugs.webkit.org/show_bug.cgi?id=60941

media/controls-css-overload.html still failing on non-GPU
tests (Requested by scherkus on #webkit).

  • platform/chromium/test_expectations.txt:
19:34 Changeset [86650] by commit-queue@webkit.org

2011-05-16 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
https://bugs.webkit.org/show_bug.cgi?id=60871

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added expected results.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added test patterns when initial values are empty.

2011-05-16 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

HTML5 Number Spinbox displays a 0 in situations where a 0 is not between the min and max.
https://bugs.webkit.org/show_bug.cgi?id=60871

Test: fast/forms/input-stepup-stepdown-from-renderer.html

In number input type, if the value is not a number, including empty, the currect valued is assumed 0.
But we have to handle it separately from the case when the value is actuall "0".

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Added cliping for default value.
18:42 Changeset [86649] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
https://bugs.webkit.org/show_bug.cgi?id=60935

This test case triggers the ASSERT.

  • fast/parser/append-child-followed-by-document-write-expected.txt: Added.
  • fast/parser/append-child-followed-by-document-write.html: Added.

2011-05-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove bogus ASSERT in Document::setCompatibilityMode
https://bugs.webkit.org/show_bug.cgi?id=60935

The ASSERT is invalid when the parser is in the initial state and the
document is non-empty, which is strange but not impossible.

Test: fast/parser/append-child-followed-by-document-write.html

  • dom/Document.cpp: (WebCore::Document::setCompatibilityMode):
18:14 Changeset [86648] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating expectation for media/controls-css-overload.html.

  • platform/chromium/test_expectations.txt:
18:11 Changeset [86647] by morrita@google.com

2011-05-16 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
https://bugs.webkit.org/show_bug.cgi?id=56814

  • Moved DocumentMarker's member variables to private and added getters for them.
  • Added DocumentMarker setters and constructors, which contain assertions against m_type values because description and activeMatch are used with specific type of MarkerType.
  • Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController because it accesses DocumentMarker internals.
  • Moved a version of DMC::addMarker() to private and add alternatives that hide internals of DocumentMarker. (The internal will be renewed by upcoming change.)
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::type): (WebCore::DocumentMarker::startOffset): (WebCore::DocumentMarker::endOffset): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::hasDescription): (WebCore::DocumentMarker::activeMatch): (WebCore::DocumentMarker::clearDescription): (WebCore::DocumentMarker::setStartOffset): (WebCore::DocumentMarker::setEndOffset): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromList): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): (WebCore::DocumentMarkerController::showMarkers):
  • dom/DocumentMarkerController.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): (WebCore::HitTestResult::replacedString):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

2011-05-16 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] Member variables of DocumentMarker should be encapsulated.
https://bugs.webkit.org/show_bug.cgi?id=56814

Moved addMarker() implementation to
WebCore::DocumentMarkerController::addTextMatchMarker().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMarker):
18:01 Changeset [86646] by mrobinson@webkit.org

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Fix the Cairo build for older versions of GTK+.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Include GtkVersioning.h to satisfy older versions of GTK+ 2.x.

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Take another shot at fixing the WinCairo build.

  • Shared/cairo/LayerTreeContextCairo.cpp: Include NotImplemented.h using a framework include.
17:53 Changeset [86645] by weinig@apple.com

2011-05-16 Sam Weinig <sam@webkit.org>

Reviewed by Jon Honeycutt.

Add access to process pid in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=60938

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp: Added. (WKPageGetProcessIdentifier):
  • UIProcess/API/C/mac/WKPagePrivateMac.h: Added.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::processIdentifier):
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Add WKPageGetProcessIdentifier as SPI for the mac.
17:50 Changeset [86644] by commit-queue@webkit.org

2011-05-16 Ian Henderson <ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
https://bugs.webkit.org/show_bug.cgi?id=60412

  • loader/navigation-while-deferring-loads-expected.txt: Added.
  • loader/navigation-while-deferring-loads.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-16 Ian Henderson <ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
https://bugs.webkit.org/show_bug.cgi?id=60412

If goToItem is called while loading is deferred, save the arguments
and try again later instead of doing nothing.

Test: loader/navigation-while-deferring-loads.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Pipe the "defersLoading" state into HistoryController.
  • loader/HistoryController.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::goToItem): Save the HistoryItem and FrameLoadType if loading is deferred. (WebCore::HistoryController::setDefersLoading): If we have a saved HistoryItem after resuming, try going to it.
  • loader/HistoryController.h:
  • page/Page.cpp: (WebCore::Page::goToItem): No longer bail early if loading is deferred, since HistoryController now handles this case.

2011-05-16 Ian Henderson <ianh@apple.com>

Reviewed by Joseph Pecoraro.

Page::goToItem doesn't work while loading is deferred
https://bugs.webkit.org/show_bug.cgi?id=60412

Add setDefersLoading and goBack methods to LayoutTestController. We
need to use goBack() instead of history.back() because the latter goes
through NavigationScheduler, hence doesn't exhibit the bug.

  • DumpRenderTree/LayoutTestController.cpp: (goBackCallback): (setDefersLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
17:31 Changeset [86643] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in new baselines for media/video-canvas-alpha.html for chromium-gpu-{linux,win}.

  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium/test_expectations.txt:
17:27 Changeset [86642] by mrobinson@webkit.org

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Add file missing from my previous commit.

  • Shared/cairo/LayerTreeContextCairo.cpp: Added.
17:22 Changeset [86641] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, un-skipping a few Chromium layout test expectations.

  • platform/chromium/test_expectations.txt:
17:21 Changeset [86640] by atwilson@chromium.org

2011-05-16 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86625.
http://trac.webkit.org/changeset/86625
https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Removed.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
  • platform/graphics/chromium/LayerTextureSubImage.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdater.h: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Removed.
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Removed.
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setLayerRenderer): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86625.
http://trac.webkit.org/changeset/86625
https://bugs.webkit.org/show_bug.cgi?id=60719

Caused failed assertion on Chromium gpu canary bots

  • src/WebViewImpl.cpp:
16:50 Changeset [86639] by mitz@apple.com

No need to compile .js files, that is what the JIT is for.

  • WebKit.xcodeproj/project.pbxproj:
16:48 Changeset [86638] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, marking media/video-transformed.html as passing on all platforms.

  • platform/chromium/test_expectations.txt:
16:43 Changeset [86637] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Attempt to fix baselines for xss-DENIED-set-opener.html. This is too hard.

  • platform/chromium-linux/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium-win-vista/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
16:40 Changeset [86636] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Attempt to fix baselines for set-href-attribute-hash.html. This is too hard.

  • platform/chromium-linux/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
  • platform/chromium-win-vista/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
16:39 Changeset [86635] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=60927
fastCheckSelector() does not inline correctly in all cases

Reviewed by Dave Kilzer.

Use anonymous namespace instead of static qualifier to get internal linkage.
Use functions as template arguments instead of classes.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

16:36 Changeset [86634] by mrobinson@webkit.org

2011-05-16 Martin Robinson <martin.james.robinson@gmail.com>

Try to fix the WinCairo build after r86612.

Move the LayerTreeContextGtk.cpp stub to LayerTreeContextCairo.cpp and add
it to the WinCairo build.

  • GNUmakefile.am: Update the source list.
  • Shared/cairo/LayerTreeContextCairo.cpp: Renamed from Source/WebKit2/Shared/gtk/LayerTreeContextGtk.cpp.
  • win/WebKit2.vcproj: Update the source list.
16:36 Changeset [86633] by crogers@google.com

2011-05-16 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Just return "nullptr" to fix compile errors
https://bugs.webkit.org/show_bug.cgi?id=60932

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
16:33 Changeset [86632] by eae@chromium.org

2011-05-16 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
https://bugs.webkit.org/show_bug.cgi?id=60743

Change RenderView::documentRect to compute rect once rather than four times.
Replace all uses of docTop/Right/Bottom/Left/Width/Height with documentRect to
simplify the code and reduce complexity.

Covered by existing tests.

  • WebCore.exp.in:
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::forceLayoutForPagination):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
  • rendering/RenderView.cpp: (WebCore::RenderView::documentRect):
  • rendering/RenderView.h:

2011-05-16 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Replace docTop/Right/Bottom/Left/Width/Height with documentRect
https://bugs.webkit.org/show_bug.cgi?id=60743

Replace uses of docWidth/Height with documentRect.

  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
16:32 Changeset [86631] by tony@chromium.org

2011-05-16 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] shard V8DerivedSources into 19 files
https://bugs.webkit.org/show_bug.cgi?id=60926

This reduces the clobber build time by 4s on my machine. It helps
by making the slowest to compile V8DerivedSources faster (and thus
more parallelizable). With 8 files, the 3 slowest are 23s, 18s and
10s. With 19 files, the 3 slowest are 16s, 10s, and 10s.

  • WebCore.gyp/WebCore.gyp:
  • storage/IDBObjectStore.h: Fix a missing include that was working because a different .cpp file before it was including the header.
16:13 Changeset [86630] by crogers@google.com

2011-05-16 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Fix web audio enabled mac port compile errors
https://bugs.webkit.org/show_bug.cgi?id=60930

  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus):
16:12 Changeset [86629] by atwilson@chromium.org

Unreviewed chromium expectations changes to disable crashing tests.

https://bugs.webkit.org/show_bug.cgi?id=60931

  • platform/chromium/test_expectations.txt:
16:10 Changeset [86628] by eric@webkit.org

2011-05-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
https://bugs.webkit.org/show_bug.cgi?id=60925

I suspect this difference is really just papering over other bugs
but now that I finally understand the difference, I should at least
document it for others.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::deleteLineRange): (WebCore::RenderBlock::determineStartPosition):
16:02 Changeset [86627] by commit-queue@webkit.org

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Scrolling in Twitter is broken after r86102
https://bugs.webkit.org/show_bug.cgi?id=60922

Fix adjustment handling for pages that trigger the slow scrolling path.
The slow scrolling path is triggered by WebCore when it determines that
doing a simple invalidation is quicker than doing a normal scroll. This
typically happens when there are large elements with fixed positions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment watcher to update its adjustments when a page triggers the slow scrolling path.
16:02 Changeset [86626] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining media/video-aspect-ratio.html for chromium-gpu-{linux,mac,win}.

  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:58 Changeset [86625] by alokp@chromium.org

2011-05-16 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Split canvas from LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=60719

LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
Also abstracted LayerTextureSubImage to upload texture pixels.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::create): (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::createTextureUpdater): (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater): (WebCore::ImageLayerTextureUpdater::orientation): (WebCore::ImageLayerTextureUpdater::prepareToUpdate): (WebCore::ImageLayerTextureUpdater::updateTextureRect): (WebCore::ImageLayerTextureUpdater::imageRect): (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerPainterChromium.h: Added.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateRootLayerContents): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: Added. (WebCore::LayerTextureSubImage::LayerTextureSubImage): (WebCore::LayerTextureSubImage::~LayerTextureSubImage): (WebCore::LayerTextureSubImage::setSubImageSize): (WebCore::LayerTextureSubImage::upload): (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/LayerTextureSubImage.h: Added.
  • platform/graphics/chromium/LayerTextureUpdater.h: Added. (WebCore::LayerTextureUpdater::LayerTextureUpdater): (WebCore::LayerTextureUpdater::~LayerTextureUpdater): (WebCore::LayerTextureUpdater::context):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added. (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::paintContents): (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate): (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added. (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas): (WebCore::LayerTextureUpdaterCanvas::contentRect): (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap): (WebCore::LayerTextureUpdaterBitmap::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

2011-05-16 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Split canvas from LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=60719

  • src/WebViewImpl.cpp:
15:57 Changeset [86624] by weinig@apple.com

2011-05-16 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

TestWebKitAPI should build with clang if it can
https://bugs.webkit.org/show_bug.cgi?id=60918

  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Update CompilerVersion.xcconfig to match others.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add CompilerVersion.xcconfig to the project.
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: (TestWebKitAPI::didSameDocumentNavigationForFrame): Add some casts to quiet warnings from clang.
15:56 Changeset [86623] by atwilson@chromium.org

Unreviewed prospective build fix/workaround for chromium ARM compiler error.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::animationNameForTransition):

15:53 Changeset [86622] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Layout test file-URL-with-port-number.html fails on Mac and Linux
http://code.google.com/p/chromium/issues/detail?id=10342

The consensus is to not support this behavior unless there is a
compelling compatibility reason.

  • platform/chromium/test_expectations.txt:
15:51 Changeset [86621] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining media/video-zoom.html for chromium-gpu-{linux,mac}.

  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
15:48 Changeset [86620] by commit-queue@webkit.org

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
https://bugs.webkit.org/show_bug.cgi?id=60912

No new tests. This will be covered by WebKit2 pixel tests.

  • GNUmakefile.list.am: Added new GtkWidgetBackingStore source and header files.
  • platform/gtk/GtkWidgetBackingStore.h: Added.
  • platform/gtk/GtkWidgetBackingStoreCairo.cpp: Added this implementation of the backing store that uses Cairo and has the same performance characteristics as the WebKit2 implementaiton.
  • platform/gtk/GtkWidgetBackingStoreX11.cpp: Added this implementation of the backing store that uses X11 directly and has better performance than the Cairo version.

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] [WebKit2] Provide a fast version of the backing store for X11
https://bugs.webkit.org/show_bug.cgi?id=60912

Instead of allocating the backing store surface directly in WebKit2,
instantiate the GtkWidgetBackingStore class which abstracts away the
platform-specific details of maintaining the backing store.

  • UIProcess/BackingStore.h:
  • UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::paint): Call into GtkWidgetBackingStore to get the Cairo surface now. (WebKit::BackingStore::incorporateUpdate): Ditto. (WebKit::BackingStore::scroll): Call into GtkWidgetBackingStore to do the actual backing store scroll.
15:46 Changeset [86619] by rniwa@webkit.org

2011-05-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/pasteboard/5075944-2.html and 5075944-3.html should be renamed and converted to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=60923

Renamed pasteboard/5075944-2.html to pasteboard/preserve-underline-color.html and pasteboard/5075944-3.html to
deleting/deleting-line-break-preserves-underline-color.html. Also converted them to dump-as-markup tests.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: Added.
  • editing/deleting/deleting-line-break-preserves-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-3.html.
  • editing/pasteboard/5075944-2.html: Removed.
  • editing/pasteboard/5075944-3.html: Removed.
  • editing/pasteboard/preserve-underline-color-expected.txt: Added.
  • editing/pasteboard/preserve-underline-color.html: Copied from LayoutTests/editing/pasteboard/5075944-2.html.
  • platform/chromium-linux/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/5075944-3-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5075944-3-expected.txt: Removed.
15:45 Changeset [86618] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Layout Test fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing
http://code.google.com/p/chromium/issues/detail?id=72428

This test is passing, not failing.

  • platform/chromium/fast/dom/HTMLAnchorElement: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:41 Changeset [86617] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

cross-frame-access-call.html fails after WebKit r74449
http://code.google.com/p/chromium/issues/detail?id=67767

These tests aren't really failing. They just have different results
because of interactions with the popup blocker.

  • platform/chromium/http/tests/security/aboutBlank: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
15:39 Changeset [86616] by dpranke@chromium.org

2011-05-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

add dpranke as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=60919

  • Scripts/webkitpy/common/config/committers.py:
15:32 Changeset [86615] by cmarrin@apple.com

2011-05-16 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Plug-in hit testing is broken after zooming
https://bugs.webkit.org/show_bug.cgi?id=60916

Construct a WebMouseEvent to send to plugin, adjusting values to take pageScaleFactor
into account. Also adjusted bounds sent to viewGeometryDidChange to take pageScaleFactor
into account. Both are needed or the plugin will think the mouse positions are outside
its bounds.

  • Shared/WebEvent.h:
  • Shared/WebMouseEvent.cpp:Add ctor to clone a WebMouseEvent and add a scaleFactor to values (WebKit::WebMouseEvent::WebMouseEvent):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::handleEvent):Adjust mouse coords to take pageScaleFactor into account (WebKit::PluginView::viewGeometryDidChange):Adjust bounds to take pageScaleFactor into account
15:25 Changeset [86614] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, removing baselines for media/media-document-audio-repaint.html as they're incorrect.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:19 Changeset [86613] by robert@webkit.org

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Csaba Osztrogonác.

https://bugs.webkit.org/show_bug.cgi?id=59930

Add plugins/object-embed-plugin-scripting.html to qt-mac Skipped list

Note that nearly all plugin tests are currently skipped by qt-mac,
so something may be missng from the buildbot.

  • platform/qt-mac/Skipped:
15:07 Changeset [86612] by mrobinson@webkit.org

2011-05-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

GTK port of WebKit2 should switch to new DrawingAreaImpl model
https://bugs.webkit.org/show_bug.cgi?id=59655

  • GNUmakefile.am: Add the files necessary to use the DrawingAreaProxyImpl to the source list. The source list also needs the LayerContextTree stubs.
  • Shared/LayerTreeContext.h: This file should not be guarded by USE(ACCELERATED_COMPOSITING) as it's needed for the DrawingAreaProxyImpl IPC messaging.
  • Shared/gtk/LayerTreeContextGtk.cpp: Added this stub.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createDrawingAreaProxy): Instead of creating the deprecated chunked drawing area, create a DrawingAreaProxyImpl. (WebKit::PageClientImpl::setViewNeedsDisplay): Here we must now queue a redraw. Previously the chunked drawing area was doing this manually. This is the appropriate place though. (WebKit::PageClientImpl::scrollView): Add an implementation that just calls into setViewNeedsDisplay.
  • UIProcess/API/gtk/PageClientImpl.h: Added a getter for m_viewWidget. (WebKit::PageClientImpl::viewWidget):
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): Added this helper which reduces code duplication between GTK+ 2.x and 3.x (webkitWebViewBaseExpose): Call the new helper now. (webkitWebViewBaseDraw): Ditto.
  • UIProcess/BackingStore.h: Updated to include GTK+ specific types.
  • UIProcess/DrawingAreaProxy.h: Ditto.
  • UIProcess/DrawingAreaProxy.messages.in: Do not the DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING).
  • UIProcess/WebPageProxy.cpp: Removed these guards, as DrawingAreProxyImpl is used on all platforms now. (WebKit::WebPageProxy::didReceiveMessage): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/gtk/BackingStoreGtk.cpp: Added. This implementation heavily uses Cairo, but depends on GTK+/GDK in a few places. (WebKit::BackingStore::paint): (WebKit::BackingStore::incorporateUpdate): (WebKit::BackingStore::scroll):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added a getting for the viewWidget, which is required by BackingStoreGtk. A similar getter exists for Windows and Mac. (WebKit::WebPageProxy::viewWidget): Ditto.
  • WebProcess/WebPage/DrawingArea.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::DrawingArea::create): Ditto.
  • WebProcess/WebPage/DrawingArea.h: Ditto.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Do not guard this DrawingAreaProxyImpl-specific message with USE(ACCELERATED_COMPOSITING)
  • WebProcess/WebPage/WebPage.cpp: Removed these guards as DrawingAreaProxyImpl is used on all platforms now. (WebKit::WebPage::didReceiveMessage): Ditto.
15:05 Changeset [86611] by robert@webkit.org

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

https://bugs.webkit.org/show_bug.cgi?id=60838

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Anders Carlsson.

[Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

https://bugs.webkit.org/show_bug.cgi?id=60838

The unix test plugin needs to call the test's NPP_URLNotify
rather than the browsers.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_url_notify):
14:46 WebKit Team edited by bfulgham@webkit.org
(diff)
14:44 Changeset [86610] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, correcting bug number for a test expectation.

  • platform/chromium/test_expectations.txt:
14:42 Changeset [86609] by bfulgham@webkit.org

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:

Rubber-stamped by Adam Roben.

14:37 Changeset [86608] by mjs@apple.com

2011-05-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Sandbox denies Kerberos authentication
https://bugs.webkit.org/show_bug.cgi?id=60921
<rdar://problem/9133872>


  • WebProcess/com.apple.WebProcess.sb:
14:34 Changeset [86607] by crogers@google.com

2011-05-16 Chris Rogers <crogers@google.com>

Reviewed by senorblanco@chromium.org.

Add DynamicsCompressorNode implementation
https://bugs.webkit.org/show_bug.cgi?id=60682

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DynamicsCompressor.cpp: Added. (WebCore::DynamicsCompressor::DynamicsCompressor): (WebCore::DynamicsCompressor::initializeParameters): (WebCore::DynamicsCompressor::parameterValue): (WebCore::DynamicsCompressor::setEmphasisStageParameters): (WebCore::DynamicsCompressor::setEmphasisParameters): (WebCore::DynamicsCompressor::process): (WebCore::DynamicsCompressor::reset):
  • platform/audio/DynamicsCompressor.h: Added. (WebCore::DynamicsCompressor::isStereo): (WebCore::DynamicsCompressor::sampleRate): (WebCore::DynamicsCompressor::nyquist):
  • platform/audio/DynamicsCompressorKernel.cpp: Added. (WebCore::saturate): (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel): (WebCore::DynamicsCompressorKernel::setPreDelayTime): (WebCore::DynamicsCompressorKernel::process): (WebCore::DynamicsCompressorKernel::reset):
  • platform/audio/DynamicsCompressorKernel.h: Added. (WebCore::DynamicsCompressorKernel::latencyFrames): (WebCore::DynamicsCompressorKernel::sampleRate):
  • platform/audio/ZeroPole.cpp: Added. (WebCore::ZeroPole::process):
  • platform/audio/ZeroPole.h: Added. (WebCore::ZeroPole::ZeroPole): (WebCore::ZeroPole::reset): (WebCore::ZeroPole::setZero): (WebCore::ZeroPole::setPole): (WebCore::ZeroPole::zero): (WebCore::ZeroPole::pole):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createDynamicsCompressor):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/DynamicsCompressorNode.cpp: Added. (WebCore::DynamicsCompressorNode::DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::~DynamicsCompressorNode): (WebCore::DynamicsCompressorNode::process): (WebCore::DynamicsCompressorNode::reset): (WebCore::DynamicsCompressorNode::initialize): (WebCore::DynamicsCompressorNode::uninitialize):
  • webaudio/DynamicsCompressorNode.h: Added. (WebCore::DynamicsCompressorNode::create):
  • webaudio/DynamicsCompressorNode.idl: Added.
14:26 Changeset [86606] by mitz@apple.com

Re-added platform-specific result after r86599.

  • platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from platform/mac-leopard/editing/text-iterator/findString-expected.txt.
14:17 Nice Bugzilla queries edited by ddkilzer@webkit.org
Updated 5-year-old links to work with current Bugzilla. (diff)
14:17 Changeset [86605] by rniwa@webkit.org

2011-05-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=60920

Renamed 5091898.html to delete-line-break-before-underlined-content.html and converted it
to a dump-as-markup test.

  • editing/deleting/5091898.html: Removed.
  • editing/deleting/delete-line-break-before-underlined-content-expected.txt: Added.
  • editing/deleting/delete-line-break-before-underlined-content.html: Copied from LayoutTests/editing/deleting/5091898.html.
  • platform/chromium-linux/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5091898-expected.txt: Removed.
  • platform/gtk/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.png: Removed.
  • platform/mac/editing/deleting/5091898-expected.txt: Removed.
  • platform/mac/editing/style/5091898-expected.png: Removed.
  • platform/mac/editing/style/5091898-expected.txt: Removed.
  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/editing/deleting/5091898-expected.png: Removed.
  • platform/qt/editing/deleting/5091898-expected.txt: Removed.
13:45 Changeset [86604] by tony@chromium.org

2011-05-16 Tony Chang <tony@chromium.org>

Move chromium-linux-x86_64 results into chromium-linux. We're making
x86_64 the default configuration for chromium-linux because that's
what the devs build and use.

13:35 Changeset [86603] by weinig@apple.com

Fix typo pointed out by Dave Levin.

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::assertWKStringEqual):
Strig -> String.

13:28 Changeset [86602] by weinig@apple.com

2011-05-16 Sam Weinig <sam@webkit.org>

Reviewed by David Levin.

Convert api tester over to using gtest expectations directly
https://bugs.webkit.org/show_bug.cgi?id=60862

  • TestWebKitAPI/PlatformUtilities.cpp: (TestWebKitAPI::Util::toSTD):
  • TestWebKitAPI/PlatformUtilities.h: (TestWebKitAPI::Util::assertWKStrigEqual): Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make the implementation of the macro simpler.
  • TestWebKitAPI/Test.h: Remove TEST_ASSERT forwarder.

[Test changes elided]

13:24 Changeset [86601] by yuzo@google.com

2011-05-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
https://bugs.webkit.org/show_bug.cgi?id=43704

In setting printing, we should not validate resources already cached
for the document. If we do, web fonts used for screen are revalidated
and possiby reloaded. Then the fonts can be shown as blank on print.
This patch won't save the case where screen and print use different web
fonts. Nonetheless, this is an improvement.

No new tests because there seems to be no good way to test print images.

  • editing/Editor.cpp: (WebCore::Editor::paste): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • loader/cache/CachedResourceLoader.h: (WebCore::ResourceCacheValidationSuppressor::ResourceCacheValidationSuppressor): RAII class for allowing/disallowing stale resources. (WebCore::ResourceCacheValidationSuppressor::~ResourceCacheValidationSuppressor):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
  • page/Frame.cpp: (WebCore::Frame::setPrinting): Use ResourceCacheValidationSuppressor to allow stale resources in printing.

2011-05-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 43704 - Web font is printed as blank if it is not cached
https://bugs.webkit.org/show_bug.cgi?id=43704

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
13:18 Changeset [86600] by scherkus@chromium.org

2011-05-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, de-duplicating media/video-zoom-controls.html expectations.

  • platform/chromium/test_expectations.txt:
13:14 Changeset [86599] by mitz@apple.com

<rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe mid-word
https://bugs.webkit.org/show_bug.cgi?id=60915

Reviewed by Darin Adler.

Source/WebCore:

CFStringTokenizer’s kCFStringTokenizerUnitWord considers “Here’s” as two separate tokens.
Switching to CFStringTokenizer in r84750 was an attempt to address an issue with Japanese word
boundaries for searches with WebFindOptionsAtWordStarts, but it turned out to be insufficient,
and in r86387 the Japanese word issue was addressed independently of text boundaries, so just
revert r84750.

  • platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

LayoutTests:

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
12:59 Changeset [86598] by ddkilzer@apple.com

<http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
<rdar://problem/9446430>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig: Fixed typo.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebCore:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit/mac:

  • Configurations/Base.xcconfig: Fixed typo.

Source/WebKit2:

  • Configurations/Base.xcconfig: Fixed typo.

Tools:

  • MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
  • TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  • WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
12:25 Changeset [86597] by jonlee@apple.com

Fix for broken regression tests. Adding null pointer check

  • page/FrameView.cpp:

(WebCore::FrameView::didAddHorizontalScrollbar):
(WebCore::FrameView::willRemoveHorizontalScrollbar):

12:04 Changeset [86596] by enne@google.com

2011-05-16 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Remove unused member variables from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=60899

These should have been removed when tiling was enabled for root
layers.

  • platform/graphics/chromium/LayerRendererChromium.h:
11:58 Changeset [86595] by atwilson@chromium.org

2011-05-16 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86589.
http://trac.webkit.org/changeset/86589
https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r86589.
http://trac.webkit.org/changeset/86589
https://bugs.webkit.org/show_bug.cgi?id=54670

Broke chromium inspector tests.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.hide): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
11:54 Changeset [86594] by oliver@apple.com

2011-05-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

JSWeakObjectMap finalisation may occur while gc is in inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=60908
<rdar://problem/9409491>

We need to ensure that we have called all the weak map finalizers while
the global object (and hence global context) is still in a consistent
state. The best way to achieve this is to simply use a weak handle and
finalizer on the global object.

  • JavaScriptCore.exp:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::WeakMapFinalizer::finalize):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap):
11:08 Changeset [86593] by bweinstein@apple.com

Fix a revision number in the ChangeLog

11:07 Changeset [86592] by bweinstein@apple.com

REGRESSION (r86555): Dropping URL onto Desktop creates broken Internet Shortcut file.

Reviewed by Enrica Casucci.

r86477 fixed this bug by using latin1 as the CString's encoding instead of ascii, but r86555
undid this change.

Change it back to latin1 to fix the bug.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeURL):

11:03 Changeset [86591] by jer.noble@apple.com

Unreviewed; build fix for non-SnowLeopard builds.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition

of layerIsDescendentOf in a #if check.

10:55 Changeset [86590] by andersca@apple.com

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

If the root compositing layer changes while we're about to exit compositing mode, make sure to enter compositing mode
https://bugs.webkit.org/show_bug.cgi?id=60905
<rdar://problem/9365574>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): If we have a layer tree host, but haven't yet sent a EnterAcceleratedCompositingMode message (this can happen when quickly going in and out of compositing mode), make sure to schedule a notification when the layer tree host does it next flush. This will end up sending the EnterAcceleratedCompositingMode message.
10:54 Changeset [86589] by podivilov@chromium.org

2011-05-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
https://bugs.webkit.org/show_bug.cgi?id=54670

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/console/console-uncaught-exception.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/styles/styles-iframe.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:

2011-05-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: merge ConsoleView into ConsolePanel.
https://bugs.webkit.org/show_bug.cgi?id=54670

Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsolePanel.prototype.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.showInDrawer): (WebInspector.ConsolePanel.prototype.afterShowInDrawer): (WebInspector.ConsolePanel.prototype.hideInDrawer): (WebInspector.ConsolePanel.prototype.addMessage): (WebInspector.ConsolePanel.prototype.clearMessages):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel):
  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show):
  • inspector/front-end/Panel.js: (WebInspector.Panel):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
10:50 Changeset [86588] by jer.noble@apple.com

2011-05-13 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
https://bugs.webkit.org/show_bug.cgi?id=60826

Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
next time setVisible(true) is called.

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement): Call setFullScreenRootLayer(0)

before disabling animation on the full screen renderer.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new

WebKitLayerHostChanged notification.

(WebCore::layerIsDescendentOf): Added.
(WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added. If the changed

layer is an ancestor of the movie layer, tear down rendering and re-
create the next time setVisible(true) is called.

(-[WebCoreMovieObserver layerHostChanged:]): Added ObjC listener wrapper.

2011-05-13 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
https://bugs.webkit.org/show_bug.cgi?id=60826

Emit a notification when moving a CALayer from the WebProcess's main
layer host to a new context. This allows listeners to invalidate their
layers which may not support moving between different CAContexts (as is
the case with QTMovieLayer). In order to allow listeners to determine if they
are affected, the notification will pass the root CALayer in a userInfo
dictionary.

In WebFullScreenManagerMac, move from storing a pointer to a non-refcounted
class (GraphicsLayer) to a retainable class (PlatformLayer).

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): No need to initialize

m_fullScreenRootLayer now that it is a RetainPtr<>.

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Emit a notification

after either creating or destroying the full screen layer host.

(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

10:48 Changeset [86587] by kbalazs@webkit.org

2011-05-16 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

[WK2] Remove some passing tests from the mac-wk2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=60889

  • platform/mac-wk2/Skipped:
10:32 Changeset [86586] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60874

No need to test a feature that doesn't exist.

  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Removed.

2011-05-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove disable-javascript-urls CSP directive
https://bugs.webkit.org/show_bug.cgi?id=60874

After talking this out with various folks in the CSP working group, we
decided that this syntax isn't the right way to approach this issue.
If we want to address the use case of enabling JavaScript URLs
separately from inline script, we'll probably just make

script-src javascript:

work that way.

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
10:27 Changeset [86585] by ossy@webkit.org

[Qt][Wk2][Symbian] Fix build after r86560
https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2011-05-16
Rubber-stamped by Csaba Osztrogonác.

Temporarily fix Symbian build by re-enabling compilation
of Qt/Gtk common code (as was the case for Symbian before r55875).
This is a stop gap until the pure Symbian Core IPC and process launching bits land in Bug 55875
As of this revision, only the native SharedMemory implementation is in trunk.

  • Platform/CoreIPC/Attachment.h: Compile Qt/Gtk common code for Qt-Symbian too
  • Platform/CoreIPC/Connection.h: ditto
  • Platform/SharedMemory.h: ditto
  • Platform/qt/SharedMemorySymbian.cpp: stub implementations of attachment handling

(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):

10:25 Changeset [86584] by jonlee@apple.com

Source/WebCore: Reviewed by Simon Fraser.

Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

  • dom/Document.cpp: (WebCore::Document::Document): Initialize wheel event handler count (WebCore::Document::didAddWheelEventHandler): Increment count, and tell the main frame to recalculate the total number of wheel event handlers in all of its frames' documents (WebCore::Document::didRemoveWheelEventHandler): Reverse of previous method
  • dom/Document.h: (WebCore::Document::wheelEventHandlerCount): Access the count
  • dom/Node.cpp: (WebCore::tryAddEventListener): If the event listener is a mouse wheel event, then tell the document to increment its count (WebCore::tryRemoveEventListener): Reverse of previous method
  • page/ChromeClient.h: Two new methods:

numWheelEventHandlersChanged: WebProcess tells UIProcess to update its cached

count of total wheel event handlers, which in this case only include horizontal
scrollbars and mouse wheel JS handlers

shouldRubberBandInDirection: allow the UIProcess to provide some control over

whether rubber banding is allowed when scrolling in a particular direction

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::numWheelEventHandlersChanged): Default empty impl (WebCore::EmptyChromeClient::shouldRubberBandInDirection): Default empty impl
  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Remove a redundant pointer check
  • page/Frame.cpp: (WebCore::Frame::setDocument): When the frame's document changes, calculate that document's total wheel event handlers, and notify the UIProcess (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged): Performs a crawl of the frame tree to aggregate the count
  • page/Frame.h:
  • platform/ScrollableArea.h: Virtualize didAddHorizontalScrollbar and willRemoveHorizontalScrollbar for overriding in RenderLayer and FrameView (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition): Returns true if there is no scrollbar or the scroller position is in the minimum scroll position. (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition): Converse of the above. (WebCore::ScrollableArea::shouldRubberBandInDirection): Default impl
  • page/FrameView.cpp: (WebCore::FrameView::didAddHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::willRemoveHorizontalScrollbar): Updates the frame's document's count (WebCore::FrameView::shouldRubberBandInDirection): Connective glue
  • page/FrameView.h: Adding overriding methods from ScrollableArea
  • rendering/RenderLayer.cpp: Similar functionality to FrameView (WebCore::RenderLayer::didAddHorizontalScrollbar): (WebCore::RenderLayer::willRemoveHorizontalScrollbar):
  • rendering/RenderLayer.h:
  • platform/mac/ScrollAnimatorMac.h: Fix typo of "momentum"
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Fix typo of "momentum" (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::beginScrollGesture): Fix typo of "coalesced" (WebCore::ScrollAnimatorMac::snapRubberBand): Fix typo of "momentum"

(WebCore::ScrollAnimatorMac::handleWheelEvent): New logic for determining whether
to allow rubber-banding based on the area's scroll position and the wheel event.
Could prevent accepting the wheel event. Also, fix typo of "momentum"
(WebCore::isScrollingLeftAndShouldNotRubberBand): Inline helper function for logic
(WebCore::isScrollingRightAndShouldNotRubberBand): Inline helper function for logic

Source/WebKit/chromium: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/efl: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientEfl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/gtk: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/haiku: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientHaiku.h:

(WebCore::ChromeClientHaiku::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientHaiku::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/mac: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method

Source/WebKit/qt: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/win: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wince: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebCoreSupport/ChromeClientWinCE.h:

(WebKit::ChromeClientWinCE::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientWinCE::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wx: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientWx::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit2: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

We keep track of the number of horizontal scrollbars and mouse wheel event handlers in the
UI process as a means of determining whether horizontal scroll events will be handled
by the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willHandleHorizontalScrollEvents): Return true if there is at least
one wheel event handler

  • UIProcess/WebPageProxy.h: Add new variable to cache the count

(WebKit::WebPageProxy::numWheelEventHandlersChanged): Sets the count

The rest just provides all the connections.

  • UIProcess/API/C/WKPage.cpp:

(WKPageWillHandleHorizontalScrollEvents):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldRubberBandInDirection): Forward to injected bundle UI client
(WebKit::WebChromeClient::updateCountWheelEventHandlers): Updates the web page proxy

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Tools: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.

10:16 Changeset [86583] by commit-queue@webkit.org

2011-05-16 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
https://bugs.webkit.org/show_bug.cgi?id=60177

Re-enable the argument-types test as the navigator.getUserMedia options
are now being parsed and raise the appropriate exceptions.

  • platform/chromium/test_expectations.txt:

2011-05-16 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add local stream requests.
https://bugs.webkit.org/show_bug.cgi?id=60177

Add the code and messages for requesting the generation of local streams and getting the reply back.

Tests for the Media Stream API will be provided by the bug 56587.
One test is re-enabled with this patch.

Test: fast/dom/MediaStream/argument-types.html

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/CallbackTask.h: Added. (WebCore::CallbackTask1::create): (WebCore::CallbackTask1::performTask): (WebCore::CallbackTask1::Scheduler::scheduleCallback): (WebCore::CallbackTask1::CallbackTask1):
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::isClientAvailable): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest): (WebCore::MediaStreamController::registerStream): (WebCore::MediaStreamController::generateStream): (WebCore::MediaStreamController::streamGenerated): (WebCore::MediaStreamController::streamGenerationFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback): (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback): (WebCore::::unregisterAll): (WebCore::::detachEmbedder): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::isClientAvailable): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::parseGenerateStreamOptions): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::ClientBase): (WebCore::MediaStreamFrameController::ClientBase::~ClientBase): (WebCore::MediaStreamFrameController::ClientBase::mediaStreamFrameController): (WebCore::MediaStreamFrameController::ClientBase::clientId): (WebCore::MediaStreamFrameController::ClientBase::isStream): (WebCore::MediaStreamFrameController::ClientBase::isGeneratedStream): (WebCore::MediaStreamFrameController::ClientBase::detachEmbedder): (WebCore::MediaStreamFrameController::ClientBase::associateFrameController): (WebCore::MediaStreamFrameController::ClientBase::unregisterClient): (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::~StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isStream): (WebCore::MediaStreamFrameController::StreamClient::unregister): (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator): (WebCore::MediaStreamFrameController::IdGenerator::getNextId): (WebCore::MediaStreamFrameController::ClientMapBase::ClientMapBase):
  • page/Navigator.cpp: (WebCore::Navigator::webkitGetUserMedia):
  • page/NavigatorUserMediaErrorCallback.h:
10:09 Changeset [86582] by andreas.kling@nokia.com

2011-05-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=60892

Don't set the ItemClipsChildrenToShape flag for the root platform layer,
since that is now the overflow controls layer. The clip layer, which was
previously the root platform layer, already gets the flag by way of
the GraphicsLayer mask-to-bounds flag.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
09:58 Changeset [86581] by podivilov@chromium.org

2011-05-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: debuggerWasEnabled notification should not be send to front-end on navigation.
https://bugs.webkit.org/show_bug.cgi?id=60888

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::restore): (WebCore::InspectorDebuggerAgent::clearFrontend):
  • inspector/InspectorDebuggerAgent.h:
09:54 Changeset [86580] by andersca@apple.com

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
https://bugs.webkit.org/show_bug.cgi?id=60898
<rdar://problem/9309903>

Special-case Command-A and always return true, indicating that the plug-in handled the event.
This matches WebKit1.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
09:52 Changeset [86579] by commit-queue@webkit.org

2011-05-16 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursors
https://bugs.webkit.org/show_bug.cgi?id=60804

This test creates an object store with a few records and exercises
a variety of cursors going forward, backward, and over key ranges.
It also updates records from the cursor and checks that the update
stuck.

  • storage/indexeddb/mozilla/cursors-expected.txt: Added.
  • storage/indexeddb/mozilla/cursors.html: Added.
09:34 Changeset [86578] by andersca@apple.com

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Short-circuit NPRuntime calls made by Flash during plug-in instantiation
https://bugs.webkit.org/show_bug.cgi?id=60894
<rdar://problem/8804681>

During plug-in instantiation, Flash makes a couple of NPRuntime calls to get the
URL of the current document as well as the URL of the toplevel document. This leads to
a bunch of IPC traffic that slows down instantiation.

Since we know what calls Flash is making and what results are expected, we can handle the
NPRuntime calls directly in the plug-in process and avoid extra IPC overhead.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): Initialize m_pluginCreationParameters.

(WebKit::PluginControllerProxy::initialize):
Set m_pluginCreationParameters to point to the creation parameters right before
calling Plugin::initialize and restore it back afterwards.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
If the plug-in calling NPN_Invoke has the CanShortCircuitSomeNPRuntimeCallsDuringInitialization
quirk, and we're being initialized, check for the flash_getWindowLocation and
flash_getTopLocation function calls and return the correct values.

(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Check if the script string has the definitions of flash_getWindowLocation or flash_getTopLocation
and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
which could in theory be a backwards compatibility problem if web pages were to assume that these
functions existed on a page with plug-ins. In practice this is probably not a problem, especially since
these functions are only used on Mac WebKit.

  • PluginProcess/PluginControllerProxy.h: (WebKit::PluginControllerProxy::inInitialize): Add helper function.
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add the CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk for Flash on Mac.
  • Shared/Plugins/PluginQuirks.h: Add Mac specific CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk.
09:06 Changeset [86577] by andersca@apple.com

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add a returnValue parameter to tryToShortCircuitInvoke
https://bugs.webkit.org/show_bug.cgi?id=60891

tryToShortCircuitInvoke needs to be able to indicate that an invoke
call failed. Add a returnValue parameter and have the real return value
indicate whether tryToShortCircuitInvoke did short-circuit the invoke or not.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke):
  • WebProcess/Plugins/PluginView.h:
09:05 Changeset [86576] by commit-queue@webkit.org

2011-05-16 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove EAPI macro from functions definition
https://bugs.webkit.org/show_bug.cgi?id=60754

This macro should be used in header files only.
It's not necessary to have it in definitions.

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_window_features.cpp: (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get):
08:58 Changeset [86575] by jberlin@webkit.org

Remove the failing mac-wk2 expected results for online-fallback-layering.html, since it now
appears to be passing on the SL WK2 bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r86545%20(11698)/http/tests/appcache/online-fallback-layering-pretty-diff.html

  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Removed.
08:23 Changeset [86574] by ossy@webkit.org

[Qt][Wk2][Symbian] Fix build after r86560
https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2011-05-16
Reviewed by Csaba Osztrogonác.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with USE(UNIX_DOMAIN_SOCKETS)

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder): ditto

08:11 Changeset [86573] by andersca@apple.com

2011-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
https://bugs.webkit.org/show_bug.cgi?id=60886

Make it possible for a plug-in controller to intercept calls to NPN_Invoke, which
will be useful for avoiding sync IPC messages during instantiation.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::evaluate): Call tryToShortCircuitEvaluate. If it returns true, we don't need to call back to the web process to ask it to evaluate the script string.

(WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
(WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
Always return false for now.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke): Get the plug-in and call tryToShortCircuitInvoke.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::tryToShortCircuitInvoke): Call the plug-in controller.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::tryToShortCircuitInvoke): Always return false here, since there's no need to short-circuit calls for plug-ins that live in the web process.
07:49 Changeset [86572] by ademar.reis@openbossa.org

2011-05-16 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Tools.pro misses include(common.pri)
https://bugs.webkit.org/show_bug.cgi?id=60883

It includes features.pri, which depends on common.pri (the build is
not broken today with the default options, but this is the right
thing to do).

  • Tools.pro:
07:41 Changeset [86571] by ossy@webkit.org

Unreviewed, skip failing tests.

  • platform/mac-wk2/Skipped: Add fast/forms/focus-with-display-block.html because of missing eventSender.keyDown implementation
  • platform/qt-wk2/Skipped: Add fast/js/array-sort-modifying-tostring.html to make WK2 bot green to be able to catch new regressions
07:38 Changeset [86570] by pfeldman@chromium.org

2011-05-16 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector dom action test flake.

  • inspector/elements/edit-dom-actions.html:
07:26 Changeset [86569] by aroben@apple.com

Skip another new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Added fast/forms/focus-with-display-block.html.
07:23 Changeset [86568] by aroben@apple.com

Skip a new test that relies on parts of EventSender that WTR doesn't support

  • platform/mac-wk2/Skipped: Addd

platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html.

07:23 Changeset [86567] by aroben@apple.com

Update results for a new Mac dragging test

This test has been failing since it was added in r86472. I don't know whether the old
results are wrong or the test is actually showing a bug. <http://webkit.org/b/60882> tracks
the failure.

  • platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt:
06:44 Changeset [86566] by yurys@chromium.org

2011-05-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Windows build fix.

  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::consoleMarkTimeline):
06:36 Changeset [86565] by yurys@chromium.org

2011-05-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext):
06:27 Changeset [86564] by yurys@chromium.org

2011-05-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=60624

InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
about changes in WebCore.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed):
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::inspectedPage):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros is used for early return in common case when inspector is not opened. In this case inspector instrumentation costs one additional check of a static field. (WebCore::InspectorInstrumentation::didOpenDatabase):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl): (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willCallFunctionImpl): (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willEvaluateScriptImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::willLayoutImpl): (WebCore::InspectorInstrumentation::willLoadXHRImpl): (WebCore::InspectorInstrumentation::willPaintImpl): (WebCore::InspectorInstrumentation::willRecalculateStyleImpl): (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl): (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::willWriteHTMLImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::bindInstrumentingAgents): (WebCore::InspectorInstrumentation::unbindInstrumentingAgents): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::didInvalidateStyleAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::applyUserAgentOverride): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::continueAfterPingLoader): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied): (WebCore::InspectorInstrumentation::continueWithPolicyDownload): (WebCore::InspectorInstrumentation::continueWithPolicyIgnore): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::instrumentingAgentsForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext): (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):
06:18 Changeset [86563] by pfeldman@chromium.org

2011-05-16 Pavel Feldman <pfeldman@google.com>

Not reviewed: simplify inspector dom actions test.

  • inspector/elements/edit-dom-actions.html:
05:56 Changeset [86562] by commit-queue@webkit.org

2011-05-16 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Move Resources Panel search to backend
https://bugs.webkit.org/show_bug.cgi?id=59596

  • inspector/Inspector.json:
  • inspector/InspectorPageAgent.cpp: (WebCore::decodeMainResource): (WebCore::InspectorPageAgent::resourceContent): (WebCore::cachedResourcesForFrame): (WebCore::InspectorPageAgent::getCookies): (WebCore::InspectorPageAgent::deleteCookie): (WebCore::createSearchRegexSource): (WebCore::countRegularExpressionMatches): (WebCore::buildObjectForSearchMatch): (WebCore::InspectorPageAgent::searchInResources): (WebCore::InspectorPageAgent::domContentEventFired): (WebCore::InspectorPageAgent::loadEventFired): (WebCore::InspectorPageAgent::frameNavigated): (WebCore::InspectorPageAgent::frameDetached): (WebCore::InspectorPageAgent::buildObjectForFrameTree):
  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype.performSearch.searchInEditedResource): (WebInspector.ResourcesPanel.prototype.performSearch.callback): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype._ensureViewSearchPerformed): (WebInspector.ResourcesPanel.prototype._showSearchResult.callback): (WebInspector.ResourcesPanel.prototype._showSearchResult): (WebInspector.ResourcesPanel.prototype._resetSearchResults): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult): (WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult): (WebInspector.FrameTreeElement.prototype.resourceByURL): (WebInspector.FrameResourceTreeElement.prototype._resetSearchResults): (WebInspector.FrameResourceTreeElement.prototype.get searchMatchesCount): (WebInspector.FrameResourceTreeElement.prototype.searchMatchesFound): (WebInspector.ResourcesSearchController): (WebInspector.ResourcesSearchController.prototype.nextSearchResult): (WebInspector.ResourcesSearchController.prototype.previousSearchResult): (WebInspector.ResourcesSearchController.prototype._searchResult): (WebInspector.SearchResultsTreeElementsTraverser): (WebInspector.SearchResultsTreeElementsTraverser.prototype.first): (WebInspector.SearchResultsTreeElementsTraverser.prototype.last): (WebInspector.SearchResultsTreeElementsTraverser.prototype.next): (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext): (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementHasSearchResults): (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.createSearchRegex): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.hasSearchResults): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.jumpToSearchResult): (WebInspector.SourceFrame.prototype._collectRegexMatches):
  • inspector/front-end/utilities.js: ():
05:42 Changeset [86561] by andreas.kling@nokia.com

2011-05-16 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

CSS: Fast path for 'px' lengths should be case-insensitive.
https://bugs.webkit.org/show_bug.cgi?id=60703

No new tests, this is an optimization that avoids creating
a full CSSParser to parse the value.

  • css/CSSParser.cpp: (WebCore::parseSimpleLengthValue):
05:40 Changeset [86560] by commit-queue@webkit.org

2011-05-16 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
https://bugs.webkit.org/show_bug.cgi?id=55875

  • wtf/Platform.h: Exclude Symbian OS from USE(UNIX_DOMAIN_SOCKETS) users

2011-05-16 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2][Symbian] Shared memory implementation for Symbian
https://bugs.webkit.org/show_bug.cgi?id=55875

Use global chunks for sharing data between processes.
This is an initial implementation. An outstanding issue
is the correct way to close() the chunk in the SharedMemory d'tor
without triggering a delete by the kernel when the ref-count
temporarily goes to zero.

  • Platform/SharedMemory.h: platform specific handle and chunk name
  • Platform/qt/SharedMemorySymbian.cpp: Added. Native Symbian OS implementation using RChunk.CreateGlobal() for named chunks. The chunk name is serialized and sent over the IPC channel and opened by the remote process using RChunk.OpenGlobal().

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
(WebKit::SharedMemory::systemPageSize):

  • Platform/unix/SharedMemoryUnix.cpp: Exclude Qt-Symbian using HAVE(UNIX_DOMAIN_SOCKETS)
  • WebKit2.pro: Add SharedMemorySymbian.cpp
05:28 Changeset [86559] by apavlov@chromium.org

Merge 85402 - 2011-04-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector toolbar titles were 2px off.

  • inspector/front-end/inspector.css: (#toolbar-dropdown .toolbar-label):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7032004

05:24 Changeset [86558] by apavlov@chromium.org

Merge 86027 - 2011-05-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: ignore 0 responses in the inspector network instrumentation.

  • inspector/front-end/NetworkManager.js:

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7030014

05:05 Changeset [86557] by abecsi@webkit.org

2011-05-16 Naiem Shaik <naiem.shaik@gmail.com>

Reviewed by Adam Barth.

This is for fixing build break in webgl due to https://bugs.webkit.org/show_bug.cgi?id=59861
The bug raised for fixing this is https://bugs.webkit.org/show_bug.cgi?id=60867

No new tests. This does not change any functionality.

  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: (WebCore::GraphicsContext3D::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.cpp: (WebCore::GraphicsContext3DInternal::create):
  • platform/graphics/gtk/GraphicsContext3DInternal.h:
05:00 Changeset [86556] by pfeldman@chromium.org

2011-05-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: parse edited attributes by means of InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=60807

This change moves attribute parsing from the front-end to the backend.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttribute):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
03:58 Changeset [86555] by zimmermann@webkit.org

2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Switch from Vector<UChar> to StringBuilder in dom/
https://bugs.webkit.org/show_bug.cgi?id=57843

Incorporate comment from Darin/Andreas.

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i]. (WebCore::convertPropertyNameToAttributeName): Ditto.
03:51 Changeset [86554] by apavlov@chromium.org

2011-05-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:

2011-05-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
https://bugs.webkit.org/show_bug.cgi?id=60773

  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
03:20 Changeset [86553] by zimmermann@webkit.org

2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

Switch from Vector<UChar> to StringBuilder in dom/
https://bugs.webkit.org/show_bug.cgi?id=57843

  • dom/DatasetDOMStringMap.cpp: (WebCore::convertAttributeNameToPropertyName): (WebCore::convertPropertyNameToAttributeName):
  • dom/Range.cpp: (WebCore::Range::toString):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptContent):
02:53 Changeset [86552] by podivilov@chromium.org

2011-05-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move double click handling from TextEditor to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=60271

It is SourceFrame's responsibility to check if content is editable and
to configure TextEditor component (e.g. set editable range) when user
tries to initiate editing.

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.doubleClick): (WebInspector.RevisionSourceFrame.prototype.doubleClick):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.beforeTextChanged): (WebInspector.SourceFrame.prototype.afterTextChanged): (WebInspector.SourceFrame.prototype.doubleClick): (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.cancelEditing): (WebInspector.SourceFrame.prototype._setReadOnly):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._doubleClick): (WebInspector.TextViewer.prototype._commitEditing): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewerDelegate.prototype.doubleClick): (WebInspector.TextViewerDelegate.prototype.beforeTextChanged): (WebInspector.TextViewerDelegate.prototype.afterTextChanged):
02:50 Changeset [86551] by loislo@chromium.org

2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:
02:30 Changeset [86550] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Partial revert of r86537. FullScreenVideoQt.h can't depend on OwnPtr.h
because moc_FullScreenVideoQt.cpp fails to include config.h.
Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
is hard, so we're going back to manual new and delete for this class.
Bad times.

  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
02:27 Changeset [86549] by carlosgc@webkit.org

2011-05-16 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r86489.

  • GNUmakefile.am: Add PluginProcess/PluginCreationParameters.cpp and PluginProcess/PluginCreationParameters.h to compilation.
02:17 Changeset [86548] by commit-queue@webkit.org

2011-05-16 Huzaifa Sidhpurwala <huzaifas@redhat.com>

Reviewed by Adam Barth.

Add Huzaifa Sidhpurwala to the WebKit Security Group site.
https://bugs.webkit.org/show_bug.cgi?id=60686

  • security/security-group-members.html:
02:08 Changeset [86547] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=60866
Evaluation order broken for empty alternatives in subpatterns

Rubber stamped by Geoff Garen.

Source/JavaScriptCore:

Reverting https://bugs.webkit.org/show_bug.cgi?id=51395

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

LayoutTests:

Reverted https://bugs.webkit.org/show_bug.cgi?id=51395, and added
test cases for /(|a)/ and /(a|)/, to test the evaluation order of
subpattern matches with empty alternatives.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
  • fast/regex/script-tests/slow.js:
  • fast/regex/slow-expected.txt:
01:25 Changeset [86546] by alex@webkit.org

2011-05-16 Alejandro G. Castro <alex@igalia.com>

Skipped failing test, the fail already has a bug:

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834

  • platform/gtk/Skipped:
01:05 Changeset [86545] by carlosgc@webkit.org

2011-05-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=58223

  • configure.ac: Add configure option to enable/disable plugin process.

2011-05-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=58223

  • GNUmakefile.am: Add new files to compilation.
  • PluginProcess/gtk/PluginControllerProxyGtk.cpp: Added. (WebKit::PluginControllerProxy::platformInitialize): (WebKit::PluginControllerProxy::platformDestroy): (WebKit::PluginControllerProxy::platformGeometryDidChange):
  • PluginProcess/gtk/PluginProcessGtk.cpp: Added. (WebKit::PluginProcess::platformInitialize):
  • UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp: Added. (WebKit::PluginProcessProxy::platformInitializePluginProcess):
  • WebProcess/Plugins/Netscape/gtk/PluginProxyGtk.cpp: Added. (WebKit::PluginProxy::needsBackingStore):
01:02 Changeset [86544] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createGraphicsContext):
00:59 Changeset [86543] by zimmermann@webkit.org

2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
https://bugs.webkit.org/show_bug.cgi?id=60700

Oops, forgot to include plugins/ in my previous commit.

Remove makeString() usage everywhere, instead directly use operator+.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
00:56 Changeset [86542] by zimmermann@webkit.org

2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace direct StringConcatenate usage, by using operator+ (again)
https://bugs.webkit.org/show_bug.cgi?id=60700

Remove makeString() usage everywhere, instead directly use operator+.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::borderSpacingValue):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
  • html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::didReceiveResponse):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::crossDomainAccessErrorMessage):
  • page/PageSerializer.cpp: (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator): (WebCore::SerializerMarkupAccumulator::appendElement): (WebCore::PageSerializer::urlForBlankFrame):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
  • platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationIdentifier):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL):
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL):
  • platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::reportErrorToClient):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeURL):
  • platform/win/FileSystemWin.cpp: (WebCore::listDirectory):
  • platform/win/LanguageWin.cpp: (WebCore::platformDefaultLanguage):
  • platform/win/PathWalker.cpp: (WebCore::PathWalker::PathWalker):
  • platform/win/SystemInfo.cpp: (WebCore::osVersionForUAString): (WebCore::windowsVersionForUAString):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::valueAsString):
  • svg/SVGLength.cpp: (WebCore::SVGLength::valueAsString):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::cssText):
  • svg/SVGPointList.cpp: (WebCore::SVGPointList::valueAsString):
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::valueAsString):
  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString):
  • svg/SVGTransformList.cpp:
  • svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
00:51 Changeset [86541] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Sigh. This code is somewhat crazy.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
00:43 Changeset [86540] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

This patch requires some slightly fancy footwork.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
00:30 Changeset [86539] by yurys@chromium.org

2011-05-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector console should be searchable
https://bugs.webkit.org/show_bug.cgi?id=60711

Search now works for Console panel. It shows number of matching console entries
and allows to jump to the next matching console entry. Also the matches count
is dynamically updated when new messages are added to the console.

ResourceTreeModel and DebuggerPresentationModel now listen to console events instead
of being called directly from ConsoleView.

  • inspector/front-end/ConsolePanel.js: (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide): (WebInspector.ConsolePanel.prototype.searchCanceled): (WebInspector.ConsolePanel.prototype.performSearch): (WebInspector.ConsolePanel.prototype.jumpToNextSearchResult): (WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult): (WebInspector.ConsolePanel.prototype._clearCurrentSearchResultHighlight): (WebInspector.ConsolePanel.prototype._jumpToSearchResult): (WebInspector.ConsolePanel.prototype._consoleMessageAdded): (WebInspector.ConsolePanel.prototype._consoleCleared):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage.prototype.clearHighlight): (WebInspector.ConsoleMessage.prototype.highlightSearchResults): (WebInspector.ConsoleMessage.prototype.matchesRegex): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype.clearHighlight): (WebInspector.ConsoleCommand.prototype.highlightSearchResults): (WebInspector.ConsoleCommand.prototype.matchesRegex): (WebInspector.ConsoleCommand.prototype.toMessageElement): (WebInspector.ConsoleCommand.prototype._formatCommand):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded): (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
  • inspector/front-end/utilities.js: ():
00:27 Changeset [86538] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

Missing include.

  • WebCoreSupport/PopupMenuQt.h:
00:24 Changeset [86537] by abarth@webkit.org

2011-05-16 Adam Barth <abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60873

This change is slightly more than a build fix because the patch kind of
spidered a bit while I was trying to fix the build the "right way."
Hopefully nothing here is controversial.

  • Api/qwebpage.cpp: (QWebPagePrivate::adjustPointForClicking):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
  • WebCoreSupport/FullScreenVideoQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationWrapper::NotificationWrapper): (WebCore::NotificationPresenterClientQt::displayNotification):
  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::show):
  • WebCoreSupport/PopupMenuQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createSelectInputMethod): (WebCore::QtPlatformPlugin::createNotificationPresenter): (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer): (WebCore::QtPlatformPlugin::createTouchModifier): (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h: (WebCore::QtPlatformPlugin::QtPlatformPlugin):

2011-05-16 Adam Barth <abarth@webkit.org>

[Qt] QtPlatformPlugin create methods should use PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=60873

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart):
00:21 Changeset [86536] by barraclough@apple.com

Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=60860
Simplify backtracking in YARR JIT

Reviewed by Geoff Garen & Michael Saboff.

YARR JIT currently performs a single pass of code generation over the pattern,
with special handling to allow the code generation for some backtracking code
out of line. We can simplify things by moving to a common mechanism whereby all
forwards matching code is generated in one pass, and all backtracking code is
generated in another. Backtracking code can be generated in reverse order, to
optimized the common fall-through case.

To make it easier to walk over the pattern, we can first convert to a more
byte-code like format before JIT generating. In time we should unify this with
the YARR interpreter to more closely unify the two.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):
(JSC::Yarr::YarrGenerator::BacktrackingState::BacktrackingState):
(JSC::Yarr::YarrGenerator::BacktrackingState::append):
(JSC::Yarr::YarrGenerator::BacktrackingState::fallthrough):
(JSC::Yarr::YarrGenerator::BacktrackingState::link):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkTo):
(JSC::Yarr::YarrGenerator::BacktrackingState::takeBacktracksToJumpList):
(JSC::Yarr::YarrGenerator::BacktrackingState::isEmpty):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkDataLabels):
(JSC::Yarr::YarrGenerator::BacktrackingState::ReturnAddressRecord::ReturnAddressRecord):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::backtrackAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileAlternative):
(JSC::Yarr::YarrGenerator::opCompileBody):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=60860
Add layout tests for some regular expressions that used to crash the compiler.

Reviewed by Geoff Garen & Michael Saboff.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
00:07 Changeset [86535] by philn@webkit.org

2011-05-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

media/video-volume-slider.html causes GTK 64 bit debug bot to time out
https://bugs.webkit.org/show_bug.cgi?id=60055

  • media/video-volume-slider.html: Use the shadow DOM tree to locate the mute button and get its coordinates. This test is now more port-agnostic.
00:01 Changeset [86534] by philn@webkit.org

2011-05-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Darin Adler.

Move mediaControlsButtonCoordinates() out of video-test.js
https://bugs.webkit.org/show_bug.cgi?id=60693

Moved the function to a new js file called media-controls.js. Also
made the function throw an exception if the button is not found
and handle the exception in the various tests using the function.

  • media/audio-delete-while-step-button-clicked.html:
  • media/media-controls.js: Added. (mediaControlsButtonCoordinates):
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-test.js: (isInTimeRanges):

05/15/11:

23:52 Changeset [86533] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt build. (Strict PassOwnPtr fix.)

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::detachCurrentPage): (QGraphicsWebView::setPage):
  • Api/qwebpage.cpp: (QWebPage::setView):
23:46 Changeset [86532] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::GraphicsLayerQt): (WebCore::GraphicsLayer::create):
23:41 Changeset [86531] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/text/qt/TextCodecQt.cpp: (WebCore::newTextCodecQt):
23:36 Changeset [86530] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::release): (WebCore::QNetworkReplyWrapper::receiveMetaData): (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType): (WebCore::QNetworkReplyHandler::release): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::redirect): (WebCore::QNetworkReplyHandler::start):
23:30 Changeset [86529] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build. (Strict PassOwnPtr fix.)

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doEnd):
23:21 Changeset [86528] by abarth@webkit.org

2011-05-15 Adam Barth <abarth@webkit.org>

Enable strict PassOwnPtr on Qt. (Build fixes to follow.)

  • wtf/PassOwnPtr.h:
23:15 Changeset [86527] by morrita@google.com

2011-05-15 MORITA Hajime <morrita@google.com>

Unreviewed an expectation update.

  • platform/gtk/fast/html/details-add-child-2-expected.txt:
22:59 Changeset [86526] by commit-queue@webkit.org

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

Add a test that ensures <output>, <meter> and <progress> are not focused.
Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

  • fast/forms/focus-with-display-block-expected.txt: Added.
  • fast/forms/focus-with-display-block.html: Added.
  • platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.

2011-05-15 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

<output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
https://bugs.webkit.org/show_bug.cgi?id=60602

HTMLFormControlElement::isFocusable() returns true when the element is
visible as a block element. However, for output, meter, and progress
elements, the function should not return true unless they have
tabindex attributes. Override supportsFocus() of these elements to
apply the result of Node::supportsFocus() because it takes care of
whether the element has tabindex or not.

Test: fast/forms/focus-with-display-block.html

  • html/HTMLFormControlElement.h: Made supportsFocus() protected.
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::supportsFocus): Added.
  • html/HTMLMeterElement.h:
  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::supportsFocus): Added.
  • html/HTMLOutputElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::supportsFocus): Added.
  • html/HTMLProgressElement.h:
22:44 Changeset [86525] by jonlee@apple.com

Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

22:31 Changeset [86524] by msaboff@apple.com

2011-05-15 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
https://bugs.webkit.org/show_bug.cgi?id=60864

Implemented reuse of BackingStore's in
DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
matches the size of the existing BackingStore.
Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
These changes reduces memory usage up to 10MB on memory tests.

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
22:10 Changeset [86523] by ggaren@apple.com

2011-05-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=59699
Global object is recreated on teardown, for no good reason


(Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
~7% slower in browser than on command line (was 17%))


I'm basically rolling out http://trac.webkit.org/changeset/49786 because

(a) it created this performance problem


and


(b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
was committed in http://trac.webkit.org/changeset/53439.


Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.

  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't create a new window every time we destroy a frame.
20:29 Changeset [86522] by andersca@apple.com

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Pass the window NPObject identifier in the plug-in creation parameters
https://bugs.webkit.org/show_bug.cgi?id=60865

This avoids a synchronous call when the plug-in wants to get the NPObject that
corresponds to the window.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): Change this to take the PluginCreationParameters. Initialize the window NPObject.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Just return the window NPObject; it's already been initialized.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginCreationParameters.cpp: (WebKit::PluginCreationParameters::PluginCreationParameters): (WebKit::PluginCreationParameters::encode): (WebKit::PluginCreationParameters::decode):
  • PluginProcess/PluginCreationParameters.h: Add the window NPObject ID.
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin): Pass the creation parameters to PluginControllerProxy::initialize.
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Initialize the window NPObject ID.
  • WebProcess/Plugins/PluginProxy.messages.in: Remove the GetWindowScriptNPObject message.
19:55 Changeset [86521] by morrita@google.com

2011-05-12 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

  • fast/html/details-add-details-child-1.html: Added.
  • fast/html/details-add-details-child-2.html: Added.
  • fast/html/details-nested-1.html: Added.
  • fast/html/details-nested-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.png: Added.
  • platform/mac/fast/html/details-nested-1-expected.txt: Added.
  • platform/mac/fast/html/details-nested-2-expected.png: Added.
  • platform/mac/fast/html/details-nested-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:

2011-05-12 MORITA Hajime <morrita@google.com>

ShadowContentElement should affect the order of renderer children
https://bugs.webkit.org/show_bug.cgi?id=59157

Introduced ShadowContentSelector to collect and forward content
children for each ShadowContentElement. ShadowRoot collects child
nodes of its host (we call these children "content children"), and
the descendant ShadowContentElement pulls that these content
children and put it under its child during
ShadowContentElement::attach().

Content children no longer create its renderer during its normal
attach() phase (called "light" phase). And they create it during
attach() as a content children instead (called "forwarded phase").
These phases are detected by NodeRendererFactory and represented
as NodeRendererFactory::AttachPhase value AttachContentLight and
AttachContentForwarded.

Tests: fast/html/details-add-details-child-1.html

fast/html/details-add-details-child-2.html
fast/html/details-nested-1.html
fast/html/details-nested-2.html

  • dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/ShadowRoot.cpp: (WebCore::forceReattach): (WebCore::ShadowContentSelector::shadowRoot): (WebCore::ShadowContentSelector::activeElement): (WebCore::ShadowContentSelector::currentInstance): (WebCore::ShadowContentSelector::ShadowContentSelector): (WebCore::ShadowContentSelector::~ShadowContentSelector): (WebCore::ShadowContentSelector::attachChildrenFor): (WebCore::ShadowContentElement::attach): (WebCore::ShadowRoot::recalcStyle): (WebCore::ShadowRoot::activeContentContainer): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::attach):
  • dom/ShadowRoot.h:
  • html/shadow/ShadowContentElement.h: (WebCore::ShadowContentElement::rendererIsNeeded):
  • rendering/RenderDetails.cpp:
  • rendering/RenderDetails.h:
19:46 Changeset [86520] by morrita@google.com

2011-05-13 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
https://bugs.webkit.org/show_bug.cgi?id=57088

Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::resolveTextCheckingTypeMask):
  • editing/Editor.h:
  • platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel
18:44 Changeset [86519] by yuzo@google.com

2011-05-15 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.
18:35 Changeset [86518] by dominicc@chromium.org

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed. Remove expectation of gc-shadow.html flakiness.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [86517] by dominicc@chromium.org

2011-05-15 Dominic Cooney <dominicc@chromium.org>

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
17:53 Changeset [86516] by andersca@apple.com

2011-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Pass the document URL and toplevel document URL when creating a plug-in
https://bugs.webkit.org/show_bug.cgi?id=60863

This is the first of a series of patches intended to reduce the IPC traffic
during plug-in instantiation.

  • WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::Parameters::encode): Encode the URLs.

(WebKit::Plugin::Parameters::decode):
Decode the URLs.

  • WebProcess/Plugins/Plugin.h: Add the document and toplevel document URLs.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin): Initialize the document and toplevel document URLs.
16:54 Changeset [86515] by dbates@webkit.org

2011-05-15 Daniel Bates <dbates@webkit.org>

Reviewed by Chris Jerdonek.

svn-apply can't handle Git diff that only changes executable bit
https://bugs.webkit.org/show_bug.cgi?id=60848

Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
that only has an executable bit change.

  • Scripts/VCSUtils.pm:
    • Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().

(parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.

  • Scripts/svn-apply: (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
  • Scripts/svn-unapply: (patch): Ditto.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated expected results for test cases to account for numTextChunks.
    • Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
    • Added test case "Git: file that only has an executable bit change".
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
    • Updated expected results for test cases to account for numTextChunks.
16:20 Changeset [86514] by rwlbuis@webkit.org

2011-05-15 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
https://bugs.webkit.org/show_bug.cgi?id=16614

Include testcase from the bug to prevent future regression (right now we pass both full testcase
and this reduction).

  • platform/mac/svg/custom/small-rect-scale-expected.png: Added.
  • platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
  • svg/custom/small-rect-scale.svg: Added.
16:02 Changeset [86513] by weinig@apple.com

Fix windows build.

  • TestWebKitAPI/win/main.cpp:

(main):

15:49 Changeset [86512] by ossy@webkit.org

Unreviewed typo fix after r86509.

  • platform/qt/Skipped:
15:41 Changeset [86511] by weinig@apple.com

2011-05-15 Sam Weinig <sam@webkit.org>

Reviewed by David Levin.

Make API tester more gtest friendly
https://bugs.webkit.org/show_bug.cgi?id=60859

  • Scripts/run-api-tests: Numerous changes:
  • Remove logic to run tests one at a time.
  • Remove logic to build up a list of tests, instead just pass --gtest_list_tests to the test runner and allow gtest to print it for us.
  • Forward stdout from the test tool to stdout, even in non-verbose runs.
  • Run test tool from the current working directory instead of the root webkit directory.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Move plist to be with other bundle sources.
  • TestWebKitAPI/TestsController.cpp: (TestWebKitAPI::TestsController::TestsController): (TestWebKitAPI::TestsController::run):
  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm: Simplify TestController down to a single run function. We should consider removing the class entirely at some point.
15:31 Changeset [86510] by ggaren@apple.com

Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

  • jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • runtime/JSFunction.cpp: Made the host function stub cache weak --

otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

11:43 Changeset [86509] by loislo@chromium.org

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just skipping a test.

  • platform/qt/Skipped: inspector/console/console-long-eval-crash.html
10:34 Changeset [86508] by eric.carlson@apple.com

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Unreviewed, just skipping a test.

New test fails on some of the SnowLeopard bots.

  • platform/mac-snowleopard/Skipped:
09:57 Changeset [86507] by loislo@chromium.org

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
09:18 Changeset [86506] by eric.carlson@apple.com

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Test: http/tests/media/video-cross-site.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Set restriction

to prevent cross-domain references from being followed.

2011-05-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

Use new AVAssetReferenceRestrictions to prevent cross site media references
https://bugs.webkit.org/show_bug.cgi?id=60791
<rdar://problem/9374202>

Add test for cross-domain QuickTime reference movie and test.

  • http/tests/media/resources/cross-site-reference.mov: Added.
  • http/tests/media/video-cross-site-expected.txt: Added.
  • http/tests/media/video-cross-site.html: Added.
  • platform/chromium/test_expectations.txt: Skipped, QuickTime reference movies not supported.
  • platform/gtk/Skipped: Ditto.
07:07 Changeset [86505] by commit-queue@webkit.org

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86504.
http://trac.webkit.org/changeset/86504
https://bugs.webkit.org/show_bug.cgi?id=60853

"Broke Qt EventSender in editing/selection tests" (Requested
by mwenge on #webkit).

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::eventSender):
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
06:49 Changeset [86504] by robert@webkit.org

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

For some reason the platform-independent expected result has
no newline at the end of the file. The unix test plugin also
reports the event from a different line. These are harmless
differences, so create platform-specific result.

Note that nearly every platform skips this test at the moment.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • platform/qt/Skipped:
  • platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html
https://bugs.webkit.org/show_bug.cgi?id=60722

QWebPage::setView() will display the browser window, so
implement a private version that does just enough to
satisfy EventSender's requirement to install an event
filter on a page's web view.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setView):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-12 Robert Hogan <robert@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] fix http/tests/plugins/plugin-document-has-focus.html

The support for this test added to the unix test plugin here
may allow other platforms to pass it (nearly everyone
skips it). On Qt it required a bit of trickiness with
the page's EventSender object to get it working fully though,
so only unskipping Qt here.

https://bugs.webkit.org/show_bug.cgi?id=60722

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::eventSender): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): (webkit_test_plugin_handle_event):
04:40 Changeset [86503] by commit-queue@webkit.org

2011-05-15 Arno Renevier <arno@renevier.net>

Reviewed by Darin Adler.

remove unecessary includes from Source/WebCore/html/HTMLFrameElementBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=60775

No new tests. This change only impacts compilation.

  • html/HTMLFrameElementBase.cpp:
Note: See TracTimeline for information about the timeline view.