Timeline


and

05/23/11:

23:39 Changeset [87130] by ukai@chromium.org

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87118.
http://trac.webkit.org/changeset/87118
https://bugs.webkit.org/show_bug.cgi?id=61347

patch breaks layout tests
(https://bugs.webkit.org/show_bug.cgi?id=61342), and chromium
tests (browser_test MacTestCmdUp and ui_test Scrollbar)
(Requested by ukai_ on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/ScrollAnimator.cpp:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  • platform/graphics/IntPoint.h:
23:09 Changeset [87129] by inferno@chromium.org

Merge 87098 Build Fix
BUG=83012
Review URL: http://codereview.chromium.org/6992020

23:07 Changeset [87128] by commit-queue@webkit.org

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Adam Barth.

Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

No new tests as this is just a removal.

  • dom/ContainerNode.cpp:
  • dom/ContainerNode.h:
  • dom/Node.cpp:
  • dom/Node.h: Removed the method now that the last instance got removed as part of the <input> shadow DOM refactoring.
22:28 Changeset [87127] by krit@webkit.org

2011-05-23 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVGTextPositioning attributes are marked as NumberList instead of LengthList
https://bugs.webkit.org/show_bug.cgi?id=61301

SVGTextPositioningElement attributes x, y, dx and dy were marked as AnimatedNumberList
instead of AnimatedLengthList.
See specification http://www.w3.org/TR/SVG/text.html#InterfaceSVGTextPositioningElement

This does not affect the behavior, since we do not respect SVG units in SMIL animation yet.
No new tests added.

  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
21:53 Changeset [87126] by ukai@chromium.org

Unreviewed.

Chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61342

  • platform/chromium/test_expectations.txt:
21:11 Changeset [87125] by morrita@google.com

2011-05-19 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] Pass NodeRenderingContext to Node::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=61114

  • Extracted NodeRenderingContext from NodeRendererFactory, giving separate files to it.
  • Changed signature rendererIsNeeded(RenderStyle*) to rendererIsNeeded(const NodeRenderingContext&). The style object is retrieved from NodeRendererFactory::style() This will allow rendererIsNeeded() to access contextual information like attaching phase and rendering-parent.

No new tests. No behaviour change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer): Pass unresolved NodeRenderingContext& to rendererIsNeeded() (WebCore::CharacterData::rendererIsNeeded):
  • dom/CharacterData.h:
  • dom/DOMAllInOne.cpp:
  • dom/EditingText.cpp: (WebCore::EditingText::rendererIsNeeded):
  • dom/EditingText.h:
  • dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::rendererIsNeeded):
  • dom/Node.h:
  • dom/NodeRenderingContext.cpp: Added. (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::~NodeRenderingContext): (WebCore::NodeRenderingContext::setStyle): (WebCore::NodeRenderingContext::releaseStyle): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::hostChildrenChanged): (WebCore::NodeRenderingContext::shouldCreateRenderer): (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/NodeRenderingContext.h: Added. (WebCore::NodeRenderingContext::node): (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle): (WebCore::NodeRenderingContext::style): (WebCore::NodeRendererFactory::context):
  • dom/ShadowContentElement.h:
  • dom/Text.cpp:
  • dom/Text.h:
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLElement.cpp:
  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLNoScriptElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLVideoElement.cpp:
  • html/HTMLVideoElement.h:
  • html/shadow/DetailsMarkerControl.cpp:
  • html/shadow/DetailsMarkerControl.h:
  • html/shadow/MeterShadowElement.cpp:
  • html/shadow/MeterShadowElement.h:
  • html/shadow/ProgressShadowElement.cpp:
  • html/shadow/ProgressShadowElement.h:
  • svg/SVGDescElement.h:
  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.h:
  • svg/SVGGElement.cpp:
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp:
  • svg/SVGStyledElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp:
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp:
  • svg/SVGTSpanElement.h:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:
20:41 Changeset [87124] by tony@chromium.org

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] don't use NetworkTranslation when uploading results
https://bugs.webkit.org/show_bug.cgi?id=61315

This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
20:31 Changeset [87123] by morrita@google.com

2011-05-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] attach() following detach() should be replaced with Node::reattach()
https://bugs.webkit.org/show_bug.cgi?id=61011

  • Renamed forceReattach() to reattach()
  • Introduced reattachIfAttached() as a variant.

No new tests. No behavior change.

  • dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • dom/Node.h: (WebCore::Node::reattach): (WebCore::Node::reattachIfAttached):
  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::recalcStyle):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
20:26 Changeset [87122] by mrowe@apple.com

Build fix after r87117.

When moving #defines out in to separate files I find that code is more likely to compile
when the new header file is actually #included.

  • editing/SpellingCorrectionController.h:
19:25 Changeset [87121] by commit-queue@webkit.org

2011-05-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

  • css3/images/optimize-contrast-canvas-expected.checksum: Added.
  • css3/images/optimize-contrast-canvas-expected.png: Added.
  • css3/images/optimize-contrast-canvas-expected.txt: Added.
  • css3/images/optimize-contrast-canvas.html: Added.
  • css3/images/optimize-contrast-image-expected.checksum: Added.
  • css3/images/optimize-contrast-image-expected.png: Added.
  • css3/images/optimize-contrast-image-expected.txt: Added.
  • css3/images/optimize-contrast-image.html: Added.

2011-05-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

Tests: css3/images/optimize-contrast-canvas.html

css3/images/optimize-contrast-image.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Added.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
19:15 Changeset [87120] by jschuh@chromium.org

2011-05-23 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium multiple expectations update.

  • platform/chromium/test_expectations.txt:
19:08 Changeset [87119] by andersca@apple.com

2011-05-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Cap painting to 30fps on Windows
https://bugs.webkit.org/show_bug.cgi?id=61337
<rdar://problem/9213388>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::displayTimerFired):
19:04 Changeset [87118] by commit-queue@webkit.org

2011-05-23 Sailesh Agrawal <sail@chromium.org>

Reviewed by James Robinson.

Chromium Mac: Use ScrollAnimatorMac.mm for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/ScrollAnimator.cpp:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h:
18:58 Changeset [87117] by morrita@google.com

2011-05-22 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
https://bugs.webkit.org/show_bug.cgi?id=61181

  • Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
  • Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h

No new tests. Just renaming a compilation conditional.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
  • editing/SpellingCorrectionController.cpp:
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  • loader/EmptyClients.h:
  • page/EditorClient.h:
  • platform/text/TextChecking.h:
18:56 Changeset [87116] by tony@chromium.org

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by Dirk Pranke.

[chromium] fix the rebaseline tool to work with Linux GPU failures
https://bugs.webkit.org/show_bug.cgi?id=61312

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
18:52 Changeset [87115] by commit-queue@webkit.org

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329

patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).

  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329

patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId):
18:17 Changeset [87114] by jchaffraix@webkit.org

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
<rdar://problem/9191214>

  • fast/storage/storage-detached-iframe-expected.txt: Added.
  • fast/storage/storage-detached-iframe.html: Added.
  • platform/chromium/test_expectations.txt: Marked the test as CRASH on Chromium - Linux.

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140

Test: fast/storage/storage-detached-iframe.html

Access of localStorage on a detached iframe was causing a crash because a detached
iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.

  • storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): check that child->page() is non-null before accessing it.
18:02 Changeset [87113] by jer.noble@apple.com

2011-05-23 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (r86990:86992): World leak when all windows closed
https://bugs.webkit.org/show_bug.cgi?id=61311

Three interlocking problems:

1) Calling [WKView fullScreenController] will create the controller if it doesn't all ready
exist, so move the closing code into WKView, where we can bail early if there isn't a
controller.

2) A retain-cycle exists between WKView and WKFullScreenWindowController. Make sure to break
the cycle explicitly by clearing the _fullScreenWindowController ivar when closing the
controller.

3) [NSWindowController close] was overridden without calling [super close]. Do that.

  • UIProcess/API/mac/WKView.mm: (-[WKView closeFullScreenWindowController]): Moved here from WebFullScreenManagerProxyMac.mm.
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Call [super close].
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate):
17:54 Changeset [87112] by darin@apple.com

Ignore generated .pyc files in a directory full of python code.

  • Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
17:31 Changeset [87111] by cfleizach@apple.com

VO doesn't work with HTML5 range (slider) input @step attribute
https://bugs.webkit.org/show_bug.cgi?id=61298

Reviewed by David Kilzer.

Source/WebCore:

Test: platform/mac/accessibility/range-alter-by-step.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::stepValueForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::alterSliderValue):
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::stepValueForRange):
(WebCore::AccessibilityRenderObject::changeValueByStep):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/range-alter-by-step-expected.txt: Added.
  • platform/mac/accessibility/range-alter-by-step.html: Added.
17:29 Changeset [87110] by rniwa@webkit.org

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Rebaselines work better if we had the new lines at the end of each file.

  • platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt:
  • platform/gtk/fast/events/selectstart-by-drag-expected.txt:
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt:
  • platform/qt/fast/events/selectstart-by-drag-expected.txt:
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt:
  • platform/win/fast/events/selectstart-by-drag-expected.txt:
17:09 Changeset [87109] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=61306

Reviewed by Geoff Garen.

The begin characters optimization currently has issues (#61129),
and does not appear to still be a performance win. The prudent
next step seems to be to disable while we ascertain whether this
is still a useful performance optimization.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):

16:53 Changeset [87108] by ddkilzer@apple.com

Part 1 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE

Merge ANGLE upstream commit r653 for Issue 154.

  • src/compiler/PoolAlloc.h: Added newline to end of file.
  • src/compiler/ShHandle.h: Ditto.
  • src/libEGL/Display.cpp: Ditto.
16:52 Changeset [87107] by abarth@webkit.org

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot should give more details about the failures in IRC
https://bugs.webkit.org/show_bug.cgi?id=61233

With this patch, sheriffbot will annonce the set of failing tests,
which might help folks triage the problem.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
16:50 Changeset [87106] by commit-queue@webkit.org

2011-05-23 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):

2011-05-23 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

  • public/WebURLRequest.h:
16:43 Changeset [87105] by rniwa@webkit.org

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Check in failing test expectations after r87096.
They are tracked by the bugs 61319, 61320, and 61322.

  • platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • platform/gtk/fast/events/selectstart-by-drag-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-drag-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
  • platform/win/fast/events/selectstart-by-drag-expected.txt: Added.
16:14 Changeset [87104] by rniwa@webkit.org

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Chromium test fix. On Chromium Windows, a space after a word is selected when you double click on the word.

  • fast/events/selectstart-by-double-triple-clicks.html:
15:33 Changeset [87103] by mdelaney@apple.com

2011-05-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216

  • wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):

2011-05-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216

No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.

  • platform/graphics/FloatRect.cpp: (WebCore::enclosingIntRect):
15:22 Changeset [87102] by jer.noble@apple.com

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220

No new tests, because DumpRenderTree does not currently "animate" the full-screen transition.

There are three issues animating video content to full screen which this patch is meant to
address:
1) The animation scales between the client sizes of the element before and after full-screen.
Because these sizes have different aspect ratios, the video appears "squished" for part of
the animation. Instead, we will animate between the content box sizes before and after full
screen which, in the case of video now and object-fit content in the future, will have the
same aspect ratio before and after full screen.
2) Now that we are animating the full-screen video element's content box, the black letterbox
bars appear above and below the video (depending on the video's aspect ratio) as soon as the
animation begins. This is extremely jarring, so set the background color to clear. The
full-screen renderer's background color will serve the same purpose (providing the letterbox
background) once the animation completes.
3) Now that the letterbox color is gone, the full screen controls can appear to float in thin
air beneath the video (again, depending on aspect ratio) during the animation, so to avoid
that effect and to make the animation consistent with the old webkitenterfullscreen()
animation, we will hide the controls during the animation by adding a new CSS pseudo class
-webkit-animating-full-screen-transition.

Added a new css pseudo-class: -webkit-animating-full-screen. During the transition animation, this
pseudo-class will be applied to the current full-screen element. Styles have been added to
fullscreenQuickTime.css to hide the video element's built-in controller during the full-screen
animation.

To accomplish this, the ivar tracking whether the full-screen animation is taking place has been moved
from the RenderFullScreen renderer, to the current full-screen Document. Because changing
isAnimatingFullScreen causes style changes, make sure to call recalcStyle on the full-screen element
after changing.

This extra transition caused assertions in HTMLFormControlElement::updateFromElementCallback. A
full-screen media control's renderer is disabled during the style recalculation when exiting full
screen. This assertion was exposed by the extra recalcStyle() issued during the exit transition, and
has been removed.

  • WebCore.exp.in:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Add support for new pseudo class -webkit-animate-full-screen-transition. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • css/fullscreen.css: (video:-webkit-full-screen): Set full screen video background color to clear.
  • css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-panel): Set a default opacity transition. (video:-webkit-animating-full-screen::-webkit-media-controls-panel): Set the opacity to 0 and

disable the transition.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitWillEnterFullScreenForElement): Call our new setAnimatingFullScreen function. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::isAnimatingFullScreen): Moved here from RenderFullScreen. (WebCore::Document::setAnimatingFullScreen): Ditto.
  • dom/Document.h:
  • html/HTMLFormControlElement.cpp: (WebCore::updateFromElementCallback): Use the Document's isAnimatingFullScreen function.
  • page/FrameView.cpp: (WebCore::isDocumentRunningFullScreenAnimation): Ditto.
  • rendering/RenderFullScreen.cpp:
  • rendering/RenderFullScreen.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
  • rendering/style/RenderStyleConstants.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220

Instead of scaling between the client sizes of the full-screen element before and after
entering full-screen, scale between their content boxes. The difference is that the client
sizes can have different aspect ratios, and thus the animation can end up "squishing" the
content at one end of the animation. When animating between the two content box sizes, their
aspect ratios (for the case of video) are equal, so the animation will appear to scale
smoothly between the two states without "squishing" the content.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Set the destination frame

to be the content box of the current full screen element.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

15:15 Changeset [87101] by eae@chromium.org

2011-05-23 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock hit testing to use IntPoint instead x,y pair
https://bugs.webkit.org/show_bug.cgi?id=61146

Covered by existing tests.

  • platform/graphics/IntPoint.h: (WebCore::toSize): Add toSize function for converting from point to size.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h: Change hit testing code in RenderBlock to use IntPoint.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
  • rendering/RenderListBox.h: Change overridden method to use IntPoint.
15:11 Changeset [87100] by simonjam@chromium.org

Merge 87098 - 2011-05-23 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):

BUG=83012
Review URL: http://codereview.chromium.org/7064010

14:50 Changeset [87099] by commit-queue@webkit.org

2011-05-23 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311

No new tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
14:29 Changeset [87098] by simonjam@chromium.org

2011-05-23 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
14:06 Changeset [87097] by tony@chromium.org

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] Link tcmalloc to DRT so we can use the heap checker
https://bugs.webkit.org/show_bug.cgi?id=61292

  • WebKit.gyp:
13:49 Changeset [87096] by rniwa@webkit.org

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489

Added tests to ensure selectstart is dispatches exactly once when selecting text by a mouse drag,
a mouse click, a double click, or a triple click. Also rebaselined a test that previously logged
extra selectstart dispatches.

  • fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • fast/events/selectstart-by-double-triple-clicks.html: Added.
  • fast/events/selectstart-by-drag.html:
  • fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
  • fast/events/selectstart-by-single-click-with-shift.html: Added.

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489

Fixed the bug by dispatching selectstart event immediately before modifying selection in
handleMousePressEventSingleClick and updateSelectionForMouseDrag.

Also replaced a boolean EventHandler::m_beganSelectingText by an enum-valued m_selectionInitiationState
to retain 3 states:

  1. HaveNotStartedSelection - Selection has not been set by a mouse drag or a mouse click
  2. PlacedCaret - A caret was placed by a mouse click, double click, or triple click, and is about to replace selection if a mouse drag never occurs.
  3. ExtendedSelection - A range selection was set by a mouse click, a double click, a triple click, or a mouse drag; otherwise a caret selection was set by a mouse drag.

State 1 corresponds to m_beganSelectingText being false and state 3 corresponds to m_beganSelectingText
being true. State 2 is used in updateSelectionForMouseDrag to avoid dispatching selectstart twice.

States 1 and 2 are set by updateSelectionForMouseDownDispatchingSelectStart and state 3 is set by
updateSelectionForMouseDrag.

Test: fast/events/selectstart-by-double-triple-clicks.html

fast/events/selectstart-by-drag.html
fast/events/selectstart-by-single-click-with-shift.html

  • page/EventHandler.cpp: Removed canMouseDragExtendSelect. (WebCore::EventHandler::EventHandler): Initializes m_selectionInitiationState. (WebCore::dispatchSelectStart): Returns true only if selectstart was successfully fired and default action was not prevented. (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Updates m_selectionInitiationState and modifies the selection if dispatchSelectStart returns true. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls updateSelectionForMouseDownDispatchingSelectStart. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::canMouseDownStartSelect): No longer dispatches startselect; also renamed from EventHandler::canMouseDownStartSelect. (WebCore::EventHandler::handleMousePressEvent): No longer calls canMouseDragExtendSelect. (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): Exit early if m_selectionInitiationState is HaveNotStartedSelection and dispatchSelectStart returns false. Since setSelectionIfPossible dispatches selectstart event before assigning PlacedCaret or ExtendedSelection to m_selectionInitiationState, there is no need to dispatch event for those two cases. (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/EventHandler.h: Removed canMouseDownStartSelect and canMouseDragExtendSelect from EventHandler and added setSelectionIfPossible.
13:47 Changeset [87095] by adamk@chromium.org

2011-05-23 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155

Covered by existing tests: fast/filesystem/file-from-file-entry.html

fast/filesystem/workers/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry-sync.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Updated to call createWithName().
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
  • fileapi/File.cpp: (WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup. (WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method. (WebCore::File::File):
  • fileapi/File.h: (WebCore::File::createWithName):
  • html/FileInputType.cpp: (WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
13:40 Changeset [87094] by enne@google.com

2011-05-23 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord):

2011-05-23 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164

Add additional tests for small max texture sizes.

  • tests/TilingDataTest.cpp: (WebCore::TEST):
13:21 Changeset [87093] by weinig@apple.com

2011-05-23 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
https://bugs.webkit.org/show_bug.cgi?id=61299

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess): Change validity check to only check for process validity, since terminating the process of a page that is closed or is closing is acceptable behavior.
12:59 Changeset [87092] by robert@webkit.org

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Unskip passing transitions tests
https://bugs.webkit.org/show_bug.cgi?id=61246

  • platform/qt/Skipped:
  • platform/qt/transitions/move-after-transition-expected.txt: Added.
  • platform/qt/transitions/transition-end-event-rendering-expected.txt: Added.
12:54 Changeset [87091] by kov@webkit.org

Merging http://trac.webkit.org/changeset/86364.

12:47 Changeset [87090] by abarth@webkit.org

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683

This test actually passes before this patch anyway. I don't think this
patch is actually observable in any meaningful way.

  • fast/images/busted-oval-does-not-render-expected.txt: Added.
  • fast/images/busted-oval-does-not-render.html: Added.
  • fast/images/resources/busted-oval.png: Added.

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683

This change is difficult to test. We're making this change to comply
with standards even if the change is difficult to observe. (This patch
also causes us to match Firefox.)

Test: fast/images/busted-oval-does-not-render.html

  • platform/image-decoders/ImageDecoder.cpp:
12:05 Changeset [87089] by commit-queue@webkit.org

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

No new tests, just changing gyp defines.

  • WebCore.gyp/WebCore.gyp:

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

  • WebKit.gyp:
  • WebKit.gypi:
11:52 Changeset [87088] by inferno@chromium.org

Merge 86725
BUG=81949
Review URL: http://codereview.chromium.org/7067001

11:51 Changeset [87087] by luiz@webkit.org

[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288

Reviewed by Andreas Kling.

Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.

The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::show):

11:47 Changeset [87086] by inferno@chromium.org

Merge 86665
BUG=82416
Review URL: http://codereview.chromium.org/7065004

11:44 Changeset [87085] by inferno@chromium.org

Merge 86976
BUG=83235
Review URL: http://codereview.chromium.org/7065003

11:41 Changeset [87084] by inferno@chromium.org

Merge 87083
BUG=83598
Review URL: http://codereview.chromium.org/6966014

11:27 Changeset [87083] by inferno@chromium.org

2011-05-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash when parsing css color for integer or
percentage values.
https://bugs.webkit.org/show_bug.cgi?id=61293

  • fast/css/parse-color-int-or-percent-crash-expected.txt: Added.
  • fast/css/parse-color-int-or-percent-crash.html: Added.

2011-05-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Terminate css color parsing on integers which are not followed
by a terminator.
https://bugs.webkit.org/show_bug.cgi?id=61293

Test: fast/css/parse-color-int-or-percent-crash.html

  • css/CSSParser.cpp: (WebCore::parseColorIntOrPercentage):
11:07 Changeset [87082] by rniwa@webkit.org

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914

Added a test to ensure WebKit does not clone hierarchy to preserve background color.

Also renamed editing/pasteboard/do-not-copy-body-color.html to do-no-clone-unnecessary-styles.html
and updated the description to match new behavior. While this test ensures WebKit does not copy
body's background color when it's not fully selected, this isn't a necessary requirement for us
not to duplicate borders so new expected result is correct.

  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Some spans became style spans.
  • editing/pasteboard/do-no-clone-unnecessary-styles-2-expected.txt: Added.
  • editing/pasteboard/do-no-clone-unnecessary-styles-2.html: Added.
  • editing/pasteboard/do-no-clone-unnecessary-styles-expected.txt: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color-expected.txt.
  • editing/pasteboard/do-no-clone-unnecessary-styles.html: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color.html.

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914

The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
Fixed the bug by not cloning background color and adding the effective background color to the wrapping
style span.

Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html

editing/pasteboard/do-no-clone-unnecessary-styles.html

  • editing/EditingStyle.cpp: (WebCore::cssValueToRGBA): Extracted from getRGBAFontColor. (WebCore::getRGBAFontColor): Moved. (WebCore::rgbaBackgroundColorInEffect): Added. (WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect. (WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position. Also remove the background color property when the effective background color is equal to the background color property (in terms of RGBA value) of the editing style. (WebCore::hasTransparentBackgroundColor): Moved from Editor class. (WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
  • editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
  • editing/Editor.h: Removed hasTransparentBackgroundColor.
  • editing/markup.cpp: (WebCore::isElementPresentational): Reverted r85090 and r84311. (WebCore::createMarkup): Include the background color in effect when computing the editing style.
11:07 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
11:06 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
11:04 QtWebKit edited by ademar.reis@openbossa.org
(diff)
11:00 QtWebKitRelease21 edited by ademar.reis@openbossa.org
(diff)
10:59 Changeset [87081] by rniwa@webkit.org

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content
https://bugs.webkit.org/show_bug.cgi?id=45889

Add a regression test now that the bug has been fixed by r87067.

  • fast/forms/delete-text-with-invisible-br-expected.txt: Added.
  • fast/forms/delete-text-with-invisible-br.html: Added.
10:59 QtWebKitFeatures21 edited by ademar.reis@openbossa.org
(diff)
10:56 Changeset [87080] by abarth@webkit.org

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87078.
http://trac.webkit.org/changeset/87078
https://bugs.webkit.org/show_bug.cgi?id=61294

Patch contains errors and seems likely to break a bunch of
bots (Requested by abarth on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:47 Changeset [87079] by rolandsteiner@chromium.org

2011-05-23 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983

Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.

No new tests. (refactoring)

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
10:28 Changeset [87078] by commit-queue@webkit.org

2011-05-23 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:15 Changeset [87077] by jberlin@webkit.org

[Windows] Initial Cookie Accept Policy not set on Deserialized Storage Session.
https://bugs.webkit.org/show_bug.cgi?id=61255

Reviewed by Darin Adler.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
Move the code to set the cookie policy before the early return that is taken when using the
default storage session from the UI Process.
Also, remove unnecessary #ifdefs (USE(CFURLSTORAGESESSIONS) is true if USE(CFNETWORK) is
true) and add a comment explaining the early return.

09:40 Changeset [87076] by commit-queue@webkit.org

2011-05-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>

Reviewed by Gavin Barraclough.

[SH4] AssemblerLabel does not name a type
https://bugs.webkit.org/show_bug.cgi?id=59927

SH4Assembler.h file shoold be included before AbstractMacroAssembler.h.

  • assembler/MacroAssemblerSH4.h:
09:05 Changeset [87075] by paroga@webkit.org

2011-05-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Move generation of shell_command from port to executive
https://bugs.webkit.org/show_bug.cgi?id=61251

After move it's possible to use the code in other places too.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/system/executive.py:
08:07 Changeset [87074] by yurys@chromium.org

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267

All methods of WorkerContextInspectorProxy are inlined in WorkerContextProxy and
the class itself is removed. Messages from worker inspector to page inspector
are sent by means of WorkerReportingProxy.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker): (WebCore::InspectorWorkerAgent::sendMessageToWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.h:
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
  • inspector/WorkerInspectorController.h:
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postMessageToPageInspector):
  • workers/WorkerContextInspectorProxy.h: Removed.
  • workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::PageInspector::~PageInspector): (WebCore::WorkerContextProxy::connectToInspector): (WebCore::WorkerContextProxy::disconnectFromInspector): (WebCore::WorkerContextProxy::sendMessageToInspector):
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267

WebWorker and WebWorkerClient are extended with methods for passing
DevTools messages between worker context inspector and page inspector.

  • public/WebWorker.h: (WebKit::WebWorker::attachDevTools): (WebKit::WebWorker::detachDevTools): (WebKit::WebWorker::dispatchDevToolsMessage):
  • public/WebWorkerClient.h: (WebKit::WebWorkerClient::dispatchDevToolsMessage):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspector): (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::connectToInspector): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::sendMessageToInspector): (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
  • src/WebWorkerImpl.h:
07:30 Changeset [87073] by commit-queue@webkit.org

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285

broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).

  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Removed.
  • http/tests/inspector/resource-har-headers.html: Removed.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285

broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).

07:20 Changeset [87072] by qi.2.zhang@nokia.com

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Unskip test case due to the implementation setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setJavaScriptCanAccessClipboard):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
06:41 Changeset [87071] by podivilov@chromium.org

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
  • inspector/debugger/resources/obfuscated.js: (withComments):
  • inspector/debugger/script-formatter.html:

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037

  • inspector/front-end/JavaScriptFormatter.js: (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype._addComment): (FormattedContentBuilder.prototype._addText): (FormattedContentBuilder.prototype._addMappingIfNeeded):
06:29 Changeset [87070] by caseq@chromium.org

2011-05-23 Mike West <mkwst@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Setting correct expectations for the following fields newly added to
the HAR implementation:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Added.
  • http/tests/inspector/resource-har-headers.html: Added.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-05-23 Mike West <mkwst@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Specifically, this patch adds:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression

Tests: http/tests/inspector/resource-har-conversion.html

http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html

06:26 Changeset [87069] by ossy@webkit.org

[Qt][WK] Skip a failing test.

  • platform/qt-wk2/Skipped:
05:05 Changeset [87068] by caseq@chromium.org

2011-05-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: keyboard shortcut panel is 1px too short
https://bugs.webkit.org/show_bug.cgi?id=61242

Fixed bottom margin of attached helpscreen so it's glued to status bar.

  • inspector/front-end/helpScreen.css: (body.attached .help-window-outer):
03:10 Changeset [87067] by tkent@chromium.org

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Reviewed by Dimitri Glazkov.

Source/WebCore:

By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:

<textarea> --(shadow-connection)-- <div> -- ...

After the change:

<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...

The goals of this change are

  • Change to the new shadow DOM model, and
  • Minimize the patch size.

We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.

Note: This is a re-landing for r87014 with a small fix of
Element::removeShadowRoot().

  • css/html.css:

(input::-webkit-inner-spin-button):

Add vertical-align in order to avoid the button affect the baseline.

(input::-webkit-outer-spin-button): ditto.
(input::-webkit-input-speech-button): ditto.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle): Calls styleForRenderer() so that a

subclass of Element can override it.

(WebCore::Element::remvoeShadowRoot):

Fix a wrong parameter for willRemoveDOMNode().

(WebCore::Element::isSpellCheckingEnabled):

Handle ShadowRoot, which is not an Element.

  • dom/Node.cpp: Add utility functions for editing code.

(WebCore::Node::nonBoundaryShadowTreeRootNode):
(WebCore::Node::nonShadowBoundaryParentNode):

  • dom/Node.h: Declare them.
  • dom/Position.cpp:
    • Add some assertions about ShadowRoot
    • Replace parentNode() with nonShadowBoundaryParentNode()

Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

  • dom/Position.h: ditto.

(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):

  • editing/CompositeEditCommand.cpp: ditto.

(WebCore::CompositeEditCommand::insertNodeAfter):
(WebCore::CompositeEditCommand::removeNode):

  • editing/Editor.cpp:

(WebCore::Editor::findString): ditto.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.

  • editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeNode): ditto.
(WebCore::ReplacementFragment::insertNodeBefore): ditto.

  • editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot.

(WebCore::VisibleSelection::isAll):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):

  • editing/VisibleSelection.h: ditto.
  • editing/htmlediting.cpp: Add assertions.

(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::create): Calls createShadowSubtree().
(WebCore::HTMLInputElement::createShadowSubtree):

Calls InputType::createShadowSubTree().

(WebCore::HTMLInputElement::innerTextElement):

Accessor of a shadow node. This is used by RenderTextControlSingleLine.

(WebCore::HTMLInputElement::innerBlockElement): ditto.
(WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::resultsButtonElement): ditto.
(WebCore::HTMLInputElement::cancelButtonElement): ditto.
(WebCore::HTMLInputElement::speechButtonElement): ditto.
(WebCore::HTMLInputElement::parseMappedAttribute):

Rebuild shadow trees because x-webkit-speech attribute affects it.

  • html/HTMLInputElement.h: Add declarations.
  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
(WebCore::HTMLTextAreaElement::createShadowSubtree): Added.

  • html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  • html/InputType.h: Add default implementations of accessors.

(WebCore::InputType::innerBlockElement):
(WebCore::InputType::innerTextElement):
(WebCore::InputType::innerSpinButtonElement):
(WebCore::InputType::outerSpinButtonElement):
(WebCore::InputType::resultsButtonElement):
(WebCore::InputType::cancelButtonElement):
(WebCore::InputType::speechButtonElement):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType): Initializes new data members.
(WebCore::SearchInputType::createShadowSubtree):

Moved from RenderTextControlSingleLine.

(WebCore::SearchInputType::destroyShadowSubtree): Clear element references.

  • html/SearchInputType.h: Add declarations.

(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::TextFieldInputType):

Initializes new data members.

(WebCore::TextFieldInputType::createShadowSubtree):

Moved from RenderTextControlSingleLine.

(WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.

  • html/TextFieldInputType.h: Add declarations.

(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::outerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):

Remove shadowParent parameter. It is unnecessary because we switch to
new shadow model.

(WebCore::TextControlInnerElement::create):

Change the parameter type to Document.

(WebCore::TextControlInnerElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerBlockStyle().

(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):

Remove shadowParent parameter.
Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
(WebCore::TextControlInnerTextElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerTextStyle().

(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):

Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SearchFieldResultsButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createResultButtonStyle().

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):

Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SearchFieldCancelButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createCancelButtonStyle().

(WebCore::SearchFieldCancelButtonElement::detach):

Update for the parent class change.

(WebCore::SpinButtonElement::SpinButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Add the inner flag
  • Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SpinButtonElement::createInner): Introduce a new factory

method to hide a bool parameter of the constructor.

(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().

(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Inherit HTMLDivElement, not TextControlInnerElement.
  • Do not register this as a speech input listener here.

(WebCore::InputFieldSpeechButtonElement::create):

Update for the parameter change.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Do not handle click event if listener registration is not done.

(WebCore::InputFieldSpeechButtonElement::attach):

Register this as a speech input listener.

(WebCore::InputFieldSpeechButtonElement::detach):

Update for the parent class change.

(WebCore::InputFieldSpeechButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().

  • html/shadow/TextControlInnerElements.h:

(WebCore::TextControlInnerTextElement::isMouseFocusable):

Add this because the class is not a subclass of TextControllInnerElement.

(WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
(WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
(WebCore::SpinButtonElement::isMouseFocusable): ditto.
(WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
(WebCore::RenderTextControl::styleDidChange):

innerTextElement can have no renderer.
Explicitly call setNeedsStyleRecals() for innerTextElement. It is
needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.

(WebCore::RenderTextControl::textBlockWidth): Member data -> function
(WebCore::RenderTextControl::updateFromElement): ditto.
(WebCore::RenderTextControl::setInnerTextValue): ditto.
(WebCore::RenderTextControl::hasVisibleTextArea): ditto.
(WebCore::RenderTextControl::isSelectableElement): ditto.
(WebCore::RenderTextControl::selection): ditto.
(WebCore::RenderTextControl::visiblePositionForIndex): ditto.
(WebCore::RenderTextControl::indexForVisiblePosition): ditto.
(WebCore::RenderTextControl::text): ditto.
(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
(WebCore::RenderTextControl::computeLogicalHeight): ditto.
(WebCore::RenderTextControl::hitInnerTextElement): ditto.
(WebCore::RenderTextControl::forwardEvent): ditto.
(WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.

  • rendering/RenderTextControl.h:
    • Make m_innerText virtual function.
    • Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::innerTextElement): Added.
(WebCore::RenderTextControlMultiLine::updateFromElement):

Remove unnecessary createSubtreeIfNeeded() call.

  • rendering/RenderTextControlMultiLine.h: Add a declaration.
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):

Remove unnecessary code.

(WebCore::RenderTextControlSingleLine::innerTextElement): Added.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
(WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
(WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
(WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
(WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
(WebCore::RenderTextControlSingleLine::layout): ditto.
(WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
(WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
(WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
(WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
(WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
(WebCore::RenderTextControlSingleLine::updateFromElement):

ditto, and remove unnecessary createSubtreeIfNeeded() call.

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

Data member -> function

(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
(WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.

  • rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.

LayoutTests:

Update test results because the shadow tree structure of <input> and
<textarea> is changed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:
02:41 Changeset [87066] by apavlov@chromium.org

Merge 86963 - 2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/7051034

02:07 Changeset [87065] by ossy@webkit.org

[Qt][WK2] Unreviewed trivial fix after r86990.

  • WebKit2.pro: Remove UIProcess/ChunkedUpdateDrawingAreaProxy.h.
02:01 Changeset [87064] by ossy@webkit.org

[Qt] Unreviewed, skip new failing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
01:48 Changeset [87063] by vitalyr@chromium.org

2011-05-19 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Explicitly mark objects with complex GC rules.
https://bugs.webkit.org/show_bug.cgi?id=61131

From the GC point view there are two kinds of objects: the ones
that may participate in object grouping (i.e. their lifetime
depends on other objects) and the ones that never participate in
grouping (independent). V8 added support for marking persistent
handles as independent so that the GC can process the objects they
hold faster. The motivating use case here is typed arrays.

This patch adds V8-specific inherited IDL attribute
V8DependentLifetime to types used in V8GCController, which is
exactly the set of types with object lifetimes depending on other
objects. The handles for the types that are not marked with the
new attribute can be marked as independent and GC-ed faster.

  • bindings/scripts/CodeGeneratorV8.pm: Added proccessing of the new attribute.

Updated test output:

  • bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
  • bindings/scripts/test/V8/V8TestObj.h:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

Added the new attribute:

  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/DOMImplementation.idl:
  • dom/Node.idl:
01:46 Changeset [87062] by commit-queue@webkit.org

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266

It made more tests assert (Requested by Ossy on #webkit).

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266

It made more tests assert (Requested by Ossy on #webkit).

  • css/html.css: (input::-webkit-inner-spin-button): (input::-webkit-outer-spin-button): (input::-webkit-input-speech-button):
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::Element::isSpellCheckingEnabled):
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::containerNode): (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::parentEditingBoundary): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree):
  • dom/Position.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::findString):
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll):
  • editing/FrameSelection.h: (WebCore::FrameSelection::shadowTreeRootNode):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): (WebCore::ReplacementFragment::insertNodeBefore):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::shadowTreeRootNode):
  • editing/VisibleSelection.h:
  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
  • html/HTMLTextAreaElement.h:
  • html/InputType.h:
  • html/SearchInputType.cpp:
  • html/SearchInputType.h: (WebCore::SearchInputType::SearchInputType):
  • html/TextFieldInputType.cpp:
  • html/TextFieldInputType.h: (WebCore::TextFieldInputType::TextFieldInputType):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::TextControlInnerElement::detach): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::detach): (WebCore::SpinButtonElement::setHovered): (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
  • html/shadow/TextControlInnerElements.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::hasVisibleTextArea): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition): (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::computeLogicalHeight): (WebCore::RenderTextControl::hitInnerTextElement): (WebCore::RenderTextControl::forwardEvent): (WebCore::RenderTextControl::computePreferredLogicalWidths): (WebCore::RenderTextControl::innerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::decorationWidthRight): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
  • rendering/RenderTextControlSingleLine.h:
01:27 Changeset [87061] by commit-queue@webkit.org

2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146

Move WTF_INCLUDE_DIRECTORIES to Source/JavaScriptCore/wtf/CMakeLists.txt.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:

2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146

Move wtf-files to Source/JavaScriptCore/wtf/CMakeLists.txt.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • wtf/CMakeLists.txt:
  • wtf/CMakeListsEfl.txt:
01:14 Changeset [87060] by commit-queue@webkit.org

2011-05-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Andreas Kling.

[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200

  • symbian/eabi/QtWebKitu.def:
01:07 Changeset [87059] by commit-queue@webkit.org

2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61202

LayoutTests/fast/canvas/webgl/gl-object-get-calls.html

getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
01:02 Changeset [87058] by carlosgc@webkit.org

2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r86990.

  • GNUmakefile.am: Remove UpdateChunk.cpp and UpdateChunk.h.
00:58 Changeset [87057] by carlosgc@webkit.org

2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Strict PassOwnPtr build fix.

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::newTextCodecGtk):
00:50 Changeset [87056] by mnaganov@chromium.org

2011-05-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Show "Please wait" message during initial
heap snapshot processing.
https://bugs.webkit.org/show_bug.cgi?id=61040

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView.setDataSource): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeView):
  • inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
00:11 Changeset [87055] by abarth@webkit.org

2011-05-23 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fixes.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderTrackStyle): (WebCore::RenderThemeGtk::adjustSliderThumbStyle): (WebCore::RenderThemeGtk::adjustProgressBarStyle):

05/22/11:

23:56 Changeset [87054] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustProgressBarStyle):
23:27 Changeset [87053] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Build fix. More public destructors needed to play nice with OwnPtr.

  • WebCoreSupport/InspectorClientGtk.cpp:
23:22 Changeset [87052] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Build fix. InspectorFrontendClient needs a public destructor so that
we can properly track ownership using OwnPtr.

  • WebCoreSupport/InspectorClientGtk.h:
23:11 Changeset [87051] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::InspectorFrontendClient):
23:07 Changeset [87050] by ukai@chromium.org

2011-05-22 Greg Simon <gregsimon@chromium.org>

Reviewed by Darin Fisher.

[chromium] Updating chromium DEPS

https://bugs.webkit.org/show_bug.cgi?id=61236

  • DEPS:
23:04 Changeset [87049] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::addUserStyleSheet):
22:54 Changeset [87048] by abarth@webkit.org

2011-05-22 Adam Barth <abarth@webkit.org>

Enable strict PassOwnPtr for everyone. I expect this patch will need
some followups to make the GTK and EFL bots green again.

  • wtf/PassOwnPtr.h:
22:48 BuildingQtOnOSX edited by dominicc@chromium.org
Added note about the dangers of MacPorts flex (diff)
18:00 WebKit Team edited by dpranke@chromium.org
(diff)
17:48 Changeset [87047] by ukai@chromium.org

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt: add fast/block/positioning/058.html
15:35 Changeset [87046] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).

15:29 Changeset [87045] by sullivan@apple.com

Rolled out <http://trac.webkit.org/changeset/87030>, which I accidentally checked into
the branch instead of trunk.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):

15:18 Changeset [87044] by yi.4.shen@nokia.com

2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin with html5 video player.

  • symbian/platformplugin/HTML5VideoPlugin.cpp: Added. (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler): (HTML5FullScreenVideoHandler::enterFullScreen): (HTML5FullScreenVideoHandler::exitFullScreen): (HTML5FullScreenVideoHandler::onPlayerError): (HTML5FullScreenVideoHandler::onPlayerStateChanged): (HTML5FullScreenVideoHandler::onMediaStatusChanged): (HTML5VideoPlugin::supportsExtension): (HTML5VideoPlugin::createExtension):
  • symbian/platformplugin/HTML5VideoPlugin.h: Added. (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (HTML5FullScreenVideoHandler::isFullScreen): (HTML5FullScreenVideoHandler::updateScreenRect):
  • symbian/platformplugin/HTML5VideoWidget.cpp: Added. (HTML5VideoWidget::HTML5VideoWidget): (HTML5VideoWidget::setDuration): (HTML5VideoWidget::mousePressEvent): (HTML5VideoWidget::onPlayerStopped): (HTML5VideoWidget::onPlayerError): (HTML5VideoWidget::onEndOfMedia): (HTML5VideoWidget::onBufferingMedia): (HTML5VideoWidget::onBufferedMedia): (HTML5VideoWidget::onControlClicked): (HTML5VideoWidget::onPositionChanged): (HTML5VideoWidget::onSliderMoved): (HTML5VideoWidget::onCloseClicked): (HTML5VideoWidget::showFullScreen): (HTML5VideoWidget::setVolume):
  • symbian/platformplugin/HTML5VideoWidget.h: Added.
  • symbian/platformplugin/OverlayWidget.cpp: Added. (OverlayWidget::OverlayWidget): (OverlayWidget::~OverlayWidget): (OverlayWidget::setDuration): (OverlayWidget::setPosition): (OverlayWidget::setVolume): (OverlayWidget::mousePressEvent): (OverlayWidget::onPlayerStopped): (OverlayWidget::onPlayerError): (OverlayWidget::onEndOfMedia): (OverlayWidget::onBufferingMedia): (OverlayWidget::onBufferedMedia): (OverlayWidget::timeToString): (OverlayWidget::applyStyleSheet): (OverlayWidget::onControlClicked): (OverlayWidget::onSliderMoved): (OverlayWidget::onSoundClicked): (OverlayWidget::onCloseClicked): (OverlayWidget::onVolumeSliderReleased): (OverlayWidget::onVolumeSliderMoved): (OverlayWidget::onTimerTimeout): (OverlayWidget::showFullScreen):
  • symbian/platformplugin/OverlayWidget.h: Added.
  • symbian/platformplugin/PlayerButton.cpp: Added. (PlayerButton::PlayerButton): (PlayerButton::event):
  • symbian/platformplugin/PlayerButton.h: Added.
  • symbian/platformplugin/PlayerLabel.cpp: Added. (PlayerLabel::PlayerLabel): (PlayerLabel::onPlayerError): (PlayerLabel::startBufferingAnimation): (PlayerLabel::stopBufferingAnimation): (PlayerLabel::onAnimationTimeout):
  • symbian/platformplugin/PlayerLabel.h: Added.
  • symbian/platformplugin/WebPlugin.cpp: (WebPlugin::createExtension):
  • symbian/platformplugin/images: Added.
  • symbian/platformplugin/images/button_cannotplay.png: Added.
  • symbian/platformplugin/images/button_close.png: Added.
  • symbian/platformplugin/images/button_pause.png: Added.
  • symbian/platformplugin/images/button_play.png: Added.
  • symbian/platformplugin/images/button_sound_off.png: Added.
  • symbian/platformplugin/images/button_sound_on.png: Added.
  • symbian/platformplugin/images/loading_buffering_1.png: Added.
  • symbian/platformplugin/images/loading_buffering_2.png: Added.
  • symbian/platformplugin/images/loading_buffering_3.png: Added.
  • symbian/platformplugin/images/loading_buffering_4.png: Added.
  • symbian/platformplugin/platformplugin.pro:
  • symbian/platformplugin/platformplugin.qrc: Added.
  • symbian/platformplugin/qss: Added.
  • symbian/platformplugin/qss/OverlayWidget.qss: Added.
12:33 Changeset [87043] by robert@webkit.org

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

  • platform/qt/Skipped: Unskip fast/encoding/mailto-always-utf-8.html
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Removed.

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT

https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant, so remove it.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate):
11:52 Changeset [87042] by lforschler@apple.com

Versioning.

11:51 Changeset [87041] by lforschler@apple.com

New tag.

11:08 Changeset [87040] by paroga@webkit.org

2011-05-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use double quotes for filename arguments
https://bugs.webkit.org/show_bug.cgi?id=61250

Windows does not support single quotes on the command line,
so replace them with double quotes.

  • Scripts/prepare-ChangeLog:
10:35 Changeset [87039] by lforschler@apple.com

Merge r86972.

10:33 Changeset [87038] by lforschler@apple.com

Merge r86967.

10:31 Changeset [87037] by lforschler@apple.com

Merge r86956.

10:28 Changeset [87036] by lforschler@apple.com

Merge r86924.

10:26 Changeset [87035] by lforschler@apple.com

Merge r86904.

10:23 Changeset [87034] by lforschler@apple.com

Merge r86895.

10:16 Changeset [87033] by lforschler@apple.com

Merge r86779.

09:56 Changeset [87032] by commit-queue@webkit.org

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Tests are in WebKit/qt/tests/hybridPixmap

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToImageDataMethod::name): (JSC::Bindings::QtPixmapToImageDataMethod::invoke): (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels): (JSC::Bindings::QtPixmapClass::methodsNamed): (JSC::Bindings::QtPixmapInstance::getPropertyNames): Add toImageData() to Qt Bridge, alternative to assignToHTMLImageElement().

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

  • docs/qtwebkit-bridge.qdoc:
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): Document Qt bridge toImageData() feature.
  • tests/hybridPixmap/test.html:
  • tests/hybridPixmap/widget.cpp: (Widget::Widget): (Widget::abcImage):
  • tests/hybridPixmap/widget.h: Add tests for Qt bridge toImageData() feature.
09:48 Changeset [87031] by jeffm@apple.com

2011-05-22 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249

  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().
09:27 Changeset [87030] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).

08:56 Changeset [87029] by dominicc@chromium.org

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

  • platform/mac/Skipped: Unskip shadow tests.

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot): Call detach if attached.
03:13 Changeset [87028] by krit@webkit.org

2011-05-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176

General clean-up.

Don't resolve style manually, instead ask the RenderObject for its style.

Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.

No new tests needed. No change of behavior.

  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::build):
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/svgattrs.in:

05/21/11:

23:58 Changeset [87027] by krit@webkit.org

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
if none of its childs caught the event. This is the case for all pointer-events other than 'none'.

Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml

svg/custom/pointer-events-on-svg-without-pointer.xhtml

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

Check that an embedded SVG element doesn't have a pointer, if pointer-events is set to 'none'.

  • svg/custom/pointer-events-on-svg-with-pointer-expected.txt: Added.
  • svg/custom/pointer-events-on-svg-with-pointer.xhtml: Added.
  • svg/custom/pointer-events-on-svg-without-pointer-expected.txt: Added.
  • svg/custom/pointer-events-on-svg-without-pointer.xhtml: Added.
21:44 Changeset [87026] by mitz@apple.com

<rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/block/positioning/start-ignoring-before.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
whether to merge the first trailing space with the line break.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
character, account for trailing positioned objects that occurred after the midpoint by calling
updateMidpointsForTrailingBoxes(), which adds midpoints for them.

LayoutTests:

  • fast/block/positioning/start-ignoring-before-expected.png: Added.
  • fast/block/positioning/start-ignoring-before-expected.txt: Added.
  • fast/block/positioning/start-ignoring-before.html: Added.
20:08 Changeset [87025] by jschuh@chromium.org

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations exception for:
fast/css/custom-font-xheight.html

  • platform/chromium/test_expectations.txt:
17:43 Changeset [87024] by jschuh@chromium.org

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed

Chromium expectations updates.

  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:52 Changeset [87023] by commit-queue@webkit.org

2011-05-21 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] WKStringCopyQString function is not exported
https://bugs.webkit.org/show_bug.cgi?id=59285

A few functions were declared twice but without the export macro.
On Symbian, the linking failed when trying to reference these functions.

  • UIProcess/API/qt/qgraphicswkview.h:
15:30 Changeset [87022] by jer.noble@apple.com

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be

synchronous, so make sure to check whether the current element is
in the DOM before dispatching.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the

exit functions (was calling the enter functions).

13:15 Changeset [87021] by jschuh@chromium.org

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium SVG expectations update.

  • platform/chromium/test_expectations.txt:
12:24 Changeset [87020] by commit-queue@webkit.org

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

  • fast/dom/HTMLLinkElement/prerender-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prerender.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

Test: fast/dom/HTMLLinkElement/prerender.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
  • platform/network/ResourceRequestBase.h:
08:30 Changeset [87019] by eae@chromium.org

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderLineBoxList::hitTest to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61156

Change the RenderLineBoxList hit testing to use IntPoint and clean up the rect calculation.

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
06:54 Changeset [87018] by eae@chromium.org

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change HitTestResult to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61230

Covered by existing tests.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult):
  • rendering/HitTestResult.h: (WebCore::HitTestResult::isRectBasedTest):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
05:41 Changeset [87017] by tkent@chromium.org

2011-05-21 Kent Tamura <tkent@chromium.org>

[GTK] [Chromium] Update test results for r87014.
https://bugs.webkit.org/show_bug.cgi?id=54179

  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
04:23 Changeset [87016] by tkent@chromium.org

2011-05-21 Kent Tamura <tkent@chromium.org>

[Qt] Update test results for r87014.

  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
04:04 Changeset [87015] by jochen@chromium.org

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ExtraData::~ExtraData): (WebCore::ResourceRequest::extraData): (WebCore::ResourceRequest::setExtraData):

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

  • WebKit.gypi:
  • public/WebURLRequest.h: (WebKit::WebURLRequest::ExtraData::~ExtraData):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::extraData): (WebKit::WebURLRequest::setExtraData):
  • tests/WebURLRequestTest.cpp: Added. (WebKit::TestExtraData::TestExtraData): (WebKit::TestExtraData::~TestExtraData): (WebKit::TEST):
03:47 Changeset [87014] by tkent@chromium.org

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Update test results because the shadow tree structure of <input> and
<textarea> is changed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:

<textarea> --(shadow-connection)-- <div> -- ...

After the change:

<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...

The goals of this change are

  • Change to the new shadow DOM model, and
  • Minimize the patch size.

We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.

  • css/html.css: (input::-webkit-inner-spin-button): Add vertical-align in order to avoid the button affect the baseline. (input::-webkit-outer-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
  • dom/Element.cpp: (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a subclass of Element can override it. (WebCore::Element::isSpellCheckingEnabled): Handle ShadowRoot, which is not an Element.
  • dom/Node.cpp: Add utility functions for editing code. (WebCore::Node::nonBoundaryShadowTreeRootNode): (WebCore::Node::nonShadowBoundaryParentNode):
  • dom/Node.h: Declare them.
  • dom/Position.cpp:
    • Add some assertions about ShadowRoot
    • Replace parentNode() with nonShadowBoundaryParentNode()

Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

  • dom/Position.h: ditto. (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • editing/CompositeEditCommand.cpp: ditto. (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::findString): ditto.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
  • editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): ditto. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
  • editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot. (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
  • editing/VisibleSelection.h: ditto.
  • editing/htmlediting.cpp: Add assertions. (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): Calls createShadowSubtree(). (WebCore::HTMLInputElement::createShadowSubtree): Calls InputType::createShadowSubTree(). (WebCore::HTMLInputElement::innerTextElement): Accessor of a shadow node. This is used by RenderTextControlSingleLine. (WebCore::HTMLInputElement::innerBlockElement): ditto. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto. (WebCore::HTMLInputElement::resultsButtonElement): ditto. (WebCore::HTMLInputElement::cancelButtonElement): ditto. (WebCore::HTMLInputElement::speechButtonElement): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Rebuild shadow trees because x-webkit-speech attribute affects it.
  • html/HTMLInputElement.h: Add declarations.
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree(). (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
  • html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  • html/InputType.h: Add default implementations of accessors. (WebCore::InputType::innerBlockElement): (WebCore::InputType::innerTextElement): (WebCore::InputType::innerSpinButtonElement): (WebCore::InputType::outerSpinButtonElement): (WebCore::InputType::resultsButtonElement): (WebCore::InputType::cancelButtonElement): (WebCore::InputType::speechButtonElement):
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): Initializes new data members. (WebCore::SearchInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
  • html/SearchInputType.h: Add declarations. (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initializes new data members. (WebCore::TextFieldInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
  • html/TextFieldInputType.h: Add declarations. (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::outerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Remove shadowParent parameter. It is unnecessary because we switch to new shadow model. (WebCore::TextControlInnerElement::create): Change the parameter type to Document. (WebCore::TextControlInnerElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerBlockStyle(). (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): Remove shadowParent parameter. Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter. (WebCore::TextControlInnerTextElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerTextStyle(). (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldResultsButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createResultButtonStyle(). (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldCancelButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createCancelButtonStyle(). (WebCore::SearchFieldCancelButtonElement::detach): Update for the parent class change. (WebCore::SpinButtonElement::SpinButtonElement):
    • Change the parameter type: shadowParent -> Document
    • Add the inner flag
    • Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SpinButtonElement::createInner): Introduce a new factory

method to hide a bool parameter of the constructor.

(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().

(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Inherit HTMLDivElement, not TextControlInnerElement.
  • Do not register this as a speech input listener here.

(WebCore::InputFieldSpeechButtonElement::create):

Update for the parameter change.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Do not handle click event if listener registration is not done.

(WebCore::InputFieldSpeechButtonElement::attach):

Register this as a speech input listener.

(WebCore::InputFieldSpeechButtonElement::detach):

Update for the parent class change.

(WebCore::InputFieldSpeechButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().

  • html/shadow/TextControlInnerElements.h: (WebCore::TextControlInnerTextElement::isMouseFocusable): Add this because the class is not a subclass of TextControllInnerElement. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto. (WebCore::SpinButtonElement::isMouseFocusable): ditto. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code. (WebCore::RenderTextControl::styleDidChange): innerTextElement can have no renderer. Explicitly call setNeedsStyleRecals() for innerTextElement. It is needed for LayoutTests/editing/selection/select-across-readonly-input-*.html. (WebCore::RenderTextControl::textBlockWidth): Member data -> function (WebCore::RenderTextControl::updateFromElement): ditto. (WebCore::RenderTextControl::setInnerTextValue): ditto. (WebCore::RenderTextControl::hasVisibleTextArea): ditto. (WebCore::RenderTextControl::isSelectableElement): ditto. (WebCore::RenderTextControl::selection): ditto. (WebCore::RenderTextControl::visiblePositionForIndex): ditto. (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::text): ditto. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::computeLogicalHeight): ditto. (WebCore::RenderTextControl::hitInnerTextElement): ditto. (WebCore::RenderTextControl::forwardEvent): ditto. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
  • rendering/RenderTextControl.h:
    • Make m_innerText virtual function.
    • Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::innerTextElement): Added. (WebCore::RenderTextControlMultiLine::updateFromElement): Remove unnecessary createSubtreeIfNeeded() call.
  • rendering/RenderTextControlMultiLine.h: Add a declaration.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): Remove unnecessary code. (WebCore::RenderTextControlSingleLine::innerTextElement): Added. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto. (WebCore::RenderTextControlSingleLine::layout): ditto. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto. (WebCore::RenderTextControlSingleLine::updateFromElement): ditto, and remove unnecessary createSubtreeIfNeeded() call. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Data member -> function (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
  • rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.
02:42 Changeset [87013] by crogers@google.com

2011-05-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

AudioBufferSourceNode noteOff() method must respect scheduling time
https://bugs.webkit.org/show_bug.cgi?id=61226

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::finish): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff):
  • webaudio/AudioBufferSourceNode.h:
01:47 Changeset [87012] by tkent@chromium.org

2011-05-21 Kent Tamura <tkent@chromium.org>

[Mac] Add expectation files for box-shadow-and-border-radius.html.

  • platform/mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Added.

05/20/11:

23:44 Changeset [87011] by krit@webkit.org

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Share more code in PathTraversalState
https://bugs.webkit.org/show_bug.cgi?id=61238

Share more code between SVGPathTraversalStateBuilder and Path in PathTraversalState.

No change in functionality, so no new tests.

  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction):
  • platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::processSegment):
  • platform/graphics/PathTraversalState.h:
  • svg/SVGPathTraversalStateBuilder.cpp: (WebCore::SVGPathTraversalStateBuilder::continueConsuming):
23:15 Changeset [87010] by zimmermann@webkit.org

2011-05-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG svgAttributeChanged/synchronizeProperty/parseMappedAttribute should be optimized
https://bugs.webkit.org/show_bug.cgi?id=61183

Example: rect.x.baseVal.value = 100;
What happens: SVGRectElement::svgAttributeChanged(const QualifiedName& attrName) is invoked with "SVGNames::rectAttr" as parameter.

void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
{

SVGStyledTransformableElement::svgAttributeChanged(attrName);
Handle my own attribute changes...

}

Currently we always traverse the base class hierarchy, when invoking svgAttributeChanged. Every svgAttributeChanged call from a class
like SVGRectElement has to reach the base class SVGStyledElement::svgAttributeChanged, as it handles invalidation of the instances of
an element. Say that a <rect> is referenced by a <use> and we change the 'x' attribute of the <rect>, then SVGStyledElement::svgAttributeChanged,
calls SVGElementInstance::invalidateAllInstancesOfElement(this), so that the <use> can rebuild its shadow tree...
That's the only reason all svgAttributeChanged implementations call the base class immediately, so SVGStyledElement is always reached.

Switch to a more efficient pattern, by providing a "bool isSupportedAttribute(const QualifiedName&);" function for all SVG*Elements.
It contains all attributes the particular SVG*Element class handles (but not its parent classes attributes). For example SVGRectElement
contains x/y/width/height/rx/ry attributes, and the ones from SVGTests/SVGLangSpace/SVGExternalResourcesRequired (xml:space/lang, etc.),
but not eg. transform as that's handled by the parent class SVGStyledTransformableElement.

void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
{

if (!isSupportedAttribute.contains(attrName)) {

SVGStyledTransformableElement::svgAttributeChanged(attrName);
return;

}

When we get here, we know for sure it's one of our attributes that has changed.
Note for eg. SVGNames::transformAttr, the call from SVGRectElement::svgAttributeChanged, would be immediately forwarded to the base class, which handles transformAttr changes)

if (attrName == SVGNames::xAttr) { do_work(); return; }
if (attrName == SVGNames::yAttr) { do_work(); return; }
...
Assure that we handled all properties we claim support for in "isSupportedAttribute()".
ASSERT_NOT_REACHED();

}

Exactly the same pattern can be applied to synchronizeProperty and parseMappedAttribute to speed them up as well.

Add "SVGElementInstance::InvalidationGuard guard(this)" statements in all svgAttributeChanged implementations, that calls invalidateAllInstancesOfElement(this)
upon destruction, after we've reacted to the svg attribute change. This assures we never forget to call the invalidation method anywhere, and don't
need to rely on the base class svgAttributeChanged() call to do it.


It's a slight overal performance progression.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::isSupportedAttribute): (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::svgAttributeChanged): (WebCore::SVGAElement::synchronizeProperty):
  • svg/SVGAElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::isSupportedAttribute): (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::isSupportedAttribute): (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isSupportedAttribute): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::isSupportedAttribute): (WebCore::SVGCircleElement::parseMappedAttribute): (WebCore::SVGCircleElement::svgAttributeChanged): (WebCore::SVGCircleElement::synchronizeProperty):
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::isSupportedAttribute): (WebCore::SVGClipPathElement::parseMappedAttribute): (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::synchronizeProperty):
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::isSupportedAttribute): (WebCore::SVGCursorElement::parseMappedAttribute): (WebCore::SVGCursorElement::svgAttributeChanged): (WebCore::SVGCursorElement::synchronizeProperty):
  • svg/SVGCursorElement.h:
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::InvalidationGuard::InvalidationGuard): (WebCore::SVGElementInstance::InvalidationGuard::~InvalidationGuard):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::isSupportedAttribute): (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::synchronizeProperty):
  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp: (WebCore::SVGExternalResourcesRequired::addSupportedAttributes):
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::isSupportedAttribute): (WebCore::SVGFEBlendElement::parseMappedAttribute): (WebCore::SVGFEBlendElement::svgAttributeChanged): (WebCore::SVGFEBlendElement::synchronizeProperty):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::isSupportedAttribute): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::svgAttributeChanged): (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::isSupportedAttribute): (WebCore::SVGFEComponentTransferElement::parseMappedAttribute): (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::isSupportedAttribute): (WebCore::SVGFECompositeElement::parseMappedAttribute): (WebCore::SVGFECompositeElement::svgAttributeChanged): (WebCore::SVGFECompositeElement::synchronizeProperty):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute): (WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::isSupportedAttribute): (WebCore::SVGFEDropShadowElement::parseMappedAttribute): (WebCore::SVGFEDropShadowElement::svgAttributeChanged): (WebCore::SVGFEDropShadowElement::synchronizeProperty):
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute): (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::isSupportedAttribute): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::svgAttributeChanged): (WebCore::SVGFEImageElement::synchronizeProperty):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::isSupportedAttribute): (WebCore::SVGFELightElement::parseMappedAttribute): (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::synchronizeProperty):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::isSupportedAttribute): (WebCore::SVGFEMergeNodeElement::parseMappedAttribute): (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::isSupportedAttribute): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::svgAttributeChanged): (WebCore::SVGFEMorphologyElement::synchronizeProperty):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::isSupportedAttribute): (WebCore::SVGFEOffsetElement::parseMappedAttribute): (WebCore::SVGFEOffsetElement::svgAttributeChanged): (WebCore::SVGFEOffsetElement::synchronizeProperty):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::isSupportedAttribute): (WebCore::SVGFESpecularLightingElement::parseMappedAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::isSupportedAttribute): (WebCore::SVGFETileElement::parseMappedAttribute): (WebCore::SVGFETileElement::svgAttributeChanged): (WebCore::SVGFETileElement::synchronizeProperty):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::isSupportedAttribute): (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged): (WebCore::SVGFETurbulenceElement::synchronizeProperty):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::isSupportedAttribute): (WebCore::SVGFilterElement::parseMappedAttribute): (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::synchronizeProperty):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute): (WebCore::SVGFilterPrimitiveStandardAttributes::parseMappedAttribute): (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged): (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute): (WebCore::SVGFitToViewBox::synchronizeProperties): (WebCore::SVGFitToViewBox::addSupportedAttributes):
  • svg/SVGFitToViewBox.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::isSupportedAttribute): (WebCore::SVGForeignObjectElement::parseMappedAttribute): (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::synchronizeProperty):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::isSupportedAttribute): (WebCore::SVGGElement::parseMappedAttribute): (WebCore::SVGGElement::svgAttributeChanged): (WebCore::SVGGElement::synchronizeProperty):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::isSupportedAttribute): (WebCore::SVGGradientElement::parseMappedAttribute): (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::synchronizeProperty):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::isSupportedAttribute): (WebCore::SVGImageElement::parseMappedAttribute): (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::synchronizeProperty):
  • svg/SVGImageElement.h:
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::addSupportedAttributes):
  • svg/SVGLangSpace.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::isSupportedAttribute): (WebCore::SVGLineElement::parseMappedAttribute): (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::synchronizeProperty):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::isSupportedAttribute): (WebCore::SVGLinearGradientElement::parseMappedAttribute): (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::synchronizeProperty):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::isSupportedAttribute): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::synchronizeProperty):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::isSupportedAttribute): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::synchronizeProperty):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::isSupportedAttribute): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::synchronizeProperty):
  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::isSupportedAttribute): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::svgAttributeChanged): (WebCore::SVGPathElement::synchronizeProperty):
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::isSupportedAttribute): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::synchronizeProperty):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::isSupportedAttribute): (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::isSupportedAttribute): (WebCore::SVGRadialGradientElement::parseMappedAttribute): (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::synchronizeProperty):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::isSupportedAttribute): (WebCore::SVGRectElement::parseMappedAttribute): (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::synchronizeProperty):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::synchronizeProperty):
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::isSupportedAttribute): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::svgAttributeChanged): (WebCore::SVGScriptElement::synchronizeProperty):
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::isSupportedAttribute): (WebCore::SVGStopElement::parseMappedAttribute): (WebCore::SVGStopElement::svgAttributeChanged): (WebCore::SVGStopElement::synchronizeProperty):
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::isSupportedAttribute): (WebCore::SVGStyleElement::parseMappedAttribute):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::synchronizeProperty):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isSupportedAttribute): (WebCore::SVGStyledTransformableElement::parseMappedAttribute): (WebCore::SVGStyledTransformableElement::svgAttributeChanged): (WebCore::SVGStyledTransformableElement::synchronizeProperty):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::isSupportedAttribute): (WebCore::SVGSymbolElement::parseMappedAttribute): (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::synchronizeProperty):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::isSupportedAttribute): (WebCore::SVGTRefElement::parseMappedAttribute): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::synchronizeProperty):
  • svg/SVGTRefElement.h:
  • svg/SVGTests.cpp: (WebCore::SVGTests::addSupportedAttributes):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isSupportedAttribute): (WebCore::SVGTextContentElement::parseMappedAttribute): (WebCore::SVGTextContentElement::synchronizeProperty): (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::isSupportedAttribute): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::synchronizeProperty):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::isSupportedAttribute): (WebCore::SVGTextPathElement::parseMappedAttribute): (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::synchronizeProperty):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::isSupportedAttribute): (WebCore::SVGTextPositioningElement::parseMappedAttribute): (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::SVGTextPositioningElement::synchronizeProperty):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTransformable.cpp:
  • svg/SVGTransformable.h:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::addSupportedAttributes):
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::isSupportedAttribute): (WebCore::SVGUseElement::parseMappedAttribute): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::synchronizeProperty):
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::isSupportedAttribute): (WebCore::SVGViewElement::parseMappedAttribute): (WebCore::SVGViewElement::synchronizeProperty):
  • svg/SVGViewElement.h:
  • svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::addSupportedAttributes):
  • svg/SVGZoomAndPan.h:
21:20 Changeset [87009] by simon.fraser@apple.com

2011-05-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Allow ShadowBlur to do tiling when the context is scaled
https://bugs.webkit.org/show_bug.cgi?id=61232

If the GraphicsContext is scaled or rotated by a multiple of 90deg, have ShadowBlur
use the tiling code path, to avoid blurring large areas on pages like cracked.com
when the context is scaled.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawRectShadow): Call preservesAxisAlignment() to decide when to not use tiling. (WebCore::ShadowBlur::drawInsetShadow): Ditto. (WebCore::ShadowBlur::drawLayerPieces): Round to device pixels when drawing tiles to avoid pixel cracks in scaled contexts.
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::preservesAxisAlignment): Return true if there is the matrix contains a transform that results in axis alignment (no rotation or skew, or rotations which are multiples of 90deg).
18:15 Changeset [87008] by ap@apple.com

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Kent Tamura.

Special characters can be inserted in text field having reached maxlength
https://bugs.webkit.org/show_bug.cgi?id=19479
<rdar://problem/7828739>

  • platform/mac/editing/input/maxlength-expected.txt: Added.
  • platform/mac/editing/input/maxlength.html: Added.
  • fast/forms/input-number-commit-valid-only-expected.txt:
  • fast/forms/script-tests/input-number-commit-valid-only.js: The user can make a number field empty by deleting its content, so there is no reason why execCommand shouldn't be able to make it empty.

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Kent Tamura.

Special characters can be inserted in text field having reached maxlength
https://bugs.webkit.org/show_bug.cgi?id=19479
<rdar://problem/7828739>

Test: platform/mac/editing/input/maxlength.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertTextIntoNode): (WebCore::CompositeEditCommand::replaceTextInNode): Avoid hitting an assertion below, now that we can get here with empty text.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): There is still work to do even if beforetextinput removed all text from the event. At the very least, we should delete the current selection.
18:07 Changeset [87007] by aestes@apple.com

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
https://bugs.webkit.org/show_bug.cgi?id=61229

Test that an object element with a non-empty classid, a valid MIME
type and no fallback content is allowed to load.

  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html:

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
https://bugs.webkit.org/show_bug.cgi?id=61229

Podcast Producer uses an object tag with a classid attribute to embed
QuickTime Player into a page. In r70748, we changed our behavior to
render the object's fallback content when a non-empty classid is
encountered, per HTML5. Since Podcast Producer videos have no fallback
content, this change in behavior causes the video to fail to load.

Since the object tag has a valid type attribute, we would be able to
load it if weren't for the non-empty classid. This patch changes our
policy to allow objects with non-empty classids if there is no fallback
content. We still continue to prefer fallback content if it exists,
however.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): Treat a non-empty classid as valid if the object has no fallback content.
17:52 Changeset [87006] by jchaffraix@webkit.org

2011-05-20 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by Simon Fraser.

If both border-radius and box-shadow applied, shadow is not fully visible
https://bugs.webkit.org/show_bug.cgi?id=59577

  • fast/css/box-shadow-and-border-radius.html: Added.
  • platform/qt/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/qt/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/win/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Added.

2011-05-20 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by Simon Fraser.

If both border-radius and box-shadow applied, shadow is not fully visible
https://bugs.webkit.org/show_bug.cgi?id=59577

The current implementation of RoundedIntRect::inflateWithRadii() inflates
its rect size and corner radii out of sync. This leads to validation failure in
Path::addRoundedRect() and results in ignoring radii in the path.
When this invalid path is used to clip out the rounded corner box before painting
the box shadow, the entire rectangle is clipped out without the corner radii.

This patch implements RoundedIntRect::inflateWithRadii() properly to inflate
rounded rect radii based on inflate ratios of rect size.

Test: fast/css/box-shadow-and-border-radius.html

  • platform/graphics/RoundedIntRect.cpp: (WebCore::RoundedIntRect::inflateWithRadii):
  • platform/graphics/RoundedIntRect.h:
17:48 Changeset [87005] by jer.noble@apple.com

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Mark Rowe.

Crash in WebFullScreenManager::didExitFullScreen when closing a window in Safari.
https://bugs.webkit.org/show_bug.cgi?id=61228

Do not attempt to exit full screen if we aren't in full screen to begin with, as the WebProcess
won't be expecting will/didExitFullScreen notifications.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]):
17:42 Changeset [87004] by kbr@google.com

2011-05-20 Kenneth Russell <kbr@google.com>

Unreviewed. Manually pulled missing layout test result from Mesa bots.

  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-actual.png: Added.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-actual.png: Added.
17:29 Changeset [87003] by jer.noble@apple.com

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=61224

Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
versions of same.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): (-[WebFullScreenController enterFullscreen:]): (-[WebFullScreenController exitFullscreen]): (-[WebFullscreenWindow setRendererLayer:]):
17:20 Changeset [87002] by commit-queue@webkit.org

2011-05-20 Leon Scroggins <scroggo@google.com>

Reviewed by Kenneth Russell.

gpu canvas alpha tests failing on the chromium canaries
https://bugs.webkit.org/show_bug.cgi?id=59768

Remove tests which are now passing from test_expectations.

  • platform/chromium/test_expectations.txt:
16:48 Changeset [87001] by michaeln@google.com

2011-05-20 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] Support the new webkit apis so the WebDatabase system participates
in the unified quota management system.
https://bugs.webkit.org/show_bug.cgi?id=60985

No change in functionality, no new tests.

  • platform/chromium/PlatformBridge.h:
  • storage/chromium/QuotaTracker.cpp: (WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin): (WebCore::QuotaTracker::updateDatabaseSize): (WebCore::QuotaTracker::updateSpaceAvailableToOrigin): (WebCore::QuotaTracker::resetSpaceAvailableToOrigin):
  • storage/chromium/QuotaTracker.h:

2011-05-20 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

Changes to allow the WebDatabase system to participate in Chrome's unified quota
management system. Now that changes outside of the database system affect the space
available to the database system, we need new ways of getting the limit to renderers.

Split WebDatabase::updateDatabaseSizeAndSpaceAvailable() into three methods.

  • WebDatabase::updateDatababaseSize()
  • WebDatabase::updateSpaceAvailable()
  • WebDatabase::resetSpaceAvailable() The WebDatabase methods are used to 'push' size and space available info into renderers. The space available can change independently of a database having changed size.

Also provide a means for the renderer to 'pull' the space available from the main
process if that value has not been pushed into it.

  • WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin()
  • WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin()

https://bugs.webkit.org/show_bug.cgi?id=60985

  • public/WebDatabase.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
  • src/WebDatabase.cpp: (WebKit::WebDatabase::updateDatabaseSize): (WebKit::WebDatabase::updateSpaceAvailable): (WebKit::WebDatabase::resetSpaceAvailable):
16:38 Changeset [87000] by bfulgham@webkit.org

Implement the ability to add C++ event listeners to html dom
elements and dom window.
https://bugs.webkit.org/show_bug.cgi?id=60269

Patch by Anthony Johnson <anthony.johnson@flexsim.com> on 2011-05-18
Reviewed by Brent Fulgham.

  • DOMCoreClasses.cpp: Add new DOMWindow class and implementations.

(DOMNode::QueryInterface): Report that the DOMNode implements

the IDomEventTarget interface.

(DOMNode::addEventListener): Add implementation of a COM-based

event listener.

(DOMNode::removeEventListener):
(DOMNode::dispatchEvent):
(DOMDocument::createInstance):
(DOMWindow::QueryInterface): New implementation.
(DOMWindow::document): New implementation.
(DOMWindow::getComputedStyle): Stub.
(DOMWindow::getMatchedCSSRules): Stub.
(DOMWindow::devicePixelRatio): Stub.
(DOMWindow::addEventListener): New implementation.
(DOMWindow::removeEventListener): New implementation.
(DOMWindow::dispatchEvent): New implementation.
(DOMWindow::DOMWindow): New implementation.
(DOMWindow::~DOMWindow): New implementation.
(DOMWindow::createInstance): New implementation.

  • DOMCoreClasses.h: Add new DOMWindow class and declarations.

(DOMWindow::AddRef): New declaration.
(DOMWindow::Release): New declaration.
(DOMWindow::throwException): New declaration.
(DOMWindow::callWebScriptMethod): New declaration.
(DOMWindow::evaluateWebScript): New declaration.
(DOMWindow::removeWebScriptKey): New declaration.
(DOMWindow::stringRepresentation): New declaration.
(DOMWindow::webScriptValueAtIndex): New declaration.
(DOMWindow::setWebScriptValueAtIndex): New declaration.
(DOMWindow::setException): New declaration.
(DOMWindow::window): New declaration.

  • DOMEventsClasses.cpp: Add new WebEventListener and implementation.

(DOMEventListener::handleEvent): New implementation.
(WebEventListener::WebEventListener): New implementation.
(WebEventListener::~WebEventListener): New implementation.
(WebEventListener::operator==): New implementation.
(WebEventListener::handleEvent): New implementation.
(WebEventListener::create): New implementation.

  • DOMEventsClasses.h: Add new WebEventListener class declaration.
  • Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the main Web Frame interface.
  • WebFrame.cpp: Add implementation of new DOMWindow creation method.

(WebFrame::DOMWindow):

  • WebFrame.h: Add DOMWindow declaration.
16:20 Changeset [86999] by oliver@apple.com

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Reduce size of inline cache path of get_by_id on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=61221

This reduces the code size of get_by_id by 20 bytes

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::ldrCompact): (JSC::ARMv7Assembler::repatchCompact): (JSC::ARMv7Assembler::setUInt7ForLoad):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
  • jit/JIT.h:
16:13 Changeset [86998] by ap@apple.com

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

Building instructions should not talk about Tiger
https://bugs.webkit.org/show_bug.cgi?id=61210

  • building/tools.html: Removed steps that are only necessary on Tiger, and changed required Xcode version to the latest Leopard one.
15:59 Changeset [86997] by jschuh@chromium.org

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations exception for:
svg/W3C-SVG-1.1-SE/struct-use-14-f.svg

  • platform/chromium/test_expectations.txt:
15:56 Changeset [86996] by lforschler@apple.com

Versioning.

15:51 Changeset [86995] by aestes@apple.com

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

No test possible via DRT. Add a manual test instead.

  • manual-tests/full-screen-keypress.html: Added.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • WebKit.xcodeproj/project.pbxproj: Export WebNSWindowExtras.h as a private header so that WebKit2 can include it.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a convenience method to NSWindow that makes the given NSResponder first responder only if it is a descendant of the given view.
  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView was a descendant of the browser window's first responder when entering full-screen mode, set the full-screen window's first responder to that same NSResponder. (-[WebFullScreenController exitFullscreen]): Do the reverse of what is done in windowDidEnterFullscreen:.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): If the WebView was a descendant of the browser window's first responder when entering full-screen mode, set the full-screen window's first responder to that same NSResponder. (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Do the reverse of what is done in finishedEnterFullScreenAnimation:.
15:47 Changeset [86994] by lforschler@apple.com

Versioning.

15:43 Changeset [86993] by lforschler@apple.com

New tag.

15:36 Changeset [86992] by jer.noble@apple.com

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Exit full screen mode if the WebProcess crashes.
https://bugs.webkit.org/show_bug.cgi?id=61151

  • platform/graphics/win/FullScreenController.h:
  • platform/graphics/win/FullScreenController.cpp: (FullScreenController::close): Added. Close the full-screen window without animation

if called.

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Exit full screen mode if the WebProcess crashes.
https://bugs.webkit.org/show_bug.cgi?id=61151

If the WebProcess crashes, exit full-screen mode to avoid getting stuck. Move the
WebFullScreenManagerProxy::invalidate() implementation into the platform-specific
files, and have them close their respective platform's full-screen window.

  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: (WebKit::WebFullScreenManagerProxy::invalidate): Added. Copied from main implementation.
  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Added.
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate): Added.
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: (WebKit::WebFullScreenManagerProxy::invalidate): Added.
15:34 Changeset [86991] by lforschler@apple.com

rename branch.

15:31 Changeset [86990] by andersca@apple.com

2011-05-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove the chunked update drawing area
https://bugs.webkit.org/show_bug.cgi?id=61216

The chunked update drawing area is no longer used in any port, so remove all traces of it.

Qt still uses UpdateChunks for the tiled drawing area so keep the Shared/qt/UpdateChunk.* classes for now.

  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • Shared/gtk/UpdateChunk.cpp: Removed.
  • Shared/gtk/UpdateChunk.h: Removed.
  • Shared/mac/UpdateChunk.cpp: Removed.
  • Shared/mac/UpdateChunk.h: Removed.
  • Shared/win/UpdateChunk.cpp: Removed.
  • Shared/win/UpdateChunk.h: Removed.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: Removed.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Removed.
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: Removed.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Removed.
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: Removed.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::paint): (WebKit::WebView::createDrawingAreaProxy): (WebKit::WebView::enterAcceleratedCompositingMode): (WebKit::WebView::exitAcceleratedCompositingMode):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: Removed.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Removed.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp: Removed.
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Removed.
  • WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: Removed.
  • win/WebKit2.vcproj:
15:29 Changeset [86989] by rniwa@webkit.org

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Rebaselines after r86983.

  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
15:26 Changeset [86988] by enrica@apple.com

Add delegate methods about focus and blur to all elements.
https://bugs.webkit.org/show_bug.cgi?id=61218

Reviewed by David Kilzer.

Source/WebCore:

We want to have delegates for these events for all the elements, not only the form elements.
The patch moves the call to the delegate in the Node class and changes the name
of the methods not to be form element specific.

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent): Added call to delegate with the new name.
(WebCore::Node::dispatchBlurEvent): Added call to delegate with the new name.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchBlurEvent): Removed code that calls the delegate since
it has been moved into Node.

  • html/HTMLFormControlElement.h: Removed dispatchFocusEvent, since we are using the default inplementation in Node.
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::elementDidFocus): Name changed.
(WebCore::EmptyChromeClient::elementDidBlur): Name changed.

  • page/ChromeClient.h:

(WebCore::ChromeClient::elementDidFocus): Name changed.
(WebCore::ChromeClient::elementDidBlur): Name changed.

Source/WebKit/mac:

We want to have delegates for these events for all the elements, not only the form elements.
The patch changes the name of the methods in a way that is not form element specific.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::elementDidFocus):
(WebChromeClient::elementDidBlur):

  • WebView/WebUIDelegatePrivate.h:
15:18 Changeset [86987] by jschuh@chromium.org

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
15:03 Changeset [86986] by scherkus@chromium.org

2011-05-20 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in baselines for media/media-document-audio-repaint.html for chromium-{mac,linux,win}.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
14:40 Changeset [86985] by mdelaney@apple.com

2011-05-20 Matthew Delaney <mdelaney@apple.com>

Reviewed by Steve Falkenburg.

Default min DOM Timer interval is not set soon enough for first page to pick it up in WK2
https://bugs.webkit.org/show_bug.cgi?id=61215

  • WebProcess/WebPage/WebPage.cpp: Simply moving the DOM min timer interval setting to before the first page creation.
14:28 Changeset [86984] by jschuh@chromium.org

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectaions update.

  • platform/chromium/test_expectations.txt:
14:23 Changeset [86983] by rniwa@webkit.org

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Wrap copied contents by one style span instead of two
https://bugs.webkit.org/show_bug.cgi?id=60988

Rebaselined tests due to the change in how WebKit preserves style in copy and paste.

  • editing/pasteboard/4930986-2-expected.txt: Whitespace change.
  • editing/pasteboard/5065605-expected.txt: No longer adds redundant inline style declaration.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Progression; Now we hit the list merging logic in ReplaceSelectionCommand: isStyleSpan(refNode.get()) && isListElement(refNode->firstChild()).
  • editing/pasteboard/paste-list-001-expected.txt: Ditto.
  • editing/pasteboard/paste-text-011-expected.txt: An extra style span was added.
  • editing/pasteboard/paste-text-012-expected.txt: Ditto.
  • editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: No longer adds redundant style span.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: No longer adds empty anonymous nodes.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Ditto.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Ditto.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Ditto.

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Wrap copied contents by one style span instead of two
https://bugs.webkit.org/show_bug.cgi?id=60988

Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by one wrapping style span. Instead
of wrapping the copied contents by user-applied style and document default style in serialization,
take the difference with the document default's style in paste code.

This will dramatically simplify our copy and paste code and pave a way to fix the bug 60914.

No new tests because copy & paste is tested by existing layout tests.

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::prepareToApplyAt): Remove the color property if RGBA values of color matches that of the computed style at the specified position.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by wrappingStyleSpan. When pasting as a quotation, compare style against the document's default style to avoid keeping the document default style (tested by editing/pasteboard/4930986-3.html).
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::createMarkup): Only use one style span to wrap the serialized contents.
14:12 Changeset [86982] by jschuh@chromium.org

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectaions update.

  • platform/chromium/test_expectations.txt:
14:00 Changeset [86981] by simon.fraser@apple.com

2011-05-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

numberOfActiveAnimations() can include animations from documents in the page cache
https://bugs.webkit.org/show_bug.cgi?id=53641

Some transition tests using layoutTestController.numberOfActiveAnimations() failed
in WebKit2 because numberOfActiveAnimations() could include those from other documents
in the page cache.

Fix by passing in the document for which we wish to count animations.

  • WebCore.exp.in:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::numberOfActiveAnimations): (WebCore::AnimationController::numberOfActiveAnimations):
  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
13:58 Changeset [86980] by abarth@webkit.org

2011-05-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Factor CORS request preparation out of DocumentThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=61209

DocumentThreadableLoader has two jobs:

1) Proxy loads between threads.
2) Run the CORS state machine.

This patch begins the work of separating those concerns, allowing CORS
to be used elsewhere in the loading pipeline. In particular, this
patch moves knowledge of how to prepare CORS requests out of
DocumentThreadableLoder.

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::updateRequestForAccessControl): (WebCore::createAccessControlPreflightRequest):
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
13:11 Changeset [86979] by krit@webkit.org

2011-05-20 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of Qt. One of the two tests doesn't even need a platform specific result anymore.

SVGPathSegList needs better getTotalLength, getSegmentAtLength path traversal code
https://bugs.webkit.org/show_bug.cgi?id=12047

  • platform/qt/svg/custom/path-getTotalLength-expected.txt: Removed.
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
12:53 Changeset [86978] by rwlbuis@webkit.org

2011-05-20 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60844

When an id changes on an in-document element, we need to check whether the id
is part of the pending elements. Since this is the same thing as happens in
insertedIntoDocument, split out the common code into buildPendingResourcesIfNeeded.

Test: svg/W3C-SVG-1.1-SE/struct-use-14-f.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
  • svg/SVGStyledElement.h:

2011-05-20 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60844

  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/struct-use-14-f.svg: Added.
12:43 Changeset [86977] by simon.fraser@apple.com

2011-05-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42550

Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Copy the code for pausing animations, FIXME comments and all. (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-05-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42550

Plumb through methods to pause a transition of a given property on an element.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFramePauseAnimationOnElementWithId): (WKBundleFramePauseTransitionOnElementWithId):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::pauseTransitionOnElementWithId):
  • WebProcess/WebPage/WebFrame.h:
12:36 Changeset [86976] by inferno@chromium.org

2011-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Tests that we do not crash when auto-focus triggers a attach.
https://bugs.webkit.org/show_bug.cgi?id=32882

  • fast/forms/input-element-attach-crash-expected.txt: Added.
  • fast/forms/input-element-attach-crash.html: Added.

2011-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Make auto-focus a post attach callback in
HTMLFormControlElement::attach().
https://bugs.webkit.org/show_bug.cgi?id=32882

Original patch by Darin Adler. This one uses a part of it.


Test: fast/forms/input-element-attach-crash.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is already false by the time post-attach callbacks are done so that layout triggered inside those callbacks can work properly.
  • html/HTMLFormControlElement.cpp: (WebCore::shouldAutofocus): Helper function that expresses the rule for which form control elements should auto-focus. (WebCore::focusPostAttach): Called post-attach to focus an element if we discover it should be focused during attach. (WebCore::HTMLFormControlElement::attach): Refactored code for which elements need auto-focus into a separate function. Instead of focusing right away, use the focusPostAttach function to focus after attach is done. Also added calls to suspendPostAttachCallbacks and resumePostAttachCallbacks so post-attach callbacks happen late enough. Before, they could run inside the base attach function.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Added calls to suspendPostAttachCallbacks and resumePostAttachCallbacks so post-attach callbacks happen late enough
12:28 Changeset [86975] by alokp@chromium.org

2011-05-20 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Remove LayerRendererChromium::useShader
https://bugs.webkit.org/show_bug.cgi?id=61143

GPU compositor tests should be sufficient.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::drawDebugBorder):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::drawYUV): (WebCore::CCVideoLayerImpl::drawRGBA):
12:06 Changeset [86974] by commit-queue@webkit.org

2011-05-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Zombies should "live" forever
https://bugs.webkit.org/show_bug.cgi?id=61170

Reusing zombie cells could still hide garbage
collected cell related bugs.

  • JavaScriptCore.pro:
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::clearMarks):
  • heap/MarkedBlock.h:
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::isZombie):
  • runtime/JSZombie.h: (JSC::JSZombie::~JSZombie):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):
12:04 Changeset [86973] by krit@webkit.org

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVGPathSegList needs better getTotalLength, getSegmentAtLength path traversal code
https://bugs.webkit.org/show_bug.cgi?id=12047

Right now SVGPathElement::getTotalLength and SVGPathElement::getPointAtLength use toPathData()
to transform a SVGPathByteStream to a Path. This Path gets traversed to find the searched value.
With this patch both functions use the SVGPathByteStream directly together with the existing
traversing code in SVG. This avoids the intermediate transforming to a platform path and gives
platform independent results.
The traversal code in SVG needed to be extended to support all PathTraversalActions.

No new tests added. The existing tests cover the changes.

  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::getTotalLengthOfSVGPathByteStream): (WebCore::SVGPathParserFactory::getPointAtLengthOfSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathTraversalStateBuilder.cpp: (WebCore::SVGPathTraversalStateBuilder::continueConsuming): (WebCore::SVGPathTraversalStateBuilder::totalLength): (WebCore::SVGPathTraversalStateBuilder::currentPoint):
  • svg/SVGPathTraversalStateBuilder.h:
11:56 SVG TODO List - Short notes edited by rwlbuis@webkit.org
Bugs are fixed, removing (diff)
11:53 SVG TODO List - Short notes edited by rwlbuis@webkit.org
All bugs in this section are fixed (diff)
11:46 Changeset [86972] by beidson@apple.com

<rdar://problem/9472883> and https://bugs.webkit.org/show_bug.cgi?id=61203
Horrendous bug in callOnMainThreadAndWait

Reviewed by Sam Weinig.

  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread): Before signaling the background thread with the

syncFlag condition, reacquire the mutex first.

11:39 Changeset [86971] by kerz@chromium.org

Revert 86910 - 2011-05-19 James Robinson <jamesr@chromium.org>

This caused chromium beta builders to fail on all platforms.

https://bugs.webkit.org/show_bug.cgi?id=61159

Add a speculative null check to see if it reduces the crashrate.

http://code.google.com/p/chromium-os/issues/detail?id=15377

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7054014

11:32 WebCoreRendering edited by rwlbuis@webkit.org
Fix typo (diff)
11:30 Changeset [86970] by commit-queue@webkit.org

2011-05-20 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=58465

  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/create-objectstore-null-name.html: Added.

2011-05-20 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=58465

Test: storage/indexeddb/mozilla/create-objectstore-null-name.html

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore):
11:23 Changeset [86969] by alokp@chromium.org

2011-05-20 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
11:20 Changeset [86968] by oliver@apple.com

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Remove unnecessary double->int conversion at the end of op_div
https://bugs.webkit.org/show_bug.cgi?id=61198

We don't attempt this conversion on 64bit, removing it actually speeds
up sunspider and v8 slightly, and it reduces code size.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_div):
11:18 Changeset [86967] by weinig@apple.com

2011-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Media files cannot be saved in the Application Cache due to a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=61199

Instead of using a sandbox extension to give permission to the application cache directory,
initialize the sandbox with access to it like we do for other databases.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
10:45 Changeset [86966] by xji@chromium.org

2011-05-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

ctrl-arrow does not work on words separated by multiple spaces.
https://bugs.webkit.org/show_bug.cgi?id=57543.

Add the leftmost boundary of a box in RTL block or the rightmost boundary of a box in LTR
block as word break if its inlineBox is the current box and it is a word break.

  • editing/visible_units.cpp: (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Add the rightmost boundary of a box in LTR block or leftmost boundary of a box in RTL block as visually first word break. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality): (WebCore::leftWordBoundary): Fix bug change "box" to "adjacentBox". (WebCore::rightWordBoundary): Fix bug change "box" to "adjacentBox".

2011-05-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

ctrl-arrow does not work on words separated by multiple spaces.
https://bugs.webkit.org/show_bug.cgi?id=57543.

Add more test cases for mutiplespaces.

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:
10:20 Changeset [86965] by evan@chromium.org

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • glu/glu.gyp:
  • gyp/test/library/src/library.gyp:

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • WebCore.gyp/WebCore.gyp:

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • WebKit.gyp:
09:36 Changeset [86964] by scherkus@chromium.org

2011-05-20 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating media/event-attributes.html as passing for Chromium.

  • platform/chromium/test_expectations.txt:
09:25 Changeset [86963] by podivilov@chromium.org

2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
09:20 Changeset [86962] by tkent@chromium.org

[Windows] fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html failing since r86936
https://bugs.webkit.org/show_bug.cgi?id=61190

  • platform/win/Skipped: Skip it because the test uses <progress> and Windows doesn't have <progress> support.
09:20 Changeset [86961] by podivilov@chromium.org

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86958.
http://trac.webkit.org/changeset/86958
https://bugs.webkit.org/show_bug.cgi?id=61195

broke breakpoints persisting (Requested by podivilov on
#webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
09:19 Changeset [86960] by oliver@apple.com

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Interpreter uses wrong bytecode offset for determining exception handler
https://bugs.webkit.org/show_bug.cgi?id=61191

The bytecode offset given for the returnPC from the JIT is
actually the offset for the start of the instruction triggering
the call, whereas in the interpreter it is the actual return
VPC. This means if the next instruction following a call was
in an exception region we would incorrectly redirect to its
handler. Long term we want to completely redo how exceptions
are handled anyway so the simplest and lowest risk fix here is
to simply subtract one from the return vPC so that we have an
offset in the triggering instruction.

It turns out this is caught by a couple of tests already.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
09:15 Changeset [86959] by yurys@chromium.org

2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Background network events collection - add GUI to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=58652

Move reopenFrontend() to inspector-test.js
Add first test for background events collection.

  • http/tests/inspector/inspector-test.js: ():
  • http/tests/inspector/network-test.js: Added. (initialize_NetworkTest.InspectorTest.enableBackgroundEventCollection): (initialize_NetworkTest.InspectorTest.disableBackgroundEventCollection):
  • http/tests/inspector/network/network-clear-after-disabled-expected.txt: Added.
  • http/tests/inspector/network/network-clear-after-disabled.html: Added.
  • http/tests/inspector/network/network-close-load-open-expected.txt: Added.
  • http/tests/inspector/network/network-close-load-open.html: Added.
  • http/tests/inspector/network/network-open-load-reopen-expected.txt: Added.
  • http/tests/inspector/network/network-open-load-reopen.html: Added.
  • inspector/debugger/open-close-open-expected.txt:
  • inspector/debugger/open-close-open.html:
  • platform/qt/Skipped:

2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Background network events collection - add GUI to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=58652

Now in WebInspector Network panel avalaible new checkbox item in context menu:
"Background events collection". It allows to save all network events when inspector
frontend closed. Events that occur before collection enabling are not preserved after
frontend reopening. Property unique for each page. Disabled by default.

Tests: http/tests/inspector/network/network-clear-after-disabled.html

http/tests/inspector/network/network-close-load-open.html
http/tests/inspector/network/network-open-load-reopen.html

  • inspector/EventsCollector.cpp: (WebCore::EventsCollector::clear):
  • inspector/EventsCollector.h:
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: (WebCore::InspectorFrontendProxy::inspectorFrontendChannel):
  • inspector/InspectorFrontendProxy.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::isBackgroundEventsCollectionEnabled): (WebCore::InspectorResourceAgent::setBackgroundEventsCollectionEnabled): (WebCore::InspectorResourceAgent::initializeBackgroundCollection): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._toggleBackgroundEventsCollection):
09:11 Changeset [86958] by podivilov@chromium.org

2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
08:55 Changeset [86957] by xan@webkit.org

2011-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756

Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel
check of the available memory. This should give us an
overcommit-like behavior in most systems, which is what we want.

  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap.
08:50 Changeset [86956] by jer.noble@apple.com

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

Instead of repainting the full- and non-full-screen windows in WebCore, delegate that
responsibility to the FullScreenControllerClient. Because the repaint operation may
be asynchronous, add a new method for clients to use to indicate repainting has completed.

  • platform/graphics/win/FullScreenController.cpp: (FullScreenController::Private::Private): Added new ivars. (FullScreenController::enterFullScreen): Split into two functions (pre-and post repaint) (FullScreenController::enterFullScreenRepaintCompleted): Ditto. (FullScreenController::exitFullScreen): Ditto. (FullScreenController::exitFullScreenRepaintCompleted): Ditto. (FullScreenController::repaintCompleted): Call the appropriated repaint completed function.
  • platform/graphics/win/FullScreenController.h:
  • platform/graphics/win/FullScreenControllerClient.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

  • WebView.cpp: (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the

full screen controller.

  • WebView.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

When the fullScreenController asks us to repaint, make an async repaint request, and when the
callback is fired, notify the fullScreenController that repaint has completed.

  • UIProcess/win/WebView.cpp: (WebKit::fullScreenClientForceRepaintCompleted): Added. (WebKit::WebView::fullScreenClientForceRepaint): Added.
  • UIProcess/win/WebView.h:
08:18 Changeset [86955] by yurys@chromium.org

2011-05-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use RefPtr instead of OwnPtr to store InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=61188

  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
  • inspector/WorkerInspectorController.h:
08:04 Changeset [86954] by ossy@webkit.org

[Qt] Skip failing tests.

  • platform/qt-arm/Skipped:
07:29 Changeset [86953] by ossy@webkit.org

2011-05-20 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=60372

  • tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail. (tst_QWebElement::style):
07:27 Changeset [86952] by ossy@webkit.org

2011-05-20 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails. (tst_QDeclarativeWebView::basicProperties): (tst_QDeclarativeWebView::historyNav):
07:19 Changeset [86951] by ossy@webkit.org

[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
https://bugs.webkit.org/show_bug.cgi?id=61045

Reviewed by Benjamin Poulain.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.

07:03 Changeset [86950] by commit-queue@webkit.org

2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Network panel should only show pointer cursor over valid resources
https://bugs.webkit.org/show_bug.cgi?id=55240

Cursor style removed from filler area.

  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid tr:not(.filler) td.name-column):
06:57 Changeset [86949] by pvarga@webkit.org

2011-05-20 Peter Varga <pvarga@webkit.org>

Reviewed by Simon Hausmann.

[Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
https://bugs.webkit.org/show_bug.cgi?id=56649

Use the provided V8 and functionality of
http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
Based on the original patch of Andras Becsi <abecsi@webkit.org>.

No new tests needed.

  • CodeGenerators.pri: Add generating of DebuggerScriptSource.h
  • WebCore.pri: Fix the options for V8 build.
  • WebCore.pro: Ditto.
  • bindings/v8/NPV8Object.cpp: (WebCore::npObjectTypeInfo): Add missing initializer.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval): Temporarily disable unsupported feature on Qt.
  • bindings/v8/ScriptControllerQt.cpp: (WebCore::ScriptController::qtScriptEngine): use the QtScriptEngine constructor of qtscript-staging.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Add missing initializer.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.
  • loader/appcache/ApplicationCacheGroup.cpp: Add missing header.
  • loader/cache/CachedResourceRequest.cpp: Ditto.
  • page/PageSerializer.cpp: Ditto.
  • page/qt/FrameQt.cpp: Ditto.
  • storage/StorageEventDispatcher.cpp: Ditto.

2011-05-20 Peter Varga <pvarga@webkit.org>

Reviewed by Simon Hausmann.

[Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
https://bugs.webkit.org/show_bug.cgi?id=56649

Use the provided V8 and functionality of
http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
Based on the original patch of Andras Becsi <abecsi@webkit.org>.

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject): Fix QString deprecated warning.
  • QtWebKit.pro: Adding the V8 library should happen in the final build step.
  • WebCoreSupport/ChromeClientQt.cpp: Add missing head.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
06:49 Changeset [86948] by commit-queue@webkit.org

2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: console.log(XMLDocument) should be case preserving
https://bugs.webkit.org/show_bug.cgi?id=60765

Changes the XML document checking from base documents MIME type
to xmlVersion parameter.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
06:46 Changeset [86947] by mnaganov@chromium.org

2011-05-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM,
instead of building it on Inspector's side.
https://bugs.webkit.org/show_bug.cgi?id=61185

  • bindings/js/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  • bindings/js/ScriptProfile.h:
  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  • bindings/v8/ScriptProfile.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
06:32 Changeset [86946] by ossy@webkit.org

2011-05-20 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Benjamin Poulain.

[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
06:24 Changeset [86945] by aroben@apple.com

Don't try to process DownloadProxy messages twice (and robustify code that runs if we do)

Fixes <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
(preceded by assertion) in fastMalloc when downloading a file

Reviewed by Darin Adler.

Source/WebKit2:

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::alignedBufferIsLargeEnoughToContain): Added. This helper function checks that the
given buffer is large enough to hold |size| bytes (and correctly handles the case where
we're already at the end or beyond the end of the buffer).

(CoreIPC::ArgumentDecoder::alignBufferPosition):
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
Replaced old code that was vulnerable to underflow with the new helper function.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage): Added back an early return that was
mistakenly removed in r86812 so that we don't mistakenly pass DownloadProxy messages on to
a WebPageProxy after we've already handled them.

Tools:

Test that the WebKit2 UI process doesn't crash when starting a download

  • TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.

(TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
(TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
started, cancel the download, and return a bogus string.

(TestWebKitAPI::setContextDownloadClient):
(TestWebKitAPI::setPagePolicyClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
our policy client, and run until we know that the download was started. If we haven't
crashed, we win!

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

Added new files.

05:52 Changeset [86944] by aroben@apple.com

Mac build fix after r86936

  • WebCore.xcodeproj/project.pbxproj: Added preprocessor.pm like the

other .pm files.

05:44 Changeset [86943] by vitalyr@chromium.org

2011-05-20 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Updating chromium DEPS.

  • DEPS:
05:43 Changeset [86942] by ossy@webkit.org

[Qt][Mac] Skip one more plugins test after r86938.

  • platform/qt-mac/Skipped:
05:26 Changeset [86941] by tkent@chromium.org

2011-05-20 Kent Tamura <tkent@chromium.org>

Try to fix Windows CE build.
Touch html.css to kick UA style sheet generation.

  • css/html.css:
05:18 Changeset [86940] by tkent@chromium.org

2011-05-20 Kent Tamura <tkent@chromium.org>

Try to fix Windows CE build.

  • CMakeLists.txt: Add --preprocessor flag.
04:45 Changeset [86939] by robert@webkit.org

2011-05-20 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt-mac] Skip two plugins test

Unskipped in platform/qt/ so need to skip in qt-mac as the build
does not support plugins (?)

  • platform/qt-mac/Skipped: plugins/get-url-with-javascript-url.html

plugins/windowless_plugin_paint_test.html

04:35 Changeset [86938] by robert@webkit.org

2011-05-20 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] plugins/keyboard-events.html fails after r72717

https://bugs.webkit.org/show_bug.cgi?id=50050

keyboard-events.html now passes thanks to the buildbot
upgrades. It was blocked by a bug in Xvfb on xorg-server
1.4.2.

  • platform/qt/Skipped:
04:29 Changeset [86937] by ossy@webkit.org

[Qt] Unreviewed. Remove unnecessary Qt specific expected files.

  • platform/qt/editing/execCommand/5062376-expected.txt: Removed.
  • platform/qt/editing/execCommand/insert-list-with-id-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-before-link-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4840662-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5245519-expected.txt: Removed.
  • platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/page-zoom-expected.txt: Removed.
  • platform/qt/editing/undo/redo-style-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/qt/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
  • platform/qt/fast/dom/wrapper-classes-expected.txt: Removed.
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
  • platform/qt/fast/dynamic/float-at-line-break-expected.txt: Removed.
  • platform/qt/fast/dynamic/unicode-bidi-expected.txt: Removed.
  • platform/qt/fast/encoding/preload-encoding-expected.txt: Removed.
  • platform/qt/fast/lists/alpha-list-wrap-expected.txt: Removed.
  • platform/qt/fast/lists/decimal-leading-zero-expected.txt: Removed.
  • platform/qt/fast/lists/li-values-expected.txt: Removed.
  • platform/qt/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Removed.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed.
  • platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
  • platform/qt/fast/text/setData-dirty-lines-expected.txt: Removed.
  • platform/qt/fast/text/splitText-dirty-lines-expected.txt: Removed.
  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Removed.
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Removed.
  • platform/qt/plugins/document-open-expected.txt: Removed.
  • platform/qt/plugins/resize-from-plugin-expected.txt: Removed.
  • platform/qt/svg/custom/animation-currentColor-expected.txt: Removed.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
  • platform/qt/svg/custom/text-zoom-expected.txt: Removed.
  • platform/qt/svg/custom/transformedMaskFails-expected.txt: Removed.
03:47 Changeset [86936] by tkent@chromium.org

2011-05-20 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Apply feature flags to user-agent style sheets
https://bugs.webkit.org/show_bug.cgi?id=52612

A user-agent style sheet should not have style definitions for disabled
features because such definitions makes feature detection harder and
causes incorrect behavior (See Bug 52214).

We have handled such feature-dependent style definitions by providing
separated CSS files and selecting them in build files. Adding such style
definition was hard because we need to update each of build files. This
change simplifies the process to add such style definitions by applying
preprocessor to the CSS files.

Implementation:
make-css-file-arrays.pl invokes a preprocessor if it has --defines
option. Otherwise, it just remove lines beginning with #.
In this change, we pass --defines on Mac, Windows, Chromium, GTK, and
CMake platforms. Qt and Android have no behavior change.

  • CMakeLists.txt:
    • IDL handling depends on preprocessor.pm.
    • Pass --defines option to make-css-file-arrays.pl
    • Add WebCore/bindings/scripts to @INC for make-css-file-arrays.pl
  • CodeGenerators.pri: IDL handling depends on preprocessor.pm.
  • DerivedSources.make: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gyp/WebCore.gyp: ditto.
  • WebCore.gyp/scripts/action_useragentstylesheets.py: Change parameter order to support perl modules and options. Many code is taken from rule_bindings.py.
  • WebCore.vcproj/MigrateScripts: Handles preprocessor.pm.
  • bindings/scripts/IDLParser.pm: Move the preprocessor code to preprocessor.pm.
  • bindings/scripts/preprocessor.pm: Added. The code was moved from IDLParser.pm
  • css/html.css: Enclose some style definitions with #if-#endif.
  • css/make-css-file-arrays.pl:
    • Add --defines and --preprocessor options.
    • Invoke a preprocessor if --defines is specified.
03:16 Changeset [86935] by krit@webkit.org

2011-05-20 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

Remove unnecessary class Path inlcude from PathTraversalState.

  • platform/graphics/PathTraversalState.h:
02:56 Changeset [86934] by sergio@webkit.org

2011-05-20 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test results.

  • platform/gtk/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-nested-1-expected.png: Added.
  • platform/gtk/fast/html/details-nested-1-expected.txt: Added.
  • platform/gtk/fast/html/details-nested-2-expected.png: Added.
  • platform/gtk/fast/html/details-nested-2-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
  • platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
  • platform/gtk/svg/custom/small-rect-scale-expected.png: Added.
  • platform/gtk/svg/custom/small-rect-scale-expected.txt: Added.
02:33 Changeset [86933] by sergio@webkit.org

2011-05-20 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r86920.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
02:32 Changeset [86932] by podivilov@chromium.org

2011-05-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: ctrl+s should not switch source frame to read only mode.
https://bugs.webkit.org/show_bug.cgi?id=61125

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
01:53 Changeset [86931] by loki@webkit.org

2011-05-20 Piroska András <Piroska.Andras@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FEConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=61171

The FEConvolveMatrix filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-30% on dual-core machines.

Developed in cooperation with Gabor Loki.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::fastSetInteriorPixels): (WebCore::FEConvolveMatrix::setInteriorPixels): (WebCore::FEConvolveMatrix::setInteriorPixelsWorker): (WebCore::FEConvolveMatrix::apply):
  • platform/graphics/filters/FEConvolveMatrix.h:
01:48 Changeset [86930] by tkent@chromium.org

2011-05-20 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Fix style errors in DumpRenderTree/chromium/.
https://bugs.webkit.org/show_bug.cgi?id=61172

  • DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getAsCppVariant): (CppBoundClass::bindToJavascript):
  • DumpRenderTree/chromium/CppBoundClass.h: (CppBoundClass::GetterCallback::~GetterCallback): (CppBoundClass::CppBoundClass): (CppBoundClass::Callback::~Callback): (CppBoundClass::MemberCallback::MemberCallback): (CppBoundClass::MemberCallback::~MemberCallback): (CppBoundClass::MemberGetterCallback::MemberGetterCallback): (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h: (DRTDevToolsAgent::~DRTDevToolsAgent):
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendFrontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/EventSender.cpp: (SavedEvent::SavedEvent): (EventSender::EventSender): (EventSender::keyDown):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::Image):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::WorkQueue::reset): (WorkItemBackForward::WorkItemBackForward): (WorkItemLoadingScript::WorkItemLoadingScript): (WorkItemNonLoadingScript::WorkItemNonLoadingScript): (WorkItemLoad::WorkItemLoad): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::WorkItem::~WorkItem): (LayoutTestController::WorkQueue::WorkQueue):
  • DumpRenderTree/chromium/MockSpellCheck.cpp: (MockSpellCheck::MockSpellCheck): (MockSpellCheck::~MockSpellCheck):
  • DumpRenderTree/chromium/MockSpellCheck.h:
  • DumpRenderTree/chromium/NotificationPresenter.h: (NotificationPresenter::NotificationPresenter):
  • DumpRenderTree/chromium/Task.cpp: (WebTask::WebTask):
  • DumpRenderTree/chromium/Task.h: (TaskList::TaskList):
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::DRTPrinter): (TestShellPrinter::TestShellPrinter):
  • DumpRenderTree/chromium/TestNavigationController.cpp: (TestNavigationEntry::TestNavigationEntry): (TestNavigationEntry::~TestNavigationEntry): (TestNavigationController::TestNavigationController): (TestNavigationController::reload): (TestNavigationController::loadEntry): (TestNavigationController::didNavigateToEntry):
  • DumpRenderTree/chromium/TestNavigationController.h: (TestShellExtraData::TestShellExtraData):
  • DumpRenderTree/chromium/TestShell.cpp: (dumpHistoryItem):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
  • DumpRenderTree/chromium/TestShellWin.cpp: (TestShell::waitTestFinished):
  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::startWorkerContext): (TestWebWorker::terminateWorkerContext): (TestWebWorker::postMessageToWorkerContext): (TestWebWorker::clientDestroyed): (TestWebWorker::postMessageToWorkerObject): (TestWebWorker::postExceptionToWorkerObject): (TestWebWorker::postConsoleMessageToWorkerObject): (TestWebWorker::confirmMessageFromWorkerObject): (TestWebWorker::reportPendingActivity): (TestWebWorker::workerContextClosed): (TestWebWorker::~TestWebWorker):
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintButton): (WebThemeEngineDRTWin::paintMenuList): (WebThemeEngineDRTWin::paintTrackbar):
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.h: (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::navigate): (WebViewHost::updateSessionHistory): (WebViewHost::paintInvalidatedRegion):
  • DumpRenderTree/chromium/WebViewHost.h:
01:14 Changeset [86929] by commit-queue@webkit.org

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86920.
http://trac.webkit.org/changeset/86920
https://bugs.webkit.org/show_bug.cgi?id=61173

It cause compile error on some buildbot in chromium. e.g.
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
(Requested by ukai_ on #webkit).

  • css3/images/optimize-contrast-canvas-expected.png: Removed.
  • css3/images/optimize-contrast-canvas-expected.txt: Removed.
  • css3/images/optimize-contrast-canvas.html: Removed.
  • css3/images/optimize-contrast-image-expected.png: Removed.
  • css3/images/optimize-contrast-image-expected.txt: Removed.
  • css3/images/optimize-contrast-image.html: Removed.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86920.
http://trac.webkit.org/changeset/86920
https://bugs.webkit.org/show_bug.cgi?id=61173

It cause compile error on some buildbot in chromium. e.g.
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
(Requested by ukai_ on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Removed.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::initialImageRendering): (WebCore::SVGRenderStyle::setImageRendering): (WebCore::SVGRenderStyle::imageRendering): (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
01:01 Changeset [86928] by krit@webkit.org

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079

Limit the depth of repeatedly splitting a segment on length calculation to 20. The limitation
is necessary for very big segments that would be splitter into millions of parts otherwise.
The limitation just cause a less accurate approximation.
At the moment the limit is fixed to 20. This is comparable with splitting the segment into
~1 million parts as a worst case. We might want to be more flexible later.

Test: svg/custom/path-getTotalLength-on-big-segment-crash.svg

  • platform/graphics/PathTraversalState.cpp: (WebCore::midPoint): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
  • platform/graphics/PathTraversalState.h:

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079

Added a test to verify, that the browser does not crash on calculating the total length on big segments.
It makes no sense to add the result of getTotalLength(), since they differ a lot bewteen platforms.
This is caused by the platform graphic libraries. See comment #9 on the bug.

  • svg/custom/path-getTotalLength-on-big-segment-crash-expected.txt: Added.
  • svg/custom/path-getTotalLength-on-big-segment-crash.svg: Added.
00:56 Changeset [86927] by leo.yang@torchmobile.com.cn

2011-05-20 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

SVGRootInlineBox triggers calculateBoundaries twice in layout
https://bugs.webkit.org/show_bug.cgi?id=60979

SVGRootInlineBox was calculating boundaries for children twice
in computePerCharacterLayoutInformation(). The first time of
calculation was in layoutChildBoxes() which is called by
computePerCharacterLayoutInformation(), and the second time of
calculation was in layoutRootBox() following layoutChildBoxes().

This patch calculates rectangle of children in layoutChildBoxes()
and then uses the rectange in layoutRootBox() to reduce a pass
of calculating child boundaries.

No functionality change, no new tests.

  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutChildBoxes): (WebCore::SVGRootInlineBox::layoutRootBox):
  • rendering/svg/SVGRootInlineBox.h:

05/19/11:

23:37 Changeset [86926] by commit-queue@webkit.org

2011-05-19 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
https://bugs.webkit.org/show_bug.cgi?id=61163

Manual test input-number-localization.html.
Because we can't assume any number formats in various WebKit ports.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
  • manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.
23:25 Changeset [86925] by ukai@chromium.org

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt: add BUGWK61169
22:31 Changeset [86924] by jer.noble@apple.com

2011-05-19 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
https://bugs.webkit.org/show_bug.cgi?id=56957

Guard against the parameter of setAnimating() matching the ivar value it's
setting, thus avoiding tearing down the renderer's layer backing.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating):

2011-05-19 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Flashing when entering and exiting full screen mode
https://bugs.webkit.org/show_bug.cgi?id=56957

In the WKFullscreenWindowController, when exiting accelerated compositing mode,
force a repaint, and don't actually remove the animation layer until the repaint
completes. Also, move back to parenting the WebView in a layer-backed view, and
work around the SnowLeopard bug which causes a crash in those situations. We no
longer need to do a bunch of work in finishedEnterFullScreenAnimation, because
the animation layer is "hiding" all the drawing happening in the webView underneath.

In the WebFullScreenManagerMac, when asked to tear down the root layer, instead
remove all its children, and set its contents to a flattened image of the full
screen element and its children. This helps patch over the time where everything
is re-rendering and helps give the appearance of continuousness in the animation.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): (-[WKFullScreenWindowController beganExitFullScreenAnimation]): (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]): (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): (exitCompositedModeRepaintCompleted): (-[WKFullScreenWindowController _page]): (-[WKFullScreenWindowController _manager]): (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
22:27 Changeset [86923] by loki@webkit.org

Fix ARM build after r86919

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::nop):

21:10 Changeset [86922] by commit-queue@webkit.org

2011-05-19 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

Detect hangs in run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=48043

  • Scripts/run-api-tests: Added test timeouts
19:39 Changeset [86921] by commit-queue@webkit.org

2011-05-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Adam Barth.

Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

Refactoring only so no new tests.

This patch fails short of one instance of deprecatedParserAddChild which will
require a refactoring of <input> shadow DOM to be removed.

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode. (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear up m_leafTextNode too.

(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::exitText):
Those methods were updated to use m_leafTextNode instead of m_currentNode.

  • dom/XMLDocumentParser.h: Changed the currentNode logic to use ContainerNode. Also fixed the style of the forward declarations.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): Removed the calls to deprecatedParserAddChild, changed the code to use m_leafTextNode when it made sense and used ContainerNode instead of Node for m_currentNode.
19:01 Changeset [86920] by commit-queue@webkit.org

2011-05-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

  • css3/images/optimize-contrast-canvas-expected.checksum: Added.
  • css3/images/optimize-contrast-canvas-expected.png: Added.
  • css3/images/optimize-contrast-canvas-expected.txt: Added.
  • css3/images/optimize-contrast-canvas.html: Added.
  • css3/images/optimize-contrast-image-expected.checksum: Added.
  • css3/images/optimize-contrast-image-expected.png: Added.
  • css3/images/optimize-contrast-image-expected.txt: Added.
  • css3/images/optimize-contrast-image.html: Added.

2011-05-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by Simon Fraser.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

Tests: css3/images/optimize-contrast-canvas.html

css3/images/optimize-contrast-image.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Added.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
18:33 Changeset [86919] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Randomise code starting location a little
https://bugs.webkit.org/show_bug.cgi?id=61161

Add a nop() function to the Assemblers so that we
can randomise code offsets slightly at no real cost.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::nop):
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::nop):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::nop):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nop):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::nop):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::nop):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::nop):
  • assembler/X86Assembler.h: (JSC::X86Assembler::nop):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • runtime/WeakRandom.h: (JSC::WeakRandom::getUint32):
18:25 Changeset [86918] by lforschler@apple.com

Merge r86852.

18:18 Changeset [86917] by lforschler@apple.com

Merge r86851.

18:16 Changeset [86916] by lforschler@apple.com

Merge r86850.

18:13 Changeset [86915] by lforschler@apple.com

Merge r86827.

18:13 Changeset [86914] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
18:11 Changeset [86913] by lforschler@apple.com

Merge r86809.

18:04 Changeset [86912] by lforschler@apple.com

Merge r86785.

18:03 Changeset [86911] by jer.noble@apple.com

Unreviewed; added new test to gtk Skipped list.

  • platform/gtk/Skipped:
18:01 Changeset [86910] by jamesr@google.com

2011-05-19 James Robinson <jamesr@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=61159

Add a speculative null check to see if it reduces the crashrate.

http://code.google.com/p/chromium-os/issues/detail?id=15377

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
17:56 Changeset [86909] by lforschler@apple.com

Merge r86748.

17:20 Changeset [86908] by oliver@apple.com

Fix windows build.

17:12 Changeset [86907] by commit-queue@webkit.org

2011-05-19 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

run-api-tests should run one test per process
https://bugs.webkit.org/show_bug.cgi?id=61088

  • Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, return code, and parsing GTest output format.
16:46 Changeset [86906] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add guard pages to each end of the memory region used by the fixedvm allocator
https://bugs.webkit.org/show_bug.cgi?id=61150

Add mechanism to notify the OSAllocator that pages at either end of an
allocation should be considered guard pages. Update PageReservation,
PageAllocation, etc to handle this.

  • JavaScriptCore.exp:
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
  • wtf/OSAllocator.h:
  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::reserveAndCommit):
  • wtf/PageAllocation.h: (WTF::PageAllocation::PageAllocation):
  • wtf/PageAllocationAligned.h: (WTF::PageAllocationAligned::PageAllocationAligned):
  • wtf/PageBlock.h: (WTF::PageBlock::PageBlock):
  • wtf/PageReservation.h: (WTF::PageReservation::reserve): (WTF::PageReservation::reserveWithGuardPages):

Add a new function to make a reservation that will add guard
pages to the ends of an allocation.

(WTF::PageReservation::PageReservation):

16:43 Changeset [86905] by kbr@google.com

2011-05-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
https://bugs.webkit.org/show_bug.cgi?id=61091

  • compositing/webgl/webgl-no-alpha.html: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/mac/compositing/webgl/webgl-no-alpha-expected.txt: Added.

2011-05-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Disable blending in compositor for WebGL layers with alpha=false
https://bugs.webkit.org/show_bug.cgi?id=61091

Test: compositing/webgl/webgl-no-alpha.html

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::pushPropertiesTo):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl): (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: (WebCore::CCCanvasLayerImpl::setHasAlpha):
16:17 Changeset [86904] by jer.noble@apple.com

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

  • media/video-src-invalid-poster-expected.txt: Added.
  • media/video-src-invalid-poster.html: Added.

2011-05-18 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Poster is not shown in Safari for video element with no playable source elements.
https://bugs.webkit.org/show_bug.cgi?id=61109

Test: media/video-src-invalid-poster.html

In the case where no video sources are playable, update the display state and
renderer, allowing the poster image to display.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::waitForSourceChange):
15:53 Changeset [86903] by lforschler@apple.com

Merge r86820.

15:51 Changeset [86902] by lforschler@apple.com

Merge r86814.

15:46 Changeset [86901] by lforschler@apple.com

Merge r86806.

15:39 Changeset [86900] by lforschler@apple.com

Merge r86793.

15:29 Changeset [86899] by atwilson@chromium.org

2011-05-19 Andrew Wilson <atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying
https://bugs.webkit.org/show_bug.cgi?id=61130

  • fast/events/message-port-multi-expected.txt:
  • fast/events/resources/message-port-multi.js: Added test for "passing an array with an item at a really large index" to postMessage().

2011-05-19 Andrew Wilson <atwilson@chromium.org>

Reviewed by Darin Adler.

MessagePortArray cloning code needs to verify source before copying.
https://bugs.webkit.org/show_bug.cgi?id=61130

  • bindings/js/JSMessagePortCustom.cpp: (WebCore::fillMessagePortArray): Changed code to not pre-allocate the destination array.
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray): Changed code to not pre-allocate the destination array.
15:13 Changeset [86898] by andersca@apple.com

Address a review comment by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didUpdateHistoryTitle):

15:13 Changeset [86897] by lforschler@apple.com

Merge r86792.

15:10 Changeset [86896] by lforschler@apple.com

Merge r86783.

15:10 Changeset [86895] by andersca@apple.com

2011-05-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Hang UI appears when WebProcess isn't running
https://bugs.webkit.org/show_bug.cgi?id=61147
<rdar://problem/9413683>

This fixes two bugs:

  1. The HistoryClient related message handlers in WebContext could get invoked for pages that have been closed, and thus didn't have any subframes. Since we have a MESSAGE_CHECK that checks that the frame exists, we'd mark the currently dispatched message as invalid, which would end up calling Connection::Client::didReceiveInvalidMessage. Fix this by checking that the page exists first.
  1. In the call to WebProcessProxy::didReceiveInvalidMessage we'd first invalidate the CoreIPC connection to make sure that we won't get any further messages from this connection. We'd then go ahead and terminate the web process, but because we've already invalidated the CoreIPC connection we would never get the Connection::Client::didClose callback that would call WebPageProxy::processDidCrash. Fix this by explicitly calling WebProcessProxy::didClose. Also, add logging when we receive an invalid message
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveInvalidMessage):
15:08 Changeset [86894] by lforschler@apple.com

Merge r86781.

15:06 Changeset [86893] by bweinstein@apple.com

Crash when detaching Web Inspector when parent is in process of closing.
https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>

Reviewed by Adam Roben.

We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.

15:06 Changeset [86892] by inferno@chromium.org

Merge 86781
BUG=79075
Review URL: http://codereview.chromium.org/7048016

15:05 Changeset [86891] by lforschler@apple.com

Merge r86741.

15:00 Changeset [86890] by lforschler@apple.com

Versioning.

14:41 Changeset [86889] by lforschler@apple.com

rollout last change... merged the wrong changeset.

14:18 Changeset [86888] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
13:39 Changeset [86887] by robert@webkit.org

2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • platform/qt/Skipped:

2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt][GTK] plugins/get-url-with-javascript-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=60834
Fix unix test plugin for plugins/get-url-with-javascript-url.html

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_stream): (webkit_test_plugin_write_ready): (webkit_test_plugin_write):
13:36 Changeset [86886] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.


  • platform/chromium/test_expectations.txt:
13:26 Changeset [86885] by mrowe@apple.com

Move aside some old branches.

13:19 Changeset [86884] by lforschler@apple.com

Merge r86741.

13:18 Changeset [86883] by oliver@apple.com

2011-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Executables release their JIT code as soon as they become dead
https://bugs.webkit.org/show_bug.cgi?id=61134

Add an ability to clear an Executable's jit code without requiring
it to be destroyed, and then call that from a finalizer.

  • heap/Weak.h: (JSC::Weak::Weak): (JSC::Weak::leak):
  • jit/JITCode.h: (JSC::JITCode::clear):
  • runtime/Executable.cpp: (JSC::ExecutableFinalizer::finalize): (JSC::ExecutableBase::executableFinalizer):
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::clearExecutableCode):
13:18 Changeset [86882] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium gradient expectations update.

  • platform/chromium-linux-x86/fast/gradients: Added.
  • platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-mac-leopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
13:13 Changeset [86881] by lforschler@apple.com

Merge r86738.

13:11 Changeset [86880] by lforschler@apple.com

Merge r86737.

13:10 Changeset [86879] by dglazkov@chromium.org

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/harness/internals-object-expected.txt: Removed.
  • fast/harness/internals-object.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/Internals.cpp: Removed.
  • testing/Internals.h: Removed.
  • testing/Internals.idl: Removed.
  • testing/js/WebCoreTestSupport.cpp: Removed.
  • testing/js/WebCoreTestSupport.h: Removed.
  • testing/v8/WebCoreTestSupport.cpp: Removed.
  • testing/v8/WebCoreTestSupport.h: Removed.

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • WebKit.gyp:
  • public/WebTestingSupport.h: Removed.
  • src/WebTestingSupport.cpp: Removed.

2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86869, r86873, r86875, and r86877.
http://trac.webkit.org/changeset/86869
http://trac.webkit.org/changeset/86873
http://trac.webkit.org/changeset/86875
http://trac.webkit.org/changeset/86877
https://bugs.webkit.org/show_bug.cgi?id=61139

broke builds and debug DRT (Requested by rniwa on #webkit).

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
13:05 Changeset [86878] by lforschler@apple.com

Merge r86734.

13:01 Changeset [86877] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

One more fix after r86869.

  • WebCore.exp.in: Made ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.
12:55 Changeset [86876] by lforschler@apple.com

Merge r86727.

12:45 Changeset [86875] by andersca@apple.com

Add two more symbols needed by the window.internals library.

  • WebCore.exp.in:
12:44 Changeset [86874] by lforschler@apple.com

Merge r86725.

12:26 Changeset [86873] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

Fix Leopard build after r86869.

  • WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.
12:24 Changeset [86872] by jschuh@chromium.org

2011-05-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
12:05 Changeset [86871] by lforschler@apple.com

Versioning.

11:59 Changeset [86870] by robert@webkit.org

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
https://bugs.webkit.org/show_bug.cgi?id=60992

  • platform/qt/Skipped:

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html
https://bugs.webkit.org/show_bug.cgi?id=60992

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • plugins/qt/PluginViewQt.cpp: (WebCore::getPluginDisplay):

2011-05-19 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix plugins/windowless_plugin_paint_test.html

Call gdk_init_check before gdk_display_get_default().
If we don't do this, gdk_display_get_default() will hang
the next time it's called.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::getPluginDisplay):
11:54 Changeset [86869] by dglazkov@chromium.org

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/harness/internals-object-expected.txt: Added.
  • fast/harness/internals-object.html: Added.
  • platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

Test: fast/harness/internals-object.html

  • DerivedSources.make: Added support for generating from Internals.idl.
  • WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  • testing/Internals.cpp: Added.
  • testing/Internals.h: Added.
  • testing/Internals.idl: Added.
  • testing/js/WebCoreTestSupport.cpp: Added.
  • testing/js/WebCoreTestSupport.h: Added.
  • testing/v8/WebCoreTestSupport.cpp: Added.
  • testing/v8/WebCoreTestSupport.h: Added.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • WebKit.gyp: Added linking new webkit_test_support library.
  • public/WebTestingSupport.h: Added.
  • src/WebTestingSupport.cpp: Added.

2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
11:51 Changeset [86868] by rniwa@webkit.org

Merge 84265 - 2011-04-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=57061

The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
a significant performance regression.

Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
and prevents respondToNodeModification from clearing selection.

No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
isn't exposed to JavaScript.

  • dom/Range.cpp: (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of start and end nodes are same, we should never get an exception from compareBoundaryPoints. (WebCore::Range::setEnd): Ditto. (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints throws an exception. (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by compareBoundaryPoints. (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor. (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
  • dom/Range.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::respondToNodeModification):
  • editing/htmlediting.cpp: (WebCore::comparePositions): Calls compareBoundaryPoints.
  • editing/markup.cpp: (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document and neither are in a shadow DOM, it should never throw an exception.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception was thrown.

ISSUE=83197
TBR=rniwa@webkit.org

11:45 Changeset [86867] by inferno@chromium.org

Merge 86748
BUG=82516

11:43 Changeset [86866] by inferno@chromium.org

Merge 86748
BUG=82516
Review URL: http://codereview.chromium.org/7048008

11:43 Changeset [86865] by cdn@chromium.org

Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572
Review URL: http://codereview.chromium.org/7049017

11:40 Changeset [86864] by cdn@chromium.org

Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org>

Reviewed by David Hyatt.

Fix reparenting and destruction of counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=57929

Fixed several issues related to not met assertions.
See below in the per file description.

Test: fast/css/counters/element-removal-crash.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves.
  • rendering/RenderCounter.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters.

BUG=78572

11:40 Changeset [86863] by dglazkov@chromium.org

2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>

Accept XCode's decisions to keep modifying WebCore.xcodeproj.

  • WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.
11:39 Changeset [86862] by inferno@chromium.org

Merge 86448
BUG=82546
Review URL: http://codereview.chromium.org/7050016

11:39 Changeset [86861] by commit-queue@webkit.org

2011-05-19 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Darin Adler.

Fix GraphicsContext3DQt.cpp compile error
https://bugs.webkit.org/show_bug.cgi?id=61128

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): clear() m_internal OwnPtr.
11:38 Changeset [86860] by inferno@chromium.org

Merge 86448
BUG=82546

11:35 Changeset [86859] by inferno@chromium.org

Merge 86500
BUG=82633
Review URL: http://codereview.chromium.org/7033030

11:33 Changeset [86858] by inferno@chromium.org

Merge 86500
BUG=82633

11:31 Changeset [86857] by cdn@chromium.org

Merge 85977 - 2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189
Review URL: http://codereview.chromium.org/7051008

11:27 Changeset [86856] by cdn@chromium.org

Merge 85977 - 2011-05-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

[Chromium] Whitelist input events interpreted as user gestures
https://bugs.webkit.org/show_bug.cgi?id=60213

  • public/WebInputEvent.h: (WebKit::WebInputEvent::isUserGestureEventType):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

BUG=72189

11:14 Changeset [86855] by commit-queue@webkit.org

2011-05-19 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Resizing columns in the network panel is weird
https://bugs.webkit.org/show_bug.cgi?id=55238

Makes network panel column resizing more usable by adding "first only" and "last only"
resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
remains default. Network panels datagrid is set to use method "last".

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get resizeMethod): (WebInspector.DataGrid.prototype.set resizeMethod): (WebInspector.DataGrid.prototype._resizerDragging):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable):
10:46 Changeset [86854] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

JoinTextNodesCommand is never used
https://bugs.webkit.org/show_bug.cgi?id=61089

Deleted JoinTextNodesCommand because it's never used.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditingAllInOne.cpp:
  • editing/JoinTextNodesCommand.cpp: Removed.
  • editing/JoinTextNodesCommand.h: Removed.
10:27 Changeset [86853] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Make Mac Leopard bot happy after r81176.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
10:22 Changeset [86852] by rniwa@webkit.org

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=61012

Added a test to ensure WebKit does not crash when inserting a content immediately after
a styled element inside a Mail blockquote. Regrettably the expected result is incorrect,
but it matches the behavior of WebKit before r83322.

  • editing/pasteboard/5065605-expected.txt: Reintroduced redundant style spans.
  • editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • editing/pasteboard/paste-after-inline-style-element-expected.txt: Added.
  • editing/pasteboard/paste-after-inline-style-element.html: Added.

2011-05-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=61012

The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
being moved when the insertion position's container node is the node to split to. Fixed the crash
by not changing the insertion position in such a case.

Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
it's much better than crashing.

Test: editing/pasteboard/paste-after-inline-style-element.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
10:17 Changeset [86851] by cmarrin@apple.com

2011-05-18 Chris Marrin <cmarrin@apple.com>

Reviewed by Anders Carlsson.

Plug-ins at YouTube, cnn.com, nytimes vanish when their top/left is scrolled out of view when zoomed
https://bugs.webkit.org/show_bug.cgi?id=61101

Scale both bounding boxes sent to m_plugin->geometryDidChange(), not just the frameRect. This fools
the plugin into thinking it is drawing into an unscaled box with an unscaled view even when scaled.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::frame):Made this const so it can be used in clipRectInWindowCoordinates() (WebKit::PluginView::viewGeometryDidChange):Used IntRect::scale() rather than scaling by hand (WebKit::PluginView::clipRectInWindowCoordinates):Added scale of clipRect.
  • WebProcess/Plugins/PluginView.h:
10:15 Changeset [86850] by aroben@apple.com

Remove a redundant and broken data export

Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.
10:15 Changeset [86849] by lforschler@apple.com

New Branch.

09:51 Changeset [86848] by carlosgc@webkit.org

2011-05-19 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
https://bugs.webkit.org/show_bug.cgi?id=61113

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke): (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
09:33 Changeset [86847] by beidson@apple.com

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

09:28 Changeset [86846] by ossy@webkit.org

[Qt] Skip failing test after r86841.

  • platform/qt-arm/Skipped:
09:22 Changeset [86845] by darin@apple.com

Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

  • editing/SpellingCorrectionController.cpp:

(WebCore::markersHaveIdenticalDescription): Call description() function.

08:12 Changeset [86844] by ossy@webkit.org

[Qt] Skip failing tests after r86834.

  • platform/qt-arm/Skipped:
06:08 Changeset [86843] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip 2 failing tests on GTK.

  • platform/gtk/Skipped: Skip http/tests/appcache/interrupted-update.html and http/tests/navigation/post-307-response.html
05:44 Changeset [86842] by commit-queue@webkit.org

2011-05-19 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: switch to Scripts panel is too slow
https://bugs.webkit.org/show_bug.cgi?id=61030

  • It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
  • Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates): (WebInspector.TextEditorMainPanel.prototype.endDomUpdates): (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype._createRow):
05:39 Changeset [86841] by ossy@webkit.org

[Qt] Implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=60015

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-05-19
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::scalePageBy):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::scalePageBy):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped: Unskip fast/transforms/selection-bounds-in-transformed-view.html.
05:35 Changeset [86840] by ossy@webkit.org

[Qt] Skip failing tests after r86834.

  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
05:13 Changeset [86839] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Not reviewed: inspector protocol tests fixed.

  • inspector/InjectedScriptSource.js:
05:03 Changeset [86838] by commit-queue@webkit.org

2011-05-19 David Grogan <dgrogan@chromium.org>

Reviewed by David Levin.

Make EventQueue post a Task to the task queue for each asynchronous event
https://bugs.webkit.org/show_bug.cgi?id=60790

Currently EventQueue queues up events to be fired asynchronously and
fires each of them when a single DOMTimer goes off. In the words of
dimich, "Having 2 queues will sooner or later cause problems with
ordering of tasks, termination, suspension and other things that all
require some control on how queues operate."

No new tests; this is just a refactoring to avoid potential future
problems.

  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::EventDispatcherTask::create): (WebCore::EventQueue::EventDispatcherTask::dispatchEvent): (WebCore::EventQueue::EventDispatcherTask::performTask): (WebCore::EventQueue::EventDispatcherTask::cancel): (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask): (WebCore::EventQueue::removeEvent): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::enqueueOrDispatchScrollEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::cancelQueuedEvents):
  • dom/EventQueue.h:
04:47 Changeset [86837] by yurys@chromium.org

2011-05-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
https://bugs.webkit.org/show_bug.cgi?id=60800

  • inspector/console/console-eval-blocked-expected.txt: Added.
  • inspector/console/console-eval-blocked.html: Added.

2011-05-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

InjectedScriptSource.js - "Don't be eval()."
https://bugs.webkit.org/show_bug.cgi?id=60800

Thanks to Adam Barth for providing JSC implementation!

InjectedScriptHost.evaluate is used to perform script evaluations for
inspector needs. This method is not affected by CSP and should fix inspector
on pages with CSP restrictions.

Test: inspector/console/console-eval-blocked.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::evaluate):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
04:10 Changeset [86836] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: expose object class name as a part of RemoteObject mirror.
https://bugs.webkit.org/show_bug.cgi?id=61067

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
04:09 Changeset [86835] by pfeldman@chromium.org

2011-05-19 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make "this" a part of callFrame, not scope in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=61057

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
04:04 Changeset [86834] by commit-queue@webkit.org

2011-05-19 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Rebaseline editing/style tests that are working
https://bugs.webkit.org/show_bug.cgi?id=61075

Also based on digging of Zsolt Fehér.

  • platform/qt/Skipped:
  • platform/qt/editing/style/5046875-1-expected.png: Added.
  • platform/qt/editing/style/5046875-1-expected.txt:
  • platform/qt/editing/style/5046875-2-expected.png: Added.
  • platform/qt/editing/style/5046875-2-expected.txt:
  • platform/qt/editing/style/5065910-expected.png: Added.
  • platform/qt/editing/style/5065910-expected.txt:
  • platform/qt/editing/style/5084241-expected.png: Added.
  • platform/qt/editing/style/5084241-expected.txt:
  • platform/qt/editing/style/5279521-expected.png: Added.
  • platform/qt/editing/style/5279521-expected.txt:
  • platform/qt/editing/style/block-style-004-expected.png: Added.
  • platform/qt/editing/style/block-style-005-expected.png: Added.
  • platform/qt/editing/style/block-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-001-expected.txt:
  • platform/qt/editing/style/create-block-for-style-002-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-002-expected.txt:
  • platform/qt/editing/style/create-block-for-style-003-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-003-expected.txt:
  • platform/qt/editing/style/create-block-for-style-004-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-004-expected.txt:
  • platform/qt/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-005-expected.txt:
  • platform/qt/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-006-expected.txt:
  • platform/qt/editing/style/create-block-for-style-007-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-007-expected.txt:
  • platform/qt/editing/style/create-block-for-style-008-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-008-expected.txt:
  • platform/qt/editing/style/create-block-for-style-009-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-009-expected.txt:
  • platform/qt/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-010-expected.txt:
  • platform/qt/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-011-expected.txt:
  • platform/qt/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-012-expected.txt:
  • platform/qt/editing/style/create-block-for-style-013-expected.png: Added.
  • platform/qt/editing/style/create-block-for-style-013-expected.txt:
  • platform/qt/editing/style/font-family-with-space-expected.png: Added.
  • platform/qt/editing/style/font-family-with-space-expected.txt:
  • platform/qt/editing/style/fontsize-1-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Added.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-001-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-001-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-002-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-002-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-003-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-003-expected.txt:
  • platform/qt/editing/style/relative-font-size-change-004-expected.png: Added.
  • platform/qt/editing/style/relative-font-size-change-004-expected.txt:
  • platform/qt/editing/style/smoosh-styles-001-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-001-expected.txt:
  • platform/qt/editing/style/smoosh-styles-003-expected.png: Added.
  • platform/qt/editing/style/smoosh-styles-003-expected.txt:
  • platform/qt/editing/style/style-3690704-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.png: Added.
  • platform/qt/editing/style/style-3998892-fix-expected.txt:
  • platform/qt/editing/style/style-boundary-001-expected.png: Added.
  • platform/qt/editing/style/style-boundary-001-expected.txt:
  • platform/qt/editing/style/style-boundary-004-expected.png: Added.
  • platform/qt/editing/style/style-boundary-004-expected.txt:
  • platform/qt/editing/style/table-selection-expected.png: Added.
  • platform/qt/editing/style/table-selection-expected.txt:
03:23 Changeset [86833] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing GTK fullscreen test

https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped: Skip fullscreen/full-screen-keyboard-enabled.html
02:50 Changeset [86832] by tkent@chromium.org

2011-05-19 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
https://bugs.webkit.org/show_bug.cgi?id=60948

Update existing tests for the new behavior.

  • fast/forms/ValidityState-tooLong-input-expected.txt:
  • fast/forms/ValidityState-tooLong-textarea-expected.txt:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/ValidityState-tooLong-input.js:
  • fast/forms/script-tests/ValidityState-tooLong-textarea.js:

2011-05-19 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

tooLong validity should not be true for a value set by a script
https://bugs.webkit.org/show_bug.cgi?id=60948

The specification has been updated so that tooLong should be true only
for user-edit values.

Introduce m_wasModifiedByUser flag to HTMLInputElement and
HTMLTextAreaElemnt. It is set to true when a renderer updates the
value, and is cleared when the value is updated by others.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Initialize m_wasModifiedByUser. (WebCore::HTMLInputElement::tooLong): Skip the check if m_wasModifiedByUser is false. (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser. (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::setValue): If sendChange is true, m_wasModifiedByUser should be true because sendChange is set in a case of form auto-fill. We assume a value set by form auto-fill is a kind of user-edit. (WebCore::HTMLInputElement::setValueFromRenderer): m_wasModifiedByUser should be true for the update by a renderer.
  • html/HTMLInputElement.h: Declare m_wasModifiedByUser.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initialize m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::updateValue): m_wasModifiedByUser should be true for the update by a renderer. (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser. (WebCore::HTMLTextAreaElement::tooLong): Skip the check if m_wasModifiedByUser is false.
  • html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.
02:47 Changeset [86831] by yuzo@google.com

2011-05-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Leopard.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
02:45 Changeset [86830] by commit-queue@webkit.org

2011-05-19 David Barr <davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
https://bugs.webkit.org/show_bug.cgi?id=38788

  • fast/css/border-radius-non-negative-expected.txt: Added.
  • fast/css/border-radius-non-negative.html: Added.
  • platform/mac/fast/css/border-radius-non-negative-expected.png: Added.

2011-05-19 David Barr <davidbarr@chromium.org>

Reviewed by Simon Fraser.

CSS3: We fail 'border radius sum of radii' test
https://bugs.webkit.org/show_bug.cgi?id=38788

Ignore border-radius properties with negative values.

Test: fast/css/border-radius-non-negative.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderRadius):
02:33 Changeset [86829] by yutak@chromium.org

2011-05-19 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
https://bugs.webkit.org/show_bug.cgi?id=61034

Refactoring only. No new tests.

  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::resume): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task to hold these pending events.
02:22 Changeset [86828] by commit-queue@webkit.org

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Added a test which ensures the IME candidate position is located
at suitable position.

  • platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
  • platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
  • platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Always adjusts the range to window relative coordinates.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition which excludes editable selectionRoot from adjusting.

2011-05-19 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

[Chromium] IME candidate window appears wrong position in an iframe
https://bugs.webkit.org/show_bug.cgi?id=61023

Call the focused frame's firstRectForCharacterRange() instead of the
main frame so that DRT behaves as the same as Chromium.

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::firstRectForCharacterRange):
02:21 Changeset [86827] by eae@chromium.org

2011-05-19 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
https://bugs.webkit.org/show_bug.cgi?id=60986

  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt:
  • fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html:

2011-05-19 Emil A Eklund <eae@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
https://bugs.webkit.org/show_bug.cgi?id=60986

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setMultiple): Don't restore selection if the multiple attribute hasn't changed.
02:19 Changeset [86826] by commit-queue@webkit.org

2011-05-19 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Simon Fraser.

Gradients not horizontal using 270deg with odd div width
https://bugs.webkit.org/show_bug.cgi?id=60157

When the angle of the linear gradient is 270, the endpoint should
be computed in the same way as for 0, 90, 180 cases since tan(270)
is undefined.

  • fast/gradients/css3-linear-right-angle-gradients-expected.txt: Added.
  • fast/gradients/css3-linear-right-angle-gradients.html: Added.
  • platform/mac/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
01:55 Changeset [86825] by philn@webkit.org

2011-05-19 Philippe Normand <pnormand@igalia.com>

Unreviewed, follow-up fix of the messages python unittests after r86812.

[WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
https://bugs.webkit.org/show_bug.cgi?id=60872

  • Scripts/webkit2/messages_unittest.py:
01:16 Changeset [86824] by yuzo@google.com

2011-05-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Snow Leopard.

  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
00:28 Changeset [86823] by zimmermann@webkit.org

2011-05-19 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update mac pixel test baseline, had marginal differences in the filter results and the text selection rectangles since a while.
The baseline passes again on my 32bit and 64bit machine, using run-webkit-tests --tolerance 0.011 -p svg

  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-fonts-02-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.png:
  • platform/mac/svg/text/text-tref-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/text/text-ws-01-t-expected.png:
  • platform/mac/svg/text/text-ws-02-t-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
00:12 BuildingQtOnOSX edited by dominicc@chromium.org
Added note about installing the debug variant of the qt4-mac port, since … (diff)
Note: See TracTimeline for information about the timeline view.