Timeline



May 24, 2011:

11:42 PM Changeset in webkit [87276] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed typo fix after r87228.

  • WebCore.pro:
11:37 PM Changeset in webkit [87275] by timothy@apple.com
  • 3 edits in trunk/Source/WebKit2

Make the Web Inspector bring the right window to the front when docked.

rdar://problem/9464685
https://webkit.org/b/61420

Reviewed by Brian Weinstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformBringToFront): Ditto.

11:23 PM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt on minimal bot (diff)
11:03 PM Changeset in webkit [87274] by tkent@chromium.org
  • 33 edits
    3 adds
    3 deletes in trunk

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • configure.ac: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-color.html: Removed.
  • fast/forms/color/input-value-sanitization-color-expected.txt: Added.
  • fast/forms/color/input-value-sanitization-color.html: Added. Tests sanitization algorithm for input type=color.
  • fast/forms/input-type-change3-expected.txt:
  • fast/forms/input-widths-expected.txt:
  • fast/forms/input-widths.html: Removed type=color because it is no loger a text input type.
  • fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
  • fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
  • fast/forms/script-tests/input-type-change3.js:
  • platform/gtk/Skipped: Skip fast/forms/color.
  • platform/mac/Skipped: Skip fast/forms/color.
  • platform/qt/Skipped: Skip fast/forms/color.
  • platform/win/Skipped: Skip fast/forms/color.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

Test: fast/forms/color/input-value-sanitization-color.html

  • Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
  • GNUmakefile.am: Added COLOR_INPUT feature flag.
  • features.pri: Added COLOR_INPUT feature flag.
  • html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::isColorControl): Added. (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec. (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
  • html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
  • html/InputType.cpp: (WebCore::InputType::isColorControl): Added.
  • html/InputType.h:

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • features.gypi: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Scripts/build-webkit: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.
10:56 PM Changeset in webkit [87273] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip new failing test.

  • platform/qt-wk2/Skipped:
9:54 PM Changeset in webkit [87272] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
https://bugs.webkit.org/show_bug.cgi?id=61349
<rdar://problem/9476255>

  • WebProcess/com.apple.WebProcess.sb:
9:43 PM Changeset in webkit [87271] by sfalken@apple.com
  • 279 edits in branches/safari-534-branch/LayoutTests

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Rubber stamped by Maciej Stachowiak.

Update test results after http://trac.webkit.org/changeset/87211
which disabled several features.

9:38 PM Changeset in webkit [87270] by commit-queue@webkit.org
  • 3 edits
    2 adds
    16 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61402

Converts the two html files to dump-as-markup and adds doctype, html, and body tags.

  • editing/selection/4895428-1-expected.txt: Added.
  • editing/selection/4895428-1.html: Converted to dump-as-markup
  • editing/selection/4895428-4-expected.txt: Added.
  • editing/selection/4895428-4.html: Converted to dump-as-markup
  • platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
  • platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
  • platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
  • platform/gtk/editing/selection/4895428-1-expected.png: Removed.
  • platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
  • platform/gtk/editing/selection/4895428-4-expected.png: Removed.
  • platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
  • platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
  • platform/mac/editing/selection/4895428-1-expected.png: Removed.
  • platform/mac/editing/selection/4895428-1-expected.txt: Removed.
  • platform/mac/editing/selection/4895428-4-expected.png: Removed.
  • platform/mac/editing/selection/4895428-4-expected.txt: Removed.
9:38 PM Changeset in webkit [87269] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Reviewed by Eric Seidel.

Add export macros to WTFString.h.

https://bugs.webkit.org/show_bug.cgi?id=27551

9:35 PM Changeset in webkit [87268] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-24 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

https://bugs.webkit.org/show_bug.cgi?id=61379

  • platform/chromium/test_expectations.txt: Added expected failures from this change.

2011-05-24 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

https://bugs.webkit.org/show_bug.cgi?id=61379

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
9:26 PM Changeset in webkit [87267] by tkent@chromium.org
  • 4 edits
    1 add
    21 deletes in trunk/LayoutTests

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Convert fast/forms/input-type-change.html to a dumpAsText() test
https://bugs.webkit.org/show_bug.cgi?id=61029

Merge input-type-change2 to input-type-change.html, and convert it to
a dumpAsText() test.

  • fast/forms/input-type-change-expected.txt:
  • fast/forms/input-type-change.html:
  • fast/forms/input-type-change2.html: Removed.
  • platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/gtk/fast/forms/input-type-change-expected.png: Removed.
  • platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
  • platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
  • platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change-expected.txt:
  • platform/mac/fast/forms/input-type-change-expected.txt: Removed.
  • platform/mac/fast/forms/input-type-change2-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/qt-arm/Skipped: Remove input-type-change2.html.
  • platform/qt-mac/Skipped: ditto.
  • platform/qt/fast/forms/input-type-change-expected.txt: Removed.
  • platform/qt/fast/forms/input-type-change2-expected.txt: Removed.
9:20 PM Changeset in webkit [87266] by ukai@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix clang error.

error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::create):

9:17 PM Changeset in webkit [87265] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Hajime Morita.

<legend> element is dropped on the floor
https://bugs.webkit.org/show_bug.cgi?id=18691

  • html5lib/resources/webkit02.dat: Added a passing test for <legend> parsing.
9:14 PM Changeset in webkit [87264] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Tony Chang.

editing/deleting/5032066 should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61327

Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.

  • editing/deleting/5032066-expected.txt: Added.
  • editing/deleting/5032066.html:
  • platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
  • platform/gtk/editing/deleting/5032066-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
  • platform/mac/editing/deleting/5032066-expected.png: Removed.
  • platform/mac/editing/deleting/5032066-expected.txt: Removed.
  • platform/qt/editing/deleting/5032066-expected.png: Removed.
  • platform/qt/editing/deleting/5032066-expected.txt: Removed.
9:04 PM Changeset in webkit [87263] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
https://bugs.webkit.org/show_bug.cgi?id=61330

Converted to dump-as-markup and added a little html cleanup.

  • editing/deleting/5115601-expected.txt: Added.
  • editing/deleting/5115601.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
  • platform/gtk/editing/deleting/5115601-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
  • platform/mac/editing/deleting/5115601-expected.png: Removed.
  • platform/mac/editing/deleting/5115601-expected.txt: Removed.
  • platform/qt/editing/deleting/5115601-expected.png: Removed.
  • platform/qt/editing/deleting/5115601-expected.txt: Removed.
8:50 PM Changeset in webkit [87262] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61332

Used dump-as-markup to improve readability of results.
Also improved HTML and cleaned up descriptions.

  • editing/deleting/5206311-2-expected.txt: Added.
  • editing/deleting/5206311-2.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
  • platform/mac/editing/deleting/5206311-2-expected.png: Removed.
  • platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5206311-2-expected.png: Removed.
  • platform/qt/editing/deleting/5206311-2-expected.txt: Removed.
8:39 PM Changeset in webkit [87261] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
https://bugs.webkit.org/show_bug.cgi?id=61333

Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.

  • editing/deleting/delete-block-table-expected.txt: Added.
  • editing/deleting/delete-block-table.html: Converted to dump-as-markup.
  • platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.
8:39 PM Changeset in webkit [87260] by abarth@webkit.org
  • 10 edits in trunk/Source

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

All the callers of the API are wrong. They should call the more modern
static member function of ScriptController instead. I'll remove the
FrameLoader function in a future patch.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
8:28 PM Changeset in webkit [87259] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Justin Novosad <junov@chromium.org>

Reviewed by Stephen White.

[Chromium] cleanup test expectations for drawImage that are no longer
flaky
https://bugs.webkit.org/show_bug.cgi?id=61389

  • platform/chromium/test_expectations.txt:
8:03 PM Changeset in webkit [87258] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • platform/efl/WidgetEfl.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
8:00 PM Changeset in webkit [87257] by commit-queue@webkit.org
  • 20 edits
    2 adds in trunk

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

LayoutTest for migration between SQLite and LevelDB
in IndxededDB.

  • storage/indexeddb/migrate-basics-expected.txt: Added.
  • storage/indexeddb/migrate-basics.html: Added.

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

Test: storage/indexeddb/migrate-basics.html

  • storage/IDBBackingStore.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setEnableMigration): (WebCore::IDBFactoryBackendImpl::migrate):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h: (WebCore::IDBLevelDBBackingStore::backingStoreType):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h: (WebCore::IDBSQLiteBackingStore::backingStoreType):

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::setEnableMigration):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::setEnableMigration):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactory::setOverrideBackingStoreType): (WebKit::WebIDBFactory::setTemporaryDatabaseFolder): (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open): (WebKit::WebIDBFactoryImpl::setEnableMigration):
  • src/WebIDBFactoryImpl.h:

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
7:54 PM Changeset in webkit [87256] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Chromium expectations update. (mhtml)

  • platform/chromium/test_expectations.txt:
7:52 PM Changeset in webkit [87255] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

Explicitly use uint32_t when encoding / decoding a type that is a typedef of OSType,
as this is declared as different underlying types in 32- and 64-bit (unsigned long
vs unsigned int).

  • Shared/mac/KeychainAttribute.cpp:

(CoreIPC::encode):
(CoreIPC::decode):

7:35 PM Changeset in webkit [87254] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Leon Scroggins <scroggo@google.com>

Reviewed by Kenneth Russell.

Update expectations for tests drawing a canvas into another canvas (or itself), which have been fixed in gpu.
https://bugs.webkit.org/show_bug.cgi?id=61362

  • platform/chromium/test_expectations.txt:
7:22 PM Changeset in webkit [87253] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Enable coalesced wheel events
<rdar://problem/9444786>

Reviewed by Maciej Stachowiak.

  • UIProcess/WebPageProxy.cpp:

Flip the switch for coalescing wheel events rather than dropping them.

7:18 PM Changeset in webkit [87252] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

7:16 PM Changeset in webkit [87251] by Lucas Forschler
  • 1 copy in tags/Safari-534.39

New tag.

7:14 PM Changeset in webkit [87250] by Lucas Forschler
  • 9 edits
    8 deletes in branches/safari-534-branch/Source/WebKit2

Rollout 87221.

7:07 PM Changeset in webkit [87249] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Final attempt to fix a test; if this fails, I'm just going to skip it.

  • fast/events/selectstart-by-double-triple-clicks.html:
6:26 PM Changeset in webkit [87248] by leo.yang@torchmobile.com.cn
  • 4 edits
    2 adds in trunk

2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Ryosuke Niwa.

[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692

Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.

Test: editing/pasteboard/drag-drop-input-in-svg.svg

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):

2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Ryosuke Niwa.

[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692

Test case to verify dragging and dropping text between input fields
inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.

Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.

  • editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
  • editing/pasteboard/drag-drop-input-in-svg.svg: Added.
  • platform/qt/Skipped:
6:05 PM Changeset in webkit [87247] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Yet another attempt to make Chromium Windows test bots happy.

  • fast/events/selectstart-by-double-triple-clicks.html:
5:59 PM Changeset in webkit [87246] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r87187.

5:56 PM Changeset in webkit [87245] by Lucas Forschler
  • 9 edits
    2 copies in branches/safari-534-branch

Merge r87179 + fix.

5:48 PM Changeset in webkit [87244] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-24 Andy Estes <aestes@apple.com>

Reviewed by Geoffrey Garen.

REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
https://bugs.webkit.org/show_bug.cgi?id=61229

This site-specific hack maintains compatibility with Mac OS X Wiki Server,
which embeds QuickTime movies using an object tag containing QuickTime's
ActiveX classid. Treat this classid as valid only if OS X Server's unique
'generator' meta tag is present. Only apply this quirk if there is no
fallback content, which ensures the quirk will disable itself if Wiki
Server is updated to generate an alternate embed tag as fallback content.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return true if site-specific quirks are enabled, the object element has no fallback content, the classid attribute matches QuickTime's classid and the document has a 'generator' meta tag matching Mac OS X Web Services Server's unique generator string. (WebCore::HTMLObjectElement::hasValidClassId): Call shouldAllowQuickTimeClassIdQuirk()
  • html/HTMLObjectElement.h:
5:33 PM Changeset in webkit [87243] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Maybe fix the Mac build now?

5:29 PM Changeset in webkit [87242] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87170.

5:27 PM Changeset in webkit [87241] by Lucas Forschler
  • 9 edits
    8 copies in branches/safari-534-branch/Source/WebKit2

Merge r87221.

5:25 PM Changeset in webkit [87240] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87154.

5:24 PM Changeset in webkit [87239] by Nate Chapin
  • 29 edits in trunk/Source/WebCore

2011-05-24 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Change CachedResources to take a ResourceRequest instead of
a url in their constructors and provide a very minimal set of
cases for avoiding reusing a CachedResource. The ResourceRequest
part of this change requires pushing responsibility
for calling Document::completeURL() to the caller, instead of
CachedResourceLoader, since ResourceRequest ASSERTs if it
is constructed with an invalid url.

https://bugs.webkit.org/show_bug.cgi?id=61318

Refactor, no new tests.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::CachedFont):
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::checkShouldPaintBrokenImage):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::reuseRequest): (WebCore::CachedResource::allowReuseOfRequest): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::resourceRequest): (WebCore::CachedResource::url):
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::checkNotify):
  • loader/cache/CachedXSLStyleSheet.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
5:24 PM Changeset in webkit [87238] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-534-branch/Source/WebKit2

Merge r87153.

5:23 PM Changeset in webkit [87237] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Additional sandbox extension required for quarantine database
<rdar://problem/9397494>
https://bugs.webkit.org/show_bug.cgi?id=61405

  • WebProcess/com.apple.WebProcess.sb: Add read-data access for ~/Library/Preferences.
5:18 PM Changeset in webkit [87236] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87119.

5:18 PM Changeset in webkit [87235] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use Element::shadowPseudoId() for text field decoration elements
https://bugs.webkit.org/show_bug.cgi?id=61351

No new tests. Covered by existing tests.

  • css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
    • -webkit-inner-spin-button
    • -webkit-input-speech-button
    • -webkit-outer-spin-button
    • -webkit-search-cancel-button
    • -webkit-search-decoration
    • -webkit-search-results-button
    • -webkit-search-results-decoration

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h: ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Store shadowPseudoId() result in a local variable because SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
  • html/shadow/TextControlInnerElements.cpp: Override Element::shadowPseudoId() instead of Element::styleForRenderer(). (WebCore::SearchFieldResultsButtonElement::shadowPseudoId): (WebCore::SearchFieldCancelButtonElement::shadowPseudoId): (WebCore::SpinButtonElement::shadowPseudoId): (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
  • html/shadow/TextControlInnerElements.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
  • rendering/RenderTextControlSingleLine.h: ditto.
  • rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.
5:16 PM Changeset in webkit [87234] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r87109.

5:12 PM Changeset in webkit [87233] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Maybe fix the Mac build?

5:00 PM Changeset in webkit [87232] by Lucas Forschler
  • 16 edits in branches/safari-534-branch/Source

Merge r87102.

4:49 PM Changeset in webkit [87231] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-24 Dimitri Glazkov <Dimitri Glazkov>

Sorted WebCore.xcodeproj again.

  • WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
4:46 PM Changeset in webkit [87230] by ggaren@apple.com
  • 11 edits
    1 copy in trunk/Source/JavaScriptCore

2011-05-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split HeapRootVisitor into its own class
https://bugs.webkit.org/show_bug.cgi?id=61399

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/HandleHeap.cpp:
  • heap/HandleStack.cpp:
  • heap/Heap.cpp:
  • heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
  • heap/MarkStack.h:
  • runtime/ArgList.cpp:
  • runtime/SmallStrings.cpp:
4:46 PM Changeset in webkit [87229] by Stephanie Lewis
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

Reviewed by Geoff Garen.

No new tests because functionality has not changed.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::platformLazyInit):

4:43 PM Changeset in webkit [87228] by msaboff@apple.com
  • 13 edits
    3 adds in trunk/Source

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added call to enable memory pressure handling.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
  • WebView/WebViewInternal.h:

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added new class, MemoryPressureHandler, to platform to respond to low
system memory events. Added Mac specific implementation that reduces the
page cache, NSURL cache, WebCore cache by half their current usage
and then garbage collects. This can allow Safari to continue operating
in a low memory situation with minimal paging.
Split up prune operations in MemoryCache to allow for pruning to a
specific actual size to support this change.

No tests added as the functionality of WebKit wasn't changed.

  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::forcePruneLiveResources): (WebCore::MemoryCache::pruneLiveResourcesToTarget): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::forcePruneDeadResources): (WebCore::MemoryCache::pruneDeadResourcesToTarget):
  • loader/cache/MemoryCache.h: (WebCore::MemoryCache::forcePrune):
  • platform/MemoryPressureHandler.cpp: Added. (WebCore::memoryPressureHandler): (WebCore::MemoryPressureHandler::MemoryPressureHandler): (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
  • platform/MemoryPressureHandler.h: Added.
  • platform/mac/MemoryPressureHandler.mm: Added. (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added call to enable memory pressure handling for Mac case.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/WebProcess.h:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
4:19 PM Changeset in webkit [87227] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
https://bugs.webkit.org/show_bug.cgi?id=61398

shadowAncestorNode() and shadowTreeRootNode() should be const
though they can return 'this' pointer.

No new tests. This doesn't change any visible behavior.

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Make this const. (WebCore::Node::shadowTreeRootNode): ditto.
  • dom/Node.h: Update declarations.
  • html/shadow/TextControlInnerElements.h: (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>. (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.
4:13 PM Changeset in webkit [87226] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Source/JavaScriptCore/wtf/Platform.h

Merge radar 9489360.

4:03 PM Changeset in webkit [87225] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/WebKit2

Merge r87113.

4:01 PM Changeset in webkit [87224] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87093.

3:58 PM Changeset in webkit [87223] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r87083.

3:53 PM Changeset in webkit [87222] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87077.

3:52 PM Changeset in webkit [87221] by beidson@apple.com
  • 9 edits
    8 adds in trunk/Source/WebKit2

Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Darin Adler.

Initialize the KeychainItem shim on SnowLeopard:

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim):

On SnowLeopard, shim the 4 SecKeychainItem methods:

  • WebProcess/mac/WebProcessShim.h:
  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecKeychainItemCopyContent):
(WebKit::shimSecKeychainItemCreateFromContent):
(WebKit::shimSecKeychainItemModifyContent):
(WebKit::shimSecKeychainItemFreeContent):
(WebKit::WebKitWebProcessKeychainItemShimInitialize):

  • WebProcess/mac/KeychainItemShimMethods.h: Added.
  • WebProcess/mac/KeychainItemShimMethods.mm: Added.

Manage a set of shim-controlled AttributeList data:
(WebKit::shimManagedAttributeLists):
(WebKit::freeAttributeListContents):
(WebKit::allocateAttributeListContents):

Manage a set of shim-controlled KeychainItem data:
(WebKit::shimManagedKeychainItemContents):
(WebKit::allocateKeychainItemContentData):

Free any shim-controlled AttributeList or KeychainItem data:
(WebKit::webFreeAttributeListContentOnMainThread):
(WebKit::webFreeAttributeListContent):
(WebKit::webFreeKeychainItemContentOnMainThread):
(WebKit::webFreeKeychainItemContent):

Marshall these 3 KeychainItem methods to the UIProcess:
(WebKit::webSecKeychainItemCopyContentOnMainThread):
(WebKit::webSecKeychainItemCopyContent):
(WebKit::webSecKeychainItemCreateFromContentOnMainThread):
(WebKit::webSecKeychainItemCreateFromContent):
(WebKit::webSecKeychainItemModifyContentOnMainThread):
(WebKit::webSecKeychainItemModifyContent):
(WebKit::initializeKeychainItemShim):

Container for an AttributeList entry that knows how to encode/decode:

  • Shared/mac/KeychainAttribute.cpp: Added.

(WebKit::KeychainAttribute::KeychainAttribute):
(CoreIPC::encode):
(CoreIPC::decode):

  • Shared/mac/KeychainAttribute.h: Added.

Container for the relevant arguments to the shimmed methods, to send to the UIProcess:

  • Shared/mac/SecKeychainItemRequestData.cpp: Added.

(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::initializeWithAttributeList):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):

  • Shared/mac/SecKeychainItemRequestData.h: Added.

(WebKit::SecKeychainItemRequestData::keychainItem):
(WebKit::SecKeychainItemRequestData::itemClass):
(WebKit::SecKeychainItemRequestData::length):
(WebKit::SecKeychainItemRequestData::data):

Container for the possible output from the shimmed methods, to send back to the WebProcess:

  • Shared/mac/SecKeychainItemResponseData.cpp: Added.

(WebKit::SecKeychainItemResponseData::SecKeychainItemResponseData):
(WebKit::SecKeychainItemResponseData::encode):
(WebKit::SecKeychainItemResponseData::decode):

  • Shared/mac/SecKeychainItemResponseData.h: Added.

(WebKit::SecKeychainItemResponseData::itemClass):
(WebKit::SecKeychainItemResponseData::data):
(WebKit::SecKeychainItemResponseData::resultCode):
(WebKit::SecKeychainItemResponseData::attributes):
(WebKit::SecKeychainItemResponseData::keychainItem):

Actually implement the calls to the SecKeychainItem* methods in the UIProcess:

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::secKeychainItemCopyContent):
(WebKit::WebProcessProxy::secKeychainItemCreateFromContent):
(WebKit::WebProcessProxy::secKeychainItemModifyContent):

  • WebKit2.xcodeproj/project.pbxproj: Project file stuff
  • Configurations/Shim.xcconfig:
3:27 PM Changeset in webkit [87220] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87046.

3:23 PM Changeset in webkit [87219] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534-branch

Merge r87026.

3:22 PM Changeset in webkit [87218] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
fail on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=61377

selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
the failing test expectation on Windows port.

In selectstart-by-double-triple-clicks.html, /\s|\s$/ isn't recognized by V8 so
replace it by /
[ \t]|[ \t]$/.

  • platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from LayoutTests/fast/events/selectstart-by-drag-expected.txt.
  • fast/events/selectstart-by-double-triple-clicks.html:
  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [87217] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534-branch

Merge r87009.

3:17 PM Changeset in webkit [87216] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87005.

3:12 PM Changeset in webkit [87215] by simonjam@chromium.org
  • 5 edits in trunk

2011-05-24 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528

  • platform/chromium/test_expectations.txt: Remove CRASH from fixed test.

2011-05-24 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528

Test: fast/text/justify-ideograph-vertical.html (on chromium linux)

  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.
3:10 PM Changeset in webkit [87214] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html on Mac WebKit2
since WebKitTestRunner doesn't implement eventSender.mouseScrollBy yet (bug 42194).

  • platform/mac-wk2/Skipped:
3:09 PM Changeset in webkit [87213] by abarth@webkit.org
  • 6 edits in trunk/Source

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:
3:06 PM Changeset in webkit [87212] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip platform/mac/editing/input/maxlength.html - textInputController is not implemented.

  • platform/mac-wk2/Skipped:
3:04 PM Changeset in webkit [87211] by sfalken@apple.com
  • 10 edits in branches/safari-534-branch

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable features on safari-534-branch.
<rdar://problem/9261347>

This change requires a full rebuild.

2:59 PM Changeset in webkit [87210] by robert@webkit.org
  • 5 edits in trunk

2011-05-24 Robert Hogan <robert@webkit.org>

Reviewed by Ryosuke Niwa.

[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393

  • platform/qt/Skipped: Unskip fast/events/selectstart-by-single-click-with-shift.html

2011-05-24 Robert Hogan <robert@webkit.org>

Reviewed by Ryosuke Niwa.

[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393

  • DumpRenderTree/qt/EventSenderQt.h:
  • DumpRenderTree/qt/EventSenderQt.cpp: (getModifiers): static function for interpreting modifiers (EventSender::mouseDown): Respect keyboard modifiers (EventSender::keyDown): use new static function (EventSender::sendOrQueueEvent): whitespace fix
2:56 PM Changeset in webkit [87209] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/selectstart-by-double-triple-clicks.html and selectstart-by-drag.html
on Mac WebKit 2 per the bug 42194.

  • platform/mac-wk2/Skipped:
2:47 PM Changeset in webkit [87208] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

We do not need assert for the useProgram as program can be null.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.
2:36 PM Changeset in webkit [87207] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on GTK
because GTK port doesn't implement eventSender.scalePageBy yet (bug 61396).

  • platform/gtk/Skipped:
2:32 PM Changeset in webkit [87206] by Lucas Forschler
  • 9 edits
    1 copy in branches/safari-534-branch/Source

Merge r86995.

2:29 PM Changeset in webkit [87205] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on Windows
because Windows port doesn't implement eventSender.scalePageBy yet (bug 59098).

  • platform/win/Skipped:
2:22 PM Changeset in webkit [87204] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340

Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.

  • editing/undo/undo-after-setting-value-expected.txt: Added.
  • editing/undo/undo-after-setting-value.html: Added.

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340

The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
calling clearUndoRedoOperations whenever script sets new value to input or textarea.

Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.

Test: editing/undo/undo-after-setting-value.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
2:12 PM Changeset in webkit [87203] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed. Updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:06 PM Changeset in webkit [87202] by Lucas Forschler
  • 10 edits in branches/safari-534-branch/Source

Merge r86992.

2:01 PM Changeset in webkit [87201] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=61392

Reviewed by Dave Hyatt.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs): Moved code here...
(WebCore::SimpleFontData::platformInit): ...from here.

1:59 PM Changeset in webkit [87200] by Lucas Forschler
  • 6 edits in branches/safari-534-branch

Merge r87022.

1:56 PM Changeset in webkit [87199] by ggaren@apple.com
  • 2 edits
    3 deletes in trunk/Source/JavaScriptCore

Fix the Mac build: Yes, please do remove these files, svn.

1:51 PM Changeset in webkit [87198] by ggaren@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

2011-05-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Let's just have one way to get the system page size, bokay?
https://bugs.webkit.org/show_bug.cgi?id=61384

  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: MarkStack[Platform].cpp is gone completely now, since it only existed to provide a duplicate way to access the system page size.
  • heap/MarkStack.cpp: (JSC::MarkStack::reset):
  • heap/MarkStack.h: (JSC::::MarkStackArray): (JSC::::shrinkAllocation): Use WTF::pageSize.
  • heap/MarkStackPosix.cpp:
  • heap/MarkStackSymbian.cpp:
  • heap/MarkStackWin.cpp: Removed now-empty files.
  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: Use WTF::pageSize.
  • wscript: Removed now-empty files.
  • wtf/PageBlock.cpp: (WTF::systemPageSize): Integrated questionable Symbian page size rule from ExecutableAllocator, because that seems like what the original author should have done.
1:41 PM Changeset in webkit [87197] by kbr@google.com
  • 25 edits
    5 adds in trunk

2011-05-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144

Implemented Float64Array based on the existing Float32Array sources.
Built and tested in Chromium on Linux and Mac OS X and Safari on Mac OS X.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::float64Array):
  • bindings/js/JSFloat64ArrayCustom.cpp: Added. (WebCore::JSFloat64Array::indexSetter): (WebCore::toJS): (WebCore::JSFloat64Array::set): (WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
  • bindings/v8/custom/V8Float64ArrayCustom.cpp: Added. (WebCore::V8Float64Array::constructorCallback): (WebCore::V8Float64Array::setCallback): (WebCore::toV8):
  • html/canvas/ArrayBufferView.h: (WebCore::ArrayBufferView::isDoubleArray):
  • html/canvas/Float64Array.cpp: Added. (WebCore::Float64Array::create): (WebCore::Float64Array::Float64Array): (WebCore::Float64Array::subarray):
  • html/canvas/Float64Array.h: Added. (WebCore::Float64Array::set): (WebCore::Float64Array::item): (WebCore::Float64Array::isDoubleArray):
  • html/canvas/Float64Array.idl: Added.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

2011-05-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144

Added unit tests to existing typed array tests in Khronos repository and
synced layout test with them. Updated other affected layout tests.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
1:23 PM Changeset in webkit [87196] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-05-24 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Add ability to set compositing layer bounds origin
https://bugs.webkit.org/show_bug.cgi?id=61381

On Core Animation layers, the origin of the bounds
rectangle affects where layer content is rendered, as well
as the offset of sublayers. Currently we always set the
bounds offset to a zero point, but may need to make use
of the bounds offset in future, so expose it via GraphicsLayer.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::boundsOrigin): (WebCore::GraphicsLayer::setBoundsOrigin):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setSize): (WebCore::GraphicsLayerCA::setBoundsOrigin): (WebCore::GraphicsLayerCA::setAllowTiledLayer): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateBounds): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  • platform/graphics/ca/GraphicsLayerCA.h:
1:18 PM Changeset in webkit [87195] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up after Geoff and fix the WebKit2 build.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
1:16 PM Changeset in webkit [87194] by Lucas Forschler
  • 10 edits in branches/safari-534-branch

Rollout 87186. It breaks the branch.

1:07 PM Changeset in webkit [87193] by leandro@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix.

  • CMakeLists.txt: Also build platform/network/ContentTypeParser.cpp, added by r86289.
1:03 PM Changeset in webkit [87192] by leandro@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix.

  • bridge/runtime_root.cpp: Include <heap/Weak.h> instead of <JavaScriptCore/Weak.h>.
12:51 PM Changeset in webkit [87191] by rniwa@webkit.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip the tests added by r87096 and remove the failing test expectations on Qt.
The failures are tracked by the bug 61322.

  • platform/qt/Skipped:
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
  • platform/qt/fast/events/selectstart-by-drag-expected.txt: Removed.
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Removed.
12:39 PM Changeset in webkit [87190] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Interpreter crashes with gc validation enabled due to failure to mark initial cache structure
https://bugs.webkit.org/show_bug.cgi?id=61385

The interpreter uses the structure slot of get_by_id and put_by_id to hold
the initial structure it encountered so that it can identify whether a
given access is stable.

When marking though we only visit the slot when we've decided to cache, and
so this value could die. This was "safe" as the value was only used for a
pointer compare, but it was incorrect. We now just mark the slot like we
should have been doing already.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures):
12:32 PM Changeset in webkit [87189] by jcivelli@chromium.org
  • 36 edits
    1 copy
    35 adds in trunk

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • configure.ac:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • mhtml/frame_0.html_original: Added.
  • mhtml/frame_1.html_original: Added.
  • mhtml/frame_2.html_original: Added.
  • mhtml/frame_4.html_original: Added.
  • mhtml/multi_frames.html_original: Added.
  • mhtml/multi_frames_ie.mht: Added.
  • mhtml/multi_frames_unmht.mht: Added.
  • mhtml/page_with_css_and_js.html_original: Added.
  • mhtml/page_with_css_and_js_ie.mht: Added.
  • mhtml/page_with_css_and_js_unmht.mht: Added.
  • mhtml/page_with_image.html_original: Added.
  • mhtml/page_with_image_ie.mht: Added.
  • mhtml/page_with_image_unmht.mht: Added.
  • mhtml/resources/red_square.png: Added.
  • mhtml/simple_page.html_original: Added.
  • mhtml/simple_page_ie.mht: Added.
  • mhtml/simple_page_unmht.mht: Added.
  • platform/chromium/mhtml/multi_frames_ie-expected.txt: Added.
  • platform/chromium/mhtml/multi_frames_unmht-expected.txt: Added.
  • platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt: Added.
  • platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt: Added.
  • platform/chromium/mhtml/page_with_image_ie-expected.txt: Added.
  • platform/chromium/mhtml/page_with_image_unmht-expected.txt: Added.
  • platform/chromium/mhtml/simple_page_ie-expected.txt: Added.
  • platform/chromium/mhtml/simple_page_unmht-expected.txt: Added.

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support. That required some basic MIME header parsing.
Modified DocumentLoader to keep a reference to the currently Archive loaded,
so we can have different policies for loading subresources depending on the
archive type.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::popArchiveForSubframe): (WebCore::DocumentLoader::scheduleArchiveLoad):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h: (WebCore::FrameLoader::archive):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/Archive.cpp: Added.
  • loader/archive/Archive.h: (WebCore::Archive::mainResource):
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveFactoryCreate): (WebCore::archiveMIMETypes): (WebCore::ArchiveFactory::create): (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
  • loader/archive/ArchiveFactory.h:
  • loader/archive/ArchiveResourceCollection.cpp: (WebCore::ArchiveResourceCollection::addAllResources): (WebCore::ArchiveResourceCollection::popSubframeArchive):
  • loader/archive/ArchiveResourceCollection.h:
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): (WebCore::LegacyWebArchive::type):
  • loader/archive/cf/LegacyWebArchive.h:
  • loader/archive/mhtml/MHTMLArchive.cpp: Added.
  • loader/archive/mhtml/MHTMLArchive.h: Added.
  • loader/archive/mhtml/MHTMLParser.cpp: Added.
  • loader/archive/mhtml/MHTMLParser.h: Added.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):
  • platform/network/MIMEHeader.cpp: Added.
  • platform/network/MIMEHeader.h: Added.

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • features.gypi:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:24 PM Changeset in webkit [87188] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix some builds: #include Weak.h for Weak<T>.

  • bridge/runtime_root.h:
12:23 PM Changeset in webkit [87187] by weinig@apple.com
  • 3 edits
    2 adds in trunk

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339

Test: fast/events/scroll-in-scaled-page-with-overflow-hidden.html

  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Scrollbars should be enabled for the viewport when scaled, even if overflow:hidden is specified.

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339

  • fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt: Added.
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html: Added.
12:22 PM Changeset in webkit [87186] by sfalken@apple.com
  • 10 edits in branches/safari-534-branch

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable features on safari-534-branch.
<rdar://problem/9261347>

12:16 PM Changeset in webkit [87185] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r86985.

12:13 PM Changeset in webkit [87184] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed now-inline functions.
12:07 PM Changeset in webkit [87183] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix: update the #if OS(WINDOWS) section to match my last patch.

  • heap/MarkStack.h:

(JSC::::shrinkAllocation):

12:03 PM Changeset in webkit [87182] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Leopard build fix

  • bridge/runtime_root.cpp: Added a missing #include.
11:57 AM Changeset in webkit [87181] by jianli@chromium.org
  • 6 edits in trunk

Make start parameter of Blob.slice optional.
https://bugs.webkit.org/show_bug.cgi?id=59628

Reviewed by Kenneth Russell.

Source/WebCore:

The start parameter should be optional per the latest FILE API
spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob.

  • fileapi/Blob.h:
  • fileapi/Blob.idl: Make start parameter optional.

LayoutTests:

  • fast/files/blob-slice-test-expected.txt:
  • fast/files/blob-slice-test.html:
11:55 AM Changeset in webkit [87180] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Split out function definitions and class definitions from class
declarations in MarkStack.h, for readability.

Rubber-stamped by Oliver Hunt.

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
(JSC::MarkStack::pageSize):
(JSC::::MarkStackArray):
(JSC::::~MarkStackArray):
(JSC::::expand):
(JSC::::append):
(JSC::::removeLast):
(JSC::::last):
(JSC::::isEmpty):
(JSC::::size):
(JSC::::shrinkAllocation):

11:51 AM Changeset in webkit [87179] by Adam Roben
  • 9 edits
    2 adds in trunk

Invalidate JS wrappers for NPObjects when they are finalized

This will cause the underlying NPObject to be released at finalization time, rather than at
destruction time (which is unpredictable and could occur after the plugin has been
unloaded).

Test: plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html

Fixes <http://webkit.org/b/61316> <rdar://problem/9489824> Crash in deallocateNPObject when
reloading yahoo.com webarchive in WebKit2

and

<http://webkit.org/b/61317> <rdar://problem/9489829> Crash in _NPN_DeallocateObject when
reloading yahoo.com webarchive in WebKit1

Reviewed by Oliver Hunt.

Source/WebCore:

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::~RuntimeObject): Assert that we've already been invalidated.

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
Updated for m_runtimeObjects type change.

(JSC::Bindings::RootObject::finalize): Added. Invalidates the RuntimeObject and removes it
from the map.

  • bridge/runtime_root.h: Now inherits from WeakHandleOwner.

Changed m_runtimeObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will
be notified when the RuntimeObjects are finalized.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::~JSNPObject): Assert that we've already been invalidated, rather than
trying to perform invalidation now (when the plugin might already be unloaded).

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
(WebKit::NPRuntimeObjectMap::invalidate):
Updated for m_jsNPObjects type change.

(WebKit::NPRuntimeObjectMap::finalize): Added. Invalidates the JSNPObject and removes it
from the map.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Now inherits from WeakHandleOwner.

Changed m_jsNPObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will be
notified when the JSNPObjects are finalized.

LayoutTests:

Test that we don't crash when a JS wrapper for an NPObject is destroyed after its plugin is unloaded

  • plugins/npobject-js-wrapper-destroyed-after-plugin-unload-expected.txt: Added.
  • plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html: Added.

(startTest): Gets a JS wrapper for an NPObject from the plugin, allocate a bunch of memory
so the JS wrapper will be finalized, then destroy the plugin and wait for a little bit
before calling finishTest.
(finishTest): Force a GC so the JS wrapper will be destroyed. If we didn't crash, we passed!

11:50 AM Changeset in webkit [87178] by senorblanco@chromium.org
  • 26 edits in trunk

2011-05-24 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Remove most style checks on Source/ThirdParty/glu, since it doesn't
follow WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=61365

  • Scripts/webkitpy/style/checker.py:

2011-05-24 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Unfork glu sources as much as possible.
https://bugs.webkit.org/show_bug.cgi?id=61365

Restore the glu sources closer to the original version on oss.sgi.com
by removing the WebKit-specific include paths, restoring the include
order, and renaming the glu* functions via #defines rather than in
the source.

  • glu/README.webkit: Update the README to reflect the changes from trunk.
  • glu/glu.gyp: Add Source/Thirdparty/glu as an include path, so we can remove the hardcoded paths from the source files.
  • glu/gluos.h: Add #defines to rename the glu entry points to internal_*.
  • glu/internal_glu.h:
  • glu/libtess/dict.c:
  • glu/libtess/geom.c:
  • glu/libtess/geom.h:
  • glu/libtess/memalloc.c:
  • glu/libtess/mesh.c:
  • glu/libtess/mesh.h:
  • glu/libtess/normal.c:
  • glu/libtess/normal.h:
  • glu/libtess/priorityq-heap.c:
  • glu/libtess/priorityq-sort.h:
  • glu/libtess/priorityq.c:
  • glu/libtess/priorityq.h:
  • glu/libtess/render.c:
  • glu/libtess/render.h:
  • glu/libtess/sweep.c:
  • glu/libtess/sweep.h:
  • glu/libtess/tess.c:
  • glu/libtess/tess.h:
  • glu/libtess/tessmono.c: Remove WebKit-specific include paths, and internal_ prefixes from glu entry points. Restore include order to original source order.
11:49 AM Changeset in webkit [87177] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Avoid creating unnecessary identifiers and strings in the syntax checker
https://bugs.webkit.org/show_bug.cgi?id=61378

Selectively tell the lexer that there are some places it does not need to
do the real work of creating Identifiers for IDENT and STRING tokens.

Make parseString and parseIdentifier templatized on whether they should
do real work, or merely validate the tokens.

SunSpider --parse-only reports ~5-8% win depending on hardware.

  • parser/ASTBuilder.h: (JSC::ASTBuilder::createDotAccess):
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression):
  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h:
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createProperty):
11:46 AM Changeset in webkit [87176] by Adam Roben
  • 2 edits in trunk/Tools

Don't allow forcing builds through the build.webkit.org web interface

Someone has been forcing bogus builds.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:39 AM Changeset in webkit [87175] by qi.2.zhang@nokia.com
  • 4 edits in trunk

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Adam Roben.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Fixes a typo issue for patch 94265.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Adam Roben.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
Because that case changed the setting.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
11:32 AM WebKit Team edited by helder@sencha.com
(diff)
11:24 AM Changeset in webkit [87174] by commit-queue@webkit.org
  • 3 edits in trunk

2011-05-24 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

skia: fix stroking of zero-height rectangles
https://bugs.webkit.org/show_bug.cgi?id=61284

Tests: canvas/philip/tests/2d.line.miter.lineedge.html

canvas/philip/tests/2d.strokeRect.zero.4.html

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::strokeRect):
11:16 AM Changeset in webkit [87173] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

2011-05-24 Zan Dobersek <zandobersek@gmail.com> and Philippe Normand <pnormand@igalia.com>

Reviewed by Kenneth Russell.

Enable FloatArray usage outside WebGL guards
https://bugs.webkit.org/show_bug.cgi?id=61356

  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
11:12 AM Changeset in webkit [87172] by adamk@chromium.org
  • 3 edits
    3 deletes in trunk

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

  • inspector/console/console-eval-syntax-error-expected.txt: Removed.
  • inspector/console/console-eval-syntax-error.html: Removed.
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback):
11:04 AM Changeset in webkit [87171] by mdelaney@apple.com
  • 5 edits
    2 adds in trunk

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135

  • fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt: Added.
  • fast/canvas/canvas-getImageData-largeNonintegralDimensions.html: Added.

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135

Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData):
  • platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::ImageBufferData::getData):
10:53 AM Changeset in webkit [87170] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by John Sullivan.

WebKit tells client that the page has become unresponsive while the beforeUnloadConfirm dialog is up
https://bugs.webkit.org/show_bug.cgi?id=61372

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Stop the unresponsiveness timer like we do for other client functions that spin a runloop.
10:45 AM Changeset in webkit [87169] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Make sure x and y adjustments are applied to all operations, and fix the calculations for the height and width checks to take into account x and y offsets.

https://bugs.webkit.org/show_bug.cgi?id=61367

10:43 AM Changeset in webkit [87168] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132

  • fast/forms/slider-hit-testing-expected.txt: Added.
  • fast/forms/slider-hit-testing.html: Added.

2011-05-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132

Test: fast/forms/slider-hit-testing.html

We need to clear m_overflow otherwise we use the first
size of the slider for hit testing (i.e., changes to the size
cause problems). This only shows up if the thumb isn't contained
in the bounds of the slider. Making the range have a smaller height
than the thumb shows the bug.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Clear the overflow during layout

so we re-compute the overflow based on the current size of the
slider.

10:41 AM Changeset in webkit [87167] by alokp@chromium.org
  • 9 edits in trunk/Source

2011-05-24 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::reallocateRenderer):

2011-05-24 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

This patch adds gpu accelerated rendering for content and root layers.
Layer textures are updated in two stages:

  1. Paint: The non-accelerated path paints the layer contents into a bitmap.

The accelerated path paints into an SkPicture, which is essentially a display list.

  1. Upload: The non-accelerated path uploads the pixels obtained in the first stage to a texture.

The accelerated path renders the picture directly into the texture.

The accelerated path can be enabled by --enable-accelerated-drawing command-line flag in chromium.
Note that this patch does not accelerate the CG path on mac. We have two options here - use skia or accelrate CG path.
Any bugs should be caught by layout tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::skiaContext): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::createRootLayerTextureUpdater):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::acceleratedDrawing):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate): (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::clearFrameBuffer):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: (WebCore::LayerTextureUpdaterSkPicture::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
10:36 AM Changeset in webkit [87166] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: display keyboard shortcuts in scripts panel sidebar buttons tooltip text.
https://bugs.webkit.org/show_bug.cgi?id=61358

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.registerShortcut):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._createSidebarButtons): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
10:15 AM Changeset in webkit [87165] by kbr@google.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

2011-05-24 Kenneth Russell <kbr@google.com>

Unreviewed. Fixed incorrect test expectations I previously checked in.

  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-actual.png: Removed.
  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-actual.png: Removed.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-expected.png: Added.
10:14 AM Changeset in webkit [87164] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed. Updated Chromium test expectations.

  • platform/chromium/test_expectations.txt: svg failure on Linux, BUGWK61370.
10:12 AM Changeset in webkit [87163] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Andres Kling.

JSAudioContextCustom doesn't encode errors
https://bugs.webkit.org/show_bug.cgi?id=61357

Fix AudioContext return values

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):
10:07 AM Changeset in webkit [87162] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-05-24 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Kenneth Rohde Christiansen.

[ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
https://bugs.webkit.org/show_bug.cgi?id=61052

  • Scripts/old-run-webkit-tests:
9:43 AM Changeset in webkit [87161] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-24 Rob Buis <rbuis@rim.com>

Rubber-stamped by Dirk Schulze.

Remove requiresLayer inlines, already provided by RenderSVGModelObject.

  • rendering/svg/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
  • rendering/svg/RenderSVGImage.h:
9:30 AM Changeset in webkit [87160] by andreas.kling@nokia.com
  • 12 edits
    2 deletes in trunk/Source/WebKit2

2011-05-24 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[WK2] Change TiledDrawingArea to use ShareableBitmap instead of UpdateChunk.
https://bugs.webkit.org/show_bug.cgi?id=61296

Pass UpdateInfo containing ShareableBitmaps instead of UpdateChunk for tile updates.
Only the bounds rect and bitmap handle in the UpdateInfo are used since none of the
other parameters are needed for TiledDrawingArea.

  • Shared/ShareableBitmap.h:
  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createQImage): (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/qt/UpdateChunk.cpp: Removed.
  • Shared/qt/UpdateChunk.h: Removed.
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate):
  • WebKit2.pro:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: (WebKit::TiledDrawingArea::paintIntoBitmap):
9:25 AM Changeset in webkit [87159] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed.

Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61169

  • platform/chromium/test_expectations.txt: Marked optimize-contrast tests as IMAGE failure, BUGWK61169.
9:11 AM Changeset in webkit [87158] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, build fix.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

Forgot to rename the destructor.

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::AdditionalFontData::~AdditionalFontData):
9:06 AM Changeset in webkit [87157] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-23 Michael Saboff <msaboff@apple.com>

Reviewed by Mark Rowe.

Safari often freezes when clicking "Return free memory" in Caches dialog
https://bugs.webkit.org/show_bug.cgi?id=61325

There are two fixes and improvement in instrumentation code used to find
one of the problems.
Changed ReleaseFreeList() to set the "decommitted" bit when releasing
pages to the system and moving Spans from the normal list to the returned
list.
Added a "not making forward progress" check to TCMalloc_PageHeap::scavenge
to eliminate an infinite loop if we can't meet the pagesToRelease target.
Added a check for the decommitted bit being set properly in
TCMalloc_PageHeap::CheckList.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::ReleaseFreeList):
8:49 AM Changeset in webkit [87156] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, build fix.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

Rename SimpleFontData::FontData subclass to AdditionalFontData, to avoid clashes with the WebCore::FontData class, which breaks the win build.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::fontData):
  • svg/SVGFontData.h:
8:44 AM Changeset in webkit [87155] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281

Remove the test case from skip list.

  • platform/qt/Skipped:
8:39 AM Changeset in webkit [87154] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix after r87153

  • WebProcess/mac/SecItemShimMethods.mm: Don't compile this code on SnowLeopard.
8:31 AM Changeset in webkit [87153] by beidson@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Sam Weinig.

In preparation for different WebProcess shims depending on platform, move the current
shim to its own files.

  • WebKit2.xcodeproj/project.pbxproj:


  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim): For non-SnowLeopard platforms, call initializeSecItemShim().

  • WebProcess/mac/SecItemShimMethods.h: Added.
  • WebProcess/mac/SecItemShimMethods.mm: Added. Actual webSecItem* methods moved from WebProcessMac.mm.

(WebKit::webSecItemCopyMatchingMainThread):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAddOnMainThread):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdateOnMainThread):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDeleteOnMainThread):
(WebKit::webSecItemDelete):
(WebKit::initializeSecItemShim): Initialize the callbacks via WebKitWebProcessSecItemShimInitialize

  • WebProcess/mac/WebProcessShim.h:
  • WebProcess/mac/WebProcessShim.mm: Wrap all the actual code here in a !BUILDING_ON_SNOW_LEOPARD block

(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):
(WebKit::WebKitWebProcessSecItemShimInitialize):

8:27 AM Changeset in webkit [87152] by Nikolas Zimmermann
  • 38 edits
    1 move
    1 add in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

First part:
Remove a long-standing layering violation in TextRun: it stores RenderObject/RenderSVGResource pointers for SVG Fonts support.
Replace the two Render* pointers with a single RefPtr<AbstractRenderingContext>. AbstractRenderingContext is a helper class,
that can be derived from in order to associate additional data with a TextRun. This effectively reduces the memory consumption of TextRun.

Introduce rendering/TextRunRenderingContext.h, which inherits from TextRun::AbstractRenderingContext and holds additional data.
If the primary font in use is a SVG Font then allocate a TextRunRenderingContext object and store it in the RefPtr<AbstractRenderingContext>
in TextRun. If the primary font is not a SVG Font, don't even allocate the TextRunRenderingContext structure, as we won't need the context data.
SVG Fonts glyph matching only works within a context, so we need access to the RenderObject that's drawing the text.

This is the main preparation patch for the SVG Fonts rewrite, that will allow us to share the simple text code path for SVG Fonts as well,
making all CSS text properties work for HTML text using SVG Fonts, and allows proper integration within the GlyphPage concept. Soon
we can intermix WOFF/SVG & native fonts, within segment font declarations.

Second part:
Remove a long-standing layering violation in SimpleFontData: it stores SVGFontData objects, that are living in svg/.
Use the same concept as above, introduce SimpleFontData::AbstractFontData, and let SVGFontData inherit from AbstractFontData and extent it.
If SVG Fonts are used, CSSFontFaceSource will create a SVGFontData object and pass it as PassOwnPtr<AbstractFontData> to SimpleFontData.

All layering violations are gone now, SVG Fonts are cleanly integrated now.
Doesn't affect any tests yet, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • platform/graphics/Font.cpp: (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
  • platform/graphics/Font.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::FontData::~FontData): (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::setMaxCharWidth): (WebCore::SimpleFontData::setAvgCharWidth): (WebCore::SimpleFontData::setSpaceWidth): (WebCore::SimpleFontData::setSpaceGlyph): (WebCore::SimpleFontData::setZeroWidthSpaceGlyph): (WebCore::SimpleFontData::fontData): (WebCore::SimpleFontData::isSVGFont): (WebCore::SimpleFontData::setMissingGlyphData):
  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setAllowTabs): (WebCore::TextRun::setXPos): (WebCore::TextRun::RenderingContext::~RenderingContext): (WebCore::TextRun::renderingContext): (WebCore::TextRun::setRenderingContext):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): (WebCore::RenderBlock::constructTextRun):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::setLogicalWidthForTextRun): (WebCore::textWidth): (WebCore::tryHyphenating): (WebCore::RenderBlock::LineBreaker::nextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::paintText):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
  • rendering/svg/SVGTextRunRenderingContext.cpp: Copied from svg/SVGFont.cpp. (WebCore::svgFontAndFontFaceElementForFontData): (WebCore::firstParentRendererForNonTextNode): (WebCore::referencingRenderObjectFromRun): (WebCore::activePaintingResourceFromRun): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthMissingGlyphCallback): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::selectionRectForTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::offsetForPositionForTextUsingSVGFont):
  • rendering/svg/SVGTextRunRenderingContext.h: Added. (WebCore::SVGTextRunRenderingContext::create): (WebCore::SVGTextRunRenderingContext::context): (WebCore::SVGTextRunRenderingContext::activePaintingResource): (WebCore::SVGTextRunRenderingContext::setActivePaintingResource): (WebCore::SVGTextRunRenderingContext::SVGTextRunRenderingContext): (WebCore::textRunNeedsRenderingContext):
  • svg/SVGAllInOne.cpp:
  • svg/SVGFont.cpp: Removed.
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
  • svg/SVGFontData.h: (WebCore::SVGFontData::create): (WebCore::SVGFontData::isSVGFontData):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::SVGVKernElement): (WebCore::SVGVKernElement::buildVerticalKerningPair):
  • svg/SVGVKernElement.h:
8:13 AM Changeset in webkit [87151] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
https://bugs.webkit.org/show_bug.cgi?id=60827

Implement getter/setter of imageInterpolationQuality and logic to change
interpolation algorithm when drawing image.
Mac and Qt already implemented it.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::drawSurfaceToContext):
  • platform/graphics/cairo/PlatformContextCairo.h: (WebCore::PlatformContextCairo::setImageInterpolationQuality): Added. (WebCore::PlatformContextCairo::imageInterpolationQuality): Added.
8:11 AM Changeset in webkit [87150] by commit-queue@webkit.org
  • 24 edits
    4 copies
    2 adds in trunk/Source/WebCore

2011-05-24 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: adding Stream and GeneratedStream classes.
https://bugs.webkit.org/show_bug.cgi?id=56666

Add the code for the Stream and GeneratedStream classes and integrate it
with the existing stream generation requests.

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toStream): (WebCore::EventTarget::toGeneratedStream):
  • dom/EventTarget.h:
  • dom/GeneratedStream.cpp: Added. (WebCore::GeneratedStream::DispatchUpdateTask::create): (WebCore::GeneratedStream::DispatchUpdateTask::performTask): (WebCore::GeneratedStream::DispatchUpdateTask::DispatchUpdateTask): (WebCore::GeneratedStream::create): (WebCore::GeneratedStream::GeneratedStream): (WebCore::GeneratedStream::~GeneratedStream): (WebCore::GeneratedStream::toGeneratedStream): (WebCore::GeneratedStream::detachEmbedder): (WebCore::GeneratedStream::stop): (WebCore::GeneratedStream::onStop):
  • dom/GeneratedStream.h: Added.
  • dom/GeneratedStream.idl: Added.
  • dom/Stream.cpp: Added. (WebCore::Stream::create): (WebCore::Stream::Stream): (WebCore::Stream::~Stream): (WebCore::Stream::toStream): (WebCore::Stream::streamEnded): (WebCore::Stream::scriptExecutionContext): (WebCore::Stream::eventTargetData): (WebCore::Stream::ensureEventTargetData):
  • dom/Stream.h: Added. (WebCore::Stream::readyState): (WebCore::Stream::label): (WebCore::Stream::refEventTarget): (WebCore::Stream::derefEventTarget):
  • dom/Stream.idl: Added.
  • page/CallbackTask.h: (WebCore::CallbackTask1::Scheduler::~Scheduler):
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::stopGeneratedStream): (WebCore::MediaStreamController::streamFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::GenerateStreamRequest::create): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::getStreamFromLabel): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::stopGeneratedStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed): (WebCore::MediaStreamFrameController::streamFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isGeneratedStream):
  • page/NavigatorUserMediaError.h: (WebCore::NavigatorUserMediaError::create): (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
  • page/NavigatorUserMediaSuccessCallback.h:
  • page/NavigatorUserMediaSuccessCallback.idl:
8:10 AM Changeset in webkit [87149] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Part 2 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE

Reviewed by Adam Roben.

  • Configurations/Base.xcconfig:

(GCC_WARN_ABOUT_MISSING_NEWLINE): Added. Set to YES.

8:09 AM Changeset in webkit [87148] by Adam Roben
  • 4 edits in trunk/Tools

Make TestFailures show how many tests are failing on each tester, and omit testers with no failures

Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
that don't have any failing tests, which isn't useful

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:

(Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
instead of name strings.
(Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
builder names into an array of builders.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
the most recently completed build, or -1 if there is no such build.
(Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
in the given build, or -1 if the number could not be determined. Some of this code came from
_getFailingTests.
(Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
(Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
getNumberOfFailingTests functions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayTesters): Get the current number of test failures for each
tester and show it in the list. Omit testers that have no failures at all. We keep the
testers and failure counts in an array and sort it before displaying the current data, as
the order in which data will be fetched is unpredictable.

7:48 AM Changeset in webkit [87147] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

REGRESSION (r45620): Node list caches never deleted
https://bugs.webkit.org/show_bug.cgi?id=61268
<rdar://problem/9467379>

Reviewed by Oliver Hunt.

NodeListsNodeData::isEmpty() tests if RefCounted objects have refcount of zero which is impossible.
As a results NodeList caches are never deleted, causing bad performance in DOM mutating operations as
they repeatedly invalidate caches.

  • dom/Node.cpp:

(WebCore::Node::childNodes):

Construct m_childNodeListCaches lazily.

(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::notifyLocalNodeListsAttributeChanged):
(WebCore::Node::notifyLocalNodeListsChildrenChanged):
(WebCore::Node::removeNodeListCacheIfPossible):

Add a helper.

(WebCore::NodeListsNodeData::invalidateCaches):

Invalidate m_childNodeListCaches by clearing it if there are no additional clients

(WebCore::NodeListsNodeData::isEmpty):

Test emptiness of various NodeListCaches simply by testing hash emptiness instead of testing for non-zero ref count of items.
m_childNodeListCaches is empty if it is null.

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListsNodeData):

Construct m_childNodeListCaches lazily.

7:17 AM Changeset in webkit [87146] by mnaganov@chromium.org
  • 4 edits in trunk/Source

2011-05-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300

  • inspector/CodeGeneratorInspector.pm:

2011-05-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
7:15 AM BuildingGtk edited by steveg20101@hotmail.com
reading is very helpful in our learning (diff)
7:10 AM QtWebKitBuildBots edited by Csaba Osztrogonác
(diff)
6:11 AM QtWebKitBuildBots edited by Laszlo Gombos
(diff)
5:38 AM Changeset in webkit [87145] by yurys@chromium.org
  • 3 edits
    3 adds in trunk

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

  • inspector/console/console-eval-syntax-error-expected.txt: Added.
  • inspector/console/console-eval-syntax-error.html: Added.
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

Test: inspector/console/console-eval-syntax-error.html

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
5:16 AM QtWebKitBuildBots edited by Laszlo Gombos
(diff)
4:22 AM Changeset in webkit [87144] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failing new test introduced in r87096

  • platform/qt-arm/Skipped:
4:14 AM QtWebKitBuildBots edited by abecsi@webkit.org
(diff)
3:55 AM QtWebKit edited by Csaba Osztrogonác
Add link to QtWebKit buildbots (diff)
3:54 AM Changeset in webkit [87143] by steveblock@google.com
  • 17 edits
    2 adds
    8 deletes in trunk/Source/WebCore

2011-04-13 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Geolocation callbacks should make use of new callback generation mechanism
https://bugs.webkit.org/show_bug.cgi?id=40065

No new tests, refactoring only.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomPositionCallback.cpp: Removed.
  • bindings/js/JSCustomPositionCallback.h: Removed.
  • bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomPositionErrorCallback.h: Removed.
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomPositionCallback.h: Removed.
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomPositionErrorCallback.h: Removed.
  • bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):
  • page/PositionCallback.h:
  • page/PositionCallback.idl: Added.
  • page/PositionErrorCallback.h:
  • page/PositionErrorCallback.idl: Added.
3:46 AM QtWebKitBuildBots created by Csaba Osztrogonác
Add the list of QtWebKit buildbots
3:04 AM Changeset in webkit [87142] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Leon Scroggins <scroggo@google.com>

Reviewed by James Robinson.

Update expectations for shadow tests which are now passing.
https://bugs.webkit.org/show_bug.cgi?id=61278

Also remove some expectations for missing tests.

  • platform/chromium/test_expectations.txt:
2:27 AM Changeset in webkit [87141] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip one more failing test.

  • platform/qt-mac/Skipped:
2:24 AM Changeset in webkit [87140] by podivilov@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-05-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: watched expressions buttons do not match inspector styles.
https://bugs.webkit.org/show_bug.cgi?id=30554

  • WebCore.gypi:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane):
  • inspector/front-end/Images/deleteIcon.png: Added.
  • inspector/front-end/Images/paneRefreshButtons.png: Added.
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype.reset): (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update.appendResult): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.prototype._mouseMove): (WebInspector.WatchExpressionsSection.prototype._mouseOut): (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.properties-tree.watch-expressions): (.properties-tree.watch-expressions li): (.section .properties .delete-button): (.section .properties li.hovered .delete-button): (.pane > .title > .pane-title-button): (.pane > .title > .pane-title-button:hover): (.pane > .title > .pane-title-button:active): (.pane > .title > .pane-title-button.add): (.pane > .title > .pane-title-button.refresh):
2:15 AM Changeset in webkit [87139] by yutak@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add fail() to WebSocketChannel and its family
https://bugs.webkit.org/show_bug.cgi?id=61277

This is the first part of refactoring effort described in bug 61115.
Existing error reports will be modified to use fail() in a later patch.

No change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail):
  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::fail): (WebCore::WorkerThreadableWebSocketChannel::Peer::fail): (WebCore::WorkerThreadableWebSocketChannel::mainThreadFail): (WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
  • websockets/WorkerThreadableWebSocketChannel.h:
2:05 AM Changeset in webkit [87138] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] REGRESSION (r87063): Fix the build.
https://bugs.webkit.org/show_bug.cgi?id=61290

No new tests needed.

2:02 AM Changeset in webkit [87137] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-24 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.
https://bugs.webkit.org/show_bug.cgi?id=61252
http://code.google.com/p/chromium/issues/detail?id=83539

Manual test: manual-tests/autofill-popup-location.html.

  • manual-tests/autofill-popup-location.html: With long long text, test the shown location is correct.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setBaseWidth): Clip width with m_maxWindowWidth. (WebCore::PopupListBox::PopupListBox): Add m_maxWindowWidth initialization. (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Call setMaxWidthAndLayout() when the width is clipped with screen size. (WebCore::PopupListBox::setMaxWidthAndLayout): Set m_maxWindowWidth and call layout(). (WebCore::PopupListBox::layout): Compare renewed windowWidth and m_maxWindowWidth, and clip the it.
1:42 AM Changeset in webkit [87136] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-24 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077

Update expectation to reflect that the canvas layer isn't composited.

  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt:

2011-05-24 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077

Return NULL from DrawingBuffer::create() if the initial dimensions are larger than we can support in hardware so
that we properly use the software canvas path and not enable the compositor for the canvas.

compositing/tiling/huge-layer-img.html triggers this case by trying to create a 20000 pixel high canvas. The
failure was previously masked by other bugs fixed by r85661.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):

Return NULL from DrawingBuffer::create() if resize() fails.

1:10 AM Changeset in webkit [87135] by ukai@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-24 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301

  • http/tests/websocket/tests/close-before-open-expected.txt: Added.
  • http/tests/websocket/tests/close-before-open.html: Added.

2011-05-24 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301

In platformClose(), m_readStream may be 0 until proxy is resolved.
It should callback didClose() in such case.

Test: http/tests/websocket/tests/close-before-open.html

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
12:42 AM Changeset in webkit [87134] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Paint the bot green for ultimate satisfaction of Ossy.

  • platform/qt-wk2/Skipped:
12:22 AM Changeset in webkit [87133] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
12:16 AM Changeset in webkit [87132] by commit-queue@webkit.org
  • 3 edits
    2 adds
    18 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/deleting/5026848-2 and editing/deleting/5026848-3 should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61323

Convert editing/deleting/5026848-2 and editing/deleting/5026848-3 to dump-as-markup.

  • editing/deleting/5026848-2-expected.txt: Added.
  • editing/deleting/5026848-2.html: Convert to dump-as-markup.
  • editing/deleting/5026848-3-expected.txt: Added.
  • editing/deleting/5026848-3.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5026848-2-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5026848-3-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/5026848-3-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5026848-2-expected.png: Removed.
  • platform/mac-leopard/editing/deleting/5026848-3-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-2-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/mac/editing/deleting/5026848-3-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-2-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-3-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-3-expected.txt: Removed.
12:04 AM Changeset in webkit [87131] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-23 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failing test because of missing anti-aliased fonts on ARM

  • platform/qt-arm/Skipped:

May 23, 2011:

11:39 PM Changeset in webkit [87130] by ukai@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87118.
http://trac.webkit.org/changeset/87118
https://bugs.webkit.org/show_bug.cgi?id=61347

patch breaks layout tests
(https://bugs.webkit.org/show_bug.cgi?id=61342), and chromium
tests (browser_test MacTestCmdUp and ui_test Scrollbar)
(Requested by ukai_ on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/ScrollAnimator.cpp:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
  • platform/graphics/IntPoint.h:
11:09 PM Changeset in webkit [87129] by inferno@chromium.org
  • 2 edits in branches/chromium/742/Source/WebCore/dom

Merge 87098 Build Fix
BUG=83012
Review URL: http://codereview.chromium.org/6992020

11:07 PM Changeset in webkit [87128] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Adam Barth.

Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818

No new tests as this is just a removal.

  • dom/ContainerNode.cpp:
  • dom/ContainerNode.h:
  • dom/Node.cpp:
  • dom/Node.h: Removed the method now that the last instance got removed as part of the <input> shadow DOM refactoring.
10:28 PM Changeset in webkit [87127] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-23 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVGTextPositioning attributes are marked as NumberList instead of LengthList
https://bugs.webkit.org/show_bug.cgi?id=61301

SVGTextPositioningElement attributes x, y, dx and dy were marked as AnimatedNumberList
instead of AnimatedLengthList.
See specification http://www.w3.org/TR/SVG/text.html#InterfaceSVGTextPositioningElement

This does not affect the behavior, since we do not respect SVG units in SMIL animation yet.
No new tests added.

  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
9:53 PM Changeset in webkit [87126] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61342

  • platform/chromium/test_expectations.txt:
9:11 PM Changeset in webkit [87125] by morrita@google.com
  • 72 edits
    2 adds in trunk/Source/WebCore

2011-05-19 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] Pass NodeRenderingContext to Node::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=61114

  • Extracted NodeRenderingContext from NodeRendererFactory, giving separate files to it.
  • Changed signature rendererIsNeeded(RenderStyle*) to rendererIsNeeded(const NodeRenderingContext&). The style object is retrieved from NodeRendererFactory::style() This will allow rendererIsNeeded() to access contextual information like attaching phase and rendering-parent.

No new tests. No behaviour change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer): Pass unresolved NodeRenderingContext& to rendererIsNeeded() (WebCore::CharacterData::rendererIsNeeded):
  • dom/CharacterData.h:
  • dom/DOMAllInOne.cpp:
  • dom/EditingText.cpp: (WebCore::EditingText::rendererIsNeeded):
  • dom/EditingText.h:
  • dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::rendererIsNeeded):
  • dom/Node.h:
  • dom/NodeRenderingContext.cpp: Added. (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::~NodeRenderingContext): (WebCore::NodeRenderingContext::setStyle): (WebCore::NodeRenderingContext::releaseStyle): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::hostChildrenChanged): (WebCore::NodeRenderingContext::shouldCreateRenderer): (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::NodeRendererFactory::createRendererIfNeeded):
  • dom/NodeRenderingContext.h: Added. (WebCore::NodeRenderingContext::node): (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle): (WebCore::NodeRenderingContext::style): (WebCore::NodeRendererFactory::context):
  • dom/ShadowContentElement.h:
  • dom/Text.cpp:
  • dom/Text.h:
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLElement.cpp:
  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLNoScriptElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLVideoElement.cpp:
  • html/HTMLVideoElement.h:
  • html/shadow/DetailsMarkerControl.cpp:
  • html/shadow/DetailsMarkerControl.h:
  • html/shadow/MeterShadowElement.cpp:
  • html/shadow/MeterShadowElement.h:
  • html/shadow/ProgressShadowElement.cpp:
  • html/shadow/ProgressShadowElement.h:
  • svg/SVGDescElement.h:
  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.h:
  • svg/SVGGElement.cpp:
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp:
  • svg/SVGStyledElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp:
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp:
  • svg/SVGTSpanElement.h:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:
8:41 PM Changeset in webkit [87124] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] don't use NetworkTranslation when uploading results
https://bugs.webkit.org/show_bug.cgi?id=61315

This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
8:31 PM Changeset in webkit [87123] by morrita@google.com
  • 12 edits in trunk/Source/WebCore

2011-05-20 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] attach() following detach() should be replaced with Node::reattach()
https://bugs.webkit.org/show_bug.cgi?id=61011

  • Renamed forceReattach() to reattach()
  • Introduced reattachIfAttached() as a variant.

No new tests. No behavior change.

  • dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • dom/Node.h: (WebCore::Node::reattach): (WebCore::Node::reattachIfAttached):
  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::recalcStyle):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
8:26 PM Changeset in webkit [87122] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r87117.

When moving #defines out in to separate files I find that code is more likely to compile
when the new header file is actually #included.

  • editing/SpellingCorrectionController.h:
7:25 PM Changeset in webkit [87121] by commit-queue@webkit.org
  • 31 edits
    7 adds in trunk

2011-05-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

  • css3/images/optimize-contrast-canvas-expected.checksum: Added.
  • css3/images/optimize-contrast-canvas-expected.png: Added.
  • css3/images/optimize-contrast-canvas-expected.txt: Added.
  • css3/images/optimize-contrast-canvas.html: Added.
  • css3/images/optimize-contrast-image-expected.checksum: Added.
  • css3/images/optimize-contrast-image-expected.png: Added.
  • css3/images/optimize-contrast-image-expected.txt: Added.
  • css3/images/optimize-contrast-image.html: Added.

2011-05-23 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627

Tests: css3/images/optimize-contrast-canvas.html

css3/images/optimize-contrast-image.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Added.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
7:15 PM Changeset in webkit [87120] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-23 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium multiple expectations update.

  • platform/chromium/test_expectations.txt:
7:08 PM Changeset in webkit [87119] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Cap painting to 30fps on Windows
https://bugs.webkit.org/show_bug.cgi?id=61337
<rdar://problem/9213388>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::displayTimerFired):
7:04 PM Changeset in webkit [87118] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

2011-05-23 Sailesh Agrawal <sail@chromium.org>

Reviewed by James Robinson.

Chromium Mac: Use ScrollAnimatorMac.mm for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/ScrollAnimator.cpp:
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h:
6:58 PM Changeset in webkit [87117] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-05-22 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
https://bugs.webkit.org/show_bug.cgi?id=61181

  • Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
  • Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h

No new tests. Just renaming a compilation conditional.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
  • editing/SpellingCorrectionController.cpp:
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
  • loader/EmptyClients.h:
  • page/EditorClient.h:
  • platform/text/TextChecking.h:
6:56 PM Changeset in webkit [87116] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by Dirk Pranke.

[chromium] fix the rebaseline tool to work with Linux GPU failures
https://bugs.webkit.org/show_bug.cgi?id=61312

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
6:52 PM Changeset in webkit [87115] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329

patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).

  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329

patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId):
6:17 PM Changeset in webkit [87114] by jchaffraix@webkit.org
  • 4 edits
    3 adds in trunk

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
<rdar://problem/9191214>

  • fast/storage/storage-detached-iframe-expected.txt: Added.
  • fast/storage/storage-detached-iframe.html: Added.
  • platform/chromium/test_expectations.txt: Marked the test as CRASH on Chromium - Linux.

2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Darin Adler.

Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140

Test: fast/storage/storage-detached-iframe.html

Access of localStorage on a detached iframe was causing a crash because a detached
iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.

  • storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): check that child->page() is non-null before accessing it.
6:02 PM Changeset in webkit [87113] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-23 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (r86990:86992): World leak when all windows closed
https://bugs.webkit.org/show_bug.cgi?id=61311

Three interlocking problems:

1) Calling [WKView fullScreenController] will create the controller if it doesn't all ready
exist, so move the closing code into WKView, where we can bail early if there isn't a
controller.

2) A retain-cycle exists between WKView and WKFullScreenWindowController. Make sure to break
the cycle explicitly by clearing the _fullScreenWindowController ivar when closing the
controller.

3) [NSWindowController close] was overridden without calling [super close]. Do that.

  • UIProcess/API/mac/WKView.mm: (-[WKView closeFullScreenWindowController]): Moved here from WebFullScreenManagerProxyMac.mm.
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Call [super close].
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate):
5:54 PM Changeset in webkit [87112] by Darin Adler
  • 2 edits in trunk/Tools

Ignore generated .pyc files in a directory full of python code.

  • Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
5:31 PM Changeset in webkit [87111] by Chris Fleizach
  • 5 edits
    2 adds in trunk

VO doesn't work with HTML5 range (slider) input @step attribute
https://bugs.webkit.org/show_bug.cgi?id=61298

Reviewed by David Kilzer.

Source/WebCore:

Test: platform/mac/accessibility/range-alter-by-step.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::stepValueForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::alterSliderValue):
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::stepValueForRange):
(WebCore::AccessibilityRenderObject::changeValueByStep):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/range-alter-by-step-expected.txt: Added.
  • platform/mac/accessibility/range-alter-by-step.html: Added.
5:29 PM Changeset in webkit [87110] by rniwa@webkit.org
  • 7 edits in trunk/LayoutTests

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Rebaselines work better if we had the new lines at the end of each file.

  • platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt:
  • platform/gtk/fast/events/selectstart-by-drag-expected.txt:
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt:
  • platform/qt/fast/events/selectstart-by-drag-expected.txt:
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt:
  • platform/win/fast/events/selectstart-by-drag-expected.txt:
5:09 PM Changeset in webkit [87109] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=61306

Reviewed by Geoff Garen.

The begin characters optimization currently has issues (#61129),
and does not appear to still be a performance win. The prudent
next step seems to be to disable while we ascertain whether this
is still a useful performance optimization.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):

4:53 PM Changeset in webkit [87108] by ddkilzer@apple.com
  • 4 edits in trunk/Source/ThirdParty/ANGLE

Part 1 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE

Merge ANGLE upstream commit r653 for Issue 154.

  • src/compiler/PoolAlloc.h: Added newline to end of file.
  • src/compiler/ShHandle.h: Ditto.
  • src/libEGL/Display.cpp: Ditto.
4:52 PM Changeset in webkit [87107] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot should give more details about the failures in IRC
https://bugs.webkit.org/show_bug.cgi?id=61233

With this patch, sheriffbot will annonce the set of failing tests,
which might help folks triage the problem.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4:50 PM Changeset in webkit [87106] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-23 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):

2011-05-23 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297

The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.

No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.

  • public/WebURLRequest.h:
4:43 PM Changeset in webkit [87105] by rniwa@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Check in failing test expectations after r87096.
They are tracked by the bugs 61319, 61320, and 61322.

  • platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • platform/gtk/fast/events/selectstart-by-drag-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-drag-expected.txt: Added.
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
  • platform/win/fast/events/selectstart-by-drag-expected.txt: Added.
4:14 PM Changeset in webkit [87104] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Chromium test fix. On Chromium Windows, a space after a word is selected when you double click on the word.

  • fast/events/selectstart-by-double-triple-clicks.html:
3:33 PM Changeset in webkit [87103] by mdelaney@apple.com
  • 4 edits in trunk/Source

2011-05-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216

  • wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):

2011-05-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216

No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.

  • platform/graphics/FloatRect.cpp: (WebCore::enclosingIntRect):
3:22 PM Changeset in webkit [87102] by jer.noble@apple.com
  • 16 edits in trunk/Source

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220

No new tests, because DumpRenderTree does not currently "animate" the full-screen transition.

There are three issues animating video content to full screen which this patch is meant to
address:
1) The animation scales between the client sizes of the element before and after full-screen.
Because these sizes have different aspect ratios, the video appears "squished" for part of
the animation. Instead, we will animate between the content box sizes before and after full
screen which, in the case of video now and object-fit content in the future, will have the
same aspect ratio before and after full screen.
2) Now that we are animating the full-screen video element's content box, the black letterbox
bars appear above and below the video (depending on the video's aspect ratio) as soon as the
animation begins. This is extremely jarring, so set the background color to clear. The
full-screen renderer's background color will serve the same purpose (providing the letterbox
background) once the animation completes.
3) Now that the letterbox color is gone, the full screen controls can appear to float in thin
air beneath the video (again, depending on aspect ratio) during the animation, so to avoid
that effect and to make the animation consistent with the old webkitenterfullscreen()
animation, we will hide the controls during the animation by adding a new CSS pseudo class
-webkit-animating-full-screen-transition.

Added a new css pseudo-class: -webkit-animating-full-screen. During the transition animation, this
pseudo-class will be applied to the current full-screen element. Styles have been added to
fullscreenQuickTime.css to hide the video element's built-in controller during the full-screen
animation.

To accomplish this, the ivar tracking whether the full-screen animation is taking place has been moved
from the RenderFullScreen renderer, to the current full-screen Document. Because changing
isAnimatingFullScreen causes style changes, make sure to call recalcStyle on the full-screen element
after changing.

This extra transition caused assertions in HTMLFormControlElement::updateFromElementCallback. A
full-screen media control's renderer is disabled during the style recalculation when exiting full
screen. This assertion was exposed by the extra recalcStyle() issued during the exit transition, and
has been removed.

  • WebCore.exp.in:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Add support for new pseudo class -webkit-animate-full-screen-transition. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • css/fullscreen.css: (video:-webkit-full-screen): Set full screen video background color to clear.
  • css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-panel): Set a default opacity transition. (video:-webkit-animating-full-screen::-webkit-media-controls-panel): Set the opacity to 0 and

disable the transition.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitWillEnterFullScreenForElement): Call our new setAnimatingFullScreen function. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::isAnimatingFullScreen): Moved here from RenderFullScreen. (WebCore::Document::setAnimatingFullScreen): Ditto.
  • dom/Document.h:
  • html/HTMLFormControlElement.cpp: (WebCore::updateFromElementCallback): Use the Document's isAnimatingFullScreen function.
  • page/FrameView.cpp: (WebCore::isDocumentRunningFullScreenAnimation): Ditto.
  • rendering/RenderFullScreen.cpp:
  • rendering/RenderFullScreen.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
  • rendering/style/RenderStyleConstants.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220

Instead of scaling between the client sizes of the full-screen element before and after
entering full-screen, scale between their content boxes. The difference is that the client
sizes can have different aspect ratios, and thus the animation can end up "squishing" the
content at one end of the animation. When animating between the two content box sizes, their
aspect ratios (for the case of video) are equal, so the animation will appear to scale
smoothly between the two states without "squishing" the content.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Set the destination frame

to be the content box of the current full screen element.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

3:15 PM Changeset in webkit [87101] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-23 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock hit testing to use IntPoint instead x,y pair
https://bugs.webkit.org/show_bug.cgi?id=61146

Covered by existing tests.

  • platform/graphics/IntPoint.h: (WebCore::toSize): Add toSize function for converting from point to size.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h: Change hit testing code in RenderBlock to use IntPoint.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
  • rendering/RenderListBox.h: Change overridden method to use IntPoint.
3:11 PM Changeset in webkit [87100] by simonjam@chromium.org
  • 2 edits in branches/chromium/742/Source/WebCore/dom

Merge 87098 - 2011-05-23 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):

BUG=83012
Review URL: http://codereview.chromium.org/7064010

2:50 PM Changeset in webkit [87099] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-23 Mike Reed <reed@google.com>

Reviewed by James Robinson.

Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311

No new tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
2:29 PM Changeset in webkit [87098] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-23 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
2:06 PM Changeset in webkit [87097] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-23 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] Link tcmalloc to DRT so we can use the heap checker
https://bugs.webkit.org/show_bug.cgi?id=61292

  • WebKit.gyp:
1:49 PM Changeset in webkit [87096] by rniwa@webkit.org
  • 5 edits
    6 adds in trunk

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489

Added tests to ensure selectstart is dispatches exactly once when selecting text by a mouse drag,
a mouse click, a double click, or a triple click. Also rebaselined a test that previously logged
extra selectstart dispatches.

  • fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
  • fast/events/selectstart-by-double-triple-clicks.html: Added.
  • fast/events/selectstart-by-drag.html:
  • fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
  • fast/events/selectstart-by-single-click-with-shift.html: Added.

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489

Fixed the bug by dispatching selectstart event immediately before modifying selection in
handleMousePressEventSingleClick and updateSelectionForMouseDrag.

Also replaced a boolean EventHandler::m_beganSelectingText by an enum-valued m_selectionInitiationState
to retain 3 states:

  1. HaveNotStartedSelection - Selection has not been set by a mouse drag or a mouse click
  2. PlacedCaret - A caret was placed by a mouse click, double click, or triple click, and is about to replace selection if a mouse drag never occurs.
  3. ExtendedSelection - A range selection was set by a mouse click, a double click, a triple click, or a mouse drag; otherwise a caret selection was set by a mouse drag.

State 1 corresponds to m_beganSelectingText being false and state 3 corresponds to m_beganSelectingText
being true. State 2 is used in updateSelectionForMouseDrag to avoid dispatching selectstart twice.

States 1 and 2 are set by updateSelectionForMouseDownDispatchingSelectStart and state 3 is set by
updateSelectionForMouseDrag.

Test: fast/events/selectstart-by-double-triple-clicks.html

fast/events/selectstart-by-drag.html
fast/events/selectstart-by-single-click-with-shift.html

  • page/EventHandler.cpp: Removed canMouseDragExtendSelect. (WebCore::EventHandler::EventHandler): Initializes m_selectionInitiationState. (WebCore::dispatchSelectStart): Returns true only if selectstart was successfully fired and default action was not prevented. (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Updates m_selectionInitiationState and modifies the selection if dispatchSelectStart returns true. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls updateSelectionForMouseDownDispatchingSelectStart. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::canMouseDownStartSelect): No longer dispatches startselect; also renamed from EventHandler::canMouseDownStartSelect. (WebCore::EventHandler::handleMousePressEvent): No longer calls canMouseDragExtendSelect. (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): Exit early if m_selectionInitiationState is HaveNotStartedSelection and dispatchSelectStart returns false. Since setSelectionIfPossible dispatches selectstart event before assigning PlacedCaret or ExtendedSelection to m_selectionInitiationState, there is no need to dispatch event for those two cases. (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/EventHandler.h: Removed canMouseDownStartSelect and canMouseDragExtendSelect from EventHandler and added setSelectionIfPossible.
1:47 PM Changeset in webkit [87095] by adamk@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-23 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155

Covered by existing tests: fast/filesystem/file-from-file-entry.html

fast/filesystem/workers/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry-sync.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Updated to call createWithName().
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
  • fileapi/File.cpp: (WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup. (WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method. (WebCore::File::File):
  • fileapi/File.h: (WebCore::File::createWithName):
  • html/FileInputType.cpp: (WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
1:40 PM Changeset in webkit [87094] by enne@google.com
  • 4 edits in trunk/Source

2011-05-23 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord):

2011-05-23 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164

Add additional tests for small max texture sizes.

  • tests/TilingDataTest.cpp: (WebCore::TEST):
1:21 PM Changeset in webkit [87093] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-23 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
https://bugs.webkit.org/show_bug.cgi?id=61299

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess): Change validity check to only check for process validity, since terminating the process of a page that is closed or is closing is acceptable behavior.
12:59 PM Changeset in webkit [87092] by robert@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Unskip passing transitions tests
https://bugs.webkit.org/show_bug.cgi?id=61246

  • platform/qt/Skipped:
  • platform/qt/transitions/move-after-transition-expected.txt: Added.
  • platform/qt/transitions/transition-end-event-rendering-expected.txt: Added.
12:54 PM Changeset in webkit [87091] by kov@webkit.org
  • 3 edits
    4 adds in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/86364.

12:47 PM Changeset in webkit [87090] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683

This test actually passes before this patch anyway. I don't think this
patch is actually observable in any meaningful way.

  • fast/images/busted-oval-does-not-render-expected.txt: Added.
  • fast/images/busted-oval-does-not-render.html: Added.
  • fast/images/resources/busted-oval.png: Added.

2011-05-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683

This change is difficult to test. We're making this change to comply
with standards even if the change is difficult to observe. (This patch
also causes us to match Firefox.)

Test: fast/images/busted-oval-does-not-render.html

  • platform/image-decoders/ImageDecoder.cpp:
12:05 PM Changeset in webkit [87089] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

No new tests, just changing gyp defines.

  • WebCore.gyp/WebCore.gyp:

2011-05-23 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219

  • WebKit.gyp:
  • WebKit.gypi:
11:52 AM Changeset in webkit [87088] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 86725
BUG=81949
Review URL: http://codereview.chromium.org/7067001

11:51 AM Changeset in webkit [87087] by luiz@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288

Reviewed by Andreas Kling.

Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.

The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::show):

11:47 AM Changeset in webkit [87086] by inferno@chromium.org
  • 3 edits in branches/chromium/742

Merge 86665
BUG=82416
Review URL: http://codereview.chromium.org/7065004

11:44 AM Changeset in webkit [87085] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 86976
BUG=83235
Review URL: http://codereview.chromium.org/7065003

11:41 AM Changeset in webkit [87084] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 87083
BUG=83598
Review URL: http://codereview.chromium.org/6966014

11:27 AM Changeset in webkit [87083] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash when parsing css color for integer or
percentage values.
https://bugs.webkit.org/show_bug.cgi?id=61293

  • fast/css/parse-color-int-or-percent-crash-expected.txt: Added.
  • fast/css/parse-color-int-or-percent-crash.html: Added.

2011-05-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Terminate css color parsing on integers which are not followed
by a terminator.
https://bugs.webkit.org/show_bug.cgi?id=61293

Test: fast/css/parse-color-int-or-percent-crash.html

  • css/CSSParser.cpp: (WebCore::parseColorIntOrPercentage):
11:07 AM Changeset in webkit [87082] by rniwa@webkit.org
  • 8 edits
    2 moves
    2 adds in trunk

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914

Added a test to ensure WebKit does not clone hierarchy to preserve background color.

Also renamed editing/pasteboard/do-not-copy-body-color.html to do-no-clone-unnecessary-styles.html
and updated the description to match new behavior. While this test ensures WebKit does not copy
body's background color when it's not fully selected, this isn't a necessary requirement for us
not to duplicate borders so new expected result is correct.

  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Some spans became style spans.
  • editing/pasteboard/do-no-clone-unnecessary-styles-2-expected.txt: Added.
  • editing/pasteboard/do-no-clone-unnecessary-styles-2.html: Added.
  • editing/pasteboard/do-no-clone-unnecessary-styles-expected.txt: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color-expected.txt.
  • editing/pasteboard/do-no-clone-unnecessary-styles.html: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color.html.

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914

The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
Fixed the bug by not cloning background color and adding the effective background color to the wrapping
style span.

Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html

editing/pasteboard/do-no-clone-unnecessary-styles.html

  • editing/EditingStyle.cpp: (WebCore::cssValueToRGBA): Extracted from getRGBAFontColor. (WebCore::getRGBAFontColor): Moved. (WebCore::rgbaBackgroundColorInEffect): Added. (WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect. (WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position. Also remove the background color property when the effective background color is equal to the background color property (in terms of RGBA value) of the editing style. (WebCore::hasTransparentBackgroundColor): Moved from Editor class. (WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
  • editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
  • editing/Editor.h: Removed hasTransparentBackgroundColor.
  • editing/markup.cpp: (WebCore::isElementPresentational): Reverted r85090 and r84311. (WebCore::createMarkup): Include the background color in effect when computing the editing style.
11:07 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
11:06 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
11:04 AM QtWebKit edited by Ademar Reis
(diff)
11:00 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
10:59 AM Changeset in webkit [87081] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content
https://bugs.webkit.org/show_bug.cgi?id=45889

Add a regression test now that the bug has been fixed by r87067.

  • fast/forms/delete-text-with-invisible-br-expected.txt: Added.
  • fast/forms/delete-text-with-invisible-br.html: Added.
10:59 AM QtWebKitFeatures21 edited by Ademar Reis
(diff)
10:56 AM Changeset in webkit [87080] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87078.
http://trac.webkit.org/changeset/87078
https://bugs.webkit.org/show_bug.cgi?id=61294

Patch contains errors and seems likely to break a bunch of
bots (Requested by abarth on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:47 AM Changeset in webkit [87079] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-23 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983

Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.

No new tests. (refactoring)

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
10:28 AM Changeset in webkit [87078] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-05-23 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:15 AM Changeset in webkit [87077] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Windows] Initial Cookie Accept Policy not set on Deserialized Storage Session.
https://bugs.webkit.org/show_bug.cgi?id=61255

Reviewed by Darin Adler.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
Move the code to set the cookie policy before the early return that is taken when using the
default storage session from the UI Process.
Also, remove unnecessary #ifdefs (USE(CFURLSTORAGESESSIONS) is true if USE(CFNETWORK) is
true) and add a comment explaining the early return.

9:40 AM Changeset in webkit [87076] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>

Reviewed by Gavin Barraclough.

[SH4] AssemblerLabel does not name a type
https://bugs.webkit.org/show_bug.cgi?id=59927

SH4Assembler.h file shoold be included before AbstractMacroAssembler.h.

  • assembler/MacroAssemblerSH4.h:
9:05 AM Changeset in webkit [87075] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-05-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Move generation of shell_command from port to executive
https://bugs.webkit.org/show_bug.cgi?id=61251

After move it's possible to use the code in other places too.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/system/executive.py:
8:07 AM Changeset in webkit [87074] by yurys@chromium.org
  • 23 edits
    1 delete in trunk/Source

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267

All methods of WorkerContextInspectorProxy are inlined in WorkerContextProxy and
the class itself is removed. Messages from worker inspector to page inspector
are sent by means of WorkerReportingProxy.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker): (WebCore::InspectorWorkerAgent::sendMessageToWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.h:
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
  • inspector/WorkerInspectorController.h:
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postMessageToPageInspector):
  • workers/WorkerContextInspectorProxy.h: Removed.
  • workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::PageInspector::~PageInspector): (WebCore::WorkerContextProxy::connectToInspector): (WebCore::WorkerContextProxy::disconnectFromInspector): (WebCore::WorkerContextProxy::sendMessageToInspector):
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267

WebWorker and WebWorkerClient are extended with methods for passing
DevTools messages between worker context inspector and page inspector.

  • public/WebWorker.h: (WebKit::WebWorker::attachDevTools): (WebKit::WebWorker::detachDevTools): (WebKit::WebWorker::dispatchDevToolsMessage):
  • public/WebWorkerClient.h: (WebKit::WebWorkerClient::dispatchDevToolsMessage):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspector): (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::connectToInspector): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::sendMessageToInspector): (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
  • src/WebWorkerClientImpl.h:
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
  • src/WebWorkerImpl.h:
7:30 AM Changeset in webkit [87073] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285

broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).

  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Removed.
  • http/tests/inspector/resource-har-headers.html: Removed.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285

broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).

7:20 AM Changeset in webkit [87072] by qi.2.zhang@nokia.com
  • 12 edits in trunk

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Unskip test case due to the implementation setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setJavaScriptCanAccessClipboard):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
6:41 AM Changeset in webkit [87071] by podivilov@chromium.org
  • 6 edits in trunk

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
  • inspector/debugger/resources/obfuscated.js: (withComments):
  • inspector/debugger/script-formatter.html:

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037

  • inspector/front-end/JavaScriptFormatter.js: (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype._addComment): (FormattedContentBuilder.prototype._addText): (FormattedContentBuilder.prototype._addMappingIfNeeded):
6:29 AM Changeset in webkit [87070] by caseq@chromium.org
  • 9 edits
    2 adds in trunk

2011-05-23 Mike West <mkwst@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Setting correct expectations for the following fields newly added to
the HAR implementation:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Added.
  • http/tests/inspector/resource-har-headers.html: Added.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-05-23 Mike West <mkwst@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Specifically, this patch adds:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression

Tests: http/tests/inspector/resource-har-conversion.html

http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html

6:26 AM Changeset in webkit [87069] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK] Skip a failing test.

  • platform/qt-wk2/Skipped:
5:05 AM Changeset in webkit [87068] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: keyboard shortcut panel is 1px too short
https://bugs.webkit.org/show_bug.cgi?id=61242

Fixed bottom margin of attached helpscreen so it's glued to status bar.

  • inspector/front-end/helpScreen.css: (body.attached .help-window-outer):
3:10 AM Changeset in webkit [87067] by tkent@chromium.org
  • 212 edits in trunk

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Reviewed by Dimitri Glazkov.

Source/WebCore:

By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:

<textarea> --(shadow-connection)-- <div> -- ...

After the change:

<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...

The goals of this change are

  • Change to the new shadow DOM model, and
  • Minimize the patch size.

We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.

Note: This is a re-landing for r87014 with a small fix of
Element::removeShadowRoot().

  • css/html.css:

(input::-webkit-inner-spin-button):

Add vertical-align in order to avoid the button affect the baseline.

(input::-webkit-outer-spin-button): ditto.
(input::-webkit-input-speech-button): ditto.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle): Calls styleForRenderer() so that a

subclass of Element can override it.

(WebCore::Element::remvoeShadowRoot):

Fix a wrong parameter for willRemoveDOMNode().

(WebCore::Element::isSpellCheckingEnabled):

Handle ShadowRoot, which is not an Element.

  • dom/Node.cpp: Add utility functions for editing code.

(WebCore::Node::nonBoundaryShadowTreeRootNode):
(WebCore::Node::nonShadowBoundaryParentNode):

  • dom/Node.h: Declare them.
  • dom/Position.cpp:
    • Add some assertions about ShadowRoot
    • Replace parentNode() with nonShadowBoundaryParentNode()

Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

  • dom/Position.h: ditto.

(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):

  • editing/CompositeEditCommand.cpp: ditto.

(WebCore::CompositeEditCommand::insertNodeAfter):
(WebCore::CompositeEditCommand::removeNode):

  • editing/Editor.cpp:

(WebCore::Editor::findString): ditto.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.

  • editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeNode): ditto.
(WebCore::ReplacementFragment::insertNodeBefore): ditto.

  • editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot.

(WebCore::VisibleSelection::isAll):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):

  • editing/VisibleSelection.h: ditto.
  • editing/htmlediting.cpp: Add assertions.

(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::create): Calls createShadowSubtree().
(WebCore::HTMLInputElement::createShadowSubtree):

Calls InputType::createShadowSubTree().

(WebCore::HTMLInputElement::innerTextElement):

Accessor of a shadow node. This is used by RenderTextControlSingleLine.

(WebCore::HTMLInputElement::innerBlockElement): ditto.
(WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::resultsButtonElement): ditto.
(WebCore::HTMLInputElement::cancelButtonElement): ditto.
(WebCore::HTMLInputElement::speechButtonElement): ditto.
(WebCore::HTMLInputElement::parseMappedAttribute):

Rebuild shadow trees because x-webkit-speech attribute affects it.

  • html/HTMLInputElement.h: Add declarations.
  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
(WebCore::HTMLTextAreaElement::createShadowSubtree): Added.

  • html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  • html/InputType.h: Add default implementations of accessors.

(WebCore::InputType::innerBlockElement):
(WebCore::InputType::innerTextElement):
(WebCore::InputType::innerSpinButtonElement):
(WebCore::InputType::outerSpinButtonElement):
(WebCore::InputType::resultsButtonElement):
(WebCore::InputType::cancelButtonElement):
(WebCore::InputType::speechButtonElement):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType): Initializes new data members.
(WebCore::SearchInputType::createShadowSubtree):

Moved from RenderTextControlSingleLine.

(WebCore::SearchInputType::destroyShadowSubtree): Clear element references.

  • html/SearchInputType.h: Add declarations.

(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::TextFieldInputType):

Initializes new data members.

(WebCore::TextFieldInputType::createShadowSubtree):

Moved from RenderTextControlSingleLine.

(WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.

  • html/TextFieldInputType.h: Add declarations.

(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::outerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):

Remove shadowParent parameter. It is unnecessary because we switch to
new shadow model.

(WebCore::TextControlInnerElement::create):

Change the parameter type to Document.

(WebCore::TextControlInnerElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerBlockStyle().

(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):

Remove shadowParent parameter.
Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
(WebCore::TextControlInnerTextElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerTextStyle().

(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):

Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SearchFieldResultsButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createResultButtonStyle().

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):

Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SearchFieldCancelButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createCancelButtonStyle().

(WebCore::SearchFieldCancelButtonElement::detach):

Update for the parent class change.

(WebCore::SpinButtonElement::SpinButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Add the inner flag
  • Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SpinButtonElement::createInner): Introduce a new factory

method to hide a bool parameter of the constructor.

(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().

(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Inherit HTMLDivElement, not TextControlInnerElement.
  • Do not register this as a speech input listener here.

(WebCore::InputFieldSpeechButtonElement::create):

Update for the parameter change.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Do not handle click event if listener registration is not done.

(WebCore::InputFieldSpeechButtonElement::attach):

Register this as a speech input listener.

(WebCore::InputFieldSpeechButtonElement::detach):

Update for the parent class change.

(WebCore::InputFieldSpeechButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().

  • html/shadow/TextControlInnerElements.h:

(WebCore::TextControlInnerTextElement::isMouseFocusable):

Add this because the class is not a subclass of TextControllInnerElement.

(WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
(WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
(WebCore::SpinButtonElement::isMouseFocusable): ditto.
(WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
(WebCore::RenderTextControl::styleDidChange):

innerTextElement can have no renderer.
Explicitly call setNeedsStyleRecals() for innerTextElement. It is
needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.

(WebCore::RenderTextControl::textBlockWidth): Member data -> function
(WebCore::RenderTextControl::updateFromElement): ditto.
(WebCore::RenderTextControl::setInnerTextValue): ditto.
(WebCore::RenderTextControl::hasVisibleTextArea): ditto.
(WebCore::RenderTextControl::isSelectableElement): ditto.
(WebCore::RenderTextControl::selection): ditto.
(WebCore::RenderTextControl::visiblePositionForIndex): ditto.
(WebCore::RenderTextControl::indexForVisiblePosition): ditto.
(WebCore::RenderTextControl::text): ditto.
(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
(WebCore::RenderTextControl::computeLogicalHeight): ditto.
(WebCore::RenderTextControl::hitInnerTextElement): ditto.
(WebCore::RenderTextControl::forwardEvent): ditto.
(WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.

  • rendering/RenderTextControl.h:
    • Make m_innerText virtual function.
    • Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::innerTextElement): Added.
(WebCore::RenderTextControlMultiLine::updateFromElement):

Remove unnecessary createSubtreeIfNeeded() call.

  • rendering/RenderTextControlMultiLine.h: Add a declaration.
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):

Remove unnecessary code.

(WebCore::RenderTextControlSingleLine::innerTextElement): Added.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
(WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
(WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
(WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
(WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
(WebCore::RenderTextControlSingleLine::layout): ditto.
(WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
(WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
(WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
(WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
(WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
(WebCore::RenderTextControlSingleLine::updateFromElement):

ditto, and remove unnecessary createSubtreeIfNeeded() call.

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

Data member -> function

(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
(WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.

  • rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.

LayoutTests:

Update test results because the shadow tree structure of <input> and
<textarea> is changed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:
2:41 AM Changeset in webkit [87066] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

Merge 86963 - 2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/7051034

2:07 AM Changeset in webkit [87065] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed trivial fix after r86990.

  • WebKit2.pro: Remove UIProcess/ChunkedUpdateDrawingAreaProxy.h.
2:01 AM Changeset in webkit [87064] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed, skip new failing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
1:48 AM Changeset in webkit [87063] by vitalyr@chromium.org
  • 18 edits in trunk/Source/WebCore

2011-05-19 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Explicitly mark objects with complex GC rules.
https://bugs.webkit.org/show_bug.cgi?id=61131

From the GC point view there are two kinds of objects: the ones
that may participate in object grouping (i.e. their lifetime
depends on other objects) and the ones that never participate in
grouping (independent). V8 added support for marking persistent
handles as independent so that the GC can process the objects they
hold faster. The motivating use case here is typed arrays.

This patch adds V8-specific inherited IDL attribute
V8DependentLifetime to types used in V8GCController, which is
exactly the set of types with object lifetimes depending on other
objects. The handles for the types that are not marked with the
new attribute can be marked as independent and GC-ed faster.

  • bindings/scripts/CodeGeneratorV8.pm: Added proccessing of the new attribute.

Updated test output:

  • bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
  • bindings/scripts/test/V8/V8TestObj.h:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

Added the new attribute:

  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/DOMImplementation.idl:
  • dom/Node.idl:
1:46 AM Changeset in webkit [87062] by commit-queue@webkit.org
  • 212 edits in trunk

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266

It made more tests assert (Requested by Ossy on #webkit).

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:

2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266

It made more tests assert (Requested by Ossy on #webkit).

  • css/html.css: (input::-webkit-inner-spin-button): (input::-webkit-outer-spin-button): (input::-webkit-input-speech-button):
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::Element::isSpellCheckingEnabled):
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::containerNode): (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::parentEditingBoundary): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree):
  • dom/Position.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::findString):
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll):
  • editing/FrameSelection.h: (WebCore::FrameSelection::shadowTreeRootNode):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): (WebCore::ReplacementFragment::insertNodeBefore):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::shadowTreeRootNode):
  • editing/VisibleSelection.h:
  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
  • html/HTMLTextAreaElement.h:
  • html/InputType.h:
  • html/SearchInputType.cpp:
  • html/SearchInputType.h: (WebCore::SearchInputType::SearchInputType):
  • html/TextFieldInputType.cpp:
  • html/TextFieldInputType.h: (WebCore::TextFieldInputType::TextFieldInputType):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::TextControlInnerElement::detach): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::detach): (WebCore::SpinButtonElement::setHovered): (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
  • html/shadow/TextControlInnerElements.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::hasVisibleTextArea): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition): (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::computeLogicalHeight): (WebCore::RenderTextControl::hitInnerTextElement): (WebCore::RenderTextControl::forwardEvent): (WebCore::RenderTextControl::computePreferredLogicalWidths): (WebCore::RenderTextControl::innerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::decorationWidthRight): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
  • rendering/RenderTextControlSingleLine.h:
1:27 AM Changeset in webkit [87061] by commit-queue@webkit.org
  • 8 edits in trunk

2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146

Move WTF_INCLUDE_DIRECTORIES to Source/JavaScriptCore/wtf/CMakeLists.txt.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:

2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146

Move wtf-files to Source/JavaScriptCore/wtf/CMakeLists.txt.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • wtf/CMakeLists.txt:
  • wtf/CMakeListsEfl.txt:
1:14 AM Changeset in webkit [87060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-23 Joe Wild <joseph.wild@nokia.com>

Reviewed by Andreas Kling.

[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200

  • symbian/eabi/QtWebKitu.def:
1:07 AM Changeset in webkit [87059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61202

LayoutTests/fast/canvas/webgl/gl-object-get-calls.html

getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
1:02 AM Changeset in webkit [87058] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r86990.

  • GNUmakefile.am: Remove UpdateChunk.cpp and UpdateChunk.h.
12:58 AM Changeset in webkit [87057] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Strict PassOwnPtr build fix.

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::newTextCodecGtk):
12:50 AM Changeset in webkit [87056] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Show "Please wait" message during initial
heap snapshot processing.
https://bugs.webkit.org/show_bug.cgi?id=61040

  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView.setDataSource): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeView):
  • inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
12:11 AM Changeset in webkit [87055] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-23 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fixes.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderTrackStyle): (WebCore::RenderThemeGtk::adjustSliderThumbStyle): (WebCore::RenderThemeGtk::adjustProgressBarStyle):

May 22, 2011:

11:56 PM Changeset in webkit [87054] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustProgressBarStyle):
11:27 PM Changeset in webkit [87053] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-22 Adam Barth <abarth@webkit.org>

Build fix. More public destructors needed to play nice with OwnPtr.

  • WebCoreSupport/InspectorClientGtk.cpp:
11:22 PM Changeset in webkit [87052] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-22 Adam Barth <abarth@webkit.org>

Build fix. InspectorFrontendClient needs a public destructor so that
we can properly track ownership using OwnPtr.

  • WebCoreSupport/InspectorClientGtk.h:
11:11 PM Changeset in webkit [87051] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::InspectorFrontendClient):
11:07 PM Changeset in webkit [87050] by ukai@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-22 Greg Simon <gregsimon@chromium.org>

Reviewed by Darin Fisher.

[chromium] Updating chromium DEPS

https://bugs.webkit.org/show_bug.cgi?id=61236

  • DEPS:
11:04 PM Changeset in webkit [87049] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-22 Adam Barth <abarth@webkit.org>

Strict PassOwnPtr build fix.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::addUserStyleSheet):
10:54 PM Changeset in webkit [87048] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-22 Adam Barth <abarth@webkit.org>

Enable strict PassOwnPtr for everyone. I expect this patch will need
some followups to make the GTK and EFL bots green again.

  • wtf/PassOwnPtr.h:
10:48 PM BuildingQtOnOSX edited by dominicc@chromium.org
Added note about the dangers of MacPorts flex (diff)
6:00 PM WebKit Team edited by dpranke@chromium.org
(diff)
5:48 PM Changeset in webkit [87047] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt: add fast/block/positioning/058.html
3:35 PM Changeset in webkit [87046] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).

3:29 PM Changeset in webkit [87045] by sullivan@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Rolled out <http://trac.webkit.org/changeset/87030>, which I accidentally checked into
the branch instead of trunk.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):

3:18 PM Changeset in webkit [87044] by yi.4.shen@nokia.com
  • 3 edits
    24 adds in trunk/Source/WebKit/qt

2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin with html5 video player.

  • symbian/platformplugin/HTML5VideoPlugin.cpp: Added. (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler): (HTML5FullScreenVideoHandler::enterFullScreen): (HTML5FullScreenVideoHandler::exitFullScreen): (HTML5FullScreenVideoHandler::onPlayerError): (HTML5FullScreenVideoHandler::onPlayerStateChanged): (HTML5FullScreenVideoHandler::onMediaStatusChanged): (HTML5VideoPlugin::supportsExtension): (HTML5VideoPlugin::createExtension):
  • symbian/platformplugin/HTML5VideoPlugin.h: Added. (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (HTML5FullScreenVideoHandler::isFullScreen): (HTML5FullScreenVideoHandler::updateScreenRect):
  • symbian/platformplugin/HTML5VideoWidget.cpp: Added. (HTML5VideoWidget::HTML5VideoWidget): (HTML5VideoWidget::setDuration): (HTML5VideoWidget::mousePressEvent): (HTML5VideoWidget::onPlayerStopped): (HTML5VideoWidget::onPlayerError): (HTML5VideoWidget::onEndOfMedia): (HTML5VideoWidget::onBufferingMedia): (HTML5VideoWidget::onBufferedMedia): (HTML5VideoWidget::onControlClicked): (HTML5VideoWidget::onPositionChanged): (HTML5VideoWidget::onSliderMoved): (HTML5VideoWidget::onCloseClicked): (HTML5VideoWidget::showFullScreen): (HTML5VideoWidget::setVolume):
  • symbian/platformplugin/HTML5VideoWidget.h: Added.
  • symbian/platformplugin/OverlayWidget.cpp: Added. (OverlayWidget::OverlayWidget): (OverlayWidget::~OverlayWidget): (OverlayWidget::setDuration): (OverlayWidget::setPosition): (OverlayWidget::setVolume): (OverlayWidget::mousePressEvent): (OverlayWidget::onPlayerStopped): (OverlayWidget::onPlayerError): (OverlayWidget::onEndOfMedia): (OverlayWidget::onBufferingMedia): (OverlayWidget::onBufferedMedia): (OverlayWidget::timeToString): (OverlayWidget::applyStyleSheet): (OverlayWidget::onControlClicked): (OverlayWidget::onSliderMoved): (OverlayWidget::onSoundClicked): (OverlayWidget::onCloseClicked): (OverlayWidget::onVolumeSliderReleased): (OverlayWidget::onVolumeSliderMoved): (OverlayWidget::onTimerTimeout): (OverlayWidget::showFullScreen):
  • symbian/platformplugin/OverlayWidget.h: Added.
  • symbian/platformplugin/PlayerButton.cpp: Added. (PlayerButton::PlayerButton): (PlayerButton::event):
  • symbian/platformplugin/PlayerButton.h: Added.
  • symbian/platformplugin/PlayerLabel.cpp: Added. (PlayerLabel::PlayerLabel): (PlayerLabel::onPlayerError): (PlayerLabel::startBufferingAnimation): (PlayerLabel::stopBufferingAnimation): (PlayerLabel::onAnimationTimeout):
  • symbian/platformplugin/PlayerLabel.h: Added.
  • symbian/platformplugin/WebPlugin.cpp: (WebPlugin::createExtension):
  • symbian/platformplugin/images: Added.
  • symbian/platformplugin/images/button_cannotplay.png: Added.
  • symbian/platformplugin/images/button_close.png: Added.
  • symbian/platformplugin/images/button_pause.png: Added.
  • symbian/platformplugin/images/button_play.png: Added.
  • symbian/platformplugin/images/button_sound_off.png: Added.
  • symbian/platformplugin/images/button_sound_on.png: Added.
  • symbian/platformplugin/images/loading_buffering_1.png: Added.
  • symbian/platformplugin/images/loading_buffering_2.png: Added.
  • symbian/platformplugin/images/loading_buffering_3.png: Added.
  • symbian/platformplugin/images/loading_buffering_4.png: Added.
  • symbian/platformplugin/platformplugin.pro:
  • symbian/platformplugin/platformplugin.qrc: Added.
  • symbian/platformplugin/qss: Added.
  • symbian/platformplugin/qss/OverlayWidget.qss: Added.
12:33 PM Changeset in webkit [87043] by robert@webkit.org
  • 7 edits
    2 deletes in trunk

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

  • platform/qt/Skipped: Unskip fast/encoding/mailto-always-utf-8.html
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Removed.

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT

https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

2011-05-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247

Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant, so remove it.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate):
11:52 AM Changeset in webkit [87042] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

11:51 AM Changeset in webkit [87041] by Lucas Forschler
  • 1 copy in tags/Safari-534.38

New tag.

11:08 AM Changeset in webkit [87040] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-05-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use double quotes for filename arguments
https://bugs.webkit.org/show_bug.cgi?id=61250

Windows does not support single quotes on the command line,
so replace them with double quotes.

  • Scripts/prepare-ChangeLog:
10:35 AM Changeset in webkit [87039] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r86972.

10:33 AM Changeset in webkit [87038] by Lucas Forschler
  • 7 edits in branches/safari-534-branch/Source/WebKit2

Merge r86967.

10:31 AM Changeset in webkit [87037] by Lucas Forschler
  • 10 edits in branches/safari-534-branch/Source

Merge r86956.

10:28 AM Changeset in webkit [87036] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Merge r86924.

10:26 AM Changeset in webkit [87035] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r86904.

10:23 AM Changeset in webkit [87034] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r86895.

10:16 AM Changeset in webkit [87033] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r86779.

9:56 AM Changeset in webkit [87032] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

Tests are in WebKit/qt/tests/hybridPixmap

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToImageDataMethod::name): (JSC::Bindings::QtPixmapToImageDataMethod::invoke): (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels): (JSC::Bindings::QtPixmapClass::methodsNamed): (JSC::Bindings::QtPixmapInstance::getPropertyNames): Add toImageData() to Qt Bridge, alternative to assignToHTMLImageElement().

2011-05-22 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Benjamin Poulain.

[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897

  • docs/qtwebkit-bridge.qdoc:
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): Document Qt bridge toImageData() feature.
  • tests/hybridPixmap/test.html:
  • tests/hybridPixmap/widget.cpp: (Widget::Widget): (Widget::abcImage):
  • tests/hybridPixmap/widget.h: Add tests for Qt bridge toImageData() feature.
9:48 AM Changeset in webkit [87031] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-22 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249

  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().
9:27 AM Changeset in webkit [87030] by sullivan@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).

8:56 AM Changeset in webkit [87029] by dominicc@chromium.org
  • 4 edits in trunk

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

  • platform/mac/Skipped: Unskip shadow tests.

2011-05-22 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245

Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot): Call detach if attached.
3:13 AM Changeset in webkit [87028] by krit@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176

General clean-up.

Don't resolve style manually, instead ask the RenderObject for its style.

Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.

No new tests needed. No change of behavior.

  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::build):
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/svgattrs.in:

May 21, 2011:

11:58 PM Changeset in webkit [87027] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
if none of its childs caught the event. This is the case for all pointer-events other than 'none'.

Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml

svg/custom/pointer-events-on-svg-without-pointer.xhtml

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

2011-05-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467

Check that an embedded SVG element doesn't have a pointer, if pointer-events is set to 'none'.

  • svg/custom/pointer-events-on-svg-with-pointer-expected.txt: Added.
  • svg/custom/pointer-events-on-svg-with-pointer.xhtml: Added.
  • svg/custom/pointer-events-on-svg-without-pointer-expected.txt: Added.
  • svg/custom/pointer-events-on-svg-without-pointer.xhtml: Added.
9:44 PM Changeset in webkit [87026] by mitz@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/block/positioning/start-ignoring-before.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
whether to merge the first trailing space with the line break.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
character, account for trailing positioned objects that occurred after the midpoint by calling
updateMidpointsForTrailingBoxes(), which adds midpoints for them.

LayoutTests:

  • fast/block/positioning/start-ignoring-before-expected.png: Added.
  • fast/block/positioning/start-ignoring-before-expected.txt: Added.
  • fast/block/positioning/start-ignoring-before.html: Added.
8:08 PM Changeset in webkit [87025] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations exception for:
fast/css/custom-font-xheight.html

  • platform/chromium/test_expectations.txt:
5:43 PM Changeset in webkit [87024] by jschuh@chromium.org
  • 3 edits
    6 adds in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed

Chromium expectations updates.

  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [87023] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-21 Nancy Piedra <nancy.piedra@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] WKStringCopyQString function is not exported
https://bugs.webkit.org/show_bug.cgi?id=59285

A few functions were declared twice but without the export macro.
On Symbian, the linking failed when trying to reference these functions.

  • UIProcess/API/qt/qgraphicswkview.h:
3:30 PM Changeset in webkit [87022] by jer.noble@apple.com
  • 6 edits in trunk

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be

synchronous, so make sure to check whether the current element is
in the DOM before dispatching.

2011-05-21 Jeremy Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the

exit functions (was calling the enter functions).

1:15 PM Changeset in webkit [87021] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-21 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium SVG expectations update.

  • platform/chromium/test_expectations.txt:
12:24 PM Changeset in webkit [87020] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

  • fast/dom/HTMLLinkElement/prerender-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prerender.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-21 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079

Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.

This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.

Test: fast/dom/HTMLLinkElement/prerender.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
  • platform/network/ResourceRequestBase.h:
8:30 AM Changeset in webkit [87019] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderLineBoxList::hitTest to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61156

Change the RenderLineBoxList hit testing to use IntPoint and clean up the rect calculation.

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
6:54 AM Changeset in webkit [87018] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-21 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change HitTestResult to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61230

Covered by existing tests.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult):
  • rendering/HitTestResult.h: (WebCore::HitTestResult::isRectBasedTest):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
5:41 AM Changeset in webkit [87017] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[GTK] [Chromium] Update test results for r87014.
https://bugs.webkit.org/show_bug.cgi?id=54179

  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
4:23 AM Changeset in webkit [87016] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[Qt] Update test results for r87014.

  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
4:04 AM Changeset in webkit [87015] by jochen@chromium.org
  • 6 edits
    1 add in trunk/Source

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ExtraData::~ExtraData): (WebCore::ResourceRequest::extraData): (WebCore::ResourceRequest::setExtraData):

2011-05-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033

  • WebKit.gypi:
  • public/WebURLRequest.h: (WebKit::WebURLRequest::ExtraData::~ExtraData):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::extraData): (WebKit::WebURLRequest::setExtraData):
  • tests/WebURLRequestTest.cpp: Added. (WebKit::TestExtraData::TestExtraData): (WebKit::TestExtraData::~TestExtraData): (WebKit::TEST):
3:47 AM Changeset in webkit [87014] by tkent@chromium.org
  • 206 edits in trunk

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

Update test results because the shadow tree structure of <input> and
<textarea> is changed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-zoomed-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-paste-undo-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-transformed-expected.txt:
  • platform/mac/fast/forms/search-zoomed-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-paste-undo-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-transformed-expected.txt:
  • platform/qt/fast/forms/search-zoomed-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:

2011-05-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179

By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:

<textarea> --(shadow-connection)-- <div> -- ...

After the change:

<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...

The goals of this change are

  • Change to the new shadow DOM model, and
  • Minimize the patch size.

We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.

  • css/html.css: (input::-webkit-inner-spin-button): Add vertical-align in order to avoid the button affect the baseline. (input::-webkit-outer-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
  • dom/Element.cpp: (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a subclass of Element can override it. (WebCore::Element::isSpellCheckingEnabled): Handle ShadowRoot, which is not an Element.
  • dom/Node.cpp: Add utility functions for editing code. (WebCore::Node::nonBoundaryShadowTreeRootNode): (WebCore::Node::nonShadowBoundaryParentNode):
  • dom/Node.h: Declare them.
  • dom/Position.cpp:
    • Add some assertions about ShadowRoot
    • Replace parentNode() with nonShadowBoundaryParentNode()

Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

  • dom/Position.h: ditto. (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
  • editing/CompositeEditCommand.cpp: ditto. (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::findString): ditto.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
  • editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): ditto. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
  • editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot. (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
  • editing/VisibleSelection.h: ditto.
  • editing/htmlediting.cpp: Add assertions. (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): Calls createShadowSubtree(). (WebCore::HTMLInputElement::createShadowSubtree): Calls InputType::createShadowSubTree(). (WebCore::HTMLInputElement::innerTextElement): Accessor of a shadow node. This is used by RenderTextControlSingleLine. (WebCore::HTMLInputElement::innerBlockElement): ditto. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto. (WebCore::HTMLInputElement::resultsButtonElement): ditto. (WebCore::HTMLInputElement::cancelButtonElement): ditto. (WebCore::HTMLInputElement::speechButtonElement): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Rebuild shadow trees because x-webkit-speech attribute affects it.
  • html/HTMLInputElement.h: Add declarations.
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree(). (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
  • html/HTMLTextAreaElement.h: Declare createShadowSubtree().
  • html/InputType.h: Add default implementations of accessors. (WebCore::InputType::innerBlockElement): (WebCore::InputType::innerTextElement): (WebCore::InputType::innerSpinButtonElement): (WebCore::InputType::outerSpinButtonElement): (WebCore::InputType::resultsButtonElement): (WebCore::InputType::cancelButtonElement): (WebCore::InputType::speechButtonElement):
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): Initializes new data members. (WebCore::SearchInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
  • html/SearchInputType.h: Add declarations. (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initializes new data members. (WebCore::TextFieldInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
  • html/TextFieldInputType.h: Add declarations. (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::outerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Remove shadowParent parameter. It is unnecessary because we switch to new shadow model. (WebCore::TextControlInnerElement::create): Change the parameter type to Document. (WebCore::TextControlInnerElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerBlockStyle(). (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): Remove shadowParent parameter. Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter. (WebCore::TextControlInnerTextElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createInnerTextStyle(). (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldResultsButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createResultButtonStyle(). (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): Inherit HTMLDivElement, not TextControlInnerElement. (WebCore::SearchFieldCancelButtonElement::styleForRenderer): Override this in order to set style by RenderTextControlSingleLine::createCancelButtonStyle(). (WebCore::SearchFieldCancelButtonElement::detach): Update for the parent class change. (WebCore::SpinButtonElement::SpinButtonElement):
    • Change the parameter type: shadowParent -> Document
    • Add the inner flag
    • Inherit HTMLDivElement, not TextControlInnerElement.

(WebCore::SpinButtonElement::createInner): Introduce a new factory

method to hide a bool parameter of the constructor.

(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().

(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):

  • Change the parameter type: shadowParent -> Document
  • Inherit HTMLDivElement, not TextControlInnerElement.
  • Do not register this as a speech input listener here.

(WebCore::InputFieldSpeechButtonElement::create):

Update for the parameter change.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Do not handle click event if listener registration is not done.

(WebCore::InputFieldSpeechButtonElement::attach):

Register this as a speech input listener.

(WebCore::InputFieldSpeechButtonElement::detach):

Update for the parent class change.

(WebCore::InputFieldSpeechButtonElement::styleForRenderer):

Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().

  • html/shadow/TextControlInnerElements.h: (WebCore::TextControlInnerTextElement::isMouseFocusable): Add this because the class is not a subclass of TextControllInnerElement. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto. (WebCore::SpinButtonElement::isMouseFocusable): ditto. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code. (WebCore::RenderTextControl::styleDidChange): innerTextElement can have no renderer. Explicitly call setNeedsStyleRecals() for innerTextElement. It is needed for LayoutTests/editing/selection/select-across-readonly-input-*.html. (WebCore::RenderTextControl::textBlockWidth): Member data -> function (WebCore::RenderTextControl::updateFromElement): ditto. (WebCore::RenderTextControl::setInnerTextValue): ditto. (WebCore::RenderTextControl::hasVisibleTextArea): ditto. (WebCore::RenderTextControl::isSelectableElement): ditto. (WebCore::RenderTextControl::selection): ditto. (WebCore::RenderTextControl::visiblePositionForIndex): ditto. (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::text): ditto. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::computeLogicalHeight): ditto. (WebCore::RenderTextControl::hitInnerTextElement): ditto. (WebCore::RenderTextControl::forwardEvent): ditto. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
  • rendering/RenderTextControl.h:
    • Make m_innerText virtual function.
    • Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::innerTextElement): Added. (WebCore::RenderTextControlMultiLine::updateFromElement): Remove unnecessary createSubtreeIfNeeded() call.
  • rendering/RenderTextControlMultiLine.h: Add a declaration.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): Remove unnecessary code. (WebCore::RenderTextControlSingleLine::innerTextElement): Added. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto. (WebCore::RenderTextControlSingleLine::layout): ditto. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto. (WebCore::RenderTextControlSingleLine::updateFromElement): ditto, and remove unnecessary createSubtreeIfNeeded() call. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Data member -> function (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
  • rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.
2:42 AM Changeset in webkit [87013] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

AudioBufferSourceNode noteOff() method must respect scheduling time
https://bugs.webkit.org/show_bug.cgi?id=61226

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::finish): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff):
  • webaudio/AudioBufferSourceNode.h:
1:47 AM Changeset in webkit [87012] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-21 Kent Tamura <tkent@chromium.org>

[Mac] Add expectation files for box-shadow-and-border-radius.html.

  • platform/mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Added.

May 20, 2011:

11:44 PM Changeset in webkit [87011] by krit@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Share more code in PathTraversalState
https://bugs.webkit.org/show_bug.cgi?id=61238

Share more code between SVGPathTraversalStateBuilder and Path in PathTraversalState.

No change in functionality, so no new tests.

  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction):
  • platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::processSegment):
  • platform/graphics/PathTraversalState.h:
  • svg/SVGPathTraversalStateBuilder.cpp: (WebCore::SVGPathTraversalStateBuilder::continueConsuming):
11:15 PM Changeset in webkit [87010] by Nikolas Zimmermann
  • 126 edits in trunk/Source/WebCore

2011-05-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG svgAttributeChanged/synchronizeProperty/parseMappedAttribute should be optimized
https://bugs.webkit.org/show_bug.cgi?id=61183

Example: rect.x.baseVal.value = 100;
What happens: SVGRectElement::svgAttributeChanged(const QualifiedName& attrName) is invoked with "SVGNames::rectAttr" as parameter.

void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
{

SVGStyledTransformableElement::svgAttributeChanged(attrName);
Handle my own attribute changes...

}

Currently we always traverse the base class hierarchy, when invoking svgAttributeChanged. Every svgAttributeChanged call from a class
like SVGRectElement has to reach the base class SVGStyledElement::svgAttributeChanged, as it handles invalidation of the instances of
an element. Say that a <rect> is referenced by a <use> and we change the 'x' attribute of the <rect>, then SVGStyledElement::svgAttributeChanged,
calls SVGElementInstance::invalidateAllInstancesOfElement(this), so that the <use> can rebuild its shadow tree...
That's the only reason all svgAttributeChanged implementations call the base class immediately, so SVGStyledElement is always reached.

Switch to a more efficient pattern, by providing a "bool isSupportedAttribute(const QualifiedName&);" function for all SVG*Elements.
It contains all attributes the particular SVG*Element class handles (but not its parent classes attributes). For example SVGRectElement
contains x/y/width/height/rx/ry attributes, and the ones from SVGTests/SVGLangSpace/SVGExternalResourcesRequired (xml:space/lang, etc.),
but not eg. transform as that's handled by the parent class SVGStyledTransformableElement.

void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
{

if (!isSupportedAttribute.contains(attrName)) {

SVGStyledTransformableElement::svgAttributeChanged(attrName);
return;

}

When we get here, we know for sure it's one of our attributes that has changed.
Note for eg. SVGNames::transformAttr, the call from SVGRectElement::svgAttributeChanged, would be immediately forwarded to the base class, which handles transformAttr changes)

if (attrName == SVGNames::xAttr) { do_work(); return; }
if (attrName == SVGNames::yAttr) { do_work(); return; }
...
Assure that we handled all properties we claim support for in "isSupportedAttribute()".
ASSERT_NOT_REACHED();

}

Exactly the same pattern can be applied to synchronizeProperty and parseMappedAttribute to speed them up as well.

Add "SVGElementInstance::InvalidationGuard guard(this)" statements in all svgAttributeChanged implementations, that calls invalidateAllInstancesOfElement(this)
upon destruction, after we've reacted to the svg attribute change. This assures we never forget to call the invalidation method anywhere, and don't
need to rely on the base class svgAttributeChanged() call to do it.


It's a slight overal performance progression.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::isSupportedAttribute): (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::svgAttributeChanged): (WebCore::SVGAElement::synchronizeProperty):
  • svg/SVGAElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::isSupportedAttribute): (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::isSupportedAttribute): (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isSupportedAttribute): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::isSupportedAttribute): (WebCore::SVGCircleElement::parseMappedAttribute): (WebCore::SVGCircleElement::svgAttributeChanged): (WebCore::SVGCircleElement::synchronizeProperty):
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::isSupportedAttribute): (WebCore::SVGClipPathElement::parseMappedAttribute): (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::synchronizeProperty):
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::isSupportedAttribute): (WebCore::SVGCursorElement::parseMappedAttribute): (WebCore::SVGCursorElement::svgAttributeChanged): (WebCore::SVGCursorElement::synchronizeProperty):
  • svg/SVGCursorElement.h:
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::InvalidationGuard::InvalidationGuard): (WebCore::SVGElementInstance::InvalidationGuard::~InvalidationGuard):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::isSupportedAttribute): (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::synchronizeProperty):
  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp: (WebCore::SVGExternalResourcesRequired::addSupportedAttributes):
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::isSupportedAttribute): (WebCore::SVGFEBlendElement::parseMappedAttribute): (WebCore::SVGFEBlendElement::svgAttributeChanged): (WebCore::SVGFEBlendElement::synchronizeProperty):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::isSupportedAttribute): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::svgAttributeChanged): (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::isSupportedAttribute): (WebCore::SVGFEComponentTransferElement::parseMappedAttribute): (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::isSupportedAttribute): (WebCore::SVGFECompositeElement::parseMappedAttribute): (WebCore::SVGFECompositeElement::svgAttributeChanged): (WebCore::SVGFECompositeElement::synchronizeProperty):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute): (WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::isSupportedAttribute): (WebCore::SVGFEDropShadowElement::parseMappedAttribute): (WebCore::SVGFEDropShadowElement::svgAttributeChanged): (WebCore::SVGFEDropShadowElement::synchronizeProperty):
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute): (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::isSupportedAttribute): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::svgAttributeChanged): (WebCore::SVGFEImageElement::synchronizeProperty):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::isSupportedAttribute): (WebCore::SVGFELightElement::parseMappedAttribute): (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::synchronizeProperty):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::isSupportedAttribute): (WebCore::SVGFEMergeNodeElement::parseMappedAttribute): (WebCore::SVGFEMergeNodeElement::svgAttributeChanged): (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::isSupportedAttribute): (WebCore::SVGFEMorphologyElement::parseMappedAttribute): (WebCore::SVGFEMorphologyElement::svgAttributeChanged): (WebCore::SVGFEMorphologyElement::synchronizeProperty):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::isSupportedAttribute): (WebCore::SVGFEOffsetElement::parseMappedAttribute): (WebCore::SVGFEOffsetElement::svgAttributeChanged): (WebCore::SVGFEOffsetElement::synchronizeProperty):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::isSupportedAttribute): (WebCore::SVGFESpecularLightingElement::parseMappedAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::isSupportedAttribute): (WebCore::SVGFETileElement::parseMappedAttribute): (WebCore::SVGFETileElement::svgAttributeChanged): (WebCore::SVGFETileElement::synchronizeProperty):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::isSupportedAttribute): (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged): (WebCore::SVGFETurbulenceElement::synchronizeProperty):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::isSupportedAttribute): (WebCore::SVGFilterElement::parseMappedAttribute): (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::synchronizeProperty):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute): (WebCore::SVGFilterPrimitiveStandardAttributes::parseMappedAttribute): (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged): (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseMappedAttribute): (WebCore::SVGFitToViewBox::synchronizeProperties): (WebCore::SVGFitToViewBox::addSupportedAttributes):
  • svg/SVGFitToViewBox.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::isSupportedAttribute): (WebCore::SVGForeignObjectElement::parseMappedAttribute): (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::synchronizeProperty):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::isSupportedAttribute): (WebCore::SVGGElement::parseMappedAttribute): (WebCore::SVGGElement::svgAttributeChanged): (WebCore::SVGGElement::synchronizeProperty):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::isSupportedAttribute): (WebCore::SVGGradientElement::parseMappedAttribute): (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::synchronizeProperty):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::isSupportedAttribute): (WebCore::SVGImageElement::parseMappedAttribute): (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::synchronizeProperty):
  • svg/SVGImageElement.h:
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::addSupportedAttributes):
  • svg/SVGLangSpace.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::isSupportedAttribute): (WebCore::SVGLineElement::parseMappedAttribute): (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::synchronizeProperty):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::isSupportedAttribute): (WebCore::SVGLinearGradientElement::parseMappedAttribute): (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::synchronizeProperty):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::isSupportedAttribute): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::synchronizeProperty):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::isSupportedAttribute): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::synchronizeProperty):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::isSupportedAttribute): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::synchronizeProperty):
  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::isSupportedAttribute): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::svgAttributeChanged): (WebCore::SVGPathElement::synchronizeProperty):
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::isSupportedAttribute): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::synchronizeProperty):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::isSupportedAttribute): (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::isSupportedAttribute): (WebCore::SVGRadialGradientElement::parseMappedAttribute): (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::synchronizeProperty):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::isSupportedAttribute): (WebCore::SVGRectElement::parseMappedAttribute): (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::synchronizeProperty):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::synchronizeProperty):
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::isSupportedAttribute): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::svgAttributeChanged): (WebCore::SVGScriptElement::synchronizeProperty):
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::isSupportedAttribute): (WebCore::SVGStopElement::parseMappedAttribute): (WebCore::SVGStopElement::svgAttributeChanged): (WebCore::SVGStopElement::synchronizeProperty):
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::isSupportedAttribute): (WebCore::SVGStyleElement::parseMappedAttribute):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::synchronizeProperty):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isSupportedAttribute): (WebCore::SVGStyledTransformableElement::parseMappedAttribute): (WebCore::SVGStyledTransformableElement::svgAttributeChanged): (WebCore::SVGStyledTransformableElement::synchronizeProperty):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::isSupportedAttribute): (WebCore::SVGSymbolElement::parseMappedAttribute): (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::synchronizeProperty):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::isSupportedAttribute): (WebCore::SVGTRefElement::parseMappedAttribute): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::synchronizeProperty):
  • svg/SVGTRefElement.h:
  • svg/SVGTests.cpp: (WebCore::SVGTests::addSupportedAttributes):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isSupportedAttribute): (WebCore::SVGTextContentElement::parseMappedAttribute): (WebCore::SVGTextContentElement::synchronizeProperty): (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::isSupportedAttribute): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::synchronizeProperty):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::isSupportedAttribute): (WebCore::SVGTextPathElement::parseMappedAttribute): (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::synchronizeProperty):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::isSupportedAttribute): (WebCore::SVGTextPositioningElement::parseMappedAttribute): (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::SVGTextPositioningElement::synchronizeProperty):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTransformable.cpp:
  • svg/SVGTransformable.h:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::addSupportedAttributes):
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::isSupportedAttribute): (WebCore::SVGUseElement::parseMappedAttribute): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::synchronizeProperty):
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::isSupportedAttribute): (WebCore::SVGViewElement::parseMappedAttribute): (WebCore::SVGViewElement::synchronizeProperty):
  • svg/SVGViewElement.h:
  • svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::addSupportedAttributes):
  • svg/SVGZoomAndPan.h:
9:20 PM Changeset in webkit [87009] by Simon Fraser
  • 4 edits
    3 adds in trunk

2011-05-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Allow ShadowBlur to do tiling when the context is scaled
https://bugs.webkit.org/show_bug.cgi?id=61232

If the GraphicsContext is scaled or rotated by a multiple of 90deg, have ShadowBlur
use the tiling code path, to avoid blurring large areas on pages like cracked.com
when the context is scaled.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawRectShadow): Call preservesAxisAlignment() to decide when to not use tiling. (WebCore::ShadowBlur::drawInsetShadow): Ditto. (WebCore::ShadowBlur::drawLayerPieces): Round to device pixels when drawing tiles to avoid pixel cracks in scaled contexts.
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::preservesAxisAlignment): Return true if there is the matrix contains a transform that results in axis alignment (no rotation or skew, or rotations which are multiples of 90deg).
6:15 PM Changeset in webkit [87008] by ap@apple.com
  • 6 edits
    2 adds in trunk

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Kent Tamura.

Special characters can be inserted in text field having reached maxlength
https://bugs.webkit.org/show_bug.cgi?id=19479
<rdar://problem/7828739>

  • platform/mac/editing/input/maxlength-expected.txt: Added.
  • platform/mac/editing/input/maxlength.html: Added.
  • fast/forms/input-number-commit-valid-only-expected.txt:
  • fast/forms/script-tests/input-number-commit-valid-only.js: The user can make a number field empty by deleting its content, so there is no reason why execCommand shouldn't be able to make it empty.

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Kent Tamura.

Special characters can be inserted in text field having reached maxlength
https://bugs.webkit.org/show_bug.cgi?id=19479
<rdar://problem/7828739>

Test: platform/mac/editing/input/maxlength.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertTextIntoNode): (WebCore::CompositeEditCommand::replaceTextInNode): Avoid hitting an assertion below, now that we can get here with empty text.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): There is still work to do even if beforetextinput removed all text from the event. At the very least, we should delete the current selection.
6:07 PM Changeset in webkit [87007] by aestes@apple.com
  • 5 edits in trunk

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
https://bugs.webkit.org/show_bug.cgi?id=61229

Test that an object element with a non-empty classid, a valid MIME
type and no fallback content is allowed to load.

  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html:

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
https://bugs.webkit.org/show_bug.cgi?id=61229

Podcast Producer uses an object tag with a classid attribute to embed
QuickTime Player into a page. In r70748, we changed our behavior to
render the object's fallback content when a non-empty classid is
encountered, per HTML5. Since Podcast Producer videos have no fallback
content, this change in behavior causes the video to fail to load.

Since the object tag has a valid type attribute, we would be able to
load it if weren't for the non-empty classid. This patch changes our
policy to allow objects with non-empty classids if there is no fallback
content. We still continue to prefer fallback content if it exists,
however.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): Treat a non-empty classid as valid if the object has no fallback content.
5:52 PM Changeset in webkit [87006] by jchaffraix@webkit.org
  • 4 edits
    5 adds in trunk

2011-05-20 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by Simon Fraser.

If both border-radius and box-shadow applied, shadow is not fully visible
https://bugs.webkit.org/show_bug.cgi?id=59577

  • fast/css/box-shadow-and-border-radius.html: Added.
  • platform/qt/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/qt/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/win/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Added.

2011-05-20 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by Simon Fraser.

If both border-radius and box-shadow applied, shadow is not fully visible
https://bugs.webkit.org/show_bug.cgi?id=59577

The current implementation of RoundedIntRect::inflateWithRadii() inflates
its rect size and corner radii out of sync. This leads to validation failure in
Path::addRoundedRect() and results in ignoring radii in the path.
When this invalid path is used to clip out the rounded corner box before painting
the box shadow, the entire rectangle is clipped out without the corner radii.

This patch implements RoundedIntRect::inflateWithRadii() properly to inflate
rounded rect radii based on inflate ratios of rect size.

Test: fast/css/box-shadow-and-border-radius.html

  • platform/graphics/RoundedIntRect.cpp: (WebCore::RoundedIntRect::inflateWithRadii):
  • platform/graphics/RoundedIntRect.h:
5:48 PM Changeset in webkit [87005] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Mark Rowe.

Crash in WebFullScreenManager::didExitFullScreen when closing a window in Safari.
https://bugs.webkit.org/show_bug.cgi?id=61228

Do not attempt to exit full screen if we aren't in full screen to begin with, as the WebProcess
won't be expecting will/didExitFullScreen notifications.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]):
5:42 PM Changeset in webkit [87004] by kbr@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-20 Kenneth Russell <kbr@google.com>

Unreviewed. Manually pulled missing layout test result from Mesa bots.

  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-actual.png: Added.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-actual.png: Added.
5:29 PM Changeset in webkit [87003] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=61224

Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
versions of same.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): (-[WebFullScreenController enterFullscreen:]): (-[WebFullScreenController exitFullscreen]): (-[WebFullscreenWindow setRendererLayer:]):
5:20 PM Changeset in webkit [87002] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Leon Scroggins <scroggo@google.com>

Reviewed by Kenneth Russell.

gpu canvas alpha tests failing on the chromium canaries
https://bugs.webkit.org/show_bug.cgi?id=59768

Remove tests which are now passing from test_expectations.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [87001] by Michael Nordman
  • 9 edits in trunk/Source

2011-05-20 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

[Chromium] Support the new webkit apis so the WebDatabase system participates
in the unified quota management system.
https://bugs.webkit.org/show_bug.cgi?id=60985

No change in functionality, no new tests.

  • platform/chromium/PlatformBridge.h:
  • storage/chromium/QuotaTracker.cpp: (WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin): (WebCore::QuotaTracker::updateDatabaseSize): (WebCore::QuotaTracker::updateSpaceAvailableToOrigin): (WebCore::QuotaTracker::resetSpaceAvailableToOrigin):
  • storage/chromium/QuotaTracker.h:

2011-05-20 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

Changes to allow the WebDatabase system to participate in Chrome's unified quota
management system. Now that changes outside of the database system affect the space
available to the database system, we need new ways of getting the limit to renderers.

Split WebDatabase::updateDatabaseSizeAndSpaceAvailable() into three methods.

  • WebDatabase::updateDatababaseSize()
  • WebDatabase::updateSpaceAvailable()
  • WebDatabase::resetSpaceAvailable() The WebDatabase methods are used to 'push' size and space available info into renderers. The space available can change independently of a database having changed size.

Also provide a means for the renderer to 'pull' the space available from the main
process if that value has not been pushed into it.

  • WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin()
  • WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin()

https://bugs.webkit.org/show_bug.cgi?id=60985

  • public/WebDatabase.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
  • src/WebDatabase.cpp: (WebKit::WebDatabase::updateDatabaseSize): (WebKit::WebDatabase::updateSpaceAvailable): (WebKit::WebDatabase::resetSpaceAvailable):
4:38 PM Changeset in webkit [87000] by bfulgham@webkit.org
  • 8 edits in trunk/Source/WebKit/win

Implement the ability to add C++ event listeners to html dom
elements and dom window.
https://bugs.webkit.org/show_bug.cgi?id=60269

Patch by Anthony Johnson <anthony.johnson@flexsim.com> on 2011-05-18
Reviewed by Brent Fulgham.

  • DOMCoreClasses.cpp: Add new DOMWindow class and implementations.

(DOMNode::QueryInterface): Report that the DOMNode implements

the IDomEventTarget interface.

(DOMNode::addEventListener): Add implementation of a COM-based

event listener.

(DOMNode::removeEventListener):
(DOMNode::dispatchEvent):
(DOMDocument::createInstance):
(DOMWindow::QueryInterface): New implementation.
(DOMWindow::document): New implementation.
(DOMWindow::getComputedStyle): Stub.
(DOMWindow::getMatchedCSSRules): Stub.
(DOMWindow::devicePixelRatio): Stub.
(DOMWindow::addEventListener): New implementation.
(DOMWindow::removeEventListener): New implementation.
(DOMWindow::dispatchEvent): New implementation.
(DOMWindow::DOMWindow): New implementation.
(DOMWindow::~DOMWindow): New implementation.
(DOMWindow::createInstance): New implementation.

  • DOMCoreClasses.h: Add new DOMWindow class and declarations.

(DOMWindow::AddRef): New declaration.
(DOMWindow::Release): New declaration.
(DOMWindow::throwException): New declaration.
(DOMWindow::callWebScriptMethod): New declaration.
(DOMWindow::evaluateWebScript): New declaration.
(DOMWindow::removeWebScriptKey): New declaration.
(DOMWindow::stringRepresentation): New declaration.
(DOMWindow::webScriptValueAtIndex): New declaration.
(DOMWindow::setWebScriptValueAtIndex): New declaration.
(DOMWindow::setException): New declaration.
(DOMWindow::window): New declaration.

  • DOMEventsClasses.cpp: Add new WebEventListener and implementation.

(DOMEventListener::handleEvent): New implementation.
(WebEventListener::WebEventListener): New implementation.
(WebEventListener::~WebEventListener): New implementation.
(WebEventListener::operator==): New implementation.
(WebEventListener::handleEvent): New implementation.
(WebEventListener::create): New implementation.

  • DOMEventsClasses.h: Add new WebEventListener class declaration.
  • Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the main Web Frame interface.
  • WebFrame.cpp: Add implementation of new DOMWindow creation method.

(WebFrame::DOMWindow):

  • WebFrame.h: Add DOMWindow declaration.
4:20 PM Changeset in webkit [86999] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Reduce size of inline cache path of get_by_id on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=61221

This reduces the code size of get_by_id by 20 bytes

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::ldrCompact): (JSC::ARMv7Assembler::repatchCompact): (JSC::ARMv7Assembler::setUInt7ForLoad):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):
  • jit/JIT.h:
4:13 PM Changeset in webkit [86998] by ap@apple.com
  • 2 edits in trunk/Websites/webkit.org

2011-05-20 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

Building instructions should not talk about Tiger
https://bugs.webkit.org/show_bug.cgi?id=61210

  • building/tools.html: Removed steps that are only necessary on Tiger, and changed required Xcode version to the latest Leopard one.
3:59 PM Changeset in webkit [86997] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations exception for:
svg/W3C-SVG-1.1-SE/struct-use-14-f.svg

  • platform/chromium/test_expectations.txt:
3:56 PM Changeset in webkit [86996] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

3:51 PM Changeset in webkit [86995] by aestes@apple.com
  • 9 edits
    1 add in trunk/Source

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

No test possible via DRT. Add a manual test instead.

  • manual-tests/full-screen-keypress.html: Added.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • WebKit.xcodeproj/project.pbxproj: Export WebNSWindowExtras.h as a private header so that WebKit2 can include it.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a convenience method to NSWindow that makes the given NSResponder first responder only if it is a descendant of the given view.
  • WebView/WebFullScreenController.mm: (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView was a descendant of the browser window's first responder when entering full-screen mode, set the full-screen window's first responder to that same NSResponder. (-[WebFullScreenController exitFullscreen]): Do the reverse of what is done in windowDidEnterFullscreen:.

2011-05-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

WebView loses firstResponder status when entering full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=61153

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): If the WebView was a descendant of the browser window's first responder when entering full-screen mode, set the full-screen window's first responder to that same NSResponder. (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Do the reverse of what is done in finishedEnterFullScreenAnimation:.
3:47 PM Changeset in webkit [86994] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

3:43 PM Changeset in webkit [86993] by Lucas Forschler
  • 1 copy in tags/Safari-534.37

New tag.

3:36 PM Changeset in webkit [86992] by jer.noble@apple.com
  • 10 edits in trunk/Source

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Exit full screen mode if the WebProcess crashes.
https://bugs.webkit.org/show_bug.cgi?id=61151

  • platform/graphics/win/FullScreenController.h:
  • platform/graphics/win/FullScreenController.cpp: (FullScreenController::close): Added. Close the full-screen window without animation

if called.

2011-05-20 Jeremy Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

WebKit2: Exit full screen mode if the WebProcess crashes.
https://bugs.webkit.org/show_bug.cgi?id=61151

If the WebProcess crashes, exit full-screen mode to avoid getting stuck. Move the
WebFullScreenManagerProxy::invalidate() implementation into the platform-specific
files, and have them close their respective platform's full-screen window.

  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp: (WebKit::WebFullScreenManagerProxy::invalidate): Added. Copied from main implementation.
  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Added.
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate): Added.
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: (WebKit::WebFullScreenManagerProxy::invalidate): Added.
3:34 PM Changeset in webkit [86991] by Lucas Forschler
  • 1 move in branches/safari-534-branch

rename branch.

3:31 PM Changeset in webkit [86990] by andersca@apple.com
  • 9 edits
    17 deletes in trunk/Source/WebKit2

2011-05-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove the chunked update drawing area
https://bugs.webkit.org/show_bug.cgi?id=61216

The chunked update drawing area is no longer used in any port, so remove all traces of it.

Qt still uses UpdateChunks for the tiled drawing area so keep the Shared/qt/UpdateChunk.* classes for now.

  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • Shared/gtk/UpdateChunk.cpp: Removed.
  • Shared/gtk/UpdateChunk.h: Removed.
  • Shared/mac/UpdateChunk.cpp: Removed.
  • Shared/mac/UpdateChunk.h: Removed.
  • Shared/win/UpdateChunk.cpp: Removed.
  • Shared/win/UpdateChunk.h: Removed.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: Removed.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed.
  • UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Removed.
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: Removed.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Removed.
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: Removed.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::paint): (WebKit::WebView::createDrawingAreaProxy): (WebKit::WebView::enterAcceleratedCompositingMode): (WebKit::WebView::exitAcceleratedCompositingMode):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: Removed.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Removed.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp: Removed.
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Removed.
  • WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: Removed.
  • win/WebKit2.vcproj:
3:29 PM Changeset in webkit [86989] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Rebaselines after r86983.

  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
3:26 PM Changeset in webkit [86988] by enrica@apple.com
  • 10 edits in trunk/Source

Add delegate methods about focus and blur to all elements.
https://bugs.webkit.org/show_bug.cgi?id=61218

Reviewed by David Kilzer.

Source/WebCore:

We want to have delegates for these events for all the elements, not only the form elements.
The patch moves the call to the delegate in the Node class and changes the name
of the methods not to be form element specific.

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent): Added call to delegate with the new name.
(WebCore::Node::dispatchBlurEvent): Added call to delegate with the new name.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchBlurEvent): Removed code that calls the delegate since
it has been moved into Node.

  • html/HTMLFormControlElement.h: Removed dispatchFocusEvent, since we are using the default inplementation in Node.
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::elementDidFocus): Name changed.
(WebCore::EmptyChromeClient::elementDidBlur): Name changed.

  • page/ChromeClient.h:

(WebCore::ChromeClient::elementDidFocus): Name changed.
(WebCore::ChromeClient::elementDidBlur): Name changed.

Source/WebKit/mac:

We want to have delegates for these events for all the elements, not only the form elements.
The patch changes the name of the methods in a way that is not form element specific.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::elementDidFocus):
(WebChromeClient::elementDidBlur):

  • WebView/WebUIDelegatePrivate.h:
3:18 PM Changeset in webkit [86987] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectations update.

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [86986] by scherkus@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-20 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in baselines for media/media-document-audio-repaint.html for chromium-{mac,linux,win}.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
2:40 PM Changeset in webkit [86985] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-20 Matthew Delaney <mdelaney@apple.com>

Reviewed by Steve Falkenburg.

Default min DOM Timer interval is not set soon enough for first page to pick it up in WK2
https://bugs.webkit.org/show_bug.cgi?id=61215

  • WebProcess/WebPage/WebPage.cpp: Simply moving the DOM min timer interval setting to before the first page creation.
2:28 PM Changeset in webkit [86984] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectaions update.

  • platform/chromium/test_expectations.txt:
2:23 PM Changeset in webkit [86983] by rniwa@webkit.org
  • 18 edits in trunk

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Wrap copied contents by one style span instead of two
https://bugs.webkit.org/show_bug.cgi?id=60988

Rebaselined tests due to the change in how WebKit preserves style in copy and paste.

  • editing/pasteboard/4930986-2-expected.txt: Whitespace change.
  • editing/pasteboard/5065605-expected.txt: No longer adds redundant inline style declaration.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Progression; Now we hit the list merging logic in ReplaceSelectionCommand: isStyleSpan(refNode.get()) && isListElement(refNode->firstChild()).
  • editing/pasteboard/paste-list-001-expected.txt: Ditto.
  • editing/pasteboard/paste-text-011-expected.txt: An extra style span was added.
  • editing/pasteboard/paste-text-012-expected.txt: Ditto.
  • editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: No longer adds redundant style span.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: No longer adds empty anonymous nodes.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Ditto.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Ditto.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Ditto.

2011-05-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

Wrap copied contents by one style span instead of two
https://bugs.webkit.org/show_bug.cgi?id=60988

Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by one wrapping style span. Instead
of wrapping the copied contents by user-applied style and document default style in serialization,
take the difference with the document default's style in paste code.

This will dramatically simplify our copy and paste code and pave a way to fix the bug 60914.

No new tests because copy & paste is tested by existing layout tests.

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::prepareToApplyAt): Remove the color property if RGBA values of color matches that of the computed style at the specified position.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans): Replaced sourceDocumentStyleSpan and copiedRangeStyleSpan by wrappingStyleSpan. When pasting as a quotation, compare style against the document's default style to avoid keeping the document default style (tested by editing/pasteboard/4930986-3.html).
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::createMarkup): Only use one style span to wrap the serialized contents.
2:12 PM Changeset in webkit [86982] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Chromium expectaions update.

  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [86981] by Simon Fraser
  • 19 edits in trunk

2011-05-20 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

numberOfActiveAnimations() can include animations from documents in the page cache
https://bugs.webkit.org/show_bug.cgi?id=53641

Some transition tests using layoutTestController.numberOfActiveAnimations() failed
in WebKit2 because numberOfActiveAnimations() could include those from other documents
in the page cache.

Fix by passing in the document for which we wish to count animations.

  • WebCore.exp.in:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::numberOfActiveAnimations): (WebCore::AnimationController::numberOfActiveAnimations):
  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
1:58 PM Changeset in webkit [86980] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Factor CORS request preparation out of DocumentThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=61209

DocumentThreadableLoader has two jobs:

1) Proxy loads between threads.
2) Run the CORS state machine.

This patch begins the work of separating those concerns, allowing CORS
to be used elsewhere in the loading pipeline. In particular, this
patch moves knowledge of how to prepare CORS requests out of
DocumentThreadableLoder.

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::updateRequestForAccessControl): (WebCore::createAccessControlPreflightRequest):
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
1:11 PM Changeset in webkit [86979] by krit@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-20 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of Qt. One of the two tests doesn't even need a platform specific result anymore.

SVGPathSegList needs better getTotalLength, getSegmentAtLength path traversal code
https://bugs.webkit.org/show_bug.cgi?id=12047

  • platform/qt/svg/custom/path-getTotalLength-expected.txt: Removed.
  • platform/qt/svg/custom/path-textPath-simulation-expected.txt:
12:53 PM Changeset in webkit [86978] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk

2011-05-20 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60844

When an id changes on an in-document element, we need to check whether the id
is part of the pending elements. Since this is the same thing as happens in
insertedIntoDocument, split out the common code into buildPendingResourcesIfNeeded.

Test: svg/W3C-SVG-1.1-SE/struct-use-14-f.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
  • svg/SVGStyledElement.h:

2011-05-20 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Use test from ietestcenter fails
https://bugs.webkit.org/show_bug.cgi?id=60844

  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/struct-use-14-f.svg: Added.
12:43 PM Changeset in webkit [86977] by Simon Fraser
  • 11 edits in trunk

2011-05-20 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42550

Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Copy the code for pausing animations, FIXME comments and all. (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-05-20 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42550

Plumb through methods to pause a transition of a given property on an element.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFramePauseAnimationOnElementWithId): (WKBundleFramePauseTransitionOnElementWithId):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::pauseTransitionOnElementWithId):
  • WebProcess/WebPage/WebFrame.h:
12:36 PM Changeset in webkit [86976] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Tests that we do not crash when auto-focus triggers a attach.
https://bugs.webkit.org/show_bug.cgi?id=32882

  • fast/forms/input-element-attach-crash-expected.txt: Added.
  • fast/forms/input-element-attach-crash.html: Added.

2011-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Make auto-focus a post attach callback in
HTMLFormControlElement::attach().
https://bugs.webkit.org/show_bug.cgi?id=32882

Original patch by Darin Adler. This one uses a part of it.


Test: fast/forms/input-element-attach-crash.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is already false by the time post-attach callbacks are done so that layout triggered inside those callbacks can work properly.
  • html/HTMLFormControlElement.cpp: (WebCore::shouldAutofocus): Helper function that expresses the rule for which form control elements should auto-focus. (WebCore::focusPostAttach): Called post-attach to focus an element if we discover it should be focused during attach. (WebCore::HTMLFormControlElement::attach): Refactored code for which elements need auto-focus into a separate function. Instead of focusing right away, use the focusPostAttach function to focus after attach is done. Also added calls to suspendPostAttachCallbacks and resumePostAttachCallbacks so post-attach callbacks happen late enough. Before, they could run inside the base attach function.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Added calls to suspendPostAttachCallbacks and resumePostAttachCallbacks so post-attach callbacks happen late enough
12:28 PM Changeset in webkit [86975] by alokp@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-20 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Remove LayerRendererChromium::useShader
https://bugs.webkit.org/show_bug.cgi?id=61143

GPU compositor tests should be sufficient.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::drawDebugBorder):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::drawYUV): (WebCore::CCVideoLayerImpl::drawRGBA):
12:06 PM Changeset in webkit [86974] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

2011-05-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Zombies should "live" forever
https://bugs.webkit.org/show_bug.cgi?id=61170

Reusing zombie cells could still hide garbage
collected cell related bugs.

  • JavaScriptCore.pro:
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::clearMarks):
  • heap/MarkedBlock.h:
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::isZombie):
  • runtime/JSZombie.h: (JSC::JSZombie::~JSZombie):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):
12:04 PM Changeset in webkit [86973] by krit@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVGPathSegList needs better getTotalLength, getSegmentAtLength path traversal code
https://bugs.webkit.org/show_bug.cgi?id=12047

Right now SVGPathElement::getTotalLength and SVGPathElement::getPointAtLength use toPathData()
to transform a SVGPathByteStream to a Path. This Path gets traversed to find the searched value.
With this patch both functions use the SVGPathByteStream directly together with the existing
traversing code in SVG. This avoids the intermediate transforming to a platform path and gives
platform independent results.
The traversal code in SVG needed to be extended to support all PathTraversalActions.

No new tests added. The existing tests cover the changes.

  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::getTotalLengthOfSVGPathByteStream): (WebCore::SVGPathParserFactory::getPointAtLengthOfSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathTraversalStateBuilder.cpp: (WebCore::SVGPathTraversalStateBuilder::continueConsuming): (WebCore::SVGPathTraversalStateBuilder::totalLength): (WebCore::SVGPathTraversalStateBuilder::currentPoint):
  • svg/SVGPathTraversalStateBuilder.h:
11:56 AM SVG TODO List - Short notes edited by rwlbuis@webkit.org
Bugs are fixed, removing (diff)
11:53 AM SVG TODO List - Short notes edited by rwlbuis@webkit.org
All bugs in this section are fixed (diff)
11:46 AM Changeset in webkit [86972] by beidson@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/9472883> and https://bugs.webkit.org/show_bug.cgi?id=61203
Horrendous bug in callOnMainThreadAndWait

Reviewed by Sam Weinig.

  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread): Before signaling the background thread with the

syncFlag condition, reacquire the mutex first.

11:39 AM Changeset in webkit [86971] by kerz@chromium.org
  • 2 edits in branches/chromium/742/Source/WebCore

Revert 86910 - 2011-05-19 James Robinson <jamesr@chromium.org>

This caused chromium beta builders to fail on all platforms.

https://bugs.webkit.org/show_bug.cgi?id=61159

Add a speculative null check to see if it reduces the crashrate.

http://code.google.com/p/chromium-os/issues/detail?id=15377

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/7054014

11:32 AM WebCoreRendering edited by rwlbuis@webkit.org
Fix typo (diff)
11:30 AM Changeset in webkit [86970] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-20 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=58465

  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/create-objectstore-null-name.html: Added.

2011-05-20 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB createObjectStore should throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=58465

Test: storage/indexeddb/mozilla/create-objectstore-null-name.html

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore):
11:23 AM Changeset in webkit [86969] by alokp@chromium.org
  • 2 edits in trunk/Tools

2011-05-20 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
11:20 AM Changeset in webkit [86968] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Remove unnecessary double->int conversion at the end of op_div
https://bugs.webkit.org/show_bug.cgi?id=61198

We don't attempt this conversion on 64bit, removing it actually speeds
up sunspider and v8 slightly, and it reduces code size.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_div):
11:18 AM Changeset in webkit [86967] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Media files cannot be saved in the Application Cache due to a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=61199

Instead of using a sandbox extension to give permission to the application cache directory,
initialize the sandbox with access to it like we do for other databases.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
10:45 AM Changeset in webkit [86966] by xji@chromium.org
  • 5 edits in trunk

2011-05-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

ctrl-arrow does not work on words separated by multiple spaces.
https://bugs.webkit.org/show_bug.cgi?id=57543.

Add the leftmost boundary of a box in RTL block or the rightmost boundary of a box in LTR
block as word break if its inlineBox is the current box and it is a word break.

  • editing/visible_units.cpp: (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Add the rightmost boundary of a box in LTR block or leftmost boundary of a box in RTL block as visually first word break. (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality): (WebCore::leftWordBoundary): Fix bug change "box" to "adjacentBox". (WebCore::rightWordBoundary): Fix bug change "box" to "adjacentBox".

2011-05-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

ctrl-arrow does not work on words separated by multiple spaces.
https://bugs.webkit.org/show_bug.cgi?id=57543.

Add more test cases for mutiplespaces.

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:
10:20 AM Changeset in webkit [86965] by evan@chromium.org
  • 9 edits in trunk/Source

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • glu/glu.gyp:
  • gyp/test/library/src/library.gyp:

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • WebCore.gyp/WebCore.gyp:

2011-05-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] remove <(library) variable
https://bugs.webkit.org/show_bug.cgi?id=61158

This was for a build experiment; we can just use the correct value now.

  • WebKit.gyp:
9:36 AM Changeset in webkit [86964] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating media/event-attributes.html as passing for Chromium.

  • platform/chromium/test_expectations.txt:
9:25 AM Changeset in webkit [86963] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
9:20 AM Changeset in webkit [86962] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Windows] fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html failing since r86936
https://bugs.webkit.org/show_bug.cgi?id=61190

  • platform/win/Skipped: Skip it because the test uses <progress> and Windows doesn't have <progress> support.
9:20 AM Changeset in webkit [86961] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86958.
http://trac.webkit.org/changeset/86958
https://bugs.webkit.org/show_bug.cgi?id=61195

broke breakpoints persisting (Requested by podivilov on
#webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
9:19 AM Changeset in webkit [86960] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-20 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Interpreter uses wrong bytecode offset for determining exception handler
https://bugs.webkit.org/show_bug.cgi?id=61191

The bytecode offset given for the returnPC from the JIT is
actually the offset for the start of the instruction triggering
the call, whereas in the interpreter it is the actual return
VPC. This means if the next instruction following a call was
in an exception region we would incorrectly redirect to its
handler. Long term we want to completely redo how exceptions
are handled anyway so the simplest and lowest risk fix here is
to simply subtract one from the return vPC so that we have an
offset in the triggering instruction.

It turns out this is caught by a couple of tests already.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
9:15 AM Changeset in webkit [86959] by yurys@chromium.org
  • 14 edits
    7 adds in trunk

2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Background network events collection - add GUI to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=58652

Move reopenFrontend() to inspector-test.js
Add first test for background events collection.

  • http/tests/inspector/inspector-test.js: ():
  • http/tests/inspector/network-test.js: Added. (initialize_NetworkTest.InspectorTest.enableBackgroundEventCollection): (initialize_NetworkTest.InspectorTest.disableBackgroundEventCollection):
  • http/tests/inspector/network/network-clear-after-disabled-expected.txt: Added.
  • http/tests/inspector/network/network-clear-after-disabled.html: Added.
  • http/tests/inspector/network/network-close-load-open-expected.txt: Added.
  • http/tests/inspector/network/network-close-load-open.html: Added.
  • http/tests/inspector/network/network-open-load-reopen-expected.txt: Added.
  • http/tests/inspector/network/network-open-load-reopen.html: Added.
  • inspector/debugger/open-close-open-expected.txt:
  • inspector/debugger/open-close-open.html:
  • platform/qt/Skipped:

2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Background network events collection - add GUI to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=58652

Now in WebInspector Network panel avalaible new checkbox item in context menu:
"Background events collection". It allows to save all network events when inspector
frontend closed. Events that occur before collection enabling are not preserved after
frontend reopening. Property unique for each page. Disabled by default.

Tests: http/tests/inspector/network/network-clear-after-disabled.html

http/tests/inspector/network/network-close-load-open.html
http/tests/inspector/network/network-open-load-reopen.html

  • inspector/EventsCollector.cpp: (WebCore::EventsCollector::clear):
  • inspector/EventsCollector.h:
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: (WebCore::InspectorFrontendProxy::inspectorFrontendChannel):
  • inspector/InspectorFrontendProxy.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::isBackgroundEventsCollectionEnabled): (WebCore::InspectorResourceAgent::setBackgroundEventsCollectionEnabled): (WebCore::InspectorResourceAgent::initializeBackgroundCollection): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._toggleBackgroundEventsCollection):
9:11 AM Changeset in webkit [86958] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
8:55 AM Changeset in webkit [86957] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756

Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel
check of the available memory. This should give us an
overcommit-like behavior in most systems, which is what we want.

  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap.
8:50 AM Changeset in webkit [86956] by jer.noble@apple.com
  • 10 edits in trunk/Source

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

Instead of repainting the full- and non-full-screen windows in WebCore, delegate that
responsibility to the FullScreenControllerClient. Because the repaint operation may
be asynchronous, add a new method for clients to use to indicate repainting has completed.

  • platform/graphics/win/FullScreenController.cpp: (FullScreenController::Private::Private): Added new ivars. (FullScreenController::enterFullScreen): Split into two functions (pre-and post repaint) (FullScreenController::enterFullScreenRepaintCompleted): Ditto. (FullScreenController::exitFullScreen): Ditto. (FullScreenController::exitFullScreenRepaintCompleted): Ditto. (FullScreenController::repaintCompleted): Call the appropriated repaint completed function.
  • platform/graphics/win/FullScreenController.h:
  • platform/graphics/win/FullScreenControllerClient.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

  • WebView.cpp: (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the

full screen controller.

  • WebView.h:

2011-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108

When the fullScreenController asks us to repaint, make an async repaint request, and when the
callback is fired, notify the fullScreenController that repaint has completed.

  • UIProcess/win/WebView.cpp: (WebKit::fullScreenClientForceRepaintCompleted): Added. (WebKit::WebView::fullScreenClientForceRepaint): Added.
  • UIProcess/win/WebView.h:
8:18 AM Changeset in webkit [86955] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use RefPtr instead of OwnPtr to store InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=61188

  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
  • inspector/WorkerInspectorController.h:
8:04 AM Changeset in webkit [86954] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing tests.

  • platform/qt-arm/Skipped:
7:29 AM Changeset in webkit [86953] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

2011-05-20 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Benjamin Poulain.

[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=60372

  • tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail. (tst_QWebElement::style):
7:27 AM Changeset in webkit [86952] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

2011-05-20 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Benjamin Poulain.

[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails. (tst_QDeclarativeWebView::basicProperties): (tst_QDeclarativeWebView::historyNav):
7:19 AM Changeset in webkit [86951] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
https://bugs.webkit.org/show_bug.cgi?id=61045

Reviewed by Benjamin Poulain.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.

7:03 AM Changeset in webkit [86950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Network panel should only show pointer cursor over valid resources
https://bugs.webkit.org/show_bug.cgi?id=55240

Cursor style removed from filler area.

  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid tr:not(.filler) td.name-column):
6:57 AM Changeset in webkit [86949] by pvarga@webkit.org
  • 20 edits in trunk/Source

2011-05-20 Peter Varga <pvarga@webkit.org>

Reviewed by Simon Hausmann.

[Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
https://bugs.webkit.org/show_bug.cgi?id=56649

Use the provided V8 and functionality of
http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
Based on the original patch of Andras Becsi <abecsi@webkit.org>.

No new tests needed.

  • CodeGenerators.pri: Add generating of DebuggerScriptSource.h
  • WebCore.pri: Fix the options for V8 build.
  • WebCore.pro: Ditto.
  • bindings/v8/NPV8Object.cpp: (WebCore::npObjectTypeInfo): Add missing initializer.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::disableEval): Temporarily disable unsupported feature on Qt.
  • bindings/v8/ScriptControllerQt.cpp: (WebCore::ScriptController::qtScriptEngine): use the QtScriptEngine constructor of qtscript-staging.
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Add missing initializer.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.
  • loader/appcache/ApplicationCacheGroup.cpp: Add missing header.
  • loader/cache/CachedResourceRequest.cpp: Ditto.
  • page/PageSerializer.cpp: Ditto.
  • page/qt/FrameQt.cpp: Ditto.
  • storage/StorageEventDispatcher.cpp: Ditto.

2011-05-20 Peter Varga <pvarga@webkit.org>

Reviewed by Simon Hausmann.

[Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
https://bugs.webkit.org/show_bug.cgi?id=56649

Use the provided V8 and functionality of
http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
Based on the original patch of Andras Becsi <abecsi@webkit.org>.

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject): Fix QString deprecated warning.
  • QtWebKit.pro: Adding the V8 library should happen in the final build step.
  • WebCoreSupport/ChromeClientQt.cpp: Add missing head.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
6:49 AM Changeset in webkit [86948] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: console.log(XMLDocument) should be case preserving
https://bugs.webkit.org/show_bug.cgi?id=60765

Changes the XML document checking from base documents MIME type
to xmlVersion parameter.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
6:46 AM Changeset in webkit [86947] by mnaganov@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-05-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM,
instead of building it on Inspector's side.
https://bugs.webkit.org/show_bug.cgi?id=61185

  • bindings/js/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  • bindings/js/ScriptProfile.h:
  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
  • bindings/v8/ScriptProfile.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
6:32 AM Changeset in webkit [86946] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

2011-05-20 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Benjamin Poulain.

[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
6:24 AM Changeset in webkit [86945] by Adam Roben
  • 7 edits
    2 adds in trunk

Don't try to process DownloadProxy messages twice (and robustify code that runs if we do)

Fixes <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
(preceded by assertion) in fastMalloc when downloading a file

Reviewed by Darin Adler.

Source/WebKit2:

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::alignedBufferIsLargeEnoughToContain): Added. This helper function checks that the
given buffer is large enough to hold |size| bytes (and correctly handles the case where
we're already at the end or beyond the end of the buffer).

(CoreIPC::ArgumentDecoder::alignBufferPosition):
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
Replaced old code that was vulnerable to underflow with the new helper function.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage): Added back an early return that was
mistakenly removed in r86812 so that we don't mistakenly pass DownloadProxy messages on to
a WebPageProxy after we've already handled them.

Tools:

Test that the WebKit2 UI process doesn't crash when starting a download

  • TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.

(TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
(TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
started, cancel the download, and return a bogus string.

(TestWebKitAPI::setContextDownloadClient):
(TestWebKitAPI::setPagePolicyClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
our policy client, and run until we know that the download was started. If we haven't
crashed, we win!

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

Added new files.

5:52 AM Changeset in webkit [86944] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Mac build fix after r86936

  • WebCore.xcodeproj/project.pbxproj: Added preprocessor.pm like the

other .pm files.

5:44 AM Changeset in webkit [86943] by vitalyr@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-20 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Updating chromium DEPS.

  • DEPS:
5:43 AM Changeset in webkit [86942] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip one more plugins test after r86938.

  • platform/qt-mac/Skipped:
5:26 AM Changeset in webkit [86941] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Kent Tamura <tkent@chromium.org>

Try to fix Windows CE build.
Touch html.css to kick UA style sheet generation.

  • css/html.css:
5:18 AM Changeset in webkit [86940] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Kent Tamura <tkent@chromium.org>

Try to fix Windows CE build.

  • CMakeLists.txt: Add --preprocessor flag.
4:45 AM Changeset in webkit [86939] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt-mac] Skip two plugins test

Unskipped in platform/qt/ so need to skip in qt-mac as the build
does not support plugins (?)

  • platform/qt-mac/Skipped: plugins/get-url-with-javascript-url.html

plugins/windowless_plugin_paint_test.html

4:35 AM Changeset in webkit [86938] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] plugins/keyboard-events.html fails after r72717

https://bugs.webkit.org/show_bug.cgi?id=50050

keyboard-events.html now passes thanks to the buildbot
upgrades. It was blocked by a bug in Xvfb on xorg-server
1.4.2.

  • platform/qt/Skipped:
4:29 AM Changeset in webkit [86937] by Csaba Osztrogonác
  • 1 edit
    32 deletes in trunk/LayoutTests

[Qt] Unreviewed. Remove unnecessary Qt specific expected files.

  • platform/qt/editing/execCommand/5062376-expected.txt: Removed.
  • platform/qt/editing/execCommand/insert-list-with-id-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-before-link-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4840662-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5245519-expected.txt: Removed.
  • platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/page-zoom-expected.txt: Removed.
  • platform/qt/editing/undo/redo-style-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/qt/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
  • platform/qt/fast/dom/wrapper-classes-expected.txt: Removed.
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
  • platform/qt/fast/dynamic/float-at-line-break-expected.txt: Removed.
  • platform/qt/fast/dynamic/unicode-bidi-expected.txt: Removed.
  • platform/qt/fast/encoding/preload-encoding-expected.txt: Removed.
  • platform/qt/fast/lists/alpha-list-wrap-expected.txt: Removed.
  • platform/qt/fast/lists/decimal-leading-zero-expected.txt: Removed.
  • platform/qt/fast/lists/li-values-expected.txt: Removed.
  • platform/qt/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Removed.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed.
  • platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
  • platform/qt/fast/text/setData-dirty-lines-expected.txt: Removed.
  • platform/qt/fast/text/splitText-dirty-lines-expected.txt: Removed.
  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Removed.
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Removed.
  • platform/qt/plugins/document-open-expected.txt: Removed.
  • platform/qt/plugins/resize-from-plugin-expected.txt: Removed.
  • platform/qt/svg/custom/animation-currentColor-expected.txt: Removed.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
  • platform/qt/svg/custom/text-zoom-expected.txt: Removed.
  • platform/qt/svg/custom/transformedMaskFails-expected.txt: Removed.
3:47 AM Changeset in webkit [86936] by tkent@chromium.org
  • 11 edits
    1 add in trunk/Source/WebCore

2011-05-20 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Apply feature flags to user-agent style sheets
https://bugs.webkit.org/show_bug.cgi?id=52612

A user-agent style sheet should not have style definitions for disabled
features because such definitions makes feature detection harder and
causes incorrect behavior (See Bug 52214).

We have handled such feature-dependent style definitions by providing
separated CSS files and selecting them in build files. Adding such style
definition was hard because we need to update each of build files. This
change simplifies the process to add such style definitions by applying
preprocessor to the CSS files.

Implementation:
make-css-file-arrays.pl invokes a preprocessor if it has --defines
option. Otherwise, it just remove lines beginning with #.
In this change, we pass --defines on Mac, Windows, Chromium, GTK, and
CMake platforms. Qt and Android have no behavior change.

  • CMakeLists.txt:
    • IDL handling depends on preprocessor.pm.
    • Pass --defines option to make-css-file-arrays.pl
    • Add WebCore/bindings/scripts to @INC for make-css-file-arrays.pl
  • CodeGenerators.pri: IDL handling depends on preprocessor.pm.
  • DerivedSources.make: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gyp/WebCore.gyp: ditto.
  • WebCore.gyp/scripts/action_useragentstylesheets.py: Change parameter order to support perl modules and options. Many code is taken from rule_bindings.py.
  • WebCore.vcproj/MigrateScripts: Handles preprocessor.pm.
  • bindings/scripts/IDLParser.pm: Move the preprocessor code to preprocessor.pm.
  • bindings/scripts/preprocessor.pm: Added. The code was moved from IDLParser.pm
  • css/html.css: Enclose some style definitions with #if-#endif.
  • css/make-css-file-arrays.pl:
    • Add --defines and --preprocessor options.
    • Invoke a preprocessor if --defines is specified.
3:16 AM Changeset in webkit [86935] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-20 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

Remove unnecessary class Path inlcude from PathTraversalState.

  • platform/graphics/PathTraversalState.h:
2:56 AM Changeset in webkit [86934] by sergio@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-20 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test results.

  • platform/gtk/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-nested-1-expected.png: Added.
  • platform/gtk/fast/html/details-nested-1-expected.txt: Added.
  • platform/gtk/fast/html/details-nested-2-expected.png: Added.
  • platform/gtk/fast/html/details-nested-2-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
  • platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
  • platform/gtk/svg/custom/small-rect-scale-expected.png: Added.
  • platform/gtk/svg/custom/small-rect-scale-expected.txt: Added.
2:33 AM Changeset in webkit [86933] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-20 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r86920.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
2:32 AM Changeset in webkit [86932] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: ctrl+s should not switch source frame to read only mode.
https://bugs.webkit.org/show_bug.cgi?id=61125

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
1:53 AM Changeset in webkit [86931] by loki@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-20 Piroska András <Piroska.Andras@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Apply the ParallelJobs support to FEConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=61171

The FEConvolveMatrix filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-30% on dual-core machines.

Developed in cooperation with Gabor Loki.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::fastSetInteriorPixels): (WebCore::FEConvolveMatrix::setInteriorPixels): (WebCore::FEConvolveMatrix::setInteriorPixelsWorker): (WebCore::FEConvolveMatrix::apply):
  • platform/graphics/filters/FEConvolveMatrix.h:
1:48 AM Changeset in webkit [86930] by tkent@chromium.org
  • 32 edits in trunk/Tools

2011-05-20 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Fix style errors in DumpRenderTree/chromium/.
https://bugs.webkit.org/show_bug.cgi?id=61172

  • DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getAsCppVariant): (CppBoundClass::bindToJavascript):
  • DumpRenderTree/chromium/CppBoundClass.h: (CppBoundClass::GetterCallback::~GetterCallback): (CppBoundClass::CppBoundClass): (CppBoundClass::Callback::~Callback): (CppBoundClass::MemberCallback::MemberCallback): (CppBoundClass::MemberCallback::~MemberCallback): (CppBoundClass::MemberGetterCallback::MemberGetterCallback): (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h: (DRTDevToolsAgent::~DRTDevToolsAgent):
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendFrontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/EventSender.cpp: (SavedEvent::SavedEvent): (EventSender::EventSender): (EventSender::keyDown):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::Image):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::WorkQueue::reset): (WorkItemBackForward::WorkItemBackForward): (WorkItemLoadingScript::WorkItemLoadingScript): (WorkItemNonLoadingScript::WorkItemNonLoadingScript): (WorkItemLoad::WorkItemLoad): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::WorkItem::~WorkItem): (LayoutTestController::WorkQueue::WorkQueue):
  • DumpRenderTree/chromium/MockSpellCheck.cpp: (MockSpellCheck::MockSpellCheck): (MockSpellCheck::~MockSpellCheck):
  • DumpRenderTree/chromium/MockSpellCheck.h:
  • DumpRenderTree/chromium/NotificationPresenter.h: (NotificationPresenter::NotificationPresenter):
  • DumpRenderTree/chromium/Task.cpp: (WebTask::WebTask):
  • DumpRenderTree/chromium/Task.h: (TaskList::TaskList):
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::DRTPrinter): (TestShellPrinter::TestShellPrinter):
  • DumpRenderTree/chromium/TestNavigationController.cpp: (TestNavigationEntry::TestNavigationEntry): (TestNavigationEntry::~TestNavigationEntry): (TestNavigationController::TestNavigationController): (TestNavigationController::reload): (TestNavigationController::loadEntry): (TestNavigationController::didNavigateToEntry):
  • DumpRenderTree/chromium/TestNavigationController.h: (TestShellExtraData::TestShellExtraData):
  • DumpRenderTree/chromium/TestShell.cpp: (dumpHistoryItem):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
  • DumpRenderTree/chromium/TestShellWin.cpp: (TestShell::waitTestFinished):
  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::startWorkerContext): (TestWebWorker::terminateWorkerContext): (TestWebWorker::postMessageToWorkerContext): (TestWebWorker::clientDestroyed): (TestWebWorker::postMessageToWorkerObject): (TestWebWorker::postExceptionToWorkerObject): (TestWebWorker::postConsoleMessageToWorkerObject): (TestWebWorker::confirmMessageFromWorkerObject): (TestWebWorker::reportPendingActivity): (TestWebWorker::workerContextClosed): (TestWebWorker::~TestWebWorker):
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintButton): (WebThemeEngineDRTWin::paintMenuList): (WebThemeEngineDRTWin::paintTrackbar):
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.h: (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::navigate): (WebViewHost::updateSessionHistory): (WebViewHost::paintInvalidatedRegion):
  • DumpRenderTree/chromium/WebViewHost.h:
1:14 AM Changeset in webkit [86929] by commit-queue@webkit.org
  • 31 edits
    7 deletes in trunk

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86920.
http://trac.webkit.org/changeset/86920
https://bugs.webkit.org/show_bug.cgi?id=61173

It cause compile error on some buildbot in chromium. e.g.
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
(Requested by ukai_ on #webkit).

  • css3/images/optimize-contrast-canvas-expected.png: Removed.
  • css3/images/optimize-contrast-canvas-expected.txt: Removed.
  • css3/images/optimize-contrast-canvas.html: Removed.
  • css3/images/optimize-contrast-image-expected.png: Removed.
  • css3/images/optimize-contrast-image-expected.txt: Removed.
  • css3/images/optimize-contrast-image.html: Removed.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:

2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r86920.
http://trac.webkit.org/changeset/86920
https://bugs.webkit.org/show_bug.cgi?id=61173

It cause compile error on some buildbot in chromium. e.g.
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
(Requested by ukai_ on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • css/SVGCSSValueKeywords.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/HTMLCanvasElement.h:
  • platform/graphics/ImageRenderingMode.h: Removed.
  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::initialImageRendering): (WebCore::SVGRenderStyle::setImageRendering): (WebCore::SVGRenderStyle::imageRendering): (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
1:01 AM Changeset in webkit [86928] by krit@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079

Limit the depth of repeatedly splitting a segment on length calculation to 20. The limitation
is necessary for very big segments that would be splitter into millions of parts otherwise.
The limitation just cause a less accurate approximation.
At the moment the limit is fixed to 20. This is comparable with splitting the segment into
~1 million parts as a worst case. We might want to be more flexible later.

Test: svg/custom/path-getTotalLength-on-big-segment-crash.svg

  • platform/graphics/PathTraversalState.cpp: (WebCore::midPoint): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
  • platform/graphics/PathTraversalState.h:

2011-05-20 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Large curve path segment OOM crash
https://bugs.webkit.org/show_bug.cgi?id=42079

Added a test to verify, that the browser does not crash on calculating the total length on big segments.
It makes no sense to add the result of getTotalLength(), since they differ a lot bewteen platforms.
This is caused by the platform graphic libraries. See comment #9 on the bug.

  • svg/custom/path-getTotalLength-on-big-segment-crash-expected.txt: Added.
  • svg/custom/path-getTotalLength-on-big-segment-crash.svg: Added.
12:56 AM Changeset in webkit [86927] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

2011-05-20 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

SVGRootInlineBox triggers calculateBoundaries twice in layout
https://bugs.webkit.org/show_bug.cgi?id=60979

SVGRootInlineBox was calculating boundaries for children twice
in computePerCharacterLayoutInformation(). The first time of
calculation was in layoutChildBoxes() which is called by
computePerCharacterLayoutInformation(), and the second time of
calculation was in layoutRootBox() following layoutChildBoxes().

This patch calculates rectangle of children in layoutChildBoxes()
and then uses the rectange in layoutRootBox() to reduce a pass
of calculating child boundaries.

No functionality change, no new tests.

  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutChildBoxes): (WebCore::SVGRootInlineBox::layoutRootBox):
  • rendering/svg/SVGRootInlineBox.h:
Note: See TracTimeline for information about the timeline view.