Timeline
05/25/11:
- 23:58 Changeset [87364] by
-
https://bugs.webkit.org/show_bug.cgi?id=61506
Reviewed by Sam Weinig.
Move the silent spill/fill methods in the DFG JIT to the JITCodeGenerator
so that they are available to the SpeculativeJIT.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
- dfg/DFGNonSpeculativeJIT.h:
- 23:48 Changeset [87363] by
-
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505
Add support for painting MediaReturnToRealtimeButton, as well as hide and show
the correct default video control buttons when entering full-screen mode.
- css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
- html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and
"Return to Realtime" buttons for Live Streams in full-screen mode.
(WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of
all the buttons affected by enteredFullscreen().
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Add support for
MediaReturnToRealtimeButton.
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505
Updated WKSI Libraries with new images for Backward buttons in default
video controls.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 23:46 Changeset [87362] by
-
2011-05-25 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement various CSS font properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60603
No new tests - refactoring only.
- css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyFont): Added templated class to handle font properties (WebCore::ApplyPropertyFontWeight): Added class to handle font weight calculation (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Instantiate ApplyPropertyFont/ApplyPropertyFontWeight for appropriate properties.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove properties that are now implemented in CSSStyleApplyProperty
- css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontDescription): Added getter for m_style->fontDescription() (WebCore::CSSStyleSelector::parentFontDescription): Added getter for m_parentStyle->fontDescription() (WebCore::CSSStyleSelector::setFontDescription): Added setter for m_style->setFontDescription() that automatically sets m_fontDirty
- 23:20 Changeset [87361] by
-
2011-05-25 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Add site-specific hack for zipcar.com with old versions of requirejs.
https://bugs.webkit.org/show_bug.cgi?id=61321
Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).
- html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order.
- 23:15 Changeset [87360] by
-
2011-05-25 Andreas Kling <kling@webkit.org>
Reviewed by David Levin.
Rebaseline run-bindings-tests.
https://bugs.webkit.org/show_bug.cgi?id=61469
- bindings/scripts/test/JS/:
- bindings/scripts/test/V8/:
- 22:32 Changeset [87359] by
-
An attempt to revive Windows bots.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-05-25
- runtime/RegExp.cpp:
- runtime/RegExp.h:
- 22:19 Changeset [87358] by
-
2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
An attempt to revive Windows bots.
- runtime/RegExp.cpp:
- runtime/RegExp.h:
- 21:16 Changeset [87357] by
-
2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] REGRESSION(r87298) Skip drag-not-loaded-image.html failing test
https://bugs.webkit.org/show_bug.cgi?id=61465
Skip drag-not-loaded-image.html layout test from Qt. see bug 31332
- platform/qt/Skipped:
- 21:12 Changeset [87356] by
-
Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.
Reviewed by Sam Weinig.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Call::fromTailJump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::isSet):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::linkCall):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::linkCall):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::linkCall):
- assembler/MacroAssemblerSH4.cpp:
(JSC::MacroAssemblerSH4::linkCall):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::linkCall):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
- 21:05 Changeset [87355] by
-
https://bugs.webkit.org/show_bug.cgi?id=61500
Add JSObject::offsetOfPropertyStorage
Reviewed by Sam Weinig.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
- runtime/JSObject.h:
(JSC::JSObject::offsetOfPropertyStorage):
- 20:50 Changeset [87354] by
-
2011-05-25 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Rebaseline media tests after moving media controls to flexbox layout.
- platform/chromium-mac/fast/layers/video-layer-expected.txt:
- platform/chromium-mac/media/audio-controls-rendering-expected.txt:
- platform/chromium-mac/media/audio-repaint-expected.txt:
- platform/chromium-mac/media/controls-after-reload-expected.txt:
- platform/chromium-mac/media/controls-strict-expected.txt:
- platform/chromium-mac/media/controls-styling-expected.txt:
- platform/chromium-mac/media/controls-without-preload-expected.txt:
- platform/chromium-mac/media/video-controls-rendering-expected.txt:
- platform/chromium-mac/media/video-display-toggle-expected.txt:
- platform/chromium-mac/media/video-empty-source-expected.txt:
- platform/chromium-mac/media/video-no-audio-expected.txt:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium-win/fast/layers/video-layer-expected.txt:
- platform/chromium-win/media/audio-controls-rendering-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.txt:
- platform/chromium-win/media/controls-after-reload-expected.txt:
- platform/chromium-win/media/controls-strict-expected.txt:
- platform/chromium-win/media/controls-styling-expected.txt:
- platform/chromium-win/media/controls-without-preload-expected.txt:
- platform/chromium-win/media/video-controls-rendering-expected.txt:
- platform/chromium-win/media/video-display-toggle-expected.txt:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium-win/media/video-no-audio-expected.txt:
- platform/chromium-win/media/video-volume-slider-expected.txt:
- platform/chromium/test_expectations.txt:
- 20:32 Changeset [87353] by
-
2011-05-25 Gregg Tavares <gman@chromium.org>
Reviewed by Kenneth Russell.
Add 'noExtensions' option to Web/GraphicsContext3D attributes.
https://bugs.webkit.org/show_bug.cgi?id=61460
- Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
- Source/WebCore/platform/graphics/GraphicsContext3D.h:
- Source/WebKit/chromium/public/WebGraphicsContext3D.h:
- Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:
- 20:13 Changeset [87352] by
-
2011-05-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch itemBoundingBoxRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60789
Changing itemBoundingBoxRect to use an IntPoint representing the offset
to be added tot he box rect instead of a pair of ints.
No new tests since this is just refactoring.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
- accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::addFocusRingRects): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::nodeAtPoint):
- rendering/RenderListBox.h:
- 19:31 Changeset [87351] by
-
2011-05-24 MORITA Hajime <morrita@google.com>
RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=61111
- Added tests that capture the probelem.
- Updated expectations that were wrong.
- fast/html/details-replace-summary-child.html: Added.
- fast/html/details-replace-text.html: Added.
- platform/gtk/fast/html/details-no-summary4-expected.txt:
- platform/gtk/fast/html/details-open-javascript-expected.txt:
- platform/gtk/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-add-details-child-2-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.png: Added.
- platform/mac/fast/html/details-replace-summary-child-expected.txt: Added.
- platform/mac/fast/html/details-replace-text-expected.png: Added.
- platform/mac/fast/html/details-replace-text-expected.txt: Added.
- platform/qt/fast/html/details-no-summary4-expected.txt:
- platform/qt/fast/html/details-open-javascript-expected.txt:
- platform/qt/fast/html/details-open4-expected.txt:
2011-05-24 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=61111
- Changed Text::rendererIsNeeded() to be shadow-aware.
- previousRenderer(), nextRenderer() and parentRenderer() on NodeRenderingContext is now safe even if it's used with an attached node, which was originally used only during attach(). We need this change because these APIs are called inside CharacterData::updateRenderer() callstack.
Tests: fast/html/details-replace-summary-child.html
fast/html/details-replace-text.html
- dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::shouldCreateRenderer):
- dom/NodeRenderingContext.h: (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
- dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
- 18:58 Changeset [87350] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
reported as http://crbug.com/83994.
- platform/chromium/test_expectations.txt:
- 18:50 Changeset [87349] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Temporarily ignore MHTML test failures on Windows
while we dig into it in http://crbug.com/83833.
- platform/chromium/test_expectations.txt:
- 18:48 Changeset [87348] by
-
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697
Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetPrivateBrowsingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Simon Hausmann.
WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697
Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPrivateBrowsingEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 18:30 Changeset [87347] by
-
2011-05-25 Sailesh Agrawal <sail@chromium.org>
Reviewed by Tony Chang.
Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
https://bugs.webkit.org/show_bug.cgi?id=61401
ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.
- WebCore.gypi:
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
- platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
- platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.
- 18:12 Changeset [87346] by
-
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490
Make RegExp GC allocated. Basically mechanical change to replace
most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
where actual ownership happens.
Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h: (JSC::CodeBlock::addRegExp):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitNewRegExp):
- bytecompiler/BytecodeGenerator.h:
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::addRegExpToTrace):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::invalidateCode):
- runtime/RegExp.h: (JSC::RegExp::createStructure):
- runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
- runtime/RegExpCache.h:
- runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): (JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h: (JSC::RegExpObject::setRegExp): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
- runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::regExpProtoFuncCompile):
- runtime/RegExpPrototype.h:
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
2011-05-25 James Robinson <jamesr@chromium.org>
Reviewed by Geoffrey Garen
CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481
CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.
This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.
- loader/cache/CachedResource.cpp: (WebCore::CachedResource::overheadSize):
- 18:08 Changeset [87345] by
-
Revert last change, something weird happened when I went to land.
- 18:07 Changeset [87344] by
-
2011-05-25 James Robinson <jamesr@chromium.org>
Reviewed by Geoffrey Garen
CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481
CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.
This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.
- loader/cache/CachedResource.cpp: (WebCore::CachedResource::overheadSize):
- 18:01 Changeset [87343] by
-
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490
Make RegExp GC allocated. Basically mechanical change to replace
most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
where actual ownership happens.
Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h: (JSC::CodeBlock::addRegExp):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitNewRegExp):
- bytecompiler/BytecodeGenerator.h:
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::addRegExpToTrace):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::invalidateCode):
- runtime/RegExp.h: (JSC::RegExp::createStructure):
- runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
- runtime/RegExpCache.h:
- runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): (JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h: (JSC::RegExpObject::setRegExp): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
- runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::regExpProtoFuncCompile):
- runtime/RegExpPrototype.h:
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490
RegExp is GC'd so we don't need the RefPtr shenanigans anymore.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):
- 17:59 Changeset [87342] by
-
2011-05-25 Shishir Agrawal <shishir@chromium.org>
Reviewed by Dimitri Glazkov.
Fix crash in Chromium memory test.
https://bugs.webkit.org/show_bug.cgi?id=61451
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 17:52 Changeset [87341] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.
- platform/chromium/test_expectations.txt:
- 17:44 Changeset [87340] by
-
Unreviewed; Skip failing tests after r87328.
- platform/mac/Skipped:
- 17:27 Changeset [87339] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Test expectations update.
- platform/chromium/test_expectations.txt:
- 17:24 Changeset [87338] by
-
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87333.
http://trac.webkit.org/changeset/87333
https://bugs.webkit.org/show_bug.cgi?id=61488
Breaks Chromium build due to pure virtual methods. (Requested
by aklein on #webkit).
- public/WebWidget.h:
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- 17:04 Changeset [87337] by
-
Revert 79703 since it broke pdf scrolling (http://crbug.com/81878) - 2011-02-15 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
- 16:54 Changeset [87336] by
-
2011-05-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=60185
Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
state into PlatformContextCairo. Since Cairo is the only platform that needs
to store this, this is the proper place for it. Change the image mask stack into
a more generic state stack that can keep track of the multiple bits of platform
specific state and properly handle save/restore pairs.
No new tests. This is just a code refactor.
- platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs. (WebCore::GraphicsContextState::GraphicsContextState): Ditto.
- platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now. (WebCore::ContextShadow::drawRectShadow):
- platform/graphics/cairo/FontCairo.cpp: Ditto. (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): Ditto. (WebCore::setPlatformStroke): Ditto. (WebCore::GraphicsContext::setAlpha): Ditto.
- platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the header file, since it can be private now. Abstract the image mask state and the global alpha in a generic State class. (WebCore::ImageMaskInformation::update): (WebCore::ImageMaskInformation::isValid): (WebCore::ImageMaskInformation::maskSurface): (WebCore::ImageMaskInformation::maskRect): (WebCore::PlatformContextCairo::State::State): Added. (WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state class when this class is constructed. (WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack. (WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward declare the State class in the header. (WebCore::PlatformContextCairo::save): Push a new state onto the stack. (WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now. (WebCore::PlatformContextCairo::globalAlpha): Added. (WebCore::PlatformContextCairo::setGlobalAlpha): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha().
- platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack into a more generic state stack, much like PlatformContextChromium.
- 16:41 Changeset [87335] by
-
<rdar://problem/9504058> Need some way to query user gesture state from injected bundle
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in: Add an export that WebKit2 needs.
Source/WebKit2:
Add WKBundleIsProcessingUserGesture.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
(WKBundleIsProcessingUserGesture):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
- WebProcess/InjectedBundle/InjectedBundle.h:
- 16:39 Changeset [87334] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Rebaseline svg tests after r87310.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
- 16:30 Changeset [87333] by
-
2011-05-25 Sailesh Agrawal <sail@chromium.org>
Reviewed by Darin Fisher.
Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518
- public/WebWidget.h:
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::willStartLiveResize): (WebKit::WebPopupMenuImpl::willEndLiveResize):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::willStartLiveResize): (WebKit::WebViewImpl::willEndLiveResize):
- src/WebViewImpl.h:
- 16:09 Changeset [87332] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Removing test_expectations for non-existent tests.
- platform/chromium/test_expectations.txt:
- 16:08 Changeset [87331] by
-
Ureviewed; Build fix for Leopard and Snow Leopard.
Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.
- WebCore.exp.in:
- 16:05 Changeset [87330] by
-
2011-05-25 Michael Saboff <msaboff@apple.com>
Reviewed by Sam Weinig.
Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
https://bugs.webkit.org/show_bug.cgi?id=61478
Cleanup of further comments after patch was landed. Changes include
using /2 instead of >>1, adding a blank line after class include,
making method names start with lower case and adding clarifying
comments.
No new tests as the changes are stylistic and not functional.
- loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::pruneLiveResourcesToPercentage): (WebCore::MemoryCache::pruneDeadResourcesToPercentage):
- loader/cache/MemoryCache.h: (WebCore::MemoryCache::pruneToPercentage):
- platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::respondToMemoryPressure):
- 16:00 Changeset [87329] by
-
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload. Restructure the conditions so it only called when absolutely
necessary.
Reviewed by Brady Eidson.
No change in functionality so no new tests.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- platform/network/cf/ResourceRequest.h:
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Remove Quicklook pref. Moving it enirely down into WebCore so it can
be calculated only on reloads.
Reviewed by Brady Eidson.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 15:53 Changeset [87328] by
-
2011-05-24 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
No new tests; Covered by media/video-canvas-source.html.
Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
remote->local and make our answer to hasSingleSecurityOrigin dynamic.
When checking whether a given request has a single security origin, use a
SecurityOrigin to check the host, port, and scheme.
- WebCore.exp.in:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference
for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for
NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the
requested and resolved URLs have the same host and port.
- platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
2011-05-24 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
wkQTMovieResolvedURL.
2011-05-24 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
wkQTMovieResolvedURL.
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
Added functions to retrieve the resolved URL for media types supported on
mac.
- WebKitSystemInterface.h:
- WebKitSystemInterface.m: (WKAVAssetResolvedURL): Added. (WKQTMovieResolvedURL): Added.
- 15:49 Changeset [87327] by
-
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476
RegExp construction now simply validates the RegExp, it does
not perform actual codegen.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::recompile): (JSC::RegExp::compile): (JSC::RegExp::match):
- runtime/RegExp.h: (JSC::RegExp::recompileIfNecessary):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSplit):
- 15:46 Changeset [87326] by
-
Unreviewed; Update Skipped list for failing tests.
A new full-screen test requires <video> full screen support, which does not
exist on mac-leopard. Follow-up to r87322.
- platform/mac-leopard/Skipped:
- 15:03 Changeset [87325] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Test expectations update, followup to r87291.
The aforementioned change cleared out these files, when the intent
seems to have been removal to remove them.
- platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
- platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.
- platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
- platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.
- 14:56 Changeset [87324] by
-
REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
https://bugs.webkit.org/show_bug.cgi?id=61428
<rdar://problem/9457006>
Reviewed by Adam Roben.
Source/WebKit2:
The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.
- Platform/WorkItem.h:
(DerefWorkItem::DerefWorkItem):
Initialize m_ptr.
(DerefWorkItem::execute):
Deref the object.
(WorkItem::createDeref):
Create and return a DerefWorkItem.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
If the PluginView has only one reference left, deref it asynchronously.
Tools:
The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.
This test emulates that behavior.
- DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
(CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
Initialize member vars.
(CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
Remove our custom property from the message window, and destroy it.
(CallJSThatDestroysPlugin::NPP_Destroy):
Set m_isDestroyed, log that the plug-in was destroyed, and notify the
layout test controller that we're done.
(wndProc):
Get the PluginTest object, and call its runTest() function.
(CallJSThatDestroysPlugin::NPP_New):
Setup the test: register a class for the message-only window, create
it, and post a message to it to run the test.
(CallJSThatDestroysPlugin::runTest):
Execute JS that removes the plug-in from the page, and if we're not
destroyed, log a success message.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Add new test to project.
LayoutTests:
- platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
- platform/win/plugins/call-javascript-that-destroys-plugin.html: Added.
- 14:47 Changeset [87323] by
-
2011-05-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix media element regression where ended event stopped firing after changing the src attribute.
- media/media-ended-expected.txt: Added.
- media/media-ended.html: Added.
2011-05-25 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix media element regression where ended event stopped firing after changing the src attribute.
Test: media/media-ended.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
- 14:45 QtWebKitBuildBots edited by
- Update Qt on Windows bots to 4.7.3 (diff)
- 14:38 Changeset [87322] by
-
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461
- fullscreen/full-screen-iframe-legacy-expected.txt: Added.
- fullscreen/full-screen-iframe-legacy.html: Added.
- fullscreen/resources/legacy.html: Added.
2011-05-25 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461
Tests: fullscreen/full-screen-iframe-legacy.html
Allow calls from the legacy full-screen API to bypass the iframe
"webkitallowfullscreen" requirement by adding a parameter to
Document::webkitRequestFullScreenForElement specifying the strictness
of that check. Specify this new parameter everywhere that function is
called, including in the default controls' full-screen button handler.
- dom/Document.cpp: (WebCore::Document::webkitRequestFullScreenForElement):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen):
- html/shadow/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
- 14:33 Changeset [87321] by
-
2011-05-25 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
webkitpy's NetworkTransaction shouldn't use mechanize
https://bugs.webkit.org/show_bug.cgi?id=61450
mechanize.HTTPError is just an alias for urllib2.HTTPError, so
use urllib2 directly. Re-add NetworkTransaction to
test_results_uploader.py (reverting r87124).
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
- 14:31 Changeset [87320] by
-
[Qt] Missing update for expected results in LayoutTests after r87315
https://bugs.webkit.org/show_bug.cgi?id=61467
Reviewed by Andreas Kling.
We now expose qt_sender as a non-enumarated property in the
global object. Fix our expectations in relevant tests.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- 14:29 Changeset [87319] by
-
2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
Reviewed by David Hyatt.
Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752
Added test cases for all the attribute selector types (CSS2.1 & CSS3).
- fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-begin-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-contain-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-end-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-exact-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-list-dynamic-no-elementstyle.html: Added.
- fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt: Added.
- fast/css/attribute-selector-set-dynamic-no-elementstyle.html: Added.
2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
Reviewed by David Hyatt.
Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752
Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
which are used in CSS attribute selectors to determine the need for style
recalculation whenever element attributes are manipulated in DOM.
In certain conditions (element with no style, element is styled and attribute
is not a mapped attribute, attribute is of type 'type' or read-only)
even when attribute selector matches for an element, the attribute is not
added to m_selectorAttrs. This results in missing style recalculations
when a DOM element attribute is changed and is not found in m_selectorAttrs.
Removing the above said conditions in
CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
attributes in m_selectorAttrs will solve this issue. But this particular
function is called numerous times which triggers adding duplicate attributes
again and again.
This patch follows the approach taken for collecting ids in selectors, where
all the attributes in selectors are added to a HashSet at the time of adding
style rules to CSSStyleSelector from StyleSheets and when
CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
simply looked up in this pre-populated hash set.
Test: fast/css/attribute-selector-dynamic-no-elementstyle.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
- css/CSSStyleSelector.h:
- 14:23 Changeset [87318] by
-
2011-05-25 Adam Klein <adamk@chromium.org>
Unreviewed. Update chromium expectations after r87307.
- platform/chromium/test_expectations.txt: suppress, WK61470.
- 13:32 Changeset [87317] by
-
2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by James Robinson.
CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
https://bugs.webkit.org/show_bug.cgi?id=61454
Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
by one enum, and provided a way to obtain rules from UA/user stylesheets.
- css/CSSRule.h: Removed CSSRuleFilter.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): See above. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
- css/CSSStyleSelector.h: Moved CSSRuleFilter here.
- editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
- page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules): Ditto.
- 12:37 Changeset [87316] by
-
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Removed MarkSetProperties because it was unused
https://bugs.webkit.org/show_bug.cgi?id=61418
- heap/MarkStack.h: (JSC::MarkSet::MarkSet): (JSC::MarkStack::append):
- runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
- runtime/JSArray.h: (JSC::JSArray::visitChildrenDirect):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
- runtime/WriteBarrier.h: (JSC::MarkStack::appendValues):
- 12:28 Changeset [87315] by
-
2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] JSC bridge: implement qt_sender without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343
Create a stack to keep track of the sender objects. This is simpler than
the similar mechanism in QObject (C++ API), that keeps a stack per-object.
Since we do not support multiple threads, one static stack will be enough for
handling the behavior.
This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::qtSenderStack): We have one static stack of QObject*. The top of the stack contains the last object that emitted signal that called a JavaScript function.
- bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::QtSenderStack::top): (JSC::Bindings::QtInstance::QtSenderStack::push): (JSC::Bindings::QtInstance::QtSenderStack::pop): Minimal functionality to manipulate the sender stack.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute): Remove the previous code that modified the scope chain. Push the sender object to the stack before calling the JavaScript function (the "slot" in Qt-speak) and pop it afterwards.
2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] JSC bridge: implement qt_sender without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343
Create a 'qt_sender' property in the global object, that returns the top of
the qtSenderStack. This is an alternative implementation for the feature of
providing a way for a function (acting as a Qt 'slot') discover which object
emitted the signal that caused it to be executed.
This reduces the coupling of the Qt bridge and JSC internal implementation. The
patch tries to use as much JSC public API as possible.
This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls a QWebPagePrivate function to do it.
- Api/qwebframe_p.h:
- Api/qwebframe.cpp: (QWebFramePrivate::didClearedWindowObject): Before emitting the signal mentioned, adds the 'qt_sender' to the fresh global object.
(qtSenderCallback):
Returns the JSObjectRef corresponding to the top of qtSenderStack.
(QWebFramePrivate::addQtSenderToGlobalObject):
Create a property with a qtSenderCallback as getter function in the global object.
- 12:25 Changeset [87314] by
-
[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
until the port begins using those export macros.
- 12:23 Changeset [87313] by
-
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
- storage/indexeddb/migrate-basics-expected.txt: Removed.
- storage/indexeddb/migrate-basics.html: Removed.
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
- storage/IDBBackingStore.h:
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBLevelDBBackingStore.cpp:
- storage/IDBLevelDBBackingStore.h:
- storage/IDBSQLiteBackingStore.cpp:
- storage/IDBSQLiteBackingStore.h:
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
- public/WebIDBFactory.h:
- src/AssertMatchingEnums.cpp:
- src/IDBFactoryBackendProxy.cpp:
- src/IDBFactoryBackendProxy.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open):
- src/WebIDBFactoryImpl.h:
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllDatabases):
- DumpRenderTree/chromium/LayoutTestController.h:
- 12:22 Changeset [87312] by
-
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Carlson.
[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61279
Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
when calling build-webkit.
- WebCore.pri:
- WebCore.pro:
- features.pri:
- platform/KURL.h:
- platform/SharedBuffer.h:
- platform/cf/KURLCFNet.cpp:
- platform/cf/SharedBufferCF.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/cg/FloatSizeCG.cpp:
- platform/graphics/cg/IntRectCG.cpp:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::paint): (-[WebCoreMovieObserver layerHostChanged:]):
- platform/mac/KURLMac.mm:
- platform/mac/SharedBufferMac.mm: (+[WebCoreSharedBufferData initialize]):
- platform/mac/WebCoreObjCExtras.mm:
- platform/qt/WebCoreSystemInterface.h: Added.
- platform/qt/WebCoreSystemInterface.mm: Added.
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Eric Carlson.
[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61279
Enable the usage of QuickTime backend for the Qt port. It can be enabled by
passing DEFINES+=USE_QTKIT=1 when calling build-webkit.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- QtWebKit.pro:
- WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
- WebCoreSupport/WebSystemInterface.h: Added.
- WebCoreSupport/WebSystemInterface.mm: Added. (InitWebCoreSystemInterface):
- 12:20 Changeset [87311] by
-
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438
Unskip test case and provide expect result files.
- platform/qt/Skipped:
- platform/qt/fast/css/disabled-author-styles-expected.png: Added.
- platform/qt/fast/css/disabled-author-styles-expected.txt: Added.
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438
Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438
Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 12:01 Changeset [87310] by
-
2011-05-25 Rob Buis <rbuis@rim.com>
Reviewed by Eric Seidel.
WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569
Updated improved pixel test result and add new SVG1.1 SE test and results.
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
- svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
2011-05-25 Rob Buis <rbuis@rim.com>
Reviewed by Eric Seidel.
New test rubber-stamped by Dirk Schulze.
WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569
Do not render elements that reference non-existant filters.
Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg
- rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
- 11:51 Changeset [87309] by
-
2011-05-25 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
https://bugs.webkit.org/show_bug.cgi?id=59113
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
- dom/Document.h: (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
- xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- 11:48 Changeset [87308] by
-
2011-05-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make allocations with guard pages ensure that the allocation succeeded
https://bugs.webkit.org/show_bug.cgi?id=61453
Add null checks, and make PageBlock's operator bool() use
the realbase, rather than the start of usable memory.
- wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveAndCommit):
- wtf/PageBlock.h: (WTF::PageBlock::operator bool): (WTF::PageBlock::PageBlock):
- 11:45 Changeset [87307] by
-
2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by James Robinson.
http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027
And:
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html https://bugs.webkit.org/show_bug.cgi?id=48295
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html https://bugs.webkit.org/show_bug.cgi?id=48304
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html https://bugs.webkit.org/show_bug.cgi?id=48305
- canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
- canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt: Those 2 tests need a trailing line that was added as part of this change.
- fast/canvas/canvas-composite-alpha.html: Updated the test result to match the specification.
The changes are fairly simple:
- Clear up the destination rectangle as it should be always transparent now (source is transparent outside the source rectangle).
- Clear the composition rectangle if source or destination is transparent.
- Fixed the test when run in the browser.
Validated the changes against FF and Opera (IE 9 cannot render this test).
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped: Re-enable 4 tests.
2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by James Robinson.
http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027
And:
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html https://bugs.webkit.org/show_bug.cgi?id=48295
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html https://bugs.webkit.org/show_bug.cgi?id=48304
- Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html https://bugs.webkit.org/show_bug.cgi?id=48305
Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
them together as the fix is common.
Based on an older work by Ariya Hidayat.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2 cases if we have to.
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
(WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
(which matches other browsers' behavior) and "display transparency elsewhere".
- html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.
- 10:58 Changeset [87306] by
-
2011-05-20 Robert Hogan <robert@webkit.org>
Reviewed by Geoffrey Garen.
[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html
Use the test netscape plugin instead of quicktime.
Allows the test to pass on Qt/Gtk/Chromium as well as Mac.
https://bugs.webkit.org/show_bug.cgi?id=61182
http://code.google.com/p/chromium/issues/detail?id=15797
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- plugins/embed-attributes-setting-expected.txt:
- plugins/embed-attributes-setting.html:
- 10:22 Changeset [87305] by
-
<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
https://bugs.webkit.org/show_bug.cgi?id=61448
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
after intersecting the two rectangles.
- 10:10 Changeset [87304] by
-
Reviewed by Eric Seidel.
Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.
https://bugs.webkit.org/show_bug.cgi?id=27551
- 10:06 Changeset [87303] by
-
2011-05-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Add IntPoint versions of IntRect::move and IntPoint::move
https://bugs.webkit.org/show_bug.cgi?id=61390
Adding move methods to IntRect and IntPoint that take an IntPoint
that's acting as an offset. Since we also apply negative offsets,
also adding a single parameter operator- for IntPoint.
No new tests since this is refactoring.
- page/FrameView.cpp: (WebCore::FrameView::invalidateScrollbarRect): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer):
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild):
- platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
- platform/graphics/IntPoint.h: (WebCore::IntPoint::move): (WebCore::operator-):
- platform/graphics/IntRect.h: (WebCore::IntRect::move):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::requestedRegionOfInputImageData):
- platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalRectToPhysicalRect): (WebCore::RenderBlock::selectionGaps):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::localCaretRect):
- rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
- rendering/RenderInline.cpp: (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
- rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
- rendering/RenderLayerBacking.cpp: (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerCompositor.cpp: (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
- 10:04 Changeset [87302] by
-
2011-05-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch addFocusRingRects to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60783
Switching addFocusRingRects to use an IntPoint representing the offset being
applied instead of a pair of ints.
No new tests as this is only refactoring.
- platform/graphics/FloatSize.h: (WebCore::flooredIntPoint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::addFocusRingRects):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
- rendering/RenderListBox.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h: (WebCore::RenderObject::addFocusRingRects):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::addFocusRingRects):
- rendering/RenderTextControlSingleLine.h:
- rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addFocusRingRects):
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::addFocusRingRects):
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::addFocusRingRects):
- rendering/svg/RenderSVGPath.h:
- 09:50 Changeset [87301] by
-
2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87229.
http://trac.webkit.org/changeset/87229
https://bugs.webkit.org/show_bug.cgi?id=61445
Lots of tests crashing in
CFNetwork!URLResponse::createFilenameFromResponseHeaders on
Windows XP (Requested by aroben on #webkit).
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
- 09:48 Changeset [87300] by
-
2011-05-25 Leon Scroggins <scroggo@google.com>
Reviewed by Steve Block.
Update chromium expectations for more canvas fixes.
https://bugs.webkit.org/show_bug.cgi?id=61433
- platform/chromium/test_expectations.txt:
- 09:38 Changeset [87299] by
-
Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.info): Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.
- 09:33 Changeset [87298] by
-
2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314
Checks if WebKit crashes when dragging an image not yet loaded.
- http/tests/misc/drag-not-loaded-image-expected.txt: Added.
- http/tests/misc/drag-not-loaded-image.html: Added.
2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314
Checks if nativeImageForCurrentFrame is a valid pointer.
Test: http/tests/misc/drag-not-loaded-image.html
- platform/qt/DragImageQt.cpp: (WebCore::createDragImageFromImage):
- 09:27 Changeset [87297] by
-
2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Xan Lopez.
[GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
https://bugs.webkit.org/show_bug.cgi?id=61436
Fix arguments of gdk_drawable_get_size.
No new tests, no behavior change.
- platform/gtk/GtkVersioning.c: (getGdkDrawableSize):
- 08:02 QtWebKitRelease22 edited by
- (diff)
- 07:58 Changeset [87296] by
-
2011-05-25 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Skipped 3 new inspector tests that time out on gtk.
- platform/gtk/Skipped:
- 07:50 QtWebKitRelease22 edited by
- (diff)
- 07:46 QtWebKitRelease22 edited by
- (diff)
- 07:20 Changeset [87295] by
-
2011-05-25 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
- platform/qt-arm/Skipped:
- 07:02 Changeset [87294] by
-
2011-05-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extreme lagging when searching for "img[src*="
https://bugs.webkit.org/show_bug.cgi?id=61282
No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
when built and search-highlighted, rather than through innerHTML.
- inspector/front-end/DOMSyntaxHighlighter.js: (WebInspector.DOMSyntaxHighlighter): (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.highlightSearchResults): (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM): ():
- inspector/front-end/utilities.js: ():
- 05:34 Changeset [87293] by
-
2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Tony Gentilcore.
Introduce HTML5 track list objects.
https://bugs.webkit.org/show_bug.cgi?id=60184
Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
for their use in the MediaStream API and the HTML Media Element.
Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist
The Media Stream API will test this feature in the bug 56587.
More tests related to the HTML Media Element may be added later.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/DOMAllInOne.cpp:
- dom/EventTarget.cpp: (WebCore::EventTarget::toTrackList): (WebCore::EventTarget::toMultipleTrackList): (WebCore::EventTarget::toExclusiveTrackList):
- dom/EventTarget.h:
- dom/ExclusiveTrackList.cpp: Added. (WebCore::ExclusiveTrackList::create): (WebCore::ExclusiveTrackList::ExclusiveTrackList): (WebCore::ExclusiveTrackList::~ExclusiveTrackList): (WebCore::ExclusiveTrackList::clear): (WebCore::ExclusiveTrackList::select): (WebCore::ExclusiveTrackList::toExclusiveTrackList):
- dom/ExclusiveTrackList.h: Added. (WebCore::ExclusiveTrackList::selectedIndex):
- dom/ExclusiveTrackList.idl: Added.
- dom/MultipleTrackList.cpp: Added. (WebCore::MultipleTrackList::create): (WebCore::MultipleTrackList::MultipleTrackList): (WebCore::MultipleTrackList::~MultipleTrackList): (WebCore::MultipleTrackList::clear): (WebCore::MultipleTrackList::isEnabled): (WebCore::MultipleTrackList::enable): (WebCore::MultipleTrackList::disable): (WebCore::MultipleTrackList::toMultipleTrackList):
- dom/MultipleTrackList.h: Added.
- dom/MultipleTrackList.idl: Added.
- dom/TrackList.cpp: Added. (WebCore::Track::create): (WebCore::Track::Track): (WebCore::TrackList::create): (WebCore::TrackList::TrackList): (WebCore::TrackList::~TrackList): (WebCore::TrackList::length): (WebCore::TrackList::checkIndex): (WebCore::TrackList::getID): (WebCore::TrackList::getKind): (WebCore::TrackList::getLabel): (WebCore::TrackList::getLanguage): (WebCore::TrackList::clear): (WebCore::TrackList::postChangeEvent): (WebCore::TrackList::dispatchChangeEvent): (WebCore::TrackList::toTrackList): (WebCore::TrackList::scriptExecutionContext): (WebCore::TrackList::eventTargetData): (WebCore::TrackList::ensureEventTargetData):
- dom/TrackList.h: Added. (WebCore::Track::id): (WebCore::Track::kind): (WebCore::Track::label): (WebCore::Track::language): (WebCore::TrackList::DispatchTask::create): (WebCore::TrackList::DispatchTask::performTask): (WebCore::TrackList::DispatchTask::DispatchTask): (WebCore::TrackList::refEventTarget): (WebCore::TrackList::derefEventTarget):
- dom/TrackList.idl: Added.
- 05:06 QtWebKitRelease22 edited by
- (diff)
- 04:55 Changeset [87292] by
-
2011-05-25 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Move ElementWithPseudoId to separate file
https://bugs.webkit.org/show_bug.cgi?id=61430
No new tests because no behavior changes.
- CMakeLists.txt: Added ElementWithPseudoId.cpp
- GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
- WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
- WebCore.pro: Added ElementWithPseudoId.{h,cpp}
- WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
- WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
- html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
- html/shadow/ElementWithPseudoId.cpp: Added. (WebCore::ElementWithPseudoId::shadowPseudoId):
- html/shadow/ElementWithPseudoId.h: Added. (WebCore::ElementWithPseudoId::create): (WebCore::ElementWithPseudoId::ElementWithPseudoId):
- 04:43 Changeset [87291] by
-
2011-05-25 Anton Muhin <antonm@chromium.org>
Unreviewed.
Update test expectations after 3.3.6.1 v8 roll.
- platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
- platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
- platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
- platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
- platform/chromium/ietestcenter: Added.
- platform/chromium/ietestcenter/Javascript: Added.
- platform/chromium/ietestcenter/Javascript/15.4.4.14-5-28-expected.txt: Added.
- platform/chromium/ietestcenter/Javascript/15.4.4.15-5-28-expected.txt: Added.
- 04:39 Changeset [87290] by
-
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=34635
Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
application with -style plastique for example, therefore the code used for other styles should also be
used whenever the current style is not the Mac style.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
- 04:21 Changeset [87289] by
-
Unreviewed.
Update chromium test expectations.
- platform/chromium/test_expectations.txt: svn/dynamic-updates failing
- 04:19 Changeset [87288] by
-
2011-05-25 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Skip a flakey timed out test on ARM
- platform/qt-arm/Skipped:
- 04:08 Changeset [87287] by
-
Unreviewed.
Update chromium test expectations.
- platform/chromium/test_expectations.txt: mhtml tests pass
- 04:00 Changeset [87286] by
-
Unreviewed.
Update chromium test expectations.
- platform/chromium/test_expectations.txt:
- 03:41 Changeset [87285] by
-
Unreviewed.
Update chromium test expectations.
- platform/chromium/test_expectations.txt:
- 03:34 Changeset [87284] by
-
2011-05-25 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
https://bugs.webkit.org/show_bug.cgi?id=59677
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
- svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-dom-dx-attr.html: Added.
- svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-dom-dy-attr.html: Added.
- svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html: Added.
- svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGTextElement-dom-dx-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-dom-dy-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-dom-rotate-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-dom-x-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-dom-y-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dx-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dy-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-svgdom-x-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGTextElement-svgdom-y-prop.js: Added. (executeTest):
- 03:12 Changeset [87283] by
-
2011-05-25 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Clean up WebSocket test expectations
https://bugs.webkit.org/show_bug.cgi?id=61429
- platform/chromium/test_expectations.txt: Remove two test expectations for tests that are no longer failing.
- 02:52 Changeset [87282] by
-
2011-05-25 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353
- http/tests/websocket/tests/frame-length-overflow-expected.txt: Added a new console message.
2011-05-25 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353
An existing error message has been modified, but it is impossible
to test this message in LayoutTests because it is only shown when
memory allocation has failed, which is hard to reproduce reliably.
One new message has been added. It is covered by an existing test
http/tests/websocket/tests/frame-length-overflow.html.
There is no other change in behavior. No new tests are added.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail): Do not close if we know the socket stream is already closed. This does not change the behavior, because SocketStreamBase does nothing if it is already closed. (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didReceiveData): We need to set m_shouldDiscardReceivedData to true before calling fail(), so I moved the error message from appendToBuffer() to here. The error message was rephrased in order to improve readability. (WebCore::WebSocketChannel::appendToBuffer): Unnested the code. (WebCore::WebSocketChannel::processBuffer):
- 02:35 Changeset [87281] by
-
2011-05-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by David Levin.
CSSParser: m_implicitShorthand should probably be RAII
https://bugs.webkit.org/show_bug.cgi?id=51586
It was impossible to entirely eliminate the m_implicitShorthand manual changes
due to the parseFill*() method stateful call chains.
No new tests, as this is a refactoring.
- css/CSSParser.cpp: (ImplicitScope::ImplicitScope): (ImplicitScope::~ImplicitScope): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseBorderRadius):
- 02:03 Changeset [87280] by
-
2011-05-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364
- inspector/debugger/live-edit-expected.txt:
- inspector/debugger/live-edit.html:
- platform/chromium/test_expectations.txt:
2011-05-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
- 00:48 Changeset [87279] by
-
2011-05-25 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
Update chromium expectations after removal of execScript from V8
https://bugs.webkit.org/show_bug.cgi?id=61267
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 00:45 Changeset [87278] by
-
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194
Test: inspector/console/console-eval-syntax-error.html
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194
- inspector/console/console-eval-syntax-error-expected.txt: Added.
- inspector/console/console-eval-syntax-error.html: Added.
- platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.
- 00:30 Component Model edited by
- Updated the status of legacy shadow DOM post r87014 (diff)
- 00:17 Changeset [87277] by
-
2011-05-25 Yuzo Fujishima <yuzo@google.com>
Reviewed by Kent Tamura.
Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
https://bugs.webkit.org/show_bug.cgi?id=61352
No new tests because no behavior changes.
- html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::layout):
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::layout):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
- rendering/RenderView.h: (WebCore::RenderView::disableLayoutState): (WebCore::RenderView::enableLayoutState): (WebCore::LayoutStateDisabler::LayoutStateDisabler): (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
05/24/11:
- 23:42 Changeset [87276] by
-
[Qt] Unreviewed typo fix after r87228.
- WebCore.pro:
- 23:37 Changeset [87275] by
-
Make the Web Inspector bring the right window to the front when docked.
rdar://problem/9464685
https://webkit.org/b/61420
Reviewed by Brian Weinstein.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Ditto.
- 23:23 QtWebKitBuildBots edited by
- Update Qt on minimal bot (diff)
- 23:03 Changeset [87274] by
-
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- configure.ac: Added INPUT_COLOR feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
- fast/forms/ValidityState-typeMismatch-color.html: Removed.
- fast/forms/color/input-value-sanitization-color-expected.txt: Added.
- fast/forms/color/input-value-sanitization-color.html: Added. Tests sanitization algorithm for input type=color.
- fast/forms/input-type-change3-expected.txt:
- fast/forms/input-widths-expected.txt:
- fast/forms/input-widths.html: Removed type=color because it is no loger a text input type.
- fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
- fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
- fast/forms/script-tests/input-type-change3.js:
- platform/gtk/Skipped: Skip fast/forms/color.
- platform/mac/Skipped: Skip fast/forms/color.
- platform/qt/Skipped: Skip fast/forms/color.
- platform/win/Skipped: Skip fast/forms/color.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
Test: fast/forms/color/input-value-sanitization-color.html
- Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
- GNUmakefile.am: Added COLOR_INPUT feature flag.
- features.pri: Added COLOR_INPUT feature flag.
- html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::isColorControl): Added. (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec. (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
- html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
- html/InputType.cpp: (WebCore::InputType::isColorControl): Added.
- html/InputType.h:
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- features.gypi: Added INPUT_COLOR feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- Scripts/build-webkit: Added INPUT_COLOR feature flag.
2011-05-24 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273
- win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.
- 22:56 Changeset [87273] by
-
[Qt][WK2] Skip new failing test.
- platform/qt-wk2/Skipped:
- 21:54 Changeset [87272] by
-
2011-05-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
https://bugs.webkit.org/show_bug.cgi?id=61349
<rdar://problem/9476255>
- WebProcess/com.apple.WebProcess.sb:
- 21:43 Changeset [87271] by
-
2011-05-24 Steve Falkenburg <sfalken@apple.com>
Rubber stamped by Maciej Stachowiak.
Update test results after http://trac.webkit.org/changeset/87211
which disabled several features.
- 21:38 Changeset [87270] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61402
Converts the two html files to dump-as-markup and adds doctype, html, and body tags.
- editing/selection/4895428-1-expected.txt: Added.
- editing/selection/4895428-1.html: Converted to dump-as-markup
- editing/selection/4895428-4-expected.txt: Added.
- editing/selection/4895428-4.html: Converted to dump-as-markup
- platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
- platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
- platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
- platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
- platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
- platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
- platform/gtk/editing/selection/4895428-1-expected.png: Removed.
- platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
- platform/gtk/editing/selection/4895428-4-expected.png: Removed.
- platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
- platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
- platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
- platform/mac/editing/selection/4895428-1-expected.png: Removed.
- platform/mac/editing/selection/4895428-1-expected.txt: Removed.
- platform/mac/editing/selection/4895428-4-expected.png: Removed.
- platform/mac/editing/selection/4895428-4-expected.txt: Removed.
- 21:38 Changeset [87269] by
-
Reviewed by Eric Seidel.
Add export macros to WTFString.h.
https://bugs.webkit.org/show_bug.cgi?id=27551
- 21:35 Changeset [87268] by
-
2011-05-24 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Move chromium media controls timeline back to flexible rather than absolute
layout.
- platform/chromium/test_expectations.txt: Added expected failures from this change.
2011-05-24 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Move chromium media controls timeline back to flexible rather than absolute
layout.
- css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
- 21:26 Changeset [87267] by
-
2011-05-24 Kent Tamura <tkent@chromium.org>
Reviewed by Hajime Morita.
Convert fast/forms/input-type-change.html to a dumpAsText() test
https://bugs.webkit.org/show_bug.cgi?id=61029
Merge input-type-change2 to input-type-change.html, and convert it to
a dumpAsText() test.
- fast/forms/input-type-change-expected.txt:
- fast/forms/input-type-change.html:
- fast/forms/input-type-change2.html: Removed.
- platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
- platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
- platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
- platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
- platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
- platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
- platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
- platform/gtk/fast/forms/input-type-change-expected.png: Removed.
- platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
- platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
- platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
- platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
- platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
- platform/mac/fast/forms/input-type-change-expected.png: Removed.
- platform/mac/fast/forms/input-type-change-expected.txt:
- platform/mac/fast/forms/input-type-change-expected.txt: Removed.
- platform/mac/fast/forms/input-type-change2-expected.png: Removed.
- platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
- platform/qt-arm/Skipped: Remove input-type-change2.html.
- platform/qt-mac/Skipped: ditto.
- platform/qt/fast/forms/input-type-change-expected.txt: Removed.
- platform/qt/fast/forms/input-type-change2-expected.txt: Removed.
- 21:20 Changeset [87266] by
-
Unreviewed. Fix clang error.
error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):
- 21:17 Changeset [87265] by
-
2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Hajime Morita.
<legend> element is dropped on the floor
https://bugs.webkit.org/show_bug.cgi?id=18691
- html5lib/resources/webkit02.dat: Added a passing test for <legend> parsing.
- 21:14 Changeset [87264] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Tony Chang.
editing/deleting/5032066 should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61327
Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.
- editing/deleting/5032066-expected.txt: Added.
- editing/deleting/5032066.html:
- platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
- platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
- platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
- platform/gtk/editing/deleting/5032066-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
- platform/mac/editing/deleting/5032066-expected.png: Removed.
- platform/mac/editing/deleting/5032066-expected.txt: Removed.
- platform/qt/editing/deleting/5032066-expected.png: Removed.
- platform/qt/editing/deleting/5032066-expected.txt: Removed.
- 21:04 Changeset [87263] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
https://bugs.webkit.org/show_bug.cgi?id=61330
Converted to dump-as-markup and added a little html cleanup.
- editing/deleting/5115601-expected.txt: Added.
- editing/deleting/5115601.html: Convert to dump-as-markup.
- platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
- platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
- platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
- platform/gtk/editing/deleting/5115601-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
- platform/mac/editing/deleting/5115601-expected.png: Removed.
- platform/mac/editing/deleting/5115601-expected.txt: Removed.
- platform/qt/editing/deleting/5115601-expected.png: Removed.
- platform/qt/editing/deleting/5115601-expected.txt: Removed.
- 20:50 Changeset [87262] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61332
Used dump-as-markup to improve readability of results.
Also improved HTML and cleaned up descriptions.
- editing/deleting/5206311-2-expected.txt: Added.
- editing/deleting/5206311-2.html: Convert to dump-as-markup.
- platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
- platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
- platform/mac/editing/deleting/5206311-2-expected.png: Removed.
- platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
- platform/qt/editing/deleting/5206311-2-expected.png: Removed.
- platform/qt/editing/deleting/5206311-2-expected.txt: Removed.
- 20:39 Changeset [87261] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
https://bugs.webkit.org/show_bug.cgi?id=61333
Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.
- editing/deleting/delete-block-table-expected.txt: Added.
- editing/deleting/delete-block-table.html: Converted to dump-as-markup.
- platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
- platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
- platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
- platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
- platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.
- 20:39 Changeset [87260] by
-
2011-05-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395
All the callers of the API are wrong. They should call the more modern
static member function of ScriptController instead. I'll remove the
FrameLoader function in a future patch.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):
2011-05-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-05-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
2011-05-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395
- WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
- 20:28 Changeset [87259] by
-
2011-05-24 Justin Novosad <junov@chromium.org>
Reviewed by Stephen White.
[Chromium] cleanup test expectations for drawImage that are no longer
flaky
https://bugs.webkit.org/show_bug.cgi?id=61389
- platform/chromium/test_expectations.txt:
- 20:03 Changeset [87258] by
-
2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Fix style error.
- platform/efl/WidgetEfl.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
- 20:00 Changeset [87257] by
-
2011-05-24 Greg Simon <gregsimon@chromium.org>
Reviewed by Dimitri Glazkov.
Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000
LayoutTest for migration between SQLite and LevelDB
in IndxededDB.
- storage/indexeddb/migrate-basics-expected.txt: Added.
- storage/indexeddb/migrate-basics.html: Added.
2011-05-24 Greg Simon <gregsimon@chromium.org>
Reviewed by Dimitri Glazkov.
Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000
Test: storage/indexeddb/migrate-basics.html
- storage/IDBBackingStore.h:
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setEnableMigration): (WebCore::IDBFactoryBackendImpl::migrate):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
- storage/IDBLevelDBBackingStore.h: (WebCore::IDBLevelDBBackingStore::backingStoreType):
- storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
- storage/IDBSQLiteBackingStore.h: (WebCore::IDBSQLiteBackingStore::backingStoreType):
2011-05-24 Greg Simon <gregsimon@chromium.org>
Reviewed by Dimitri Glazkov.
Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::setEnableMigration):
- src/AssertMatchingEnums.cpp:
- src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::setEnableMigration):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactory::setOverrideBackingStoreType): (WebKit::WebIDBFactory::setTemporaryDatabaseFolder): (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open): (WebKit::WebIDBFactoryImpl::setEnableMigration):
- src/WebIDBFactoryImpl.h:
2011-05-24 Greg Simon <gregsimon@chromium.org>
Reviewed by Dimitri Glazkov.
Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
- DumpRenderTree/chromium/LayoutTestController.h:
- 19:54 Changeset [87256] by
-
Unreviewed.
Chromium expectations update. (mhtml)
- platform/chromium/test_expectations.txt:
- 19:52 Changeset [87255] by
-
Fix the 32-bit build.
Explicitly use uint32_t when encoding / decoding a type that is a typedef of OSType,
as this is declared as different underlying types in 32- and 64-bit (unsigned long
vs unsigned int).
- Shared/mac/KeychainAttribute.cpp:
(CoreIPC::encode):
(CoreIPC::decode):
- 19:35 Changeset [87254] by
-
2011-05-24 Leon Scroggins <scroggo@google.com>
Reviewed by Kenneth Russell.
Update expectations for tests drawing a canvas into another canvas (or itself), which have been fixed in gpu.
https://bugs.webkit.org/show_bug.cgi?id=61362
- platform/chromium/test_expectations.txt:
- 19:22 Changeset [87253] by
-
Enable coalesced wheel events
<rdar://problem/9444786>
Reviewed by Maciej Stachowiak.
- UIProcess/WebPageProxy.cpp:
Flip the switch for coalescing wheel events rather than dropping them.
- 19:18 Changeset [87252] by
-
Versioning.
- 19:16 Changeset [87251] by
-
New tag.
- 19:14 Changeset [87250] by
-
Rollout 87221.
- 19:07 Changeset [87249] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Final attempt to fix a test; if this fails, I'm just going to skip it.
- fast/events/selectstart-by-double-triple-clicks.html:
- 18:26 Changeset [87248] by
-
2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Ryosuke Niwa.
[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692
Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.
Test: editing/pasteboard/drag-drop-input-in-svg.svg
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Ryosuke Niwa.
[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692
Test case to verify dragging and dropping text between input fields
inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.
Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.
- editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
- editing/pasteboard/drag-drop-input-in-svg.svg: Added.
- platform/qt/Skipped:
- 18:05 Changeset [87247] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Yet another attempt to make Chromium Windows test bots happy.
- fast/events/selectstart-by-double-triple-clicks.html:
- 17:59 Changeset [87246] by
-
Merge r87187.
- 17:56 Changeset [87245] by
-
Merge r87179 + fix.
- 17:48 Changeset [87244] by
-
2011-05-24 Andy Estes <aestes@apple.com>
Reviewed by Geoffrey Garen.
REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
https://bugs.webkit.org/show_bug.cgi?id=61229
This site-specific hack maintains compatibility with Mac OS X Wiki Server,
which embeds QuickTime movies using an object tag containing QuickTime's
ActiveX classid. Treat this classid as valid only if OS X Server's unique
'generator' meta tag is present. Only apply this quirk if there is no
fallback content, which ensures the quirk will disable itself if Wiki
Server is updated to generate an alternate embed tag as fallback content.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return true if site-specific quirks are enabled, the object element has no fallback content, the classid attribute matches QuickTime's classid and the document has a 'generator' meta tag matching Mac OS X Web Services Server's unique generator string. (WebCore::HTMLObjectElement::hasValidClassId): Call shouldAllowQuickTimeClassIdQuirk()
- html/HTMLObjectElement.h:
- 17:33 Changeset [87243] by
-
Maybe fix the Mac build now?
- JavaScriptCore.xcodeproj/project.pbxproj:
- 17:29 Changeset [87242] by
-
Merge r87170.
- 17:27 Changeset [87241] by
-
Merge r87221.
- 17:25 Changeset [87240] by
-
Merge r87154.
- 17:24 Changeset [87239] by
-
2011-05-24 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Change CachedResources to take a ResourceRequest instead of
a url in their constructors and provide a very minimal set of
cases for avoiding reusing a CachedResource. The ResourceRequest
part of this change requires pushing responsibility
for calling Document::completeURL() to the caller, instead of
CachedResourceLoader, since ResourceRequest ASSERTs if it
is constructed with an invalid url.
Refactor, no new tests.
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
- loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.cpp: (WebCore::CachedFont::CachedFont):
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::checkShouldPaintBrokenImage):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::reuseRequest): (WebCore::CachedResource::allowReuseOfRequest): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator):
- loader/cache/CachedResource.h: (WebCore::CachedResource::resourceRequest): (WebCore::CachedResource::url):
- loader/cache/CachedResourceLoader.cpp:
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
- loader/cache/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
- loader/cache/CachedScript.h:
- loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::checkNotify):
- loader/cache/CachedXSLStyleSheet.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource):
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
- 17:24 Changeset [87238] by
-
Merge r87153.
- 17:23 Changeset [87237] by
-
2011-05-24 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Additional sandbox extension required for quarantine database
<rdar://problem/9397494>
https://bugs.webkit.org/show_bug.cgi?id=61405
- WebProcess/com.apple.WebProcess.sb: Add read-data access for ~/Library/Preferences.
- 17:18 Changeset [87236] by
-
Merge r87119.
- 17:18 Changeset [87235] by
-
2011-05-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use Element::shadowPseudoId() for text field decoration elements
https://bugs.webkit.org/show_bug.cgi?id=61351
No new tests. Covered by existing tests.
- css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
- -webkit-inner-spin-button
- -webkit-input-speech-button
- -webkit-outer-spin-button
- -webkit-search-cancel-button
- -webkit-search-decoration
- -webkit-search-results-button
- -webkit-search-results-decoration
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Store shadowPseudoId() result in a local variable because SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
- html/shadow/TextControlInnerElements.cpp: Override Element::shadowPseudoId() instead of Element::styleForRenderer(). (WebCore::SearchFieldResultsButtonElement::shadowPseudoId): (WebCore::SearchFieldCancelButtonElement::shadowPseudoId): (WebCore::SpinButtonElement::shadowPseudoId): (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
- html/shadow/TextControlInnerElements.h: Update declarations.
- rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
- rendering/RenderTextControlSingleLine.h: ditto.
- rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.
- css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
- 17:16 Changeset [87234] by
-
Merge r87109.
- 17:12 Changeset [87233] by
-
Maybe fix the Mac build?
- JavaScriptCore.xcodeproj/project.pbxproj:
- 17:00 Changeset [87232] by
-
Merge r87102.
- 16:49 Changeset [87231] by
-
2011-05-24 Dimitri Glazkov <dglazkov@chromium.org>
Sorted WebCore.xcodeproj again.
- WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
- 16:46 Changeset [87230] by
-
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Split HeapRootVisitor into its own class
https://bugs.webkit.org/show_bug.cgi?id=61399
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/HandleHeap.cpp:
- heap/HandleStack.cpp:
- heap/Heap.cpp:
- heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
- heap/MarkStack.h:
- runtime/ArgList.cpp:
- runtime/SmallStrings.cpp:
- 16:46 Changeset [87229] by
-
https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.
Reviewed by Geoff Garen.
No new tests because functionality has not changed.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
- 16:43 Changeset [87228] by
-
2011-05-24 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222
Added call to enable memory pressure handling.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
- WebView/WebViewInternal.h:
2011-05-24 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222
Added new class, MemoryPressureHandler, to platform to respond to low
system memory events. Added Mac specific implementation that reduces the
page cache, NSURL cache, WebCore cache by half their current usage
and then garbage collects. This can allow Safari to continue operating
in a low memory situation with minimal paging.
Split up prune operations in MemoryCache to allow for pruning to a
specific actual size to support this change.
No tests added as the functionality of WebKit wasn't changed.
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::forcePruneLiveResources): (WebCore::MemoryCache::pruneLiveResourcesToTarget): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::forcePruneDeadResources): (WebCore::MemoryCache::pruneDeadResourcesToTarget):
- loader/cache/MemoryCache.h: (WebCore::MemoryCache::forcePrune):
- platform/MemoryPressureHandler.cpp: Added. (WebCore::memoryPressureHandler): (WebCore::MemoryPressureHandler::MemoryPressureHandler): (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
- platform/MemoryPressureHandler.h: Added.
- platform/mac/MemoryPressureHandler.mm: Added. (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2011-05-24 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222
Added call to enable memory pressure handling for Mac case.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
- WebProcess/WebProcess.h:
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
- 16:19 Changeset [87227] by
-
2011-05-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
https://bugs.webkit.org/show_bug.cgi?id=61398
shadowAncestorNode() and shadowTreeRootNode() should be const
though they can return 'this' pointer.
No new tests. This doesn't change any visible behavior.
- dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Make this const. (WebCore::Node::shadowTreeRootNode): ditto.
- dom/Node.h: Update declarations.
- html/shadow/TextControlInnerElements.h: (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>. (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.
- 16:13 Changeset [87226] by
-
Merge radar 9489360.
- 16:03 Changeset [87225] by
-
Merge r87113.
- 16:01 Changeset [87224] by
-
Merge r87093.
- 15:58 Changeset [87223] by
-
Merge r87083.
- 15:53 Changeset [87222] by
-
Merge r87077.
- 15:52 Changeset [87221] by
-
Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard
Reviewed by Darin Adler.
Initialize the KeychainItem shim on SnowLeopard:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim):
On SnowLeopard, shim the 4 SecKeychainItem methods:
- WebProcess/mac/WebProcessShim.h:
- WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecKeychainItemCopyContent):
(WebKit::shimSecKeychainItemCreateFromContent):
(WebKit::shimSecKeychainItemModifyContent):
(WebKit::shimSecKeychainItemFreeContent):
(WebKit::WebKitWebProcessKeychainItemShimInitialize):
- WebProcess/mac/KeychainItemShimMethods.h: Added.
- WebProcess/mac/KeychainItemShimMethods.mm: Added.
Manage a set of shim-controlled AttributeList data:
(WebKit::shimManagedAttributeLists):
(WebKit::freeAttributeListContents):
(WebKit::allocateAttributeListContents):
Manage a set of shim-controlled KeychainItem data:
(WebKit::shimManagedKeychainItemContents):
(WebKit::allocateKeychainItemContentData):
Free any shim-controlled AttributeList or KeychainItem data:
(WebKit::webFreeAttributeListContentOnMainThread):
(WebKit::webFreeAttributeListContent):
(WebKit::webFreeKeychainItemContentOnMainThread):
(WebKit::webFreeKeychainItemContent):
Marshall these 3 KeychainItem methods to the UIProcess:
(WebKit::webSecKeychainItemCopyContentOnMainThread):
(WebKit::webSecKeychainItemCopyContent):
(WebKit::webSecKeychainItemCreateFromContentOnMainThread):
(WebKit::webSecKeychainItemCreateFromContent):
(WebKit::webSecKeychainItemModifyContentOnMainThread):
(WebKit::webSecKeychainItemModifyContent):
(WebKit::initializeKeychainItemShim):
Container for an AttributeList entry that knows how to encode/decode:
- Shared/mac/KeychainAttribute.cpp: Added.
(WebKit::KeychainAttribute::KeychainAttribute):
(CoreIPC::encode):
(CoreIPC::decode):
- Shared/mac/KeychainAttribute.h: Added.
Container for the relevant arguments to the shimmed methods, to send to the UIProcess:
- Shared/mac/SecKeychainItemRequestData.cpp: Added.
(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::initializeWithAttributeList):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):
- Shared/mac/SecKeychainItemRequestData.h: Added.
(WebKit::SecKeychainItemRequestData::keychainItem):
(WebKit::SecKeychainItemRequestData::itemClass):
(WebKit::SecKeychainItemRequestData::length):
(WebKit::SecKeychainItemRequestData::data):
Container for the possible output from the shimmed methods, to send back to the WebProcess:
- Shared/mac/SecKeychainItemResponseData.cpp: Added.
(WebKit::SecKeychainItemResponseData::SecKeychainItemResponseData):
(WebKit::SecKeychainItemResponseData::encode):
(WebKit::SecKeychainItemResponseData::decode):
- Shared/mac/SecKeychainItemResponseData.h: Added.
(WebKit::SecKeychainItemResponseData::itemClass):
(WebKit::SecKeychainItemResponseData::data):
(WebKit::SecKeychainItemResponseData::resultCode):
(WebKit::SecKeychainItemResponseData::attributes):
(WebKit::SecKeychainItemResponseData::keychainItem):
Actually implement the calls to the SecKeychainItem* methods in the UIProcess:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secKeychainItemCopyContent):
(WebKit::WebProcessProxy::secKeychainItemCreateFromContent):
(WebKit::WebProcessProxy::secKeychainItemModifyContent):
- WebKit2.xcodeproj/project.pbxproj: Project file stuff
- Configurations/Shim.xcconfig:
- 15:27 Changeset [87220] by
-
Merge r87046.
- 15:23 Changeset [87219] by
-
Merge r87026.
- 15:22 Changeset [87218] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
[chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
fail on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=61377
selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
the failing test expectation on Windows port.
In selectstart-by-double-triple-clicks.html, /\s|\s$/ isn't recognized by V8 so
replace it by /[ \t]|[ \t]$/.
- platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from LayoutTests/fast/events/selectstart-by-drag-expected.txt.
- fast/events/selectstart-by-double-triple-clicks.html:
- platform/chromium/test_expectations.txt:
- 15:20 Changeset [87217] by
-
Merge r87009.
- 15:17 Changeset [87216] by
-
Merge r87005.
- 15:12 Changeset [87215] by
-
2011-05-24 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528
- platform/chromium/test_expectations.txt: Remove CRASH from fixed test.
2011-05-24 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528
Test: fast/text/justify-ideograph-vertical.html (on chromium linux)
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.
- 15:10 Changeset [87214] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html on Mac WebKit2
since WebKitTestRunner doesn't implement eventSender.mouseScrollBy yet (bug 42194).
- platform/mac-wk2/Skipped:
- 15:09 Changeset [87213] by
-
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Rubberstamped by David Kilzer.
Updated some files that I forgot in my previous MHTML CL.
- Configurations/FeatureDefines.xcconfig:
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Rubberstamped by David Kilzer.
Updated some files that I forgot in my previous MHTML CL.
- Configurations/FeatureDefines.xcconfig:
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Rubberstamped by David Kilzer.
Updated some files that I forgot in my previous MHTML CL.
- Configurations/FeatureDefines.xcconfig:
- 15:06 Changeset [87212] by
-
Skip platform/mac/editing/input/maxlength.html - textInputController is not implemented.
- platform/mac-wk2/Skipped:
- 15:04 Changeset [87211] by
-
2011-05-24 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable features on safari-534-branch.
<rdar://problem/9261347>
This change requires a full rebuild.
- 14:59 Changeset [87210] by
-
2011-05-24 Robert Hogan <robert@webkit.org>
Reviewed by Ryosuke Niwa.
[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393
- platform/qt/Skipped: Unskip fast/events/selectstart-by-single-click-with-shift.html
2011-05-24 Robert Hogan <robert@webkit.org>
Reviewed by Ryosuke Niwa.
[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393
- DumpRenderTree/qt/EventSenderQt.h:
- DumpRenderTree/qt/EventSenderQt.cpp: (getModifiers): static function for interpreting modifiers (EventSender::mouseDown): Respect keyboard modifiers (EventSender::keyDown): use new static function (EventSender::sendOrQueueEvent): whitespace fix
- 14:56 Changeset [87209] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Skip fast/events/selectstart-by-double-triple-clicks.html and selectstart-by-drag.html
on Mac WebKit 2 per the bug 42194.
- platform/mac-wk2/Skipped:
- 14:47 Changeset [87208] by
-
2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377
LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html
We do not need assert for the useProgram as program can be null.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.
- 14:36 Changeset [87207] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on GTK
because GTK port doesn't implement eventSender.scalePageBy yet (bug 61396).
- platform/gtk/Skipped:
- 14:32 Changeset [87206] by
-
Merge r86995.
- 14:29 Changeset [87205] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on Windows
because Windows port doesn't implement eventSender.scalePageBy yet (bug 59098).
- platform/win/Skipped:
- 14:22 Changeset [87204] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340
Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.
- editing/undo/undo-after-setting-value-expected.txt: Added.
- editing/undo/undo-after-setting-value.html: Added.
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340
The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
calling clearUndoRedoOperations whenever script sets new value to input or textarea.
Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.
Test: editing/undo/undo-after-setting-value.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
- 14:12 Changeset [87203] by
-
2011-05-24 Adam Klein <adamk@chromium.org>
Unreviewed. Updating Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 14:06 Changeset [87202] by
-
Merge r86992.
- 14:01 Changeset [87201] by
-
Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=61392
Reviewed by Dave Hyatt.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Moved code here...
(WebCore::SimpleFontData::platformInit): ...from here.
- 13:59 Changeset [87200] by
-
Merge r87022.
- 13:56 Changeset [87199] by
-
Fix the Mac build: Yes, please do remove these files, svn.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 13:51 Changeset [87198] by
-
2011-05-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Let's just have one way to get the system page size, bokay?
https://bugs.webkit.org/show_bug.cgi?id=61384
- CMakeListsEfl.txt:
- CMakeListsWinCE.txt:
- GNUmakefile.list.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: MarkStack[Platform].cpp is gone completely now, since it only existed to provide a duplicate way to access the system page size.
- heap/MarkStack.cpp: (JSC::MarkStack::reset):
- heap/MarkStack.h: (JSC::::MarkStackArray): (JSC::::shrinkAllocation): Use WTF::pageSize.
- heap/MarkStackPosix.cpp:
- heap/MarkStackSymbian.cpp:
- heap/MarkStackWin.cpp: Removed now-empty files.
- jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
- jit/ExecutableAllocatorFixedVMPool.cpp: Use WTF::pageSize.
- wscript: Removed now-empty files.
- wtf/PageBlock.cpp: (WTF::systemPageSize): Integrated questionable Symbian page size rule from ExecutableAllocator, because that seems like what the original author should have done.
- 13:41 Changeset [87197] by
-
2011-05-24 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144
Implemented Float64Array based on the existing Float32Array sources.
Built and tested in Chromium on Linux and Mac OS X and Safari on Mac OS X.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::float64Array):
- bindings/js/JSFloat64ArrayCustom.cpp: Added. (WebCore::JSFloat64Array::indexSetter): (WebCore::toJS): (WebCore::JSFloat64Array::set): (WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
- bindings/v8/custom/V8Float64ArrayCustom.cpp: Added. (WebCore::V8Float64Array::constructorCallback): (WebCore::V8Float64Array::setCallback): (WebCore::toV8):
- html/canvas/ArrayBufferView.h: (WebCore::ArrayBufferView::isDoubleArray):
- html/canvas/Float64Array.cpp: Added. (WebCore::Float64Array::create): (WebCore::Float64Array::Float64Array): (WebCore::Float64Array::subarray):
- html/canvas/Float64Array.h: Added. (WebCore::Float64Array::set): (WebCore::Float64Array::item): (WebCore::Float64Array::isDoubleArray):
- html/canvas/Float64Array.idl: Added.
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
2011-05-24 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144
Added unit tests to existing typed array tests in Khronos repository and
synced layout test with them. Updated other affected layout tests.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
- fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):
- fast/dom/script-tests/prototype-inheritance.js:
- fast/js/script-tests/global-constructors.js:
- 13:23 Changeset [87196] by
-
2011-05-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Add ability to set compositing layer bounds origin
https://bugs.webkit.org/show_bug.cgi?id=61381
On Core Animation layers, the origin of the bounds
rectangle affects where layer content is rendered, as well
as the offset of sublayers. Currently we always set the
bounds offset to a zero point, but may need to make use
of the bounds offset in future, so expose it via GraphicsLayer.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::boundsOrigin): (WebCore::GraphicsLayer::setBoundsOrigin):
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setSize): (WebCore::GraphicsLayerCA::setBoundsOrigin): (WebCore::GraphicsLayerCA::setAllowTiledLayer): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateBounds): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
- 13:18 Changeset [87195] by
-
Clean up after Geoff and fix the WebKit2 build.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- 13:16 Changeset [87194] by
-
Rollout 87186. It breaks the branch.
- 13:07 Changeset [87193] by
-
2011-05-24 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix.
- CMakeLists.txt: Also build platform/network/ContentTypeParser.cpp, added by r86289.
- 13:03 Changeset [87192] by
-
2011-05-24 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix.
- bridge/runtime_root.cpp: Include <heap/Weak.h> instead of <JavaScriptCore/Weak.h>.
- 12:51 Changeset [87191] by
-
2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
Skip the tests added by r87096 and remove the failing test expectations on Qt.
The failures are tracked by the bug 61322.
- platform/qt/Skipped:
- platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
- platform/qt/fast/events/selectstart-by-drag-expected.txt: Removed.
- platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Removed.
- 12:39 Changeset [87190] by
-
2011-05-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Interpreter crashes with gc validation enabled due to failure to mark initial cache structure
https://bugs.webkit.org/show_bug.cgi?id=61385
The interpreter uses the structure slot of get_by_id and put_by_id to hold
the initial structure it encountered so that it can identify whether a
given access is stable.
When marking though we only visit the slot when we've decided to cache, and
so this value could die. This was "safe" as the value was only used for a
pointer compare, but it was incorrect. We now just mark the slot like we
should have been doing already.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures):
- 12:32 Changeset [87189] by
-
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168
- configure.ac:
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168
- mhtml/frame_0.html_original: Added.
- mhtml/frame_1.html_original: Added.
- mhtml/frame_2.html_original: Added.
- mhtml/frame_4.html_original: Added.
- mhtml/multi_frames.html_original: Added.
- mhtml/multi_frames_ie.mht: Added.
- mhtml/multi_frames_unmht.mht: Added.
- mhtml/page_with_css_and_js.html_original: Added.
- mhtml/page_with_css_and_js_ie.mht: Added.
- mhtml/page_with_css_and_js_unmht.mht: Added.
- mhtml/page_with_image.html_original: Added.
- mhtml/page_with_image_ie.mht: Added.
- mhtml/page_with_image_unmht.mht: Added.
- mhtml/resources/red_square.png: Added.
- mhtml/simple_page.html_original: Added.
- mhtml/simple_page_ie.mht: Added.
- mhtml/simple_page_unmht.mht: Added.
- platform/chromium/mhtml/multi_frames_ie-expected.txt: Added.
- platform/chromium/mhtml/multi_frames_unmht-expected.txt: Added.
- platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt: Added.
- platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt: Added.
- platform/chromium/mhtml/page_with_image_ie-expected.txt: Added.
- platform/chromium/mhtml/page_with_image_unmht-expected.txt: Added.
- platform/chromium/mhtml/simple_page_ie-expected.txt: Added.
- platform/chromium/mhtml/simple_page_unmht-expected.txt: Added.
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML reading support. That required some basic MIME header parsing.
Modified DocumentLoader to keep a reference to the currently Archive loaded,
so we can have different policies for loading subresources depending on the
archive type.
https://bugs.webkit.org/show_bug.cgi?id=7168
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- features.pri:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::popArchiveForSubframe): (WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
- loader/FrameLoader.h: (WebCore::FrameLoader::archive):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
- loader/archive/Archive.cpp: Added.
- loader/archive/Archive.h: (WebCore::Archive::mainResource):
- loader/archive/ArchiveFactory.cpp: (WebCore::archiveFactoryCreate): (WebCore::archiveMIMETypes): (WebCore::ArchiveFactory::create): (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
- loader/archive/ArchiveFactory.h:
- loader/archive/ArchiveResourceCollection.cpp: (WebCore::ArchiveResourceCollection::addAllResources): (WebCore::ArchiveResourceCollection::popSubframeArchive):
- loader/archive/ArchiveResourceCollection.h:
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): (WebCore::LegacyWebArchive::type):
- loader/archive/cf/LegacyWebArchive.h:
- loader/archive/mhtml/MHTMLArchive.cpp: Added.
- loader/archive/mhtml/MHTMLArchive.h: Added.
- loader/archive/mhtml/MHTMLParser.cpp: Added.
- loader/archive/mhtml/MHTMLParser.h: Added.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):
- platform/network/MIMEHeader.cpp: Added.
- platform/network/MIMEHeader.h: Added.
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168
- features.gypi:
2011-05-24 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168
- Scripts/build-webkit:
- Scripts/old-run-webkit-tests:
- Scripts/webkitperl/features.pm:
- Scripts/webkitpy/layout_tests/port/test_files.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 12:24 Changeset [87188] by
-
Try to fix some builds: #include Weak.h for Weak<T>.
- bridge/runtime_root.h:
- 12:23 Changeset [87187] by
-
2011-05-24 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339
Test: fast/events/scroll-in-scaled-page-with-overflow-hidden.html
- page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Scrollbars should be enabled for the viewport when scaled, even if overflow:hidden is specified.
2011-05-24 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339
- fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt: Added.
- fast/events/scroll-in-scaled-page-with-overflow-hidden.html: Added.
- 12:22 Changeset [87186] by
-
2011-05-24 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable features on safari-534-branch.
<rdar://problem/9261347>
- 12:16 Changeset [87185] by
-
Merge r86985.
- 12:13 Changeset [87184] by
-
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed now-inline functions.
- 12:07 Changeset [87183] by
-
Windows build fix: update the #if OS(WINDOWS) section to match my last patch.
- heap/MarkStack.h:
(JSC::::shrinkAllocation):
- 12:03 Changeset [87182] by
-
Leopard build fix
- bridge/runtime_root.cpp: Added a missing #include.
- 11:57 Changeset [87181] by
-
Make start parameter of Blob.slice optional.
https://bugs.webkit.org/show_bug.cgi?id=59628
Reviewed by Kenneth Russell.
Source/WebCore:
The start parameter should be optional per the latest FILE API
spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob.
- fileapi/Blob.h:
- fileapi/Blob.idl: Make start parameter optional.
LayoutTests:
- fast/files/blob-slice-test-expected.txt:
- fast/files/blob-slice-test.html:
- 11:55 Changeset [87180] by
-
Split out function definitions and class definitions from class
declarations in MarkStack.h, for readability.
Rubber-stamped by Oliver Hunt.
- heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
(JSC::MarkStack::pageSize):
(JSC::::MarkStackArray):
(JSC::::~MarkStackArray):
(JSC::::expand):
(JSC::::append):
(JSC::::removeLast):
(JSC::::last):
(JSC::::isEmpty):
(JSC::::size):
(JSC::::shrinkAllocation):
- 11:51 Changeset [87179] by
-
Invalidate JS wrappers for NPObjects when they are finalized
This will cause the underlying NPObject to be released at finalization time, rather than at
destruction time (which is unpredictable and could occur after the plugin has been
unloaded).
Test: plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html
Fixes <http://webkit.org/b/61316> <rdar://problem/9489824> Crash in deallocateNPObject when
reloading yahoo.com webarchive in WebKit2
and
<http://webkit.org/b/61317> <rdar://problem/9489829> Crash in _NPN_DeallocateObject when
reloading yahoo.com webarchive in WebKit1
Reviewed by Oliver Hunt.
Source/WebCore:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::~RuntimeObject): Assert that we've already been invalidated.
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
Updated for m_runtimeObjects type change.
(JSC::Bindings::RootObject::finalize): Added. Invalidates the RuntimeObject and removes it
from the map.
- bridge/runtime_root.h: Now inherits from WeakHandleOwner.
Changed m_runtimeObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will
be notified when the RuntimeObjects are finalized.
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::~JSNPObject): Assert that we've already been invalidated, rather than
trying to perform invalidation now (when the plugin might already be unloaded).
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
(WebKit::NPRuntimeObjectMap::invalidate):
Updated for m_jsNPObjects type change.
(WebKit::NPRuntimeObjectMap::finalize): Added. Invalidates the JSNPObject and removes it
from the map.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Now inherits from WeakHandleOwner.
Changed m_jsNPObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will be
notified when the JSNPObjects are finalized.
LayoutTests:
Test that we don't crash when a JS wrapper for an NPObject is destroyed after its plugin is unloaded
- plugins/npobject-js-wrapper-destroyed-after-plugin-unload-expected.txt: Added.
- plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html: Added.
(startTest): Gets a JS wrapper for an NPObject from the plugin, allocate a bunch of memory
so the JS wrapper will be finalized, then destroy the plugin and wait for a little bit
before calling finishTest.
(finishTest): Force a GC so the JS wrapper will be destroyed. If we didn't crash, we passed!
- 11:50 Changeset [87178] by
-
2011-05-24 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Remove most style checks on Source/ThirdParty/glu, since it doesn't
follow WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=61365
- Scripts/webkitpy/style/checker.py:
2011-05-24 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
Unfork glu sources as much as possible.
https://bugs.webkit.org/show_bug.cgi?id=61365
Restore the glu sources closer to the original version on oss.sgi.com
by removing the WebKit-specific include paths, restoring the include
order, and renaming the glu* functions via #defines rather than in
the source.
- glu/README.webkit: Update the README to reflect the changes from trunk.
- glu/glu.gyp: Add Source/Thirdparty/glu as an include path, so we can remove the hardcoded paths from the source files.
- glu/gluos.h: Add #defines to rename the glu entry points to internal_*.
- glu/internal_glu.h:
- glu/libtess/dict.c:
- glu/libtess/geom.c:
- glu/libtess/geom.h:
- glu/libtess/memalloc.c:
- glu/libtess/mesh.c:
- glu/libtess/mesh.h:
- glu/libtess/normal.c:
- glu/libtess/normal.h:
- glu/libtess/priorityq-heap.c:
- glu/libtess/priorityq-sort.h:
- glu/libtess/priorityq.c:
- glu/libtess/priorityq.h:
- glu/libtess/render.c:
- glu/libtess/render.h:
- glu/libtess/sweep.c:
- glu/libtess/sweep.h:
- glu/libtess/tess.c:
- glu/libtess/tess.h:
- glu/libtess/tessmono.c: Remove WebKit-specific include paths, and internal_ prefixes from glu entry points. Restore include order to original source order.
- 11:49 Changeset [87177] by
-
2011-05-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Avoid creating unnecessary identifiers and strings in the syntax checker
https://bugs.webkit.org/show_bug.cgi?id=61378
Selectively tell the lexer that there are some places it does not need to
do the real work of creating Identifiers for IDENT and STRING tokens.
Make parseString and parseIdentifier templatized on whether they should
do real work, or merely validate the tokens.
SunSpider --parse-only reports ~5-8% win depending on hardware.
- parser/ASTBuilder.h: (JSC::ASTBuilder::createDotAccess):
- parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression):
- parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
- parser/Lexer.h:
- parser/SyntaxChecker.h: (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createProperty):
- 11:46 Changeset [87176] by
-
Don't allow forcing builds through the build.webkit.org web interface
Someone has been forcing bogus builds.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 11:39 Changeset [87175] by
-
2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Adam Roben.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Fixes a typo issue for patch 94265.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):
2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Adam Roben.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
Because that case changed the setting.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
- 11:32 WebKit Team edited by
- (diff)
- 11:24 Changeset [87174] by
-
2011-05-24 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
skia: fix stroking of zero-height rectangles
https://bugs.webkit.org/show_bug.cgi?id=61284
Tests: canvas/philip/tests/2d.line.miter.lineedge.html
canvas/philip/tests/2d.strokeRect.zero.4.html
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::strokeRect):
- 11:16 Changeset [87173] by
-
2011-05-24 Zan Dobersek <zandobersek@gmail.com> and Philippe Normand <pnormand@igalia.com>
Reviewed by Kenneth Russell.
Enable FloatArray usage outside WebGL guards
https://bugs.webkit.org/show_bug.cgi?id=61356
- webaudio/AudioBuffer.cpp:
- webaudio/AudioBuffer.idl:
- webaudio/RealtimeAnalyser.cpp:
- webaudio/RealtimeAnalyser.h:
- webaudio/RealtimeAnalyserNode.h:
- webaudio/RealtimeAnalyserNode.idl:
- 11:12 Changeset [87172] by
-
2011-05-24 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194
Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
- inspector/console/console-eval-syntax-error-expected.txt: Removed.
- inspector/console/console-eval-syntax-error.html: Removed.
- platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
2011-05-24 Adam Klein <adamk@chromium.org>
Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194
Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback):
- 11:04 Changeset [87171] by
-
2011-05-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135
- fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt: Added.
- fast/canvas/canvas-getImageData-largeNonintegralDimensions.html: Added.
2011-05-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135
Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData):
- platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::ImageBufferData::getData):
- 10:53 Changeset [87170] by
-
2011-05-24 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
WebKit tells client that the page has become unresponsive while the beforeUnloadConfirm dialog is up
https://bugs.webkit.org/show_bug.cgi?id=61372
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Stop the unresponsiveness timer like we do for other client functions that spin a runloop.
- 10:45 Changeset [87169] by
-
Reviewed by Kevin Ollivier.
[wx] Make sure x and y adjustments are applied to all operations, and fix the calculations for the height and width checks to take into account x and y offsets.
https://bugs.webkit.org/show_bug.cgi?id=61367
- 10:43 Changeset [87168] by
-
2011-05-24 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132
- fast/forms/slider-hit-testing-expected.txt: Added.
- fast/forms/slider-hit-testing.html: Added.
2011-05-24 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132
Test: fast/forms/slider-hit-testing.html
We need to clear m_overflow otherwise we use the first
size of the slider for hit testing (i.e., changes to the size
cause problems). This only shows up if the thumb isn't contained
in the bounds of the slider. Making the range have a smaller height
than the thumb shows the bug.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Clear the overflow during layout
so we re-compute the overflow based on the current size of the
slider.
- 10:41 Changeset [87167] by
-
2011-05-24 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::reallocateRenderer):
2011-05-24 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749
This patch adds gpu accelerated rendering for content and root layers.
Layer textures are updated in two stages:
- Paint: The non-accelerated path paints the layer contents into a bitmap.
The accelerated path paints into an SkPicture, which is essentially a display list.
- Upload: The non-accelerated path uploads the pixels obtained in the first stage to a texture.
The accelerated path renders the picture directly into the texture.
The accelerated path can be enabled by --enable-accelerated-drawing command-line flag in chromium.
Note that this patch does not accelerate the CG path on mac. We have two options here - use skia or accelrate CG path.
Any bugs should be caught by layout tests.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::skiaContext): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::createRootLayerTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::acceleratedDrawing):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate): (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::clearFrameBuffer):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h: (WebCore::LayerTextureUpdaterSkPicture::orientation):
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
- 10:36 Changeset [87166] by
-
2011-05-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: display keyboard shortcuts in scripts panel sidebar buttons tooltip text.
https://bugs.webkit.org/show_bug.cgi?id=61358
- English.lproj/localizedStrings.js:
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.registerShortcut):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._createSidebarButtons): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
- 10:15 Changeset [87165] by
-
2011-05-24 Kenneth Russell <kbr@google.com>
Unreviewed. Fixed incorrect test expectations I previously checked in.
- platform/chromium-gpu-mac/compositing/animation/busy-indicator-actual.png: Removed.
- platform/chromium-gpu-mac/compositing/animation/busy-indicator-expected.png: Added.
- platform/chromium-gpu-win/compositing/animation/busy-indicator-actual.png: Removed.
- platform/chromium-gpu-win/compositing/animation/busy-indicator-expected.png: Added.
- 10:14 Changeset [87164] by
-
2011-05-24 Adam Klein <adamk@chromium.org>
Unreviewed. Updated Chromium test expectations.
- platform/chromium/test_expectations.txt: svg failure on Linux, BUGWK61370.
- 10:12 Changeset [87163] by
-
2011-05-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Andres Kling.
JSAudioContextCustom doesn't encode errors
https://bugs.webkit.org/show_bug.cgi?id=61357
Fix AudioContext return values
- bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):
- 10:07 Changeset [87162] by
-
2011-05-24 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
https://bugs.webkit.org/show_bug.cgi?id=61052
- Scripts/old-run-webkit-tests:
- 09:43 Changeset [87161] by
-
2011-05-24 Rob Buis <rbuis@rim.com>
Rubber-stamped by Dirk Schulze.
Remove requiresLayer inlines, already provided by RenderSVGModelObject.
- rendering/svg/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
- rendering/svg/RenderSVGImage.h:
- 09:30 Changeset [87160] by
-
2011-05-24 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[WK2] Change TiledDrawingArea to use ShareableBitmap instead of UpdateChunk.
https://bugs.webkit.org/show_bug.cgi?id=61296
Pass UpdateInfo containing ShareableBitmaps instead of UpdateChunk for tile updates.
Only the bounds rect and bitmap handle in the UpdateInfo are used since none of the
other parameters are needed for TiledDrawingArea.
- Shared/ShareableBitmap.h:
- Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createQImage): (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
- Shared/qt/UpdateChunk.cpp: Removed.
- Shared/qt/UpdateChunk.h: Removed.
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
- UIProcess/TiledDrawingAreaProxy.h:
- UIProcess/TiledDrawingAreaTile.h:
- UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
- UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate):
- WebKit2.pro:
- WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::didReceiveMessage):
- WebProcess/WebPage/TiledDrawingArea.h:
- WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: (WebKit::TiledDrawingArea::paintIntoBitmap):
- 09:25 Changeset [87159] by
-
2011-05-24 Adam Klein <adamk@chromium.org>
Unreviewed.
Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61169
- platform/chromium/test_expectations.txt: Marked optimize-contrast tests as IMAGE failure, BUGWK61169.
- 09:11 Changeset [87158] by
-
2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, build fix.
Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254
Forgot to rename the destructor.
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::AdditionalFontData::~AdditionalFontData):
- 09:06 Changeset [87157] by
-
2011-05-23 Michael Saboff <msaboff@apple.com>
Reviewed by Mark Rowe.
Safari often freezes when clicking "Return free memory" in Caches dialog
https://bugs.webkit.org/show_bug.cgi?id=61325
There are two fixes and improvement in instrumentation code used to find
one of the problems.
Changed ReleaseFreeList() to set the "decommitted" bit when releasing
pages to the system and moving Spans from the normal list to the returned
list.
Added a "not making forward progress" check to TCMalloc_PageHeap::scavenge
to eliminate an infinite loop if we can't meet the pagesToRelease target.
Added a check for the decommitted bit being set properly in
TCMalloc_PageHeap::CheckList.
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::ReleaseFreeList):
- 08:49 Changeset [87156] by
-
2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, build fix.
Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254
Rename SimpleFontData::FontData subclass to AdditionalFontData, to avoid clashes with the WebCore::FontData class, which breaks the win build.
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::fontData):
- svg/SVGFontData.h:
- 08:44 Changeset [87155] by
-
2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281
Remove the test case from skip list.
- platform/qt/Skipped:
- 08:39 Changeset [87154] by
-
Build fix after r87153
- WebProcess/mac/SecItemShimMethods.mm: Don't compile this code on SnowLeopard.
- 08:31 Changeset [87153] by
-
Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard
Reviewed by Sam Weinig.
In preparation for different WebProcess shims depending on platform, move the current
shim to its own files.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim): For non-SnowLeopard platforms, call initializeSecItemShim().
- WebProcess/mac/SecItemShimMethods.h: Added.
- WebProcess/mac/SecItemShimMethods.mm: Added. Actual webSecItem* methods moved from WebProcessMac.mm.
(WebKit::webSecItemCopyMatchingMainThread):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAddOnMainThread):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdateOnMainThread):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDeleteOnMainThread):
(WebKit::webSecItemDelete):
(WebKit::initializeSecItemShim): Initialize the callbacks via WebKitWebProcessSecItemShimInitialize
- WebProcess/mac/WebProcessShim.h:
- WebProcess/mac/WebProcessShim.mm: Wrap all the actual code here in a !BUILDING_ON_SNOW_LEOPARD block
(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):
(WebKit::WebKitWebProcessSecItemShimInitialize):
- 08:27 Changeset [87152] by
-
2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254
First part:
Remove a long-standing layering violation in TextRun: it stores RenderObject/RenderSVGResource pointers for SVG Fonts support.
Replace the two Render* pointers with a single RefPtr<AbstractRenderingContext>. AbstractRenderingContext is a helper class,
that can be derived from in order to associate additional data with a TextRun. This effectively reduces the memory consumption of TextRun.
Introduce rendering/TextRunRenderingContext.h, which inherits from TextRun::AbstractRenderingContext and holds additional data.
If the primary font in use is a SVG Font then allocate a TextRunRenderingContext object and store it in the RefPtr<AbstractRenderingContext>
in TextRun. If the primary font is not a SVG Font, don't even allocate the TextRunRenderingContext structure, as we won't need the context data.
SVG Fonts glyph matching only works within a context, so we need access to the RenderObject that's drawing the text.
This is the main preparation patch for the SVG Fonts rewrite, that will allow us to share the simple text code path for SVG Fonts as well,
making all CSS text properties work for HTML text using SVG Fonts, and allows proper integration within the GlyphPage concept. Soon
we can intermix WOFF/SVG & native fonts, within segment font declarations.
Second part:
Remove a long-standing layering violation in SimpleFontData: it stores SVGFontData objects, that are living in svg/.
Use the same concept as above, introduce SimpleFontData::AbstractFontData, and let SVGFontData inherit from AbstractFontData and extent it.
If SVG Fonts are used, CSSFontFaceSource will create a SVGFontData object and pass it as PassOwnPtr<AbstractFontData> to SimpleFontData.
All layering violations are gone now, SVG Fonts are cleanly integrated now.
Doesn't affect any tests yet, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- platform/graphics/Font.cpp: (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
- platform/graphics/Font.h:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::FontData::~FontData): (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::setMaxCharWidth): (WebCore::SimpleFontData::setAvgCharWidth): (WebCore::SimpleFontData::setSpaceWidth): (WebCore::SimpleFontData::setSpaceGlyph): (WebCore::SimpleFontData::setZeroWidthSpaceGlyph): (WebCore::SimpleFontData::fontData): (WebCore::SimpleFontData::isSVGFont): (WebCore::SimpleFontData::setMissingGlyphData):
- platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setAllowTabs): (WebCore::TextRun::setXPos): (WebCore::TextRun::RenderingContext::~RenderingContext): (WebCore::TextRun::renderingContext): (WebCore::TextRun::setRenderingContext):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): (WebCore::RenderBlock::constructTextRun):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp: (WebCore::setLogicalWidthForTextRun): (WebCore::textWidth): (WebCore::tryHyphenating): (WebCore::RenderBlock::LineBreaker::nextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow):
- rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
- rendering/svg/RenderSVGAllInOne.cpp:
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
- rendering/svg/SVGTextMetrics.cpp: (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
- rendering/svg/SVGTextRunRenderingContext.cpp: Copied from svg/SVGFont.cpp. (WebCore::svgFontAndFontFaceElementForFontData): (WebCore::firstParentRendererForNonTextNode): (WebCore::referencingRenderObjectFromRun): (WebCore::activePaintingResourceFromRun): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthMissingGlyphCallback): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::selectionRectForTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::offsetForPositionForTextUsingSVGFont):
- rendering/svg/SVGTextRunRenderingContext.h: Added. (WebCore::SVGTextRunRenderingContext::create): (WebCore::SVGTextRunRenderingContext::context): (WebCore::SVGTextRunRenderingContext::activePaintingResource): (WebCore::SVGTextRunRenderingContext::setActivePaintingResource): (WebCore::SVGTextRunRenderingContext::SVGTextRunRenderingContext): (WebCore::textRunNeedsRenderingContext):
- svg/SVGAllInOne.cpp:
- svg/SVGFont.cpp: Removed.
- svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
- svg/SVGFontData.h: (WebCore::SVGFontData::create): (WebCore::SVGFontData::isSVGFontData):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
- svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::SVGVKernElement): (WebCore::SVGVKernElement::buildVerticalKerningPair):
- svg/SVGVKernElement.h:
- 08:13 Changeset [87151] by
-
2011-05-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Andreas Kling.
[GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
https://bugs.webkit.org/show_bug.cgi?id=60827
Implement getter/setter of imageInterpolationQuality and logic to change
interpolation algorithm when drawing image.
Mac and Qt already implemented it.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::drawSurfaceToContext):
- platform/graphics/cairo/PlatformContextCairo.h: (WebCore::PlatformContextCairo::setImageInterpolationQuality): Added. (WebCore::PlatformContextCairo::imageInterpolationQuality): Added.
- 08:11 Changeset [87150] by
-
2011-05-24 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Tony Gentilcore.
Media Stream API: adding Stream and GeneratedStream classes.
https://bugs.webkit.org/show_bug.cgi?id=56666
Add the code for the Stream and GeneratedStream classes and integrate it
with the existing stream generation requests.
Tests for the Media Stream API will be provided by the bug 56587.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/DOMAllInOne.cpp:
- dom/EventTarget.cpp: (WebCore::EventTarget::toStream): (WebCore::EventTarget::toGeneratedStream):
- dom/EventTarget.h:
- dom/GeneratedStream.cpp: Added. (WebCore::GeneratedStream::DispatchUpdateTask::create): (WebCore::GeneratedStream::DispatchUpdateTask::performTask): (WebCore::GeneratedStream::DispatchUpdateTask::DispatchUpdateTask): (WebCore::GeneratedStream::create): (WebCore::GeneratedStream::GeneratedStream): (WebCore::GeneratedStream::~GeneratedStream): (WebCore::GeneratedStream::toGeneratedStream): (WebCore::GeneratedStream::detachEmbedder): (WebCore::GeneratedStream::stop): (WebCore::GeneratedStream::onStop):
- dom/GeneratedStream.h: Added.
- dom/GeneratedStream.idl: Added.
- dom/Stream.cpp: Added. (WebCore::Stream::create): (WebCore::Stream::Stream): (WebCore::Stream::~Stream): (WebCore::Stream::toStream): (WebCore::Stream::streamEnded): (WebCore::Stream::scriptExecutionContext): (WebCore::Stream::eventTargetData): (WebCore::Stream::ensureEventTargetData):
- dom/Stream.h: Added. (WebCore::Stream::readyState): (WebCore::Stream::label): (WebCore::Stream::refEventTarget): (WebCore::Stream::derefEventTarget):
- dom/Stream.idl: Added.
- page/CallbackTask.h: (WebCore::CallbackTask1::Scheduler::~Scheduler):
- page/MediaStreamClient.h:
- page/MediaStreamController.cpp: (WebCore::MediaStreamController::stopGeneratedStream): (WebCore::MediaStreamController::streamFailed):
- page/MediaStreamController.h:
- page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::GenerateStreamRequest::create): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::getStreamFromLabel): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::stopGeneratedStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed): (WebCore::MediaStreamFrameController::streamFailed):
- page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isGeneratedStream):
- page/NavigatorUserMediaError.h: (WebCore::NavigatorUserMediaError::create): (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
- page/NavigatorUserMediaSuccessCallback.h:
- page/NavigatorUserMediaSuccessCallback.idl:
- 08:10 Changeset [87149] by
-
Part 2 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE
Reviewed by Adam Roben.
- Configurations/Base.xcconfig:
(GCC_WARN_ABOUT_MISSING_NEWLINE): Added. Set to YES.
- 08:09 Changeset [87148] by
-
Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
that don't have any failing tests, which isn't useful
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
(Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
instead of name strings.
(Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
builder names into an array of builders.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
the most recently completed build, or -1 if there is no such build.
(Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
in the given build, or -1 if the number could not be determined. Some of this code came from
_getFailingTests.
(Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
(Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
getNumberOfFailingTests functions.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayTesters): Get the current number of test failures for each
tester and show it in the list. Omit testers that have no failures at all. We keep the
testers and failure counts in an array and sort it before displaying the current data, as
the order in which data will be fetched is unpredictable.
- 07:48 Changeset [87147] by
-
REGRESSION (r45620): Node list caches never deleted
https://bugs.webkit.org/show_bug.cgi?id=61268
<rdar://problem/9467379>
Reviewed by Oliver Hunt.
NodeListsNodeData::isEmpty() tests if RefCounted objects have refcount of zero which is impossible.
As a results NodeList caches are never deleted, causing bad performance in DOM mutating operations as
they repeatedly invalidate caches.
- dom/Node.cpp:
(WebCore::Node::childNodes):
Construct m_childNodeListCaches lazily.
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::notifyLocalNodeListsAttributeChanged):
(WebCore::Node::notifyLocalNodeListsChildrenChanged):
(WebCore::Node::removeNodeListCacheIfPossible):
Add a helper.
(WebCore::NodeListsNodeData::invalidateCaches):
Invalidate m_childNodeListCaches by clearing it if there are no additional clients
(WebCore::NodeListsNodeData::isEmpty):
Test emptiness of various NodeListCaches simply by testing hash emptiness instead of testing for non-zero ref count of items.
m_childNodeListCaches is empty if it is null.
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::NodeListsNodeData):
Construct m_childNodeListCaches lazily.
- 07:17 Changeset [87146] by
-
2011-05-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300
- inspector/CodeGeneratorInspector.pm:
2011-05-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
- 07:15 BuildingGtk edited by
- reading is very helpful in our learning (diff)
- 07:10 QtWebKitBuildBots edited by
- (diff)
- 06:11 QtWebKitBuildBots edited by
- (diff)
- 05:38 Changeset [87145] by
-
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194
- inspector/console/console-eval-syntax-error-expected.txt: Added.
- inspector/console/console-eval-syntax-error.html: Added.
- platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194
Test: inspector/console/console-eval-syntax-error.html
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
- 05:16 QtWebKitBuildBots edited by
- (diff)
- 04:22 Changeset [87144] by
-
2011-05-24 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Skip failing new test introduced in r87096
- platform/qt-arm/Skipped:
- 04:14 QtWebKitBuildBots edited by
- (diff)
- 03:55 QtWebKit edited by
- Add link to QtWebKit buildbots (diff)
- 03:54 Changeset [87143] by
-
2011-04-13 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Geolocation callbacks should make use of new callback generation mechanism
https://bugs.webkit.org/show_bug.cgi?id=40065
No new tests, refactoring only.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCustomPositionCallback.cpp: Removed.
- bindings/js/JSCustomPositionCallback.h: Removed.
- bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
- bindings/js/JSCustomPositionErrorCallback.h: Removed.
- bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/v8/custom/V8CustomPositionCallback.cpp: Removed.
- bindings/v8/custom/V8CustomPositionCallback.h: Removed.
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Removed.
- bindings/v8/custom/V8CustomPositionErrorCallback.h: Removed.
- bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):
- page/PositionCallback.h:
- page/PositionCallback.idl: Added.
- page/PositionErrorCallback.h:
- page/PositionErrorCallback.idl: Added.
- 03:46 QtWebKitBuildBots created by
- Add the list of QtWebKit buildbots
- 03:04 Changeset [87142] by
-
2011-05-24 Leon Scroggins <scroggo@google.com>
Reviewed by James Robinson.
Update expectations for shadow tests which are now passing.
https://bugs.webkit.org/show_bug.cgi?id=61278
Also remove some expectations for missing tests.
- platform/chromium/test_expectations.txt:
- 02:27 Changeset [87141] by
-
[Qt][Mac] Skip one more failing test.
- platform/qt-mac/Skipped:
- 02:24 Changeset [87140] by
-
2011-05-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watched expressions buttons do not match inspector styles.
https://bugs.webkit.org/show_bug.cgi?id=30554
- WebCore.gypi:
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane):
- inspector/front-end/Images/deleteIcon.png: Added.
- inspector/front-end/Images/paneRefreshButtons.png: Added.
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype.reset): (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update.appendResult): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.prototype._mouseMove): (WebInspector.WatchExpressionsSection.prototype._mouseOut): (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.properties-tree.watch-expressions): (.properties-tree.watch-expressions li): (.section .properties .delete-button): (.section .properties li.hovered .delete-button): (.pane > .title > .pane-title-button): (.pane > .title > .pane-title-button:hover): (.pane > .title > .pane-title-button:active): (.pane > .title > .pane-title-button.add): (.pane > .title > .pane-title-button.refresh):
- 02:15 Changeset [87139] by
-
2011-05-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Add fail() to WebSocketChannel and its family
https://bugs.webkit.org/show_bug.cgi?id=61277
This is the first part of refactoring effort described in bug 61115.
Existing error reports will be modified to use fail() in a later patch.
No change in behavior, thus no new tests.
- websockets/ThreadableWebSocketChannel.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail):
- websockets/WebSocketChannel.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::fail): (WebCore::WorkerThreadableWebSocketChannel::Peer::fail): (WebCore::WorkerThreadableWebSocketChannel::mainThreadFail): (WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
- websockets/WorkerThreadableWebSocketChannel.h:
- 02:05 Changeset [87138] by
-
2011-05-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] REGRESSION (r87063): Fix the build.
https://bugs.webkit.org/show_bug.cgi?id=61290
No new tests needed.
- bindings/scripts/CodeGeneratorV8.pm: disable the unsupported call tracked in: https://bugs.webkit.org/show_bug.cgi?id=61291
- 02:02 Changeset [87137] by
-
2011-05-24 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.
https://bugs.webkit.org/show_bug.cgi?id=61252
http://code.google.com/p/chromium/issues/detail?id=83539
Manual test: manual-tests/autofill-popup-location.html.
- manual-tests/autofill-popup-location.html: With long long text, test the shown location is correct.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setBaseWidth): Clip width with m_maxWindowWidth. (WebCore::PopupListBox::PopupListBox): Add m_maxWindowWidth initialization. (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Call setMaxWidthAndLayout() when the width is clipped with screen size. (WebCore::PopupListBox::setMaxWidthAndLayout): Set m_maxWindowWidth and call layout(). (WebCore::PopupListBox::layout): Compare renewed windowWidth and m_maxWindowWidth, and clip the it.
- 01:42 Changeset [87136] by
-
2011-05-24 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077
Update expectation to reflect that the canvas layer isn't composited.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt:
2011-05-24 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077
Return NULL from DrawingBuffer::create() if the initial dimensions are larger than we can support in hardware so
that we properly use the software canvas path and not enable the compositor for the canvas.
compositing/tiling/huge-layer-img.html triggers this case by trying to create a 20000 pixel high canvas. The
failure was previously masked by other bugs fixed by r85661.
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
Return NULL from DrawingBuffer::create() if resize() fails.
- 01:10 Changeset [87135] by
-
2011-05-24 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301
- http/tests/websocket/tests/close-before-open-expected.txt: Added.
- http/tests/websocket/tests/close-before-open.html: Added.
2011-05-24 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301
In platformClose(), m_readStream may be 0 until proxy is resolved.
It should callback didClose() in such case.
Test: http/tests/websocket/tests/close-before-open.html
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
- 00:42 Changeset [87134] by
-
[Qt][WK2] Paint the bot green for ultimate satisfaction of Ossy.
- platform/qt-wk2/Skipped:
- 00:22 Changeset [87133] by
-
[Qt][Mac] Skip failing tests.
- platform/qt-mac/Skipped:
- 00:16 Changeset [87132] by
-
2011-05-24 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
editing/deleting/5026848-2 and editing/deleting/5026848-3 should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61323
Convert editing/deleting/5026848-2 and editing/deleting/5026848-3 to dump-as-markup.
- editing/deleting/5026848-2-expected.txt: Added.
- editing/deleting/5026848-2.html: Convert to dump-as-markup.
- editing/deleting/5026848-3-expected.txt: Added.
- editing/deleting/5026848-3.html: Convert to dump-as-markup.
- platform/chromium-linux/editing/deleting/5026848-2-expected.png: Removed.
- platform/chromium-linux/editing/deleting/5026848-3-expected.png: Removed.
- platform/chromium-win/editing/deleting/5026848-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/5026848-2-expected.txt: Removed.
- platform/chromium-win/editing/deleting/5026848-3-expected.png: Removed.
- platform/chromium-win/editing/deleting/5026848-3-expected.txt: Removed.
- platform/gtk/editing/deleting/5026848-2-expected.txt: Removed.
- platform/gtk/editing/deleting/5026848-3-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/5026848-2-expected.png: Removed.
- platform/mac-leopard/editing/deleting/5026848-3-expected.png: Removed.
- platform/mac/editing/deleting/5026848-2-expected.png: Removed.
- platform/mac/editing/deleting/5026848-2-expected.txt: Removed.
- platform/mac/editing/deleting/5026848-3-expected.png: Removed.
- platform/mac/editing/deleting/5026848-3-expected.txt: Removed.
- platform/qt/editing/deleting/5026848-2-expected.png: Removed.
- platform/qt/editing/deleting/5026848-2-expected.txt: Removed.
- platform/qt/editing/deleting/5026848-3-expected.png: Removed.
- platform/qt/editing/deleting/5026848-3-expected.txt: Removed.
- 00:04 Changeset [87131] by
-
2011-05-23 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Skip failing test because of missing anti-aliased fonts on ARM
- platform/qt-arm/Skipped:
05/23/11:
- 23:39 Changeset [87130] by
-
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87118.
http://trac.webkit.org/changeset/87118
https://bugs.webkit.org/show_bug.cgi?id=61347
patch breaks layout tests
(https://bugs.webkit.org/show_bug.cgi?id=61342), and chromium
tests (browser_test MacTestCmdUp and ui_test Scrollbar)
(Requested by ukai_ on #webkit).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/ScrollAnimator.cpp:
- platform/chromium/ScrollAnimatorChromiumMac.h: Removed.
- platform/chromium/ScrollAnimatorChromiumMac.mm: Removed.
- platform/graphics/IntPoint.h:
- 23:09 Changeset [87129] by
-
Merge 87098 Build Fix
BUG=83012
Review URL: http://codereview.chromium.org/6992020
- 23:07 Changeset [87128] by
-
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Adam Barth.
Remove Node::deprecatedParserAddChild
https://bugs.webkit.org/show_bug.cgi?id=60818
No new tests as this is just a removal.
- dom/ContainerNode.cpp:
- dom/ContainerNode.h:
- dom/Node.cpp:
- dom/Node.h: Removed the method now that the last instance got removed as part of the <input> shadow DOM refactoring.
- 22:28 Changeset [87127] by
-
2011-05-23 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVGTextPositioning attributes are marked as NumberList instead of LengthList
https://bugs.webkit.org/show_bug.cgi?id=61301
SVGTextPositioningElement attributes x, y, dx and dy were marked as AnimatedNumberList
instead of AnimatedLengthList.
See specification http://www.w3.org/TR/SVG/text.html#InterfaceSVGTextPositioningElement
This does not affect the behavior, since we do not respect SVG units in SMIL animation yet.
No new tests added.
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
- 21:53 Changeset [87126] by
-
Unreviewed.
Chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61342
- platform/chromium/test_expectations.txt:
- 21:11 Changeset [87125] by
-
2011-05-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] Pass NodeRenderingContext to Node::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=61114
- Extracted NodeRenderingContext from NodeRendererFactory, giving separate files to it.
- Changed signature rendererIsNeeded(RenderStyle*) to rendererIsNeeded(const NodeRenderingContext&). The style object is retrieved from NodeRendererFactory::style() This will allow rendererIsNeeded() to access contextual information like attaching phase and rendering-parent.
No new tests. No behaviour change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer): Pass unresolved NodeRenderingContext& to rendererIsNeeded() (WebCore::CharacterData::rendererIsNeeded):
- dom/CharacterData.h:
- dom/DOMAllInOne.cpp:
- dom/EditingText.cpp: (WebCore::EditingText::rendererIsNeeded):
- dom/EditingText.h:
- dom/Node.cpp: (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::rendererIsNeeded):
- dom/Node.h:
- dom/NodeRenderingContext.cpp: Added. (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::~NodeRenderingContext): (WebCore::NodeRenderingContext::setStyle): (WebCore::NodeRenderingContext::releaseStyle): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::hostChildrenChanged): (WebCore::NodeRenderingContext::shouldCreateRenderer): (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::wrapWithRenderFullScreen): (WebCore::NodeRendererFactory::createRendererIfNeeded):
- dom/NodeRenderingContext.h: Added. (WebCore::NodeRenderingContext::node): (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle): (WebCore::NodeRenderingContext::style): (WebCore::NodeRendererFactory::context):
- dom/ShadowContentElement.h:
- dom/Text.cpp:
- dom/Text.h:
- html/HTMLAppletElement.cpp:
- html/HTMLAppletElement.h:
- html/HTMLElement.cpp:
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
- html/HTMLEmbedElement.h:
- html/HTMLFormElement.cpp:
- html/HTMLFormElement.h:
- html/HTMLFrameElement.cpp:
- html/HTMLFrameElement.h:
- html/HTMLFrameSetElement.cpp:
- html/HTMLFrameSetElement.h:
- html/HTMLIFrameElement.cpp:
- html/HTMLIFrameElement.h:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLNoScriptElement.h:
- html/HTMLObjectElement.cpp:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- html/shadow/DetailsMarkerControl.cpp:
- html/shadow/DetailsMarkerControl.h:
- html/shadow/MeterShadowElement.cpp:
- html/shadow/MeterShadowElement.h:
- html/shadow/ProgressShadowElement.cpp:
- html/shadow/ProgressShadowElement.h:
- svg/SVGDescElement.h:
- svg/SVGElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.h:
- svg/SVGGElement.cpp:
- svg/SVGGElement.h:
- svg/SVGGlyphElement.h:
- svg/SVGHKernElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMissingGlyphElement.h:
- svg/SVGSVGElement.h:
- svg/SVGStyledElement.cpp:
- svg/SVGStyledElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp:
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp:
- svg/SVGTSpanElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTextPathElement.h:
- svg/SVGTitleElement.h:
- svg/SVGVKernElement.h:
- svg/SVGViewElement.h:
- 20:41 Changeset [87124] by
-
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[nrwt] don't use NetworkTranslation when uploading results
https://bugs.webkit.org/show_bug.cgi?id=61315
This avoids autoinstalling mechanize. It didn't matter anyway
because test_results_uploader.py wasn't using mechanize to make the
request so NetworkTransaction::run wasn't doing anything extra
(it only matters if it catches mechanize.HTTPError).
- Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
- 20:31 Changeset [87123] by
-
2011-05-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[Refactoring] attach() following detach() should be replaced with Node::reattach()
https://bugs.webkit.org/show_bug.cgi?id=61011
- Renamed forceReattach() to reattach()
- Introduced reattachIfAttached() as a variant.
No new tests. No behavior change.
- dom/CharacterData.cpp: (WebCore::CharacterData::updateRenderer):
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- dom/Node.h: (WebCore::Node::reattach): (WebCore::Node::reattachIfAttached):
- dom/Text.cpp: (WebCore::Text::recalcStyle):
- html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
- html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::recalcStyle):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- 20:26 Changeset [87122] by
-
Build fix after r87117.
When moving #defines out in to separate files I find that code is more likely to compile
when the new header file is actually #included.
- editing/SpellingCorrectionController.h:
- 19:25 Changeset [87121] by
-
2011-05-23 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627
- css3/images/optimize-contrast-canvas-expected.checksum: Added.
- css3/images/optimize-contrast-canvas-expected.png: Added.
- css3/images/optimize-contrast-canvas-expected.txt: Added.
- css3/images/optimize-contrast-canvas.html: Added.
- css3/images/optimize-contrast-image-expected.checksum: Added.
- css3/images/optimize-contrast-image-expected.png: Added.
- css3/images/optimize-contrast-image-expected.txt: Added.
- css3/images/optimize-contrast-image.html: Added.
2011-05-23 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
https://bugs.webkit.org/show_bug.cgi?id=56627
Tests: css3/images/optimize-contrast-canvas.html
css3/images/optimize-contrast-image.html
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- css/SVGCSSValueKeywords.in:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- platform/graphics/ImageRenderingMode.h: Added.
- rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::imageRendering): (WebCore::InheritedFlags::setImageRendering): (WebCore::InheritedFlags::initialImageRendering):
- rendering/style/RenderStyleConstants.h:
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
- rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeStyle):
- 19:15 Changeset [87120] by
-
2011-05-23 Justin Schuh <jschuh@chromium.org>
Unreviewed.
Chromium multiple expectations update.
- platform/chromium/test_expectations.txt:
- 19:08 Changeset [87119] by
-
2011-05-23 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Cap painting to 30fps on Windows
https://bugs.webkit.org/show_bug.cgi?id=61337
<rdar://problem/9213388>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::displayTimerFired):
- 19:04 Changeset [87118] by
-
2011-05-23 Sailesh Agrawal <sail@chromium.org>
Reviewed by James Robinson.
Chromium Mac: Use ScrollAnimatorMac.mm for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753
No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/ScrollAnimator.cpp:
- platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
- platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
- platform/graphics/IntPoint.h:
- 18:58 Changeset [87117] by
-
2011-05-22 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
SUPPORT_AUTOCORRECTION_PANEL should be USE(AUTOCORRECTION_PANEL)
https://bugs.webkit.org/show_bug.cgi?id=61181
- Removed SUPPORT_AUTOCORRECTION_PANEL and REMOVE_MARKERS_UPON_EDITING from SpellingCorrectionController.h
- Define WTF_USE_UNIFIED_TEXT_CHECKING and WTF_USE_AUTOMATIC_TEXT_REPLACEMENT at TextChecking.h
No new tests. Just renaming a compilation conditional.
- editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
- editing/SpellingCorrectionController.cpp:
- editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldRemoveMarkersUponEditing):
- loader/EmptyClients.h:
- page/EditorClient.h:
- platform/text/TextChecking.h:
- 18:56 Changeset [87116] by
-
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by Dirk Pranke.
[chromium] fix the rebaseline tool to work with Linux GPU failures
https://bugs.webkit.org/show_bug.cgi?id=61312
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 18:52 Changeset [87115] by
-
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329
patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87007.
http://trac.webkit.org/changeset/87007
https://bugs.webkit.org/show_bug.cgi?id=61329
patch unnecessarily breaks HTML5 compatibility (Requested by
estes on #webkit).
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId):
- 18:17 Changeset [87114] by
-
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
<rdar://problem/9191214>
- fast/storage/storage-detached-iframe-expected.txt: Added.
- fast/storage/storage-detached-iframe.html: Added.
- platform/chromium/test_expectations.txt: Marked the test as CRASH on Chromium - Linux.
2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
https://bugs.webkit.org/show_bug.cgi?id=57140
Test: fast/storage/storage-detached-iframe.html
Access of localStorage on a detached iframe was causing a crash because a detached
iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.
- storage/StorageAreaImpl.cpp: (WebCore::privateBrowsingEnabled): check that child->page() is non-null before accessing it.
- 18:02 Changeset [87113] by
-
2011-05-23 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION (r86990:86992): World leak when all windows closed
https://bugs.webkit.org/show_bug.cgi?id=61311
Three interlocking problems:
1) Calling [WKView fullScreenController] will create the controller if it doesn't all ready
exist, so move the closing code into WKView, where we can bail early if there isn't a
controller.
2) A retain-cycle exists between WKView and WKFullScreenWindowController. Make sure to break
the cycle explicitly by clearing the _fullScreenWindowController ivar when closing the
controller.
3) [NSWindowController close] was overridden without calling [super close]. Do that.
- UIProcess/API/mac/WKView.mm: (-[WKView closeFullScreenWindowController]): Moved here from WebFullScreenManagerProxyMac.mm.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController close]): Call [super close].
- UIProcess/mac/WebFullScreenManagerProxyMac.mm: (WebKit::WebFullScreenManagerProxy::invalidate):
- 17:54 Changeset [87112] by
-
Ignore generated .pyc files in a directory full of python code.
- Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
- 17:31 Changeset [87111] by
-
VO doesn't work with HTML5 range (slider) input @step attribute
https://bugs.webkit.org/show_bug.cgi?id=61298
Reviewed by David Kilzer.
Source/WebCore:
Test: platform/mac/accessibility/range-alter-by-step.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::stepValueForRange):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::alterSliderValue):
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::stepValueForRange):
(WebCore::AccessibilityRenderObject::changeValueByStep):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- platform/mac/accessibility/range-alter-by-step-expected.txt: Added.
- platform/mac/accessibility/range-alter-by-step.html: Added.
- 17:29 Changeset [87110] by
-
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Rebaselines work better if we had the new lines at the end of each file.
- platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt:
- platform/gtk/fast/events/selectstart-by-drag-expected.txt:
- platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt:
- platform/qt/fast/events/selectstart-by-drag-expected.txt:
- platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt:
- platform/win/fast/events/selectstart-by-drag-expected.txt:
- 17:09 Changeset [87109] by
-
https://bugs.webkit.org/show_bug.cgi?id=61306
Reviewed by Geoff Garen.
The begin characters optimization currently has issues (#61129),
and does not appear to still be a performance win. The prudent
next step seems to be to disable while we ascertain whether this
is still a useful performance optimization.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
- yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
- 16:53 Changeset [87108] by
-
Part 1 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE
Merge ANGLE upstream commit r653 for Issue 154.
- src/compiler/PoolAlloc.h: Added newline to end of file.
- src/compiler/ShHandle.h: Ditto.
- src/libEGL/Display.cpp: Ditto.
- 16:52 Changeset [87107] by
-
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sheriffbot should give more details about the failures in IRC
https://bugs.webkit.org/show_bug.cgi?id=61233
With this patch, sheriffbot will annonce the set of failing tests,
which might help folks triage the problem.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 16:50 Changeset [87106] by
-
2011-05-23 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297
The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.
No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.
- loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType):
2011-05-23 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
fix rel=prerender target types
https://bugs.webkit.org/show_bug.cgi?id=61297
The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
didn't properly map the target type, and didn't carry the target
types through to chromium properly. Fixed.
No new tests; it's very hard to catch these with a layout test, however
all of the chromium Prerender browser tests will test this functionality
when I land an upcoming chromium CL.
- public/WebURLRequest.h:
- 16:43 Changeset [87105] by
-
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Check in failing test expectations after r87096.
They are tracked by the bugs 61319, 61320, and 61322.
- platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- platform/gtk/fast/events/selectstart-by-drag-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-drag-expected.txt: Added.
- platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
- platform/win/fast/events/selectstart-by-drag-expected.txt: Added.
- 16:14 Changeset [87104] by
-
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Chromium test fix. On Chromium Windows, a space after a word is selected when you double click on the word.
- fast/events/selectstart-by-double-triple-clicks.html:
- 15:33 Changeset [87103] by
-
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
- wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.
- platform/graphics/FloatRect.cpp: (WebCore::enclosingIntRect):
- 15:22 Changeset [87102] by
-
2011-05-20 Jeremy Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220
No new tests, because DumpRenderTree does not currently "animate" the full-screen transition.
There are three issues animating video content to full screen which this patch is meant to
address:
1) The animation scales between the client sizes of the element before and after full-screen.
Because these sizes have different aspect ratios, the video appears "squished" for part of
the animation. Instead, we will animate between the content box sizes before and after full
screen which, in the case of video now and object-fit content in the future, will have the
same aspect ratio before and after full screen.
2) Now that we are animating the full-screen video element's content box, the black letterbox
bars appear above and below the video (depending on the video's aspect ratio) as soon as the
animation begins. This is extremely jarring, so set the background color to clear. The
full-screen renderer's background color will serve the same purpose (providing the letterbox
background) once the animation completes.
3) Now that the letterbox color is gone, the full screen controls can appear to float in thin
air beneath the video (again, depending on aspect ratio) during the animation, so to avoid
that effect and to make the animation consistent with the old webkitenterfullscreen()
animation, we will hide the controls during the animation by adding a new CSS pseudo class
-webkit-animating-full-screen-transition.
Added a new css pseudo-class: -webkit-animating-full-screen. During the transition animation, this
pseudo-class will be applied to the current full-screen element. Styles have been added to
fullscreenQuickTime.css to hide the video element's built-in controller during the full-screen
animation.
To accomplish this, the ivar tracking whether the full-screen animation is taking place has been moved
from the RenderFullScreen renderer, to the current full-screen Document. Because changing
isAnimatingFullScreen causes style changes, make sure to call recalcStyle on the full-screen element
after changing.
This extra transition caused assertions in HTMLFormControlElement::updateFromElementCallback. A
full-screen media control's renderer is disabled during the style recalculation when exiting full
screen. This assertion was exposed by the extra recalcStyle() issued during the exit transition, and
has been removed.
- WebCore.exp.in:
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Add support for new pseudo class -webkit-animate-full-screen-transition. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- css/fullscreen.css: (video:-webkit-full-screen): Set full screen video background color to clear.
- css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-panel): Set a default opacity transition. (video:-webkit-animating-full-screen::-webkit-media-controls-panel): Set the opacity to 0 and
disable the transition.
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitWillEnterFullScreenForElement): Call our new setAnimatingFullScreen function. (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto. (WebCore::Document::webkitWillExitFullScreenForElement): Ditto. (WebCore::Document::webkitDidExitFullScreenForElement): Ditto. (WebCore::Document::isAnimatingFullScreen): Moved here from RenderFullScreen. (WebCore::Document::setAnimatingFullScreen): Ditto.
- dom/Document.h:
- html/HTMLFormControlElement.cpp: (WebCore::updateFromElementCallback): Use the Document's isAnimatingFullScreen function.
- page/FrameView.cpp: (WebCore::isDocumentRunningFullScreenAnimation): Ditto.
- rendering/RenderFullScreen.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto. (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
- rendering/style/RenderStyleConstants.h:
2011-05-20 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Video looks squished when animating to full screen.
https://bugs.webkit.org/show_bug.cgi?id=61220
Instead of scaling between the client sizes of the full-screen element before and after
entering full-screen, scale between their content boxes. The difference is that the client
sizes can have different aspect ratios, and thus the animation can end up "squishing" the
content at one end of the animation. When animating between the two content box sizes, their
aspect ratios (for the case of video) are equal, so the animation will appear to scale
smoothly between the two states without "squishing" the content.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Set the destination frame
to be the content box of the current full screen element.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
- 15:15 Changeset [87101] by
-
2011-05-23 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change RenderBlock hit testing to use IntPoint instead x,y pair
https://bugs.webkit.org/show_bug.cgi?id=61146
Covered by existing tests.
- platform/graphics/IntPoint.h: (WebCore::toSize): Add toSize function for converting from point to size.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
- rendering/RenderBlock.h: Change hit testing code in RenderBlock to use IntPoint.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderListBox.h: Change overridden method to use IntPoint.
- 15:11 Changeset [87100] by
-
Merge 87098 - 2011-05-23 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
BUG=83012
Review URL: http://codereview.chromium.org/7064010
- 14:50 Changeset [87099] by
-
2011-05-23 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Skia: Need to implement GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41311
No new tests.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::setPathFromConvexPoints): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::clipConvexPolygon):
- 14:29 Changeset [87098] by
-
2011-05-23 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Convert raw pointer to RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=61196
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
- 14:06 Changeset [87097] by
-
2011-05-23 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] Link tcmalloc to DRT so we can use the heap checker
https://bugs.webkit.org/show_bug.cgi?id=61292
- WebKit.gyp:
- 13:49 Changeset [87096] by
-
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Alexey Proskuryakov.
selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489
Added tests to ensure selectstart is dispatches exactly once when selecting text by a mouse drag,
a mouse click, a double click, or a triple click. Also rebaselined a test that previously logged
extra selectstart dispatches.
- fast/events/selectstart-by-double-triple-clicks-expected.txt: Added.
- fast/events/selectstart-by-double-triple-clicks.html: Added.
- fast/events/selectstart-by-drag.html:
- fast/events/selectstart-by-single-click-with-shift-expected.txt: Added.
- fast/events/selectstart-by-single-click-with-shift.html: Added.
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Alexey Proskuryakov.
selectstart is fired for every mouse move
https://bugs.webkit.org/show_bug.cgi?id=19489
Fixed the bug by dispatching selectstart event immediately before modifying selection in
handleMousePressEventSingleClick and updateSelectionForMouseDrag.
Also replaced a boolean EventHandler::m_beganSelectingText by an enum-valued m_selectionInitiationState
to retain 3 states:
- HaveNotStartedSelection - Selection has not been set by a mouse drag or a mouse click
- PlacedCaret - A caret was placed by a mouse click, double click, or triple click, and is about to replace selection if a mouse drag never occurs.
- ExtendedSelection - A range selection was set by a mouse click, a double click, a triple click, or a mouse drag; otherwise a caret selection was set by a mouse drag.
State 1 corresponds to m_beganSelectingText being false and state 3 corresponds to m_beganSelectingText
being true. State 2 is used in updateSelectionForMouseDrag to avoid dispatching selectstart twice.
States 1 and 2 are set by updateSelectionForMouseDownDispatchingSelectStart and state 3 is set by
updateSelectionForMouseDrag.
Test: fast/events/selectstart-by-double-triple-clicks.html
fast/events/selectstart-by-drag.html
fast/events/selectstart-by-single-click-with-shift.html
- page/EventHandler.cpp: Removed canMouseDragExtendSelect. (WebCore::EventHandler::EventHandler): Initializes m_selectionInitiationState. (WebCore::dispatchSelectStart): Returns true only if selectstart was successfully fired and default action was not prevented. (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Updates m_selectionInitiationState and modifies the selection if dispatchSelectStart returns true. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls updateSelectionForMouseDownDispatchingSelectStart. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::canMouseDownStartSelect): No longer dispatches startselect; also renamed from EventHandler::canMouseDownStartSelect. (WebCore::EventHandler::handleMousePressEvent): No longer calls canMouseDragExtendSelect. (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): Exit early if m_selectionInitiationState is HaveNotStartedSelection and dispatchSelectStart returns false. Since setSelectionIfPossible dispatches selectstart event before assigning PlacedCaret or ExtendedSelection to m_selectionInitiationState, there is no need to dispatch event for those two cases. (WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h: Removed canMouseDownStartSelect and canMouseDragExtendSelect from EventHandler and added setSelectionIfPossible.
- 13:47 Changeset [87095] by
-
2011-05-23 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155
Covered by existing tests: fast/filesystem/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry.html
fast/filesystem/workers/file-from-file-entry-sync.html
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Updated to call createWithName().
- fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
- fileapi/File.cpp: (WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup. (WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method. (WebCore::File::File):
- fileapi/File.h: (WebCore::File::createWithName):
- html/FileInputType.cpp: (WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
- 13:40 Changeset [87094] by
-
2011-05-23 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164
- platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord):
2011-05-23 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix division by zero in TilingData for boundary case texture sizes
https://bugs.webkit.org/show_bug.cgi?id=61164
Add additional tests for small max texture sizes.
- tests/TilingDataTest.cpp: (WebCore::TEST):
- 13:21 Changeset [87093] by
-
2011-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Terminating a WebProcess should work even while a page is being closed
<rdar://problem/8934632>
https://bugs.webkit.org/show_bug.cgi?id=61299
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess): Change validity check to only check for process validity, since terminating the process of a page that is closed or is closing is acceptable behavior.
- 12:59 Changeset [87092] by
-
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Unskip passing transitions tests
https://bugs.webkit.org/show_bug.cgi?id=61246
- platform/qt/Skipped:
- platform/qt/transitions/move-after-transition-expected.txt: Added.
- platform/qt/transitions/transition-end-event-rendering-expected.txt: Added.
- 12:54 Changeset [87091] by
- 12:47 Changeset [87090] by
-
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683
This test actually passes before this patch anyway. I don't think this
patch is actually observable in any meaningful way.
- fast/images/busted-oval-does-not-render-expected.txt: Added.
- fast/images/busted-oval-does-not-render.html: Added.
- fast/images/resources/busted-oval.png: Added.
2011-05-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update ImageDecoder::create to match sniffing spec
https://bugs.webkit.org/show_bug.cgi?id=47683
This change is difficult to test. We're making this change to comply
with standards even if the change is difficult to observe. (This patch
also causes us to match Firefox.)
Test: fast/images/busted-oval-does-not-render.html
- platform/image-decoders/ImageDecoder.cpp:
- 12:05 Changeset [87089] by
-
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
- JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
No new tests, just changing gyp defines.
- WebCore.gyp/WebCore.gyp:
2011-05-23 Ruben <chromium@hybridsource.org>
Reviewed by Tony Chang.
Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
https://bugs.webkit.org/show_bug.cgi?id=61219
- WebKit.gyp:
- WebKit.gypi:
- 11:52 Changeset [87088] by
-
Merge 86725
BUG=81949
Review URL: http://codereview.chromium.org/7067001
- 11:51 Changeset [87087] by
-
[Qt] When opening a combo-box the popup renders badly.
https://bugs.webkit.org/show_bug.cgi?id=61288
Reviewed by Andreas Kling.
Removing combobox palette changes from QtFallbackWebPopup::show() because they
are causing rendering problems for some styles.
The changes in palette are not needed because the background and foreground
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
in method QtFallbackWebPopup::populate().
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::show):
- 11:47 Changeset [87086] by
-
Merge 86665
BUG=82416
Review URL: http://codereview.chromium.org/7065004
- 11:44 Changeset [87085] by
-
Merge 86976
BUG=83235
Review URL: http://codereview.chromium.org/7065003
- 11:41 Changeset [87084] by
-
Merge 87083
BUG=83598
Review URL: http://codereview.chromium.org/6966014
- 11:27 Changeset [87083] by
-
2011-05-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that we do not crash when parsing css color for integer or
percentage values.
https://bugs.webkit.org/show_bug.cgi?id=61293
- fast/css/parse-color-int-or-percent-crash-expected.txt: Added.
- fast/css/parse-color-int-or-percent-crash.html: Added.
2011-05-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Terminate css color parsing on integers which are not followed
by a terminator.
https://bugs.webkit.org/show_bug.cgi?id=61293
Test: fast/css/parse-color-int-or-percent-crash.html
- css/CSSParser.cpp: (WebCore::parseColorIntOrPercentage):
- 11:07 Changeset [87082] by
-
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914
Added a test to ensure WebKit does not clone hierarchy to preserve background color.
Also renamed editing/pasteboard/do-not-copy-body-color.html to do-no-clone-unnecessary-styles.html
and updated the description to match new behavior. While this test ensures WebKit does not copy
body's background color when it's not fully selected, this isn't a necessary requirement for us
not to duplicate borders so new expected result is correct.
- editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Some spans became style spans.
- editing/pasteboard/do-no-clone-unnecessary-styles-2-expected.txt: Added.
- editing/pasteboard/do-no-clone-unnecessary-styles-2.html: Added.
- editing/pasteboard/do-no-clone-unnecessary-styles-expected.txt: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color-expected.txt.
- editing/pasteboard/do-no-clone-unnecessary-styles.html: Renamed from LayoutTests/editing/pasteboard/do-not-copy-body-color.html.
2011-05-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
REGRESSION(r84311): WebKit copies too much styles when copying
https://bugs.webkit.org/show_bug.cgi?id=60914
The bug was caused by WebKit's cloning node hierarchy up until the node that has background color.
Fixed the bug by not cloning background color and adding the effective background color to the wrapping
style span.
Tests: editing/pasteboard/do-no-clone-unnecessary-styles-2.html
editing/pasteboard/do-no-clone-unnecessary-styles.html
- editing/EditingStyle.cpp: (WebCore::cssValueToRGBA): Extracted from getRGBAFontColor. (WebCore::getRGBAFontColor): Moved. (WebCore::rgbaBackgroundColorInEffect): Added. (WebCore::EditingStyle::init): Added support for InheritablePropertiesAndBackgroundColorInEffect. (WebCore::EditingStyle::prepareToApplyAt): Include the effective background color at the given position. Also remove the background color property when the effective background color is equal to the background color property (in terms of RGBA value) of the editing style. (WebCore::hasTransparentBackgroundColor): Moved from Editor class. (WebCore::backgroundColorInEffect): Extracted from Editor::selectionStartCSSPropertyValue.
- editing/EditingStyle.h: Added prototypes for hasTransparentBackgroundColor and backgroundColorInEffect.
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls backgroundColorInEffect.
- editing/Editor.h: Removed hasTransparentBackgroundColor.
- editing/markup.cpp: (WebCore::isElementPresentational): Reverted r85090 and r84311. (WebCore::createMarkup): Include the background color in effect when computing the editing style.
- 11:07 QtWebKitRelease21 edited by
- (diff)
- 11:06 QtWebKitRelease21 edited by
- (diff)
- 11:04 QtWebKit edited by
- (diff)
- 11:00 QtWebKitRelease21 edited by
- (diff)
- 10:59 Changeset [87081] by
-
2011-05-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content
https://bugs.webkit.org/show_bug.cgi?id=45889
Add a regression test now that the bug has been fixed by r87067.
- fast/forms/delete-text-with-invisible-br-expected.txt: Added.
- fast/forms/delete-text-with-invisible-br.html: Added.
- 10:59 QtWebKitFeatures21 edited by
- (diff)
- 10:56 Changeset [87080] by
-
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87078.
http://trac.webkit.org/changeset/87078
https://bugs.webkit.org/show_bug.cgi?id=61294
Patch contains errors and seems likely to break a bunch of
bots (Requested by abarth on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- 10:47 Changeset [87079] by
-
2011-05-23 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983
Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.
No new tests. (refactoring)
- dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
- dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
- dom/Node.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
- 10:28 Changeset [87078] by
-
2011-05-23 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- 10:15 Changeset [87077] by
-
[Windows] Initial Cookie Accept Policy not set on Deserialized Storage Session.
https://bugs.webkit.org/show_bug.cgi?id=61255
Reviewed by Darin Adler.
- WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Move the code to set the cookie policy before the early return that is taken when using the
default storage session from the UI Process.
Also, remove unnecessary #ifdefs (USE(CFURLSTORAGESESSIONS) is true if USE(CFNETWORK) is
true) and add a comment explaining the early return.
- 09:40 Changeset [87076] by
-
2011-05-23 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Gavin Barraclough.
[SH4] AssemblerLabel does not name a type
https://bugs.webkit.org/show_bug.cgi?id=59927
SH4Assembler.h file shoold be included before AbstractMacroAssembler.h.
- assembler/MacroAssemblerSH4.h:
- 09:05 Changeset [87075] by
-
2011-05-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Move generation of shell_command from port to executive
https://bugs.webkit.org/show_bug.cgi?id=61251
After move it's possible to use the code in other places too.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/system/executive.py:
- 08:07 Changeset [87074] by
-
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267
All methods of WorkerContextInspectorProxy are inlined in WorkerContextProxy and
the class itself is removed. Messages from worker inspector to page inspector
are sent by means of WorkerReportingProxy.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker): (WebCore::InspectorWorkerAgent::sendMessageToWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
- inspector/InspectorWorkerAgent.h:
- inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postMessageToPageInspector):
- workers/WorkerContextInspectorProxy.h: Removed.
- workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::PageInspector::~PageInspector): (WebCore::WorkerContextProxy::connectToInspector): (WebCore::WorkerContextProxy::disconnectFromInspector): (WebCore::WorkerContextProxy::sendMessageToInspector):
- workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
2011-05-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Web Inspector: provide initial implementation of worker inspector transport
https://bugs.webkit.org/show_bug.cgi?id=60267
WebWorker and WebWorkerClient are extended with methods for passing
DevTools messages between worker context inspector and page inspector.
- public/WebWorker.h: (WebKit::WebWorker::attachDevTools): (WebKit::WebWorker::detachDevTools): (WebKit::WebWorker::dispatchDevToolsMessage):
- public/WebWorkerClient.h: (WebKit::WebWorkerClient::dispatchDevToolsMessage):
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToPageInspector): (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
- src/WebWorkerBase.h:
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::connectToInspector): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::sendMessageToInspector): (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
- src/WebWorkerClientImpl.h:
- src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::connectToWorkerContextInspectorTask): (WebKit::WebWorkerImpl::attachDevTools): (WebKit::disconnectFromWorkerContextInspectorTask): (WebKit::WebWorkerImpl::detachDevTools): (WebKit::dispatchOnInspectorBackendTask): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
- src/WebWorkerImpl.h:
- 07:30 Changeset [87073] by
-
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285
broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-har-headers-expected.txt: Removed.
- http/tests/inspector/resource-har-headers.html: Removed.
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resources-test.js:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87070.
http://trac.webkit.org/changeset/87070
https://bugs.webkit.org/show_bug.cgi?id=61285
broke resource-parameters.html on win, weird failures on wk2
(Requested by caseq on #webkit).
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildContent): (WebInspector.HAREntry.prototype._buildCookie): (WebInspector.HAREntry.prototype._interval): (WebInspector.HARLog.prototype.build):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
- 07:20 Changeset [87072] by
-
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Unskip test case due to the implementation setJavaScriptCanAccessClipboard in WebKitTestRunner.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setJavaScriptCanAccessClipboard):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669
Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 06:41 Changeset [87071] by
-
2011-05-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest):
- inspector/debugger/resources/obfuscated.js: (withComments):
- inspector/debugger/script-formatter.html:
2011-05-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: source mapping for pretty-printed scripts is sometimes inaccurate after indented comments.
https://bugs.webkit.org/show_bug.cgi?id=61037
- inspector/front-end/JavaScriptFormatter.js: (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype._addComment): (FormattedContentBuilder.prototype._addText): (FormattedContentBuilder.prototype._addMappingIfNeeded):
- 06:29 Changeset [87070] by
-
2011-05-23 Mike West <mkwst@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127
Setting correct expectations for the following fields newly added to
the HAR implementation:
- entry.request.httpVersion
- entry.request.headersSize
- entry.request.bodySize
- entry.response.httpVersion
- entry.response.headersSize
- entry.response.bodySize
- entry.response.content.compression
- http/tests/inspector/network/network-size.html:
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-har-headers-expected.txt: Added.
- http/tests/inspector/resource-har-headers.html: Added.
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resources-test.js:
2011-05-23 Mike West <mkwst@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127
Specifically, this patch adds:
- entry.request.httpVersion
- entry.request.headersSize
- entry.request.bodySize
- entry.response.httpVersion
- entry.response.headersSize
- entry.response.bodySize
- entry.response.content.compression
Tests: http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildContent): (WebInspector.HAREntry.prototype._buildCookie): (WebInspector.HAREntry.prototype._interval): (WebInspector.HAREntry.prototype.get requestBodySize): (WebInspector.HAREntry.prototype.get responseBodySize): (WebInspector.HAREntry.prototype.get responseCompression): (WebInspector.HARLog.prototype.build):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.get requestHttpVersion): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype.get responseHttpVersion):
- 06:26 Changeset [87069] by
-
[Qt][WK] Skip a failing test.
- platform/qt-wk2/Skipped:
- 05:05 Changeset [87068] by
-
2011-05-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: keyboard shortcut panel is 1px too short
https://bugs.webkit.org/show_bug.cgi?id=61242
Fixed bottom margin of attached helpscreen so it's glued to status bar.
- inspector/front-end/helpScreen.css: (body.attached .help-window-outer):
- 03:10 Changeset [87067] by
-
Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179
Reviewed by Dimitri Glazkov.
Source/WebCore:
By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:
<textarea> --(shadow-connection)-- <div> -- ...
After the change:
<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...
The goals of this change are
- Change to the new shadow DOM model, and
- Minimize the patch size.
We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.
Note: This is a re-landing for r87014 with a small fix of
Element::removeShadowRoot().
- css/html.css:
(input::-webkit-inner-spin-button):
Add vertical-align in order to avoid the button affect the baseline.
(input::-webkit-outer-spin-button): ditto.
(input::-webkit-input-speech-button): ditto.
- dom/Element.cpp:
(WebCore::Element::recalcStyle): Calls styleForRenderer() so that a
subclass of Element can override it.
(WebCore::Element::remvoeShadowRoot):
Fix a wrong parameter for willRemoveDOMNode().
(WebCore::Element::isSpellCheckingEnabled):
Handle ShadowRoot, which is not an Element.
- dom/Node.cpp: Add utility functions for editing code.
(WebCore::Node::nonBoundaryShadowTreeRootNode):
(WebCore::Node::nonShadowBoundaryParentNode):
- dom/Node.h: Declare them.
- dom/Position.cpp:
- Add some assertions about ShadowRoot
- Replace parentNode() with nonShadowBoundaryParentNode()
Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
- dom/Position.h: ditto.
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):
- editing/CompositeEditCommand.cpp: ditto.
(WebCore::CompositeEditCommand::insertNodeAfter):
(WebCore::CompositeEditCommand::removeNode):
- editing/Editor.cpp:
(WebCore::Editor::findString): ditto.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
- editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeNode): ditto.
(WebCore::ReplacementFragment::insertNodeBefore): ditto.
- editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot.
(WebCore::VisibleSelection::isAll):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
- editing/VisibleSelection.h: ditto.
- editing/htmlediting.cpp: Add assertions.
(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::create): Calls createShadowSubtree().
(WebCore::HTMLInputElement::createShadowSubtree):
Calls InputType::createShadowSubTree().
(WebCore::HTMLInputElement::innerTextElement):
Accessor of a shadow node. This is used by RenderTextControlSingleLine.
(WebCore::HTMLInputElement::innerBlockElement): ditto.
(WebCore::HTMLInputElement::innerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::outerSpinButtonElement): ditto.
(WebCore::HTMLInputElement::resultsButtonElement): ditto.
(WebCore::HTMLInputElement::cancelButtonElement): ditto.
(WebCore::HTMLInputElement::speechButtonElement): ditto.
(WebCore::HTMLInputElement::parseMappedAttribute):
Rebuild shadow trees because x-webkit-speech attribute affects it.
- html/HTMLInputElement.h: Add declarations.
- html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree().
(WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
- html/HTMLTextAreaElement.h: Declare createShadowSubtree().
- html/InputType.h: Add default implementations of accessors.
(WebCore::InputType::innerBlockElement):
(WebCore::InputType::innerTextElement):
(WebCore::InputType::innerSpinButtonElement):
(WebCore::InputType::outerSpinButtonElement):
(WebCore::InputType::resultsButtonElement):
(WebCore::InputType::cancelButtonElement):
(WebCore::InputType::speechButtonElement):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType): Initializes new data members.
(WebCore::SearchInputType::createShadowSubtree):
Moved from RenderTextControlSingleLine.
(WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
- html/SearchInputType.h: Add declarations.
(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::TextFieldInputType):
Initializes new data members.
(WebCore::TextFieldInputType::createShadowSubtree):
Moved from RenderTextControlSingleLine.
(WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
- html/TextFieldInputType.h: Add declarations.
(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::outerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
Remove shadowParent parameter. It is unnecessary because we switch to
new shadow model.
(WebCore::TextControlInnerElement::create):
Change the parameter type to Document.
(WebCore::TextControlInnerElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerBlockStyle().
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
Remove shadowParent parameter.
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
(WebCore::TextControlInnerTextElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerTextStyle().
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldResultsButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createResultButtonStyle().
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldCancelButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createCancelButtonStyle().
(WebCore::SearchFieldCancelButtonElement::detach):
Update for the parent class change.
(WebCore::SpinButtonElement::SpinButtonElement):
- Change the parameter type: shadowParent -> Document
- Add the inner flag
- Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SpinButtonElement::createInner): Introduce a new factory
method to hide a bool parameter of the constructor.
(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().
(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
- Change the parameter type: shadowParent -> Document
- Inherit HTMLDivElement, not TextControlInnerElement.
- Do not register this as a speech input listener here.
(WebCore::InputFieldSpeechButtonElement::create):
Update for the parameter change.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
Do not handle click event if listener registration is not done.
(WebCore::InputFieldSpeechButtonElement::attach):
Register this as a speech input listener.
(WebCore::InputFieldSpeechButtonElement::detach):
Update for the parent class change.
(WebCore::InputFieldSpeechButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().
- html/shadow/TextControlInnerElements.h:
(WebCore::TextControlInnerTextElement::isMouseFocusable):
Add this because the class is not a subclass of TextControllInnerElement.
(WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto.
(WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto.
(WebCore::SpinButtonElement::isMouseFocusable): ditto.
(WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code.
(WebCore::RenderTextControl::styleDidChange):
innerTextElement can have no renderer.
Explicitly call setNeedsStyleRecals() for innerTextElement. It is
needed for LayoutTests/editing/selection/select-across-readonly-input-*.html.
(WebCore::RenderTextControl::textBlockWidth): Member data -> function
(WebCore::RenderTextControl::updateFromElement): ditto.
(WebCore::RenderTextControl::setInnerTextValue): ditto.
(WebCore::RenderTextControl::hasVisibleTextArea): ditto.
(WebCore::RenderTextControl::isSelectableElement): ditto.
(WebCore::RenderTextControl::selection): ditto.
(WebCore::RenderTextControl::visiblePositionForIndex): ditto.
(WebCore::RenderTextControl::indexForVisiblePosition): ditto.
(WebCore::RenderTextControl::text): ditto.
(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
(WebCore::RenderTextControl::computeLogicalHeight): ditto.
(WebCore::RenderTextControl::hitInnerTextElement): ditto.
(WebCore::RenderTextControl::forwardEvent): ditto.
(WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
- rendering/RenderTextControl.h:
- Make m_innerText virtual function.
- Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::innerTextElement): Added.
(WebCore::RenderTextControlMultiLine::updateFromElement):
Remove unnecessary createSubtreeIfNeeded() call.
- rendering/RenderTextControlMultiLine.h: Add a declaration.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
Remove unnecessary code.
(WebCore::RenderTextControlSingleLine::innerTextElement): Added.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Added.
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added.
(WebCore::RenderTextControlSingleLine::resultsButtonElement): Added.
(WebCore::RenderTextControlSingleLine::cancelButtonElement): Added.
(WebCore::RenderTextControlSingleLine::speechButtonElement): Added.
(WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function
(WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto.
(WebCore::RenderTextControlSingleLine::layout): ditto.
(WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto.
(WebCore::RenderTextControlSingleLine::forwardEvent): ditto.
(WebCore::RenderTextControlSingleLine::styleDidChange): ditto.
(WebCore::RenderTextControlSingleLine::hasControlClip): ditto.
(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::textBlockWidth): ditto.
(WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto.
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto.
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto.
(WebCore::RenderTextControlSingleLine::updateFromElement):
ditto, and remove unnecessary createSubtreeIfNeeded() call.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
Data member -> function
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto.
(WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto.
(WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
- rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.
LayoutTests:
Update test results because the shadow tree structure of <input> and
<textarea> is changed.
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/search-zoomed-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-outline-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
- platform/gtk/editing/selection/4895428-3-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/context-no-deselect-expected.txt:
- platform/gtk/fast/forms/input-appearance-focus-expected.txt:
- platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-selection-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-paste-undo-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/gtk/fast/forms/input-text-click-inside-expected.txt:
- platform/gtk/fast/forms/input-text-click-outside-expected.txt:
- platform/gtk/fast/forms/input-text-double-click-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/input-text-option-delete-expected.txt:
- platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/fast/forms/textfield-outline-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/fast/events/context-no-deselect-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-paste-undo-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/plaintext-mode-2-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt:
- 02:41 Changeset [87066] by
-
Merge 86963 - 2011-05-20 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints disappear from ui after navigation.
https://bugs.webkit.org/show_bug.cgi?id=61133
- inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/7051034
- 02:07 Changeset [87065] by
-
[Qt][WK2] Unreviewed trivial fix after r86990.
- WebKit2.pro: Remove UIProcess/ChunkedUpdateDrawingAreaProxy.h.
- 02:01 Changeset [87064] by
-
[Qt] Unreviewed, skip new failing tests.
- platform/qt-arm/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- 01:48 Changeset [87063] by
-
2011-05-19 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Explicitly mark objects with complex GC rules.
https://bugs.webkit.org/show_bug.cgi?id=61131
From the GC point view there are two kinds of objects: the ones
that may participate in object grouping (i.e. their lifetime
depends on other objects) and the ones that never participate in
grouping (independent). V8 added support for marking persistent
handles as independent so that the GC can process the objects they
hold faster. The motivating use case here is typed arrays.
This patch adds V8-specific inherited IDL attribute
V8DependentLifetime to types used in V8GCController, which is
exactly the set of types with object lifetimes depending on other
objects. The handles for the types that are not marked with the
new attribute can be marked as independent and GC-ed faster.
- bindings/scripts/CodeGeneratorV8.pm: Added proccessing of the new attribute.
Updated test output:
- bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.h:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
Added the new attribute:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/Node.idl:
- 01:46 Changeset [87062] by
-
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266
It made more tests assert (Requested by Ossy on #webkit).
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/search-zoomed-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-outline-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
- platform/gtk/editing/selection/4895428-3-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/context-no-deselect-expected.txt:
- platform/gtk/fast/forms/input-appearance-focus-expected.txt:
- platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-selection-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-paste-undo-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/gtk/fast/forms/input-text-click-inside-expected.txt:
- platform/gtk/fast/forms/input-text-click-outside-expected.txt:
- platform/gtk/fast/forms/input-text-double-click-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/input-text-option-delete-expected.txt:
- platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/fast/forms/textfield-outline-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/fast/events/context-no-deselect-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-paste-undo-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/plaintext-mode-2-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt:
2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87014, r87016, and r87017.
http://trac.webkit.org/changeset/87014
http://trac.webkit.org/changeset/87016
http://trac.webkit.org/changeset/87017
https://bugs.webkit.org/show_bug.cgi?id=61266
It made more tests assert (Requested by Ossy on #webkit).
- css/html.css: (input::-webkit-inner-spin-button): (input::-webkit-outer-spin-button): (input::-webkit-input-speech-button):
- dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::Element::isSpellCheckingEnabled):
- dom/Node.cpp:
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::containerNode): (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::parentEditingBoundary): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree):
- dom/Position.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::findString):
- editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll):
- editing/FrameSelection.h: (WebCore::FrameSelection::shadowTreeRootNode):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): (WebCore::ReplacementFragment::insertNodeBefore):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::shadowTreeRootNode):
- editing/VisibleSelection.h:
- editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h:
- html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
- html/HTMLTextAreaElement.h:
- html/InputType.h:
- html/SearchInputType.cpp:
- html/SearchInputType.h: (WebCore::SearchInputType::SearchInputType):
- html/TextFieldInputType.cpp:
- html/TextFieldInputType.h: (WebCore::TextFieldInputType::TextFieldInputType):
- html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::TextControlInnerElement::detach): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::detach): (WebCore::SpinButtonElement::setHovered): (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
- html/shadow/TextControlInnerElements.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::setInnerTextStyle): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::hasVisibleTextArea): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition): (WebCore::RenderTextControl::text): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::computeLogicalHeight): (WebCore::RenderTextControl::hitInnerTextElement): (WebCore::RenderTextControl::forwardEvent): (WebCore::RenderTextControl::computePreferredLogicalWidths): (WebCore::RenderTextControl::innerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::decorationWidthRight): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
- rendering/RenderTextControlSingleLine.h:
- 01:27 Changeset [87061] by
-
2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>
Rubber stamped by Eric Seidel.
[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146
Move WTF_INCLUDE_DIRECTORIES to Source/JavaScriptCore/wtf/CMakeLists.txt.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
2011-05-23 Ryuan Choi <ryuan.choi@samsung.com>
Rubber stamped by Eric Seidel.
[CMAKE] Refactoring wtf related code.
https://bugs.webkit.org/show_bug.cgi?id=60146
Move wtf-files to Source/JavaScriptCore/wtf/CMakeLists.txt.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- wtf/CMakeLists.txt:
- wtf/CMakeListsEfl.txt:
- 01:14 Changeset [87060] by
-
2011-05-23 Joe Wild <joseph.wild@nokia.com>
Reviewed by Andreas Kling.
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200
- symbian/eabi/QtWebKitu.def:
- 01:07 Changeset [87059] by
-
2011-05-23 Syed Idris Shah <syed.idris-shah@nokia.com>
Reviewed by Andreas Kling.
GraphicsContext3DInternal object should be called for getAttachedShaders.
[Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61202
LayoutTests/fast/canvas/webgl/gl-object-get-calls.html
getAttachedShaders should be called on GraphicsContext3DInternal instance.
It was left out by mistake.
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getAttachedShaders): GraphicsContext3DInternal instance should be called.
- 01:02 Changeset [87058] by
-
2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r86990.
- GNUmakefile.am: Remove UpdateChunk.cpp and UpdateChunk.h.
- 00:58 Changeset [87057] by
-
2011-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Strict PassOwnPtr build fix.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::newTextCodecGtk):
- 00:50 Changeset [87056] by
-
2011-05-23 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Show "Please wait" message during initial
heap snapshot processing.
https://bugs.webkit.org/show_bug.cgi?id=61040
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView.setDataSource): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView.setDataSource): (WebInspector.DetailedHeapshotView.prototype._changeView):
- inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
- 00:11 Changeset [87055] by
-
2011-05-23 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fixes.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::create):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderTrackStyle): (WebCore::RenderThemeGtk::adjustSliderThumbStyle): (WebCore::RenderThemeGtk::adjustProgressBarStyle):
05/22/11:
- 23:56 Changeset [87054] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustProgressBarStyle):
- 23:27 Changeset [87053] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Build fix. More public destructors needed to play nice with OwnPtr.
- WebCoreSupport/InspectorClientGtk.cpp:
- 23:22 Changeset [87052] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Build fix. InspectorFrontendClient needs a public destructor so that
we can properly track ownership using OwnPtr.
- WebCoreSupport/InspectorClientGtk.h:
- 23:11 Changeset [87051] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::InspectorFrontendClient):
- 23:07 Changeset [87050] by
-
2011-05-22 Greg Simon <gregsimon@chromium.org>
Reviewed by Darin Fisher.
[chromium] Updating chromium DEPS
- DEPS:
- 23:04 Changeset [87049] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Strict PassOwnPtr build fix.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::addUserStyleSheet):
- 22:54 Changeset [87048] by
-
2011-05-22 Adam Barth <abarth@webkit.org>
Enable strict PassOwnPtr for everyone. I expect this patch will need
some followups to make the GTK and EFL bots green again.
- wtf/PassOwnPtr.h:
- 22:48 BuildingQtOnOSX edited by
- Added note about the dangers of MacPorts flex (diff)
- 18:00 WebKit Team edited by
- (diff)
- 17:48 Changeset [87047] by
-
Unreviewed.
Chromium expectations update.
- platform/chromium/test_expectations.txt: add fast/block/positioning/058.html
- 15:35 Changeset [87046] by
-
https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).
- 15:29 Changeset [87045] by
-
Rolled out <http://trac.webkit.org/changeset/87030>, which I accidentally checked into
the branch instead of trunk.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
- 15:18 Changeset [87044] by
-
2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin with html5 video player.
- symbian/platformplugin/HTML5VideoPlugin.cpp: Added. (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler): (HTML5FullScreenVideoHandler::enterFullScreen): (HTML5FullScreenVideoHandler::exitFullScreen): (HTML5FullScreenVideoHandler::onPlayerError): (HTML5FullScreenVideoHandler::onPlayerStateChanged): (HTML5FullScreenVideoHandler::onMediaStatusChanged): (HTML5VideoPlugin::supportsExtension): (HTML5VideoPlugin::createExtension):
- symbian/platformplugin/HTML5VideoPlugin.h: Added. (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (HTML5FullScreenVideoHandler::isFullScreen): (HTML5FullScreenVideoHandler::updateScreenRect):
- symbian/platformplugin/HTML5VideoWidget.cpp: Added. (HTML5VideoWidget::HTML5VideoWidget): (HTML5VideoWidget::setDuration): (HTML5VideoWidget::mousePressEvent): (HTML5VideoWidget::onPlayerStopped): (HTML5VideoWidget::onPlayerError): (HTML5VideoWidget::onEndOfMedia): (HTML5VideoWidget::onBufferingMedia): (HTML5VideoWidget::onBufferedMedia): (HTML5VideoWidget::onControlClicked): (HTML5VideoWidget::onPositionChanged): (HTML5VideoWidget::onSliderMoved): (HTML5VideoWidget::onCloseClicked): (HTML5VideoWidget::showFullScreen): (HTML5VideoWidget::setVolume):
- symbian/platformplugin/HTML5VideoWidget.h: Added.
- symbian/platformplugin/OverlayWidget.cpp: Added. (OverlayWidget::OverlayWidget): (OverlayWidget::~OverlayWidget): (OverlayWidget::setDuration): (OverlayWidget::setPosition): (OverlayWidget::setVolume): (OverlayWidget::mousePressEvent): (OverlayWidget::onPlayerStopped): (OverlayWidget::onPlayerError): (OverlayWidget::onEndOfMedia): (OverlayWidget::onBufferingMedia): (OverlayWidget::onBufferedMedia): (OverlayWidget::timeToString): (OverlayWidget::applyStyleSheet): (OverlayWidget::onControlClicked): (OverlayWidget::onSliderMoved): (OverlayWidget::onSoundClicked): (OverlayWidget::onCloseClicked): (OverlayWidget::onVolumeSliderReleased): (OverlayWidget::onVolumeSliderMoved): (OverlayWidget::onTimerTimeout): (OverlayWidget::showFullScreen):
- symbian/platformplugin/OverlayWidget.h: Added.
- symbian/platformplugin/PlayerButton.cpp: Added. (PlayerButton::PlayerButton): (PlayerButton::event):
- symbian/platformplugin/PlayerButton.h: Added.
- symbian/platformplugin/PlayerLabel.cpp: Added. (PlayerLabel::PlayerLabel): (PlayerLabel::onPlayerError): (PlayerLabel::startBufferingAnimation): (PlayerLabel::stopBufferingAnimation): (PlayerLabel::onAnimationTimeout):
- symbian/platformplugin/PlayerLabel.h: Added.
- symbian/platformplugin/WebPlugin.cpp: (WebPlugin::createExtension):
- symbian/platformplugin/images: Added.
- symbian/platformplugin/images/button_cannotplay.png: Added.
- symbian/platformplugin/images/button_close.png: Added.
- symbian/platformplugin/images/button_pause.png: Added.
- symbian/platformplugin/images/button_play.png: Added.
- symbian/platformplugin/images/button_sound_off.png: Added.
- symbian/platformplugin/images/button_sound_on.png: Added.
- symbian/platformplugin/images/loading_buffering_1.png: Added.
- symbian/platformplugin/images/loading_buffering_2.png: Added.
- symbian/platformplugin/images/loading_buffering_3.png: Added.
- symbian/platformplugin/images/loading_buffering_4.png: Added.
- symbian/platformplugin/platformplugin.pro:
- symbian/platformplugin/platformplugin.qrc: Added.
- symbian/platformplugin/qss: Added.
- symbian/platformplugin/qss/OverlayWidget.qss: Added.
- 12:33 Changeset [87043] by
-
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247
- platform/qt/Skipped: Unskip fast/encoding/mailto-always-utf-8.html
- platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Removed.
- platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Removed.
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
2011-05-22 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Fix policyDelegate in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=61247
Use the 'policy delegate' implemented in FrameLoaderClient
for layout tests. The partial implementation in DumpRenderTreeQt
is redundant, so remove it.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::acceptNavigationRequest):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitForPolicyDelegate):
- 11:52 Changeset [87042] by
-
Versioning.
- 11:51 Changeset [87041] by
-
New tag.
- 11:08 Changeset [87040] by
-
2011-05-22 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use double quotes for filename arguments
https://bugs.webkit.org/show_bug.cgi?id=61250
Windows does not support single quotes on the command line,
so replace them with double quotes.
- Scripts/prepare-ChangeLog:
- 10:35 Changeset [87039] by
-
Merge r86972.
- 10:33 Changeset [87038] by
-
Merge r86967.
- 10:31 Changeset [87037] by
-
Merge r86956.
- 10:28 Changeset [87036] by
-
Merge r86924.
- 10:26 Changeset [87035] by
-
Merge r86904.
- 10:23 Changeset [87034] by
-
Merge r86895.
- 10:16 Changeset [87033] by
-
Merge r86779.
- 09:56 Changeset [87032] by
-
2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897
Tests are in WebKit/qt/tests/hybridPixmap
- bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapToImageDataMethod::name): (JSC::Bindings::QtPixmapToImageDataMethod::invoke): (JSC::Bindings::QtPixmapToImageDataMethod::copyPixels): (JSC::Bindings::QtPixmapClass::methodsNamed): (JSC::Bindings::QtPixmapInstance::getPropertyNames): Add toImageData() to Qt Bridge, alternative to assignToHTMLImageElement().
2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Benjamin Poulain.
[Qt] Implement toImageData() in QtWebKit Bridge
https://bugs.webkit.org/show_bug.cgi?id=60897
- docs/qtwebkit-bridge.qdoc:
- docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction): Document Qt bridge toImageData() feature.
- tests/hybridPixmap/test.html:
- tests/hybridPixmap/widget.cpp: (Widget::Widget): (Widget::abcImage):
- tests/hybridPixmap/widget.h: Add tests for Qt bridge toImageData() feature.
- 09:48 Changeset [87031] by
-
2011-05-22 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Don't call WebKit::initializeLogChannelsIfNecessary if logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61249
- UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Check #if !LOG_DISABLED, not #ifndef NDEBUG, to decide whether to call WebKit::initializeLogChannelsIfNecessary().
- 09:27 Changeset [87030] by
-
https://bugs.webkit.org/show_bug.cgi?id=61244
<rdar://problem/9482856>
Undo operations for a web page linger after page is destroyed
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::closePage):
Clear editing commands before telling UI client to close the page (this must be done
while the page is still in a window so its undo manager can be accessed, so waiting
for WebPageProxy::close() is too late).
- 08:56 Changeset [87029] by
-
2011-05-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
- platform/mac/Skipped: Unskip shadow tests.
2011-05-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
When removing a shadow root, also remove it from the render tree.
https://bugs.webkit.org/show_bug.cgi?id=61245
Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html
- dom/Element.cpp: (WebCore::Element::removeShadowRoot): Call detach if attached.
- 03:13 Changeset [87028] by
-
2011-05-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Don't do manually style resolution for SVGElements with renderer
https://bugs.webkit.org/show_bug.cgi?id=59176
General clean-up.
Don't resolve style manually, instead ask the RenderObject for its style.
Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.
No new tests needed. No change of behavior.
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDropShadowElement.cpp: (WebCore::SVGFEDropShadowElement::build):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/svgattrs.in:
05/21/11:
- 23:58 Changeset [87027] by
-
2011-05-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467
The SVGSVGElement shouldn't be the target of a mouse event, if its pointer-events attribute is set
to 'none'. This matches the behavior on Firefox where an embedded SVG element is the target of an event,
if none of its childs caught the event. This is the case for all pointer-events other than 'none'.
Tests: svg/custom/pointer-events-on-svg-with-pointer.xhtml
svg/custom/pointer-events-on-svg-without-pointer.xhtml
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
2011-05-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r66731): pointer-events are broken in some cases
https://bugs.webkit.org/show_bug.cgi?id=45467
Check that an embedded SVG element doesn't have a pointer, if pointer-events is set to 'none'.
- svg/custom/pointer-events-on-svg-with-pointer-expected.txt: Added.
- svg/custom/pointer-events-on-svg-with-pointer.xhtml: Added.
- svg/custom/pointer-events-on-svg-without-pointer-expected.txt: Added.
- svg/custom/pointer-events-on-svg-without-pointer.xhtml: Added.
- 21:44 Changeset [87026] by
-
<rdar://problem/9479926> REGRESSION (r82144): Icon overlaps text in Twitter message dialog
https://bugs.webkit.org/show_bug.cgi?id=61241
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/block/positioning/start-ignoring-before.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Added a boolean parameter saying
whether to merge the first trailing space with the line break.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): When adding a midpoint behind the current
character, account for trailing positioned objects that occurred after the midpoint by calling
updateMidpointsForTrailingBoxes(), which adds midpoints for them.
LayoutTests:
- fast/block/positioning/start-ignoring-before-expected.png: Added.
- fast/block/positioning/start-ignoring-before-expected.txt: Added.
- fast/block/positioning/start-ignoring-before.html: Added.
- 20:08 Changeset [87025] by
-
2011-05-21 Justin Schuh <jschuh@chromium.org>
Unreviewed.
Chromium expectations exception for:
fast/css/custom-font-xheight.html
- platform/chromium/test_expectations.txt:
- 17:43 Changeset [87024] by
-
2011-05-21 Justin Schuh <jschuh@chromium.org>
Unreviewed
Chromium expectations updates.
- platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
- platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 15:52 Changeset [87023] by
-
2011-05-21 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Andreas Kling.
[Qt][Symbian] WKStringCopyQString function is not exported
https://bugs.webkit.org/show_bug.cgi?id=59285
A few functions were declared twice but without the export macro.
On Symbian, the linking failed when trying to reference these functions.
- UIProcess/API/qt/qgraphicswkview.h:
- 15:30 Changeset [87022] by
-
2011-05-21 Jeremy Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
- platform/mac-wk2/Skipped: Unskip most fullscreen/ tests.
2011-05-21 Jeremy Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
- dom/Document.cpp: (WebCore::Document::fullScreenChangeDelayTimerFired): dispatchEvent can be
synchronous, so make sure to check whether the current element is
in the DOM before dispatching.
2011-05-21 Jeremy Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
WebKit2: fix failing fullscreen/full-screen-remove* tests.
https://bugs.webkit.org/show_bug.cgi?id=61027
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Call the
exit functions (was calling the enter functions).
- 13:15 Changeset [87021] by
-
2011-05-21 Justin Schuh <jschuh@chromium.org>
Unreviewed.
Chromium SVG expectations update.
- platform/chromium/test_expectations.txt:
- 12:24 Changeset [87020] by
-
2011-05-21 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079
Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.
This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.
- fast/dom/HTMLLinkElement/prerender-expected.txt: Added.
- fast/dom/HTMLLinkElement/prerender.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-05-21 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Add rel type prerender to distinguish prerender from prefetch
https://bugs.webkit.org/show_bug.cgi?id=61079
Chrome right now uses <link rel=prefetch ...> for one of two things,
to warm the cache in the same way as firefox, or to launch a speculative
rendering of a web page, for faster "loading" when the user navigates to it.
This new rel type will let us distinguish the two cases; the rel type prerender
isn't used on the web today, but the Google Web Search example prerendering application
is ready to experiment with it.
Test: fast/dom/HTMLLinkElement/prerender.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
- loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
- loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
- loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
- platform/network/ResourceRequestBase.h:
- 08:30 Changeset [87019] by
-
2011-05-21 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change RenderLineBoxList::hitTest to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61156
Change the RenderLineBoxList hit testing to use IntPoint and clean up the rect calculation.
Covered by existing tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestContents):
- rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- 06:54 Changeset [87018] by
-
2011-05-21 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change HitTestResult to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61230
Covered by existing tests.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/HitTestResult.h: (WebCore::HitTestResult::isRectBasedTest):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
- rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
- 05:41 Changeset [87017] by
-
2011-05-21 Kent Tamura <tkent@chromium.org>
[GTK] [Chromium] Update test results for r87014.
https://bugs.webkit.org/show_bug.cgi?id=54179
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt:
- platform/gtk/fast/forms/input-text-click-outside-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- 04:23 Changeset [87016] by
-
2011-05-21 Kent Tamura <tkent@chromium.org>
[Qt] Update test results for r87014.
- platform/qt/fast/events/context-no-deselect-expected.txt:
- platform/qt/fast/forms/input-text-double-click-expected.txt:
- platform/qt/fast/forms/textfield-outline-expected.txt:
- 04:04 Changeset [87015] by
-
2011-05-21 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ExtraData::~ExtraData): (WebCore::ResourceRequest::extraData): (WebCore::ResourceRequest::setExtraData):
2011-05-21 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
[chromium] add extraData field to resource requests
https://bugs.webkit.org/show_bug.cgi?id=61033
- WebKit.gypi:
- public/WebURLRequest.h: (WebKit::WebURLRequest::ExtraData::~ExtraData):
- src/WebURLRequest.cpp: (WebKit::WebURLRequest::extraData): (WebKit::WebURLRequest::setExtraData):
- tests/WebURLRequestTest.cpp: Added. (WebKit::TestExtraData::TestExtraData): (WebKit::TestExtraData::~TestExtraData): (WebKit::TEST):
- 03:47 Changeset [87014] by
-
2011-05-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179
Update test results because the shadow tree structure of <input> and
<textarea> is changed.
- editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-paste-undo-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/search-zoomed-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-outline-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
- platform/gtk/editing/selection/4895428-3-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/context-no-deselect-expected.txt:
- platform/gtk/fast/forms/input-appearance-focus-expected.txt:
- platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-selection-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-paste-undo-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/gtk/fast/forms/input-text-click-inside-expected.txt:
- platform/gtk/fast/forms/input-text-double-click-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/input-text-option-delete-expected.txt:
- platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-transformed-expected.txt:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/fast/forms/textfield-outline-expected.txt:
- platform/gtk/fast/forms/textfield-overflow-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/inserting/4960120-1-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/events/autoscroll-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-paste-undo-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-transformed-expected.txt:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/mac/fast/forms/textarea-scrollbar-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/qt/editing/inserting/4960120-1-expected.txt:
- platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
- platform/qt/editing/selection/4895428-3-expected.txt:
- platform/qt/editing/selection/4975120-expected.txt:
- platform/qt/fast/forms/input-appearance-focus-expected.txt:
- platform/qt/fast/forms/input-appearance-readonly-expected.txt:
- platform/qt/fast/forms/input-appearance-selection-expected.txt:
- platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/qt/fast/forms/input-paste-undo-expected.txt:
- platform/qt/fast/forms/input-text-click-inside-expected.txt:
- platform/qt/fast/forms/input-text-option-delete-expected.txt:
- platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/qt/fast/forms/plaintext-mode-2-expected.txt:
- platform/qt/fast/forms/search-rtl-expected.txt:
- platform/qt/fast/forms/search-transformed-expected.txt:
- platform/qt/fast/forms/search-zoomed-expected.txt:
- platform/qt/fast/forms/textfield-overflow-expected.txt:
- platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
- platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt:
2011-05-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Change text-based <input> types to the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=54179
By this change, text field inputs and textareas have one extra
shadow node at the root of shadow trees.
e.g. Before the change:
<textarea> --(shadow-connection)-- <div> -- ...
After the change:
<textarea> --(shadow-connection)-- {#shadow-root} -- <div> -- ...
The goals of this change are
- Change to the new shadow DOM model, and
- Minimize the patch size.
We should use shadowPseudoId() in the new shadow DOM model, but the
shadow elements in this patch don't use it in order to reduce the patch
size.
- css/html.css: (input::-webkit-inner-spin-button): Add vertical-align in order to avoid the button affect the baseline. (input::-webkit-outer-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
- dom/Element.cpp: (WebCore::Element::recalcStyle): Calls styleForRenderer() so that a subclass of Element can override it. (WebCore::Element::isSpellCheckingEnabled): Handle ShadowRoot, which is not an Element.
- dom/Node.cpp: Add utility functions for editing code. (WebCore::Node::nonBoundaryShadowTreeRootNode): (WebCore::Node::nonShadowBoundaryParentNode):
- dom/Node.h: Declare them.
- dom/Position.cpp:
- Add some assertions about ShadowRoot
- Replace parentNode() with nonShadowBoundaryParentNode()
Because input/textarea shadow structures are changed.
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::parentEditingBoundary):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
- dom/Position.h: ditto. (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
- editing/CompositeEditCommand.cpp: ditto. (WebCore::CompositeEditCommand::insertNodeAfter): (WebCore::CompositeEditCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::findString): ditto.
- editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): Inline shadowTreeRootNode() calls.
- editing/FrameSelection.h: Remove shadowTreeRootNode(). It is used only by FrameSelection::selectAll().
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use nonShadowBoundaryParentNode()
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNode): ditto. (WebCore::ReplacementFragment::insertNodeBefore): ditto.
- editing/VisibleSelection.cpp: Rename shadowTreeRootNode() to nonBoundaryShadowTreeRootNode(), and it reutrns a child node of ShadowRoot. (WebCore::VisibleSelection::isAll): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): (WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
- editing/VisibleSelection.h: ditto.
- editing/htmlediting.cpp: Add assertions. (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create): Calls createShadowSubtree(). (WebCore::HTMLInputElement::createShadowSubtree): Calls InputType::createShadowSubTree(). (WebCore::HTMLInputElement::innerTextElement): Accessor of a shadow node. This is used by RenderTextControlSingleLine. (WebCore::HTMLInputElement::innerBlockElement): ditto. (WebCore::HTMLInputElement::innerSpinButtonElement): ditto. (WebCore::HTMLInputElement::outerSpinButtonElement): ditto. (WebCore::HTMLInputElement::resultsButtonElement): ditto. (WebCore::HTMLInputElement::cancelButtonElement): ditto. (WebCore::HTMLInputElement::speechButtonElement): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): Rebuild shadow trees because x-webkit-speech attribute affects it.
- html/HTMLInputElement.h: Add declarations.
- html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create): Calls createShadowSubtree().
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create): Calls createShadowSubtree(). (WebCore::HTMLTextAreaElement::createShadowSubtree): Added.
- html/HTMLTextAreaElement.h: Declare createShadowSubtree().
- html/InputType.h: Add default implementations of accessors. (WebCore::InputType::innerBlockElement): (WebCore::InputType::innerTextElement): (WebCore::InputType::innerSpinButtonElement): (WebCore::InputType::outerSpinButtonElement): (WebCore::InputType::resultsButtonElement): (WebCore::InputType::cancelButtonElement): (WebCore::InputType::speechButtonElement):
- html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): Initializes new data members. (WebCore::SearchInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::SearchInputType::destroyShadowSubtree): Clear element references.
- html/SearchInputType.h: Add declarations. (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initializes new data members. (WebCore::TextFieldInputType::createShadowSubtree): Moved from RenderTextControlSingleLine. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear element references.
- html/TextFieldInputType.h: Add declarations. (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::outerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement): (WebCore::TextFieldInputType::setInnerTextElement): (WebCore::TextFieldInputType::setSpeechButtonElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
Remove shadowParent parameter. It is unnecessary because we switch to
new shadow model.
(WebCore::TextControlInnerElement::create):
Change the parameter type to Document.
(WebCore::TextControlInnerElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerBlockStyle().
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
Remove shadowParent parameter.
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::TextControlInnerTextElement::create): Remove shadowParent parameter.
(WebCore::TextControlInnerTextElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerTextStyle().
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldResultsButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createResultButtonStyle().
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SearchFieldCancelButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createCancelButtonStyle().
(WebCore::SearchFieldCancelButtonElement::detach):
Update for the parent class change.
(WebCore::SpinButtonElement::SpinButtonElement):
- Change the parameter type: shadowParent -> Document
- Add the inner flag
- Inherit HTMLDivElement, not TextControlInnerElement.
(WebCore::SpinButtonElement::createInner): Introduce a new factory
method to hide a bool parameter of the constructor.
(WebCore::SpinButtonElement::createOuter): ditto.
(WebCore::SpinButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createInnerSpinButtonStyle() or
createOuterSpinButtonStyle().
(WebCore::SpinButtonElement::detach): Update for the parent class change.
(WebCore::SpinButtonElement::setHovered): ditto.
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
- Change the parameter type: shadowParent -> Document
- Inherit HTMLDivElement, not TextControlInnerElement.
- Do not register this as a speech input listener here.
(WebCore::InputFieldSpeechButtonElement::create):
Update for the parameter change.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
Do not handle click event if listener registration is not done.
(WebCore::InputFieldSpeechButtonElement::attach):
Register this as a speech input listener.
(WebCore::InputFieldSpeechButtonElement::detach):
Update for the parent class change.
(WebCore::InputFieldSpeechButtonElement::styleForRenderer):
Override this in order to set style by
RenderTextControlSingleLine::createSpeechButtonStyle().
- html/shadow/TextControlInnerElements.h: (WebCore::TextControlInnerTextElement::isMouseFocusable): Add this because the class is not a subclass of TextControllInnerElement. (WebCore::SearchFieldResultsButtonElement::isMouseFocusable): ditto. (WebCore::SearchFieldCancelButtonElement::isMouseFocusable): ditto. (WebCore::SpinButtonElement::isMouseFocusable): ditto. (WebCore::InputFieldSpeechButtonElement::isMouseFocusable): ditto.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::~RenderTextControl): Remove unnecessary code. (WebCore::RenderTextControl::styleDidChange): innerTextElement can have no renderer. Explicitly call setNeedsStyleRecals() for innerTextElement. It is needed for LayoutTests/editing/selection/select-across-readonly-input-*.html. (WebCore::RenderTextControl::textBlockWidth): Member data -> function (WebCore::RenderTextControl::updateFromElement): ditto. (WebCore::RenderTextControl::setInnerTextValue): ditto. (WebCore::RenderTextControl::hasVisibleTextArea): ditto. (WebCore::RenderTextControl::isSelectableElement): ditto. (WebCore::RenderTextControl::selection): ditto. (WebCore::RenderTextControl::visiblePositionForIndex): ditto. (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::text): ditto. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::computeLogicalHeight): ditto. (WebCore::RenderTextControl::hitInnerTextElement): ditto. (WebCore::RenderTextControl::forwardEvent): ditto. (WebCore::RenderTextControl::computePreferredLogicalWidths): ditto.
- rendering/RenderTextControl.h:
- Make m_innerText virtual function.
- Make createInnerTextStyle() public in order that TextControlInnerElements can call it.
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::innerTextElement): Added. (WebCore::RenderTextControlMultiLine::updateFromElement): Remove unnecessary createSubtreeIfNeeded() call.
- rendering/RenderTextControlMultiLine.h: Add a declaration.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): Remove unnecessary code. (WebCore::RenderTextControlSingleLine::innerTextElement): Added. (WebCore::RenderTextControlSingleLine::innerBlockElement): Added. (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::outerSpinButtonElement): Added. (WebCore::RenderTextControlSingleLine::resultsButtonElement): Added. (WebCore::RenderTextControlSingleLine::cancelButtonElement): Added. (WebCore::RenderTextControlSingleLine::speechButtonElement): Added. (WebCore::RenderTextControlSingleLine::textBaseStyle): Data member -> function (WebCore::RenderTextControlSingleLine::subtreeHasChanged): ditto. (WebCore::RenderTextControlSingleLine::layout): ditto. (WebCore::RenderTextControlSingleLine::nodeAtPoint): ditto. (WebCore::RenderTextControlSingleLine::forwardEvent): ditto. (WebCore::RenderTextControlSingleLine::styleDidChange): ditto. (WebCore::RenderTextControlSingleLine::hasControlClip): ditto. (WebCore::RenderTextControlSingleLine::controlClipRect): ditto. (WebCore::RenderTextControlSingleLine::textBlockWidth): ditto. (WebCore::RenderTextControlSingleLine::decorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::preferredContentWidth): ditto. (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): ditto. (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): ditto. (WebCore::RenderTextControlSingleLine::updateFromElement): ditto, and remove unnecessary createSubtreeIfNeeded() call. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Data member -> function (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingLeft): ditto. (WebCore::RenderTextControlSingleLine::clientPaddingRight): ditto. (WebCore::RenderTextControlSingleLine::textBlockInsetTop): ditto.
- rendering/RenderTextControlSingleLine.h: Add declarations, and remove unnecessary data members.
- 02:42 Changeset [87013] by
-
2011-05-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
AudioBufferSourceNode noteOff() method must respect scheduling time
https://bugs.webkit.org/show_bug.cgi?id=61226
No new tests since audio API is not yet implemented.
- webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::finish): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff):
- webaudio/AudioBufferSourceNode.h:
- 01:47 Changeset [87012] by
-
2011-05-21 Kent Tamura <tkent@chromium.org>
[Mac] Add expectation files for box-shadow-and-border-radius.html.
- platform/mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
- platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Added.
