Timeline



May 28, 2011:

9:42 PM Changeset in webkit [87633] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Suggested by Simon Fraser.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use ASSERT_UNUSED here.
7:46 PM Changeset in webkit [87632] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87624.

7:44 PM Changeset in webkit [87631] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87622.

7:42 PM Changeset in webkit [87630] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebKit2

Merge r87627.

7:41 PM Changeset in webkit [87629] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87598.

6:37 PM Changeset in webkit [87628] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Geoff Garen.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

Test: fast/dom/gc-image-element-2.html

Manually verified that tests from bug 59604 and from bug 40926 still pass.

The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::wasCanceled): (WebCore::CachedResource::errorOccurred): Track whether the load was canceled. We want to always notify clients of load outcome, as that's the only way they could make intelligent decisions.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now get a notifyFinished call on cancellation. Handle this case, where we don't need the execute the script, but also don't need to fire an error event.
  • html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single function call now.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large window between when CachedResource::isLoading() becomes false and events are queued. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting an event to fire.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do anything on cancellation.
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to give an accurate result while looping over the list of events to dispatch. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to switch to a broken image icon, or to dispatch events. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching list, as the event is no longer pending when it's being dispatched.
  • loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one is already pending, we only care if one is expected at some time in the future, and !haveFiredLoadEvent() is our best idea of that.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to handle cancellation.
4:45 PM Changeset in webkit [87627] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

2011-05-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Maciej Stachowiak.

Denying access to your keychain on login crashes WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61695
<rdar://problem/9520570>

Fix two sources of crashes if you hit the Deny button when WebKit2 is
doing HTTP authentication.

First, SecKeychainItemRequestData::attributeList() failed to initialize the
length and data members of SecKeychainAttributes in the list if there was no data.
This caused invalid memory reads later.

Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
would cause a later crash in a system framework, which is not set up to handle
errors. Instead, we always return noErr, and allow the authentication to fail.

Finally, paranoically initialize the SecKeychainItemContext in two places
to avoid uninitialized data members, and initialize length and outData
to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
fails to set them on error.

  • Shared/mac/SecKeychainItemRequestData.cpp: (WebKit::SecKeychainItemRequestData::attributeList):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::secKeychainItemCopyContent):
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCopyContent): (WebKit::webSecKeychainItemCreateFromContent):
3:26 PM Changeset in webkit [87626] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS builds patches that fail to build twice, which seems useless and slows down the bots
https://bugs.webkit.org/show_bug.cgi?id=55585

This patch switches all the early warning system bots over to the new
PatchAnalysisTask-based infrastructure. This patch makes these bots
more efficient (in the case where patches fail to build) and paves the
way for running tests on these bots!

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
2:45 PM Changeset in webkit [87625] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-28 Martin Robinson <mrobinson@igalia.com>

Skip a failing test and better classify some existing skipped tests.

  • platform/gtk/Skipped: Update the skipped list.
1:39 PM Changeset in webkit [87624] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r86578): Flash content missing from mercurynews.com
https://bugs.webkit.org/show_bug.cgi?id=61691
<rdar://problem/9519893>

If the plug-in doesn't have access to the toplevel URL, make sure to
return *something* to the plug-in.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
12:59 PM Changeset in webkit [87623] by abarth@webkit.org
  • 23 edits in trunk/Source

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::cancelledError): (WebCore::FrameLoaderClientQt::blockedError): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest): (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::cancelledError): (WebCore::FrameLoaderClientEfl::blockedError):
  • ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): (ewk_frame_uri_changed):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_frame_create): (ewk_view_plugin_create):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

As far as I can tell, all the callers of this API are confused. There
seems to be a cargo cult of using the "pretty" version of a URL, but in
reality folks just want the URL itself. The only case I'm unsure about
is location.href, which could have some compatibility constraints.
I've renamed prettyURL to deprecatedString to discourage folks from
further cargo-culting.

  • WebCore.exp.in:
  • page/Location.cpp: (WebCore::Location::href): (WebCore::Location::toString):
  • platform/KURL.cpp: (WebCore::KURL::deprecatedString):
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURL::deprecatedString):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::href): (WebCore::WorkerLocation::toString):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::cancelledError): (WebKit::blockedError):
12:41 PM Changeset in webkit [87622] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-28 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Mouse clicks propagate outside full-screen media controls.
https://bugs.webkit.org/show_bug.cgi?id=61689

Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block

propagation of all mouse click events.

(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):

Renamed from setDefaultHandled.

(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

  • html/shadow/MediaControlElements.h:
11:49 AM Changeset in webkit [87621] by mrowe@apple.com
  • 5 edits in tags/Safari-534.40.1/Source

Versioning.

11:37 AM Changeset in webkit [87620] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40.1

New tag.

11:37 AM Changeset in webkit [87619] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87331.

11:18 AM Changeset in webkit [87618] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
10:55 AM Changeset in webkit [87617] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
10:02 AM Changeset in webkit [87616] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial lyAligned
https://bugs.webkit.org/show_bug.cgi?id=61606

Removed duplicated statement within if condition.

No new tests. Obvious clean up patch.

  • page/SpatialNavigation.cpp: (WebCore::areRectsPartiallyAligned):
9:16 AM Changeset in webkit [87615] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, clean up GPU tests expectations

8:43 AM Changeset in webkit [87614] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX when building only the interpreter

Fixes the following compiler warning:

JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]

void releaseExecutableMemory(JSGlobalData& globalData)


  • jit/ExecutableAllocator.h: Moved declaration of

JSC::releaseExecutableMemory().

8:27 AM Changeset in webkit [87613] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

8:24 AM Changeset in webkit [87612] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode): Added missing argument.

5:15 AM Changeset in webkit [87611] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-28 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

If there is no editable text Qt interprets backspace as a navigation
command, regardless of platform.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.
5:06 AM Changeset in webkit [87610] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

3:32 AM Changeset in webkit [87609] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

1:50 AM Changeset in webkit [87608] by mnaganov@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-28 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed. Test expectations update after r87605

  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.
1:27 AM Changeset in webkit [87607] by bashi@chromium.org
  • 2 edits in trunk/Tools

2011-05-28 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

Add bashi as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61685

  • Scripts/webkitpy/common/config/committers.py:
12:17 AM Changeset in webkit [87606] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-05-28 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/style/non-inheritable-styles should be dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61681

Converts the test to dump-as-markup and cleans up the HTML a bit.

  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html:
  • platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

May 27, 2011:

11:52 PM Changeset in webkit [87605] by Nikolas Zimmermann
  • 1 edit
    10 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, this just adds a new test.

WebKit fails WICD SVG background image tests
https://bugs.webkit.org/show_bug.cgi?id=16481

Add two WICD SVG background image tests, which pass just fine.

  • svg/wicd/resources/test-scalable-background-image1.css: Added. (html): (body): (p):
  • svg/wicd/resources/test-scalable-background-image1.svg: Added.
  • svg/wicd/resources/test-scalable-background-image2.css: Added. (html):
  • svg/wicd/resources/test-scalable-background-image2.svg: Added.
  • svg/wicd/test-scalable-background-image1.xhtml: Added.
  • svg/wicd/test-scalable-background-image2.xhtml: Added.
11:19 PM Changeset in webkit [87604] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/inserting/insert-3907422 should be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=61680

Converted to dumpAsMarkup and cleaned up markup.

  • editing/inserting/insert-3907422-fix-expected.txt: Added.
  • editing/inserting/insert-3907422-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.
10:13 PM Changeset in webkit [87603] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

10:13 PM Changeset in webkit [87602] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40

New tag.

9:48 PM Changeset in webkit [87601] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

When checking whether the tree is red, the EWS posts a link to the wrong log
https://bugs.webkit.org/show_bug.cgi?id=61072

We need to cache the original script error because that contains the
failure log we want to upload. If we don't cache that script error,
self._script_error will get overwritten when we sanity check the clean
tree (and it also has test failures).

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • This testing approach is slightly goofy. We'd like to use assertRaisesRegexp, but that's not available until Python 2.7.
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
9:42 PM Changeset in webkit [87600] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87599.

9:39 PM Changeset in webkit [87599] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Roll out r87544 since it is bogus.

9:18 PM Changeset in webkit [87598] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-27 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CG BitmapImage needs to check for valid CGImage in a couple of places
https://bugs.webkit.org/show_bug.cgi?id=61684
<rdar://problem/9519348>

BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
returns null, which it may do if the image is corrupted or still
loading. Protect against that here and in getFirstCGImageRefOfSize().

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::getFirstCGImageRefOfSize): (WebCore::BitmapImage::getCGImageArray):
8:27 PM Changeset in webkit [87597] by jochen@chromium.org
  • 15 edits
    4 adds in trunk

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • platform/chromium/permissionclient/storage-permission-expected.txt: Added.
  • platform/chromium/permissionclient/storage-permission.html: Added.

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add Frame parameter to all StorageArea methods. The chromium
embedder uses the Frame as context to decide whether or not
to allow usage of the storage API.
https://bugs.webkit.org/show_bug.cgi?id=61581

Test: platform/chromium/permissionclient/storage-permission.html

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::contains):
  • storage/StorageAreaImpl.h:

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains): (WebCore::StorageAreaProxy::canAccessStorage):
  • src/StorageAreaProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem):

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add layoutTestController.setStorageAllowed() to control whether access
to the localStorage API is enabled via the WebPermissionClient
https://bugs.webkit.org/show_bug.cgi?id=61581

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.h: Added. (WebPermissions::WebPermissions): (WebPermissions::allowStorage): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
7:28 PM Changeset in webkit [87596] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
https://bugs.webkit.org/show_bug.cgi?id=60326

This patch removes a lot of the complexity from the
metered_stream implementation that was unnecessary since there
was only one caller and the logic could be coordinated better.

There should be no functional changes in this patch, just code
getting deleted and cleaned up.

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
7:24 PM Changeset in webkit [87595] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

2011-05-27 Nate Chapin <Nate Chapin>

Reviewed by Jian Li.

Keep a reference to BlobResourceHandle before calling doNotifyFinish()
asynchronously to ensure it's still safe in the main thread.

https://bugs.webkit.org/show_bug.cgi?id=61669

I triggered this crash in fast/files/file-reader-abort.html during a
refactor that changed timings slightly.

  • platform/network/BlobResourceHandle.cpp: (WebCore::doNotifyFinish): (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/BlobResourceHandle.h: (WebCore::BlobResourceHandle::aborted):
7:16 PM Changeset in webkit [87594] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: minor cleanup in printing module
https://bugs.webkit.org/show_bug.cgi?id=60329

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
7:11 PM Changeset in webkit [87593] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

NRWT: remove --print detailed-progress
https://bugs.webkit.org/show_bug.cgi?id=60324

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:00 PM Changeset in webkit [87592] by sjl@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Add sjl@chromium.org as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61672

  • Scripts/webkitpy/common/config/committers.py:
6:56 PM Changeset in webkit [87591] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

NRWT: debug messages from the workers are being logged twice
https://bugs.webkit.org/show_bug.cgi?id=60428

It looks like when the workers are run in separate processes
we end up getting two copies of every log message they print.
This has to do with the multiprocessing module on UNIX cloning
the log configuration in a way I wasn't expecting, and so two
log handlers end up getting registered.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6:24 PM Changeset in webkit [87590] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Hopefully last rebaseline from r87526.

  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
5:30 PM Changeset in webkit [87589] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: Vista flakiness.

5:28 PM Changeset in webkit [87588] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

JS API is too aggressive about throwing exceptions for NULL get or set operations
https://bugs.webkit.org/show_bug.cgi?id=61678

  • API/JSCallbackObject.h: Changed our staticValueGetter to a regular function that returns a JSValue, so it can fail and still forward to normal property lookup.
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): Don't throw an exception when failing to access a static property -- just forward the access. This allows objects to observe get/set operations but still let the JS object manage lifetime.

(JSC::::put): Ditto.

(JSC::::getStaticValue): Same as JSCallbackObject.h.

  • API/tests/testapi.c: (MyObject_set_nullGetForwardSet):
  • API/tests/testapi.js: Updated tests to reflect slightly less strict behavior, which matches headerdoc claims.
5:26 PM Changeset in webkit [87587] by adamk@chromium.org
  • 2 edits
    11 adds
    2 deletes in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Even more rebaselines after r87526.

  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [87586] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Property caching is too aggressive for API objects
https://bugs.webkit.org/show_bug.cgi?id=61677

  • API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our callback APIs allow the client to change its mind about our propertis at any time.
  • API/tests/testapi.c: (PropertyCatchalls_getProperty): (PropertyCatchalls_setProperty): (PropertyCatchalls_getPropertyNames): (PropertyCatchalls_class): (main):
  • API/tests/testapi.js: Some tests for dynamic API objects.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client requires it.
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::isFinal): (JSC::TypeInfo::prohibitsPropertyCaching): (JSC::TypeInfo::flags): Added a flag to track opting out of property caching. Fixed an "&&" vs "&" typo that was previously harmless, but is now harmful since m_flags2 can have more than one bit set.
4:34 PM Changeset in webkit [87585] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87578.

4:21 PM Changeset in webkit [87584] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: widen flakiness to include Linux.

4:18 PM Changeset in webkit [87583] by sjl@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

The behaviour of controls-after-reload was causing
layoutTestController in DumpRenderTree to misbehave causing a reported
failure in the test run after it (controls-css-overload).

Effectively, notifyDone() ended up getting called again after the test
was being torn down.

This change removes the unneeded seek at the end of the test (as we
should have already seeked to 0.

https://bugs.webkit.org/show_bug.cgi?id=60132

  • media/controls-after-reload.html:
  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [87582] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source

Merge r87580.

4:09 PM Changeset in webkit [87581] by mrowe@apple.com
  • 11 edits
    1 add in branches/safari-534-branch/Source

Merge r87520.

3:57 PM Changeset in webkit [87580] by slewis@apple.com
  • 8 edits in trunk/Source

Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
3:49 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:48 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:48 PM Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
3:32 PM Changeset in webkit [87579] by adamk@chromium.org
  • 3 edits
    2 copies
    3 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. More rebaselines after r87526.

  • platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-linux/svg/in-html/by-reference-expected.txt:
  • platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:14 PM Changeset in webkit [87578] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Always use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=61670
<rdar://problem/9516130>

Always use the default localization strategy when there's no platform strategy.

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::shared):
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultDetailsSummaryText): (WebCore::copyImageUnknownFileLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagCopyImageUrlToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagSelectAll): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchInSpotlight): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagShowFonts): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagStyles): (WebCore::contextMenuItemTagShowColors): (WebCore::contextMenuItemTagSpeechMenu): (WebCore::contextMenuItemTagStartSpeaking): (WebCore::contextMenuItemTagStopSpeaking): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagCorrectSpellingAutomatically): (WebCore::contextMenuItemTagSubstitutionsMenu): (WebCore::contextMenuItemTagShowSubstitutions): (WebCore::contextMenuItemTagSmartCopyPaste): (WebCore::contextMenuItemTagSmartQuotes): (WebCore::contextMenuItemTagSmartDashes): (WebCore::contextMenuItemTagSmartLinks): (WebCore::contextMenuItemTagTextReplacement): (WebCore::contextMenuItemTagTransformationsMenu): (WebCore::contextMenuItemTagMakeUpperCase): (WebCore::contextMenuItemTagMakeLowerCase): (WebCore::contextMenuItemTagCapitalize): (WebCore::contextMenuItemTagChangeBack): (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXARIAContentGroupText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::missingPluginText): (WebCore::crashedPluginText): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::uploadFileText): (WebCore::allFilesText): (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName): (WebCore::imageTitle): (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
2:55 PM Changeset in webkit [87577] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source/WebCore

Merge r87566.

2:50 PM Changeset in webkit [87576] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r87330.

2:50 PM Changeset in webkit [87575] by mrowe@apple.com
  • 13 edits
    3 adds in branches/safari-534-branch/Source

Merge r87228.

2:43 PM Changeset in webkit [87574] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87460.

2:37 PM Changeset in webkit [87573] by mrowe@apple.com
  • 11 edits in branches/safari-534-branch/Source

Merge r87329.

2:36 PM Changeset in webkit [87572] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

2:33 PM Changeset in webkit [87571] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87557.

2:25 PM Changeset in webkit [87570] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87414.

2:20 PM Changeset in webkit [87569] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87456.

2:18 PM Changeset in webkit [87568] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-534-branch

Merge r87322.

2:16 PM Changeset in webkit [87567] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87363.

2:15 PM Changeset in webkit [87566] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
2:15 PM Changeset in webkit [87565] by mrowe@apple.com
  • 16 edits in branches/safari-534-branch

Merge r87328.

2:12 PM Changeset in webkit [87564] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87442.

2:10 PM Changeset in webkit [87563] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87544.

2:08 PM Changeset in webkit [87562] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87421.

2:05 PM Changeset in webkit [87561] by enne@google.com
  • 3 edits in trunk/LayoutTests

2011-05-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
2:02 PM Changeset in webkit [87560] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source

Merge r87335.

1:59 PM Changeset in webkit [87559] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87397.

1:56 PM Changeset in webkit [87558] by adamk@chromium.org
  • 5 edits
    3 copies
    77 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaselines and test expectations updates after r87526.

  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [87557] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

30 second rewind button obscured in fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=61663

If reset() is called while in full-screen mode, make sure to show and hide
the correct controls for that mode.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
1:53 PM Changeset in webkit [87556] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87305.

1:51 PM Changeset in webkit [87555] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87272.

1:50 PM Changeset in webkit [87554] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87237.

1:48 PM Changeset in webkit [87553] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-534-branch

Merge r87387.

1:45 PM Changeset in webkit [87552] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87458.

1:43 PM Changeset in webkit [87551] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87524.

1:39 PM Changeset in webkit [87550] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.

  • runtime/JSGlobalData.cpp: (JSGlobalData::JSGlobalData):
1:37 PM Changeset in webkit [87549] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87361.

1:35 PM Changeset in webkit [87548] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-534-branch

Merge r87324.

1:29 PM Changeset in webkit [87547] by jamesr@google.com
  • 3 edits
    3 adds in trunk

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

  • compositing/iframes/resizer-expected.txt: Added.
  • compositing/iframes/resizer.html: Added.

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
graphics layer tree consistent.

Test: compositing/iframes/resizer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
1:28 PM Changeset in webkit [87546] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87253.

1:25 PM Changeset in webkit [87545] by Nikolas Zimmermann
  • 1 edit
    1 move in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fix last failing win/svg test, put result in correct directory.

  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.
1:22 PM Changeset in webkit [87544] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

  • WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
1:21 PM Changeset in webkit [87543] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.

1:18 PM Changeset in webkit [87542] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
The feature is tracked by the bug 61630.

  • platform/gtk/Skipped:
1:10 PM Changeset in webkit [87541] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87244.

1:10 PM Changeset in webkit [87540] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87275.

12:53 PM Changeset in webkit [87539] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLVideoElement::currentSrc() should return a KURL
https://bugs.webkit.org/show_bug.cgi?id=61578

I suspect we got into this mess because the author of this code didn't
know about the URL attribute in WebKit IDL, which is super useful!

Bad news: The line of code in question seems to have another bug, which
I've documented in a FIXME. Let the yak shaving continue!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::currentURL):
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
    • This complete URL call was unnecessary because currentSrc is already absolute.
12:52 PM Changeset in webkit [87538] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=61177

  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className):
12:50 PM Changeset in webkit [87537] by Adam Roben
  • 2 edits in trunk/Tools

Always decode tester names from location.hash

When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.

12:48 PM Changeset in webkit [87536] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add a few validity assertions to JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=61659

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::visitChildren):
12:44 PM Changeset in webkit [87535] by Nikolas Zimmermann
  • 4 edits
    8 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Rebaseline some qt/win/leopard results.

  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
12:32 PM Changeset in webkit [87534] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fixes crash in svg/custom/immutable-properties.html, seen on the bots.

  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
12:32 PM Changeset in webkit [87533] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-27 Nat Duca <nduca@chromium.org>

Unreviewed, landed by enne@google.com.

[chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium/test_expectations.txt:
11:56 AM Changeset in webkit [87532] by rniwa@webkit.org
  • 2 adds in trunk/LayoutTests/platform/chromium-win/editing/pasteboard

Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.

11:52 AM Changeset in webkit [87531] by rniwa@webkit.org
  • 3 edits
    2 adds
    19 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61610

Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.

  • editing/pasteboard/paste-pre-001-expected.txt: Added.
  • editing/pasteboard/paste-pre-001.html:
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.
11:49 AM Changeset in webkit [87530] by Adam Roben
  • 2 edits in trunk/Tools

Remove testing code that snuck into r87528

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.

11:47 AM Changeset in webkit [87529] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

11:41 AM Changeset in webkit [87528] by Adam Roben
  • 3 edits in trunk/Tools

Add links to TestFailures to easily file bugs about failing tests

Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!

11:30 AM Changeset in webkit [87527] by oliver@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Try to release unused executable memory when the FixedVMPool allocator is under pressure
https://bugs.webkit.org/show_bug.cgi?id=61651

Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h:
  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::linkCode):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::executableCopy):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::executableCopy):
  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy): (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::create): (JSC::ExecutablePool::alloc): (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutableAllocator::poolForSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::alloc):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator): (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::releaseExecutableMemory): (JSC::releaseExecutableMemory):
  • runtime/JSGlobalData.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::invalidateCode):
  • runtime/RegExpCache.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::compile):
11:27 AM Changeset in webkit [87526] by Nikolas Zimmermann
  • 18 edits
    92 adds in trunk

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
  • http/tests/misc/resources/embedded.svg: Added.
  • http/tests/misc/resources/svg-slow.pl: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • svg/custom/object-no-size-attributes.xhtml: Added.
  • svg/custom/object-sizing-explicit-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width.xhtml: Added.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
  • svg/custom/object-sizing-no-width-height.xhtml: Added.
  • svg/custom/object-sizing.xhtml: Added.
  • svg/custom/resources/embedded.svg: Added.
  • svg/custom/resources/red-circle.svg: Added.
  • svg/in-html/by-reference-expected.png:
  • svg/wicd: Added.
  • svg/wicd/resources: Added.
  • svg/wicd/resources/a.svg: Added.
  • svg/wicd/resources/bcde.svg: Added.
  • svg/wicd/resources/empty1.svg: Added.
  • svg/wicd/resources/empty2.svg: Added.
  • svg/wicd/resources/empty3.svg: Added.
  • svg/wicd/resources/f.svg: Added.
  • svg/wicd/resources/g.svg: Added.
  • svg/wicd/resources/h.svg: Added.
  • svg/wicd/resources/i.svg: Added.
  • svg/wicd/resources/j.svg: Added.
  • svg/wicd/resources/k.svg: Added.
  • svg/wicd/resources/l.svg: Added.
  • svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
  • svg/wicd/resources/mnop.svg: Added.
  • svg/wicd/resources/q.svg: Added.
  • svg/wicd/resources/r.svg: Added.
  • svg/wicd/resources/s.svg: Added.
  • svg/wicd/resources/t.svg: Added.
  • svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
  • svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
  • svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
  • svg/wicd/rightsizing-grid.xhtml: Added.
  • svg/wicd/test-rightsizing-a.xhtml: Added.
  • svg/wicd/test-rightsizing-b.xhtml: Added.
  • svg/zoom/page/resources: Added.
  • svg/zoom/page/resources/absolute-sized-svg.png: Added.
  • svg/zoom/page/resources/absolute-sized-svg.svg: Added.
  • svg/zoom/page/resources/huge-rect.svg: Added.
  • svg/zoom/page/resources/percentage-sized-svg.png: Added.
  • svg/zoom/page/resources/percentage-sized-svg.svg: Added.
  • svg/zoom/page/resources/text.svg: Added.
  • svg/zoom/page/resources/tux.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.

If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml

svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/Length.h: (WebCore::Length::isSpecified):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h:
11:11 AM Changeset in webkit [87525] by jochen@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] drop unused WebFrame parameter to WebStorageArea::setItem
https://bugs.webkit.org/show_bug.cgi?id=61583

  • public/WebStorageArea.h:
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
  • src/WebStorageAreaImpl.h:
10:52 AM Changeset in webkit [87524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Michael Saboff <msaboff@apple.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=61646
Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font

Change the platformIsEqual to just compare the m_font members if
either is not null.

No tests added - functionality unchanged, fixing memory abandonment.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::platformIsEqual):
10:39 AM Changeset in webkit [87523] by mrobinson@webkit.org
  • 7 edits
    3 adds in trunk

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

Added a GTK+ specific test that verifies that zero pixel sized
fonts do not corrupt the Cairo context.

  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

When instantiating a cairo_scaled_font_t font would put the font in an error state,
leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
in the error state can later lead to corrupted rendering.

Due to this change, we must always null check cairo_scaled_font_t and the platform
data now carries the cairo_font_face_t object with it, so that it can be accessed later
if there is no cairo_scaled_font_t.

Test: platform/gtk/fonts/zero-pixel-sized-fonts.html

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
  • platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Initialize the new member. (WebCore::FontPlatformData::operator=): Carry over the new member. (WebCore::FontPlatformData::operator==): Check equality with the new member. (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont put the font into an error state, then just free it and return. (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap when the scaled font is null, because rendering is always a no-op and the font data never needs to be read.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font. (WebCore::SimpleFontData::scaledFontData): Use the new m_font member. (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
10:39 AM Changeset in webkit [87522] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized ConservativeSet to avoid double-visiting objects
https://bugs.webkit.org/show_bug.cgi?id=61592


SunSpider thinks this might be a 1% speedup

  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting an object.
  • heap/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type to void*, since clients want to ask questions about arbitrary pointers into the heap, even when they aren't known to be JSCells.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::testAndClearMarked):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::testAndClearMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Ditto.
  • wtf/Bitmap.h: (WTF::::testAndClear): New function for ConservativeRoots's inverted marking pass.
10:25 AM Changeset in webkit [87521] by levin@chromium.org
  • 9 edits in trunk/Source

Need a callback for when the preferred rendered size may have changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::layoutUpdated): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h:

(WebCore::ChromeClient::layoutUpdated): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Added a callback for whem a layout has finished.

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didUpdateLayout): Added stub.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.

  • src/ChromeClientImpl.h: Added declaration.
9:59 AM Changeset in webkit [87520] by slewis@apple.com
  • 11 edits
    1 add in trunk/Source

Rubber Stamped by Adam Roben.

Source/JavaScriptCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

Source/WebCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebCore.order:

Source/WebKit/mac:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebKit.order:

Source/WebKit2:

Add Order File. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • mac/WebKit2.order: Added.
9:34 AM Changeset in webkit [87519] by commit-queue@webkit.org
  • 21 edits
    6 deletes in trunk

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • http/tests/websocket/tests/client-close-expected.txt: Removed.
  • http/tests/websocket/tests/client-close.html: Removed.
  • http/tests/websocket/tests/client-close_wsh.py: Removed.
  • http/tests/websocket/tests/close-before-open-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html:
  • http/tests/websocket/tests/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/server-close-expected.txt: Removed.
  • http/tests/websocket/tests/server-close.html: Removed.
  • http/tests/websocket/tests/server-close_wsh.py: Removed.
  • http/tests/websocket/tests/websocket-event-target-expected.txt:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): (WebCore::SocketStreamHandleBase::close): (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • Scripts/webkitpy/thirdparty/init.py:
9:19 AM Changeset in webkit [87518] by rwlbuis@webkit.org
  • 3 edits
    2 adds
    3 deletes in trunk

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Remove 003-broken.xml and replace it with a 003.xml that is text-only.

  • platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
  • svg/hixie/links/003-broken.xml: Removed.
  • svg/hixie/links/003-expected.txt: Added.
  • svg/hixie/links/003.xml: Added.

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Only allow links to animation elements within the document.

Test: svg/hixie/links/003.xml

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
9:14 AM Changeset in webkit [87517] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
https://bugs.webkit.org/show_bug.cgi?id=60757

cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint):
9:10 AM Changeset in webkit [87516] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

8:41 AM Changeset in webkit [87515] by ap@apple.com
  • 2 edits in trunk/Tools

Added Douglas Davidson to contributors list for easier CC'ing.

  • Scripts/webkitpy/common/config/committers.py:
8:34 AM Changeset in webkit [87514] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044

Make sure to set the active window on the application too.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette):
8:19 AM Changeset in webkit [87513] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

WebKit2 does not support eventSender.

  • platform/mac-wk2/Skipped:
8:03 AM Changeset in webkit [87512] by andreas.kling@nokia.com
  • 16 edits in trunk

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

HTML5 now specifies that fully transparent colors should have their alpha value
serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)

The number of decimals for alpha values between 0 and 1 is not specified,
so match Gecko and Presto by returning the lowest number of decimals needed
to represent the number. (No more trailing zeroes.)

  • platform/graphics/Color.cpp: (WebCore::Color::serialized):

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

Update tests to reflect the new behavior.

  • canvas/philip/tests/2d.fillStyle.get.transparent.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
  • editing/style/inline-style-container-expected.txt
  • editing/style/script-tests/inline-style-container.js:
  • fast/canvas/canvas-color-clamping-expected.txt:
  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/canvas-currentColor-expected.txt:
  • fast/canvas/script-tests/canvas-color-clamping.js:
  • fast/canvas/script-tests/canvas-color-serialization.js:
  • fast/canvas/script-tests/canvas-currentColor.js:
  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
  • fast/dom/canvasContext2d-element-attribute-js-null.html:
7:35 AM Changeset in webkit [87511] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that requires eventSender.beginDragWithFiles.

  • platform/win/Skipped:
7:23 AM Changeset in webkit [87510] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that is failing until investigated.

  • platform/gtk/Skipped:
7:19 AM Changeset in webkit [87509] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-26 Jeff Miller <jeffm@apple.com>

Reviewed by Alexey Proskuryakov.

Add a key handling logging channel for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61588


Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

  • Platform/Logging.cpp: (WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
  • Platform/Logging.h: Added LogKeyHandling channel.
  • UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment. (WebKit::webKeyboardEventTypeString): Added to support logging. (WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event. (WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
7:02 AM Changeset in webkit [87508] by hans@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

New test for adding new entries to an objecet store while running a
cursor over it.

  • storage/indexeddb/mutating-cursor-expected.txt: Added.
  • storage/indexeddb/mutating-cursor.html: Added.

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

We need to support the case where a new node is added to the tree in a
transaction after the TreeIterator has covered the whole tree.

Since this is done lazily, i.e. we set a flag that the tree might have
changed, and act upon it later, some members need to be mutable,
because we might need to re-seek the tree iterator in a const function.

Test: storage/indexeddb/mutating-cursor.html

storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)

  • platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::treeChanged): (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
  • platform/leveldb/LevelDBTransaction.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::open):
6:51 AM Changeset in webkit [87507] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Sujin Park <sujjin.park@gmail.com>

Unreviewed, buildfix if --no-javascript-debugger.

Regression(R84125): Broke GTK build
https://bugs.webkit.org/show_bug.cgi?id=60698

No new tests since this doesn't change any behavior.

  • inspector/WorkerInspectorController.h:
6:48 AM Changeset in webkit [87506] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Daily gardening.

Typo fix, and remove non-existent files from Skipped list.

  • platform/qt-mac/Skipped:
6:12 AM Changeset in webkit [87505] by Csaba Osztrogonác
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt][Mac] Daily gardening.

  • platform/qt-mac/Skipped:
    • plugins/embed-attributes-setting.html was unskipped by r87306, but fails on Qt-Mac.
    • plugins/plugin-initiate-popup-window.html unskipped by r87429, but fails on Qt-Mac.
    • fast/css/disabled-author-styles unskipped by r87311, but fails on Qt-Mac.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Added after r87468.
5:59 AM Changeset in webkit [87504] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip test that is failing on the bot, until investigated.

  • platform/chromium/test_expectations.txt:
5:48 AM Changeset in webkit [87503] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip new dropzone tests. Qt's DRT does not support drag 'n drop.

  • platform/qt/Skipped:
5:46 AM Changeset in webkit [87502] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress editing/pasteboard/smart-paste-004.html on Win after r87496

5:43 AM Changeset in webkit [87501] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreveiwed, suppress editing/pasteboard/smart-paste-003.html on Win after r87495

5:42 AM Changeset in webkit [87500] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[WK2] Skip new failing tests because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped: Add failing tests.
  • platform/qt-wk2/Skipped: Remove tests, because they fail because of WK2 specific bug, not Qt-WK2 specific.
5:37 AM Changeset in webkit [87499] by yael.aharon@nokia.com
  • 7 edits
    9 adds in trunk

webkit should implement the dropzone attribute
https://bugs.webkit.org/show_bug.cgi?id=58210

Reviewed by Tony Chang.

Source/WebCore:

Add support for dropzone attribute.
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
If there is such an element, and it matches the drag data store, set the action defined by that
element and continue processing the drag and drop operation.

Tests: fast/events/dropzone-001.html

fast/events/dropzone-002.html
fast/events/dropzone-003.html
fast/events/dropzone-004.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::Clipboard::processDropZoneKeyword):

  • dom/Clipboard.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.idl:
  • page/EventHandler.cpp:

(WebCore::EventHandler::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):

  • page/EventHandler.h:

LayoutTests:

  • fast/events/dropzone-001-expected.txt: Added.
  • fast/events/dropzone-001.html: Added.
  • fast/events/dropzone-002-expected.txt: Added.
  • fast/events/dropzone-002.html: Added.
  • fast/events/dropzone-003-expected.txt: Added.
  • fast/events/dropzone-003.html: Added.
  • fast/events/dropzone-004-expected.txt: Added.
  • fast/events/dropzone-004.html: Added.
  • fast/events/resources/dropzone.js: Added.
5:20 AM Changeset in webkit [87498] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60175

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped: The bug is in Qt 4.8, add Qt bug tracker URL's.
4:57 AM Changeset in webkit [87497] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Make the bot environmentally friendly.

  • platform/qt-wk2/Skipped:
4:44 AM Changeset in webkit [87496] by rniwa@webkit.org
  • 4 edits
    1 move
    2 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-004.html through smart-paste-006.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61618

Converted smart-paste-004.html, smart-paste-005.html, and smart-paste-005.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-004-expected.txt: Added.
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005-expected.txt: Added.
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-006-expected.txt: Added.
  • editing/pasteboard/smart-paste-006.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt: Removed.
4:38 AM Changeset in webkit [87495] by rniwa@webkit.org
  • 4 edits
    3 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61617

Converted smart-paste-001.html, smart-paste-002.html, and smart-paste-003.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-001-expected.txt: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002-expected.txt: Added.
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003-expected.txt: Added.
  • editing/pasteboard/smart-paste-003.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Removed.
4:36 AM Changeset in webkit [87494] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-27 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r87467.

  • page/wince/FrameWinCE.cpp:
4:22 AM Changeset in webkit [87493] by rniwa@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-unrendered-select.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61616

Converted paste-unrendered-select.html to a dump-as-markup test.

  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html:
  • platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
4:16 AM Changeset in webkit [87492] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • platform/chromium/test_expectations.txt:

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • features.gypi:
3:54 AM Changeset in webkit [87491] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=61517

Support cursors where the direction is set to NEXT_NO_DUPLICATE,
or PREV_NO_DUPLICATE, as specified here:
http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE

This is tested by storage/indexeddb/mozilla/indexes.html

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
3:37 AM Changeset in webkit [87490] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

LevelDB: turn on paranoid checks and verify checksums, log errors
https://bugs.webkit.org/show_bug.cgi?id=61516

This allows for detection of corrupted databases.
Even if we can't recover from a corrupted database, discovering the
problem is a step in the right direction.

No new functionality, no new tests.

  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::checkStatus): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::LevelDBDatabase::createIterator):
3:16 AM Changeset in webkit [87489] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark fast/canvas/webgl/uniform-location.html as timing out

2:36 AM Changeset in webkit [87488] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/InspectorFrontendHost.cpp

Merge 86551 - 2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062045

2:30 AM Changeset in webkit [87487] by apavlov@chromium.org
  • 7 edits
    2 copies in branches/chromium/742

Merge 86507 - 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062044

2:11 AM Changeset in webkit [87486] by rniwa@webkit.org
  • 3 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61614

Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.

  • editing/pasteboard/paste-text-002-expected.txt: Added.
  • editing/pasteboard/paste-text-002.html:
  • editing/pasteboard/paste-text-003-expected.txt: Added.
  • editing/pasteboard/paste-text-003.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
1:26 AM Changeset in webkit [87485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

CachedResourceLoader stores data: urls in validated URL set
https://bugs.webkit.org/show_bug.cgi?id=61604

CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource):
1:01 AM Changeset in webkit [87484] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(

12:56 AM Changeset in webkit [87483] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

2011-05-23 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] DocumentMarker should be carried around as a pointer, not value.
https://bugs.webkit.org/show_bug.cgi?id=61262

  • Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
  • Introduced markersFor() that returns Vector<DocumentMarker*>
  • Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by RenderedDocumentMarker::setRenderedRect().
  • This change didn't remove markersForNode() beucase there is patches on review which depends markersForNode(). I'll remove its call after these patches are landed.

No new tests. No behavior change.

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::markersFor): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
  • dom/DocumentMarkerController.h:
  • dom/RenderedDocumentMarker.h: (WebCore::toRenderedDocumentMarker):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
12:54 AM Changeset in webkit [87482] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460

12:45 AM Changeset in webkit [87481] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux

12:26 AM Changeset in webkit [87480] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary crashes
https://bugs.webkit.org/show_bug.cgi?id=61511

  • fast/html/details-summary-document-child-expected.txt: Added.
  • fast/html/details-summary-document-child.html: Added.

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511

Removed Unnecessary wrong cast to Elmement, which can be non-Element.

Test: fast/html/details-summary-document-child.html

  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::detailsElement):

May 26, 2011:

11:54 PM Changeset in webkit [87479] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Ryosuke Niwa.

FrameLoader cannot be null
https://bugs.webkit.org/show_bug.cgi?id=61609

This code has a bunch of cargo-cult null checking.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::getPluginProxyParams): (WebCore::HTMLMediaElement::createMediaPlayerProxy): (WebCore::HTMLMediaElement::updateWidget):
11:43 PM Changeset in webkit [87478] by rniwa@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/paste-blockquote-1.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61608

Converted paste-blockquote-1.html to a dump-as-markup test.

  • editing/pasteboard/paste-blockquote-1-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-1.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
11:42 PM Changeset in webkit [87477] by rniwa@webkit.org
  • 6 edits
    5 adds
    51 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/merge-end-*.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61607

  • editing/pasteboard/merge-end-1-expected.txt: Added.
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.txt: Added.
  • editing/pasteboard/merge-end-2.html:
  • editing/pasteboard/merge-end-3-expected.txt: Added.
  • editing/pasteboard/merge-end-3.html:
  • editing/pasteboard/merge-end-4-expected.txt: Added.
  • editing/pasteboard/merge-end-4.html:
  • editing/pasteboard/merge-end-5-expected.txt: Added.
  • editing/pasteboard/merge-end-5.html:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt: Removed.
11:40 PM Changeset in webkit [87476] by rniwa@webkit.org
  • 5 edits
    4 adds
    38 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/interchange-newline-*.html to dump-as-markup tests.
https://bugs.webkit.org/show_bug.cgi?id=61605

Converted interchange-newline-1 thorugh 4 to dump-as-markup tests.
Also revised some test descriptions.

  • editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • editing/pasteboard/interchange-newline-1.html:
  • editing/pasteboard/interchange-newline-2-expected.txt: Added.
  • editing/pasteboard/interchange-newline-2.html:
  • editing/pasteboard/interchange-newline-3-expected.txt: Added.
  • editing/pasteboard/interchange-newline-3.html:
  • editing/pasteboard/interchange-newline-4-expected.txt: Added.
  • editing/pasteboard/interchange-newline-4.html:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
11:28 PM Changeset in webkit [87475] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

  • transforms/2d/set-transform-and-top-expected.txt: Added.
  • transforms/2d/set-transform-and-top.html: Added.

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

When a transform is modified in a style, we were upgrading our understanding
of the difference from PositionedMovementOnly to SimplifiedLayout. However,
if the position of the style is independently changed at the same time, both
PositionedMovement and SimplifiedLayout passes are required.

Test: transforms/2d/set-transform-and-top.html

  • rendering/RenderObject.cpp: Added checks for SimplifiedLayoutAndPositionedMovement - when encountered, set both PositionedMovement and SimplifiedLayout update flasgs.
  • rendering/style/RenderStyleConstants.h: Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for cases when both PositionedMovement and SimplifiedLayout are required.
11:26 PM Changeset in webkit [87474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61589

No new tests as no new functionality added.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Add handlers for: CSSPropertyWebkitMarginBeforeCollapse CSSPropertyWebkitMarginAfterCollapse CSSPropertyWebkitMarginTopCollapse CSSPropertyWebkitMarginBottomCollapse CSSPropertyWebkitMarginCollapse
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove cases that are no longer required.
11:12 PM Changeset in webkit [87473] by abarth@webkit.org
  • 11 edits
    8 adds in trunk

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015

Test various cases involving CORS requests and canvas tainting.

  • http/tests/security/canvas-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • http/tests/security/resources/abe-allow-credentials.php: Added.
  • http/tests/security/resources/abe-allow-star.php: Added.

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015

This patch add support for the crossorigin attribute of images and
teaches 2D canvas to respect that flag and not taint a canvas if the
image drawn on the canvas is allowed by CORS.

While I was editing this code, I couldn't resist a couple touch-up
changes.

Tests: http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/canvas-remote-read-remote-image-allowed.html
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html

  • html/HTMLAttributeNames.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::securityOrigin):
  • html/HTMLCanvasElement.h:
  • html/HTMLImageElement.idl:
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::passesAccessControlCheck):
  • loader/cache/CachedResource.h:
10:33 PM Changeset in webkit [87472] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    10 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/4700297.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61595

Renamed 4700297.html to insert-div-text-into-text.html and converted it into a dump-as-markup test.

  • editing/pasteboard/4700297.html: Removed.
  • editing/pasteboard/insert-div-text-into-text-expected.txt: Added.
  • editing/pasteboard/insert-div-text-into-text.html: Copied from LayoutTests/editing/pasteboard/4700297.html.
  • platform/chromium-linux/editing/pasteboard/4700297-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4700297-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/4700297-expected.png: Removed.
  • platform/gtk/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/4700297-expected.png: Removed.
  • platform/mac/editing/pasteboard/4700297-expected.png: Removed.
  • platform/mac/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4700297-expected.png: Removed.
  • platform/qt/editing/pasteboard/4700297-expected.txt: Removed.
10:31 PM Changeset in webkit [87471] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Hajime Morita.

editing/pasteboard/5483567.html should be renamed and converted to a dump-as-markup test.
https://bugs.webkit.org/show_bug.cgi?id=61599

Renamed 5483567.html to pasting-word-in-div-extra-line.html and converted it to
a dump-as-markup test.

  • editing/pasteboard/5483567.html: Removed.
  • editing/pasteboard/pasting-word-in-div-extra-line-expected.txt: Added.
  • editing/pasteboard/pasting-word-in-div-extra-line.html: Copied from LayoutTests/editing/pasteboard/5483567.html.
  • platform/chromium-linux/editing/pasteboard/5483567-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5483567-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5483567-expected.png: Removed.
  • platform/mac/editing/pasteboard/5483567-expected.png: Removed.
  • platform/mac/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5483567-expected.txt: Removed.
10:29 PM Changeset in webkit [87470] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61597

Renamed 5089327.html to paste-into-blockquote-with-document-font-color.html and converted it
to a dump-as-markup test.

  • editing/pasteboard/5089327.html: Removed.
  • editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt: Added.
  • editing/pasteboard/paste-into-blockquote-with-document-font-color.html: Copied from LayoutTests/editing/pasteboard/5089327.html.
  • platform/chromium-linux/editing/pasteboard/5089327-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5089327-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5089327-expected.png: Removed.
  • platform/mac/editing/pasteboard/5089327-expected.png: Removed.
  • platform/mac/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Removed.
10:29 PM Changeset in webkit [87469] by mihaip@chromium.org
  • 12 edits in trunk

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8Proxy.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): (WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
  • page/SecurityOrigin.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
  • src/WebFrameImpl.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
10:27 PM Changeset in webkit [87468] by rniwa@webkit.org
  • 1 edit
    1 move
    2 adds
    9 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/5027857.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61602

Renamed 5027857.html to paste-code-in-pre.html and converted it to a dump-as-markup test.

  • editing/pasteboard/5027857.html: Removed.
  • editing/pasteboard/paste-code-in-pre-expected.txt: Added.
  • editing/pasteboard/paste-code-in-pre.html: Copied from LayoutTests/editing/pasteboard/5027857.html.
  • platform/chromium-linux/editing/pasteboard/5027857-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5027857-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5027857-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5027857-expected.png: Removed.
  • platform/mac/editing/pasteboard/5027857-expected.png: Removed.
  • platform/mac/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5027857-expected.txt: Removed.
9:53 PM Changeset in webkit [87467] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-26 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Replace RenderLayer::x/y/width/height with location/size
https://bugs.webkit.org/show_bug.cgi?id=61414

Covered by existing tests.

  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::computeRelativePosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderBox.h: (WebCore::RenderBox::maxLayoutOverflow):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::computeRectForRepaint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::offsetFromResizeCorner): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::location): (WebCore::RenderLayer::setSize):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::writeLayers): (WebCore::externalRepresentation):
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): (WebCore::RenderView::absoluteQuads):
9:18 PM Changeset in webkit [87466] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148

Add a test for the case given in the bug: deleting an unstyled table
should not leave behind a style span.

Rebaseline tests now that border-collapse, -webkit-border-horizontal-spacing,
and -webkit-border-vertical-spacing style spans are no longer added on
table and table cell deletion, and no longer applied when copying to the
clipboard.

  • editing/deleting/5026848-2-expected.txt:
  • editing/deleting/5026848-3-expected.txt:
  • editing/deleting/5032066-expected.txt:
  • editing/deleting/5115601-expected.txt:
  • editing/deleting/5206311-2-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-last-char-in-table-expected.txt: Added.
  • editing/deleting/delete-last-char-in-table.html: Added. New test for bug.
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/selection/4895428-1-expected.txt:
  • editing/selection/4895428-4-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148

Removes border-collapse, -webkit-border-horizontal-spacing, and
-webkit-border-vertical-spacing from the list of properties which
should be preserved during edit operations. Also renames this
list to editingInheritableProperties to be more clear about what
the list is for.

Test: editing/deleting/delete-last-char-in-table.html

  • editing/EditingStyle.cpp: Removes border vertical/horizontal spacing from editingStyleProperties.
  • editing/EditingStyle.h: Renames OnlyInheritableProperties to OnlyEditingInheritableProperties.
  • editing/markup.cpp: Renames InheritablePropertiesAndBackgroundColorInEffect.
9:14 PM Changeset in webkit [87465] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

editing/pasteboard/style-from-rules.html is flaky on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=61586

Don't attach an event listener to dump markup on paste when ran by DRT
because we manually dump markup in DRT.

  • editing/pasteboard/style-from-rules.html:
8:24 PM Changeset in webkit [87464] by yutak@chromium.org
  • 21 edits
    4 copies
    2 adds in trunk

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
7:22 PM Changeset in webkit [87463] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit/chromium

2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Dmitry Titov.

Add missing compile guards for WebWorkers in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=61536

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/LocalFileSystemChromium.cpp: (WebCore::openFileSystemHelper):
  • src/PlatformBridge.cpp:
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WorkerFileWriterCallbacksBridge.h:
7:16 PM Changeset in webkit [87462] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 David Levin <levin@chromium.org>

Reviewed by Dmitry Titov.

WebKit's font notification has problems when the WebKit main thread != UI thread.
https://bugs.webkit.org/show_bug.cgi?id=61391

This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
some time to write correctly. In the meantime, this issues happens to be causing
some crashes in Chrome so here's the fix alone for the time being.

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread. (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation. Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically, there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code. (WebCore::fontCacheATSNotificationCallback): Ditto.
7:07 PM Changeset in webkit [87461] by morrita@google.com
  • 47 edits
    75 adds in trunk/LayoutTests

2011-05-26 MORITA Hajime <morrita@google.com>

Unreviewed expectations update for <details>.

  • platform/chromium-linux-x86/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-nested-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-win/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-win/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [87460] by slewis@apple.com
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Roll back in now that the Crashes are fixed. ResourceResponseBase and ResourceResponse had two different definitions
for m_isNull. ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse.
ResourceResponseBase treats m_isNull as meaning no fields have been initialized. Consolidate calls into ResourceResponseBase meaning.

Reviewed by Geoff Garen.

Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

No new functionality so no new tests.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/mac/ResourceResponseMac.mm:
6:16 PM Changeset in webkit [87459] by koz@chromium.org
  • 4 edits in trunk

2011-05-26 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Implement a whitelist for registerProtocolHandler.

Described in the thread here
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-April/031220.html

https://bugs.webkit.org/show_bug.cgi?id=60322

  • fast/dom/register-protocol-handler.html:

2011-05-26 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Implement a whitelist for registerProtocolHandler
https://bugs.webkit.org/show_bug.cgi?id=60322

  • page/Navigator.cpp: (WebCore::initProtocolHandlerWhitelist): (WebCore::isProtocolWhitelisted): (WebCore::verifyProtocolHandlerScheme):
6:12 PM Changeset in webkit [87458] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492

Reviewed by Darin Adler.

The method for determining which WebPage is actually focused and foreground was faulty. More
extensive checks are required to check which WebPage should be returned as the focusable one.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowIsFocused):

6:00 PM Changeset in webkit [87457] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Remove some passing tests from the test expectations.

  • platform/chromium/test_expectations.txt:
5:29 PM Changeset in webkit [87456] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-26 Jon Lee <jonlee@apple.com>

Reviewed by Darin Adler.

REGRESSION (5.0.5-Jazz): Transition to full screen video animates in wrong location when scrolled (61559)
https://bugs.webkit.org/show_bug.cgi?id=61559
<rdar://problem/9496054>

The CALayer that gets animated has a position that is offset by the scroll position of the web view. To
fix this, we set the destination location based on the rect of the full screen, and add a position
animation which keeps the position of the layer centered. This prevents glitches if others
are trying to change the layer position while the animation is running.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Refactor the calculation of the CALayer windowed position into a private helper function, as well as the animation setup.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): (WebKit::WebFullScreenManagerMac::animateFullScreen): Sets up the zoom animation, and the position offset animation. (WebKit::WebFullScreenManagerMac::windowedCGTransform): Calculates the placement of the windowed layer in screen coordinates.
5:28 PM Changeset in webkit [87455] by simonjam@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/html/HTMLScriptElement.cpp

Merge 87361 - 2011-05-25 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Add site-specific hack for zipcar.com with old versions of requirejs.
https://bugs.webkit.org/show_bug.cgi?id=61321

Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).

  • html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order.

TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/6962032

5:18 PM Changeset in webkit [87454] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-26 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify TestNetscapePlugIn naming logic
https://bugs.webkit.org/show_bug.cgi?id=61577

  • WebKit.gyp: drop use of product_prefix, just use the name needed directly.
5:08 PM Changeset in webkit [87453] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

[debug feature] CSSStyleDeclaration should have a way to print cssText
https://bugs.webkit.org/show_bug.cgi?id=61570

Adds a method to print the cssText to stderr for debugging.

  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::showStyle): New method to print cssText to stderr
  • css/CSSStyleDeclaration.h: New method declaration
5:00 PM Changeset in webkit [87452] by qi.2.zhang@nokia.com
  • 13 edits in trunk

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAuthorAndUserStylesEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAuthorAndUserStylesEnabled):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4:58 PM Changeset in webkit [87451] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

For an array of active uniform, we should be careful while truncating the name of the uniform.
Currently we are truncating the last three characters of an array with out checking for [0].
As a result we are truncating the the actual name of the active uniforms i.e. color to co.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
4:47 PM Changeset in webkit [87450] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed heapRootMarker to heapRootVisitor to match its class name
https://bugs.webkit.org/show_bug.cgi?id=61584

  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
4:47 PM Changeset in webkit [87449] by adamk@chromium.org
  • 10 edits in trunk/Source

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
  • page/FrameView.h:

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

  • public/WebFrameClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
4:39 PM Changeset in webkit [87448] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some interdependency between Heap and SmallStrings by simplifying
the SmallStrings lifetime model
https://bugs.webkit.org/show_bug.cgi?id=61579


SunSpider reports no change.


Using Weak<T> could accomplish this too, but we're not sure it will give
us the performance we need. This is a first step, and it accomplishes
most of the value of using Weak<T>.

  • heap/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): (JSC::Heap::reset): Finalize small strings just like other weak handles.
  • runtime/SmallStrings.cpp: (JSC::finalize): (JSC::SmallStrings::finalizeSmallStrings):
  • runtime/SmallStrings.h: Make all small strings trivially weak, instead of having an "all for one, one for all" memory model.
4:17 PM Changeset in webkit [87447] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87255.

4:14 PM Changeset in webkit [87446] by Lucas Forschler
  • 9 edits
    8 copies in branches/safari-534-branch/Source/WebKit2

Merge r87221.

3:58 PM Changeset in webkit [87445] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-05-26 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make RegExpCache a weak map
https://bugs.webkit.org/show_bug.cgi?id=61554

Switch to a weak map for the regexp cache, and hide that
behaviour behind RegExp::create.

When a RegExp is compiled it attempts to add itself to
the "strong" cache. This cache is a simple round-robin
buffer as was the old strong cache. Happily this can
be smaller than the old strong cache as RegExps are only
added when they're compiled so it is under less pressure
to evict.

  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::match):
  • runtime/RegExp.h: (JSC::RegExp::gcShouldInvalidateCode): (JSC::RegExp::hasCode): (JSC::RegExp::key):
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::RegExpCache): (JSC::RegExpCache::isReachableFromOpaqueRoots): (JSC::RegExpCache::finalize):
  • runtime/RegExpCache.h:
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
3:49 PM Changeset in webkit [87444] by levin@chromium.org
  • 10 edits in trunk/Source

Need a callback for when the preferred rendered size changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::contentsPreferredSizeChanged): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h: Ditto.
  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize): Added calculations for the preferred size
and the call to contentsPreferredSizeChanged.

Source/WebKit/chromium:

  • public/WebFrameClient.h

(WebKit::WebFrameClient::didChangeContentsPreferredSize): Added stub.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added declaration.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added call to WebFrameClient::didChangeContentsPreferredSize.

3:49 PM Changeset in webkit [87443] by leviw@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-05-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch controlClipRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60806

Switching controlClipRect to take an IntPoint representing the
offset to be added instead of a pair of ints.

No new tests as this is just refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBox.h: (WebCore::RenderBox::controlClipRect):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
  • rendering/RenderButton.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::controlClipRect):
  • rendering/RenderTextControlSingleLine.h:
3:43 PM Changeset in webkit [87442] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
https://bugs.webkit.org/show_bug.cgi?id=61569
<rdar://problem/9454315>

Reviewed by Steve Falkenburg.

Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
Workaround this issue by setting the real fullscreen window to be a topmost window.

  • platform/graphics/win/FullScreenController.cpp:

(FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
(FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.

3:43 PM Changeset in webkit [87441] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved Heap-related functions out of JSCell.h and into respective header files
https://bugs.webkit.org/show_bug.cgi?id=61567

  • heap/Heap.h: (JSC::Heap::allocate): (JSC::Heap::heap):
  • heap/MarkedBlock.h: (JSC::MarkedBlock::allocate):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::sizeClassFor): (JSC::MarkedSpace::allocate):
  • runtime/JSCell.h: (JSC::JSCell::destructor):
3:37 PM Changeset in webkit [87440] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

3:30 PM Changeset in webkit [87439] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-26 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[skia] Add area check to ImageBufferData::getImageData
https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData):
3:09 PM Changeset in webkit [87438] by rniwa@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

[debug feature] WTFString should have show() method
https://bugs.webkit.org/show_bug.cgi?id=61149

Added String::show and AtomicString::show in NDEBUG.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::show):
  • wtf/text/AtomicString.h:
  • wtf/text/WTFString.cpp: (String::show):
  • wtf/text/WTFString.h:
3:06 PM Changeset in webkit [87437] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch positionOverflowControls to IntSize
https://bugs.webkit.org/show_bug.cgi?id=61493

Switching positionOverflowControls to take a layerOffset IntSize
as opposed to a pair of ints.

No new tests since this is just refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls):
  • rendering/RenderLayer.h:
2:58 PM Changeset in webkit [87436] by Ademar Reis
  • 2 edits in trunk/Tools

2011-05-26 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser "Switch User Agent" dialog is broken
https://bugs.webkit.org/show_bug.cgi?id=61527

The setMaximumHeight() call is unecessary and breaks the dialog at
least on my setup.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::showUserAgentDialog):
2:50 PM Changeset in webkit [87435] by adamk@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Add Leopard rebaseline.

  • platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
2:46 PM Changeset in webkit [87434] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Factored out some Heap ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=61565

  • JavaScriptCore.exp:
  • heap/Heap.cpp: (JSC::isValidSharedInstanceThreadState): (JSC::isValidThreadState): (JSC::Heap::markRoots): (JSC::Heap::isValidAllocation):
  • heap/Heap.h:
  • runtime/JSCell.h: (JSC::JSCell::Heap::allocate):
2:43 PM Changeset in webkit [87433] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-26 Gustavo Noronha Silva <gustavo.noronha@collabora.com>

Reviewed by Martin Robinson.

Cleanup postCommitFrameViewSetup parameters which are no longer
necessary after the adjustments handling refactoring.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
2:39 PM Changeset in webkit [87432] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564

Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).

  • transforms/2d/set-transform-and-top-expected.txt: Removed.
  • transforms/2d/set-transform-and-top.html: Removed.

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564

Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).

  • rendering/RenderObject.h: (WebCore::RenderObject::needsPositionedMovementLayout):
2:37 PM Changeset in webkit [87431] by barraclough@apple.com
  • 9 edits
    2 adds in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=61508
DFG JIT - Add support for get by id self caching.

Reviewed by Geoff Garen.

Change the call out to be an unexpected call (using silent spill/fill functions),
add a structure check & compact load to the JIT code, and add repatching mechanisms.
Since DFGOperations may want to be be implemented in asm, make these symbols be extern
"C". Add an asm wrapper to pass the return address to the optimizing get-by-id operation,
so that it can look up its StructureStubInfo.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files.
  • bytecode/StructureStubInfo.h:
    • Added 'unset' entries to union.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):

  • Return the call, we need this to populate the StructureStubInfo.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • Populate the CodebBlock's StructureStubInfo Vector.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):

  • Return the call, we need this to populate the StructureStubInfo.

(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

  • Add structures to record property access info during compilation.
  • dfg/DFGOperations.cpp:
    • Made all external methods extern "C".

(JSC::DFG::operationPutByValInternal):

  • Moved outside of the extern "C" block.
  • dfg/DFGOperations.h:
    • Made all external methods extern "C".
  • dfg/DFGRepatch.cpp: Added.

(JSC::DFG::dfgRepatchCall):

  • repatch a call to link to a new callee function.

(JSC::DFG::dfgRepatchGetByIdSelf):

  • Modify the JIT code to optimize self accesses.

(JSC::DFG::tryCacheGetByID):

  • Internal implementation of dfgRepatchGetByID (factor out failing cases).

(JSC::DFG::dfgRepatchGetByID):

  • Used to optimize 'operationGetByIdOptimize' - repatches to 'operationGetById', and tries to optimize self accesses!
  • dfg/DFGRepatch.h: Added.
    • Expose dfgRepatchGetByID.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Changed implementation of GetById ops.
2:36 PM Changeset in webkit [87430] by mrowe@apple.com
  • 1 delete in trunk/Source/JavaScriptCore.xcworkspace

Remvoe the directory too, since I apparently forgot the magic git-svn argument to clean up empty directories.

2:04 PM Changeset in webkit [87429] by robert@webkit.org
  • 7 edits
    1 add in trunk

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

  • platform/qt/Skipped: Unskip plugin-initiate-popup-window.html
  • platform/qt/plugins/plugin-initiate-popup-window-expected.txt: Copied from LayoutTests/platform/mac/plugins/plugin-initiate-popup-window-expected.txt.
  • plugins/plugin-initiate-popup-window.html: Plugins are only windowless

by default on OSX, so make the plugins windowless explicitly.

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

If the event is from a user gesture and the plugin doesn't support
NPN_PushPopupsEnabledState() and NPN_PopPopupsEnabledState(), allow popups.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

Support parameters introduced in plugin-initiate-popup-window.html

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event):
1:49 PM Changeset in webkit [87428] by mrowe@apple.com
  • 1 delete in trunk/Source/JavaScriptCore.xcworkspace/contents.xcworkspacedata

Remove a bogus .xcworkspace file that was checked in and is causing problems with tab completion.

1:39 PM Changeset in webkit [87427] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled back in http://trac.webkit.org/changeset/87408 with Windows build fixed.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:
  • wtf/DoublyLinkedList.h:

(WTF::::DoublyLinkedListNode):
(WTF::::setPrev):
(WTF::::setNext):
(WTF::::prev):
(WTF::::next):
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead):

1:31 PM Changeset in webkit [87426] by Lucas Forschler
  • 9 edits in branches/safari-534-branch/Source/WebKit2

Rollout 87420, messed up merge.

1:30 PM Changeset in webkit [87425] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Source/WebKit2/ChangeLog

Rollout 87422, messed up merge.

1:09 PM Changeset in webkit [87424] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Dmitry Titov.

[V8] Add missing compile guards for WebWorkers in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=61535

No new tests - refactoring only.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
12:53 PM Changeset in webkit [87423] by mihaip@chromium.org
  • 25 edits
    3 adds in trunk

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Add test for doing a cross-origin XHR in an isolated world via
setIsolatedWorldSecurityOrigin and addOriginAccessWhitelistEntry.

Skipped on JSC ports.

  • http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt: Added.
  • http/tests/security/isolatedWorld/cross-origin-xhr.html: Added.
  • http/tests/security/isolatedWorld/resources/cross-origin-xhr.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Allows isolated worlds to be associated with a different SecurityOrigin
(exposed as a setIsolatedWorldSecurityOrigin function in
ScriptController).

The XMLHttpRequest constructor can then check that it's being
instantiated in an isolated world and use its security origin.
XMLHttpRequest, ThreadableLoader and DocumentThreadableLoader had to be
changed to use the copied SecurityOrigin instead of always grabbing the
Document's.

Test: http/tests/security/isolatedWorld/cross-origin-xhr.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::setSecurityOrigin):
  • bindings/v8/V8IsolatedContext.h: (WebCore::V8IsolatedContext::securityOrigin):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setIsolatedWorldSecurityOrigin): (WebCore::V8Proxy::resetIsolatedWorlds):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::isAllowedRedirect): (WebCore::DocumentThreadableLoader::securityOrigin):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::create): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::securityOrigin): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader):
  • xml/XMLHttpRequest.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Expose setIsolatedWorldSecurityOrigin in the WebFrame API.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
  • src/WebFrameImpl.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Expose setIsolatedWorldSecurityOrigin in LayoutTestController.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setIsolatedWorldSecurityOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
12:50 PM Changeset in webkit [87422] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Source/WebKit2/ChangeLog

Merge r87255.

12:48 PM Changeset in webkit [87421] by bweinstein@apple.com
  • 7 edits in trunk

WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=61474
<rdar://problem/9468337>

Reviewed by Adam Roben.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::statusBarIsVisible): Call the function on the client

if it exists.

(WebKit::InjectedBundlePageUIClient::menuBarIsVisible): Ditto.
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible): Ditto.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::statusbarVisible): Add a possible short-circuit in the injected bundle.
(WebKit::WebChromeClient::menubarVisible): Ditto.
(WebKit::WebChromeClient::toolbarsVisible): Ditto.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.

12:46 PM Changeset in webkit [87420] by Lucas Forschler
  • 9 edits in branches/safari-534-branch/Source/WebKit2

Merge r87221.

12:43 PM Changeset in webkit [87419] by Michael Nordman
  • 5 edits in trunk/Source

2011-05-26 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417

  • src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):

2011-05-26 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417

New new functionality, no tests.

  • storage/DatabaseTracker.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::getOpenDatabases): (WebCore::DatabaseTracker::interruptAllDatabasesForContext):
12:42 PM Changeset in webkit [87418] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Suppress more flaky Linux tests.

  • platform/chromium/test_expectations.txt:
12:36 PM Changeset in webkit [87417] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-26 Sailesh Agrawal <sail@chromium.org>

Reviewed by Tony Chang.

Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::willStartLiveResize): (WebKit::WebPopupMenuImpl::willEndLiveResize):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willStartLiveResize): (WebKit::WebViewImpl::willEndLiveResize):
  • src/WebViewImpl.h:
12:34 PM Changeset in webkit [87416] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled out http://trac.webkit.org/changeset/87408 because it broke the
Windows build.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::setPrev):
(JSC::MarkedBlock::setNext):
(JSC::MarkedBlock::prev):
(JSC::MarkedBlock::next):

  • wtf/DoublyLinkedList.h:

(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::head):
(WTF::::append):
(WTF::::remove):

12:33 PM Changeset in webkit [87415] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Suppress flaky timeouts and crashes in a few tests.

  • platform/chromium/test_expectations.txt:
12:30 PM Changeset in webkit [87414] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Safari Web Content crashes while entering/exiting the full screen mode of the video content
https://bugs.webkit.org/show_bug.cgi?id=61498

No new tests, as DRT does not currently animate the full screen transition.

To guard against m_fullScreenRenderer being called after it has been deleted, add
code in RenderFullScreen which notifies the document when its full-screen renderer
will be destroyed.

Also, add some sanity checks when accessing the full-screen renderer's layer backing.

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Guard against a missing

full-screen renderer layer.

(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Added ASSERT.
(WebCore::Document::fullScreenRendererDestroyed): Added.
(WebCore::Document::setAnimatingFullScreen): Guard against the full-screen

element having been removed from the document.

  • dom/Document.h:
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::destroy): Added. Tell the Document that it's full-screen

renderer is about to be destroyed.

  • rendering/RenderFullScreen.h:
12:26 PM Changeset in webkit [87413] by andreas.kling@nokia.com
  • 2 edits in trunk/Tools

2011-05-26 Andreas Kling <kling@webkit.org>

Unreviewed, correct address to webkit-committers mailing list.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
12:25 PM Changeset in webkit [87412] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Geoffrey Garen.

Overload resolution in generated JSC bindings could be more efficient.
https://bugs.webkit.org/show_bug.cgi?id=61544

Only fetch the arguments once, and not until they are needed (less work
in the case of an early return.)

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
12:23 PM Changeset in webkit [87411] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r87157.

12:14 PM Changeset in webkit [87410] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Remove test expectations for now-passing tests.

  • platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.
12:06 PM Changeset in webkit [87409] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-26 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Be robust to empty viewports in the compositor
https://bugs.webkit.org/show_bug.cgi?id=61545

It's possible for a frame to be requested to be drawn before it is
non-empty. The compositor should be robust to that possibility. The
changes in LayerTilerChromium are the only required changes to handle
this, but having an early out in LayerRendererChromium seemed like a
good sanity check.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
11:54 AM Changeset in webkit [87408] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Filled out some features in DoublyLinkedList
https://bugs.webkit.org/show_bug.cgi?id=61549

  • heap/MarkedBlock.h: Use DoublyLinkedListNode to simplify our class definition.
  • wtf/DoublyLinkedList.h: (WTF::::DoublyLinkedListNode): (WTF::::setPrev): (WTF::::setNext): (WTF::::prev): (WTF::::next): Added a helper base class for being a node in a list. The odd idioms here allow subclasses to choose their own data member layout, which is sometimes important for performance.

(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead): Change "Node" to "T" to be more idiomatic, and added
clear(), removeHead(), and size() functions.

11:46 AM Changeset in webkit [87407] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderObject to use FloatPoint::scale and FloatQuad::scale
https://bugs.webkit.org/show_bug.cgi?id=61497

Covered by existing test.

  • platform/graphics/FloatQuad.h: (WebCore::FloatQuad::scale):
  • rendering/RenderObject.h: (WebCore::adjustFloatQuadForAbsoluteZoom): (WebCore::adjustFloatRectForAbsoluteZoom): (WebCore::adjustFloatQuadForPageScale): (WebCore::adjustFloatRectForPageScale):
11:43 AM Changeset in webkit [87406] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Provide a real owner when copying a property table, for the sake of
write barriers.
https://bugs.webkit.org/show_bug.cgi?id=61547


No test because we can't enable the writeBarrier() ASSERT just yet.

  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition):
11:34 AM Changeset in webkit [87405] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source

2011-05-26 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix for Qt and QuickTime backend.

r87328 added a new system interface, we need to add it too.

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):

2011-05-26 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix for Qt and QuickTime backend.

r87328 added a new system interface, we need to add it too.

  • platform/qt/WebCoreSystemInterface.h:
  • platform/qt/WebCoreSystemInterface.mm:
11:28 AM Changeset in webkit [87404] by adamk@chromium.org
  • 2 edits
    36 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaselines for SVG tests added in r87284.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:22 AM Changeset in webkit [87403] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

GTK & Qt rebaselines for r87400.

  • platform/gtk/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
11:15 AM Changeset in webkit [87402] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipping 3 new inspector tests on mac-wk2, see http://webkit.org/b/61437

  • platform/mac-wk2/Skipped:
11:11 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:10 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
11:05 AM Changeset in webkit [87401] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Unreviewed follow-up to r87395, added checks to avoid accessing undefined member for certain timeline events.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord):
10:49 AM Changeset in webkit [87400] by rniwa@webkit.org
  • 11 edits
    2 adds in trunk

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466

Fixed the bug by removing duplicate properties from inline style declarations in ReplaceSelectionCommand.
Also moved the code to obtain style from rules from markup.cpp to EditingStyle.cpp to share code.

Test: editing/pasteboard/style-from-rules.html

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added a null check. (WebCore::EditingStyle::extractFontSizeDelta): Ditto. (WebCore::styleFromMatchedRulesForElement): Moved from markup.cpp. (WebCore::EditingStyle::mergeStyleFromRules): Extracted from StyledMarkupAccumulator::appendElement. (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Ditto. (WebCore::EditingStyle::removeStyleFromRules): Added.
  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Renamed from negateStyleRulesThatAffectAppearance; Calls removeStyleFromRules.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement): Calls mergeStyleFromRulesForSerialization. (WebCore::styleFromMatchedRulesAndInlineDecl): Calls mergeStyleFromRules; changed the return type from CSSMutableStyleDeclaration to EditingStyle. (WebCore::isElementPresentational): Calls styleFromMatchedRulesAndInlineDecl. (WebCore::shouldIncludeWrapperForFullySelectedRoot): Ditto. (WebCore::highestAncestorToWrapMarkup): Calls shouldIncludeWrapperForFullySelectedRoot. (WebCore::createMarkup): Calls styleFromMatchedRulesAndInlineDecl.

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466

Added a test to ensure Webkit does not leave redundant inline style declarations after paste.
Also rebaselined several tests that progressed.

  • editing/pasteboard/4922709-expected.txt:
  • editing/pasteboard/5780697-2-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/style-from-rules-expected.txt: Added.
  • editing/pasteboard/style-from-rules.html: Added.
  • platform/chromium-win/editing/pasteboard/5780697-2-expected.txt:
10:16 AM Changeset in webkit [87399] by caseq@chromium.org
  • 13 edits
    1 add in trunk

2011-05-26 Michael Schneider <michschn@google.com>

Reviewed by Pavel Feldman.

WebInspector: Added API to access the timeline data in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._addRecordToTimeline): (WebInspector.ExtensionServer.prototype._onSubscribe): (WebInspector.ExtensionServer.prototype._onUnsubscribe): (WebInspector.ExtensionServer.prototype._registerHandler): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
  • inspector/front-end/TimelineManager.js: Added. (WebInspector.TimelineManager): (WebInspector.TimelineManager.prototype.start): (WebInspector.TimelineManager.prototype.stop): (WebInspector.TimelineDispatcher): (WebInspector.TimelineDispatcher.prototype.started): (WebInspector.TimelineDispatcher.prototype.stopped): (WebInspector.TimelineDispatcher.prototype.eventRecorded):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked): (WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-05-26 Michael Schneider <michschn@google.com>

Reviewed by Pavel Feldman.

WebInspector: Added tests for timeline data API in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline):
10:11 AM Changeset in webkit [87398] by adamk@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Added baselines after r87387.

  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed override.
10:05 AM Changeset in webkit [87397] by sfalken@apple.com
  • 2 edits
    18 deletes in trunk/Source/WebKit2

2011-05-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512


Better fix for this. We just need to specify CFBundleAllowMixedLocalizations.

  • win/WebKit2WebProcess.resources/English.lproj: Removed.
  • win/WebKit2WebProcess.resources/Info.plist:
  • win/WebKit2WebProcess.resources/da.lproj: Removed.
  • win/WebKit2WebProcess.resources/de.lproj: Removed.
  • win/WebKit2WebProcess.resources/es.lproj: Removed.
  • win/WebKit2WebProcess.resources/fi.lproj: Removed.
  • win/WebKit2WebProcess.resources/fr.lproj: Removed.
  • win/WebKit2WebProcess.resources/it.lproj: Removed.
  • win/WebKit2WebProcess.resources/ja.lproj: Removed.
  • win/WebKit2WebProcess.resources/ko.lproj: Removed.
  • win/WebKit2WebProcess.resources/nb.lproj: Removed.
  • win/WebKit2WebProcess.resources/nl.lproj: Removed.
  • win/WebKit2WebProcess.resources/pl.lproj: Removed.
  • win/WebKit2WebProcess.resources/pt.lproj: Removed.
  • win/WebKit2WebProcess.resources/pt_PT.lproj: Removed.
  • win/WebKit2WebProcess.resources/ru.lproj: Removed.
  • win/WebKit2WebProcess.resources/sv.lproj: Removed.
  • win/WebKit2WebProcess.resources/zh_CN.lproj: Removed.
  • win/WebKit2WebProcess.resources/zh_TW.lproj: Removed.
9:56 AM Changeset in webkit [87396] by adamk@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Test expectations update/rebaseline.

  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium/test_expectations.txt: BUGCR84052, border-antialiasing.html IMAGE+TEXT.
9:36 AM Changeset in webkit [87395] by caseq@chromium.org
  • 5 edits in trunk

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529

Do not modify input timeline data when processing timeline event.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._refreshDetails): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529

Do not modify input timeline data when processing timeline event.

  • inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt
9:35 AM Changeset in webkit [87394] by sfalken@apple.com
  • 2 edits
    19 adds in trunk/Source/WebKit2

2011-05-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512
<rdar://problem/9498607>


These lproj directories are intentionally left empty.
Their presence indicates that this exe is localized to this
set of languages.

  • win/WebKit2WebProcess.resources/English.lproj: Added.
  • win/WebKit2WebProcess.resources/da.lproj: Added.
  • win/WebKit2WebProcess.resources/de.lproj: Added.
  • win/WebKit2WebProcess.resources/es.lproj: Added.
  • win/WebKit2WebProcess.resources/fi.lproj: Added.
  • win/WebKit2WebProcess.resources/fr.lproj: Added.
  • win/WebKit2WebProcess.resources/it.lproj: Added.
  • win/WebKit2WebProcess.resources/ja.lproj: Added.
  • win/WebKit2WebProcess.resources/ko.lproj: Added.
  • win/WebKit2WebProcess.resources/nb.lproj: Added.
  • win/WebKit2WebProcess.resources/nl.lproj: Added.
  • win/WebKit2WebProcess.resources/pl.lproj: Added.
  • win/WebKit2WebProcess.resources/pt.lproj: Added.
  • win/WebKit2WebProcess.resources/pt_PT.lproj: Added.
  • win/WebKit2WebProcess.resources/ru.lproj: Added.
  • win/WebKit2WebProcess.resources/sv.lproj: Added.
  • win/WebKit2WebProcess.resources/zh_CN.lproj: Added.
  • win/WebKit2WebProcess.resources/zh_TW.lproj: Added.
  • win/WebKit2WebProcessPostBuild.cmd: Copy entire resources directory, exclude .svn directories.
  • win/xcopy.excludes: Added. Excludes .svn directories.
9:32 AM April 2011 Meeting edited by Adam Roben
Added link to spreadsheet of bugs filed in the reducing test failures … (diff)
9:32 AM Changeset in webkit [87393] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-26 Tony Chang <tony@chromium.org>

Unreviewed, fixing the expected results for a test that had the
output duplicated.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
9:13 AM Changeset in webkit [87392] by rwlbuis@webkit.org
  • 4 edits
    6 adds in trunk

2011-05-26 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028

Tests: svg/animations/animate-insert-begin.html

svg/animations/animate-insert-no-begin.html

Move animation initializing and rescheduling to insertedIntoDocument. This way animate elements
dynamicaly inserted into the document using js start as well.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument):
  • svg/animation/SVGSMILElement.h:

2011-05-26 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028

Add tests for dynamically inserting <animate>.

  • svg/animations/animate-insert-begin-expected.txt: Added.
  • svg/animations/animate-insert-begin.html: Added.
  • svg/animations/animate-insert-no-begin-expected.txt: Added.
  • svg/animations/animate-insert-no-begin.html: Added.
  • svg/animations/script-tests/animate-insert-begin.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/animate-insert-no-begin.js: Added. (sample1): (sample2): (executeTest):
9:08 AM Changeset in webkit [87391] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-26 Chang Shu <cshu@webkit.org>

Unreviewed.

[Qt] http/tests/websocket/tests/reload-crash.html fails intermittently with time out
https://bugs.webkit.org/show_bug.cgi?id=50152

Unskip the test case as it's not reproducible. Will watch the buildbot results.

  • platform/qt/Skipped: Unskip http/tests/websocket/tests/reload-crash.html
9:05 AM Changeset in webkit [87390] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

JSC DOM bindings: ExecState::argumentCount() is size_t, not int.
https://bugs.webkit.org/show_bug.cgi?id=61530

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
8:56 AM Changeset in webkit [87389] by Simon Fraser
  • 3 edits
    3 adds in trunk

2011-05-26 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Some repeating linear gradients look wrong
https://bugs.webkit.org/show_bug.cgi?id=61371

Test: fast/gradients/css3-repeating-linear-gradients2.html

Fix incorrect stop duplication code when filling forwards a repeating
gradient. The "if (srcStopOrdinal < originalNumStops - 1)" test was wrong
because srcStopOrdinal had been adjusted for stops added by start-filling,
but originalNumStops had not. Fix by considering srcStopOrdinal as an index
into the original stops, so comparing it with originalNumStops remains valid.

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
8:54 AM Changeset in webkit [87388] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: In network panel, show transfer size in a first line of resource row.
https://bugs.webkit.org/show_bug.cgi?id=61354

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
8:34 AM Changeset in webkit [87387] by Simon Fraser
  • 5 edits
    3 adds in trunk

2011-05-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Always antialias borders, outlines and rules when scaling
https://bugs.webkit.org/show_bug.cgi?id=61502

r84273 changed the behavior of drawLineForBoxSide() to never antialias by default.
This actually disabled antialiasing in some circumstances where it used to be enabled,
for example collapsed table border drawing.

Fix by allowing antialiasing for collapsed table borders, column rules and span
outlines when the context is scaled.

Test: fast/borders/border-antialiasing.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintCollapsedBorder):
8:01 AM Changeset in webkit [87386] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark inspector/profiler/cpu-profiler-profiling.html as flaky on Linux

7:54 AM Changeset in webkit [87385] by Csaba Osztrogonác
  • 2 edits
    5 adds in trunk/LayoutTests

[Qt][WK2] Update expected files after r87320.

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Added.
7:35 AM Changeset in webkit [87384] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove test cases related to layoutTestController.dumpBackForwardList from qt-wk2/Skipped
https://bugs.webkit.org/show_bug.cgi?id=61462

WebKitTestRunner already support layoutTestController.dumpBackForwardList from r70723.

  • platform/qt-wk2/Skipped:
7:28 AM Changeset in webkit [87383] by yurys@chromium.org
  • 9 edits in trunk

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

  • inspector/debugger/source-frame.html:

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.NetworkItemView._contentViewForResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get messages): (WebInspector.Resource.prototype.addMessage): (WebInspector.Resource.prototype.set errors): (WebInspector.Resource.prototype.set warnings): (WebInspector.Resource.prototype.clearErrorsAndWarnings):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent): (WebInspector.ResourceView.nonSourceViewForResource): (WebInspector.ResourceSourceFrame): (WebInspector.ResourceSourceFrame.mimeTypeForResource): (WebInspector.ResourceSourceFrame.prototype.requestContent): (WebInspector.ResourceSourceFrame.prototype.suggestedFileName): (WebInspector.EditableResourceSourceFrame): (WebInspector.EditableResourceSourceFrame.prototype.doubleClick): (WebInspector.EditableResourceSourceFrame.prototype.editContent): (WebInspector.EditableResourceSourceFrame.prototype.cancelEditing): (WebInspector.EditableResourceSourceFrame.prototype.afterTextChanged): (WebInspector.EditableResourceSourceFrame.prototype._clearIncrementalUpdateTimer): (WebInspector.ResourceRevisionSourceFrame): (WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._resourceViewForResource): (WebInspector.ResourcesPanel.prototype._showRevisionView): (WebInspector.ResourcesPanel.prototype._sourceViewForRevision): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision): (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision.getParent): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype.onattach): (WebInspector.FrameResourceTreeElement.prototype._updateErrorsAndWarningsBubbles): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsCleared): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsMessageAdded): (WebInspector.FrameResourceTreeElement.prototype._appendRevision): (WebInspector.FrameResourceTreeElement.prototype.sourceView): (WebInspector.FrameResourceTreeElement.prototype._createSourceView): (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent): (WebInspector.ResourceRevisionTreeElement.prototype.sourceView):
7:01 AM Changeset in webkit [87382] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] http/tests/eventsource/workers/eventsource-simple.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=61523

  • platform/gtk/Skipped:
6:28 AM Changeset in webkit [87381] by Philippe Normand
  • 1 edit
    7 adds in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
6:20 AM Changeset in webkit [87380] by Adam Roben
  • 2 edits in trunk/Tools

Don't assume that builds finish in the order they were started

Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
build when one slave is taking a long time to finish a build

Reviewed by Antti Koivisto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
newer than the oldest in-progress build are also themselves in progress. Just check whether
each build is actually in progress (as signified by its presence in the currentBuilds set).

5:54 AM Changeset in webkit [87379] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update. Mark 3 tests as flaky

5:48 AM Changeset in webkit [87378] by Adam Roben
  • 3 edits in trunk/Tools

Correctly detect cases where only a single test failed/crashed/timed out

Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
failing test

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
will be singular when only a single test fails/crashes/times out.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
failed/crashed/timed out.

5:45 AM Changeset in webkit [87377] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r87346

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Fixed up exports to match

reality.

5:20 AM Changeset in webkit [87376] by Philippe Normand
  • 1 edit
    29 deletes in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, rollout of r87373 and r87375. Those commits were
mistaken. I'll properly land the baselines later on.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-actual.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-diffs.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-expectted.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-stderr.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-actual.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-diffs.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-actual.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-diffs.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-actual.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-diffs.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-actual.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-diffs.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-pretty-diff.html.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-actual.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-diffs.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-pretty-diff.html.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-actual.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-diffs.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-pretty-diff.html.txt: Removed.
5:09 AM Changeset in webkit [87375] by mnaganov@chromium.org
  • 7 moves in trunk/LayoutTests/platform/gtk

Unreviewed. Rename .html files from r87374 to .html.txt to avoid confusion with tests

4:46 AM Changeset in webkit [87374] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

JSC DOM bindings: Use isUndefinedOrNull() instead of (isNull()
isUndefined()).

https://bugs.webkit.org/show_bug.cgi?id=61472

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined. (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
3:53 AM Changeset in webkit [87373] by Philippe Normand
  • 1 edit
    29 adds in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-actual.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-diffs.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-pretty-diff.html: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-stderr.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-actual.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-diffs.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-add-details-child-2-actual.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-diffs.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-replace-summary-child-actual.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-diffs.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-replace-text-actual.txt: Added.
  • platform/gtk/fast/html/details-replace-text-diffs.txt: Added.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-text-pretty-diff.html: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-actual.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-diffs.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-pretty-diff.html: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-actual.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-diffs.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-pretty-diff.html: Added.
2:58 AM Changeset in webkit [87372] by keishi@webkit.org
  • 6 edits
    4 adds in trunk

2011-05-26 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Add <input type=color> appearance.
https://bugs.webkit.org/show_bug.cgi?id=61275

  • fast/forms/color/input-appearance-color.html: Added. Tests appearance of input type=color.
  • platform/chromium/test_expectations.txt: Expect FAIL for fast/forms/color
  • platform/mac/fast/forms/color/input-appearance-color-expected.png: Added.
  • platform/mac/fast/forms/color/input-appearance-color-expected.txt: Added.

2011-05-26 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Add <input type=color> appearance.
https://bugs.webkit.org/show_bug.cgi?id=61275

Test: fast/forms/color/input-appearance-color.html

  • css/html.css: (input[type="color"]): Adds square-button appearance. (input[type="color"]::-webkit-color-swatch-wrapper): (input[type="color"]::-webkit-color-swatch): (input[type="color"][list]): Adds menulist appearance. (input[type="color"][list]::-webkit-color-swatch-wrapper): (input[type="color"][list]::-webkit-color-swatch):
  • html/ColorInputType.cpp: (WebCore::ColorInputType::createShadowSubtree): Creates -webkit-color-swatch inside -webkit-color-swatch-wrapper. (WebCore::ColorInputType::updateColorSwatch): Updates background color of shadowColorSwatch. (WebCore::ColorInputType::valueChanged): Calls updateColorSwatch. (WebCore::ColorInputType::shadowColorSwatch): Gets shadowColorSwatch element.
  • html/ColorInputType.h: (WebCore::ColorInputType::ColorInputType): Changed to inherit InputType.
2:10 AM Changeset in webkit [87371] by tkent@chromium.org
  • 11 edits
    2 adds in trunk

2011-05-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bug that <input type="number"> dispatches two blurs when tabbing
from an invalid number
https://bugs.webkit.org/show_bug.cgi?id=59071

  • fast/forms/input-number-blur-twice-expected.txt: Added.
  • fast/forms/input-number-blur-twice.html: Added.

2011-05-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bug that <input type="number"> dispatches two blurs when tabbing
from an invalid number
https://bugs.webkit.org/show_bug.cgi?id=59071

NumberInputType::handleBlurEvent() dispatched an extra focus event
and an extra blur event because
SelectionController::textWillBeReplaced() called by
RenderTextControlSingleLine::updateFromElement() focuses a node
with the selection.

In order to avoid this problem,

  • Introduce Node::willBlur() It is called before any state changes by a blur event.
  • Call RenderTextControlSingleLine::updateFromElement() in willBlur() It avoids extra focus/blur events because Document::m_focusedNode is still the number input during willBlur().

Test: fast/forms/input-number-blur-twice.html

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Calls Node::beforeBlueEvent().
  • dom/Node.cpp: (WebCore::Node::willBlur): Default empty implementation of willBlur().
  • dom/Node.h: Declare willBlur().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willBlur): Added. It just calls InputType::willBlur(). (WebCore::HTMLInputElement::handleBlurEvent): Removed InputType::handleBlurEvent() call.
  • html/HTMLInputElement.h: Declare willBlur().
  • html/InputType.cpp: (WebCore::InputType::willBlur): Default empty implementation. (WebCore::InputType::handleBlurEvent): Removed.
  • html/InputType.h: Declare willBlur(), remove handleBlurEvent().
  • html/NumberInputType.cpp: (WebCore::NumberInputType::willBlur): Move the code in handleBlurEvent() here.
  • html/NumberInputType.h: Declare willBlur().
1:48 AM Changeset in webkit [87370] by hans@chromium.org
  • 12 edits
    1 copy
    1 move
    2 adds in trunk/Source/WebCore

2011-05-25 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Support LevelDB transactions.
https://bugs.webkit.org/show_bug.cgi?id=61270

Introduce LevelDBTransaction, which implements in-memory transaction
support on top of LevelDB, and hook this up for IndexedDB to use.

This is all covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::IteratorImpl): (WebCore::IteratorImpl::isValid): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::IteratorImpl::key): (WebCore::IteratorImpl::value): (WebCore::LevelDBDatabase::createIterator): (WebCore::LevelDBDatabase::comparator):
  • platform/leveldb/LevelDBDatabase.h:
  • platform/leveldb/LevelDBIterator.h: (WebCore::LevelDBIterator::~LevelDBIterator):
  • platform/leveldb/LevelDBTransaction.cpp: Added. (WebCore::LevelDBTransaction::create): (WebCore::LevelDBTransaction::LevelDBTransaction): (WebCore::LevelDBTransaction::clearTree): (WebCore::LevelDBTransaction::~LevelDBTransaction): (WebCore::makeVector): (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::put): (WebCore::LevelDBTransaction::remove): (WebCore::LevelDBTransaction::get): (WebCore::LevelDBTransaction::commit): (WebCore::LevelDBTransaction::rollback): (WebCore::LevelDBTransaction::createIterator): (WebCore::LevelDBTransaction::TreeIterator::create): (WebCore::LevelDBTransaction::TreeIterator::isValid): (WebCore::LevelDBTransaction::TreeIterator::seekToLast): (WebCore::LevelDBTransaction::TreeIterator::seek): (WebCore::LevelDBTransaction::TreeIterator::next): (WebCore::LevelDBTransaction::TreeIterator::prev): (WebCore::LevelDBTransaction::TreeIterator::key): (WebCore::LevelDBTransaction::TreeIterator::value): (WebCore::LevelDBTransaction::TreeIterator::isDeleted): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::create): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::isValid): (WebCore::LevelDBTransaction::TransactionIterator::seekToLast): (WebCore::LevelDBTransaction::TransactionIterator::seek): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes): (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToSmallestKey): (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToLargestKey): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::resetIterators):
  • platform/leveldb/LevelDBTransaction.h: Added. (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_less): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_less): (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_greater): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_greater): (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_balance_factor): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_balance_factor): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_key): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_node): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_node_node): (WebCore::LevelDBTransaction::AVLTreeAbstractor::null): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
  • platform/leveldb/LevelDBWriteBatch.cpp: (WebCore::LevelDBWriteBatch::create): (WebCore::LevelDBWriteBatch::LevelDBWriteBatch): (WebCore::LevelDBWriteBatch::~LevelDBWriteBatch): (WebCore::makeSlice): (WebCore::LevelDBWriteBatch::put): (WebCore::LevelDBWriteBatch::remove): (WebCore::LevelDBWriteBatch::clear):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::findGreatestKeyLessThan): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor): (WebCore::IDBLevelDBBackingStore::createTransaction): (WebCore::IDBLevelDBBackingStore::Transaction::create): (WebCore::IDBLevelDBBackingStore::Transaction::Transaction): (WebCore::IDBLevelDBBackingStore::Transaction::begin): (WebCore::IDBLevelDBBackingStore::Transaction::commit): (WebCore::IDBLevelDBBackingStore::Transaction::rollback):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort):
1:08 AM Changeset in webkit [87369] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

ASSERT(isMainThread()) when using single threaded jsc executable
https://bugs.webkit.org/show_bug.cgi?id=60846

Remove the ASSERT since we do not have the concept of MainThread in JSC.

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
12:59 AM Changeset in webkit [87368] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

  • transforms/2d/set-transform-and-top-expected.txt: Added.
  • transforms/2d/set-transform-and-top.html: Added.

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

Test: transforms/2d/set-transform-and-top.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedLayout):
12:44 AM Changeset in webkit [87367] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-26 Tom Hudson <tomhudson@google.com>

Reviewed by Tony Chang.

Add flags to Chromium ImageDiff to write image comparison metrics on
stdout.
https://bugs.webkit.org/show_bug.cgi?id=60569

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::createFromStdin): Fix spelling. (maxOf3): New function to do 3-way maximum. (getRedComponent): Extract red component from ABGR packed encoding. (getGreenComponent): Extract green component from ABGR packed encoding. (getBlueComponent): Extract blue component from ABGR packed encoding. (weightedPercentageDifferent): Determine % of pixels different in two images multiplied by intensity difference of each pixel. (printHelp): Document new arguments. (compareImages): Parameterize. (untestedCompareImages): Parameterize. (diffImages): Parameterize; write results on stdout if requested. (main): Parse new arguments.
12:15 AM Changeset in webkit [87366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

drag-not-loaded-image.html test crashes when WebKit is built with debug option
https://bugs.webkit.org/show_bug.cgi?id=61480

Checks if image has content before starting to drag.

  • page/DragController.cpp: (WebCore::DragController::startDrag):
12:01 AM Changeset in webkit [87365] by alokp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Cannot create stencil render-buffer for accelerated drawing on desktop GL
https://bugs.webkit.org/show_bug.cgi?id=61444

Used DEPTH24_STENCIL8 format for stencil buffer instead of STENCIL_INDEX8.
Packed depth-stencil buffer is the most common format supported by graphics cards.
It is not very robust to rely on just one format being supported,
so long term the task of creating FBO should be delegated to SKIA,
which has necessary code to iterate through all possible formats.

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

May 25, 2011:

11:58 PM Changeset in webkit [87364] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=61506

Reviewed by Sam Weinig.

Move the silent spill/fill methods in the DFG JIT to the JITCodeGenerator
so that they are available to the SpeculativeJIT.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):

  • dfg/DFGNonSpeculativeJIT.h:
11:48 PM Changeset in webkit [87363] by jer.noble@apple.com
  • 7 edits in trunk

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505

Add support for painting MediaReturnToRealtimeButton, as well as hide and show
the correct default video control buttons when entering full-screen mode.

  • css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Show the "Back 30s" and

"Return to Realtime" buttons for Live Streams in full-screen mode.

(WebCore::MediaControlRootElement::exitedFullscreen): Reset the styles of

all the buttons affected by enteredFullscreen().

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart): Add support for

MediaReturnToRealtimeButton.

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

30 second rewind button dysfunctional viewing trailers fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=61505

Updated WKSI Libraries with new images for Backward buttons in default
video controls.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:46 PM Changeset in webkit [87362] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-25 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement various CSS font properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=60603

No new tests - refactoring only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyFont): Added templated class to handle font properties (WebCore::ApplyPropertyFontWeight): Added class to handle font weight calculation (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Instantiate ApplyPropertyFont/ApplyPropertyFontWeight for appropriate properties.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove properties that are now implemented in CSSStyleApplyProperty
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontDescription): Added getter for m_style->fontDescription() (WebCore::CSSStyleSelector::parentFontDescription): Added getter for m_parentStyle->fontDescription() (WebCore::CSSStyleSelector::setFontDescription): Added setter for m_style->setFontDescription() that automatically sets m_fontDirty
11:20 PM Changeset in webkit [87361] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-25 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Add site-specific hack for zipcar.com with old versions of requirejs.
https://bugs.webkit.org/show_bug.cgi?id=61321

Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).

  • html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order.
11:15 PM Changeset in webkit [87360] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

2011-05-25 Andreas Kling <kling@webkit.org>

Reviewed by David Levin.

Rebaseline run-bindings-tests.
https://bugs.webkit.org/show_bug.cgi?id=61469

  • bindings/scripts/test/JS/:
  • bindings/scripts/test/V8/:
10:32 PM Changeset in webkit [87359] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

An attempt to revive Windows bots.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-05-25

  • runtime/RegExp.cpp:
  • runtime/RegExp.h:
10:19 PM Changeset in webkit [87358] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

An attempt to revive Windows bots.

  • runtime/RegExp.cpp:
  • runtime/RegExp.h:
9:16 PM Changeset in webkit [87357] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] REGRESSION(r87298) Skip drag-not-loaded-image.html failing test
https://bugs.webkit.org/show_bug.cgi?id=61465

Skip drag-not-loaded-image.html layout test from Qt. see bug 31332

  • platform/qt/Skipped:
9:12 PM Changeset in webkit [87356] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.

Reviewed by Sam Weinig.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Call::fromTailJump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::isSet):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::link):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::linkCall):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::linkCall):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::linkCall):

  • assembler/MacroAssemblerSH4.cpp:

(JSC::MacroAssemblerSH4::linkCall):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::linkCall):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

9:05 PM Changeset in webkit [87355] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=61500
Add JSObject::offsetOfPropertyStorage

Reviewed by Sam Weinig.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):

  • runtime/JSObject.h:

(JSC::JSObject::offsetOfPropertyStorage):

8:50 PM Changeset in webkit [87354] by commit-queue@webkit.org
  • 26 edits in trunk/LayoutTests

2011-05-25 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Rebaseline media tests after moving media controls to flexbox layout.

https://bugs.webkit.org/show_bug.cgi?id=61380

  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
8:32 PM Changeset in webkit [87353] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-25 Gregg Tavares <gman@chromium.org>

Reviewed by Kenneth Russell.

Add 'noExtensions' option to Web/GraphicsContext3D attributes.
https://bugs.webkit.org/show_bug.cgi?id=61460

  • Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
  • Source/WebCore/platform/graphics/GraphicsContext3D.h:
  • Source/WebKit/chromium/public/WebGraphicsContext3D.h:
  • Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:
8:13 PM Changeset in webkit [87352] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch itemBoundingBoxRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60789

Changing itemBoundingBoxRect to use an IntPoint representing the offset
to be added tot he box rect instead of a pair of ints.

No new tests since this is just refactoring.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
  • accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::addFocusRingRects): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
7:31 PM Changeset in webkit [87351] by morrita@google.com
  • 16 edits
    6 adds in trunk

2011-05-24 MORITA Hajime <morrita@google.com>

RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=61111

  • Added tests that capture the probelem.
  • Updated expectations that were wrong.
  • fast/html/details-replace-summary-child.html: Added.
  • fast/html/details-replace-text.html: Added.
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/mac/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/mac/fast/html/details-replace-text-expected.png: Added.
  • platform/mac/fast/html/details-replace-text-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:

2011-05-24 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderText with empty text is not created inside ShadowContentElement
https://bugs.webkit.org/show_bug.cgi?id=61111

  • Changed Text::rendererIsNeeded() to be shadow-aware.
  • previousRenderer(), nextRenderer() and parentRenderer() on NodeRenderingContext is now safe even if it's used with an attached node, which was originally used only during attach(). We need this change because these APIs are called inside CharacterData::updateRenderer() callstack.

Tests: fast/html/details-replace-summary-child.html

fast/html/details-replace-text.html

  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer): (WebCore::NodeRenderingContext::parentRenderer): (WebCore::NodeRenderingContext::shouldCreateRenderer):
  • dom/NodeRenderingContext.h: (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
  • dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
6:58 PM Changeset in webkit [87350] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
reported as http://crbug.com/83994.

  • platform/chromium/test_expectations.txt:
6:50 PM Changeset in webkit [87349] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Temporarily ignore MHTML test failures on Windows
while we dig into it in http://crbug.com/83833.

  • platform/chromium/test_expectations.txt:
6:48 PM Changeset in webkit [87348] by qi.2.zhang@nokia.com
  • 13 edits in trunk

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetPrivateBrowsingEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42697

Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPrivateBrowsingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
6:30 PM Changeset in webkit [87347] by commit-queue@webkit.org
  • 2 edits
    2 moves in trunk/Source/WebCore

2011-05-25 Sailesh Agrawal <sail@chromium.org>

Reviewed by Tony Chang.

Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
https://bugs.webkit.org/show_bug.cgi?id=61401

ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.

  • WebCore.gypi:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
  • platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
  • platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.
6:12 PM Changeset in webkit [87346] by oliver@apple.com
  • 24 edits in trunk/Source

2011-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

Make RegExp GC allocated. Basically mechanical change to replace
most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
where actual ownership happens.

Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addRegExp):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitNewRegExp):
  • bytecompiler/BytecodeGenerator.h:
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::addRegExpToTrace):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::invalidateCode):
  • runtime/RegExp.h: (JSC::RegExp::createStructure):
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
  • runtime/RegExpCache.h:
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): (JSC::RegExpObject::visitChildren):
  • runtime/RegExpObject.h: (JSC::RegExpObject::setRegExp): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::regExpProtoFuncCompile):
  • runtime/RegExpPrototype.h:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):

2011-05-25 James Robinson <jamesr@chromium.org>

Reviewed by Geoffrey Garen

CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481

CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.

This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::overheadSize):
6:08 PM Changeset in webkit [87345] by oliver@apple.com
  • 26 edits in trunk/Source

Revert last change, something weird happened when I went to land.

6:07 PM Changeset in webkit [87344] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-25 James Robinson <jamesr@chromium.org>

Reviewed by Geoffrey Garen

CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481

CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.

This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::overheadSize):
6:01 PM Changeset in webkit [87343] by oliver@apple.com
  • 26 edits in trunk/Source

2011-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

Make RegExp GC allocated. Basically mechanical change to replace
most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
where actual ownership happens.

Made the RegExpCache use Strong<> references currently to avoid any
changes in behaviour.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addRegExp):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitNewRegExp):
  • bytecompiler/BytecodeGenerator.h:
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::addRegExpToTrace):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::invalidateCode):
  • runtime/RegExp.h: (JSC::RegExp::createStructure):
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
  • runtime/RegExpCache.h:
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): (JSC::RegExpObject::visitChildren):
  • runtime/RegExpObject.h: (JSC::RegExpObject::setRegExp): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::regExpProtoFuncCompile):
  • runtime/RegExpPrototype.h:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):

2011-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make RegExp GC allocated
https://bugs.webkit.org/show_bug.cgi?id=61490

RegExp is GC'd so we don't need the RefPtr shenanigans anymore.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):
5:59 PM Changeset in webkit [87342] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-25 Shishir Agrawal <shishir@chromium.org>

Reviewed by Dimitri Glazkov.

Fix crash in Chromium memory test.
https://bugs.webkit.org/show_bug.cgi?id=61451

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
5:52 PM Changeset in webkit [87341] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.

  • platform/chromium/test_expectations.txt:
5:44 PM Changeset in webkit [87340] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Skip failing tests after r87328.

  • platform/mac/Skipped:
5:27 PM Changeset in webkit [87339] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Test expectations update.

  • platform/chromium/test_expectations.txt:
5:24 PM Changeset in webkit [87338] by adamk@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87333.
http://trac.webkit.org/changeset/87333
https://bugs.webkit.org/show_bug.cgi?id=61488

Breaks Chromium build due to pure virtual methods. (Requested
by aklein on #webkit).

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
5:04 PM Changeset in webkit [87337] by jam@chromium.org
  • 1 edit in trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

Revert 79703 since it broke pdf scrolling (http://crbug.com/81878) - 2011-02-15 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):

TBR=brettw@chromium.org

4:54 PM Changeset in webkit [87336] by mrobinson@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
https://bugs.webkit.org/show_bug.cgi?id=60185

Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
state into PlatformContextCairo. Since Cairo is the only platform that needs
to store this, this is the proper place for it. Change the image mask stack into
a more generic state stack that can keep track of the multiple bits of platform
specific state and properly handle save/restore pairs.

No new tests. This is just a code refactor.

  • platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs. (WebCore::GraphicsContextState::GraphicsContextState): Ditto.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now. (WebCore::ContextShadow::drawRectShadow):
  • platform/graphics/cairo/FontCairo.cpp: Ditto. (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): Ditto. (WebCore::setPlatformStroke): Ditto. (WebCore::GraphicsContext::setAlpha): Ditto.
  • platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the header file, since it can be private now. Abstract the image mask state and the global alpha in a generic State class. (WebCore::ImageMaskInformation::update): (WebCore::ImageMaskInformation::isValid): (WebCore::ImageMaskInformation::maskSurface): (WebCore::ImageMaskInformation::maskRect): (WebCore::PlatformContextCairo::State::State): Added. (WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state class when this class is constructed. (WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack. (WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward declare the State class in the header. (WebCore::PlatformContextCairo::save): Push a new state onto the stack. (WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now. (WebCore::PlatformContextCairo::globalAlpha): Added. (WebCore::PlatformContextCairo::setGlobalAlpha): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha().
  • platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack into a more generic state stack, much like PlatformContextChromium.
4:41 PM Changeset in webkit [87335] by mrowe@apple.com
  • 7 edits in trunk/Source

<rdar://problem/9504058> Need some way to query user gesture state from injected bundle

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Add an export that WebKit2 needs.

Source/WebKit2:

Add WKBundleIsProcessingUserGesture.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleIsPageBoxVisible):
(WKBundleIsProcessingUserGesture):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::isProcessingUserGesture):

  • WebProcess/InjectedBundle/InjectedBundle.h:
4:39 PM Changeset in webkit [87334] by adamk@chromium.org
  • 3 edits
    7 adds
    1 delete in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaseline svg tests after r87310.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
4:30 PM Changeset in webkit [87333] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-25 Sailesh Agrawal <sail@chromium.org>

Reviewed by Darin Fisher.

Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::willStartLiveResize): (WebKit::WebPopupMenuImpl::willEndLiveResize):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willStartLiveResize): (WebKit::WebViewImpl::willEndLiveResize):
  • src/WebViewImpl.h:
4:09 PM Changeset in webkit [87332] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Removing test_expectations for non-existent tests.

  • platform/chromium/test_expectations.txt:
4:08 PM Changeset in webkit [87331] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Ureviewed; Build fix for Leopard and Snow Leopard.

Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.

  • WebCore.exp.in:
4:05 PM Changeset in webkit [87330] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-25 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig.

Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
https://bugs.webkit.org/show_bug.cgi?id=61478

Cleanup of further comments after patch was landed. Changes include
using /2 instead of >>1, adding a blank line after class include,
making method names start with lower case and adding clarifying
comments.

No new tests as the changes are stylistic and not functional.

  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::pruneLiveResourcesToPercentage): (WebCore::MemoryCache::pruneDeadResourcesToPercentage):
  • loader/cache/MemoryCache.h: (WebCore::MemoryCache::pruneToPercentage):
  • platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::respondToMemoryPressure):
4:00 PM Changeset in webkit [87329] by slewis@apple.com
  • 11 edits in trunk/Source

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload. Restructure the conditions so it only called when absolutely
necessary.

Reviewed by Brady Eidson.

No change in functionality so no new tests.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::subresourceCachePolicy):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):

Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Remove Quicklook pref. Moving it enirely down into WebCore so it can
be calculated only on reloads.

Reviewed by Brady Eidson.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

3:53 PM Changeset in webkit [87328] by jer.noble@apple.com
  • 16 edits in trunk

2011-05-24 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

No new tests; Covered by media/video-canvas-source.html.

Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
remote->local and make our answer to hasSingleSecurityOrigin dynamic.

When checking whether a given request has a single security origin, use a
SecurityOrigin to check the host, port, and scheme.

  • WebCore.exp.in:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference

for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the

requested and resolved URLs have the same host and port.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for

NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.

(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the

requested and resolved URLs have the same host and port.

  • platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-05-24 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and

wkQTMovieResolvedURL.

2011-05-24 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and

wkQTMovieResolvedURL.

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

Added functions to retrieve the resolved URL for media types supported on
mac.

  • WebKitSystemInterface.h:
  • WebKitSystemInterface.m: (WKAVAssetResolvedURL): Added. (WKQTMovieResolvedURL): Added.
3:49 PM Changeset in webkit [87327] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476

RegExp construction now simply validates the RegExp, it does
not perform actual codegen.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::recompile): (JSC::RegExp::compile): (JSC::RegExp::match):
  • runtime/RegExp.h: (JSC::RegExp::recompileIfNecessary):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::performMatch):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSplit):
3:46 PM Changeset in webkit [87326] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; Update Skipped list for failing tests.

A new full-screen test requires <video> full screen support, which does not
exist on mac-leopard. Follow-up to r87322.

  • platform/mac-leopard/Skipped:
3:03 PM Changeset in webkit [87325] by adamk@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Test expectations update, followup to r87291.

The aforementioned change cleared out these files, when the intent
seems to have been removal to remove them.

  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.
2:56 PM Changeset in webkit [87324] by jhoneycutt@apple.com
  • 6 edits
    3 adds in trunk

REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
https://bugs.webkit.org/show_bug.cgi?id=61428
<rdar://problem/9457006>

Reviewed by Adam Roben.

Source/WebKit2:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

  • Platform/WorkItem.h:

(DerefWorkItem::DerefWorkItem):
Initialize m_ptr.
(DerefWorkItem::execute):
Deref the object.
(WorkItem::createDeref):
Create and return a DerefWorkItem.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::unprotectPluginFromDestruction):
If the PluginView has only one reference left, deref it asynchronously.

Tools:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

This test emulates that behavior.

  • DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.

(CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
Initialize member vars.
(CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
Remove our custom property from the message window, and destroy it.
(CallJSThatDestroysPlugin::NPP_Destroy):
Set m_isDestroyed, log that the plug-in was destroyed, and notify the
layout test controller that we're done.
(wndProc):
Get the PluginTest object, and call its runTest() function.
(CallJSThatDestroysPlugin::NPP_New):
Setup the test: register a class for the message-only window, create
it, and post a message to it to run the test.
(CallJSThatDestroysPlugin::runTest):
Execute JS that removes the plug-in from the page, and if we're not
destroyed, log a success message.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Add new test to project.

LayoutTests:

  • platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
  • platform/win/plugins/call-javascript-that-destroys-plugin.html: Added.
2:47 PM Changeset in webkit [87323] by scherkus@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-25 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

  • media/media-ended-expected.txt: Added.
  • media/media-ended.html: Added.

2011-05-25 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix media element regression where ended event stopped firing after changing the src attribute.

https://bugs.webkit.org/show_bug.cgi?id=61336

Test: media/media-ended.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
2:45 PM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt on Windows bots to 4.7.3 (diff)
2:38 PM Changeset in webkit [87322] by jer.noble@apple.com
  • 7 edits
    3 adds in trunk

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461

  • fullscreen/full-screen-iframe-legacy-expected.txt: Added.
  • fullscreen/full-screen-iframe-legacy.html: Added.
  • fullscreen/resources/legacy.html: Added.

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
https://bugs.webkit.org/show_bug.cgi?id=61461

Tests: fullscreen/full-screen-iframe-legacy.html

Allow calls from the legacy full-screen API to bypass the iframe
"webkitallowfullscreen" requirement by adding a parameter to
Document::webkitRequestFullScreenForElement specifying the strictness
of that check. Specify this new parameter everywhere that function is
called, including in the default controls' full-screen button handler.

  • dom/Document.cpp: (WebCore::Document::webkitRequestFullScreenForElement):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen):
  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
2:33 PM Changeset in webkit [87321] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-05-25 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

webkitpy's NetworkTransaction shouldn't use mechanize
https://bugs.webkit.org/show_bug.cgi?id=61450

mechanize.HTTPError is just an alias for urllib2.HTTPError, so
use urllib2 directly. Re-add NetworkTransaction to
test_results_uploader.py (reverting r87124).

  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2:31 PM Changeset in webkit [87320] by caio.oliveira@openbossa.org
  • 3 edits in trunk/LayoutTests

[Qt] Missing update for expected results in LayoutTests after r87315
https://bugs.webkit.org/show_bug.cgi?id=61467

Reviewed by Andreas Kling.

We now expose qt_sender as a non-enumarated property in the
global object. Fix our expectations in relevant tests.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
2:29 PM Changeset in webkit [87319] by commit-queue@webkit.org
  • 4 edits
    14 adds in trunk

2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by David Hyatt.

Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752

Added test cases for all the attribute selector types (CSS2.1 & CSS3).

  • fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-begin-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-contain-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-end-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-exact-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-list-dynamic-no-elementstyle.html: Added.
  • fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt: Added.
  • fast/css/attribute-selector-set-dynamic-no-elementstyle.html: Added.

2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>

Reviewed by David Hyatt.

Selector matching doesn't update when DOM changes ("[data-a=x] #x")
https://bugs.webkit.org/show_bug.cgi?id=60752

Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
which are used in CSS attribute selectors to determine the need for style
recalculation whenever element attributes are manipulated in DOM.
In certain conditions (element with no style, element is styled and attribute
is not a mapped attribute, attribute is of type 'type' or read-only)
even when attribute selector matches for an element, the attribute is not
added to m_selectorAttrs. This results in missing style recalculations
when a DOM element attribute is changed and is not found in m_selectorAttrs.

Removing the above said conditions in
CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
attributes in m_selectorAttrs will solve this issue. But this particular
function is called numerous times which triggers adding duplicate attributes
again and again.

This patch follows the approach taken for collecting ids in selectors, where
all the attributes in selectors are added to a HashSet at the time of adding
style rules to CSSStyleSelector from StyleSheets and when
CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
simply looked up in this pre-populated hash set.

Test: fast/css/attribute-selector-dynamic-no-elementstyle.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::collectFeaturesFromSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
  • css/CSSStyleSelector.h:
2:23 PM Changeset in webkit [87318] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Adam Klein <adamk@chromium.org>

Unreviewed. Update chromium expectations after r87307.

  • platform/chromium/test_expectations.txt: suppress, WK61470.
1:32 PM Changeset in webkit [87317] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by James Robinson.

CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
https://bugs.webkit.org/show_bug.cgi?id=61454

Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
by one enum, and provided a way to obtain rules from UA/user stylesheets.

  • css/CSSRule.h: Removed CSSRuleFilter.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): See above. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
  • css/CSSStyleSelector.h: Moved CSSRuleFilter here.
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules): Ditto.
12:37 PM Changeset in webkit [87316] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Removed MarkSetProperties because it was unused
https://bugs.webkit.org/show_bug.cgi?id=61418

  • heap/MarkStack.h: (JSC::MarkSet::MarkSet): (JSC::MarkStack::append):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSArray.h: (JSC::JSArray::visitChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/WriteBarrier.h: (JSC::MarkStack::appendValues):
12:28 PM Changeset in webkit [87315] by caio.oliveira@openbossa.org
  • 8 edits in trunk/Source

2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement qt_sender without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343

Create a stack to keep track of the sender objects. This is simpler than
the similar mechanism in QObject (C++ API), that keeps a stack per-object.

Since we do not support multiple threads, one static stack will be enough for
handling the behavior.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::qtSenderStack): We have one static stack of QObject*. The top of the stack contains the last object that emitted signal that called a JavaScript function.
  • bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::QtSenderStack::top): (JSC::Bindings::QtInstance::QtSenderStack::push): (JSC::Bindings::QtInstance::QtSenderStack::pop): Minimal functionality to manipulate the sender stack.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute): Remove the previous code that modified the scope chain. Push the sender object to the stack before calling the JavaScript function (the "slot" in Qt-speak) and pop it afterwards.

2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC bridge: implement qt_sender without using Scope Chain
https://bugs.webkit.org/show_bug.cgi?id=61343

Create a 'qt_sender' property in the global object, that returns the top of
the qtSenderStack. This is an alternative implementation for the feature of
providing a way for a function (acting as a Qt 'slot') discover which object
emitted the signal that caused it to be executed.

This reduces the coupling of the Qt bridge and JSC internal implementation. The
patch tries to use as much JSC public API as possible.

This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls a QWebPagePrivate function to do it.
  • Api/qwebframe_p.h:
  • Api/qwebframe.cpp: (QWebFramePrivate::didClearedWindowObject): Before emitting the signal mentioned, adds the 'qt_sender' to the fresh global object.

(qtSenderCallback):
Returns the JSObjectRef corresponding to the top of qtSenderStack.

(QWebFramePrivate::addQtSenderToGlobalObject):
Create a property with a qtSenderCallback as getter function in the global object.

12:25 PM Changeset in webkit [87314] by kevino@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
until the port begins using those export macros.

12:23 PM Changeset in webkit [87313] by commit-queue@webkit.org
  • 20 edits
    2 deletes in trunk

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

  • storage/indexeddb/migrate-basics-expected.txt: Removed.
  • storage/indexeddb/migrate-basics.html: Removed.

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

  • storage/IDBBackingStore.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp:
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBSQLiteBackingStore.cpp:
  • storage/IDBSQLiteBackingStore.h:

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

  • public/WebIDBFactory.h:
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457

This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
12:22 PM Changeset in webkit [87312] by alexis.menard@openbossa.org
  • 23 edits
    1 copy
    3 adds in trunk/Source

2011-05-25 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61279

Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
when calling build-webkit.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/KURL.h:
  • platform/SharedBuffer.h:
  • platform/cf/KURLCFNet.cpp:
  • platform/cf/SharedBufferCF.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::paint): (-[WebCoreMovieObserver layerHostChanged:]):
  • platform/mac/KURLMac.mm:
  • platform/mac/SharedBufferMac.mm: (+[WebCoreSharedBufferData initialize]):
  • platform/mac/WebCoreObjCExtras.mm:
  • platform/qt/WebCoreSystemInterface.h: Added.
  • platform/qt/WebCoreSystemInterface.mm: Added.

2011-05-25 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61279

Enable the usage of QuickTime backend for the Qt port. It can be enabled by
passing DEFINES+=USE_QTKIT=1 when calling build-webkit.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • QtWebKit.pro:
  • WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/WebSystemInterface.h: Added.
  • WebCoreSupport/WebSystemInterface.mm: Added. (InitWebCoreSystemInterface):
12:20 PM Changeset in webkit [87311] by qi.2.zhang@nokia.com
  • 9 edits
    2 adds in trunk

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Unskip test case and provide expect result files.

  • platform/qt/Skipped:
  • platform/qt/fast/css/disabled-author-styles-expected.png: Added.
  • platform/qt/fast/css/disabled-author-styles-expected.txt: Added.

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/css/disabled-author-styles.html failed
https://bugs.webkit.org/show_bug.cgi?id=61438

Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAuthorAndUserStylesEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:01 PM Changeset in webkit [87310] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk

2011-05-25 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.

WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569

Updated improved pixel test result and add new SVG1.1 SE test and results.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.

2011-05-25 Rob Buis <rbuis@rim.com>

Reviewed by Eric Seidel.
New test rubber-stamped by Dirk Schulze.

WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569

Do not render elements that reference non-existant filters.

Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg

  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
11:51 AM Changeset in webkit [87309] by Nate Chapin
  • 10 edits in trunk

2011-05-25 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
https://bugs.webkit.org/show_bug.cgi?id=59113

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
  • dom/Document.h: (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
11:48 AM Changeset in webkit [87308] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make allocations with guard pages ensure that the allocation succeeded
https://bugs.webkit.org/show_bug.cgi?id=61453

Add null checks, and make PageBlock's operator bool() use
the realbase, rather than the start of usable memory.

  • wtf/OSAllocatorPosix.cpp: (WTF::OSAllocator::reserveAndCommit):
  • wtf/PageBlock.h: (WTF::PageBlock::operator bool): (WTF::PageBlock::PageBlock):
11:45 AM Changeset in webkit [87307] by jchaffraix@webkit.org
  • 11 edits in trunk

2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by James Robinson.

http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027

And:

  • canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt: Those 2 tests need a trailing line that was added as part of this change.
  • fast/canvas/canvas-composite-alpha.html: Updated the test result to match the specification. The changes are fairly simple:
    • Clear up the destination rectangle as it should be always transparent now (source is transparent outside the source rectangle).
    • Clear the composition rectangle if source or destination is transparent.
    • Fixed the test when run in the browser.

Validated the changes against FF and Opera (IE 9 cannot render this test).

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped: Re-enable 4 tests.

2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by James Robinson.

http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
https://bugs.webkit.org/show_bug.cgi?id=39027

And:

Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
them together as the fix is common.

Based on an older work by Ariya Hidayat.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2 cases if we have to.

(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
(WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
(which matches other browsers' behavior) and "display transparency elsewhere".

  • html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.
10:58 AM Changeset in webkit [87306] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

2011-05-20 Robert Hogan <robert@webkit.org>

Reviewed by Geoffrey Garen.

[Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html

Use the test netscape plugin instead of quicktime.
Allows the test to pass on Qt/Gtk/Chromium as well as Mac.

https://bugs.webkit.org/show_bug.cgi?id=61182
http://code.google.com/p/chromium/issues/detail?id=15797

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • plugins/embed-attributes-setting-expected.txt:
  • plugins/embed-attributes-setting.html:
10:22 AM Changeset in webkit [87305] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
https://bugs.webkit.org/show_bug.cgi?id=61448

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
after intersecting the two rectangles.

10:10 AM Changeset in webkit [87304] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Reviewed by Eric Seidel.

Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.

https://bugs.webkit.org/show_bug.cgi?id=27551

10:06 AM Changeset in webkit [87303] by leviw@chromium.org
  • 22 edits in trunk/Source/WebCore

2011-05-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add IntPoint versions of IntRect::move and IntPoint::move
https://bugs.webkit.org/show_bug.cgi?id=61390

Adding move methods to IntRect and IntPoint that take an IntPoint
that's acting as an offset. Since we also apply negative offsets,
also adding a single parameter operator- for IntPoint.

No new tests since this is refactoring.

  • page/FrameView.cpp: (WebCore::FrameView::invalidateScrollbarRect): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::move): (WebCore::operator-):
  • platform/graphics/IntRect.h: (WebCore::IntRect::move):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::requestedRegionOfInputImageData):
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalRectToPhysicalRect): (WebCore::RenderBlock::selectionGaps):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::localCaretRect):
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderLayerBacking.cpp: (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerCompositor.cpp: (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
10:04 AM Changeset in webkit [87302] by leviw@chromium.org
  • 22 edits in trunk/Source/WebCore

2011-05-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch addFocusRingRects to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60783

Switching addFocusRingRects to use an IntPoint representing the offset being
applied instead of a pair of ints.

No new tests as this is only refactoring.

  • platform/graphics/FloatSize.h: (WebCore::flooredIntPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addFocusRingRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::addFocusRingRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addFocusRingRects):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::absoluteFocusRingQuads):
  • rendering/RenderObject.h: (WebCore::RenderObject::addFocusRingRects):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::addFocusRingRects):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addFocusRingRects):
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::addFocusRingRects):
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::addFocusRingRects):
  • rendering/svg/RenderSVGPath.h:
9:50 AM Changeset in webkit [87301] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87229.
http://trac.webkit.org/changeset/87229
https://bugs.webkit.org/show_bug.cgi?id=61445

Lots of tests crashing in
CFNetwork!URLResponse::createFilenameFromResponseHeaders on
Windows XP (Requested by aroben on #webkit).

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo):
  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
9:48 AM Changeset in webkit [87300] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Leon Scroggins <scroggo@google.com>

Reviewed by Steve Block.

Update chromium expectations for more canvas fixes.
https://bugs.webkit.org/show_bug.cgi?id=61433

  • platform/chromium/test_expectations.txt:
9:38 AM Changeset in webkit [87299] by Adam Roben
  • 4 edits in trunk/Tools

Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.info): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.

9:33 AM Changeset in webkit [87298] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314

Checks if WebKit crashes when dragging an image not yet loaded.

  • http/tests/misc/drag-not-loaded-image-expected.txt: Added.
  • http/tests/misc/drag-not-loaded-image.html: Added.

2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] QtWebKit crashes when dragging not loaded images
https://bugs.webkit.org/show_bug.cgi?id=61314

Checks if nativeImageForCurrentFrame is a valid pointer.

Test: http/tests/misc/drag-not-loaded-image.html

  • platform/qt/DragImageQt.cpp: (WebCore::createDragImageFromImage):
9:27 AM Changeset in webkit [87297] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Xan Lopez.

[GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
https://bugs.webkit.org/show_bug.cgi?id=61436

Fix arguments of gdk_drawable_get_size.

No new tests, no behavior change.

  • platform/gtk/GtkVersioning.c: (getGdkDrawableSize):
8:02 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:58 AM Changeset in webkit [87296] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipped 3 new inspector tests that time out on gtk.

  • platform/gtk/Skipped:
7:50 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:46 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:20 AM Changeset in webkit [87295] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failed tests after r87290 and r87292 on ARM

  • platform/qt-arm/Skipped:
7:02 AM Changeset in webkit [87294] by apavlov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extreme lagging when searching for "img[src*="
https://bugs.webkit.org/show_bug.cgi?id=61282

No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
when built and search-highlighted, rather than through innerHTML.

  • inspector/front-end/DOMSyntaxHighlighter.js: (WebInspector.DOMSyntaxHighlighter): (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.highlightSearchResults): (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide): (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight): (WebInspector.ElementsTreeElement.prototype._addNewAttribute): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM): ():
  • inspector/front-end/utilities.js: ():
5:34 AM Changeset in webkit [87293] by commit-queue@webkit.org
  • 15 edits
    9 adds in trunk/Source/WebCore

2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Introduce HTML5 track list objects.
https://bugs.webkit.org/show_bug.cgi?id=60184

Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
for their use in the MediaStream API and the HTML Media Element.
Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist

The Media Stream API will test this feature in the bug 56587.
More tests related to the HTML Media Element may be added later.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toTrackList): (WebCore::EventTarget::toMultipleTrackList): (WebCore::EventTarget::toExclusiveTrackList):
  • dom/EventTarget.h:
  • dom/ExclusiveTrackList.cpp: Added. (WebCore::ExclusiveTrackList::create): (WebCore::ExclusiveTrackList::ExclusiveTrackList): (WebCore::ExclusiveTrackList::~ExclusiveTrackList): (WebCore::ExclusiveTrackList::clear): (WebCore::ExclusiveTrackList::select): (WebCore::ExclusiveTrackList::toExclusiveTrackList):
  • dom/ExclusiveTrackList.h: Added. (WebCore::ExclusiveTrackList::selectedIndex):
  • dom/ExclusiveTrackList.idl: Added.
  • dom/MultipleTrackList.cpp: Added. (WebCore::MultipleTrackList::create): (WebCore::MultipleTrackList::MultipleTrackList): (WebCore::MultipleTrackList::~MultipleTrackList): (WebCore::MultipleTrackList::clear): (WebCore::MultipleTrackList::isEnabled): (WebCore::MultipleTrackList::enable): (WebCore::MultipleTrackList::disable): (WebCore::MultipleTrackList::toMultipleTrackList):
  • dom/MultipleTrackList.h: Added.
  • dom/MultipleTrackList.idl: Added.
  • dom/TrackList.cpp: Added. (WebCore::Track::create): (WebCore::Track::Track): (WebCore::TrackList::create): (WebCore::TrackList::TrackList): (WebCore::TrackList::~TrackList): (WebCore::TrackList::length): (WebCore::TrackList::checkIndex): (WebCore::TrackList::getID): (WebCore::TrackList::getKind): (WebCore::TrackList::getLabel): (WebCore::TrackList::getLanguage): (WebCore::TrackList::clear): (WebCore::TrackList::postChangeEvent): (WebCore::TrackList::dispatchChangeEvent): (WebCore::TrackList::toTrackList): (WebCore::TrackList::scriptExecutionContext): (WebCore::TrackList::eventTargetData): (WebCore::TrackList::ensureEventTargetData):
  • dom/TrackList.h: Added. (WebCore::Track::id): (WebCore::Track::kind): (WebCore::Track::label): (WebCore::Track::language): (WebCore::TrackList::DispatchTask::create): (WebCore::TrackList::DispatchTask::performTask): (WebCore::TrackList::DispatchTask::DispatchTask): (WebCore::TrackList::refEventTarget): (WebCore::TrackList::derefEventTarget):
  • dom/TrackList.idl: Added.
5:06 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
4:55 AM Changeset in webkit [87292] by keishi@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

2011-05-25 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Move ElementWithPseudoId to separate file
https://bugs.webkit.org/show_bug.cgi?id=61430

No new tests because no behavior changes.

  • CMakeLists.txt: Added ElementWithPseudoId.cpp
  • GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
  • WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
  • WebCore.pro: Added ElementWithPseudoId.{h,cpp}
  • WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
  • WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
  • html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
  • html/shadow/ElementWithPseudoId.cpp: Added. (WebCore::ElementWithPseudoId::shadowPseudoId):
  • html/shadow/ElementWithPseudoId.h: Added. (WebCore::ElementWithPseudoId::create): (WebCore::ElementWithPseudoId::ElementWithPseudoId):
4:43 AM Changeset in webkit [87291] by antonm@chromium.org
  • 5 edits
    4 adds in trunk/LayoutTests

2011-05-25 Anton Muhin <antonm@chromium.org>

Unreviewed.

Update test expectations after 3.3.6.1 v8 roll.

  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
  • platform/chromium/ietestcenter: Added.
  • platform/chromium/ietestcenter/Javascript: Added.
  • platform/chromium/ietestcenter/Javascript/15.4.4.14-5-28-expected.txt: Added.
  • platform/chromium/ietestcenter/Javascript/15.4.4.15-5-28-expected.txt: Added.
4:39 AM Changeset in webkit [87290] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-25 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=34635

Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
application with -style plastique for example, therefore the code used for other styles should also be
used whenever the current style is not the Mac style.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
4:21 AM Changeset in webkit [87289] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update chromium test expectations.

  • platform/chromium/test_expectations.txt: svn/dynamic-updates failing
4:19 AM Changeset in webkit [87288] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip a flakey timed out test on ARM

  • platform/qt-arm/Skipped:
4:08 AM Changeset in webkit [87287] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update chromium test expectations.

  • platform/chromium/test_expectations.txt: mhtml tests pass
4:00 AM Changeset in webkit [87286] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:41 AM Changeset in webkit [87285] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:34 AM Changeset in webkit [87284] by commit-queue@webkit.org
  • 1 edit
    36 adds in trunk/LayoutTests

2011-05-25 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
https://bugs.webkit.org/show_bug.cgi?id=59677

  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-dx-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-dy-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-dx-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-dy-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-rotate-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-x-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-y-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dx-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dy-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-x-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-y-prop.js: Added. (executeTest):
3:12 AM Changeset in webkit [87283] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Clean up WebSocket test expectations
https://bugs.webkit.org/show_bug.cgi?id=61429

  • platform/chromium/test_expectations.txt: Remove two test expectations for tests that are no longer failing.
2:52 AM Changeset in webkit [87282] by yutak@chromium.org
  • 4 edits in trunk

2011-05-25 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353

  • http/tests/websocket/tests/frame-length-overflow-expected.txt: Added a new console message.

2011-05-25 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Use fail() when WebSocketChannel has failed
https://bugs.webkit.org/show_bug.cgi?id=61353

An existing error message has been modified, but it is impossible
to test this message in LayoutTests because it is only shown when
memory allocation has failed, which is hard to reproduce reliably.

One new message has been added. It is covered by an existing test
http/tests/websocket/tests/frame-length-overflow.html.

There is no other change in behavior. No new tests are added.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail): Do not close if we know the socket stream is already closed. This does not change the behavior, because SocketStreamBase does nothing if it is already closed. (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didReceiveData): We need to set m_shouldDiscardReceivedData to true before calling fail(), so I moved the error message from appendToBuffer() to here. The error message was rephrased in order to improve readability. (WebCore::WebSocketChannel::appendToBuffer): Unnested the code. (WebCore::WebSocketChannel::processBuffer):
2:35 AM Changeset in webkit [87281] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by David Levin.

CSSParser: m_implicitShorthand should probably be RAII
https://bugs.webkit.org/show_bug.cgi?id=51586

It was impossible to entirely eliminate the m_implicitShorthand manual changes
due to the parseFill*() method stateful call chains.

No new tests, as this is a refactoring.

  • css/CSSParser.cpp: (ImplicitScope::ImplicitScope): (ImplicitScope::~ImplicitScope): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseBorderRadius):
2:03 AM Changeset in webkit [87280] by podivilov@chromium.org
  • 6 edits in trunk

2011-05-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364

  • inspector/debugger/live-edit-expected.txt:
  • inspector/debugger/live-edit.html:
  • platform/chromium/test_expectations.txt:

2011-05-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: inspected page crashes when call stack is empty after live edit.
https://bugs.webkit.org/show_bug.cgi?id=61364

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
12:48 AM Changeset in webkit [87279] by ager@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-25 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

Update chromium expectations after removal of execScript from V8
https://bugs.webkit.org/show_bug.cgi?id=61267

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
12:45 AM Changeset in webkit [87278] by yurys@chromium.org
  • 3 edits
    3 adds in trunk

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

Test: inspector/console/console-eval-syntax-error.html

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

  • inspector/console/console-eval-syntax-error-expected.txt: Added.
  • inspector/console/console-eval-syntax-error.html: Added.
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.
12:30 AM Component Model edited by dominicc@chromium.org
Updated the status of legacy shadow DOM post r87014 (diff)
12:17 AM Changeset in webkit [87277] by yuzo@google.com
  • 10 edits in trunk/Source/WebCore

2011-05-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
https://bugs.webkit.org/show_bug.cgi?id=61352

No new tests because no behavior changes.

  • html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaVolumeSliderContainer::layout):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::layout):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
  • rendering/RenderView.h: (WebCore::RenderView::disableLayoutState): (WebCore::RenderView::enableLayoutState): (WebCore::LayoutStateDisabler::LayoutStateDisabler): (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):

May 24, 2011:

11:42 PM Changeset in webkit [87276] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed typo fix after r87228.

  • WebCore.pro:
11:37 PM Changeset in webkit [87275] by timothy@apple.com
  • 3 edits in trunk/Source/WebKit2

Make the Web Inspector bring the right window to the front when docked.

rdar://problem/9464685
https://webkit.org/b/61420

Reviewed by Brian Weinstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformBringToFront): Ditto.

11:23 PM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt on minimal bot (diff)
11:03 PM Changeset in webkit [87274] by tkent@chromium.org
  • 33 edits
    3 adds
    3 deletes in trunk

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • configure.ac: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-color.html: Removed.
  • fast/forms/color/input-value-sanitization-color-expected.txt: Added.
  • fast/forms/color/input-value-sanitization-color.html: Added. Tests sanitization algorithm for input type=color.
  • fast/forms/input-type-change3-expected.txt:
  • fast/forms/input-widths-expected.txt:
  • fast/forms/input-widths.html: Removed type=color because it is no loger a text input type.
  • fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
  • fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
  • fast/forms/script-tests/input-type-change3.js:
  • platform/gtk/Skipped: Skip fast/forms/color.
  • platform/mac/Skipped: Skip fast/forms/color.
  • platform/qt/Skipped: Skip fast/forms/color.
  • platform/win/Skipped: Skip fast/forms/color.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

Test: fast/forms/color/input-value-sanitization-color.html

  • Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
  • GNUmakefile.am: Added COLOR_INPUT feature flag.
  • features.pri: Added COLOR_INPUT feature flag.
  • html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::isColorControl): Added. (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec. (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
  • html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag. (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
  • html/InputType.cpp: (WebCore::InputType::isColorControl): Added.
  • html/InputType.h:

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • features.gypi: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • Scripts/build-webkit: Added INPUT_COLOR feature flag.

2011-05-24 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
https://bugs.webkit.org/show_bug.cgi?id=61273

  • win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.
10:56 PM Changeset in webkit [87273] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip new failing test.

  • platform/qt-wk2/Skipped:
9:54 PM Changeset in webkit [87272] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
https://bugs.webkit.org/show_bug.cgi?id=61349
<rdar://problem/9476255>

  • WebProcess/com.apple.WebProcess.sb:
9:43 PM Changeset in webkit [87271] by sfalken@apple.com
  • 279 edits in branches/safari-534-branch/LayoutTests

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Rubber stamped by Maciej Stachowiak.

Update test results after http://trac.webkit.org/changeset/87211
which disabled several features.

9:38 PM Changeset in webkit [87270] by commit-queue@webkit.org
  • 3 edits
    2 adds
    16 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61402

Converts the two html files to dump-as-markup and adds doctype, html, and body tags.

  • editing/selection/4895428-1-expected.txt: Added.
  • editing/selection/4895428-1.html: Converted to dump-as-markup
  • editing/selection/4895428-4-expected.txt: Added.
  • editing/selection/4895428-4.html: Converted to dump-as-markup
  • platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
  • platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
  • platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
  • platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
  • platform/gtk/editing/selection/4895428-1-expected.png: Removed.
  • platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
  • platform/gtk/editing/selection/4895428-4-expected.png: Removed.
  • platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
  • platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
  • platform/mac/editing/selection/4895428-1-expected.png: Removed.
  • platform/mac/editing/selection/4895428-1-expected.txt: Removed.
  • platform/mac/editing/selection/4895428-4-expected.png: Removed.
  • platform/mac/editing/selection/4895428-4-expected.txt: Removed.
9:38 PM Changeset in webkit [87269] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Reviewed by Eric Seidel.

Add export macros to WTFString.h.

https://bugs.webkit.org/show_bug.cgi?id=27551

9:35 PM Changeset in webkit [87268] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-24 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

https://bugs.webkit.org/show_bug.cgi?id=61379

  • platform/chromium/test_expectations.txt: Added expected failures from this change.

2011-05-24 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Move chromium media controls timeline back to flexible rather than absolute
layout.

https://bugs.webkit.org/show_bug.cgi?id=61379

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
9:26 PM Changeset in webkit [87267] by tkent@chromium.org
  • 4 edits
    1 add
    21 deletes in trunk/LayoutTests

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Convert fast/forms/input-type-change.html to a dumpAsText() test
https://bugs.webkit.org/show_bug.cgi?id=61029

Merge input-type-change2 to input-type-change.html, and convert it to
a dumpAsText() test.

  • fast/forms/input-type-change-expected.txt:
  • fast/forms/input-type-change.html:
  • fast/forms/input-type-change2.html: Removed.
  • platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
  • platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
  • platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/gtk/fast/forms/input-type-change-expected.png: Removed.
  • platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
  • platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
  • platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
  • platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change-expected.txt:
  • platform/mac/fast/forms/input-type-change-expected.txt: Removed.
  • platform/mac/fast/forms/input-type-change2-expected.png: Removed.
  • platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
  • platform/qt-arm/Skipped: Remove input-type-change2.html.
  • platform/qt-mac/Skipped: ditto.
  • platform/qt/fast/forms/input-type-change-expected.txt: Removed.
  • platform/qt/fast/forms/input-type-change2-expected.txt: Removed.
9:20 PM Changeset in webkit [87266] by ukai@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix clang error.

error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::create):

9:17 PM Changeset in webkit [87265] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Hajime Morita.

<legend> element is dropped on the floor
https://bugs.webkit.org/show_bug.cgi?id=18691

  • html5lib/resources/webkit02.dat: Added a passing test for <legend> parsing.
9:14 PM Changeset in webkit [87264] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Tony Chang.

editing/deleting/5032066 should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61327

Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.

  • editing/deleting/5032066-expected.txt: Added.
  • editing/deleting/5032066.html:
  • platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
  • platform/gtk/editing/deleting/5032066-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
  • platform/mac/editing/deleting/5032066-expected.png: Removed.
  • platform/mac/editing/deleting/5032066-expected.txt: Removed.
  • platform/qt/editing/deleting/5032066-expected.png: Removed.
  • platform/qt/editing/deleting/5032066-expected.txt: Removed.
9:04 PM Changeset in webkit [87263] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
https://bugs.webkit.org/show_bug.cgi?id=61330

Converted to dump-as-markup and added a little html cleanup.

  • editing/deleting/5115601-expected.txt: Added.
  • editing/deleting/5115601.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
  • platform/gtk/editing/deleting/5115601-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
  • platform/mac/editing/deleting/5115601-expected.png: Removed.
  • platform/mac/editing/deleting/5115601-expected.txt: Removed.
  • platform/qt/editing/deleting/5115601-expected.png: Removed.
  • platform/qt/editing/deleting/5115601-expected.txt: Removed.
8:50 PM Changeset in webkit [87262] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61332

Used dump-as-markup to improve readability of results.
Also improved HTML and cleaned up descriptions.

  • editing/deleting/5206311-2-expected.txt: Added.
  • editing/deleting/5206311-2.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
  • platform/mac/editing/deleting/5206311-2-expected.png: Removed.
  • platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5206311-2-expected.png: Removed.
  • platform/qt/editing/deleting/5206311-2-expected.txt: Removed.
8:39 PM Changeset in webkit [87261] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
https://bugs.webkit.org/show_bug.cgi?id=61333

Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.

  • editing/deleting/delete-block-table-expected.txt: Added.
  • editing/deleting/delete-block-table.html: Converted to dump-as-markup.
  • platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
  • platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.
8:39 PM Changeset in webkit [87260] by abarth@webkit.org
  • 10 edits in trunk/Source

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

All the callers of the API are wrong. They should call the more modern
static member function of ScriptController instead. I'll remove the
FrameLoader function in a future patch.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-05-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add FIXME comments about removing FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=61395

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
8:28 PM Changeset in webkit [87259] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Justin Novosad <junov@chromium.org>

Reviewed by Stephen White.

[Chromium] cleanup test expectations for drawImage that are no longer
flaky
https://bugs.webkit.org/show_bug.cgi?id=61389

  • platform/chromium/test_expectations.txt:
8:03 PM Changeset in webkit [87258] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • platform/efl/WidgetEfl.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
8:00 PM Changeset in webkit [87257] by commit-queue@webkit.org
  • 20 edits
    2 adds in trunk

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

LayoutTest for migration between SQLite and LevelDB
in IndxededDB.

  • storage/indexeddb/migrate-basics-expected.txt: Added.
  • storage/indexeddb/migrate-basics.html: Added.

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

Test: storage/indexeddb/migrate-basics.html

  • storage/IDBBackingStore.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setEnableMigration): (WebCore::IDBFactoryBackendImpl::migrate):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h: (WebCore::IDBLevelDBBackingStore::backingStoreType):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h: (WebCore::IDBSQLiteBackingStore::backingStoreType):

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::setEnableMigration):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::setEnableMigration):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactory::setOverrideBackingStoreType): (WebKit::WebIDBFactory::setTemporaryDatabaseFolder): (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl): (WebKit::WebIDBFactoryImpl::open): (WebKit::WebIDBFactoryImpl::setEnableMigration):
  • src/WebIDBFactoryImpl.h:

2011-05-24 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
7:54 PM Changeset in webkit [87256] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Chromium expectations update. (mhtml)

  • platform/chromium/test_expectations.txt:
7:52 PM Changeset in webkit [87255] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

Explicitly use uint32_t when encoding / decoding a type that is a typedef of OSType,
as this is declared as different underlying types in 32- and 64-bit (unsigned long
vs unsigned int).

  • Shared/mac/KeychainAttribute.cpp:

(CoreIPC::encode):
(CoreIPC::decode):

7:35 PM Changeset in webkit [87254] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Leon Scroggins <scroggo@google.com>

Reviewed by Kenneth Russell.

Update expectations for tests drawing a canvas into another canvas (or itself), which have been fixed in gpu.
https://bugs.webkit.org/show_bug.cgi?id=61362

  • platform/chromium/test_expectations.txt:
7:22 PM Changeset in webkit [87253] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Enable coalesced wheel events
<rdar://problem/9444786>

Reviewed by Maciej Stachowiak.

  • UIProcess/WebPageProxy.cpp:

Flip the switch for coalescing wheel events rather than dropping them.

7:18 PM Changeset in webkit [87252] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

7:16 PM Changeset in webkit [87251] by Lucas Forschler
  • 1 copy in tags/Safari-534.39

New tag.

7:14 PM Changeset in webkit [87250] by Lucas Forschler
  • 9 edits
    8 deletes in branches/safari-534-branch/Source/WebKit2

Rollout 87221.

7:07 PM Changeset in webkit [87249] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Final attempt to fix a test; if this fails, I'm just going to skip it.

  • fast/events/selectstart-by-double-triple-clicks.html:
6:26 PM Changeset in webkit [87248] by leo.yang@torchmobile.com.cn
  • 4 edits
    2 adds in trunk

2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Ryosuke Niwa.

[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692

Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.

Test: editing/pasteboard/drag-drop-input-in-svg.svg

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):

2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Ryosuke Niwa.

[SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
https://bugs.webkit.org/show_bug.cgi?id=60692

Test case to verify dragging and dropping text between input fields
inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.

Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.

  • editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
  • editing/pasteboard/drag-drop-input-in-svg.svg: Added.
  • platform/qt/Skipped:
6:05 PM Changeset in webkit [87247] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Yet another attempt to make Chromium Windows test bots happy.

  • fast/events/selectstart-by-double-triple-clicks.html:
5:59 PM Changeset in webkit [87246] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r87187.

5:56 PM Changeset in webkit [87245] by Lucas Forschler
  • 9 edits
    2 copies in branches/safari-534-branch

Merge r87179 + fix.

5:48 PM Changeset in webkit [87244] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-24 Andy Estes <aestes@apple.com>

Reviewed by Geoffrey Garen.

REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
https://bugs.webkit.org/show_bug.cgi?id=61229

This site-specific hack maintains compatibility with Mac OS X Wiki Server,
which embeds QuickTime movies using an object tag containing QuickTime's
ActiveX classid. Treat this classid as valid only if OS X Server's unique
'generator' meta tag is present. Only apply this quirk if there is no
fallback content, which ensures the quirk will disable itself if Wiki
Server is updated to generate an alternate embed tag as fallback content.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return true if site-specific quirks are enabled, the object element has no fallback content, the classid attribute matches QuickTime's classid and the document has a 'generator' meta tag matching Mac OS X Web Services Server's unique generator string. (WebCore::HTMLObjectElement::hasValidClassId): Call shouldAllowQuickTimeClassIdQuirk()
  • html/HTMLObjectElement.h:
5:33 PM Changeset in webkit [87243] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Maybe fix the Mac build now?

5:29 PM Changeset in webkit [87242] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87170.

5:27 PM Changeset in webkit [87241] by Lucas Forschler
  • 9 edits
    8 copies in branches/safari-534-branch/Source/WebKit2

Merge r87221.

5:25 PM Changeset in webkit [87240] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87154.

5:24 PM Changeset in webkit [87239] by Nate Chapin
  • 29 edits in trunk/Source/WebCore

2011-05-24 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Change CachedResources to take a ResourceRequest instead of
a url in their constructors and provide a very minimal set of
cases for avoiding reusing a CachedResource. The ResourceRequest
part of this change requires pushing responsibility
for calling Document::completeURL() to the caller, instead of
CachedResourceLoader, since ResourceRequest ASSERTs if it
is constructed with an invalid url.

https://bugs.webkit.org/show_bug.cgi?id=61318

Refactor, no new tests.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::CachedFont):
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::checkShouldPaintBrokenImage):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::reuseRequest): (WebCore::CachedResource::allowReuseOfRequest): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::resourceRequest): (WebCore::CachedResource::url):
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::checkNotify):
  • loader/cache/CachedXSLStyleSheet.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
5:24 PM Changeset in webkit [87238] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-534-branch/Source/WebKit2

Merge r87153.

5:23 PM Changeset in webkit [87237] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Additional sandbox extension required for quarantine database
<rdar://problem/9397494>
https://bugs.webkit.org/show_bug.cgi?id=61405

  • WebProcess/com.apple.WebProcess.sb: Add read-data access for ~/Library/Preferences.
5:18 PM Changeset in webkit [87236] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87119.

5:18 PM Changeset in webkit [87235] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use Element::shadowPseudoId() for text field decoration elements
https://bugs.webkit.org/show_bug.cgi?id=61351

No new tests. Covered by existing tests.

  • css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
    • -webkit-inner-spin-button
    • -webkit-input-speech-button
    • -webkit-outer-spin-button
    • -webkit-search-cancel-button
    • -webkit-search-decoration
    • -webkit-search-results-button
    • -webkit-search-results-decoration

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h: ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Store shadowPseudoId() result in a local variable because SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
  • html/shadow/TextControlInnerElements.cpp: Override Element::shadowPseudoId() instead of Element::styleForRenderer(). (WebCore::SearchFieldResultsButtonElement::shadowPseudoId): (WebCore::SearchFieldCancelButtonElement::shadowPseudoId): (WebCore::SpinButtonElement::shadowPseudoId): (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
  • html/shadow/TextControlInnerElements.h: Update declarations.
  • rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
  • rendering/RenderTextControlSingleLine.h: ditto.
  • rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.
5:16 PM Changeset in webkit [87234] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r87109.

5:12 PM Changeset in webkit [87233] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Maybe fix the Mac build?

5:00 PM Changeset in webkit [87232] by Lucas Forschler
  • 16 edits in branches/safari-534-branch/Source

Merge r87102.

4:49 PM Changeset in webkit [87231] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-24 Dimitri Glazkov <Dimitri Glazkov>

Sorted WebCore.xcodeproj again.

  • WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
4:46 PM Changeset in webkit [87230] by ggaren@apple.com
  • 11 edits
    1 copy in trunk/Source/JavaScriptCore

2011-05-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split HeapRootVisitor into its own class
https://bugs.webkit.org/show_bug.cgi?id=61399

  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/HandleHeap.cpp:
  • heap/HandleStack.cpp:
  • heap/Heap.cpp:
  • heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
  • heap/MarkStack.h:
  • runtime/ArgList.cpp:
  • runtime/SmallStrings.cpp:
4:46 PM Changeset in webkit [87229] by slewis@apple.com
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

Reviewed by Geoff Garen.

No new tests because functionality has not changed.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::platformLazyInit):

4:43 PM Changeset in webkit [87228] by msaboff@apple.com
  • 13 edits
    3 adds in trunk/Source

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added call to enable memory pressure handling.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
  • WebView/WebViewInternal.h:

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added new class, MemoryPressureHandler, to platform to respond to low
system memory events. Added Mac specific implementation that reduces the
page cache, NSURL cache, WebCore cache by half their current usage
and then garbage collects. This can allow Safari to continue operating
in a low memory situation with minimal paging.
Split up prune operations in MemoryCache to allow for pruning to a
specific actual size to support this change.

No tests added as the functionality of WebKit wasn't changed.

  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::forcePruneLiveResources): (WebCore::MemoryCache::pruneLiveResourcesToTarget): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::forcePruneDeadResources): (WebCore::MemoryCache::pruneDeadResourcesToTarget):
  • loader/cache/MemoryCache.h: (WebCore::MemoryCache::forcePrune):
  • platform/MemoryPressureHandler.cpp: Added. (WebCore::memoryPressureHandler): (WebCore::MemoryPressureHandler::MemoryPressureHandler): (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
  • platform/MemoryPressureHandler.h: Added.
  • platform/mac/MemoryPressureHandler.mm: Added. (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):

2011-05-24 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Added call to enable memory pressure handling for Mac case.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/WebProcess.h:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
4:19 PM Changeset in webkit [87227] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
https://bugs.webkit.org/show_bug.cgi?id=61398

shadowAncestorNode() and shadowTreeRootNode() should be const
though they can return 'this' pointer.

No new tests. This doesn't change any visible behavior.

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Make this const. (WebCore::Node::shadowTreeRootNode): ditto.
  • dom/Node.h: Update declarations.
  • html/shadow/TextControlInnerElements.h: (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>. (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.
4:13 PM Changeset in webkit [87226] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Source/JavaScriptCore/wtf/Platform.h

Merge radar 9489360.

4:03 PM Changeset in webkit [87225] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/WebKit2

Merge r87113.

4:01 PM Changeset in webkit [87224] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87093.

3:58 PM Changeset in webkit [87223] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r87083.

3:53 PM Changeset in webkit [87222] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87077.

3:52 PM Changeset in webkit [87221] by beidson@apple.com
  • 9 edits
    8 adds in trunk/Source/WebKit2

Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Darin Adler.

Initialize the KeychainItem shim on SnowLeopard:

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim):

On SnowLeopard, shim the 4 SecKeychainItem methods:

  • WebProcess/mac/WebProcessShim.h:
  • WebProcess/mac/WebProcessShim.mm:

(WebKit::shimSecKeychainItemCopyContent):
(WebKit::shimSecKeychainItemCreateFromContent):
(WebKit::shimSecKeychainItemModifyContent):
(WebKit::shimSecKeychainItemFreeContent):
(WebKit::WebKitWebProcessKeychainItemShimInitialize):

  • WebProcess/mac/KeychainItemShimMethods.h: Added.
  • WebProcess/mac/KeychainItemShimMethods.mm: Added.

Manage a set of shim-controlled AttributeList data:
(WebKit::shimManagedAttributeLists):
(WebKit::freeAttributeListContents):
(WebKit::allocateAttributeListContents):

Manage a set of shim-controlled KeychainItem data:
(WebKit::shimManagedKeychainItemContents):
(WebKit::allocateKeychainItemContentData):

Free any shim-controlled AttributeList or KeychainItem data:
(WebKit::webFreeAttributeListContentOnMainThread):
(WebKit::webFreeAttributeListContent):
(WebKit::webFreeKeychainItemContentOnMainThread):
(WebKit::webFreeKeychainItemContent):

Marshall these 3 KeychainItem methods to the UIProcess:
(WebKit::webSecKeychainItemCopyContentOnMainThread):
(WebKit::webSecKeychainItemCopyContent):
(WebKit::webSecKeychainItemCreateFromContentOnMainThread):
(WebKit::webSecKeychainItemCreateFromContent):
(WebKit::webSecKeychainItemModifyContentOnMainThread):
(WebKit::webSecKeychainItemModifyContent):
(WebKit::initializeKeychainItemShim):

Container for an AttributeList entry that knows how to encode/decode:

  • Shared/mac/KeychainAttribute.cpp: Added.

(WebKit::KeychainAttribute::KeychainAttribute):
(CoreIPC::encode):
(CoreIPC::decode):

  • Shared/mac/KeychainAttribute.h: Added.

Container for the relevant arguments to the shimmed methods, to send to the UIProcess:

  • Shared/mac/SecKeychainItemRequestData.cpp: Added.

(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::initializeWithAttributeList):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):

  • Shared/mac/SecKeychainItemRequestData.h: Added.

(WebKit::SecKeychainItemRequestData::keychainItem):
(WebKit::SecKeychainItemRequestData::itemClass):
(WebKit::SecKeychainItemRequestData::length):
(WebKit::SecKeychainItemRequestData::data):

Container for the possible output from the shimmed methods, to send back to the WebProcess:

  • Shared/mac/SecKeychainItemResponseData.cpp: Added.

(WebKit::SecKeychainItemResponseData::SecKeychainItemResponseData):
(WebKit::SecKeychainItemResponseData::encode):
(WebKit::SecKeychainItemResponseData::decode):

  • Shared/mac/SecKeychainItemResponseData.h: Added.

(WebKit::SecKeychainItemResponseData::itemClass):
(WebKit::SecKeychainItemResponseData::data):
(WebKit::SecKeychainItemResponseData::resultCode):
(WebKit::SecKeychainItemResponseData::attributes):
(WebKit::SecKeychainItemResponseData::keychainItem):

Actually implement the calls to the SecKeychainItem* methods in the UIProcess:

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::secKeychainItemCopyContent):
(WebKit::WebProcessProxy::secKeychainItemCreateFromContent):
(WebKit::WebProcessProxy::secKeychainItemModifyContent):

  • WebKit2.xcodeproj/project.pbxproj: Project file stuff
  • Configurations/Shim.xcconfig:
3:27 PM Changeset in webkit [87220] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87046.

3:23 PM Changeset in webkit [87219] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534-branch

Merge r87026.

3:22 PM Changeset in webkit [87218] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

[chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
fail on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=61377

selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
the failing test expectation on Windows port.

In selectstart-by-double-triple-clicks.html, /\s|\s$/ isn't recognized by V8 so
replace it by /
[ \t]|[ \t]$/.

  • platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from LayoutTests/fast/events/selectstart-by-drag-expected.txt.
  • fast/events/selectstart-by-double-triple-clicks.html:
  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [87217] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-534-branch

Merge r87009.

3:17 PM Changeset in webkit [87216] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87005.

3:12 PM Changeset in webkit [87215] by simonjam@chromium.org
  • 5 edits in trunk

2011-05-24 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528

  • platform/chromium/test_expectations.txt: Remove CRASH from fixed test.

2011-05-24 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

ASSERT_NOT_REACHED reached with broken ideograph and system fallback
https://bugs.webkit.org/show_bug.cgi?id=53528

Test: fast/text/justify-ideograph-vertical.html (on chromium linux)

  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.
3:10 PM Changeset in webkit [87214] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html on Mac WebKit2
since WebKitTestRunner doesn't implement eventSender.mouseScrollBy yet (bug 42194).

  • platform/mac-wk2/Skipped:
3:09 PM Changeset in webkit [87213] by abarth@webkit.org
  • 6 edits in trunk/Source

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Rubberstamped by David Kilzer.

Updated some files that I forgot in my previous MHTML CL.

  • Configurations/FeatureDefines.xcconfig:
3:06 PM Changeset in webkit [87212] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip platform/mac/editing/input/maxlength.html - textInputController is not implemented.

  • platform/mac-wk2/Skipped:
3:04 PM Changeset in webkit [87211] by sfalken@apple.com
  • 10 edits in branches/safari-534-branch

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable features on safari-534-branch.
<rdar://problem/9261347>

This change requires a full rebuild.

2:59 PM Changeset in webkit [87210] by robert@webkit.org
  • 5 edits in trunk

2011-05-24 Robert Hogan <robert@webkit.org>

Reviewed by Ryosuke Niwa.

[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393

  • platform/qt/Skipped: Unskip fast/events/selectstart-by-single-click-with-shift.html

2011-05-24 Robert Hogan <robert@webkit.org>

Reviewed by Ryosuke Niwa.

[Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
https://bugs.webkit.org/show_bug.cgi?id=61393

  • DumpRenderTree/qt/EventSenderQt.h:
  • DumpRenderTree/qt/EventSenderQt.cpp: (getModifiers): static function for interpreting modifiers (EventSender::mouseDown): Respect keyboard modifiers (EventSender::keyDown): use new static function (EventSender::sendOrQueueEvent): whitespace fix
2:56 PM Changeset in webkit [87209] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/selectstart-by-double-triple-clicks.html and selectstart-by-drag.html
on Mac WebKit 2 per the bug 42194.

  • platform/mac-wk2/Skipped:
2:47 PM Changeset in webkit [87208] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

We do not need assert for the useProgram as program can be null.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.
2:36 PM Changeset in webkit [87207] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on GTK
because GTK port doesn't implement eventSender.scalePageBy yet (bug 61396).

  • platform/gtk/Skipped:
2:32 PM Changeset in webkit [87206] by Lucas Forschler
  • 9 edits
    1 copy in branches/safari-534-branch/Source

Merge r86995.

2:29 PM Changeset in webkit [87205] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on Windows
because Windows port doesn't implement eventSender.scalePageBy yet (bug 59098).

  • platform/win/Skipped:
2:22 PM Changeset in webkit [87204] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340

Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.

  • editing/undo/undo-after-setting-value-expected.txt: Added.
  • editing/undo/undo-after-setting-value.html: Added.

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Undo gets broken in contenteditable area when a text field's value is set by script
https://bugs.webkit.org/show_bug.cgi?id=61340

The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
calling clearUndoRedoOperations whenever script sets new value to input or textarea.

Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.

Test: editing/undo/undo-after-setting-value.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
2:12 PM Changeset in webkit [87203] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed. Updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:06 PM Changeset in webkit [87202] by Lucas Forschler
  • 10 edits in branches/safari-534-branch/Source

Merge r86992.

2:01 PM Changeset in webkit [87201] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=61392

Reviewed by Dave Hyatt.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs): Moved code here...
(WebCore::SimpleFontData::platformInit): ...from here.

1:59 PM Changeset in webkit [87200] by Lucas Forschler
  • 6 edits in branches/safari-534-branch

Merge r87022.

1:56 PM Changeset in webkit [87199] by ggaren@apple.com
  • 2 edits
    3 deletes in trunk/Source/JavaScriptCore

Fix the Mac build: Yes, please do remove these files, svn.

1:51 PM Changeset in webkit [87198] by ggaren@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

2011-05-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Let's just have one way to get the system page size, bokay?
https://bugs.webkit.org/show_bug.cgi?id=61384

  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: MarkStack[Platform].cpp is gone completely now, since it only existed to provide a duplicate way to access the system page size.
  • heap/MarkStack.cpp: (JSC::MarkStack::reset):
  • heap/MarkStack.h: (JSC::::MarkStackArray): (JSC::::shrinkAllocation): Use WTF::pageSize.
  • heap/MarkStackPosix.cpp:
  • heap/MarkStackSymbian.cpp:
  • heap/MarkStackWin.cpp: Removed now-empty files.
  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: Use WTF::pageSize.
  • wscript: Removed now-empty files.
  • wtf/PageBlock.cpp: (WTF::systemPageSize): Integrated questionable Symbian page size rule from ExecutableAllocator, because that seems like what the original author should have done.
1:41 PM Changeset in webkit [87197] by kbr@google.com
  • 25 edits
    5 adds in trunk

2011-05-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144

Implemented Float64Array based on the existing Float32Array sources.
Built and tested in Chromium on Linux and Mac OS X and Safari on Mac OS X.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::float64Array):
  • bindings/js/JSFloat64ArrayCustom.cpp: Added. (WebCore::JSFloat64Array::indexSetter): (WebCore::toJS): (WebCore::JSFloat64Array::set): (WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
  • bindings/v8/custom/V8Float64ArrayCustom.cpp: Added. (WebCore::V8Float64Array::constructorCallback): (WebCore::V8Float64Array::setCallback): (WebCore::toV8):
  • html/canvas/ArrayBufferView.h: (WebCore::ArrayBufferView::isDoubleArray):
  • html/canvas/Float64Array.cpp: Added. (WebCore::Float64Array::create): (WebCore::Float64Array::Float64Array): (WebCore::Float64Array::subarray):
  • html/canvas/Float64Array.h: Added. (WebCore::Float64Array::set): (WebCore::Float64Array::item): (WebCore::Float64Array::isDoubleArray):
  • html/canvas/Float64Array.idl: Added.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

2011-05-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Implement Float64Array
https://bugs.webkit.org/show_bug.cgi?id=39144

Added unit tests to existing typed array tests in Khronos repository and
synced layout test with them. Updated other affected layout tests.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
1:23 PM Changeset in webkit [87196] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-05-24 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Add ability to set compositing layer bounds origin
https://bugs.webkit.org/show_bug.cgi?id=61381

On Core Animation layers, the origin of the bounds
rectangle affects where layer content is rendered, as well
as the offset of sublayers. Currently we always set the
bounds offset to a zero point, but may need to make use
of the bounds offset in future, so expose it via GraphicsLayer.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::boundsOrigin): (WebCore::GraphicsLayer::setBoundsOrigin):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setSize): (WebCore::GraphicsLayerCA::setBoundsOrigin): (WebCore::GraphicsLayerCA::setAllowTiledLayer): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateBounds): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
  • platform/graphics/ca/GraphicsLayerCA.h:
1:18 PM Changeset in webkit [87195] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up after Geoff and fix the WebKit2 build.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
1:16 PM Changeset in webkit [87194] by Lucas Forschler
  • 10 edits in branches/safari-534-branch

Rollout 87186. It breaks the branch.

1:07 PM Changeset in webkit [87193] by leandro@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix.

  • CMakeLists.txt: Also build platform/network/ContentTypeParser.cpp, added by r86289.
1:03 PM Changeset in webkit [87192] by leandro@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix.

  • bridge/runtime_root.cpp: Include <heap/Weak.h> instead of <JavaScriptCore/Weak.h>.
12:51 PM Changeset in webkit [87191] by rniwa@webkit.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2011-05-24 Ryosuke Niwa <rniwa@webkit.org>

Skip the tests added by r87096 and remove the failing test expectations on Qt.
The failures are tracked by the bug 61322.

  • platform/qt/Skipped:
  • platform/qt/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
  • platform/qt/fast/events/selectstart-by-drag-expected.txt: Removed.
  • platform/qt/fast/events/selectstart-by-single-click-with-shift-expected.txt: Removed.
12:39 PM Changeset in webkit [87190] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Interpreter crashes with gc validation enabled due to failure to mark initial cache structure
https://bugs.webkit.org/show_bug.cgi?id=61385

The interpreter uses the structure slot of get_by_id and put_by_id to hold
the initial structure it encountered so that it can identify whether a
given access is stable.

When marking though we only visit the slot when we've decided to cache, and
so this value could die. This was "safe" as the value was only used for a
pointer compare, but it was incorrect. We now just mark the slot like we
should have been doing already.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures):
12:32 PM Changeset in webkit [87189] by jcivelli@chromium.org
  • 36 edits
    1 copy
    35 adds in trunk

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • configure.ac:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • mhtml/frame_0.html_original: Added.
  • mhtml/frame_1.html_original: Added.
  • mhtml/frame_2.html_original: Added.
  • mhtml/frame_4.html_original: Added.
  • mhtml/multi_frames.html_original: Added.
  • mhtml/multi_frames_ie.mht: Added.
  • mhtml/multi_frames_unmht.mht: Added.
  • mhtml/page_with_css_and_js.html_original: Added.
  • mhtml/page_with_css_and_js_ie.mht: Added.
  • mhtml/page_with_css_and_js_unmht.mht: Added.
  • mhtml/page_with_image.html_original: Added.
  • mhtml/page_with_image_ie.mht: Added.
  • mhtml/page_with_image_unmht.mht: Added.
  • mhtml/resources/red_square.png: Added.
  • mhtml/simple_page.html_original: Added.
  • mhtml/simple_page_ie.mht: Added.
  • mhtml/simple_page_unmht.mht: Added.
  • platform/chromium/mhtml/multi_frames_ie-expected.txt: Added.
  • platform/chromium/mhtml/multi_frames_unmht-expected.txt: Added.
  • platform/chromium/mhtml/page_with_css_and_js_ie-expected.txt: Added.
  • platform/chromium/mhtml/page_with_css_and_js_unmht-expected.txt: Added.
  • platform/chromium/mhtml/page_with_image_ie-expected.txt: Added.
  • platform/chromium/mhtml/page_with_image_unmht-expected.txt: Added.
  • platform/chromium/mhtml/simple_page_ie-expected.txt: Added.
  • platform/chromium/mhtml/simple_page_unmht-expected.txt: Added.

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support. That required some basic MIME header parsing.
Modified DocumentLoader to keep a reference to the currently Archive loaded,
so we can have different policies for loading subresources depending on the
archive type.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • features.pri:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::popArchiveForSubframe): (WebCore::DocumentLoader::scheduleArchiveLoad):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h: (WebCore::FrameLoader::archive):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/Archive.cpp: Added.
  • loader/archive/Archive.h: (WebCore::Archive::mainResource):
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveFactoryCreate): (WebCore::archiveMIMETypes): (WebCore::ArchiveFactory::create): (WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
  • loader/archive/ArchiveFactory.h:
  • loader/archive/ArchiveResourceCollection.cpp: (WebCore::ArchiveResourceCollection::addAllResources): (WebCore::ArchiveResourceCollection::popSubframeArchive):
  • loader/archive/ArchiveResourceCollection.h:
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): (WebCore::LegacyWebArchive::type):
  • loader/archive/cf/LegacyWebArchive.h:
  • loader/archive/mhtml/MHTMLArchive.cpp: Added.
  • loader/archive/mhtml/MHTMLArchive.h: Added.
  • loader/archive/mhtml/MHTMLParser.cpp: Added.
  • loader/archive/mhtml/MHTMLParser.h: Added.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):
  • platform/network/MIMEHeader.cpp: Added.
  • platform/network/MIMEHeader.h: Added.

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • features.gypi:

2011-05-24 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:24 PM Changeset in webkit [87188] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix some builds: #include Weak.h for Weak<T>.

  • bridge/runtime_root.h:
12:23 PM Changeset in webkit [87187] by weinig@apple.com
  • 3 edits
    2 adds in trunk

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339

Test: fast/events/scroll-in-scaled-page-with-overflow-hidden.html

  • page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): Scrollbars should be enabled for the viewport when scaled, even if overflow:hidden is specified.

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Can't scroll scaled page that has overflow:hidden on its root
<rdar://problem/9029189>
https://bugs.webkit.org/show_bug.cgi?id=61339

  • fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt: Added.
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html: Added.
12:22 PM Changeset in webkit [87186] by sfalken@apple.com
  • 10 edits in branches/safari-534-branch

2011-05-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable features on safari-534-branch.
<rdar://problem/9261347>

12:16 PM Changeset in webkit [87185] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r86985.

12:13 PM Changeset in webkit [87184] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed now-inline functions.
12:07 PM Changeset in webkit [87183] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix: update the #if OS(WINDOWS) section to match my last patch.

  • heap/MarkStack.h:

(JSC::::shrinkAllocation):

12:03 PM Changeset in webkit [87182] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Leopard build fix

  • bridge/runtime_root.cpp: Added a missing #include.
11:57 AM Changeset in webkit [87181] by jianli@chromium.org
  • 6 edits in trunk

Make start parameter of Blob.slice optional.
https://bugs.webkit.org/show_bug.cgi?id=59628

Reviewed by Kenneth Russell.

Source/WebCore:

The start parameter should be optional per the latest FILE API
spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob.

  • fileapi/Blob.h:
  • fileapi/Blob.idl: Make start parameter optional.

LayoutTests:

  • fast/files/blob-slice-test-expected.txt:
  • fast/files/blob-slice-test.html:
11:55 AM Changeset in webkit [87180] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Split out function definitions and class definitions from class
declarations in MarkStack.h, for readability.

Rubber-stamped by Oliver Hunt.

  • heap/MarkStack.h:

(JSC::MarkStack::MarkStack):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::MarkSet::MarkSet):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
(JSC::MarkStack::pageSize):
(JSC::::MarkStackArray):
(JSC::::~MarkStackArray):
(JSC::::expand):
(JSC::::append):
(JSC::::removeLast):
(JSC::::last):
(JSC::::isEmpty):
(JSC::::size):
(JSC::::shrinkAllocation):

11:51 AM Changeset in webkit [87179] by Adam Roben
  • 9 edits
    2 adds in trunk

Invalidate JS wrappers for NPObjects when they are finalized

This will cause the underlying NPObject to be released at finalization time, rather than at
destruction time (which is unpredictable and could occur after the plugin has been
unloaded).

Test: plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html

Fixes <http://webkit.org/b/61316> <rdar://problem/9489824> Crash in deallocateNPObject when
reloading yahoo.com webarchive in WebKit2

and

<http://webkit.org/b/61317> <rdar://problem/9489829> Crash in _NPN_DeallocateObject when
reloading yahoo.com webarchive in WebKit1

Reviewed by Oliver Hunt.

Source/WebCore:

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::~RuntimeObject): Assert that we've already been invalidated.

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
Updated for m_runtimeObjects type change.

(JSC::Bindings::RootObject::finalize): Added. Invalidates the RuntimeObject and removes it
from the map.

  • bridge/runtime_root.h: Now inherits from WeakHandleOwner.

Changed m_runtimeObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will
be notified when the RuntimeObjects are finalized.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::~JSNPObject): Assert that we've already been invalidated, rather than
trying to perform invalidation now (when the plugin might already be unloaded).

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
(WebKit::NPRuntimeObjectMap::invalidate):
Updated for m_jsNPObjects type change.

(WebKit::NPRuntimeObjectMap::finalize): Added. Invalidates the JSNPObject and removes it
from the map.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Now inherits from WeakHandleOwner.

Changed m_jsNPObjects from a WeakGCMap to a HashMap of JSC::Weak objects so that we will be
notified when the JSNPObjects are finalized.

LayoutTests:

Test that we don't crash when a JS wrapper for an NPObject is destroyed after its plugin is unloaded

  • plugins/npobject-js-wrapper-destroyed-after-plugin-unload-expected.txt: Added.
  • plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html: Added.

(startTest): Gets a JS wrapper for an NPObject from the plugin, allocate a bunch of memory
so the JS wrapper will be finalized, then destroy the plugin and wait for a little bit
before calling finishTest.
(finishTest): Force a GC so the JS wrapper will be destroyed. If we didn't crash, we passed!

11:50 AM Changeset in webkit [87178] by senorblanco@chromium.org
  • 26 edits in trunk

2011-05-24 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Remove most style checks on Source/ThirdParty/glu, since it doesn't
follow WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=61365

  • Scripts/webkitpy/style/checker.py:

2011-05-24 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Unfork glu sources as much as possible.
https://bugs.webkit.org/show_bug.cgi?id=61365

Restore the glu sources closer to the original version on oss.sgi.com
by removing the WebKit-specific include paths, restoring the include
order, and renaming the glu* functions via #defines rather than in
the source.

  • glu/README.webkit: Update the README to reflect the changes from trunk.
  • glu/glu.gyp: Add Source/Thirdparty/glu as an include path, so we can remove the hardcoded paths from the source files.
  • glu/gluos.h: Add #defines to rename the glu entry points to internal_*.
  • glu/internal_glu.h:
  • glu/libtess/dict.c:
  • glu/libtess/geom.c:
  • glu/libtess/geom.h:
  • glu/libtess/memalloc.c:
  • glu/libtess/mesh.c:
  • glu/libtess/mesh.h:
  • glu/libtess/normal.c:
  • glu/libtess/normal.h:
  • glu/libtess/priorityq-heap.c:
  • glu/libtess/priorityq-sort.h:
  • glu/libtess/priorityq.c:
  • glu/libtess/priorityq.h:
  • glu/libtess/render.c:
  • glu/libtess/render.h:
  • glu/libtess/sweep.c:
  • glu/libtess/sweep.h:
  • glu/libtess/tess.c:
  • glu/libtess/tess.h:
  • glu/libtess/tessmono.c: Remove WebKit-specific include paths, and internal_ prefixes from glu entry points. Restore include order to original source order.
11:49 AM Changeset in webkit [87177] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-24 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Avoid creating unnecessary identifiers and strings in the syntax checker
https://bugs.webkit.org/show_bug.cgi?id=61378

Selectively tell the lexer that there are some places it does not need to
do the real work of creating Identifiers for IDENT and STRING tokens.

Make parseString and parseIdentifier templatized on whether they should
do real work, or merely validate the tokens.

SunSpider --parse-only reports ~5-8% win depending on hardware.

  • parser/ASTBuilder.h: (JSC::ASTBuilder::createDotAccess):
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression):
  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h:
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createProperty):
11:46 AM Changeset in webkit [87176] by Adam Roben
  • 2 edits in trunk/Tools

Don't allow forcing builds through the build.webkit.org web interface

Someone has been forcing bogus builds.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:39 AM Changeset in webkit [87175] by qi.2.zhang@nokia.com
  • 4 edits in trunk

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Adam Roben.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Fixes a typo issue for patch 94265.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetJavaScriptCanAccessClipboard):

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Adam Roben.

WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=42669

Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
Because that case changed the setting.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
11:32 AM WebKit Team edited by helder@sencha.com
(diff)
11:24 AM Changeset in webkit [87174] by commit-queue@webkit.org
  • 3 edits in trunk

2011-05-24 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

skia: fix stroking of zero-height rectangles
https://bugs.webkit.org/show_bug.cgi?id=61284

Tests: canvas/philip/tests/2d.line.miter.lineedge.html

canvas/philip/tests/2d.strokeRect.zero.4.html

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::strokeRect):
11:16 AM Changeset in webkit [87173] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

2011-05-24 Zan Dobersek <zandobersek@gmail.com> and Philippe Normand <pnormand@igalia.com>

Reviewed by Kenneth Russell.

Enable FloatArray usage outside WebGL guards
https://bugs.webkit.org/show_bug.cgi?id=61356

  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
11:12 AM Changeset in webkit [87172] by adamk@chromium.org
  • 3 edits
    3 deletes in trunk

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

  • inspector/console/console-eval-syntax-error-expected.txt: Removed.
  • inspector/console/console-eval-syntax-error.html: Removed.
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback):
11:04 AM Changeset in webkit [87171] by mdelaney@apple.com
  • 5 edits
    2 adds in trunk

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135

  • fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt: Added.
  • fast/canvas/canvas-getImageData-largeNonintegralDimensions.html: Added.

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135

Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData):
  • platform/graphics/cg/ImageBufferDataCG.cpp: (WebCore::ImageBufferData::getData):
10:53 AM Changeset in webkit [87170] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-24 Sam Weinig <sam@webkit.org>

Reviewed by John Sullivan.

WebKit tells client that the page has become unresponsive while the beforeUnloadConfirm dialog is up
https://bugs.webkit.org/show_bug.cgi?id=61372

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Stop the unresponsiveness timer like we do for other client functions that spin a runloop.
10:45 AM Changeset in webkit [87169] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Kevin Ollivier.

[wx] Make sure x and y adjustments are applied to all operations, and fix the calculations for the height and width checks to take into account x and y offsets.

https://bugs.webkit.org/show_bug.cgi?id=61367

10:43 AM Changeset in webkit [87168] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132

  • fast/forms/slider-hit-testing-expected.txt: Added.
  • fast/forms/slider-hit-testing.html: Added.

2011-05-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

fix render overflow computation for input type=range
https://bugs.webkit.org/show_bug.cgi?id=61132

Test: fast/forms/slider-hit-testing.html

We need to clear m_overflow otherwise we use the first
size of the slider for hit testing (i.e., changes to the size
cause problems). This only shows up if the thumb isn't contained
in the bounds of the slider. Making the range have a smaller height
than the thumb shows the bug.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Clear the overflow during layout

so we re-compute the overflow based on the current size of the
slider.

10:41 AM Changeset in webkit [87167] by alokp@chromium.org
  • 9 edits in trunk/Source

2011-05-24 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::reallocateRenderer):

2011-05-24 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

This patch adds gpu accelerated rendering for content and root layers.
Layer textures are updated in two stages:

  1. Paint: The non-accelerated path paints the layer contents into a bitmap.

The accelerated path paints into an SkPicture, which is essentially a display list.

  1. Upload: The non-accelerated path uploads the pixels obtained in the first stage to a texture.

The accelerated path renders the picture directly into the texture.

The accelerated path can be enabled by --enable-accelerated-drawing command-line flag in chromium.
Note that this patch does not accelerate the CG path on mac. We have two options here - use skia or accelrate CG path.
Any bugs should be caught by layout tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::createTextureUpdater):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::skiaContext): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::createRootLayerTextureUpdater):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::acceleratedDrawing):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture): (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate): (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::clearFrameBuffer):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h: (WebCore::LayerTextureUpdaterSkPicture::orientation):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
10:36 AM Changeset in webkit [87166] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: display keyboard shortcuts in scripts panel sidebar buttons tooltip text.
https://bugs.webkit.org/show_bug.cgi?id=61358

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.registerShortcut):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._createSidebarButtons): (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
10:15 AM Changeset in webkit [87165] by kbr@google.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

2011-05-24 Kenneth Russell <kbr@google.com>

Unreviewed. Fixed incorrect test expectations I previously checked in.

  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-actual.png: Removed.
  • platform/chromium-gpu-mac/compositing/animation/busy-indicator-expected.png: Added.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-actual.png: Removed.
  • platform/chromium-gpu-win/compositing/animation/busy-indicator-expected.png: Added.
10:14 AM Changeset in webkit [87164] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed. Updated Chromium test expectations.

  • platform/chromium/test_expectations.txt: svg failure on Linux, BUGWK61370.
10:12 AM Changeset in webkit [87163] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Andres Kling.

JSAudioContextCustom doesn't encode errors
https://bugs.webkit.org/show_bug.cgi?id=61357

Fix AudioContext return values

  • bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext):
10:07 AM Changeset in webkit [87162] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-05-24 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Kenneth Rohde Christiansen.

[ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
https://bugs.webkit.org/show_bug.cgi?id=61052

  • Scripts/old-run-webkit-tests:
9:43 AM Changeset in webkit [87161] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-24 Rob Buis <rbuis@rim.com>

Rubber-stamped by Dirk Schulze.

Remove requiresLayer inlines, already provided by RenderSVGModelObject.

  • rendering/svg/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
  • rendering/svg/RenderSVGImage.h:
9:30 AM Changeset in webkit [87160] by andreas.kling@nokia.com
  • 12 edits
    2 deletes in trunk/Source/WebKit2

2011-05-24 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[WK2] Change TiledDrawingArea to use ShareableBitmap instead of UpdateChunk.
https://bugs.webkit.org/show_bug.cgi?id=61296

Pass UpdateInfo containing ShareableBitmaps instead of UpdateChunk for tile updates.
Only the bounds rect and bitmap handle in the UpdateInfo are used since none of the
other parameters are needed for TiledDrawingArea.

  • Shared/ShareableBitmap.h:
  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createQImage): (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/qt/UpdateChunk.cpp: Removed.
  • Shared/qt/UpdateChunk.h: Removed.
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate):
  • WebKit2.pro:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: (WebKit::TiledDrawingArea::paintIntoBitmap):
9:25 AM Changeset in webkit [87159] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed.

Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61169

  • platform/chromium/test_expectations.txt: Marked optimize-contrast tests as IMAGE failure, BUGWK61169.
9:11 AM Changeset in webkit [87158] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, build fix.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

Forgot to rename the destructor.

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::AdditionalFontData::~AdditionalFontData):
9:06 AM Changeset in webkit [87157] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-23 Michael Saboff <msaboff@apple.com>

Reviewed by Mark Rowe.

Safari often freezes when clicking "Return free memory" in Caches dialog
https://bugs.webkit.org/show_bug.cgi?id=61325

There are two fixes and improvement in instrumentation code used to find
one of the problems.
Changed ReleaseFreeList() to set the "decommitted" bit when releasing
pages to the system and moving Spans from the normal list to the returned
list.
Added a "not making forward progress" check to TCMalloc_PageHeap::scavenge
to eliminate an infinite loop if we can't meet the pagesToRelease target.
Added a check for the decommitted bit being set properly in
TCMalloc_PageHeap::CheckList.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavenge): (WTF::TCMalloc_PageHeap::Check): (WTF::TCMalloc_PageHeap::CheckList): (WTF::ReleaseFreeList):
8:49 AM Changeset in webkit [87156] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, build fix.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

Rename SimpleFontData::FontData subclass to AdditionalFontData, to avoid clashes with the WebCore::FontData class, which breaks the win build.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::fontData):
  • svg/SVGFontData.h:
8:44 AM Changeset in webkit [87155] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281

Remove the test case from skip list.

  • platform/qt/Skipped:
8:39 AM Changeset in webkit [87154] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix after r87153

  • WebProcess/mac/SecItemShimMethods.mm: Don't compile this code on SnowLeopard.
8:31 AM Changeset in webkit [87153] by beidson@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Sam Weinig.

In preparation for different WebProcess shims depending on platform, move the current
shim to its own files.

  • WebKit2.xcodeproj/project.pbxproj:


  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim): For non-SnowLeopard platforms, call initializeSecItemShim().

  • WebProcess/mac/SecItemShimMethods.h: Added.
  • WebProcess/mac/SecItemShimMethods.mm: Added. Actual webSecItem* methods moved from WebProcessMac.mm.

(WebKit::webSecItemCopyMatchingMainThread):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAddOnMainThread):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdateOnMainThread):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDeleteOnMainThread):
(WebKit::webSecItemDelete):
(WebKit::initializeSecItemShim): Initialize the callbacks via WebKitWebProcessSecItemShimInitialize

  • WebProcess/mac/WebProcessShim.h:
  • WebProcess/mac/WebProcessShim.mm: Wrap all the actual code here in a !BUILDING_ON_SNOW_LEOPARD block

(WebKit::shimSecItemCopyMatching):
(WebKit::shimSecItemAdd):
(WebKit::shimSecItemUpdate):
(WebKit::shimSecItemDelete):
(WebKit::WebKitWebProcessSecItemShimInitialize):

8:27 AM Changeset in webkit [87152] by Nikolas Zimmermann
  • 38 edits
    1 move
    1 add in trunk/Source/WebCore

2011-05-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Antti Koivisto.

Remove platform layering violation: TextRun stores RenderObjects for SVG Fonts support
https://bugs.webkit.org/show_bug.cgi?id=60254

First part:
Remove a long-standing layering violation in TextRun: it stores RenderObject/RenderSVGResource pointers for SVG Fonts support.
Replace the two Render* pointers with a single RefPtr<AbstractRenderingContext>. AbstractRenderingContext is a helper class,
that can be derived from in order to associate additional data with a TextRun. This effectively reduces the memory consumption of TextRun.

Introduce rendering/TextRunRenderingContext.h, which inherits from TextRun::AbstractRenderingContext and holds additional data.
If the primary font in use is a SVG Font then allocate a TextRunRenderingContext object and store it in the RefPtr<AbstractRenderingContext>
in TextRun. If the primary font is not a SVG Font, don't even allocate the TextRunRenderingContext structure, as we won't need the context data.
SVG Fonts glyph matching only works within a context, so we need access to the RenderObject that's drawing the text.

This is the main preparation patch for the SVG Fonts rewrite, that will allow us to share the simple text code path for SVG Fonts as well,
making all CSS text properties work for HTML text using SVG Fonts, and allows proper integration within the GlyphPage concept. Soon
we can intermix WOFF/SVG & native fonts, within segment font declarations.

Second part:
Remove a long-standing layering violation in SimpleFontData: it stores SVGFontData objects, that are living in svg/.
Use the same concept as above, introduce SimpleFontData::AbstractFontData, and let SVGFontData inherit from AbstractFontData and extent it.
If SVG Fonts are used, CSSFontFaceSource will create a SVGFontData object and pass it as PassOwnPtr<AbstractFontData> to SimpleFontData.

All layering violations are gone now, SVG Fonts are cleanly integrated now.
Doesn't affect any tests yet, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • platform/graphics/Font.cpp: (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
  • platform/graphics/Font.h:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::~SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::FontData::~FontData): (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::setMaxCharWidth): (WebCore::SimpleFontData::setAvgCharWidth): (WebCore::SimpleFontData::setSpaceWidth): (WebCore::SimpleFontData::setSpaceGlyph): (WebCore::SimpleFontData::setZeroWidthSpaceGlyph): (WebCore::SimpleFontData::fontData): (WebCore::SimpleFontData::isSVGFont): (WebCore::SimpleFontData::setMissingGlyphData):
  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setAllowTabs): (WebCore::TextRun::setXPos): (WebCore::TextRun::RenderingContext::~RenderingContext): (WebCore::TextRun::renderingContext): (WebCore::TextRun::setRenderingContext):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): (WebCore::InlineTextBox::constructTextRun):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): (WebCore::RenderBlock::constructTextRun):
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::setLogicalWidthForTextRun): (WebCore::textWidth): (WebCore::tryHyphenating): (WebCore::RenderBlock::LineBreaker::nextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::paintText):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  • rendering/svg/SVGTextMetrics.cpp: (WebCore::constructTextRun): (WebCore::SVGTextMetrics::measureCharacterRange):
  • rendering/svg/SVGTextRunRenderingContext.cpp: Copied from svg/SVGFont.cpp. (WebCore::svgFontAndFontFaceElementForFontData): (WebCore::firstParentRendererForNonTextNode): (WebCore::referencingRenderObjectFromRun): (WebCore::activePaintingResourceFromRun): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthMissingGlyphCallback): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::selectionRectForTextUsingSVGFont): (WebCore::SVGTextRunRenderingContext::offsetForPositionForTextUsingSVGFont):
  • rendering/svg/SVGTextRunRenderingContext.h: Added. (WebCore::SVGTextRunRenderingContext::create): (WebCore::SVGTextRunRenderingContext::context): (WebCore::SVGTextRunRenderingContext::activePaintingResource): (WebCore::SVGTextRunRenderingContext::setActivePaintingResource): (WebCore::SVGTextRunRenderingContext::SVGTextRunRenderingContext): (WebCore::textRunNeedsRenderingContext):
  • svg/SVGAllInOne.cpp:
  • svg/SVGFont.cpp: Removed.
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
  • svg/SVGFontData.h: (WebCore::SVGFontData::create): (WebCore::SVGFontData::isSVGFontData):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::SVGHKernElement): (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::SVGVKernElement): (WebCore::SVGVKernElement::buildVerticalKerningPair):
  • svg/SVGVKernElement.h:
8:13 AM Changeset in webkit [87151] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[GTK] Implement GraphicsContextCairo::imageInterpolationQuality().
https://bugs.webkit.org/show_bug.cgi?id=60827

Implement getter/setter of imageInterpolationQuality and logic to change
interpolation algorithm when drawing image.
Mac and Qt already implemented it.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::drawSurfaceToContext):
  • platform/graphics/cairo/PlatformContextCairo.h: (WebCore::PlatformContextCairo::setImageInterpolationQuality): Added. (WebCore::PlatformContextCairo::imageInterpolationQuality): Added.
8:11 AM Changeset in webkit [87150] by commit-queue@webkit.org
  • 24 edits
    4 copies
    2 adds in trunk/Source/WebCore

2011-05-24 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: adding Stream and GeneratedStream classes.
https://bugs.webkit.org/show_bug.cgi?id=56666

Add the code for the Stream and GeneratedStream classes and integrate it
with the existing stream generation requests.

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/DOMAllInOne.cpp:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toStream): (WebCore::EventTarget::toGeneratedStream):
  • dom/EventTarget.h:
  • dom/GeneratedStream.cpp: Added. (WebCore::GeneratedStream::DispatchUpdateTask::create): (WebCore::GeneratedStream::DispatchUpdateTask::performTask): (WebCore::GeneratedStream::DispatchUpdateTask::DispatchUpdateTask): (WebCore::GeneratedStream::create): (WebCore::GeneratedStream::GeneratedStream): (WebCore::GeneratedStream::~GeneratedStream): (WebCore::GeneratedStream::toGeneratedStream): (WebCore::GeneratedStream::detachEmbedder): (WebCore::GeneratedStream::stop): (WebCore::GeneratedStream::onStop):
  • dom/GeneratedStream.h: Added.
  • dom/GeneratedStream.idl: Added.
  • dom/Stream.cpp: Added. (WebCore::Stream::create): (WebCore::Stream::Stream): (WebCore::Stream::~Stream): (WebCore::Stream::toStream): (WebCore::Stream::streamEnded): (WebCore::Stream::scriptExecutionContext): (WebCore::Stream::eventTargetData): (WebCore::Stream::ensureEventTargetData):
  • dom/Stream.h: Added. (WebCore::Stream::readyState): (WebCore::Stream::label): (WebCore::Stream::refEventTarget): (WebCore::Stream::derefEventTarget):
  • dom/Stream.idl: Added.
  • page/CallbackTask.h: (WebCore::CallbackTask1::Scheduler::~Scheduler):
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::stopGeneratedStream): (WebCore::MediaStreamController::streamFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::GenerateStreamRequest::create): (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest): (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::getStreamFromLabel): (WebCore::MediaStreamFrameController::generateStream): (WebCore::MediaStreamFrameController::stopGeneratedStream): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::streamGenerationFailed): (WebCore::MediaStreamFrameController::streamFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::StreamClient::StreamClient): (WebCore::MediaStreamFrameController::StreamClient::isGeneratedStream):
  • page/NavigatorUserMediaError.h: (WebCore::NavigatorUserMediaError::create): (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
  • page/NavigatorUserMediaSuccessCallback.h:
  • page/NavigatorUserMediaSuccessCallback.idl:
8:10 AM Changeset in webkit [87149] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Part 2 of 2: <http://webkit.org/b/60805> Enable -Wnewline-eof on ANGLE

Reviewed by Adam Roben.

  • Configurations/Base.xcconfig:

(GCC_WARN_ABOUT_MISSING_NEWLINE): Added. Set to YES.

8:09 AM Changeset in webkit [87148] by Adam Roben
  • 4 edits in trunk/Tools

Make TestFailures show how many tests are failing on each tester, and omit testers with no failures

Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
that don't have any failing tests, which isn't useful

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:

(Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
instead of name strings.
(Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
builder names into an array of builders.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
the most recently completed build, or -1 if there is no such build.
(Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
in the given build, or -1 if the number could not be determined. Some of this code came from
_getFailingTests.
(Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
(Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
getNumberOfFailingTests functions.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayTesters): Get the current number of test failures for each
tester and show it in the list. Omit testers that have no failures at all. We keep the
testers and failure counts in an array and sort it before displaying the current data, as
the order in which data will be fetched is unpredictable.

7:48 AM Changeset in webkit [87147] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

REGRESSION (r45620): Node list caches never deleted
https://bugs.webkit.org/show_bug.cgi?id=61268
<rdar://problem/9467379>

Reviewed by Oliver Hunt.

NodeListsNodeData::isEmpty() tests if RefCounted objects have refcount of zero which is impossible.
As a results NodeList caches are never deleted, causing bad performance in DOM mutating operations as
they repeatedly invalidate caches.

  • dom/Node.cpp:

(WebCore::Node::childNodes):

Construct m_childNodeListCaches lazily.

(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::notifyLocalNodeListsAttributeChanged):
(WebCore::Node::notifyLocalNodeListsChildrenChanged):
(WebCore::Node::removeNodeListCacheIfPossible):

Add a helper.

(WebCore::NodeListsNodeData::invalidateCaches):

Invalidate m_childNodeListCaches by clearing it if there are no additional clients

(WebCore::NodeListsNodeData::isEmpty):

Test emptiness of various NodeListCaches simply by testing hash emptiness instead of testing for non-zero ref count of items.
m_childNodeListCaches is empty if it is null.

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListsNodeData):

Construct m_childNodeListCaches lazily.

7:17 AM Changeset in webkit [87146] by mnaganov@chromium.org
  • 4 edits in trunk/Source

2011-05-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300

  • inspector/CodeGeneratorInspector.pm:

2011-05-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
https://bugs.webkit.org/show_bug.cgi?id=61300

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
7:15 AM BuildingGtk edited by steveg20101@hotmail.com
reading is very helpful in our learning (diff)
7:10 AM QtWebKitBuildBots edited by Csaba Osztrogonác
(diff)
6:11 AM QtWebKitBuildBots edited by Laszlo Gombos
(diff)
5:38 AM Changeset in webkit [87145] by yurys@chromium.org
  • 3 edits
    3 adds in trunk

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

  • inspector/console/console-eval-syntax-error-expected.txt: Added.
  • inspector/console/console-eval-syntax-error.html: Added.
  • platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

2011-05-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
https://bugs.webkit.org/show_bug.cgi?id=61194

Test: inspector/console/console-eval-syntax-error.html

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error
5:16 AM QtWebKitBuildBots edited by Laszlo Gombos
(diff)
4:22 AM Changeset in webkit [87144] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failing new test introduced in r87096

  • platform/qt-arm/Skipped:
4:14 AM QtWebKitBuildBots edited by abecsi@webkit.org
(diff)
3:55 AM QtWebKit edited by Csaba Osztrogonác
Add link to QtWebKit buildbots (diff)
3:54 AM Changeset in webkit [87143] by steveblock@google.com
  • 17 edits
    2 adds
    8 deletes in trunk/Source/WebCore

2011-04-13 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Geolocation callbacks should make use of new callback generation mechanism
https://bugs.webkit.org/show_bug.cgi?id=40065

No new tests, refactoring only.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomPositionCallback.cpp: Removed.
  • bindings/js/JSCustomPositionCallback.h: Removed.
  • bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomPositionErrorCallback.h: Removed.
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomPositionCallback.h: Removed.
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomPositionErrorCallback.h: Removed.
  • bindings/v8/custom/V8GeolocationCustom.cpp: (WebCore::V8Geolocation::getCurrentPositionCallback): (WebCore::V8Geolocation::watchPositionCallback):
  • page/PositionCallback.h:
  • page/PositionCallback.idl: Added.
  • page/PositionErrorCallback.h:
  • page/PositionErrorCallback.idl: Added.
3:46 AM QtWebKitBuildBots created by Csaba Osztrogonác
Add the list of QtWebKit buildbots
3:04 AM Changeset in webkit [87142] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-24 Leon Scroggins <scroggo@google.com>

Reviewed by James Robinson.

Update expectations for shadow tests which are now passing.
https://bugs.webkit.org/show_bug.cgi?id=61278

Also remove some expectations for missing tests.

  • platform/chromium/test_expectations.txt:
2:27 AM Changeset in webkit [87141] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip one more failing test.

  • platform/qt-mac/Skipped:
2:24 AM Changeset in webkit [87140] by podivilov@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-05-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: watched expressions buttons do not match inspector styles.
https://bugs.webkit.org/show_bug.cgi?id=30554

  • WebCore.gypi:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane):
  • inspector/front-end/Images/deleteIcon.png: Added.
  • inspector/front-end/Images/paneRefreshButtons.png: Added.
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype.reset): (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.update.appendResult): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.saveExpressions): (WebInspector.WatchExpressionsSection.prototype._mouseMove): (WebInspector.WatchExpressionsSection.prototype._mouseOut): (WebInspector.WatchExpressionsSection.prototype._updateHoveredElement): (WebInspector.WatchExpressionsSection.CompareProperties): (WebInspector.WatchExpressionTreeElement.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.properties-tree.watch-expressions): (.properties-tree.watch-expressions li): (.section .properties .delete-button): (.section .properties li.hovered .delete-button): (.pane > .title > .pane-title-button): (.pane > .title > .pane-title-button:hover): (.pane > .title > .pane-title-button:active): (.pane > .title > .pane-title-button.add): (.pane > .title > .pane-title-button.refresh):
2:15 AM Changeset in webkit [87139] by yutak@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-24 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Add fail() to WebSocketChannel and its family
https://bugs.webkit.org/show_bug.cgi?id=61277

This is the first part of refactoring effort described in bug 61115.
Existing error reports will be modified to use fail() in a later patch.

No change in behavior, thus no new tests.

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail):
  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::fail): (WebCore::WorkerThreadableWebSocketChannel::Peer::fail): (WebCore::WorkerThreadableWebSocketChannel::mainThreadFail): (WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
  • websockets/WorkerThreadableWebSocketChannel.h:
2:05 AM Changeset in webkit [87138] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] REGRESSION (r87063): Fix the build.
https://bugs.webkit.org/show_bug.cgi?id=61290

No new tests needed.

2:02 AM Changeset in webkit [87137] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-24 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.
https://bugs.webkit.org/show_bug.cgi?id=61252
http://code.google.com/p/chromium/issues/detail?id=83539

Manual test: manual-tests/autofill-popup-location.html.

  • manual-tests/autofill-popup-location.html: With long long text, test the shown location is correct.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setBaseWidth): Clip width with m_maxWindowWidth. (WebCore::PopupListBox::PopupListBox): Add m_maxWindowWidth initialization. (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Call setMaxWidthAndLayout() when the width is clipped with screen size. (WebCore::PopupListBox::setMaxWidthAndLayout): Set m_maxWindowWidth and call layout(). (WebCore::PopupListBox::layout): Compare renewed windowWidth and m_maxWindowWidth, and clip the it.
1:42 AM Changeset in webkit [87136] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-24 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077

Update expectation to reflect that the canvas layer isn't composited.

  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt:

2011-05-24 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Properly handle huge initial dimensions for 2d canvas when accelerated 2d canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=60077

Return NULL from DrawingBuffer::create() if the initial dimensions are larger than we can support in hardware so
that we properly use the software canvas path and not enable the compositor for the canvas.

compositing/tiling/huge-layer-img.html triggers this case by trying to create a 20000 pixel high canvas. The
failure was previously masked by other bugs fixed by r85661.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):

Return NULL from DrawingBuffer::create() if resize() fails.

1:10 AM Changeset in webkit [87135] by ukai@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-24 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301

  • http/tests/websocket/tests/close-before-open-expected.txt: Added.
  • http/tests/websocket/tests/close-before-open.html: Added.

2011-05-24 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

close before open WebSocket doesn't fire close event.
https://bugs.webkit.org/show_bug.cgi?id=57301

In platformClose(), m_readStream may be 0 until proxy is resolved.
It should callback didClose() in such case.

Test: http/tests/websocket/tests/close-before-open.html

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
12:42 AM Changeset in webkit [87134] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Paint the bot green for ultimate satisfaction of Ossy.

  • platform/qt-wk2/Skipped:
12:22 AM Changeset in webkit [87133] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
12:16 AM Changeset in webkit [87132] by commit-queue@webkit.org
  • 3 edits
    2 adds
    18 deletes in trunk/LayoutTests

2011-05-24 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/deleting/5026848-2 and editing/deleting/5026848-3 should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61323

Convert editing/deleting/5026848-2 and editing/deleting/5026848-3 to dump-as-markup.

  • editing/deleting/5026848-2-expected.txt: Added.
  • editing/deleting/5026848-2.html: Convert to dump-as-markup.
  • editing/deleting/5026848-3-expected.txt: Added.
  • editing/deleting/5026848-3.html: Convert to dump-as-markup.
  • platform/chromium-linux/editing/deleting/5026848-2-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5026848-3-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/5026848-3-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5026848-2-expected.png: Removed.
  • platform/mac-leopard/editing/deleting/5026848-3-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-2-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/mac/editing/deleting/5026848-3-expected.png: Removed.
  • platform/mac/editing/deleting/5026848-3-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-2-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5026848-3-expected.png: Removed.
  • platform/qt/editing/deleting/5026848-3-expected.txt: Removed.
12:04 AM Changeset in webkit [87131] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-23 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip failing test because of missing anti-aliased fonts on ARM

  • platform/qt-arm/Skipped:
Note: See TracTimeline for information about the timeline view.