Timeline


and

05/30/11:

23:28 Changeset [87713] by koz@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-30 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt: Added.

2011-05-30 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

Also, detect syntax errors before security errors; some syntax errors
will also trigger a security error, but it's more helpful to the
programmer to know if they have a syntax error, which are well-defined
in the spec, rather than a security error, which aren't.

  • page/Navigator.cpp: (WebCore::Navigator::registerProtocolHandler): Detect syntax errors before security errors.
  • platform/KURLGoogle.cpp: (WebCore::isSchemeChar): Include '+' in the list of valid characters.
22:22 Changeset [87712] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

22:21 Changeset [87711] by mrowe@apple.com
  • 1 copy in tags/Safari-534.42

New tag.

22:12 Changeset [87710] by mrowe@apple.com
  • 9 edits in branches/safari-534-branch/Source/WebCore

Merge r87692.

22:00 Changeset [87709] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721

  • editing/pasteboard/copy-standalone-image-crash-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image-crash.html: Added.

2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721

For platform code, do not assert nodes always have renderer at
the time context menu action is invoked.
Renderer can actually be empty for a given node if it was hidden
or removed from domtree by some non-user generated event (e.g timeout)
after the popup menu had been created.

Changing Chromium, Gtk, Mac, Qt, Win and WinCE.

Test: editing/pasteboard/copy-standalone-image-crash.html

  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage):
21:03 Changeset [87708] by dbates@webkit.org
  • 10 edits
    3 moves in trunk

2011-05-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • XSSAuditor: Copied from PerformanceTests/XSSFilter.
  • XSSFilter: Removed.
  • XSSFilter/large-post-many-events.html: Removed.
  • XSSFilter/large-post-many-inline-scripts-and-events.html: Removed.
  • XSSFilter/resources: Removed.
  • XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Removed.

2011-05-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::init): (WebCore::XSSAuditor::filterToken): (WebCore::XSSAuditor::filterTokenInitial): (WebCore::XSSAuditor::filterTokenAfterScriptStartTag): (WebCore::XSSAuditor::filterScriptToken): (WebCore::XSSAuditor::filterObjectToken): (WebCore::XSSAuditor::filterParamToken): (WebCore::XSSAuditor::filterEmbedToken): (WebCore::XSSAuditor::filterAppletToken): (WebCore::XSSAuditor::filterIframeToken): (WebCore::XSSAuditor::filterMetaToken): (WebCore::XSSAuditor::filterBaseToken): (WebCore::XSSAuditor::filterFormToken): (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): (WebCore::XSSAuditor::eraseAttributeIfInjected): (WebCore::XSSAuditor::snippetForRange): (WebCore::XSSAuditor::snippetForAttribute): (WebCore::XSSAuditor::isContainedInRequest): (WebCore::XSSAuditor::isSameOriginResource):
  • html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
  • html/parser/XSSFilter.cpp: Removed.
  • html/parser/XSSFilter.h: Removed.
19:21 Changeset [87707] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Expose a public clearAll() function to reset WebCore::Animation.

No new functionality, so no new tests.

  • platform/animation/Animation.h: (WebCore::Animation::clearAll):

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Create an ArgumentCoder for WebCore::Animation.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
19:18 Changeset [87706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kent Tamura.

[efl] Fix _ewk_frame_children_iterator_next().
https://bugs.webkit.org/show_bug.cgi?id=61749

The iterator was returning always the first child, making tests like
fast/history/history-back-initial-vs-final-url.html to timeout and
eventually run out of memory.

  • ewk/ewk_frame.cpp: (_ewk_frame_children_iterator_next): (ewk_frame_children_iterator_new):
19:04 Changeset [87705] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-30 Kent Tamura <tkent@chromium.org>

[Mac] Skip a flaky test: svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/mac/Skipped:
18:44 Changeset [87704] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Audio and video files saved to the Application Cache should preserve the original file extension
https://bugs.webkit.org/show_bug.cgi?id=61750
<rdar://9524922>

No new tests, it isn't possible to check the name of the file in the cache from within
DRT. Changes verified manually.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache

file name.

(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.

  • loader/appcache/ApplicationCacheStorage.h:
17:05 Changeset [87703] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Play/Pause button in wrong state when entering full screen on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61754

Update the play/pause button inside reset(). This ensures the button is in
the correct state when the controls are created after playback has already
started.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
16:49 Changeset [87702] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-30 Hojong Han <hojong.han@samsung.com>

Reviewed by Geoffrey Garen.

[JSC] malfunction during arithmetic condition check with negative number (-2147483648)
https://bugs.webkit.org/show_bug.cgi?id=61416

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
  • tests/mozilla/ecma/Expressions/11.12-1.js: (getTestCases):
16:43 Changeset [87701] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Added a public TimingFunction::type() method.

No new functionality, so no new tests.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::type):

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for WebCore::TimingFunction. This serializer can create the appropriate
TimingFunction subclass based on the type of timing function.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
15:29 Changeset [87700] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

BUILD FIX for r87697 on Windows/Symbian

For now enabling TextureMapper for Mac/Linux only.

  • WebCore.pri:
15:02 Changeset [87699] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add WebCore::Length and WebCore::TransformationMatrix to the types that use SimpleArgumentCoder.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
15:00 Changeset [87698] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior): Mark
shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).

13:57 Changeset [87697] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Make CONFIG+=texmap an opt-out instead of an opt-in.

No new functionality so no new tests.

  • WebCore.pri:
13:08 Changeset [87696] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=61693

  • platform/gtk/Skipped: Unskip the test which is no longer crashing.

2011-05-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=61693

Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
may now be null.

No new tests. This change should cause fast/css/font-face-zero-hash-key.html
to stop crashing.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing m_scaledFont.
12:23 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
12:02 Changeset [87695] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
https://bugs.webkit.org/show_bug.cgi?id=61711

The loadFinished() signal was emitted directly inside the call for setHtml, so
the test was waiting the loadFinished() signal with a big timeout. Change this by
a very small timeout and a verification with signal spy.

In practice, setHtml() will either directly call loadFinished() or queue it to
the next event loop run, and test will work for both situations.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::scrollbarsOff):
11:28 Changeset [87694] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media until they're working.
https://bugs.webkit.org/show_bug.cgi?id=61687

Until this works properly, we should indicate that our media implementation
in texture mapper doesn't support accelerated compositing.

This makes LayoutTests/compositing/video/* work again.

  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::platformLayer):

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media in until they're working.
https://bugs.webkit.org/show_bug.cgi?id=61687

Turn off accelerated compositing for media and plugins when in texture-mapper.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
10:21 Changeset [87693] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Adam Barth.

[Chromium] Fix regression after r87628.
https://bugs.webkit.org/show_bug.cgi?id=61733

Having r87628 in place, Chrome reliability bot crashes in
WebCore::HTMLLinkElement::onloadTimerFired.

This is because the change makes WebCore::CachedResource::setRequest to
call checkNotify on request reset. HTMLLinkElement registers itself as
CachedResource client via m_cachedSheet, which can happen even if
m_cachedLinkResource wasn't set. As a result,
WebCore::HTMLLinkElement::notifyFinished is got called with unset
m_cachedLinkResource, which causes a crash in
HTMLLinkElement::onloadTimerFired

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::notifyFinished):
10:09 Changeset [87692] by darin@apple.com
  • 9 edits in trunk/Source/WebCore

2011-05-30 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler and Simon Fraser.

REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
https://bugs.webkit.org/show_bug.cgi?id=61717
rdar://problem/9522272

May be some good way to test this later. No immediate idea about the best way.

When a media element is taken into full-screen mode, stop events from propagating
outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
has been changed to take a shadow root node. In our full screen media element check,
we check to see if the passed shadow root is the shadow root of the full screen media
element, and if so, specify events should StayInsideShadowDOM. The end result is that
inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
way from the SliderThumb to the video element's shadow root, but no further.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the shadow DOM when showing a full screen video.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls. The events telling us about activity in the shadow DOM no longer bubble out so we need to handle this inside the shadow DOM on the root element. (WebCore::HTMLMediaElement::play): Ditto. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto. (WebCore::HTMLMediaElement::defaultEventHandler): Ditto. (WebCore::HTMLMediaElement::enterFullscreen): Ditto. (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
  • html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out changes that tried to make special rules for events using preDispatchEventHandler and such. This rolls out both r87622 and r87655. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
  • html/shadow/MediaControlElements.h: Ditto.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members. (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider hiding the controls later. (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse is no longer over the controls. (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide automatically if we're playing. (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer. (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care if we are full screen. (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function. (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions as the mouse is moved in and out. (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if needed. (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions are met. (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
  • html/shadow/MediaControlRootElement.h: Added new functions and data members.
10:05 Changeset [87691] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-30 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

2011-05-30 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:25 Changeset [87690] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement JavaScript dialogs in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61725

  • MiniBrowser/gtk/BrowserWindow.c: (WKStringGetCString): Helper function to get a UTF-8 c string from a WKStringRef. (WKURLGetCString): Helper function to get a UTF-8 c string from a WKURLRef. (browserWindowUpdateURL): Update to use WKURLGetCString. (didReceiveTitleForFrame): Update to use WKStringGetCString. (createMessageDialog): Create a GtkMessageDialog. (runJavaScriptAlert): (runJavaScriptConfirm): (runJavaScriptPrompt): (browserWindowUIClientInit):
09:17 Changeset [87689] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-05-30 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
09:14 Changeset [87688] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-30 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
08:44 Changeset [87687] by pvarga@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-30 Peter Varga <pvarga@webkit.org>

Unreviewed build fix.

[Qt][V8] Fix debug build.

No new tests needed.

  • css/CSSStyleDeclaration.cpp: Add missing header.
  • dom/Text.cpp: Ditto.
  • rendering/InlineTextBox.cpp: Ditto.
08:03 QtWebKitForQt5 created by hausmann@webkit.org
07:50 Changeset [87686] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
http://trac.webkit.org/changeset/87683
https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
http://trac.webkit.org/changeset/87683
https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
07:13 Changeset [87685] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=60536

  • Platform/CoreIPC/Connection.cpp: Remove WebProcess.h.
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove ProcessLauncher.h and WebProcessProxy.h. Add <wtf/OwnArrayPtr.h>.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Remove PluginView.h.
07:06 Changeset [87684] by rgabor@webkit.org
  • 2 edits
    5 deletes in trunk/LayoutTests

[Qt] Remove passing tests from ARM Skipped list

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
  • platform/qt-arm/fast: Removed.
  • platform/qt-arm/fast/block: Removed.
  • platform/qt-arm/fast/block/float: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
  • platform/qt-arm/fast/transforms: Removed.
  • platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Removed.
  • platform/qt-arm/transforms: Removed.
  • platform/qt-arm/transforms/2d: Removed.
  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Removed.
  • platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/qt-arm/transforms/svg-vs-css-expected.txt: Removed.
06:48 Changeset [87683] by apavlov@chromium.org
  • 10 edits in trunk

2011-05-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-url-linkify.html:

2011-05-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend up front.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
03:36 Changeset [87682] by mnaganov@chromium.org
  • 49 edits
    39 adds in trunk/LayoutTests

2011-05-30 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed.
[Chromium] Rebaseline tests after r87680.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
02:18 Changeset [87681] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

011-05-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not issue frontendReused for reload or navigation.
https://bugs.webkit.org/show_bug.cgi?id=61192

  • only issue frontendReused when inspector is attached after main resource committed load
  • upon committing loading main resource, reset agents before sending FrameNavigated to page agent
  • Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
  • do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::clearFrontend): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._resetResourcesTree): (WebInspector.DatabaseTreeElement.prototype.onpopulate): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.frontendReused):
01:30 Changeset [87680] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-30 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
https://bugs.webkit.org/show_bug.cgi?id=61603

  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
  • svg/filters/feConvolveFilter-y-bounds.svg: Added.

2011-05-30 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
https://bugs.webkit.org/show_bug.cgi?id=61603

Test: svg/filters/feConvolveFilter-y-bounds.svg

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::getPixelValue):
00:45 Changeset [87679] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-05-30 Nate Chapin <japhet@chromium.org>

Reviewed by Antti Koivisto.

Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
flow so it's a little less circular.
https://bugs.webkit.org/show_bug.cgi?id=61666

  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::beginLoadIfNeeded):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::load):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::loadStarted):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
00:22 Changeset [87678] by abarth@webkit.org
  • 7 edits
    2 deletes in trunk

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
http://trac.webkit.org/changeset/87618
https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
http://trac.webkit.org/changeset/87618
https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

05/29/11:

23:25 Changeset [87677] by mrowe@apple.com
  • 5 edits in tags/Safari-534.41.1/Source

Versioning.

23:23 Changeset [87676] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41.1

New tag.

23:22 Changeset [87675] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87657.

23:22 Changeset [87674] by yutak@chromium.org
  • 21 edits
    4 copies
    2 adds in trunk

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
23:17 Changeset [87673] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <abarth@webkit.org>

More IMAGE results.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
23:07 Changeset [87672] by abarth@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-05-29 Adam Barth <abarth@webkit.org>

Add image baselines for all these beautiful platforms.

  • platform/chromium-linux-x86/fullscreen: Added.
  • platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac/fullscreen: Added.
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-win-vista/fullscreen: Added.
  • platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
22:54 Changeset [87671] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-29 Adam Barth <abarth@webkit.org>

Attempt to fix build by implementing pure virtual function.

  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::shouldHideControls):
  • html/shadow/MediaControlRootElementChromium.h:
22:20 Changeset [87670] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

22:19 Changeset [87669] by mrowe@apple.com
  • 1 copy in tags/Safari-534.41

New tag.

21:41 Changeset [87668] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87654.

21:40 Changeset [87667] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87642.

21:34 Changeset [87666] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87643.

21:32 Changeset [87665] by mrowe@apple.com
  • 14 edits
    3 adds in branches/safari-534-branch

Merge r87660.

21:20 Changeset [87664] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87655.

21:18 Changeset [87663] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87661.

21:14 Changeset [87662] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87652.

20:37 Changeset [87661] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-29 Brian Weinstein <bweinstein@apple.com>

Reviewed by Darin Adler.

Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715
<rdar://problem/9522182>

When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
show the media controls, and then start a timer.

The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
move), and hides the controls.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer. (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen

controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
to play.

(WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future

if we are in full screen.

(WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and

we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.

(WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
(WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the

controls and start a timer to hide them.

(WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't

have the move the mouse once they enter full screen to hide the controls.

(WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls. (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that

the caller should hide the controls if the panel is not hovered.

  • html/shadow/MediaControlRootElement.h:
19:05 Changeset [87660] by jer.noble@apple.com
  • 14 edits
    3 adds in trunk

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
https://bugs.webkit.org/show_bug.cgi?id=61712

  • fullscreen/full-screen-iframe-zIndex-expected.txt: Added.
  • fullscreen/full-screen-iframe-zIndex.html: Added.
  • platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
https://bugs.webkit.org/show_bug.cgi?id=61712

Tests: fullscreen/full-screen-iframe-zIndex.html

Walk up the ancestor chain for the full-screen element, marking them as full-screen
ancestors. Then, we apply a pseudo-class to those elements, which disable all their
stacking-context-creating styles. Set the z-index of all full-screen elements (and
the iframes which contain them) to a large value, ensuring they appear above other
sibling elements.

This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
and pesudo-class, so remove it and replace it with the new pseudo-class.

  • css/CSSSelector.cpp: (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove

-webkit-full-screen-media-document.

(WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove

PseudoFullScreenMediaDocument

(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the

PseudoFullScreenMediaDocument implementation and replace it with
PseudoFullScreenAncestor.

  • css/fullscreen.css: (:-webkit-full-screen): Add a z-index property. (:-webkit-full-screen-ancestor:not(iframe)): Added. Reset the z-index to

auto, and reset other stacking-context creating properties.

  • dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element

instead of just the iframe elements.

(WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.

  • dom/Element.cpp: (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property. (WebCore::Element::insertedIntoTree): Ditto. (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase. (WebCore::Element::setContainsFullScreenElement): Ditto.
  • dom/Element.h:
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for

m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
  • html/HTMLFrameElementBase.h:
  • rendering/style/RenderStyleConstants.h:
17:49 Changeset [87659] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-29 Adam Barth <abarth@webkit.org>

Add expected result.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
17:42 Changeset [87658] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-29 Adam Barth <abarth@webkit.org>

Slightly adjust the type of the expected failure.

  • platform/chromium/test_expectations.txt:
17:19 Changeset [87657] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
https://bugs.webkit.org/show_bug.cgi?id=61714

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
new full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
the full screen element.

  • dom/Element.h:

(WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
(WebCore::Element::willStopBeingFullscreenElement): Ditto.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
MediaControls::enteredFullscreen().
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
MediaControls::exitedFullscreen().

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
changes to the fullscreen-ness of the element.

17:19 Changeset [87656] by darin@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
https://bugs.webkit.org/show_bug.cgi?id=61707

Second try at this. First try could lead to a WKView leak.

  • UIProcess/mac/WKFullScreenWindowController.h: Added _isExitingAcceleratedCompositingMode. Needed to track whether we have retained so we don't leak if the page goes away before we get the callback.
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Added code to set the new variable to YES. (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Added code to deal with the new boolean and to release. (exitCompositedModeRepaintCompleted): Removed the release that was here. (-[WKFullScreenWindowController close]): Added a call to exitCompositedModeRepaintCompleted here. We're as complete as we'll ever be when we're closed; we can't get the callback after that point.
17:00 Changeset [87655] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Kevin Decker.

REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
https://bugs.webkit.org/show_bug.cgi?id=61713

We need to come up with a way to regression-test these changes. Nothing at the moment.

The bug is that we removed calls to preventDefault, but we still do need to prevent
default handling of this event.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault that was in here before r87622 as well as the stopPropagation that was added in r87622. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
15:14 Changeset [87654] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r87637): nytimes.com freezes after going back to it
<rdar://problem/9521928>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
Add call to setShouldNotifyAfterNextScheduledLayerFlush(false) to prevent a
redundant call to layerHostDidFlushLayers which would cause the layer state
to get out of sync with the UIProcess.

14:56 Changeset [87653] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-05-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Some heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=61704


SunSpider says no change.

  • heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

(JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

(JSC::Heap::allocate): Changed inline allocation code to only select the
size class, since this can be optimized out at compile time -- everything
else is now inlined into this out-of-line function.


No need to duplicate ASSERTs made in our caller.

  • heap/Heap.h: (JSC::Heap::heap): (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding a layer of indirection through MarkedSpace.

(JSC::Heap::allocate): See above.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::create): (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::allocate): Updated to match changes above.
14:28 Changeset [87652] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
https://bugs.webkit.org/show_bug.cgi?id=61710

When taking the documentElement full screen, we don't create a RenderFullScreen
object and thus never enter accelerated compositing mode for the animation. Tell
the WKFullScreenWindowController to enter accelerated compositing mode anyway
(with an empty layer context) so as to fulfill its expectations and cause the
full screen animation to complete.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a

comment explaining when we expect the animation to complete.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):

Remove an ASSERT which is no longer valid.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess

to enter then exit full-screen mode.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

14:01 Changeset [87651] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87633.

14:01 Changeset [87650] by mrowe@apple.com
  • 11 edits
    2 adds in branches/safari-534-branch

Merge r87628.

13:57 Changeset [87649] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87637.

13:56 Changeset [87648] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87634.

13:54 Changeset [87647] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87639.

13:54 Changeset [87646] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source/WebKit2

Merge r87638.

13:45 Changeset [87645] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Element: Micro-cleanup of scroll methods.
https://bugs.webkit.org/show_bug.cgi?id=61705

Do an early return without calculating element boundaries when asked
to scroll an element without a renderer().

  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::scrollByUnits):
13:12 Changeset [87644] by darin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
https://bugs.webkit.org/show_bug.cgi?id=61707

Saw this while debugging a crash. We don't have a way to make regression tests for this
kind of issue at this time.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller here since we are keeping a pointer to it. (exitCompositedModeRepaintCompleted): Release the controller here.
13:12 Changeset [87643] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Fix assertion seen when entering full screen mode for standalone video
https://bugs.webkit.org/show_bug.cgi?id=61708

We don't currently have a way to make a regression test for this.

  • dom/Document.cpp: (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc, because scheduleStyleRecalc is intended to only be called when the style system itself detects recalc is needed.
13:06 Changeset [87642] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-29 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
https://bugs.webkit.org/show_bug.cgi?id=61706
<rdar://problem/9521970>

If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
12:38 Changeset [87641] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-29 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
https://bugs.webkit.org/show_bug.cgi?id=61162

Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
that omits a line count. In particular, the chunk range regular expression does
not match a chunk range line that omits a line count. GNU diff(1) will omit the
line count in the chunk range if the line count is exactly 1. For example, appending
a new line to the end of an existing file F that contains exactly one line of text will
be represented in a diff with a chunk range line that omits the line count for F.

  • Scripts/VCSUtils.pm: (parseChunkRange): Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added unit test "Git: Append new line to the end of an existing file".
12:13 Changeset [87640] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

[Qt] Add area check to ImageBufferData::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
12:00 Changeset [87639] by darin@apple.com
  • 5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <bdakin@apple.com> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.

  • page/ChromeClient.h:

(WebCore::ChromeClient::setRenderTreeSize):

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

  • rendering/RenderArena.h:

(WebCore::RenderArena::totalRenderArenaSize):

11:13 Changeset [87638] by darin@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-05-29 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

  • UIProcess/API/C/WKPage.cpp: (WKPageGetRenderTreeSize):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::renderTreeSize): (WebKit::WebPageProxy::setRenderTreeSize):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setRenderTreeSize):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:03 Changeset [87637] by darin@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

02:49 Changeset [87636] by philn@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Data directory is webkitgtk-x.y not webkit-x.y
https://bugs.webkit.org/show_bug.cgi?id=61642

  • GNUmakefile.am: updated data directory.
01:30 Changeset [87635] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87566.
http://trac.webkit.org/changeset/87566
https://bugs.webkit.org/show_bug.cgi?id=61702

It made all tests assert on Qt in debug mode (Requested by
Ossy_weekend on #webkit).

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suggestedMIMEType): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • platform/mac/HTMLConverter.mm: (fileWrapperForElement):
00:04 Changeset [87634] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-28 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't add sub-frames to global history when navigating via back/forward
https://bugs.webkit.org/show_bug.cgi?id=61701
<rdar://problem/9521222>

Instead of just checking whether the load is the first in the frame, we also need to
check to make sure we're loading in the main frame.

Not testable due to lack of global history infrastructure in DRT.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

05/28/11:

21:42 Changeset [87633] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Suggested by Simon Fraser.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use ASSERT_UNUSED here.
19:46 Changeset [87632] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87624.

19:44 Changeset [87631] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87622.

19:42 Changeset [87630] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebKit2

Merge r87627.

19:41 Changeset [87629] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87598.

18:37 Changeset [87628] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Geoff Garen.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

Test: fast/dom/gc-image-element-2.html

Manually verified that tests from bug 59604 and from bug 40926 still pass.

The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::wasCanceled): (WebCore::CachedResource::errorOccurred): Track whether the load was canceled. We want to always notify clients of load outcome, as that's the only way they could make intelligent decisions.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now get a notifyFinished call on cancellation. Handle this case, where we don't need the execute the script, but also don't need to fire an error event.
  • html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single function call now.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large window between when CachedResource::isLoading() becomes false and events are queued. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting an event to fire.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do anything on cancellation.
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to give an accurate result while looping over the list of events to dispatch. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to switch to a broken image icon, or to dispatch events. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching list, as the event is no longer pending when it's being dispatched.
  • loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one is already pending, we only care if one is expected at some time in the future, and !haveFiredLoadEvent() is our best idea of that.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to handle cancellation.
16:45 Changeset [87627] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Maciej Stachowiak.

Denying access to your keychain on login crashes WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61695
<rdar://problem/9520570>

Fix two sources of crashes if you hit the Deny button when WebKit2 is
doing HTTP authentication.

First, SecKeychainItemRequestData::attributeList() failed to initialize the
length and data members of SecKeychainAttributes in the list if there was no data.
This caused invalid memory reads later.

Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
would cause a later crash in a system framework, which is not set up to handle
errors. Instead, we always return noErr, and allow the authentication to fail.

Finally, paranoically initialize the SecKeychainItemContext in two places
to avoid uninitialized data members, and initialize length and outData
to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
fails to set them on error.

  • Shared/mac/SecKeychainItemRequestData.cpp: (WebKit::SecKeychainItemRequestData::attributeList):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::secKeychainItemCopyContent):
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCopyContent): (WebKit::webSecKeychainItemCreateFromContent):
15:26 Changeset [87626] by abarth@webkit.org
  • 7 edits in trunk/Tools

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS builds patches that fail to build twice, which seems useless and slows down the bots
https://bugs.webkit.org/show_bug.cgi?id=55585

This patch switches all the early warning system bots over to the new
PatchAnalysisTask-based infrastructure. This patch makes these bots
more efficient (in the case where patches fail to build) and paves the
way for running tests on these bots!

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
14:45 Changeset [87625] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-28 Martin Robinson <mrobinson@igalia.com>

Skip a failing test and better classify some existing skipped tests.

  • platform/gtk/Skipped: Update the skipped list.
13:39 Changeset [87624] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r86578): Flash content missing from mercurynews.com
https://bugs.webkit.org/show_bug.cgi?id=61691
<rdar://problem/9519893>

If the plug-in doesn't have access to the toplevel URL, make sure to
return *something* to the plug-in.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
12:59 Changeset [87623] by abarth@webkit.org
  • 23 edits in trunk/Source

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::cancelledError): (WebCore::FrameLoaderClientQt::blockedError): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest): (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::cancelledError): (WebCore::FrameLoaderClientEfl::blockedError):
  • ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): (ewk_frame_uri_changed):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_frame_create): (ewk_view_plugin_create):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

As far as I can tell, all the callers of this API are confused. There
seems to be a cargo cult of using the "pretty" version of a URL, but in
reality folks just want the URL itself. The only case I'm unsure about
is location.href, which could have some compatibility constraints.
I've renamed prettyURL to deprecatedString to discourage folks from
further cargo-culting.

  • WebCore.exp.in:
  • page/Location.cpp: (WebCore::Location::href): (WebCore::Location::toString):
  • platform/KURL.cpp: (WebCore::KURL::deprecatedString):
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURL::deprecatedString):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::href): (WebCore::WorkerLocation::toString):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::cancelledError): (WebKit::blockedError):
12:41 Changeset [87622] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-28 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Mouse clicks propagate outside full-screen media controls.
https://bugs.webkit.org/show_bug.cgi?id=61689

Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block

propagation of all mouse click events.

(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):

Renamed from setDefaultHandled.

(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

  • html/shadow/MediaControlElements.h:
11:49 Changeset [87621] by mrowe@apple.com
  • 5 edits in tags/Safari-534.40.1/Source

Versioning.

11:37 Changeset [87620] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40.1

New tag.

11:37 Changeset [87619] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87331.

11:18 Changeset [87618] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
10:55 Changeset [87617] by commit-queue@webkit.org
  • 5 edits in trunk

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
10:02 Changeset [87616] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial lyAligned
https://bugs.webkit.org/show_bug.cgi?id=61606

Removed duplicated statement within if condition.

No new tests. Obvious clean up patch.

  • page/SpatialNavigation.cpp: (WebCore::areRectsPartiallyAligned):
09:16 Changeset [87615] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, clean up GPU tests expectations

08:43 Changeset [87614] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX when building only the interpreter

Fixes the following compiler warning:

JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]

void releaseExecutableMemory(JSGlobalData& globalData)


  • jit/ExecutableAllocator.h: Moved declaration of

JSC::releaseExecutableMemory().

08:27 Changeset [87613] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

08:24 Changeset [87612] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode): Added missing argument.

05:15 Changeset [87611] by robert@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-28 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

If there is no editable text Qt interprets backspace as a navigation
command, regardless of platform.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.
05:06 Changeset [87610] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

03:32 Changeset [87609] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

01:50 Changeset [87608] by mnaganov@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-05-28 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed. Test expectations update after r87605

  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.
01:27 Changeset [87607] by bashi@chromium.org
  • 2 edits in trunk/Tools

2011-05-28 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

Add bashi as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61685

  • Scripts/webkitpy/common/config/committers.py:
00:17 Changeset [87606] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-05-28 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/style/non-inheritable-styles should be dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61681

Converts the test to dump-as-markup and cleans up the HTML a bit.

  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html:
  • platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

05/27/11:

23:52 Changeset [87605] by zimmermann@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, this just adds a new test.

WebKit fails WICD SVG background image tests
https://bugs.webkit.org/show_bug.cgi?id=16481

Add two WICD SVG background image tests, which pass just fine.

  • svg/wicd/resources/test-scalable-background-image1.css: Added. (html): (body): (p):
  • svg/wicd/resources/test-scalable-background-image1.svg: Added.
  • svg/wicd/resources/test-scalable-background-image2.css: Added. (html):
  • svg/wicd/resources/test-scalable-background-image2.svg: Added.
  • svg/wicd/test-scalable-background-image1.xhtml: Added.
  • svg/wicd/test-scalable-background-image2.xhtml: Added.
23:19 Changeset [87604] by commit-queue@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/inserting/insert-3907422 should be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=61680

Converted to dumpAsMarkup and cleaned up markup.

  • editing/inserting/insert-3907422-fix-expected.txt: Added.
  • editing/inserting/insert-3907422-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.
22:13 Changeset [87603] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

22:13 Changeset [87602] by mrowe@apple.com
  • 1 copy in tags/Safari-534.40

New tag.

21:48 Changeset [87601] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

When checking whether the tree is red, the EWS posts a link to the wrong log
https://bugs.webkit.org/show_bug.cgi?id=61072

We need to cache the original script error because that contains the
failure log we want to upload. If we don't cache that script error,
self._script_error will get overwritten when we sanity check the clean
tree (and it also has test failures).

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • This testing approach is slightly goofy. We'd like to use assertRaisesRegexp, but that's not available until Python 2.7.
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
21:42 Changeset [87600] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87599.

21:39 Changeset [87599] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Roll out r87544 since it is bogus.

21:18 Changeset [87598] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CG BitmapImage needs to check for valid CGImage in a couple of places
https://bugs.webkit.org/show_bug.cgi?id=61684
<rdar://problem/9519348>

BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
returns null, which it may do if the image is corrupted or still
loading. Protect against that here and in getFirstCGImageRefOfSize().

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::getFirstCGImageRefOfSize): (WebCore::BitmapImage::getCGImageArray):
20:27 Changeset [87597] by jochen@chromium.org
  • 15 edits
    4 adds in trunk

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • platform/chromium/permissionclient/storage-permission-expected.txt: Added.
  • platform/chromium/permissionclient/storage-permission.html: Added.

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add Frame parameter to all StorageArea methods. The chromium
embedder uses the Frame as context to decide whether or not
to allow usage of the storage API.
https://bugs.webkit.org/show_bug.cgi?id=61581

Test: platform/chromium/permissionclient/storage-permission.html

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::contains):
  • storage/StorageAreaImpl.h:

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains): (WebCore::StorageAreaProxy::canAccessStorage):
  • src/StorageAreaProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem):

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add layoutTestController.setStorageAllowed() to control whether access
to the localStorage API is enabled via the WebPermissionClient
https://bugs.webkit.org/show_bug.cgi?id=61581

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.h: Added. (WebPermissions::WebPermissions): (WebPermissions::allowStorage): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
19:28 Changeset [87596] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
https://bugs.webkit.org/show_bug.cgi?id=60326

This patch removes a lot of the complexity from the
metered_stream implementation that was unnecessary since there
was only one caller and the logic could be coordinated better.

There should be no functional changes in this patch, just code
getting deleted and cleaned up.

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
19:24 Changeset [87595] by japhet@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-27 Nate Chapin <japhet@chromium.org>

Reviewed by Jian Li.

Keep a reference to BlobResourceHandle before calling doNotifyFinish()
asynchronously to ensure it's still safe in the main thread.

https://bugs.webkit.org/show_bug.cgi?id=61669

I triggered this crash in fast/files/file-reader-abort.html during a
refactor that changed timings slightly.

  • platform/network/BlobResourceHandle.cpp: (WebCore::doNotifyFinish): (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/BlobResourceHandle.h: (WebCore::BlobResourceHandle::aborted):
19:16 Changeset [87594] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: minor cleanup in printing module
https://bugs.webkit.org/show_bug.cgi?id=60329

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
19:11 Changeset [87593] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

NRWT: remove --print detailed-progress
https://bugs.webkit.org/show_bug.cgi?id=60324

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:00 Changeset [87592] by sjl@chromium.org
  • 2 edits in trunk/Tools

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Add sjl@chromium.org as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61672

  • Scripts/webkitpy/common/config/committers.py:
18:56 Changeset [87591] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

NRWT: debug messages from the workers are being logged twice
https://bugs.webkit.org/show_bug.cgi?id=60428

It looks like when the workers are run in separate processes
we end up getting two copies of every log message they print.
This has to do with the multiprocessing module on UNIX cloning
the log configuration in a way I wasn't expecting, and so two
log handlers end up getting registered.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:24 Changeset [87590] by adamk@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Hopefully last rebaseline from r87526.

  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
17:30 Changeset [87589] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: Vista flakiness.

17:28 Changeset [87588] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

JS API is too aggressive about throwing exceptions for NULL get or set operations
https://bugs.webkit.org/show_bug.cgi?id=61678

  • API/JSCallbackObject.h: Changed our staticValueGetter to a regular function that returns a JSValue, so it can fail and still forward to normal property lookup.
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): Don't throw an exception when failing to access a static property -- just forward the access. This allows objects to observe get/set operations but still let the JS object manage lifetime.

(JSC::::put): Ditto.

(JSC::::getStaticValue): Same as JSCallbackObject.h.

  • API/tests/testapi.c: (MyObject_set_nullGetForwardSet):
  • API/tests/testapi.js: Updated tests to reflect slightly less strict behavior, which matches headerdoc claims.
17:26 Changeset [87587] by adamk@chromium.org
  • 2 edits
    11 adds
    2 deletes in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Even more rebaselines after r87526.

  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:53 Changeset [87586] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Property caching is too aggressive for API objects
https://bugs.webkit.org/show_bug.cgi?id=61677

  • API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our callback APIs allow the client to change its mind about our propertis at any time.
  • API/tests/testapi.c: (PropertyCatchalls_getProperty): (PropertyCatchalls_setProperty): (PropertyCatchalls_getPropertyNames): (PropertyCatchalls_class): (main):
  • API/tests/testapi.js: Some tests for dynamic API objects.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client requires it.
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::isFinal): (JSC::TypeInfo::prohibitsPropertyCaching): (JSC::TypeInfo::flags): Added a flag to track opting out of property caching. Fixed an "&&" vs "&" typo that was previously harmless, but is now harmful since m_flags2 can have more than one bit set.
16:34 Changeset [87585] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87578.

16:21 Changeset [87584] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed test expectations update: widen flakiness to include Linux.

16:18 Changeset [87583] by sjl@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

The behaviour of controls-after-reload was causing
layoutTestController in DumpRenderTree to misbehave causing a reported
failure in the test run after it (controls-css-overload).

Effectively, notifyDone() ended up getting called again after the test
was being torn down.

This change removes the unneeded seek at the end of the test (as we
should have already seeked to 0.

https://bugs.webkit.org/show_bug.cgi?id=60132

  • media/controls-after-reload.html:
  • platform/chromium/test_expectations.txt:
16:09 Changeset [87582] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source

Merge r87580.

16:09 Changeset [87581] by mrowe@apple.com
  • 11 edits
    1 add in branches/safari-534-branch/Source

Merge r87520.

15:57 Changeset [87580] by slewis@apple.com
  • 8 edits in trunk/Source

Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
15:49 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:48 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:48 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:32 Changeset [87579] by adamk@chromium.org
  • 3 edits
    2 copies
    3 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. More rebaselines after r87526.

  • platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-linux/svg/in-html/by-reference-expected.txt:
  • platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:14 Changeset [87578] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

2011-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Always use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=61670
<rdar://problem/9516130>

Always use the default localization strategy when there's no platform strategy.

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::shared):
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultDetailsSummaryText): (WebCore::copyImageUnknownFileLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagCopyImageUrlToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagSelectAll): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchInSpotlight): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagShowFonts): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagStyles): (WebCore::contextMenuItemTagShowColors): (WebCore::contextMenuItemTagSpeechMenu): (WebCore::contextMenuItemTagStartSpeaking): (WebCore::contextMenuItemTagStopSpeaking): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagCorrectSpellingAutomatically): (WebCore::contextMenuItemTagSubstitutionsMenu): (WebCore::contextMenuItemTagShowSubstitutions): (WebCore::contextMenuItemTagSmartCopyPaste): (WebCore::contextMenuItemTagSmartQuotes): (WebCore::contextMenuItemTagSmartDashes): (WebCore::contextMenuItemTagSmartLinks): (WebCore::contextMenuItemTagTextReplacement): (WebCore::contextMenuItemTagTransformationsMenu): (WebCore::contextMenuItemTagMakeUpperCase): (WebCore::contextMenuItemTagMakeLowerCase): (WebCore::contextMenuItemTagCapitalize): (WebCore::contextMenuItemTagChangeBack): (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXARIAContentGroupText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::missingPluginText): (WebCore::crashedPluginText): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::uploadFileText): (WebCore::allFilesText): (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName): (WebCore::imageTitle): (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
14:55 Changeset [87577] by mrowe@apple.com
  • 8 edits in branches/safari-534-branch/Source/WebCore

Merge r87566.

14:50 Changeset [87576] by mrowe@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r87330.

14:50 Changeset [87575] by mrowe@apple.com
  • 13 edits
    3 adds in branches/safari-534-branch/Source

Merge r87228.

14:43 Changeset [87574] by mrowe@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r87460.

14:37 Changeset [87573] by mrowe@apple.com
  • 11 edits in branches/safari-534-branch/Source

Merge r87329.

14:36 Changeset [87572] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

14:33 Changeset [87571] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87557.

14:25 Changeset [87570] by mrowe@apple.com
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87414.

14:20 Changeset [87569] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87456.

14:18 Changeset [87568] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-534-branch

Merge r87322.

14:16 Changeset [87567] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87363.

14:15 Changeset [87566] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
14:15 Changeset [87565] by mrowe@apple.com
  • 16 edits in branches/safari-534-branch

Merge r87328.

14:12 Changeset [87564] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87442.

14:10 Changeset [87563] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87544.

14:08 Changeset [87562] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch

Merge r87421.

14:05 Changeset [87561] by enne@google.com
  • 3 edits in trunk/LayoutTests

2011-05-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
14:02 Changeset [87560] by mrowe@apple.com
  • 7 edits in branches/safari-534-branch/Source

Merge r87335.

13:59 Changeset [87559] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87397.

13:56 Changeset [87558] by adamk@chromium.org
  • 5 edits
    3 copies
    77 adds in trunk/LayoutTests

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaselines and test expectations updates after r87526.

  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
13:53 Changeset [87557] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

30 second rewind button obscured in fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=61663

If reset() is called while in full-screen mode, make sure to show and hide
the correct controls for that mode.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
13:53 Changeset [87556] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87305.

13:51 Changeset [87555] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87272.

13:50 Changeset [87554] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87237.

13:48 Changeset [87553] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-534-branch

Merge r87387.

13:45 Changeset [87552] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87458.

13:43 Changeset [87551] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87524.

13:39 Changeset [87550] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.

  • runtime/JSGlobalData.cpp: (JSGlobalData::JSGlobalData):
13:37 Changeset [87549] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87361.

13:35 Changeset [87548] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-534-branch

Merge r87324.

13:29 Changeset [87547] by jamesr@google.com
  • 3 edits
    3 adds in trunk

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

  • compositing/iframes/resizer-expected.txt: Added.
  • compositing/iframes/resizer.html: Added.

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
graphics layer tree consistent.

Test: compositing/iframes/resizer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
13:28 Changeset [87546] by mrowe@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87253.

13:25 Changeset [87545] by zimmermann@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fix last failing win/svg test, put result in correct directory.

  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.
13:22 Changeset [87544] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

  • WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
13:21 Changeset [87543] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.

13:18 Changeset [87542] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
The feature is tracked by the bug 61630.

  • platform/gtk/Skipped:
13:10 Changeset [87541] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87244.

13:10 Changeset [87540] by mrowe@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r87275.

12:53 Changeset [87539] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLVideoElement::currentSrc() should return a KURL
https://bugs.webkit.org/show_bug.cgi?id=61578

I suspect we got into this mess because the author of this code didn't
know about the URL attribute in WebKit IDL, which is super useful!

Bad news: The line of code in question seems to have another bug, which
I've documented in a FIXME. Let the yak shaving continue!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::currentURL):
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
    • This complete URL call was unnecessary because currentSrc is already absolute.
12:52 Changeset [87538] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=61177

  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className):
12:50 Changeset [87537] by aroben@apple.com
  • 2 edits in trunk/Tools

Always decode tester names from location.hash

When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.

12:48 Changeset [87536] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add a few validity assertions to JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=61659

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::visitChildren):
12:44 Changeset [87535] by zimmermann@webkit.org
  • 4 edits
    8 adds in trunk/LayoutTests

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Rebaseline some qt/win/leopard results.

  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
12:32 Changeset [87534] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fixes crash in svg/custom/immutable-properties.html, seen on the bots.

  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
12:32 Changeset [87533] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-05-27 Nat Duca <nduca@chromium.org>

Unreviewed, landed by enne@google.com.

[chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium/test_expectations.txt:
11:56 Changeset [87532] by rniwa@webkit.org
  • 2 adds in trunk/LayoutTests/platform/chromium-win/editing/pasteboard

Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.

11:52 Changeset [87531] by rniwa@webkit.org
  • 3 edits
    2 adds
    19 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61610

Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.

  • editing/pasteboard/paste-pre-001-expected.txt: Added.
  • editing/pasteboard/paste-pre-001.html:
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.
11:49 Changeset [87530] by aroben@apple.com
  • 2 edits in trunk/Tools

Remove testing code that snuck into r87528

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.

11:47 Changeset [87529] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

11:41 Changeset [87528] by aroben@apple.com
  • 3 edits in trunk/Tools

Add links to TestFailures to easily file bugs about failing tests

Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!

11:30 Changeset [87527] by oliver@apple.com
  • 25 edits in trunk/Source/JavaScriptCore

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Try to release unused executable memory when the FixedVMPool allocator is under pressure
https://bugs.webkit.org/show_bug.cgi?id=61651

Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h:
  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::linkCode):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::executableCopy):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::executableCopy):
  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy): (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::create): (JSC::ExecutablePool::alloc): (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutableAllocator::poolForSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::alloc):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator): (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::releaseExecutableMemory): (JSC::releaseExecutableMemory):
  • runtime/JSGlobalData.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::invalidateCode):
  • runtime/RegExpCache.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::compile):
11:27 Changeset [87526] by zimmermann@webkit.org
  • 18 edits
    92 adds in trunk

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
  • http/tests/misc/resources/embedded.svg: Added.
  • http/tests/misc/resources/svg-slow.pl: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • svg/custom/object-no-size-attributes.xhtml: Added.
  • svg/custom/object-sizing-explicit-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width.xhtml: Added.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
  • svg/custom/object-sizing-no-width-height.xhtml: Added.
  • svg/custom/object-sizing.xhtml: Added.
  • svg/custom/resources/embedded.svg: Added.
  • svg/custom/resources/red-circle.svg: Added.
  • svg/in-html/by-reference-expected.png:
  • svg/wicd: Added.
  • svg/wicd/resources: Added.
  • svg/wicd/resources/a.svg: Added.
  • svg/wicd/resources/bcde.svg: Added.
  • svg/wicd/resources/empty1.svg: Added.
  • svg/wicd/resources/empty2.svg: Added.
  • svg/wicd/resources/empty3.svg: Added.
  • svg/wicd/resources/f.svg: Added.
  • svg/wicd/resources/g.svg: Added.
  • svg/wicd/resources/h.svg: Added.
  • svg/wicd/resources/i.svg: Added.
  • svg/wicd/resources/j.svg: Added.
  • svg/wicd/resources/k.svg: Added.
  • svg/wicd/resources/l.svg: Added.
  • svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
  • svg/wicd/resources/mnop.svg: Added.
  • svg/wicd/resources/q.svg: Added.
  • svg/wicd/resources/r.svg: Added.
  • svg/wicd/resources/s.svg: Added.
  • svg/wicd/resources/t.svg: Added.
  • svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
  • svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
  • svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
  • svg/wicd/rightsizing-grid.xhtml: Added.
  • svg/wicd/test-rightsizing-a.xhtml: Added.
  • svg/wicd/test-rightsizing-b.xhtml: Added.
  • svg/zoom/page/resources: Added.
  • svg/zoom/page/resources/absolute-sized-svg.png: Added.
  • svg/zoom/page/resources/absolute-sized-svg.svg: Added.
  • svg/zoom/page/resources/huge-rect.svg: Added.
  • svg/zoom/page/resources/percentage-sized-svg.png: Added.
  • svg/zoom/page/resources/percentage-sized-svg.svg: Added.
  • svg/zoom/page/resources/text.svg: Added.
  • svg/zoom/page/resources/tux.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.

If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml

svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/Length.h: (WebCore::Length::isSpecified):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h:
11:11 Changeset [87525] by jochen@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] drop unused WebFrame parameter to WebStorageArea::setItem
https://bugs.webkit.org/show_bug.cgi?id=61583

  • public/WebStorageArea.h:
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
  • src/WebStorageAreaImpl.h:
10:52 Changeset [87524] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-27 Michael Saboff <msaboff@apple.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=61646
Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font

Change the platformIsEqual to just compare the m_font members if
either is not null.

No tests added - functionality unchanged, fixing memory abandonment.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::platformIsEqual):
10:39 Changeset [87523] by mrobinson@webkit.org
  • 7 edits
    3 adds in trunk

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

Added a GTK+ specific test that verifies that zero pixel sized
fonts do not corrupt the Cairo context.

  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

When instantiating a cairo_scaled_font_t font would put the font in an error state,
leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
in the error state can later lead to corrupted rendering.

Due to this change, we must always null check cairo_scaled_font_t and the platform
data now carries the cairo_font_face_t object with it, so that it can be accessed later
if there is no cairo_scaled_font_t.

Test: platform/gtk/fonts/zero-pixel-sized-fonts.html

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
  • platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Initialize the new member. (WebCore::FontPlatformData::operator=): Carry over the new member. (WebCore::FontPlatformData::operator==): Check equality with the new member. (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont put the font into an error state, then just free it and return. (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap when the scaled font is null, because rendering is always a no-op and the font data never needs to be read.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font. (WebCore::SimpleFontData::scaledFontData): Use the new m_font member. (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
10:39 Changeset [87522] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized ConservativeSet to avoid double-visiting objects
https://bugs.webkit.org/show_bug.cgi?id=61592


SunSpider thinks this might be a 1% speedup

  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting an object.
  • heap/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type to void*, since clients want to ask questions about arbitrary pointers into the heap, even when they aren't known to be JSCells.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::testAndClearMarked):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::testAndClearMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Ditto.
  • wtf/Bitmap.h: (WTF::::testAndClear): New function for ConservativeRoots's inverted marking pass.
10:25 Changeset [87521] by levin@chromium.org
  • 9 edits in trunk/Source

Need a callback for when the preferred rendered size may have changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::layoutUpdated): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h:

(WebCore::ChromeClient::layoutUpdated): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Added a callback for whem a layout has finished.

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didUpdateLayout): Added stub.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.

  • src/ChromeClientImpl.h: Added declaration.
09:59 Changeset [87520] by slewis@apple.com
  • 11 edits
    1 add in trunk/Source

Rubber Stamped by Adam Roben.

Source/JavaScriptCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

Source/WebCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebCore.order:

Source/WebKit/mac:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebKit.order:

Source/WebKit2:

Add Order File. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • mac/WebKit2.order: Added.
09:34 Changeset [87519] by commit-queue@webkit.org
  • 21 edits
    6 deletes in trunk

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • http/tests/websocket/tests/client-close-expected.txt: Removed.
  • http/tests/websocket/tests/client-close.html: Removed.
  • http/tests/websocket/tests/client-close_wsh.py: Removed.
  • http/tests/websocket/tests/close-before-open-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html:
  • http/tests/websocket/tests/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/server-close-expected.txt: Removed.
  • http/tests/websocket/tests/server-close.html: Removed.
  • http/tests/websocket/tests/server-close_wsh.py: Removed.
  • http/tests/websocket/tests/websocket-event-target-expected.txt:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): (WebCore::SocketStreamHandleBase::close): (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • Scripts/webkitpy/thirdparty/init.py:
09:19 Changeset [87518] by rwlbuis@webkit.org
  • 3 edits
    2 adds
    3 deletes in trunk

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Remove 003-broken.xml and replace it with a 003.xml that is text-only.

  • platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
  • svg/hixie/links/003-broken.xml: Removed.
  • svg/hixie/links/003-expected.txt: Added.
  • svg/hixie/links/003.xml: Added.

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Only allow links to animation elements within the document.

Test: svg/hixie/links/003.xml

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
09:14 Changeset [87517] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
https://bugs.webkit.org/show_bug.cgi?id=60757

cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint):
09:10 Changeset [87516] by adamk@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

08:41 Changeset [87515] by ap@apple.com
  • 2 edits in trunk/Tools

Added Douglas Davidson to contributors list for easier CC'ing.

  • Scripts/webkitpy/common/config/committers.py:
08:34 Changeset [87514] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044

Make sure to set the active window on the application too.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette):
08:19 Changeset [87513] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

WebKit2 does not support eventSender.

  • platform/mac-wk2/Skipped:
08:03 Changeset [87512] by andreas.kling@nokia.com
  • 16 edits in trunk

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

HTML5 now specifies that fully transparent colors should have their alpha value
serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)

The number of decimals for alpha values between 0 and 1 is not specified,
so match Gecko and Presto by returning the lowest number of decimals needed
to represent the number. (No more trailing zeroes.)

  • platform/graphics/Color.cpp: (WebCore::Color::serialized):

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

Update tests to reflect the new behavior.

  • canvas/philip/tests/2d.fillStyle.get.transparent.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
  • editing/style/inline-style-container-expected.txt
  • editing/style/script-tests/inline-style-container.js:
  • fast/canvas/canvas-color-clamping-expected.txt:
  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/canvas-currentColor-expected.txt:
  • fast/canvas/script-tests/canvas-color-clamping.js:
  • fast/canvas/script-tests/canvas-color-serialization.js:
  • fast/canvas/script-tests/canvas-currentColor.js:
  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
  • fast/dom/canvasContext2d-element-attribute-js-null.html:
07:35 Changeset [87511] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that requires eventSender.beginDragWithFiles.

  • platform/win/Skipped:
07:23 Changeset [87510] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip a test that is failing until investigated.

  • platform/gtk/Skipped:
07:19 Changeset [87509] by jeffm@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-26 Jeff Miller <jeffm@apple.com>

Reviewed by Alexey Proskuryakov.

Add a key handling logging channel for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61588


Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

  • Platform/Logging.cpp: (WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
  • Platform/Logging.h: Added LogKeyHandling channel.
  • UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment. (WebKit::webKeyboardEventTypeString): Added to support logging. (WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event. (WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
07:02 Changeset [87508] by hans@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

New test for adding new entries to an objecet store while running a
cursor over it.

  • storage/indexeddb/mutating-cursor-expected.txt: Added.
  • storage/indexeddb/mutating-cursor.html: Added.

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

We need to support the case where a new node is added to the tree in a
transaction after the TreeIterator has covered the whole tree.

Since this is done lazily, i.e. we set a flag that the tree might have
changed, and act upon it later, some members need to be mutable,
because we might need to re-seek the tree iterator in a const function.

Test: storage/indexeddb/mutating-cursor.html

storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)

  • platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::treeChanged): (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
  • platform/leveldb/LevelDBTransaction.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::open):
06:51 Changeset [87507] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Sujin Park <sujjin.park@gmail.com>

Unreviewed, buildfix if --no-javascript-debugger.

Regression(R84125): Broke GTK build
https://bugs.webkit.org/show_bug.cgi?id=60698

No new tests since this doesn't change any behavior.

  • inspector/WorkerInspectorController.h:
06:48 Changeset [87506] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Daily gardening.

Typo fix, and remove non-existent files from Skipped list.

  • platform/qt-mac/Skipped:
06:12 Changeset [87505] by ossy@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Qt][Mac] Daily gardening.

  • platform/qt-mac/Skipped:
    • plugins/embed-attributes-setting.html was unskipped by r87306, but fails on Qt-Mac.
    • plugins/plugin-initiate-popup-window.html unskipped by r87429, but fails on Qt-Mac.
    • fast/css/disabled-author-styles unskipped by r87311, but fails on Qt-Mac.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Added after r87468.
05:59 Changeset [87504] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip test that is failing on the bot, until investigated.

  • platform/chromium/test_expectations.txt:
05:48 Changeset [87503] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip new dropzone tests. Qt's DRT does not support drag 'n drop.

  • platform/qt/Skipped:
05:46 Changeset [87502] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress editing/pasteboard/smart-paste-004.html on Win after r87496

05:43 Changeset [87501] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreveiwed, suppress editing/pasteboard/smart-paste-003.html on Win after r87495

05:42 Changeset [87500] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[WK2] Skip new failing tests because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped: Add failing tests.
  • platform/qt-wk2/Skipped: Remove tests, because they fail because of WK2 specific bug, not Qt-WK2 specific.
05:37 Changeset [87499] by yael.aharon@nokia.com
  • 7 edits
    9 adds in trunk

webkit should implement the dropzone attribute
https://bugs.webkit.org/show_bug.cgi?id=58210

Reviewed by Tony Chang.

Source/WebCore:

Add support for dropzone attribute.
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
If there is such an element, and it matches the drag data store, set the action defined by that
element and continue processing the drag and drop operation.

Tests: fast/events/dropzone-001.html

fast/events/dropzone-002.html
fast/events/dropzone-003.html
fast/events/dropzone-004.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::Clipboard::processDropZoneKeyword):

  • dom/Clipboard.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.idl:
  • page/EventHandler.cpp:

(WebCore::EventHandler::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):

  • page/EventHandler.h:

LayoutTests:

  • fast/events/dropzone-001-expected.txt: Added.
  • fast/events/dropzone-001.html: Added.
  • fast/events/dropzone-002-expected.txt: Added.
  • fast/events/dropzone-002.html: Added.
  • fast/events/dropzone-003-expected.txt: Added.
  • fast/events/dropzone-003.html: Added.
  • fast/events/dropzone-004-expected.txt: Added.
  • fast/events/dropzone-004.html: Added.
  • fast/events/resources/dropzone.js: Added.
05:20 Changeset [87498] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60175

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped: The bug is in Qt 4.8, add Qt bug tracker URL's.
04:57 Changeset [87497] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Make the bot environmentally friendly.

  • platform/qt-wk2/Skipped:
04:44 Changeset [87496] by rniwa@webkit.org
  • 4 edits
    1 move
    2 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-004.html through smart-paste-006.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61618

Converted smart-paste-004.html, smart-paste-005.html, and smart-paste-005.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-004-expected.txt: Added.
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005-expected.txt: Added.
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-006-expected.txt: Added.
  • editing/pasteboard/smart-paste-006.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt: Removed.
04:38 Changeset [87495] by rniwa@webkit.org
  • 4 edits
    3 adds
    27 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61617

Converted smart-paste-001.html, smart-paste-002.html, and smart-paste-003.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-001-expected.txt: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002-expected.txt: Added.
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003-expected.txt: Added.
  • editing/pasteboard/smart-paste-003.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Removed.
04:36 Changeset [87494] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r87467.

  • page/wince/FrameWinCE.cpp:
04:22 Changeset [87493] by rniwa@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-unrendered-select.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61616

Converted paste-unrendered-select.html to a dump-as-markup test.

  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html:
  • platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
04:16 Changeset [87492] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • platform/chromium/test_expectations.txt:

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • features.gypi:
03:54 Changeset [87491] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=61517

Support cursors where the direction is set to NEXT_NO_DUPLICATE,
or PREV_NO_DUPLICATE, as specified here:
http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE

This is tested by storage/indexeddb/mozilla/indexes.html

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
03:37 Changeset [87490] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

LevelDB: turn on paranoid checks and verify checksums, log errors
https://bugs.webkit.org/show_bug.cgi?id=61516

This allows for detection of corrupted databases.
Even if we can't recover from a corrupted database, discovering the
problem is a step in the right direction.

No new functionality, no new tests.

  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::checkStatus): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::LevelDBDatabase::createIterator):
03:16 Changeset [87489] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark fast/canvas/webgl/uniform-location.html as timing out

02:36 Changeset [87488] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/InspectorFrontendHost.cpp

Merge 86551 - 2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062045

02:30 Changeset [87487] by apavlov@chromium.org
  • 7 edits
    2 copies in branches/chromium/742

Merge 86507 - 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062044

02:11 Changeset [87486] by rniwa@webkit.org
  • 3 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61614

Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.

  • editing/pasteboard/paste-text-002-expected.txt: Added.
  • editing/pasteboard/paste-text-002.html:
  • editing/pasteboard/paste-text-003-expected.txt: Added.
  • editing/pasteboard/paste-text-003.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
01:26 Changeset [87485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

CachedResourceLoader stores data: urls in validated URL set
https://bugs.webkit.org/show_bug.cgi?id=61604

CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource):
01:01 Changeset [87484] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(

00:56 Changeset [87483] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

2011-05-23 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] DocumentMarker should be carried around as a pointer, not value.
https://bugs.webkit.org/show_bug.cgi?id=61262

  • Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
  • Introduced markersFor() that returns Vector<DocumentMarker*>
  • Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by RenderedDocumentMarker::setRenderedRect().
  • This change didn't remove markersForNode() beucase there is patches on review which depends markersForNode(). I'll remove its call after these patches are landed.

No new tests. No behavior change.

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::markersFor): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
  • dom/DocumentMarkerController.h:
  • dom/RenderedDocumentMarker.h: (WebCore::toRenderedDocumentMarker):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
00:54 Changeset [87482] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460

00:45 Changeset [87481] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux

00:26 Changeset [87480] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary crashes
https://bugs.webkit.org/show_bug.cgi?id=61511

  • fast/html/details-summary-document-child-expected.txt: Added.
  • fast/html/details-summary-document-child.html: Added.

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511

Removed Unnecessary wrong cast to Elmement, which can be non-Element.

Test: fast/html/details-summary-document-child.html

  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::detailsElement):

05/26/11:

23:54 Changeset [87479] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Ryosuke Niwa.

FrameLoader cannot be null
https://bugs.webkit.org/show_bug.cgi?id=61609

This code has a bunch of cargo-cult null checking.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::getPluginProxyParams): (WebCore::HTMLMediaElement::createMediaPlayerProxy): (WebCore::HTMLMediaElement::updateWidget):
23:43 Changeset [87478] by rniwa@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/paste-blockquote-1.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61608

Converted paste-blockquote-1.html to a dump-as-markup test.

  • editing/pasteboard/paste-blockquote-1-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-1.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt: Removed.
23:42 Changeset [87477] by rniwa@webkit.org
  • 6 edits
    5 adds
    51 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/merge-end-*.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61607

  • editing/pasteboard/merge-end-1-expected.txt: Added.
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.txt: Added.
  • editing/pasteboard/merge-end-2.html:
  • editing/pasteboard/merge-end-3-expected.txt: Added.
  • editing/pasteboard/merge-end-3.html:
  • editing/pasteboard/merge-end-4-expected.txt: Added.
  • editing/pasteboard/merge-end-4.html:
  • editing/pasteboard/merge-end-5-expected.txt: Added.
  • editing/pasteboard/merge-end-5.html:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/gtk/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/mac/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/mac/editing/pasteboard/merge-end-5-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-1-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-2-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-3-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-4-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt: Removed.
  • platform/qt/editing/pasteboard/merge-end-5-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt: Removed.
23:40 Changeset [87476] by rniwa@webkit.org
  • 5 edits
    4 adds
    38 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Convert editing/pasteboard/interchange-newline-*.html to dump-as-markup tests.
https://bugs.webkit.org/show_bug.cgi?id=61605

Converted interchange-newline-1 thorugh 4 to dump-as-markup tests.
Also revised some test descriptions.

  • editing/pasteboard/interchange-newline-1-expected.txt: Added.
  • editing/pasteboard/interchange-newline-1.html:
  • editing/pasteboard/interchange-newline-2-expected.txt: Added.
  • editing/pasteboard/interchange-newline-2.html:
  • editing/pasteboard/interchange-newline-3-expected.txt: Added.
  • editing/pasteboard/interchange-newline-3.html:
  • editing/pasteboard/interchange-newline-4-expected.txt: Added.
  • editing/pasteboard/interchange-newline-4.html:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/gtk/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-2-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-3-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-4-expected.png: Removed.
  • platform/mac/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.png: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt: Removed.
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt: Removed.
23:28 Changeset [87475] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

  • transforms/2d/set-transform-and-top-expected.txt: Added.
  • transforms/2d/set-transform-and-top.html: Added.

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

When a transform is modified in a style, we were upgrading our understanding
of the difference from PositionedMovementOnly to SimplifiedLayout. However,
if the position of the style is independently changed at the same time, both
PositionedMovement and SimplifiedLayout passes are required.

Test: transforms/2d/set-transform-and-top.html

  • rendering/RenderObject.cpp: Added checks for SimplifiedLayoutAndPositionedMovement - when encountered, set both PositionedMovement and SimplifiedLayout update flasgs.
  • rendering/style/RenderStyleConstants.h: Added a new StyleDifference enum value (SimplifiedLayoutAndPositionedMovement) for cases when both PositionedMovement and SimplifiedLayout are required.
23:26 Changeset [87474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement webkit margin collapse CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61589

No new tests as no new functionality added.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Add handlers for: CSSPropertyWebkitMarginBeforeCollapse CSSPropertyWebkitMarginAfterCollapse CSSPropertyWebkitMarginTopCollapse CSSPropertyWebkitMarginBottomCollapse CSSPropertyWebkitMarginCollapse
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove cases that are no longer required.
23:12 Changeset [87473] by abarth@webkit.org
  • 11 edits
    8 adds in trunk

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015

Test various cases involving CORS requests and canvas tainting.

  • http/tests/security/canvas-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/canvas-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • http/tests/security/resources/abe-allow-credentials.php: Added.
  • http/tests/security/resources/abe-allow-star.php: Added.

2011-05-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support cross-origin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015

This patch add support for the crossorigin attribute of images and
teaches 2D canvas to respect that flag and not taint a canvas if the
image drawn on the canvas is allowed by CORS.

While I was editing this code, I couldn't resist a couple touch-up
changes.

Tests: http/tests/security/canvas-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/canvas-remote-read-remote-image-allowed.html
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin.html

  • html/HTMLAttributeNames.in:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::securityOrigin):
  • html/HTMLCanvasElement.h:
  • html/HTMLImageElement.idl:
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::passesAccessControlCheck):
  • loader/cache/CachedResource.h:
22:33 Changeset [87472] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    10 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/4700297.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61595

Renamed 4700297.html to insert-div-text-into-text.html and converted it into a dump-as-markup test.

  • editing/pasteboard/4700297.html: Removed.
  • editing/pasteboard/insert-div-text-into-text-expected.txt: Added.
  • editing/pasteboard/insert-div-text-into-text.html: Copied from LayoutTests/editing/pasteboard/4700297.html.
  • platform/chromium-linux/editing/pasteboard/4700297-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4700297-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/4700297-expected.png: Removed.
  • platform/gtk/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/4700297-expected.png: Removed.
  • platform/mac/editing/pasteboard/4700297-expected.png: Removed.
  • platform/mac/editing/pasteboard/4700297-expected.txt: Removed.
  • platform/qt/editing/pasteboard/4700297-expected.png: Removed.
  • platform/qt/editing/pasteboard/4700297-expected.txt: Removed.
22:31 Changeset [87471] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Hajime Morita.

editing/pasteboard/5483567.html should be renamed and converted to a dump-as-markup test.
https://bugs.webkit.org/show_bug.cgi?id=61599

Renamed 5483567.html to pasting-word-in-div-extra-line.html and converted it to
a dump-as-markup test.

  • editing/pasteboard/5483567.html: Removed.
  • editing/pasteboard/pasting-word-in-div-extra-line-expected.txt: Added.
  • editing/pasteboard/pasting-word-in-div-extra-line.html: Copied from LayoutTests/editing/pasteboard/5483567.html.
  • platform/chromium-linux/editing/pasteboard/5483567-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5483567-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5483567-expected.png: Removed.
  • platform/mac/editing/pasteboard/5483567-expected.png: Removed.
  • platform/mac/editing/pasteboard/5483567-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5483567-expected.txt: Removed.
22:29 Changeset [87470] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61597

Renamed 5089327.html to paste-into-blockquote-with-document-font-color.html and converted it
to a dump-as-markup test.

  • editing/pasteboard/5089327.html: Removed.
  • editing/pasteboard/paste-into-blockquote-with-document-font-color-expected.txt: Added.
  • editing/pasteboard/paste-into-blockquote-with-document-font-color.html: Copied from LayoutTests/editing/pasteboard/5089327.html.
  • platform/chromium-linux/editing/pasteboard/5089327-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5089327-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5089327-expected.png: Removed.
  • platform/mac/editing/pasteboard/5089327-expected.png: Removed.
  • platform/mac/editing/pasteboard/5089327-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Removed.
22:29 Changeset [87469] by mihaip@chromium.org
  • 12 edits in trunk

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8Proxy.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): (WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry):
  • page/SecurityOrigin.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
  • src/WebFrameImpl.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix worldID and destinationDomain argument names
https://bugs.webkit.org/show_bug.cgi?id=61571

As part of working on r87423, I noticed a couple of inconsistencies in
argument names:

  • We would use worldId in .h files but worldID in .cpp files. Standardize on the latter
  • SecurityOrigin::addOriginAccessWhitelistEntry would take a destinationDomains argument, even though the actual parameter was for a single domain (renamed to be singular).
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
22:27 Changeset [87468] by rniwa@webkit.org
  • 1 edit
    1 move
    2 adds
    9 deletes in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

editing/pasteboard/5027857.html should be renamed and converted to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61602

Renamed 5027857.html to paste-code-in-pre.html and converted it to a dump-as-markup test.

  • editing/pasteboard/5027857.html: Removed.
  • editing/pasteboard/paste-code-in-pre-expected.txt: Added.
  • editing/pasteboard/paste-code-in-pre.html: Copied from LayoutTests/editing/pasteboard/5027857.html.
  • platform/chromium-linux/editing/pasteboard/5027857-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5027857-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Added.
  • platform/gtk/editing/pasteboard/5027857-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/5027857-expected.png: Removed.
  • platform/mac/editing/pasteboard/5027857-expected.png: Removed.
  • platform/mac/editing/pasteboard/5027857-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5027857-expected.txt: Removed.
21:53 Changeset [87467] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-05-26 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Replace RenderLayer::x/y/width/height with location/size
https://bugs.webkit.org/show_bug.cgi?id=61414

Covered by existing tests.

  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::computeRelativePosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderBox.h: (WebCore::RenderBox::maxLayoutOverflow):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::computeRectForRepaint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::offsetFromResizeCorner): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::location): (WebCore::RenderLayer::setSize):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::writeLayers): (WebCore::externalRepresentation):
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): (WebCore::RenderView::absoluteQuads):
21:18 Changeset [87466] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148

Add a test for the case given in the bug: deleting an unstyled table
should not leave behind a style span.

Rebaseline tests now that border-collapse, -webkit-border-horizontal-spacing,
and -webkit-border-vertical-spacing style spans are no longer added on
table and table cell deletion, and no longer applied when copying to the
clipboard.

  • editing/deleting/5026848-2-expected.txt:
  • editing/deleting/5026848-3-expected.txt:
  • editing/deleting/5032066-expected.txt:
  • editing/deleting/5115601-expected.txt:
  • editing/deleting/5206311-2-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-last-char-in-table-expected.txt: Added.
  • editing/deleting/delete-last-char-in-table.html: Added. New test for bug.
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • editing/selection/4895428-1-expected.txt:
  • editing/selection/4895428-4-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148

Removes border-collapse, -webkit-border-horizontal-spacing, and
-webkit-border-vertical-spacing from the list of properties which
should be preserved during edit operations. Also renames this
list to editingInheritableProperties to be more clear about what
the list is for.

Test: editing/deleting/delete-last-char-in-table.html

  • editing/EditingStyle.cpp: Removes border vertical/horizontal spacing from editingStyleProperties.
  • editing/EditingStyle.h: Renames OnlyInheritableProperties to OnlyEditingInheritableProperties.
  • editing/markup.cpp: Renames InheritablePropertiesAndBackgroundColorInEffect.
21:14 Changeset [87465] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

editing/pasteboard/style-from-rules.html is flaky on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=61586

Don't attach an event listener to dump markup on paste when ran by DRT
because we manually dump markup in DRT.

  • editing/pasteboard/style-from-rules.html:
20:24 Changeset [87464] by yutak@chromium.org
  • 21 edits
    4 copies
    2 adds in trunk

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
19:22 Changeset [87463] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit/chromium

2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Dmitry Titov.

Add missing compile guards for WebWorkers in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=61536

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/LocalFileSystemChromium.cpp: (WebCore::openFileSystemHelper):
  • src/PlatformBridge.cpp:
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WorkerFileWriterCallbacksBridge.h:
19:16 Changeset [87462] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 David Levin <levin@chromium.org>

Reviewed by Dmitry Titov.

WebKit's font notification has problems when the WebKit main thread != UI thread.
https://bugs.webkit.org/show_bug.cgi?id=61391

This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
some time to write correctly. In the meantime, this issues happens to be causing
some crashes in Chrome so here's the fix alone for the time being.

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread. (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation. Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically, there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code. (WebCore::fontCacheATSNotificationCallback): Ditto.
19:07 Changeset [87461] by morrita@google.com
  • 47 edits
    75 adds in trunk/LayoutTests

2011-05-26 MORITA Hajime <morrita@google.com>

Unreviewed expectations update for <details>.

  • platform/chromium-linux-x86/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux-x86/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-linux/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-nested-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-nested-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/chromium-win/fast/html/details-replace-text-expected.png: Added.
  • platform/chromium-win/fast/html/details-replace-text-expected.txt: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/chromium/test_expectations.txt:
18:36 Changeset [87460] by slewis@apple.com
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Roll back in now that the Crashes are fixed. ResourceResponseBase and ResourceResponse had two different definitions
for m_isNull. ResourceResponse treats m_isNull as meaning there isn't any platform ResourceResponse.
ResourceResponseBase treats m_isNull as meaning no fields have been initialized. Consolidate calls into ResourceResponseBase meaning.

Reviewed by Geoff Garen.

Don't initialize ResourceResponse.m_suggestedFilename until we want to use it. Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse. This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

No new functionality so no new tests.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/mac/ResourceResponseMac.mm:
18:16 Changeset [87459] by koz@chromium.org
  • 4 edits in trunk

2011-05-26 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Implement a whitelist for registerProtocolHandler.

Described in the thread here
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-April/031220.html

https://bugs.webkit.org/show_bug.cgi?id=60322

  • fast/dom/register-protocol-handler.html:

2011-05-26 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Implement a whitelist for registerProtocolHandler
https://bugs.webkit.org/show_bug.cgi?id=60322

  • page/Navigator.cpp: (WebCore::initProtocolHandlerWhitelist): (WebCore::isProtocolWhitelisted): (WebCore::verifyProtocolHandlerScheme):
18:12 Changeset [87458] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebKit2

Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492

Reviewed by Darin Adler.

The method for determining which WebPage is actually focused and foreground was faulty. More
extensive checks are required to check which WebPage should be returned as the focusable one.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowIsFocused):

18:00 Changeset [87457] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Remove some passing tests from the test expectations.

  • platform/chromium/test_expectations.txt:
17:29 Changeset [87456] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-26 Jon Lee <jonlee@apple.com>

Reviewed by Darin Adler.

REGRESSION (5.0.5-Jazz): Transition to full screen video animates in wrong location when scrolled (61559)
https://bugs.webkit.org/show_bug.cgi?id=61559
<rdar://problem/9496054>

The CALayer that gets animated has a position that is offset by the scroll position of the web view. To
fix this, we set the destination location based on the rect of the full screen, and add a position
animation which keeps the position of the layer centered. This prevents glitches if others
are trying to change the layer position while the animation is running.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Refactor the calculation of the CALayer windowed position into a private helper function, as well as the animation setup.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): (WebKit::WebFullScreenManagerMac::animateFullScreen): Sets up the zoom animation, and the position offset animation. (WebKit::WebFullScreenManagerMac::windowedCGTransform): Calculates the placement of the windowed layer in screen coordinates.
17:28 Changeset [87455] by simonjam@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/html/HTMLScriptElement.cpp

Merge 87361 - 2011-05-25 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Add site-specific hack for zipcar.com with old versions of requirejs.
https://bugs.webkit.org/show_bug.cgi?id=61321

Old versions of requirejs (< 0.15.0) try to load scripts in parallel but execute them in
order. This used to work in webkit by setting a bogus script type (script/cache), then
changing the type to a valid one when they wanted to execute it. This hack translates the
behavior into the new API (by disabling forceAsync).

  • html/HTMLScriptElement.cpp: (WebCore::needsOldRequirejsQuirk): Added. (WebCore::HTMLScriptElement::insertedIntoDocument): If hack is needed, set a proper script type so script loads. If script isn't async, disable forceAsync so script executes in order.

TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/6962032

17:18 Changeset [87454] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-26 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify TestNetscapePlugIn naming logic
https://bugs.webkit.org/show_bug.cgi?id=61577

  • WebKit.gyp: drop use of product_prefix, just use the name needed directly.
17:08 Changeset [87453] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

[debug feature] CSSStyleDeclaration should have a way to print cssText
https://bugs.webkit.org/show_bug.cgi?id=61570

Adds a method to print the cssText to stderr for debugging.

  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::showStyle): New method to print cssText to stderr
  • css/CSSStyleDeclaration.h: New method declaration
17:00 Changeset [87452] by qi.2.zhang@nokia.com
  • 13 edits in trunk

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAuthorAndUserStylesEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAuthorAndUserStylesEnabled):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
https://bugs.webkit.org/show_bug.cgi?id=42676

Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
16:58 Changeset [87451] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
https://bugs.webkit.org/show_bug.cgi?id=60377

LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

For an array of active uniform, we should be careful while truncating the name of the uniform.
Currently we are truncating the last three characters of an array with out checking for [0].
As a result we are truncating the the actual name of the active uniforms i.e. color to co.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): Strip "[0]" from the name if it's an array and is part of the name.
16:47 Changeset [87450] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed heapRootMarker to heapRootVisitor to match its class name
https://bugs.webkit.org/show_bug.cgi?id=61584

  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
16:47 Changeset [87449] by adamk@chromium.org
  • 10 edits in trunk/Source

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize):
  • page/FrameView.h:

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

  • public/WebFrameClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
16:39 Changeset [87448] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some interdependency between Heap and SmallStrings by simplifying
the SmallStrings lifetime model
https://bugs.webkit.org/show_bug.cgi?id=61579


SunSpider reports no change.


Using Weak<T> could accomplish this too, but we're not sure it will give
us the performance we need. This is a first step, and it accomplishes
most of the value of using Weak<T>.

  • heap/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): (JSC::Heap::reset): Finalize small strings just like other weak handles.
  • runtime/SmallStrings.cpp: (JSC::finalize): (JSC::SmallStrings::finalizeSmallStrings):
  • runtime/SmallStrings.h: Make all small strings trivially weak, instead of having an "all for one, one for all" memory model.
16:17 Changeset [87447] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87255.

16:14 Changeset [87446] by lforschler@apple.com
  • 9 edits
    8 copies in branches/safari-534-branch/Source/WebKit2

Merge r87221.

15:58 Changeset [87445] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-05-26 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make RegExpCache a weak map
https://bugs.webkit.org/show_bug.cgi?id=61554

Switch to a weak map for the regexp cache, and hide that
behaviour behind RegExp::create.

When a RegExp is compiled it attempts to add itself to
the "strong" cache. This cache is a simple round-robin
buffer as was the old strong cache. Happily this can
be smaller than the old strong cache as RegExps are only
added when they're compiled so it is under less pressure
to evict.

  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::match):
  • runtime/RegExp.h: (JSC::RegExp::gcShouldInvalidateCode): (JSC::RegExp::hasCode): (JSC::RegExp::key):
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::RegExpCache): (JSC::RegExpCache::isReachableFromOpaqueRoots): (JSC::RegExpCache::finalize):
  • runtime/RegExpCache.h:
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
15:49 Changeset [87444] by levin@chromium.org
  • 10 edits in trunk/Source

Need a callback for when the preferred rendered size changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::contentsPreferredSizeChanged): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h: Ditto.
  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize): Added calculations for the preferred size
and the call to contentsPreferredSizeChanged.

Source/WebKit/chromium:

  • public/WebFrameClient.h

(WebKit::WebFrameClient::didChangeContentsPreferredSize): Added stub.

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added declaration.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added call to WebFrameClient::didChangeContentsPreferredSize.

15:49 Changeset [87443] by leviw@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-05-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch controlClipRect to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=60806

Switching controlClipRect to take an IntPoint representing the
offset to be added instead of a pair of ints.

No new tests as this is just refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBox.h: (WebCore::RenderBox::controlClipRect):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
  • rendering/RenderButton.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::controlClipRect):
  • rendering/RenderTextControlSingleLine.h:
15:43 Changeset [87442] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button)
https://bugs.webkit.org/show_bug.cgi?id=61569
<rdar://problem/9454315>

Reviewed by Steve Falkenburg.

Normally, when the background fullscreen window is animated in, the Windows taskbar will be hidden, but this doesn't always work for some reason.
Workaround this issue by setting the real fullscreen window to be a topmost window.

  • platform/graphics/win/FullScreenController.cpp:

(FullScreenController::Private::fullscreenClientWndProc): Exit fullscreen when m_fullScreenWindow is deactivated.
(FullScreenController::enterFullScreenRepaintCompleted): Make m_fullScreenWindow a topmost window before animating it in to ensure the taskbar is hidden.

15:43 Changeset [87441] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved Heap-related functions out of JSCell.h and into respective header files
https://bugs.webkit.org/show_bug.cgi?id=61567

  • heap/Heap.h: (JSC::Heap::allocate): (JSC::Heap::heap):
  • heap/MarkedBlock.h: (JSC::MarkedBlock::allocate):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::sizeClassFor): (JSC::MarkedSpace::allocate):
  • runtime/JSCell.h: (JSC::JSCell::destructor):
15:37 Changeset [87440] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Windows build.

15:30 Changeset [87439] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-05-26 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[skia] Add area check to ImageBufferData::getImageData
https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData):
15:09 Changeset [87438] by rniwa@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

[debug feature] WTFString should have show() method
https://bugs.webkit.org/show_bug.cgi?id=61149

Added String::show and AtomicString::show in NDEBUG.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::show):
  • wtf/text/AtomicString.h:
  • wtf/text/WTFString.cpp: (String::show):
  • wtf/text/WTFString.h:
15:06 Changeset [87437] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch positionOverflowControls to IntSize
https://bugs.webkit.org/show_bug.cgi?id=61493

Switching positionOverflowControls to take a layerOffset IntSize
as opposed to a pair of ints.

No new tests since this is just refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls):
  • rendering/RenderLayer.h:
14:58 Changeset [87436] by ademar.reis@openbossa.org
  • 2 edits in trunk/Tools

2011-05-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser "Switch User Agent" dialog is broken
https://bugs.webkit.org/show_bug.cgi?id=61527

The setMaximumHeight() call is unecessary and breaks the dialog at
least on my setup.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::showUserAgentDialog):
14:50 Changeset [87435] by adamk@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Add Leopard rebaseline.

  • platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
14:46 Changeset [87434] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Factored out some Heap ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=61565

  • JavaScriptCore.exp:
  • heap/Heap.cpp: (JSC::isValidSharedInstanceThreadState): (JSC::isValidThreadState): (JSC::Heap::markRoots): (JSC::Heap::isValidAllocation):
  • heap/Heap.h:
  • runtime/JSCell.h: (JSC::JSCell::Heap::allocate):
14:43 Changeset [87433] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-26 Gustavo Noronha Silva <gustavo.noronha@collabora.com>

Reviewed by Martin Robinson.

Cleanup postCommitFrameViewSetup parameters which are no longer
necessary after the adjustments handling refactoring.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
14:39 Changeset [87432] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564

Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).

  • transforms/2d/set-transform-and-top-expected.txt: Removed.
  • transforms/2d/set-transform-and-top.html: Removed.

2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87368.
http://trac.webkit.org/changeset/87368
https://bugs.webkit.org/show_bug.cgi?id=61564

Wrong approach, will do the wrong thing if the element needs
simplified normal flow layout but is not positioned (Requested
by jamesr on #webkit).

  • rendering/RenderObject.h: (WebCore::RenderObject::needsPositionedMovementLayout):
14:37 Changeset [87431] by barraclough@apple.com
  • 9 edits
    2 adds in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=61508
DFG JIT - Add support for get by id self caching.

Reviewed by Geoff Garen.

Change the call out to be an unexpected call (using silent spill/fill functions),
add a structure check & compact load to the JIT code, and add repatching mechanisms.
Since DFGOperations may want to be be implemented in asm, make these symbols be extern
"C". Add an asm wrapper to pass the return address to the optimizing get-by-id operation,
so that it can look up its StructureStubInfo.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files.
  • bytecode/StructureStubInfo.h:
    • Added 'unset' entries to union.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheck):

  • Return the call, we need this to populate the StructureStubInfo.
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • Populate the CodebBlock's StructureStubInfo Vector.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):

  • Return the call, we need this to populate the StructureStubInfo.

(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

  • Add structures to record property access info during compilation.
  • dfg/DFGOperations.cpp:
    • Made all external methods extern "C".

(JSC::DFG::operationPutByValInternal):

  • Moved outside of the extern "C" block.
  • dfg/DFGOperations.h:
    • Made all external methods extern "C".
  • dfg/DFGRepatch.cpp: Added.

(JSC::DFG::dfgRepatchCall):

  • repatch a call to link to a new callee function.

(JSC::DFG::dfgRepatchGetByIdSelf):

  • Modify the JIT code to optimize self accesses.

(JSC::DFG::tryCacheGetByID):

  • Internal implementation of dfgRepatchGetByID (factor out failing cases).

(JSC::DFG::dfgRepatchGetByID):

  • Used to optimize 'operationGetByIdOptimize' - repatches to 'operationGetById', and tries to optimize self accesses!
  • dfg/DFGRepatch.h: Added.
    • Expose dfgRepatchGetByID.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Changed implementation of GetById ops.
14:36 Changeset [87430] by mrowe@apple.com
  • 1 delete in trunk/Source/JavaScriptCore.xcworkspace

Remvoe the directory too, since I apparently forgot the magic git-svn argument to clean up empty directories.

14:04 Changeset [87429] by robert@webkit.org
  • 7 edits
    1 add in trunk

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

  • platform/qt/Skipped: Unskip plugin-initiate-popup-window.html
  • platform/qt/plugins/plugin-initiate-popup-window-expected.txt: Copied from LayoutTests/platform/mac/plugins/plugin-initiate-popup-window-expected.txt.
  • plugins/plugin-initiate-popup-window.html: Plugins are only windowless

by default on OSX, so make the plugins windowless explicitly.

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

If the event is from a user gesture and the plugin doesn't support
NPN_PushPopupsEnabledState() and NPN_PopPopupsEnabledState(), allow popups.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent):

2011-05-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Roben.

[Qt] Allow popup windows from plugins when initiated by a user gesture

https://bugs.webkit.org/show_bug.cgi?id=41292

Support parameters introduced in plugin-initiate-popup-window.html

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_handle_event):
13:49 Changeset [87428] by mrowe@apple.com
  • 1 delete in trunk/Source/JavaScriptCore.xcworkspace/contents.xcworkspacedata

Remove a bogus .xcworkspace file that was checked in and is causing problems with tab completion.

13:39 Changeset [87427] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled back in http://trac.webkit.org/changeset/87408 with Windows build fixed.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:
  • wtf/DoublyLinkedList.h:

(WTF::::DoublyLinkedListNode):
(WTF::::setPrev):
(WTF::::setNext):
(WTF::::prev):
(WTF::::next):
(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead):

13:31 Changeset [87426] by lforschler@apple.com
  • 9 edits in branches/safari-534-branch/Source/WebKit2

Rollout 87420, messed up merge.

13:30 Changeset [87425] by lforschler@apple.com
  • 1 edit in branches/safari-534-branch/Source/WebKit2/ChangeLog

Rollout 87422, messed up merge.

13:09 Changeset [87424] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Dmitry Titov.

[V8] Add missing compile guards for WebWorkers in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=61535

No new tests - refactoring only.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
12:53 Changeset [87423] by mihaip@chromium.org
  • 25 edits
    3 adds in trunk

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Add test for doing a cross-origin XHR in an isolated world via
setIsolatedWorldSecurityOrigin and addOriginAccessWhitelistEntry.

Skipped on JSC ports.

  • http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt: Added.
  • http/tests/security/isolatedWorld/cross-origin-xhr.html: Added.
  • http/tests/security/isolatedWorld/resources/cross-origin-xhr.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Allows isolated worlds to be associated with a different SecurityOrigin
(exposed as a setIsolatedWorldSecurityOrigin function in
ScriptController).

The XMLHttpRequest constructor can then check that it's being
instantiated in an isolated world and use its security origin.
XMLHttpRequest, ThreadableLoader and DocumentThreadableLoader had to be
changed to use the copied SecurityOrigin instead of always grabbing the
Document's.

Test: http/tests/security/isolatedWorld/cross-origin-xhr.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::setSecurityOrigin):
  • bindings/v8/V8IsolatedContext.h: (WebCore::V8IsolatedContext::securityOrigin):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setIsolatedWorldSecurityOrigin): (WebCore::V8Proxy::resetIsolatedWorlds):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::isAllowedRedirect): (WebCore::DocumentThreadableLoader::securityOrigin):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::create): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::securityOrigin): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader):
  • xml/XMLHttpRequest.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Expose setIsolatedWorldSecurityOrigin in the WebFrame API.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
  • src/WebFrameImpl.h:

2011-05-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support cross-origin XMLHttpRequest in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=59843

Expose setIsolatedWorldSecurityOrigin in LayoutTestController.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setIsolatedWorldSecurityOrigin):
  • DumpRenderTree/chromium/LayoutTestController.h:
12:50 Changeset [87422] by lforschler@apple.com
  • 1 edit in branches/safari-534-branch/Source/WebKit2/ChangeLog

Merge r87255.

12:48 Changeset [87421] by bweinstein@apple.com
  • 7 edits in trunk

WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=61474
<rdar://problem/9468337>

Reviewed by Adam Roben.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::statusBarIsVisible): Call the function on the client

if it exists.

(WebKit::InjectedBundlePageUIClient::menuBarIsVisible): Ditto.
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible): Ditto.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::statusbarVisible): Add a possible short-circuit in the injected bundle.
(WebKit::WebChromeClient::menubarVisible): Ditto.
(WebKit::WebChromeClient::toolbarsVisible): Ditto.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.

12:46 Changeset [87420] by lforschler@apple.com
  • 9 edits in branches/safari-534-branch/Source/WebKit2

Merge r87221.

12:43 Changeset [87419] by michaeln@google.com
  • 5 edits in trunk/Source

2011-05-26 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417

  • src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):

2011-05-26 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

[Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
collection of open databases. Otherwise we can fail to lookup databases when
trying to forceably close them via WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=61417

New new functionality, no tests.

  • storage/DatabaseTracker.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::getOpenDatabases): (WebCore::DatabaseTracker::interruptAllDatabasesForContext):
12:42 Changeset [87418] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Suppress more flaky Linux tests.

  • platform/chromium/test_expectations.txt:
12:36 Changeset [87417] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-26 Sailesh Agrawal <sail@chromium.org>

Reviewed by Tony Chang.

Expose willStartLiveResize and willEndLiveResize in WebWidget
https://bugs.webkit.org/show_bug.cgi?id=60518

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::willStartLiveResize): (WebKit::WebPopupMenuImpl::willEndLiveResize):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::willStartLiveResize): (WebKit::WebViewImpl::willEndLiveResize):
  • src/WebViewImpl.h:
12:34 Changeset [87416] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled out http://trac.webkit.org/changeset/87408 because it broke the
Windows build.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::setPrev):
(JSC::MarkedBlock::setNext):
(JSC::MarkedBlock::prev):
(JSC::MarkedBlock::next):

  • wtf/DoublyLinkedList.h:

(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::head):
(WTF::::append):
(WTF::::remove):

12:33 Changeset [87415] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Suppress flaky timeouts and crashes in a few tests.

  • platform/chromium/test_expectations.txt:
12:30 Changeset [87414] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

2011-05-25 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Safari Web Content crashes while entering/exiting the full screen mode of the video content
https://bugs.webkit.org/show_bug.cgi?id=61498

No new tests, as DRT does not currently animate the full screen transition.

To guard against m_fullScreenRenderer being called after it has been deleted, add
code in RenderFullScreen which notifies the document when its full-screen renderer
will be destroyed.

Also, add some sanity checks when accessing the full-screen renderer's layer backing.

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Guard against a missing

full-screen renderer layer.

(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Added ASSERT.
(WebCore::Document::fullScreenRendererDestroyed): Added.
(WebCore::Document::setAnimatingFullScreen): Guard against the full-screen

element having been removed from the document.

  • dom/Document.h:
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::destroy): Added. Tell the Document that it's full-screen

renderer is about to be destroyed.

  • rendering/RenderFullScreen.h:
12:26 Changeset [87413] by andreas.kling@nokia.com
  • 2 edits in trunk/Tools

2011-05-26 Andreas Kling <kling@webkit.org>

Unreviewed, correct address to webkit-committers mailing list.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
12:25 Changeset [87412] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Geoffrey Garen.

Overload resolution in generated JSC bindings could be more efficient.
https://bugs.webkit.org/show_bug.cgi?id=61544

Only fetch the arguments once, and not until they are needed (less work
in the case of an early return.)

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined. (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
12:23 Changeset [87411] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/JavaScriptCore

Merge r87157.

12:14 Changeset [87410] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Remove test expectations for now-passing tests.

  • platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.
12:06 Changeset [87409] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-05-26 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Be robust to empty viewports in the compositor
https://bugs.webkit.org/show_bug.cgi?id=61545

It's possible for a frame to be requested to be drawn before it is
non-empty. The compositor should be robust to that possibility. The
changes in LayerTilerChromium are the only required changes to handle
this, but having an early out in LayerRendererChromium seemed like a
good sanity check.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::draw):
11:54 Changeset [87408] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Filled out some features in DoublyLinkedList
https://bugs.webkit.org/show_bug.cgi?id=61549

  • heap/MarkedBlock.h: Use DoublyLinkedListNode to simplify our class definition.
  • wtf/DoublyLinkedList.h: (WTF::::DoublyLinkedListNode): (WTF::::setPrev): (WTF::::setNext): (WTF::::prev): (WTF::::next): Added a helper base class for being a node in a list. The odd idioms here allow subclasses to choose their own data member layout, which is sometimes important for performance.

(WTF::::DoublyLinkedList):
(WTF::::isEmpty):
(WTF::::size):
(WTF::::clear):
(WTF::::head):
(WTF::::append):
(WTF::::remove):
(WTF::::removeHead): Change "Node" to "T" to be more idiomatic, and added
clear(), removeHead(), and size() functions.

11:46 Changeset [87407] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderObject to use FloatPoint::scale and FloatQuad::scale
https://bugs.webkit.org/show_bug.cgi?id=61497

Covered by existing test.

  • platform/graphics/FloatQuad.h: (WebCore::FloatQuad::scale):
  • rendering/RenderObject.h: (WebCore::adjustFloatQuadForAbsoluteZoom): (WebCore::adjustFloatRectForAbsoluteZoom): (WebCore::adjustFloatQuadForPageScale): (WebCore::adjustFloatRectForPageScale):
11:43 Changeset [87406] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Provide a real owner when copying a property table, for the sake of
write barriers.
https://bugs.webkit.org/show_bug.cgi?id=61547


No test because we can't enable the writeBarrier() ASSERT just yet.

  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition):
11:34 Changeset [87405] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source

2011-05-26 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix for Qt and QuickTime backend.

r87328 added a new system interface, we need to add it too.

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):

2011-05-26 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix for Qt and QuickTime backend.

r87328 added a new system interface, we need to add it too.

  • platform/qt/WebCoreSystemInterface.h:
  • platform/qt/WebCoreSystemInterface.mm:
11:28 Changeset [87404] by adamk@chromium.org
  • 2 edits
    36 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaselines for SVG tests added in r87284.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:22 Changeset [87403] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-26 Ryosuke Niwa <rniwa@webkit.org>

GTK & Qt rebaselines for r87400.

  • platform/gtk/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
11:15 Changeset [87402] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipping 3 new inspector tests on mac-wk2, see http://webkit.org/b/61437

  • platform/mac-wk2/Skipped:
11:11 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:10 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
11:05 Changeset [87401] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Unreviewed follow-up to r87395, added checks to avoid accessing undefined member for certain timeline events.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord):
10:49 Changeset [87400] by rniwa@webkit.org
  • 11 edits
    2 adds in trunk

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466

Fixed the bug by removing duplicate properties from inline style declarations in ReplaceSelectionCommand.
Also moved the code to obtain style from rules from markup.cpp to EditingStyle.cpp to share code.

Test: editing/pasteboard/style-from-rules.html

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added a null check. (WebCore::EditingStyle::extractFontSizeDelta): Ditto. (WebCore::styleFromMatchedRulesForElement): Moved from markup.cpp. (WebCore::EditingStyle::mergeStyleFromRules): Extracted from StyledMarkupAccumulator::appendElement. (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Ditto. (WebCore::EditingStyle::removeStyleFromRules): Added.
  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Renamed from negateStyleRulesThatAffectAppearance; Calls removeStyleFromRules.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement): Calls mergeStyleFromRulesForSerialization. (WebCore::styleFromMatchedRulesAndInlineDecl): Calls mergeStyleFromRules; changed the return type from CSSMutableStyleDeclaration to EditingStyle. (WebCore::isElementPresentational): Calls styleFromMatchedRulesAndInlineDecl. (WebCore::shouldIncludeWrapperForFullySelectedRoot): Ditto. (WebCore::highestAncestorToWrapMarkup): Calls shouldIncludeWrapperForFullySelectedRoot. (WebCore::createMarkup): Calls styleFromMatchedRulesAndInlineDecl.

2011-05-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

WebKit duplicates styles from css rules on copy and paste
https://bugs.webkit.org/show_bug.cgi?id=61466

Added a test to ensure Webkit does not leave redundant inline style declarations after paste.
Also rebaselined several tests that progressed.

  • editing/pasteboard/4922709-expected.txt:
  • editing/pasteboard/5780697-2-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/style-from-rules-expected.txt: Added.
  • editing/pasteboard/style-from-rules.html: Added.
  • platform/chromium-win/editing/pasteboard/5780697-2-expected.txt:
10:16 Changeset [87399] by caseq@chromium.org
  • 13 edits
    1 add in trunk

2011-05-26 Michael Schneider <michschn@google.com>

Reviewed by Pavel Feldman.

WebInspector: Added API to access the timeline data in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._addRecordToTimeline): (WebInspector.ExtensionServer.prototype._onSubscribe): (WebInspector.ExtensionServer.prototype._onUnsubscribe): (WebInspector.ExtensionServer.prototype._registerHandler): (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
  • inspector/front-end/TimelineManager.js: Added. (WebInspector.TimelineManager): (WebInspector.TimelineManager.prototype.start): (WebInspector.TimelineManager.prototype.stop): (WebInspector.TimelineDispatcher): (WebInspector.TimelineDispatcher.prototype.started): (WebInspector.TimelineDispatcher.prototype.stopped): (WebInspector.TimelineDispatcher.prototype.eventRecorded):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked): (WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-05-26 Michael Schneider <michschn@google.com>

Reviewed by Pavel Feldman.

WebInspector: Added tests for timeline data API in a inspector extension.
https://bugs.webkit.org/show_bug.cgi?id=61098

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-events-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.startTimeline): (initialize_Timeline.InspectorTest.stopTimeline):
10:11 Changeset [87398] by adamk@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Added baselines after r87387.

  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-win-vista/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed override.
10:05 Changeset [87397] by sfalken@apple.com
  • 2 edits
    18 deletes in trunk/Source/WebKit2

2011-05-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512


Better fix for this. We just need to specify CFBundleAllowMixedLocalizations.

  • win/WebKit2WebProcess.resources/English.lproj: Removed.
  • win/WebKit2WebProcess.resources/Info.plist:
  • win/WebKit2WebProcess.resources/da.lproj: Removed.
  • win/WebKit2WebProcess.resources/de.lproj: Removed.
  • win/WebKit2WebProcess.resources/es.lproj: Removed.
  • win/WebKit2WebProcess.resources/fi.lproj: Removed.
  • win/WebKit2WebProcess.resources/fr.lproj: Removed.
  • win/WebKit2WebProcess.resources/it.lproj: Removed.
  • win/WebKit2WebProcess.resources/ja.lproj: Removed.
  • win/WebKit2WebProcess.resources/ko.lproj: Removed.
  • win/WebKit2WebProcess.resources/nb.lproj: Removed.
  • win/WebKit2WebProcess.resources/nl.lproj: Removed.
  • win/WebKit2WebProcess.resources/pl.lproj: Removed.
  • win/WebKit2WebProcess.resources/pt.lproj: Removed.
  • win/WebKit2WebProcess.resources/pt_PT.lproj: Removed.
  • win/WebKit2WebProcess.resources/ru.lproj: Removed.
  • win/WebKit2WebProcess.resources/sv.lproj: Removed.
  • win/WebKit2WebProcess.resources/zh_CN.lproj: Removed.
  • win/WebKit2WebProcess.resources/zh_TW.lproj: Removed.
09:56 Changeset [87396] by adamk@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-26 Adam Klein <adamk@chromium.org>

Unreviewed. Test expectations update/rebaseline.

  • platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium/test_expectations.txt: BUGCR84052, border-antialiasing.html IMAGE+TEXT.
09:36 Changeset [87395] by caseq@chromium.org
  • 5 edits in trunk

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529

Do not modify input timeline data when processing timeline event.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._refreshDetails): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

2011-05-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
https://bugs.webkit.org/show_bug.cgi?id=61529

Do not modify input timeline data when processing timeline event.

  • inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt
09:35 Changeset [87394] by sfalken@apple.com
  • 2 edits
    19 adds in trunk/Source/WebKit2

2011-05-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 bundle missing localization subdirectories
https://bugs.webkit.org/show_bug.cgi?id=61512
<rdar://problem/9498607>


These lproj directories are intentionally left empty.
Their presence indicates that this exe is localized to this
set of languages.

  • win/WebKit2WebProcess.resources/English.lproj: Added.
  • win/WebKit2WebProcess.resources/da.lproj: Added.
  • win/WebKit2WebProcess.resources/de.lproj: Added.
  • win/WebKit2WebProcess.resources/es.lproj: Added.
  • win/WebKit2WebProcess.resources/fi.lproj: Added.
  • win/WebKit2WebProcess.resources/fr.lproj: Added.
  • win/WebKit2WebProcess.resources/it.lproj: Added.
  • win/WebKit2WebProcess.resources/ja.lproj: Added.
  • win/WebKit2WebProcess.resources/ko.lproj: Added.
  • win/WebKit2WebProcess.resources/nb.lproj: Added.
  • win/WebKit2WebProcess.resources/nl.lproj: Added.
  • win/WebKit2WebProcess.resources/pl.lproj: Added.
  • win/WebKit2WebProcess.resources/pt.lproj: Added.
  • win/WebKit2WebProcess.resources/pt_PT.lproj: Added.
  • win/WebKit2WebProcess.resources/ru.lproj: Added.
  • win/WebKit2WebProcess.resources/sv.lproj: Added.
  • win/WebKit2WebProcess.resources/zh_CN.lproj: Added.
  • win/WebKit2WebProcess.resources/zh_TW.lproj: Added.
  • win/WebKit2WebProcessPostBuild.cmd: Copy entire resources directory, exclude .svn directories.
  • win/xcopy.excludes: Added. Excludes .svn directories.
09:32 April 2011 Meeting edited by aroben@apple.com
Added link to spreadsheet of bugs filed in the reducing test failures … (diff)
09:32 Changeset [87393] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-26 Tony Chang <tony@chromium.org>

Unreviewed, fixing the expected results for a test that had the
output duplicated.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
09:13 Changeset [87392] by rwlbuis@webkit.org
  • 4 edits
    6 adds in trunk

2011-05-26 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028

Tests: svg/animations/animate-insert-begin.html

svg/animations/animate-insert-no-begin.html

Move animation initializing and rescheduling to insertedIntoDocument. This way animate elements
dynamicaly inserted into the document using js start as well.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument):
  • svg/animation/SVGSMILElement.h:

2011-05-26 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

Dynamically created <animate> elements do not animate upon document insertion as they should
https://bugs.webkit.org/show_bug.cgi?id=20028

Add tests for dynamically inserting <animate>.

  • svg/animations/animate-insert-begin-expected.txt: Added.
  • svg/animations/animate-insert-begin.html: Added.
  • svg/animations/animate-insert-no-begin-expected.txt: Added.
  • svg/animations/animate-insert-no-begin.html: Added.
  • svg/animations/script-tests/animate-insert-begin.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/animate-insert-no-begin.js: Added. (sample1): (sample2): (executeTest):
09:08 Changeset [87391] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-26 Chang Shu <cshu@webkit.org>

Unreviewed.

[Qt] http/tests/websocket/tests/reload-crash.html fails intermittently with time out
https://bugs.webkit.org/show_bug.cgi?id=50152

Unskip the test case as it's not reproducible. Will watch the buildbot results.

  • platform/qt/Skipped: Unskip http/tests/websocket/tests/reload-crash.html
09:05 Changeset [87390] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

JSC DOM bindings: ExecState::argumentCount() is size_t, not int.
https://bugs.webkit.org/show_bug.cgi?id=61530

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
08:56 Changeset [87389] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

2011-05-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Some repeating linear gradients look wrong
https://bugs.webkit.org/show_bug.cgi?id=61371

Test: fast/gradients/css3-repeating-linear-gradients2.html

Fix incorrect stop duplication code when filling forwards a repeating
gradient. The "if (srcStopOrdinal < originalNumStops - 1)" test was wrong
because srcStopOrdinal had been adjusted for stops added by start-filling,
but originalNumStops had not. Fix by considering srcStopOrdinal as an index
into the original stops, so comparing it with originalNumStops remains valid.

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
08:54 Changeset [87388] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: In network panel, show transfer size in a first line of resource row.
https://bugs.webkit.org/show_bug.cgi?id=61354

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
08:34 Changeset [87387] by simon.fraser@apple.com
  • 5 edits
    3 adds in trunk

2011-05-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Always antialias borders, outlines and rules when scaling
https://bugs.webkit.org/show_bug.cgi?id=61502

r84273 changed the behavior of drawLineForBoxSide() to never antialias by default.
This actually disabled antialiasing in some circumstances where it used to be enabled,
for example collapsed table border drawing.

Fix by allowing antialiasing for collapsed table borders, column rules and span
outlines when the context is scaled.

Test: fast/borders/border-antialiasing.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintCollapsedBorder):
08:01 Changeset [87386] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed. Mark inspector/profiler/cpu-profiler-profiling.html as flaky on Linux

07:54 Changeset [87385] by ossy@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

[Qt][WK2] Update expected files after r87320.

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Added.
07:35 Changeset [87384] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove test cases related to layoutTestController.dumpBackForwardList from qt-wk2/Skipped
https://bugs.webkit.org/show_bug.cgi?id=61462

WebKitTestRunner already support layoutTestController.dumpBackForwardList from r70723.

  • platform/qt-wk2/Skipped:
07:28 Changeset [87383] by yurys@chromium.org
  • 9 edits in trunk

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

  • inspector/debugger/source-frame.html:

2011-05-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView): (WebInspector.NetworkItemView._contentViewForResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get messages): (WebInspector.Resource.prototype.addMessage): (WebInspector.Resource.prototype.set errors): (WebInspector.Resource.prototype.set warnings): (WebInspector.Resource.prototype.clearErrorsAndWarnings):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.hasTextContent): (WebInspector.ResourceView.nonSourceViewForResource): (WebInspector.ResourceSourceFrame): (WebInspector.ResourceSourceFrame.mimeTypeForResource): (WebInspector.ResourceSourceFrame.prototype.requestContent): (WebInspector.ResourceSourceFrame.prototype.suggestedFileName): (WebInspector.EditableResourceSourceFrame): (WebInspector.EditableResourceSourceFrame.prototype.doubleClick): (WebInspector.EditableResourceSourceFrame.prototype.editContent): (WebInspector.EditableResourceSourceFrame.prototype.cancelEditing): (WebInspector.EditableResourceSourceFrame.prototype.afterTextChanged): (WebInspector.EditableResourceSourceFrame.prototype._clearIncrementalUpdateTimer): (WebInspector.ResourceRevisionSourceFrame): (WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._resourceViewForResource): (WebInspector.ResourcesPanel.prototype._showRevisionView): (WebInspector.ResourcesPanel.prototype._sourceViewForRevision): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision): (WebInspector.ResourcesPanel.prototype._findTreeElementForRevision.getParent): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype.onattach): (WebInspector.FrameResourceTreeElement.prototype._updateErrorsAndWarningsBubbles): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsCleared): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsMessageAdded): (WebInspector.FrameResourceTreeElement.prototype._appendRevision): (WebInspector.FrameResourceTreeElement.prototype.sourceView): (WebInspector.FrameResourceTreeElement.prototype._createSourceView): (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent): (WebInspector.ResourceRevisionTreeElement.prototype.sourceView):
07:01 Changeset [87382] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] http/tests/eventsource/workers/eventsource-simple.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=61523

  • platform/gtk/Skipped:
06:28 Changeset [87381] by philn@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
06:20 Changeset [87380] by aroben@apple.com
  • 2 edits in trunk/Tools

Don't assume that builds finish in the order they were started

Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
build when one slave is taking a long time to finish a build

Reviewed by Antti Koivisto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
newer than the oldest in-progress build are also themselves in progress. Just check whether
each build is actually in progress (as signified by its presence in the currentBuilds set).

05:54 Changeset [87379] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update. Mark 3 tests as flaky

05:48 Changeset [87378] by aroben@apple.com
  • 3 edits in trunk/Tools

Correctly detect cases where only a single test failed/crashed/timed out

Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
failing test

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
will be singular when only a single test fails/crashes/times out.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
failed/crashed/timed out.

05:45 Changeset [87377] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r87346

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Fixed up exports to match

reality.

05:20 Changeset [87376] by philn@webkit.org
  • 1 edit
    29 deletes in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, rollout of r87373 and r87375. Those commits were
mistaken. I'll properly land the baselines later on.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-actual.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-diffs.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-expectted.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-stderr.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-actual.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-diffs.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
  • platform/gtk/fast/css/box-shadow-and-border-radius-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-actual.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-diffs.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Removed.
  • platform/gtk/fast/html/details-add-details-child-2-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-actual.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-diffs.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Removed.
  • platform/gtk/fast/html/details-replace-summary-child-pretty-diff.html.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-actual.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-diffs.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Removed.
  • platform/gtk/fast/html/details-replace-text-pretty-diff.html.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-actual.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-diffs.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-pretty-diff.html.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-actual.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-diffs.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-pretty-diff.html.txt: Removed.
05:09 Changeset [87375] by mnaganov@chromium.org
  • 7 moves in trunk/LayoutTests/platform/gtk

Unreviewed. Rename .html files from r87374 to .html.txt to avoid confusion with tests

04:46 Changeset [87374] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

JSC DOM bindings: Use isUndefinedOrNull() instead of (isNull()
isUndefined()).

https://bugs.webkit.org/show_bug.cgi?id=61472

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined. (WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
03:53 Changeset [87373] by philn@webkit.org
  • 1 edit
    29 adds in trunk/LayoutTests

2011-05-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/box-shadow/scaled-box-shadow-actual.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-diffs.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-pretty-diff.html: Added.
  • platform/gtk/fast/box-shadow/scaled-box-shadow-stderr.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-actual.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-diffs.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-and-border-radius-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-add-details-child-2-actual.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-diffs.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-add-details-child-2-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-replace-summary-child-actual.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-diffs.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-summary-child-pretty-diff.html: Added.
  • platform/gtk/fast/html/details-replace-text-actual.txt: Added.
  • platform/gtk/fast/html/details-replace-text-diffs.txt: Added.
  • platform/gtk/fast/html/details-replace-text-expected.txt: Added.
  • platform/gtk/fast/html/details-replace-text-pretty-diff.html: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-actual.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-diffs.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-pretty-diff.html: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-actual.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-diffs.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-pretty-diff.html: Added.
02:58 Changeset [87372] by keishi@webkit.org
  • 6 edits
    4 adds in trunk

2011-05-26 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Add <input type=color> appearance.
https://bugs.webkit.org/show_bug.cgi?id=61275

  • fast/forms/color/input-appearance-color.html: Added. Tests appearance of input type=color.
  • platform/chromium/test_expectations.txt: Expect FAIL for fast/forms/color
  • platform/mac/fast/forms/color/input-appearance-color-expected.png: Added.
  • platform/mac/fast/forms/color/input-appearance-color-expected.txt: Added.

2011-05-26 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Add <input type=color> appearance.
https://bugs.webkit.org/show_bug.cgi?id=61275

Test: fast/forms/color/input-appearance-color.html

  • css/html.css: (input[type="color"]): Adds square-button appearance. (input[type="color"]::-webkit-color-swatch-wrapper): (input[type="color"]::-webkit-color-swatch): (input[type="color"][list]): Adds menulist appearance. (input[type="color"][list]::-webkit-color-swatch-wrapper): (input[type="color"][list]::-webkit-color-swatch):
  • html/ColorInputType.cpp: (WebCore::ColorInputType::createShadowSubtree): Creates -webkit-color-swatch inside -webkit-color-swatch-wrapper. (WebCore::ColorInputType::updateColorSwatch): Updates background color of shadowColorSwatch. (WebCore::ColorInputType::valueChanged): Calls updateColorSwatch. (WebCore::ColorInputType::shadowColorSwatch): Gets shadowColorSwatch element.
  • html/ColorInputType.h: (WebCore::ColorInputType::ColorInputType): Changed to inherit InputType.
02:10 Changeset [87371] by tkent@chromium.org
  • 11 edits
    2 adds in trunk

2011-05-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bug that <input type="number"> dispatches two blurs when tabbing
from an invalid number
https://bugs.webkit.org/show_bug.cgi?id=59071

  • fast/forms/input-number-blur-twice-expected.txt: Added.
  • fast/forms/input-number-blur-twice.html: Added.

2011-05-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a bug that <input type="number"> dispatches two blurs when tabbing
from an invalid number
https://bugs.webkit.org/show_bug.cgi?id=59071

NumberInputType::handleBlurEvent() dispatched an extra focus event
and an extra blur event because
SelectionController::textWillBeReplaced() called by
RenderTextControlSingleLine::updateFromElement() focuses a node
with the selection.

In order to avoid this problem,

  • Introduce Node::willBlur() It is called before any state changes by a blur event.
  • Call RenderTextControlSingleLine::updateFromElement() in willBlur() It avoids extra focus/blur events because Document::m_focusedNode is still the number input during willBlur().

Test: fast/forms/input-number-blur-twice.html

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Calls Node::beforeBlueEvent().
  • dom/Node.cpp: (WebCore::Node::willBlur): Default empty implementation of willBlur().
  • dom/Node.h: Declare willBlur().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willBlur): Added. It just calls InputType::willBlur(). (WebCore::HTMLInputElement::handleBlurEvent): Removed InputType::handleBlurEvent() call.
  • html/HTMLInputElement.h: Declare willBlur().
  • html/InputType.cpp: (WebCore::InputType::willBlur): Default empty implementation. (WebCore::InputType::handleBlurEvent): Removed.
  • html/InputType.h: Declare willBlur(), remove handleBlurEvent().
  • html/NumberInputType.cpp: (WebCore::NumberInputType::willBlur): Move the code in handleBlurEvent() here.
  • html/NumberInputType.h: Declare willBlur().
01:48 Changeset [87370] by hans@chromium.org
  • 12 edits
    1 copy
    1 move
    2 adds in trunk/Source/WebCore

2011-05-25 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Support LevelDB transactions.
https://bugs.webkit.org/show_bug.cgi?id=61270

Introduce LevelDBTransaction, which implements in-memory transaction
support on top of LevelDB, and hook this up for IndexedDB to use.

This is all covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::IteratorImpl): (WebCore::IteratorImpl::isValid): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::IteratorImpl::key): (WebCore::IteratorImpl::value): (WebCore::LevelDBDatabase::createIterator): (WebCore::LevelDBDatabase::comparator):
  • platform/leveldb/LevelDBDatabase.h:
  • platform/leveldb/LevelDBIterator.h: (WebCore::LevelDBIterator::~LevelDBIterator):
  • platform/leveldb/LevelDBTransaction.cpp: Added. (WebCore::LevelDBTransaction::create): (WebCore::LevelDBTransaction::LevelDBTransaction): (WebCore::LevelDBTransaction::clearTree): (WebCore::LevelDBTransaction::~LevelDBTransaction): (WebCore::makeVector): (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::put): (WebCore::LevelDBTransaction::remove): (WebCore::LevelDBTransaction::get): (WebCore::LevelDBTransaction::commit): (WebCore::LevelDBTransaction::rollback): (WebCore::LevelDBTransaction::createIterator): (WebCore::LevelDBTransaction::TreeIterator::create): (WebCore::LevelDBTransaction::TreeIterator::isValid): (WebCore::LevelDBTransaction::TreeIterator::seekToLast): (WebCore::LevelDBTransaction::TreeIterator::seek): (WebCore::LevelDBTransaction::TreeIterator::next): (WebCore::LevelDBTransaction::TreeIterator::prev): (WebCore::LevelDBTransaction::TreeIterator::key): (WebCore::LevelDBTransaction::TreeIterator::value): (WebCore::LevelDBTransaction::TreeIterator::isDeleted): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::create): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::isValid): (WebCore::LevelDBTransaction::TransactionIterator::seekToLast): (WebCore::LevelDBTransaction::TransactionIterator::seek): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes): (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToSmallestKey): (WebCore::LevelDBTransaction::TransactionIterator::setCurrentIteratorToLargestKey): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::resetIterators):
  • platform/leveldb/LevelDBTransaction.h: Added. (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_less): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_less): (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_greater): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_greater): (WebCore::LevelDBTransaction::AVLTreeAbstractor::get_balance_factor): (WebCore::LevelDBTransaction::AVLTreeAbstractor::set_balance_factor): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_key): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_key_node): (WebCore::LevelDBTransaction::AVLTreeAbstractor::compare_node_node): (WebCore::LevelDBTransaction::AVLTreeAbstractor::null): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
  • platform/leveldb/LevelDBWriteBatch.cpp: (WebCore::LevelDBWriteBatch::create): (WebCore::LevelDBWriteBatch::LevelDBWriteBatch): (WebCore::LevelDBWriteBatch::~LevelDBWriteBatch): (WebCore::makeSlice): (WebCore::LevelDBWriteBatch::put): (WebCore::LevelDBWriteBatch::remove): (WebCore::LevelDBWriteBatch::clear):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getInt): (WebCore::putInt): (WebCore::getString): (WebCore::putString): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::createObjectStore): (WebCore::deleteRange): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord): (WebCore::getNewVersionNumber): (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::clearObjectStore): (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord): (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber): (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore): (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord): (WebCore::getNewIndexId): (WebCore::IDBLevelDBBackingStore::createIndex): (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord): (WebCore::findGreatestKeyLessThan): (WebCore::versionExists): (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex): (WebCore::IDBLevelDBBackingStore::keyExistsInIndex): (WebCore::findLastIndexKeyEqualTo): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor): (WebCore::IDBLevelDBBackingStore::createTransaction): (WebCore::IDBLevelDBBackingStore::Transaction::create): (WebCore::IDBLevelDBBackingStore::Transaction::Transaction): (WebCore::IDBLevelDBBackingStore::Transaction::begin): (WebCore::IDBLevelDBBackingStore::Transaction::commit): (WebCore::IDBLevelDBBackingStore::Transaction::rollback):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort):
01:08 Changeset [87369] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-26 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

ASSERT(isMainThread()) when using single threaded jsc executable
https://bugs.webkit.org/show_bug.cgi?id=60846

Remove the ASSERT since we do not have the concept of MainThread in JSC.

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
00:59 Changeset [87368] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

  • transforms/2d/set-transform-and-top-expected.txt: Added.
  • transforms/2d/set-transform-and-top.html: Added.

2011-05-26 Shane Stephens <shanestephens@google.com>

Reviewed by James Robinson.

REGRESSION (r81992): layout triggered by position update fails to apply when transform is updated at same time
https://bugs.webkit.org/show_bug.cgi?id=60689

Test: transforms/2d/set-transform-and-top.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedLayout):
00:44 Changeset [87367] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-26 Tom Hudson <tomhudson@google.com>

Reviewed by Tony Chang.

Add flags to Chromium ImageDiff to write image comparison metrics on
stdout.
https://bugs.webkit.org/show_bug.cgi?id=60569

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::createFromStdin): Fix spelling. (maxOf3): New function to do 3-way maximum. (getRedComponent): Extract red component from ABGR packed encoding. (getGreenComponent): Extract green component from ABGR packed encoding. (getBlueComponent): Extract blue component from ABGR packed encoding. (weightedPercentageDifferent): Determine % of pixels different in two images multiplied by intensity difference of each pixel. (printHelp): Document new arguments. (compareImages): Parameterize. (untestedCompareImages): Parameterize. (diffImages): Parameterize; write results on stdout if requested. (main): Parse new arguments.
00:15 Changeset [87366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-26 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

drag-not-loaded-image.html test crashes when WebKit is built with debug option
https://bugs.webkit.org/show_bug.cgi?id=61480

Checks if image has content before starting to drag.

  • page/DragController.cpp: (WebCore::DragController::startDrag):
00:01 Changeset [87365] by alokp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-26 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Cannot create stencil render-buffer for accelerated drawing on desktop GL
https://bugs.webkit.org/show_bug.cgi?id=61444

Used DEPTH24_STENCIL8 format for stencil buffer instead of STENCIL_INDEX8.
Packed depth-stencil buffer is the most common format supported by graphics cards.
It is not very robust to rely on just one format being supported,
so long term the task of creating FBO should be delegated to SKIA,
which has necessary code to iterate through all possible formats.

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::deleteFrameBuffer): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
Note: See TracTimeline for information about the timeline view.