Timeline


and

05/31/11:

23:57 Changeset [87777] by tkent@chromium.org

2011-05-31 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Convert fast/forms/date-input-visible-strings.html to dumpAsText().
https://bugs.webkit.org/show_bug.cgi?id=61777

  • fast/forms/date-input-visible-strings.html:
  • fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/win/fast/forms/date-input-visible-strings-expected.txt: Removed.
23:25 Changeset [87776] by commit-queue@webkit.org

2011-05-31 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Timeline panel improvements for managing current selection
https://bugs.webkit.org/show_bug.cgi?id=61468

Enables X-axis dragging of the selected area.
Double click zoom-out.
Fixes slightly wrong selection area position.

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum): (WebInspector.TimelineOverviewPane.prototype.scrollWindow): (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel):
23:18 Changeset [87775] by commit-queue@webkit.org

2011-05-31 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61682

Convert test to dump-as-markup and clean up HTML. Also update test description.

  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote-2.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
22:54 Changeset [87774] by commit-queue@webkit.org

2011-05-31 Hao Zheng <zhenghao@chromium.org>

Reviewed by Dirk Pranke.

Fix exception in verbose printing mode.
https://bugs.webkit.org/show_bug.cgi?id=61723

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
22:46 Changeset [87773] by keishi@webkit.org

2011-05-31 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Fix to enable page scroll of select element
https://bugs.webkit.org/show_bug.cgi?id=53628

Manual test: select-page-scroll.html

  • manual-tests/select-page-scroll.html: Added.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
22:09 Changeset [87772] by kinuko@chromium.org

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/storageinfo-no-callbacks-expected.txt: Added.
  • storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):
19:40 Changeset [87771] by commit-queue@webkit.org

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • bytecode/StructureStubInfo.h:

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.h:
  • rendering/InlineBox.h:
  • rendering/RenderBlock.h:

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

  • Scripts/webkitpy/style/checkers/cpp.py:
19:39 QtWebKitForQt5 edited by noam.rosenthal@nokia.com
(diff)
19:25 Changeset [87770] by morrita@google.com

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952

This adds a new layout test to verify that we can receive input events
when we change the text direction of a <textarea> element and an <input>
element.

  • fast/html/set-text-direction-expected.txt: Added.
  • fast/html/set-text-direction.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952

Both Safari and Chrome call Editor::setBaseWritingDirection() to change
the text direction of an editable element with their UIs. This change
calls dispatchInputEvent() to send an input event when the function
actually changes the "dir" attribute so we can send an input event as
written in the HTML5 spec.

Test: fast/html/set-text-direction.html

  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Add a JavaScript function layoutTestController.setTextDirection().
https://bugs.webkit.org/show_bug.cgi?id=50952

This change adds a new JavaScript function setTextDirection() to the
LayoutTestController class of Safari and Chrome to write layout tests
that changes the text direction of an editable element.

  • DumpRenderTree/LayoutTestController.cpp: (setTextDirectionCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setTextDirection):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTextDirection):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTextDirection):
19:22 Changeset [87769] by cevans@google.com

2011-05-31 Chris Evans <cevans@chromium.org>

Reviewed by Drew Yao.

Add "Collaboration" to WebKit Security Group Privileges and Responsibilities section.

  • security/index.html: Add "Collaboration" section with text discussed on webkit-security.
18:48 Changeset [87768] by jer.noble@apple.com

2011-05-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756

Added two new entries to the WebCore exports list.

  • WebCore.exp.in:

2011-05-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756

The @"WebKitLayerHostChanged" notification is causing the QTMovie to tear down its layer
(which is good) at the wrong time (which is bad). Send this notification only after
the dragImage snapshot is taken. This exposed another problem, that the snapshot has
a white background. Set the default background color and transparency for the view (making
sure to reset them afterwards) to transparent.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
18:47 Changeset [87767] by commit-queue@webkit.org

2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893

Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
this test was calculating the final geometry incorrectly. As the order between
a translate and a draw operation could be relevant for it, but not for the
final rendered result, they were changed on ScrollbarThemeQt::paint.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):

2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893

The test was expecting the frame contents to be already loaded
before rendering it into a QPicture. Renamed the test to fit
its real purpose more accordingly.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::renderGeometry):
18:42 Rebaseline edited by dpranke@chromium.org
(diff)
18:26 Changeset [87766] by commit-queue@webkit.org

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] gtkdoc run produces many warnings about missing declarations
https://bugs.webkit.org/show_bug.cgi?id=61797

  • docs/webkitgtk-sections.txt: Remove inexistent symbols from this file to reduce the number of gtkdoc warnings.
18:05 Changeset [87765] by commit-queue@webkit.org

2011-05-31 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Adam Barth.

[efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746

Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_developer_extras_get): (ewk_view_setting_enable_developer_extras_set):
  • ewk/ewk_view.h:
17:43 Changeset [87764] by commit-queue@webkit.org

2011-05-31 Daniel Erat <derat@chromium.org>

Reviewed by Tony Chang.

Make WebScreenInfoFactory return fresh screen dimensions.
https://bugs.webkit.org/show_bug.cgi?id=61679

  • public/x11/WebScreenInfoFactory.h:
  • src/x11/WebScreenInfoFactory.cpp: (WebKit::WebScreenInfoFactory::screenInfo):
17:14 Changeset [87763] by ademar.reis@openbossa.org

2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] User-agent list of Qt test browsers is very outdated
https://bugs.webkit.org/show_bug.cgi?id=61531

The user can edit the user-agent manually, so there's no need to have
a super complete and up to date list, but it's nice to have it
minimally updated.

  • MiniBrowser/qt/useragentlist.txt:
  • QtTestBrowser/useragentlist.txt:
16:49 Changeset [87762] by enne@google.com

2011-05-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654

  • compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
  • compositing/reflections/empty-reflection-with-mask.html: Added.

2011-05-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654

Change the iteration for updateCompositorResources to match that being
done in the paint and draw steps. This mismatch of iteration style
was causing layers with replica masks to correctly get skipped while
painting but not get skipped during texture upload.

Test: compositing/reflections/empty-reflection-with-mask.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerRendererChromium.h:
16:37 Changeset [87761] by inferno@chromium.org

Merge 87743

BUG=84452
Review URL: http://codereview.chromium.org/7057049

16:35 Changeset [87760] by mrobinson@webkit.org

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

  • GNUmakefile.am: Added reference to WebKitTestRunner GNUmakefile.

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

Added InjectedBundle support for GTK+.

  • WebProcess/InjectedBundle/InjectedBundle.h: Added typedef for GTK+.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added implementation. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Remove unnecessary method definition.

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

Add an implementation of WebKitTestRunner for GTK+.

  • Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
  • Scripts/old-run-webkit-tests: Ditto.
  • Scripts/run-launcher: Ditto.
  • Scripts/webkitdirs.pm: Ditto.
  • WebKitTestRunner/GNUmakefile.am: Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
  • WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (main): Added.
16:35 Changeset [87759] by inferno@chromium.org

Merge 87737

BUG=84333
Review URL: http://codereview.chromium.org/7057048

15:40 Changeset [87758] by commit-queue@webkit.org

2011-05-31 Berend-Jan Wever <skylined@chromium.org>

Reviewed by Adam Barth.

Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
when no error callback is supplied does not cause a NULL ptr.
https://bugs.webkit.org/show_bug.cgi?id=49539

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.

2011-05-31 B.J. Wever <skylined@chromium.org>

Reviewed by Adam Barth.

requestFileSystem and resolveLocalFileSystemURI are not checking if
errorCallback is NULL before scheduling a callback on error.
https://bugs.webkit.org/show_bug.cgi?id=49539

Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::scheduleCallback): Only call callback if one is supplied.
15:26 Changeset [87757] by dpranke@chromium.org

2011-05-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
https://bugs.webkit.org/show_bug.cgi?id=60241

  • Scripts/new-run-webkit-tests:
15:13 Changeset [87756] by beidson@apple.com

Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
15:11 Changeset [87755] by mitz@apple.com

<rdar://problem/9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigating between pages on wsj.com, other sites (when navigating away from composited page)
https://bugs.webkit.org/show_bug.cgi?id=61808

Reviewed by Simon Fraser.

WebKit1 has a mechanism to prevent the stale bits from the outgoing page from being erased
until the incoming page has layout. Adapt this in WebKit2 to prevent the composited layer tree
of the outgoing page from being torn down or updated until the incoming page has layout.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Unfreeze the layer tree state.
(WebKit::WebFrameLoaderClient::frameLoadCompleted): Ditto.
(WebKit::WebFrameLoaderClient::provisionalLoadStarted): Freeze the layer tree state.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setLayerTreeStateIsFrozen): Added.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member variables.
(WebKit::DrawingAreaImpl::setLayerTreeStateIsFrozen): Added. When freezing, sets the flag and
disables layer flush scheduling and exiting accelerated compositing mode. When unfreezing,
clears the flag and exits compositing mode if needed.
(WebKit::DrawingAreaImpl::setRootCompositingLayer): Reset m_wantsToExitAcceleratedCompositingMode.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon): If the layer tree state is frozen,
bail out but set m_wantsToExitAcceleratedCompositingMode.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Initialize m_layerFlushSchedulingEnabled.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Added an assertion.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
15:03 Changeset [87754] by commit-queue@webkit.org

2011-05-31 Hao Zheng <zhenghao@chromium.org>

Reviewed by Tony Chang.

Flush output buffer of php.
https://bugs.webkit.org/show_bug.cgi?id=56060

On Lucid, the output buffer is enabled by default, but it's not
enabled on Hardy. Fix test http/tests/loading/preload-slow-loading.php
http://www.php.net/manual/en/function.ob-flush.php

  • http/tests/loading/preload-slow-loading.php:
  • platform/chromium/test_expectations.txt:
14:55 Changeset [87753] by leviw@chromium.org

2011-05-31 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Change InlineBox::paint and its overloaded variants to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61804

Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
to use IntPoint for their paint offset instead of a pair of ints.

No new tests since this is just a refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint):
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • rendering/svg/SVGRootInlineBox.h:
14:50 Changeset [87752] by commit-queue@webkit.org

2011-05-31 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=61593

Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
This is extremely defensive and not strictly necessary, but not harmful either.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::~CCLayerImpl):
14:15 Changeset [87751] by eric@webkit.org

2011-05-31 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

webkitpy should create zips with zip -9
https://bugs.webkit.org/show_bug.cgi?id=61789

Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
14:02 Changeset [87750] by senorblanco@chromium.org

2011-05-31 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Silence some warnings on the Safari/Mac release build.

  • platform/graphics/gpu/TilingData.h: (WebCore::TilingData::assertTile):
13:53 Changeset [87749] by abarth@webkit.org

2011-05-31 Adam Barth <abarth@webkit.org>

Add chromium-mac-leopard image results for these SVG tests.

  • platform/chromium-mac-leopard/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-uri-stroke-expected.png: Added.
13:21 Changeset [87748] by senorblanco@chromium.org

2011-05-31 Justin Novosad <junov@chromium.org>

Reviewed by Stephen White.

[Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
https://bugs.webkit.org/show_bug.cgi?id=61790
Changing the build guards in these two files that are required
by the accelerated compositing feature.

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  • platform/graphics/gpu/TilingData.cpp:
12:56 WebKit Team edited by tonikitoo@webkit.org
(diff)
12:51 Changeset [87747] by rwlbuis@webkit.org

2011-05-31 Rob Buis <rbuis@rim.com>

RS=Dirk Schulze.

run-webkit-tests on animate-path-nested-transform.html crashes
https://bugs.webkit.org/show_bug.cgi?id=61798

"Fix" the crashing test by choosing safer values.

  • svg/animations/script-tests/animate-path-nested-transforms.js: (executeTest):
12:38 Changeset [87746] by rwlbuis@webkit.org

2011-05-31 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Add missing idl files.

Test: svg/animations/animate-mpath-insert.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAnimateMotionElement.idl: Added.
  • svg/SVGMPathElement.idl: Added.

2011-05-31 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Verify that adding mpath via javascript works.

  • svg/animations/animate-mpath-insert-expected.txt: Added.
  • svg/animations/animate-mpath-insert.html: Added.
  • svg/animations/script-tests/animate-mpath-insert.js: Added. (mpath.setAttributeNS.animateMotion.appendChild.g.appendChild.rootSVGElement.appendChild.passIfCloseEnough): (startSample): (endSample): (executeTest):
12:21 Changeset [87745] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Implement printing support for wxWidgets 2.9.x and above.

https://bugs.webkit.org/show_bug.cgi?id=61796

11:53 Changeset [87744] by joepeck@webkit.org

2011-05-31 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
https://bugs.webkit.org/show_bug.cgi?id=61751

Add missing stub function causing an error on load.

  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
11:16 Changeset [87743] by inferno@chromium.org

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Improve hasMediaControls logic to check that node has
media controls. This can be false when cloning nodes.
https://bugs.webkit.org/show_bug.cgi?id=61765

Test: media/media-controls-clone-crash.html

  • dom/Node.h: (WebCore::Node::isMediaControls):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): (WebCore::HTMLMediaElement::hasMediaControls):
  • html/shadow/MediaControls.h: (WebCore::MediaControls::isMediaControls): (WebCore::toMediaControls):

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that cloning an audio element with media controls does
not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=61765

  • media/media-controls-clone-crash-expected.txt: Added.
  • media/media-controls-clone-crash.html: Added.
11:14 Changeset [87742] by xan@webkit.org

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Bump version to 1.5.1.

  • configure.ac:
11:10 Changeset [87741] by xan@webkit.org

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
https://bugs.webkit.org/show_bug.cgi?id=61791

  • bindings/gobject/GNUmakefile.am: add new files.
  • bindings/gobject/WebKitDOMCustom.cpp: Added. (webkit_dom_html_text_area_element_is_edited): (webkit_dom_html_input_element_is_edited):
  • bindings/gobject/WebKitDOMCustom.h: Added.

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
https://bugs.webkit.org/show_bug.cgi?id=61791

  • GNUmakefile.am: add new files.
10:55 Changeset [87740] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Unreviewed. Rebaseline Mac after JSC/Canvas bindings changes.

  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
10:22 Changeset [87739] by noam.rosenthal@nokia.com

2011-05-31 Noam Rosenthal <noam.rosenthal@nokia.com>

Unreviewed build fix for Symbian.
Opt-out Symbian for TextureMapper.

No new tests: build fix.

  • WebCore.pri:
10:12 Changeset [87738] by leviw@chromium.org

2011-05-31 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFocusRing to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61580

Switching paintFocusRing to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests as this is just refactoring.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
09:51 Changeset [87737] by inferno@chromium.org

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Convert raw ptr to RefPtr for documentElement.
https://bugs.webkit.org/show_bug.cgi?id=61688

Test: fast/dom/xml-parser-error-message-crash.svg

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock):

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Test that we do not crash when a DOMNodeInsertedIntoDocument event
is fired while generating a error message block in xml parsing.
https://bugs.webkit.org/show_bug.cgi?id=61688

  • fast/dom/xml-parser-error-message-crash-expected.txt: Added.
  • fast/dom/xml-parser-error-message-crash.svg: Added.
09:28 Changeset [87736] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
https://bugs.webkit.org/show_bug.cgi?id=61786

Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-setShadow.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
https://bugs.webkit.org/show_bug.cgi?id=61786

Add a test to verify the behavior of setShadow() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-setShadow-expected.txt: Added.
  • fast/canvas/canvas-overloads-setShadow.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setShadow.js: Added.
09:25 Changeset [87735] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
https://bugs.webkit.org/show_bug.cgi?id=61709

Add a test to verify the behavior of drawImageFromRect() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImageFromRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImageFromRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
https://bugs.webkit.org/show_bug.cgi?id=61709

Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
Side effect: calling drawImageFromRect() with zero arguments will now raise
SyntaxError instead of TypeError.

Test: fast/canvas/canvas-overloads-drawImageFromRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
09:22 Changeset [87734] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
https://bugs.webkit.org/show_bug.cgi?id=61703

Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-drawImage.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
https://bugs.webkit.org/show_bug.cgi?id=61703

Add a test to verify the behavior of drawImage() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImage-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImage.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImage.js: Added.
09:20 Changeset [87733] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
https://bugs.webkit.org/show_bug.cgi?id=61641

Add a test to verify the behavior of strokeRect() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-strokeRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeRect.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
https://bugs.webkit.org/show_bug.cgi?id=61641

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

No behavioral change.

Test: fast/canvas/canvas-overloads-strokeRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
09:15 Changeset [87732] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=61635

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setFillColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=61635

Add a test to verify the behavior of setFillColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setFillColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setFillColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setFillColor.js: Added.
09:12 Changeset [87731] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
https://bugs.webkit.org/show_bug.cgi?id=61629

Add a test to verify the behavior of setStrokeColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setStrokeColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setStrokeColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setStrokeColor.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
https://bugs.webkit.org/show_bug.cgi?id=61629

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setStrokeColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
09:10 Changeset [87730] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
https://bugs.webkit.org/show_bug.cgi?id=61626

Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-strokeText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
https://bugs.webkit.org/show_bug.cgi?id=61626

Add a test to verify the behavior of strokeText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling strokeText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-strokeText-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeText.js: Added.
09:08 Changeset [87729] by andreas.kling@nokia.com

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
https://bugs.webkit.org/show_bug.cgi?id=61623

Add a test to verify the behavior of fillText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling fillText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-fillText-expected.txt: Added.
  • fast/canvas/canvas-overloads-fillText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-fillText.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
https://bugs.webkit.org/show_bug.cgi?id=61623

Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-fillText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
09:05 Changeset [87728] by commit-queue@webkit.org

2011-05-31 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Allow Chromium porting layer to use Skia on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61548

  • public/WebCommon.h: Don't allow WebKit to use CG if it is already using Skia.
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::paintScrollbarThumb): Allow scrollbar thumb draw to take WebCanvas.
08:38 Changeset [87727] by commit-queue@webkit.org

2011-05-31 ChangeLog <james.cooley@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Qt port needs test content for QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=57850

Created data-driven QTestLib tests for existing QWKHistory APIs.

This walks through loading four simple pages, navigating
backwards and forwards.

We check the results at each action by creating expected forward/back
lists and comparing those lists in count and membership to those kept by
WebKit and retrieved via the QWKHistory APIs.

  • UIProcess/API/qt/tests/html/a.htm: Added.
  • UIProcess/API/qt/tests/html/b.htm: Added.
  • UIProcess/API/qt/tests/html/c.htm: Added.
  • UIProcess/API/qt/tests/html/d.htm: Added. Four added simple pages
  • UIProcess/API/qt/tests/qwkhistory: Added.
  • UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro: Added. Created qwkhistory folder and pro
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Added. (TestHistoryItem::title): (TestHistoryItem::url): (TestHistoryItem::TestHistoryItem): Utility class to hold expected url,title for test

(tst_QWKHistory::initTestCase):
(tst_QWKHistory::historyFBTest_data):
(tst_QWKHistory::historyFBTest):
init, data, and data-driven test case

  • UIProcess/API/qt/tests/tests.pro: Included qwkhistory in tests.pro
07:20 Changeset [87726] by simon.fraser@apple.com

2011-05-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

  • fast/frames/flattening/iframe-flattening-nested.html: Added.
  • fast/frames/flattening/resources/inner-frame.html: Added.
  • fast/frames/flattening/resources/intermediate-frame.html: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.

2011-05-31 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.

Test: fast/frames/flattening/iframe-flattening-nested.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
06:46 Changeset [87725] by commit-queue@webkit.org

2011-05-31 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Fix getUserMedia callback bindings for JSC.
https://bugs.webkit.org/show_bug.cgi?id=60174

This patch initializes the exception code variable to 0.

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
06:32 Changeset [87724] by ossy@webkit.org

[Qt] Implement find feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61425

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-31
Reviewed by Csaba Osztrogonác.

Buildfix for --minimal and CONFIG+=qt_minimal build.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:
05:43 Changeset [87723] by commit-queue@webkit.org

2011-05-31 Oleg Romashin <oleg.romashin@nokia.com>

Reviewed by Benjamin Poulain.

Fix compilation with debug enabled, m_lightSource.type is not valid anymore
https://bugs.webkit.org/show_bug.cgi?id=61719

  • platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):
05:39 QtWebKitForQt5 edited by hausmann@webkit.org
(diff)
04:49 Changeset [87722] by mnaganov@chromium.org

2011-05-31 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed tests results rebaseline after r87721.

  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.png:
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.txt: Added.
03:46 Changeset [87721] by commit-queue@webkit.org

2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/mac/svg/custom/invalid-fill-expected.png:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.png:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/mac/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/qt/svg/custom/invalid-fill-expected.txt:
  • platform/qt/svg/custom/invalid-fill-hex-expected.txt:
  • platform/qt/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/qt/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • svg/custom/invalid-fill-hex.svg:
  • svg/custom/invalid-fill.svg:
  • svg/custom/invalid-stroke-hex.svg: Added.
  • svg/custom/invalid-uri-stroke.svg: Added.

2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

Tests: svg/custom/invalid-stroke-hex.svg

svg/custom/invalid-uri-stroke.svg

  • rendering/svg/RenderSVGResource.cpp: (WebCore::inheritColorFromParentStyleIfNeeded): (WebCore::requestPaintingResource):
03:42 Changeset [87720] by commit-queue@webkit.org

2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement find feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61425

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::showFindBar): (LauncherWindow::find):
  • QtTestBrowser/launcherwindow.h:
03:20 Changeset [87719] by yutak@chromium.org

2011-05-31 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Make the output of client-close.html more verbose
https://bugs.webkit.org/show_bug.cgi?id=61770

  • http/tests/websocket/tests/client-close-expected.txt:
  • http/tests/websocket/tests/client-close.html:
  • http/tests/websocket/tests/client-close_wsh.py: Echo back the first two bytes received from the client.
02:58 Changeset [87718] by vangelis@chromium.org

2011-05-31 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kent Tamura.

[chromium] Avoid double deletion of DrawingBuffer's color buffer
texture.
https://bugs.webkit.org/show_bug.cgi?id=61761

Test: Verified that the DCHECK in GraphicsContext3D implementation
doesn't trigger.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer):
02:10 Changeset [87717] by zoltan@webkit.org

[Qt][WK2] Ossyize editing/pasteboard/copy-standalone-image-crash.html since eventSender is not implemented.

  • platform/qt-wk2/Skipped:
01:50 QtWebKitForQt5 edited by hausmann@webkit.org
More cleanups (diff)
01:49 QtWebKitForQt5 edited by hausmann@webkit.org
AC wording cleanup (diff)
01:45 QtWebKitForQt5 edited by hausmann@webkit.org
Mentioning theming (diff)
00:39 Changeset [87716] by hayato@chromium.org

2011-05-30 Hayato Ito <hayato@chromium.org>

Reviewed by Ryosuke Niwa.

Add a utility function for dumping a tree for the Node, including a document of a frame.
https://bugs.webkit.org/show_bug.cgi?id=61727

No new tests since added functions are only available in debug builds.

  • dom/Node.cpp: (WebCore::parentOrHostOrFrameOwner): (WebCore::traverseNextNodeAcrossFrame): (WebCore::Node::showTreeForThisAcrossFrame):
  • dom/Node.h:
00:29 Changeset [87715] by yutak@chromium.org

2011-05-31 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Chromium test expectation for http/tests/websocket/tests/client-close.html.

  • platform/chromium/test_expectations.txt:
00:01 Changeset [87714] by loki@webkit.org

2011-05-30 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip crashed test after r87691-r87693 on ARM
https://bugs.webkit.org/show_bug.cgi?id=61764

  • platform/qt-arm/Skipped:

05/30/11:

23:28 Changeset [87713] by koz@chromium.org

2011-05-30 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium/fast/dom/register-protocol-handler-expected.txt: Added.

2011-05-30 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Make isValidProtocol() accept protocols with '+'.
https://bugs.webkit.org/show_bug.cgi?id=61759

Also, detect syntax errors before security errors; some syntax errors
will also trigger a security error, but it's more helpful to the
programmer to know if they have a syntax error, which are well-defined
in the spec, rather than a security error, which aren't.

  • page/Navigator.cpp: (WebCore::Navigator::registerProtocolHandler): Detect syntax errors before security errors.
  • platform/KURLGoogle.cpp: (WebCore::isSchemeChar): Include '+' in the list of valid characters.
22:22 Changeset [87712] by mrowe@apple.com

Versioning.

22:21 Changeset [87711] by mrowe@apple.com

New tag.

22:12 Changeset [87710] by mrowe@apple.com

Merge r87692.

22:00 Changeset [87709] by commit-queue@webkit.org

2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721

  • editing/pasteboard/copy-standalone-image-crash-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image-crash.html: Added.

2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>

Reviewed by Hajime Morita.

Using jQuery to show/hide IMG elements crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=31721

For platform code, do not assert nodes always have renderer at
the time context menu action is invoked.
Renderer can actually be empty for a given node if it was hidden
or removed from domtree by some non-user generated event (e.g timeout)
after the popup menu had been created.

Changing Chromium, Gtk, Mac, Qt, Win and WinCE.

Test: editing/pasteboard/copy-standalone-image-crash.html

  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage):
21:03 Changeset [87708] by dbates@webkit.org

2011-05-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • XSSAuditor: Copied from PerformanceTests/XSSFilter.
  • XSSFilter: Removed.
  • XSSFilter/large-post-many-events.html: Removed.
  • XSSFilter/large-post-many-inline-scripts-and-events.html: Removed.
  • XSSFilter/resources: Removed.
  • XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Removed.

2011-05-30 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

Rename XSSFilter to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=61718

Currently we use the names XSSFilter and XSSAuditor throughout the project.
Instead, we should choose one name for consistency.

No functionality was changed. So, no new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp. (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::init): (WebCore::XSSAuditor::filterToken): (WebCore::XSSAuditor::filterTokenInitial): (WebCore::XSSAuditor::filterTokenAfterScriptStartTag): (WebCore::XSSAuditor::filterScriptToken): (WebCore::XSSAuditor::filterObjectToken): (WebCore::XSSAuditor::filterParamToken): (WebCore::XSSAuditor::filterEmbedToken): (WebCore::XSSAuditor::filterAppletToken): (WebCore::XSSAuditor::filterIframeToken): (WebCore::XSSAuditor::filterMetaToken): (WebCore::XSSAuditor::filterBaseToken): (WebCore::XSSAuditor::filterFormToken): (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected): (WebCore::XSSAuditor::eraseAttributeIfInjected): (WebCore::XSSAuditor::snippetForRange): (WebCore::XSSAuditor::snippetForAttribute): (WebCore::XSSAuditor::isContainedInRequest): (WebCore::XSSAuditor::isSameOriginResource):
  • html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
  • html/parser/XSSFilter.cpp: Removed.
  • html/parser/XSSFilter.h: Removed.
19:21 Changeset [87707] by noam.rosenthal@nokia.com

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Expose a public clearAll() function to reset WebCore::Animation.

No new functionality, so no new tests.

  • platform/animation/Animation.h: (WebCore::Animation::clearAll):

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Create an ArgumentCoder for WebCore::Animation.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
19:18 Changeset [87706] by commit-queue@webkit.org

2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kent Tamura.

[efl] Fix _ewk_frame_children_iterator_next().
https://bugs.webkit.org/show_bug.cgi?id=61749

The iterator was returning always the first child, making tests like
fast/history/history-back-initial-vs-final-url.html to timeout and
eventually run out of memory.

  • ewk/ewk_frame.cpp: (_ewk_frame_children_iterator_next): (ewk_frame_children_iterator_new):
19:04 Changeset [87705] by tkent@chromium.org

2011-05-30 Kent Tamura <tkent@chromium.org>

[Mac] Skip a flaky test: svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/mac/Skipped:
18:44 Changeset [87704] by eric.carlson@apple.com

2011-05-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Audio and video files saved to the Application Cache should preserve the original file extension
https://bugs.webkit.org/show_bug.cgi?id=61750
<rdar://9524922>

No new tests, it isn't possible to check the name of the file in the cache from within
DRT. Changes verified manually.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache

file name.

(WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.

  • loader/appcache/ApplicationCacheStorage.h:
17:05 Changeset [87703] by jer.noble@apple.com

2011-05-30 Jer Noble <jer.noble@apple.com>

Reviewed by Dan Bernstein.

Play/Pause button in wrong state when entering full screen on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61754

Update the play/pause button inside reset(). This ensures the button is in
the correct state when the controls are created after playback has already
started.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
16:49 Changeset [87702] by commit-queue@webkit.org

2011-05-30 Hojong Han <hojong.han@samsung.com>

Reviewed by Geoffrey Garen.

[JSC] malfunction during arithmetic condition check with negative number (-2147483648)
https://bugs.webkit.org/show_bug.cgi?id=61416

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
  • tests/mozilla/ecma/Expressions/11.12-1.js: (getTestCases):
16:43 Changeset [87701] by noam.rosenthal@nokia.com

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Added a public TimingFunction::type() method.

No new functionality, so no new tests.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::type):

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for WebCore::TimingFunction. This serializer can create the appropriate
TimingFunction subclass based on the type of timing function.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
15:29 Changeset [87700] by noam.rosenthal@nokia.com

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

BUILD FIX for r87697 on Windows/Symbian

For now enabling TextureMapper for Mac/Linux only.

  • WebCore.pri:
15:02 Changeset [87699] by noam.rosenthal@nokia.com

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add WebCore::Length and WebCore::TransformationMatrix to the types that use SimpleArgumentCoder.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
15:00 Changeset [87698] by ddkilzer@apple.com

BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior): Mark
shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).

13:57 Changeset [87697] by noam.rosenthal@nokia.com

2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Make CONFIG+=texmap an opt-out instead of an opt-in.

No new functionality so no new tests.

  • WebCore.pri:
13:08 Changeset [87696] by commit-queue@webkit.org

2011-05-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=61693

  • platform/gtk/Skipped: Unskip the test which is no longer crashing.

2011-05-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=61693

Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
may now be null.

No new tests. This change should cause fast/css/font-face-zero-hash-key.html
to stop crashing.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing m_scaledFont.
12:23 QtWebKitRelease22 edited by ademar.reis@openbossa.org
(diff)
12:02 Changeset [87695] by caio.oliveira@openbossa.org

2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
https://bugs.webkit.org/show_bug.cgi?id=61711

The loadFinished() signal was emitted directly inside the call for setHtml, so
the test was waiting the loadFinished() signal with a big timeout. Change this by
a very small timeout and a verification with signal spy.

In practice, setHtml() will either directly call loadFinished() or queue it to
the next event loop run, and test will work for both situations.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::scrollbarsOff):
11:28 Changeset [87694] by noam.rosenthal@nokia.com

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media until they're working.
https://bugs.webkit.org/show_bug.cgi?id=61687

Until this works properly, we should indicate that our media implementation
in texture mapper doesn't support accelerated compositing.

This makes LayoutTests/compositing/video/* work again.

  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::platformLayer):

2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Disable accelerated plugins/media in until they're working.
https://bugs.webkit.org/show_bug.cgi?id=61687

Turn off accelerated compositing for media and plugins when in texture-mapper.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
10:21 Changeset [87693] by abarth@webkit.org

2011-05-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Adam Barth.

[Chromium] Fix regression after r87628.
https://bugs.webkit.org/show_bug.cgi?id=61733

Having r87628 in place, Chrome reliability bot crashes in
WebCore::HTMLLinkElement::onloadTimerFired.

This is because the change makes WebCore::CachedResource::setRequest to
call checkNotify on request reset. HTMLLinkElement registers itself as
CachedResource client via m_cachedSheet, which can happen even if
m_cachedLinkResource wasn't set. As a result,
WebCore::HTMLLinkElement::notifyFinished is got called with unset
m_cachedLinkResource, which causes a crash in
HTMLLinkElement::onloadTimerFired

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::notifyFinished):
10:09 Changeset [87692] by darin@apple.com

2011-05-30 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler and Simon Fraser.

REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
https://bugs.webkit.org/show_bug.cgi?id=61717
rdar://problem/9522272

May be some good way to test this later. No immediate idea about the best way.

When a media element is taken into full-screen mode, stop events from propagating
outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
has been changed to take a shadow root node. In our full screen media element check,
we check to see if the passed shadow root is the shadow root of the full screen media
element, and if so, specify events should StayInsideShadowDOM. The end result is that
inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
way from the SliderThumb to the video element's shadow root, but no further.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the shadow DOM when showing a full screen video.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls. The events telling us about activity in the shadow DOM no longer bubble out so we need to handle this inside the shadow DOM on the root element. (WebCore::HTMLMediaElement::play): Ditto. (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto. (WebCore::HTMLMediaElement::defaultEventHandler): Ditto. (WebCore::HTMLMediaElement::enterFullscreen): Ditto. (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
  • html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out changes that tried to make special rules for events using preDispatchEventHandler and such. This rolls out both r87622 and r87655. (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
  • html/shadow/MediaControlElements.h: Ditto.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members. (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider hiding the controls later. (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse is no longer over the controls. (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide automatically if we're playing. (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer. (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care if we are full screen. (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function. (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions as the mouse is moved in and out. (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if needed. (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions are met. (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
  • html/shadow/MediaControlRootElement.h: Added new functions and data members.
10:05 Changeset [87691] by abarth@webkit.org

2011-05-30 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

2011-05-30 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:25 Changeset [87690] by carlosgc@webkit.org

2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement JavaScript dialogs in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61725

  • MiniBrowser/gtk/BrowserWindow.c: (WKStringGetCString): Helper function to get a UTF-8 c string from a WKStringRef. (WKURLGetCString): Helper function to get a UTF-8 c string from a WKURLRef. (browserWindowUpdateURL): Update to use WKURLGetCString. (didReceiveTitleForFrame): Update to use WKStringGetCString. (createMessageDialog): Create a GtkMessageDialog. (runJavaScriptAlert): (runJavaScriptConfirm): (runJavaScriptPrompt): (browserWindowUIClientInit):
09:17 Changeset [87689] by carlosgc@webkit.org

2011-05-30 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
09:14 Changeset [87688] by andersca@apple.com

2011-05-30 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Remove incorrect asserts from PluginProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=61731

There might be pending incoming messages from a PluginProxy even though we've
destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveMessage): (WebKit::PluginProcessConnection::didReceiveSyncMessage):
08:44 Changeset [87687] by pvarga@webkit.org

2011-05-30 Peter Varga <pvarga@webkit.org>

Unreviewed build fix.

[Qt][V8] Fix debug build.

No new tests needed.

  • css/CSSStyleDeclaration.cpp: Add missing header.
  • dom/Text.cpp: Ditto.
  • rendering/InlineTextBox.cpp: Ditto.
08:03 QtWebKitForQt5 created by hausmann@webkit.org
07:50 Changeset [87686] by commit-queue@webkit.org

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
http://trac.webkit.org/changeset/87683
https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87683.
http://trac.webkit.org/changeset/87683
https://bugs.webkit.org/show_bug.cgi?id=61729

Breaks inspector tests on Chromium (Requested by apavlov on
#webkit).

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
07:13 Changeset [87685] by carlosgc@webkit.org

2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=60536

  • Platform/CoreIPC/Connection.cpp: Remove WebProcess.h.
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove ProcessLauncher.h and WebProcessProxy.h. Add <wtf/OwnArrayPtr.h>.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Remove PluginView.h.
07:06 Changeset [87684] by rgabor@webkit.org

[Qt] Remove passing tests from ARM Skipped list

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
  • platform/qt-arm/fast: Removed.
  • platform/qt-arm/fast/block: Removed.
  • platform/qt-arm/fast/block/float: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
  • platform/qt-arm/fast/transforms: Removed.
  • platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Removed.
  • platform/qt-arm/transforms: Removed.
  • platform/qt-arm/transforms/2d: Removed.
  • platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
  • platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Removed.
  • platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/qt-arm/transforms/svg-vs-css-expected.txt: Removed.
06:48 Changeset [87683] by apavlov@chromium.org

2011-05-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-url-linkify.html:

2011-05-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend up front.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
03:36 Changeset [87682] by mnaganov@chromium.org

2011-05-30 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed.
[Chromium] Rebaseline tests after r87680.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
02:18 Changeset [87681] by caseq@chromium.org

011-05-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not issue frontendReused for reload or navigation.
https://bugs.webkit.org/show_bug.cgi?id=61192

  • only issue frontendReused when inspector is attached after main resource committed load
  • upon committing loading main resource, reset agents before sending FrameNavigated to page agent
  • Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
  • do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::clearFrontend): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._resetResourcesTree): (WebInspector.DatabaseTreeElement.prototype.onpopulate): (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
  • inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.frontendReused):
01:30 Changeset [87680] by commit-queue@webkit.org

2011-05-30 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
https://bugs.webkit.org/show_bug.cgi?id=61603

  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
  • svg/filters/feConvolveFilter-y-bounds.svg: Added.

2011-05-30 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Darin Adler.

FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
https://bugs.webkit.org/show_bug.cgi?id=61603

Test: svg/filters/feConvolveFilter-y-bounds.svg

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::getPixelValue):
00:45 Changeset [87679] by japhet@chromium.org

2011-05-30 Nate Chapin <japhet@chromium.org>

Reviewed by Antti Koivisto.

Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
flow so it's a little less circular.
https://bugs.webkit.org/show_bug.cgi?id=61666

  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::beginLoadIfNeeded):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::load):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::loadStarted):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load):
00:22 Changeset [87678] by abarth@webkit.org

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
http://trac.webkit.org/changeset/87618
https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87618.
http://trac.webkit.org/changeset/87618
https://bugs.webkit.org/show_bug.cgi?id=61720

Causes BrowserFocusTest.FocusOnReload to fail (Requested by
abarth|gardener on #webkit).

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

05/29/11:

23:25 Changeset [87677] by mrowe@apple.com

Versioning.

23:23 Changeset [87676] by mrowe@apple.com

New tag.

23:22 Changeset [87675] by mrowe@apple.com

Merge r87657.

23:22 Changeset [87674] by yutak@chromium.org

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • http/tests/websocket/tests/client-close-expected.txt: Added.
  • http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
  • http/tests/websocket/tests/client-close_wsh.py: Added.
  • http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
  • http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py: We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket waits for a close frame to arrive and this test will time out.
  • http/tests/websocket/tests/server-close-expected.txt: Added.
  • http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
  • http/tests/websocket/tests/server-close_wsh.py: Added.
  • http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

Implement WebSocket closing handshake based on Ian Hickson's
WebSocket protocol draft 76.

Tests: http/tests/websocket/tests/client-close.html

http/tests/websocket/tests/server-close.html

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): Do not send a message if we are in Closing state. (WebCore::SocketStreamHandleBase::close): Do not disconnect if we have pending data which have not been sent yet. In this case, the actual disconnection will happen in sendPendingData(). (WebCore::SocketStreamHandleBase::disconnect): Renamed from close(). Disconnect the connection immediately. (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus) to didClose(). (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake): (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): Fail if close() is attempted before the connection is established. Otherwise, set the state to CLOSING and start the closing handshake. (WebCore::WebSocket::bufferedAmount): If the state is CLOSING, we need to consider buffered data in m_channel and sent after close(). (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): We need to invoke message event in CLOSING state as well as OPEN state. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didStartClosingHandshake): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): Start the closing handshake. (WebCore::WebSocketChannel::disconnect): Disconnect the socket stream, instead of close. (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): Ditto. (WebCore::WebSocketChannel::didFail): Ditto. (WebCore::WebSocketChannel::processBuffer): Ditto. Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started. (WebCore::WebSocketChannel::startClosingHandshake): Send 0xFF 0x00 byte sequence. (WebCore::WebSocketChannel::closingTimerFired): Disconnect the socket stream if the closing handshake has timed out.
  • websockets/WebSocketChannel.h: m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol specification).
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added. (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake(). (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidStartClosingHandshake): (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket closing handshake
https://bugs.webkit.org/show_bug.cgi?id=35721

  • Scripts/webkitpy/thirdparty/init.py: Pull in pywebsocket 0.6b1. We need to update pywebsocket to get the right behavior of closing handshake.
23:17 Changeset [87673] by abarth@webkit.org

2011-05-29 Adam Barth <abarth@webkit.org>

More IMAGE results.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
23:07 Changeset [87672] by abarth@webkit.org

2011-05-29 Adam Barth <abarth@webkit.org>

Add image baselines for all these beautiful platforms.

  • platform/chromium-linux-x86/fullscreen: Added.
  • platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac-leopard/fullscreen: Added.
  • platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-mac/fullscreen: Added.
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-win-vista/fullscreen: Added.
  • platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
22:54 Changeset [87671] by abarth@webkit.org

2011-05-29 Adam Barth <abarth@webkit.org>

Attempt to fix build by implementing pure virtual function.

  • html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::shouldHideControls):
  • html/shadow/MediaControlRootElementChromium.h:
22:20 Changeset [87670] by mrowe@apple.com

Versioning.

22:19 Changeset [87669] by mrowe@apple.com

New tag.

21:41 Changeset [87668] by mrowe@apple.com

Merge r87654.

21:40 Changeset [87667] by mrowe@apple.com

Merge r87642.

21:34 Changeset [87666] by mrowe@apple.com

Merge r87643.

21:32 Changeset [87665] by mrowe@apple.com

Merge r87660.

21:20 Changeset [87664] by mrowe@apple.com

Merge r87655.

21:18 Changeset [87663] by mrowe@apple.com

Merge r87661.

21:14 Changeset [87662] by mrowe@apple.com

Merge r87652.

20:37 Changeset [87661] by jer.noble@apple.com

2011-05-29 Brian Weinstein <bweinstein@apple.com>

Reviewed by Darin Adler.

Controls never hide in full screen after user stops moving mouse
https://bugs.webkit.org/show_bug.cgi?id=61715
<rdar://problem/9522182>

When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
show the media controls, and then start a timer.

The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
move), and hides the controls.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer. (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen

controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
to play.

(WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future

if we are in full screen.

(WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and

we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.

(WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
(WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the

controls and start a timer to hide them.

(WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't

have the move the mouse once they enter full screen to hide the controls.

(WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls. (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that

the caller should hide the controls if the panel is not hovered.

  • html/shadow/MediaControlRootElement.h:
19:05 Changeset [87660] by jer.noble@apple.com

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
https://bugs.webkit.org/show_bug.cgi?id=61712

  • fullscreen/full-screen-iframe-zIndex-expected.txt: Added.
  • fullscreen/full-screen-iframe-zIndex.html: Added.
  • platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
https://bugs.webkit.org/show_bug.cgi?id=61712

Tests: fullscreen/full-screen-iframe-zIndex.html

Walk up the ancestor chain for the full-screen element, marking them as full-screen
ancestors. Then, we apply a pseudo-class to those elements, which disable all their
stacking-context-creating styles. Set the z-index of all full-screen elements (and
the iframes which contain them) to a large value, ensuring they appear above other
sibling elements.

This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
and pesudo-class, so remove it and replace it with the new pseudo-class.

  • css/CSSSelector.cpp: (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove

-webkit-full-screen-media-document.

(WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove

PseudoFullScreenMediaDocument

(WebCore::CSSSelector::extractPseudoType): Ditto.

  • css/CSSSelector.h: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the

PseudoFullScreenMediaDocument implementation and replace it with
PseudoFullScreenAncestor.

  • css/fullscreen.css: (:-webkit-full-screen): Add a z-index property. (:-webkit-full-screen-ancestor:not(iframe)): Added. Reset the z-index to

auto, and reset other stacking-context creating properties.

  • dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element

instead of just the iframe elements.

(WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.

  • dom/Element.cpp: (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property. (WebCore::Element::insertedIntoTree): Ditto. (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase. (WebCore::Element::setContainsFullScreenElement): Ditto.
  • dom/Element.h:
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for

m_containsFullScreenElement.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer. (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
  • html/HTMLFrameElementBase.h:
  • rendering/style/RenderStyleConstants.h:
17:49 Changeset [87659] by abarth@webkit.org

2011-05-29 Adam Barth <abarth@webkit.org>

Add expected result.

  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
17:42 Changeset [87658] by abarth@webkit.org

2011-05-29 Adam Barth <abarth@webkit.org>

Slightly adjust the type of the expected failure.

  • platform/chromium/test_expectations.txt:
17:19 Changeset [87657] by mitz@apple.com

<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
https://bugs.webkit.org/show_bug.cgi?id=61714

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
new full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
the full screen element.

  • dom/Element.h:

(WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
(WebCore::Element::willStopBeingFullscreenElement): Ditto.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
MediaControls::enteredFullscreen().
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
MediaControls::exitedFullscreen().

  • html/HTMLMediaElement.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
changes to the fullscreen-ness of the element.

17:19 Changeset [87656] by darin@apple.com

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
https://bugs.webkit.org/show_bug.cgi?id=61707

Second try at this. First try could lead to a WKView leak.

  • UIProcess/mac/WKFullScreenWindowController.h: Added _isExitingAcceleratedCompositingMode. Needed to track whether we have retained so we don't leak if the page goes away before we get the callback.
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Added code to set the new variable to YES. (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Added code to deal with the new boolean and to release. (exitCompositedModeRepaintCompleted): Removed the release that was here. (-[WKFullScreenWindowController close]): Added a call to exitCompositedModeRepaintCompleted here. We're as complete as we'll ever be when we're closed; we can't get the callback after that point.
17:00 Changeset [87655] by darin@apple.com

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Kevin Decker.

REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
https://bugs.webkit.org/show_bug.cgi?id=61713

We need to come up with a way to regression-test these changes. Nothing at the moment.

The bug is that we removed calls to preventDefault, but we still do need to prevent
default handling of this event.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault that was in here before r87622 as well as the stopPropagation that was added in r87622. (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto. (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
15:14 Changeset [87654] by weinig@apple.com

REGRESSION (r87637): nytimes.com freezes after going back to it
<rdar://problem/9521928>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
Add call to setShouldNotifyAfterNextScheduledLayerFlush(false) to prevent a
redundant call to layerHostDidFlushLayers which would cause the layer state
to get out of sync with the UIProcess.

14:56 Changeset [87653] by ggaren@apple.com

2011-05-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Some heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=61704


SunSpider says no change.

  • heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

(JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

(JSC::Heap::allocate): Changed inline allocation code to only select the
size class, since this can be optimized out at compile time -- everything
else is now inlined into this out-of-line function.


No need to duplicate ASSERTs made in our caller.

  • heap/Heap.h: (JSC::Heap::heap): (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding a layer of indirection through MarkedSpace.

(JSC::Heap::allocate): See above.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::create): (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::allocate): Updated to match changes above.
14:28 Changeset [87652] by jer.noble@apple.com

2011-05-29 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
https://bugs.webkit.org/show_bug.cgi?id=61710

When taking the documentElement full screen, we don't create a RenderFullScreen
object and thus never enter accelerated compositing mode for the animation. Tell
the WKFullScreenWindowController to enter accelerated compositing mode anyway
(with an empty layer context) so as to fulfill its expectations and cause the
full screen animation to complete.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a

comment explaining when we expect the animation to complete.

(-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):

Remove an ASSERT which is no longer valid.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess

to enter then exit full-screen mode.

(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

14:01 Changeset [87651] by mrowe@apple.com

Merge r87633.

14:01 Changeset [87650] by mrowe@apple.com

Merge r87628.

13:57 Changeset [87649] by mrowe@apple.com

Merge r87637.

13:56 Changeset [87648] by mrowe@apple.com

Merge r87634.

13:54 Changeset [87647] by mrowe@apple.com

Merge r87639.

13:54 Changeset [87646] by mrowe@apple.com

Merge r87638.

13:45 Changeset [87645] by andreas.kling@nokia.com

2011-05-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Element: Micro-cleanup of scroll methods.
https://bugs.webkit.org/show_bug.cgi?id=61705

Do an early return without calculating element boundaries when asked
to scroll an element without a renderer().

  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::scrollByUnits):
13:12 Changeset [87644] by darin@apple.com

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Race condition in full screen controller, which leads to problem when web process crashes
https://bugs.webkit.org/show_bug.cgi?id=61707

Saw this while debugging a crash. We don't have a way to make regression tests for this
kind of issue at this time.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller here since we are keeping a pointer to it. (exitCompositedModeRepaintCompleted): Release the controller here.
13:12 Changeset [87643] by darin@apple.com

2011-05-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Fix assertion seen when entering full screen mode for standalone video
https://bugs.webkit.org/show_bug.cgi?id=61708

We don't currently have a way to make a regression test for this.

  • dom/Document.cpp: (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc, because scheduleStyleRecalc is intended to only be called when the style system itself detects recalc is needed.
13:06 Changeset [87642] by andersca@apple.com

2011-05-29 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
https://bugs.webkit.org/show_bug.cgi?id=61706
<rdar://problem/9521970>

If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
12:38 Changeset [87641] by dbates@webkit.org

2011-05-29 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
https://bugs.webkit.org/show_bug.cgi?id=61162

Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
that omits a line count. In particular, the chunk range regular expression does
not match a chunk range line that omits a line count. GNU diff(1) will omit the
line count in the chunk range if the line count is exactly 1. For example, appending
a new line to the end of an existing file F that contains exactly one line of text will
be represented in a diff with a chunk range line that omits the line count for F.

  • Scripts/VCSUtils.pm: (parseChunkRange): Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added unit test "Git: Append new line to the end of an existing file".
12:13 Changeset [87640] by andreas.kling@nokia.com

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

[Qt] Add area check to ImageBufferData::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=61375

No change in behavior, just a sanity check.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
12:00 Changeset [87639] by darin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <bdakin@apple.com> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.

  • page/ChromeClient.h:

(WebCore::ChromeClient::setRenderTreeSize):

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

  • rendering/RenderArena.h:

(WebCore::RenderArena::totalRenderArenaSize):

11:13 Changeset [87638] by darin@apple.com

2011-05-29 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

  • UIProcess/API/C/WKPage.cpp: (WKPageGetRenderTreeSize):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::renderTreeSize): (WebKit::WebPageProxy::setRenderTreeSize):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setRenderTreeSize):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:03 Changeset [87637] by darin@apple.com

<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

02:49 Changeset [87636] by philn@webkit.org

2011-05-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Data directory is webkitgtk-x.y not webkit-x.y
https://bugs.webkit.org/show_bug.cgi?id=61642

  • GNUmakefile.am: updated data directory.
01:30 Changeset [87635] by commit-queue@webkit.org

2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87566.
http://trac.webkit.org/changeset/87566
https://bugs.webkit.org/show_bug.cgi?id=61702

It made all tests assert on Qt in debug mode (Requested by
Ossy_weekend on #webkit).

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suggestedMIMEType): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • platform/mac/HTMLConverter.mm: (fileWrapperForElement):
00:04 Changeset [87634] by sfalken@apple.com

2011-05-28 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't add sub-frames to global history when navigating via back/forward
https://bugs.webkit.org/show_bug.cgi?id=61701
<rdar://problem/9521222>

Instead of just checking whether the load is the first in the frame, we also need to
check to make sure we're loading in the main frame.

Not testable due to lack of global history infrastructure in DRT.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

05/28/11:

21:42 Changeset [87633] by ap@apple.com

Suggested by Simon Fraser.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use ASSERT_UNUSED here.
19:46 Changeset [87632] by mrowe@apple.com

Merge r87624.

19:44 Changeset [87631] by mrowe@apple.com

Merge r87622.

19:42 Changeset [87630] by mrowe@apple.com

Merge r87627.

19:41 Changeset [87629] by mrowe@apple.com

Merge r87598.

18:37 Changeset [87628] by ap@apple.com

Reviewed by Geoff Garen.

REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
https://bugs.webkit.org/show_bug.cgi?id=61692
<rdar://problem/9488628>

Test: fast/dom/gc-image-element-2.html

Manually verified that tests from bug 59604 and from bug 40926 still pass.

The problem here was that HTMLImageElement::hasPendingActivity() could return false when
a load (or error) event was still expected to fire.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::setRequest):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::wasCanceled): (WebCore::CachedResource::errorOccurred): Track whether the load was canceled. We want to always notify clients of load outcome, as that's the only way they could make intelligent decisions.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now get a notifyFinished call on cancellation. Handle this case, where we don't need the execute the script, but also don't need to fire an error event.
  • html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single function call now.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large window between when CachedResource::isLoading() becomes false and events are queued. ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting an event to fire.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do anything on cancellation.
  • loader/ImageLoader.cpp: (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to give an accurate result while looping over the list of events to dispatch. (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to switch to a broken image icon, or to dispatch events. (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching list, as the event is no longer pending when it's being dispatched.
  • loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one is already pending, we only care if one is expected at some time in the future, and !haveFiredLoadEvent() is our best idea of that.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to handle cancellation.
16:45 Changeset [87627] by simon.fraser@apple.com

2011-05-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Maciej Stachowiak.

Denying access to your keychain on login crashes WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61695
<rdar://problem/9520570>

Fix two sources of crashes if you hit the Deny button when WebKit2 is
doing HTTP authentication.

First, SecKeychainItemRequestData::attributeList() failed to initialize the
length and data members of SecKeychainAttributes in the list if there was no data.
This caused invalid memory reads later.

Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
would cause a later crash in a system framework, which is not set up to handle
errors. Instead, we always return noErr, and allow the authentication to fail.

Finally, paranoically initialize the SecKeychainItemContext in two places
to avoid uninitialized data members, and initialize length and outData
to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
fails to set them on error.

  • Shared/mac/SecKeychainItemRequestData.cpp: (WebKit::SecKeychainItemRequestData::attributeList):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::secKeychainItemCopyContent):
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCopyContent): (WebKit::webSecKeychainItemCreateFromContent):
15:26 Changeset [87626] by abarth@webkit.org

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS builds patches that fail to build twice, which seems useless and slows down the bots
https://bugs.webkit.org/show_bug.cgi?id=55585

This patch switches all the early warning system bots over to the new
PatchAnalysisTask-based infrastructure. This patch makes these bots
more efficient (in the case where patches fail to build) and paves the
way for running tests on these bots!

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
14:45 Changeset [87625] by mrobinson@webkit.org

2011-05-28 Martin Robinson <mrobinson@igalia.com>

Skip a failing test and better classify some existing skipped tests.

  • platform/gtk/Skipped: Update the skipped list.
13:39 Changeset [87624] by andersca@apple.com

2011-05-28 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r86578): Flash content missing from mercurynews.com
https://bugs.webkit.org/show_bug.cgi?id=61691
<rdar://problem/9519893>

If the plug-in doesn't have access to the toplevel URL, make sure to
return *something* to the plug-in.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
12:59 Changeset [87623] by abarth@webkit.org

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::cancelledError): (WebCore::FrameLoaderClientQt::blockedError): (WebCore::FrameLoaderClientQt::objectContentType): (WebCore::FrameLoaderClientQt::createPlugin):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest): (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::cancelledError): (WebCore::FrameLoaderClientEfl::blockedError):
  • ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): (ewk_frame_uri_changed):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_frame_create): (ewk_view_plugin_create):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

As far as I can tell, all the callers of this API are confused. There
seems to be a cargo cult of using the "pretty" version of a URL, but in
reality folks just want the URL itself. The only case I'm unsure about
is location.href, which could have some compatibility constraints.
I've renamed prettyURL to deprecatedString to discourage folks from
further cargo-culting.

  • WebCore.exp.in:
  • page/Location.cpp: (WebCore::Location::href): (WebCore::Location::toString):
  • platform/KURL.cpp: (WebCore::KURL::deprecatedString):
  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURL::deprecatedString):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL):
  • workers/WorkerLocation.cpp: (WebCore::WorkerLocation::href): (WebCore::WorkerLocation::toString):

2011-05-28 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Audit all uses of KURL::prettyURL
https://bugs.webkit.org/show_bug.cgi?id=61201

Update callers of prettyURL to just call string.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::cancelledError): (WebKit::blockedError):
12:41 Changeset [87622] by jer.noble@apple.com

2011-05-28 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Mouse clicks propagate outside full-screen media controls.
https://bugs.webkit.org/show_bug.cgi?id=61689

Mouse click events are propagating out of the media controls, so mouse click
listeners registered on the video element are getting fired when the user
clicks on media controller buttons. By default, block propagation of click
events from MediaControlElements by overriding preDispatchEventHandler, and
convert all instances of defaultEventHandler -> preDispatchEventHandler. Change
all calls of event->setDefaultHandled() to event->stopPropagation().

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlElement::preDispatchEventHandler): Added. Block

propagation of all mouse click events.

(WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):

Renamed from setDefaultHandled.

(WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

  • html/shadow/MediaControlElements.h:
11:49 Changeset [87621] by mrowe@apple.com

Versioning.

11:37 Changeset [87620] by mrowe@apple.com

New tag.

11:37 Changeset [87619] by mrowe@apple.com

Merge r87331.

11:18 Changeset [87618] by commit-queue@webkit.org

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

  • fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-28 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prevent HTMLLinkElement from watching multiple CachedResources
https://bugs.webkit.org/show_bug.cgi?id=61686

If we modify an existing link element, stop listening to the previous
cached resource, to prevent double notifications (which crash).

Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
10:55 Changeset [87617] by commit-queue@webkit.org

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

Adding cases that test invalid properties.

  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-computed-trace.html:

2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: there is a problem with computed style properties with wrong values
https://bugs.webkit.org/show_bug.cgi?id=60535

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
10:02 Changeset [87616] by tonikitoo@webkit.org

2011-05-26 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial lyAligned
https://bugs.webkit.org/show_bug.cgi?id=61606

Removed duplicated statement within if condition.

No new tests. Obvious clean up patch.

  • page/SpatialNavigation.cpp: (WebCore::areRectsPartiallyAligned):
09:16 Changeset [87615] by mnaganov@chromium.org

[Chromium] Unreviewed, clean up GPU tests expectations

08:43 Changeset [87614] by ddkilzer@apple.com

BUILD FIX when building only the interpreter

Fixes the following compiler warning:

JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]

void releaseExecutableMemory(JSGlobalData& globalData)


  • jit/ExecutableAllocator.h: Moved declaration of

JSC::releaseExecutableMemory().

08:27 Changeset [87613] by mnaganov@chromium.org

[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

08:24 Changeset [87612] by ddkilzer@apple.com

BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode): Added missing argument.

05:15 Changeset [87611] by robert@webkit.org

2011-05-28 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
https://bugs.webkit.org/show_bug.cgi?id=60311

If there is no editable text Qt interprets backspace as a navigation
command, regardless of platform.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.
05:06 Changeset [87610] by mnaganov@chromium.org

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

03:32 Changeset [87609] by mnaganov@chromium.org

[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

01:50 Changeset [87608] by mnaganov@chromium.org

2011-05-28 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed. Test expectations update after r87605

  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.
01:27 Changeset [87607] by bashi@chromium.org

2011-05-28 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

Add bashi as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61685

  • Scripts/webkitpy/common/config/committers.py:
00:17 Changeset [87606] by commit-queue@webkit.org

2011-05-28 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/style/non-inheritable-styles should be dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61681

Converts the test to dump-as-markup and cleans up the HTML a bit.

  • editing/style/non-inheritable-styles-expected.txt: Added.
  • editing/style/non-inheritable-styles.html:
  • platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
  • platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

05/27/11:

23:52 Changeset [87605] by zimmermann@webkit.org

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, this just adds a new test.

WebKit fails WICD SVG background image tests
https://bugs.webkit.org/show_bug.cgi?id=16481

Add two WICD SVG background image tests, which pass just fine.

  • svg/wicd/resources/test-scalable-background-image1.css: Added. (html): (body): (p):
  • svg/wicd/resources/test-scalable-background-image1.svg: Added.
  • svg/wicd/resources/test-scalable-background-image2.css: Added. (html):
  • svg/wicd/resources/test-scalable-background-image2.svg: Added.
  • svg/wicd/test-scalable-background-image1.xhtml: Added.
  • svg/wicd/test-scalable-background-image2.xhtml: Added.
23:19 Changeset [87604] by commit-queue@webkit.org

2011-05-27 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

editing/inserting/insert-3907422 should be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=61680

Converted to dumpAsMarkup and cleaned up markup.

  • editing/inserting/insert-3907422-fix-expected.txt: Added.
  • editing/inserting/insert-3907422-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.
22:13 Changeset [87603] by mrowe@apple.com

Versioning.

22:13 Changeset [87602] by mrowe@apple.com

New tag.

21:48 Changeset [87601] by abarth@webkit.org

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

When checking whether the tree is red, the EWS posts a link to the wrong log
https://bugs.webkit.org/show_bug.cgi?id=61072

We need to cache the original script error because that contains the
failure log we want to upload. If we don't cache that script error,
self._script_error will get overwritten when we sanity check the clean
tree (and it also has test failures).

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • This testing approach is slightly goofy. We'd like to use assertRaisesRegexp, but that's not available until Python 2.7.
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
21:42 Changeset [87600] by mrowe@apple.com

Merge r87599.

21:39 Changeset [87599] by mrowe@apple.com

Roll out r87544 since it is bogus.

21:18 Changeset [87598] by simon.fraser@apple.com

2011-05-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CG BitmapImage needs to check for valid CGImage in a couple of places
https://bugs.webkit.org/show_bug.cgi?id=61684
<rdar://problem/9519348>

BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
returns null, which it may do if the image is corrupted or still
loading. Protect against that here and in getFirstCGImageRefOfSize().

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::getFirstCGImageRefOfSize): (WebCore::BitmapImage::getCGImageArray):
20:27 Changeset [87597] by jochen@chromium.org

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • platform/chromium/permissionclient/storage-permission-expected.txt: Added.
  • platform/chromium/permissionclient/storage-permission.html: Added.

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add Frame parameter to all StorageArea methods. The chromium
embedder uses the Frame as context to decide whether or not
to allow usage of the storage API.
https://bugs.webkit.org/show_bug.cgi?id=61581

Test: platform/chromium/permissionclient/storage-permission.html

  • storage/Storage.cpp: (WebCore::Storage::length): (WebCore::Storage::key): (WebCore::Storage::getItem): (WebCore::Storage::contains):
  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::getItem): (WebCore::StorageAreaImpl::contains):
  • storage/StorageAreaImpl.h:

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Check access policy on all storage operations
https://bugs.webkit.org/show_bug.cgi?id=61581

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains): (WebCore::StorageAreaProxy::canAccessStorage):
  • src/StorageAreaProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem):

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add layoutTestController.setStorageAllowed() to control whether access
to the localStorage API is enabled via the WebPermissionClient
https://bugs.webkit.org/show_bug.cgi?id=61581

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebPermissions.h: Added. (WebPermissions::WebPermissions): (WebPermissions::allowStorage): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
19:28 Changeset [87596] by dpranke@chromium.org

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
https://bugs.webkit.org/show_bug.cgi?id=60326

This patch removes a lot of the complexity from the
metered_stream implementation that was unnecessary since there
was only one caller and the logic could be coordinated better.

There should be no functional changes in this patch, just code
getting deleted and cleaned up.

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
19:24 Changeset [87595] by japhet@chromium.org

2011-05-27 Nate Chapin <japhet@chromium.org>

Reviewed by Jian Li.

Keep a reference to BlobResourceHandle before calling doNotifyFinish()
asynchronously to ensure it's still safe in the main thread.

https://bugs.webkit.org/show_bug.cgi?id=61669

I triggered this crash in fast/files/file-reader-abort.html during a
refactor that changed timings slightly.

  • platform/network/BlobResourceHandle.cpp: (WebCore::doNotifyFinish): (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/BlobResourceHandle.h: (WebCore::BlobResourceHandle::aborted):
19:16 Changeset [87594] by dpranke@chromium.org

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: minor cleanup in printing module
https://bugs.webkit.org/show_bug.cgi?id=60329

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
19:11 Changeset [87593] by dpranke@chromium.org

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

NRWT: remove --print detailed-progress
https://bugs.webkit.org/show_bug.cgi?id=60324

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:00 Changeset [87592] by sjl@chromium.org

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Add sjl@chromium.org as a committer.

https://bugs.webkit.org/show_bug.cgi?id=61672

  • Scripts/webkitpy/common/config/committers.py:
18:56 Changeset [87591] by dpranke@chromium.org

2011-05-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

NRWT: debug messages from the workers are being logged twice
https://bugs.webkit.org/show_bug.cgi?id=60428

It looks like when the workers are run in separate processes
we end up getting two copies of every log message they print.
This has to do with the multiprocessing module on UNIX cloning
the log configuration in a way I wasn't expecting, and so two
log handlers end up getting registered.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:24 Changeset [87590] by adamk@chromium.org

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Hopefully last rebaseline from r87526.

  • platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
17:30 Changeset [87589] by adamk@chromium.org

Unreviewed test expectations update: Vista flakiness.

17:28 Changeset [87588] by ggaren@apple.com

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

JS API is too aggressive about throwing exceptions for NULL get or set operations
https://bugs.webkit.org/show_bug.cgi?id=61678

  • API/JSCallbackObject.h: Changed our staticValueGetter to a regular function that returns a JSValue, so it can fail and still forward to normal property lookup.
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): Don't throw an exception when failing to access a static property -- just forward the access. This allows objects to observe get/set operations but still let the JS object manage lifetime.

(JSC::::put): Ditto.

(JSC::::getStaticValue): Same as JSCallbackObject.h.

  • API/tests/testapi.c: (MyObject_set_nullGetForwardSet):
  • API/tests/testapi.js: Updated tests to reflect slightly less strict behavior, which matches headerdoc claims.
17:26 Changeset [87587] by adamk@chromium.org

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Even more rebaselines after r87526.

  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:53 Changeset [87586] by ggaren@apple.com

2011-05-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Property caching is too aggressive for API objects
https://bugs.webkit.org/show_bug.cgi?id=61677

  • API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our callback APIs allow the client to change its mind about our propertis at any time.
  • API/tests/testapi.c: (PropertyCatchalls_getProperty): (PropertyCatchalls_setProperty): (PropertyCatchalls_getPropertyNames): (PropertyCatchalls_class): (main):
  • API/tests/testapi.js: Some tests for dynamic API objects.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client requires it.
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::isFinal): (JSC::TypeInfo::prohibitsPropertyCaching): (JSC::TypeInfo::flags): Added a flag to track opting out of property caching. Fixed an "&&" vs "&" typo that was previously harmless, but is now harmful since m_flags2 can have more than one bit set.
16:34 Changeset [87585] by mrowe@apple.com

Merge r87578.

16:21 Changeset [87584] by adamk@chromium.org

Unreviewed test expectations update: widen flakiness to include Linux.

16:18 Changeset [87583] by sjl@chromium.org

2011-05-27 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

The behaviour of controls-after-reload was causing
layoutTestController in DumpRenderTree to misbehave causing a reported
failure in the test run after it (controls-css-overload).

Effectively, notifyDone() ended up getting called again after the test
was being torn down.

This change removes the unneeded seek at the end of the test (as we
should have already seeked to 0.

https://bugs.webkit.org/show_bug.cgi?id=60132

  • media/controls-after-reload.html:
  • platform/chromium/test_expectations.txt:
16:09 Changeset [87582] by mrowe@apple.com

Merge r87580.

16:09 Changeset [87581] by mrowe@apple.com

Merge r87520.

15:57 Changeset [87580] by slewis@apple.com

Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
15:49 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:48 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:48 Writing Layout Tests for DumpRenderTree edited by abarth@webkit.org
(diff)
15:32 Changeset [87579] by adamk@chromium.org

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. More rebaselines after r87526.

  • platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-linux/svg/in-html/by-reference-expected.txt:
  • platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:14 Changeset [87578] by andersca@apple.com

2011-05-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Always use the default localization strategy
https://bugs.webkit.org/show_bug.cgi?id=61670
<rdar://problem/9516130>

Always use the default localization strategy when there's no platform strategy.

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::shared):
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultDetailsSummaryText): (WebCore::copyImageUnknownFileLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagCopyImageUrlToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagSelectAll): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchInSpotlight): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagShowFonts): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagStyles): (WebCore::contextMenuItemTagShowColors): (WebCore::contextMenuItemTagSpeechMenu): (WebCore::contextMenuItemTagStartSpeaking): (WebCore::contextMenuItemTagStopSpeaking): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagCorrectSpellingAutomatically): (WebCore::contextMenuItemTagSubstitutionsMenu): (WebCore::contextMenuItemTagShowSubstitutions): (WebCore::contextMenuItemTagSmartCopyPaste): (WebCore::contextMenuItemTagSmartQuotes): (WebCore::contextMenuItemTagSmartDashes): (WebCore::contextMenuItemTagSmartLinks): (WebCore::contextMenuItemTagTextReplacement): (WebCore::contextMenuItemTagTransformationsMenu): (WebCore::contextMenuItemTagMakeUpperCase): (WebCore::contextMenuItemTagMakeLowerCase): (WebCore::contextMenuItemTagCapitalize): (WebCore::contextMenuItemTagChangeBack): (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXARIAContentGroupText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::missingPluginText): (WebCore::crashedPluginText): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::uploadFileText): (WebCore::allFilesText): (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName): (WebCore::imageTitle): (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
14:55 Changeset [87577] by mrowe@apple.com

Merge r87566.

14:50 Changeset [87576] by mrowe@apple.com

Merge r87330.

14:50 Changeset [87575] by mrowe@apple.com

Merge r87228.

14:43 Changeset [87574] by mrowe@apple.com

Merge r87460.

14:37 Changeset [87573] by mrowe@apple.com

Merge r87329.

14:36 Changeset [87572] by adamk@chromium.org

[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

14:33 Changeset [87571] by mrowe@apple.com

Merge r87557.

14:25 Changeset [87570] by mrowe@apple.com

Merge r87414.

14:20 Changeset [87569] by mrowe@apple.com

Merge r87456.

14:18 Changeset [87568] by mrowe@apple.com

Merge r87322.

14:16 Changeset [87567] by mrowe@apple.com

Merge r87363.

14:15 Changeset [87566] by beidson@apple.com

First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
14:15 Changeset [87565] by mrowe@apple.com

Merge r87328.

14:12 Changeset [87564] by mrowe@apple.com

Merge r87442.

14:10 Changeset [87563] by mrowe@apple.com

Merge r87544.

14:08 Changeset [87562] by mrowe@apple.com

Merge r87421.

14:05 Changeset [87561] by enne@google.com

2011-05-27 Adrienne Walker <enne@google.com>

[chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
14:02 Changeset [87560] by mrowe@apple.com

Merge r87335.

13:59 Changeset [87559] by mrowe@apple.com

Merge r87397.

13:56 Changeset [87558] by adamk@chromium.org

2011-05-27 Adam Klein <adamk@chromium.org>

Unreviewed. Rebaselines and test expectations updates after r87526.

  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium/test_expectations.txt:
13:53 Changeset [87557] by jer.noble@apple.com

2011-05-27 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

30 second rewind button obscured in fullscreen controller
https://bugs.webkit.org/show_bug.cgi?id=61663

If reset() is called while in full-screen mode, make sure to show and hide
the correct controls for that mode.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
13:53 Changeset [87556] by mrowe@apple.com

Merge r87305.

13:51 Changeset [87555] by mrowe@apple.com

Merge r87272.

13:50 Changeset [87554] by mrowe@apple.com

Merge r87237.

13:48 Changeset [87553] by mrowe@apple.com

Merge r87387.

13:45 Changeset [87552] by mrowe@apple.com

Merge r87458.

13:43 Changeset [87551] by mrowe@apple.com

Merge r87524.

13:39 Changeset [87550] by paroga@webkit.org

2011-05-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.

  • runtime/JSGlobalData.cpp: (JSGlobalData::JSGlobalData):
13:37 Changeset [87549] by mrowe@apple.com

Merge r87361.

13:35 Changeset [87548] by mrowe@apple.com

Merge r87324.

13:29 Changeset [87547] by jamesr@google.com

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

  • compositing/iframes/resizer-expected.txt: Added.
  • compositing/iframes/resizer.html: Added.

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
https://bugs.webkit.org/show_bug.cgi?id=61590

Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
backing is parented. This ensures that the scroll corner layer for an iframe without a clipping layer ends up
in the final layer tree. We don't currently render resizers for iframes, but we will soon and this keeps the
graphics layer tree consistent.

Test: compositing/iframes/resizer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
13:28 Changeset [87546] by mrowe@apple.com

Merge r87253.

13:25 Changeset [87545] by zimmermann@webkit.org

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fix last failing win/svg test, put result in correct directory.

  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.
13:22 Changeset [87544] by jeffm@apple.com

<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

  • WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).
13:21 Changeset [87543] by rniwa@webkit.org

Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.

13:18 Changeset [87542] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
The feature is tracked by the bug 61630.

  • platform/gtk/Skipped:
13:10 Changeset [87541] by mrowe@apple.com

Merge r87244.

13:10 Changeset [87540] by mrowe@apple.com

Merge r87275.

12:53 Changeset [87539] by abarth@webkit.org

2011-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLVideoElement::currentSrc() should return a KURL
https://bugs.webkit.org/show_bug.cgi?id=61578

I suspect we got into this mess because the author of this code didn't
know about the URL attribute in WebKit IDL, which is super useful!

Bad news: The line of code in question seems to have another bug, which
I've documented in a FIXME. Let the yak shaving continue!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::currentSrc): (WebCore::HTMLMediaElement::currentURL):
  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
    • This complete URL call was unnecessary because currentSrc is already absolute.
12:52 Changeset [87538] by mnaganov@chromium.org

2011-05-27 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=61177

  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className):
12:50 Changeset [87537] by aroben@apple.com

Always decode tester names from location.hash

When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.

12:48 Changeset [87536] by oliver@apple.com

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add a few validity assertions to JSCallbackObject
https://bugs.webkit.org/show_bug.cgi?id=61659

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::visitChildren):
12:44 Changeset [87535] by zimmermann@webkit.org

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Rebaseline some qt/win/leopard results.

  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
12:32 Changeset [87534] by zimmermann@webkit.org

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Fixes crash in svg/custom/immutable-properties.html, seen on the bots.

  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.
12:32 Changeset [87533] by enne@google.com

2011-05-27 Nat Duca <nduca@chromium.org>

Unreviewed, landed by enne@google.com.

[chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
https://bugs.webkit.org/show_bug.cgi?id=61652

  • platform/chromium/test_expectations.txt:
11:56 Changeset [87532] by rniwa@webkit.org

Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.

11:52 Changeset [87531] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61610

Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.

  • editing/pasteboard/paste-pre-001-expected.txt: Added.
  • editing/pasteboard/paste-pre-001.html:
  • editing/pasteboard/paste-pre-002-expected.txt: Added.
  • editing/pasteboard/paste-pre-002.html:
  • platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.
11:49 Changeset [87530] by aroben@apple.com

Remove testing code that snuck into r87528

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.

11:47 Changeset [87529] by oliver@apple.com

Build fix

11:41 Changeset [87528] by aroben@apple.com

Add links to TestFailures to easily file bugs about failing tests

Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!

11:30 Changeset [87527] by oliver@apple.com

2011-05-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Try to release unused executable memory when the FixedVMPool allocator is under pressure
https://bugs.webkit.org/show_bug.cgi?id=61651

Rather than crashing when full the FixedVMPool allocator now returns a null
allocation. We replace the code that used to CRASH() on null allocations
with logic that asks the provided globalData to release any executable memory
that it can. Currently this just means throwing away all regexp code, but
in future we'll try to be more aggressive.

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
  • assembler/ARMAssembler.h:
  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::executableCopy):
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::linkCode):
  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::executableCopy):
  • assembler/SH4Assembler.h: (JSC::SH4Assembler::executableCopy):
  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy): (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::create): (JSC::ExecutablePool::alloc): (JSC::ExecutableAllocator::ExecutableAllocator): (JSC::ExecutableAllocator::poolForSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::alloc):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator): (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::releaseExecutableMemory): (JSC::releaseExecutableMemory):
  • runtime/JSGlobalData.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::invalidateCode):
  • runtime/RegExpCache.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::compile):
11:27 Changeset [87526] by zimmermann@webkit.org

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
  • http/tests/misc/resources/embedded.svg: Added.
  • http/tests/misc/resources/svg-slow.pl: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
  • svg/custom/object-no-size-attributes.xhtml: Added.
  • svg/custom/object-sizing-explicit-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Added.
  • svg/custom/object-sizing-explicit-width.xhtml: Added.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
  • svg/custom/object-sizing-no-width-height.xhtml: Added.
  • svg/custom/object-sizing.xhtml: Added.
  • svg/custom/resources/embedded.svg: Added.
  • svg/custom/resources/red-circle.svg: Added.
  • svg/in-html/by-reference-expected.png:
  • svg/wicd: Added.
  • svg/wicd/resources: Added.
  • svg/wicd/resources/a.svg: Added.
  • svg/wicd/resources/bcde.svg: Added.
  • svg/wicd/resources/empty1.svg: Added.
  • svg/wicd/resources/empty2.svg: Added.
  • svg/wicd/resources/empty3.svg: Added.
  • svg/wicd/resources/f.svg: Added.
  • svg/wicd/resources/g.svg: Added.
  • svg/wicd/resources/h.svg: Added.
  • svg/wicd/resources/i.svg: Added.
  • svg/wicd/resources/j.svg: Added.
  • svg/wicd/resources/k.svg: Added.
  • svg/wicd/resources/l.svg: Added.
  • svg/wicd/resources/main.css: Added. (body,html): (body): (.buttons): (h1): (h2): (h4): (p): (table): (th): (td,th): (td a): (a): (a:hover): (a:focus): (a:visited): (a.index): (a.index:hover): (a.index:focus): (a.index:visited): (ul): (ol): (.red): (.navi): (.navi a): (.navi a:hover): (.navi a:visited):
  • svg/wicd/resources/mnop.svg: Added.
  • svg/wicd/resources/q.svg: Added.
  • svg/wicd/resources/r.svg: Added.
  • svg/wicd/resources/s.svg: Added.
  • svg/wicd/resources/t.svg: Added.
  • svg/wicd/resources/test-rightsizing-a.css: Added. (html,body): (div.all): (object.w100): (object.h100):
  • svg/wicd/resources/test-rightsizing-b.css: Added. (html,body): (object):
  • svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
  • svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
  • svg/wicd/rightsizing-grid.xhtml: Added.
  • svg/wicd/test-rightsizing-a.xhtml: Added.
  • svg/wicd/test-rightsizing-b.xhtml: Added.
  • svg/zoom/page/resources: Added.
  • svg/zoom/page/resources/absolute-sized-svg.png: Added.
  • svg/zoom/page/resources/absolute-sized-svg.svg: Added.
  • svg/zoom/page/resources/huge-rect.svg: Added.
  • svg/zoom/page/resources/percentage-sized-svg.png: Added.
  • svg/zoom/page/resources/percentage-sized-svg.svg: Added.
  • svg/zoom/page/resources/text.svg: Added.
  • svg/zoom/page/resources/tux.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

<object> tags should treat width/height on a referenced SVG as intrinsic width/height
https://bugs.webkit.org/show_bug.cgi?id=11976

Incorrect handling of percentage values for width/height on embedded elements
https://bugs.webkit.org/show_bug.cgi?id=14793

WebKit fails some WICD 1.0 core test cases
https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

SVG embedded as <object> doesn't respect width/height attributes
https://bugs.webkit.org/show_bug.cgi?id=34972

Explicit size of object tag ignored
https://bugs.webkit.org/show_bug.cgi?id=37086

Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

SVG 1.1 says:
The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
...
and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
the positioning properties establish the viewport's width.

If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
This requires a negotiation between the host document and the embedded document.
(There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml

svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
svg/custom/object-sizing-explicit-width-height.xhtml
svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
svg/custom/object-sizing-no-width-height.xhtml
svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
svg/wicd/test-rightsizing-a.xhtml (ditto)
svg/wicd/test-rightsizing-b.xhtml (ditto)
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-text.xhtml

  • platform/Length.h: (WebCore::Length::isSpecified):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedSVGContentRenderer): (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight): (WebCore::RenderPart::layout):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::computeIntrinsicRatio): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::determineViewport):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentViewBoxRect): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h:
11:11 Changeset [87525] by jochen@chromium.org

2011-05-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] drop unused WebFrame parameter to WebStorageArea::setItem
https://bugs.webkit.org/show_bug.cgi?id=61583

  • public/WebStorageArea.h:
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
  • src/WebStorageAreaImpl.h:
10:52 Changeset [87524] by msaboff@apple.com

2011-05-27 Michael Saboff <msaboff@apple.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=61646
Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font

Change the platformIsEqual to just compare the m_font members if
either is not null.

No tests added - functionality unchanged, fixing memory abandonment.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::platformIsEqual):
10:39 Changeset [87523] by mrobinson@webkit.org

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

Added a GTK+ specific test that verifies that zero pixel sized
fonts do not corrupt the Cairo context.

  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
  • platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.

2011-05-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK][Cairo] Twitter rendering breaks
https://bugs.webkit.org/show_bug.cgi?id=60917

When instantiating a cairo_scaled_font_t font would put the font in an error state,
leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
in the error state can later lead to corrupted rendering.

Due to this change, we must always null check cairo_scaled_font_t and the platform
data now carries the cairo_font_face_t object with it, so that it can be accessed later
if there is no cairo_scaled_font_t.

Test: platform/gtk/fonts/zero-pixel-sized-fonts.html

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
  • platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Initialize the new member. (WebCore::FontPlatformData::operator=): Carry over the new member. (WebCore::FontPlatformData::operator==): Check equality with the new member. (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont put the font into an error state, then just free it and return. (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap when the scaled font is null, because rendering is always a no-op and the font data never needs to be read.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font. (WebCore::SimpleFontData::scaledFontData): Use the new m_font member. (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
10:39 Changeset [87522] by ggaren@apple.com

2011-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Optimized ConservativeSet to avoid double-visiting objects
https://bugs.webkit.org/show_bug.cgi?id=61592


SunSpider thinks this might be a 1% speedup

  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting an object.
  • heap/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::testAndClearMarked): (JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type to void*, since clients want to ask questions about arbitrary pointers into the heap, even when they aren't known to be JSCells.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::testAndClearMarked):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::testAndClearMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Ditto.
  • wtf/Bitmap.h: (WTF::::testAndClear): New function for ConservativeRoots's inverted marking pass.
10:25 Changeset [87521] by levin@chromium.org

Need a callback for when the preferred rendered size may have changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

  • page/Chrome.cpp:

(WebCore::Chrome::layoutUpdated): Plumbed through the call.

  • page/Chrome.h: Added the new method.
  • page/ChromeClient.h:

(WebCore::ChromeClient::layoutUpdated): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Added a callback for whem a layout has finished.

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didUpdateLayout): Added stub.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.

  • src/ChromeClientImpl.h: Added declaration.
09:59 Changeset [87520] by slewis@apple.com

Rubber Stamped by Adam Roben.

Source/JavaScriptCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

Source/WebCore:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebCore.order:

Source/WebKit/mac:

Update Order Files. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • WebKit.order:

Source/WebKit2:

Add Order File. Use -order_file flag since it can order more of the binary.

  • Configurations/Base.xcconfig:
  • mac/WebKit2.order: Added.
09:34 Changeset [87519] by commit-queue@webkit.org

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • http/tests/websocket/tests/client-close-expected.txt: Removed.
  • http/tests/websocket/tests/client-close.html: Removed.
  • http/tests/websocket/tests/client-close_wsh.py: Removed.
  • http/tests/websocket/tests/close-before-open-expected.txt:
  • http/tests/websocket/tests/close-event-expected.txt:
  • http/tests/websocket/tests/close-event.html:
  • http/tests/websocket/tests/close-unref-websocket-expected.txt:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/server-close-expected.txt: Removed.
  • http/tests/websocket/tests/server-close.html: Removed.
  • http/tests/websocket/tests/server-close_wsh.py: Removed.
  • http/tests/websocket/tests/websocket-event-target-expected.txt:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): (WebCore::SocketStreamHandleBase::close): (WebCore::SocketStreamHandleBase::sendPendingData):
  • platform/network/SocketStreamHandleBase.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Peer::close): (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:

2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87464.
http://trac.webkit.org/changeset/87464
https://bugs.webkit.org/show_bug.cgi?id=61643

client-close/server-close tests are flaky on Chromium Mac and
Windows (Requested by aklein on #webkit).

  • Scripts/webkitpy/thirdparty/init.py:
09:19 Changeset [87518] by rwlbuis@webkit.org

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Remove 003-broken.xml and replace it with a 003.xml that is text-only.

  • platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
  • svg/hixie/links/003-broken.xml: Removed.
  • svg/hixie/links/003-expected.txt: Added.
  • svg/hixie/links/003.xml: Added.

2011-05-27 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=19995
hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

Only allow links to animation elements within the document.

Test: svg/hixie/links/003.xml

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
09:14 Changeset [87517] by carlosgc@webkit.org

2011-05-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
https://bugs.webkit.org/show_bug.cgi?id=60757

cairo_image_surface_create_for_data() is already a shallow copy of
the image, so we don't need to copy it again.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint):
09:10 Changeset [87516] by adamk@chromium.org

[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

08:41 Changeset [87515] by ap@apple.com

Added Douglas Davidson to contributors list for easier CC'ing.

  • Scripts/webkitpy/common/config/committers.py:
08:34 Changeset [87514] by alexis.menard@openbossa.org

2011-05-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
https://bugs.webkit.org/show_bug.cgi?id=61044

Make sure to set the active window on the application too.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette):
08:19 Changeset [87513] by yael.aharon@nokia.com

Unreviewed.

WebKit2 does not support eventSender.

  • platform/mac-wk2/Skipped:
08:03 Changeset [87512] by andreas.kling@nokia.com

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

HTML5 now specifies that fully transparent colors should have their alpha value
serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)

The number of decimals for alpha values between 0 and 1 is not specified,
so match Gecko and Presto by returning the lowest number of decimals needed
to represent the number. (No more trailing zeroes.)

  • platform/graphics/Color.cpp: (WebCore::Color::serialized):

2011-05-27 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Update RGBA color serialization to match HTML5.
https://bugs.webkit.org/show_bug.cgi?id=61449

Update tests to reflect the new behavior.

  • canvas/philip/tests/2d.fillStyle.get.transparent.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
  • canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
  • editing/style/inline-style-container-expected.txt
  • editing/style/script-tests/inline-style-container.js:
  • fast/canvas/canvas-color-clamping-expected.txt:
  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/canvas-currentColor-expected.txt:
  • fast/canvas/script-tests/canvas-color-clamping.js:
  • fast/canvas/script-tests/canvas-color-serialization.js:
  • fast/canvas/script-tests/canvas-currentColor.js:
  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
  • fast/dom/canvasContext2d-element-attribute-js-null.html:
07:35 Changeset [87511] by yael.aharon@nokia.com

Unreviewed.

Skip a test that requires eventSender.beginDragWithFiles.

  • platform/win/Skipped:
07:23 Changeset [87510] by yael.aharon@nokia.com

Unreviewed.

Skip a test that is failing until investigated.

  • platform/gtk/Skipped:
07:19 Changeset [87509] by jeffm@apple.com

2011-05-26 Jeff Miller <jeffm@apple.com>

Reviewed by Alexey Proskuryakov.

Add a key handling logging channel for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61588


Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

  • Platform/Logging.cpp: (WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
  • Platform/Logging.h: Added LogKeyHandling channel.
  • UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment. (WebKit::webKeyboardEventTypeString): Added to support logging. (WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event. (WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.
07:02 Changeset [87508] by hans@chromium.org

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

New test for adding new entries to an objecet store while running a
cursor over it.

  • storage/indexeddb/mutating-cursor-expected.txt: Added.
  • storage/indexeddb/mutating-cursor.html: Added.

2011-05-27 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support mutating cursors on top of LevelDB
https://bugs.webkit.org/show_bug.cgi?id=61615

We need to support the case where a new node is added to the tree in a
transaction after the TreeIterator has covered the whole tree.

Since this is done lazily, i.e. we set a flag that the tree might have
changed, and act upon it later, some members need to be mutable,
because we might need to re-seek the tree iterator in a const function.

Test: storage/indexeddb/mutating-cursor.html

storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)

  • platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::set): (WebCore::LevelDBTransaction::TreeIterator::reset): (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator): (WebCore::LevelDBTransaction::TreeIterator::TreeIterator): (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator): (WebCore::LevelDBTransaction::TransactionIterator::next): (WebCore::LevelDBTransaction::TransactionIterator::prev): (WebCore::LevelDBTransaction::TransactionIterator::key): (WebCore::LevelDBTransaction::TransactionIterator::value): (WebCore::LevelDBTransaction::TransactionIterator::treeChanged): (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator): (WebCore::LevelDBTransaction::registerIterator): (WebCore::LevelDBTransaction::unregisterIterator): (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
  • platform/leveldb/LevelDBTransaction.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::open):
06:51 Changeset [87507] by commit-queue@webkit.org

2011-05-27 Sujin Park <sujjin.park@gmail.com>

Unreviewed, buildfix if --no-javascript-debugger.

Regression(R84125): Broke GTK build
https://bugs.webkit.org/show_bug.cgi?id=60698

No new tests since this doesn't change any behavior.

  • inspector/WorkerInspectorController.h:
06:48 Changeset [87506] by ossy@webkit.org

[Qt][Mac] Daily gardening.

Typo fix, and remove non-existent files from Skipped list.

  • platform/qt-mac/Skipped:
06:12 Changeset [87505] by ossy@webkit.org

[Qt][Mac] Daily gardening.

  • platform/qt-mac/Skipped:
    • plugins/embed-attributes-setting.html was unskipped by r87306, but fails on Qt-Mac.
    • plugins/plugin-initiate-popup-window.html unskipped by r87429, but fails on Qt-Mac.
    • fast/css/disabled-author-styles unskipped by r87311, but fails on Qt-Mac.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Added after r87468.
05:59 Changeset [87504] by yael.aharon@nokia.com

Unreviewed.

Skip test that is failing on the bot, until investigated.

  • platform/chromium/test_expectations.txt:
05:48 Changeset [87503] by yael.aharon@nokia.com

Unreviewed.

Skip new dropzone tests. Qt's DRT does not support drag 'n drop.

  • platform/qt/Skipped:
05:46 Changeset [87502] by mnaganov@chromium.org

[Chromium] Unreviewed, suppress editing/pasteboard/smart-paste-004.html on Win after r87496

05:43 Changeset [87501] by mnaganov@chromium.org

[Chromium] Unreveiwed, suppress editing/pasteboard/smart-paste-003.html on Win after r87495

05:42 Changeset [87500] by ossy@webkit.org

[WK2] Skip new failing tests because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped: Add failing tests.
  • platform/qt-wk2/Skipped: Remove tests, because they fail because of WK2 specific bug, not Qt-WK2 specific.
05:37 Changeset [87499] by yael.aharon@nokia.com

webkit should implement the dropzone attribute
https://bugs.webkit.org/show_bug.cgi?id=58210

Reviewed by Tony Chang.

Source/WebCore:

Add support for dropzone attribute.
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-dropzone-attribute
If a drag event was not canceled by JavaScript, look for an element with a dropzone attribute.
If there is such an element, and it matches the drag data store, set the action defined by that
element and continue processing the drag and drop operation.

Tests: fast/events/dropzone-001.html

fast/events/dropzone-002.html
fast/events/dropzone-003.html
fast/events/dropzone-004.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::convertDragOperationToDropZoneOperation):
(WebCore::Clipboard::processDropZoneKeyword):

  • dom/Clipboard.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.idl:
  • page/EventHandler.cpp:

(WebCore::EventHandler::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):

  • page/EventHandler.h:

LayoutTests:

  • fast/events/dropzone-001-expected.txt: Added.
  • fast/events/dropzone-001.html: Added.
  • fast/events/dropzone-002-expected.txt: Added.
  • fast/events/dropzone-002.html: Added.
  • fast/events/dropzone-003-expected.txt: Added.
  • fast/events/dropzone-003.html: Added.
  • fast/events/dropzone-004-expected.txt: Added.
  • fast/events/dropzone-004.html: Added.
  • fast/events/resources/dropzone.js: Added.
05:20 Changeset [87498] by ossy@webkit.org

[Qt]http/tests/security/xss-DENIED-xsl-document.xml fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60175

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/Skipped: The bug is in Qt 4.8, add Qt bug tracker URL's.
04:57 Changeset [87497] by zoltan@webkit.org

[Qt][WK2] Make the bot environmentally friendly.

  • platform/qt-wk2/Skipped:
04:44 Changeset [87496] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-004.html through smart-paste-006.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61618

Converted smart-paste-004.html, smart-paste-005.html, and smart-paste-005.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-004-expected.txt: Added.
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005-expected.txt: Added.
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-006-expected.txt: Added.
  • editing/pasteboard/smart-paste-006.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt: Removed.
04:38 Changeset [87495] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert smart-paste-001.html through smart-paste-003.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=61617

Converted smart-paste-001.html, smart-paste-002.html, and smart-paste-003.html to dumpAsText tests.

  • editing/pasteboard/smart-paste-001-expected.txt: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002-expected.txt: Added.
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003-expected.txt: Added.
  • editing/pasteboard/smart-paste-003.html:
  • platform/chromium-linux/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Removed.
04:36 Changeset [87494] by paroga@webkit.org

2011-05-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r87467.

  • page/wince/FrameWinCE.cpp:
04:22 Changeset [87493] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-unrendered-select.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=61616

Converted paste-unrendered-select.html to a dump-as-markup test.

  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html:
  • platform/chromium-linux/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt: Removed.
04:16 Changeset [87492] by commit-queue@webkit.org

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • platform/chromium/test_expectations.txt:

2011-05-27 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Enable Page Visibility API in the chromium port.
https://bugs.webkit.org/show_bug.cgi?id=61397

  • features.gypi:
03:54 Changeset [87491] by hans@chromium.org

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Support NO_DUPLICATE cursors on LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=61517

Support cursors where the direction is set to NEXT_NO_DUPLICATE,
or PREV_NO_DUPLICATE, as specified here:
http://www.w3.org/TR/IndexedDB/#widl-IDBCursor-NEXT_NO_DUPLICATE

This is tested by storage/indexeddb/mozilla/indexes.html

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
03:37 Changeset [87490] by hans@chromium.org

2011-05-26 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

LevelDB: turn on paranoid checks and verify checksums, log errors
https://bugs.webkit.org/show_bug.cgi?id=61516

This allows for detection of corrupted databases.
Even if we can't recover from a corrupted database, discovering the
problem is a step in the right direction.

No new functionality, no new tests.

  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::open): (WebCore::LevelDBDatabase::put): (WebCore::LevelDBDatabase::remove): (WebCore::LevelDBDatabase::get): (WebCore::LevelDBDatabase::write): (WebCore::IteratorImpl::checkStatus): (WebCore::IteratorImpl::seekToLast): (WebCore::IteratorImpl::seek): (WebCore::IteratorImpl::next): (WebCore::IteratorImpl::prev): (WebCore::LevelDBDatabase::createIterator):
03:16 Changeset [87489] by mnaganov@chromium.org

[Chromium] Unreviewed, mark fast/canvas/webgl/uniform-location.html as timing out

02:36 Changeset [87488] by apavlov@chromium.org

Merge 86551 - 2011-05-15 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

The client may be gone when sendMessageToBackend() is called.

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Yury Semikhatsky.

[Qt] Fix crash in inspector/console/console-long-eval-crash.html
https://bugs.webkit.org/show_bug.cgi?id=60858

  • platform/qt/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062045

02:30 Changeset [87487] by apavlov@chromium.org

Merge 86507 - 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

Test: inspector/console/console-long-eval-crash.html

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h:

2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium renderer crash at eval in console.

https://bugs.webkit.org/show_bug.cgi?id=60616
Renderer of inspected page is crashing when modal dialog
has been opened via console eval and page is reloaded.

  • inspector/console/console-long-eval-crash-expected.txt: Added.
  • inspector/console/console-long-eval-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/7062044

02:11 Changeset [87486] by rniwa@webkit.org

2011-05-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Convert editing/pasteboard/paste-text-002.html and paste-text-003.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=61614

Converted paste-text-002.html and paste-text-003.html to dump-as-markup tests.
Also added some descriptions to the tests.

  • editing/pasteboard/paste-text-002-expected.txt: Added.
  • editing/pasteboard/paste-text-002.html:
  • editing/pasteboard/paste-text-003-expected.txt: Added.
  • editing/pasteboard/paste-text-003.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
01:26 Changeset [87485] by commit-queue@webkit.org

2011-05-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

CachedResourceLoader stores data: urls in validated URL set
https://bugs.webkit.org/show_bug.cgi?id=61604

CachedResourceLoader maintains a set of URLs that have been validated to avoid validating the same resource
multiple times for loads within the same document. This doesn't make sense for data: URLs and just wastes
memory.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource):
01:01 Changeset [87484] by mnaganov@chromium.org

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Windows (bots are slow :(

00:56 Changeset [87483] by morrita@google.com

2011-05-23 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Refactoring] DocumentMarker should be carried around as a pointer, not value.
https://bugs.webkit.org/show_bug.cgi?id=61262

  • Changed return value of markersInRange() from Vector<DocumentMarker> to Vector<DocumentMarker*>.
  • Introduced markersFor() that returns Vector<DocumentMarker*>
  • Removed DocumentMarkerController::setRenderedRectForMarker() which now can be replaced by RenderedDocumentMarker::setRenderedRect().
  • This change didn't remove markersForNode() beucase there is patches on review which depends markersForNode(). I'll remove its call after these patches are landed.

No new tests. No behavior change.

  • WebCore.exp.in:
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addTextMatchMarker): (WebCore::DocumentMarkerController::markersFor): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers):
  • dom/DocumentMarkerController.h:
  • dom/RenderedDocumentMarker.h: (WebCore::toRenderedDocumentMarker):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::markersHaveIdenticalDescription): (WebCore::SpellingCorrectionController::respondToChangedSelection): (WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection): (WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
00:54 Changeset [87482] by mnaganov@chromium.org

[Chromium] Unreviewed, suppress http/tests/local/formdata/ test crashes after r87460

00:45 Changeset [87481] by mnaganov@chromium.org

[Chromium] Unreviewed, mark editing/pasteboard/interchange-newline-2.html as failing on Linux

00:26 Changeset [87480] by morrita@google.com

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary crashes
https://bugs.webkit.org/show_bug.cgi?id=61511

  • fast/html/details-summary-document-child-expected.txt: Added.
  • fast/html/details-summary-document-child.html: Added.

2011-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

WebCore::HTMLSummaryElement::isMainSummary ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=61511

Removed Unnecessary wrong cast to Elmement, which can be non-Element.

Test: fast/html/details-summary-document-child.html

  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::detailsElement):
Note: See TracTimeline for information about the timeline view.