Timeline
06/06/11:
- 23:31 Changeset [88223] by
-
2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88222.
http://trac.webkit.org/changeset/88222
https://bugs.webkit.org/show_bug.cgi?id=62192
Broke compile on Mac (Requested by abarth on #webkit).
- Scripts/webkit2/messages.py:
- Shared/WebCoreArgumentCoders.h:
- 23:20 Changeset [88222] by
-
2011-06-06 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694
Add ArgumentCoders for TransformOperation, including all the subclasses,
and TransformOperations.
- Scripts/webkit2/messages.py:
- Shared/WebCoreArgumentCoders.h:
- 23:19 Changeset [88221] by
-
2011-06-06 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.
- WebCore.gypi:
- bindings/v8/ChildThreadDOMData.cpp: Removed.
- bindings/v8/ChildThreadDOMData.h: Removed.
- bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
- bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
- bindings/v8/DOMDataStore.h:
- bindings/v8/MainThreadDOMData.cpp: Removed.
- bindings/v8/MainThreadDOMData.h: Removed.
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
- bindings/v8/V8DOMMap.h:
- bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
- 23:11 Changeset [88220] by
-
2011-06-06 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
[chromium] Make VideoFrameChromium's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62186
This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
deletes a VideoFrameChromium subclass type through this interface
class, causing ~VideoFrameChromiumImpl's destructor not to run.
(VideoFrameChroimumImpl happens to not have a destructor or any
non-POD member variables, so it's more a latent bug.)
- platform/graphics/chromium/VideoFrameChromium.cpp: (WebCore::VideoFrameChromium::~VideoFrameChromium):
- platform/graphics/chromium/VideoFrameChromium.h:
- 22:52 Changeset [88219] by
-
2011-06-06 MORITA Hajime <morrita@google.com>
Unreviewed attempt to fix flakiness on Snow Leopard.
- fast/replaced/resources/focus-test.js:
- 22:24 Changeset [88218] by
-
2011-06-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sammy Weinig.
Remove some unnecessary includes from AnimationBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=62183
- page/animation/AnimationBase.cpp:
- 22:14 Changeset [88217] by
-
2011-06-06 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Rebaseline outline-replaced-elements windows/linux image results.
https://bugs.webkit.org/show_bug.cgi?id=57439
- platform/chromium-linux-x86/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 21:52 Changeset [88216] by
-
Unreviewed, a crash fix by a roll out.
REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
https://bugs.webkit.org/show_bug.cgi?id=62116
Roll out the WebCore part of r87980.
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):
- html/SearchInputType.h:
(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
- html/TextFieldInputType.h:
(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):
- html/shadow/TextControlInnerElements.cpp:
- html/shadow/TextControlInnerElements.h:
- 21:42 Changeset [88215] by
-
2011-06-06 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Fraser.
Allow copying of KeyframeValueList.
https://bugs.webkit.org/show_bug.cgi?id=62171
Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
No new functionality so no new tests.
- platform/graphics/GraphicsLayer.h: (WebCore::FloatAnimationValue::clone): (WebCore::TransformAnimationValue::TransformAnimationValue): (WebCore::TransformAnimationValue::clone): (WebCore::TransformAnimationValue::value): (WebCore::KeyframeValueList::KeyframeValueList):
- 21:12 Changeset [88214] by
-
2011-06-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Incorrect rounding of color values during transitions
https://bugs.webkit.org/show_bug.cgi?id=62141
When blending integers, round to the nearest integer, instead of always rounding down.
Test: transitions/color-transition-rounding.html
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- 21:06 Changeset [88213] by
-
2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88202.
http://trac.webkit.org/changeset/88202
https://bugs.webkit.org/show_bug.cgi?id=62182
This broke the mac clang bot (Requested by koz on #webkit).
- dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
- rendering/InlineBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
- rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
- rendering/RenderText.h:
- rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
- rendering/RenderView.h:
- 21:04 Changeset [88212] by
-
2011-06-06 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Hajime Morita.
CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439
- fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
- fast/replaced/no-focus-ring-embed-1.html: Added.
- fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
- fast/replaced/no-focus-ring-embed-2.html: Added.
- fast/replaced/no-focus-ring-iframe-expected.txt: Added.
- fast/replaced/no-focus-ring-iframe.html: Added.
- fast/replaced/no-focus-ring-object-1-expected.txt: Added.
- fast/replaced/no-focus-ring-object-1.html: Added.
- fast/replaced/no-focus-ring-object-2-expected.txt: Added.
- fast/replaced/no-focus-ring-object-2.html: Added.
- fast/replaced/outline-replaced-elements-expected.txt: Added.
- fast/replaced/outline-replaced-elements.html: Added.
- fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.
2011-06-06 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Hajime Morita.
Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439
Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
Tests: fast/replaced/no-focus-ring-embed-1.html
fast/replaced/no-focus-ring-embed-2.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object-1.html
fast/replaced/no-focus-ring-object-2.html
fast/replaced/outline-replaced-elements.html
- css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
- 18:44 Changeset [88211] by
-
2011-06-06 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991
- editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
- editing/spelling/spellcheck-input-search-crash.html: Added.
2011-06-06 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991
Added a guard bofore TextCheckingHelper construction sites.
Test: editing/spelling/spellcheck-input-search-crash.html
- editing/Editor.cpp: (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
- 18:35 Changeset [88210] by
-
2011-06-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dirk Pranke.
[chromium] Chromium bots on build.webkit.org don't upload results.html
https://bugs.webkit.org/show_bug.cgi?id=61961
Don't fix the path on chromium port erroneously.
- BuildSlaveSupport/test-result-archive:
- 18:17 Changeset [88209] by
-
2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload): Change prettyURL() with string().
- 18:12 Changeset [88208] by
-
Merge 87960 - 2011-06-02 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
TBR=enne@google.com
Review URL: http://codereview.chromium.org/7125002
- 18:03 Changeset [88207] by
-
2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998
Implement startDownload() with download().
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
- 17:56 Changeset [88206] by
-
2011-06-06 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed, update test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 17:53 Changeset [88205] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Update RenderBlock::paint to use IntPoint internally
https://bugs.webkit.org/show_bug.cgi?id=62140
Covered by existing tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
- 17:07 Changeset [88204] by
-
<https://bugs.webkit.org/show_bug.cgi?id=62165>
<rdar://problem/9555835>
WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages
Reviewed by Dan Bernstein.
- UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::findString):
Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
number that would be ignored.
- 17:03 Changeset [88203] by
-
2011-06-06 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make WebViewImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62155
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/WebViewImpl.h:
- 16:45 Changeset [88202] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130
Covered by existing tests.
- dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
- rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
- rendering/RenderText.h:
- rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
- rendering/RenderView.h:
- 16:31 Changeset [88201] by
-
2011-06-06 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Clean scalePage related LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=62142
- platform/qt/Skipped:
- 16:21 Changeset [88200] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch shouldPaint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62158
Switching shouldPaint to take an IntPoint representing the paint offset instead
of a pair of ints.
No new tests as this is simple refactoring.
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
- rendering/RenderReplaced.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- 16:04 Changeset [88199] by
-
2011-06-06 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743
- wtf/CurrentTime.cpp: Add monotonicallyIncreasingTime() for mac and a fallback implementation that just wraps currentTime(). (WTF::monotonicallyIncreasingTime):
- wtf/CurrentTime.h: Add monotonicallyIncreasingTime().
2011-06-06 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743
- platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
- 16:01 Changeset [88198] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert RenderBox::pushContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62133
Covered by existing tests.
- rendering/RenderBlock.cpp: (WebCore::Covered by existing tests.RenderBlock::paint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
- rendering/RenderBox.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
- 15:28 Changeset [88197] by
-
Merge r87959 to chromium/782.
< rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.
Reviewed by Oliver Hunt.
Source/WebCore:
Test: webarchive/loading/javascript-url-iframe-crash.html
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
cause the DocumentLoader to be destroyed, so protect it with a Ref here.
LayoutTests:
- webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
- webarchive/loading/javascript-url-iframe-crash.html: Added.
- webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
- 15:27 Changeset [88196] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156
Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
offset instead of a pair of ints.
No new tests as this is simple refactoring.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
- 15:13 Changeset [88195] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert hitTest to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62144
Covered by existing tests.
- rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestContents):
- rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
- rendering/RenderLayer.h: (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
- rendering/RenderObject.h:
- 15:03 Changeset [88194] by
-
2011-06-06 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html
- platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
- platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
- 15:00 Changeset [88193] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151
Switching paintScrollbar to use IntPoint instead of a pair of ints.
No new tests since this is simple refactoring.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar):
- rendering/RenderListBox.h:
- 14:52 Changeset [88192] by
-
2011-06-06 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113
No new tests since this change only deleted unused code.
- WebCore.gypi:
- platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
- platform/chromium/ChromiumDataObjectLegacy.h: Removed.
- platform/chromium/ReadableDataObject.cpp: Removed.
- platform/chromium/ReadableDataObject.h: Removed.
- platform/chromium/WritableDataObject.cpp: Removed.
- platform/chromium/WritableDataObject.h: Removed.
2011-06-06 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113
- src/WebDragData.cpp:
- 14:45 Changeset [88191] by
-
2011-06-06 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
- src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
- 14:35 Changeset [88190] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137
Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
representing the paint offset instead of a pair of ints.
No new tests as this is simple refactoring.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintContinuationOutlines):
- rendering/RenderBlock.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
- 14:30 Changeset [88189] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert RenderBox::popContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62132
Covered by existing tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::popContentsClip):
- rendering/RenderBox.h:
- rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
- 14:26 Changeset [88188] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Remove tx/ty offset from selectionRect
https://bugs.webkit.org/show_bug.cgi?id=62146
Removing unused offset parameters from selectionRect.
No new tests since this is just cleanup.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::selectionRect):
- rendering/EllipsisBox.h:
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
- rendering/InlineTextBox.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::ellipsisRectForBox): (WebCore::RenderText::absoluteQuadsForRange): (WebCore::RenderText::selectionRectForRepaint):
- rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect):
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRect):
- rendering/svg/SVGInlineTextBox.h:
- 14:15 Changeset [88187] by
-
2011-06-06 Paul Kinlan <paulkinlan@google.com>
Reviewed by Jeremy Orlow.
Adds a test for firing popstate, using window.dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=62099
- fast/events/fire-popstate-event-expected.txt: Added.
- fast/events/fire-popstate-event.html: Added.
2011-06-06 Paul Kinlan <paulkinlan@google.com>
Reviewed by Jeremy Orlow.
Let developers call createEvent("PopStateEvent"), previously it wasn't
exposed and threw an exeception.
https://bugs.webkit.org/show_bug.cgi?id=62099
- WebCore/dom/Document.cpp:
- WebCore/dom/PopStateEvent.cpp:
- WebCore/dom/PopStateEvent.h:
- 14:12 QtWebKitBuildBots edited by
- Update Szeged slaves with links (diff)
- 14:02 QtWebKitBuildBots edited by
- Wiki syntax this time (diff)
- 13:58 QtWebKitBuildBots edited by
- Add links to the Apple master slaves (diff)
- 13:42 Changeset [88186] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62059
Switching paintSelection to use an IntPoint to represent the paint offset
instead of a pair of ints.
No new tests since this is simple refactoring.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::paintSelection):
- rendering/EllipsisBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
- rendering/RenderBlock.h:
- 13:40 BuildBot edited by
- Added a reference to … (diff)
- 13:18 Changeset [88185] by
-
2011-06-06 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.
- GNUmakefile.am: Assign libWebCoreInternals built sources to libwebcoreinternals_built_sources before adding to the source list and to BUILT_SOURCES.
2011-06-06 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.
- GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
- 13:14 Changeset [88184] by
-
Update the Windows-specific results after r88020 in order to get the bots green.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 13:00 BuildBot edited by
- Added instruction to connect to bot master (diff)
- 12:57 Changeset [88183] by
-
2011-06-06 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert RenderBox::clipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62045
Covered by existing tests.
- rendering/RenderBox.cpp: (WebCore::RenderBox::clipRect):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
- rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
- 12:57 Changeset [88182] by
-
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081
Skip more tests on Windows that use the Shadow DOM to get the bots green.
- platform/win/Skipped:
- 12:42 Changeset [88181] by
-
2011-06-06 Anna Cavender <annacc@chromium.org>
Reviewed by David Levin.
Marking media/video-canvas-alpha.html as SKIP for GPU MAC.
https://bugs.webkit.org/show_bug.cgi?id=62068
- platform/chromium/test_expectations.txt:
- 12:40 Changeset [88180] by
-
2011-06-06 Vangelis Kokkevis <vangelis@chromium.org>
Unreviewed. Layout test expectations fix.
[chromium] Adjusting expectations for failing huge-layer-img.html
- platform/chromium/test_expectations.txt:
- 12:36 Changeset [88179] by
-
2011-06-06 Yong Li <yoli@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=62097
Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 12:21 Changeset [88178] by
-
2011-06-06 Peter Kasting <pkasting@google.com>
Reviewed by Antonio Gomes.
Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648
No behavior change, so no tests.
- WebCore.exp.in:
- WebCore.order:
- dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
- editing/FrameSelection.cpp: (WebCore::FrameSelection::revealSelection):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
- page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
- rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea): (WebCore::RenderBox::canBeProgramaticallyScrolled):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
- rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2011-06-06 Peter Kasting <pkasting@google.com>
Reviewed by Antonio Gomes.
Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648
- WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):
- 12:03 BuildBot edited by
- Fixed indentation (diff)
- 12:02 BuildBot edited by
- Added instruction to run buildbot locally (diff)
- 11:55 QtWebKitForQt5 edited by
- Responding to comments (diff)
- 11:51 QtWebKitForQt5 edited by
- Clean ups, clear up focus on browser development (diff)
- 11:51 Changeset [88177] by
-
2011-06-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Enable feature/symbol detection in NWRT/GTK
https://bugs.webkit.org/show_bug.cgi?id=62136
Disable feature detection through DRT, since we don't support it,
and set the libwebcore patch correctly so that symbol detection
through 'nm' works.
- Scripts/webkitpy/layout_tests/port/gtk.py:
- 11:43 Changeset [88176] by
-
2011-06-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62134
Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
IntPoint representing the paint offset instead of a pair of ints.
No new tests as this simple refactoring.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
- rendering/RenderBlock.h:
- 11:38 WikiStart edited by
- Added a link to BuildBot (diff)
- 11:32 Changeset [88175] by
-
2011-06-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
- fast/inline/inline-wrap-with-parent-padding.html: Added.
- platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
- platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
2011-06-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.
Test: fast/inline/inline-wrap-with-parent-padding.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::nextLineBreak):
- 11:03 Changeset [88174] by
-
2011-06-06 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
2011-06-06 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
- page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
- page/PageVisibilityState.h:
2011-06-06 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
- public/WebPageVisibilityState.h:
- src/AssertMatchingEnums.cpp:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):
2011-06-06 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):
- 11:01 Changeset [88173] by
-
2011-06-06 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Fix typo in CachedFont.cpp #define
https://bugs.webkit.org/show_bug.cgi?id=62127
No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.
- loader/cache/CachedFont.cpp: change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
- 10:50 Changeset [88172] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62058
Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
their paint offsets instead of pairs of ints.
No new tests since this is simple refactoring.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes):
- rendering/RenderBlock.h:
- 10:27 BuildBot edited by
- Added an instruction to use easy_install-2.6 on SL (diff)
- 10:10 Changeset [88171] by
-
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Anders Carlsson.
Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
https://bugs.webkit.org/show_bug.cgi?id=62124
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setException):
- 09:48 Changeset [88170] by
-
2011-06-06 Nico Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
webkit/glue/webmediaplayer_impl.cc deletes an object of type
WebVideoFrame, which means this patch fixes a real bug, not just
a theoretical one.
[chromium] Give WebVideoFrame a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=61742
- public/WebVideoFrame.h: (WebKit::WebVideoFrame::~WebVideoFrame):
- 08:49 Changeset [88169] by
-
Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Kent Tamura.
[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823
Added a new test for the fix marked the new test 'skipped' on unsupported platforms.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- storage/storageinfo-no-callbacks-expected.txt: Added.
- storage/storageinfo-no-callbacks.html: Added.
2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Kent Tamura.
[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823
Fixed assertion on errorCallback parameter.
Test: storage/quotainfo-no-callbacks.html
- src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):
BUG=84527
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/7054073
- 07:57 Changeset [88168] by
-
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812
- platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml.
- 07:52 Changeset [88167] by
-
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
- QtTestBrowser/launcherwindow.h:
- 07:15 Changeset [88166] by
-
2011-06-06 Steve Block <steveblock@google.com>
Reviewed by Yury Semikhatsky.
Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118
Correctly guard implementation of ScriptProfiler.
No new tests, build fix only.
- bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::initialize):
- 07:12 Changeset [88165] by
-
Unreviewed WinCairo build fix after r88159.
- win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.
- 06:53 Changeset [88164] by
-
[Qt][Mac] Skip failing tests.
- platform/qt-mac/Skipped:
- 06:33 Changeset [88163] by
-
[Qt] Add expected results for the new passing tests, and skip the new failing tests.
Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Skip new failing tests.
- platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
- platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
- platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
- platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
- platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
- platform/qt/svg/custom/embedding-external-svgs-expected.png: Added.
- platform/qt/svg/custom/embedding-external-svgs-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/qt/svg/hixie/intrinsic/001-expected.png: Added.
- platform/qt/svg/hixie/intrinsic/001-expected.txt: Added.
- platform/qt/svg/hixie/intrinsic/002-expected.png: Added.
- platform/qt/svg/hixie/intrinsic/002-expected.txt: Added.
- platform/qt/svg/hixie/intrinsic/003-expected.png: Added.
- platform/qt/svg/hixie/intrinsic/003-expected.txt: Added.
- platform/qt/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/qt/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
- 06:27 Changeset [88162] by
-
2011-06-06 Marcus Bulach <bulach@chromium.org>
Reviewed by Unreviewed rebaseline.
[chromium] Unreviewed, new baseline for GPU test.
https://bugs.webkit.org/show_bug.cgi?id=62123
- platform/chromium/test_expectations.txt:
- 06:19 Changeset [88161] by
-
2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::downloadRequest): (LauncherWindow::fileDownloadFinished):
- QtTestBrowser/launcherwindow.h:
- 05:41 Changeset [88160] by
-
2011-06-06 Gabor Loki <loki@webkit.org>
Rubber-stamped by Csaba Osztrogonác
Skip a flakey test on ARM.
- platform/qt-arm/Skipped:
- 05:32 Changeset [88159] by
-
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Unskip window.internals test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=61076
- platform/win/Skipped:
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Add WebCoreTestSupport project.
https://bugs.webkit.org/show_bug.cgi?id=61076
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
- WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Add WebCoreTestSupport project containing window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076
- WebKit.vcproj/WebKit.sln:
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Re-export JSC and WebCore symbols required by WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=61076
- win/WebKit2.def:
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Make DumpRenderTree initialize window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076
- DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
- 05:23 Changeset [88158] by
-
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812
- platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml.
- 05:16 Changeset [88157] by
-
2011-06-06 Csaba Osztrogonác <ossy@webkit.org>
[Qt][WK2] Remove previously deleted tests from the Skipped list.
- platform/qt-wk2/Skipped:
- 04:58 Changeset [88156] by
-
[Qt][WK2] Remove previously deleted tests from the Skipped list.
- platform/qt-wk2/Skipped:
- 04:53 Changeset [88155] by
-
[Qt][WK2] Skip failing tests.
- platform/qt-wk2/Skipped:
- 04:37 Changeset [88154] by
-
[Qt][Mac] Skip failing tests.
- platform/qt-mac/Skipped:
- 04:22 Changeset [88153] by
-
2011-06-06 Marcus Bulach <bulach@chromium.org>
Reviewed by Unreviewed rebaseline.
[chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077
https://bugs.webkit.org/show_bug.cgi?id=62115
- platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
- platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-expected.png:
- platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
- platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
- platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-win/media/video-zoom-expected.png:
- platform/chromium/test_expectations.txt:
- 04:12 Changeset [88152] by
-
[Qt] Add expected results for the new passing tests, and skip the new failing tests.
Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Skip new failing tests.
- platform/qt/editing/selection/select-across-readonly-input-1-expected.png: Added.
- platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Added.
- platform/qt/editing/selection/select-across-readonly-input-2-expected.png: Added.
- platform/qt/editing/selection/select-across-readonly-input-2-expected.txt: Added.
- platform/qt/editing/selection/select-across-readonly-input-3-expected.png: Added.
- platform/qt/editing/selection/select-across-readonly-input-3-expected.txt: Added.
- platform/qt/editing/selection/select-across-readonly-input-4-expected.png: Added.
- platform/qt/editing/selection/select-across-readonly-input-4-expected.txt: Added.
- platform/qt/editing/selection/select-across-readonly-input-5-expected.png: Added.
- platform/qt/editing/selection/select-across-readonly-input-5-expected.txt: Added.
- platform/qt/fast/block/float/float-overhangs-root-expected.png: Added.
- platform/qt/fast/block/float/float-overhangs-root-expected.txt: Added.
- platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
- platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
- platform/qt/fast/forms/date-input-visible-strings-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Added.
- platform/qt/fast/html/details-add-details-child-1-expected.png: Added.
- platform/qt/fast/html/details-add-details-child-1-expected.txt: Added.
- platform/qt/fast/html/details-add-details-child-2-expected.png: Added.
- platform/qt/fast/html/details-add-details-child-2-expected.txt: Added.
- platform/qt/fast/html/details-nested-1-expected.png: Added.
- platform/qt/fast/html/details-nested-1-expected.txt: Added.
- platform/qt/fast/html/details-nested-2-expected.png: Added.
- platform/qt/fast/html/details-nested-2-expected.txt: Added.
- platform/qt/fast/html/details-replace-summary-child-expected.png: Added.
- platform/qt/fast/html/details-replace-summary-child-expected.txt: Added.
- platform/qt/fast/html/details-replace-text-expected.png: Added.
- platform/qt/fast/html/details-replace-text-expected.txt: Added.
- platform/qt/fast/inline/nested-top-alignment-expected.png: Added.
- platform/qt/fast/inline/nested-top-alignment-expected.txt: Added.
- platform/qt/fast/table/dynamic-caption-add-before-child-expected.png: Added.
- platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
- platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
- platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
- platform/qt/fast/table/multiple-captions-display-expected.png: Added.
- platform/qt/fast/table/multiple-captions-display-expected.txt: Added.
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
- platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
- platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-update-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-update-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-expected.png: Added.
- platform/qt/svg/custom/object-sizing-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
- platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
- platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
- platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Added.
- platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Added.
- platform/qt/svg/custom/stroke-opacity-update-expected.png: Added.
- platform/qt/svg/custom/stroke-opacity-update-expected.txt: Added.
- platform/qt/svg/wicd/rightsizing-grid-expected.png: Added.
- platform/qt/svg/wicd/rightsizing-grid-expected.txt: Added.
- platform/qt/svg/wicd/test-rightsizing-a-expected.png: Added.
- platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Added.
- platform/qt/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Added.
- platform/qt/svg/wicd/test-scalable-background-image1-expected.png: Added.
- platform/qt/svg/wicd/test-scalable-background-image1-expected.txt: Added.
- platform/qt/svg/wicd/test-scalable-background-image2-expected.png: Added.
- platform/qt/svg/wicd/test-scalable-background-image2-expected.txt: Added.
- 03:45 Changeset [88151] by
-
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
This patch modifies only the build system. Therefore,
there are no new tests.
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
- Scripts/build-webkit:
2011-06-06 Alexandru Chiculita <achicu@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 02:36 Changeset [88150] by
-
2011-06-06 Mario Sanchez Prada <msanchez@igalia.com>
- platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
- platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.
- 02:29 Changeset [88149] by
-
2011-06-02 MORITA Hajime <morrita@google.com>
Verify cloning <meter> and <progress> works
https://bugs.webkit.org/show_bug.cgi?id=61986
Added test cases for cloning <meter> and <progress>
- fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
- fast/dom/HTMLMeterElement/meter-clone.html: Added.
- fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
- fast/dom/HTMLProgressElement/progress-clone.html: Added.
- 01:46 Changeset [88148] by
-
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
This patch modifies only the build system. Therefore,
there are no new tests.
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
- Configurations/FeatureDefines.xcconfig:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
- Scripts/build-webkit:
2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
Reviewed by Kent Tamura.
Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 01:35 Changeset [88147] by
-
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Anders Carlsson.
[UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
https://bugs.webkit.org/show_bug.cgi?id=61538
Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
receiver code to support stream sockets, since it requires to
handle message boundaries. The same code works for DGRAM sockets,
so this change shouldn't break other ports using DGRAM.
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::processMessage): Process messages from data already received. (CoreIPC::readBytesFromSocket): Read from socket using recvmsg(). (CoreIPC::Connection::readyReadHandler):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in socketpair().
- 01:32 QtWebKitForQt5 edited by
- Refine the FBO approach (diff)
- 01:09 Changeset [88146] by
-
2011-06-03 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=62013
Clean up the prototypes for cursor open functions by introducing the
CursorOptions struct.
Just clean-up, no new functionality so no new tests.
- storage/IDBLevelDBBackingStore.cpp: (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon): (WebCore::CursorOptions::CursorImplCommon::firstSeek): (WebCore::CursorOptions::CursorImplCommon::continueFunction): (WebCore::CursorOptions::ObjectStoreCursorImpl::create): (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl): (WebCore::CursorOptions::IndexKeyCursorImpl::create): (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl): (WebCore::CursorOptions::IndexCursorImpl::create): (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
- 00:57 Changeset [88145] by
-
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix the GTK+ build.
- GNUmakefile.am: Add javascriptcore_cflags variable.
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix the GTK+ build.
- GNUmakefile.am: Add javascriptcore_cflags variable.
2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix the GTK+ build.
- GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
- 00:27 Changeset [88144] by
-
2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48290
Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
from failed/skipped test list
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>
Reviewed by Darin Adler.
Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
https://bugs.webkit.org/show_bug.cgi?id=48290
"highlight" is not a valid globalComposite operation
as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
Therefore, removed the option from the source code.
Tests: No new tests required.
LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator CompositeOperator):
- platform/graphics/GraphicsTypes.cpp:
- platform/graphics/GraphicsTypes.h:
- platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
- platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::applyBlending):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
- platform/graphics/skia/SkiaUtils.cpp:
06/05/11:
- 23:12 Changeset [88143] by
-
[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- 22:54 Changeset [88142] by
-
[Qt] Unreviewed trivial fix.
- platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518.
- 22:49 Changeset [88141] by
-
[Qt][Mac] Unreviewed. Skip new failing tests.
- platform/qt-mac/Skipped:
- 22:38 Changeset [88140] by
-
[Qt] Unreviewed. Update platform specific expected files after r88020.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 21:56 Changeset [88139] by
-
2011-06-04 Abhishek Arya <inferno@chromium.org>
Reviewed by Kent Tamura.
Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
https://bugs.webkit.org/show_bug.cgi?id=62085
Testing ComplexTextControllerLinux change requires a testcase
32 kb which is not feasible. All other changes are tested by
existing layouttests.
- platform/graphics/TextRun.h: (WebCore::TextRun::operator[]): add assert. (WebCore::TextRun::data): add assert.
- platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance): bail early and prevent access to one byte across the text run boundary.
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): wrong int16 vs int comparison.
- rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk): bail early when from and to is outside the text run boundary. this hit easily after adding the assert when from = to = end and read in run.data(from).
- 21:07 Changeset [88138] by
-
Merge 88137
2011-06-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100
- fast/dom/shadow/import-shadowroot-expected.txt: Removed.
- fast/dom/shadow/import-shadowroot.html: Removed.
2011-06-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100
It made several problems on elements with new shadow DOM.
- dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
TBR=tkent@chromium.org
BUG=84819
Review URL: http://codereview.chromium.org/6993052
- 19:01 Changeset [88137] by
-
2011-06-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100
- fast/dom/shadow/import-shadowroot-expected.txt: Removed.
- fast/dom/shadow/import-shadowroot.html: Removed.
2011-06-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100
It made several problems on elements with new shadow DOM.
- dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
- 13:13 Changeset [88136] by
-
Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
works properly).
- Scripts/webkitpy/common/config/committers.py:
- 13:12 Changeset [88135] by
-
2011-06-05 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089
We're unskipping acid2.html event though it's just a landing
page for the acid2 test. Some elements of the test are loaded by
the landing page so it is testing something, but acid2-pixel covers the same
ground.
- platform/qt/Skipped:
- platform/qt/fast/css/acid2-expected.txt: Updated
- platform/qt/fast/css/acid2-pixel-expected.png: Added.
- platform/qt/fast/css/acid2-pixel-expected.txt: Added.
- platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Removed.
- platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Removed.
- platform/qt/http/tests/misc/acid2-expected.png: Added.
- platform/qt/http/tests/misc/acid2-expected.txt: Added.
- platform/qt/http/tests/misc/acid2-pixel-expected.png: Added.
- platform/qt/http/tests/misc/acid2-pixel-expected.txt: Added
2011-06-04 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089
shouldFallBack() tells the DOM if it should attempt to render
the next nested <object> if its parent fails to load.
This fix is only required for the fast/css version of the ACID2
test, which loads a non-existent file:// url. The HTTP version of the
test already passes because the loader will render fallback content
on a failed HTTP load without delegating the decision to the client
( see MainResourceLoader::continueAfterContentPolicy).
Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
what to return. This error isn't currently set by Qt so we don't check
it. (Other ports set it when the erring document is a MediaDocument, maybe
we should do that too at some point).
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldFallBack):
- 11:34 Changeset [88134] by
-
2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
Rebaseline tests.
- fast/viewport/viewport-45-expected.txt:
- fast/viewport/viewport-86-expected.txt:
- platform/qt/Skipped:
2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.
- dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
- 10:03 Changeset [88133] by
-
2011-09-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha.
Update the library and user-facing version in preparation
for the 1.4.1 release.
- configure.ac: Update the versions.
06/04/11:
- 22:28 Changeset [88132] by
-
[wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx.
- 22:07 Changeset [88131] by
-
[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac.
- 21:38 Changeset [88130] by
-
[wx] Unreviewed build fixes for recent trunk changes.
- 21:33 Changeset [88129] by
-
Merge 87856
BUG=84950
Review URL: http://codereview.chromium.org/7058064
- 20:21 Changeset [88128] by
-
Roll over some ChangeLogs.
- 19:08 Changeset [88127] by
-
2011-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Disable WebProcess side display throttling when in a user scroll
<rdar://problem/9517175>
https://bugs.webkit.org/show_bug.cgi?id=62095
Add the ability to disable WebProcess side display throttling that
takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
when in a user or animated scroll.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::enableDisplayThrottling): (WebKit::DrawingArea::disableDisplayThrottling):
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::enableDisplayThrottling): (WebKit::DrawingAreaImpl::disableDisplayThrottling): (WebKit::DrawingAreaImpl::displayTimerFired):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::wheelEvent):
- 17:46 Changeset [88126] by
-
2011-06-04 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed, MIPS build fix.
WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691
- GNUmakefile.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
- 17:37 Changeset [88125] by
-
2011-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez
Update the news file for the 1.4.1 release.
- NEWS: Update news.
- 17:09 Changeset [88124] by
-
2011-06-04 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed, MIPS build fix.
WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691
- GNUmakefile.list.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
- 14:03 Changeset [88123] by
-
2011-06-04 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204
- WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
- platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
2011-06-04 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204
- WebKit2.xcodeproj/project.pbxproj: Added new source files.
- WebProcess/mac/CoreIPCClientRunLoop.h: Added.
- WebProcess/mac/CoreIPCClientRunLoop.mm: Added. (-[WKFunctionAdapter perform]): Added. (WebKit::createCoreIPCRunLoopModesArray): Added. (WebKit::coreIPCRunLoopModesArray): Added. (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.
- WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait. (WebKit::webFreeKeychainItemContent): Ditto. (WebKit::webSecKeychainItemCopyContent): Ditto. (WebKit::webSecKeychainItemCreateFromContent): Ditto. (WebKit::webSecKeychainItemModifyContent): Ditto.
- WebProcess/mac/SecItemShimMethods.mm: (WebKit::webSecItemCopyMatching): Ditto. (WebKit::webSecItemAdd): Ditto. (WebKit::webSecItemUpdate): Ditto. (WebKit::webSecItemDelete): Ditto.
- 12:34 Changeset [88122] by
-
2011-06-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add InlineWalker class to hold state for repeated calls to bidiNext
https://bugs.webkit.org/show_bug.cgi?id=60724
This is one more little step towards removing (naked) bidiNext usage.
More refactoring is required before all callers of bidiNext can move
onto using an InlineWalker instead of bidiNext directly.
No change in behavior, thus no tests.
- rendering/InlineIterator.h: (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::root): (WebCore::InlineWalker::current): (WebCore::InlineWalker::atEndOfInline): (WebCore::InlineWalker::atEnd): (WebCore::InlineWalker::advance):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 12:20 Changeset [88121] by
-
2011-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093
Add additional ChromeClient functions to indicate the beginning and end of
the various ScrollAnimator animations. Change existing notification that a
rubber-band has completed for the main frame to be triggered for all frames.
- page/ChromeClient.h: (WebCore::ChromeClient::didStartRubberBandForFrame): (WebCore::ChromeClient::didCompleteRubberBandForFrame): (WebCore::ChromeClient::didStartAnimatedScroll): (WebCore::ChromeClient::didCompleteAnimatedScroll):
- page/FrameView.cpp: (WebCore::FrameView::didStartRubberBand): (WebCore::FrameView::didCompleteRubberBand): (WebCore::FrameView::didStartAnimatedScroll): (WebCore::FrameView::didCompleteAnimatedScroll):
- page/FrameView.h:
- platform/ScrollableArea.h: (WebCore::ScrollableArea::didStartRubberBand): (WebCore::ScrollableArea::didStartAnimatedScroll): (WebCore::ScrollableArea::didCompleteAnimatedScroll):
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm: (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
2011-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093
Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
animated scrolls, and update logic for rubber-band ending to check for main frame
now that it is called for all frames.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 11:59 Changeset [88120] by
-
2011-06-04 Martin Robinson <mrobinson@igalia.com>
Touch a file to try to fix the GTK+ build on the 32-bit bot.
- testing/Internals.idl: Touch this IDL file in an effort to fix the build.
- 11:55 Changeset [88119] by
-
2011-06-04 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix formatting of the output generated by KeywordLookupGenerator.py
https://bugs.webkit.org/show_bug.cgi?id=62083
- Uses correct year for copyright.
- Puts ending brace on same line as "else if"
- Puts starting brace of function on its own line.
- Adds some tasteful whitespace.
- Adds comments to make clear that scopes are ending
- Make macros actually split on two lines.
- KeywordLookupGenerator.py:
- 11:18 Changeset [88118] by
-
Merging r87696
- 10:45 Changeset [88117] by
-
Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
- fast/events/drag-image-filename-expected.txt: Added.
- fast/events/drag-image-filename.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
We try to guess an appropriate filename when dragging out images. In order, we try to use:
- The filename suggested in the HTTP header.
- The last path component of the source URL.
- The alt text. This matches the behavior of the other WebKit ports.
Test: fast/events/drag-image-filename.html
- platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
- platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):
2011-06-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
- DumpRenderTree/chromium/EventSender.h:
TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/7054067
- 10:23 Changeset [88116] by
-
2011-06-04 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build.
- bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.
2011-06-04 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build.
- GNUmakefile.am: Add some missing newline escape.
- 10:14 Changeset [88115] by
-
2011-06-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Convert file <input> to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=59005
Refactoring, covered by existing tests.
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h: Ditto.
- css/html.css: (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
- html/FileInputType.cpp: (WebCore::UploadButtonElement::create): Added. (WebCore::UploadButtonElement::UploadButtonElement): Added. (WebCore::UploadButtonElement::shadowPseudoId): Added. (WebCore::FileInputType::createShadowSubtree): Added.
- html/FileInputType.h: Added createShadowSubtree decl.
- page/DragController.cpp: (WebCore::asFileInput): Changed the logic to use new shadow DOM.
- rendering/RenderFileUploadControl.cpp: Removed UploadButton class. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary. (WebCore::nodeWidth): Added a helper. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
- rendering/RenderFileUploadControl.h: Changed decls.
- rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
- 09:15 Changeset [88114] by
- 05:56 Changeset [88113] by
-
2011-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
KeywordLookupGenerator.py spams stdout in Chromium Linux build
https://bugs.webkit.org/show_bug.cgi?id=62087
This action does not appear to be needed.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 05:06 Changeset [88112] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make ResourceHandleInternal's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62073
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- 04:35 Changeset [88111] by
-
2011-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Andreas Kling.
[Qt] Enable passing File API tests
https://bugs.webkit.org/show_bug.cgi?id=62020
File API has been enabled for QtWebKit in r74115,
let's also enable the passing related tests.
- platform/qt/Skipped:
- 04:23 Changeset [88110] by
-
2011-06-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>
- fast/forms/input-value-sanitization-expected.txt:
- fast/forms/input-value-sanitization.html:
- fast/forms/paste-multiline-text-input.html:
- fast/forms/script-tests/input-value-sanitization.js: Removed.
2011-06-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>
Newline characters should be removed according to HTML5, not replaced with spaces.
This also matches Safari 5 behavior.
- html/TextFieldInputType.cpp: (WebCore::isASCIILineBreak): A functor for removeCharacters(). (WebCore::limitLength): Do one thing at once. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising) code that replaces newlines with spaces here.
- 04:14 Changeset [88109] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076
Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.
- src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
- 04:06 Changeset [88108] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
- 03:58 Changeset [88107] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/PlatformMessagePortChannel.h:
- 03:50 Changeset [88106] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
- 03:42 Changeset [88105] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
- src/WebFrameImpl.h:
- 03:32 Changeset [88104] by
-
2011-06-04 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Beth Dakin.
Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897
Added simple test that hits the relevant code.
- mathml/msubsup-remove-children-expected.txt: Added.
- mathml/msubsup-remove-children.xhtml: Added.
2011-06-04 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Beth Dakin.
Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897
Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml
- rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::baselinePosition):
- 03:24 Changeset [88103] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Give IDBBackingStore::Transaction a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62063
IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.
- storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Transaction::~Transaction):
- 02:53 Changeset [88102] by
-
2011-06-04 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032
Covered by existing tests.
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- platform/graphics/IntRect.h: (WebCore::IntRect::contract):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::overflowClipRect):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
- rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
- rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect): (WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTable.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
- 02:24 Changeset [88101] by
-
- glu: Added property svn:ignore.
- For glu.xcodeproj, which is generated from glu.gyp.
- glu: Added property svn:ignore.
- 02:22 Changeset [88100] by
-
2011-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
V8Proxy::disconnectFrame doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=62051
Dead code should die.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- 02:05 Changeset [88099] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
Make the destructors of DataTransferItem and DataTransferItems virtual
https://bugs.webkit.org/show_bug.cgi?id=62052
Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)
- dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
- dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):
- 02:02 Changeset [88098] by
-
2011-06-04 Nico Weber <thakis@chromium.org>
Reviewed by James Robinson.
[chromium] Make LayerPainterChromium destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62056
LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
means that without this patch, the destructor of classes implementing
LayerPainterChromium wasn't called correctly in that case.
- platform/graphics/chromium/LayerPainterChromium.h: (WebCore::LayerPainterChromium::~LayerPainterChromium):
- 01:08 Changeset [88097] by
-
Configure new commit-queue instance. (Please ignore.)
- 00:02 Changeset [88096] by
-
2011-06-04 Emil A Eklund <eae@chromium.org>
Reviewed by Andreas Kling.
Fix IntRect::expand(const IntSize& size)
https://bugs.webkit.org/show_bug.cgi?id=62042
No new tests.
- platform/graphics/IntRect.h: (WebCore::IntRect::expand): Fix IntRect::expand to expand the size rather than move the location. Currently unused.
06/03/11:
- 23:45 Changeset [88095] by
-
2011-06-03 Vangelis Kokkevis <vangelis@chromium.org>
Unreviewed. Fixes test expectatations.
[chromium] Fixing redefinitions of test_expectations entries
for chrome gpu tests.
- platform/chromium/test_expectations.txt:
- 23:15 Changeset [88094] by
-
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Lexer needs to provide Identifier for reserved words
https://bugs.webkit.org/show_bug.cgi?id=62086
Alas it is necessary to provide an Identifier reference for keywords
so that we can do the right thing when they're used in object literals.
We now keep Identifiers for all reserved words in the CommonIdentifiers
structure so that we can access them without a hash lookup.
- KeywordLookupGenerator.py:
- parser/Lexer.cpp: (JSC::Lexer::parseIdentifier):
- parser/Lexer.h:
- runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- 22:25 Changeset [88093] by
-
Add debug code to break on speculation failures.
Reviewed by Sam Weinig.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGNode.h:
- 22:13 Changeset [88092] by
-
https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap
Reviewed by Sam Weinig.
This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.
This can also affect function calls passing three arguments.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
- Call swap with the correct arguments.
- 21:59 Changeset [88091] by
-
2011-06-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
ResourceHandleMac should always respond to an authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=61667
I don't know if this can actually happen in practice, so no new tests.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Cancel authentication challenge if we don't have a client. We must always respond to the challenge to release the connection, and there is nothing else to do in this state anyway.
- 21:35 Changeset [88090] by
-
Try to fix the Apple LLVM Compiler build after r88087.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintMask):
- rendering/RenderTableCell.h:
- 20:06 Changeset [88089] by
-
Fix clang build - take 2
- 19:57 Changeset [88088] by
-
Fix clang build
- 19:25 Changeset [88087] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintMask and paintObject to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62077
Switching paintMask and paintObject to use IntPoint for their paint offset instead of
a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.
No new tests since this is simple refactoring.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
- rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFileUploadControl.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
- rendering/RenderListBox.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
- rendering/RenderTable.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject):
- rendering/RenderTableSection.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): (WebCore::RenderTextControl::paintObject):
- rendering/RenderTextControl.h:
- rendering/RenderView.cpp: (WebCore::RenderView::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- 18:58 Changeset [88086] by
-
Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7058060
- 18:55 Changeset [88085] by
-
Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7112025
- 18:34 Changeset [88084] by
-
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Force inlining of some hot lexer functions
https://bugs.webkit.org/show_bug.cgi?id=62079
Fix more GCC stupidity
- parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator):
- 17:43 Changeset [88083] by
-
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
GCC not inlining some functions that it really should be
https://bugs.webkit.org/show_bug.cgi?id=62075
Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.
- KeywordLookupGenerator.py:
- parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
- parser/Lexer.cpp: (JSC::isIdentPart):
- 17:39 Changeset [88082] by
-
Whoops, fix last minute bug.
- 17:22 Changeset [88081] by
-
2011-06-03 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Support FontCustomPlatformData on Skia-Mac-Chrome variant
https://bugs.webkit.org/show_bug.cgi?id=62040
Canvas text is only recognized by Skia if it is registered
by creating a new SkTypeface. Skia uses CGFont to measure
and render the glyphs, then takes care of managing the glyph
cache.
Skia on Mac Chrome is not yet enabled, so this change
does not affect existing code, and requires no new tests.
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::RemoteFontStream): (WebCore::RemoteFontStream::~RemoteFontStream): (WebCore::RemoteFontStream::rewind): (WebCore::RemoteFontStream::read): Turn the buffer into a stream. This is identical to the implementation in skia/FontCustomPlatformData.cpp. While that file could be modified instead of this one, it was simpler to add SkTypeface streaming to this instead of adding all CGFont support to the skia platform file.
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
Release the SkTypeface reference.
(WebCore::createFontCustomPlatformData):
Associate the buffer stream with a SkTypeface so Skia
can find the custom font data.
- platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Add a slot to hold the SkTypeface.
- 17:16 Changeset [88080] by
-
2011-06-03 Steve Falkenburg <sfalken@apple.com>
Reviewed by Brian Weinstein.
HistoryItem children persist across page loads
https://bugs.webkit.org/show_bug.cgi?id=62071
<rdar://problem/9552129>
Not testable since there's no way to check for the presence/absence
of children for a HistoryItem.
- history/HistoryItem.cpp: (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.
- 17:09 Changeset [88079] by
-
2011-06-03 James Robinson <jamesr@chromium.org>
[chromium] Mark GPU-only expectations as GPU.
- platform/chromium/test_expectations.txt:
- 16:57 Changeset [88078] by
-
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Try to fix the GTK+ build.
- GNUmakefile.am: Clean up some spaces that should be tabs.
- GNUmakefile.list.am: Add KeywordLookup.h to the source list and clean up some spaces that should be tabs.
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Try to fix the GTK+ bulid.
- GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals source list.
- 16:53 Changeset [88077] by
-
2011-06-03 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, rebaselining Chromium GPU media pixel results after Chromium commit 87830.
- platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
- platform/chromium-gpu-linux/media/controls-strict-expected.png:
- platform/chromium-gpu-linux/media/controls-styling-expected.png:
- platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
- platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
- platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
- platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
- platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
- platform/chromium-gpu-linux/media/video-no-audio-expected.png:
- platform/chromium-gpu-linux/media/video-transformed-expected.png:
- platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
- platform/chromium-gpu-mac/media/controls-strict-expected.png:
- platform/chromium-gpu-mac/media/controls-styling-expected.png:
- platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
- platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
- platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
- platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
- platform/chromium-gpu-mac/media/video-no-audio-expected.png:
- platform/chromium-gpu-mac/media/video-transformed-expected.png:
- platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/controls-after-reload-expected.png:
- platform/chromium-gpu-win/media/controls-strict-expected.png:
- platform/chromium-gpu-win/media/controls-styling-expected.png:
- platform/chromium-gpu-win/media/controls-without-preload-expected.png:
- platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
- platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
- platform/chromium-gpu-win/media/video-display-toggle-expected.png:
- platform/chromium-gpu-win/media/video-layer-crash-expected.png:
- platform/chromium-gpu-win/media/video-no-audio-expected.png:
- platform/chromium-gpu-win/media/video-transformed-expected.png:
- platform/chromium-gpu-win/media/video-volume-slider-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
- 16:30 Changeset [88076] by
-
2011-06-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve keyword lookup
https://bugs.webkit.org/show_bug.cgi?id=61913
Rather than doing multiple hash lookups as we currently
do when trying to identify keywords we now use an
automatically generated decision tree (essentially it's
a hard coded patricia trie). We still use the regular
lookup table for the last few characters of an input as
this allows us to completely skip all bounds checks.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pro:
- GNUmakefile.am:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- KeywordLookupGenerator.py: Added.
- make-generated-sources.sh:
- parser/Lexer.cpp: (JSC::Lexer::internalShift): (JSC::Lexer::shift): (JSC::Lexer::parseIdentifier):
- parser/Lexer.h:
- 16:29 Changeset [88075] by
-
<rdar://problem/9553645> and https://bugs.webkit.org/show_bug.cgi?id=62064
WebBackForwardListItem::setBackForwardData actually appends data
Reviewed by Steve Falkenburg.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::setBackForwardData): Clear the Vector out before appending
the replacement data.
- 16:03 Changeset [88074] by
-
2011-06-03 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Allow existing AudioParams to use scheduled parameter changes
https://bugs.webkit.org/show_bug.cgi?id=62046
No new tests since audio API is not yet implemented.
- platform/audio/AudioBus.cpp: (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
- platform/audio/AudioBus.h:
- webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process):
- webaudio/AudioGainNode.h:
- webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
- webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):
- 16:02 Changeset [88073] by
-
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, merge in downstream lines from Chromium as part of
landing the fix for bug 61888.
- platform/chromium/test_expectations.txt:
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
nrwt: should skip chromium test expectation overrides on upstream bots
https://bugs.webkit.org/show_bug.cgi?id=61888
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- 15:52 Changeset [88072] by
-
2011-06-03 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Biquad filter coefficient naming is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62053
No new tests since audio API is not yet implemented.
- platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::process): (WebCore::Biquad::processFast): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setZeroPolePairs):
- platform/audio/Biquad.h:
- 15:42 Changeset [88071] by
-
2011-06-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057
Test that some esoteric combination of eval, load, and Location don't
do something goofy.
- http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Added.
- http/tests/security/xss-DENIED-contentWindow-eval.html: Added.
2011-06-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057
This code gets confused when dealing with inactive DOMWindows. We
should just block inactive DOMWindows because there's no compatibility
reason to support them in this code path.
Test: http/tests/security/xss-DENIED-contentWindow-eval.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::isInsecureScriptAccess):
- 15:38 QtWebKitFeatures22 edited by
- (diff)
- 15:34 Changeset [88070] by
-
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: minor logging, code cleanup
https://bugs.webkit.org/show_bug.cgi?id=62055
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 15:22 Changeset [88069] by
-
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Try to fix the build failure on the GTK+ 32-bit Release bot.
- GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
- 15:14 Changeset [88068] by
-
2011-06-03 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, baseline for full-screen-placeholder. More flakiness for svg/zoom and navigator.
- platform/chromium-win/fullscreen/full-screen-placeholder-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 15:03 Changeset [88067] by
-
Merge 87868 - 2011-06-01 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895
- platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
2011-06-01 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895
- tests/TreeSynchronizerTest.cpp: (WebCore::TEST):
TBR=enne@google.com
- 14:55 Changeset [88066] by
-
2011-05-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ryosuke Niwa.
[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734
Unskip tests which are now passing and update results for other tests
which vary depending on smart replace support.
- platform/gtk/Skipped: Unskip tests which are now passing.
- platform/gtk/editing/deleting/smart-delete-003-expected.txt:
- platform/gtk/editing/deleting/smart-delete-004-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
- platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
- platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/gtk/fast/lists/drag-into-marker-expected.txt:
2011-05-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ryosuke Niwa.
[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734
Add smart replace support to WebCore and add hooks for it in WebKit
via DumpRenderTreeSupportGtk. When a platform supports smart replace,
WebCore will remove extra spaces that appear when pasting text. Eventually
WebKitGTK+ may want to expose this in the public API.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace when calling writeSelection. (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard for whether or not it supports smart paste.
- platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): Added initialization for smart replace atom. (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom. (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
- platform/gtk/PasteboardHelper.h: Add new method definition.
2011-05-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ryosuke Niwa.
[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734
Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
smart replace in the tests.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): targeListForDataObject now takes another parameter determining whether or not to add smart paste support. Add it here.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
- WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation. (WebKit::EditorClient::smartInsertDeleteEnabled): Added. (WebKit::EditorClient::EditorClient):
- WebCoreSupport/EditorClientGtk.h: Add new method definition.
2011-05-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ryosuke Niwa.
[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734
Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
This is required to produce consistent test results.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this methods which calls into DumpRenderTreeSupportGtk.
- 14:53 Changeset [88065] by
-
2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847
Modified failing test's base url so it could get a valid origin
and make use of local storage. Also added another test that checks
local storage visibility in both scenarios.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testOptionalJSObjects): (checkLocalStorageVisibility): (tst_QWebPage::testLocalStorageVisibility):
- 14:49 Changeset [88064] by
-
2011-06-03 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, updating media/video-display-aspect-ratio.html expectations for Chromium.
- platform/chromium/test_expectations.txt:
- 14:45 Changeset [88063] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62033
Switching paintCell to take an IntPoint representing the paint offset
instead of a pair of ints.
No new tests since this is simple refactoring.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject):
- rendering/RenderTableSection.h:
- 14:39 Changeset [88062] by
-
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dimitri Glazkov.
Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071
- Source/autotools/symbols.filter: Added some symbols necessary for window.internals to function to the global symbol list.
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dimitri Glazkov.
Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071
- platform/gtk/Skipped: Unskip the one new window.internals test.
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dimitri Glazkov.
Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071
- GNUmakefile.am: Add new internals directories to the VPATH (for idl processing) and the include list.
2011-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dimitri Glazkov.
Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Inject the new internals object when the window object clears.
- GNUmakefile.am: Add new source files and includes necessary for window.internals. Also do a little bit of cleanup.
- 14:37 Changeset [88061] by
-
Versioning.
- 14:34 Changeset [88060] by
-
New tag.
- 14:33 Changeset [88059] by
-
remove tag.
- 14:33 Changeset [88058] by
-
remove tag.
- 14:31 Changeset [88057] by
-
New tag.
- 14:31 Changeset [88056] by
-
Merge r87839.
- 14:26 Changeset [88055] by
-
New tag.
- 14:26 Changeset [88054] by
-
2011-06-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Enable ArrayBuffer passing tests as ArrayBuffer is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=62025
- platform/qt/Skipped:
- 14:24 Changeset [88053] by
-
2011-06-03 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, adding Ogg Theora version of media/content/test-par-16-9.mp4.
- media/content/test-par-16-9.ogv: Added.
- 14:02 Changeset [88052] by
-
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Warning fixes on comparisons between a signed and an unsigned.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): (DumpRenderTreeSupportQt::nodesFromRect):
- 13:59 Changeset [88051] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintBackgroundsBehindCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62031
Switching paintBackgroundsBehindCell to take an IntPoint representing
the paint offset instead of a pair of ints.
No new tests as this is simple refactoring.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell):
- 13:57 Changeset [88050] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintCaret and paintDragCaret to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62037
Switching paintCaret and paintDragCaret to use an IntPoint representing
the paint offset instead of a pair of ints.
No new tests since this is simple refactoring.
- editing/FrameSelection.cpp: (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::DragCaretController::paintDragCaret):
- editing/FrameSelection.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::offsetForContents):
- rendering/RenderBlock.h:
- 13:55 Changeset [88049] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintItemForeground and paintItemForeground to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62035
Switching paintItemFore/Background to use IntPoint instead of a pair of ints.
No new tests since this is simple refactoring.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
- rendering/RenderListBox.h:
- 13:53 Changeset [88048] by
-
2011-06-03 Anders Carlsson <andersca@apple.com>
Reviewed by Brady Eidson.
Disable the sync message timeout for the Microsoft SharePoint plug-in
https://bugs.webkit.org/show_bug.cgi?id=62043
<rdar://problem/9536303>
- WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout):
- 13:49 Changeset [88047] by
-
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Fix conflict in expectations.
- platform/chromium/test_expectations.txt:
- 13:35 Changeset [88046] by
-
2011-06-03 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] TiledDrawingArea: Initialize tiles to transparent.
- UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate): When constructing new back buffers, fill them with transparent pixels.
- 13:32 Changeset [88045] by
-
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
- WebCoreSupport/FrameLoaderClientQt.h:
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
- platform/network/qt/QtMIMETypeSniffer.h:
- 13:29 Changeset [88044] by
-
[Chromium] Unreviewed test expectations update for inspector/profiler/cpu-profiler-profiling* on Linux. https://bugs.webkit.org/show_bug.cgi?id=61533
- 13:28 Changeset [88043] by
- 13:22 Changeset [88042] by
- 13:07 Changeset [88041] by
-
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix after r87902.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
only on classes inside Qt.
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- 12:43 Changeset [88040] by
-
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Worker may not be stopped after LT.
https://bugs.webkit.org/show_bug.cgi?id=61847
Re-submit a variant of the first fix for this bug. It's possible
that actually calling cleanup() in the worker threads was taking
too long and we triggered the assertions in the manager thread.
I've bumped up the timeout in the manager and added better
diagnostics. I also cleaned up the cleanup() code a bit because
there was some unnecessary if-checks.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 12:35 Changeset [88039] by
-
2011-06-03 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
Cleanup member variable usage in svg/animation classes
https://bugs.webkit.org/show_bug.cgi?id=62029
Cleanup member variables.
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement):
- svg/animation/SVGSMILElement.h:
- 12:18 Changeset [88038] by
-
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
Some warning fixes. Values in switch not handled, and
a comparison between a signed and an unsigned.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::action):
- 12:17 Changeset [88037] by
-
2011-06-03 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioParam parameter scheduling implementation
https://bugs.webkit.org/show_bug.cgi?id=61830
No new tests since audio API is not yet implemented.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- webaudio/AudioParam.cpp: (WebCore::AudioParam::value): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::calculateSampleAccurateValues):
- webaudio/AudioParam.h: (WebCore::AudioParam::setContext): (WebCore::AudioParam::context): (WebCore::AudioParam::setValueAtTime): (WebCore::AudioParam::linearRampToValueAtTime): (WebCore::AudioParam::exponentialRampToValueAtTime): (WebCore::AudioParam::setTargetValueAtTime): (WebCore::AudioParam::setValueCurveAtTime): (WebCore::AudioParam::cancelScheduledValues): (WebCore::AudioParam::hasTimelineValues):
- webaudio/AudioParam.idl:
- webaudio/AudioParamTimeline.cpp: Added. (WebCore::AudioParamTimeline::setValueAtTime): (WebCore::AudioParamTimeline::linearRampToValueAtTime): (WebCore::AudioParamTimeline::exponentialRampToValueAtTime): (WebCore::AudioParamTimeline::setTargetValueAtTime): (WebCore::AudioParamTimeline::setValueCurveAtTime): (WebCore::isValidNumber): (WebCore::AudioParamTimeline::insertEvent): (WebCore::AudioParamTimeline::cancelScheduledValues): (WebCore::AudioParamTimeline::valueForContextTime): (WebCore::AudioParamTimeline::valuesForTimeRange): (WebCore::timeToSampleFrame): (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- webaudio/AudioParamTimeline.h: Added. (WebCore::AudioParamTimeline::AudioParamTimeline): (WebCore::AudioParamTimeline::hasValues): (WebCore::AudioParamTimeline::ParamEvent::ParamEvent): (WebCore::AudioParamTimeline::ParamEvent::type): (WebCore::AudioParamTimeline::ParamEvent::value): (WebCore::AudioParamTimeline::ParamEvent::time): (WebCore::AudioParamTimeline::ParamEvent::timeConstant): (WebCore::AudioParamTimeline::ParamEvent::duration): (WebCore::AudioParamTimeline::ParamEvent::curve):
- 12:05 QtWebKitFeatures22 edited by
- (diff)
- 12:03 QtWebKitFeatures22 edited by
- (diff)
- 12:02 QtWebKitFeatures22 edited by
- (diff)
- 12:02 Changeset [88036] by
- 12:00 Changeset [88035] by
-
2011-06-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: fix duplicate logging regression
https://bugs.webkit.org/show_bug.cgi?id=61981
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- 11:57 QtWebKitFeatures22 edited by
- (diff)
- 11:51 QtWebKitFeatures22 edited by
- (diff)
- 11:48 Changeset [88034] by
-
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>
- fullscreen/full-screen-placeholder-expected.txt: Added.
- fullscreen/full-screen-placeholder.html: Added.
2011-06-01 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>
Test: fullscreen/full-screen-placeholder.html
Entering full-screen mode is causing the page layout to change because the full-screen
element is taken out of the normal flow. To counteract this effect, insert a placeholder
block as a parent of the full-screen renderer with the same size and style as the full-screen
element pre-full-screen.
Only create a placeholder for block-level elements; the technique required for inline elements
would be vastly more complicated.
- dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder
based on the size and style of the full-screen element.
(WebCore::Document::setFullScreenRenderer): Persist the placeholder size and
style across new renderers.
- rendering/RenderFullScreen.cpp: (RenderFullScreen::RenderFullScreen): Added ivar. (RenderFullScreen::destroy): Make sure to safely destroy our placeholder. (RenderFullScreen::createPlaceholder): Added.
- rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::placeholder): Ivar accessor.
- 11:43 Changeset [88033] by
-
2011-06-03 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintBoxDecorations to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61968
Switching paintBoxDecorations to take an IntPoint representing
the paint offset instead of a pair of ints. Also cleaning up
some duplicated code in InlineFlowBox related to constraining
the paint rect to the linetop and linebottom.
No new tests since this is just refactoring.
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added to remove duplicate code in paintBoxDecorations and paintMask. (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
- rendering/RenderBox.h:
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFieldset.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTableCell.h:
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
- 11:37 QtWebKitFeatures22 edited by
- (diff)
- 11:33 Changeset [88032] by
-
2011-06-03 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Adam Barth.
Removed test_expectations failure entry for BUGCR36415 as is fixed
with patch in https://bugs.webkit.org/show_bug.cgi?id=62016
- platform/chromium/test_expectations.txt:
2011-06-03 Robert Kroeger <rjkroege@chromium.org>
Reviewed by Adam Barth.
Modified addTouchPoint to correctly re-use touchPoint id values starting
from the lowest not-un-use touchPoint id as is done by the embedder
APIs. (Fixes BUGCR36415)
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint):
- 11:22 Changeset [88031] by
-
2011-06-03 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, pixel baselines for selectlist-minsize.html.
- platform/chromium-linux/fast/forms/selectlist-minsize-expected.png: Added.
- platform/chromium-linux/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Added.
- platform/chromium-win/fast/forms/selectlist-minsize-expected.png: Added.
- platform/chromium-win/fast/forms/selectlist-minsize-expected.txt: Added.
- 10:39 Changeset [88030] by
-
2011-06-03 Philippe Beauchamp <philippe.beauchamp@gmail.com>
Reviewed by Dimitri Glazkov.
Add the feature "Add as search engine..." in a search text field context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980
- public/WebContextMenuData.h:
- public/WebSearchableFormData.h:
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/WebSearchableFormData.cpp: (WebKit::WebSearchableFormData::WebSearchableFormData):
- 10:03 Changeset [88029] by
-
2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>
Reviewed by Benjamin Poulain.
[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752
The test is to get the render tree of select menu lists with varying widths based on content.
Some select list based tests are rebaselined because minimum width of RenderMenuList changes
based on the content with this fix.
- fast/forms/selectlist-minsize.html: Added.
- platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/qt/editing/pasteboard/4641033-expected.txt:
- platform/qt/editing/pasteboard/4944770-1-expected.txt:
- platform/qt/editing/pasteboard/4944770-2-expected.txt:
- platform/qt/editing/selection/caret-before-select-expected.txt:
- platform/qt/fast/forms/003-expected.txt:
- platform/qt/fast/forms/004-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/qt/fast/forms/basic-selects-expected.txt:
- platform/qt/fast/forms/menulist-deselect-update-expected.txt:
- platform/qt/fast/forms/menulist-separator-painting-expected.txt:
- platform/qt/fast/forms/menulist-style-color-expected.txt:
- platform/qt/fast/forms/option-script-expected.txt:
- platform/qt/fast/forms/select-background-none-expected.txt:
- platform/qt/fast/forms/select-baseline-expected.txt:
- platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/qt/fast/forms/select-empty-option-height-expected.txt:
- platform/qt/fast/forms/select-size-expected.txt:
- platform/qt/fast/forms/select-style-expected.txt:
- platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/qt/fast/invalid/014-expected.txt:
- platform/qt/fast/replaced/replaced-breaking-expected.txt:
- platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/qt/fast/replaced/three-selects-break-expected.txt:
- platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
- platform/qt/tables/mozilla/core/margins-expected.txt:
2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>
Reviewed by Benjamin Poulain.
[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752
The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.
Test: fast/forms/selectlist-minsize.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::minimumMenuListSize):
- 10:00 Changeset [88028] by
-
2011-06-03 Marcus Bulach <bulach@chromium.org>
Reviewed by Unreviewed rebaseline.
[chromium] Rebaseline following r88020
https://bugs.webkit.org/show_bug.cgi?id=62028
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 09:54 Changeset [88027] by
-
2011-06-03 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt][WK2] Make tiling on WebKit2 more responsive.
https://bugs.webkit.org/show_bug.cgi?id=50064
Instead of creating and destroying pixmaps, and copying them using QPixmap::copy()
or relying on the implicit sharing functionality, we keep the QPixmaps alive
and just make sure their content is synchronized.
This seems to improve responsiveness noticably, as now the UI process doesn't deal
with allocating/deallocating pixmaps, and the copies are done with the optimized
path (QPainter) vs the unoptimized ones (QPixmap::copy().)
- UIProcess/TiledDrawingAreaTile.h:
- UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::incorporateUpdate):
- 09:26 Changeset [88026] by
-
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979
- fast/events/shadow-boundary-crossing-expected.txt: Added test.
- fast/events/shadow-boundary-crossing.html: Added expectations.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979
Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.
- dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing. (WebCore::EventDispatcher::EventDispatcher): Added initializer. (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
- dom/EventDispatcher.h: Added a def.
- 09:24 Changeset [88025] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
- platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- 09:14 Changeset [88024] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, new baselines for GTK after r88011.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
- 09:08 Changeset [88023] by
-
Mac build fix.
- WebCore.xcodeproj/project.pbxproj:
- 09:07 Changeset [88022] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, tests rebaselines for GTK after r88011.
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
- platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
- 09:00 Changeset [88021] by
-
2011-06-03 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721
Manual test: select-popup-tooltip-test.html
- manual-tests/select-popup-tooltip-test.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
- platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.
2011-06-03 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721
- public/WebMenuItemInfo.h: Add toolTip.
- public/WebViewClient.h: Remove setToolTipText().
- public/WebWidgetClient.h: Add setTooTipText(). (WebKit::WebWidgetClient::setToolTipText):
- src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().
- 08:45 Changeset [88020] by
-
2011-06-03 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301
Update test results.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- svg/custom/global-constructors-expected.txt:
2011-06-03 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301
Enable constructors for SVGMPathElement and SVGAnimateMotionElement.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- 08:37 BuildingQtOnLinux edited by
- added note on ICU (diff)
- 08:02 Changeset [88019] by
-
2011-06-03 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009
This constant should only be needed inside IDBLevelDBCoding.cpp.
No new functionality, no new tests.
- storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::getNewIndexId):
- storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
- storage/IDBLevelDBCoding.h:
2011-06-03 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009
Don't use INT64_MAX, use the various encodeMaxKey() functions instead.
- tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
- 07:58 Changeset [88018] by
-
2011-06-03 Marcus Bulach <bulach@chromium.org>
Reviewed by Unreviewed rebaseline.
[chromium] Rebaseline following r88007-88008
https://bugs.webkit.org/show_bug.cgi?id=62018
- platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/chromium-linux-x86/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/chromium-linux/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
- platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 07:53 Changeset [88017] by
-
2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88014.
http://trac.webkit.org/changeset/88014
https://bugs.webkit.org/show_bug.cgi?id=62017
Broken EFL build (Requested by tonikitoo on #webkit).
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
- 07:47 Changeset [88016] by
-
2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786
Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.
- JavaScriptCore.pri: Support for use_system_icu CONFIG flag.
- wtf/unicode/qt4/UnicodeQt4.h: Guard an include file with USE(ICU_UNICODE).
2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786
Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.
No new tests as no new features added.
- WebCore.pri: Removed text_breaking_with_icu CONFIG flag.
- WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
- editing/qt/SmartReplaceQt.cpp:
- features.pri: Support for use_system_icu CONFIG flag.
- platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE).
- platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added. (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
- platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). (WebCore::isTextBreak):
- platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). (WebCore::TextCodecQt::registerEncodingNames): (WebCore::TextCodecQt::registerCodecs):
- 07:39 Changeset [88015] by
-
2011-06-03 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Draw DRT scroll bar thumb with CG when WebKit renders with Skia
https://bugs.webkit.org/show_bug.cgi?id=61534
Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.
The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.
The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/
When WebKit uses Skia for rendering, the WebCanvas
is an SkCanvas. Create an equivalent CGContext to
draw the scrollbar thumb.
As the Chrome Mac port does not yet use Skia, this
patch has no effect and requires no tests.
- DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
- 07:17 Changeset [88014] by
-
2011-06-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998
Implement startDownload() with download().
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
- 07:12 Changeset [88013] by
-
2011-06-03 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
Fix typo.
- Scripts/old-run-webkit-tests:
- 06:56 Changeset [88012] by
-
2011-06-03 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=61939
- Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
- Scripts/webkitperl/httpd.pm:
- 06:47 Changeset [88011] by
-
2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
- fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
Test: fast/frames/flattening/iframe-flattening-out-of-view.html
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
- rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame):
- 06:29 Changeset [88010] by
-
2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533
Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
- inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Added.
- inspector/profiler/cpu-profiler-profiling-without-inspector.html: Added.
- platform/chromium/test_expectations.txt:
2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533
Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
- public/WebDevToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
- src/WebDevToolsAgentImpl.h:
2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533
Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptProfilingEnabled):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptProfilingEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533
Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorSetJavaScriptProfilingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
- WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::setJavaScriptProfilingEnabled):
- WebProcess/WebPage/WebInspector.h:
- 05:43 Changeset [88009] by
-
2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007
When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.
- platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
- platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
- platform/mac/svg/as-object: Added.
- platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
- platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
- svg/as-image/img-preserveAspectRatio-support-2.html: Added.
- svg/as-image/resources/circle-default-default.svg: Added.
- svg/as-object: Added.
- svg/as-object/object-box-sizing-no-width-height.html: Added.
2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007
When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.
RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.
Tests: svg/as-image/img-preserveAspectRatio-support-2.html
svg/as-object/object-box-sizing-no-width-height.html
- rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
- 05:36 Changeset [88008] by
-
2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008
This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).
- platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Removed.
- platform/gtk/accessibility/caret-browsing-anchor-followed.html: Removed.
2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008
This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor):
- 05:11 Changeset [88007] by
-
2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005
Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Added new tests covering this zooming.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- svg/zoom/page/resources/circle.svg: Added.
- svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Added.
2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005
Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
zoom in the RenderStyle instead of asking SVGSVGElement.
The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.
Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html
- rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::localToBorderBoxTransform):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):
- svg/SVGSVGElement.h:
- 05:04 Changeset [88006] by
-
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=.
- Source/WebKit.pri:
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.
- JavaScriptCore.pro:
- 04:20 Changeset [88005] by
-
[Qt][WK2] Update platform specific expected file after r87873.
- platform/qt-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
- 04:10 Changeset [88004] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737
Update the caret position to the anchor's position after scrolling.
This behavior is specific to the Gtk port and requested because of
accessibility needs, that's why it's implemented in AXObjectCache.
Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the caret is updated to be in the anchor's position after scrolling.
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737
New layout test for testing this GTK-specific feature.
- platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
- platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.
- 03:44 Changeset [88003] by
-
Merge 87802 - 2011-06-01 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825
Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
- Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
- The attribute webkitIsVisible needs to change to webkitHidden
- fast/events/page-visibility-iframe-delete-test.html:
- fast/events/page-visibility-iframe-move-test-expected.txt:
- fast/events/page-visibility-iframe-move-test.html:
- fast/events/page-visibility-iframe-propagation-test-expected.txt:
- fast/events/page-visibility-iframe-propagation-test.html:
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
2011-06-01 Shishir Agrawal <shishir@chromium.org>
Reviewed by Tony Gentilcore.
Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825
Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
- Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
- The attribute webkitIsVisible needs to change to webkitHidden
- dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
- dom/Document.h:
- dom/Document.idl:
- dom/EventNames.h:
BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7065057
- 03:35 Changeset [88002] by
-
2011-06-03 Dominic Cooney <dominicc@chromium.org>
Reviewed by Kent Tamura.
Adds a test that keygen clones have the right shadow pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984
- fast/html/clone-keygen-expected.txt: Added.
- fast/html/clone-keygen.html: Added.
- platform/win/Skipped: Test needs DRT functionality not in this port.
2011-06-03 Dominic Cooney <dominicc@chromium.org>
Reviewed by Kent Tamura.
Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984
When cloneNode's tag name-based cloning algorithm clones the
KeygenSelectElements of a keygen shadow as select elements. These
lack the -webkit-keygen-select pseudoclass.
Test: fast/html/clone-keygen.html
- html/HTMLKeygenElement.cpp: (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
- 03:31 Changeset [88001] by
-
2011-06-02 MORITA Hajime <morrita@google.com>
Unreviewed ChangeLog fix.
- 03:08 Changeset [88000] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test with different results in 32-bit and 64-bit.
- platform/gtk/Skipped: Skipped test.
- 03:05 Changeset [87999] by
-
2011-06-03 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Unref the SoupSession used by WebKitGtk+ at exit
https://bugs.webkit.org/show_bug.cgi?id=60165
WebKitGtk+ creates a SoupSession instance to handle network stuff
that is never freed. We should unref that object at exit time.
- webkit/webkitglobals.cpp: (webkitExit): (webkitInit):
- 02:53 Changeset [87998] by
-
[Qt] Update platform specific expected files after r87873.
- platform/qt/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
- platform/qt/plugins/document-open-expected.txt: Added.
- 01:57 Changeset [87997] by
-
[Qt][V8] build fix.
- 01:36 Changeset [87996] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Test rebaseline for GTK after revision 87936.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- 01:36 Changeset [87995] by
-
2011-06-03 Dominic Cooney <dominicc@chromium.org>
Reviewed by Kent Tamura.
Adds a test that range input clones have the right kind of slider.
https://bugs.webkit.org/show_bug.cgi?id=61982
- fast/html/clone-range-expected.txt: Added.
- fast/html/clone-range.html: Added.
- platform/win/Skipped: Test needs DRT functionality not in this port.
2011-06-03 Dominic Cooney <dominicc@chromium.org>
Reviewed by Kent Tamura.
Cloned range input sliders should be SliderThumbElements, not divs.
https://bugs.webkit.org/show_bug.cgi?id=61982
Test: fast/html/clone-range.html
- html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
- 01:22 Changeset [87994] by
-
2011-06-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Organize the disabled features section in the Skipped list
https://bugs.webkit.org/show_bug.cgi?id=61994
Move all the tests for disabled features under the "Disabled
features" section in the Skipped list. Use the name of the build flags to
identify the features for better tracking.
- platform/qt/Skipped:
- 00:47 Changeset [87993] by
-
2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, unskipping tests, now passing after reverting r87901.
- platform/gtk/Skipped: Unskipped 3 tests.
- 00:23 Changeset [87992] by
-
2011-06-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930
Worker list is extended with a checkbox that makes inspector attach to each
new worker. Whenever a new worker context starts a new inspector window will
be opened for it.
Also worker agent and worker list will be updated when worker context is terminated.
- inspector/Inspector.json:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::workerContextTerminated):
- inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers): (WebCore::InspectorWorkerAgent::didStartWorkerContext): (WebCore::InspectorWorkerAgent::workerContextTerminated):
- inspector/InspectorWorkerAgent.h:
- inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._workerTerminated): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype._openInspectorWindow): (WebInspector.WorkerManager.prototype.reset): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
- inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workersCleared): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked): (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
- inspector/front-end/inspector.js: (WebInspector.reset):
2011-06-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930
Notification about worker context termination are now sent to the inspector.
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::workerContextDestroyed):
06/02/11:
- 22:17 Changeset [87991] by
-
2011-06-02 Hayato Ito <hayato@chromium.org>
Reviewed by Ryosuke Niwa.
Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
https://bugs.webkit.org/show_bug.cgi?id=61992
It's better to show a shadow root node itself for debugging.
Skipping it didn't add any values.
No new tests since the function is only available in debug builds.
- dom/Node.cpp: (WebCore::traverseNextNodeAcrossFrame):
- 20:12 Changeset [87990] by
-
2011-06-02 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r87901.
http://trac.webkit.org/changeset/87901
https://bugs.webkit.org/show_bug.cgi?id=61894
Might be responsible for performance regression on Chromium page cyclers, reverting to see...
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): (WebCore::DocumentLoader::haveToldClientAboutLoad):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
- 19:41 Changeset [87989] by
-
2011-06-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Switch paintReplaced to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61891
Switching paintReplaced to use IntPoint to represent the paint offset instead
of a pair of ints.
Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
fact that the IntPoint is added as an offset as opposed to being relocated
to that point.
No tests because this is just a refactoring.
- page/FrameView.cpp: (WebCore::FrameView::invalidateScrollbarRect): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer):
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
- platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
- platform/graphics/gpu/Texture.cpp (WebCore::Texture::updateSubRect)
- platform/graphics/IntRect.h: (WebCore::IntRect::moveBy):
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalRectToPhysicalRect): (WebCore::RenderBlock::selectionGaps):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::localCaretRect):
- rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderHTMLCanvas.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
- rendering/RenderImage.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
- rendering/RenderLayer.cpp: (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::boundingBox): (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::controlClipRect):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderReplaced.h: (WebCore::RenderReplaced::paintReplaced):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::controlClipRect):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
- rendering/RenderVideo.h:
- rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
- 19:34 Changeset [87988] by
-
2011-06-02 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium][V8] Add trace events for timer fires and event listener dispatches
https://bugs.webkit.org/show_bug.cgi?id=61977
Adds TRACE_EVENT macro around timer and event listener dispatches. When tracing (a chromium feature) is
enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
is traced. When tracing is disabled, this macro does nothing useful. Trace points are very cheap when tracing
is disabled so this should have no performance impact for non-developers.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
- 19:10 Changeset [87987] by
-
2011-06-02 John Bates <jbates@google.com>
Reviewed by James Robinson.
DrawingBufferChromium cleanup:
- Correct FIXME comment about synchronization.
- Remove unnecessary DrawingBufferInternal indirection struct and its unused offscreenColorTexture member. https://bugs.webkit.org/show_bug.cgi?id=61953
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer):
- platform/graphics/gpu/DrawingBuffer.h:
- 18:50 Changeset [87986] by
-
Merge r87945.
- 18:48 Changeset [87985] by
-
Merge r87857.
- 18:46 Changeset [87984] by
-
Merge r87856.
- 18:44 Changeset [87983] by
-
2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix enum order in qwebpage.h public API header
https://bugs.webkit.org/show_bug.cgi?id=61959
Since qwebpage.h is a public header, we can't change the values of
the enumerations. This patch moves the new enumeration to the end
of the list. As a bonus, adds a missing entry in
editorCommandWebActions table.
- Api/qwebpage.cpp:
- Api/qwebpage.h:
- 18:44 Changeset [87982] by
-
Merge r87844.
- 18:21 Changeset [87981] by
-
2011-06-02 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: ResourceCookiesView.resize() is missing
https://bugs.webkit.org/show_bug.cgi?id=61868
- inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.resize):
- 18:15 Changeset [87980] by
-
2011-06-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r87014): Cloned text <input> doesn't work well.
https://bugs.webkit.org/show_bug.cgi?id=61909
- fast/forms/textfield-clone-expected.txt: Added.
- fast/forms/textfield-clone.html: Added.
2011-06-02 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r87014): Cloned text <input> doesn't work well.
https://bugs.webkit.org/show_bug.cgi?id=61909
The default implementation of Element::cloneNode() creates a clone
node by Document::createElement(). So, if a customized class is used for
shadow nodes, cloneNode() doesn't create a node of the correct class.
- Such custom classes need to override Element
- cloneElementWithoutAttributesAndChildren().
TextFieldInputType and SearchInputType had references to shadow nodes
initialized in createShadowSubtree(). However createShadowSubtree() is
not called if the host node is cloned. The accessors for shadow nodes
should search a shadow tree.
Test: fast/forms/textfield-clone.html
- html/SearchInputType.cpp: Remove data members for shadow nodes, and the accessors search the shadow tree for the requested node by TreeScope::getElementById(). (WebCore::SearchInputType::SearchInputType): (WebCore::innerBlockId): (WebCore::resultButtonId): (WebCore::cancelButtonId): (WebCore::SearchInputType::createShadowSubtree): (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
- html/SearchInputType.h:
- html/TextFieldInputType.cpp: ditto. (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::innerTextId): (WebCore::spinButtonId): (WebCore::TextFieldInputType::speechButtonId): (WebCore::TextFieldInputType::appendChildAndSetId): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::getShadowElementById): (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement):
- html/TextFieldInputType.h:
- html/shadow/TextControlInnerElements.cpp: Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode() produces an instance of the correct class. (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren): (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren): (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
- html/shadow/TextControlInnerElements.h:
- 18:13 Changeset [87979] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
Tweaks to which kind of failure we expect.
- platform/chromium/test_expectations.txt:
- 18:05 Changeset [87978] by
-
2011-05-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Remove PasteboardHelperGtk
https://bugs.webkit.org/show_bug.cgi?id=61690
Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
can be removed. Since the GtkClipboard IDs are verified to be the same between
WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
get them.
No new tests. This is just a code refactor.
- platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
- platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the PasteboardHelper singleton directly.
- platform/gtk/ClipboardGtk.h: Ditto.
- platform/gtk/PasteboardGtk.cpp: Ditto.
- platform/gtk/PasteboardHelper.cpp: (WebCore::removeMarkupPrefix): Remove an extra line. (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter for the singleton. (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here. (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine whether or not to use the primary selection clipboard, just use our new member. (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID. (WebCore::PasteboardHelper::targetListForDataObject): Ditto. (WebCore::PasteboardHelper::dropAtomsForContext): Ditto. (WebCore::getClipboardContentsCallback): Ditto.
- platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or not to use the primary selection clipboard internally. (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added. (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.
2011-05-28 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Remove PastboardHelperGtk
https://bugs.webkit.org/show_bug.cgi?id=61690
Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
activity. This change moves the PasteboardHelper singleton from WebKit
to WebCore.
- GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
- WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the WebCore versions of the GtkClipboard enums match those in the WebKit API.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify that the current clipboard is selection primary now.
- WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
- webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
- webkit/webkitglobalsprivate.h: Ditto.
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Access the pasteboard helper via a static method. (webkit_web_view_drag_data_get): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_get_copy_target_list): Ditto. (webkit_web_view_get_paste_target_list): Ditto.
- webkit/webkitwebviewprivate.h: Ditto.
- 17:57 Changeset [87977] by
-
Merge r87826.
- 17:52 Changeset [87976] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
This process is converging (hopefully).
- platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Added.
- 17:50 Changeset [87975] by
-
Merge r87768.
- 17:48 Changeset [87974] by
-
Merge r87804.
- 17:46 Changeset [87973] by
-
Merge r87755.
- 17:44 Changeset [87972] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
Some more fallout from http://trac.webkit.org/changeset/87955, this time on Windows.
- platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Removed.
- platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
- 17:44 Changeset [87971] by
-
Merge r87704.
- 17:42 Changeset [87970] by
-
Merge r87703.
- 17:30 Changeset [87969] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
This test is flaky on Linux.
- platform/chromium/test_expectations.txt:
- 17:28 Changeset [87968] by
-
2011-06-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Assert when trying to unload a module that failed to load
https://bugs.webkit.org/show_bug.cgi?id=61980
Remove an invalid ASSERT; it's OK for m_bundle to be null if the bundle failed to load.
- Platform/mac/ModuleMac.mm: (WebKit::Module::unload):
- 17:21 Changeset [87967] by
-
2011-06-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
NRWT needs a way to log to a file without including backspaces without needing --verbose
https://bugs.webkit.org/show_bug.cgi?id=60328
This change modifies NRWT so that if it can tell if it is
writing to a terminal, it will overwrite any messages printed
in the 'one-line-progress' and 'updates' print options, and if
not (or if --verbose was specified) the messages will be printed
without backspaces.
If the overwriting updates are disabled, one-line-progress will
only print every 10 seconds instead of on every update. This
ensures that we still get updates once in a while while the
tests are running, even if we're not in --verbose mode. Note
that one-line-progress will now still be printed in --verbose,
since it's useful as long as you're not flooded with the
updates.
- Scripts/webkitpy/layout_tests/layout_package/manager.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- 17:16 Changeset [87966] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
The next round of updated baselines after
http://trac.webkit.org/changeset/87955. Again, these all look fine to
visual inspection.
- platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png:
- platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
- platform/chromium-mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
- platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
- platform/chromium-mac/fast/borders/border-styles-split-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png: Added.
- platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Added.
- platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Added.
- platform/chromium-mac/fast/borders/webkit-border-radius-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/spread-expected.png:
- platform/chromium-mac/fast/css/border-radius-non-negative-expected.png: Added.
- platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
- platform/chromium-mac/fast/css/shadow-multiple-expected.png: Added.
- platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Added.
- platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Added.
- platform/chromium-mac/fast/forms/select-background-none-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
- platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Added.
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/chromium-mac/svg/carto.net/button-expected.png: Added.
- 17:01 Changeset [87965] by
-
2011-06-02 Aaron Colwell <acolwell@chromium.org>
Reviewed by David Levin.
Add mediaTimeForTimeValue() implementation.
https://bugs.webkit.org/show_bug.cgi?id=61555
- public/WebMediaPlayer.h:
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
- src/WebMediaPlayerClientImpl.h:
- 16:49 Changeset [87964] by
-
2011-06-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Eric Seidel.
Teach InlineBox about FloatPoint
https://bugs.webkit.org/show_bug.cgi?id=44412
Original patch by Eric Seidel. Updated by me.
This is another step towards more point/size
usage throughout the rendering tree.
Added left(), right(), top(), and bottom() methods
to InlineBox. Removed m_x, and m_y and replaced them
with a single m_topLeft member.
No new tests since this is just a refactoring.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection): (WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::canAccommodateEllipsis):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::left): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::top): (WebCore::InlineBox::topLeft): (WebCore::InlineBox::right): (WebCore::InlineBox::bottom): (WebCore::InlineBox::logicalLeft): (WebCore::InlineBox::setLogicalLeft): (WebCore::InlineBox::logicalTop): (WebCore::InlineBox::setLogicalTop): (WebCore::InlineBox::logicalFrameRect):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker):
- rendering/RenderText.cpp: (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY):
- rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis):
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint):
- rendering/svg/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::selectionTop):
- rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
- 16:45 Changeset [87963] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
First round of baseline updates after
http://trac.webkit.org/changeset/87955 changed some floating point
calculations for borders. Visually, these appear to all be fine.
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
- platform/chromium-linux-x86/fast/backgrounds: Added.
- platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-radius-constraints-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-radius-split-inline-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid04-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/different-color-borders-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/fieldsetBorderRadius-expected.png: Added.
- platform/chromium-linux-x86/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/chromium-linux-x86/fast/box-shadow/inset-expected.png: Added.
- platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/chromium-linux-x86/fast/box-shadow/spread-multiple-inset-expected.png: Added.
- platform/chromium-linux-x86/fast/clip: Added.
- platform/chromium-linux-x86/fast/clip/overflow-border-radius-clip-expected.png: Added.
- platform/chromium-linux-x86/fast/css/nested-rounded-corners-expected.png: Added.
- platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png:
- platform/chromium-linux-x86/fast/transforms: Added.
- platform/chromium-linux-x86/fast/transforms/shadows-expected.png: Added.
- platform/chromium-linux-x86/media: Added.
- platform/chromium-linux-x86/media/video-zoom-controls-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/dasharrayOrigin-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/fractional-rects-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/gradient-rotated-bbox-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/rounded-rects-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
- platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png:
- platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-linux/fast/backgrounds/border-radius-split-background-expected.png:
- platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
- platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
- platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
- platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
- platform/chromium-linux/fast/borders/different-color-borders-expected.png:
- platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
- platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
- platform/chromium-linux/fast/transforms/shadows-expected.png:
- platform/chromium-linux/media/video-zoom-controls-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
- platform/chromium-linux/svg/custom/dasharrayOrigin-expected.png:
- platform/chromium-linux/svg/custom/fractional-rects-expected.png:
- platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
- platform/chromium-linux/svg/custom/rounded-rects-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
- platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
- platform/chromium-mac-leopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/border-radius-repaint-expected.png: Added.
- platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/perf: Added.
- platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/border-radius-split-background-expected.png:
- platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
- platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-constraints-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Added.
- platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
- platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png:
- platform/chromium-mac/fast/clip: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Added.
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac/fast/repaint/border-radius-repaint-expected.png: Added.
- platform/chromium-mac/fast/transforms/shadows-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
- platform/chromium-mac/svg/custom/dasharrayOrigin-expected.png:
- platform/chromium-mac/svg/custom/fractional-rects-expected.png: Added.
- platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png:
- platform/chromium-mac/svg/custom/rounded-rects-expected.png: Added.
- platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-mac/svg/hixie/perf/001-expected.png:
- platform/chromium-mac/svg/hixie/perf/002-expected.png:
- platform/chromium-mac/svg/wicd: Added.
- platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png: Added.
- platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Added.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
- platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Removed.
- platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Removed.
- platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/border-radius-split-background-expected.png:
- platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
- platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
- platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
- platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
- platform/chromium-win/fast/borders/different-color-borders-expected.png:
- platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/inset-expected.png:
- platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
- platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
- platform/chromium-win/svg/custom/dasharrayOrigin-expected.png:
- platform/chromium-win/svg/custom/fractional-rects-expected.png:
- platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
- platform/chromium-win/svg/custom/rounded-rects-expected.png:
- platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png: Added.
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.txt: Added.
- 16:02 Changeset [87962] by
-
2011-06-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Need a way to install the memory pressure handler without initializing WebKit1
https://bugs.webkit.org/show_bug.cgi?id=61975
Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
-[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
but we'd like to be able to install a memory pressure handler without creating a WebView or even
calling any WebView method since that will call +[WebView initialize].
- WebKit.exp:
- WebView/WebView.mm: (WebInstallMemoryPressureHandler):
- WebView/WebViewPrivate.h:
- 15:26 Changeset [87961] by
-
Update the behavior of multiple reads for FileReader
https://bugs.webkit.org/show_bug.cgi?id=61793
Reviewed by David Levin.
Source/WebCore:
Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
status code on any of the read methods that occur when readyState = LOADING.
Otherwise, calling any of the read methods should work.
Test: fast/files/read-file-async.html
- CodeGenerators.pri:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
- dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::abort):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
- fileapi/FileReader.h:
(WebCore::FileReader::readyState):
- fileapi/FileReader.idl:
- fileapi/OperationNotAllowedException.h: Added.
(WebCore::OperationNotAllowedException::create):
(WebCore::OperationNotAllowedException::OperationNotAllowedException):
- fileapi/OperationNotAllowedException.idl: Added.
LayoutTests:
Added test cases to cover calling read methods multiple times.
- fast/files/read-file-async-expected.txt:
- fast/files/resources/read-file-test-cases.js:
(ensureInitialized):
(runNextTest):
(testMultipleReads):
(testReuseReaderStep1):
(testReuseReaderStep2):
- fast/files/workers/worker-read-file-async-expected.txt:
- 15:14 Changeset [87960] by
-
2011-06-02 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
- 15:03 Changeset [87959] by
-
<rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.
Reviewed by Oliver Hunt.
Source/WebCore:
Test: webarchive/loading/javascript-url-iframe-crash.html
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
cause the DocumentLoader to be destroyed, so protect it with a Ref here.
LayoutTests:
- webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
- webarchive/loading/javascript-url-iframe-crash.html: Added.
- webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
- 14:59 Changeset [87958] by
-
2011-06-02 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169
- wtf/DateMath.cpp: (WTF::twoDigitStringFromNumber): (WTF::makeRFC2822DateString):
- wtf/DateMath.h:
2011-06-02 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169
- loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::generateRandomBoundary): (WebCore::replaceNonPrintableCharacters): (WebCore::MHTMLArchive::generateMHTMLData):
- loader/archive/mhtml/MHTMLArchive.h:
- page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
- platform/SharedBuffer.h:
2011-06-02 Jay Civelli <jcivelli@chromium.org>
Reviewed by Adam Barth.
Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169
- public/WebPageSerializer.h:
- src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML):
- 14:50 Changeset [87957] by
-
2011-06-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] autogen.sh is run twice for each buld on the bots
https://bugs.webkit.org/show_bug.cgi?id=61951
- Scripts/webkitdirs.pm: Only check the previous autotools arguments for the WebKit project. This prevents build-jsc runs from forcing subsequent build-webkit runs to re-rerun autogen.sh.
- 14:45 Changeset [87956] by
-
2011-06-02 Tony Chang <tony@chromium.org>
[chromium] mark media/audio-delete-while-slider-thumb-clicked.html as passing
https://bugs.webkit.org/show_bug.cgi?id=61967
This test is passing now that we get proper click events on the
slider and we no longer use absolute positions on the slider. The
test was updated in r78562 while it was disabled, so the chromium
results were stale (thus I'm deleting them).
- platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 14:43 Changeset [87955] by
-
2011-06-02 Simon Fraser <simon.fraser@apple.com>
Reviewed by Andreas Kling.
Share Path code that uses beziers to construct a rounded rect
https://bugs.webkit.org/show_bug.cgi?id=61960
Have two methods in Path that construct beziers for rounded
rects to share the same code.
Make gCircleControlPoint a little more precise, and add
a comment describing its derivation.
Make use of FloatRect::maxX() and maxY().
- platform/graphics/Path.cpp: (WebCore::Path::addRoundedRect): (WebCore::Path::addBeziersForRoundedRect):
- platform/graphics/Path.h:
- 14:41 Changeset [87954] by
-
2011-06-02 Stephen White <senorblanco@chromium.org>
Reviewed by Andreas Kling.
Fix layout test compositing/images/direct-svg-image.html.
https://bugs.webkit.org/show_bug.cgi?id=61966
Change this test to get SVG resources from their new, post-r87782
location (svg/as-image).
- compositing/images/direct-svg-image.html:
- 14:36 Changeset [87953] by
-
2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87946.
http://trac.webkit.org/changeset/87946
https://bugs.webkit.org/show_bug.cgi?id=61965
Cause NRWT to break (Requested by abarth|gardener on #webkit).
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 14:35 Changeset [87952] by
-
2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Enrica Casucci.
ApplyStyleCommand shouldn't call collapseTextDecorationProperties
https://bugs.webkit.org/show_bug.cgi?id=61887
Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.
No new tests because this is a code refactoring.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
- editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration and -webkit-text-decorations-in-effect. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment. (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration and -webkit-text-decorations-in-effect. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration is present in -webkit-text-decorations-in-effect or text-decoration preferring the former. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties is false and true. Added a support for -webkit-text-decorations-in-effect.
- 14:29 Changeset [87951] by
-
2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make more functions static local in EventHandlers.cpp
https://bugs.webkit.org/show_bug.cgi?id=58503
Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.
- page/EventHandler.cpp: (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget. (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget. (WebCore::EventHandler::cancelDragAndDrop): Ditto. (WebCore::EventHandler::performDragAndDrop): Ditto. (WebCore::focusDirectionForKey): No longer a member function of EventHandler class. (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls focusDirectionForKey instead of manually comparing.
- page/EventHandler.h:
- 13:37 Changeset [87950] by
-
2011-06-02 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks.
- Source/WebKit.pri:
2011-06-02 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957
When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks.
- JavaScriptCore.pro:
- 13:20 Changeset [87949] by
-
2011-06-02 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
[chromium] Things jump around when selecting anything on the page
https://bugs.webkit.org/show_bug.cgi?id=61639
WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
with the viewport set by skia.
No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
Here is a non-exhaustive list of existing tests covering this case.
Test: editing/selection/14971.html (existing)
editing/selection/3690703-2.html (existing)
editing/selection/4402375.html (existing)
editing/selection/4818145.html (existing)
- platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
- platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
- 13:15 Changeset [87948] by
-
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
- fast/dom/Window/window-properties.html: Ditto.
- fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
- fast/dom/script-tests/prototype-inheritance.js: Ditto.
- fast/harness/internals-object-expected.txt: Added.
- fast/harness/internals-object.html: Added.
- platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
- platform/mac-wk2/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
Test: fast/harness/internals-object.html
- Configurations/WebCoreTestSupport.xcconfig: Added.
- DerivedSources.make: Added support for generating from Internals.idl.
- WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
- testing/Internals.cpp: Added.
- testing/Internals.h: Added.
- testing/Internals.idl: Added.
- testing/js/WebCoreTestSupport.cpp: Added.
- testing/js/WebCoreTestSupport.h: Added.
- testing/v8/WebCoreTestSupport.cpp: Added.
- testing/v8/WebCoreTestSupport.h: Added.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- WebKit.gyp: Added linking new webkit_test_support library.
- public/WebTestingSupport.h: Added.
- src/WebTestingSupport.cpp: Added.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
- 13:01 Changeset [87947] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
More housekeep w.r.t. border-radius-clip.html. These new image results
look correct. The "replaced" version is the one with the failure.
- platform/chromium-linux-x86/fast/overflow/border-radius-clipping-expected.png: Added.
- platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
- platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.png:
- platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Removed.
- platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
- platform/chromium/test_expectations.txt:
- 13:01 Changeset [87946] by
-
2011-06-02 Hao Zheng <zhenghao@chromium.org>
Reviewed by Dirk Pranke.
Call cleanup() explicitly at the end of worker.run().
https://bugs.webkit.org/show_bug.cgi?id=61847
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- 12:59 Changeset [87945] by
-
2011-06-02 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Add quirk for plug-ins that return a retained CALayer
https://bugs.webkit.org/show_bug.cgi?id=61948
<rdar://problem/9530390>
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Set the ReturnsRetainedCoreAnimationLayer quirk for Flash.
- Shared/Plugins/PluginQuirks.h: Add ReturnsRetainedCoreAnimationLayer quirk.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle WKNVExpectsNonretainedLayer by always returning true, and also call NetscapePlugin::setPluginReturnsNonretainedLayer(true) to add a way for plug-ins to opt into returning non-retained layers even if they have the quirk specified.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_pluginReturnsNonretainedLayer to true.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: (WebKit::NetscapePlugin::setPluginReturnsNonretainedLayer): Add setter.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize): If m_pluginReturnsNonretainedLayer is false, adopt the layer.
- 12:58 Changeset [87944] by
-
2011-06-02 Aaron Colwell <acolwell@chromium.org>
Reviewed by David Levin.
Update chromium version
https://bugs.webkit.org/show_bug.cgi?id=61555
- DEPS:
- 12:54 Changeset [87943] by
-
Unreviewed WinCairo build correction.
- UIProcess/win/WebView.cpp: Don't include CG file header
when building without CoreGraphics support.
- 12:45 Changeset [87942] by
-
2011-06-01 Adrienne Walker <enne@google.com>
Reviewed by Eric Seidel.
[chromium] LayerChromium should use a RefPtr for replica layer
https://bugs.webkit.org/show_bug.cgi?id=61898
Having this member variable be a raw pointer is brittle and assumes
that the GraphicsLayer tree keeps this in sync. There aren't any
known bugs caused by this, but it seems like good sense to do this.
- platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::replicaLayer):
- 12:38 Changeset [87941] by
-
Actually make the property change.
- 12:38 Changeset [87940] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
Reviewed by Ryosuke Niwa.
Update svn:ignore property on Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=61952
Add some more generated files and directories mapped in using DEPS to svn:ignore.
- chromium: Modified property svn:ignore.
- 12:27 Changeset [87939] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
First cut at updating test expectations for Win 7.
- platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Removed.
- platform/chromium-win/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
- platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt: Added.
- platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png: Added.
- platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.txt: Added.
- platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:10 Changeset [87938] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
These differ only by the scroll bar.
- platform/chromium-linux-x86/fast/css: Added.
- platform/chromium-linux-x86/fast/css/last-of-type-pseudo-class-expected.png: Added.
- platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
- platform/chromium/test_expectations.txt:
- 12:07 Changeset [87937] by
-
2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: inline style is lost when deleting line break between paragraphs with same style
https://bugs.webkit.org/show_bug.cgi?id=61899
Added a regression test to ensure WebKit preserves font family for a paragraph being merged
to the previous paragraph when deleting a line break between two paragraphs with the same style.
- editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt: Added.
- editing/deleting/delete-line-break-between-paragraphs-with-same-style.html: Added.
2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: inline style is lost when deleting line break between paragraphs with same style
https://bugs.webkit.org/show_bug.cgi?id=61899
The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- 12:05 Changeset [87936] by
-
2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929
The bug was caused by RenderText::positionForPoint's not considering the case where a point is
above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
any point between selectionTop and lineTop to be inside a root inline box. This condition is
consistent with the condition we use to determine the bottom of a line.
Test: editing/selection/hit-test-on-text-with-line-height.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether or not a point is above the first root line box. We need to check both selectionTop and logicalTop for the same reason explained above.
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): See above.
2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Simon Fraser.
REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929
Added a test to ensure WebKit can place caret in text with a line-height smaller than
the height of the text.
- editing/selection/hit-test-on-text-with-line-height-expected.txt: Added.
- editing/selection/hit-test-on-text-with-line-height.html: Added.
- 11:57 Changeset [87935] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
This test actually fails as IMAGE not as IMAGE+TEXT.
- platform/chromium/test_expectations.txt:
- 11:39 Changeset [87934] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
New baselines for these tests. These only differ from the existing baselines by a handful of pixels.
- platform/chromium-linux-x86/fast/borders/border-radius-huge-assert-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusInvalidColor-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png: Added.
- platform/chromium-linux-x86/fast/box-shadow: Added.
- platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
- platform/chromium-linux-x86/fast/overflow: Added.
- platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png: Added.
- platform/chromium-linux-x86/fast/replaced: Added.
- platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
- platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
- platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
- platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
- platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
- platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
- platform/chromium/test_expectations.txt:
- 11:27 Changeset [87933] by
-
2011-06-02 Andreas Kling <kling@webkit.org>
Reviewed by James Robinson.
Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
https://bugs.webkit.org/show_bug.cgi?id=61944
- platform/chromium/test_expectations.txt: Unskip canvas/philip/tests/2d.fillStyle.parse.system.html.
2011-06-02 Andreas Kling <kling@webkit.org>
Reviewed by James Robinson.
Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
https://bugs.webkit.org/show_bug.cgi?id=61944
Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
for string styles. This ensures that system color resolution is performed,
and matches what the JSC bindings do.
Test: canvas/philip/tests/2d.fillStyle.parse.system.html
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter): (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
- 11:08 Changeset [87932] by
-
2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87920.
http://trac.webkit.org/changeset/87920
https://bugs.webkit.org/show_bug.cgi?id=61943
This patch does not build in Win Builder (dbg)(shared)
downstream (Requested by abarth|gardener on #webkit).
- tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): (WebKit::TestPopupMenuClient::valueChanged): (WebKit::TestPopupMenuClient::itemIsEnabled): (WebKit::SelectPopupMenuTest::TearDown):
- tests/data/popup/select_event.html: Removed.
- tests/data/popup/select_event_remove_on_change.html: Removed.
- tests/data/popup/select_event_remove_on_click.html: Removed.
2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r87920.
http://trac.webkit.org/changeset/87920
https://bugs.webkit.org/show_bug.cgi?id=61943
This patch does not build in Win Builder (dbg)(shared)
downstream (Requested by abarth|gardener on #webkit).
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleMouseReleaseEvent): (WebCore::PopupListBox::acceptIndex):
- 11:05 Changeset [87931] by
-
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313
Fails to find WebCoreTestSupport.dylib on bots.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance-2.js:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/harness/internals-object-expected.txt: Removed.
- fast/harness/internals-object.html: Removed.
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313
Fails to find WebCoreTestSupport.dylib on bots.
- Configurations/WebCore.xcconfig:
- Configurations/WebCoreTestSupport.xcconfig: Removed.
- DerivedSources.make:
- WebCore.exp.in:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMWrapper::~JSDOMWrapper):
- bindings/js/JSDOMWrapper.h:
- testing/Internals.cpp: Removed.
- testing/Internals.h: Removed.
- testing/Internals.idl: Removed.
- testing/js/WebCoreTestSupport.cpp: Removed.
- testing/js/WebCoreTestSupport.h: Removed.
- testing/v8/WebCoreTestSupport.cpp: Removed.
- testing/v8/WebCoreTestSupport.h: Removed.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313
Fails to find WebCoreTestSupport.dylib on bots.
- WebKit.gyp:
- public/WebTestingSupport.h: Removed.
- src/WebTestingSupport.cpp: Removed.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313
Fails to find WebCoreTestSupport.dylib on bots.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow):
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
- 11:01 Changeset [87930] by
-
2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement popup menus in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=61854
Move common code into a new class to be used by both WebKit1 and
WebKit2.
- GNUmakefile.list.am: Add new files to compilation.
- platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp. (WebCore::GtkPopupMenu::GtkPopupMenu): (WebCore::GtkPopupMenu::~GtkPopupMenu): (WebCore::GtkPopupMenu::clear): Remove all menu items. (WebCore::GtkPopupMenu::appendSeparator): Add a new separator item to the menu. (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for the given action. (WebCore::GtkPopupMenu::popUp): Show the menu. (WebCore::GtkPopupMenu::popDown): Hide the menu. (WebCore::GtkPopupMenu::menuRemoveItem): (WebCore::GtkPopupMenu::menuPositionFunction): (WebCore::GtkPopupMenu::resetTypeAheadFindState): (WebCore::GtkPopupMenu::typeAheadFind): (WebCore::GtkPopupMenu::selectItemCallback): (WebCore::GtkPopupMenu::keyPressEventCallback):
- platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h. (WebCore::GtkPopupMenu::create): (WebCore::GtkPopupMenu::platformMenu):
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): (WebCore::PopupMenuGtk::~PopupMenuGtk): (WebCore::PopupMenuGtk::show): Use GtkPopupMenu. (WebCore::PopupMenuGtk::hide): Ditto. (WebCore::PopupMenuGtk::menuItemActivated): (WebCore::PopupMenuGtk::menuUnmapped):
- platform/gtk/PopupMenuGtk.h:
2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement popup menus in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=61854
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createPopupMenuProxy): Create a new WebPopupMenuProxy.
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Added. (WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): (WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk): (WebKit::WebPopupMenuProxyGtk::showPopupMenu): (WebKit::WebPopupMenuProxyGtk::hidePopupMenu): (WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): (WebKit::WebPopupMenuProxyGtk::menuItemActivated): (WebKit::WebPopupMenuProxyGtk::menuUnmapped):
- UIProcess/gtk/WebPopupMenuProxyGtk.h: Added. (WebKit::WebPopupMenuProxyGtk::create): (WebKit::WebPopupMenuProxyGtk::setActiveItem):
- 10:50 Changeset [87929] by
-
2011-06-02 Adam Barth <abarth@webkit.org>
More examples of SVG tests timing out in debug with Skia.
- platform/chromium/test_expectations.txt:
- 10:42 Changeset [87928] by
-
2011-06-02 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline tests after r87822
https://bugs.webkit.org/show_bug.cgi?id=60821
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
- 10:40 Changeset [87927] by
-
2011-06-02 Aaron Colwell <acolwell@chromium.org>
Reviewed by Dimitri Glazkov.
Bring gyp_webkit up to date with changes made to
gyp_chromium so chromium_rev can be advanced past
revision 87140.
https://bugs.webkit.org/show_bug.cgi?id=61881
- gyp_webkit:
- 10:30 Changeset [87926] by
-
2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
- fast/dom/Window/window-properties.html: Ditto.
- fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
- fast/dom/script-tests/prototype-inheritance.js: Ditto.
- fast/harness/internals-object-expected.txt: Added.
- fast/harness/internals-object.html: Added.
- platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
- platform/mac-wk2/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
Test: fast/harness/internals-object.html
- Configurations/WebCoreTestSupport.xcconfig: Added.
- DerivedSources.make: Added support for generating from Internals.idl.
- WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
- testing/Internals.cpp: Added.
- testing/Internals.h: Added.
- testing/Internals.idl: Added.
- testing/js/WebCoreTestSupport.cpp: Added.
- testing/js/WebCoreTestSupport.h: Added.
- testing/v8/WebCoreTestSupport.cpp: Added.
- testing/v8/WebCoreTestSupport.h: Added.
2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- WebKit.gyp: Added linking new webkit_test_support library.
- public/WebTestingSupport.h: Added.
- src/WebTestingSupport.cpp: Added.
2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
- 10:16 Changeset [87925] by
-
2011-06-02 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Only load dictionaries if spell check is enabled
https://bugs.webkit.org/show_bug.cgi?id=32879
We don't need to call enchant if enable-spell-checking is false.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false. (webkit_web_view_settings_notify): Ditto.
- 10:04 Changeset [87924] by
-
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
[Win] Start skipping a test that's now using shadowRoot machinery.
- platform/win/Skipped: Skip fast/events/shadow-boundary-crossing.html, since it now uses shadowRoot accessors.
- 10:00 Changeset [87923] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=61938
- platform/chromium/test_expectations.txt:
- 09:50 Changeset [87922] by
-
2011-06-02 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline tests after r87822
https://bugs.webkit.org/show_bug.cgi?id=60821
- platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium/test_expectations.txt:
- 09:48 Changeset [87921] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping another failing test in GTK after r87901.
- platform/gtk/Skipped: Skipped test.
- 09:45 Changeset [87920] by
-
2011-06-02 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Dimitri Glazkov.
[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563
Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView. (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup. (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
2011-06-02 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Dimitri Glazkov.
[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563
- tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node. (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList. (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not. (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item. (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event. (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL. (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call. (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL(). (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests(). (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string. (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
- tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
- tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
- tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
- 09:36 Changeset [87919] by
-
WebKitTestRunner needs an implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194
Add editing/pasteboard/copy-standalone-image-crash.html to the mac-wk2 skipped list to get
the bots green, as it uses eventSender.contextClick().
- platform/mac-wk2/Skipped:
- 09:31 Changeset [87918] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Rebaseline scaling-font-with-geometric-precision and navigator-detached-no-crash.
https://bugs.webkit.org/show_bug.cgi?id=61934
- platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png:
- platform/chromium-mac-leopard/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Added.
- platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 09:24 Changeset [87917] by
-
WebKitTestRunner needs an implementation of setTextDirection.
https://bugs.webkit.org/show_bug.cgi?id=61931
Add fast/html/set-text-direction.html to the mac-wk2 skipped list to get the bots green.
- platform/mac-wk2/Skipped:
- 09:10 Changeset [87916] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skiping flaky test on GTK 32-bit Debug bot.
- platform/gtk/Skipped: Skipped test.
- 09:05 Changeset [87915] by
-
2011-06-02 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Rebaseline tables/mozilla/bugs/bug196870.html test after r73385
https://bugs.webkit.org/show_bug.cgi?id=61781
Rebaseline tables/mozilla/bugs/bug196870.html test after r73385.
See bug #49220
- platform/qt/Skipped:
- platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
- 08:59 Changeset [87914] by
-
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=61892
- fast/events/shadow-boundary-crossing.html: Added a test that uses new shadow DOM testing machinery.
- fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.
2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=61892
In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.
- dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
- 08:48 Changeset [87913] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping failing tests in GTK after r87901.
- platform/gtk/Skipped: Skipped 2 tests.
- 08:46 Changeset [87912] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
Adjust test expectations, rebaseline windows SVG wicd tests.
https://bugs.webkit.org/show_bug.cgi?id=61929
- platform/chromium-win/svg/wicd/rightsizing-grid-expected.png: Added.
- platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt: Added.
- platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png: Added.
- platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 08:32 Changeset [87911] by
-
2011-06-02 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
Fix LevelDBTransaction::clearTree()
https://bugs.webkit.org/show_bug.cgi?id=61917
This was broken in the code I copied it from; we can't delete and walk
the tree at the same time.
No new functionality, no new tests.
- platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::clearTree):
- 07:53 Changeset [87910] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
Rebaseline SVG tests.
https://bugs.webkit.org/show_bug.cgi?id=61927
- platform/chromium-mac-leopard/svg/hixie/intrinsic/001-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/intrinsic/002-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/intrinsic/003-expected.png: Added.
- platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
- platform/chromium-win/svg/hixie/intrinsic/001-expected.png: Added.
- platform/chromium-win/svg/hixie/intrinsic/001-expected.txt: Added.
- platform/chromium-win/svg/hixie/intrinsic/002-expected.png: Added.
- platform/chromium-win/svg/hixie/intrinsic/002-expected.txt: Added.
- platform/chromium-win/svg/hixie/intrinsic/003-expected.png: Added.
- platform/chromium-win/svg/hixie/intrinsic/003-expected.txt: Added.
- platform/chromium-win/svg/in-html/by-reference-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
- 07:44 Changeset [87909] by
-
2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
Adjust efl coding style to more efl directories
https://bugs.webkit.org/show_bug.cgi?id=61903
- Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
- 07:40 Changeset [87908] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped tests crashing on GTK debug bots.
- platform/gtk/Skipped: Skipped 2 more tests crashing on GTK debug bots because of the same reason than before (see WK bug 61924).
- 07:20 Changeset [87907] by
-
2011-06-02 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
LayoutTests/svg/animations/animate-path-nested-transforms.html causes assertion in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=49045
Fix mistake in id part of expected values.
- svg/animations/script-tests/animate-mpath-insert.js: (executeTest):
- svg/animations/script-tests/animate-path-nested-transforms.js: (executeTest):
- 07:12 Changeset [87906] by
-
2011-06-02 Kent Tamura <tkent@chromium.org>
[Chromium] Update spinbutton expectations.
- platform/chromium/test_expectations.txt:
- 07:00 Changeset [87905] by
-
2011-06-02 Andreas Kling <kling@webkit.org>
Rubber-stamped by Simon Hausmann.
Remove Qt's precompiled header hack as it was broken, and was not even
used unless building WebKit inside a Qt tree.
- WebKit_pch.h: Removed.
2011-06-02 Andreas Kling <kling@webkit.org>
Rubber-stamped by Simon Hausmann.
Remove Qt's precompiled header hack as it was broken, and was not even
used unless building WebKit inside a Qt tree.
- WebCore.pri:
- 06:58 Changeset [87904] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped tests crashing on GTK debug bots.
- platform/gtk/Skipped: Skipped 9 more tests crashing on GTK debug bots because of the same reason than before (see WK bug 61924).
- 06:42 Changeset [87903] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped tests crashing on GTK debug bots.
- platform/gtk/Skipped: Skipped 7 tests crashing, apparently all of them crash because of the same reason (see WK bug 61924).
- 05:55 Changeset [87902] by
-
2011-06-02 Andreas Kling <kling@webkit.org>
Unreviewed build fix.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- 05:52 Changeset [87901] by
-
2011-06-02 James Robinson <jamesr@chromium.org>
Reviewed by Brady Eidson.
DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
https://bugs.webkit.org/show_bug.cgi?id=61894
DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
whether to inform the FrameLoader's m_client about this load. Unfortunately, this set holds a reference to the
URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
lots of memory.
This set only has an effect on the Mac port, as the only two ports that implement
FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
can correctly handle receiving multiple callbacks. This patch limits the set to only PLATFORM(MAC) so other
ports do not have to pay this memory cost. It's possible that a better fix exists specifically for the Mac port
implementation, but that would have to determined by someone who works on that port specifically.
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): (WebCore::DocumentLoader::haveToldClientAboutLoad):
- 05:52 Changeset [87900] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=61922
- platform/chromium/test_expectations.txt:
- 05:48 Changeset [87899] by
-
2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement hasWebView() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61905
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::hasWebView): Implement hasWebView() function.
- 05:24 Changeset [87898] by
-
2011-06-02 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] No need to invalidate empty areas in ChromeClientEfl::invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=61902
Just return to reduce unnecessary calls when invalidateContentsAndWindow
received empty area.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::invalidateContentsAndWindow):
- 05:10 Changeset [87897] by
-
2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] Multiple drop events when doing DnD of images.
https://bugs.webkit.org/show_bug.cgi?id=61504
Duplicate entries of the url were getting added into drag data
which is removed. The duplicate entries were causing the same image
url to be copied twice. The code changes now match other webkit ports.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
- 05:00 Changeset [87896] by
-
2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>
Reviewed by Kent Tamura.
Fixing invalid value being returned for default checkbox and radio state
https://bugs.webkit.org/show_bug.cgi?id=61674
As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on"
This works as per spec in IE9,Firefox and Opera
- fast/forms/checkbox-default-value-expected.txt: Added.
- fast/forms/checkbox-default-value.html: Added.
- fast/forms/radio-default-value-expected.txt: Added.
- fast/forms/radio-default-value.html: Added.
2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>
Reviewed by Kent Tamura.
Fixing invalid value being returned for default checkbox and radio state
https://bugs.webkit.org/show_bug.cgi?id=61674
As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on".Changed fallbackValue function to return the same
This works as per spec in IE9,Firefox and Opera
Tests: fast/forms/checkbox-default-value.html
fast/forms/radio-default-value.html
- html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::fallbackValue):
- 04:57 Changeset [87895] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped test timing out for GTK since r87605.
- platform/gtk/Skipped: Skipped test.
- 04:52 Changeset [87894] by
-
Unreviewed: Web Inspector: remove accidental eXecutable flag from certain script files
- 04:35 Changeset [87893] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added missing new baselines for GTK after r87779.
- platform/gtk/svg/hixie/intrinsic/002-expected.png: Added.
- platform/gtk/svg/hixie/intrinsic/002-expected.txt: Added.
- 04:11 Changeset [87892] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, new GTK baselines after r87807, r87829, r87840 and r87846.
- platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
- platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
- platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
- platform/gtk/svg/custom/embedding-external-svgs-expected.png: Added.
- platform/gtk/svg/custom/embedding-external-svgs-expected.txt: Added.
- platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
- platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
- 03:56 Changeset [87891] by
-
[Chromium/Mac] Fix a wrong merge for r87881
https://bugs.webkit.org/show_bug.cgi?id=61845
- platform/chromium/ThemeChromiumMac.mm:
(WebCore::paintStepper):
- 03:49 Changeset [87890] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped SVG tests randomly failing with 16px diff.
- platform/gtk/Skipped: Skipped tests.
- 03:20 Changeset [87889] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Update GTK expectations because the position of steppers are moved.
- platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
- 03:12 Changeset [87888] by
-
2011-06-02 John Knottenbelt <jknotten@chromium.org>
Unreviewed.
[Chromium] Update baselines for Windows 7 platform.
https://bugs.webkit.org/show_bug.cgi?id=61916
- platform/chromium-win/fast/borders/border-antialiasing-expected.png: Added.
- platform/chromium-win/fast/borders/border-antialiasing-expected.txt: Added.
- platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
- platform/chromium-win/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
- platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
- platform/chromium-win/svg/custom/embedding-external-svgs-expected.png: Added.
- platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt: Added.
- platform/chromium-win/svg/custom/invalid-fill-expected.png:
- platform/chromium-win/svg/custom/invalid-fill-expected.txt:
- platform/chromium-win/svg/custom/invalid-fill-hex-expected.png:
- platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
- platform/chromium-win/svg/custom/invalid-stroke-hex-expected.png: Added.
- platform/chromium-win/svg/custom/invalid-stroke-hex-expected.txt: Added.
- platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png: Added.
- platform/chromium-win/svg/custom/invalid-uri-stroke-expected.txt: Added.
- platform/chromium-win/svg/custom/object-no-size-attributes-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/small-rect-scale-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
- platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Added.
- platform/chromium-win/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
- 03:04 Changeset [87887] by
-
2011-06-02 Ian Henderson <ianh@apple.com>
Reviewed by Simon Fraser.
[CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
https://bugs.webkit.org/show_bug.cgi?id=61882
If we have a gradient or pattern fill set, take the slow path, which
handles these cases properly.
No new tests, since we never try to fill a rounded rect with a
gradient or pattern.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
- 02:48 Changeset [87886] by
-
2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipped test with 1px different results in GTK bots.
- platform/gtk/Skipped: Skipped test.
- 02:14 Changeset [87885] by
-
2011-06-02 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=61912
Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
removed original definitions.
No test, no behavioral change.
- dom/Node.cpp:
- dom/Node.h:
- dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
- 01:48 Changeset [87884] by
-
2011-06-02 Piroska András <Piroska.Andras@stud.u-szeged.hu>
Rubber-stamped by Gabor Loki.
Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.
- platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply): Rename variable i to job
- 01:12 Changeset [87883] by
-
2011-06-02 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
https://bugs.webkit.org/show_bug.cgi?id=61841
- http/tests/websocket/tests/bad-handshake-crash-expected.txt: Now the error message starts with a capital letter.
2011-06-02 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
https://bugs.webkit.org/show_bug.cgi?id=61841
There is no change in behavior except that capitalization of a few error messages
has been changed. No new tests are added.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processBuffer): Pass m_handshake.failureReason() to fail() if the handshake has failed.
- websockets/WebSocketHandshake.cpp: Replace occurrences of m_handle->addMessage() with assignments to m_failureReason. Change capitalization of a few messages so that all messages start with a capital letter. (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::failureReason): (WebCore::WebSocketHandshake::readStatusLine): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
- websockets/WebSocketHandshake.h: Add failureReason(), which returns a string that describes why WebSocket handshake has failed.
- 00:21 Changeset [87882] by
-
Incorrect UA style when printing a simple document
https://bugs.webkit.org/show_bug.cgi?id=61900
Reviewed by Anders Carlsson.
This is not testable in run-webkit-tests because unless the test is the first to run in an instance
of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.
- css/CSSStyleSelector.cpp:
(WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
simple default style, with a new RuleSet before adding the style rules from the full default sheet.
(WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
equal in the simple case.
- 00:04 Changeset [87881] by
-
2011-06-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Remove outer-spin-button
https://bugs.webkit.org/show_bug.cgi?id=61845
Update Mac expectations because the position of steppers are moved.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
- platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
- platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png:
- platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png:
- platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
2011-06-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Remove outer-spin-button
https://bugs.webkit.org/show_bug.cgi?id=61845
Remove outer-spin-button, and render steppers as inner-spin-button.
Outer-spin-button have never worked well with padding and border of
<input>, and the layout code is very tricky and very hard to maintain it.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/html.css:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::innerSpinButtonElement):
- html/HTMLInputElement.h:
- html/InputType.h:
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::destroyShadowSubtree):
- html/TextFieldInputType.h:
- html/shadow/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::shadowPseudoId):
- html/shadow/TextControlInnerElements.h:
- platform/ThemeTypes.h:
- platform/chromium/ThemeChromiumMac.mm: (WebCore::paintStepper): Center the stepper drawing area because the specified area can be larger than the NSStepper sizes. (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
- platform/mac/ThemeMac.mm: (WebCore::paintStepper): Center the stepper drawing area because the specified area can be larger than the NSStepper sizes. (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
- rendering/RenderBox.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::textBlockWidth):
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
