Timeline


and

06/07/11:

23:18 Changeset [88329] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Rename HTMLInputElement::m_value to m_valueIfDirty
https://bugs.webkit.org/show_bug.cgi?id=61990

No new tests because no behavior change.

  • html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty. (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::updateValueIfNeeded):
  • html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty. (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
23:16 Changeset [88328] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split 'reset' into 'collect' and 'resetAllocator'
https://bugs.webkit.org/show_bug.cgi?id=62267

  • heap/Heap.cpp: (JSC::Heap::allocate): (JSC::Heap::collectAllGarbage): (JSC::Heap::collect):
  • heap/Heap.h:
  • heap/MarkedBlock.h: (JSC::MarkedBlock::resetAllocator):
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::resetAllocator):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::resetAllocator):
23:13 Changeset [88327] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip new failing tests.

  • platform/qt/Skipped:
23:01 Changeset [88326] by koz@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update more snowleopard baselines after r88321.

  • platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
22:28 Changeset [88325] by koz@chromium.org
  • 5 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update snowleopard baselines after r88321.

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
21:57 Changeset [88324] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-06-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed some more marks to visits
https://bugs.webkit.org/show_bug.cgi?id=62254

  • heap/HandleHeap.cpp: (JSC::HandleHeap::visitStrongHandles): (JSC::HandleHeap::visitWeakHandles):
  • heap/HandleHeap.h:
  • heap/HandleStack.cpp: (JSC::HandleStack::visit):
  • heap/HandleStack.h:
  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • heap/HeapRootVisitor.h: (JSC::HeapRootVisitor::visit):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
20:59 Changeset [88323] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Update expectations for flaky tests.

  • platform/chromium/test_expectations.txt:
20:36 Changeset [88322] by koz@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update expectations for registerProtocolHandler
test.

  • platform/chromium-linux/fast/dom/register-protocol-handler-expected.txt: Added.
20:31 Changeset [88321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Ian Henderson <ianh@apple.com>

Reviewed by Dan Bernstein.

(CG) Sub-image drawing clips unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=62258

If destRect completely encompasses the adjustedDestRect into which we
draw, clipping to destRect will do nothing. Skip the call to
CGContextClipToRect in this case.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
20:22 Changeset [88320] by koz@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Disable SelectItemEvenFire that fails on
chromium canaries.

  • tests/PopupMenuTest.cpp: (WebKit::TEST_F):
20:12 Changeset [88319] by eae@chromium.org
  • 47 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert nodeAtPoint to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62145

Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
accumulated offset.

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::moveBy): Add moveBy(IntPoint) method
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
19:44 Changeset [88318] by yi.4.shen@nokia.com
  • 4 edits in trunk

2011-06-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901

Unskip the tests which are now passing.

  • platform/qt/Skipped:

2011-06-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901

To indicate the media resource failures, set the network state to
MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
QMediaPlayer::ResourceError.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):
19:32 Changeset [88317] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestFloats to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62176

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBlock.h:
19:27 WebKit Team edited by eae@chromium.org
(diff)
19:14 Changeset [88316] by commit-queue@webkit.org
  • 8 edits in trunk

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • PluginProcess/mac/PluginProcessShim.mm:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • WebKitSystemInterface.h:
19:09 Changeset [88315] by barraclough@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=55537
Functions claim to have 'callee' which they actually don't (and shouldn't)

Source/JavaScriptCore:

Reviewed by Sam Weinig

(JSC::JSFunction::getOwnPropertyNames):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
19:06 Changeset [88314] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

19:00 Changeset [88313] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-07 Juan C. Montemayor <jmont@apple.com>

Reviewed by Darin Adler.

Make JSStaticFunction and JSStaticValue less "const"
https://bugs.webkit.org/show_bug.cgi?id=62222

  • API/JSObjectRef.h:
  • API/tests/testapi.c: (checkConstnessInJSObjectNames): (main):
  • JavaScriptCore.xcodeproj/project.pbxproj:
18:59 Changeset [88312] by lforschler@apple.com
  • 1 copy in tags/Safari-534.44

New tag.

18:46 Changeset [88311] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestColumns to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62172

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBlock.h:
18:37 Changeset [88310] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
https://bugs.webkit.org/show_bug.cgi?id=62178

Added commandComplete and evaluateCommand for NewRunWebKitTests class
to parse new-run-webkit-tests' results.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
18:37 Changeset [88309] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update expectations for tests that are timing out.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [88308] by simon.fraser@apple.com
  • 8 edits
    2 adds in trunk

2011-06-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Opacity transition doesn't work while content property is set.
https://bugs.webkit.org/show_bug.cgi?id=59301

StyleRareNonInheritedData's copy constructor omitted to copy
the m_content data, which caused us to detach and re-attach the renderer
at the start of the transition, thereby killing the transition.

Fix by making StyleRareNonInheritedData's copy ctor do the right thing.

Test: transitions/transition-on-element-with-content.html

  • rendering/style/ContentData.h:
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy ctor because of the subclasses.)
  • rendering/style/CounterDirectives.h: Pack the data members to save space. Add a clone() function for the HashMap.
  • rendering/style/CounterDirectives.cpp: (WebCore::clone): Make a new HashMap and copy the contents over.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy the content and counter directives over. (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing for pointer equality, do a correct check for m_counterDirectives equality. (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
  • rendering/style/StyleRareNonInheritedData.h:
18:18 Changeset [88307] by commit-queue@webkit.org
  • 10 edits
    10 adds in trunk

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Shows that the basic Chromium gesture manager can correctly convert a touch
event sequence into a sequence of synthetic mouse events for clicking and
scrolling.

  • fast/events/touch/touch-gesture-click-expected.txt: Added.
  • fast/events/touch/touch-gesture-click.html: Added.
  • fast/events/touch/touch-gesture-scroll-expected.txt: Added.
  • fast/events/touch/touch-gesture-scroll.html: Added.
  • platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Added.

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Adds a basic gesture recognizer to the Chromium platform. Adds an entry
point to the GestureRecognizer to reset any internal state on a page reset.
Resetting the gesture recognizer on page load is necesary for reliable
layout test execution and improves gesture recognizer operational
robustness.

Added an additional constructor to permit building a synthetic
PlatformWheelEvent.

Small modifications to the PlatformGestureRecognizer as required to
implement the simple Chromium platform gesture recognizer.

Tests: fast/events/touch/touch-gesture-click.html

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::resetGestureRecognizer):
  • page/EventHandler.h:
  • page/FrameView.cpp: (WebCore::FrameView::reset):
  • platform/PlatformGestureRecognizer.h:
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/chromium/GestureRecognizerChromium.cpp: Added. (WebCore::InnerGestureRecognizer::InnerGestureRecognizer): (WebCore::InnerGestureRecognizer::reset): (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer): (WebCore::InnerGestureRecognizer::addEdgeFunction): (WebCore::InnerGestureRecognizer::isInClickTimeWindow): (WebCore::InnerGestureRecognizer::isInsideManhattanSquare): (WebCore::InnerGestureRecognizer::dispatchSyntheticClick): (WebCore::InnerGestureRecognizer::processTouchEventForGesture): (WebCore::InnerGestureRecognizer::scrollViaTouchMotion): (WebCore::InnerGestureRecognizer::updateValues): (WebCore::InnerGestureRecognizer::signature): (WebCore::touchDown): (WebCore::noGesture): (WebCore::click): (WebCore::isClickOrScroll): (WebCore::inScroll): (WebCore::PlatformGestureRecognizer::create): (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::GestureRecognizerChromium::GestureRecognizerChromium): (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
  • platform/chromium/GestureRecognizerChromium.h: Added. (WebCore::InnerGestureRecognizer::setState): (WebCore::InnerGestureRecognizer::state): (WebCore::GestureRecognizerChromium::reset): (WebCore::GestureRecognizerChromium::processTouchEventForGesture):

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Added unit tests for the basic chromium platform gesture recognizer.

  • tests/InnerGestureRecognizerTest.cpp: Added. (WebCore::InspectableInnerGestureRecognizer::InspectableInnerGestureRecognizer): (WebCore::InspectableInnerGestureRecognizer::signature): (WebCore::InspectableInnerGestureRecognizer::firstTouchPosition): (WebCore::InspectableInnerGestureRecognizer::setFirstTouchTime): (WebCore::InspectableInnerGestureRecognizer::firstTouchTime): (WebCore::InspectableInnerGestureRecognizer::setLastTouchTime): (WebCore::InspectableInnerGestureRecognizer::lastTouchTime): (WebCore::InspectableInnerGestureRecognizer::edgeFunction): (WebCore::InspectableInnerGestureRecognizer::updateValues): (WebCore::InspectableInnerGestureRecognizer::addEdgeFunction): (WebCore::BuildablePlatformTouchPoint::setX): (WebCore::BuildablePlatformTouchPoint::setY): (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint): (WebCore::TestGestureRecognizer::TestGestureRecognizer): (WebCore::TestGestureRecognizer::SetUp): (WebCore::TestGestureRecognizer::TearDown): (WebCore::TEST_F):
18:12 Changeset [88306] by koz@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Fix expectations for registerProtocolHandler tests.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:57 Changeset [88305] by lforschler@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r88261.

17:57 Changeset [88304] by noam.rosenthal@nokia.com
  • 7 edits in trunk/Source

2011-06-07 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.

No new functionality so no new tests.

  • WebCore.pri:
  • WebCore.pro:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapper::create):

2011-06-07 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
17:53 Changeset [88303] by lforschler@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r88269.

17:52 Changeset [88302] by lforschler@apple.com
  • 27 edits in branches/safari-534-branch/Source

Merge r88260.

17:50 Changeset [88301] by tkent@chromium.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-06-07 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Convert fast/forms/thumbslider-crash.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=62195

  • fast/forms/thumbslider-crash-expected.txt: Added.
  • fast/forms/thumbslider-crash.html:
  • platform/chromium-linux/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/gtk/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/qt/fast/forms/thumbslider-crash-expected.txt: Removed.
17:48 Changeset [88300] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88204.

17:46 Changeset [88299] by lforschler@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebKit2

Merge r88127.

17:42 Changeset [88298] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62248>
<rdar://problem/9568516>
WKResponderChainSink mechanism isn't robust against some types of responder chain manipulation

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKResponderChainSink detach]):
This method formerly blindly assumed that since -initWithResponderChain: put self at the
end of the responder chain, after _lastResponderInChain, then self is still at the end
of the responder chain and still immediately after _lastResponderInChain. Made this function
robust against some kinds of responder chain manipulations, though it can't be robust against
some other kinds (e.g., manipulations that removed self from this chain and put it into some
other chain).

17:30 Changeset [88297] by eae@chromium.org
  • 19 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Covered by existing tests.

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/InlineBox.h: (WebCore::InlineBox::size):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects):
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects):
  • rendering/svg/RenderSVGModelObject.h:
17:27 Changeset [88296] by simonjam@chromium.org
  • 22 edits
    1 move
    17 adds
    2 deletes in trunk/LayoutTests

2011-06-07 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline leopard and win7 tests due to:

  • r87955.
  • New fast/forms/select-baseline.html.
  • New fullscreen/full-screen-zIndex-after.html
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-mac-leopard/fast/borders/different-color-borders-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/selectlist-minsize-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-separator-painting-expected.png.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/carto.net/button-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/http/tests/appcache/manifest-redirect-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/resource-redirect-2-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/resource-redirect-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-content-type-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-signature-2-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-signature-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.txt: Added.
17:26 Changeset [88295] by lforschler@apple.com
  • 9 edits
    2 copies in branches/safari-534-branch/Source

Merge r88123.

17:26 Changeset [88294] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Kent Tamura <tkent@chromium.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
https://bugs.webkit.org/show_bug.cgi?id=62207

  • css/mediaControlsQt.css: Add comments. (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider):
  • platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent(). (WebCore::RenderThemeQt::adjustSliderThumbSize):
17:21 Changeset [88293] by lforschler@apple.com
  • 10 edits in branches/safari-534-branch/Source

Merge r88121.

17:19 Changeset [88292] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r88104.

17:16 Changeset [88291] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88080.

17:15 Changeset [88290] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88075.

17:02 Changeset [88289] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88048.

16:59 Changeset [88288] by vangelis@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):
16:58 Changeset [88287] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

webkitpy: add a popen() call to executive
https://bugs.webkit.org/show_bug.cgi?id=62179

This change adds a popen() wrapper call to the Executive object.
This will allow other webkitpy scripts that currently call
subprocess directly to use Executive, instead.

No additional tests are necessary (the existing tests cover the code).

  • Scripts/webkitpy/common/system/executive.py:
16:57 Changeset [88286] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

2011-06-07 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
  • WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
  • platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
16:56 Changeset [88285] by lforschler@apple.com
  • 11 edits
    2 copies in branches/safari-534-branch

Merge r88034.

16:38 Changeset [88284] by weinig@apple.com
  • 20 edits in trunk

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebCore.xcodeproj/project.pbxproj: Make RenderArena.h private so it can be called from WebKit2.
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidLayout): Added.
  • page/ChromeClient.h: Remove setRenderTreeSize.
  • page/FrameView.cpp: (WebCore::FrameView::performPostLayoutTasks): Call dispatchDidLayout for all frames instead of calling setRenderTreeSize for the main frame.

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didLayoutForFrame callback.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetRenderTreeSize):
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Add render tree size getter in WebProcess.
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h: Removed setRenderTreeSize.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidLayout):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Call the new didLayoutForFrame client function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::renderTreeSize):
  • WebProcess/WebPage/WebPage.h: Add iterative implementation to compute the total size of the render tree for a page.

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add stub for didLayoutForFrame.
16:25 Changeset [88283] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534-branch

Merge r87959.

16:24 Changeset [88282] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestContents to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62170

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
16:21 Changeset [88281] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
https://bugs.webkit.org/show_bug.cgi?id=62241

  • Scripts/webkitpy/layout_tests/port/chromium.py:
16:03 Changeset [88280] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62240
DFG JIT - add support for for-loop array initialization.

Reviewed by Sam Weinig.

Support put by val beyond vector length.
Add a operationPutByValBeyondArrayBounds operation, make
PutValVal call this if the vector length check fails.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::isDoubleConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isJSConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isIntegerConstant):
(JSC::DFG::JITCodeGenerator::valueOfIntegerConstant):

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
16:02 Changeset [88279] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-07 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Video with poster attribute will not display new frames when scrubbing.
https://bugs.webkit.org/show_bug.cgi?id=62036

Remove our "detection" about the end of a scrub now that there is an explicit seek completion
handler available in AVFoundation. Move what we used to do upon detection in timeChanged()
into seekCompleted().

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
15:51 Changeset [88278] by simonjam@chromium.org
  • 1 edit
    4 adds in trunk/Source/WebCore

2011-06-07 James Simonsen <simonjam@chromium.org>

Unreviewed, build fix, missing files from r88274.

  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getCurrent): (WebCore::MainThreadDOMData::getMainThreadStore): (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
  • bindings/v8/MainThreadDOMData.h: Added. (WebCore::MainThreadDOMData::getStore):
15:45 Changeset [88277] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Replicate WidthIterator.cpp fix from r88139.
https://bugs.webkit.org/show_bug.cgi?id=62238

No new tests. Covered by existing layout tests on XP debug bots.

  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::advance):
15:41 Changeset [88276] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Gtk rebaseline after r88266.

  • platform/gtk/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:37 Changeset [88275] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Qt rebaseline after r88266.

  • platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:33 Changeset [88274] by simonjam@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-06-07 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline after r88266.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:25 Changeset [88273] by simonjam@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88221, r88224, and r88231.
http://trac.webkit.org/changeset/88221
http://trac.webkit.org/changeset/88224
http://trac.webkit.org/changeset/88231
https://bugs.webkit.org/show_bug.cgi?id=62233

assert failure on chromium linux debug (Requested by simonjam
on #webkit).

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent):
  • bindings/v8/DOMData.h: (WebCore::DOMData::owningThread): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getCurrent): (WebCore::MainThreadDOMData::getMainThreadStore): (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
  • bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::removeAllDOMObjectsInCurrentThread): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
15:24 Changeset [88272] by alokp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 88258 - 2011-06-07 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

[chromium] PlatformContextSkia leaks SkDeviceFactory
https://bugs.webkit.org/show_bug.cgi?id=62163

Valgrind tests should have caught this.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/7119002

15:17 Changeset [88271] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88254, r88262, and r88268.
http://trac.webkit.org/changeset/88254
http://trac.webkit.org/changeset/88262
http://trac.webkit.org/changeset/88268
https://bugs.webkit.org/show_bug.cgi?id=62234

I fail at changing features.gypi (Requested by abarth on
#webkit).

  • features.gypi:
15:14 Changeset [88270] by simon.fraser@apple.com
  • 14 edits in trunk/Source/WebCore

2011-06-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=62185

ContentData did manual ref()/deref() and had a lot of awkward
code from using a union to store data.

Clean this up by adding ContentData subclasses for different
content types, which are then able to use RefPtr and OwnPtr
as appropriate.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::contentToCSSValue): Cast to different ContentData types as appropriate.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some const gyrations.
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::createRenderer): Use hasContent().
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::createRenderer): Ditto
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer): Ditto
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Cast to ImageContentData.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as appropriate.
  • rendering/style/ContentData.h: (WebCore::ContentData::~ContentData): (WebCore::ContentData::isCounter): (WebCore::ContentData::isImage): (WebCore::ContentData::isQuote): (WebCore::ContentData::isText): (WebCore::ContentData::next): (WebCore::ContentData::setNext): (WebCore::ImageContentData::image): (WebCore::ImageContentData::setImage): (WebCore::ImageContentData::ImageContentData): (WebCore::ImageContentData::type): (WebCore::ImageContentData::isImage): (WebCore::TextContentData::text): (WebCore::TextContentData::setText): (WebCore::TextContentData::TextContentData): (WebCore::TextContentData::type): (WebCore::TextContentData::isText): (WebCore::CounterContentData::counter): (WebCore::CounterContentData::setCounter): (WebCore::CounterContentData::CounterContentData): (WebCore::CounterContentData::type): (WebCore::CounterContentData::isCounter): (WebCore::QuoteContentData::quote): (WebCore::QuoteContentData::setQuote): (WebCore::QuoteContentData::QuoteContentData): (WebCore::QuoteContentData::type): (WebCore::QuoteContentData::isQuote): Add subclasses for different content types, which are created via overloaded create() methods on the base class.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::create): (WebCore::operator==): Test for type equality, followed by comparing data. (WebCore::operator!=):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::clearContent): (WebCore::RenderStyle::appendContent): (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent() code with code that either appends, or replaces the content. This loses an optimization where the existing ContentData object could get reused, but this seems to be rarely hit in practice.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasContent): Convenience method.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test that the pointers are non-null, then use the != operator.
  • rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
15:01 Changeset [88269] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix after r88260.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.

  • platform/graphics/wince/FontCacheWinCE.cpp:
14:31 Changeset [88268] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Fix "branding" issue in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=62229

Apparently we need to move the conditional block further out of the
nesting in order to see the branding variable. This patch also remove
the dummy branding variable I added to get the buildbot building again.

  • features.gypi:
14:21 Changeset [88267] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-06-07 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

TiledDrawingArea: Delay serving tile requests when the drawing area is suspended.

Do not paint tiles when painting is disabled (suspended) on the web process side.
Buffer up the tile requests and paint them, when the drawing area gets resumed.
On the UI process side, do not block on tile updates, when the tiled area is
not visible (painting is disabled on the web process side).

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::scheduleTileUpdate): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h:
14:15 Changeset [88266] by rwlbuis@webkit.org
  • 5 edits
    6 adds in trunk

2011-06-07 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

stroke-dasharray does not handle "none"
https://bugs.webkit.org/show_bug.cgi?id=62203

Test stroke-dasharray=none as well as invalid syntaxes.

  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
  • platform/mac/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/mac/svg/custom/invalid-dasharray-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f.svg: Added.
  • svg/custom/invalid-dasharray.svg: Added.

2011-06-07 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

stroke-dasharray does not handle "none"
https://bugs.webkit.org/show_bug.cgi?id=62203

Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.

Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg

svg/custom/invalid-dasharray.svg

  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
14:10 Changeset [88265] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88259 and r88263.
http://trac.webkit.org/changeset/88259
http://trac.webkit.org/changeset/88263
https://bugs.webkit.org/show_bug.cgi?id=62228

broke builds (Requested by rniwa on #webkit).

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88259 and r88263.
http://trac.webkit.org/changeset/88259
http://trac.webkit.org/changeset/88263
https://bugs.webkit.org/show_bug.cgi?id=62228

broke builds (Requested by rniwa on #webkit).

  • PluginProcess/mac/PluginProcessShim.mm:
14:06 Changeset [88264] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch ContainerNode to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61893

Covered by existing tests.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): (WebCore::ContainerNode::getRect): Change to use maxX/maxY instead of x+width/y+height
  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): (WebCore::FloatPoint::moveBy): (WebCore::FloatPoint::expandedTo): Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
13:59 Changeset [88263] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Speculative build fix after r88259.

  • platform/network/cf/ResourceRequest.h:
13:51 Changeset [88262] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Attempt to fix the cr-win build.

  • features.gypi:
13:49 Changeset [88261] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-07 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Need to enable font cache purging in MemoryPressureHandler
https://bugs.webkit.org/show_bug.cgi?id=62060

Improve memory usage under pressure.
Added call to fontCache()->purgeInactiveFontData() in
MemoryPressureHandler::respondToMemoryPressure(). Added protection to
MemoryPressureHandler::install() being called multiple times.

No new tests as funtionality wasn't changed.

  • platform/MemoryPressureHandler.cpp: (WebCore::MemoryPressureHandler::MemoryPressureHandler):
  • platform/MemoryPressureHandler.h:
  • platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
13:46 Changeset [88260] by msaboff@apple.com
  • 27 edits in trunk/Source

2011-06-06 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

See more comments for this defect in Source/WebCore/ChangeLog.

  • WebKitGraphics.cpp: (CenterTruncateStringToWidth): (RightTruncateStringToWidth): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.

2011-06-06 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

See more comments for this defect in Source/WebCore/ChangeLog.

  • Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • Misc/WebStringTruncator.mm: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.

2011-06-07 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

Most accesses to the font cache still use the reference counting
implemented by FontCache::getCacheFontData() and
FontCache::releaseFontData() and that operation is not affected by
this change.

Added local scoped instance of FontCachePurgePreventer to wrap code
that directly or indirectly accesses fonts via getFontDataForCharacters.
Did a few other miscellaneous bug fixes and changes to allow system
fallback fonts to be pruned from the GlyphPageTree. Changed the
calls to getFontData in the platform specific versions of
Fontcache::getFontDataForCharacters to not increment the reference
count. Moved the purge font check
outside of FontCache::getCachedFontData() into a separate method,
purgeInactiveFontDataIfNeeded() since almost all calls to
getCachedFontData() now happen when purging is not allowed.
purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
m_purgePreventCount is 0.

No new test as the functionality has not changed. Improved font life
cycle management.

  • WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::measureText): (WebCore::CanvasRenderingContext2D::drawTextInternal): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::FontCache): (WebCore::FontCache::getCachedFontData): Moved purge check to new method since it likely can't happen here. (WebCore::FontCache::releaseFontData): (WebCore::FontCache::purgeInactiveFontDataIfNeeded): (WebCore::FontCache::purgeInactiveFontData): Made purging conditional on m_purgePreventCount. Now some fonts in the cache are reference counted while other can be purged outside of code wrapped by in scope FontCachePurgePreventer objects.
  • platform/graphics/FontCache.h: (WebCore::FontCache::disablePurging): (WebCore::FontCache::enablePurging): (WebCore::FontCachePurgePreventer::FontCachePurgePreventer): (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer): Added new simple purge prevention wrapper class and methods that it calls in FontCache actually prevent purging. The simple methods inlined to reduce overhead.
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Update level in glyph page tree for system fallback fonts so pruning works.
  • platform/graphics/GlyphPage.h: (WebCore::GlyphPage::clearForFontData): New method used for pruning
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::pruneFontData): Now we prune system fallback fonts.
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/haiku/FontCacheHaiku.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters): Changed the calls to getFontData() to not increment the reference count. The caller of this getFontDataForCharacters() (currently only Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers don't attempt to release the returned fonts so we use the purge protection described above.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in this method.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRectForTextFragment): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in this method.
13:37 Changeset [88259] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • PluginProcess/mac/PluginProcessShim.mm:
13:28 Changeset [88258] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

[chromium] PlatformContextSkia leaks SkDeviceFactory
https://bugs.webkit.org/show_bug.cgi?id=62163

Valgrind tests should have caught this.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
13:23 Changeset [88257] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Enable tests on the mac-ews

When we bring the mac-ews back up, we're going to try running tests!

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:55 Changeset [88256] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-07 Dmitry Lomov <dslomov@google.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=62215
Allow comparisons with 0 in LIKELY and UNLIKELY macros.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:21 Changeset [88255] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skip test crashing in GTK bots because of an ASSERT.

Actually, it's the same problem observed before (see bug 61937).

  • platform/gtk/Skipped: Skipped test.
12:18 Changeset [88254] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
https://bugs.webkit.org/show_bug.cgi?id=62135

After this patch is rolled into Chromium, we should be able to delete
features_override.gyp downstream. Once we do that, we can simplify
this file somewhat by removing at least on level of nesting.

  • features.gypi:
12:17 Changeset [88253] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-07 Aravind Akella <aravind.akella@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] API test failure qdeclarativewebview
https://bugs.webkit.org/show_bug.cgi?id=59481

QML files cannot be loaded on Symbian due to difference
in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
missing is observed when dynamically loading the QML plugin.

  • declarative/declarative.pro: Match capabilities in QtWebKit.pro.
  • symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs. Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL, and causes build warnings about undefined VENDOR_VID.
  • tests/tests.pri: Add WriteDeviceData capability for API tests.
12:09 Changeset [88252] by thakis@chromium.org
  • 7 edits
    2 deletes in branches/chromium/782

Revert 84329 - 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test case by Bijan Amirzada <bijana@codeaurora.org>.

  • fast/dom/HTMLLinkElement/disabled-attribute-expected.txt: Added.
  • fast/dom/HTMLLinkElement/disabled-attribute.html: Added. Test that the properties are properly forwarded to the stylesheet.
  • fast/dom/boolean-attribute-reflection-expected.txt:
  • fast/dom/script-tests/boolean-attribute-reflection.js: Removed link:disabled as it is not reflected anymore.

2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test: fast/html/htmllink-disable.html
Test: fast/dom/HTMLLinkElement/disabled-attribute.html

Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.

Based on previous work by Bijan Amirzada <bijana@codeaurora.org>.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or false if we don't have a stylesheet. (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or ignore the call if we don't have a stylesheet.
  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5. This matches the way FF4, Opera and IE9 handle the attribute.

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7046023

11:58 Changeset [88251] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderTextControl::hitInnerTextElement to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62167

Covered by existing tests.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
11:56 Changeset [88250] by leviw@chromium.org
  • 74 edits in trunk/Source/WebCore

2011-06-07 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62177

Flipping the switch on the remaining paint functions to have them all
use IntPoint for the paint offset instead of tx/ty.

No new tests since this is just refactoring.

  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paint):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintCell):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::paint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::paint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::paint):
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::paint):
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
11:29 Changeset [88249] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[Chromium] REGRESSION fast/events/onload-after-document-close-with-subresource.html
https://bugs.webkit.org/show_bug.cgi?id=61921

Force a non-cached load of onload-image.png.

  • fast/events/onload-after-document-close-with-subresource.html:
  • platform/chromium/test_expectations.txt:
10:41 Changeset [88248] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Test expectations fix.

[chromium] Fixing test expectations error for chromium-gpu.

  • platform/chromium/test_expectations.txt:
09:58 Changeset [88247] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-07 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is not paused properly.
https://bugs.webkit.org/show_bug.cgi?id=61446

The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.

  • animations/play-state-paused-expected.png: Added.
  • animations/play-state-paused-expected.txt: Added.
  • animations/play-state-paused.html: Added.

2011-06-07 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is not paused properly.
https://bugs.webkit.org/show_bug.cgi?id=61446

The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.

Test: animations/play-state-paused.html

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncCompositingStateSelf): (WebCore::TextureMapperNode::hasOpacityAnimation): (WebCore::TextureMapperNode::hasTransformAnimation):
  • platform/graphics/texmap/TextureMapperNode.h:
09:48 Changeset [88246] by thakis@chromium.org
  • 6 edits in trunk/Tools

2011-06-07 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=62210

The change to TestEventPrinter fixes a latent bug, because
objects are deleted through the TestEventPrinter type, but none
of the subclasses have destructors or non-POD members.

The changes to NotificationPresenter and WebViewHost do _not_ to fix a
real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
discussed at http://codereview.chromium.org/7094005/, we prefer making
leaf class destructors virtual over making the leaf classes final.

  • DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::~NotificationPresenter):
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestEventPrinter::~TestEventPrinter):
  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/WebViewHost.h:
09:40 Changeset [88245] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-07 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Remove Ecore_X bits from PlatformScreenEfl
https://bugs.webkit.org/show_bug.cgi?id=61649

Remove the need for Ecore_X and some X calls by always using
new functions available in EFL to get the screen size.

  • Source/cmake/FindEFL.cmake: Bump ecore and ecore-evas versions.

2011-06-07 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Remove Ecore_X bits from PlatformScreenEfl
https://bugs.webkit.org/show_bug.cgi?id=61649

Remove the need for Ecore_X and some X calls by always using
new functions available in EFL to get the screen size.

No new tests since the same functionality are done inside EFL now.

  • platform/efl/PlatformScreenEfl.cpp: (WebCore::screenRect):
09:38 WebKit Team edited by takano.naoki@gmail.com
(diff)
09:35 Changeset [88244] by carlosgc@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
https://bugs.webkit.org/show_bug.cgi?id=62200

In WebKit2 PluginPackage is used by the UI process to load plugins
in order to get information about them, but it doesn't use any GTK
symbol. So the UI process should be able to load plugins even when
building with GTK3, but we should not allow the plugin view to use
the plugin if it mixes GTK2 and GTK3 symbols.

  • plugins/PluginPackage.h: (WebCore::PluginPackage::module): New method to return the platform module.
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): Check whether plugin was successfully loaded before trying to create the drawable. (WebCore::PluginView::paint): Return early if plugin didn't start or was not successfully loaded. (WebCore::PluginView::handleKeyboardEvent): Ditto. (WebCore::PluginView::handleMouseEvent): Ditto. (WebCore::PluginView::handleFocusInEvent): Ditto. (WebCore::PluginView::handleFocusOutEvent): Ditto. (WebCore::moduleMixesGtkSymbols): (WebCore::PluginView::platformStart): Check whether module is mixing GTK+ 2 and GTK+ 3 symbols.

2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
https://bugs.webkit.org/show_bug.cgi?id=62200

In WebKit2 PluginPackage is used by the UI process to load plugins
in order to get information about them, but it doesn't use any GTK
symbol. So the UI process should be able to load plugins even when
building with GTK3, but we should not allow the plugin view to use
the plugin if it mixes GTK2 and GTK3 symbols.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::moduleMixesGtkSymbols): (WebKit::NetscapePlugin::platformPostInitialize): Check whether the module is mixing GTK+ 2 and GTK+ 3 symbols.
09:33 Changeset [88243] by commit-queue@webkit.org
  • 18 edits in trunk

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88238.
http://trac.webkit.org/changeset/88238
https://bugs.webkit.org/show_bug.cgi?id=62216

Broke a couple of inspector tests (Requested by apavlov on
#webkit).

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88238.
http://trac.webkit.org/changeset/88238
https://bugs.webkit.org/show_bug.cgi?id=62216

Broke a couple of inspector tests (Requested by apavlov on
#webkit).

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
09:20 Changeset [88242] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-07 Dinu Jacob <dinu.jacob@nokia.com>

Reviewed by Dimitri Glazkov.

Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
https://bugs.webkit.org/show_bug.cgi?id=61543

Inform chrome client that touch events are not needed by the webpage
when navigating away from the page only once to avoid the flag being
overwritten later if a page is removed from the page cache

  • dom/Document.cpp: (WebCore::Document::detach):
  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
08:54 Changeset [88241] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-07 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove JSC dependency from WebKit/efl
https://bugs.webkit.org/show_bug.cgi?id=62173

Change JSC::initializeThreading() and WTF::initializeMainThread() to
WebCore::ScriptController::initializeThreading() which contains these
functions and remove JSC dependency to build webkit/efl with v8.

  • ewk/ewk_main.cpp: (_ewk_init_body):
08:33 Changeset [88240] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] "webkithittestresult.h" is malformed
https://bugs.webkit.org/show_bug.cgi?id=62117

  • webkit/webkithittestresult.h: fix typo in GET_CLASS macro.
08:33 Changeset [88239] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.4.1

Tagging the WebKitGTK+ 1.4.1 release.

08:31 Changeset [88238] by apavlov@chromium.org
  • 18 edits in trunk

2011-06-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend immediately.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
08:19 Changeset [88237] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove duplicate breakpoints from localStorage
https://bugs.webkit.org/show_bug.cgi?id=62206

Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
case when settings version is less than 1.

08:15 Changeset [88236] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Unreviewed. Skip failing tests because of unimplemented features.

  • platform/mac-wk2/Skipped:
07:27 Changeset [88235] by yurys@chromium.org
  • 5 edits in trunk/Source

2011-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
https://bugs.webkit.org/show_bug.cgi?id=62019

Dispatch disconnecFrontend message in debugger task mode to make sure
it is processed even if execution is paused.

  • bindings/v8/WorkerScriptDebugServer.cpp: (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/WorkerScriptDebugServer.h:

2011-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
https://bugs.webkit.org/show_bug.cgi?id=62019

Dispatch disconnecFrontend message in debugger task mode to make sure
it is processed even if execution is paused.

  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::detachDevTools): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
06:31 Changeset [88234] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-07 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation beginElement() does not restart the animation after endElement().
https://bugs.webkit.org/show_bug.cgi?id=43452

Added test for animation beginElement. It should restart the animation even if the animation is stopped by endElement() previously.

  • svg/animations/animate-endElement-beginElement-expected.txt: Added.
  • svg/animations/animate-endElement-beginElement.html: Added.
  • svg/animations/script-tests/animate-endElement-beginElement.js: Added.

2011-06-07 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation beginElement() does not restart the animation after endElement().
https://bugs.webkit.org/show_bug.cgi?id=43452

Test: svg/animations/animate-endElement-beginElement.html

Calling beginElement() after calling endElement() previously does not restarted the animation when animation
element's end attribute doesn't contains a bigger value than the current animation time.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::findInstanceTime):
06:22 Changeset [88233] by andreas.kling@nokia.com
  • 2 edits in trunk

2011-06-07 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix Symbian build with RVCT 2.x
https://bugs.webkit.org/show_bug.cgi?id=62205

RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
option, so restrict it to version 4.x of the compiler.

  • Source/WebKit.pri:
02:44 Changeset [88232] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk/Source

2011-06-07 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView. (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup. (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.

2011-06-07 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node. (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList. (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not. (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item. (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event. (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL. (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call. (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL(). (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests(). (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string. (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
  • tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
  • tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
  • tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
  • WebKit.gyp: Added PopupMenuTest.cpp. Because webkit_support dependency is added, we can't build PopupMenuTest.cpp with Chromium-win (shared) configuration.
02:39 Changeset [88231] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Andras Becsi <abecsi@webkit.org>

Reviewed by Yury Semikhatsky.

REGRESSION(r88221): "Chromium debug compilation broken".
https://bugs.webkit.org/show_bug.cgi?id=62197

No new tests needed.

  • bindings/v8/V8GCController.cpp: Also rename call-sites. (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
02:23 Changeset [88230] by tonyg@chromium.org
  • 12 edits in branches/chromium/782

Merge 88174 - 2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
  • page/PageVisibilityState.h:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • public/WebPageVisibilityState.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):

BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7121007

01:55 Changeset [88229] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed Skipped entry addition following r88225.

  • platform/win/Skipped:
01:41 Changeset [88228] by morrita@google.com
  • 4 edits
    14 deletes in trunk

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88212 and r88219.
http://trac.webkit.org/changeset/88212
http://trac.webkit.org/changeset/88219
https://bugs.webkit.org/show_bug.cgi?id=57439

Tests get timeout on Snow Leopard

  • fast/replaced/no-focus-ring-embed-1-expected.txt: Removed.
  • fast/replaced/no-focus-ring-embed-1.html: Removed.
  • fast/replaced/no-focus-ring-embed-2-expected.txt: Removed.
  • fast/replaced/no-focus-ring-embed-2.html: Removed.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Removed.
  • fast/replaced/no-focus-ring-iframe.html: Removed.
  • fast/replaced/no-focus-ring-object-1-expected.txt: Removed.
  • fast/replaced/no-focus-ring-object-1.html: Removed.
  • fast/replaced/no-focus-ring-object-2-expected.txt: Removed.
  • fast/replaced/no-focus-ring-object-2.html: Removed.
  • fast/replaced/outline-replaced-elements-expected.txt: Removed.
  • fast/replaced/outline-replaced-elements.html: Removed.
  • fast/replaced/resources/focus-test.js: Removed.
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Removed.

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88212 and r88219.
http://trac.webkit.org/changeset/88212
http://trac.webkit.org/changeset/88219
https://bugs.webkit.org/show_bug.cgi?id=57439

Tests get timeout at Snow Leopard

  • css/html.css: (html:focus, body:focus, input[readonly]:focus):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
01:39 Changeset [88227] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r88175.

  • platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
01:38 Changeset [88226] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skip tests crashing in GTK bots because of an ASSERT.

Also relocated one skipped test into its right category, together
with the new one being skipped now.

  • platform/gtk/Skipped: SKipped test
01:33 Changeset [88225] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Verify cloning <details> and <summary> works.
https://bugs.webkit.org/show_bug.cgi?id=61985

  • fast/html/details-clone-expected.txt: Added.
  • fast/html/details-clone.html: Added.
01:26 Changeset [88224] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt][V8] Fix the build after 88221.

No new tests needed.

  • WebCore.pro: Remove non-existing files.
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjects): Also rename the definition of the function.

06/06/11:

23:31 Changeset [88223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88222.
http://trac.webkit.org/changeset/88222
https://bugs.webkit.org/show_bug.cgi?id=62192

Broke compile on Mac (Requested by abarth on #webkit).

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
23:20 Changeset [88222] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-06 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add ArgumentCoders for TransformOperation, including all the subclasses,
and TransformOperations.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
23:19 Changeset [88221] by commit-queue@webkit.org
  • 10 edits
    4 deletes in trunk/Source/WebCore

2011-06-06 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Removed.
  • bindings/v8/ChildThreadDOMData.h: Removed.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
  • bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Removed.
  • bindings/v8/MainThreadDOMData.h: Removed.
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
23:11 Changeset [88220] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

[chromium] Make VideoFrameChromium's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62186

This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
deletes a VideoFrameChromium subclass type through this interface
class, causing ~VideoFrameChromiumImpl's destructor not to run.
(VideoFrameChroimumImpl happens to not have a destructor or any
non-POD member variables, so it's more a latent bug.)

  • platform/graphics/chromium/VideoFrameChromium.cpp: (WebCore::VideoFrameChromium::~VideoFrameChromium):
  • platform/graphics/chromium/VideoFrameChromium.h:
22:52 Changeset [88219] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-06-06 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fix flakiness on Snow Leopard.

  • fast/replaced/resources/focus-test.js:
22:24 Changeset [88218] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sammy Weinig.

Remove some unnecessary includes from AnimationBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=62183

  • page/animation/AnimationBase.cpp:
22:14 Changeset [88217] by koz@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Rebaseline outline-replaced-elements windows/linux image results.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • platform/chromium-linux-x86/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium/test_expectations.txt:
21:52 Changeset [88216] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, a crash fix by a roll out.

REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
https://bugs.webkit.org/show_bug.cgi?id=62116

Roll out the WebCore part of r87980.

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):

  • html/SearchInputType.h:

(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):

  • html/TextFieldInputType.h:

(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):

  • html/shadow/TextControlInnerElements.cpp:
  • html/shadow/TextControlInnerElements.h:
21:42 Changeset [88215] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Allow copying of KeyframeValueList.
https://bugs.webkit.org/show_bug.cgi?id=62171

Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.

No new functionality so no new tests.

  • platform/graphics/GraphicsLayer.h: (WebCore::FloatAnimationValue::clone): (WebCore::TransformAnimationValue::TransformAnimationValue): (WebCore::TransformAnimationValue::clone): (WebCore::TransformAnimationValue::value): (WebCore::KeyframeValueList::KeyframeValueList):
21:12 Changeset [88214] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2011-06-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Incorrect rounding of color values during transitions
https://bugs.webkit.org/show_bug.cgi?id=62141

When blending integers, round to the nearest integer, instead of always rounding down.

Test: transitions/color-transition-rounding.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
21:06 Changeset [88213] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88202.
http://trac.webkit.org/changeset/88202
https://bugs.webkit.org/show_bug.cgi?id=62182

This broke the mac clang bot (Requested by koz on #webkit).

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/InlineBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
21:04 Changeset [88212] by commit-queue@webkit.org
  • 5 edits
    14 adds in trunk

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-1.html: Added.
  • fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-2.html: Added.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Added.
  • fast/replaced/no-focus-ring-iframe.html: Added.
  • fast/replaced/no-focus-ring-object-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-1.html: Added.
  • fast/replaced/no-focus-ring-object-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-2.html: Added.
  • fast/replaced/outline-replaced-elements-expected.txt: Added.
  • fast/replaced/outline-replaced-elements.html: Added.
  • fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439

Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.

Tests: fast/replaced/no-focus-ring-embed-1.html

fast/replaced/no-focus-ring-embed-2.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object-1.html
fast/replaced/no-focus-ring-object-2.html
fast/replaced/outline-replaced-elements.html

  • css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
18:44 Changeset [88211] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

  • editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
  • editing/spelling/spellcheck-input-search-crash.html: Added.

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

Added a guard bofore TextCheckingHelper construction sites.

Test: editing/spelling/spellcheck-input-search-crash.html

  • editing/Editor.cpp: (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
18:35 Changeset [88210] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dirk Pranke.

[chromium] Chromium bots on build.webkit.org don't upload results.html
https://bugs.webkit.org/show_bug.cgi?id=61961

Don't fix the path on chromium port erroneously.

  • BuildSlaveSupport/test-result-archive:
18:17 Changeset [88209] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload): Change prettyURL() with string().
18:12 Changeset [88208] by jamesr@google.com
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 87960 - 2011-06-02 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7125002

18:03 Changeset [88207] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
17:56 Changeset [88206] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed, update test_expectations.txt.

  • platform/chromium/test_expectations.txt:
17:53 Changeset [88205] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Update RenderBlock::paint to use IntPoint internally
https://bugs.webkit.org/show_bug.cgi?id=62140

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
17:07 Changeset [88204] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62165>
<rdar://problem/9555835>
WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::findString):
Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
number that would be ignored.

17:03 Changeset [88203] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebViewImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62155

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebViewImpl.h:
16:45 Changeset [88202] by eae@chromium.org
  • 15 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Covered by existing tests.

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
16:31 Changeset [88201] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-06 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean scalePage related LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=62142

  • platform/qt/Skipped:
16:21 Changeset [88200] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch shouldPaint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62158

Switching shouldPaint to take an IntPoint representing the paint offset instead
of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
  • rendering/RenderReplaced.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
16:04 Changeset [88199] by simonjam@chromium.org
  • 5 edits in trunk/Source

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

  • wtf/CurrentTime.cpp: Add monotonicallyIncreasingTime() for mac and a fallback implementation that just wraps currentTime(). (WTF::monotonicallyIncreasingTime):
  • wtf/CurrentTime.h: Add monotonicallyIncreasingTime().

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

  • platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
16:01 Changeset [88198] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::pushContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62133

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::Covered by existing tests.RenderBlock::paint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
15:28 Changeset [88197] by japhet@chromium.org
  • 1 edit
    3 copies in branches/chromium/782

Merge r87959 to chromium/782.

< rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.
Reviewed by Oliver Hunt.
Source/WebCore:
Test: webarchive/loading/javascript-url-iframe-crash.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
cause the DocumentLoader to be destroyed, so protect it with a Ref here.
LayoutTests:

  • webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
  • webarchive/loading/javascript-url-iframe-crash.html: Added.
  • webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
15:27 Changeset [88196] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156

Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
15:13 Changeset [88195] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert hitTest to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62144

Covered by existing tests.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
  • rendering/RenderObject.h:
15:03 Changeset [88194] by simonjam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-06 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html

  • platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
15:00 Changeset [88193] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151

Switching paintScrollbar to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar):
  • rendering/RenderListBox.h:
14:52 Changeset [88192] by dcheng@chromium.org
  • 4 edits
    6 deletes in trunk/Source

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

No new tests since this change only deleted unused code.

  • WebCore.gypi:
  • platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
  • platform/chromium/ChromiumDataObjectLegacy.h: Removed.
  • platform/chromium/ReadableDataObject.cpp: Removed.
  • platform/chromium/ReadableDataObject.h: Removed.
  • platform/chromium/WritableDataObject.cpp: Removed.
  • platform/chromium/WritableDataObject.h: Removed.

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

  • src/WebDragData.cpp:
14:45 Changeset [88191] by thakis@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
14:35 Changeset [88190] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137

Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
representing the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintContinuationOutlines):
  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
14:30 Changeset [88189] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::popContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62132

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::popContentsClip):
  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
14:26 Changeset [88188] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Remove tx/ty offset from selectionRect
https://bugs.webkit.org/show_bug.cgi?id=62146

Removing unused offset parameters from selectionRect.

No new tests since this is just cleanup.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::selectionRect):
  • rendering/EllipsisBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::ellipsisRectForBox): (WebCore::RenderText::absoluteQuadsForRange): (WebCore::RenderText::selectionRectForRepaint):
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRect):
  • rendering/svg/SVGInlineTextBox.h:
14:15 Changeset [88187] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Adds a test for firing popstate, using window.dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=62099

  • fast/events/fire-popstate-event-expected.txt: Added.
  • fast/events/fire-popstate-event.html: Added.

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Let developers call createEvent("PopStateEvent"), previously it wasn't
exposed and threw an exeception.
https://bugs.webkit.org/show_bug.cgi?id=62099

  • WebCore/dom/Document.cpp:
  • WebCore/dom/PopStateEvent.cpp:
  • WebCore/dom/PopStateEvent.h:
14:12 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Update Szeged slaves with links (diff)
14:02 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Wiki syntax this time (diff)
13:58 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Add links to the Apple master slaves (diff)
13:42 Changeset [88186] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62059

Switching paintSelection to use an IntPoint to represent the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::paintSelection):
  • rendering/EllipsisBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
  • rendering/RenderBlock.h:
13:40 BuildBot edited by rniwa@webkit.org
Added a reference to … (diff)
13:18 Changeset [88185] by mrobinson@webkit.org
  • 4 edits in trunk

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

  • GNUmakefile.am: Assign libWebCoreInternals built sources to libwebcoreinternals_built_sources before adding to the source list and to BUILT_SOURCES.

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

  • GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
13:14 Changeset [88184] by jberlin@webkit.org
  • 4 edits in trunk/LayoutTests

Update the Windows-specific results after r88020 in order to get the bots green.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
13:00 BuildBot edited by rniwa@webkit.org
Added instruction to connect to bot master (diff)
12:57 Changeset [88183] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::clipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62045

Covered by existing tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::clipRect):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
12:57 Changeset [88182] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Skip more tests on Windows that use the Shadow DOM to get the bots green.

  • platform/win/Skipped:
12:42 Changeset [88181] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Anna Cavender <annacc@chromium.org>

Reviewed by David Levin.

Marking media/video-canvas-alpha.html as SKIP for GPU MAC.
https://bugs.webkit.org/show_bug.cgi?id=62068

  • platform/chromium/test_expectations.txt:
12:40 Changeset [88180] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Layout test expectations fix.

[chromium] Adjusting expectations for failing huge-layer-img.html

  • platform/chromium/test_expectations.txt:
12:36 Changeset [88179] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-06 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=62097
Fix the problem that integral bitfield check incorrectly barked at ?: expressions.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:21 Changeset [88178] by commit-queue@webkit.org
  • 15 edits in trunk/Source

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

No behavior change, so no tests.

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::revealSelection):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea): (WebCore::RenderBox::canBeProgramaticallyScrolled):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::autoscroll):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

  • WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):
12:03 BuildBot edited by rniwa@webkit.org
Fixed indentation (diff)
12:02 BuildBot edited by rniwa@webkit.org
Added instruction to run buildbot locally (diff)
11:55 QtWebKitForQt5 edited by hausmann@webkit.org
Responding to comments (diff)
11:51 QtWebKitForQt5 edited by hausmann@webkit.org
Clean ups, clear up focus on browser development (diff)
11:51 Changeset [88177] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-06-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable feature/symbol detection in NWRT/GTK
https://bugs.webkit.org/show_bug.cgi?id=62136

Disable feature detection through DRT, since we don't support it,
and set the libwebcore patch correctly so that symbol detection
through 'nm' works.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
11:43 Changeset [88176] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62134

Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
IntPoint representing the paint offset instead of a pair of ints.

No new tests as this simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
  • rendering/RenderBlock.h:
11:38 WikiStart edited by rniwa@webkit.org
Added a link to BuildBot (diff)
11:32 Changeset [88175] by yael.aharon@nokia.com
  • 3 edits
    3 adds in trunk

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

  • fast/inline/inline-wrap-with-parent-padding.html: Added.
  • platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.

Test: fast/inline/inline-wrap-with-parent-padding.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::nextLineBreak):
11:03 Changeset [88174] by commit-queue@webkit.org
  • 12 edits in trunk

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
  • page/PageVisibilityState.h:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • public/WebPageVisibilityState.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):
11:01 Changeset [88173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-06 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Fix typo in CachedFont.cpp #define
https://bugs.webkit.org/show_bug.cgi?id=62127

No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.

  • loader/cache/CachedFont.cpp: change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
10:50 Changeset [88172] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62058

Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
their paint offsets instead of pairs of ints.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes):
  • rendering/RenderBlock.h:
10:27 BuildBot edited by rniwa@webkit.org
Added an instruction to use easy_install-2.6 on SL (diff)
10:10 Changeset [88171] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
https://bugs.webkit.org/show_bug.cgi?id=62124

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setException):
09:48 Changeset [88170] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

webkit/glue/webmediaplayer_impl.cc deletes an object of type
WebVideoFrame, which means this patch fixes a real bug, not just
a theoretical one.

[chromium] Give WebVideoFrame a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=61742

  • public/WebVideoFrame.h: (WebKit::WebVideoFrame::~WebVideoFrame):
08:49 Changeset [88169] by kinuko@chromium.org
  • 8 edits
    3 copies in branches/chromium/782

Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/storageinfo-no-callbacks-expected.txt: Added.
  • storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):

BUG=84527
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/7054073

07:57 Changeset [88168] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml.
07:52 Changeset [88167] by ossy@webkit.org
  • 3 edits in trunk/Tools

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):

  • QtTestBrowser/launcherwindow.h:
07:15 Changeset [88166] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 Steve Block <steveblock@google.com>

Reviewed by Yury Semikhatsky.

Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118

Correctly guard implementation of ScriptProfiler.

No new tests, build fix only.

  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::initialize):
07:12 Changeset [88165] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build fix after r88159.

  • win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.
06:53 Changeset [88164] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
06:33 Changeset [88163] by ossy@webkit.org
  • 2 edits
    45 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/qt/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/qt/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/qt/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/qt/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
06:27 Changeset [88162] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, new baseline for GPU test.
https://bugs.webkit.org/show_bug.cgi?id=62123

  • platform/chromium/test_expectations.txt:
06:19 Changeset [88161] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::downloadRequest): (LauncherWindow::fileDownloadFinished):
  • QtTestBrowser/launcherwindow.h:
05:41 Changeset [88160] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác

Skip a flakey test on ARM.

  • platform/qt-arm/Skipped:
05:32 Changeset [88159] by dominicc@chromium.org
  • 12 edits
    1 add in trunk

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Unskip window.internals test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • platform/win/Skipped:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project containing window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • WebKit.vcproj/WebKit.sln:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Re-export JSC and WebCore symbols required by WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • win/WebKit2.def:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Make DumpRenderTree initialize window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
05:23 Changeset [88158] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml.
05:16 Changeset [88157] by bulach@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-06 Csaba Osztrogonác <ossy@webkit.org>

[Qt][WK2] Remove previously deleted tests from the Skipped list.

  • platform/qt-wk2/Skipped:
04:58 Changeset [88156] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Remove previously deleted tests from the Skipped list.

  • platform/qt-wk2/Skipped:
04:53 Changeset [88155] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip failing tests.

  • platform/qt-wk2/Skipped:
04:37 Changeset [88154] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
04:22 Changeset [88153] by bulach@chromium.org
  • 32 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077
https://bugs.webkit.org/show_bug.cgi?id=62115

  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
04:12 Changeset [88152] by ossy@webkit.org
  • 2 edits
    70 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/qt/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/qt/fast/block/float/float-overhangs-root-expected.txt: Added.
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/qt/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/qt/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/qt/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/qt/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/qt/fast/html/details-nested-1-expected.png: Added.
  • platform/qt/fast/html/details-nested-1-expected.txt: Added.
  • platform/qt/fast/html/details-nested-2-expected.png: Added.
  • platform/qt/fast/html/details-nested-2-expected.txt: Added.
  • platform/qt/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/qt/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/qt/fast/html/details-replace-text-expected.png: Added.
  • platform/qt/fast/html/details-replace-text-expected.txt: Added.
  • platform/qt/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/qt/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/qt/fast/table/multiple-captions-display-expected.png: Added.
  • platform/qt/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-update-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-update-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/qt/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/qt/svg/custom/stroke-opacity-update-expected.txt: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.txt: Added.
03:45 Changeset [88151] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

This patch modifies only the build system. Therefore,
there are no new tests.

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Scripts/build-webkit:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
02:36 Changeset [88150] by mario@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-06 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88029 and r80034.

  • platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.
02:29 Changeset [88149] by morrita@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-02 MORITA Hajime <morrita@google.com>

Verify cloning <meter> and <progress> works
https://bugs.webkit.org/show_bug.cgi?id=61986

Added test cases for cloning <meter> and <progress>

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-clone.html: Added.
  • fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-clone.html: Added.
01:46 Changeset [88148] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

This patch modifies only the build system. Therefore,
there are no new tests.

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Scripts/build-webkit:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
01:35 Changeset [88147] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

[UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
https://bugs.webkit.org/show_bug.cgi?id=61538

Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
receiver code to support stream sockets, since it requires to
handle message boundaries. The same code works for DGRAM sockets,
so this change shouldn't break other ports using DGRAM.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::processMessage): Process messages from data already received. (CoreIPC::readBytesFromSocket): Read from socket using recvmsg(). (CoreIPC::Connection::readyReadHandler):
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in socketpair().
01:32 QtWebKitForQt5 edited by hausmann@webkit.org
Refine the FBO approach (diff)
01:09 Changeset [88146] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=62013

Clean up the prototypes for cursor open functions by introducing the
CursorOptions struct.

Just clean-up, no new functionality so no new tests.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon): (WebCore::CursorOptions::CursorImplCommon::firstSeek): (WebCore::CursorOptions::CursorImplCommon::continueFunction): (WebCore::CursorOptions::ObjectStoreCursorImpl::create): (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl): (WebCore::CursorOptions::IndexKeyCursorImpl::create): (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl): (WebCore::CursorOptions::IndexCursorImpl::create): (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
00:57 Changeset [88145] by carlosgc@webkit.org
  • 6 edits in trunk

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
00:27 Changeset [88144] by commit-queue@webkit.org
  • 15 edits in trunk

2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=48290
Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
from failed/skipped test list

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>

Reviewed by Darin Adler.

Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
https://bugs.webkit.org/show_bug.cgi?id=48290

"highlight" is not a valid globalComposite operation
as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
Therefore, removed the option from the source code.

Tests: No new tests required.
LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator CompositeOperator):
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::applyBlending):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
  • platform/graphics/skia/SkiaUtils.cpp:

06/05/11:

23:12 Changeset [88143] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
22:54 Changeset [88142] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix.

  • platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518.
22:49 Changeset [88141] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Skip new failing tests.

  • platform/qt-mac/Skipped:
22:38 Changeset [88140] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:56 Changeset [88139] by inferno@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-04 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
https://bugs.webkit.org/show_bug.cgi?id=62085

Testing ComplexTextControllerLinux change requires a testcase

32 kb which is not feasible. All other changes are tested by

existing layouttests.

  • platform/graphics/TextRun.h: (WebCore::TextRun::operator[]): add assert. (WebCore::TextRun::data): add assert.
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance): bail early and prevent access to one byte across the text run boundary.
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): wrong int16 vs int comparison.
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk): bail early when from and to is outside the text run boundary. this hit easily after adding the assert when from = to = end and read in run.data(from).
21:07 Changeset [88138] by tkent@chromium.org
  • 3 edits
    2 deletes in branches/chromium/782

Merge 88137

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):

TBR=tkent@chromium.org
BUG=84819
Review URL: http://codereview.chromium.org/6993052

19:01 Changeset [88137] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
13:13 Changeset [88136] by ap@apple.com
  • 2 edits in trunk/Tools

Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
works properly).

  • Scripts/webkitpy/common/config/committers.py:
13:12 Changeset [88135] by robert@webkit.org
  • 5 edits
    3 copies
    3 adds
    2 deletes in trunk

2011-06-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089

We're unskipping acid2.html event though it's just a landing
page for the acid2 test. Some elements of the test are loaded by
the landing page so it is testing something, but acid2-pixel covers the same
ground.

  • platform/qt/Skipped:
  • platform/qt/fast/css/acid2-expected.txt: Updated
  • platform/qt/fast/css/acid2-pixel-expected.png: Added.
  • platform/qt/fast/css/acid2-pixel-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Removed.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Removed.
  • platform/qt/http/tests/misc/acid2-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-expected.txt: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt: Added

2011-06-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089

shouldFallBack() tells the DOM if it should attempt to render
the next nested <object> if its parent fails to load.

This fix is only required for the fast/css version of the ACID2
test, which loads a non-existent file:// url. The HTTP version of the
test already passes because the loader will render fallback content
on a failed HTTP load without delegating the decision to the client
( see MainResourceLoader::continueAfterContentPolicy).

Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
what to return. This error isn't currently set by Qt so we don't check
it. (Other ports set it when the erring document is a MediaDocument, maybe
we should do that too at some point).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldFallBack):
11:34 Changeset [88134] by commit-queue@webkit.org
  • 6 edits in trunk

2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481

Rebaseline tests.

  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • platform/qt/Skipped:

2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481

computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
10:03 Changeset [88133] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

2011-09-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Update the library and user-facing version in preparation
for the 1.4.1 release.

  • configure.ac: Update the versions.

06/04/11:

22:28 Changeset [88132] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx.

22:07 Changeset [88131] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac.

21:38 Changeset [88130] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fixes for recent trunk changes.

21:33 Changeset [88129] by cevans@google.com
  • 4 edits in branches/chromium/782/Source/WebCore/accessibility

Merge 87856
BUG=84950
Review URL: http://codereview.chromium.org/7058064

20:21 Changeset [88128] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over some ChangeLogs.

19:08 Changeset [88127] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Disable WebProcess side display throttling when in a user scroll
<rdar://problem/9517175>
https://bugs.webkit.org/show_bug.cgi?id=62095

Add the ability to disable WebProcess side display throttling that
takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
when in a user or animated scroll.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::enableDisplayThrottling): (WebKit::DrawingArea::disableDisplayThrottling):
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::enableDisplayThrottling): (WebKit::DrawingAreaImpl::disableDisplayThrottling): (WebKit::DrawingAreaImpl::displayTimerFired):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::wheelEvent):
17:46 Changeset [88126] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
17:37 Changeset [88125] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez

Update the news file for the 1.4.1 release.

  • NEWS: Update news.
17:09 Changeset [88124] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.list.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
14:03 Changeset [88123] by darin@apple.com
  • 9 edits
    2 adds in trunk/Source

2011-06-04 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
  • platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.

2011-06-04 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebKit2.xcodeproj/project.pbxproj: Added new source files.
  • WebProcess/mac/CoreIPCClientRunLoop.h: Added.
  • WebProcess/mac/CoreIPCClientRunLoop.mm: Added. (-[WKFunctionAdapter perform]): Added. (WebKit::createCoreIPCRunLoopModesArray): Added. (WebKit::coreIPCRunLoopModesArray): Added. (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait. (WebKit::webFreeKeychainItemContent): Ditto. (WebKit::webSecKeychainItemCopyContent): Ditto. (WebKit::webSecKeychainItemCreateFromContent): Ditto. (WebKit::webSecKeychainItemModifyContent): Ditto.
  • WebProcess/mac/SecItemShimMethods.mm: (WebKit::webSecItemCopyMatching): Ditto. (WebKit::webSecItemAdd): Ditto. (WebKit::webSecItemUpdate): Ditto. (WebKit::webSecItemDelete): Ditto.
12:34 Changeset [88122] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add InlineWalker class to hold state for repeated calls to bidiNext
https://bugs.webkit.org/show_bug.cgi?id=60724

This is one more little step towards removing (naked) bidiNext usage.
More refactoring is required before all callers of bidiNext can move
onto using an InlineWalker instead of bidiNext directly.

No change in behavior, thus no tests.

  • rendering/InlineIterator.h: (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::root): (WebCore::InlineWalker::current): (WebCore::InlineWalker::atEndOfInline): (WebCore::InlineWalker::atEnd): (WebCore::InlineWalker::advance):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:20 Changeset [88121] by weinig@apple.com
  • 10 edits in trunk/Source

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Add additional ChromeClient functions to indicate the beginning and end of
the various ScrollAnimator animations. Change existing notification that a
rubber-band has completed for the main frame to be triggered for all frames.

  • page/ChromeClient.h: (WebCore::ChromeClient::didStartRubberBandForFrame): (WebCore::ChromeClient::didCompleteRubberBandForFrame): (WebCore::ChromeClient::didStartAnimatedScroll): (WebCore::ChromeClient::didCompleteAnimatedScroll):
  • page/FrameView.cpp: (WebCore::FrameView::didStartRubberBand): (WebCore::FrameView::didCompleteRubberBand): (WebCore::FrameView::didStartAnimatedScroll): (WebCore::FrameView::didCompleteAnimatedScroll):
  • page/FrameView.h:
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::didStartRubberBand): (WebCore::ScrollableArea::didStartAnimatedScroll): (WebCore::ScrollableArea::didCompleteAnimatedScroll):
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
animated scrolls, and update logic for rubber-band ending to check for main frame
now that it is called for all frames.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:59 Changeset [88120] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Touch a file to try to fix the GTK+ build on the 32-bit bot.

  • testing/Internals.idl: Touch this IDL file in an effort to fix the build.
11:55 Changeset [88119] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix formatting of the output generated by KeywordLookupGenerator.py
https://bugs.webkit.org/show_bug.cgi?id=62083

  • Uses correct year for copyright.
  • Puts ending brace on same line as "else if"
  • Puts starting brace of function on its own line.
  • Adds some tasteful whitespace.
  • Adds comments to make clear that scopes are ending
  • Make macros actually split on two lines.
  • KeywordLookupGenerator.py:
11:18 Changeset [88118] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.4

Merging r87696

10:45 Changeset [88117] by dcheng@chromium.org
  • 8 edits
    2 copies in branches/chromium/782

Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • fast/events/drag-image-filename-expected.txt: Added.
  • fast/events/drag-image-filename.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

  • The filename suggested in the HTTP header.
  • The last path component of the source URL.
  • The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
  • DumpRenderTree/chromium/EventSender.h:

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/7054067

10:23 Changeset [88116] by mrobinson@webkit.org
  • 4 edits in trunk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

  • bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

  • GNUmakefile.am: Add some missing newline escape.
10:14 Changeset [88115] by dglazkov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Convert file <input> to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=59005

Refactoring, covered by existing tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/html.css: (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
  • html/FileInputType.cpp: (WebCore::UploadButtonElement::create): Added. (WebCore::UploadButtonElement::UploadButtonElement): Added. (WebCore::UploadButtonElement::shadowPseudoId): Added. (WebCore::FileInputType::createShadowSubtree): Added.
  • html/FileInputType.h: Added createShadowSubtree decl.
  • page/DragController.cpp: (WebCore::asFileInput): Changed the logic to use new shadow DOM.
  • rendering/RenderFileUploadControl.cpp: Removed UploadButton class. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary. (WebCore::nodeWidth): Added a helper. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
  • rendering/RenderFileUploadControl.h: Changed decls.
  • rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
09:15 Changeset [88114] by kov@webkit.org
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/87523

05:56 Changeset [88113] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator.py spams stdout in Chromium Linux build
https://bugs.webkit.org/show_bug.cgi?id=62087

This action does not appear to be needed.

05:06 Changeset [88112] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ResourceHandleInternal's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62073

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
04:35 Changeset [88111] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enable passing File API tests
https://bugs.webkit.org/show_bug.cgi?id=62020

File API has been enabled for QtWebKit in r74115,
let's also enable the passing related tests.

  • platform/qt/Skipped:
04:23 Changeset [88110] by ap@apple.com
  • 6 edits
    1 delete in trunk

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:
  • fast/forms/paste-multiline-text-input.html:
  • fast/forms/script-tests/input-value-sanitization.js: Removed.

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

Newline characters should be removed according to HTML5, not replaced with spaces.
This also matches Safari 5 behavior.

  • html/TextFieldInputType.cpp: (WebCore::isASCIILineBreak): A functor for removeCharacters(). (WebCore::limitLength): Do one thing at once. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising) code that replaces newlines with spaces here.
04:14 Changeset [88109] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076

Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
04:06 Changeset [88108] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
03:58 Changeset [88107] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/PlatformMessagePortChannel.h:
03:50 Changeset [88106] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
03:42 Changeset [88105] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebFrameImpl.h:
03:32 Changeset [88104] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Added simple test that hits the relevant code.

  • mathml/msubsup-remove-children-expected.txt: Added.
  • mathml/msubsup-remove-children.xhtml: Added.

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml

  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::baselinePosition):
03:24 Changeset [88103] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Give IDBBackingStore::Transaction a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62063

IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.

  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Transaction::~Transaction):
02:53 Changeset [88102] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032

Covered by existing tests.

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • platform/graphics/IntRect.h: (WebCore::IntRect::contract):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::overflowClipRect):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect): (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
02:24 Changeset [88101] by abarth@webkit.org
  • 2 edits in trunk/Source/ThirdParty
  • glu: Added property svn:ignore.
    • For glu.xcodeproj, which is generated from glu.gyp.
02:22 Changeset [88100] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

V8Proxy::disconnectFrame doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=62051

Dead code should die.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
02:05 Changeset [88099] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Make the destructors of DataTransferItem and DataTransferItems virtual
https://bugs.webkit.org/show_bug.cgi?id=62052

Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)

  • dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
  • dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):
02:02 Changeset [88098] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make LayerPainterChromium destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62056

LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
means that without this patch, the destructor of classes implementing
LayerPainterChromium wasn't called correctly in that case.

  • platform/graphics/chromium/LayerPainterChromium.h: (WebCore::LayerPainterChromium::~LayerPainterChromium):
01:08 Changeset [88097] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

Configure new commit-queue instance. (Please ignore.)

00:02 Changeset [88096] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Andreas Kling.

Fix IntRect::expand(const IntSize& size)
https://bugs.webkit.org/show_bug.cgi?id=62042

No new tests.

  • platform/graphics/IntRect.h: (WebCore::IntRect::expand): Fix IntRect::expand to expand the size rather than move the location. Currently unused.

06/03/11:

23:45 Changeset [88095] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Fixes test expectatations.

[chromium] Fixing redefinitions of test_expectations entries
for chrome gpu tests.

  • platform/chromium/test_expectations.txt:
23:15 Changeset [88094] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Lexer needs to provide Identifier for reserved words
https://bugs.webkit.org/show_bug.cgi?id=62086

Alas it is necessary to provide an Identifier reference for keywords
so that we can do the right thing when they're used in object literals.
We now keep Identifiers for all reserved words in the CommonIdentifiers
structure so that we can access them without a hash lookup.

  • KeywordLookupGenerator.py:
  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier):
  • parser/Lexer.h:
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
  • runtime/CommonIdentifiers.h:
22:25 Changeset [88093] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add debug code to break on speculation failures.

Reviewed by Sam Weinig.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGNode.h:
22:13 Changeset [88092] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap

Reviewed by Sam Weinig.

This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.

This can also affect function calls passing three arguments.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):

  • Call swap with the correct arguments.
21:59 Changeset [88091] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-03 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

ResourceHandleMac should always respond to an authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=61667

I don't know if this can actually happen in practice, so no new tests.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Cancel authentication challenge if we don't have a client. We must always respond to the challenge to release the connection, and there is nothing else to do in this state anyway.
21:35 Changeset [88090] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix the Apple LLVM Compiler build after r88087.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintMask):

  • rendering/RenderTableCell.h:
20:06 Changeset [88089] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix clang build - take 2

19:57 Changeset [88088] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix clang build

19:25 Changeset [88087] by leviw@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintMask and paintObject to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62077

Switching paintMask and paintObject to use IntPoint for their paint offset instead of
a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
  • rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
  • rendering/RenderListBox.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): (WebCore::RenderTextControl::paintObject):
  • rendering/RenderTextControl.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
18:58 Changeset [88086] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7058060

18:55 Changeset [88085] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7112025

18:34 Changeset [88084] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Force inlining of some hot lexer functions
https://bugs.webkit.org/show_bug.cgi?id=62079

Fix more GCC stupidity

  • parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator):
17:43 Changeset [88083] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

GCC not inlining some functions that it really should be
https://bugs.webkit.org/show_bug.cgi?id=62075

Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.

  • KeywordLookupGenerator.py:
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
  • parser/Lexer.cpp: (JSC::isIdentPart):
17:39 Changeset [88082] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Whoops, fix last minute bug.

17:22 Changeset [88081] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Support FontCustomPlatformData on Skia-Mac-Chrome variant
https://bugs.webkit.org/show_bug.cgi?id=62040

Canvas text is only recognized by Skia if it is registered
by creating a new SkTypeface. Skia uses CGFont to measure
and render the glyphs, then takes care of managing the glyph
cache.

Skia on Mac Chrome is not yet enabled, so this change
does not affect existing code, and requires no new tests.

  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::RemoteFontStream): (WebCore::RemoteFontStream::~RemoteFontStream): (WebCore::RemoteFontStream::rewind): (WebCore::RemoteFontStream::read): Turn the buffer into a stream. This is identical to the implementation in skia/FontCustomPlatformData.cpp. While that file could be modified instead of this one, it was simpler to add SkTypeface streaming to this instead of adding all CGFont support to the skia platform file.

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
Release the SkTypeface reference.

(WebCore::createFontCustomPlatformData):
Associate the buffer stream with a SkTypeface so Skia
can find the custom font data.

  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Add a slot to hold the SkTypeface.
17:16 Changeset [88080] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Brian Weinstein.

HistoryItem children persist across page loads
https://bugs.webkit.org/show_bug.cgi?id=62071
<rdar://problem/9552129>


Not testable since there's no way to check for the presence/absence
of children for a HistoryItem.

  • history/HistoryItem.cpp: (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.
17:09 Changeset [88079] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-06-03 James Robinson <jamesr@chromium.org>

[chromium] Mark GPU-only expectations as GPU.

  • platform/chromium/test_expectations.txt:
16:57 Changeset [88078] by mrobinson@webkit.org
  • 5 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ build.

  • GNUmakefile.am: Clean up some spaces that should be tabs.
  • GNUmakefile.list.am: Add KeywordLookup.h to the source list and clean up some spaces that should be tabs.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ bulid.

  • GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals source list.
16:53 Changeset [88077] by scherkus@chromium.org
  • 36 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining Chromium GPU media pixel results after Chromium commit 87830.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
16:30 Changeset [88076] by oliver@apple.com
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve keyword lookup
https://bugs.webkit.org/show_bug.cgi?id=61913

Rather than doing multiple hash lookups as we currently
do when trying to identify keywords we now use an
automatically generated decision tree (essentially it's
a hard coded patricia trie). We still use the regular
lookup table for the last few characters of an input as
this allows us to completely skip all bounds checks.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • KeywordLookupGenerator.py: Added.
  • make-generated-sources.sh:
  • parser/Lexer.cpp: (JSC::Lexer::internalShift): (JSC::Lexer::shift): (JSC::Lexer::parseIdentifier):
  • parser/Lexer.h:
16:29 Changeset [88075] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9553645> and https://bugs.webkit.org/show_bug.cgi?id=62064
WebBackForwardListItem::setBackForwardData actually appends data

Reviewed by Steve Falkenburg.

  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::setBackForwardData): Clear the Vector out before appending

the replacement data.

16:03 Changeset [88074] by crogers@google.com
  • 8 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Allow existing AudioParams to use scheduled parameter changes
https://bugs.webkit.org/show_bug.cgi?id=62046

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
  • platform/audio/AudioBus.h:
  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
  • webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process):
  • webaudio/AudioGainNode.h:
  • webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  • webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):
16:02 Changeset [88073] by dpranke@chromium.org
  • 5 edits in trunk

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, merge in downstream lines from Chromium as part of
landing the fix for bug 61888.

  • platform/chromium/test_expectations.txt:

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

nrwt: should skip chromium test expectation overrides on upstream bots
https://bugs.webkit.org/show_bug.cgi?id=61888

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
15:52 Changeset [88072] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Biquad filter coefficient naming is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62053

No new tests since audio API is not yet implemented.

  • platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::process): (WebCore::Biquad::processFast): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setZeroPolePairs):
  • platform/audio/Biquad.h:
15:42 Changeset [88071] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

Test that some esoteric combination of eval, load, and Location don't
do something goofy.

  • http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Added.
  • http/tests/security/xss-DENIED-contentWindow-eval.html: Added.

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

This code gets confused when dealing with inactive DOMWindows. We
should just block inactive DOMWindows because there's no compatibility
reason to support them in this code path.

Test: http/tests/security/xss-DENIED-contentWindow-eval.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::isInsecureScriptAccess):
15:38 QtWebKitFeatures22 edited by laszlo.1.gombos@nokia.com
(diff)
15:34 Changeset [88070] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: minor logging, code cleanup
https://bugs.webkit.org/show_bug.cgi?id=62055

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
15:22 Changeset [88069] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the build failure on the GTK+ 32-bit Release bot.

  • GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
15:14 Changeset [88068] by simonjam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, baseline for full-screen-placeholder. More flakiness for svg/zoom and navigator.

  • platform/chromium-win/fullscreen/full-screen-placeholder-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:03 Changeset [88067] by enne@google.com
  • 2 edits in branches/chromium/782/Source

Merge 87868 - 2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • tests/TreeSynchronizerTest.cpp: (WebCore::TEST):

TBR=enne@google.com

14:55 Changeset [88066] by mrobinson@webkit.org
  • 22 edits in trunk

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Unskip tests which are now passing and update results for other tests
which vary depending on smart replace support.

  • platform/gtk/Skipped: Unskip tests which are now passing.
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add smart replace support to WebCore and add hooks for it in WebKit
via DumpRenderTreeSupportGtk. When a platform supports smart replace,
WebCore will remove extra spaces that appear when pasting text. Eventually
WebKitGTK+ may want to expose this in the public API.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace when calling writeSelection. (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard for whether or not it supports smart paste.
  • platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): Added initialization for smart replace atom. (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom. (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
  • platform/gtk/PasteboardHelper.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
smart replace in the tests.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): targeListForDataObject now takes another parameter determining whether or not to add smart paste support. Add it here.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation. (WebKit::EditorClient::smartInsertDeleteEnabled): Added. (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
This is required to produce consistent test results.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this methods which calls into DumpRenderTreeSupportGtk.
14:53 Changeset [88065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847

Modified failing test's base url so it could get a valid origin
and make use of local storage. Also added another test that checks
local storage visibility in both scenarios.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testOptionalJSObjects): (checkLocalStorageVisibility): (tst_QWebPage::testLocalStorageVisibility):
14:49 Changeset [88064] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating media/video-display-aspect-ratio.html expectations for Chromium.

  • platform/chromium/test_expectations.txt:
14:45 Changeset [88063] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62033

Switching paintCell to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
14:39 Changeset [88062] by mrobinson@webkit.org
  • 9 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • Source/autotools/symbols.filter: Added some symbols necessary for window.internals to function to the global symbol list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • platform/gtk/Skipped: Unskip the one new window.internals test.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • GNUmakefile.am: Add new internals directories to the VPATH (for idl processing) and the include list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Inject the new internals object when the window object clears.
  • GNUmakefile.am: Add new source files and includes necessary for window.internals. Also do a little bit of cleanup.
14:37 Changeset [88061] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

14:34 Changeset [88060] by lforschler@apple.com
  • 1 copy in tags/Safari-534.43

New tag.

14:33 Changeset [88059] by lforschler@apple.com
  • 1 delete in tags/Safari-534.43

remove tag.

14:33 Changeset [88058] by lforschler@apple.com
  • 1 delete in tags/Safari-534.43/safari-534-branch

remove tag.

14:31 Changeset [88057] by lforschler@apple.com
  • 1 copy in tags/Safari-534.43/safari-534-branch

New tag.

14:31 Changeset [88056] by lforschler@apple.com
  • 8 edits in branches/safari-534-branch/Source/WebKit2

Merge r87839.

14:26 Changeset [88055] by lforschler@apple.com
  • 1 copy in tags/Safari-534.43

New tag.

14:26 Changeset [88054] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Enable ArrayBuffer passing tests as ArrayBuffer is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=62025

  • platform/qt/Skipped:
14:24 Changeset [88053] by scherkus@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, adding Ogg Theora version of media/content/test-par-16-9.mp4.

  • media/content/test-par-16-9.ogv: Added.
14:02 Changeset [88052] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Warning fixes on comparisons between a signed and an unsigned.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): (DumpRenderTreeSupportQt::nodesFromRect):
13:59 Changeset [88051] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBackgroundsBehindCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62031

Switching paintBackgroundsBehindCell to take an IntPoint representing
the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell):
13:57 Changeset [88050] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCaret and paintDragCaret to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62037

Switching paintCaret and paintDragCaret to use an IntPoint representing
the paint offset instead of a pair of ints.

No new tests since this is simple refactoring.

  • editing/FrameSelection.cpp: (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::DragCaretController::paintDragCaret):
  • editing/FrameSelection.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::offsetForContents):
  • rendering/RenderBlock.h:
13:55 Changeset [88049] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintItemForeground and paintItemForeground to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62035

Switching paintItemFore/Background to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
  • rendering/RenderListBox.h:
13:53 Changeset [88048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-03 Anders Carlsson <andersca@apple.com>

Reviewed by Brady Eidson.

Disable the sync message timeout for the Microsoft SharePoint plug-in
https://bugs.webkit.org/show_bug.cgi?id=62043
<rdar://problem/9536303>

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout):
13:49 Changeset [88047] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix conflict in expectations.

  • platform/chromium/test_expectations.txt:
13:35 Changeset [88046] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-06-03 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] TiledDrawingArea: Initialize tiles to transparent.

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate): When constructing new back buffers, fill them with transparent pixels.
13:32 Changeset [88045] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

  • platform/network/qt/QtMIMETypeSniffer.h:
13:29 Changeset [88044] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update for inspector/profiler/cpu-profiler-profiling* on Linux. https://bugs.webkit.org/show_bug.cgi?id=61533

13:28 Changeset [88043] by kov@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/85207

13:22 Changeset [88042] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

http://trac.webkit.org/changeset/86084

13:07 Changeset [88041] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix after r87902.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
only on classes inside Qt.


  • WebCoreSupport/DumpRenderTreeSupportQt.h:
12:43 Changeset [88040] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Worker may not be stopped after LT.
https://bugs.webkit.org/show_bug.cgi?id=61847

Re-submit a variant of the first fix for this bug. It's possible
that actually calling cleanup() in the worker threads was taking
too long and we triggered the assertions in the manager thread.

I've bumped up the timeout in the manager and added better
diagnostics. I also cleaned up the cleanup() code a bit because
there was some unnecessary if-checks.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
12:35 Changeset [88039] by rwlbuis@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Cleanup member variable usage in svg/animation classes
https://bugs.webkit.org/show_bug.cgi?id=62029

Cleanup member variables.

  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement):
  • svg/animation/SVGSMILElement.h:
12:18 Changeset [88038] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

Some warning fixes. Values in switch not handled, and
a comparison between a signed and an unsigned.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::action):
12:17 Changeset [88037] by crogers@google.com
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioParam parameter scheduling implementation
https://bugs.webkit.org/show_bug.cgi?id=61830

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • webaudio/AudioParam.cpp: (WebCore::AudioParam::value): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::calculateSampleAccurateValues):
  • webaudio/AudioParam.h: (WebCore::AudioParam::setContext): (WebCore::AudioParam::context): (WebCore::AudioParam::setValueAtTime): (WebCore::AudioParam::linearRampToValueAtTime): (WebCore::AudioParam::exponentialRampToValueAtTime): (WebCore::AudioParam::setTargetValueAtTime): (WebCore::AudioParam::setValueCurveAtTime): (WebCore::AudioParam::cancelScheduledValues): (WebCore::AudioParam::hasTimelineValues):
  • webaudio/AudioParam.idl:
  • webaudio/AudioParamTimeline.cpp: Added. (WebCore::AudioParamTimeline::setValueAtTime): (WebCore::AudioParamTimeline::linearRampToValueAtTime): (WebCore::AudioParamTimeline::exponentialRampToValueAtTime): (WebCore::AudioParamTimeline::setTargetValueAtTime): (WebCore::AudioParamTimeline::setValueCurveAtTime): (WebCore::isValidNumber): (WebCore::AudioParamTimeline::insertEvent): (WebCore::AudioParamTimeline::cancelScheduledValues): (WebCore::AudioParamTimeline::valueForContextTime): (WebCore::AudioParamTimeline::valuesForTimeRange): (WebCore::timeToSampleFrame): (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
  • webaudio/AudioParamTimeline.h: Added. (WebCore::AudioParamTimeline::AudioParamTimeline): (WebCore::AudioParamTimeline::hasValues): (WebCore::AudioParamTimeline::ParamEvent::ParamEvent): (WebCore::AudioParamTimeline::ParamEvent::type): (WebCore::AudioParamTimeline::ParamEvent::value): (WebCore::AudioParamTimeline::ParamEvent::time): (WebCore::AudioParamTimeline::ParamEvent::timeConstant): (WebCore::AudioParamTimeline::ParamEvent::duration): (WebCore::AudioParamTimeline::ParamEvent::curve):
12:05 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
12:03 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
12:02 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
12:02 Changeset [88036] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging http://trac.webkit.org/changeset/87366

12:00 Changeset [88035] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: fix duplicate logging regression
https://bugs.webkit.org/show_bug.cgi?id=61981

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
11:57 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
11:51 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
11:48 Changeset [88034] by jer.noble@apple.com
  • 7 edits
    2 adds in trunk

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

  • fullscreen/full-screen-placeholder-expected.txt: Added.
  • fullscreen/full-screen-placeholder.html: Added.

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

Test: fullscreen/full-screen-placeholder.html

Entering full-screen mode is causing the page layout to change because the full-screen
element is taken out of the normal flow. To counteract this effect, insert a placeholder
block as a parent of the full-screen renderer with the same size and style as the full-screen
element pre-full-screen.

Only create a placeholder for block-level elements; the technique required for inline elements
would be vastly more complicated.

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder

based on the size and style of the full-screen element.

(WebCore::Document::setFullScreenRenderer): Persist the placeholder size and

style across new renderers.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::RenderFullScreen): Added ivar. (RenderFullScreen::destroy): Make sure to safely destroy our placeholder. (RenderFullScreen::createPlaceholder): Added.
  • rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::placeholder): Ivar accessor.
11:43 Changeset [88033] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxDecorations to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61968

Switching paintBoxDecorations to take an IntPoint representing
the paint offset instead of a pair of ints. Also cleaning up
some duplicated code in InlineFlowBox related to constraining
the paint rect to the linetop and linebottom.

No new tests since this is just refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added to remove duplicate code in paintBoxDecorations and paintMask. (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFieldset.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
11:37 QtWebKitFeatures22 edited by ademar.reis@openbossa.org
(diff)
11:33 Changeset [88032] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Removed test_expectations failure entry for BUGCR36415 as is fixed
with patch in https://bugs.webkit.org/show_bug.cgi?id=62016

  • platform/chromium/test_expectations.txt:

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Modified addTouchPoint to correctly re-use touchPoint id values starting
from the lowest not-un-use touchPoint id as is done by the embedder
APIs. (Fixes BUGCR36415)

https://bugs.webkit.org/show_bug.cgi?id=62016

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint):
11:22 Changeset [88031] by simonjam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, pixel baselines for selectlist-minsize.html.

  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-win/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-win/fast/forms/selectlist-minsize-expected.txt: Added.
10:39 Changeset [88030] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-06-03 Philippe Beauchamp <philippe.beauchamp@gmail.com>

Reviewed by Dimitri Glazkov.

Add the feature "Add as search engine..." in a search text field context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

  • public/WebContextMenuData.h:
  • public/WebSearchableFormData.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebSearchableFormData.cpp: (WebKit::WebSearchableFormData::WebSearchableFormData):
10:03 Changeset [88029] by commit-queue@webkit.org
  • 28 edits
    3 adds in trunk

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The test is to get the render tree of select menu lists with varying widths based on content.
Some select list based tests are rebaselined because minimum width of RenderMenuList changes
based on the content with this fix.

  • fast/forms/selectlist-minsize.html: Added.
  • platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/fast/forms/003-expected.txt:
  • platform/qt/fast/forms/004-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/menulist-deselect-update-expected.txt:
  • platform/qt/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/fast/forms/option-script-expected.txt:
  • platform/qt/fast/forms/select-background-none-expected.txt:
  • platform/qt/fast/forms/select-baseline-expected.txt:
  • platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/qt/fast/forms/select-empty-option-height-expected.txt:
  • platform/qt/fast/forms/select-size-expected.txt:
  • platform/qt/fast/forms/select-style-expected.txt:
  • platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/fast/invalid/014-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/three-selects-break-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.txt:

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.

Test: fast/forms/selectlist-minsize.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::minimumMenuListSize):
10:00 Changeset [88028] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88020
https://bugs.webkit.org/show_bug.cgi?id=62028

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
09:54 Changeset [88027] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Make tiling on WebKit2 more responsive.
https://bugs.webkit.org/show_bug.cgi?id=50064

Instead of creating and destroying pixmaps, and copying them using QPixmap::copy()
or relying on the implicit sharing functionality, we keep the QPixmaps alive
and just make sure their content is synchronized.

This seems to improve responsiveness noticably, as now the UI process doesn't deal
with allocating/deallocating pixmaps, and the copies are done with the optimized
path (QPainter) vs the unoptimized ones (QPixmap::copy().)

  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::incorporateUpdate):
09:26 Changeset [88026] by dglazkov@chromium.org
  • 6 edits in trunk

2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

  • fast/events/shadow-boundary-crossing-expected.txt: Added test.
  • fast/events/shadow-boundary-crossing.html: Added expectations.

2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing. (WebCore::EventDispatcher::EventDispatcher): Added initializer. (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
  • dom/EventDispatcher.h: Added a def.
09:24 Changeset [88025] by mario@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88007 and r8009.

  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
09:14 Changeset [88024] by mario@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88011.

  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
09:08 Changeset [88023] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
09:07 Changeset [88022] by mario@webkit.org
  • 6 edits
    5 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, tests rebaselines for GTK after r88011.

  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
09:00 Changeset [88021] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

Manual test: select-popup-tooltip-test.html

  • manual-tests/select-popup-tooltip-test.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
  • platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

  • public/WebMenuItemInfo.h: Add toolTip.
  • public/WebViewClient.h: Remove setToolTipText().
  • public/WebWidgetClient.h: Add setTooTipText(). (WebKit::WebWidgetClient::setToolTipText):
  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().
08:45 Changeset [88020] by rwlbuis@webkit.org
  • 15 edits in trunk

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Update test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • svg/custom/global-constructors-expected.txt:

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Enable constructors for SVGMPathElement and SVGAnimateMotionElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
08:37 BuildingQtOnLinux edited by siddharth.mathur@nokia.com
added note on ICU (diff)
08:02 Changeset [88019] by hans@chromium.org
  • 6 edits in trunk/Source

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

This constant should only be needed inside IDBLevelDBCoding.cpp.

No new functionality, no new tests.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::getNewIndexId):
  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
  • storage/IDBLevelDBCoding.h:

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

Don't use INT64_MAX, use the various encodeMaxKey() functions instead.

  • tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
07:58 Changeset [88018] by bulach@chromium.org
  • 2 edits
    11 adds in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88007-88008
https://bugs.webkit.org/show_bug.cgi?id=62018

  • platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-linux/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
07:53 Changeset [88017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88014.
http://trac.webkit.org/changeset/88014
https://bugs.webkit.org/show_bug.cgi?id=62017

Broken EFL build (Requested by tonikitoo on #webkit).

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
07:47 Changeset [88016] by commit-queue@webkit.org
  • 11 edits
    1 add in trunk/Source

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

  • JavaScriptCore.pri: Support for use_system_icu CONFIG flag.
  • wtf/unicode/qt4/UnicodeQt4.h: Guard an include file with USE(ICU_UNICODE).

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

No new tests as no new features added.

  • WebCore.pri: Removed text_breaking_with_icu CONFIG flag.
  • WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
  • editing/qt/SmartReplaceQt.cpp:
  • features.pri: Support for use_system_icu CONFIG flag.
  • platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE).
  • platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added. (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
  • platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). (WebCore::isTextBreak):
  • platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). (WebCore::TextCodecQt::registerEncodingNames): (WebCore::TextCodecQt::registerCodecs):
07:39 Changeset [88015] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Draw DRT scroll bar thumb with CG when WebKit renders with Skia
https://bugs.webkit.org/show_bug.cgi?id=61534

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/

When WebKit uses Skia for rendering, the WebCanvas
is an SkCanvas. Create an equivalent CGContext to
draw the scrollbar thumb.

As the Chrome Mac port does not yet use Skia, this
patch has no effect and requires no tests.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
07:17 Changeset [88014] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
07:12 Changeset [88013] by abecsi@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

Fix typo.

  • Scripts/old-run-webkit-tests:
06:56 Changeset [88012] by abecsi@webkit.org
  • 3 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=61939

  • Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
  • Scripts/webkitperl/httpd.pm:
06:47 Changeset [88011] by yael.aharon@nokia.com
  • 3 edits
    9 adds in trunk

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

  • fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.

Test: fast/frames/flattening/iframe-flattening-out-of-view.html

fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html

  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame):
06:29 Changeset [88010] by mnaganov@chromium.org
  • 19 edits
    2 adds in trunk

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Added.
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html: Added.
  • platform/chromium/test_expectations.txt:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
  • src/WebDevToolsAgentImpl.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptProfilingEnabled):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptProfilingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorSetJavaScriptProfilingEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::setJavaScriptProfilingEnabled):
  • WebProcess/WebPage/WebInspector.h:
05:43 Changeset [88009] by zimmermann@webkit.org
  • 3 edits
    9 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/mac/svg/as-object: Added.
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • svg/as-image/img-preserveAspectRatio-support-2.html: Added.
  • svg/as-image/resources/circle-default-default.svg: Added.
  • svg/as-object: Added.
  • svg/as-object/object-box-sizing-no-width-height.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.

Tests: svg/as-image/img-preserveAspectRatio-support-2.html

svg/as-object/object-box-sizing-no-width-height.html

  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
05:36 Changeset [88008] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

  • platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Removed.
  • platform/gtk/accessibility/caret-browsing-anchor-followed.html: Removed.

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor):
05:11 Changeset [88007] by zimmermann@webkit.org
  • 9 edits
    4 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Added new tests covering this zooming.

  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • svg/zoom/page/resources/circle.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
zoom in the RenderStyle instead of asking SVGSVGElement.

The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.

Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::localToBorderBoxTransform):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):
  • svg/SVGSVGElement.h:
05:04 Changeset [88006] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=.

  • Source/WebKit.pri:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.

04:20 Changeset [88005] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt][WK2] Update platform specific expected file after r87873.

  • platform/qt-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
04:10 Changeset [88004] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

Update the caret position to the anchor's position after scrolling.

This behavior is specific to the Gtk port and requested because of
accessibility needs, that's why it's implemented in AXObjectCache.

Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the caret is updated to be in the anchor's position after scrolling.

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

New layout test for testing this GTK-specific feature.

  • platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
  • platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.
03:44 Changeset [88003] by tonyg@chromium.org
  • 13 edits in branches/chromium/782

Merge 87802 - 2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • fast/events/page-visibility-iframe-delete-test.html:
  • fast/events/page-visibility-iframe-move-test-expected.txt:
  • fast/events/page-visibility-iframe-move-test.html:
  • fast/events/page-visibility-iframe-propagation-test-expected.txt:
  • fast/events/page-visibility-iframe-propagation-test.html:
  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:

BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7065057

03:35 Changeset [88002] by dominicc@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that keygen clones have the right shadow pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

  • fast/html/clone-keygen-expected.txt: Added.
  • fast/html/clone-keygen.html: Added.
  • platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

When cloneNode's tag name-based cloning algorithm clones the
KeygenSelectElements of a keygen shadow as select elements. These
lack the -webkit-keygen-select pseudoclass.

Test: fast/html/clone-keygen.html

  • html/HTMLKeygenElement.cpp: (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
03:31 Changeset [88001] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-06-02 MORITA Hajime <morrita@google.com>

Unreviewed ChangeLog fix.

03:08 Changeset [88000] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test with different results in 32-bit and 64-bit.

  • platform/gtk/Skipped: Skipped test.
03:05 Changeset [87999] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-03 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Unref the SoupSession used by WebKitGtk+ at exit
https://bugs.webkit.org/show_bug.cgi?id=60165

WebKitGtk+ creates a SoupSession instance to handle network stuff
that is never freed. We should unref that object at exit time.

  • webkit/webkitglobals.cpp: (webkitExit): (webkitInit):
02:53 Changeset [87998] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Update platform specific expected files after r87873.

  • platform/qt/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
  • platform/qt/plugins/document-open-expected.txt: Added.
01:57 Changeset [87997] by pvarga@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt][V8] build fix.

01:36 Changeset [87996] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Test rebaseline for GTK after revision 87936.

  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
01:36 Changeset [87995] by dominicc@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that range input clones have the right kind of slider.
https://bugs.webkit.org/show_bug.cgi?id=61982

  • fast/html/clone-range-expected.txt: Added.
  • fast/html/clone-range.html: Added.
  • platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned range input sliders should be SliderThumbElements, not divs.
https://bugs.webkit.org/show_bug.cgi?id=61982

Test: fast/html/clone-range.html

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
01:22 Changeset [87994] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Csaba Osztrogonác.

[Qt] Organize the disabled features section in the Skipped list
https://bugs.webkit.org/show_bug.cgi?id=61994

Move all the tests for disabled features under the "Disabled
features" section in the Skipped list. Use the name of the build flags to
identify the features for better tracking.

  • platform/qt/Skipped:
00:47 Changeset [87993] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, unskipping tests, now passing after reverting r87901.

  • platform/gtk/Skipped: Unskipped 3 tests.
00:23 Changeset [87992] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Worker list is extended with a checkbox that makes inspector attach to each
new worker. Whenever a new worker context starts a new inspector window will
be opened for it.

Also worker agent and worker list will be updated when worker context is terminated.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::workerContextTerminated):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers): (WebCore::InspectorWorkerAgent::didStartWorkerContext): (WebCore::InspectorWorkerAgent::workerContextTerminated):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._workerTerminated): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype._openInspectorWindow): (WebInspector.WorkerManager.prototype.reset): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workersCleared): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked): (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
  • inspector/front-end/inspector.js: (WebInspector.reset):

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Notification about worker context termination are now sent to the inspector.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::workerContextDestroyed):
Note: See TracTimeline for information about the timeline view.