Timeline


and

06/09/11:

23:42 Changeset [88527] by mahesh.kulkarni@nokia.com
  • 3 edits in trunk/LayoutTests

2011-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTests/fast/history/history_reload.html failing
https://bugs.webkit.org/show_bug.cgi?id=62369

Unskipping. Generating click of button element in generic way.
Remove hardcoding of click co-ordinates to avoid native font differences.

  • fast/history/history_reload.html:
  • platform/qt/Skipped:
23:20 Changeset [88526] by macpherson@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=61495

No new tests required as no functionality changed.

  • css/CSSPrimitiveValueMappings.h: Support cast to/from Order
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): Convert from bool to enum type. (WebCore::CSSStyleSelector::applyProperty): Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
  • dom/Document.cpp: (WebCore::Document::setVisuallyOrdered): Change call to RenderStyle::setRTLOrdering using enum parameter.
  • rendering/style/RenderStyle.h: rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
  • rendering/style/RenderStyleConstants.h: Define enum type.
23:19 Changeset [88525] by macpherson@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61601

No new tests. No new functionality added / covered by existing tests.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EBorderStyle): Support CSSValueAuto as required by outline-style property. (WebCore::CSSPrimitiveValue::operator OutlineIsAuto): Add cast to new OutlineIsAuto enum.
  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialize handler for CSSPropertyOutlineStyle.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove old handler for CSSPropertyOutlineStyle.
  • rendering/style/OutlineValue.h: Use new OutlineIsAuto enum instead of bool.
  • rendering/style/RenderStyle.h: Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties. Use new OutlineIsAuto enum type.
  • rendering/style/RenderStyleConstants.h: Define new enum OutlineIsAuto.
23:17 Changeset [88524] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
https://bugs.webkit.org/show_bug.cgi?id=62418

No new tests / cleanup only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyDefaultBase::applyInheritValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::applyInitialValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::setValue): Wrapper for calling m_setter function pointer. (WebCore::ApplyPropertyDefaultBase::value): Wrapper for calling m_getter function pointer. (WebCore::ApplyPropertyDefaultBase::initial): Wrapper for calling m_initial function pointer. (WebCore::ApplyPropertyDefault::applyValue): Use new setValue function. (WebCore::ApplyPropertyLength::applyValue): Use new setValue function. (WebCore::ApplyPropertyWidth::applyValue): Use new setValue function.
23:16 Changeset [88523] by koz@chromium.org
  • 4 edits
    1 delete in trunk/Source/WebKit/chromium

2011-06-09 James Kozianski <koz@chromium.org>

Unreviewed, rolling out r88466.
http://trac.webkit.org/changeset/88466
https://bugs.webkit.org/show_bug.cgi?id=60059

Broke PPAPITest.URLLoader test on the chromium bots

  • WebKit.gyp:
  • WebKit.gypi:
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::loadAsynchronously):
  • tests/AssociatedURLLoaderTest.cpp: Removed.
22:54 Changeset [88522] by keishi@webkit.org
  • 1 edit in trunk/Examples/ChangeLog

Rollback 88521

22:49 Changeset [88521] by keishi@webkit.org
  • 1 edit in trunk/Examples/ChangeLog

test

21:43 Changeset [88520] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix: Corrected header spelling.

  • heap/OldSpace.h:
21:38 Changeset [88519] by ggaren@apple.com
  • 11 edits
    2 adds in trunk/Source/JavaScriptCore

2011-06-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Added OldSpace to the project
https://bugs.webkit.org/show_bug.cgi?id=62417


Currently unused.


Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
per-block flag for testing whether you're in NewSpace vs OldSpace.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: (JSC::MarkedBlock::inNewSpace): (JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in write barrier.
  • heap/NewSpace.cpp: (JSC::NewSpace::addBlock): (JSC::NewSpace::removeBlock):
  • heap/NewSpace.h: (JSC::NewSpace::forEachBlock): Added forEachBlock, to use for NewSpace-specific operations.
  • heap/OldSpace.cpp: Added. (JSC::OldSpace::OldSpace): (JSC::OldSpace::addBlock): (JSC::OldSpace::removeBlock):
  • heap/OldSpace.h: Added. (JSC::OldSpace::forEachBlock): New class for holding promoted blocks. Not in use yet.
20:52 Changeset [88518] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.

  • wtf/Platform.h:

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add a new class, GraphicsLayerEfl - not yet implemented.
Add ACCELERATED_COMPOSITING related files to CMakeLists.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Added. (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerEfl::GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::setNeedsDisplay): (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
  • platform/graphics/efl/GraphicsLayerEfl.h: Added.

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add functions for accelerated compositing to ChromeClientEfl.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::attachRootGraphicsLayer): (WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization): (WebCore::ChromeClientEfl::scheduleCompositingLayerSync): (WebCore::ChromeClientEfl::allowedCompositingTriggers):
  • WebCoreSupport/ChromeClientEfl.h:
20:45 Changeset [88517] by demarchi@webkit.org
  • 3 edits in trunk

2011-06-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Never let USER_AGENT defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=62410

This patch is similar to r88342, but sets WEBKIT_USER_AGENT_*
definitions only if that port defined it. A port might prefer to set it
in other place, e.g. a header that is part of the public API (like GTK
does).

By using #cmakedefine instead of #define, if that variable is not set
in CMake it will expand to:

/* #define WEBKIT_USER_AGENT_MAJOR_VERSION */

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:
19:50 Changeset [88516] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

Last attempt to make buildbot happy against crazy flakiness near inspector tests. :-/

  • platform/qt/Skipped: Disable all inspector tests until fix.
19:43 Changeset [88515] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Brent Fulgham.

[efl] Do not enable the encoding detector by default.
https://bugs.webkit.org/show_bug.cgi?id=61744

This should match the behaviour of other ports more closely, and makes
at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
19:30 Changeset [88514] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

One more attempt to make buildbot happy
against crazy flakiness near inspector tests. :-/

  • platform/qt/Skipped:
18:59 Changeset [88513] by ossy@webkit.org
  • 6 edits
    1 add in trunk

Unreviewed rolling out r88471, because it broke plugin tests on Qt.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventX11):
(NPP_GetValue):

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.

(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(executeScript):
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_stream_as_file):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
(webkit_test_plugin_print):
(keyEventToChar):
(webkit_test_plugin_handle_event):
(webkit_test_plugin_url_notify):
(webkit_test_plugin_get_value):
(webkit_test_plugin_set_value):
(NP_GetMIMEDescription):
(NP_Initialize):
(NP_Shutdown):
(NP_GetValue):

  • GNUmakefile.am:

LayoutTests:

  • platform/chromium-linux/plugins/mouse-events-expected.txt:
18:42 Changeset [88512] by jianli@chromium.org
  • 1 edit
    2 copies in branches/chromium/782

Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.

BUG=85659
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/7003106

18:31 Changeset [88511] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Mac] Unskip fast/forms/input-number-large-padding.html
https://bugs.webkit.org/show_bug.cgi?id=61845

It should work now because we don't use outer-spin-button anymore.

  • platform/mac/Skipped:
18:09 Changeset [88510] by jianli@chromium.org
  • 3 edits
    2 adds in trunk

Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.
18:08 Changeset [88509] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-09 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Remove expectations for passing tests.

  • platform/chromium/test_expectations.txt:
17:50 Changeset [88508] by jamesr@google.com
  • 12 edits in trunk/LayoutTests

2011-06-09 James Robinson <jamesr@chromium.org>

[chromium] Update some chromium gpu baselines

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/test_expectations.txt:
17:30 Changeset [88507] by jamesr@google.com
  • 4 edits in trunk

2011-06-09 James Robinson <jamesr@chromium.org>

[chromium] Mark the fullscreen directory as skipped
https://bugs.webkit.org/show_bug.cgi?id=62397

  • platform/chromium/test_expectations.txt:

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=62397

Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
even when the runtime setting was disabled.

  • features.gypi:
17:30 Changeset [88506] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Geoff Garen.

Fix geoff's review comments re static_cast.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

17:03 Changeset [88505] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by David Hyatt.

Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
https://bugs.webkit.org/show_bug.cgi?id=62400

No new tests; covered by existing fullscreen/full-screen-video-offset.html test.

  • rendering/RenderVideo.cpp: (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists. (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block. (WebCore::RenderVideo::offsetTop): Ditto. (WebCore::RenderVideo::offsetWidth): Ditto. (WebCore::RenderVideo::offsetHeight): Ditto.
  • rendering/RenderVideo.h: Added virtual overrides for the offset functions.
17:02 Changeset [88504] by ggaren@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

2011-06-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Factored MarkedBlock set management into a helper class with a fast case Bloom filter
https://bugs.webkit.org/show_bug.cgi?id=62413


SunSpider reports a small speedup.


This is in preparation for having ConservativeSet operate on arbitrary
sets of MarkedBlocks, and in preparation for conservative scanning
becoming proportionally more important than other GC activities.

  • heap/ConservativeRoots.cpp: (JSC::ConservativeRoots::add):
  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet directly, instead of a Heap, so we can operate on subsets of the Heap instead.


Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
is particularly important since we expect not to find our subject pointer
in the MarkedBlock hash, and hash misses are more expensive than typical
hash lookups because they have high collision rates.


No need for single-pointer add() to be public anymore, since nobody uses it.

  • heap/Heap.cpp: (JSC::Heap::markRoots):
  • heap/Heap.h: (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what ConservativeRoots relies on.


Nixed contains(), since nobody uses it anymore.

  • heap/MarkedBlock.h: (WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of the VM layout properties of MarkedBlocks.
  • heap/MarkedBlockSet.h: Added. (JSC::MarkedBlockSet::add): (JSC::MarkedBlockSet::remove): (JSC::MarkedBlockSet::recomputeFilter): (JSC::MarkedBlockSet::filter): (JSC::MarkedBlockSet::set):
  • heap/TinyBloomFilter.h: Added. (JSC::TinyBloomFilter::TinyBloomFilter): (JSC::TinyBloomFilter::add): (JSC::TinyBloomFilter::ruleOut): New helper class, used above.
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots): No need to specifically exclude values by tag -- the tiny bloom filter is already a register-register compare, so adding another "rule out" factor just slows things down.
16:46 Changeset [88503] by barraclough@apple.com
  • 7 edits in trunk

Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Oliver Hunt.

There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.

Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.

These errors result in three test-262 failures.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

  • runtime/JSArray.cpp:

(JSC::JSArray::put):
(JSC::JSArray::push):

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:
16:37 Changeset [88502] by lforschler@apple.com
  • 1 copy in tags/Safari-534.45

New tag.

16:37 Changeset [88501] by jamesr@google.com
  • 6 edits
    3 copies in branches/chromium/782

Merge 88496 - 2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

Tests that a layer that should clip its children actually does clip even when scrolled offscreen.

  • platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
  • platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
  • platform/chromium/compositing/scissor-out-of-viewport.html: Added.

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.

This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.

Test: platform/chromium/compositing/scissor-out-of-viewport.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):

BUG=84122
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7046081

16:36 Changeset [88500] by lforschler@apple.com
  • 1 edit in branches/safari-534-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp

real fix for 88481. (remove tabs)

16:35 Changeset [88499] by lforschler@apple.com
  • 1 delete in tags/Safari-534.45

Remove Tag.

16:33 Changeset [88498] by mrobinson@webkit.org
  • 7 edits in trunk

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

  • platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and end. This matches other ports. Only use GLib style early returns when checking the validity of GObjects. (DumpRenderTreeSupportGtk::hasComposition): Added. (DumpRenderTreeSupportGtk::compositionRange): Added. (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above. (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above. (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

Add callbacks to support hasMarkedText and markedRange and also clean up existing
TextInputController support.

  • DumpRenderTree/gtk/TextInputController.cpp: (setMarkedTextCallback): Accept parameters in terms of start and length, instead of start and end. This matches the other ports. Do not use GLib style early returns. (hasMarkedTextCallback): Added. (markedRangeCallback): Added. (insertTextCallback): Cleanup as described above. (unmarkTextCallback): Cleanup as described above. (firstRectForCharacterRangeCallback): Cleanup as described above. (selectedRangeCallback): Cleanup as described above.
16:04 Changeset [88497] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-06-09 Kenneth Russell <kbr@google.com>

Skipped new tests from r88489 on WebKit Win, since WebGL is not yet enabled.

  • platform/win/Skipped:
15:53 Changeset [88496] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

Tests that a layer that should clip its children actually does clip even when scrolled offscreen.

  • platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
  • platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
  • platform/chromium/compositing/scissor-out-of-viewport.html: Added.

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.

This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.

Test: platform/chromium/compositing/scissor-out-of-viewport.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):
15:53 Changeset [88495] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88486.
http://trac.webkit.org/changeset/88486
https://bugs.webkit.org/show_bug.cgi?id=62409

Broke chromium-win compile (Requested by jamesr on #webkit).

  • public/WebData.h:
  • public/WebPageSerializer.h:
  • src/WebData.cpp:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
15:53 Changeset [88494] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

15:49 Changeset [88493] by lforschler@apple.com
  • 1 copy in tags/Safari-534.45

New tag.

15:44 Changeset [88492] by lforschler@apple.com
  • 6 edits
    2 copies in branches/safari-534-branch

Merge r88468.

15:30 Changeset [88491] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88475.

15:23 Changeset [88490] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408

It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).

  • fullscreen/full-screen-video-offset-expected.txt: Removed.
  • fullscreen/full-screen-video-offset.html: Removed.

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408

It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).

  • dom/Element.cpp: (WebCore::adjustForLocalZoom):
  • dom/Element.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
15:02 Changeset [88489] by kbr@google.com
  • 12 edits
    6 adds in trunk

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
14:55 Changeset [88488] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add an ASSERT to HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=62403

This ASSERT was useful in investigating a re-entrancy bug. We should
keep it.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
14:48 Changeset [88487] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a regression from r88478.

Reviewed by Darin Adler.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
afterwards.

14:45 Changeset [88486] by jcivelli@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-06-09 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Page serializer APIs now use WebData instead of fetching the entire
resource contents.
https://bugs.webkit.org/show_bug.cgi?id=61908

  • public/WebData.h:
  • public/WebPageSerializer.h:
  • src/WebData.cpp: (WebKit::WebData::getSomeData):
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
14:24 Changeset [88485] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Mark tests failing after http://trac.webkit.org/changeset/88478/ as failing.

  • platform/chromium/test_expectations.txt: Added failing tests.
14:19 Changeset [88484] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88401.

14:18 Changeset [88483] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: support webaudio in chromium driver
https://bugs.webkit.org/show_bug.cgi?id=62226

  • Scripts/webkitpy/layout_tests/port/chromium.py:
14:11 Changeset [88482] by dglazkov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Update expectations.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Added.
  • platform/chromium-win/fullscreen/full-screen-video-offset-expected.txt: Added.
14:06 Changeset [88481] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88279.

13:53 Changeset [88480] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by James Robinson.

Web Inspector: Inspector layout tests - extract method for sending XHR
https://bugs.webkit.org/show_bug.cgi?id=62391

  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/network-test.js: (doXHR.xhr.onreadystatechange): (doXHR):
  • http/tests/inspector/network/network-size-sync.html:
13:33 Changeset [88479] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400

Adding test to cover the regression. The test actually uncovered
a bug in the way we handle alternate stylesheet and thus is
failing some parts.

  • fast/css/link-disabled-attr-expected.txt: Added.
  • fast/css/link-disabled-attr.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400

Test: fast/css/link-disabled-attr.html

Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!

The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState, replaced by m_isEnabledViaScript. (WebCore::HTMLLinkElement::setDisabled): Updated the logic after m_disabledState removal. It also matches the spec by forwarding the disabled state to our stylesheet if we have one. (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful handling of the disabledAttr. (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto. (WebCore::HTMLLinkElement::isAlternate): Ditto.
13:30 Changeset [88478] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387

Reviewed by Darin Adler.

No new test, since functionality is unchanged.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
then reverse the run vector for RTL.

13:29 Changeset [88477] by mitz@apple.com
  • 5 edits
    1 add in trunk

Source/JavaScriptCore: Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

  • wtf/Vector.h:

(WTF::Vector::reverse): Added

Tools: Added a test for Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
13:24 Changeset [88476] by dglazkov@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

Fold isShadowBoundary into isShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=62317

Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.

In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.

Refactoring, covered by existing tests.

  • css/CSSStyleSelector.cpp: (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
  • dom/Element.cpp: (WebCore::Element::isSpellCheckingEnabled): Ditto.
  • dom/Node.cpp: (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto. (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
  • dom/Node.h: (WebCore::Node::isContentElement): Added.
  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
  • dom/Position.cpp: (WebCore::Position::Position): Ditto.
  • dom/ShadowContentElement.h: (WebCore::ShadowContentElement::isContentElement): Added.
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): Ditto. (WebCore::visiblePositionAfterNode): Ditto.
  • page/DragController.cpp: (WebCore::asFileInput): Ditto.
  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Ditto.
13:05 Changeset [88475] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159

Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
12:52 Changeset [88474] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

  • fast/css/webkit-keyframes-crash-expected.txt: Added.
  • fast/css/webkit-keyframes-crash.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

Test: fast/css/webkit-keyframes-crash.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.
12:44 Changeset [88473] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Factored a bunch of Heap functionality into stand-alone functors
https://bugs.webkit.org/show_bug.cgi?id=62337


This is in preparation for making these functors operate on arbitrary
sets of MarkedBlocks.

  • debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Updated for type change and rename.
  • heap/HandleHeap.h: (JSC::HandleHeap::forEachStrongHandle): New function for iterating all strong handles, so we can play along in the functor game.
  • heap/Heap.cpp: (JSC::CountFunctor::CountFunctor::CountFunctor): (JSC::CountFunctor::CountFunctor::count): (JSC::CountFunctor::CountFunctor::returnValue): (JSC::CountFunctor::ClearMarks::operator()): (JSC::CountFunctor::ResetAllocator::operator()): (JSC::CountFunctor::Sweep::operator()): (JSC::CountFunctor::MarkCount::operator()): (JSC::CountFunctor::Size::operator()): (JSC::CountFunctor::Capacity::operator()): (JSC::CountFunctor::Count::operator()): (JSC::CountFunctor::CountIfGlobalObject::operator()): (JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty): (JSC::CountFunctor::TakeIfEmpty::operator()): (JSC::CountFunctor::TakeIfEmpty::returnValue): (JSC::CountFunctor::RecordType::RecordType): (JSC::CountFunctor::RecordType::typeName): (JSC::CountFunctor::RecordType::operator()): (JSC::CountFunctor::RecordType::returnValue): These functors factor out behavior that used to be in the functions below.

(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Factored out behavior into the functors above.

  • heap/Heap.h: (JSC::Heap::forEachProtectedCell): (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Added forEach* iteration templates. I chose functor-based templates instead of plain iterators because they're simpler to implement in this case and they require a lot less code at the call site.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::VoidFunctor::returnValue): Default parent class for trivial functors.

(JSC::MarkedBlock::forEachCell): Renamed forEach to forEachCell because
we have a few different kind of "for each" now.

  • runtime/JSGlobalData.cpp: (WTF::Recompile::operator()): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::recompileAllJSFunctions): Updated for type change and rename.
  • runtime/JSGlobalData.h: Removed globalObjectCount because it was unused.
12:41 Changeset [88472] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by David Hyatt.

Test for chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756

  • fast/css/fontMetric-border-radius-null-crash-expected.txt: Added.
  • fast/css/fontMetric-border-radius-null-crash.html: Added.
  • fast/css/fontMetric-webkit-border-end-width-null-crash-expected.txt: Added.
  • fast/css/fontMetric-webkit-border-end-width-null-crash.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by David Hyatt.

chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756

Tests: fast/css/fontMetric-border-radius-null-crash.html

fast/css/fontMetric-webkit-border-end-width-null-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update so that our FontFallbackList is allocated if we ever need it when applying our style rules.
12:30 Changeset [88471] by mrobinson@webkit.org
  • 5 edits
    2 deletes in trunk

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove a cr-linux expectation that no longer differs from the default
expectation.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Removed.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  • GNUmakefile.am: Update source list.
12:02 Changeset [88470] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
https://bugs.webkit.org/show_bug.cgi?id=62386

  • Platform/CoreIPC/Connection.h:
11:51 Changeset [88469] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-09 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213

When building Mac Chrome using Skia as the WebKit renderer,
add state to LocalCurrentGraphicsContext to convert the SkCanvas
context passed by WebKit into the CGContext needed by UI
rendering.

No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.

  • platform/mac/LocalCurrentGraphicsContext.h: Add SkiaBitLocker to create and release the converted CGContext. Add ContextContainer, a class for Skia to create and release the converted CGContext. If Skia is not used, the class has no effect.
  • platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): When building with Skia, create the CGContext before passing it on.

(WebCore::LocalCurrentGraphicsContext::cgContext):
Get the CGContext from the SkiaBitLocker, or the saved context,
as appropriate.

  • rendering/RenderThemeMac.mm: Get the CGContext from Skia conversion or native, as appropriate. Use the LocalCurrentGraphicsContext if there is one. Otherwise, add a ContextContainer to house the SkCanvas to CGContext conversion.

(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):

11:47 Changeset [88468] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

2011-06-02 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>

  • fullscreen/full-screen-video-offset-expected.txt: Added.
  • fullscreen/full-screen-video-offset.html: Added.

2011-06-02 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>

Test: fullscreen/full-screen-video-offset.html

When the video element is taken full-screen in the new element full-screen API, return the
offset width and height of the placeholder renderer which is filling in for the full-screen
element. To do so, override offsetWidth, Height, Left, and Top from Element. These are
non-virtual functions, so make them virtual.

  • dom/Element.cpp: (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
  • dom/Element.h: Made offset functions virtual.
  • html/HTMLMediaElement.cpp: (WebCore::elementPlaceholder): Added; utility function. (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the

Element function. Will be called directly via javascript.

(WebCore::HTMLMediaElement::offsetTop): Ditto.
(WebCore::HTMLMediaElement::offsetWidth): Ditto.
(WebCore::HTMLMediaElement::offsetHeight): Ditto.

  • html/HTMLMediaElement.h:
11:26 Changeset [88467] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-09 Chang Shu <cshu@webkit.org>

Unreviewed.

Unskip more passed tests after r88461 (bug 62381).

  • platform/qt-wk2/Skipped:
11:21 Changeset [88466] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

2011-06-09 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

The AssociatedURLLoader returns URL access errors synchronously. Use a timer to return such errors asynchronously. Also add unit tests for successful loads, same-origin restriction by default, and successful cross-origin loads.
https://bugs.webkit.org/show_bug.cgi?id=60059

  • WebKit.gyp:
  • WebKit.gypi:
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::ClientAdapter::enableErrorNotifications): (WebKit::AssociatedURLLoader::ClientAdapter::notifyError): (WebKit::AssociatedURLLoader::loadAsynchronously):
  • tests/AssociatedURLLoaderTest.cpp: Added. (WebKit::TestWebFrameClient::cancelledError): (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): (WebKit::AssociatedURLLoaderTest::SetUp): (WebKit::AssociatedURLLoaderTest::TearDown): (WebKit::AssociatedURLLoaderTest::serveRequests): (WebKit::AssociatedURLLoaderTest::createAssociatedURLLoader): (WebKit::AssociatedURLLoaderTest::willSendRequest): (WebKit::AssociatedURLLoaderTest::didSendData): (WebKit::AssociatedURLLoaderTest::didReceiveResponse): (WebKit::AssociatedURLLoaderTest::didDownloadData): (WebKit::AssociatedURLLoaderTest::didReceiveData): (WebKit::AssociatedURLLoaderTest::didReceiveCachedMetadata): (WebKit::AssociatedURLLoaderTest::didFinishLoading): (WebKit::AssociatedURLLoaderTest::didFail): (WebKit::TEST_F):
11:21 Changeset [88465] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-09 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721

The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
calls to mean the plugin handled the event.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Return 0 for each event on windows.
11:19 Changeset [88464] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-09 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: behavior of undefined value in record
https://bugs.webkit.org/show_bug.cgi?id=62371

  • storage/indexeddb/value-undefined-expected.txt: Added.
  • storage/indexeddb/value-undefined.html: Added.
11:16 Changeset [88463] by andreas.kling@nokia.com
  • 22 edits
    2 deletes in trunk/Source/WebKit2

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

[Qt][WK2] Remove usage of deprecated CoreIPC functions.
https://bugs.webkit.org/show_bug.cgi?id=62290

Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
and guarded by ENABLE(TILED_BACKING_STORE).

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Prune deleted files from build system.
  • Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete, this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::invalidate): (WebKit::DrawingAreaProxy::snapshotTaken): (WebKit::DrawingAreaProxy::tileUpdated): (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by TiledDrawingAreaProxy to DrawingAreaProxy.
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): (WebKit::DrawingArea::cancelTileUpdate): (WebKit::DrawingArea::requestTileUpdate): (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea to DrawingArea.
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage() and didReceiveSyncMessage().
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::tileUpdated): (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage() into functions.

(WebKit::TiledDrawingAreaProxy::removeTile):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.

  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::cancelTileUpdate): (WebKit::TiledDrawingArea::requestTileUpdate): (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaProxyLegacy.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaLegacy.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
  • WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make CoreIPC message handlers explicitly virtual.
11:14 Changeset [88462] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Generate correct header conditionals in message receivers.
https://bugs.webkit.org/show_bug.cgi?id=62379

Given a *.messages.in file like this:

Foo(AwesomeObject o)
#if ENABLE(ESOTERIC_FEATURE)
Bar(AwesomeObject o)
#endif

messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
This breaks the build on platforms without that defined.

Furthermore, if two messages guarded by different conditionals both pull in the same
header, only the last conditional will be applied, for example:

#if ENABLE(ESOTERIC_FEATURE)
Foo(AwesomeObject o)
#endif
#if ENABLE(MYSTERIOUS_FEATURE)
Bar(AwesomeObject o)
#endif

Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should

check #if ENABLE(ESOTERIC_FEATURE)
ENABLE(MYSTERIOUS_FEATURE).

Change the generator to consider all conditionals for a given header file.
Also consider conditionals for reply parameters.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
11:09 Changeset [88461] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-09 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381

Unskip passed tests.

  • platform/qt-wk2/Skipped:

2011-06-09 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381

Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
QWKPagePrivate::isViewFocused() will check it later.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
11:05 Changeset [88460] by thakis@chromium.org
  • 7 edits in branches/chromium/782/Source

Merge 88396 - 2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

  • wtf/Platform.h:

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7134051

11:04 Changeset [88459] by thakis@chromium.org
  • 5 edits
    2 copies in branches/chromium/782/Source/WebCore

Merge 88286 - 2011-06-07 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
  • WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
  • platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7044088

10:49 Changeset [88458] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-09 Dave Tapuska <dtapuska@rim.com>

Reviewed by Daniel Bates.

PingLoader destructor could dereference 0 if the Resource
Handle creation failed.

https://bugs.webkit.org/show_bug.cgi?id=62304

  • loader/PingLoader.cpp: (WebCore::PingLoader::~PingLoader):
09:20 Changeset [88457] by thakis@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-06-09 Nico Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a few destructors private.
https://bugs.webkit.org/show_bug.cgi?id=62341

No intended functionality change.

  • src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
  • src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
09:15 Changeset [88456] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-06-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Make indexForVisiblePosition and isSelectableElement static.
https://bugs.webkit.org/show_bug.cgi?id=62329

This protects us when converting frame->selection->start() or end()
to VisiblePosition which blows away the RenderTextControl from
underneath (due to layout update).

Test: fast/forms/text-control-selection-crash.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:

2011-06-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Tests that setting selection on a text control does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62329

  • fast/forms/text-control-selection-crash-expected.txt: Added.
  • fast/forms/text-control-selection-crash.html: Added.
09:05 Changeset [88455] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-09 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix the in-tree build on Linux
https://bugs.webkit.org/show_bug.cgi?id=62378

In case of an in-tree build qmake generates defect prl dependencies for
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.

  • QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
08:52 Changeset [88454] by benm@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-09 Ben Murdoch <benm@google.com>

Reviewed by Yury Semikhatsky.

Build break in ScriptProfile.cpp and inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=62373

No new tests - build fix only.

  • bindings/v8/ScriptProfile.cpp: Add necessary guards.
  • bindings/v8/ScriptProfile.h: ditto.
08:19 Changeset [88453] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
https://bugs.webkit.org/show_bug.cgi?id=62298

  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
07:53 Changeset [88452] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r88447.

  • platform/qt/Skipped:
07:44 Changeset [88451] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] Speculative buildfix after r88286.

  • platform/graphics/IntPoint.h:
07:28 Changeset [88450] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

  • platform/qt/Skipped: Add inspector/profiler/detailed-heapshots-comparison-show-next.html.
07:24 Changeset [88449] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] eventSender.keyDown is unimplemented

  • platform/mac-wk2/Skipped: Add fast/dom/shadow/tab-order-iframe-and-shadow.html.
07:12 Changeset [88448] by mikelawther@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-09 Mike Lawther <mikelawther@chromium.org>

Reviewed by Kent Tamura.

Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276

Set the CSSParserString for the calc functions.

  • css3/calc/regression-62276-expected.txt: Added.
  • css3/calc/regression-62276.html: Added.

2011-06-09 Mike Lawther <mikelawther@chromium.org>

Reviewed by Kent Tamura.

Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276

Set the CSSParserString for the calc functions.

Test: css3/calc/regression-62276.html

  • css/CSSParser.cpp: (WebCore::CSSParser::lex):
07:11 Changeset [88447] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r88393): Tests fail on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=62374

  • platform/qt/Skipped: Add editing/selection/move-by-word-visually-others.html and

editing/selection/move-by-word-visually-single-space-sigle-line.html until fix.

07:06 Changeset [88446] by dominicc@chromium.org
  • 11 edits in trunk

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

Unskip fast/harness/internals-object.html

  • platform/qt/Skipped:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
and others. The only alternative seems like a compile time guard which we would have to teach the bots about.

  • CodeGenerators.pri:
  • WebCore.pri:
  • WebCore.pro:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::injectInternalsObject):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::initJSObjects):
06:54 Changeset [88445] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427

  • platform/qt-wk2/Skipped: Unskip passing tests after r88435.
05:42 Changeset [88444] by loislo@chromium.org
  • 5 edits in trunk/Source

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.
05:09 Changeset [88443] by commit-queue@webkit.org
  • 9 edits
    6 deletes in trunk

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368

New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Removed.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Removed.
  • platform/mac-wk2/Skipped:

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368

New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
04:56 Changeset [88442] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

  • platform/qt/Skipped: Skip 3 inspector tests to make buildbot happy.
04:10 Changeset [88441] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: New flakiness in styles tests
https://bugs.webkit.org/show_bug.cgi?id=62309

  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-source-lines-inline.html:
03:26 Changeset [88440] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/Source/WebKit2

2011-06-09 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
https://bugs.webkit.org/show_bug.cgi?id=62363

  • UIProcess/API/efl/PageClientImpl.cpp: Added. (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::~PageClientImpl): (WebKit::PageClientImpl::createDrawingAreaProxy): (WebKit::PageClientImpl::setViewNeedsDisplay): (WebKit::PageClientImpl::displayView): (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow): (WebKit::PageClientImpl::processDidCrash): (WebKit::PageClientImpl::didRelaunchProcess): (WebKit::PageClientImpl::pageClosed): (WebKit::PageClientImpl::toolTipChanged): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::clearAllEditCommands): (WebKit::PageClientImpl::canUndoRedo): (WebKit::PageClientImpl::executeUndoRedo): (WebKit::PageClientImpl::convertToDeviceSpace): (WebKit::PageClientImpl::convertToUserSpace): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::customRepresentationZoomFactor): (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): (WebKit::PageClientImpl::flashBackingStoreUpdates): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): (WebKit::PageClientImpl::userSpaceScaleFactor):
  • UIProcess/API/efl/PageClientImpl.h: Added. (WebKit::PageClientImpl::create): (WebKit::PageClientImpl::viewObject): (WebKit::PageClientImpl::page):
  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebPageProxyEfl.cpp: Added. (WebKit::WebPageProxy::viewObject): (WebKit::WebPageProxy::standardUserAgent): (WebKit::WebPageProxy::getEditorCommandsForKeyEvent): (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches):
03:06 Changeset [88439] by tkent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-09 Kent Tamura <tkent@chromium.org>

[Chromium] Leopard rebaseline for thumbslider-no-parent-slider.html.

  • platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Added.
02:39 Changeset [88438] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-09 Ryosuke Niwa <rniwa@webkit.org>

More Chromium Mac test expectation updates.

  • platform/chromium/test_expectations.txt:
02:36 Changeset [88437] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
https://bugs.webkit.org/show_bug.cgi?id=62362

The mac bots are failing inspector tests. We don't know why yet.
So for now, turning run-webkit-tests off for the mac-ews.

Also noticed that due to the wrong variable name the cr-linux
bots weren't running tests!

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
02:21 Changeset [88436] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-09 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac test expectation updates.

  • platform/chromium/test_expectations.txt:
01:47 Changeset [88435] by zherczeg@webkit.org
  • 4 edits in trunk

[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-09
Reviewed by Csaba Osztrogonac.

Tools:

Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
Since the Qt port should eventually go to QRawFont, this issue will be resolved
in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
needed for the workaround.

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::platformInitialize):

LayoutTests:

Unskipping canvas tests for WebKit2-Qt.

  • platform/qt-wk2/Skipped:
01:41 Changeset [88434] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160

  • fast/parser/document-write-onload-clear-expected.txt: Added.
  • fast/parser/document-write-onload-clear.html: Added.

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160

When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.

Test: fast/parser/document-write-onload-clear.html

  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
00:42 Changeset [88433] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-09 James Robinson <jamesr@chromium.org>

Fix chromium build on build.webkit.org builders.

  • features.gypi:
00:35 Changeset [88432] by mario@webkit.org
  • 7 edits
    4 adds in trunk

2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855

New layout test and expected results to check the new function.

  • accessibility/platform-name.html: Added.
  • platform/gtk/accessibility/platform-name-expected.txt: Added.
  • platform/mac/accessibility/platform-name-expected.txt: Added.
  • platform/win/accessibility/platform-name-expected.txt: Added.

2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855

Patch for adding 'platformName' static property to DRT's
LayoutController and provide platform specific implementations.

In principle, this feature will be only of interest for writing
accessibility tests, so that's why it's only implemented in the
Mac, Gtk and Win platforms.

  • DumpRenderTree/LayoutTestController.h: New method platformName().
  • DumpRenderTree/LayoutTestController.cpp: (getPlatformNameCallback): New callback for 'platformName'. (LayoutTestController::staticValues): New static property.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::platformName): Implemented.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::platformName): Implemented.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::platformName): Implemented.

06/08/11:

23:55 Changeset [88431] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-08 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSPrimitiveValue support cast to EVerticalAlign.
https://bugs.webkit.org/show_bug.cgi?id=62356

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
23:47 Changeset [88430] by jamesr@google.com
  • 4 edits in branches/chromium/782/Source

Merge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::create):

TBR=junov@chromium.org
BUG=85309
Review URL: http://codereview.chromium.org/7046071

23:40 Changeset [88429] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::create):
23:38 Changeset [88428] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349

r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
significant performance regression across many chromium page cyclers, for example
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.

This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
logic.

  • platform/graphics/FontCache.cpp:
23:37 Changeset [88427] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 James Robinson <jamesr@chromium.org>

Hopefully last change to features.gypi - set ENABLE_REGISTER_PROTOCOL_HANDLER based off of the the variable set
in chromium's common.gypi. Should green up the chromium linux tester on build.webkit.org.

  • features.gypi:
23:07 Changeset [88426] by mikelawther@chromium.org
  • 2 edits in trunk/Tools

2011-06-08 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Add mikelawther to committers.py
https://bugs.webkit.org/show_bug.cgi?id=62354

  • Scripts/webkitpy/common/config/committers.py:
22:48 Changeset [88425] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 James Robinson <jamesr@chromium.org>

Set ENABLE_REGISTER_PROTOCOL_HANDLER=1 for chromium. I didn't mean to turn that off...

  • features.gypi:
22:43 Changeset [88424] by jamesr@google.com
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-08 James Robinson <jamesr@chromium.org>

[chromium] Update the chromium-within-WebKit revision to r88481
https://bugs.webkit.org/show_bug.cgi?id=62353

  • DEPS:
22:37 Changeset [88423] by tkent@chromium.org
  • 7 edits
    1 copy
    5 adds
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline for r87881 and r88415.

  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
22:35 Changeset [88422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add stubs to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=62263

This change add stub implementations for all WebWidget functions. Having stub methods should make it easier to add new functions to the class without breaking Chromium.

  • public/WebWidget.h: (WebKit::WebWidget::close): (WebKit::WebWidget::size): (WebKit::WebWidget::resize): (WebKit::WebWidget::animate): (WebKit::WebWidget::layout): (WebKit::WebWidget::paint): (WebKit::WebWidget::composite): (WebKit::WebWidget::themeChanged): (WebKit::WebWidget::handleInputEvent): (WebKit::WebWidget::mouseCaptureLost): (WebKit::WebWidget::setFocus): (WebKit::WebWidget::setComposition): (WebKit::WebWidget::confirmComposition): (WebKit::WebWidget::compositionRange): (WebKit::WebWidget::textInputType): (WebKit::WebWidget::caretOrSelectionBounds): (WebKit::WebWidget::selectionRange): (WebKit::WebWidget::caretOrSelectionRange): (WebKit::WebWidget::setTextDirection): (WebKit::WebWidget::isAcceleratedCompositingActive):
22:33 Changeset [88421] by hayato@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Dimitri Glazkov.

A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410

Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.

The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.

A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.

  • fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
  • fast/dom/shadow/tab-order-iframe-and-shadow.html: Added.

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Dimitri Glazkov.

A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410

Test: fast/dom/shadow/tab-order-iframe-and-shadow.html

Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.

The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.

A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.

  • page/FocusController.cpp: (WebCore::shadowRoot): (WebCore::isTreeScopeOwner): (WebCore::FocusController::deepFocusableNode): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::FocusController::findFocusableNodeAcrossTreeScope): (WebCore::FocusController::findFocusableNode): (WebCore::FocusController::nextFocusableNode): (WebCore::FocusController::previousFocusableNode): (WebCore::FocusController::ownerOfTreeScope):
  • page/FocusController.h:
21:56 Changeset [88420] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-06-08 Kent Tamura <tkent@chromium.org>

[Chromium] Fix a typo.

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::draw):
21:50 WebKit Team edited by takano.naoki@gmail.com
(diff)
21:49 WebKit Team edited by takano.naoki@gmail.com
(diff)
21:47 Changeset [88419] by tkent@chromium.org
  • 4 edits in trunk/Tools

2011-06-08 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Support vertical sliders in Windows DRT
https://bugs.webkit.org/show_bug.cgi?id=62352

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::draw): Paint VerticalSliderThumbType and VerticalSliderTrackType.
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h: Add VerticalSliderTrackType and VerticalSliderThumbType.
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar): Convert Windows identifiers to the internal identifiers for vertical sliders.
20:55 Changeset [88418] by hayato@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Makes sure that document.activeElement won't be an element in shadow root.

https://bugs.webkit.org/show_bug.cgi?id=61413

  • fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt: Added.
  • fast/dom/shadow/activeelement-should-be-shadowhost.html: Added.

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Makes sure that document.activeElement won't be an element in shadow root.

https://bugs.webkit.org/show_bug.cgi?id=61413

Test: fast/dom/shadow/activeelement-should-be-shadowhost.html

  • html/HTMLDocument.cpp: (WebCore::focusedFrameOwnerElement): (WebCore::HTMLDocument::activeElement):
20:42 Changeset [88417] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2011-06-08 Kent Tamura <tkent@chromium.org>

[Mac][GTK][Qt] Rebaseline for r88415, and remove old images.

  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt:
19:09 Changeset [88416] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Add TIMEOUT to styles-disable-then-change.html.

  • platform/chromium/test_expectations.txt:
19:06 Changeset [88415] by tkent@chromium.org
  • 21 edits in trunk

Allow drawing a slider thumb for any nodes.
https://bugs.webkit.org/show_bug.cgi?id=62196

Reviewed by Dimitri Glazkov.

Source/WebCore:

RenderObject::node() should provide various information which is
necessary for rendering. We don't need to refer the parent renderer.

  • dom/Node.cpp:

(WebCore::Node::focusDe1egate): Added.

  • dom/Node.h: Added a declaration.
  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

Added an overload of toParentMediaElement() with Node* parameter.

  • html/shadow/MediaControlElements.h:

(WebCore::toParentMediaElement): ditto.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isEnabledFormControl):

Returns the status of the host node.

(WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
(WebCore::SliderThumbElement::focusDe1egate):

Returns the host node so that RenderTheme::isFocused() returns true.

(WebCore::SliderThumbElement::detach): Style nit.
(WebCore::SliderThumbElement::hostInput):

Make it const because it is called by const functions.

  • html/shadow/SliderThumbElement.h:
    • Remove inDragMode()
    • Update declarations
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintMediaSliderThumb):

Use Node::shadowAncestorNode() instead of RenderObject::parent() to
support deeper thumb nodes.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSliderThumb): ditto.
(WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::inDragMode):

SliderThumbElement::inDragMode() was removed, and Node::active() has
the same information.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Remove isSlider() checks.
(WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::paintSliderThumb):

isPressed() is enough.

  • rendering/RenderThemeChromiumWin.cpp: isEnabled(), isFocused(), and isPressed() are enough.

(WebCore::RenderThemeChromiumWin::determineSliderThumbState):
(WebCore::RenderThemeChromiumWin::determineClassicState):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb):

  • Remove isSlider() check.
  • Passing 'o' to udpateFooState functions is enough.
  • isPressed() is enough.
  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintSliderThumb):

We don't need special handling anymore.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::determineSliderThumbState):

isEnabled(), isFocused(), and isPressed() are enough.

LayoutTests:

The behavior was changed. We should show slider thumbs for any nodes with
-webkit-appearance:slidertumb-horizontal/vertical.

  • fast/forms/thumbslider-no-parent-slider.html:
  • platform/chromium/test_expections.txt: Expect to fail with thumbslider-no-parent-slider.html.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
18:40 Changeset [88414] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Revert r88412 because it introduced syntax
errors into test_expectations.txt.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [88413] by alokp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 88403 - 2011-06-08 Brian Salomon <bsalomon@google.com> Reviewed by James Robinson. Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO. https://bugs.webkit.org/show_bug.cgi?id=62318 Chromium-only crash Failures takes multiple seconds to occur, relying on JS garbage-collection to occur http://www.hotbazooka.com/privatejoe-large * platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
TBR=bsalomon@google.com
BUG=85157
Review URL: http://codereview.chromium.org/7044078

18:11 Changeset [88412] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Fix expectations for
styles-disable-then-change.html.

  • platform/chromium/test_expectations.txt:
17:34 Changeset [88411] by abarth@webkit.org
  • 5 edits
    4 adds in trunk

2011-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use after free in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=62160

Test that we don't trigger asserts when re-entering the parser from
tree construction.

  • fast/parser/document-write-onload-nesting-expected.txt: Added.
  • fast/parser/document-write-onload-nesting.html: Added.
  • fast/parser/document-write-onload-ordering-expected.txt: Added.
  • fast/parser/document-write-onload-ordering.html: Added.
    • The exact ordering of the script execution here differs a bit between browsers. For example, Firefox executes the scripts in a slightly different order because Firefox runs the parser on a separate thread (and therefore cannot be re-entered from tree construction). If/when we move the parser off the main thread, we're likely to change the ordering here a bit, which should be ok.

2011-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

constructTreeFromToken can re-enter parser, causing ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=62160

This patch clears the HTMLToken before constructing the tree from the
token, putting the HTMLDocumentParser in a good state to be re-entered.

Tests: fast/parser/document-write-onload-nesting.html

fast/parser/document-write-onload-ordering.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLToken.h: (WebCore::HTMLToken::isUninitialized):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken):
17:20 Changeset [88410] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 Kent Tamura <tkent@chromium.org>

Fix Qt build for r88405.
https://bugs.webkit.org/show_bug.cgi?id=62208

  • platform/qt/RenderThemeQt.h:
17:00 Changeset [88409] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Add PASS expectations to two tests that have been passing on
build.webkit.org Chromium Linux bot.

  • platform/chromium/test_expectations.txt:
16:58 Changeset [88408] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, more inspector flakiness.

  • platform/chromium/test_expectations.txt:
16:55 Changeset [88407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88404.
http://trac.webkit.org/changeset/88404
https://bugs.webkit.org/show_bug.cgi?id=62342

broke win and mac build (Requested by tonywork on #webkit).

16:54 Changeset [88406] by vangelis@chromium.org
  • 2 edits
    3 copies in branches/chromium/782

Merge 88288 - 2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7044072

16:45 Changeset [88405] by tkent@chromium.org
  • 31 edits in trunk/Source/WebCore

2011-06-08 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
https://bugs.webkit.org/show_bug.cgi?id=62208

Change the argument type of RenderTheme::adjustSliderThumbSize() and
RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.

Also, each of adjustSliderThumbStyle() overrides calls RenderTheme
adjustSliderThumbStyle() for future changes.

No new tests. This is a refactoring and should not change any behavior.

  • html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto. (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto. (WebCore::RenderThemeQt::adjustSliderThumbSize):
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControls.h:
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControlsChromium.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment. (WebCore::RenderTheme::adjustSliderThumbSize):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle(). (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle(). (WebCore::RenderThemeSafari::adjustSliderThumbSize):
  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize):
  • rendering/RenderThemeWin.h:
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
  • rendering/RenderThemeWinCE.h:
16:37 Changeset [88404] by evan@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-08 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

[chromium] use gyp 'settings' type for settings target
https://bugs.webkit.org/show_bug.cgi?id=62323

The 'settings' gyp target type is for targets that exist solely
for their settings (no build rules). The comment above this target
says it's for this, but it incorrectly uses 'none'.

16:25 Changeset [88403] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 Brian Salomon <bsalomon@google.com>

Reviewed by James Robinson.

Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
https://bugs.webkit.org/show_bug.cgi?id=62318

Chromium-only crash
Failures takes multiple seconds to occur, relying on JS garbage-collection to occur
http://www.hotbazooka.com/privatejoe-large

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
16:13 Changeset [88402] by simonjam@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-06-08 James Simonsen <simonjam@chromium.org>

Unreviewed, move generic test expectation to right place.

  • fast/gradients/crash-on-degenerate-gradient-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/crash-on-degenerate-gradient-expected.txt.
16:02 Changeset [88401] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62332>
<rdar://problem/9355199>
[WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _resendKeyDownEvent:]):
Renamed self-protecting RetainPtr from "protect" to "protector" so it's a noun.
(-[WKView _setDragImage:at:linkDrag:]):
Added a self-protecting RetainPtr.

16:00 Changeset [88400] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-08 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

RenderEmbeddedObject::getReplacementTextGeometry
https://bugs.webkit.org/show_bug.cgi?id=62313

Replace the last use of tx, ty with IntPoint.

Covered by existing tests.

  • platform/graphics/FloatRect.h: (WebCore::FloatRect::move): (WebCore::FloatRect::moveBy):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced): (WebCore::RenderEmbeddedObject::getReplacementTextGeometry): (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
  • rendering/RenderEmbeddedObject.h:
15:51 Changeset [88399] by xan@webkit.org
  • 9 edits
    1 move
    5 adds
    1 delete in trunk/Source/WebKit/gtk

2011-06-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebKitSpellChecker interface and implementations
https://bugs.webkit.org/show_bug.cgi?id=61787

Expose the spell checking functionality to the UAs through a
generic interface, and provide a default Enchant-based
implementation. On top of allowing UAs to use this functionality
this makes it possible to change the spell checking backend at
runtime.

  • GNUmakefile.am: add new files.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::EditorClient): set the spell checker using the new classes.
  • WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
  • WebCoreSupport/TextCheckerClientGtk.cpp: Added (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just chain up to the WebKitSpellChecker. (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto. (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto. (WebKit::TextCheckerClientGtk::learnWord): ditto. (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto. (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto. (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto. (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
  • WebCoreSupport/TextCheckerClientGtk.h: store a reference to the WebKitSpellChecker.
  • webkit/webkit.h: the webkitspellchecker.h header is public.
  • webkit/webkitdefines.h: defines for spell checker interface.
  • webkit/webkitglobals.cpp: Add APIs to get and set the global spell checker. (webkit_get_spell_checker): get API. (webkit_set_spell_checker): set API.
  • webkit/webkitglobals.h:
  • webkit/webkitspellchecker.cpp: Added. Spell checking interface.
  • webkit/webkitspellchecker.h: Added.
  • webkit/webkitspellcheckerenchant.cpp: Added. Default implemention, uses Enchant library.
  • webkit/webkitspellcheckerenchant.h: Added.
15:38 Changeset [88398] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-08 Tim Horton <timothy_horton@apple.com>

Reviewed by Ryosuke Niwa.

Use correct CFURLStorageSessionRef definition on Leopard, as
we created an inconsistency in const-ness between
WebCoreSystemInterface.h and these two files in the case
of Leopard only.
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:
15:35 Changeset [88397] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key sort order across types
https://bugs.webkit.org/show_bug.cgi?id=62299

  • storage/indexeddb/key-sort-order-across-types-expected.txt: Added.
  • storage/indexeddb/key-sort-order-across-types.html: Added.
15:24 Changeset [88396] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

  • wtf/Platform.h:

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint):
15:07 Changeset [88395] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key sort order for Date objects
https://bugs.webkit.org/show_bug.cgi?id=62300

  • storage/indexeddb/key-sort-order-date-expected.txt: Added.
  • storage/indexeddb/key-sort-order-date.html: Added.
14:54 Changeset [88394] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-08 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add faster lookup cache for multi character identifiers
https://bugs.webkit.org/show_bug.cgi?id=62327

Add a non-hash lookup for mutiple character identifiers. This saves us from
adding repeated identifiers to the ParserArena's identifier list as people
tend to not start all their variables and properties with the same character
and happily identifier locality works in our favour.

  • parser/ParserArena.h: (JSC::IdentifierArena::isEmpty): (JSC::IdentifierArena::clear): (JSC::IdentifierArena::makeIdentifier):
14:53 Changeset [88393] by xji@chromium.org
  • 1 edit
    2 moves
    3 adds in trunk/LayoutTests

2011-06-08 Xiaomei Ji <xji@chromium.org>

Split move-by-word-visually.html into 2 tests since the test is continuing growing and caused
time-out in Snowleopard Intel Leaks.

We will need to do profiling to improve hot code path performance later.

  • editing/selection/move-by-word-visually-expected.txt: Removed.
  • editing/selection/move-by-word-visually-others-expected.txt: Added.
  • editing/selection/move-by-word-visually-others.html: Added.
  • editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-expected.txt.
  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually.html.
  • editing/selection/move-by-word-visually.html: Removed.
  • editing/selection/resources/move-by-word-visually.js: Added. (): (flushLog): (fold): (logPositions): (nodeOfWordBreak): (logWordBreak): (positionEqualToWordBreak): (validateData): (collectWordBreaks): (setPosition): (moveByWord): (moveByWordOnEveryChar): (moveByWordForEveryPosition): (runMoveLeftRight):
14:53 Changeset [88392] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for FloatPoint3D.

Together with Viatcheslav Ostapenko.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
14:45 Changeset [88391] by japhet@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-06 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove all knowledge of CachedResourceRequests from
CachedResourceLoader. This puts the full burden of
canceling these requests on DocumentLoader (via
SubresourceLoader), and makes a CachedResourceRequest
an OwnPtr in CachedResource.

https://bugs.webkit.org/show_bug.cgi?id=62308

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::load): (WebCore::CachedResource::stopLoading):
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::loadDone):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::CachedResourceRequest): (WebCore::CachedResourceRequest::~CachedResourceRequest): (WebCore::CachedResourceRequest::load): (WebCore::CachedResourceRequest::didFinishLoading): (WebCore::CachedResourceRequest::didFail): (WebCore::CachedResourceRequest::didReceiveResponse): (WebCore::CachedResourceRequest::end):
  • loader/cache/CachedResourceRequest.h:
14:39 Changeset [88390] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2011-06-08 Mike Reed <reed@google.com>

Reviewed by James Robinson.

[Skia] check for null-shader from gradient factory
https://bugs.webkit.org/show_bug.cgi?id=62319

  • platform/chromium-linux/fast/gradients/crash-on-degenerate-gradient-expected.txt: Added.

2011-06-08 Mike Reed <reed@google.com>

Reviewed by James Robinson.

[Skia] check for null-shader from gradient factory
https://bugs.webkit.org/show_bug.cgi?id=62319

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
14:39 Changeset [88389] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Took some responsibilities away from NewSpace
https://bugs.webkit.org/show_bug.cgi?id=62325


NewSpace is basically just an allocator now.


Heap acts as a controller, responsible for managing the set of all
MarkedBlocks.


This is in preparation for moving parts of the controller logic into
separate helper classes that can act on arbitrary sets of MarkedBlocks
that may or may not be in NewSpace.

  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::allocate): (JSC::Heap::markRoots): (JSC::Heap::clearMarks): (JSC::Heap::sweep): (JSC::Heap::objectCount): (JSC::Heap::size): (JSC::Heap::capacity): (JSC::Heap::collect): (JSC::Heap::resetAllocator): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlocks): (JSC::Heap::shrink): Moved the set of MarkedBlocks from NewSpace to Heap, along with all functions that operate on the set of MarkedBlocks. Also moved responsibility for deciding whether to allocate a new MarkedBlock, and for allocating it.
  • heap/Heap.h: (JSC::Heap::contains): (JSC::Heap::forEach): Ditto.
  • heap/NewSpace.cpp: (JSC::NewSpace::addBlock): (JSC::NewSpace::removeBlock): (JSC::NewSpace::resetAllocator):
  • heap/NewSpace.h: (JSC::NewSpace::waterMark): (JSC::NewSpace::allocate): Ditto.
14:38 Changeset [88388] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-06-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add a short-flag for --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=62321

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:27 Changeset [88387] by kbr@google.com
  • 9 edits
    6 adds in trunk

2011-06-08 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/mac-wk2/Skipped:

2011-06-08 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
14:16 Changeset [88386] by jamesr@google.com
  • 4 edits
    3 adds in trunk

2011-06-08 John Bauman <jbauman@chromium.org>

Reviewed by James Robinson.

Only draw portions of tiles in contentRect
https://bugs.webkit.org/show_bug.cgi?id=62243

  • platform/chromium/test_expectations.txt:
  • compositing/repaint/shrink-layer.html: Added.
  • compositing/repaint/shrink-layer-expected.png: Added.
  • compositing/repaint/shrink-layer-expected.txt: Added.

2011-06-08 John Bauman <jbauman@chromium.org>

Reviewed by James Robinson.

Only draw portions of tiles in contentRect
https://bugs.webkit.org/show_bug.cgi?id=62243

Old garbage data can remain in tiles, so make sure to draw only those
portions that are supposed to be drawn.

Test: compositing/repaint/shrink-layer.html

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
14:15 Changeset [88385] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-08 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBlock::isPointInOverflowControl to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62312

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
  • rendering/RenderListBox.h:
14:02 Changeset [88384] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: odd value datatypes
https://bugs.webkit.org/show_bug.cgi?id=62315

  • storage/indexeddb/values-odd-types-expected.txt: Added.
  • storage/indexeddb/values-odd-types.html: Added.
14:01 Changeset [88383] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: don't turn the tree red when there are new passes
https://bugs.webkit.org/show_bug.cgi?id=62311

Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
to match commandComplete.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:43 Changeset [88382] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Fix clang issue, virtual function const mismatch
https://bugs.webkit.org/show_bug.cgi?id=62307

No new tests. Built with clang & ran layout tests.

  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
13:42 Changeset [88381] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-08 Tom Hudson <tomhudson@google.com>

Reviewed by Mihai Parparita.

Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=60964

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Add 'Sort tests by metric' link.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: (disableSorting): Activate 'Sort tests by metric' link. (enableSorting): Deactivate 'Sort tests by metric' link. (selectDirectory): Call enableSorting()/disableSorting() depending on currently selected failure type, and sort tests if requested.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: New .disabled-control class for deactivated links.
13:29 Changeset [88380] by crogers@google.com
  • 15 edits
    3 adds in trunk/Source/WebCore

2011-06-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
https://bugs.webkit.org/show_bug.cgi?id=62078

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::reset): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setNormalizedCoefficients): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setHighShelfParams): (WebCore::Biquad::setPeakingParams): (WebCore::Biquad::setAllpassParams): (WebCore::Biquad::setNotchParams): (WebCore::Biquad::setBandpassParams): (WebCore::Biquad::setZeroPolePairs): (WebCore::Biquad::setAllpassPole):
  • platform/audio/Biquad.h:
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createBiquadFilter): (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/BiquadDSPKernel.cpp: (WebCore::BiquadDSPKernel::process):
  • webaudio/BiquadFilterNode.cpp: Added. (WebCore::BiquadFilterNode::BiquadFilterNode):
  • webaudio/BiquadFilterNode.h: Added. (WebCore::BiquadFilterNode::create): (WebCore::BiquadFilterNode::type): (WebCore::BiquadFilterNode::setType): (WebCore::BiquadFilterNode::frequency): (WebCore::BiquadFilterNode::q): (WebCore::BiquadFilterNode::gain): (WebCore::BiquadFilterNode::biquadProcessor):
  • webaudio/BiquadFilterNode.idl: Added.
  • webaudio/BiquadProcessor.cpp: (WebCore::BiquadProcessor::BiquadProcessor):
  • webaudio/BiquadProcessor.h: (WebCore::BiquadProcessor::setType):
  • webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  • webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):
13:16 Changeset [88379] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Some more MarkedSpace => NewSpace renaming
https://bugs.webkit.org/show_bug.cgi?id=62305

  • JavaScriptCore.exp:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::reportExtraMemoryCostSlowCase): (JSC::Heap::allocate): (JSC::Heap::markRoots): (JSC::Heap::objectCount): (JSC::Heap::size): (JSC::Heap::capacity): (JSC::Heap::collect): (JSC::Heap::isValidAllocation):
  • heap/Heap.h: (JSC::Heap::markedSpace): (JSC::Heap::contains): (JSC::Heap::forEach): (JSC::Heap::allocate):
  • runtime/JSCell.h:
13:07 Changeset [88378] by noam.rosenthal@nokia.com
  • 5 edits in trunk/Source

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

No new tests, code path is not activated yet.

  • WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add ArgumentCoders for TransformOperation, including all the subclasses,
and TransformOperations.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
13:05 Changeset [88377] by commit-queue@webkit.org
  • 14 edits
    9 adds in trunk

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Chromium mixed content blocking, ensure that both preferences and web permissions
control the outcome. Ensure notify callback gets invoked even with insecure content.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/http/tests/security/mixedContent: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html: Added.

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Cause checks for insecure content blocking policy to callback to client.
https://bugs.webkit.org/show_bug.cgi?id=61946
Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowDisplayingInsecureContent): (WebCore::FrameLoaderClient::allowRunningInsecureContent):

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Add new permission callbacks for mixed content blocking.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowDisplayingInsecureContent): (WebKit::WebPermissionClient::allowRunningInsecureContent):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowDisplayingInsecureContent): (WebKit::FrameLoaderClientImpl::allowRunningInsecureContent):
  • src/FrameLoaderClientImpl.h:

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Add web permissions callbacks for mixed content blocking.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/WebPermissions.cpp: (WebPermissions::allowDisplayingInsecureContent): (WebPermissions::allowRunningInsecureContent): (WebPermissions::setDisplayingInsecureContentAllowed): (WebPermissions::setRunningInsecureContentAllowed): (WebPermissions::reset):
  • DumpRenderTree/chromium/WebPermissions.h:
13:04 Changeset [88376] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Add export macros to profiler headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

  • profiler/Profiler.h:
12:54 Changeset [88375] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, mark two flaky tests. Bug filed.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [88374] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Add export symbols to parser headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

  • parser/SourceProviderCache.h:
12:50 Changeset [88373] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
https://bugs.webkit.org/show_bug.cgi?id=62259

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
12:45 Changeset [88372] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Reviewed by Eric Seidel.

Add export symbols to interpreter headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

12:41 Changeset [88371] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Build fix after introduction of FontCache::ShouldRetain.

12:31 Changeset [88370] by kevino@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Reviewed by Eric Seidel.

Add export symbols to debugger headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

12:11 Changeset [88369] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
https://bugs.webkit.org/show_bug.cgi?id=62303

Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:58 Changeset [88368] by ggaren@apple.com
  • 9 edits
    2 moves in trunk/Source/JavaScriptCore

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved MarkedSpace.* to NewSpace.* in preparation for more renaming
https://bugs.webkit.org/show_bug.cgi?id=62268

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.h:
  • heap/MarkedBlock.h:
  • heap/MarkedSpace.cpp: Removed.
  • heap/MarkedSpace.h: Removed.
  • heap/NewSpace.cpp: Copied from Source/JavaScriptCore/heap/MarkedSpace.cpp.
  • heap/NewSpace.h: Copied from Source/JavaScriptCore/heap/MarkedSpace.h.
11:40 Changeset [88367] by loislo@chromium.org
  • 4 edits in trunk/Source

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88365.
http://trac.webkit.org/changeset/88365
https://bugs.webkit.org/show_bug.cgi?id=62301

windows bots broken (Requested by loislo_ on #webkit).

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88365.
http://trac.webkit.org/changeset/88365
https://bugs.webkit.org/show_bug.cgi?id=62301

windows bots broken (Requested by loislo_ on #webkit).

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
11:33 Changeset [88366] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Added new entries for skia/third_party/glu.

  • DEPS:
11:24 Changeset [88365] by loislo@chromium.org
  • 3 edits in trunk/Source

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON): Added checking the predicted buffer size and choosing exponential format, or eventually "NaN" if the buffer is too small for decimal format.
11:20 Changeset [88364] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-08 Nico Weber <thakis@chromium.org>

Reviewed by Darin Adler.

Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
https://bugs.webkit.org/show_bug.cgi?id=62295

This was found by a new warning recently added to clang's -Wparentheses

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::backButtonRect):
11:19 Changeset [88363] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
11:15 Changeset [88362] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key paths as arrays
https://bugs.webkit.org/show_bug.cgi?id=62291

  • storage/indexeddb/keypath-as-array-expected.txt: Added.
  • storage/indexeddb/keypath-as-array.html: Added.
11:12 Changeset [88361] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

2011-06-08 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Remove dead code from our JSC bridge
https://bugs.webkit.org/show_bug.cgi?id=62287

The m_defaultMethod member is not used since r36848 and QtMethod
was replaced by QtRuntimeMethod and subclasses in r29729.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::visitAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.h:
11:04 Changeset [88360] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

  • WebCore.gyp/WebCore.gyp:

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

  • WebKit.gyp:
11:03 Changeset [88359] by xji@chromium.org
  • 5 edits in trunk

2011-05-25 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

--webkit-visual-word does not work well in words separated by multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
right word boundary (before the space or after the space) by using previousWordPosition and
nextWordPosition. But they assume words are separated by single space and are not correct
for words separated by multiple spaces and words not separated by space.

Consider positionBeforeNextWord() for example,

First, it checks whether the current position is after the current word by checking current
position's previousWordPosition's nextWordPosition is the same as current position, which is
wrong for words separated by multiple spaces. For example, given words A and B separated by
3 continuous spaces "A B", position "A|", "A |", and "A |" should all be considered as
position after current word. But for position "A |", its previousWordPosition's
nextWordPosition is position "A|", which is different from its current position, so the
current position is not considered as a position after current word, consequently,
instead of returning the right position as "A |B", positionBeforeNextWord returns the
position before next next word, as "A B |C". Similar happens for position "A |".

Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at
"A|BC", positionBeforeNextWord() returns the same position after calling current position's
nextWordPosition's previousWordPosition. It should returns position "AB|C".

For those cases, we will have to collect all the word breaks inside the box and look for
the one at left or right of current position.

  • editing/visible_units.cpp: (WebCore::leftWordPosition): (WebCore::rightWordPosition):

2011-05-25 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

--webkit-visual-word does not work well in words separated by multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Add test cases for preserving white spaces and test case for words not separated by space.

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:
10:50 Changeset [88358] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Test migration from sqlite to leveldb for IndexedDB
backend.
https://bugs.webkit.org/show_bug.cgi?id=61000

  • storage/indexeddb/migrate-basics-expected.txt: Added.
  • storage/indexeddb/migrate-basics.html: Added.

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

Test: storage/indexeddb/migrate-basics.html

  • storage/IDBBackingStore.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::migrate):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h: (WebCore::IDBLevelDBBackingStore::backingStoreType):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h: (WebCore::IDBSQLiteBackingStore::backingStoreType):

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • public/WebIDBFactory.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactory::setOverrideBackingStoreType): (WebKit::WebIDBFactory::setTemporaryDatabaseFolder): (WebKit::WebIDBFactoryImpl::open):

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
10:31 Changeset [88357] by commit-queue@webkit.org
  • 11 edits
    4 deletes in trunk/Source/WebCore

2011-06-08 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/ChildThreadDOMData.cpp: Removed.
  • bindings/v8/ChildThreadDOMData.h: Removed.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
  • bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Removed.
  • bindings/v8/MainThreadDOMData.h: Removed.
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::removeAllDOMObjects): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
10:27 Changeset [88356] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, skip two failing tests. Bugs filed.

  • platform/chromium/test_expectations.txt:
10:14 Changeset [88355] by ademar.reis@openbossa.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-08 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

Webkit on SPARC Solaris has wrong endian
https://bugs.webkit.org/show_bug.cgi?id=29407

Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
there are more ocurrences of the same code pattern in webkit.

This patch includes the check on these other parts of the code.

This is a speculative fix, I don't have a sparc machine to test and
don't know which kind of test would trigger a crash (but it's quite
obvious that it's the same code duplicated in different files).

  • runtime/UString.h: (JSC::UStringHash::equal):
  • wtf/text/StringHash.h: (WTF::StringHash::equal):
10:10 Changeset [88354] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-08 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implements "undo" command execution
https://bugs.webkit.org/show_bug.cgi?id=62201

Supports to execute "Undo" command.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canUndo): (WebCore::EditorClientEfl::undo):
  • WebCoreSupport/EditorClientEfl.h:
09:16 Changeset [88353] by andreas.kling@nokia.com
  • 2 edits in trunk/Tools

2011-06-08 Andreas Kling <kling@webkit.org>

Add Pierre Rossi to contributors list for EZ-CC.

  • Scripts/webkitpy/common/config/committers.py:
09:16 Changeset [88352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-08 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Antonio Gomes.

[EFL] remove adjusting codes for zoom's center coordinate
https://bugs.webkit.org/show_bug.cgi?id=62266

It is possible that the application developers don't want to limit
zoom's center coordinate to the viewport for implementing some effects
and center coordinate out of the viewport does not affect to the zoom operation.
So, It is better to leave zoom's center coordinate freely.

  • ewk/ewk_view.cpp: (ewk_view_zoom_set): (ewk_view_zoom_weak_set):
08:52 Changeset [88351] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-08 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add a method to return the line breaks for any element with
multiline text content.
https://bugs.webkit.org/show_bug.cgi?id=62236

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::lineBreaks):
08:28 Changeset [88350] by yael.aharon@nokia.com
  • 6 edits in trunk/Source

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -ljavascriptcore
into QtWebKit.prl.

No new tests, as this is just a build fix.

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
into QtWebKit.prl.

No new tests, as this is just a build fix.

  • WebCore.pri:

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
into QtWebKit.prl.

  • WebKit2.pri:
08:24 Changeset [88349] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt] Unreviewed, skip failing tests

  • platform/qt/Skipped:
07:58 Changeset [88348] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-06-08 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Render non-document HTML resources as HTML
https://bugs.webkit.org/show_bug.cgi?id=58886

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): (WebInspector.Resource.prototype.hasErrorStatusCode):
  • inspector/front-end/ResourceHTMLView.js: Added. (WebInspector.ResourceHTMLView): (WebInspector.ResourceHTMLView.prototype.hasContent): (WebInspector.ResourceHTMLView.prototype.show): (WebInspector.ResourceHTMLView.prototype.hide): (WebInspector.ResourceHTMLView.prototype._createIFrame):
  • inspector/front-end/ResourcePreviewView.js: Added. (WebInspector.ResourcePreviewView): (WebInspector.ResourcePreviewView.prototype.hasContent): (WebInspector.ResourcePreviewView.prototype.show): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.resource-view.html iframe):
  • inspector/front-end/inspector.html:
07:52 Changeset [88347] by apavlov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt, Chromium] Unreviewed attempt to fix tests on Qt and Chromium.

  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/up-down-numerics-and-colors.html:
07:12 Changeset [88346] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

2011-06-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Enable PROGRESS_TAG feature
https://bugs.webkit.org/show_bug.cgi?id=62212

  • Source/cmake/OptionsEfl.cmake: Turn on PROGRESS_TAG by default.
06:57 QtWebKitBuildBots edited by ossy@webkit.org
(diff)
06:57 Changeset [88345] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed chromium build fix for r88332.

  • src/WebRuntimeFeatures.cpp:
06:56 QtWebKitBuildBots edited by ossy@webkit.org
(diff)
06:48 Changeset [88344] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=61035

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL): (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
06:24 Changeset [88343] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk/Source/WebCore

2011-06-08 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

StreamEvent

Media Stream PeerConnection API: adding StreamEvent class
https://bugs.webkit.org/show_bug.cgi?id=61537

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp: (WebCore::Event::isStreamEvent):
  • dom/Event.h:
  • dom/StreamEvent.cpp: Added. (WebCore::StreamEvent::create): (WebCore::StreamEvent::StreamEvent): (WebCore::StreamEvent::~StreamEvent): (WebCore::StreamEvent::initStreamEvent): (WebCore::StreamEvent::stream):
  • dom/StreamEvent.h: Added. (WebCore::StreamEvent::isStreamEvent):
  • dom/StreamEvent.idl: Added.
06:19 Changeset [88342] by demarchi@webkit.org
  • 3 edits in trunk

2011-06-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Never let a WTF_FEATURE defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=60820

If a port doesn't want to give the user some configure options,
nevertheless it would have to define this feature as OFF. Otherwise
there's a build error because the generated cmakeconfig.h is not
parsed correctly by ENABLE macro, which expects each feature to be
either undefined or defined to TRUE/FALSE.

  • Source/cmake/WebKitFeatures.cmake: Use a variable with the same name of the feature, which allows CONFIGURE_FILE() to replace it in the new cmakeconfig.h.cmake.
  • Source/cmakeconfig.h.cmake: use #cmakedefine01 instead of #define with another variable. This way the feature will always be 0 or 1 and it will never be left undefined.
06:08 Changeset [88341] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

2011-06-08 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Media Stream API: integrate the Track List objects into the existing code.
https://bugs.webkit.org/show_bug.cgi?id=60205

Tests for the Media Stream API will be provided by the bug 56587.

  • dom/ExclusiveTrackList.cpp: (WebCore::ExclusiveTrackList::select): (WebCore::ExclusiveTrackList::trackFailed):
  • dom/ExclusiveTrackList.h:
  • dom/GeneratedStream.cpp: (WebCore::GeneratedStream::create): (WebCore::GeneratedStream::GeneratedStream): (WebCore::GeneratedStream::streamEnded): (WebCore::GeneratedStream::audioTracks): (WebCore::GeneratedStream::videoTracks): (WebCore::GeneratedStream::stop):
  • dom/GeneratedStream.h:
  • dom/GeneratedStream.idl:
  • dom/MultipleTrackList.cpp: (WebCore::MultipleTrackList::trackFailed): (WebCore::MultipleTrackList::enable): (WebCore::MultipleTrackList::disable):
  • dom/MultipleTrackList.h:
  • dom/Stream.h:
  • dom/TrackList.cpp: (WebCore::TrackList::clear): (WebCore::TrackList::associateStream): (WebCore::TrackList::associatedStreamLabel): (WebCore::TrackList::trackFailed): (WebCore::TrackList::scriptExecutionContext):
  • dom/TrackList.h:
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::enableAudioTrack): (WebCore::MediaStreamController::disableAudioTrack): (WebCore::MediaStreamController::selectVideoTrack): (WebCore::MediaStreamController::streamGenerated): (WebCore::MediaStreamController::audioTrackFailed): (WebCore::MediaStreamController::videoTrackFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::enableAudioTrack): (WebCore::MediaStreamFrameController::disableAudioTrack): (WebCore::MediaStreamFrameController::selectVideoTrack): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::audioTrackFailed): (WebCore::MediaStreamFrameController::videoTrackFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::isGenericClient): (WebCore::MediaStreamFrameController::GenericClient::GenericClient): (WebCore::MediaStreamFrameController::GenericClient::~GenericClient): (WebCore::MediaStreamFrameController::GenericClient::isGenericClient): (WebCore::MediaStreamFrameController::GenericClient::unregister):
06:06 Changeset [88340] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt] Unreviewed, attempt to make test pass on Qt.

  • inspector/styles/styles-update-from-js.html:
05:52 Changeset [88339] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-06-08 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
https://bugs.webkit.org/show_bug.cgi?id=62274

Vector::find() returns size_t (which is unsigned), so we should check
for WTF::notFound instead of -1.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
05:18 Changeset [88338] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] breakpoints are not persisted.
https://bugs.webkit.org/show_bug.cgi?id=62273

  • inspector/front-end/Settings.js:
04:31 Changeset [88337] by apavlov@chromium.org
  • 18 edits in trunk

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend immediately.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
03:52 Changeset [88336] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-06-08 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] Float{32,64}Array and Int16Array fail to build.
https://bugs.webkit.org/show_bug.cgi?id=62219

For some reason, RVCT 2.x is moaning about "class member designated by
a using-declaration must be visible in a direct base class".
Apply same fix as r69122 and r76592.

  • html/canvas/Float32Array.h: (WebCore::Float32Array::set):
  • html/canvas/Float64Array.h: (WebCore::Float64Array::set):
  • html/canvas/Int16Array.h: (WebCore::Int16Array::set):
03:33 Changeset [88335] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-08 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
https://bugs.webkit.org/show_bug.cgi?id=61945

For OpenGL ES we do not need these features.
These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.

LayoutTests/fast/canvas/webgl/point-size.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
02:39 Changeset [88334] by isherman@chromium.org
  • 2 edits in trunk/Tools

2011-06-08 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Add Ilya Sherman to list of committers
https://bugs.webkit.org/show_bug.cgi?id=62270

  • Scripts/webkitpy/common/config/committers.py:
02:02 Changeset [88333] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-06-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • platform/efl/RenderThemeEfl.cpp:
  • platform/efl/RenderThemeEfl.h:
01:54 Changeset [88332] by morrita@google.com
  • 28 edits
    9 adds in trunk

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

  • editing/spelling/spellcheck-api-expected.txt: Added.
  • editing/spelling/spellcheck-api-pixel.html: Added.
  • editing/spelling/spellcheck-api.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

Tests: editing/spelling/spellcheck-api-pixel.html

editing/spelling/spellcheck-api.html

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled): (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::length):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): (WebCore::DocumentMarkerController::addUserSpellingMarker): (WebCore::DocumentMarkerController::removeUserSpellingMarker): (WebCore::DocumentMarkerController::userSpellingNode):
  • dom/DocumentMarkerController.h:
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::spellcheckRanges): (WebCore::HTMLDivElement::addSpellcheckRange): (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLDivElement.h:
  • html/HTMLDivElement.idl:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::spellcheckRanges): (WebCore::HTMLInputElement::addSpellcheckRange): (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::spellcheckRanges): (WebCore::HTMLTextAreaElement::addSpellcheckRange): (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.idl:
  • html/SpellcheckRange.cpp: Added. (WebCore::SpellcheckRange::SpellcheckRange): (WebCore::SpellcheckRange::~SpellcheckRange):
  • html/SpellcheckRange.h: Added. (WebCore::SpellcheckRange::create): (WebCore::SpellcheckRange::start): (WebCore::SpellcheckRange::length): (WebCore::SpellcheckRange::suggestions): (WebCore::SpellcheckRange::options):
  • html/SpellcheckRange.idl: Added.
  • html/SpellcheckRangeList.cpp: Added. (WebCore::SpellcheckRangeList::SpellcheckRangeList): (WebCore::SpellcheckRangeList::~SpellcheckRangeList): (WebCore::SpellcheckRangeList::item):
  • html/SpellcheckRangeList.h: Added. (WebCore::SpellcheckRangeList::create): (WebCore::SpellcheckRangeList::isEmpty): (WebCore::SpellcheckRangeList::clear): (WebCore::SpellcheckRangeList::append): (WebCore::SpellcheckRangeList::remove): (WebCore::SpellcheckRangeList::length):
  • html/SpellcheckRangeList.idl: Added.
  • rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): (WebCore::InlineTextBox::paintDocumentMarkers):

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableSpellCheckAPI): (WebKit::WebRuntimeFeatures::isSpellCheckAPIEnabled):
01:27 Changeset [88331] by caseq@chromium.org
  • 13 edits
    3 deletes in trunk

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js: (Element.prototype.query):

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.findNode.documentRequested): (initialize_ElementTest.InspectorTest.findNode):
  • inspector/console/console-shadow-dom-access.html: Removed.
  • inspector/elements/shadow-dom-expected.txt: Removed.
  • inspector/elements/shadow-dom.html: Removed.
  • platform/win/Skipped:
00:20 Changeset [88330] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):

00:05 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.7.x and on 4.8.x bots (diff)
00:02 QtWebKitBuildBots edited by ossy@webkit.org
remove ARM-GTK bot (diff)

06/07/11:

23:18 Changeset [88329] by keishi@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Rename HTMLInputElement::m_value to m_valueIfDirty
https://bugs.webkit.org/show_bug.cgi?id=61990

No new tests because no behavior change.

  • html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty. (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::copyNonAttributeProperties): (WebCore::HTMLInputElement::value): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::updateValueIfNeeded):
  • html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty. (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
23:16 Changeset [88328] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split 'reset' into 'collect' and 'resetAllocator'
https://bugs.webkit.org/show_bug.cgi?id=62267

  • heap/Heap.cpp: (JSC::Heap::allocate): (JSC::Heap::collectAllGarbage): (JSC::Heap::collect):
  • heap/Heap.h:
  • heap/MarkedBlock.h: (JSC::MarkedBlock::resetAllocator):
  • heap/MarkedSpace.cpp: (JSC::MarkedSpace::resetAllocator):
  • heap/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::resetAllocator):
23:13 Changeset [88327] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip new failing tests.

  • platform/qt/Skipped:
23:01 Changeset [88326] by koz@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update more snowleopard baselines after r88321.

  • platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
22:28 Changeset [88325] by koz@chromium.org
  • 5 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update snowleopard baselines after r88321.

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
21:57 Changeset [88324] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-06-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed some more marks to visits
https://bugs.webkit.org/show_bug.cgi?id=62254

  • heap/HandleHeap.cpp: (JSC::HandleHeap::visitStrongHandles): (JSC::HandleHeap::visitWeakHandles):
  • heap/HandleHeap.h:
  • heap/HandleStack.cpp: (JSC::HandleStack::visit):
  • heap/HandleStack.h:
  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • heap/HeapRootVisitor.h: (JSC::HeapRootVisitor::visit):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
20:59 Changeset [88323] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Update expectations for flaky tests.

  • platform/chromium/test_expectations.txt:
20:36 Changeset [88322] by koz@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update expectations for registerProtocolHandler
test.

  • platform/chromium-linux/fast/dom/register-protocol-handler-expected.txt: Added.
20:31 Changeset [88321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Ian Henderson <ianh@apple.com>

Reviewed by Dan Bernstein.

(CG) Sub-image drawing clips unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=62258

If destRect completely encompasses the adjustedDestRect into which we
draw, clipping to destRect will do nothing. Skip the call to
CGContextClipToRect in this case.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
20:22 Changeset [88320] by koz@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Disable SelectItemEvenFire that fails on
chromium canaries.

  • tests/PopupMenuTest.cpp: (WebKit::TEST_F):
20:12 Changeset [88319] by eae@chromium.org
  • 47 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert nodeAtPoint to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62145

Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
accumulated offset.

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::moveBy): Add moveBy(IntPoint) method
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::nodeAtPoint):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/RootInlineBox.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): (WebCore::RenderSVGForeignObject::nodeAtPoint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtPoint):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/svg/RenderSVGText.h:
19:44 Changeset [88318] by yi.4.shen@nokia.com
  • 4 edits in trunk

2011-06-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901

Unskip the tests which are now passing.

  • platform/qt/Skipped:

2011-06-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901

To indicate the media resource failures, set the network state to
MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
QMediaPlayer::ResourceError.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):
19:32 Changeset [88317] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestFloats to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62176

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBlock.h:
19:27 WebKit Team edited by eae@chromium.org
(diff)
19:14 Changeset [88316] by commit-queue@webkit.org
  • 8 edits in trunk

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • PluginProcess/mac/PluginProcessShim.mm:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • WebKitSystemInterface.h:
19:09 Changeset [88315] by barraclough@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=55537
Functions claim to have 'callee' which they actually don't (and shouldn't)

Source/JavaScriptCore:

Reviewed by Sam Weinig

(JSC::JSFunction::getOwnPropertyNames):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
19:06 Changeset [88314] by lforschler@apple.com
  • 5 edits in branches/safari-534-branch/Source

Versioning.

19:00 Changeset [88313] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-07 Juan C. Montemayor <jmont@apple.com>

Reviewed by Darin Adler.

Make JSStaticFunction and JSStaticValue less "const"
https://bugs.webkit.org/show_bug.cgi?id=62222

  • API/JSObjectRef.h:
  • API/tests/testapi.c: (checkConstnessInJSObjectNames): (main):
  • JavaScriptCore.xcodeproj/project.pbxproj:
18:59 Changeset [88312] by lforschler@apple.com
  • 1 copy in tags/Safari-534.44

New tag.

18:46 Changeset [88311] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestColumns to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62172

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns):
  • rendering/RenderBlock.h:
18:37 Changeset [88310] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
https://bugs.webkit.org/show_bug.cgi?id=62178

Added commandComplete and evaluateCommand for NewRunWebKitTests class
to parse new-run-webkit-tests' results.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
18:37 Changeset [88309] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Update expectations for tests that are timing out.

  • platform/chromium/test_expectations.txt:
18:21 Changeset [88308] by simon.fraser@apple.com
  • 8 edits
    2 adds in trunk

2011-06-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Opacity transition doesn't work while content property is set.
https://bugs.webkit.org/show_bug.cgi?id=59301

StyleRareNonInheritedData's copy constructor omitted to copy
the m_content data, which caused us to detach and re-attach the renderer
at the start of the transition, thereby killing the transition.

Fix by making StyleRareNonInheritedData's copy ctor do the right thing.

Test: transitions/transition-on-element-with-content.html

  • rendering/style/ContentData.h:
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy ctor because of the subclasses.)
  • rendering/style/CounterDirectives.h: Pack the data members to save space. Add a clone() function for the HashMap.
  • rendering/style/CounterDirectives.cpp: (WebCore::clone): Make a new HashMap and copy the contents over.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy the content and counter directives over. (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing for pointer equality, do a correct check for m_counterDirectives equality. (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
  • rendering/style/StyleRareNonInheritedData.h:
18:18 Changeset [88307] by commit-queue@webkit.org
  • 10 edits
    10 adds in trunk

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Shows that the basic Chromium gesture manager can correctly convert a touch
event sequence into a sequence of synthetic mouse events for clicking and
scrolling.

  • fast/events/touch/touch-gesture-click-expected.txt: Added.
  • fast/events/touch/touch-gesture-click.html: Added.
  • fast/events/touch/touch-gesture-scroll-expected.txt: Added.
  • fast/events/touch/touch-gesture-scroll.html: Added.
  • platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Added.

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Adds a basic gesture recognizer to the Chromium platform. Adds an entry
point to the GestureRecognizer to reset any internal state on a page reset.
Resetting the gesture recognizer on page load is necesary for reliable
layout test execution and improves gesture recognizer operational
robustness.

Added an additional constructor to permit building a synthetic
PlatformWheelEvent.

Small modifications to the PlatformGestureRecognizer as required to
implement the simple Chromium platform gesture recognizer.

Tests: fast/events/touch/touch-gesture-click.html

  • WebCore.gypi:
  • page/EventHandler.cpp: (WebCore::EventHandler::resetGestureRecognizer):
  • page/EventHandler.h:
  • page/FrameView.cpp: (WebCore::FrameView::reset):
  • platform/PlatformGestureRecognizer.h:
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/chromium/GestureRecognizerChromium.cpp: Added. (WebCore::InnerGestureRecognizer::InnerGestureRecognizer): (WebCore::InnerGestureRecognizer::reset): (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer): (WebCore::InnerGestureRecognizer::addEdgeFunction): (WebCore::InnerGestureRecognizer::isInClickTimeWindow): (WebCore::InnerGestureRecognizer::isInsideManhattanSquare): (WebCore::InnerGestureRecognizer::dispatchSyntheticClick): (WebCore::InnerGestureRecognizer::processTouchEventForGesture): (WebCore::InnerGestureRecognizer::scrollViaTouchMotion): (WebCore::InnerGestureRecognizer::updateValues): (WebCore::InnerGestureRecognizer::signature): (WebCore::touchDown): (WebCore::noGesture): (WebCore::click): (WebCore::isClickOrScroll): (WebCore::inScroll): (WebCore::PlatformGestureRecognizer::create): (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer): (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer): (WebCore::GestureRecognizerChromium::GestureRecognizerChromium): (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
  • platform/chromium/GestureRecognizerChromium.h: Added. (WebCore::InnerGestureRecognizer::setState): (WebCore::InnerGestureRecognizer::state): (WebCore::GestureRecognizerChromium::reset): (WebCore::GestureRecognizerChromium::processTouchEventForGesture):

2011-06-07 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

[chromium] Add a basic gesture recognizer to the Chromium platform
https://bugs.webkit.org/show_bug.cgi?id=54417

Added unit tests for the basic chromium platform gesture recognizer.

  • tests/InnerGestureRecognizerTest.cpp: Added. (WebCore::InspectableInnerGestureRecognizer::InspectableInnerGestureRecognizer): (WebCore::InspectableInnerGestureRecognizer::signature): (WebCore::InspectableInnerGestureRecognizer::firstTouchPosition): (WebCore::InspectableInnerGestureRecognizer::setFirstTouchTime): (WebCore::InspectableInnerGestureRecognizer::firstTouchTime): (WebCore::InspectableInnerGestureRecognizer::setLastTouchTime): (WebCore::InspectableInnerGestureRecognizer::lastTouchTime): (WebCore::InspectableInnerGestureRecognizer::edgeFunction): (WebCore::InspectableInnerGestureRecognizer::updateValues): (WebCore::InspectableInnerGestureRecognizer::addEdgeFunction): (WebCore::BuildablePlatformTouchPoint::setX): (WebCore::BuildablePlatformTouchPoint::setY): (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint): (WebCore::TestGestureRecognizer::TestGestureRecognizer): (WebCore::TestGestureRecognizer::SetUp): (WebCore::TestGestureRecognizer::TearDown): (WebCore::TEST_F):
18:12 Changeset [88306] by koz@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-06-07 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Fix expectations for registerProtocolHandler tests.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:57 Changeset [88305] by lforschler@apple.com
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r88261.

17:57 Changeset [88304] by noam.rosenthal@nokia.com
  • 7 edits in trunk/Source

2011-06-07 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.

No new functionality so no new tests.

  • WebCore.pri:
  • WebCore.pro:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/TextureMapperQt.cpp: (WebCore::TextureMapper::create):

2011-06-07 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap][Qt] Enable TextureMapper by default
https://bugs.webkit.org/show_bug.cgi?id=61740

Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
17:53 Changeset [88303] by lforschler@apple.com
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r88269.

17:52 Changeset [88302] by lforschler@apple.com
  • 27 edits in branches/safari-534-branch/Source

Merge r88260.

17:50 Changeset [88301] by tkent@chromium.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-06-07 Kent Tamura <tkent@chromium.org>

Reviewed by Ryosuke Niwa.

Convert fast/forms/thumbslider-crash.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=62195

  • fast/forms/thumbslider-crash-expected.txt: Added.
  • fast/forms/thumbslider-crash.html:
  • platform/chromium-linux/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/chromium-win/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/gtk/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-crash-expected.png: Removed.
  • platform/mac/fast/forms/thumbslider-crash-expected.txt: Removed.
  • platform/qt/fast/forms/thumbslider-crash-expected.txt: Removed.
17:48 Changeset [88300] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88204.

17:46 Changeset [88299] by lforschler@apple.com
  • 6 edits in branches/safari-534-branch/Source/WebKit2

Merge r88127.

17:42 Changeset [88298] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62248>
<rdar://problem/9568516>
WKResponderChainSink mechanism isn't robust against some types of responder chain manipulation

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKResponderChainSink detach]):
This method formerly blindly assumed that since -initWithResponderChain: put self at the
end of the responder chain, after _lastResponderInChain, then self is still at the end
of the responder chain and still immediately after _lastResponderInChain. Made this function
robust against some kinds of responder chain manipulations, though it can't be robust against
some other kinds (e.g., manipulations that removed self from this chain and put it into some
other chain).

17:30 Changeset [88297] by eae@chromium.org
  • 19 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Covered by existing tests.

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/InlineBox.h: (WebCore::InlineBox::size):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects):
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects):
  • rendering/svg/RenderSVGModelObject.h:
17:27 Changeset [88296] by simonjam@chromium.org
  • 22 edits
    1 move
    17 adds
    2 deletes in trunk/LayoutTests

2011-06-07 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline leopard and win7 tests due to:

  • r87955.
  • New fast/forms/select-baseline.html.
  • New fullscreen/full-screen-zIndex-after.html
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-mac-leopard/fast/borders/different-color-borders-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/selectlist-minsize-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/menulist-separator-painting-expected.png.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/carto.net/button-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/http/tests/appcache/manifest-redirect-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/resource-redirect-2-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/resource-redirect-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-content-type-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-signature-2-expected.txt: Added.
  • platform/chromium-win/http/tests/appcache/wrong-signature-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.txt: Added.
17:26 Changeset [88295] by lforschler@apple.com
  • 9 edits
    2 copies in branches/safari-534-branch/Source

Merge r88123.

17:26 Changeset [88294] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Kent Tamura <tkent@chromium.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
https://bugs.webkit.org/show_bug.cgi?id=62207

  • css/mediaControlsQt.css: Add comments. (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider):
  • platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent(). (WebCore::RenderThemeQt::adjustSliderThumbSize):
17:21 Changeset [88293] by lforschler@apple.com
  • 10 edits in branches/safari-534-branch/Source

Merge r88121.

17:19 Changeset [88292] by lforschler@apple.com
  • 3 edits
    2 copies in branches/safari-534-branch

Merge r88104.

17:16 Changeset [88291] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88080.

17:15 Changeset [88290] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88075.

17:02 Changeset [88289] by lforschler@apple.com
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88048.

16:59 Changeset [88288] by vangelis@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):
16:58 Changeset [88287] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

webkitpy: add a popen() call to executive
https://bugs.webkit.org/show_bug.cgi?id=62179

This change adds a popen() wrapper call to the Executive object.
This will allow other webkitpy scripts that currently call
subprocess directly to use Executive, instead.

No additional tests are necessary (the existing tests cover the code).

  • Scripts/webkitpy/common/system/executive.py:
16:57 Changeset [88286] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

2011-06-07 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
  • WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
  • platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
16:56 Changeset [88285] by lforschler@apple.com
  • 11 edits
    2 copies in branches/safari-534-branch

Merge r88034.

16:38 Changeset [88284] by weinig@apple.com
  • 20 edits in trunk

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebCore.xcodeproj/project.pbxproj: Make RenderArena.h private so it can be called from WebKit2.
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidLayout): Added.
  • page/ChromeClient.h: Remove setRenderTreeSize.
  • page/FrameView.cpp: (WebCore::FrameView::performPostLayoutTasks): Call dispatchDidLayout for all frames instead of calling setRenderTreeSize for the main frame.

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didLayoutForFrame callback.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetRenderTreeSize):
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Add render tree size getter in WebProcess.
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h: Removed setRenderTreeSize.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidLayout):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Call the new didLayoutForFrame client function.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::renderTreeSize):
  • WebProcess/WebPage/WebPage.h: Add iterative implementation to compute the total size of the render tree for a page.

2011-06-07 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove repeated IPC traffic from SetRenderTreeSize message
https://bugs.webkit.org/show_bug.cgi?id=62244

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add stub for didLayoutForFrame.
16:25 Changeset [88283] by lforschler@apple.com
  • 3 edits
    3 copies in branches/safari-534-branch

Merge r87959.

16:24 Changeset [88282] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Change RenderBlock::hitTestContents to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62170

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBlock.h:
16:21 Changeset [88281] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
https://bugs.webkit.org/show_bug.cgi?id=62241

  • Scripts/webkitpy/layout_tests/port/chromium.py:
16:03 Changeset [88280] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62240
DFG JIT - add support for for-loop array initialization.

Reviewed by Sam Weinig.

Support put by val beyond vector length.
Add a operationPutByValBeyondArrayBounds operation, make
PutValVal call this if the vector length check fails.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::isDoubleConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isJSConstantWithInt32Value):
(JSC::DFG::JITCodeGenerator::isIntegerConstant):
(JSC::DFG::JITCodeGenerator::valueOfIntegerConstant):

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
16:02 Changeset [88279] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-07 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Video with poster attribute will not display new frames when scrubbing.
https://bugs.webkit.org/show_bug.cgi?id=62036

Remove our "detection" about the end of a scrub now that there is an explicit seek completion
handler available in AVFoundation. Move what we used to do upon detection in timeChanged()
into seekCompleted().

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
15:51 Changeset [88278] by simonjam@chromium.org
  • 1 edit
    4 adds in trunk/Source/WebCore

2011-06-07 James Simonsen <simonjam@chromium.org>

Unreviewed, build fix, missing files from r88274.

  • bindings/v8/ChildThreadDOMData.cpp: Added. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Added.
  • bindings/v8/MainThreadDOMData.cpp: Added. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getCurrent): (WebCore::MainThreadDOMData::getMainThreadStore): (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
  • bindings/v8/MainThreadDOMData.h: Added. (WebCore::MainThreadDOMData::getStore):
15:45 Changeset [88277] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Replicate WidthIterator.cpp fix from r88139.
https://bugs.webkit.org/show_bug.cgi?id=62238

No new tests. Covered by existing layout tests on XP debug bots.

  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::advance):
15:41 Changeset [88276] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Gtk rebaseline after r88266.

  • platform/gtk/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:37 Changeset [88275] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Qt rebaseline after r88266.

  • platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:33 Changeset [88274] by simonjam@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2011-06-07 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rebaseline after r88266.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
15:25 Changeset [88273] by simonjam@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88221, r88224, and r88231.
http://trac.webkit.org/changeset/88221
http://trac.webkit.org/changeset/88224
http://trac.webkit.org/changeset/88231
https://bugs.webkit.org/show_bug.cgi?id=62233

assert failure on chromium linux debug (Requested by simonjam
on #webkit).

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore):
  • bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent):
  • bindings/v8/DOMData.h: (WebCore::DOMData::owningThread): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getCurrent): (WebCore::MainThreadDOMData::getMainThreadStore): (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
  • bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp. (WebCore::MainThreadDOMData::getStore):
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::removeAllDOMObjectsInCurrentThread): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
15:24 Changeset [88272] by alokp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 88258 - 2011-06-07 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

[chromium] PlatformContextSkia leaks SkDeviceFactory
https://bugs.webkit.org/show_bug.cgi?id=62163

Valgrind tests should have caught this.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/7119002

15:17 Changeset [88271] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88254, r88262, and r88268.
http://trac.webkit.org/changeset/88254
http://trac.webkit.org/changeset/88262
http://trac.webkit.org/changeset/88268
https://bugs.webkit.org/show_bug.cgi?id=62234

I fail at changing features.gypi (Requested by abarth on
#webkit).

  • features.gypi:
15:14 Changeset [88270] by simon.fraser@apple.com
  • 14 edits in trunk/Source/WebCore

2011-06-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=62185

ContentData did manual ref()/deref() and had a lot of awkward
code from using a union to store data.

Clean this up by adding ContentData subclasses for different
content types, which are then able to use RefPtr and OwnPtr
as appropriate.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::contentToCSSValue): Cast to different ContentData types as appropriate.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some const gyrations.
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::createRenderer): Use hasContent().
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::createRenderer): Ditto
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer): Ditto
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Cast to ImageContentData.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as appropriate.
  • rendering/style/ContentData.h: (WebCore::ContentData::~ContentData): (WebCore::ContentData::isCounter): (WebCore::ContentData::isImage): (WebCore::ContentData::isQuote): (WebCore::ContentData::isText): (WebCore::ContentData::next): (WebCore::ContentData::setNext): (WebCore::ImageContentData::image): (WebCore::ImageContentData::setImage): (WebCore::ImageContentData::ImageContentData): (WebCore::ImageContentData::type): (WebCore::ImageContentData::isImage): (WebCore::TextContentData::text): (WebCore::TextContentData::setText): (WebCore::TextContentData::TextContentData): (WebCore::TextContentData::type): (WebCore::TextContentData::isText): (WebCore::CounterContentData::counter): (WebCore::CounterContentData::setCounter): (WebCore::CounterContentData::CounterContentData): (WebCore::CounterContentData::type): (WebCore::CounterContentData::isCounter): (WebCore::QuoteContentData::quote): (WebCore::QuoteContentData::setQuote): (WebCore::QuoteContentData::QuoteContentData): (WebCore::QuoteContentData::type): (WebCore::QuoteContentData::isQuote): Add subclasses for different content types, which are created via overloaded create() methods on the base class.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::create): (WebCore::operator==): Test for type equality, followed by comparing data. (WebCore::operator!=):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::clearContent): (WebCore::RenderStyle::appendContent): (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent() code with code that either appends, or replaces the content. This loses an optimization where the existing ContentData object could get reused, but this seems to be rarely hit in practice.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasContent): Convenience method.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test that the pointers are non-null, then use the != operator.
  • rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
15:01 Changeset [88269] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix after r88260.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.

  • platform/graphics/wince/FontCacheWinCE.cpp:
14:31 Changeset [88268] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Fix "branding" issue in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=62229

Apparently we need to move the conditional block further out of the
nesting in order to see the branding variable. This patch also remove
the dummy branding variable I added to get the buildbot building again.

  • features.gypi:
14:21 Changeset [88267] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-06-07 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

TiledDrawingArea: Delay serving tile requests when the drawing area is suspended.

Do not paint tiles when painting is disabled (suspended) on the web process side.
Buffer up the tile requests and paint them, when the drawing area gets resumed.
On the UI process side, do not block on tile updates, when the tiled area is
not visible (painting is disabled on the web process side).

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::scheduleTileUpdate): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h:
14:15 Changeset [88266] by rwlbuis@webkit.org
  • 5 edits
    6 adds in trunk

2011-06-07 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

stroke-dasharray does not handle "none"
https://bugs.webkit.org/show_bug.cgi?id=62203

Test stroke-dasharray=none as well as invalid syntaxes.

  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
  • platform/mac/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/mac/svg/custom/invalid-dasharray-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f.svg: Added.
  • svg/custom/invalid-dasharray.svg: Added.

2011-06-07 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

stroke-dasharray does not handle "none"
https://bugs.webkit.org/show_bug.cgi?id=62203

Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.

Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg

svg/custom/invalid-dasharray.svg

  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
14:10 Changeset [88265] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88259 and r88263.
http://trac.webkit.org/changeset/88259
http://trac.webkit.org/changeset/88263
https://bugs.webkit.org/show_bug.cgi?id=62228

broke builds (Requested by rniwa on #webkit).

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88259 and r88263.
http://trac.webkit.org/changeset/88259
http://trac.webkit.org/changeset/88263
https://bugs.webkit.org/show_bug.cgi?id=62228

broke builds (Requested by rniwa on #webkit).

  • PluginProcess/mac/PluginProcessShim.mm:
14:06 Changeset [88264] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch ContainerNode to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61893

Covered by existing tests.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): (WebCore::ContainerNode::getRect): Change to use maxX/maxY instead of x+width/y+height
  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): (WebCore::FloatPoint::moveBy): (WebCore::FloatPoint::expandedTo): Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
13:59 Changeset [88263] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Ryosuke Niwa <rniwa@webkit.org>

Speculative build fix after r88259.

  • platform/network/cf/ResourceRequest.h:
13:51 Changeset [88262] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Attempt to fix the cr-win build.

  • features.gypi:
13:49 Changeset [88261] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-07 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Need to enable font cache purging in MemoryPressureHandler
https://bugs.webkit.org/show_bug.cgi?id=62060

Improve memory usage under pressure.
Added call to fontCache()->purgeInactiveFontData() in
MemoryPressureHandler::respondToMemoryPressure(). Added protection to
MemoryPressureHandler::install() being called multiple times.

No new tests as funtionality wasn't changed.

  • platform/MemoryPressureHandler.cpp: (WebCore::MemoryPressureHandler::MemoryPressureHandler):
  • platform/MemoryPressureHandler.h:
  • platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::install): (WebCore::MemoryPressureHandler::respondToMemoryPressure):
13:46 Changeset [88260] by msaboff@apple.com
  • 27 edits in trunk/Source

2011-06-06 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

See more comments for this defect in Source/WebCore/ChangeLog.

  • WebKitGraphics.cpp: (CenterTruncateStringToWidth): (RightTruncateStringToWidth): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.

2011-06-06 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

See more comments for this defect in Source/WebCore/ChangeLog.

  • Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • Misc/WebStringTruncator.mm: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.

2011-06-07 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875

This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.

Most accesses to the font cache still use the reference counting
implemented by FontCache::getCacheFontData() and
FontCache::releaseFontData() and that operation is not affected by
this change.

Added local scoped instance of FontCachePurgePreventer to wrap code
that directly or indirectly accesses fonts via getFontDataForCharacters.
Did a few other miscellaneous bug fixes and changes to allow system
fallback fonts to be pruned from the GlyphPageTree. Changed the
calls to getFontData in the platform specific versions of
Fontcache::getFontDataForCharacters to not increment the reference
count. Moved the purge font check
outside of FontCache::getCachedFontData() into a separate method,
purgeInactiveFontDataIfNeeded() since almost all calls to
getCachedFontData() now happen when purging is not allowed.
purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
m_purgePreventCount is 0.

No new test as the functionality has not changed. Improved font life
cycle management.

  • WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::measureText): (WebCore::CanvasRenderingContext2D::drawTextInternal): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::FontCache): (WebCore::FontCache::getCachedFontData): Moved purge check to new method since it likely can't happen here. (WebCore::FontCache::releaseFontData): (WebCore::FontCache::purgeInactiveFontDataIfNeeded): (WebCore::FontCache::purgeInactiveFontData): Made purging conditional on m_purgePreventCount. Now some fonts in the cache are reference counted while other can be purged outside of code wrapped by in scope FontCachePurgePreventer objects.
  • platform/graphics/FontCache.h: (WebCore::FontCache::disablePurging): (WebCore::FontCache::enablePurging): (WebCore::FontCachePurgePreventer::FontCachePurgePreventer): (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer): Added new simple purge prevention wrapper class and methods that it calls in FontCache actually prevent purging. The simple methods inlined to reduce overhead.
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Update level in glyph page tree for system fallback fonts so pruning works.
  • platform/graphics/GlyphPage.h: (WebCore::GlyphPage::clearForFontData): New method used for pruning
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::pruneFontData): Now we prune system fallback fonts.
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/haiku/FontCacheHaiku.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/wince/FontCacheWinCE.cpp:
  • platform/graphics/wx/FontCacheWx.cpp: (WebCore::FontCache::getFontDataForCharacters): Changed the calls to getFontData() to not increment the reference count. The caller of this getFontDataForCharacters() (currently only Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers don't attempt to release the returned fonts so we use the purge protection described above.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in this method.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in these methods
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRectForTextFragment): Wrapped code accessing fallback fonts with local FontCachePurgePreventer in this method.
13:37 Changeset [88259] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/mac/WebCoreSystemInterface.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:

2011-06-07 Tim Horton <timothy_horton@apple.com>

Reviewed by Alexey Proskuryakov.

Use correct CFURLStorageSessionRef definition on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=62223

  • PluginProcess/mac/PluginProcessShim.mm:
13:28 Changeset [88258] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Stephen White.

[chromium] PlatformContextSkia leaks SkDeviceFactory
https://bugs.webkit.org/show_bug.cgi?id=62163

Valgrind tests should have caught this.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
13:23 Changeset [88257] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-07 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Enable tests on the mac-ews

When we bring the mac-ews back up, we're going to try running tests!

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:55 Changeset [88256] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-07 Dmitry Lomov <dslomov@google.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=62215
Allow comparisons with 0 in LIKELY and UNLIKELY macros.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:21 Changeset [88255] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skip test crashing in GTK bots because of an ASSERT.

Actually, it's the same problem observed before (see bug 61937).

  • platform/gtk/Skipped: Skipped test.
12:18 Changeset [88254] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-07 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
https://bugs.webkit.org/show_bug.cgi?id=62135

After this patch is rolled into Chromium, we should be able to delete
features_override.gyp downstream. Once we do that, we can simplify
this file somewhat by removing at least on level of nesting.

  • features.gypi:
12:17 Changeset [88253] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-07 Aravind Akella <aravind.akella@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] API test failure qdeclarativewebview
https://bugs.webkit.org/show_bug.cgi?id=59481

QML files cannot be loaded on Symbian due to difference
in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
missing is observed when dynamically loading the QML plugin.

  • declarative/declarative.pro: Match capabilities in QtWebKit.pro.
  • symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs. Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL, and causes build warnings about undefined VENDOR_VID.
  • tests/tests.pri: Add WriteDeviceData capability for API tests.
12:09 Changeset [88252] by thakis@chromium.org
  • 7 edits
    2 deletes in branches/chromium/782

Revert 84329 - 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test case by Bijan Amirzada <bijana@codeaurora.org>.

  • fast/dom/HTMLLinkElement/disabled-attribute-expected.txt: Added.
  • fast/dom/HTMLLinkElement/disabled-attribute.html: Added. Test that the properties are properly forwarded to the stylesheet.
  • fast/dom/boolean-attribute-reflection-expected.txt:
  • fast/dom/script-tests/boolean-attribute-reflection.js: Removed link:disabled as it is not reflected anymore.

2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test: fast/html/htmllink-disable.html
Test: fast/dom/HTMLLinkElement/disabled-attribute.html

Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.

Based on previous work by Bijan Amirzada <bijana@codeaurora.org>.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or false if we don't have a stylesheet. (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or ignore the call if we don't have a stylesheet.
  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5. This matches the way FF4, Opera and IE9 handle the attribute.

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7046023

11:58 Changeset [88251] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-07 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderTextControl::hitInnerTextElement to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62167

Covered by existing tests.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
11:56 Changeset [88250] by leviw@chromium.org
  • 74 edits in trunk/Source/WebCore

2011-06-07 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62177

Flipping the switch on the remaining paint functions to have them all
use IntPoint for the paint offset instead of tx/ty.

No new tests since this is just refactoring.

  • page/FrameView.cpp: (WebCore::FrameView::paintScrollCorner):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paint):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintCell):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h: (WebCore::RenderText::paint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::paint):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::paint):
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::paint):
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
11:29 Changeset [88249] by dcheng@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[Chromium] REGRESSION fast/events/onload-after-document-close-with-subresource.html
https://bugs.webkit.org/show_bug.cgi?id=61921

Force a non-cached load of onload-image.png.

  • fast/events/onload-after-document-close-with-subresource.html:
  • platform/chromium/test_expectations.txt:
10:41 Changeset [88248] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Test expectations fix.

[chromium] Fixing test expectations error for chromium-gpu.

  • platform/chromium/test_expectations.txt:
09:58 Changeset [88247] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-07 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is not paused properly.
https://bugs.webkit.org/show_bug.cgi?id=61446

The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.

  • animations/play-state-paused-expected.png: Added.
  • animations/play-state-paused-expected.txt: Added.
  • animations/play-state-paused.html: Added.

2011-06-07 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is not paused properly.
https://bugs.webkit.org/show_bug.cgi?id=61446

The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.

Test: animations/play-state-paused.html

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncCompositingStateSelf): (WebCore::TextureMapperNode::hasOpacityAnimation): (WebCore::TextureMapperNode::hasTransformAnimation):
  • platform/graphics/texmap/TextureMapperNode.h:
09:48 Changeset [88246] by thakis@chromium.org
  • 6 edits in trunk/Tools

2011-06-07 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=62210

The change to TestEventPrinter fixes a latent bug, because
objects are deleted through the TestEventPrinter type, but none
of the subclasses have destructors or non-POD members.

The changes to NotificationPresenter and WebViewHost do _not_ to fix a
real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
discussed at http://codereview.chromium.org/7094005/, we prefer making
leaf class destructors virtual over making the leaf classes final.

  • DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::~NotificationPresenter):
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestEventPrinter::~TestEventPrinter):
  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/WebViewHost.h:
09:40 Changeset [88245] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-07 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Remove Ecore_X bits from PlatformScreenEfl
https://bugs.webkit.org/show_bug.cgi?id=61649

Remove the need for Ecore_X and some X calls by always using
new functions available in EFL to get the screen size.

  • Source/cmake/FindEFL.cmake: Bump ecore and ecore-evas versions.

2011-06-07 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Remove Ecore_X bits from PlatformScreenEfl
https://bugs.webkit.org/show_bug.cgi?id=61649

Remove the need for Ecore_X and some X calls by always using
new functions available in EFL to get the screen size.

No new tests since the same functionality are done inside EFL now.

  • platform/efl/PlatformScreenEfl.cpp: (WebCore::screenRect):
09:38 WebKit Team edited by takano.naoki@gmail.com
(diff)
09:35 Changeset [88244] by carlosgc@webkit.org
  • 6 edits in trunk/Source

2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
https://bugs.webkit.org/show_bug.cgi?id=62200

In WebKit2 PluginPackage is used by the UI process to load plugins
in order to get information about them, but it doesn't use any GTK
symbol. So the UI process should be able to load plugins even when
building with GTK3, but we should not allow the plugin view to use
the plugin if it mixes GTK2 and GTK3 symbols.

  • plugins/PluginPackage.h: (WebCore::PluginPackage::module): New method to return the platform module.
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): Check whether plugin was successfully loaded before trying to create the drawable. (WebCore::PluginView::paint): Return early if plugin didn't start or was not successfully loaded. (WebCore::PluginView::handleKeyboardEvent): Ditto. (WebCore::PluginView::handleMouseEvent): Ditto. (WebCore::PluginView::handleFocusInEvent): Ditto. (WebCore::PluginView::handleFocusOutEvent): Ditto. (WebCore::moduleMixesGtkSymbols): (WebCore::PluginView::platformStart): Check whether module is mixing GTK+ 2 and GTK+ 3 symbols.

2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
https://bugs.webkit.org/show_bug.cgi?id=62200

In WebKit2 PluginPackage is used by the UI process to load plugins
in order to get information about them, but it doesn't use any GTK
symbol. So the UI process should be able to load plugins even when
building with GTK3, but we should not allow the plugin view to use
the plugin if it mixes GTK2 and GTK3 symbols.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::moduleMixesGtkSymbols): (WebKit::NetscapePlugin::platformPostInitialize): Check whether the module is mixing GTK+ 2 and GTK+ 3 symbols.
09:33 Changeset [88243] by commit-queue@webkit.org
  • 18 edits in trunk

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88238.
http://trac.webkit.org/changeset/88238
https://bugs.webkit.org/show_bug.cgi?id=62216

Broke a couple of inspector tests (Requested by apavlov on
#webkit).

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88238.
http://trac.webkit.org/changeset/88238
https://bugs.webkit.org/show_bug.cgi?id=62216

Broke a couple of inspector tests (Requested by apavlov on
#webkit).

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
09:20 Changeset [88242] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-07 Dinu Jacob <dinu.jacob@nokia.com>

Reviewed by Dimitri Glazkov.

Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
https://bugs.webkit.org/show_bug.cgi?id=61543

Inform chrome client that touch events are not needed by the webpage
when navigating away from the page only once to avoid the flag being
overwritten later if a page is removed from the page cache

  • dom/Document.cpp: (WebCore::Document::detach):
  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
08:54 Changeset [88241] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-07 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove JSC dependency from WebKit/efl
https://bugs.webkit.org/show_bug.cgi?id=62173

Change JSC::initializeThreading() and WTF::initializeMainThread() to
WebCore::ScriptController::initializeThreading() which contains these
functions and remove JSC dependency to build webkit/efl with v8.

  • ewk/ewk_main.cpp: (_ewk_init_body):
08:33 Changeset [88240] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-07 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] "webkithittestresult.h" is malformed
https://bugs.webkit.org/show_bug.cgi?id=62117

  • webkit/webkithittestresult.h: fix typo in GET_CLASS macro.
08:33 Changeset [88239] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.4.1

Tagging the WebKitGTK+ 1.4.1 release.

08:31 Changeset [88238] by apavlov@chromium.org
  • 18 edits in trunk

2011-06-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend immediately.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
08:19 Changeset [88237] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove duplicate breakpoints from localStorage
https://bugs.webkit.org/show_bug.cgi?id=62206

Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
case when settings version is less than 1.

08:15 Changeset [88236] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Unreviewed. Skip failing tests because of unimplemented features.

  • platform/mac-wk2/Skipped:
07:27 Changeset [88235] by yurys@chromium.org
  • 5 edits in trunk/Source

2011-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
https://bugs.webkit.org/show_bug.cgi?id=62019

Dispatch disconnecFrontend message in debugger task mode to make sure
it is processed even if execution is paused.

  • bindings/v8/WorkerScriptDebugServer.cpp: (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/WorkerScriptDebugServer.h:

2011-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
https://bugs.webkit.org/show_bug.cgi?id=62019

Dispatch disconnecFrontend message in debugger task mode to make sure
it is processed even if execution is paused.

  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::detachDevTools): (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
06:31 Changeset [88234] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-07 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation beginElement() does not restart the animation after endElement().
https://bugs.webkit.org/show_bug.cgi?id=43452

Added test for animation beginElement. It should restart the animation even if the animation is stopped by endElement() previously.

  • svg/animations/animate-endElement-beginElement-expected.txt: Added.
  • svg/animations/animate-endElement-beginElement.html: Added.
  • svg/animations/script-tests/animate-endElement-beginElement.js: Added.

2011-06-07 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation beginElement() does not restart the animation after endElement().
https://bugs.webkit.org/show_bug.cgi?id=43452

Test: svg/animations/animate-endElement-beginElement.html

Calling beginElement() after calling endElement() previously does not restarted the animation when animation
element's end attribute doesn't contains a bigger value than the current animation time.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::findInstanceTime):
06:22 Changeset [88233] by andreas.kling@nokia.com
  • 2 edits in trunk

2011-06-07 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix Symbian build with RVCT 2.x
https://bugs.webkit.org/show_bug.cgi?id=62205

RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
option, so restrict it to version 4.x of the compiler.

  • Source/WebKit.pri:
02:44 Changeset [88232] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk/Source

2011-06-07 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView. (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup. (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.

2011-06-07 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node. (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList. (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not. (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item. (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event. (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL. (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call. (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL(). (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests(). (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string. (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
  • tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
  • tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
  • tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
  • WebKit.gyp: Added PopupMenuTest.cpp. Because webkit_support dependency is added, we can't build PopupMenuTest.cpp with Chromium-win (shared) configuration.
02:39 Changeset [88231] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-07 Andras Becsi <abecsi@webkit.org>

Reviewed by Yury Semikhatsky.

REGRESSION(r88221): "Chromium debug compilation broken".
https://bugs.webkit.org/show_bug.cgi?id=62197

No new tests needed.

  • bindings/v8/V8GCController.cpp: Also rename call-sites. (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
02:23 Changeset [88230] by tonyg@chromium.org
  • 12 edits in branches/chromium/782

Merge 88174 - 2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
  • page/PageVisibilityState.h:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • public/WebPageVisibilityState.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):

BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7121007

01:55 Changeset [88229] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed Skipped entry addition following r88225.

  • platform/win/Skipped:
01:41 Changeset [88228] by morrita@google.com
  • 4 edits
    14 deletes in trunk

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88212 and r88219.
http://trac.webkit.org/changeset/88212
http://trac.webkit.org/changeset/88219
https://bugs.webkit.org/show_bug.cgi?id=57439

Tests get timeout on Snow Leopard

  • fast/replaced/no-focus-ring-embed-1-expected.txt: Removed.
  • fast/replaced/no-focus-ring-embed-1.html: Removed.
  • fast/replaced/no-focus-ring-embed-2-expected.txt: Removed.
  • fast/replaced/no-focus-ring-embed-2.html: Removed.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Removed.
  • fast/replaced/no-focus-ring-iframe.html: Removed.
  • fast/replaced/no-focus-ring-object-1-expected.txt: Removed.
  • fast/replaced/no-focus-ring-object-1.html: Removed.
  • fast/replaced/no-focus-ring-object-2-expected.txt: Removed.
  • fast/replaced/no-focus-ring-object-2.html: Removed.
  • fast/replaced/outline-replaced-elements-expected.txt: Removed.
  • fast/replaced/outline-replaced-elements.html: Removed.
  • fast/replaced/resources/focus-test.js: Removed.
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Removed.

2011-06-07 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88212 and r88219.
http://trac.webkit.org/changeset/88212
http://trac.webkit.org/changeset/88219
https://bugs.webkit.org/show_bug.cgi?id=57439

Tests get timeout at Snow Leopard

  • css/html.css: (html:focus, body:focus, input[readonly]:focus):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
01:39 Changeset [88227] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r88175.

  • platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
01:38 Changeset [88226] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-07 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skip tests crashing in GTK bots because of an ASSERT.

Also relocated one skipped test into its right category, together
with the new one being skipped now.

  • platform/gtk/Skipped: SKipped test
01:33 Changeset [88225] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Verify cloning <details> and <summary> works.
https://bugs.webkit.org/show_bug.cgi?id=61985

  • fast/html/details-clone-expected.txt: Added.
  • fast/html/details-clone.html: Added.
01:26 Changeset [88224] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-07 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt][V8] Fix the build after 88221.

No new tests needed.

  • WebCore.pro: Remove non-existing files.
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjects): Also rename the definition of the function.

06/06/11:

23:31 Changeset [88223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88222.
http://trac.webkit.org/changeset/88222
https://bugs.webkit.org/show_bug.cgi?id=62192

Broke compile on Mac (Requested by abarth on #webkit).

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
23:20 Changeset [88222] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-06 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add ArgumentCoders for TransformOperation, including all the subclasses,
and TransformOperations.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
23:19 Changeset [88221] by commit-queue@webkit.org
  • 10 edits
    4 deletes in trunk/Source/WebCore

2011-06-06 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.

  • WebCore.gypi:
  • bindings/v8/ChildThreadDOMData.cpp: Removed.
  • bindings/v8/ChildThreadDOMData.h: Removed.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
  • bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Removed.
  • bindings/v8/MainThreadDOMData.h: Removed.
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
23:11 Changeset [88220] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

[chromium] Make VideoFrameChromium's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62186

This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
deletes a VideoFrameChromium subclass type through this interface
class, causing ~VideoFrameChromiumImpl's destructor not to run.
(VideoFrameChroimumImpl happens to not have a destructor or any
non-POD member variables, so it's more a latent bug.)

  • platform/graphics/chromium/VideoFrameChromium.cpp: (WebCore::VideoFrameChromium::~VideoFrameChromium):
  • platform/graphics/chromium/VideoFrameChromium.h:
22:52 Changeset [88219] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-06-06 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fix flakiness on Snow Leopard.

  • fast/replaced/resources/focus-test.js:
22:24 Changeset [88218] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sammy Weinig.

Remove some unnecessary includes from AnimationBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=62183

  • page/animation/AnimationBase.cpp:
22:14 Changeset [88217] by koz@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Rebaseline outline-replaced-elements windows/linux image results.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • platform/chromium-linux-x86/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium-linux/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium-win/fast/replaced/outline-replaced-elements-expected.png: Added.
  • platform/chromium/test_expectations.txt:
21:52 Changeset [88216] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, a crash fix by a roll out.

REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
https://bugs.webkit.org/show_bug.cgi?id=62116

Roll out the WebCore part of r87980.

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):

  • html/SearchInputType.h:

(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):

  • html/TextFieldInputType.h:

(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):

  • html/shadow/TextControlInnerElements.cpp:
  • html/shadow/TextControlInnerElements.h:
21:42 Changeset [88215] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Allow copying of KeyframeValueList.
https://bugs.webkit.org/show_bug.cgi?id=62171

Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.

No new functionality so no new tests.

  • platform/graphics/GraphicsLayer.h: (WebCore::FloatAnimationValue::clone): (WebCore::TransformAnimationValue::TransformAnimationValue): (WebCore::TransformAnimationValue::clone): (WebCore::TransformAnimationValue::value): (WebCore::KeyframeValueList::KeyframeValueList):
21:12 Changeset [88214] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2011-06-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Incorrect rounding of color values during transitions
https://bugs.webkit.org/show_bug.cgi?id=62141

When blending integers, round to the nearest integer, instead of always rounding down.

Test: transitions/color-transition-rounding.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
21:06 Changeset [88213] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88202.
http://trac.webkit.org/changeset/88202
https://bugs.webkit.org/show_bug.cgi?id=62182

This broke the mac clang bot (Requested by koz on #webkit).

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/InlineBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
21:04 Changeset [88212] by commit-queue@webkit.org
  • 5 edits
    14 adds in trunk

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/replaced/no-focus-ring-embed-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-1.html: Added.
  • fast/replaced/no-focus-ring-embed-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed-2.html: Added.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Added.
  • fast/replaced/no-focus-ring-iframe.html: Added.
  • fast/replaced/no-focus-ring-object-1-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-1.html: Added.
  • fast/replaced/no-focus-ring-object-2-expected.txt: Added.
  • fast/replaced/no-focus-ring-object-2.html: Added.
  • fast/replaced/outline-replaced-elements-expected.txt: Added.
  • fast/replaced/outline-replaced-elements.html: Added.
  • fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.

2011-06-06 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439

Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.

Tests: fast/replaced/no-focus-ring-embed-1.html

fast/replaced/no-focus-ring-embed-2.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object-1.html
fast/replaced/no-focus-ring-object-2.html
fast/replaced/outline-replaced-elements.html

  • css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
18:44 Changeset [88211] by morrita@google.com
  • 3 edits
    2 adds in trunk

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

  • editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
  • editing/spelling/spellcheck-input-search-crash.html: Added.

2011-06-06 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
https://bugs.webkit.org/show_bug.cgi?id=61991

Added a guard bofore TextCheckingHelper construction sites.

Test: editing/spelling/spellcheck-input-search-crash.html

  • editing/Editor.cpp: (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
18:35 Changeset [88210] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dirk Pranke.

[chromium] Chromium bots on build.webkit.org don't upload results.html
https://bugs.webkit.org/show_bug.cgi?id=61961

Don't fix the path on chromium port erroneously.

  • BuildSlaveSupport/test-result-archive:
18:17 Changeset [88209] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload): Change prettyURL() with string().
18:12 Changeset [88208] by jamesr@google.com
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 87960 - 2011-06-02 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7125002

18:03 Changeset [88207] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
17:56 Changeset [88206] by koz@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed, update test_expectations.txt.

  • platform/chromium/test_expectations.txt:
17:53 Changeset [88205] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Update RenderBlock::paint to use IntPoint internally
https://bugs.webkit.org/show_bug.cgi?id=62140

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
17:07 Changeset [88204] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62165>
<rdar://problem/9555835>
WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::findString):
Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
number that would be ignored.

17:03 Changeset [88203] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebViewImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62155

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebViewImpl.h:
16:45 Changeset [88202] by eae@chromium.org
  • 15 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Covered by existing tests.

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect):
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects):
  • rendering/RenderView.h:
16:31 Changeset [88201] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

2011-06-06 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean scalePage related LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=62142

  • platform/qt/Skipped:
16:21 Changeset [88200] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch shouldPaint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62158

Switching shouldPaint to take an IntPoint representing the paint offset instead
of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
  • rendering/RenderReplaced.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
16:04 Changeset [88199] by simonjam@chromium.org
  • 5 edits in trunk/Source

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

  • wtf/CurrentTime.cpp: Add monotonicallyIncreasingTime() for mac and a fallback implementation that just wraps currentTime(). (WTF::monotonicallyIncreasingTime):
  • wtf/CurrentTime.h: Add monotonicallyIncreasingTime().

2011-06-06 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

Add monotonicallyIncreasingTime() to get monotonically increasing time
https://bugs.webkit.org/show_bug.cgi?id=37743

  • platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
16:01 Changeset [88198] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::pushContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62133

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::Covered by existing tests.RenderBlock::paint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
15:28 Changeset [88197] by japhet@chromium.org
  • 1 edit
    3 copies in branches/chromium/782

Merge r87959 to chromium/782.

< rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.
Reviewed by Oliver Hunt.
Source/WebCore:
Test: webarchive/loading/javascript-url-iframe-crash.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
cause the DocumentLoader to be destroyed, so protect it with a Ref here.
LayoutTests:

  • webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
  • webarchive/loading/javascript-url-iframe-crash.html: Added.
  • webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
15:27 Changeset [88196] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156

Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
15:13 Changeset [88195] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert hitTest to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62144

Covered by existing tests.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest):
  • rendering/RenderObject.h:
15:03 Changeset [88194] by simonjam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-06 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html

  • platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
15:00 Changeset [88193] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151

Switching paintScrollbar to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar):
  • rendering/RenderListBox.h:
14:52 Changeset [88192] by dcheng@chromium.org
  • 4 edits
    6 deletes in trunk/Source

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

No new tests since this change only deleted unused code.

  • WebCore.gypi:
  • platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
  • platform/chromium/ChromiumDataObjectLegacy.h: Removed.
  • platform/chromium/ReadableDataObject.cpp: Removed.
  • platform/chromium/ReadableDataObject.h: Removed.
  • platform/chromium/WritableDataObject.cpp: Removed.
  • platform/chromium/WritableDataObject.h: Removed.

2011-06-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Delete dead clipboard code.
https://bugs.webkit.org/show_bug.cgi?id=62113

  • src/WebDragData.cpp:
14:45 Changeset [88191] by thakis@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
14:35 Changeset [88190] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137

Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
representing the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintContinuationOutlines):
  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
14:30 Changeset [88189] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::popContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62132

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::popContentsClip):
  • rendering/RenderBox.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
14:26 Changeset [88188] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Remove tx/ty offset from selectionRect
https://bugs.webkit.org/show_bug.cgi?id=62146

Removing unused offset parameters from selectionRect.

No new tests since this is just cleanup.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::selectionRect):
  • rendering/EllipsisBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::ellipsisRectForBox): (WebCore::RenderText::absoluteQuadsForRange): (WebCore::RenderText::selectionRectForRepaint):
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRect):
  • rendering/svg/SVGInlineTextBox.h:
14:15 Changeset [88187] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Adds a test for firing popstate, using window.dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=62099

  • fast/events/fire-popstate-event-expected.txt: Added.
  • fast/events/fire-popstate-event.html: Added.

2011-06-06 Paul Kinlan <paulkinlan@google.com>

Reviewed by Jeremy Orlow.

Let developers call createEvent("PopStateEvent"), previously it wasn't
exposed and threw an exeception.
https://bugs.webkit.org/show_bug.cgi?id=62099

  • WebCore/dom/Document.cpp:
  • WebCore/dom/PopStateEvent.cpp:
  • WebCore/dom/PopStateEvent.h:
14:12 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Update Szeged slaves with links (diff)
14:02 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Wiki syntax this time (diff)
13:58 QtWebKitBuildBots edited by laszlo.1.gombos@nokia.com
Add links to the Apple master slaves (diff)
13:42 Changeset [88186] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62059

Switching paintSelection to use an IntPoint to represent the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::paintSelection):
  • rendering/EllipsisBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
  • rendering/RenderBlock.h:
13:40 BuildBot edited by rniwa@webkit.org
Added a reference to … (diff)
13:18 Changeset [88185] by mrobinson@webkit.org
  • 4 edits in trunk

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

  • GNUmakefile.am: Assign libWebCoreInternals built sources to libwebcoreinternals_built_sources before adding to the source list and to BUILT_SOURCES.

2011-06-06 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build by ensuring that the autogenerated sources
necessary for libWebCoreInternals are recorded in a predeclared
variable before assigning to BUILT_SOURCES.

  • GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
13:14 Changeset [88184] by jberlin@webkit.org
  • 4 edits in trunk/LayoutTests

Update the Windows-specific results after r88020 in order to get the bots green.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
13:00 BuildBot edited by rniwa@webkit.org
Added instruction to connect to bot master (diff)
12:57 Changeset [88183] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-06 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::clipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62045

Covered by existing tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::clipRect):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
12:57 Changeset [88182] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Skip more tests on Windows that use the Shadow DOM to get the bots green.

  • platform/win/Skipped:
12:42 Changeset [88181] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Anna Cavender <annacc@chromium.org>

Reviewed by David Levin.

Marking media/video-canvas-alpha.html as SKIP for GPU MAC.
https://bugs.webkit.org/show_bug.cgi?id=62068

  • platform/chromium/test_expectations.txt:
12:40 Changeset [88180] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Layout test expectations fix.

[chromium] Adjusting expectations for failing huge-layer-img.html

  • platform/chromium/test_expectations.txt:
12:36 Changeset [88179] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-06 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=62097
Fix the problem that integral bitfield check incorrectly barked at ?: expressions.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:21 Changeset [88178] by commit-queue@webkit.org
  • 15 edits in trunk/Source

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

No behavior change, so no tests.

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::revealSelection):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea): (WebCore::RenderBox::canBeProgramaticallyScrolled):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::autoscroll):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2011-06-06 Peter Kasting <pkasting@google.com>

Reviewed by Antonio Gomes.

Remove unnecessary args from scroll functions.
https://bugs.webkit.org/show_bug.cgi?id=61648

  • WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):
12:03 BuildBot edited by rniwa@webkit.org
Fixed indentation (diff)
12:02 BuildBot edited by rniwa@webkit.org
Added instruction to run buildbot locally (diff)
11:55 QtWebKitForQt5 edited by hausmann@webkit.org
Responding to comments (diff)
11:51 QtWebKitForQt5 edited by hausmann@webkit.org
Clean ups, clear up focus on browser development (diff)
11:51 Changeset [88177] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-06-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Enable feature/symbol detection in NWRT/GTK
https://bugs.webkit.org/show_bug.cgi?id=62136

Disable feature detection through DRT, since we don't support it,
and set the libwebcore patch correctly so that symbol detection
through 'nm' works.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
11:43 Changeset [88176] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-06 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62134

Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
IntPoint representing the paint offset instead of a pair of ints.

No new tests as this simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintSelection):
  • rendering/RenderBlock.h:
11:38 WikiStart edited by rniwa@webkit.org
Added a link to BuildBot (diff)
11:32 Changeset [88175] by yael.aharon@nokia.com
  • 3 edits
    3 adds in trunk

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

  • fast/inline/inline-wrap-with-parent-padding.html: Added.
  • platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.

2011-06-06 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459

When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.

Test: fast/inline/inline-wrap-with-parent-padding.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::LineBreaker::nextLineBreak):
11:03 Changeset [88174] by commit-queue@webkit.org
  • 12 edits in trunk

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • page/PageVisibilityState.cpp: (WebCore::pageVisibilityStateString):
  • page/PageVisibilityState.h:

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • public/WebPageVisibilityState.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setVisibilityState):

2011-06-06 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Add a "prerender" state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setPageVisibility):
11:01 Changeset [88173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-06 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Fix typo in CachedFont.cpp #define
https://bugs.webkit.org/show_bug.cgi?id=62127

No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.

  • loader/cache/CachedFont.cpp: change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
10:50 Changeset [88172] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62058

Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
their paint offsets instead of pairs of ints.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes):
  • rendering/RenderBlock.h:
10:27 BuildBot edited by rniwa@webkit.org
Added an instruction to use easy_install-2.6 on SL (diff)
10:10 Changeset [88171] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
https://bugs.webkit.org/show_bug.cgi?id=62124

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setException):
09:48 Changeset [88170] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-06 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

webkit/glue/webmediaplayer_impl.cc deletes an object of type
WebVideoFrame, which means this patch fixes a real bug, not just
a theoretical one.

[chromium] Give WebVideoFrame a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=61742

  • public/WebVideoFrame.h: (WebKit::WebVideoFrame::~WebVideoFrame):
08:49 Changeset [88169] by kinuko@chromium.org
  • 8 edits
    3 copies in branches/chromium/782

Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/storageinfo-no-callbacks-expected.txt: Added.
  • storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):

BUG=84527
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/7054073

07:57 Changeset [88168] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml.
07:52 Changeset [88167] by ossy@webkit.org
  • 3 edits in trunk/Tools

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):

  • QtTestBrowser/launcherwindow.h:
07:15 Changeset [88166] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-06 Steve Block <steveblock@google.com>

Reviewed by Yury Semikhatsky.

Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118

Correctly guard implementation of ScriptProfiler.

No new tests, build fix only.

  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::initialize):
07:12 Changeset [88165] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build fix after r88159.

  • win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.
06:53 Changeset [88164] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
06:33 Changeset [88163] by ossy@webkit.org
  • 2 edits
    45 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/qt/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/qt/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/qt/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/qt/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/qt/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/qt/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
06:27 Changeset [88162] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, new baseline for GPU test.
https://bugs.webkit.org/show_bug.cgi?id=62123

  • platform/chromium/test_expectations.txt:
06:19 Changeset [88161] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::downloadRequest): (LauncherWindow::fileDownloadFinished):
  • QtTestBrowser/launcherwindow.h:
05:41 Changeset [88160] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-06 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác

Skip a flakey test on ARM.

  • platform/qt-arm/Skipped:
05:32 Changeset [88159] by dominicc@chromium.org
  • 12 edits
    1 add in trunk

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Unskip window.internals test on Windows.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • platform/win/Skipped:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Add WebCoreTestSupport project containing window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • WebKit.vcproj/WebKit.sln:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Re-export JSC and WebCore symbols required by WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • win/WebKit2.def:

2011-06-04 Dominic Cooney <dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Make DumpRenderTree initialize window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076

  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
05:23 Changeset [88158] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml.
05:16 Changeset [88157] by bulach@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-06 Csaba Osztrogonác <ossy@webkit.org>

[Qt][WK2] Remove previously deleted tests from the Skipped list.

  • platform/qt-wk2/Skipped:
04:58 Changeset [88156] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Remove previously deleted tests from the Skipped list.

  • platform/qt-wk2/Skipped:
04:53 Changeset [88155] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip failing tests.

  • platform/qt-wk2/Skipped:
04:37 Changeset [88154] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
04:22 Changeset [88153] by bulach@chromium.org
  • 32 edits in trunk/LayoutTests

2011-06-06 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077
https://bugs.webkit.org/show_bug.cgi?id=62115

  • platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
  • platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
04:12 Changeset [88152] by ossy@webkit.org
  • 2 edits
    70 adds in trunk/LayoutTests

[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/qt/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/qt/fast/block/float/float-overhangs-root-expected.txt: Added.
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
  • platform/qt/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/qt/fast/html/details-add-details-child-1-expected.png: Added.
  • platform/qt/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-details-child-2-expected.png: Added.
  • platform/qt/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/qt/fast/html/details-nested-1-expected.png: Added.
  • platform/qt/fast/html/details-nested-1-expected.txt: Added.
  • platform/qt/fast/html/details-nested-2-expected.png: Added.
  • platform/qt/fast/html/details-nested-2-expected.txt: Added.
  • platform/qt/fast/html/details-replace-summary-child-expected.png: Added.
  • platform/qt/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/qt/fast/html/details-replace-text-expected.png: Added.
  • platform/qt/fast/html/details-replace-text-expected.txt: Added.
  • platform/qt/fast/inline/nested-top-alignment-expected.png: Added.
  • platform/qt/fast/inline/nested-top-alignment-expected.txt: Added.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/qt/fast/table/multiple-captions-display-expected.png: Added.
  • platform/qt/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-update-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-update-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/qt/svg/custom/stroke-opacity-update-expected.png: Added.
  • platform/qt/svg/custom/stroke-opacity-update-expected.txt: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.txt: Added.
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.txt: Added.
03:45 Changeset [88151] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

This patch modifies only the build system. Therefore,
there are no new tests.

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • Scripts/build-webkit:

2011-06-06 Alexandru Chiculita <achicu@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=61628

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
02:36 Changeset [88150] by mario@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-06 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88029 and r80034.

  • platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.
02:29 Changeset [88149] by morrita@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-02 MORITA Hajime <morrita@google.com>

Verify cloning <meter> and <progress> works
https://bugs.webkit.org/show_bug.cgi?id=61986

Added test cases for cloning <meter> and <progress>

  • fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-clone.html: Added.
  • fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-clone.html: Added.
01:46 Changeset [88148] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

This patch modifies only the build system. Therefore,
there are no new tests.

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Configurations/FeatureDefines.xcconfig:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • Scripts/build-webkit:

2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>

Reviewed by Kent Tamura.

Add ENABLE(CSS_REGIONS) guard for CSS Regions support
https://bugs.webkit.org/show_bug.cgi?id=61631

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
01:35 Changeset [88147] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Anders Carlsson.

[UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
https://bugs.webkit.org/show_bug.cgi?id=61538

Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
receiver code to support stream sockets, since it requires to
handle message boundaries. The same code works for DGRAM sockets,
so this change shouldn't break other ports using DGRAM.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::processMessage): Process messages from data already received. (CoreIPC::readBytesFromSocket): Read from socket using recvmsg(). (CoreIPC::Connection::readyReadHandler):
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in socketpair().
01:32 QtWebKitForQt5 edited by hausmann@webkit.org
Refine the FBO approach (diff)
01:09 Changeset [88146] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=62013

Clean up the prototypes for cursor open functions by introducing the
CursorOptions struct.

Just clean-up, no new functionality so no new tests.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon): (WebCore::CursorOptions::CursorImplCommon::firstSeek): (WebCore::CursorOptions::CursorImplCommon::continueFunction): (WebCore::CursorOptions::ObjectStoreCursorImpl::create): (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl): (WebCore::CursorOptions::IndexKeyCursorImpl::create): (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl): (WebCore::CursorOptions::IndexCursorImpl::create): (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl): (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor): (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor): (WebCore::IDBLevelDBBackingStore::openIndexCursor):
00:57 Changeset [88145] by carlosgc@webkit.org
  • 6 edits in trunk

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the GTK+ build.

  • GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
00:27 Changeset [88144] by commit-queue@webkit.org
  • 15 edits in trunk

2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=48290
Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
from failed/skipped test list

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>

Reviewed by Darin Adler.

Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
https://bugs.webkit.org/show_bug.cgi?id=48290

"highlight" is not a valid globalComposite operation
as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
Therefore, removed the option from the source code.

Tests: No new tests required.
LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator CompositeOperator):
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::applyBlending):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
  • platform/graphics/skia/SkiaUtils.cpp:

06/05/11:

23:12 Changeset [88143] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
22:54 Changeset [88142] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix.

  • platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518.
22:49 Changeset [88141] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed. Skip new failing tests.

  • platform/qt-mac/Skipped:
22:38 Changeset [88140] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected files after r88020.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:56 Changeset [88139] by inferno@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-04 Abhishek Arya <inferno@chromium.org>

Reviewed by Kent Tamura.

Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
https://bugs.webkit.org/show_bug.cgi?id=62085

Testing ComplexTextControllerLinux change requires a testcase

32 kb which is not feasible. All other changes are tested by

existing layouttests.

  • platform/graphics/TextRun.h: (WebCore::TextRun::operator[]): add assert. (WebCore::TextRun::data): add assert.
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance): bail early and prevent access to one byte across the text run boundary.
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): wrong int16 vs int comparison.
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk): bail early when from and to is outside the text run boundary. this hit easily after adding the assert when from = to = end and read in run.data(from).
21:07 Changeset [88138] by tkent@chromium.org
  • 3 edits
    2 deletes in branches/chromium/782

Merge 88137

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):

TBR=tkent@chromium.org
BUG=84819
Review URL: http://codereview.chromium.org/6993052

19:01 Changeset [88137] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

  • fast/dom/shadow/import-shadowroot-expected.txt: Removed.
  • fast/dom/shadow/import-shadowroot.html: Removed.

2011-06-05 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling out r84528.
http://trac.webkit.org/changeset/84528
https://bugs.webkit.org/show_bug.cgi?id=62100

It made several problems on elements with new shadow DOM.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
13:13 Changeset [88136] by ap@apple.com
  • 2 edits in trunk/Tools

Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
works properly).

  • Scripts/webkitpy/common/config/committers.py:
13:12 Changeset [88135] by robert@webkit.org
  • 5 edits
    3 copies
    3 adds
    2 deletes in trunk

2011-06-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089

We're unskipping acid2.html event though it's just a landing
page for the acid2 test. Some elements of the test are loaded by
the landing page so it is testing something, but acid2-pixel covers the same
ground.

  • platform/qt/Skipped:
  • platform/qt/fast/css/acid2-expected.txt: Updated
  • platform/qt/fast/css/acid2-pixel-expected.png: Added.
  • platform/qt/fast/css/acid2-pixel-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Removed.
  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Removed.
  • platform/qt/http/tests/misc/acid2-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-expected.txt: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.png: Added.
  • platform/qt/http/tests/misc/acid2-pixel-expected.txt: Added

2011-06-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089

shouldFallBack() tells the DOM if it should attempt to render
the next nested <object> if its parent fails to load.

This fix is only required for the fast/css version of the ACID2
test, which loads a non-existent file:// url. The HTTP version of the
test already passes because the loader will render fallback content
on a failed HTTP load without delegating the decision to the client
( see MainResourceLoader::continueAfterContentPolicy).

Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
what to return. This error isn't currently set by Qt so we don't check
it. (Other ports set it when the erring document is a MediaDocument, maybe
we should do that too at some point).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldFallBack):
11:34 Changeset [88134] by commit-queue@webkit.org
  • 6 edits in trunk

2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481

Rebaseline tests.

  • fast/viewport/viewport-45-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • platform/qt/Skipped:

2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481

computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
10:03 Changeset [88133] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

2011-09-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Update the library and user-facing version in preparation
for the 1.4.1 release.

  • configure.ac: Update the versions.
Note: See TracTimeline for information about the timeline view.