Timeline


and

06/12/11:

23:38 Changeset [88630] by morrita@google.com

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • platform/mac-wk2/Skipped:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKit.vcproj/WebKit.sln:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
23:20 Changeset [88629] by jer.noble@apple.com

2011-06-12 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507

No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.

If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

  • dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
22:15 Changeset [88628] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/MainResourceLoader.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
  • src/FrameLoaderClientImpl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
  • WebFrame.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
21:55 Changeset [88627] by commit-queue@webkit.org

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

  • editing/spelling/spellcheck-api-crash-expected.txt: Added.
  • editing/spelling/spellcheck-api-crash.html: Added.

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

Test: editing/spelling/spellcheck-api-crash.html

  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
21:13 Changeset [88626] by mahesh.kulkarni@nokia.com

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
20:05 Changeset [88625] by dominicc@chromium.org

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

Test: fast/harness/internals-object.html

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
19:17 Changeset [88624] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
19:05 Changeset [88623] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes should use size_t for length instead of int
https://bugs.webkit.org/show_bug.cgi?id=62508

size_t is the proper type for distances in memory, especially on 64 bit
machines.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
19:03 Changeset [88622] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.

This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
16:34 Changeset [88621] by xan@webkit.org

2011-06-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit_web_view_get_selected_text
https://bugs.webkit.org/show_bug.cgi?id=62512

It's no longer used and it's a private method, so it can be
removed.

  • webkit/webkitwebview.cpp: kill it.
  • webkit/webkitwebviewprivate.h: ditto.
14:24 Changeset [88620] by commit-queue@webkit.org

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
13:01 Changeset [88619] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Fix fullscreen/full-screen-iframe-legacy.html.

  • html/HTMLVideoElement.idl:
12:21 Changeset [88618] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.

  • webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
  • loader/FrameLoader.h:
    • cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
11:27 Changeset [88617] by mitz@apple.com

<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557

Reviewed by Darin Adler.

Replaced the fix for bug 58500 with a refined version.

  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.

10:23 Changeset [88616] by mahesh.kulkarni@nokia.com

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Reviewed by Antonio Gomes.

Tools:

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setTextDirection):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
09:57 Changeset [88615] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Minor user-gesture related cleanup
https://bugs.webkit.org/show_bug.cgi?id=62511

In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.

  • bindings/v8/NPV8Object.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLVideoElement.idl:
07:52 Changeset [88614] by paroga@webkit.org

2011-06-12 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Build fix for !ENABLE(JIT) after r88604.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
05:40 Changeset [88613] by zimmermann@webkit.org

2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add TextRun charactersLength member
https://bugs.webkit.org/show_bug.cgi?id=62501

Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).

This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.

  • platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
  • platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
  • platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer

that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.

(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
  • rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
  • rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
04:51 Changeset [88612] by robert@webkit.org

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

Our expectations for the unskipped tests have the following differences from the mac
platform:

  • POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
  • DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
  • platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html

http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html

  • platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest (WebCore::QNetworkReplyHandler::getIODevice): ditto (WebCore::QNetworkReplyHandler::sendNetworkRequest):
    • Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
    • If a custom HTTP operation contains data, send it.
  • platform/network/qt/QNetworkReplyHandler.h:

06/11/11:

23:01 Changeset [88611] by msaboff@apple.com

2011-06-11 Michael Saboff <msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

  • platform/graphics/FontCache.cpp:
21:19 Changeset [88610] by abarth@webkit.org

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary strlen from DocumentWriter
https://bugs.webkit.org/show_bug.cgi?id=62505

This ugly piece of code appears not to be needed. Rejoice.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/DocumentWriter.h:
17:51 Changeset [88609] by abarth@webkit.org

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=62499

This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.

There's still lots of on contorting to do here, but it's a start.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/DocumentWriter.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
13:34 Changeset [88608] by rniwa@webkit.org

2011-06-11 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaseline after r85560.

Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:28 Changeset [88607] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::warmInitialProcess):

  • UIProcess/WebContext.h:
13:21 Changeset [88606] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/database-name-undefined-expected.txt: Removed.
  • storage/indexeddb/database-name-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBFactory.idl:
13:16 Changeset [88605] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):

  • wtf/DateMath.cpp:

(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

13:07 Changeset [88604] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):

  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:
  • wtf/Platform.h:
11:09 Changeset [88603] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Remove expectation of failure after clobber.
https://bugs.webkit.org/show_bug.cgi?id=62364

  • platform/chromium/test_expectations.txt: Removed.
10:12 Changeset [88602] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/setVersion-undefined-expected.txt: Removed.
  • storage/indexeddb/setVersion-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.idl:
09:37 Changeset [88601] by inferno@chromium.org

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230

When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.

Tests: fast/dom/body-link-decl-parent-crash.html

fast/dom/styled-inline-style-decl-parent-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
  • html/HTMLBodyElement.h:

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62230

  • fast/dom/body-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-link-decl-parent-crash.html: Added.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Added.

06/10/11:

23:45 Changeset [88600] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Remove bogus ASSERTs. These ASSERTs used to be correct before I
changed DocumentWriter to put the onus for ignoring empty writes onto
the parser.

This patch should stop these test from triggering ASSERTs:

plugins/plugin-document-back-forward.html
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
userscripts/user-script-plugin-document.html

  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
23:23 Changeset [88599] by jer.noble@apple.com

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

AVPlayerLayer is adding a "fade" animation during Safari full-screen
https://bugs.webkit.org/show_bug.cgi?id=62433

CoreAnimation will add default animations when certain properties are changed, unless
those changes are wrapped in a CATransaction which has had its disableActions property set
to true. Wrap each of these three property changes in a CATransaction and disable its actions,
so that the default "fade" animation is not created in response.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction. (-[WKFullScreenWindowController _swapView:with:]): Ditto:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto.
23:04 Changeset [88598] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: 'images' links on results.html don't work
https://bugs.webkit.org/show_bug.cgi?id=62194

Use relative path when generating images-diffs.html

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname.
22:52 Changeset [88597] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and
svg/custom/focus-event-handling-keyboard.html on Mac WebKit2
because they use DRT features not supported by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
21:56 Changeset [88596] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

GTK and Qt rebaselines after r88555.

  • platform/gtk/svg/custom/focus-ring-expected.txt:
  • platform/qt/svg/custom/focus-ring-expected.txt:
21:53 Changeset [88595] by jamesr@google.com

2011-06-10 James Robinson <jamesr@chromium.org>

[chromium] Update chromium gpu baselines

  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/chromium/test_expectations.txt:
21:35 Changeset [88594] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows.

  • platform/chromium/fast/harness/results-expected.txt:
  • platform/win/fast/harness/results-expected.txt:
21:14 Changeset [88593] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac
because it has been failing on the bot; the failure is tracked by the bug 62364.

  • platform/chromium/test_expectations.txt:
21:05 Changeset [88592] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: results.html don't list the same list of failed tests as bots do
https://bugs.webkit.org/show_bug.cgi?id=62425

Fixed the bug by hiding expected crash, timeout, pass, etc... by default.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
20:36 Changeset [88591] by jer.noble@apple.com

2011-06-10 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411

  • fullscreen/full-screen-remove-ancestor-after-expected.txt: Added.
  • fullscreen/full-screen-remove-ancestor-after.html: Added.
  • platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411

Test: fullscreen/full-screen-remove-ancestor-after.html

The placeholder for RenderFullScreen was being created as a non-anonymous object, which led
to the document's renderer being set to 0 when the placeholder was removed due to its parent
being removed. Setting the placeholder to be anonymous, however, means that it will be
coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the
list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder
being so coalesced. To do so, made the placeholder object a true subclass, and add and
override its destroy() function to notify the RenderFullScreen object that it has been
destroyed.

  • rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder

has been destroyed.

(RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it.
(RenderFullScreen::setPlaceholder): Added.
(RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous.

  • rendering/RenderFullScreen.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added. (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of

objects which are not anonymous blocks.

19:51 Changeset [88590] by jamesr@google.com

2011-06-10 James Robinson <jamesr@chromium.org>

[chromium] Update chromium compositor baselines for r88580

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:06 Changeset [88589] by lforschler@apple.com

2011-06-10 Lucas Forschler <lforschler@apple.com>

Reviewed by Stephanie Lewis.

Script to kill old processes on Mac.
This matches the windows version.
https://bugs.webkit.org/show_bug.cgi?id=62479

  • BuildSlaveSupport/mac: Added.
  • BuildSlaveSupport/mac/kill-old-processes: Added.
19:04 Changeset [88588] by andersca@apple.com

2011-06-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

REGRESSION (WebKit2): window.showModalDialog() broken
https://bugs.webkit.org/show_bug.cgi?id=62496
<rdar://problem/9581492>

If dispatching a message ends up creating a nested run loop, some incoming messages can end up not being
delivered until we exit from the run loop.

Fix this by using a Deque instead of a Vector for incoming messages, and get one message at a time and then
dispatch it. That prevents us from having any lingering messages lying around in stack allocated space.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::dispatchMessages):
  • Platform/CoreIPC/Connection.h:
19:03 Changeset [88587] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.

Remove JSC::Inf, JSC::NaN, switch some cases of (isnan
isinf) to !isfinite.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::toNumber):

  • API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

(JSC::CachedTranscendentalFunction::initialize):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toNumber):

  • runtime/JSValue.cpp:
  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::jsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

  • runtime/NumberConstructor.cpp:

(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/UString.cpp:
  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

  • wtf/dtoa.cpp:

(WTF::dtoa):

Source/WebCore:

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

18:56 Changeset [88586] by simonjam@chromium.org

2011-06-10 James Simonsen <simonjam@chromium.org>

Unreviewed, missing expectations for non-V8 from change 88584.
https://bugs.webkit.org/show_bug.cgi?id=62412

  • html5lib/runner-expected.txt:
18:18 Changeset [88585] by weinig@apple.com

2011-06-10 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Unresponsive cursor is shown when displaying a modal dialog
Part of <rdar://problem/9581492>
https://bugs.webkit.org/show_bug.cgi?id=62494

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runModal):
  • UIProcess/WebPageProxy.h: Stop the responsiveness timer when calling out to show a modal dialog.
18:08 Changeset [88584] by simonjam@chromium.org

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412

  • platform/chromium/html5lib/runner-expected.txt: Passes another test.
  • svg/dom/range-delete-expected.txt: Removed.
  • svg/dom/range-delete.html: Removed.
  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
  • svg/dom/use-style-recalc-script-execute-crash.html:
  • svg/in-html/resources/external.js: Added.
  • svg/in-html/script-expected.txt: Added.
  • svg/in-html/script-external-expected.txt: Added.
  • svg/in-html/script-external.html: Added.
  • svg/in-html/script-nested-expected.txt: Added.
  • svg/in-html/script-nested.html: Added.
  • svg/in-html/script-write-expected.txt: Added.
  • svg/in-html/script-write.html: Added.
  • svg/in-html/script.html: Added.

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412

Tests: svg/in-html/script-external.html

svg/in-html/script-nested.html
svg/in-html/script-write.html
svg/in-html/script.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
17:56 Changeset [88583] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336

Triggering this condition is very hard to do deterministically. This
test attempts to trigger the condition by sending exactly the right
number of bytes for the Chromium network stack. As network stacks vary
and evolve, it's likely we'll lose test coverage for this issue, but
this is the best test I could come up with.

  • fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
  • fast/parser/document-write-ignores-later-network-bytes.html: Added.

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336

If the network packet boundaries line up just right, we can end up
feeding network data to a parser created by document.write (or
document.open). That's incorrect.

This patch causes DocumentWriter to grab hold of the original parser
and direct all input to that parser.

Test: fast/parser/document-write-ignores-later-network-bytes.html

  • dom/Document.cpp: (WebCore::Document::explicitClose):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource): (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
  • loader/DocumentWriter.h:
17:39 Changeset [88582] by commit-queue@webkit.org

2011-06-10 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by James Robinson.

Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=62149

Added page overlay for inspector highlight support.

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
  • src/PageOverlay.cpp: Added. (WebKit::PageOverlay::create): (WebKit::PageOverlay::PageOverlay): (WebKit::OverlayGraphicsLayerClientImpl::create): (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl): (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted): (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired): (WebKit::OverlayGraphicsLayerClientImpl::paintContents): (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders): (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter): (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl): (WebKit::PageOverlay::clear): (WebKit::PageOverlay::update): (WebKit::PageOverlay::paintWebFrame): (WebKit::PageOverlay::invalidateWebFrame):
  • src/PageOverlay.h: Added. (WebKit::PageOverlay::~PageOverlay): (WebKit::PageOverlay::setClient):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::paintPageOverlay): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight):
  • src/WebDevToolsAgentImpl.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setPageOverlayClient): (WebKit::WebViewImpl::setOverlayLayer): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setRootPlatformLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::pageOverlay):
17:38 Changeset [88581] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by James Robinson.

When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
https://bugs.webkit.org/show_bug.cgi?id=62489

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
17:22 Changeset [88580] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Keep overlap testing logic until real 3d transforms are being used
https://bugs.webkit.org/show_bug.cgi?id=49857

For pages that use the translateZ(0) hack to force compositing layers, it's
advantageous to keep overlap testing, to avoid putting too many other
elements into layers.

Only turn off overlap testing if non-identity 3D transforms are used.

Tests: compositing/layer-creation/rotate3d-overlap.html

compositing/layer-creation/translatez-overlap.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
  • rendering/RenderLayerCompositor.h:
17:21 Changeset [88579] by levin@chromium.org

Web Worker fails to fire error event when a resource fetch fails.
https://bugs.webkit.org/show_bug.cgi?id=62475

Reviewed by Dmitry Titov.

Source/WebCore:

Test: http/tests/workers/worker-workerScriptNotThere.html

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.

LayoutTests:

  • http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
  • http/tests/workers/worker-workerScriptNotThere.html: Added.
17:11 Changeset [88578] by levin@chromium.org

Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
https://bugs.webkit.org/show_bug.cgi?id=62469

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/workers/worker-crash-with-invalid-location.html

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.

  • workers/Worker.cpp:

(WebCore::Worker::create): Ditto.

  • workers/Worker.h: Ditto.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts): Ditto.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.

  • workers/WorkerScriptLoader.h: Made this RefCounted to allow for

keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):

Source/WebKit/chromium:

Test: fast/workers/worker-crash-with-invalid-location.html

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.

LayoutTests:

  • fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
  • fast/workers/worker-crash-with-invalid-location.html: Added.
16:55 Changeset [88577] by alokp@chromium.org

2011-06-10 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Top portion of page is rendered messed up with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=62484

Fixed the math in flipping the texture from bottom-up to top-down.
Test: compositing/repaint/shrink-layer.html (existing)

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
16:35 Changeset [88576] by tony@chromium.org

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Scripts/build-webkit:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
16:27 Changeset [88575] by levin@chromium.org

2011-06-10 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

Add tests for Web Workers at invalid urls.
https://bugs.webkit.org/show_bug.cgi?id=62486

  • http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
  • http/tests/workers/shared-worker-invalid-url.html: Added.
  • http/tests/workers/worker-invalid-url-expected.txt: Added.
  • http/tests/workers/worker-invalid-url.html: Added.
15:55 Changeset [88574] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Turns out, linux baseline isn't spurious.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
15:43 Changeset [88573] by weinig@apple.com

Roll out r88568. It is not the right fix for the problem.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

15:21 Changeset [88572] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Remove all spurious copies of test expectations that somehow made it into the tree.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
15:20 Changeset [88571] by mrowe@apple.com

<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.

Reviewed by Dimitri Glazkov.

Source/WebCore:

Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.

Install the library and its associated header file in a more appropriate location
for the production configuration.

  • Configurations/WebCoreTestSupport.xcconfig:

Tools:

Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
14:53 Changeset [88570] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=62471

RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
in a way that was safe to call during existing style recalc or layout.

Move this code to ContainerElement so it can be called elsewhere.
Also add a param to the node callback so we can pass the style change type.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): (WebCore::ContainerNode::dispatchPostAttachCallbacks): (WebCore::needsStyleRecalcCallback): (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
  • dom/ContainerNode.h:
  • dom/Node.h: (WebCore::Node::scheduleSetNeedsStyleRecalc):
  • html/HTMLFormControlElement.cpp: (WebCore::focusPostAttach): (WebCore::updateFromElementCallback):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
  • html/HTMLPlugInImageElement.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::attachRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
  • rendering/RenderLayerCompositor.h:
  • svg/SVGUseElement.cpp: (WebCore::updateFromElementCallback):
14:42 Changeset [88569] by commit-queue@webkit.org

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

  • storage/indexeddb/database-name-undefined-expected.txt: Added.
  • storage/indexeddb/database-name-undefined.html: Added.

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

Test: storage/indexeddb/database-name-undefined.html

  • storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
14:34 Changeset [88568] by weinig@apple.com

Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>

Reviewed by Beth Dakin.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.

14:25 Changeset [88567] by eae@chromium.org

2011-06-10 Emil A Eklund <eae@chromium.org>

Land Windows expectations for new test added in r88556.

  • platform/win/printing/page-count-relayout-shrink-expected.txt: Added.
14:16 Changeset [88566] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Document::finishParsing
https://bugs.webkit.org/show_bug.cgi?id=62474

This function appears to exist only to confuse and befuddle us. This
patch prepares for DocumentWriter to grab hold of the parser.

This patch removes one of the print statements from
INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finish):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stop):
14:14 Changeset [88565] by commit-queue@webkit.org

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
14:04 Changeset [88564] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Null-check the layer owner again when painting layers
https://bugs.webkit.org/show_bug.cgi?id=62473

Speculative fix for a crash that occurs when the layer's owner
gets destroyed during painting.

  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
13:59 Changeset [88563] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Land expectations for a test, added in r88556.

  • platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.
13:54 Changeset [88562] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[V8] Add failure expectation for a test, added in r88559.

  • platform/chromium/test_expectations.txt: Added.
13:49 Changeset [88561] by robert@webkit.org

2011-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Lighten the --no-svg build a little
https://bugs.webkit.org/show_bug.cgi?id=62314

Only generate source from SVG*.idl if the build is svg-enabled.

  • CodeGenerators.pri:
13:39 Changeset [88560] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Remove expectation of crash, fixed in r88551.

  • platform/chromium/test_expectations.txt: Removed expectation.
13:33 Changeset [88559] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

This arises from chapter 15 of the spec:

"Every other property described in this clause has the attributes
{ Writable?: true, Enumerable?: false, Configurable?: true }
unless otherwise specified."

Standardized properties are not enumerable.

Source/JavaScriptCore:

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

LayoutTests:

  • fast/js/exception-properties-expected.txt: Added.
  • fast/js/exception-properties.html: Added.
  • fast/js/script-tests/exception-properties.js: Added.

(enumerableProperties):

13:29 Changeset [88558] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Update expectations after r88555.

  • platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.
13:15 Changeset [88557] by zimmermann@webkit.org

2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
https://bugs.webkit.org/show_bug.cgi?id=62441

Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.

Doesn't affect any test so far.

  • platform/graphics/SVGGlyph.h: (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk):
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::collectGlyphsForString): (WebCore::SVGFontElement::collectGlyphsForGlyphName): (WebCore::SVGFontElement::svgGlyphForGlyph): (WebCore::SVGFontElement::missingGlyph):
  • svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair):
  • svg/SVGGlyphMap.h: (WebCore::SVGGlyphMap::addGlyphByUnicodeString): (WebCore::SVGGlyphMap::addGlyphByName): (WebCore::SVGGlyphMap::appendToGlyphTable): (WebCore::SVGGlyphMap::collectGlyphsForString): (WebCore::SVGGlyphMap::clear): (WebCore::SVGGlyphMap::svgGlyphForGlyph): (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
12:44 Changeset [88556] by eae@chromium.org

2011-06-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

  • platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • printing/page-count-relayout-shrink.html: Added.

2011-06-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

Test: printing/page-count-relayout-shrink.html

  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
12:43 Changeset [88555] by rwlbuis@webkit.org

2011-06-10 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

animation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545

Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.

  • platform/mac/svg/custom/focus-ring-expected.txt:
  • svg/custom/focus-event-handling-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard.xhtml: Added.
  • svg/custom/focus-event-handling.xhtml: Added.
  • svg/custom/resources/focus-event-handling-keyboard.js: Added. (focusinHandler): (focusoutHandler):
  • svg/custom/resources/focus-event-handling.js: Added. (clearFocusSeen): (): (focusoutHandler): (clickAt):

2011-06-10 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

amation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545

Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:

http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute

Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.

Tests: svg/custom/focus-event-handling-keyboard.xhtml

svg/custom/focus-event-handling.xhtml

  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeRectForRepaint):
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::supportsFocus):
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::supportsFocus):
  • svg/SVGGElement.h: (WebCore::SVGGElement::supportsFocus):
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::supportsFocus):
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::supportsFocus):
  • svg/SVGPathElement.h: (WebCore::SVGPathElement::supportsFocus):
  • svg/SVGPolyElement.h: (WebCore::SVGPolyElement::supportsFocus):
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::supportsFocus):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::supportsFocus):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isMouseFocusable): (WebCore::SVGStyledElement::isKeyboardFocusable):
  • svg/SVGStyledElement.h:
  • svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::supportsFocus):
  • svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::supportsFocus):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::supportsFocus):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::supportsFocus):
11:35 Changeset [88554] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
11:17 Changeset [88553] by macpherson@chromium.org

2011-06-10 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Clean up CSSPrimitiveValue::computeLength*
https://bugs.webkit.org/show_bug.cgi?id=61612

No new tests as no functionality changed.

  • css/CSSGradientValue.cpp: Use new computeLength functions.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthIntForLength): Reduce to a single function using default parameter values. (WebCore::CSSPrimitiveValue::computeLength): Redefine existing functions with separate names as a single function using templated function specialization.
  • css/CSSPrimitiveValue.h: Prototypes for computeLengthIntForLength and computeLength.
  • css/CSSStyleApplyProperty.cpp: Use new computeLength functions.
  • css/CSSStyleSelector.cpp: Use new computeLength functions.
  • css/MediaQueryEvaluator.cpp: Use new computeLength functions.
  • css/SVGCSSStyleSelector.cpp: Use new computeLength functions.
11:10 Changeset [88552] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Add utility to RenderLayer to determine if the layer is scrollable
https://bugs.webkit.org/show_bug.cgi?id=62467

New method that returns true if either scrollbar is present and enabled.
Not called anywhere yet.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::allowsScrolling):
  • rendering/RenderLayer.h:
10:56 Changeset [88551] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Tony Chang.

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
https://bugs.webkit.org/show_bug.cgi?id=62460

Test: fast/dom/prototype-inheritance-2.html

  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.
10:51 Changeset [88550] by dglazkov@chromium.org

Revert r87319 on 782 branch.

10:31 Changeset [88549] by inferno@chromium.org

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Tony Gentilcore.

Tests that trying to remove all document children while building a svg <use>
element shadow and instance tree does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62225

  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
  • svg/dom/use-style-recalc-script-execute-crash.html: Added.

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Don't execute scripts in shadow SVG.
https://bugs.webkit.org/show_bug.cgi?id=62225

Test: svg/dom/use-style-recalc-script-execute-crash.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::prepareScript):
10:31 Changeset [88548] by tony@chromium.org

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] make features.gypi the same as features_override.gypi
https://bugs.webkit.org/show_bug.cgi?id=62399

Make the file the same as chromium's features_override.gypi so we
can remove features_override.gypi in chromium.

Remove ENABLE_DATAGRID=0 since the define is gone and remove
ENABLE_FULLSCREEN_API=1 since we want to disable it.

  • features.gypi:
10:29 Changeset [88547] by loislo@chromium.org

2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>

Reviewed by Joseph Pecoraro.

Fixed build with enabled workers and disabled inspector
https://bugs.webkit.org/show_bug.cgi?id=62461

  • inspector/InspectorWorkerAgent.cpp: Added inspector guard
10:05 Changeset [88546] by darin@apple.com

2011-06-10 Darin Adler <darin@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Fullscreen video controller can't be dragged
https://bugs.webkit.org/show_bug.cgi?id=62462

No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new booleans related to dragging. (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging is allowed and a drag isn't already in progress. (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if dragging is already in progress. (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is done during the dragging process. (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel using explicit top/left. (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning done by setPosition. (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag, continueDrag, and endDrag in response to mouse events. (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
  • html/shadow/MediaControlElements.h: Added new function and data members as mentioned above.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true) so you can drag the panel while in fullscreen. (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false) so you can't drag the panel while not in fullscreen. Also call resetPosition so position changes from dragging don't affect the panel in other contexts.
10:00 Changeset [88545] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Remove tests that are now passing.

  • platform/chromium/test_expectations.txt: Removed passing tests.
09:52 Changeset [88544] by darin@apple.com

2011-06-10 Darin Adler <darin@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Full screen video HUD is positioned too low for standalone video documents
https://bugs.webkit.org/show_bug.cgi?id=62463

No test because we don't currently have machinery for testing fullscreen.

  • css/fullscreen.css: Removed rule that said bottom: 0px for the control panel for full page media in full screen mode. This is not needed because the control panel for full screen mode already has style rules to set its vertical position. (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said -webkit-tranform. This will fix a potential problem where fullscreen would malfunction on a page that had a media element inside a transform.
09:06 Changeset [88543] by sergio@webkit.org

2011-06-10 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Add support for non-ASCII filenames in Content-Disposition header
https://bugs.webkit.org/show_bug.cgi?id=62454

Try latin1 as fallback for header parameter values as some servers
do not follow RFC 2045 for example with filename parameter in
Content-Disposition.

No new tests required as no functionality changed.

  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
08:55 Changeset [88542] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
https://bugs.webkit.org/show_bug.cgi?id=62460

  • platform/chromium/test_expectations.txt: Updated test expectations.
04:56 Changeset [88541] by commit-queue@webkit.org

2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925

Added a static factory protected member to GraphicsLayer, which should be accessed from
a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.

This is needed for accelerated compositing across processes in WebKit2, since WebCore
doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
different implementations of GraphicsLayer coexist impossible without some runtime
factory that can be overridden by the web process.

Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
would have to explicitly call it, in order to be unintrusive with current implementations.

No new functionality, so no new tests.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setGraphicsLayerFactory):
  • platform/graphics/GraphicsLayer.h:
04:34 Changeset [88540] by commit-queue@webkit.org

2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
https://bugs.webkit.org/show_bug.cgi?id=62346

Add WebProcess/WebCoreSupport/efl directory and files.

  • WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added. (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added. (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError): (WebKit::pluginWillHandleLoadError):
  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
  • WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
04:32 Changeset [88539] by commit-queue@webkit.org

2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376

Add files that need to be compiled in every port for supporting WebGL.
Each port still needs to add its specific files to
CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
yet.

  • Source/CMakeLists.txt: Add files needed to support WebGL.
  • Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
  • Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is enabled.

2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376

Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.

No change in functionality so no new tests.

  • CMakeLists.txt:
04:31 Changeset [88538] by andreas.kling@nokia.com

2011-06-10 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Fix 'headers' autotest when building inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=62449

  • Api/qwebkitplatformplugin.h:
04:30 Changeset [88537] by commit-queue@webkit.org

2011-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL]add image content hint information for tile image object when it is created
https://bugs.webkit.org/show_bug.cgi?id=62436

When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
In order to support this enhanced feature, image content hint information must be
specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC

  • ewk/ewk_tiled_model.c: (ewk_tile_new):
04:23 Changeset [88536] by commit-queue@webkit.org

2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
https://bugs.webkit.org/show_bug.cgi?id=62435

No new tests required as just fixed warning.

  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::PlatformContextCairo):

2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
03:15 Changeset [88535] by loislo@chromium.org

2011-06-10 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
03:06 Changeset [88534] by laszlo.1.gombos@nokia.com

2011-06-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=62420

ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
but they meant to be independent.

  • Api/qwebframe.cpp: (QWebFramePrivate::_q_orientationChanged): (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
02:09 Changeset [88533] by commit-queue@webkit.org

2011-06-10 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Repaint throttling API.
https://bugs.webkit.org/show_bug.cgi?id=56178

The API allows to set the values for repaint throttling.
It should ensure displaying a content with many css/gif animations.

  • ewk/ewk_settings.cpp: (ewk_settings_repaint_throttling_set):
  • ewk/ewk_settings.h:
01:56 Changeset [88532] by gyuyoung.kim@samsung.com

2011-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use makeString() when getting os version
https://bugs.webkit.org/show_bug.cgi?id=62434

When os version string is created, to use makeString() is better than
String operation.

  • ewk/ewk_settings.cpp: (_ewk_settings_webkit_os_version_get):
01:41 Changeset [88531] by loislo@chromium.org

2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/InspectorValues.cpp:
01:33 Changeset [88530] by loislo@chromium.org

2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
00:35 Changeset [88529] by yurys@chromium.org

2011-06-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Worker object may be garbage collected even if it has message handlers
https://bugs.webkit.org/show_bug.cgi?id=62292

I'd like to convert the test case into a layout test but I don't see yet
how to do this so that the test isn't too slow and reliable. The problem
with test is that full-GC needs to be triggered right after
WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
So no test for now.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending activity state every time a message is confirmed since the message may have created a new activity.
  • src/WebWorkerClientImpl.h:
00:10 Changeset [88528] by jer.noble@apple.com

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=62402

Sites are able to override the "overflow:hidden" rule for root full-screen nodes
simply by adding a "html {}" rule. Make this rule !important, and also make it apply
to root nodes who are merely ancestors of full-screen elements, to cover the case of
a root node containing an <iframe> whose contents have gone full-screen.

  • css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen),

:root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
who are full-screen ancestors, and make them !important.

06/09/11:

23:42 Changeset [88527] by mahesh.kulkarni@nokia.com

2011-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTests/fast/history/history_reload.html failing
https://bugs.webkit.org/show_bug.cgi?id=62369

Unskipping. Generating click of button element in generic way.
Remove hardcoding of click co-ordinates to avoid native font differences.

  • fast/history/history_reload.html:
  • platform/qt/Skipped:
23:20 Changeset [88526] by macpherson@chromium.org

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=61495

No new tests required as no functionality changed.

  • css/CSSPrimitiveValueMappings.h: Support cast to/from Order
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): Convert from bool to enum type. (WebCore::CSSStyleSelector::applyProperty): Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
  • dom/Document.cpp: (WebCore::Document::setVisuallyOrdered): Change call to RenderStyle::setRTLOrdering using enum parameter.
  • rendering/style/RenderStyle.h: rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
  • rendering/style/RenderStyleConstants.h: Define enum type.
23:19 Changeset [88525] by macpherson@chromium.org

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61601

No new tests. No new functionality added / covered by existing tests.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EBorderStyle): Support CSSValueAuto as required by outline-style property. (WebCore::CSSPrimitiveValue::operator OutlineIsAuto): Add cast to new OutlineIsAuto enum.
  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialize handler for CSSPropertyOutlineStyle.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove old handler for CSSPropertyOutlineStyle.
  • rendering/style/OutlineValue.h: Use new OutlineIsAuto enum instead of bool.
  • rendering/style/RenderStyle.h: Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties. Use new OutlineIsAuto enum type.
  • rendering/style/RenderStyleConstants.h: Define new enum OutlineIsAuto.
23:17 Changeset [88524] by macpherson@chromium.org

2011-06-09 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
https://bugs.webkit.org/show_bug.cgi?id=62418

No new tests / cleanup only.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyDefaultBase::applyInheritValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::applyInitialValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::setValue): Wrapper for calling m_setter function pointer. (WebCore::ApplyPropertyDefaultBase::value): Wrapper for calling m_getter function pointer. (WebCore::ApplyPropertyDefaultBase::initial): Wrapper for calling m_initial function pointer. (WebCore::ApplyPropertyDefault::applyValue): Use new setValue function. (WebCore::ApplyPropertyLength::applyValue): Use new setValue function. (WebCore::ApplyPropertyWidth::applyValue): Use new setValue function.
23:16 Changeset [88523] by koz@chromium.org

2011-06-09 James Kozianski <koz@chromium.org>

Unreviewed, rolling out r88466.
http://trac.webkit.org/changeset/88466
https://bugs.webkit.org/show_bug.cgi?id=60059

Broke PPAPITest.URLLoader test on the chromium bots

  • WebKit.gyp:
  • WebKit.gypi:
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::loadAsynchronously):
  • tests/AssociatedURLLoaderTest.cpp: Removed.
22:54 Changeset [88522] by keishi@webkit.org

Rollback 88521

22:49 Changeset [88521] by keishi@webkit.org

test

21:43 Changeset [88520] by ggaren@apple.com

Build fix: Corrected header spelling.

  • heap/OldSpace.h:
21:38 Changeset [88519] by ggaren@apple.com

2011-06-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Added OldSpace to the project
https://bugs.webkit.org/show_bug.cgi?id=62417


Currently unused.


Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
per-block flag for testing whether you're in NewSpace vs OldSpace.

  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • heap/MarkedBlock.h: (JSC::MarkedBlock::inNewSpace): (JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in write barrier.
  • heap/NewSpace.cpp: (JSC::NewSpace::addBlock): (JSC::NewSpace::removeBlock):
  • heap/NewSpace.h: (JSC::NewSpace::forEachBlock): Added forEachBlock, to use for NewSpace-specific operations.
  • heap/OldSpace.cpp: Added. (JSC::OldSpace::OldSpace): (JSC::OldSpace::addBlock): (JSC::OldSpace::removeBlock):
  • heap/OldSpace.h: Added. (JSC::OldSpace::forEachBlock): New class for holding promoted blocks. Not in use yet.
20:52 Changeset [88518] by commit-queue@webkit.org

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.

  • wtf/Platform.h:

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add a new class, GraphicsLayerEfl - not yet implemented.
Add ACCELERATED_COMPOSITING related files to CMakeLists.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • platform/graphics/efl/GraphicsLayerEfl.cpp: Added. (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerEfl::GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::setNeedsDisplay): (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
  • platform/graphics/efl/GraphicsLayerEfl.h: Added.

2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361

Add functions for accelerated compositing to ChromeClientEfl.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::attachRootGraphicsLayer): (WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization): (WebCore::ChromeClientEfl::scheduleCompositingLayerSync): (WebCore::ChromeClientEfl::allowedCompositingTriggers):
  • WebCoreSupport/ChromeClientEfl.h:
20:45 Changeset [88517] by demarchi@webkit.org

2011-06-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[CMAKE] Never let USER_AGENT defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=62410

This patch is similar to r88342, but sets WEBKIT_USER_AGENT_*
definitions only if that port defined it. A port might prefer to set it
in other place, e.g. a header that is part of the public API (like GTK
does).

By using #cmakedefine instead of #define, if that variable is not set
in CMake it will expand to:

/* #define WEBKIT_USER_AGENT_MAJOR_VERSION */

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:
19:50 Changeset [88516] by ossy@webkit.org

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

Last attempt to make buildbot happy against crazy flakiness near inspector tests. :-/

  • platform/qt/Skipped: Disable all inspector tests until fix.
19:43 Changeset [88515] by demarchi@webkit.org

2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Brent Fulgham.

[efl] Do not enable the encoding detector by default.
https://bugs.webkit.org/show_bug.cgi?id=61744

This should match the behaviour of other ports more closely, and makes
at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
19:30 Changeset [88514] by ossy@webkit.org

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

One more attempt to make buildbot happy
against crazy flakiness near inspector tests. :-/

  • platform/qt/Skipped:
18:59 Changeset [88513] by ossy@webkit.org

Unreviewed rolling out r88471, because it broke plugin tests on Qt.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventX11):
(NPP_GetValue):

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.

(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(executeScript):
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_stream_as_file):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
(webkit_test_plugin_print):
(keyEventToChar):
(webkit_test_plugin_handle_event):
(webkit_test_plugin_url_notify):
(webkit_test_plugin_get_value):
(webkit_test_plugin_set_value):
(NP_GetMIMEDescription):
(NP_Initialize):
(NP_Shutdown):
(NP_GetValue):

  • GNUmakefile.am:

LayoutTests:

  • platform/chromium-linux/plugins/mouse-events-expected.txt:
18:42 Changeset [88512] by jianli@chromium.org

Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.

BUG=85659
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/7003106

18:31 Changeset [88511] by tkent@chromium.org

[Mac] Unskip fast/forms/input-number-large-padding.html
https://bugs.webkit.org/show_bug.cgi?id=61845

It should work now because we don't use outer-spin-button anymore.

  • platform/mac/Skipped:
18:09 Changeset [88510] by jianli@chromium.org

Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.
18:08 Changeset [88509] by koz@chromium.org

2011-06-09 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Remove expectations for passing tests.

  • platform/chromium/test_expectations.txt:
17:50 Changeset [88508] by jamesr@google.com

2011-06-09 James Robinson <jamesr@chromium.org>

[chromium] Update some chromium gpu baselines

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/test_expectations.txt:
17:30 Changeset [88507] by jamesr@google.com

2011-06-09 James Robinson <jamesr@chromium.org>

[chromium] Mark the fullscreen directory as skipped
https://bugs.webkit.org/show_bug.cgi?id=62397

  • platform/chromium/test_expectations.txt:

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=62397

Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
even when the runtime setting was disabled.

  • features.gypi:
17:30 Changeset [88506] by barraclough@apple.com

Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Geoff Garen.

Fix geoff's review comments re static_cast.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

17:03 Changeset [88505] by jer.noble@apple.com

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by David Hyatt.

Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
https://bugs.webkit.org/show_bug.cgi?id=62400

No new tests; covered by existing fullscreen/full-screen-video-offset.html test.

  • rendering/RenderVideo.cpp: (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists. (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block. (WebCore::RenderVideo::offsetTop): Ditto. (WebCore::RenderVideo::offsetWidth): Ditto. (WebCore::RenderVideo::offsetHeight): Ditto.
  • rendering/RenderVideo.h: Added virtual overrides for the offset functions.
17:02 Changeset [88504] by ggaren@apple.com

2011-06-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Factored MarkedBlock set management into a helper class with a fast case Bloom filter
https://bugs.webkit.org/show_bug.cgi?id=62413


SunSpider reports a small speedup.


This is in preparation for having ConservativeSet operate on arbitrary
sets of MarkedBlocks, and in preparation for conservative scanning
becoming proportionally more important than other GC activities.

  • heap/ConservativeRoots.cpp: (JSC::ConservativeRoots::add):
  • heap/ConservativeRoots.h: (JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet directly, instead of a Heap, so we can operate on subsets of the Heap instead.


Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
is particularly important since we expect not to find our subject pointer
in the MarkedBlock hash, and hash misses are more expensive than typical
hash lookups because they have high collision rates.


No need for single-pointer add() to be public anymore, since nobody uses it.

  • heap/Heap.cpp: (JSC::Heap::markRoots):
  • heap/Heap.h: (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what ConservativeRoots relies on.


Nixed contains(), since nobody uses it anymore.

  • heap/MarkedBlock.h: (WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of the VM layout properties of MarkedBlocks.
  • heap/MarkedBlockSet.h: Added. (JSC::MarkedBlockSet::add): (JSC::MarkedBlockSet::remove): (JSC::MarkedBlockSet::recomputeFilter): (JSC::MarkedBlockSet::filter): (JSC::MarkedBlockSet::set):
  • heap/TinyBloomFilter.h: Added. (JSC::TinyBloomFilter::TinyBloomFilter): (JSC::TinyBloomFilter::add): (JSC::TinyBloomFilter::ruleOut): New helper class, used above.
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots): No need to specifically exclude values by tag -- the tiny bloom filter is already a register-register compare, so adding another "rule out" factor just slows things down.
16:46 Changeset [88503] by barraclough@apple.com

Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Oliver Hunt.

There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.

Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.

These errors result in three test-262 failures.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

  • runtime/JSArray.cpp:

(JSC::JSArray::put):
(JSC::JSArray::push):

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:
16:37 Changeset [88502] by lforschler@apple.com

New tag.

16:37 Changeset [88501] by jamesr@google.com

Merge 88496 - 2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

Tests that a layer that should clip its children actually does clip even when scrolled offscreen.

  • platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
  • platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
  • platform/chromium/compositing/scissor-out-of-viewport.html: Added.

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.

This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.

Test: platform/chromium/compositing/scissor-out-of-viewport.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):

BUG=84122
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7046081

16:36 Changeset [88500] by lforschler@apple.com

real fix for 88481. (remove tabs)

16:35 Changeset [88499] by lforschler@apple.com

Remove Tag.

16:33 Changeset [88498] by mrobinson@webkit.org

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

  • platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and end. This matches other ports. Only use GLib style early returns when checking the validity of GObjects. (DumpRenderTreeSupportGtk::hasComposition): Added. (DumpRenderTreeSupportGtk::compositionRange): Added. (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above. (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above. (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603

Add callbacks to support hasMarkedText and markedRange and also clean up existing
TextInputController support.

  • DumpRenderTree/gtk/TextInputController.cpp: (setMarkedTextCallback): Accept parameters in terms of start and length, instead of start and end. This matches the other ports. Do not use GLib style early returns. (hasMarkedTextCallback): Added. (markedRangeCallback): Added. (insertTextCallback): Cleanup as described above. (unmarkTextCallback): Cleanup as described above. (firstRectForCharacterRangeCallback): Cleanup as described above. (selectedRangeCallback): Cleanup as described above.
16:04 Changeset [88497] by kbr@google.com

2011-06-09 Kenneth Russell <kbr@google.com>

Skipped new tests from r88489 on WebKit Win, since WebGL is not yet enabled.

  • platform/win/Skipped:
15:53 Changeset [88496] by commit-queue@webkit.org

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

Tests that a layer that should clip its children actually does clip even when scrolled offscreen.

  • platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
  • platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
  • platform/chromium/compositing/scissor-out-of-viewport.html: Added.

2011-06-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339

We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.

This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.

Test: platform/chromium/compositing/scissor-out-of-viewport.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):
15:53 Changeset [88495] by commit-queue@webkit.org

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88486.
http://trac.webkit.org/changeset/88486
https://bugs.webkit.org/show_bug.cgi?id=62409

Broke chromium-win compile (Requested by jamesr on #webkit).

  • public/WebData.h:
  • public/WebPageSerializer.h:
  • src/WebData.cpp:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
15:53 Changeset [88494] by lforschler@apple.com

Versioning.

15:49 Changeset [88493] by lforschler@apple.com

New tag.

15:44 Changeset [88492] by lforschler@apple.com

Merge r88468.

15:30 Changeset [88491] by lforschler@apple.com

Merge r88475.

15:23 Changeset [88490] by commit-queue@webkit.org

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408

It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).

  • fullscreen/full-screen-video-offset-expected.txt: Removed.
  • fullscreen/full-screen-video-offset.html: Removed.

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408

It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).

  • dom/Element.cpp: (WebCore::adjustForLocalZoom):
  • dom/Element.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
15:02 Changeset [88489] by kbr@google.com

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
14:55 Changeset [88488] by abarth@webkit.org

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add an ASSERT to HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=62403

This ASSERT was useful in investigating a re-entrancy bug. We should
keep it.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
14:48 Changeset [88487] by mitz@apple.com

Fix a regression from r88478.

Reviewed by Darin Adler.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
afterwards.

14:45 Changeset [88486] by jcivelli@chromium.org

2011-06-09 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Page serializer APIs now use WebData instead of fetching the entire
resource contents.
https://bugs.webkit.org/show_bug.cgi?id=61908

  • public/WebData.h:
  • public/WebPageSerializer.h:
  • src/WebData.cpp: (WebKit::WebData::getSomeData):
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
14:24 Changeset [88485] by dglazkov@chromium.org

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Mark tests failing after http://trac.webkit.org/changeset/88478/ as failing.

  • platform/chromium/test_expectations.txt: Added failing tests.
14:19 Changeset [88484] by lforschler@apple.com

Merge r88401.

14:18 Changeset [88483] by dpranke@chromium.org

2011-06-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: support webaudio in chromium driver
https://bugs.webkit.org/show_bug.cgi?id=62226

  • Scripts/webkitpy/layout_tests/port/chromium.py:
14:11 Changeset [88482] by dglazkov@chromium.org

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Update expectations.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Added.
  • platform/chromium-win/fullscreen/full-screen-video-offset-expected.txt: Added.
14:06 Changeset [88481] by lforschler@apple.com

Merge r88279.

13:53 Changeset [88480] by commit-queue@webkit.org

2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by James Robinson.

Web Inspector: Inspector layout tests - extract method for sending XHR
https://bugs.webkit.org/show_bug.cgi?id=62391

  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/network-test.js: (doXHR.xhr.onreadystatechange): (doXHR):
  • http/tests/inspector/network/network-size-sync.html:
13:33 Changeset [88479] by commit-queue@webkit.org

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400

Adding test to cover the regression. The test actually uncovered
a bug in the way we handle alternate stylesheet and thus is
failing some parts.

  • fast/css/link-disabled-attr-expected.txt: Added.
  • fast/css/link-disabled-attr.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400

Test: fast/css/link-disabled-attr.html

Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!

The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.

  • dom/Document.cpp: (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState, replaced by m_isEnabledViaScript. (WebCore::HTMLLinkElement::setDisabled): Updated the logic after m_disabledState removal. It also matches the spec by forwarding the disabled state to our stylesheet if we have one. (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful handling of the disabledAttr. (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto. (WebCore::HTMLLinkElement::isAlternate): Ditto.
13:30 Changeset [88478] by mitz@apple.com

Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387

Reviewed by Darin Adler.

No new test, since functionality is unchanged.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
then reverse the run vector for RTL.

13:29 Changeset [88477] by mitz@apple.com

Source/JavaScriptCore: Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

  • wtf/Vector.h:

(WTF::Vector::reverse): Added

Tools: Added a test for Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
13:24 Changeset [88476] by dglazkov@chromium.org

2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

Fold isShadowBoundary into isShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=62317

Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.

In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.

Refactoring, covered by existing tests.

  • css/CSSStyleSelector.cpp: (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
  • dom/Element.cpp: (WebCore::Element::isSpellCheckingEnabled): Ditto.
  • dom/Node.cpp: (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto. (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
  • dom/Node.h: (WebCore::Node::isContentElement): Added.
  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
  • dom/Position.cpp: (WebCore::Position::Position): Ditto.
  • dom/ShadowContentElement.h: (WebCore::ShadowContentElement::isContentElement): Added.
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
  • editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): Ditto. (WebCore::visiblePositionAfterNode): Ditto.
  • page/DragController.cpp: (WebCore::asFileInput): Ditto.
  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Ditto.
13:05 Changeset [88475] by simon.fraser@apple.com

2011-06-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159

Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
12:52 Changeset [88474] by jchaffraix@webkit.org

2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

  • fast/css/webkit-keyframes-crash-expected.txt: Added.
  • fast/css/webkit-keyframes-crash.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384

Test: fast/css/webkit-keyframes-crash.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.
12:44 Changeset [88473] by ggaren@apple.com

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Factored a bunch of Heap functionality into stand-alone functors
https://bugs.webkit.org/show_bug.cgi?id=62337


This is in preparation for making these functors operate on arbitrary
sets of MarkedBlocks.

  • debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Updated for type change and rename.
  • heap/HandleHeap.h: (JSC::HandleHeap::forEachStrongHandle): New function for iterating all strong handles, so we can play along in the functor game.
  • heap/Heap.cpp: (JSC::CountFunctor::CountFunctor::CountFunctor): (JSC::CountFunctor::CountFunctor::count): (JSC::CountFunctor::CountFunctor::returnValue): (JSC::CountFunctor::ClearMarks::operator()): (JSC::CountFunctor::ResetAllocator::operator()): (JSC::CountFunctor::Sweep::operator()): (JSC::CountFunctor::MarkCount::operator()): (JSC::CountFunctor::Size::operator()): (JSC::CountFunctor::Capacity::operator()): (JSC::CountFunctor::Count::operator()): (JSC::CountFunctor::CountIfGlobalObject::operator()): (JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty): (JSC::CountFunctor::TakeIfEmpty::operator()): (JSC::CountFunctor::TakeIfEmpty::returnValue): (JSC::CountFunctor::RecordType::RecordType): (JSC::CountFunctor::RecordType::typeName): (JSC::CountFunctor::RecordType::operator()): (JSC::CountFunctor::RecordType::returnValue): These functors factor out behavior that used to be in the functions below.

(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Factored out behavior into the functors above.

  • heap/Heap.h: (JSC::Heap::forEachProtectedCell): (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Added forEach* iteration templates. I chose functor-based templates instead of plain iterators because they're simpler to implement in this case and they require a lot less code at the call site.
  • heap/MarkedBlock.h: (JSC::MarkedBlock::VoidFunctor::returnValue): Default parent class for trivial functors.

(JSC::MarkedBlock::forEachCell): Renamed forEach to forEachCell because
we have a few different kind of "for each" now.

  • runtime/JSGlobalData.cpp: (WTF::Recompile::operator()): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::recompileAllJSFunctions): Updated for type change and rename.
  • runtime/JSGlobalData.h: Removed globalObjectCount because it was unused.
12:41 Changeset [88472] by commit-queue@webkit.org

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by David Hyatt.

Test for chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756

  • fast/css/fontMetric-border-radius-null-crash-expected.txt: Added.
  • fast/css/fontMetric-border-radius-null-crash.html: Added.
  • fast/css/fontMetric-webkit-border-end-width-null-crash-expected.txt: Added.
  • fast/css/fontMetric-webkit-border-end-width-null-crash.html: Added.

2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by David Hyatt.

chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756

Tests: fast/css/fontMetric-border-radius-null-crash.html

fast/css/fontMetric-webkit-border-end-width-null-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update so that our FontFallbackList is allocated if we ever need it when applying our style rules.
12:30 Changeset [88471] by mrobinson@webkit.org

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove a cr-linux expectation that no longer differs from the default
expectation.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Removed.

2011-06-09 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  • GNUmakefile.am: Update source list.
12:02 Changeset [88470] by andreas.kling@nokia.com

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
https://bugs.webkit.org/show_bug.cgi?id=62386

  • Platform/CoreIPC/Connection.h:
11:51 Changeset [88469] by commit-queue@webkit.org

2011-06-09 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213

When building Mac Chrome using Skia as the WebKit renderer,
add state to LocalCurrentGraphicsContext to convert the SkCanvas
context passed by WebKit into the CGContext needed by UI
rendering.

No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.

  • platform/mac/LocalCurrentGraphicsContext.h: Add SkiaBitLocker to create and release the converted CGContext. Add ContextContainer, a class for Skia to create and release the converted CGContext. If Skia is not used, the class has no effect.
  • platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): When building with Skia, create the CGContext before passing it on.

(WebCore::LocalCurrentGraphicsContext::cgContext):
Get the CGContext from the SkiaBitLocker, or the saved context,
as appropriate.

  • rendering/RenderThemeMac.mm: Get the CGContext from Skia conversion or native, as appropriate. Use the LocalCurrentGraphicsContext if there is one. Otherwise, add a ContextContainer to house the SkCanvas to CGContext conversion.

(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):

11:47 Changeset [88468] by jer.noble@apple.com

2011-06-02 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>

  • fullscreen/full-screen-video-offset-expected.txt: Added.
  • fullscreen/full-screen-video-offset.html: Added.

2011-06-02 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>

Test: fullscreen/full-screen-video-offset.html

When the video element is taken full-screen in the new element full-screen API, return the
offset width and height of the placeholder renderer which is filling in for the full-screen
element. To do so, override offsetWidth, Height, Left, and Top from Element. These are
non-virtual functions, so make them virtual.

  • dom/Element.cpp: (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
  • dom/Element.h: Made offset functions virtual.
  • html/HTMLMediaElement.cpp: (WebCore::elementPlaceholder): Added; utility function. (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the

Element function. Will be called directly via javascript.

(WebCore::HTMLMediaElement::offsetTop): Ditto.
(WebCore::HTMLMediaElement::offsetWidth): Ditto.
(WebCore::HTMLMediaElement::offsetHeight): Ditto.

  • html/HTMLMediaElement.h:
11:26 Changeset [88467] by chang.shu@nokia.com

2011-06-09 Chang Shu <cshu@webkit.org>

Unreviewed.

Unskip more passed tests after r88461 (bug 62381).

  • platform/qt-wk2/Skipped:
11:21 Changeset [88466] by commit-queue@webkit.org

2011-06-09 Bill Budge <bbudge@chromium.org>

Reviewed by Adam Barth.

The AssociatedURLLoader returns URL access errors synchronously. Use a timer to return such errors asynchronously. Also add unit tests for successful loads, same-origin restriction by default, and successful cross-origin loads.
https://bugs.webkit.org/show_bug.cgi?id=60059

  • WebKit.gyp:
  • WebKit.gypi:
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::ClientAdapter::enableErrorNotifications): (WebKit::AssociatedURLLoader::ClientAdapter::notifyError): (WebKit::AssociatedURLLoader::loadAsynchronously):
  • tests/AssociatedURLLoaderTest.cpp: Added. (WebKit::TestWebFrameClient::cancelledError): (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): (WebKit::AssociatedURLLoaderTest::SetUp): (WebKit::AssociatedURLLoaderTest::TearDown): (WebKit::AssociatedURLLoaderTest::serveRequests): (WebKit::AssociatedURLLoaderTest::createAssociatedURLLoader): (WebKit::AssociatedURLLoaderTest::willSendRequest): (WebKit::AssociatedURLLoaderTest::didSendData): (WebKit::AssociatedURLLoaderTest::didReceiveResponse): (WebKit::AssociatedURLLoaderTest::didDownloadData): (WebKit::AssociatedURLLoaderTest::didReceiveData): (WebKit::AssociatedURLLoaderTest::didReceiveCachedMetadata): (WebKit::AssociatedURLLoaderTest::didFinishLoading): (WebKit::AssociatedURLLoaderTest::didFail): (WebKit::TEST_F):
11:21 Changeset [88465] by commit-queue@webkit.org

2011-06-09 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721

The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
calls to mean the plugin handled the event.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Return 0 for each event on windows.
11:19 Changeset [88464] by commit-queue@webkit.org

2011-06-09 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: behavior of undefined value in record
https://bugs.webkit.org/show_bug.cgi?id=62371

  • storage/indexeddb/value-undefined-expected.txt: Added.
  • storage/indexeddb/value-undefined.html: Added.
11:16 Changeset [88463] by andreas.kling@nokia.com

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

[Qt][WK2] Remove usage of deprecated CoreIPC functions.
https://bugs.webkit.org/show_bug.cgi?id=62290

Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
and guarded by ENABLE(TILED_BACKING_STORE).

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Prune deleted files from build system.
  • Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete, this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::invalidate): (WebKit::DrawingAreaProxy::snapshotTaken): (WebKit::DrawingAreaProxy::tileUpdated): (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by TiledDrawingAreaProxy to DrawingAreaProxy.
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): (WebKit::DrawingArea::cancelTileUpdate): (WebKit::DrawingArea::requestTileUpdate): (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea to DrawingArea.
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage() and didReceiveSyncMessage().
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::tileUpdated): (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage() into functions.

(WebKit::TiledDrawingAreaProxy::removeTile):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.

  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::cancelTileUpdate): (WebKit::TiledDrawingArea::requestTileUpdate): (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaProxyLegacy.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaLegacy.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
  • WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make CoreIPC message handlers explicitly virtual.
11:14 Changeset [88462] by andreas.kling@nokia.com

2011-06-09 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Generate correct header conditionals in message receivers.
https://bugs.webkit.org/show_bug.cgi?id=62379

Given a *.messages.in file like this:

Foo(AwesomeObject o)
#if ENABLE(ESOTERIC_FEATURE)
Bar(AwesomeObject o)
#endif

messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
This breaks the build on platforms without that defined.

Furthermore, if two messages guarded by different conditionals both pull in the same
header, only the last conditional will be applied, for example:

#if ENABLE(ESOTERIC_FEATURE)
Foo(AwesomeObject o)
#endif
#if ENABLE(MYSTERIOUS_FEATURE)
Bar(AwesomeObject o)
#endif

Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should

check #if ENABLE(ESOTERIC_FEATURE)
ENABLE(MYSTERIOUS_FEATURE).

Change the generator to consider all conditionals for a given header file.
Also consider conditionals for reply parameters.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
11:09 Changeset [88461] by commit-queue@webkit.org

2011-06-09 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381

Unskip passed tests.

  • platform/qt-wk2/Skipped:

2011-06-09 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381

Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
QWKPagePrivate::isViewFocused() will check it later.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
11:05 Changeset [88460] by thakis@chromium.org

Merge 88396 - 2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

  • wtf/Platform.h:

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7134051

11:04 Changeset [88459] by thakis@chromium.org

Merge 88286 - 2011-06-07 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753

No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.

  • WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
  • WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
  • platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
  • platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
  • platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7044088

10:49 Changeset [88458] by commit-queue@webkit.org

2011-06-09 Dave Tapuska <dtapuska@rim.com>

Reviewed by Daniel Bates.

PingLoader destructor could dereference 0 if the Resource
Handle creation failed.

https://bugs.webkit.org/show_bug.cgi?id=62304

  • loader/PingLoader.cpp: (WebCore::PingLoader::~PingLoader):
09:20 Changeset [88457] by thakis@chromium.org

2011-06-09 Nico Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a few destructors private.
https://bugs.webkit.org/show_bug.cgi?id=62341

No intended functionality change.

  • src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
  • src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
09:15 Changeset [88456] by inferno@chromium.org

2011-06-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Make indexForVisiblePosition and isSelectableElement static.
https://bugs.webkit.org/show_bug.cgi?id=62329

This protects us when converting frame->selection->start() or end()
to VisiblePosition which blows away the RenderTextControl from
underneath (due to layout update).

Test: fast/forms/text-control-selection-crash.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:

2011-06-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Tests that setting selection on a text control does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62329

  • fast/forms/text-control-selection-crash-expected.txt: Added.
  • fast/forms/text-control-selection-crash.html: Added.
09:05 Changeset [88455] by abecsi@webkit.org

2011-06-09 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix the in-tree build on Linux
https://bugs.webkit.org/show_bug.cgi?id=62378

In case of an in-tree build qmake generates defect prl dependencies for
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.

  • QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
08:52 Changeset [88454] by benm@google.com

2011-06-09 Ben Murdoch <benm@google.com>

Reviewed by Yury Semikhatsky.

Build break in ScriptProfile.cpp and inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=62373

No new tests - build fix only.

  • bindings/v8/ScriptProfile.cpp: Add necessary guards.
  • bindings/v8/ScriptProfile.h: ditto.
08:19 Changeset [88453] by commit-queue@webkit.org

2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
https://bugs.webkit.org/show_bug.cgi?id=62298

  • inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
07:53 Changeset [88452] by ossy@webkit.org

[Qt] Unreviewed fix after r88447.

  • platform/qt/Skipped:
07:44 Changeset [88451] by ossy@webkit.org

[Qt][Mac] Speculative buildfix after r88286.

  • platform/graphics/IntPoint.h:
07:28 Changeset [88450] by ossy@webkit.org

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

  • platform/qt/Skipped: Add inspector/profiler/detailed-heapshots-comparison-show-next.html.
07:24 Changeset [88449] by ossy@webkit.org

[WK2] eventSender.keyDown is unimplemented

  • platform/mac-wk2/Skipped: Add fast/dom/shadow/tab-order-iframe-and-shadow.html.
07:12 Changeset [88448] by mikelawther@chromium.org

2011-06-09 Mike Lawther <mikelawther@chromium.org>

Reviewed by Kent Tamura.

Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276

Set the CSSParserString for the calc functions.

  • css3/calc/regression-62276-expected.txt: Added.
  • css3/calc/regression-62276.html: Added.

2011-06-09 Mike Lawther <mikelawther@chromium.org>

Reviewed by Kent Tamura.

Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276

Set the CSSParserString for the calc functions.

Test: css3/calc/regression-62276.html

  • css/CSSParser.cpp: (WebCore::CSSParser::lex):
07:11 Changeset [88447] by ossy@webkit.org

REGRESSION(r88393): Tests fail on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=62374

  • platform/qt/Skipped: Add editing/selection/move-by-word-visually-others.html and

editing/selection/move-by-word-visually-single-space-sigle-line.html until fix.

07:06 Changeset [88446] by dominicc@chromium.org

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

Unskip fast/harness/internals-object.html

  • platform/qt/Skipped:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
and others. The only alternative seems like a compile time guard which we would have to teach the bots about.

  • CodeGenerators.pri:
  • WebCore.pri:
  • WebCore.pro:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::injectInternalsObject):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-06-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::initJSObjects):
06:54 Changeset [88445] by ossy@webkit.org

[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427

  • platform/qt-wk2/Skipped: Unskip passing tests after r88435.
05:42 Changeset [88444] by loislo@chromium.org

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.
05:09 Changeset [88443] by commit-queue@webkit.org

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368

New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Removed.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Removed.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Removed.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Removed.
  • platform/mac-wk2/Skipped:

2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368

New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
04:56 Changeset [88442] by ossy@webkit.org

[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

  • platform/qt/Skipped: Skip 3 inspector tests to make buildbot happy.
04:10 Changeset [88441] by apavlov@chromium.org

2011-06-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: New flakiness in styles tests
https://bugs.webkit.org/show_bug.cgi?id=62309

  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-source-lines-inline.html:
03:26 Changeset [88440] by commit-queue@webkit.org

2011-06-09 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
https://bugs.webkit.org/show_bug.cgi?id=62363

  • UIProcess/API/efl/PageClientImpl.cpp: Added. (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::~PageClientImpl): (WebKit::PageClientImpl::createDrawingAreaProxy): (WebKit::PageClientImpl::setViewNeedsDisplay): (WebKit::PageClientImpl::displayView): (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow): (WebKit::PageClientImpl::processDidCrash): (WebKit::PageClientImpl::didRelaunchProcess): (WebKit::PageClientImpl::pageClosed): (WebKit::PageClientImpl::toolTipChanged): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::clearAllEditCommands): (WebKit::PageClientImpl::canUndoRedo): (WebKit::PageClientImpl::executeUndoRedo): (WebKit::PageClientImpl::convertToDeviceSpace): (WebKit::PageClientImpl::convertToUserSpace): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::customRepresentationZoomFactor): (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): (WebKit::PageClientImpl::flashBackingStoreUpdates): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): (WebKit::PageClientImpl::userSpaceScaleFactor):
  • UIProcess/API/efl/PageClientImpl.h: Added. (WebKit::PageClientImpl::create): (WebKit::PageClientImpl::viewObject): (WebKit::PageClientImpl::page):
  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebPageProxyEfl.cpp: Added. (WebKit::WebPageProxy::viewObject): (WebKit::WebPageProxy::standardUserAgent): (WebKit::WebPageProxy::getEditorCommandsForKeyEvent): (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches):
03:06 Changeset [88439] by tkent@chromium.org

2011-06-09 Kent Tamura <tkent@chromium.org>

[Chromium] Leopard rebaseline for thumbslider-no-parent-slider.html.

  • platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Added.
02:39 Changeset [88438] by rniwa@webkit.org

2011-06-09 Ryosuke Niwa <rniwa@webkit.org>

More Chromium Mac test expectation updates.

  • platform/chromium/test_expectations.txt:
02:36 Changeset [88437] by eric@webkit.org

2011-06-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
https://bugs.webkit.org/show_bug.cgi?id=62362

The mac bots are failing inspector tests. We don't know why yet.
So for now, turning run-webkit-tests off for the mac-ews.

Also noticed that due to the wrong variable name the cr-linux
bots weren't running tests!

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
02:21 Changeset [88436] by rniwa@webkit.org

2011-06-09 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac test expectation updates.

  • platform/chromium/test_expectations.txt:
01:47 Changeset [88435] by zherczeg@webkit.org

[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-09
Reviewed by Csaba Osztrogonac.

Tools:

Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
Since the Qt port should eventually go to QRawFont, this issue will be resolved
in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
needed for the workaround.

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::platformInitialize):

LayoutTests:

Unskipping canvas tests for WebKit2-Qt.

  • platform/qt-wk2/Skipped:
01:41 Changeset [88434] by abarth@webkit.org

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160

  • fast/parser/document-write-onload-clear-expected.txt: Added.
  • fast/parser/document-write-onload-clear.html: Added.

2011-06-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160

When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.

Test: fast/parser/document-write-onload-clear.html

  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
00:42 Changeset [88433] by jamesr@google.com

2011-06-09 James Robinson <jamesr@chromium.org>

Fix chromium build on build.webkit.org builders.

  • features.gypi:
00:35 Changeset [88432] by mario@webkit.org

2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855

New layout test and expected results to check the new function.

  • accessibility/platform-name.html: Added.
  • platform/gtk/accessibility/platform-name-expected.txt: Added.
  • platform/mac/accessibility/platform-name-expected.txt: Added.
  • platform/win/accessibility/platform-name-expected.txt: Added.

2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855

Patch for adding 'platformName' static property to DRT's
LayoutController and provide platform specific implementations.

In principle, this feature will be only of interest for writing
accessibility tests, so that's why it's only implemented in the
Mac, Gtk and Win platforms.

  • DumpRenderTree/LayoutTestController.h: New method platformName().
  • DumpRenderTree/LayoutTestController.cpp: (getPlatformNameCallback): New callback for 'platformName'. (LayoutTestController::staticValues): New static property.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::platformName): Implemented.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::platformName): Implemented.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::platformName): Implemented.

06/08/11:

23:55 Changeset [88431] by macpherson@chromium.org

2011-06-08 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSPrimitiveValue support cast to EVerticalAlign.
https://bugs.webkit.org/show_bug.cgi?id=62356

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
23:47 Changeset [88430] by jamesr@google.com

Merge 88429 - 2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::create):

TBR=junov@chromium.org
BUG=85309
Review URL: http://codereview.chromium.org/7046071

23:40 Changeset [88429] by commit-queue@webkit.org

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):

2011-06-08 Justin Novosad <junov@chromium.org>

Reviewed by James Robinson.

[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::create):
23:38 Changeset [88428] by commit-queue@webkit.org

2011-06-08 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349

r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
significant performance regression across many chromium page cyclers, for example
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.

This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
logic.

  • platform/graphics/FontCache.cpp:
23:37 Changeset [88427] by jamesr@google.com

2011-06-08 James Robinson <jamesr@chromium.org>

Hopefully last change to features.gypi - set ENABLE_REGISTER_PROTOCOL_HANDLER based off of the the variable set
in chromium's common.gypi. Should green up the chromium linux tester on build.webkit.org.

  • features.gypi:
23:07 Changeset [88426] by mikelawther@chromium.org

2011-06-08 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Add mikelawther to committers.py
https://bugs.webkit.org/show_bug.cgi?id=62354

  • Scripts/webkitpy/common/config/committers.py:
22:48 Changeset [88425] by jamesr@google.com

2011-06-08 James Robinson <jamesr@chromium.org>

Set ENABLE_REGISTER_PROTOCOL_HANDLER=1 for chromium. I didn't mean to turn that off...

  • features.gypi:
22:43 Changeset [88424] by jamesr@google.com

2011-06-08 James Robinson <jamesr@chromium.org>

[chromium] Update the chromium-within-WebKit revision to r88481
https://bugs.webkit.org/show_bug.cgi?id=62353

  • DEPS:
22:37 Changeset [88423] by tkent@chromium.org

[Chromium] Rebaseline for r87881 and r88415.

  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
22:35 Changeset [88422] by commit-queue@webkit.org

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add stubs to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=62263

This change add stub implementations for all WebWidget functions. Having stub methods should make it easier to add new functions to the class without breaking Chromium.

  • public/WebWidget.h: (WebKit::WebWidget::close): (WebKit::WebWidget::size): (WebKit::WebWidget::resize): (WebKit::WebWidget::animate): (WebKit::WebWidget::layout): (WebKit::WebWidget::paint): (WebKit::WebWidget::composite): (WebKit::WebWidget::themeChanged): (WebKit::WebWidget::handleInputEvent): (WebKit::WebWidget::mouseCaptureLost): (WebKit::WebWidget::setFocus): (WebKit::WebWidget::setComposition): (WebKit::WebWidget::confirmComposition): (WebKit::WebWidget::compositionRange): (WebKit::WebWidget::textInputType): (WebKit::WebWidget::caretOrSelectionBounds): (WebKit::WebWidget::selectionRange): (WebKit::WebWidget::caretOrSelectionRange): (WebKit::WebWidget::setTextDirection): (WebKit::WebWidget::isAcceleratedCompositingActive):
22:33 Changeset [88421] by hayato@chromium.org

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Dimitri Glazkov.

A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410

Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.

The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.

A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.

  • fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
  • fast/dom/shadow/tab-order-iframe-and-shadow.html: Added.

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Dimitri Glazkov.

A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410

Test: fast/dom/shadow/tab-order-iframe-and-shadow.html

Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.

The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.

A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.

  • page/FocusController.cpp: (WebCore::shadowRoot): (WebCore::isTreeScopeOwner): (WebCore::FocusController::deepFocusableNode): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::FocusController::findFocusableNodeAcrossTreeScope): (WebCore::FocusController::findFocusableNode): (WebCore::FocusController::nextFocusableNode): (WebCore::FocusController::previousFocusableNode): (WebCore::FocusController::ownerOfTreeScope):
  • page/FocusController.h:
21:56 Changeset [88420] by tkent@chromium.org

2011-06-08 Kent Tamura <tkent@chromium.org>

[Chromium] Fix a typo.

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::draw):
21:50 WebKit Team edited by takano.naoki@gmail.com
(diff)
21:49 WebKit Team edited by takano.naoki@gmail.com
(diff)
21:47 Changeset [88419] by tkent@chromium.org

2011-06-08 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] Support vertical sliders in Windows DRT
https://bugs.webkit.org/show_bug.cgi?id=62352

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::draw): Paint VerticalSliderThumbType and VerticalSliderTrackType.
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h: Add VerticalSliderTrackType and VerticalSliderThumbType.
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar): Convert Windows identifiers to the internal identifiers for vertical sliders.
20:55 Changeset [88418] by hayato@chromium.org

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Makes sure that document.activeElement won't be an element in shadow root.

https://bugs.webkit.org/show_bug.cgi?id=61413

  • fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt: Added.
  • fast/dom/shadow/activeelement-should-be-shadowhost.html: Added.

2011-06-08 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Makes sure that document.activeElement won't be an element in shadow root.

https://bugs.webkit.org/show_bug.cgi?id=61413

Test: fast/dom/shadow/activeelement-should-be-shadowhost.html

  • html/HTMLDocument.cpp: (WebCore::focusedFrameOwnerElement): (WebCore::HTMLDocument::activeElement):
20:42 Changeset [88417] by tkent@chromium.org

2011-06-08 Kent Tamura <tkent@chromium.org>

[Mac][GTK][Qt] Rebaseline for r88415, and remove old images.

  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt:
19:09 Changeset [88416] by koz@chromium.org

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Add TIMEOUT to styles-disable-then-change.html.

  • platform/chromium/test_expectations.txt:
19:06 Changeset [88415] by tkent@chromium.org

Allow drawing a slider thumb for any nodes.
https://bugs.webkit.org/show_bug.cgi?id=62196

Reviewed by Dimitri Glazkov.

Source/WebCore:

RenderObject::node() should provide various information which is
necessary for rendering. We don't need to refer the parent renderer.

  • dom/Node.cpp:

(WebCore::Node::focusDe1egate): Added.

  • dom/Node.h: Added a declaration.
  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

Added an overload of toParentMediaElement() with Node* parameter.

  • html/shadow/MediaControlElements.h:

(WebCore::toParentMediaElement): ditto.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isEnabledFormControl):

Returns the status of the host node.

(WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
(WebCore::SliderThumbElement::focusDe1egate):

Returns the host node so that RenderTheme::isFocused() returns true.

(WebCore::SliderThumbElement::detach): Style nit.
(WebCore::SliderThumbElement::hostInput):

Make it const because it is called by const functions.

  • html/shadow/SliderThumbElement.h:
    • Remove inDragMode()
    • Update declarations
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintMediaSliderThumb):

Use Node::shadowAncestorNode() instead of RenderObject::parent() to
support deeper thumb nodes.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSliderThumb): ditto.
(WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::inDragMode):

SliderThumbElement::inDragMode() was removed, and Node::active() has
the same information.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Remove isSlider() checks.
(WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::paintSliderThumb):

isPressed() is enough.

  • rendering/RenderThemeChromiumWin.cpp: isEnabled(), isFocused(), and isPressed() are enough.

(WebCore::RenderThemeChromiumWin::determineSliderThumbState):
(WebCore::RenderThemeChromiumWin::determineClassicState):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb):

  • Remove isSlider() check.
  • Passing 'o' to udpateFooState functions is enough.
  • isPressed() is enough.
  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintSliderThumb):

We don't need special handling anymore.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::determineSliderThumbState):

isEnabled(), isFocused(), and isPressed() are enough.

LayoutTests:

The behavior was changed. We should show slider thumbs for any nodes with
-webkit-appearance:slidertumb-horizontal/vertical.

  • fast/forms/thumbslider-no-parent-slider.html:
  • platform/chromium/test_expections.txt: Expect to fail with thumbslider-no-parent-slider.html.
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
18:40 Changeset [88414] by koz@chromium.org

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Revert r88412 because it introduced syntax
errors into test_expectations.txt.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [88413] by alokp@chromium.org

Merge 88403 - 2011-06-08 Brian Salomon <bsalomon@google.com> Reviewed by James Robinson. Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO. https://bugs.webkit.org/show_bug.cgi?id=62318 Chromium-only crash Failures takes multiple seconds to occur, relying on JS garbage-collection to occur http://www.hotbazooka.com/privatejoe-large * platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
TBR=bsalomon@google.com
BUG=85157
Review URL: http://codereview.chromium.org/7044078

18:11 Changeset [88412] by koz@chromium.org

2011-06-08 James Kozianski <koz@chromium.org>

[Chromium] Unreviewed. Fix expectations for
styles-disable-then-change.html.

  • platform/chromium/test_expectations.txt:
17:34 Changeset [88411] by abarth@webkit.org

2011-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use after free in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=62160

Test that we don't trigger asserts when re-entering the parser from
tree construction.

  • fast/parser/document-write-onload-nesting-expected.txt: Added.
  • fast/parser/document-write-onload-nesting.html: Added.
  • fast/parser/document-write-onload-ordering-expected.txt: Added.
  • fast/parser/document-write-onload-ordering.html: Added.
    • The exact ordering of the script execution here differs a bit between browsers. For example, Firefox executes the scripts in a slightly different order because Firefox runs the parser on a separate thread (and therefore cannot be re-entered from tree construction). If/when we move the parser off the main thread, we're likely to change the ordering here a bit, which should be ok.

2011-06-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

constructTreeFromToken can re-enter parser, causing ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=62160

This patch clears the HTMLToken before constructing the tree from the
token, putting the HTMLDocumentParser in a good state to be re-entered.

Tests: fast/parser/document-write-onload-nesting.html

fast/parser/document-write-onload-ordering.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLToken.h: (WebCore::HTMLToken::isUninitialized):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken):
17:20 Changeset [88410] by tkent@chromium.org

2011-06-08 Kent Tamura <tkent@chromium.org>

Fix Qt build for r88405.
https://bugs.webkit.org/show_bug.cgi?id=62208

  • platform/qt/RenderThemeQt.h:
17:00 Changeset [88409] by rniwa@webkit.org

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Add PASS expectations to two tests that have been passing on
build.webkit.org Chromium Linux bot.

  • platform/chromium/test_expectations.txt:
16:58 Changeset [88408] by simonjam@chromium.org

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, more inspector flakiness.

  • platform/chromium/test_expectations.txt:
16:55 Changeset [88407] by commit-queue@webkit.org

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88404.
http://trac.webkit.org/changeset/88404
https://bugs.webkit.org/show_bug.cgi?id=62342

broke win and mac build (Requested by tonywork on #webkit).

16:54 Changeset [88406] by vangelis@chromium.org

Merge 88288 - 2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7044072

16:45 Changeset [88405] by tkent@chromium.org

2011-06-08 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
https://bugs.webkit.org/show_bug.cgi?id=62208

Change the argument type of RenderTheme::adjustSliderThumbSize() and
RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.

Also, each of adjustSliderThumbStyle() overrides calls RenderTheme
adjustSliderThumbStyle() for future changes.

No new tests. This is a refactoring and should not change any behavior.

  • html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto. (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto. (WebCore::RenderThemeQt::adjustSliderThumbSize):
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControls.h:
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
  • rendering/RenderMediaControlsChromium.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment. (WebCore::RenderTheme::adjustSliderThumbSize):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle(). (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle(). (WebCore::RenderThemeSafari::adjustSliderThumbSize):
  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize):
  • rendering/RenderThemeWin.h:
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
  • rendering/RenderThemeWinCE.h:
16:37 Changeset [88404] by evan@chromium.org

2011-06-08 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

[chromium] use gyp 'settings' type for settings target
https://bugs.webkit.org/show_bug.cgi?id=62323

The 'settings' gyp target type is for targets that exist solely
for their settings (no build rules). The comment above this target
says it's for this, but it incorrectly uses 'none'.

16:25 Changeset [88403] by commit-queue@webkit.org

2011-06-08 Brian Salomon <bsalomon@google.com>

Reviewed by James Robinson.

Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
https://bugs.webkit.org/show_bug.cgi?id=62318

Chromium-only crash
Failures takes multiple seconds to occur, relying on JS garbage-collection to occur
http://www.hotbazooka.com/privatejoe-large

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):
16:13 Changeset [88402] by simonjam@chromium.org

2011-06-08 James Simonsen <simonjam@chromium.org>

Unreviewed, move generic test expectation to right place.

  • fast/gradients/crash-on-degenerate-gradient-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/crash-on-degenerate-gradient-expected.txt.
16:02 Changeset [88401] by sullivan@apple.com

<https://bugs.webkit.org/show_bug.cgi?id=62332>
<rdar://problem/9355199>
[WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _resendKeyDownEvent:]):
Renamed self-protecting RetainPtr from "protect" to "protector" so it's a noun.
(-[WKView _setDragImage:at:linkDrag:]):
Added a self-protecting RetainPtr.

16:00 Changeset [88400] by eae@chromium.org

2011-06-08 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

RenderEmbeddedObject::getReplacementTextGeometry
https://bugs.webkit.org/show_bug.cgi?id=62313

Replace the last use of tx, ty with IntPoint.

Covered by existing tests.

  • platform/graphics/FloatRect.h: (WebCore::FloatRect::move): (WebCore::FloatRect::moveBy):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced): (WebCore::RenderEmbeddedObject::getReplacementTextGeometry): (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
  • rendering/RenderEmbeddedObject.h:
15:51 Changeset [88399] by xan@webkit.org

2011-06-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebKitSpellChecker interface and implementations
https://bugs.webkit.org/show_bug.cgi?id=61787

Expose the spell checking functionality to the UAs through a
generic interface, and provide a default Enchant-based
implementation. On top of allowing UAs to use this functionality
this makes it possible to change the spell checking backend at
runtime.

  • GNUmakefile.am: add new files.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::EditorClient): set the spell checker using the new classes.
  • WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
  • WebCoreSupport/TextCheckerClientGtk.cpp: Added (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just chain up to the WebKitSpellChecker. (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto. (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto. (WebKit::TextCheckerClientGtk::learnWord): ditto. (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto. (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto. (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto. (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
  • WebCoreSupport/TextCheckerClientGtk.h: store a reference to the WebKitSpellChecker.
  • webkit/webkit.h: the webkitspellchecker.h header is public.
  • webkit/webkitdefines.h: defines for spell checker interface.
  • webkit/webkitglobals.cpp: Add APIs to get and set the global spell checker. (webkit_get_spell_checker): get API. (webkit_set_spell_checker): set API.
  • webkit/webkitglobals.h:
  • webkit/webkitspellchecker.cpp: Added. Spell checking interface.
  • webkit/webkitspellchecker.h: Added.
  • webkit/webkitspellcheckerenchant.cpp: Added. Default implemention, uses Enchant library.
  • webkit/webkitspellcheckerenchant.h: Added.
15:38 Changeset [88398] by commit-queue@webkit.org

2011-06-08 Tim Horton <timothy_horton@apple.com>

Reviewed by Ryosuke Niwa.

Use correct CFURLStorageSessionRef definition on Leopard, as
we created an inconsistency in const-ness between
WebCoreSystemInterface.h and these two files in the case
of Leopard only.
https://bugs.webkit.org/show_bug.cgi?id=62223

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceRequest.h:
15:35 Changeset [88397] by commit-queue@webkit.org

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key sort order across types
https://bugs.webkit.org/show_bug.cgi?id=62299

  • storage/indexeddb/key-sort-order-across-types-expected.txt: Added.
  • storage/indexeddb/key-sort-order-across-types.html: Added.
15:24 Changeset [88396] by commit-queue@webkit.org

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.

  • wtf/Platform.h:

2011-06-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Mihai Parparita.

Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756

Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
  • platform/chromium/ScrollbarThemeChromiumMac.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint):
15:07 Changeset [88395] by commit-queue@webkit.org

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key sort order for Date objects
https://bugs.webkit.org/show_bug.cgi?id=62300

  • storage/indexeddb/key-sort-order-date-expected.txt: Added.
  • storage/indexeddb/key-sort-order-date.html: Added.
14:54 Changeset [88394] by oliver@apple.com

2011-06-08 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add faster lookup cache for multi character identifiers
https://bugs.webkit.org/show_bug.cgi?id=62327

Add a non-hash lookup for mutiple character identifiers. This saves us from
adding repeated identifiers to the ParserArena's identifier list as people
tend to not start all their variables and properties with the same character
and happily identifier locality works in our favour.

  • parser/ParserArena.h: (JSC::IdentifierArena::isEmpty): (JSC::IdentifierArena::clear): (JSC::IdentifierArena::makeIdentifier):
14:53 Changeset [88393] by xji@chromium.org

2011-06-08 Xiaomei Ji <xji@chromium.org>

Split move-by-word-visually.html into 2 tests since the test is continuing growing and caused
time-out in Snowleopard Intel Leaks.

We will need to do profiling to improve hot code path performance later.

  • editing/selection/move-by-word-visually-expected.txt: Removed.
  • editing/selection/move-by-word-visually-others-expected.txt: Added.
  • editing/selection/move-by-word-visually-others.html: Added.
  • editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-expected.txt.
  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually.html.
  • editing/selection/move-by-word-visually.html: Removed.
  • editing/selection/resources/move-by-word-visually.js: Added. (): (flushLog): (fold): (logPositions): (nodeOfWordBreak): (logWordBreak): (positionEqualToWordBreak): (validateData): (collectWordBreaks): (setPosition): (moveByWord): (moveByWordOnEveryChar): (moveByWordForEveryPosition): (runMoveLeftRight):
14:53 Changeset [88392] by noam.rosenthal@nokia.com

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add an ArgumentCoder for FloatPoint3D.

Together with Viatcheslav Ostapenko.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
14:45 Changeset [88391] by japhet@chromium.org

2011-06-06 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove all knowledge of CachedResourceRequests from
CachedResourceLoader. This puts the full burden of
canceling these requests on DocumentLoader (via
SubresourceLoader), and makes a CachedResourceRequest
an OwnPtr in CachedResource.

https://bugs.webkit.org/show_bug.cgi?id=62308

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::load): (WebCore::CachedResource::stopLoading):
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::loadDone):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::CachedResourceRequest): (WebCore::CachedResourceRequest::~CachedResourceRequest): (WebCore::CachedResourceRequest::load): (WebCore::CachedResourceRequest::didFinishLoading): (WebCore::CachedResourceRequest::didFail): (WebCore::CachedResourceRequest::didReceiveResponse): (WebCore::CachedResourceRequest::end):
  • loader/cache/CachedResourceRequest.h:
14:39 Changeset [88390] by jamesr@google.com

2011-06-08 Mike Reed <reed@google.com>

Reviewed by James Robinson.

[Skia] check for null-shader from gradient factory
https://bugs.webkit.org/show_bug.cgi?id=62319

  • platform/chromium-linux/fast/gradients/crash-on-degenerate-gradient-expected.txt: Added.

2011-06-08 Mike Reed <reed@google.com>

Reviewed by James Robinson.

[Skia] check for null-shader from gradient factory
https://bugs.webkit.org/show_bug.cgi?id=62319

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::platformGradient):
14:39 Changeset [88389] by ggaren@apple.com

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Took some responsibilities away from NewSpace
https://bugs.webkit.org/show_bug.cgi?id=62325


NewSpace is basically just an allocator now.


Heap acts as a controller, responsible for managing the set of all
MarkedBlocks.


This is in preparation for moving parts of the controller logic into
separate helper classes that can act on arbitrary sets of MarkedBlocks
that may or may not be in NewSpace.

  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::allocate): (JSC::Heap::markRoots): (JSC::Heap::clearMarks): (JSC::Heap::sweep): (JSC::Heap::objectCount): (JSC::Heap::size): (JSC::Heap::capacity): (JSC::Heap::collect): (JSC::Heap::resetAllocator): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlocks): (JSC::Heap::shrink): Moved the set of MarkedBlocks from NewSpace to Heap, along with all functions that operate on the set of MarkedBlocks. Also moved responsibility for deciding whether to allocate a new MarkedBlock, and for allocating it.
  • heap/Heap.h: (JSC::Heap::contains): (JSC::Heap::forEach): Ditto.
  • heap/NewSpace.cpp: (JSC::NewSpace::addBlock): (JSC::NewSpace::removeBlock): (JSC::NewSpace::resetAllocator):
  • heap/NewSpace.h: (JSC::NewSpace::waterMark): (JSC::NewSpace::allocate): Ditto.
14:38 Changeset [88388] by ojan@chromium.org

2011-06-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add a short-flag for --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=62321

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:27 Changeset [88387] by kbr@google.com

2011-06-08 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/mac-wk2/Skipped:

2011-06-08 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
14:16 Changeset [88386] by jamesr@google.com

2011-06-08 John Bauman <jbauman@chromium.org>

Reviewed by James Robinson.

Only draw portions of tiles in contentRect
https://bugs.webkit.org/show_bug.cgi?id=62243

  • platform/chromium/test_expectations.txt:
  • compositing/repaint/shrink-layer.html: Added.
  • compositing/repaint/shrink-layer-expected.png: Added.
  • compositing/repaint/shrink-layer-expected.txt: Added.

2011-06-08 John Bauman <jbauman@chromium.org>

Reviewed by James Robinson.

Only draw portions of tiles in contentRect
https://bugs.webkit.org/show_bug.cgi?id=62243

Old garbage data can remain in tiles, so make sure to draw only those
portions that are supposed to be drawn.

Test: compositing/repaint/shrink-layer.html

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
14:15 Changeset [88385] by eae@chromium.org

2011-06-08 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBlock::isPointInOverflowControl to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62312

Covered by existing tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
  • rendering/RenderListBox.h:
14:02 Changeset [88384] by commit-queue@webkit.org

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: odd value datatypes
https://bugs.webkit.org/show_bug.cgi?id=62315

  • storage/indexeddb/values-odd-types-expected.txt: Added.
  • storage/indexeddb/values-odd-types.html: Added.
14:01 Changeset [88383] by rniwa@webkit.org

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: don't turn the tree red when there are new passes
https://bugs.webkit.org/show_bug.cgi?id=62311

Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
to match commandComplete.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
13:43 Changeset [88382] by simonjam@chromium.org

2011-06-08 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Fix clang issue, virtual function const mismatch
https://bugs.webkit.org/show_bug.cgi?id=62307

No new tests. Built with clang & ran layout tests.

  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
13:42 Changeset [88381] by commit-queue@webkit.org

2011-06-08 Tom Hudson <tomhudson@google.com>

Reviewed by Mihai Parparita.

Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=60964

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Add 'Sort tests by metric' link.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: (disableSorting): Activate 'Sort tests by metric' link. (enableSorting): Deactivate 'Sort tests by metric' link. (selectDirectory): Call enableSorting()/disableSorting() depending on currently selected failure type, and sort tests if requested.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: New .disabled-control class for deactivated links.
13:29 Changeset [88380] by crogers@google.com

2011-06-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
https://bugs.webkit.org/show_bug.cgi?id=62078

No new tests since audio API is not yet implemented.

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::reset): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setNormalizedCoefficients): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setHighShelfParams): (WebCore::Biquad::setPeakingParams): (WebCore::Biquad::setAllpassParams): (WebCore::Biquad::setNotchParams): (WebCore::Biquad::setBandpassParams): (WebCore::Biquad::setZeroPolePairs): (WebCore::Biquad::setAllpassPole):
  • platform/audio/Biquad.h:
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::createBiquadFilter): (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
  • webaudio/AudioNode.h:
  • webaudio/BiquadDSPKernel.cpp: (WebCore::BiquadDSPKernel::process):
  • webaudio/BiquadFilterNode.cpp: Added. (WebCore::BiquadFilterNode::BiquadFilterNode):
  • webaudio/BiquadFilterNode.h: Added. (WebCore::BiquadFilterNode::create): (WebCore::BiquadFilterNode::type): (WebCore::BiquadFilterNode::setType): (WebCore::BiquadFilterNode::frequency): (WebCore::BiquadFilterNode::q): (WebCore::BiquadFilterNode::gain): (WebCore::BiquadFilterNode::biquadProcessor):
  • webaudio/BiquadFilterNode.idl: Added.
  • webaudio/BiquadProcessor.cpp: (WebCore::BiquadProcessor::BiquadProcessor):
  • webaudio/BiquadProcessor.h: (WebCore::BiquadProcessor::setType):
  • webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  • webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):
13:16 Changeset [88379] by ggaren@apple.com

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Some more MarkedSpace => NewSpace renaming
https://bugs.webkit.org/show_bug.cgi?id=62305

  • JavaScriptCore.exp:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::reportExtraMemoryCostSlowCase): (JSC::Heap::allocate): (JSC::Heap::markRoots): (JSC::Heap::objectCount): (JSC::Heap::size): (JSC::Heap::capacity): (JSC::Heap::collect): (JSC::Heap::isValidAllocation):
  • heap/Heap.h: (JSC::Heap::markedSpace): (JSC::Heap::contains): (JSC::Heap::forEach): (JSC::Heap::allocate):
  • runtime/JSCell.h:
13:07 Changeset [88378] by noam.rosenthal@nokia.com

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

No new tests, code path is not activated yet.

  • WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"

2011-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=61694

Add ArgumentCoders for TransformOperation, including all the subclasses,
and TransformOperations.

  • Scripts/webkit2/messages.py:
  • Shared/WebCoreArgumentCoders.h:
13:05 Changeset [88377] by commit-queue@webkit.org

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Chromium mixed content blocking, ensure that both preferences and web permissions
control the outcome. Ensure notify callback gets invoked even with insecure content.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/http/tests/security/mixedContent: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked-expected.txt: Added.
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html: Added.

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Cause checks for insecure content blocking policy to callback to client.
https://bugs.webkit.org/show_bug.cgi?id=61946
Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html

platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowDisplayingInsecureContent): (WebCore::FrameLoaderClient::allowRunningInsecureContent):

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Add new permission callbacks for mixed content blocking.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowDisplayingInsecureContent): (WebKit::WebPermissionClient::allowRunningInsecureContent):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowDisplayingInsecureContent): (WebKit::FrameLoaderClientImpl::allowRunningInsecureContent):
  • src/FrameLoaderClientImpl.h:

2011-06-08 Tom Sepez <tsepez@chromium.org>

Reviewed by Adam Barth.

Add web permissions callbacks for mixed content blocking.
https://bugs.webkit.org/show_bug.cgi?id=61946

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAllowDisplayOfInsecureContent): (LayoutTestController::setAllowRunningOfInsecureContent): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/WebPermissions.cpp: (WebPermissions::allowDisplayingInsecureContent): (WebPermissions::allowRunningInsecureContent): (WebPermissions::setDisplayingInsecureContentAllowed): (WebPermissions::setRunningInsecureContentAllowed): (WebPermissions::reset):
  • DumpRenderTree/chromium/WebPermissions.h:
13:04 Changeset [88376] by kevino@webkit.org

2011-06-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Add export macros to profiler headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

  • profiler/Profiler.h:
12:54 Changeset [88375] by simonjam@chromium.org

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, mark two flaky tests. Bug filed.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [88374] by kevino@webkit.org

2011-06-08 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Add export symbols to parser headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

  • parser/SourceProviderCache.h:
12:50 Changeset [88373] by dpranke@chromium.org

2011-06-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
https://bugs.webkit.org/show_bug.cgi?id=62259

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
12:45 Changeset [88372] by kevino@webkit.org

Reviewed by Eric Seidel.

Add export symbols to interpreter headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

12:41 Changeset [88371] by kevino@webkit.org

[wx] Build fix after introduction of FontCache::ShouldRetain.

12:31 Changeset [88370] by kevino@webkit.org

Reviewed by Eric Seidel.

Add export symbols to debugger headers.
https://bugs.webkit.org/show_bug.cgi?id=27551

12:11 Changeset [88369] by rniwa@webkit.org

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
https://bugs.webkit.org/show_bug.cgi?id=62303

Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:58 Changeset [88368] by ggaren@apple.com

2011-06-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved MarkedSpace.* to NewSpace.* in preparation for more renaming
https://bugs.webkit.org/show_bug.cgi?id=62268

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.h:
  • heap/MarkedBlock.h:
  • heap/MarkedSpace.cpp: Removed.
  • heap/MarkedSpace.h: Removed.
  • heap/NewSpace.cpp: Copied from Source/JavaScriptCore/heap/MarkedSpace.cpp.
  • heap/NewSpace.h: Copied from Source/JavaScriptCore/heap/MarkedSpace.h.
11:40 Changeset [88367] by loislo@chromium.org

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88365.
http://trac.webkit.org/changeset/88365
https://bugs.webkit.org/show_bug.cgi?id=62301

windows bots broken (Requested by loislo_ on #webkit).

2011-06-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88365.
http://trac.webkit.org/changeset/88365
https://bugs.webkit.org/show_bug.cgi?id=62301

windows bots broken (Requested by loislo_ on #webkit).

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
11:33 Changeset [88366] by rniwa@webkit.org

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Added new entries for skia/third_party/glu.

  • DEPS:
11:24 Changeset [88365] by loislo@chromium.org

2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>

Reviewed by Pavel Feldman.

Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791

No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON): Added checking the predicted buffer size and choosing exponential format, or eventually "NaN" if the buffer is too small for decimal format.
11:20 Changeset [88364] by thakis@chromium.org

2011-06-08 Nico Weber <thakis@chromium.org>

Reviewed by Darin Adler.

Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
https://bugs.webkit.org/show_bug.cgi?id=62295

This was found by a new warning recently added to clang's -Wparentheses

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::backButtonRect):
11:19 Changeset [88363] by rniwa@webkit.org

2011-06-08 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
11:15 Changeset [88362] by commit-queue@webkit.org

2011-06-08 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: key paths as arrays
https://bugs.webkit.org/show_bug.cgi?id=62291

  • storage/indexeddb/keypath-as-array-expected.txt: Added.
  • storage/indexeddb/keypath-as-array.html: Added.
11:12 Changeset [88361] by caio.oliveira@openbossa.org

2011-06-08 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Remove dead code from our JSC bridge
https://bugs.webkit.org/show_bug.cgi?id=62287

The m_defaultMethod member is not used since r36848 and QtMethod
was replaced by QtRuntimeMethod and subclasses in r29729.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::visitAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.h:
11:04 Changeset [88360] by commit-queue@webkit.org

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

  • WebCore.gyp/WebCore.gyp:

2011-06-08 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Tony Chang.

Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6

Compiling Chromium port under GCC 4.6 produces warnings about nullptr
https://bugs.webkit.org/show_bug.cgi?id=62242

  • WebKit.gyp:
11:03 Changeset [88359] by xji@chromium.org

2011-05-25 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

--webkit-visual-word does not work well in words separated by multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
right word boundary (before the space or after the space) by using previousWordPosition and
nextWordPosition. But they assume words are separated by single space and are not correct
for words separated by multiple spaces and words not separated by space.

Consider positionBeforeNextWord() for example,

First, it checks whether the current position is after the current word by checking current
position's previousWordPosition's nextWordPosition is the same as current position, which is
wrong for words separated by multiple spaces. For example, given words A and B separated by
3 continuous spaces "A B", position "A|", "A |", and "A |" should all be considered as
position after current word. But for position "A |", its previousWordPosition's
nextWordPosition is position "A|", which is different from its current position, so the
current position is not considered as a position after current word, consequently,
instead of returning the right position as "A |B", positionBeforeNextWord returns the
position before next next word, as "A B |C". Similar happens for position "A |".

Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at
"A|BC", positionBeforeNextWord() returns the same position after calling current position's
nextWordPosition's previousWordPosition. It should returns position "AB|C".

For those cases, we will have to collect all the word breaks inside the box and look for
the one at left or right of current position.

  • editing/visible_units.cpp: (WebCore::leftWordPosition): (WebCore::rightWordPosition):

2011-05-25 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

--webkit-visual-word does not work well in words separated by multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=61324

Add test cases for preserving white spaces and test case for words not separated by space.

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:
10:50 Changeset [88358] by commit-queue@webkit.org

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Test migration from sqlite to leveldb for IndexedDB
backend.
https://bugs.webkit.org/show_bug.cgi?id=61000

  • storage/indexeddb/migrate-basics-expected.txt: Added.
  • storage/indexeddb/migrate-basics.html: Added.

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

Test: storage/indexeddb/migrate-basics.html

  • storage/IDBBackingStore.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::migrate):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h: (WebCore::IDBLevelDBBackingStore::backingStoreType):
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h: (WebCore::IDBSQLiteBackingStore::backingStoreType):

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • public/WebIDBFactory.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactory::setOverrideBackingStoreType): (WebKit::WebIDBFactory::setTemporaryDatabaseFolder): (WebKit::WebIDBFactoryImpl::open):

2011-06-08 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Control Indexeddb backends from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=61000

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
10:31 Changeset [88357] by commit-queue@webkit.org

2011-06-08 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62164
Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
This functionality is untested and unused:
This is an old code from Lockers-based implementation of WebWorkers in
V8 bindings, to make sure that DOM objects are released on the right thread
even though GC could have happened on any thread. It is currently unused (since
current model is one worker per process) and is being removed because new implementation
of WebWorkers will be using V8 isolates.

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/ChildThreadDOMData.cpp: Removed.
  • bindings/v8/ChildThreadDOMData.h: Removed.
  • bindings/v8/DOMData.cpp: (WebCore::DOMData::DOMData): (WebCore::DOMData::getCurrent): (WebCore::DOMData::getMainThreadStore):
  • bindings/v8/DOMData.h: (WebCore::DOMData::getStore): (WebCore::DOMData::getCurrentMainThreadStore): (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/MainThreadDOMData.cpp: Removed.
  • bindings/v8/MainThreadDOMData.h: Removed.
  • bindings/v8/V8DOMMap.cpp: (WebCore::getDOMDataStore): (WebCore::removeAllDOMObjects): (WebCore::visitDOMNodes): (WebCore::visitDOMObjects): (WebCore::visitActiveDOMObjects): (WebCore::visitDOMSVGElementInstances):
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcPrologue): (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
10:27 Changeset [88356] by simonjam@chromium.org

2011-06-08 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, skip two failing tests. Bugs filed.

  • platform/chromium/test_expectations.txt:
10:14 Changeset [88355] by ademar.reis@openbossa.org

2011-06-08 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>

Reviewed by Andreas Kling.

Webkit on SPARC Solaris has wrong endian
https://bugs.webkit.org/show_bug.cgi?id=29407

Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
there are more ocurrences of the same code pattern in webkit.

This patch includes the check on these other parts of the code.

This is a speculative fix, I don't have a sparc machine to test and
don't know which kind of test would trigger a crash (but it's quite
obvious that it's the same code duplicated in different files).

  • runtime/UString.h: (JSC::UStringHash::equal):
  • wtf/text/StringHash.h: (WTF::StringHash::equal):
10:10 Changeset [88354] by commit-queue@webkit.org

2011-06-08 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implements "undo" command execution
https://bugs.webkit.org/show_bug.cgi?id=62201

Supports to execute "Undo" command.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canUndo): (WebCore::EditorClientEfl::undo):
  • WebCoreSupport/EditorClientEfl.h:
09:16 Changeset [88353] by andreas.kling@nokia.com

2011-06-08 Andreas Kling <kling@webkit.org>

Add Pierre Rossi to contributors list for EZ-CC.

  • Scripts/webkitpy/common/config/committers.py:
09:16 Changeset [88352] by commit-queue@webkit.org

2011-06-08 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Antonio Gomes.

[EFL] remove adjusting codes for zoom's center coordinate
https://bugs.webkit.org/show_bug.cgi?id=62266

It is possible that the application developers don't want to limit
zoom's center coordinate to the viewport for implementing some effects
and center coordinate out of the viewport does not affect to the zoom operation.
So, It is better to leave zoom's center coordinate freely.

  • ewk/ewk_view.cpp: (ewk_view_zoom_set): (ewk_view_zoom_weak_set):
08:52 Changeset [88351] by commit-queue@webkit.org

2011-06-08 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add a method to return the line breaks for any element with
multiline text content.
https://bugs.webkit.org/show_bug.cgi?id=62236

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::lineBreaks):
08:28 Changeset [88350] by yael.aharon@nokia.com

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -ljavascriptcore
into QtWebKit.prl.

No new tests, as this is just a build fix.

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
into QtWebKit.prl.

No new tests, as this is just a build fix.

  • WebCore.pri:

2011-06-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280

Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
into QtWebKit.prl.

  • WebKit2.pri:
08:24 Changeset [88349] by apavlov@chromium.org

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt] Unreviewed, skip failing tests

  • platform/qt/Skipped:
07:58 Changeset [88348] by commit-queue@webkit.org

2011-06-08 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Render non-document HTML resources as HTML
https://bugs.webkit.org/show_bug.cgi?id=58886

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): (WebInspector.Resource.prototype.hasErrorStatusCode):
  • inspector/front-end/ResourceHTMLView.js: Added. (WebInspector.ResourceHTMLView): (WebInspector.ResourceHTMLView.prototype.hasContent): (WebInspector.ResourceHTMLView.prototype.show): (WebInspector.ResourceHTMLView.prototype.hide): (WebInspector.ResourceHTMLView.prototype._createIFrame):
  • inspector/front-end/ResourcePreviewView.js: Added. (WebInspector.ResourcePreviewView): (WebInspector.ResourcePreviewView.prototype.hasContent): (WebInspector.ResourcePreviewView.prototype.show): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown): (WebInspector.ResourcePreviewView.prototype._createInnerView):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.resource-view.html iframe):
  • inspector/front-end/inspector.html:
07:52 Changeset [88347] by apavlov@chromium.org

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt, Chromium] Unreviewed attempt to fix tests on Qt and Chromium.

  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/up-down-numerics-and-colors.html:
07:12 Changeset [88346] by gyuyoung.kim@samsung.com

2011-06-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Enable PROGRESS_TAG feature
https://bugs.webkit.org/show_bug.cgi?id=62212

  • Source/cmake/OptionsEfl.cmake: Turn on PROGRESS_TAG by default.
06:57 QtWebKitBuildBots edited by ossy@webkit.org
(diff)
06:57 Changeset [88345] by loislo@chromium.org

2011-06-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed chromium build fix for r88332.

  • src/WebRuntimeFeatures.cpp:
06:56 QtWebKitBuildBots edited by ossy@webkit.org
(diff)
06:48 Changeset [88344] by podivilov@chromium.org

2011-05-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=61035

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL): (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
06:24 Changeset [88343] by commit-queue@webkit.org

2011-06-08 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

StreamEvent

Media Stream PeerConnection API: adding StreamEvent class
https://bugs.webkit.org/show_bug.cgi?id=61537

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp: (WebCore::Event::isStreamEvent):
  • dom/Event.h:
  • dom/StreamEvent.cpp: Added. (WebCore::StreamEvent::create): (WebCore::StreamEvent::StreamEvent): (WebCore::StreamEvent::~StreamEvent): (WebCore::StreamEvent::initStreamEvent): (WebCore::StreamEvent::stream):
  • dom/StreamEvent.h: Added. (WebCore::StreamEvent::isStreamEvent):
  • dom/StreamEvent.idl: Added.
06:19 Changeset [88342] by demarchi@webkit.org

2011-06-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Never let a WTF_FEATURE defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=60820

If a port doesn't want to give the user some configure options,
nevertheless it would have to define this feature as OFF. Otherwise
there's a build error because the generated cmakeconfig.h is not
parsed correctly by ENABLE macro, which expects each feature to be
either undefined or defined to TRUE/FALSE.

  • Source/cmake/WebKitFeatures.cmake: Use a variable with the same name of the feature, which allows CONFIGURE_FILE() to replace it in the new cmakeconfig.h.cmake.
  • Source/cmakeconfig.h.cmake: use #cmakedefine01 instead of #define with another variable. This way the feature will always be 0 or 1 and it will never be left undefined.
06:08 Changeset [88341] by commit-queue@webkit.org

2011-06-08 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Media Stream API: integrate the Track List objects into the existing code.
https://bugs.webkit.org/show_bug.cgi?id=60205

Tests for the Media Stream API will be provided by the bug 56587.

  • dom/ExclusiveTrackList.cpp: (WebCore::ExclusiveTrackList::select): (WebCore::ExclusiveTrackList::trackFailed):
  • dom/ExclusiveTrackList.h:
  • dom/GeneratedStream.cpp: (WebCore::GeneratedStream::create): (WebCore::GeneratedStream::GeneratedStream): (WebCore::GeneratedStream::streamEnded): (WebCore::GeneratedStream::audioTracks): (WebCore::GeneratedStream::videoTracks): (WebCore::GeneratedStream::stop):
  • dom/GeneratedStream.h:
  • dom/GeneratedStream.idl:
  • dom/MultipleTrackList.cpp: (WebCore::MultipleTrackList::trackFailed): (WebCore::MultipleTrackList::enable): (WebCore::MultipleTrackList::disable):
  • dom/MultipleTrackList.h:
  • dom/Stream.h:
  • dom/TrackList.cpp: (WebCore::TrackList::clear): (WebCore::TrackList::associateStream): (WebCore::TrackList::associatedStreamLabel): (WebCore::TrackList::trackFailed): (WebCore::TrackList::scriptExecutionContext):
  • dom/TrackList.h:
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp: (WebCore::MediaStreamController::enableAudioTrack): (WebCore::MediaStreamController::disableAudioTrack): (WebCore::MediaStreamController::selectVideoTrack): (WebCore::MediaStreamController::streamGenerated): (WebCore::MediaStreamController::audioTrackFailed): (WebCore::MediaStreamController::videoTrackFailed):
  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp: (WebCore::MediaStreamFrameController::unregister): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::enableAudioTrack): (WebCore::MediaStreamFrameController::disableAudioTrack): (WebCore::MediaStreamFrameController::selectVideoTrack): (WebCore::MediaStreamFrameController::streamGenerated): (WebCore::MediaStreamFrameController::audioTrackFailed): (WebCore::MediaStreamFrameController::videoTrackFailed):
  • page/MediaStreamFrameController.h: (WebCore::MediaStreamFrameController::ClientBase::isGenericClient): (WebCore::MediaStreamFrameController::GenericClient::GenericClient): (WebCore::MediaStreamFrameController::GenericClient::~GenericClient): (WebCore::MediaStreamFrameController::GenericClient::isGenericClient): (WebCore::MediaStreamFrameController::GenericClient::unregister):
06:06 Changeset [88340] by apavlov@chromium.org

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

[Qt] Unreviewed, attempt to make test pass on Qt.

  • inspector/styles/styles-update-from-js.html:
05:52 Changeset [88339] by andreas.kling@nokia.com

2011-06-08 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
https://bugs.webkit.org/show_bug.cgi?id=62274

Vector::find() returns size_t (which is unsigned), so we should check
for WTF::notFound instead of -1.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
05:18 Changeset [88338] by podivilov@chromium.org

2011-06-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] breakpoints are not persisted.
https://bugs.webkit.org/show_bug.cgi?id=62273

  • inspector/front-end/Settings.js:
04:31 Changeset [88337] by apavlov@chromium.org

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:

2011-06-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

Schedule full style updates rather than request all node styles from the backend immediately.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles): (WebInspector.StylesSidebarPane.prototype.update):
03:52 Changeset [88336] by andreas.kling@nokia.com

2011-06-08 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] Float{32,64}Array and Int16Array fail to build.
https://bugs.webkit.org/show_bug.cgi?id=62219

For some reason, RVCT 2.x is moaning about "class member designated by
a using-declaration must be visible in a direct base class".
Apply same fix as r69122 and r76592.

  • html/canvas/Float32Array.h: (WebCore::Float32Array::set):
  • html/canvas/Float64Array.h: (WebCore::Float64Array::set):
  • html/canvas/Int16Array.h: (WebCore::Int16Array::set):
03:33 Changeset [88335] by commit-queue@webkit.org

2011-06-08 Syed Idris Shah <syed.idris-shah@nokia.com>

Reviewed by Andreas Kling.

[Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
https://bugs.webkit.org/show_bug.cgi?id=61945

For OpenGL ES we do not need these features.
These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.

LayoutTests/fast/canvas/webgl/point-size.html

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
02:39 Changeset [88334] by isherman@chromium.org

2011-06-08 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Add Ilya Sherman to list of committers
https://bugs.webkit.org/show_bug.cgi?id=62270

  • Scripts/webkitpy/common/config/committers.py:
02:02 Changeset [88333] by gyuyoung.kim@samsung.com

2011-06-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

  • platform/efl/RenderThemeEfl.cpp:
  • platform/efl/RenderThemeEfl.h:
01:54 Changeset [88332] by morrita@google.com

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

  • editing/spelling/spellcheck-api-expected.txt: Added.
  • editing/spelling/spellcheck-api-pixel.html: Added.
  • editing/spelling/spellcheck-api.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

Tests: editing/spelling/spellcheck-api-pixel.html

editing/spelling/spellcheck-api.html

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled): (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::length):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): (WebCore::DocumentMarkerController::addUserSpellingMarker): (WebCore::DocumentMarkerController::removeUserSpellingMarker): (WebCore::DocumentMarkerController::userSpellingNode):
  • dom/DocumentMarkerController.h:
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::spellcheckRanges): (WebCore::HTMLDivElement::addSpellcheckRange): (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLDivElement.h:
  • html/HTMLDivElement.idl:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::spellcheckRanges): (WebCore::HTMLInputElement::addSpellcheckRange): (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::spellcheckRanges): (WebCore::HTMLTextAreaElement::addSpellcheckRange): (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.idl:
  • html/SpellcheckRange.cpp: Added. (WebCore::SpellcheckRange::SpellcheckRange): (WebCore::SpellcheckRange::~SpellcheckRange):
  • html/SpellcheckRange.h: Added. (WebCore::SpellcheckRange::create): (WebCore::SpellcheckRange::start): (WebCore::SpellcheckRange::length): (WebCore::SpellcheckRange::suggestions): (WebCore::SpellcheckRange::options):
  • html/SpellcheckRange.idl: Added.
  • html/SpellcheckRangeList.cpp: Added. (WebCore::SpellcheckRangeList::SpellcheckRangeList): (WebCore::SpellcheckRangeList::~SpellcheckRangeList): (WebCore::SpellcheckRangeList::item):
  • html/SpellcheckRangeList.h: Added. (WebCore::SpellcheckRangeList::create): (WebCore::SpellcheckRangeList::isEmpty): (WebCore::SpellcheckRangeList::clear): (WebCore::SpellcheckRangeList::append): (WebCore::SpellcheckRangeList::remove): (WebCore::SpellcheckRangeList::length):
  • html/SpellcheckRangeList.idl: Added.
  • rendering/InlineTextBox.cpp: (WebCore::textCheckingLineStyleForMarkerType): (WebCore::InlineTextBox::paintDocumentMarkers):

2011-06-08 Hironori Bono <hbono@chromium.org>

Reviewed by Brent Fulgham.

Add SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

This change adds two SpellCheck API functions (addSpellcheckRange and
removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
the public-webapps ML. This change is currently available only on Chromium.

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableSpellCheckAPI): (WebKit::WebRuntimeFeatures::isSpellCheckAPIEnabled):
01:27 Changeset [88331] by caseq@chromium.org

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js: (Element.prototype.query):

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.findNode.documentRequested): (initialize_ElementTest.InspectorTest.findNode):
  • inspector/console/console-shadow-dom-access.html: Removed.
  • inspector/elements/shadow-dom-expected.txt: Removed.
  • inspector/elements/shadow-dom.html: Removed.
  • platform/win/Skipped:
00:20 Changeset [88330] by mrowe@apple.com

Fix the build.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):

00:05 QtWebKitBuildBots edited by ossy@webkit.org
Update Qt and Mobility version on 4.7.x and on 4.8.x bots (diff)
00:02 QtWebKitBuildBots edited by ossy@webkit.org
remove ARM-GTK bot (diff)
Note: See TracTimeline for information about the timeline view.