Timeline


and

06/14/11:

23:27 Changeset [88909] by ossy@webkit.org

[Qt] Update platform specific expected file.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
23:24 Changeset [88908] by morrita@google.com

2011-06-09 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should detach its inclusions before attaching them.
https://bugs.webkit.org/show_bug.cgi?id=62428

  • On ShadowContentElement::attach(), changed inclusion attach scheme from per-node reattach() to detach()-all-and-attach()-them. This eliminates attach() order problems which ShadowContentElement possibly has.
  • Changed ShadowContentElement to have m_inclusions as a member variable, which will be used by upcoming changes.
  • Moved attach() code from ShadowContentSelector to ShadowContentElement because the element now owns the inclusion list.

No new tests. No visible behavioral change yet.

  • dom/ShadowContentElement.cpp: (WebCore::ShadowContentElement::attach): (WebCore::ShadowContentElement::detach): Added.
  • dom/ShadowContentElement.h: (WebCore::ShadowContentElement::inclusionAt): Added. (WebCore::ShadowContentElement::inclusionCount): Added. (WebCore::toShadowContentElement):
  • dom/ShadowContentSelector.cpp: Removed attachChildrenFor() (WebCore::ShadowContentSelector::selectInclusion): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::willAttachContentFor): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::didAttachContent): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::activeElement):
  • dom/ShadowContentSelector.h:
23:13 Changeset [88907] by commit-queue@webkit.org

2011-06-14 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Sam Weinig.

[EFL][WK2] Change string operation to makeString()
https://bugs.webkit.org/show_bug.cgi?id=62527

Use makeString() because it is better than creating individual strings and concatenating them.

  • UIProcess/efl/WebPageProxyEfl.cpp: (WebKit::WebPageProxy::standardUserAgent):
22:29 Changeset [88906] by weinig@apple.com

2011-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Follow up for Callers should be robust against WebImage::create() returning an image with a null snapshot
https://bugs.webkit.org/show_bug.cgi?id=62666

  • Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage): (WKImageCreateFromCGImage): Don't null check the arguments (as per our API design) or the direct result of WebImage::create.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): Remove redundant check and make not being able to create a handle the same as not being backed by shareable memory.
21:37 Changeset [88905] by ddkilzer@apple.com

<http://webkit.org/b/62677> Part 2/2: Remove duplicate header entries in WebCore project file

Reviewed by Darin Adler.

Most of the DOMSVG*.h headers were added in late 2006, and then
duplicated by late 2007. They've been in the tree a long time.

  • WebCore.xcodeproj/project.pbxproj: Let Xcode 4 remove

duplicate header entries.

21:37 Changeset [88904] by ddkilzer@apple.com

<http://webkit.org/b/62677> Part 1/2: Remove duplicate header entries in WebCore project file

Reviewed by Darin Adler.

These headers were added as duplicates in r83256:

DefaultAudioDestinationNode.h
JSOfflineAudioCompletionEvent.h
OfflineAudioCompletionEvent.h
OfflineAudioDestinationNode.h

The following duplicates were introduced in r84053 (after having
been originally added in r83729):

StorageInfo.h
StorageInfoErrorCallback.h
StorageInfoQuotaCallback.h
StorageInfoUsageCallback.h

  • WebCore.xcodeproj/project.pbxproj: Remove duplicates using

'uniq' since sort-Xcode-project-file did most of the work.

20:51 Changeset [88903] by sullivan@apple.com

<https://bugs.webkit.org/show_bug.cgi?id=62693>
<rdar://problem/9601436>
windowsKeyCodeForKeyEvent should be robust against NSFlagsChanged events

Reviewed by Ada Chan.

  • Shared/mac/WebEventFactory.mm:

(WebKit::windowsKeyCodeForKeyEvent):
Explicitly check for NSFlagsChanged before calling -charactersIgnoringModifiers, since
charactersIgnoringModifiers throws an exception for NSFlagsChanged events.

20:44 Changeset [88902] by rniwa@webkit.org

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Skip editing/inserting/return-key-span-start.html added by r88890 on Mac WebKit2
since TestRunner doesn't implement eventSender.keyDown.

  • platform/mac-wk2/Skipped:
20:41 Changeset [88901] by tkent@chromium.org

2011-06-14 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

REGRESSION(r88757): [Chromium] Vertical position of media slider thumb is wrong.
https://bugs.webkit.org/show_bug.cgi?id=62685

No new tests. Covered by existing tests.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Center the thumb position.
  • rendering/RenderSlider.h:
20:27 Changeset [88900] by lforschler@apple.com

Merge r88857.

20:26 Changeset [88899] by lforschler@apple.com

Merge r88857.

19:58 Changeset [88898] by kbr@google.com

Merge 88489 - 2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7171012

19:41 Changeset [88897] by gyuyoung.kim@samsung.com

2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Change color initialization with clear color constant
https://bugs.webkit.org/show_bug.cgi?id=62691

Some color values are initialized by rbg value. Color constant value is more clear than
rgb value.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl):
19:40 Changeset [88896] by jchaffraix@webkit.org

2011-06-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48293

And

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48303

  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt: Added a trailing line.
  • fast/canvas/canvas-composite-alpha.html: Updated now that we clear what is outside the source.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped: Update platform skipped lists.

2011-06-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48293

And

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48303

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationIn as this is the only one that needs a specific treatment.
19:10 Changeset [88895] by takano.naoki@gmail.com

2011-06-14 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Forward modifiers + up/down key events to text field when autofill popup window is shown.
https://bugs.webkit.org/show_bug.cgi?id=62350
http://code.google.com/p/chromium/issues/detail?id=61349

Manual test: autofill-popup-shiftupdown.html

  • manual-tests/chromium/autofill-popup-shiftupdown.hml: Added to check modifier + up/down key is working correctly for text area in autofill popup is shown.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent): Check modifier key and menu style to decide if the event should be forwarded or not.
19:03 Changeset [88894] by rniwa@webkit.org

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaseline for r88883.

  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
18:57 Changeset [88893] by lforschler@apple.com

Versioning.

18:56 Changeset [88892] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=43841
SegmentedVector::operator== typo

Reviewed by Sam Weinig.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVectorIterator::operator==):
(WTF::SegmentedVectorIterator::operator!=):

18:56 Changeset [88891] by lforschler@apple.com

New tag.

18:51 Changeset [88890] by commit-queue@webkit.org

2011-06-14 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Span ID duplicated when pressing enter at beginning of span
https://bugs.webkit.org/show_bug.cgi?id=62621

Added test for span id not getting duplicated when span is cloned.

  • editing/inserting/return-key-span-start-expected.txt: Added.
  • editing/inserting/return-key-span-start.html: Added.

2011-06-14 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Span ID duplicated when pressing enter at beginning of span
https://bugs.webkit.org/show_bug.cgi?id=62621

Strip id from cloned span, so that it is not duplicated.

Test: editing/inserting/return-key-span-start.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
18:33 Changeset [88889] by rniwa@webkit.org

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Mac, Windows, and Chromium rebaseline for r88883.

  • platform/chromium-linux/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/win/fast/forms/basic-textareas-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
18:13 Changeset [88888] by tkent@chromium.org

2011-06-14 Kent Tamura <tkent@chromium.org>

[Chromium][Qt] Assign new bug numbers for slider failures, and skip a test on Qt.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
18:11 Changeset [88887] by cfleizach@apple.com

Unreviewed. Fixing skip list.

VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

  • platform/mac-leopard/Skipped:
17:48 Changeset [88886] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use new byte array encoding/decoding functions for WTF argument coders
https://bugs.webkit.org/show_bug.cgi?id=62682

  • Platform/CoreIPC/ArgumentCoders.cpp: (CoreIPC::::encode): (CoreIPC::::decode): Use the new functions for the string argument coders.


  • Platform/CoreIPC/ArgumentCoders.h: (CoreIPC::SimpleArgumentCoder::encode): (CoreIPC::SimpleArgumentCoder::decode): Use the new functions to avoid encoding/decoding the size when it's known at decode time.
  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::roundUpToAlignment): Assert that the alignment is a power of 2.

(CoreIPC::decodeFixedLengthData):
Alignment comes before the size.

  • UIProcess/cf/WebBackForwardListCF.cpp: (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Add a FIXME about now using the internal CoreIPC encoding format here.
  • UIProcess/cf/WebPageProxyCF.cpp: Bump the current session state data version number.
17:26 Changeset [88885] by lforschler@apple.com

Merge r88856.

17:24 Changeset [88884] by lforschler@apple.com

Merge r88833.

17:19 Changeset [88883] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Trailing tabs in a textarea become unselectable under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=54598

The bug was caused by WebKit's erroneously collapsing leading whitespace when white-space is
set to pre-wrap. Per CSS 2.1 spec section 16.1.1, leading whitespace should not be removed
in this case.

See also: http://www.w3.org/TR/CSS2/text.html#white-space-model

Fixed the bug by adding an extra argument to shouldCollapseWhiteSpace, indicating whether
whitespace is leading or trailing. It defaults to leading because 16.1.1 does not allow allow
collapsing of whitespace anywhere but at the end of each line.

Test: fast/text/pre-wrap-trailing-tab.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::shouldCollapseWhiteSpace): Added WhitespacePosition as an argument. Returns false when whitespacePosition is not TrailingWhitespace even if white-space is pre-wrap. (WebCore::requiresLineBox): Takes WhitespacePosition as an argument and passes it to shouldCollapseWhiteSpace. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Calls requiresLineBox. (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): Ditto. (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Ditto.

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Trailing tabs in a textarea become unselectable under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=54598

Added a test to ensure Webkit renders leading whitespace when white-space is set to pre-wrap
and word-wrap is set to break-word.

Also rebaselined few tests because WebKit now renders leading whitespace in those tests.

  • fast/text/pre-wrap-trailing-tab-expected.txt: Added.
  • fast/text/pre-wrap-trailing-tab.html: Added.
  • http/tests/misc/acid3-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt
17:15 Changeset [88882] by lforschler@apple.com

Merge r88735.

17:12 Changeset [88881] by lforschler@apple.com

Merge r88607.

17:12 Changeset [88880] by noam.rosenthal@nokia.com

2011-06-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Expose viewportVisibleRect(), so that we can detect which parts of a texture actually
need to be uploaded.

Together with Viatcheslav Ostapenko.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::viewportVisibleRect):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::viewportVisibleRect):
17:12 Changeset [88879] by rniwa@webkit.org

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Qt rebaseline after r88757.

  • platform/qt/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.txt:
17:11 Changeset [88878] by lforschler@apple.com

Merge r88591.

17:09 Changeset [88877] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=62678
When the window is small enough, the scrollbars are misplaced with painting
artifacts, after changing the scrollbar appearance
-and corresponding-
<rdar://problem/9414015>

Reviewed by Dan Bernstein.

Get rid of the FrameView implementation of scrollbarStyleChanged(). Its approach
is just not good.

  • page/FrameView.cpp:
  • page/FrameView.h:

Implement scrollbarStyleChanged() on ScrollView instead. And just call
updatedScrollbars().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):

  • platform/ScrollView.h:

Invalidate the old scrollbar before changing it to the new scrollbar. This way
when the scrollbar gets smaller, the older, larger pieces still repaint properly.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

16:50 Changeset [88876] by lforschler@apple.com

Merge r88685.

16:49 Changeset [88875] by lforschler@apple.com

Merge r88677.

16:46 Changeset [88874] by lforschler@apple.com

Merge r88654.

16:39 Changeset [88873] by oliver@apple.com

2011-06-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658

Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addImmediateBuffer): (JSC::CodeBlock::immediateBuffer):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addImmediateBuffer): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_new_array_buffer):
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
16:35 Changeset [88872] by xan@webkit.org

2011-06-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove G_CONST_RETURN usage
https://bugs.webkit.org/show_bug.cgi?id=62673

Change G_CONST_RETURN for a simple "const" throughout the
codebase, since G_CONST_RETURN is deprecated now. This should be
totally equivalent since for all practical purposes the macro is
always expanded to const.

  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_database_directory_path): use const instead of G_CONST_RETURN.
  • webkit/webkitapplicationcache.h:
  • webkit/webkiticondatabase.cpp: (webkit_icon_database_get_path): ditto.
  • webkit/webkiticondatabase.h:
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_uri): ditto.
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_get_uri): ditto.
  • webkit/webkitnetworkresponse.h:
  • webkit/webkitsecurityorigin.cpp: (webkit_security_origin_get_protocol): ditto. (webkit_security_origin_get_host): ditto.
  • webkit/webkitsecurityorigin.h:
  • webkit/webkitwebdatabase.cpp: (webkit_web_database_get_name): ditto. (webkit_web_database_get_display_name): ditto. (webkit_web_database_get_filename): ditto. (webkit_get_web_database_directory_path): ditto.
  • webkit/webkitwebdatabase.h:
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_get_encoding): ditto. (webkit_web_data_source_get_unreachable_uri): ditto.
  • webkit/webkitwebdatasource.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_title): ditto. (webkit_web_frame_get_uri): ditto. (webkit_web_frame_get_name): ditto.
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_get_title): ditto. (webkit_web_history_item_get_alternate_title): ditto. (webkit_web_history_item_get_uri): ditto. (webkit_web_history_item_get_original_uri): ditto. (webkit_web_history_item_get_target): ditto.
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebhistoryitemprivate.h:
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_target_frame): ditto.
  • webkit/webkitwebnavigationaction.h:
  • webkit/webkitwebresource.cpp: (webkit_web_resource_get_uri): ditto. (webkit_web_resource_get_mime_type): ditto. (webkit_web_resource_get_encoding): ditto. (webkit_web_resource_get_frame_name): ditto.
  • webkit/webkitwebresource.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_get_user_agent): ditto.
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_title): ditto. (webkit_web_view_get_uri): ditto. (webkit_web_view_get_icon_uri): ditto.
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewcommon.h:
16:29 Changeset [88871] by msaboff@apple.com

2011-06-14 Michael Saboff <msaboff@apple.com>

Reviewed by Joseph Pecoraro.

Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
https://bugs.webkit.org/show_bug.cgi?id=62649

Take 2.
The #ifdef DISPATCH_VM_PRESSURE doesn't work. Combined the code
inside this #ifdef with the prior #ifndef DISPATCH_SOURCE_TYPE_VM.

No functional changes, fixing build issue therefore no tests.

  • platform/mac/MemoryPressureHandlerMac.mm:
16:25 Changeset [88870] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Start using the new encode/decode functions
https://bugs.webkit.org/show_bug.cgi?id=62676

  • Platform/CoreIPC/DataReference.cpp: (CoreIPC::DataReference::encode): Use encodeVariableLengthByteArray.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): Use encodeVariableLengthByteArray and the new dataReference accessors.

(WebKit::UserMessageDecoder::baseDecode):
Use decodeVariableLengthByteArray.


  • Shared/WebData.h: (WebKit::WebData::dataReference): Return a reference to the data.
  • Shared/WebSerializedScriptValue.h: (WebKit::WebSerializedScriptValue::dataReference): Ditto.
  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::encode): Use encodeVariableLengthByteArray.
  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::Handle::encode): Use encodeVariableLengthByteArray.
  • WebProcess/WebPage/DecoderAdapter.cpp: (WebKit::DecoderAdapter::decodeBytes): Use decodeVariableLengthByteArray.
  • WebProcess/WebPage/EncoderAdapter.cpp: (WebKit::EncoderAdapter::dataReference): Rename data() to dataReference() to indicate that it returns a reference to the data.

(WebKit::EncoderAdapter::encodeBytes):
Use encodeVariableLengthByteArray.

16:13 Changeset [88869] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add encodeVariableLengthByteArray and decodeVariableLengthByteArray
https://bugs.webkit.org/show_bug.cgi?id=62674

Rename the ArgumentDecoder::decodeBytes overload that takes a DataReference to
decodeVariableLengthByteArray, to match the added encodeVariableLengthByteArray.

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::decodeVariableLengthByteArray):
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp: (CoreIPC::ArgumentEncoder::encodeFixedLengthData): (CoreIPC::ArgumentEncoder::encodeVariableLengthByteArray):
  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/DataReference.cpp: (CoreIPC::DataReference::decode):
  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::Handle::decode):
16:09 Changeset [88868] by lforschler@apple.com

Merge r88653.

16:06 Changeset [88867] by lforschler@apple.com

Merge r88647.

16:05 Changeset [88866] by commit-queue@webkit.org

2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88841.
http://trac.webkit.org/changeset/88841
https://bugs.webkit.org/show_bug.cgi?id=62672

Caused many tests to crash (Requested by rniwa on #webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_array):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
16:05 Changeset [88865] by cevans@google.com

Merge 88601
BUG=85302
Review URL: http://codereview.chromium.org/7169001

16:05 Changeset [88864] by lforschler@apple.com

Merge r88629.

16:03 Changeset [88863] by lforschler@apple.com

Merge r88599.

16:02 Changeset [88862] by lforschler@apple.com

Merge r88588.

16:00 Changeset [88861] by lforschler@apple.com

Merge r88585.

15:57 Changeset [88860] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add functions for converting between DataReferences and vectors
https://bugs.webkit.org/show_bug.cgi?id=62671

  • Platform/CoreIPC/DataReference.h: (CoreIPC::DataReference::DataReference): New implicit constructor that takes a vector.

(CoreIPC::DataReference::vector):
New function that returns a new vector.

  • Shared/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::encode): Use implicit constructor.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScriptInMainFrame): Ditto.
15:57 Changeset [88859] by lforschler@apple.com

Merge r88528.

15:54 Changeset [88858] by lforschler@apple.com

Merge r87834.

15:23 Changeset [88857] by lforschler@apple.com

2011-06-14 Lucas Forschler <lforschler@apple.com>

Reviewed by Stephanie Lewis.

https://bugs.webkit.org/show_bug.cgi?id=62495
Bug 62495 - combine windows and mac kill-old-processes script
Add a platform agnostic script. Remove the recently added mac flavor.
Note: Leaving the windows one alone, since it is currently used by the WebKit bots.

  • BuildSlaveSupport/kill-old-processes: Added.
  • BuildSlaveSupport/mac: Removed.
  • BuildSlaveSupport/mac/kill-old-processes: Removed.
15:18 Changeset [88856] by sullivan@apple.com

<https://bugs.webkit.org/show_bug.cgi?id=62666>
<rdar://problem/9606676>
Callers should be robust against WebImage::create() returning an image with a null snapshot

Reviewed by Dan Bernstein.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateCGImage):
Return 0 if no bitmap was created.
(WKImageCreateFromCGImage):
Ditto.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
Check for null before dereferencing image->bitmap() in two places.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
Return 0 if no bitmap was created.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):
Ditto.
(WebKit::WebPage::createSnapshotOfVisibleContent):
Bail out if no bitmap was created.

15:07 Changeset [88855] by dglazkov@chromium.org

2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Turns out, inspector/cookie-parser.html can timeout out.

  • platform/chromium/test_expectations.txt: Added expectation of TIMEOUT.
14:51 Changeset [88854] by commit-queue@webkit.org

2011-06-14 Jeffrey Pfau <jpfau@apple.com>

Reviewed by David Hyatt.

Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028

Added test for spanning elements within an inline-block child of a multicol element.

  • fast/multicol/span/span-as-nested-inline-block-child.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.

2011-06-14 Jeffrey Pfau <jpfau@apple.com>

Reviewed by David Hyatt.

Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028

Ensure that the parent block of a spanning element, if it is not itself
a multicol element, is not inline.

Test: fast/multicol/span/span-as-nested-inline-block-child.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::columnsBlockForSpanningElement):
14:39 Changeset [88853] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add functions for encoding/decoding data with a known size and alignment
https://bugs.webkit.org/show_bug.cgi?id=62663

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::decodeFixedLengthData):
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp: (CoreIPC::ArgumentEncoder::encodeFixedLengthData): (CoreIPC::ArgumentEncoder::encodeVariableLengthData):
  • Platform/CoreIPC/ArgumentEncoder.h:
14:24 Changeset [88852] by vangelis@chromium.org

Merge 88288 - 2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7163005

13:51 Changeset [88851] by dglazkov@chromium.org

2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Record expectation of crash for inspector/cookie-parser.html.

  • platform/chromium/test_expectations.txt: Recorded.
13:50 Changeset [88850] by cevans@google.com

Merge 87439
BUG=83270
Review URL: http://codereview.chromium.org/7166003

13:41 Changeset [88849] by cevans@google.com

Merge 87171
BUG=83270
Review URL: http://codereview.chromium.org/7111053

13:36 Changeset [88848] by dpranke@chromium.org

2011-06-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: handle worker exceptions cleanly
https://bugs.webkit.org/show_bug.cgi?id=62614

This change modifiers new-run-webkit-tests to handle exceptions
raised by worker threads better, by:

  • capturing the worker's stack and logging it in the manager
  • propagating the worker's exception in the caller correctly
  • attempting to cancel the workers and clean up even when we get an unexpected exception
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
13:35 Changeset [88847] by jer.noble@apple.com

2011-06-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation)
https://bugs.webkit.org/show_bug.cgi?id=62655

No new tests; we don't have any media-engine specific tests.

AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
the image from the current time instead of the nearest keyframe, set the requested time tolerance to
zero (which defaults to infinity).

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
13:20 Changeset [88846] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move string ArgumentCoder template specializations out into a .cpp file
https://bugs.webkit.org/show_bug.cgi?id=62660

  • GNUmakefile.am:
  • Platform/CoreIPC/ArgumentCoders.cpp: Added. (CoreIPC::::encode): (CoreIPC::::decode):
  • Platform/CoreIPC/ArgumentCoders.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
13:09 Changeset [88845] by cevans@google.com

Merge 87103
BUG=83270
Review URL: http://codereview.chromium.org/7155005

13:01 Changeset [88844] by ericu@chromium.org

2011-06-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218

Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs.

No new tests--no change in functionality.

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createWriter): (WebCore::DOMFileSystem::createFile):
  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::getMetadata): (WebCore::DOMFileSystemBase::move): (WebCore::DOMFileSystemBase::copy): (WebCore::DOMFileSystemBase::remove): (WebCore::DOMFileSystemBase::removeRecursively): (WebCore::DOMFileSystemBase::getParent): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory): (WebCore::DOMFileSystemBase::readDirectory):
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): (WebCore::DOMFileSystemSync::createWriter):
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::AsyncFileSystem):

2011-06-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218

Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs. Also add a #define to make it easier to stage this change, as
it involves both Chromium and WebKit changes that would ideally be
simultaneous.

No new tests--no change in functionality.

  • public/WebFileSystem.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFrame.h:
  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileSystemChromium.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WorkerFileWriterCallbacksBridge.h:
12:54 Changeset [88843] by cfleizach@apple.com

Unreviewed.

VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Tables are not supported on Leopard for accessibility.

  • platform/mac-leopard/Skipped:
12:37 Changeset [88842] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove PluginInfoStore::Plugin typedef
https://bugs.webkit.org/show_bug.cgi?id=62657

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
12:10 Changeset [88841] by oliver@apple.com

2011-06-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658

Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addImmediateBuffer): (JSC::CodeBlock::immediateBuffer):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addImmediateBuffer): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_new_array_buffer):
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
11:48 Changeset [88840] by commit-queue@webkit.org

2011-06-14 Wyatt Carss <wcarss@google.com>

Reviewed by Ryosuke Niwa.

dump-as-text conversion: editing/deleting/5300379.html
https://bugs.webkit.org/show_bug.cgi?id=62620

Converted from pixel test to dump-as-text. This tests that delete backward
by word does not hang inside an empty div, and that delete backward by word
deletes exactly one word.

  • editing/deleting/5300379-expected.txt: Added.
  • editing/deleting/5300379.html:
  • platform/chromium-win/editing/deleting/5300379-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/5300379-expected.png: Removed.
  • platform/gtk/editing/deleting/5300379-expected.txt: Removed.
  • platform/gtk/editing/deleting/5300379-expected.png: Removed.
  • platform/mac/editing/deleting/5300379-expected.txt: Removed.
  • platform/mac/editing/deleting/5300379-expected.png: Removed.
  • platform/qt/editing/deleting/5300379-expected.txt: Removed.
  • platform/qt/editing/deleting/5300379-expected.png: Removed.
11:45 Changeset [88839] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Create the PluginModuleInfo class and reverse the typedef so that PluginInfoStore::Plugin is now a typedef
https://bugs.webkit.org/show_bug.cgi?id=62654

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::findPluginForMIMEType): (WebKit::PluginInfoStore::findPluginForExtension): (WebKit::PluginInfoStore::findPlugin): (WebKit::PluginInfoStore::infoForPluginWithPath):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy):
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::isOldWindowsMediaPlayerPlugin): (WebKit::isNewWindowsMediaPlayerPlugin): (WebKit::PluginInfoStore::shouldUsePlugin):
11:44 Changeset [88838] by qi.2.zhang@nokia.com

2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227

  • platform/qt/Skipped:

2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227

QtWebkit does not yet support different CacheModels. This change will
expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:43 Changeset [88837] by cevans@google.com

Merge 88549
BUG=85211
Review URL: http://codereview.chromium.org/7163002

11:42 Changeset [88836] by cevans@google.com

Merge 88549
BUG=85211
Review URL: http://codereview.chromium.org/7149024

11:32 Changeset [88835] by commit-queue@webkit.org

2011-06-14 James Robinson <jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618

This fixes several issues causing slowdowns in compositor shader initialization, mostly due to lack of
parallelism:

  • Avoid initializing all programs eagerly. We only use two programs on every page, the other programs depend on content and are constructed on demand.
  • Defer querying uniform locations until draw time. For the eagerly constructed programs (render surface + tiler) this means that the GPU process has a chance to compile the shader while the renderer is busy painting+uploading instead of blocking on shader compilation in order to get uniform locations.
  • Calls to query COMPILE_STATUS/LINK_STATUS moved behind #ifndef NDEBUG guards since these should never fail in release builds and force synchronous compilation/linking.

This also adds a number of TRACE_EVENT()s to make analysing the performance of this bit of code easier.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::borderProgram): (WebCore::LayerRendererChromium::headsUpDisplayProgram): (WebCore::LayerRendererChromium::renderSurfaceProgram): (WebCore::LayerRendererChromium::renderSurfaceMaskProgram): (WebCore::LayerRendererChromium::tilerProgram): (WebCore::LayerRendererChromium::canvasLayerProgram): (WebCore::LayerRendererChromium::pluginLayerProgram): (WebCore::LayerRendererChromium::videoLayerRGBAProgram): (WebCore::LayerRendererChromium::videoLayerYUVProgram):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/ProgramBinding.cpp: (WebCore::ProgramBindingBase::init): (WebCore::ProgramBindingBase::loadShader): (WebCore::ProgramBindingBase::createShaderProgram):
  • platform/graphics/chromium/ProgramBinding.h: (WebCore::ProgramBinding::ProgramBinding): (WebCore::ProgramBinding::initialize):
  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::VertexShaderPosTex::init): (WebCore::VertexShaderPosTexYUVStretch::init): (WebCore::VertexShaderPos::init): (WebCore::VertexShaderPosTexTransform::init): (WebCore::FragmentTexAlphaBinding::init): (WebCore::FragmentShaderRGBATexAlphaMask::init): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderColor::init):
  • platform/graphics/chromium/ShaderChromium.h:

2011-06-14 James Robinson <jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618

Add a TRACE_EVENT() around initial compositor initialization.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
11:31 Changeset [88834] by commit-queue@webkit.org

2011-06-14 Claudio Saavedra <csaavedra@igalia.com>

Reviewed by Xan Lopez.

Broken reference to webkitsoupauthdialog.c
https://bugs.webkit.org/show_bug.cgi?id=62650

  • POTFILES: Fix reference to webkitsoupauthdialog.cpp
11:30 Changeset [88833] by slewis@apple.com

<rdar://problem/9511169>
Update order files.

Rubber stamped by Oliver Hunt.

Source/JavaScriptCore:

Source/WebCore:

Build system change, no change in functionality so no new tests.

  • WebCore.order:

Source/WebKit/mac:

  • WebKit.order:

Source/WebKit2:

  • mac/WebKit2.order:
11:26 Changeset [88832] by cevans@google.com

Merge 88434
BUG=85102
Review URL: http://codereview.chromium.org/7150019

11:25 Changeset [88831] by cevans@google.com

Merge 88411
BUG=85102
Review URL: http://codereview.chromium.org/7163001

11:20 Changeset [88830] by cfleizach@apple.com

Source/WebCore: VoiceOver cannot navigate the iTunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Reviewed by David Kilzer.

This is a regression from https://bugs.webkit.org/show_bug.cgi?id=57463.
Part of that patch made a change so that an ARIA table will only look at it's children and grandchildren
for possible rows. That however, doesn't allow arbitrary hierarchies to work with ARIA, like in iTunes album view.

Test: platform/mac/accessibility/aria-grid-with-strange-hierarchy.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

LayoutTests: VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Reviewed by David Kilzer.

  • platform/mac/accessibility/aria-grid-with-strange-hierarchy-expected.txt: Added.
  • platform/mac/accessibility/aria-grid-with-strange-hierarchy.html: Added.
11:17 Changeset [88829] by aestes@apple.com

2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88823.
http://trac.webkit.org/changeset/88823
https://bugs.webkit.org/show_bug.cgi?id=62652

Broke the Lion build (Requested by estes on #webkit).

  • platform/mac/MemoryPressureHandlerMac.mm:
11:16 Changeset [88828] by cevans@google.com

Merge 88434
BUG=85102
Review URL: http://codereview.chromium.org/7162001

11:14 Changeset [88827] by cevans@google.com

Merge 88411
BUG=85102
Review URL: http://codereview.chromium.org/7155003

11:05 Changeset [88826] by cevans@google.com

Merge 88277
BUG=85256
Review URL: http://codereview.chromium.org/7104146

11:03 Changeset [88825] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Start replacing PluginInfoStore::Plugin with PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62651

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): (WebKit::PluginInfoStore::findPluginForMIMEType): (WebKit::PluginInfoStore::findPluginForExtension): (WebKit::PluginInfoStore::infoForPluginWithPath):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): (WebKit::PluginProcessManager::getSitesWithData): (WebKit::PluginProcessManager::clearSiteData): (WebKit::PluginProcessManager::getOrCreatePluginProcess):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::create):
  • UIProcess/Plugins/PluginProcessProxy.h: (WebKit::PluginProcessProxy::pluginInfo):
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::pluginNeedsExecutableHeap): (WebKit::PluginProcessProxy::createPropertyListFile):
10:57 Changeset [88824] by lforschler@apple.com

Merge r87831.

10:54 Changeset [88823] by msaboff@apple.com

2011-06-14 Michael Saboff <msaboff@apple.com>

Reviewed by Joseph Pecoraro.

Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
https://bugs.webkit.org/show_bug.cgi?id=62649

The #ifdef DISPATCH_VM_PRESSURE actually needs to be #ifndef
to handle when DISPATCH_VM_PRESSURE is NOT defined in the
system header files.

No functional changes, fixing build issue therefore no tests.

  • platform/mac/MemoryPressureHandlerMac.mm:
10:44 Changeset [88822] by enne@google.com

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607

  • platform/chromium/compositing/huge-mask-layer-expected.txt: Added.
  • platform/chromium/compositing/huge-mask-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607

Because masks have a different layer size than the layer they are
masking, they are untiled. If they are too large to be contained
within a single texture, then they should just be disabled.

Test: platform/chromium/compositing/huge-mask-layer.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::getSingleTexture): (WebCore::LayerTilerChromium::numTiles):
10:41 Changeset [88821] by weinig@apple.com

Fix dumping of constants to have the correct constant number.

Reviewed by Geoffrey Garen.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

10:40 Changeset [88820] by lforschler@apple.com

Merge r87806.

10:37 Changeset [88819] by andersca@apple.com

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add PluginModuleInfo header and prepare for renaming of PluginInfoStore::Plugin to PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62647

Make PluginModuleInfo a typedef of PluginInfoStore::Plugin for now; eventually it should be its own class,
and PluginInfoStore::Plugin should go away.

  • GNUmakefile.am:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginArchitecture): (WebKit::getMIMETypesFromPluginBundle): (WebKit::getPluginInfoFromPropertyLists): (WebKit::getPluginInfoFromCarbonResources): (WebKit::NetscapePluginModule::getPluginInfo): (WebKit::NetscapePluginModule::determineQuirks):
  • Shared/Plugins/PluginModuleInfo.cpp: Added.
  • Shared/Plugins/PluginModuleInfo.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:34 Changeset [88818] by lforschler@apple.com

Merge r87805.

10:20 Changeset [88817] by dglazkov@chromium.org

2011-06-14 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Add expectations for flaky tests.

  • platform/chromium/test_expectations.txt: Recorded flakiness.
10:13 Changeset [88816] by commit-queue@webkit.org

2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] GraphicsLayer: support plugins on symbian
https://bugs.webkit.org/show_bug.cgi?id=57418

Implement graphics layer for plugins on Symbian.

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::shouldUseAcceleratedCompositing): (WebCore::PluginView::platformStart):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt): (WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt): (WebCore::PluginGraphicsLayerQt::paint): (WebCore::PluginView::shouldUseAcceleratedCompositing): (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformLayer):
10:03 Changeset [88815] by commit-queue@webkit.org

2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359

Tests that console messages are preserved upon navigation.

  • inspector/console/console-preserve-log-expected.txt: Added.
  • inspector/console/console-preserve-log.html: Added.

2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359

Adds a context menu checkbox to preserve the console log across
navigations. However, the underlying messages and objects are actually
deleted from the backend, so they are not expandable; their continued
display in the console frontend is merely cosmetic.

Test: inspector/console/console-preserve-log.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.preserveLogItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.reset):
09:59 Changeset [88814] by cevans@google.com

Merge 87959
BUG=84946
Review URL: http://codereview.chromium.org/7158003

09:48 Changeset [88813] by cevans@google.com

Merge 87756
BUG=84946
Review URL: http://codereview.chromium.org/7147018

09:46 Changeset [88812] by abarth@webkit.org

2011-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

WebFrame::url() should use the one true URL
https://bugs.webkit.org/show_bug.cgi?id=62610

The Document's URL is the one true URL. Thou shalt have no URLs before
Document::url().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::url):
09:34 Changeset [88811] by cevans@google.com

Merge 87863
BUG=82653
Review URL: http://codereview.chromium.org/7149022

09:32 Changeset [88810] by cevans@google.com

Merge 87863
BUG=82653
Review URL: http://codereview.chromium.org/7150014

09:29 Changeset [88809] by commit-queue@webkit.org

2011-06-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Add ENABLE_TOUCH_ICON_LOADING feature.
https://bugs.webkit.org/show_bug.cgi?id=62604

Add feature to enable or disable ENABLE_TOUCH_ICON which supports
apple-touch-icon and apple-touch-icon-precomposed in link tag.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:
09:25 Changeset [88808] by podivilov@chromium.org

2011-06-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:

2011-06-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.compare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
09:25 Changeset [88807] by commit-queue@webkit.org

2011-06-14 Benjamin Poulain <benjamin@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator's Trie does not work with Python 3
https://bugs.webkit.org/show_bug.cgi?id=62635

With Python 3, dict.items() return an iterator. Since the iterator
protocol changed between Python 2 and 3, the easiest way to get the
values is to have something that use the iterator implicitely, like a
for() loop.

  • KeywordLookupGenerator.py:
08:56 Changeset [88806] by ademar.reis@openbossa.org

Unreviewed: unskip test rebasedlined by r88772

[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
http://trac.webkit.org/changeset/88772

The test was rebaselined but the committer forgot to remove it from
the Skip list.

  • platform/qt/Skipped: unskip test
08:48 Changeset [88805] by pfeldman@chromium.org

2011-06-14 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp: Implement new class to culculate border radius, initialize for appropriate properties. (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  • css/CSSStyleSelector.cpp: Remove old implementations. (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: Pass LengthSize by value. (WebCore::AnimationBase::ensurePropertyMap):
  • rendering/style/RenderStyle.h: Pass LengthSize by value consistently.
08:46 Changeset [88804] by macpherson@chromium.org

2011-06-14 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp: Implement new class to culculate border radius, initialize for appropriate properties. (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  • css/CSSStyleSelector.cpp: Remove old implementations. (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: Pass LengthSize by value. (WebCore::AnimationBase::ensurePropertyMap):
  • rendering/style/RenderStyle.h: Pass LengthSize by value consistently.
08:03 Changeset [88803] by carlosgc@webkit.org

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=62627

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::menuPositionFunction):
  • UIProcess/gtk/WebContextMenuProxyGtk.h:
07:58 Changeset [88802] by carlosgc@webkit.org

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

The method actually converts coordinates, the rectangle size is
not affected, so it can be modified to return a point
instead. Fix also a bug in the implementation, it was translating
the coordinates twice returning the wrong position when the given
rectangle was not at 0,0.

  • platform/gtk/GtkUtilities.cpp: (WebCore::convertWidgetPointToScreenPoint):
  • platform/gtk/GtkUtilities.h:
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Use convertWidgetPointToScreenPoint().

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowToScreen): Update to use convertWidgetPointToScreenPoint() (WebKit::ChromeClient::screenToWindow): Ditto.
  • webkit/webkitwebview.cpp: Remove globalPointForClientPoint() since it does the same than convertWidgetPointToScreenPoint(). (webkit_web_view_popup_menu_handler): Use convertWidgetPointToScreenPoint() instead of globalPointForClientPoint(). (doDragLeaveLater): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto.

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::screenToWindow): Implement this method using convertWidgetPointToScreenPoint(). (WebKit::PageClientImpl::windowToScreen): Update to use convertWidgetPointToScreenPoint().
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp: (WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use convertWidgetPointToScreenPoint().
07:38 Changeset [88801] by yael.aharon@nokia.com

Unreviewed.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

Skip new tests since Windows port does not support the progress element.

  • platform/win/Skipped:
07:36 Changeset [88800] by carlosgc@webkit.org

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new class to show an authentication dialog that is used by
both WebKit1 and WebKit2.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/GtkAuthenticationDialog.cpp: Added. (WebCore::addEntryToTable): (WebCore::sessionCanSavePasswords): (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog): (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): (WebCore::getSavedLogin): (WebCore::GtkAuthenticationDialog::show): (WebCore::GtkAuthenticationDialog::destroy): (WebCore::GtkAuthenticationDialog::savePasswordCallback): (WebCore::GtkAuthenticationDialog::savePassword): (WebCore::GtkAuthenticationDialog::authenticate): (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
  • platform/gtk/GtkAuthenticationDialog.h: Added.

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Move the common code of webkitsoupauthdialog to a common C++ class
in WebCore so that it can be used by WebKit2 too. The file has
been converted into a C++ file.

  • GNUmakefile.am: Rename webkitsoupauthdialog.c to webkitsoupauthdialog.cpp.
  • webkit/webkitsoupauthdialog.c: Removed.
  • webkit/webkitsoupauthdialog.cpp: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (sessionAuthenticate): Use GtkAuthenticationDialog object from WebCore. (attach): (detach):
  • webkit/webkitsoupauthdialog.h:

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new soup feature to show an authentication dialog when it
gets a 401 HTTP response.

  • GNUmakefile.am: Add new files to compilation.
  • WebProcess/gtk/WebAuthDialog.cpp: Added. (web_auth_dialog_class_init): (web_auth_dialog_init): (sessionAuthenticate): (attach): (detach): (webAuthDialogSessionFeatureInit):
  • WebProcess/gtk/WebAuthDialog.h: Added.
  • WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):
07:07 Changeset [88799] by commit-queue@webkit.org

2011-06-14 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Implementing LayerTreeHost and LayerTreeContext and LayerTreeHost for Qt.
Add the necessary plumbing to make the LayerTreeHost work with Qt, based on the original Mac
implementation (the code is nearly identical). This includes creating the right layers for the
overlay and for the non-composited content, and passing the root layer to the UI process.

Also, since LayerTreeHostQt is compiled, we have to add some of the rest of the existing patches,
namely the new messages: syncCompositingLayers and updateCompositingLayerContent, and create a
stub implementation for them in DrawingAreaProxy.

Note that this is not activated yet, until we enable accelerated compositing in the settings and
create the right GraphicsLayer.

  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/qt/LayerTreeContextQt.cpp: (WebKit::LayerTreeContext::LayerTreeContext): (WebKit::LayerTreeContext::~LayerTreeContext): (WebKit::LayerTreeContext::encode): (WebKit::LayerTreeContext::decode): (WebKit::LayerTreeContext::isEmpty): (WebKit::operator==):
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::syncCompositingLayers): (WebKit::DrawingAreaProxy::updateCompositingLayerContent):
  • UIProcess/DrawingAreaProxy.messages.in:
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: (WebCore::collectCompositingInfoForThisLayer):
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp: (WebKit::LayerTreeHostQt::create): (WebKit::LayerTreeHostQt::~LayerTreeHostQt): (WebKit::LayerTreeHostQt::LayerTreeHostQt): (WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled): (WebKit::LayerTreeHostQt::scheduleLayerFlush): (WebKit::LayerTreeHostQt::cancelPendingLayerFlush): (WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush): (WebKit::LayerTreeHostQt::setRootCompositingLayer): (WebKit::LayerTreeHostQt::invalidate): (WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostQt::scrollNonCompositedContents): (WebKit::LayerTreeHostQt::forceRepaint): (WebKit::LayerTreeHostQt::sizeDidChange): (WebKit::LayerTreeHostQt::didInstallPageOverlay): (WebKit::LayerTreeHostQt::didUninstallPageOverlay): (WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay): (WebKit::LayerTreeHostQt::flushPendingLayerChanges): (WebKit::LayerTreeHostQt::performScheduledLayerFlush): (WebKit::LayerTreeHostQt::layerFlushTimerFired): (WebKit::LayerTreeHostQt::createPageOverlayLayer): (WebKit::LayerTreeHostQt::destroyPageOverlayLayer): (WebKit::LayerTreeHostQt::notifyAnimationStarted): (WebKit::LayerTreeHostQt::notifySyncRequired): (WebKit::LayerTreeHostQt::paintContents): (WebKit::LayerTreeHostQt::showDebugBorders): (WebKit::LayerTreeHostQt::showRepaintCounter): (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
  • WebProcess/WebPage/qt/LayerTreeHostQt.h: Added. (WebKit::LayerTreeHostQt::layerTreeContext): (WebKit::LayerTreeHostQt::pauseRendering): (WebKit::LayerTreeHostQt::resumeRendering):
06:58 Changeset [88798] by commit-queue@webkit.org

2011-06-14 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Media Stream PeerConnection API: adding the StreamList and supporting classes.
https://bugs.webkit.org/show_bug.cgi?id=61539

  • dom/StreamContainer.h: Added. (WebCore::StreamContainer::create): (WebCore::StreamContainer::~StreamContainer): (WebCore::StreamContainer::length): (WebCore::StreamContainer::item): (WebCore::StreamContainer::add): (WebCore::StreamContainer::remove): (WebCore::StreamContainer::contains): (WebCore::StreamContainer::get): (WebCore::StreamContainer::StreamContainer):
  • dom/StreamList.cpp: Added. (WebCore::StreamList::create): (WebCore::StreamList::StreamList): (WebCore::StreamList::~StreamList): (WebCore::StreamList::length): (WebCore::StreamList::item):
  • dom/StreamList.h: Added.
  • dom/StreamList.idl: Added.
06:54 Changeset [88797] by noam.rosenthal@nokia.com

2011-06-14 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Add a createImage() function to ShareableBitmap, for now ifdef'ed to Qt only.
This allows us to support directly composited images across the WebKit2 processes.

Together with Viatcheslav Ostapenko.

  • Shared/ShareableBitmap.h:
  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createQImage): (WebKit::ShareableBitmap::createImage):
06:53 Changeset [88796] by caio.oliveira@openbossa.org

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Increase the likeness that JSElements are converted to QWebElements. When hinted
with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

We also remove the implicit conversion between JSDocument (which is not an
element) to QWebElement. The conversion only worked for calling slots, while
without hint it returned a QVariantMap (as can be seen in domCycles test). It was
added for supporting DRT, but since this change we can use it as QVariantMap and
get the value for "documentElement".

This patch is based on Noam Rosenthal original patch in the same bug.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::hintForRealType): Extracted function to choose the metatype hint based on the JSValue type. Add QWebElement metatype as a hint for JSElement objects, this way if no hint is provided, JSElement objects will always be converted to QWebElements.

(JSC::Bindings::convertValueToQVariant):
Use previous function. Identify the conversion between JSElement to QWebElement
as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
is QWebElement metatype and we have a JSDocument. Changed from JSHTMLElement to
JSElement to cover the 'documentElement'.

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Since the implicit conversion was removed, change support functions of DRT to
expect a QVariantMap instead of a QWebElement. This matches the exposed function
in the controller, which takes 'document' and not 'document.documentElement'.

And now that Element -> QWebElement is a perfect match, we must use QWebElement
instead of QVariantMap, like in plainText().

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of QVariantMap when getting the startContainer. Also use QVariantMap directly, bridge will do conversion for us now.

(getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
QVariantMap that Qt bridge gives us when 'document' is passed from JS.

(DumpRenderTreeSupportQt::nodesFromRect): Use helper function.

  • tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two different tests. In practice, the original test just checked whether we could create a QVariantMap representing 'document' without infinite looping due to cycles in the DOM. This was more evident before since we haven't a conversion from JSElement to QWebElement, but from JSElement to QVariantMap.

(tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
'documentElement' from it. Compares to QWebFrame::documentElement().

(tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
the documentElement.

(tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Since we don't implictly convert 'document' object to QWebElement
in metacalls anymore, change the controller to expect QVariantMap instead.

The method plainText() was updated to use QVariantMap as well to let the bridge
do the conversion directly for us.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp: (PlainTextController::plainText):
  • DumpRenderTree/qt/PlainTextControllerQt.h:
06:42 Changeset [88795] by andreas.kling@nokia.com

2011-06-14 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Don't include convenience "QWebFoo" headers in WebKit code.
https://bugs.webkit.org/show_bug.cgi?id=62632

  • WebCoreSupport/FrameNetworkingContextQt.cpp:
06:27 Changeset [88794] by andreas.kling@nokia.com

2011-06-14 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Remove some unnecessary includes.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
06:22 Changeset [88793] by yael.aharon@nokia.com

2011-06-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kent Tamura.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

  • fast/dom/HTMLProgressElement/indeterminate-progress-001.html: Added.
  • fast/dom/HTMLProgressElement/indeterminate-progress-002-expected.txt: Added.
  • fast/dom/HTMLProgressElement/indeterminate-progress-002.html: Added.
  • platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

2011-06-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kent Tamura.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

Add support for :indeterminate pseudo class for progress element.

Tests: fast/dom/HTMLProgressElement/indeterminate-progress-001.html

fast/dom/HTMLProgressElement/indeterminate-progress-002.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithControl): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::isDeterminate): (WebCore::HTMLProgressElement::didElementStateChange):
  • html/HTMLProgressElement.h:
05:53 Changeset [88792] by pfeldman@chromium.org

2011-06-14 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631

  • inspector/debugger/debugger-reload-on-pause-expected.txt: Added.
  • inspector/debugger/debugger-reload-on-pause.html: Added.

2011-06-14 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631

Test: inspector/debugger/debugger-reload-on-pause.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
05:32 Changeset [88791] by abecsi@webkit.org

2011-06-14 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
https://bugs.webkit.org/show_bug.cgi?id=62630

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): remove dead variable 'forceCarbon'
03:47 Changeset [88790] by apavlov@chromium.org

Merge 84485 - 2011-04-21 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: toolbar background is blank on Mac Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59089

  • inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7024044

03:15 Changeset [88789] by tkent@chromium.org

2011-06-14 Kent Tamura <tkent@chromium.org>

[Chromium] Test expectation update for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-linux/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png:
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/chromium/test_expectations.txt:
02:49 Changeset [88788] by gyuyoung.kim@samsung.com

2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174

Replace RenderObject parameter with RenderStyle's in adjustSliderThumbSize.
Because, parameter of the function was changed. And, add constant variable to
paintMediaSliderThumb().

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderThumb):
  • platform/efl/RenderThemeEfl.h:
02:22 Changeset [88787] by tkent@chromium.org

2011-06-14 Kent Tamura <tkent@chromium.org>

[Qt] Attempt to fix a build break by r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack):
01:36 Changeset [88786] by mario@webkit.org

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test failing in the GTK bots.

  • platform/gtk/Skipped: Skipped test
01:13 Changeset [88785] by mario@webkit.org

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baselines for GTK needed after r88266.

  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/gtk/svg/custom/invalid-dasharray-expected.txt: Added.
01:03 Changeset [88784] by mario@webkit.org

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping tests crashing in the GTK bots.

  • platform/gtk/Skipped: Skipped tests.
00:53 Changeset [88783] by tkent@chromium.org

2011-06-14 Kent Tamura <tkent@chromium.org>

[Mac-WK2] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/mac-wk2/media/controls-without-preload-expected.txt:
00:28 Changeset [88782] by loislo@chromium.org

Merge 88331 - 2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js: (Element.prototype.query):

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.findNode.documentRequested): (initialize_ElementTest.InspectorTest.findNode):
  • inspector/console/console-shadow-dom-access.html: Removed.
  • inspector/elements/shadow-dom-expected.txt: Removed.
  • inspector/elements/shadow-dom.html: Removed.
  • platform/win/Skipped:

TBR=caseq@chromium.org
Review URL: http://codereview.chromium.org/7147011

06/13/11:

23:44 Changeset [88781] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/win/media/audio-repaint-expected.txt:
23:31 Changeset [88780] by hayato@chromium.org

2011-06-13 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188

A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.

No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
23:11 Changeset [88779] by cevans@google.com

Merge 88139
BUG=84002
Review URL: http://codereview.chromium.org/7145023

22:55 Changeset [88778] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

More Leopard and GTK rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/gtk/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/mac-leopard/media/audio-repaint-expected.txt: Added.
  • platform/mac-leopard/media/media-document-audio-repaint-expected.txt: Added.
22:42 Changeset [88777] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/win/media/audio-controls-rendering-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/controls-without-preload-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
22:34 Changeset [88776] by cevans@google.com

Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145022

22:25 Changeset [88775] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[Chromium-win] Fix two wrong assertions exposed by r88757.

  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar):
22:19 Changeset [88774] by cevans@google.com

Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145021

22:15 Changeset [88773] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[GTK] Rebaseline for r88757.

  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
22:07 Changeset [88772] by commit-queue@webkit.org

2011-06-13 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125

Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871

  • platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
22:02 Changeset [88771] by laszlo.1.gombos@nokia.com

2011-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224

Fix the expected result and remove the test from the Skipped list.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
22:00 Changeset [88770] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[Mac] Leopard expectation files for r88757.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/controls-without-preload-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
21:53 Changeset [88769] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[Mac] Rebaseline for r88757.

  • media/audio-repaint-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
21:45 Changeset [88768] by ap@apple.com

Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.

  • Scripts/webkitpy/common/config/committers.py:
21:34 Changeset [88767] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Fix a typo in Mac WebKit2's skipped list.

svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.

  • platform/mac-wk2/Skipped:
21:29 Changeset [88766] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Skip editing/pasteboard/smart-paste-004.html per bug 61633.

  • platform/win/Skipped:
21:23 Changeset [88765] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.

  • platform/chromium/test_expectations.txt:
21:15 Changeset [88764] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] The second try to fix a build break.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
21:08 Changeset [88763] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] Fix a typo.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
21:07 Changeset [88762] by tkent@chromium.org

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] Try to fix a build break by r88757.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
21:05 Changeset [88761] by cevans@google.com

Merge 88444
BUG=85559
Review URL: http://codereview.chromium.org/7145019

21:02 Changeset [88760] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.

  • platform/chromium/test_expectations.txt:
20:49 Changeset [88759] by cevans@google.com

Merge 87827
BUG=84335
Review URL: http://codereview.chromium.org/7155001

20:48 Changeset [88758] by cevans@google.com

Merge 87827
BUG=84355
Review URL: http://codereview.chromium.org/7111044

20:46 Changeset [88757] by tkent@chromium.org

2011-06-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920

Add two new tests, and update tests with sliders.

  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
  • fast/forms/input-appearance-range.html: Added.
  • fast/forms/slider-thumb-stylability.html: Remove text.
  • fast/forms/validation-message-on-range-expected.txt: Added.
  • fast/forms/validation-message-on-range.html: Added.
  • fast/multicol/client-rects-expected.txt:
  • fast/repaint/slider-thumb-float-expected.txt:
  • media/audio-repaint-expected.txt:
  • media/controls-without-preload-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped: Skip validaiton-message-on-range.html because this platform doesn't support the interactive validation.
  • platform/mac-wk2/Skipped: Skip validaiton-message-on-range.html.
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-range-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/mac/fast/forms/slider-padding-expected.png:
  • platform/mac/fast/forms/slider-padding-expected.txt:
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/mac/fast/forms/slider-thumb-stylability-expected.png:
  • platform/mac/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.png:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/qt/Skipped: Skip validaiton-message-on-range.html.
  • platform/win/Skipped: Skip validaiton-message-on-range.html.

2011-06-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920

Remove RenderSlider::layout().
In order to remove it, we introduce new three shadow nodes:

  • A flex box container occupying the whole box
  • A flex box item representing a movable area of the thumb
  • A flex box item limiting the movable area of the thumb

The thumb position is specified by percentage position in the second element.

This change also fixes Bug 60353.

Tests: fast/forms/input-appearance-range.html

fast/forms/validation-message-on-range.html

  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect): Use Node::getRect() for the thumb element.
  • css/html.css: Add new style definitions for the new node layout. (input[type="range"]::-webkit-slider-container): (input[type="range"]::-webkit-slider-runnable-track): (input[type="range"]::-webkit-slider-thumb):
  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Accepts events on shadow nodes, use sliderThumbElementOf(). (WebCore::RangeInputType::createShadowSubtree): Creates new nodes layout. (WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
  • html/RangeInputType.h: Remove shadowSliderThumb().
  • html/shadow/SliderThumbElement.cpp: (WebCore::sliderPosition): Moved from RenderSlider.cpp. (WebCore::hasVerticalAppearance): New utility function. (WebCore::sliderThumbElementOf): New utility function. (WebCore::RenderSliderThumb::layout): Sets CSS top/left values. (WebCore::RenderSliderContainer::RenderSliderContainer): (WebCore::RenderSliderContainer::layout): Add some adjustment code.
    • Setting box-orient
    • Adjust heights of some nodes. It is required to pass existing tests.

(WebCore::SliderThumbElement::setPositionFromValue):

Update comments.

(WebCore::SliderThumbElement::setPositionFromPoint):

Calculate the current position from absolute positions.

(WebCore::SliderThumbElement::hostInput):

Removed unnecessary variable.

(WebCore::TrackLimiterElement::TrackLimiterElement):
(WebCore::TrackLimiterElement::create): Adjust style.
(WebCore::TrackLimiterElement::createRenderer):

This node uses RenderSliderThumb.

(WebCore::TrackLimiterElement::shadowPseudoId):

This node also uses -webkit-slider-thumb.

(WebCore::SliderContainerElement::SliderContainerElement):
(WebCore::SliderContainerElement::create):
(WebCore::SliderContainerElement::createRenderer):

Uses RenderSliderContainer.

(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/SliderThumbElement.h: Make hostInput() public, add declarations of TrackLimiterElement and SliderContainerElement.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): Added an assertion. (WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
  • rendering/RenderSlider.h: Remove declarations of removed functions.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Calls adjustSliderThumbSize().
20:30 Changeset [88756] by cevans@google.com

Merge 87911
BUG=84597
Review URL: http://codereview.chromium.org/7154001

19:55 Changeset [88755] by simonjam@chromium.org

2011-06-13 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rolled DEPS.

  • DEPS:
19:27 Changeset [88754] by joone.hur@collabora.co.uk

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.

  • configure.ac: Add configure option to enable/disable register protocol handler.

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

  • GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::registerProtocolHandler): Added.
  • WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
19:19 Changeset [88753] by gyuyoung.kim@samsung.com

2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174

Implement paintMediaSliderThumb() function to show thumb of media slider.
adjustSliderThumbSize() should be implemented in order to call paintMediaSliderThumb().

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  • platform/efl/RenderThemeEfl.h:
19:15 Changeset [88752] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.

  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
19:09 Changeset [88751] by keishi@webkit.org

2011-06-13 Keishi Hattori <keishi@webkit.org>

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
19:08 Changeset [88750] by cevans@google.com

Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149011

19:07 Changeset [88749] by cevans@google.com

Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149010

18:59 Changeset [88748] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaselines after r88617. The test is now passing on all platforms.

  • platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/chromium/test_expectations.txt:
18:46 Changeset [88747] by jberlin@webkit.org

REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566

Add/update the (failing?) expected results for Windows in order to get the bots green.

  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/tiling: Added.
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
18:15 Changeset [88746] by levin@chromium.org

2011-06-13 David Levin <levin@chromium.org>

Reviewed by Dmitry Titov.

fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609

  • fast/workers/worker-close.html: Move a setTimeout to start after the response message is received to make the ordering of messages deterministic.
18:13 Changeset [88745] by simonjam@chromium.org

2011-06-13 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.

2011-06-13 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

  • public/WebKitClient.h: (WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
18:10 Changeset [88744] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.

  • platform/chromium/test_expectations.txt:
18:00 Changeset [88743] by jianli@chromium.org

Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

  • public/WebNotification.h:
  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

TBR=jianli@chromium.org
BUG=84660
Review URL: http://codereview.chromium.org/7148005

17:58 Changeset [88742] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Skip test added by r88578 on GTK per bug 62585.

  • platform/gtk/Skipped:
17:53 Changeset [88741] by steveblock@google.com

2011-06-13 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602

No new tests, build cleanup only.

  • config.h:
17:42 Changeset [88740] by abarth@webkit.org

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612

This parameter defaults to true anyway.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
17:39 Changeset [88739] by jberlin@webkit.org

Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).

  • platform/win/svg/hixie/intrinsic: Added.
  • platform/win/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
17:38 Changeset [88738] by jianli@chromium.org

[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

  • public/WebNotification.h:
  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

17:22 Changeset [88737] by dominicc@chromium.org

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256

Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.

  • printing/page-count-with-one-word-expected.txt: Added.
  • printing/page-count-with-one-word.html: Added.

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebCore.exp.in:
  • page/Frame.cpp: (WebCore::Frame::resizePageRectsKeepingRatio):
  • page/Frame.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::begin):

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]): (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): (-[WebHTMLView _endPrintMode]): (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): (-[WebHTMLView _endScreenPaginationMode]): (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]): (-[WebHTMLView layout]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView setPageWidthForPrinting:]):

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebFrame.cpp: (WebFrame::setPrinting): (WebFrame::setInPrintingMode):
  • WebFrame.h:
17:11 Changeset [88736] by mrobinson@webkit.org

Merging r88734

17:10 Changeset [88735] by andersca@apple.com

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611
<rdar://problem/9058370>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::getPluginInfo): Get the plug-in version string instead of the version number.

(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.

(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.

  • Shared/Plugins/PluginQuirks.h: Add the ReturnsNonRetainedScriptableNPObject quirk.
  • UIProcess/Plugins/PluginInfoStore.h: Use a version string. Eventually this should hold the PluginVersion class we added.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginScriptableNPObject): If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
17:09 Changeset [88734] by mrobinson@webkit.org

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.

  • docs/webkitgtk-sections.txt: Add missing sections to the list and remove unneeded sections.
  • docs/webkitgtk.types: Update the types list.
  • webkit/webkithittestresult.cpp: Fix inline documentation errors. (webkit_hit_test_result_class_init): Ditto.
  • webkit/webkiticondatabase.cpp: Ditto.
  • webkit/webkitwebsettings.cpp: Ditto. (webkit_web_settings_class_init): Ditto.
  • webkit/webkitwebview.cpp: Ditto. (webkit_web_view_class_init): Ditto.
16:51 Changeset [88733] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Mac, GTK, and Qt rebaselines after r88717.

  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
16:49 Changeset [88732] by crogers@google.com

2011-06-13 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
16:28 Changeset [88731] by abarth@webkit.org

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601

Previously, our user-gesture state was per-frame. Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture. Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.

This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code. Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
  • bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp):
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setProcessingTimerCallback):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitFromJavaScript): (WebCore::HTMLFormElement::submit):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::createWindow): (WebCore::DOMWindow::open):
16:20 Changeset [88730] by commit-queue@webkit.org

2011-06-13 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Added a test that tries to remove the children of munder, mover and munderover elements.

  • mathml/munderover-remove-children-expected.txt: Added.
  • mathml/munderover-remove-children.html: Added.

2011-06-13 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.

Test: mathml/munderover-remove-children.html

  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
  • rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
16:06 Changeset [88729] by commit-queue@webkit.org

2011-06-13 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
  • bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::create): (WebCore::V8BindingPerIsolateData::ensureInitialized): (WebCore::V8BindingPerIsolateData::dispose): (WebCore::getToStringName): (WebCore::getToStringTemplate):
  • bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::get): (WebCore::V8BindingPerIsolateData::current): (WebCore::V8BindingPerIsolateData::rawTemplateMap): (WebCore::V8BindingPerIsolateData::templateMap): (WebCore::V8BindingPerIsolateData::toStringName): (WebCore::V8BindingPerIsolateData::toStringTemplate):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):

2011-06-13 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

  • tests/IDBBindingUtilitiesTest.cpp: (WebCore::TEST):
15:56 Changeset [88728] by commit-queue@webkit.org

2011-06-13 Lei Zhang <thestig@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
  • src/WebSettingsImpl.h:
15:53 Changeset [88727] by caio.oliveira@openbossa.org

2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Barth.

Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598

Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressCompleted):
15:50 Changeset [88726] by crogers@google.com

2011-06-13 Chris Rogers <crogers@google.com>

Reviewed by Dirk Pranke.

Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::setEncodedAudioData):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::encodedAudioData): (LayoutTestController::shouldDumpAsAudio): (LayoutTestController::setShouldDumpAsAudio):
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleAudioHeader): (TestShellPrinter::handleAudioHeader):
  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::dump):
15:47 Changeset [88725] by commit-queue@webkit.org

2011-06-13 Michal Pakula vel Rutka <m.pakula@samsung.com>

Reviewed by Eric Seidel.

[EFL] Input method hints not updated while clicking non-input field editable area
https://bugs.webkit.org/show_bug.cgi?id=62539

This fixes a minor bug when input method hints are not updated while focus is
changed from editable area with input tags to other which are does not have input
tag i.e. textarea.

  • ewk/ewk_view.cpp: (ewk_view_input_method_state_set):
15:46 Changeset [88724] by oliver@apple.com

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605

A simple rename

  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):
15:45 Changeset [88723] by commit-queue@webkit.org

2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Implements basic functions for "redo" command.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
  • WebCoreSupport/EditorClientEfl.h:
15:44 Changeset [88722] by commit-queue@webkit.org

2011-06-13 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445

Add Efl related directory and files in WebKit2/WebProcess/.

  • WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
  • WebProcess/WebPage/efl/WebPageEfl.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL):
  • WebProcess/efl/WebProcessEfl.cpp: Added. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformTerminate):
  • WebProcess/efl/WebProcessMainEfl.cpp: Added. (WebKit::WebProcessMainEfl):
  • WebProcess/efl/WebProcessMainEfl.h: Added.
  • efl/MainEfl.cpp: Added. (main):
15:39 Changeset [88721] by dglazkov@chromium.org

2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88704.
http://trac.webkit.org/changeset/88704
https://bugs.webkit.org/show_bug.cgi?id=62466

Caused layout test failures on Chromium Mac.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
15:39 Changeset [88720] by joone.hur@collabora.co.uk

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Need to report whether touch icon loading is enabled
https://bugs.webkit.org/show_bug.cgi?id=62532

It needs to report whether touch icon loading is enabled.

  • configure.ac: Updated option parsing code for loading touch icons.
15:38 Changeset [88719] by oliver@apple.com

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600

Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases. This comes out as a reasonable parsing speed
boost.

  • parser/JSParser.cpp: (JSC::JSParser::nextExpectIdentifier): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
  • parser/Lexer.cpp:
  • parser/Lexer.h: (JSC::Lexer::makeIdentifier): (JSC::Lexer::lexExpectIdentifier):
15:38 Changeset [88718] by enrica@apple.com

Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562
<rdar://problem/9313885>

Patch by Morgan Winer <mwiner@apple.com> on 2011-06-13
Reviewed by Enrica Casucci.

The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.

There are no layout tests for this, since it can be tested only at API level.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().

15:37 Changeset [88717] by commit-queue@webkit.org

2011-06-13 Wyatt Carss <wcarss@google.com>

Reviewed by Ryosuke Niwa.

dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159

Converted to dump the key part of page as text. The platform-dependent files are
copied from the previous setup of this test, as mac appears to do something different
in its delegate info -- 'insertText' instead of 'insertNode', and some differences
in how it counts indices. Note that chromium-mac works the same as chromium-win, but
would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
a bit accordingly.

  • editing/pasteboard/paste-xml.xhtml:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
15:36 Changeset [88716] by commit-queue@webkit.org

2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

  • Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE

2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

No change in functionality so no new tests.

  • CMakeLists.txt: move .idl files to be conditionally generated.
15:32 Changeset [88715] by commit-queue@webkit.org

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: Infinity as key
https://bugs.webkit.org/show_bug.cgi?id=62285

  • storage/indexeddb/key-type-infinity-expected.txt: Added.
  • storage/indexeddb/key-type-infinity.html: Added.
15:30 Changeset [88714] by commit-queue@webkit.org

2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add load error handler to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62347

Add a handler function of "load,error" to EWebLauncher.
EWebLauncher now displays a simple error page on load errors.

  • EWebLauncher/main.c: (on_load_error): (browserCreate):
15:29 Changeset [88713] by commit-queue@webkit.org

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: odd database names
https://bugs.webkit.org/show_bug.cgi?id=62322

  • storage/indexeddb/database-odd-names-expected.txt: Added.
  • storage/indexeddb/database-odd-names.html: Added.
15:25 Changeset [88712] by commit-queue@webkit.org

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
since the TestPlugin no longer prints this event.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Do not set the plugin as windowless always. Doing this breaks some results on Qt and this seems to be unnecessary for the moment. (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the XP_UNIX block is first by guarding against using a null instance.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add the XP_UNIX define for Linux.
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  • GNUmakefile.am: Update source list.
15:23 Changeset [88711] by commit-queue@webkit.org

2011-06-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
without plugin support
https://bugs.webkit.org/show_bug.cgi?id=62394

No behaviour changes, so no new tests.

  • CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and Plugin{Package,View}None.cpp and move them to CMakeListWinCE and CMakeListsEfl, respectively.
  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
15:22 Changeset [88710] by commit-queue@webkit.org

2011-06-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Eric Seidel.

[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
https://bugs.webkit.org/show_bug.cgi?id=62365

These functions do not exist in any public headers and
they are not used internally.
Moreover ewk_view has the same functionality added
https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_frame.cpp:
15:22 Changeset [88709] by japhet@chromium.org

2011-06-13 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Rewrite a bunch of XHR-based tests to use waitUntilDone()/notifyDone().
https://bugs.webkit.org/show_bug.cgi?id=62066

  • fast/xmlhttprequest/xmlhttprequest-gc.html:
  • fast/xmlhttprequest/xmlhttprequest-get.xhtml:
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
  • html5lib/runner.html:
  • html5lib/webkit-resumer.html:
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html:
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:
  • http/tests/xmlhttprequest/cross-origin-preflight-get.html:
  • http/tests/xmlhttprequest/event-listener-gc.html:
  • http/tests/xmlhttprequest/interactive-state.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html:
  • http/tests/xmlhttprequest/response-encoding.html:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-004.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-005.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-006.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-007.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-008.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-009.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-010.html:
  • http/tests/xmlhttprequest/web-apps/001.html:
  • http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html:
  • http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html:
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
  • http/tests/xmlhttprequest/zero-length-response.html:
15:17 Changeset [88708] by commit-queue@webkit.org

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: readonly properties
https://bugs.webkit.org/show_bug.cgi?id=62392

  • storage/indexeddb/readonly-expected.txt: Added.
  • storage/indexeddb/readonly.html: Added.
15:16 Changeset [88707] by commit-queue@webkit.org

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62524

  • UIProcess/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformDidClose): (WebKit::WebInspectorProxy::platformBringToFront): (WebKit::WebInspectorProxy::platformInspectedURLChanged): (WebKit::WebInspectorProxy::inspectorPageURL): (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
15:14 Changeset [88706] by commit-queue@webkit.org

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62438

  • UIProcess/efl/TextCheckerEfl.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkSpellingOfString): (WebKit::TextChecker::checkGrammarOfString): (WebKit::TextChecker::spellingUIIsShowing): (WebKit::TextChecker::toggleSpellingUIIsShowing): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::updateSpellingUIWithGrammarString): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
15:09 Changeset [88705] by caseq@chromium.org

2011-06-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: [refactoring] remove dead code from NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=62481

  • inspector/front-end/NetworkPanel.js:
15:06 Changeset [88704] by dcheng@chromium.org

2011-06-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Eric Seidel.

[chromium] Dragging images to Mail.app results in broken attachments
https://bugs.webkit.org/show_bug.cgi?id=62466

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
15:00 Changeset [88703] by commit-queue@webkit.org

2011-06-13 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add accessors for selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=62596

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::selectionEnd): (WebKit::WebAccessibilityObject::selectionStart):
14:58 Changeset [88702] by commit-queue@webkit.org

2011-06-13 Sangyong Park <sy302.park@gmail.com>

Reviewed by Eric Seidel.

implement to handle wheel event of plugin on x11
https://bugs.webkit.org/show_bug.cgi?id=62522

Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
for to handle wheel event on plugins

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent (WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent (WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin
14:51 Changeset [88701] by commit-queue@webkit.org

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62523

  • UIProcess/efl/WebContextEfl.cpp: Added. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformInvalidateContext): (WebKit::WebContext::platformDefaultDatabaseDirectory): (WebKit::WebContext::platformDefaultIconDatabasePath): (WebKit::WebContext::platformDefaultLocalStorageDirectory):
14:44 Changeset [88700] by commit-queue@webkit.org

2011-06-13 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[efl] Disable tiled backing store debug messages by default.
https://bugs.webkit.org/show_bug.cgi?id=61745

These messages pollute the output and are only useful to people
working on TBS itself. It makes more sense to have them disabled by
default.

  • ewk/ewk_tiled_backing_store.h:
14:36 Changeset [88699] by commit-queue@webkit.org

2011-06-13 Annie Sullivan <sullivan@chromium.org>

Reviewed by Dimitri Glazkov.

Convert editing/execCommand/outdent-selection.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=62582

Convert the test to dump as markup and clean up the HTML.

  • editing/execCommand/outdent-selection-expected.txt: Added.
  • editing/execCommand/outdent-selection.html:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/gtk/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/qt/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/qt/editing/execCommand/outdent-selection-expected.txt: Removed.
14:33 Changeset [88698] by enne@google.com

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

  • compositing/layer-creation/overlap-child-layer-expected.png: Added.
  • compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-child-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.

Test: compositing/layer-creation/overlap-animated-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
14:29 Changeset [88697] by dglazkov@chromium.org

2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Correctly classify the test as failing.

  • platform/chromium/test_expectations.txt: It's failing.
14:23 Changeset [88696] by xan@webkit.org

2011-06-13 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Touch this to try to fix the build...

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget):
14:22 Changeset [88695] by dglazkov@chromium.org

2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Record more flakiness...

  • platform/chromium/test_expectations.txt: Added expectation of flakiness.
14:20 Changeset [88694] by jberlin@webkit.org

[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597

Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.

  • platform/win/Skipped:
14:14 Changeset [88693] by xan@webkit.org

2011-06-13 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.list.am: remove CredentialStorage.cpp
14:10 Changeset [88692] by senorblanco@chromium.org

2011-06-13 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Improve GPU canvas startup time on the SkiaGPU path.
https://bugs.webkit.org/show_bug.cgi?id=62594


Fixed by skipping creation of shaders used only by the legacy path.

Covered by existing canvas tests.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
14:08 Changeset [88691] by msaboff@apple.com

2011-06-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498

Added some needed and speculative FontCachePurgePreventer objects.
Built and ran Safari with debug version of webkit that purges all
purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
to find system fallback fonts access via code paths that aren't
protected with FontCachePurgePreventer objects. Also examined
platform specific code that calls either Font::drawText() or
Canvas::drawText(). For those methods that may be called from currently
unprotected paths, added FontCachePurgePreventer objects.

No new functionality so no new tests.

  • inspector/DOMNodeHighlighter.cpp:
  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: (PlatformCALayerWinInternal::displayCallback):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::drawHudContents):
  • platform/mac/DragImageMac.mm: (WebCore::widthWithFont): (WebCore::drawAtPoint):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
13:59 Changeset [88690] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Windows rebaseline after r62565. The failure is tracked by the bug 62565.

  • platform/win/fast/harness/results-expected.txt:
13:58 Changeset [88689] by noam.rosenthal@nokia.com

2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Unreviewed fix - removed parts of r88659 that were committed by mistake.

The patch accidentally included parts that weren't supposed to be there, namely the whole
code was duplicated. This patch rectifies that and brings it to the original reviewed code.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
13:56 Changeset [88688] by levin@chromium.org

Test fix for Windows.

[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595

  • platform/win/Skipped: Skipped the test with the problem.
13:52 Changeset [88687] by mrobinson@webkit.org

Merging r88683

13:49 Changeset [88686] by mrobinson@webkit.org

Merging r87766

13:46 Changeset [88685] by rniwa@webkit.org

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544

Fixed the crash by adding null pointer checks.

No new tests since there's no way to open dictionary panel.

  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
  • editing/VisiblePosition.cpp: (WebCore::makeRange):
  • page/Frame.cpp: (WebCore::Frame::rangeForPoint):
13:41 Changeset [88684] by jberlin@webkit.org

plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973

Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.

  • platform/win/plugins/mouse-events-expected.txt:
  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
13:39 Changeset [88683] by mrobinson@webkit.org

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the list of ignored GTK+ header files for the documentation
generation.

  • docs/GNUmakefile.am: Update ignored header list.
13:36 Changeset [88682] by abarth@webkit.org

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::iconURLs):

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509

This new class contains all the icon-related logic from FrameLoader.
The icon-related logic and state has almost zero interaction with the
rest of FrameLoader and is better handled as a separate concern.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setIconURL):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): (WebCore::DocumentLoader::continueIconLoadWithDecision):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stop):
  • loader/FrameLoader.h: (WebCore::FrameLoader::icon):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
  • loader/icon/IconLoader.h:
13:25 Changeset [88681] by xan@webkit.org

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Update NEWS for 1.5.1 release.

  • NEWS: update.
13:20 Changeset [88680] by dpranke@chromium.org

2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88671.
http://trac.webkit.org/changeset/88671
https://bugs.webkit.org/show_bug.cgi?id=62591

"didn't work" (Requested by dpranke on #webkit).

  • Scripts/new-run-webkit-httpd:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
13:19 Changeset [88679] by japhet@chromium.org

2011-06-13 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
mostly written by Kelly Norton (knorton@google.com).

  • plugins/npruntime/embed-property-equality-expected.txt: Added.
  • plugins/npruntime/embed-property-equality.html: Added.

2011-06-13 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

[V8] Cache V8NPObjects so that we don't create multiple
NPObjects for the same v8::Object.
https://bugs.webkit.org/show_bug.cgi?id=61482

Test: plugins/npruntime/embed-property-equality.html

  • bindings/v8/NPV8Object.cpp: (WebCore::freeV8NPObject): (WebCore::npCreateV8ScriptObject):

2011-06-13 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
13:16 Changeset [88678] by jchaffraix@webkit.org

2011-06-13 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
https://bugs.webkit.org/show_bug.cgi?id=49316

The bug got fixed, thus just landing the test case. Including another test case from
http://code.google.com/p/chromium/issues/detail?id=61562
which should have the same root cause.

  • fast/html/crash-style-first-letter-expected.txt: Added.
  • fast/html/crash-style-first-letter.html: Added.
  • svg/custom/svg-use-style-float-crash-expected.txt: Added.
  • svg/custom/svg-use-style-float-crash.svg: Added.
13:07 Changeset [88677] by andersca@apple.com

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

BankID plug-in isn't instantiated correctly
https://bugs.webkit.org/show_bug.cgi?id=62588
<rdar://problem/9586600>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can use the half-baked QuickDraw support.
  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout): Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events and we don't want the plug-in to die while it's waiting for a reply.
13:03 Changeset [88676] by jamesr@google.com

2011-06-13 James Robinson <jamesr@chromium.org>

[chromium] Fix up a boo-boo in GPU test expectations

  • platform/chromium/test_expectations.txt:
13:01 Changeset [88675] by levin@chromium.org

Test run fix.

[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585

  • platform/gtk/Skipped: Skipping a test which depends on this.
12:47 Changeset [88674] by xan@webkit.org

Source/WebCore:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit/gtk:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:

Source/JavaScriptCore:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
12:37 Changeset [88673] by robert@webkit.org

2011-06-13 Robert Hogan <robert@webkit.org>

Unreviewed, cleanup r87611.

[Qt]Unskip fast/events/backspace-navigates-back.html

This should have been unskipped by http://trac.webkit.org/changeset/87611

  • platform/qt/Skipped:
12:33 Changeset [88672] by jberlin@webkit.org

Remove an extra space in the Windows-specific failing expected results to ge the bots
green.

  • platform/win/printing/page-count-relayout-shrink-expected.txt:
12:15 Changeset [88671] by dpranke@chromium.org

2011-06-13 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
https://bugs.webkit.org/show_bug.cgi?id=62251

shut_down_http_server() was a total hack that was only used by
new-run-webkit-httpd, so I've moved the code there and switched
to using executive.kill_process() for the common case. The
method itself will be removed in the patch on bug 59993.

  • Scripts/new-run-webkit-httpd:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
12:12 Changeset [88670] by krit@webkit.org

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed build fix of mac.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

Forgot to add SVGAnimatedLength.cpp.

  • WebCore.xcodeproj/project.pbxproj:
12:10 Changeset [88669] by cfleizach@apple.com

kAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547

Reviewed by Darin Adler.

Implement the missing screenToWindow method for WK2.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::screenToWindow):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::screenToWindow):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::screenToWindow):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::screenToWindow):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::screenToWindow):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenToWindow):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::screenToWindow):

  • WebProcess/WebPage/WebPage.h:
12:09 Changeset [88668] by oliver@apple.com

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Simon Fraser.

Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584

Move Identifier::equal to the Identifier header file.

  • runtime/Identifier.cpp:
  • runtime/Identifier.h: (JSC::Identifier::equal):
11:59 Changeset [88667] by weinig@apple.com

REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>

Reviewed by Darin Adler.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.

11:58 Changeset [88666] by jamesr@google.com

2011-06-13 James Robinson <jamesr@chromium.org>

[chromium] Clean up GPU test expectations.

  • platform/chromium/test_expectations.txt:
11:53 Changeset [88665] by commit-queue@webkit.org

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: complex keyPaths
https://bugs.webkit.org/show_bug.cgi?id=62468

  • storage/indexeddb/keyPath-expected.txt: Added.
  • storage/indexeddb/keyPath.html: Added.
11:50 Changeset [88664] by simon.fraser@apple.com

2011-06-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Print out bounds origin in layer dump
https://bugs.webkit.org/show_bug.cgi?id=62583

Include m_boundsOrigin in the layer dump, which is used by layerTreeAsText().

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
11:48 Changeset [88663] by krit@webkit.org

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

Added new tests to check correct behavior of SVGLength animations.

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-LengthModeOther.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-1.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-2.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-3.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-number-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-cm.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-ems.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-exs.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-in.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-pc.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-percentage.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-pt.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-px.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-values.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
  • svg/animations/svglength-animation-LengthModeHeight-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeHeight.html: Added.
  • svg/animations/svglength-animation-LengthModeOther-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeOther.html: Added.
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeWidth.html: Added.
  • svg/animations/svglength-animation-invalid-value-1-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-1.html: Added.
  • svg/animations/svglength-animation-invalid-value-2-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-2.html: Added.
  • svg/animations/svglength-animation-invalid-value-3-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-3.html: Added.
  • svg/animations/svglength-animation-number-to-number-expected.txt: Added.
  • svg/animations/svglength-animation-number-to-number.html: Added.
  • svg/animations/svglength-animation-px-to-cm-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-cm.html: Added.
  • svg/animations/svglength-animation-px-to-ems-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-ems.html: Added.
  • svg/animations/svglength-animation-px-to-exs-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-exs.html: Added.
  • svg/animations/svglength-animation-px-to-in-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-in.html: Added.
  • svg/animations/svglength-animation-px-to-number-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-number.html: Added.
  • svg/animations/svglength-animation-px-to-pc-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-pc.html: Added.
  • svg/animations/svglength-animation-px-to-percentage-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-percentage.html: Added.
  • svg/animations/svglength-animation-px-to-pt-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-pt.html: Added.
  • svg/animations/svglength-animation-px-to-px-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-px.html: Added.
  • svg/animations/svglength-animation-values-expected.txt: Added.
  • svg/animations/svglength-animation-values.html: Added.

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

When running SMIL animations within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
gets asked for its current value. This value gets transformed to a string. In SVGAnimateElement we try to parse this string again and
split it into a number and its unit. In the further steps we just animate the number. This number gets transformed back to a string
together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAngle, SVGColor, ...), relayout and rerendering.

In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.

This patch does not attempt to change the string transformations, but addresses the parsing of the string back to a number and unit in the
SVG animation code. There's no need to write a new parser in SVGAnimateElement to parse SVG primitive datatypes, we can instead reuse the existing ones.
Also the current parser of SVGAnimateElement does not handle most unit types, nor is it possible to animate lists like SVGLengthList with the
parsed content. An animation of values with different unit types is not possible:

<rect width="20" height="20">

<animate animateAttribute="width" from="20px" to="10%" dur="4s"/>

</rect>

For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
animation.
With using the parsers of SVG primitive datatypes we will also use the SVG primitive datatypes in the animation code itself. And that makes
it possible to do such animations.

In short: SVG primitive datatype -> string -> SVG primitive datatype animation -> string -> SVG primitive datatype.

It will be easier to avoid the string transformation once all SVG primitive datatypes are supported.

To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElement itself just works with the new added generic datatype SVGAnimationType.
SVGAnimatorFactory creates the SVG primitive datatype specific animators. This makes the main animation code a lot more readable and
maintainable.

With this patch I add the SVGAnimatorFactory and convert SVGLength animation to the new concept.

Tests: svg/animations/svglength-animation-LengthModeHeight.html

svg/animations/svglength-animation-LengthModeOther.html
svg/animations/svglength-animation-LengthModeWidth.html
svg/animations/svglength-animation-invalid-value-1.html
svg/animations/svglength-animation-invalid-value-2.html
svg/animations/svglength-animation-invalid-value-3.html
svg/animations/svglength-animation-number-to-number.html
svg/animations/svglength-animation-px-to-cm.html
svg/animations/svglength-animation-px-to-ems.html
svg/animations/svglength-animation-px-to-exs.html
svg/animations/svglength-animation-px-to-in.html
svg/animations/svglength-animation-px-to-number.html
svg/animations/svglength-animation-px-to-pc.html
svg/animations/svglength-animation-px-to-percentage.html
svg/animations/svglength-animation-px-to-pt.html
svg/animations/svglength-animation-px-to-px.html
svg/animations/svglength-animation-values.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other build systems.
  • svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. Use SVGLength parser directly. (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurrentColor public as preperation for SVGAnimatedColor. (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property. (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheritance as preperation for SVGAnimated* files. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now. (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedLength.cpp: Added. (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): (WebCore::sharedSVGLength): (WebCore::SVGAnimatedLengthAnimator::constructFromString): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator which is responsible for the actual animation. (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
  • svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement. (WebCore::SVGAnimatedType::createLength): (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::type): (WebCore::SVGAnimatedType::length): (WebCore::SVGAnimatedType::SVGAnimatedType):
  • svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLengthAnimator and future SVG unit animators. (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator): (WebCore::SVGAnimatedTypeAnimator::setContextElement): (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use parseNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespaces shouldn't be stripped on the following attributes: 'from', 'to' and 'by'. This is not the case for SVGLength anymore. Added new tests to check this behavior. (WebCore::SVGAnimationElement::animationMode): Enum is accessible in WebCore namespace now. (WebCore::SVGAnimationElement::calcMode): Ditto.
  • svg/SVGAnimationElement.h:
  • svg/SVGAnimatorFactory.h: Added. (WebCore::SVGAnimatorFactory::create):
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): New setter with string and SVGLengthMode. (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMode for SVGLength depending on the attribute name.
  • svg/SVGLength.h:
11:42 WebKit Team edited by caio.oliveira@openbossa.org
(diff)
11:37 Changeset [88662] by abarth@webkit.org

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

r87539 broke HTMLMediaElement url logging
https://bugs.webkit.org/show_bug.cgi?id=62551

Returning pointers to temporaries is bad times!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::sourceWasAdded): (WebCore::HTMLMediaElement::sourceWillBeRemoved):
11:36 Changeset [88661] by tony@chromium.org

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Scripts/build-webkit:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:29 Changeset [88660] by commit-queue@webkit.org

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
11:22 Changeset [88659] by noam.rosenthal@nokia.com

2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Added WebGraphicsLayer, a subclass of WebCore::GraphicsLayer that serializes the state of the layer
tree to the UI process WebLayerTreeInfo.
For now this patch doesn't serialize the animation information, a feature that will be upstreamed later on.

Together with Viatcheslav Ostapenko.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: Added.
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h: Added.
11:20 Changeset [88658] by dglazkov@chromium.org

2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Clean up test expectations, add a flake.

  • platform/chromium/test_expectations.txt: Cleaned up.
11:18 Changeset [88657] by simon.fraser@apple.com

2011-06-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Add utility method to report whether a RenderLayer has any scrollbars
https://bugs.webkit.org/show_bug.cgi?id=62579

New method that returns true with either scrollbar is present.

  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasScrollbars):
11:10 Changeset [88656] by jianli@chromium.org

Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.

TBR=jianli@chromium.org
BUG=85659
Review URL: http://codereview.chromium.org/7134095

11:09 Changeset [88655] by noam.rosenthal@nokia.com

2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Added WebLayerTreeInfo: a set of structures that can serialize a tree of GraphicsLayers
across to the UI process.

Together with Viatcheslav Ostapenko.

  • Scripts/webkit2/messages.py:
  • Shared/WebLayerTreeInfo.cpp: Added.
  • Shared/WebLayerTreeInfo.h: Added.
11:05 Changeset [88654] by jer.noble@apple.com

2011-06-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338

No new tests; covered by the existing full-screen tests.

Now that we are forcing a repaint inside of setRootFullScreenLayer() instead of during
the next run loop, make sure that we have disabled animation before calling
setRootFullScreenLayer() so that the RenderFullScreen renderer and its contents are
painted.

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement):

2011-06-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338

Instead of making a round-trip between processes by calling forceRepaint
and waiting for a callback, instead make a WebProcess-side call to
forceRepaintWithoutCallback before sending the ExitAcceleratedCompositingMode
message to the WebFullScreenControllerProxy. This also means we can get rid of
the dragImage creation and display.

Because this redraw will happen during the current run-loop instead of a future
one, make sure the background color has been set before the redraw in
didEnterFullScreen().

Wait to hide the full-screen window until after we have received the
ExitAcceleratedCompositingMode message. By this time, repaint will have already
completed.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Disable

screen updates, to be re-enabled during exitAcceleratedCompositingMode.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Don't hide

the full-screen window here; wait for exitAcceleratedCompositing instead.

(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Collapse

the redrawCompleted method into this one.

(-[WKFullScreenWindowController close]): Remove the reference to

exitCompositedModeRepaintCompleted.

  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::didEnterFullScreen): Set the full screen

background color first.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Repaint before

sending the ExitAcceleratedCompositingMode message.

11:02 Changeset [88653] by jer.noble@apple.com

2011-06-10 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
https://bugs.webkit.org/show_bug.cgi?id=62491
<rdar://problem/9584427>

No new tests; should be covered by existing fullscreen pixel tests.

On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
creation of a tiled CALayer (instead of a normal CALayer). Painting in these layers necessarily
happens asynchronously, so the flash is occurring because of the async painting of the RenderFullScreen
renderer's background color. Since we know the RenderFullScreen does not otherwise paint its contents,
we can add a special case in the RenderLayerBacking to set the GraphicsLayer contents to be the
renderer's background color. Fill in support for creating a contentLayer to contain the background
color inside GraphicsLayerCA.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from setContentsBackgroundColor to match

the other setContentsTo... functions.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the

background color.

(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a comment only.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen

renderer to call updateBackgroundColor.

(WebCore::RenderLayerBacking::updateBackgroundColor): Added.
(WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen

renderer does not paint its contents.

  • rendering/RenderLayerBacking.h:
10:59 Changeset [88652] by commit-queue@webkit.org

2011-06-13 Tim Horton <timothy_horton@apple.com>

Reviewed by Simon Fraser.

REGRESSION(87152): Crash on page with svg fonts
https://bugs.webkit.org/show_bug.cgi?id=61556

We can't assume that the parent of a SVG-font-styled
text node won't be an anonymous block.

Test: svg/text/text-font-anonymous-parent.xhtml

  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::firstParentRendererForNonTextNode): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
10:49 Changeset [88651] by krit@webkit.org

2011-06-13 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

Removing 'transform' animation test. It was added as an example for animateTransform tests but fails on some platforms.
Also it is not part of the fix for 'patternTransform' animation. The test for 'patternTransform' works.
Adding animateTransform-pattern-transform to the skip list of Mac WebKit2, like all other animation or dynamic-update tests.

  • platform/mac-wk2/Skipped:
  • svg/animations/animateTransform-transformable-transform-expected.txt: Removed.
  • svg/animations/animateTransform-transformable-transform.html: Removed.
  • svg/animations/script-tests/animateTransform-transformable-transform.js: Removed.
10:47 Changeset [88650] by andersca@apple.com

Add radar number.

10:32 Changeset [88649] by tony@chromium.org

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Scripts/build-webkit:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:25 Changeset [88648] by dglazkov@chromium.org

2011-06-13 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Updated Leopard pixel baselines.

  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:24 Changeset [88647] by andersca@apple.com

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't access freed memory in the UI process when a plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=62548

Call pluginProcessCrashedOrFailedToLaunch after sending messages to all processes about the plug-in crash,
otherwise we'll try to dereference m_pluginInfo.path after the PluginProcessProxy object has been deleted.

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose):
10:14 Changeset [88646] by carlosgc@webkit.org

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix a crash when drawing area has been deleted
https://bugs.webkit.org/show_bug.cgi?id=62541

Check whether WebPageProxy::drawingArea() returns a valid pointer
before using it, it might be null, for example, when the web
process crashes.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): (webkitWebViewBaseSizeAllocate):
10:12 Changeset [88645] by xan@webkit.org

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Some distcheck fixes. Still broken, but this is moves us closer to
the target.

  • GNUmakefile.am: fix vpath syntax and add missing files to EXTRA_DIST.
  • GNUmakefile.list.am: add missing files and remove dead files.
  • bindings/gobject/GNUmakefile.am: fix comment.
09:54 Changeset [88644] by vitalyr@chromium.org

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
09:16 Changeset [88643] by noam.rosenthal@nokia.com

2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925

Use the new factory function in TextureMapper.

No new functionality so no new tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):
08:48 Changeset [88642] by vitalyr@chromium.org

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
08:36 Changeset [88641] by commit-queue@webkit.org

2011-06-13 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

  • animations/animation-direction-normal-expected.png: Added.
  • animations/animation-direction-normal-expected.txt: Added.
  • animations/animation-direction-normal.html: Added.

2011-06-13 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

Test: animations/animation-direction-normal.html

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimations):
08:28 Changeset [88640] by commit-queue@webkit.org

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62429

  • UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
  • UIProcess/API/efl/PageClientImpl.h:
08:09 Changeset [88639] by commit-queue@webkit.org

2011-06-13 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
https://bugs.webkit.org/show_bug.cgi?id=62448

Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter

  • ewk/ewk_tiled_model.c: (ewk_tile_new):
  • ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
07:58 Changeset [88638] by commit-queue@webkit.org

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62525

  • UIProcess/efl/WebPreferencesEfl.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey):
07:28 Changeset [88637] by krit@webkit.org

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

SVG animation did not take attribute 'patternTransform' into account. Added support for combination of
SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransformElement.

Tests: svg/animations/animateTransform-pattern-transform.html

svg/animations/animateTransform-transformable-transform.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

Test SVG animateTransform for attributes 'transform' and 'patternTransform'.

  • svg/animations/animateTransform-pattern-transform-expected.txt: Added.
  • svg/animations/animateTransform-pattern-transform.html: Added.
  • svg/animations/animateTransform-transformable-transform-expected.txt: Added.
  • svg/animations/animateTransform-transformable-transform.html: Added.
  • svg/animations/script-tests/animateTransform-pattern-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animateTransform-transformable-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
07:12 Changeset [88636] by vitalyr@chromium.org

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
06:41 Changeset [88635] by caio.oliveira@openbossa.org

2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
https://bugs.webkit.org/show_bug.cgi?id=62330

This patch is based on the draft patch by Noam Rosenthal in bug 60842.
Qt API autotests cover the bridge behavior and pass after this patch.

  • bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types. In particular, we got rid of Strong<JSObject> members. Renamed some members and arguments to follow existing naming in QObject::connect().
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper function to create a connection, passing the ExecState* that will be used when the connection is activated (signal emitted). Use JSC API types when looking up the matching signal to disconnect.

(JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
protect the receiver and receiverFunction from being garbage
collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in current
code were Strong<>) anymore.

(JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
to use m_originalSender here. Unprotect values that we protected in constructor.

(JSC::Bindings::isJavaScriptFunction): Helper function to identify whether a
JSObjectRef is a JS function (in contrast to a native function exposed to JS).

(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
Both updated to use JSC API when appliable. Note that convertQVariantToValue
still returns JSC internal types, will be handled in a different patch.

(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
Convenince for the existing caller until it is converted to JSC as well.

02:35 Changeset [88634] by carlosgc@webkit.org

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827

  • platform/ContextMenuItem.h: Add gtkAction().
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): Implement constructor that receives a platform menu. (WebCore::ContextMenu::setPlatformDescription): Make sure we don't destroy the menu if the new context menu is the current one. (WebCore::contextMenuItemVector): Implement this method to return the list of menu items in the given context menu, required by WebKit2. (WebCore::platformMenuDescription): Implement this method to return a platform menu for the given menu items.
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::createPlatformMenuItemDescription): Helper function to create a platform context menu item. (WebCore::ContextMenuItem::ContextMenuItem): Use createPlatformMenuItemDescription(). (WebCore::ContextMenuItem::title): Convert the title from UTF-8. (WebCore::ContextMenuItem::setTitle): Use gtkAction(). (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu() that receives a list of items. (WebCore::ContextMenuItem::setChecked): Use gtkAction(). (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2. (WebCore::ContextMenuItem::enabled): Ditto. (WebCore::ContextMenuItem::setEnabled): Use gtkAction(). (WebCore::ContextMenuItem::gtkAction): Return the GtkAction associated to the context menu item.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createContextMenuProxy): Create a context menu proxy.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (globalPointForClientPoint): Function copied from webkit1 to convert a point in widget coordinates to global coordinates. (popupMenuPositionFunction): (webkitWebViewBaseShowContextMenu): Show the given context menu at the given position.
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added. (WebKit::contextMenuItemActivatedCallback): (WebKit::WebContextMenuProxyGtk::createGtkMenu): (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
  • UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h. (WebKit::WebContextMenuProxyGtk::create):
02:03 Changeset [88633] by keishi@webkit.org

2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>

Fix mistake I made in 88632

02:00 Changeset [88632] by keishi@webkit.org

2011-06-13 Keishi Hattori <keishi@webkit.org>

Sort WebCore.xcodeproj

Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
01:56 Changeset [88631] by carlosgc@webkit.org

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

  • GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
  • webkit/webkitwebview.h: Move declarations common to WebKit2 to webkitwebviewcommon.h.
  • webkit/webkitwebviewcommon.h: Added.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

Add first implementation of WebKitWebView, a class with the same
API than webkit1, that wraps the C API to provide a high level
WebKit2 API for GTK port.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebView.cpp: Added. (webkit_web_view_init): (webkit_web_view_class_init): (webkit_web_view_new): (webkit_web_view_load_uri): (webkit_web_view_go_back): (webkit_web_view_go_forward):
  • UIProcess/API/gtk/WebKitWebView.h: Added.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreate): (webkitWebViewBaseCreateWebPage):
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/webkit/webkit.h: Added.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
code, but linking to libwebkit2gtk.

  • GNUmakefile.am:
  • GtkLauncher/main.c: (createBrowser): (main):

06/12/11:

23:38 Changeset [88630] by morrita@google.com

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • platform/mac-wk2/Skipped:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKit.vcproj/WebKit.sln:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
23:20 Changeset [88629] by jer.noble@apple.com

2011-06-12 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507

No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.

If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

  • dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
22:15 Changeset [88628] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/MainResourceLoader.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
  • src/FrameLoaderClientImpl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
  • WebFrame.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
21:55 Changeset [88627] by commit-queue@webkit.org

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

  • editing/spelling/spellcheck-api-crash-expected.txt: Added.
  • editing/spelling/spellcheck-api-crash.html: Added.

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

Test: editing/spelling/spellcheck-api-crash.html

  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
21:13 Changeset [88626] by mahesh.kulkarni@nokia.com

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
20:05 Changeset [88625] by dominicc@chromium.org

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

Test: fast/harness/internals-object.html

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
19:17 Changeset [88624] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
19:05 Changeset [88623] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes should use size_t for length instead of int
https://bugs.webkit.org/show_bug.cgi?id=62508

size_t is the proper type for distances in memory, especially on 64 bit
machines.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
19:03 Changeset [88622] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.

This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
16:34 Changeset [88621] by xan@webkit.org

2011-06-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit_web_view_get_selected_text
https://bugs.webkit.org/show_bug.cgi?id=62512

It's no longer used and it's a private method, so it can be
removed.

  • webkit/webkitwebview.cpp: kill it.
  • webkit/webkitwebviewprivate.h: ditto.
14:24 Changeset [88620] by commit-queue@webkit.org

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
13:01 Changeset [88619] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Fix fullscreen/full-screen-iframe-legacy.html.

  • html/HTMLVideoElement.idl:
12:21 Changeset [88618] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.

  • webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
  • loader/FrameLoader.h:
    • cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
11:27 Changeset [88617] by mitz@apple.com

<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557

Reviewed by Darin Adler.

Replaced the fix for bug 58500 with a refined version.

  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.

10:23 Changeset [88616] by mahesh.kulkarni@nokia.com

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Reviewed by Antonio Gomes.

Tools:

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setTextDirection):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
09:57 Changeset [88615] by abarth@webkit.org

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Minor user-gesture related cleanup
https://bugs.webkit.org/show_bug.cgi?id=62511

In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.

  • bindings/v8/NPV8Object.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLVideoElement.idl:
07:52 Changeset [88614] by paroga@webkit.org

2011-06-12 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Build fix for !ENABLE(JIT) after r88604.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
05:40 Changeset [88613] by zimmermann@webkit.org

2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add TextRun charactersLength member
https://bugs.webkit.org/show_bug.cgi?id=62501

Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).

This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.

  • platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
  • platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
  • platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer

that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.

(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
  • rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
  • rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
04:51 Changeset [88612] by robert@webkit.org

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

Our expectations for the unskipped tests have the following differences from the mac
platform:

  • POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
  • DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
  • platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html

http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html

  • platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest (WebCore::QNetworkReplyHandler::getIODevice): ditto (WebCore::QNetworkReplyHandler::sendNetworkRequest):
    • Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
    • If a custom HTTP operation contains data, send it.
  • platform/network/qt/QNetworkReplyHandler.h:

06/11/11:

23:01 Changeset [88611] by msaboff@apple.com

2011-06-11 Michael Saboff <msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

  • platform/graphics/FontCache.cpp:
21:19 Changeset [88610] by abarth@webkit.org

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary strlen from DocumentWriter
https://bugs.webkit.org/show_bug.cgi?id=62505

This ugly piece of code appears not to be needed. Rejoice.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/DocumentWriter.h:
17:51 Changeset [88609] by abarth@webkit.org

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=62499

This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.

There's still lots of on contorting to do here, but it's a start.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/DocumentWriter.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
13:34 Changeset [88608] by rniwa@webkit.org

2011-06-11 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaseline after r85560.

Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:28 Changeset [88607] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::warmInitialProcess):

  • UIProcess/WebContext.h:
13:21 Changeset [88606] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/database-name-undefined-expected.txt: Removed.
  • storage/indexeddb/database-name-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBFactory.idl:
13:16 Changeset [88605] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):

  • wtf/DateMath.cpp:

(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

13:07 Changeset [88604] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):

  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:
  • wtf/Platform.h:
11:09 Changeset [88603] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Remove expectation of failure after clobber.
https://bugs.webkit.org/show_bug.cgi?id=62364

  • platform/chromium/test_expectations.txt: Removed.
10:12 Changeset [88602] by dglazkov@chromium.org

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/setVersion-undefined-expected.txt: Removed.
  • storage/indexeddb/setVersion-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.idl:
09:37 Changeset [88601] by inferno@chromium.org

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230

When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.

Tests: fast/dom/body-link-decl-parent-crash.html

fast/dom/styled-inline-style-decl-parent-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
  • html/HTMLBodyElement.h:

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62230

  • fast/dom/body-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-link-decl-parent-crash.html: Added.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Added.

06/10/11:

23:45 Changeset [88600] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Remove bogus ASSERTs. These ASSERTs used to be correct before I
changed DocumentWriter to put the onus for ignoring empty writes onto
the parser.

This patch should stop these test from triggering ASSERTs:

plugins/plugin-document-back-forward.html
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
userscripts/user-script-plugin-document.html

  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
23:23 Changeset [88599] by jer.noble@apple.com

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

AVPlayerLayer is adding a "fade" animation during Safari full-screen
https://bugs.webkit.org/show_bug.cgi?id=62433

CoreAnimation will add default animations when certain properties are changed, unless
those changes are wrapped in a CATransaction which has had its disableActions property set
to true. Wrap each of these three property changes in a CATransaction and disable its actions,
so that the default "fade" animation is not created in response.

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction. (-[WKFullScreenWindowController _swapView:with:]): Ditto:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto.
23:04 Changeset [88598] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: 'images' links on results.html don't work
https://bugs.webkit.org/show_bug.cgi?id=62194

Use relative path when generating images-diffs.html

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname.
22:52 Changeset [88597] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and
svg/custom/focus-event-handling-keyboard.html on Mac WebKit2
because they use DRT features not supported by WebKitTestRunner.

  • platform/mac-wk2/Skipped:
21:56 Changeset [88596] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

GTK and Qt rebaselines after r88555.

  • platform/gtk/svg/custom/focus-ring-expected.txt:
  • platform/qt/svg/custom/focus-ring-expected.txt:
21:53 Changeset [88595] by jamesr@google.com

2011-06-10 James Robinson <jamesr@chromium.org>

[chromium] Update chromium gpu baselines

  • platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/chromium/test_expectations.txt:
21:35 Changeset [88594] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows.

  • platform/chromium/fast/harness/results-expected.txt:
  • platform/win/fast/harness/results-expected.txt:
21:14 Changeset [88593] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac
because it has been failing on the bot; the failure is tracked by the bug 62364.

  • platform/chromium/test_expectations.txt:
21:05 Changeset [88592] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: results.html don't list the same list of failed tests as bots do
https://bugs.webkit.org/show_bug.cgi?id=62425

Fixed the bug by hiding expected crash, timeout, pass, etc... by default.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
20:36 Changeset [88591] by jer.noble@apple.com

2011-06-10 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411

  • fullscreen/full-screen-remove-ancestor-after-expected.txt: Added.
  • fullscreen/full-screen-remove-ancestor-after.html: Added.
  • platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411

Test: fullscreen/full-screen-remove-ancestor-after.html

The placeholder for RenderFullScreen was being created as a non-anonymous object, which led
to the document's renderer being set to 0 when the placeholder was removed due to its parent
being removed. Setting the placeholder to be anonymous, however, means that it will be
coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the
list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder
being so coalesced. To do so, made the placeholder object a true subclass, and add and
override its destroy() function to notify the RenderFullScreen object that it has been
destroyed.

  • rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder

has been destroyed.

(RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it.
(RenderFullScreen::setPlaceholder): Added.
(RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous.

  • rendering/RenderFullScreen.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added. (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of

objects which are not anonymous blocks.

19:51 Changeset [88590] by jamesr@google.com

2011-06-10 James Robinson <jamesr@chromium.org>

[chromium] Update chromium compositor baselines for r88580

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:06 Changeset [88589] by lforschler@apple.com

2011-06-10 Lucas Forschler <lforschler@apple.com>

Reviewed by Stephanie Lewis.

Script to kill old processes on Mac.
This matches the windows version.
https://bugs.webkit.org/show_bug.cgi?id=62479

  • BuildSlaveSupport/mac: Added.
  • BuildSlaveSupport/mac/kill-old-processes: Added.
19:04 Changeset [88588] by andersca@apple.com

2011-06-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

REGRESSION (WebKit2): window.showModalDialog() broken
https://bugs.webkit.org/show_bug.cgi?id=62496
<rdar://problem/9581492>

If dispatching a message ends up creating a nested run loop, some incoming messages can end up not being
delivered until we exit from the run loop.

Fix this by using a Deque instead of a Vector for incoming messages, and get one message at a time and then
dispatch it. That prevents us from having any lingering messages lying around in stack allocated space.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::dispatchMessages):
  • Platform/CoreIPC/Connection.h:
19:03 Changeset [88587] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.

Remove JSC::Inf, JSC::NaN, switch some cases of (isnan
isinf) to !isfinite.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::toNumber):

  • API/JSValueRef.cpp:

(JSValueMakeNumber):
(JSValueToNumber):

(JSC::CachedTranscendentalFunction::initialize):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DateInstanceCache.h:

(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:

(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toNumber):

  • runtime/JSValue.cpp:
  • runtime/JSValue.h:
  • runtime/JSValueInlineMethods.h:

(JSC::jsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

  • runtime/NumberConstructor.cpp:

(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/UString.cpp:
  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

  • wtf/dtoa.cpp:

(WTF::dtoa):

Source/WebCore:

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

18:56 Changeset [88586] by simonjam@chromium.org

2011-06-10 James Simonsen <simonjam@chromium.org>

Unreviewed, missing expectations for non-V8 from change 88584.
https://bugs.webkit.org/show_bug.cgi?id=62412

  • html5lib/runner-expected.txt:
18:18 Changeset [88585] by weinig@apple.com

2011-06-10 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Unresponsive cursor is shown when displaying a modal dialog
Part of <rdar://problem/9581492>
https://bugs.webkit.org/show_bug.cgi?id=62494

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runModal):
  • UIProcess/WebPageProxy.h: Stop the responsiveness timer when calling out to show a modal dialog.
18:08 Changeset [88584] by simonjam@chromium.org

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412

  • platform/chromium/html5lib/runner-expected.txt: Passes another test.
  • svg/dom/range-delete-expected.txt: Removed.
  • svg/dom/range-delete.html: Removed.
  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
  • svg/dom/use-style-recalc-script-execute-crash.html:
  • svg/in-html/resources/external.js: Added.
  • svg/in-html/script-expected.txt: Added.
  • svg/in-html/script-external-expected.txt: Added.
  • svg/in-html/script-external.html: Added.
  • svg/in-html/script-nested-expected.txt: Added.
  • svg/in-html/script-nested.html: Added.
  • svg/in-html/script-write-expected.txt: Added.
  • svg/in-html/script-write.html: Added.
  • svg/in-html/script.html: Added.

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412

Tests: svg/in-html/script-external.html

svg/in-html/script-nested.html
svg/in-html/script-write.html
svg/in-html/script.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
17:56 Changeset [88583] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336

Triggering this condition is very hard to do deterministically. This
test attempts to trigger the condition by sending exactly the right
number of bytes for the Chromium network stack. As network stacks vary
and evolve, it's likely we'll lose test coverage for this issue, but
this is the best test I could come up with.

  • fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
  • fast/parser/document-write-ignores-later-network-bytes.html: Added.

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336

If the network packet boundaries line up just right, we can end up
feeding network data to a parser created by document.write (or
document.open). That's incorrect.

This patch causes DocumentWriter to grab hold of the original parser
and direct all input to that parser.

Test: fast/parser/document-write-ignores-later-network-bytes.html

  • dom/Document.cpp: (WebCore::Document::explicitClose):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource): (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
  • loader/DocumentWriter.h:
17:39 Changeset [88582] by commit-queue@webkit.org

2011-06-10 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by James Robinson.

Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=62149

Added page overlay for inspector highlight support.

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
  • src/PageOverlay.cpp: Added. (WebKit::PageOverlay::create): (WebKit::PageOverlay::PageOverlay): (WebKit::OverlayGraphicsLayerClientImpl::create): (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl): (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted): (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired): (WebKit::OverlayGraphicsLayerClientImpl::paintContents): (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders): (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter): (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl): (WebKit::PageOverlay::clear): (WebKit::PageOverlay::update): (WebKit::PageOverlay::paintWebFrame): (WebKit::PageOverlay::invalidateWebFrame):
  • src/PageOverlay.h: Added. (WebKit::PageOverlay::~PageOverlay): (WebKit::PageOverlay::setClient):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::paintPageOverlay): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight):
  • src/WebDevToolsAgentImpl.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setPageOverlayClient): (WebKit::WebViewImpl::setOverlayLayer): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setRootPlatformLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::pageOverlay):
17:38 Changeset [88581] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by James Robinson.

When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
https://bugs.webkit.org/show_bug.cgi?id=62489

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
17:22 Changeset [88580] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Keep overlap testing logic until real 3d transforms are being used
https://bugs.webkit.org/show_bug.cgi?id=49857

For pages that use the translateZ(0) hack to force compositing layers, it's
advantageous to keep overlap testing, to avoid putting too many other
elements into layers.

Only turn off overlap testing if non-identity 3D transforms are used.

Tests: compositing/layer-creation/rotate3d-overlap.html

compositing/layer-creation/translatez-overlap.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
  • rendering/RenderLayerCompositor.h:
17:21 Changeset [88579] by levin@chromium.org

Web Worker fails to fire error event when a resource fetch fails.
https://bugs.webkit.org/show_bug.cgi?id=62475

Reviewed by Dmitry Titov.

Source/WebCore:

Test: http/tests/workers/worker-workerScriptNotThere.html

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.

LayoutTests:

  • http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
  • http/tests/workers/worker-workerScriptNotThere.html: Added.
17:11 Changeset [88578] by levin@chromium.org

Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
https://bugs.webkit.org/show_bug.cgi?id=62469

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/workers/worker-crash-with-invalid-location.html

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.

  • workers/Worker.cpp:

(WebCore::Worker::create): Ditto.

  • workers/Worker.h: Ditto.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts): Ditto.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.

  • workers/WorkerScriptLoader.h: Made this RefCounted to allow for

keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):

Source/WebKit/chromium:

Test: fast/workers/worker-crash-with-invalid-location.html

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.

LayoutTests:

  • fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
  • fast/workers/worker-crash-with-invalid-location.html: Added.
16:55 Changeset [88577] by alokp@chromium.org

2011-06-10 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Top portion of page is rendered messed up with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=62484

Fixed the math in flipping the texture from bottom-up to top-down.
Test: compositing/repaint/shrink-layer.html (existing)

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
16:35 Changeset [88576] by tony@chromium.org

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Configurations/FeatureDefines.xcconfig:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • Scripts/build-webkit:

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
16:27 Changeset [88575] by levin@chromium.org

2011-06-10 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

Add tests for Web Workers at invalid urls.
https://bugs.webkit.org/show_bug.cgi?id=62486

  • http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
  • http/tests/workers/shared-worker-invalid-url.html: Added.
  • http/tests/workers/worker-invalid-url-expected.txt: Added.
  • http/tests/workers/worker-invalid-url.html: Added.
15:55 Changeset [88574] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Turns out, linux baseline isn't spurious.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
15:43 Changeset [88573] by weinig@apple.com

Roll out r88568. It is not the right fix for the problem.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

15:21 Changeset [88572] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Remove all spurious copies of test expectations that somehow made it into the tree.

  • platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
15:20 Changeset [88571] by mrowe@apple.com

<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.

Reviewed by Dimitri Glazkov.

Source/WebCore:

Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.

Install the library and its associated header file in a more appropriate location
for the production configuration.

  • Configurations/WebCoreTestSupport.xcconfig:

Tools:

Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
14:53 Changeset [88570] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=62471

RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
in a way that was safe to call during existing style recalc or layout.

Move this code to ContainerElement so it can be called elsewhere.
Also add a param to the node callback so we can pass the style change type.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): (WebCore::ContainerNode::dispatchPostAttachCallbacks): (WebCore::needsStyleRecalcCallback): (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
  • dom/ContainerNode.h:
  • dom/Node.h: (WebCore::Node::scheduleSetNeedsStyleRecalc):
  • html/HTMLFormControlElement.cpp: (WebCore::focusPostAttach): (WebCore::updateFromElementCallback):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
  • html/HTMLPlugInImageElement.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::attachRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
  • rendering/RenderLayerCompositor.h:
  • svg/SVGUseElement.cpp: (WebCore::updateFromElementCallback):
14:42 Changeset [88569] by commit-queue@webkit.org

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

  • storage/indexeddb/database-name-undefined-expected.txt: Added.
  • storage/indexeddb/database-name-undefined.html: Added.

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

Test: storage/indexeddb/database-name-undefined.html

  • storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
14:34 Changeset [88568] by weinig@apple.com

Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>

Reviewed by Beth Dakin.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.

14:25 Changeset [88567] by eae@chromium.org

2011-06-10 Emil A Eklund <eae@chromium.org>

Land Windows expectations for new test added in r88556.

  • platform/win/printing/page-count-relayout-shrink-expected.txt: Added.
14:16 Changeset [88566] by abarth@webkit.org

2011-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Document::finishParsing
https://bugs.webkit.org/show_bug.cgi?id=62474

This function appears to exist only to confuse and befuddle us. This
patch prepares for DocumentWriter to grab hold of the parser.

This patch removes one of the print statements from
INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finish):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stop):
14:14 Changeset [88565] by commit-queue@webkit.org

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-10 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
14:04 Changeset [88564] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Null-check the layer owner again when painting layers
https://bugs.webkit.org/show_bug.cgi?id=62473

Speculative fix for a crash that occurs when the layer's owner
gets destroyed during painting.

  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
13:59 Changeset [88563] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Land expectations for a test, added in r88556.

  • platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.
13:54 Changeset [88562] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[V8] Add failure expectation for a test, added in r88559.

  • platform/chromium/test_expectations.txt: Added.
13:49 Changeset [88561] by robert@webkit.org

2011-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Lighten the --no-svg build a little
https://bugs.webkit.org/show_bug.cgi?id=62314

Only generate source from SVG*.idl if the build is svg-enabled.

  • CodeGenerators.pri:
13:39 Changeset [88560] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Remove expectation of crash, fixed in r88551.

  • platform/chromium/test_expectations.txt: Removed expectation.
13:33 Changeset [88559] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

This arises from chapter 15 of the spec:

"Every other property described in this clause has the attributes
{ Writable?: true, Enumerable?: false, Configurable?: true }
unless otherwise specified."

Standardized properties are not enumerable.

Source/JavaScriptCore:

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

LayoutTests:

  • fast/js/exception-properties-expected.txt: Added.
  • fast/js/exception-properties.html: Added.
  • fast/js/script-tests/exception-properties.js: Added.

(enumerableProperties):

13:29 Changeset [88558] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Update expectations after r88555.

  • platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.
13:15 Changeset [88557] by zimmermann@webkit.org

2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085

Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
https://bugs.webkit.org/show_bug.cgi?id=62441

Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.

Doesn't affect any test so far.

  • platform/graphics/SVGGlyph.h: (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk):
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::collectGlyphsForString): (WebCore::SVGFontElement::collectGlyphsForGlyphName): (WebCore::SVGFontElement::svgGlyphForGlyph): (WebCore::SVGFontElement::missingGlyph):
  • svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair):
  • svg/SVGGlyphMap.h: (WebCore::SVGGlyphMap::addGlyphByUnicodeString): (WebCore::SVGGlyphMap::addGlyphByName): (WebCore::SVGGlyphMap::appendToGlyphTable): (WebCore::SVGGlyphMap::collectGlyphsForString): (WebCore::SVGGlyphMap::clear): (WebCore::SVGGlyphMap::svgGlyphForGlyph): (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
12:44 Changeset [88556] by eae@chromium.org

2011-06-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

  • platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
  • platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
  • printing/page-count-relayout-shrink.html: Added.

2011-06-10 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343

Fix regression caused by r85573. Cached document size not updated after layout.

Test: printing/page-count-relayout-shrink.html

  • page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
12:43 Changeset [88555] by rwlbuis@webkit.org

2011-06-10 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

animation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545

Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.

  • platform/mac/svg/custom/focus-ring-expected.txt:
  • svg/custom/focus-event-handling-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard-expected.txt: Added.
  • svg/custom/focus-event-handling-keyboard.xhtml: Added.
  • svg/custom/focus-event-handling.xhtml: Added.
  • svg/custom/resources/focus-event-handling-keyboard.js: Added. (focusinHandler): (focusoutHandler):
  • svg/custom/resources/focus-event-handling.js: Added. (clearFocusSeen): (): (focusoutHandler): (clickAt):

2011-06-10 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

amation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894

focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545

Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:

http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute

Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.

Tests: svg/custom/focus-event-handling-keyboard.xhtml

svg/custom/focus-event-handling.xhtml

  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeRectForRepaint):
  • svg/SVGCircleElement.h: (WebCore::SVGCircleElement::supportsFocus):
  • svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::supportsFocus):
  • svg/SVGGElement.h: (WebCore::SVGGElement::supportsFocus):
  • svg/SVGImageElement.h: (WebCore::SVGImageElement::supportsFocus):
  • svg/SVGLineElement.h: (WebCore::SVGLineElement::supportsFocus):
  • svg/SVGPathElement.h: (WebCore::SVGPathElement::supportsFocus):
  • svg/SVGPolyElement.h: (WebCore::SVGPolyElement::supportsFocus):
  • svg/SVGRectElement.h: (WebCore::SVGRectElement::supportsFocus):
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::supportsFocus):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isMouseFocusable): (WebCore::SVGStyledElement::isKeyboardFocusable):
  • svg/SVGStyledElement.h:
  • svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::supportsFocus):
  • svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::supportsFocus):
  • svg/SVGTextElement.h: (WebCore::SVGTextElement::supportsFocus):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::supportsFocus):
11:35 Changeset [88554] by rniwa@webkit.org

2011-06-10 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
11:17 Changeset [88553] by macpherson@chromium.org

2011-06-10 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Clean up CSSPrimitiveValue::computeLength*
https://bugs.webkit.org/show_bug.cgi?id=61612

No new tests as no functionality changed.

  • css/CSSGradientValue.cpp: Use new computeLength functions.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthIntForLength): Reduce to a single function using default parameter values. (WebCore::CSSPrimitiveValue::computeLength): Redefine existing functions with separate names as a single function using templated function specialization.
  • css/CSSPrimitiveValue.h: Prototypes for computeLengthIntForLength and computeLength.
  • css/CSSStyleApplyProperty.cpp: Use new computeLength functions.
  • css/CSSStyleSelector.cpp: Use new computeLength functions.
  • css/MediaQueryEvaluator.cpp: Use new computeLength functions.
  • css/SVGCSSStyleSelector.cpp: Use new computeLength functions.
11:10 Changeset [88552] by simon.fraser@apple.com

2011-06-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Beth Dakin.

Add utility to RenderLayer to determine if the layer is scrollable
https://bugs.webkit.org/show_bug.cgi?id=62467

New method that returns true if either scrollbar is present and enabled.
Not called anywhere yet.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::allowsScrolling):
  • rendering/RenderLayer.h:
10:56 Changeset [88551] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Tony Chang.

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
https://bugs.webkit.org/show_bug.cgi?id=62460

Test: fast/dom/prototype-inheritance-2.html

  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.
10:51 Changeset [88550] by dglazkov@chromium.org

Revert r87319 on 782 branch.

10:31 Changeset [88549] by inferno@chromium.org

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Tony Gentilcore.

Tests that trying to remove all document children while building a svg <use>
element shadow and instance tree does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62225

  • svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
  • svg/dom/use-style-recalc-script-execute-crash.html: Added.

2011-06-10 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Don't execute scripts in shadow SVG.
https://bugs.webkit.org/show_bug.cgi?id=62225

Test: svg/dom/use-style-recalc-script-execute-crash.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::prepareScript):
10:31 Changeset [88548] by tony@chromium.org

2011-06-10 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] make features.gypi the same as features_override.gypi
https://bugs.webkit.org/show_bug.cgi?id=62399

Make the file the same as chromium's features_override.gypi so we
can remove features_override.gypi in chromium.

Remove ENABLE_DATAGRID=0 since the define is gone and remove
ENABLE_FULLSCREEN_API=1 since we want to disable it.

  • features.gypi:
10:29 Changeset [88547] by loislo@chromium.org

2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>

Reviewed by Joseph Pecoraro.

Fixed build with enabled workers and disabled inspector
https://bugs.webkit.org/show_bug.cgi?id=62461

  • inspector/InspectorWorkerAgent.cpp: Added inspector guard
10:05 Changeset [88546] by darin@apple.com

2011-06-10 Darin Adler <darin@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Fullscreen video controller can't be dragged
https://bugs.webkit.org/show_bug.cgi?id=62462

No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new booleans related to dragging. (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging is allowed and a drag isn't already in progress. (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if dragging is already in progress. (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is done during the dragging process. (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel using explicit top/left. (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning done by setPosition. (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag, continueDrag, and endDrag in response to mouse events. (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
  • html/shadow/MediaControlElements.h: Added new function and data members as mentioned above.
  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true) so you can drag the panel while in fullscreen. (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false) so you can't drag the panel while not in fullscreen. Also call resetPosition so position changes from dragging don't affect the panel in other contexts.
10:00 Changeset [88545] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

Remove tests that are now passing.

  • platform/chromium/test_expectations.txt: Removed passing tests.
09:52 Changeset [88544] by darin@apple.com

2011-06-10 Darin Adler <darin@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Full screen video HUD is positioned too low for standalone video documents
https://bugs.webkit.org/show_bug.cgi?id=62463

No test because we don't currently have machinery for testing fullscreen.

  • css/fullscreen.css: Removed rule that said bottom: 0px for the control panel for full page media in full screen mode. This is not needed because the control panel for full screen mode already has style rules to set its vertical position. (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said -webkit-tranform. This will fix a potential problem where fullscreen would malfunction on a page that had a media element inside a transform.
09:06 Changeset [88543] by sergio@webkit.org

2011-06-10 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Add support for non-ASCII filenames in Content-Disposition header
https://bugs.webkit.org/show_bug.cgi?id=62454

Try latin1 as fallback for header parameter values as some servers
do not follow RFC 2045 for example with filename parameter in
Content-Disposition.

No new tests required as no functionality changed.

  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
08:55 Changeset [88542] by dglazkov@chromium.org

2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>

REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
https://bugs.webkit.org/show_bug.cgi?id=62460

  • platform/chromium/test_expectations.txt: Updated test expectations.
04:56 Changeset [88541] by commit-queue@webkit.org

2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925

Added a static factory protected member to GraphicsLayer, which should be accessed from
a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.

This is needed for accelerated compositing across processes in WebKit2, since WebCore
doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
different implementations of GraphicsLayer coexist impossible without some runtime
factory that can be overridden by the web process.

Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
would have to explicitly call it, in order to be unintrusive with current implementations.

No new functionality, so no new tests.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setGraphicsLayerFactory):
  • platform/graphics/GraphicsLayer.h:
04:34 Changeset [88540] by commit-queue@webkit.org

2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
https://bugs.webkit.org/show_bug.cgi?id=62346

Add WebProcess/WebCoreSupport/efl directory and files.

  • WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added. (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added. (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError): (WebKit::pluginWillHandleLoadError):
  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
  • WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
04:32 Changeset [88539] by commit-queue@webkit.org

2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376

Add files that need to be compiled in every port for supporting WebGL.
Each port still needs to add its specific files to
CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
yet.

  • Source/CMakeLists.txt: Add files needed to support WebGL.
  • Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
  • Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is enabled.

2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376

Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.

No change in functionality so no new tests.

  • CMakeLists.txt:
04:31 Changeset [88538] by andreas.kling@nokia.com

2011-06-10 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Fix 'headers' autotest when building inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=62449

  • Api/qwebkitplatformplugin.h:
04:30 Changeset [88537] by commit-queue@webkit.org

2011-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL]add image content hint information for tile image object when it is created
https://bugs.webkit.org/show_bug.cgi?id=62436

When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
In order to support this enhanced feature, image content hint information must be
specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC

  • ewk/ewk_tiled_model.c: (ewk_tile_new):
04:23 Changeset [88536] by commit-queue@webkit.org

2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Andreas Kling.

[GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
https://bugs.webkit.org/show_bug.cgi?id=62435

No new tests required as just fixed warning.

  • platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::PlatformContextCairo):

2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
03:15 Changeset [88535] by loislo@chromium.org

2011-06-10 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
03:06 Changeset [88534] by laszlo.1.gombos@nokia.com

2011-06-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=62420

ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
but they meant to be independent.

  • Api/qwebframe.cpp: (QWebFramePrivate::_q_orientationChanged): (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
02:09 Changeset [88533] by commit-queue@webkit.org

2011-06-10 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Repaint throttling API.
https://bugs.webkit.org/show_bug.cgi?id=56178

The API allows to set the values for repaint throttling.
It should ensure displaying a content with many css/gif animations.

  • ewk/ewk_settings.cpp: (ewk_settings_repaint_throttling_set):
  • ewk/ewk_settings.h:
01:56 Changeset [88532] by gyuyoung.kim@samsung.com

2011-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use makeString() when getting os version
https://bugs.webkit.org/show_bug.cgi?id=62434

When os version string is created, to use makeString() is better than
String operation.

  • ewk/ewk_settings.cpp: (_ewk_settings_webkit_os_version_get):
01:41 Changeset [88531] by loislo@chromium.org

2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440

qt build was broken (Requested by loislo on #webkit).

  • inspector/InspectorValues.cpp:
01:33 Changeset [88530] by loislo@chromium.org

2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377

  • inspector/InspectorValues.cpp:
00:35 Changeset [88529] by yurys@chromium.org

2011-06-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Worker object may be garbage collected even if it has message handlers
https://bugs.webkit.org/show_bug.cgi?id=62292

I'd like to convert the test case into a layout test but I don't see yet
how to do this so that the test isn't too slow and reliable. The problem
with test is that full-GC needs to be triggered right after
WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
So no test for now.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending activity state every time a message is confirmed since the message may have created a new activity.
  • src/WebWorkerClientImpl.h:
00:10 Changeset [88528] by jer.noble@apple.com

2011-06-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=62402

Sites are able to override the "overflow:hidden" rule for root full-screen nodes
simply by adding a "html {}" rule. Make this rule !important, and also make it apply
to root nodes who are merely ancestors of full-screen elements, to cover the case of
a root node containing an <iframe> whose contents have gone full-screen.

  • css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen),

:root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
who are full-screen ancestors, and make them !important.

Note: See TracTimeline for information about the timeline view.