Timeline



Jun 15, 2011:

11:55 PM Changeset in webkit [89010] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] new test introduced in r88958 fail on Qt

  • platform/qt/Skipped: Skip http/tests/appcache/video.html until fix.
11:34 PM Changeset in webkit [89009] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update: inspector/profiler/cpu-profiler-profiling.html and cpu-profiler-profiling-without-inspector.html doesn't crash anymore. https://bugs.webkit.org/show_bug.cgi?id=61533

11:24 PM Changeset in webkit [89008] by mnaganov@chromium.org
  • 14 edits
    1 copy in trunk

2011-06-15 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector [Chromium]: Make heap snapshots UI more responsive.
https://bugs.webkit.org/show_bug.cgi?id=62360

Two changes have been made:

  • when we request elements, sort array only partially;
  • when populating children, do it in batches;
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind): (WebInspector.HeapSnapshotEdgesProvider.prototype.sort): (WebInspector.HeapSnapshotNodesProvider.prototype.sort):
  • inspector/front-end/HeapSnapshotWorker.js:
  • inspector/front-end/PartialQuickSort.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-06-15 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector [Chromium]: Make heap snapshots UI more responsive.
https://bugs.webkit.org/show_bug.cgi?id=62360

Two changes have been made:

  • when we request elements, sort array only partially;
  • when populating children, do it in batches;
  • WebKit.gyp:

2011-06-15 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector [Chromium]: Make heap snapshots UI more responsive.
https://bugs.webkit.org/show_bug.cgi?id=62360

Two changes have been made:

  • when we request elements, sort array only partially;
  • when populating children, do it in batches;
  • inspector/profiler/heap-snapshot.html:
  • inspector/utilities.html:
11:15 PM Changeset in webkit [89007] by abarth@webkit.org
  • 13 edits in trunk/Source

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Event::fromUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62778

This function is a remnant from the old user-gesture design. The list
of events here is redundant with our selection of call sites for
setting the user gesture indicator.

As part of this patch, I've also cleaned up the implementation of
UserGestureIndicator itself to always be definite about whether we're
processing a user gesture. We now start out in a definite state (no
user gesture) and inductively state in a definite state.

  • WebCore.exp.in:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/UserGestureIndicator.cpp: (WebCore::isDefinite): (WebCore::UserGestureIndicator::UserGestureIndicator): (WebCore::UserGestureIndicator::~UserGestureIndicator):
  • dom/UserGestureIndicator.h: (WebCore::UserGestureIndicator::processingUserGesture):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Event::fromUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62778

This call site is not definite about there not being a user gesture.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest):
10:12 PM Changeset in webkit [89006] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-08 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Fix range element not updating when value attribute is set with JS
https://bugs.webkit.org/show_bug.cgi?id=61857

Test: fast/forms/range-set-attribute.html

  • html/RangeInputType.cpp: (WebCore::RangeInputType::minOrMaxAttributeChanged): Changed to only sanitize the value when the dirty value flag is true.
9:40 PM Changeset in webkit [89005] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-15 Adam Barth <abarth@webkit.org>

Unreviewed. (Technically I should get this reviewed, but I
accidentally committed part of this patch in my previous commit,
causing a build break.)

Remove ScriptController::m_processingTimerCallback
https://bugs.webkit.org/show_bug.cgi?id=62776

This variable is unused. (It used to be used in a user gesture detection hack.)

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/v8/ScriptController.h:
9:38 PM Changeset in webkit [89004] by tkent@chromium.org
  • 8 edits
    1 delete in trunk

2011-06-15 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium][Qt] Some slider clicking tests fail.
https://bugs.webkit.org/show_bug.cgi?id=62683

When we pressed a mouse button on a slider thumb,
SliderThumbElement::startDragging() were called twice.

  • From SliderThumbElement::defaultEventHandler(), and
  • from RangeInputType::handleMouseDownEvent()

The latter is not needed. We should call setDefaultHandled() correctly.

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Calls setDefaultHandled()
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromPoint): Remove FIXME comments. (WebCore::SliderThumbElement::defaultEventHandler): Calls setDefaultHandled()

2011-06-15 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium][Qt] Some slider clicking tests fail.
https://bugs.webkit.org/show_bug.cgi?id=62683

  • fast/forms/slider-mouse-events-expected.txt:
  • fast/forms/slider-mouse-events.html: Add step=5 to ignore small difference of thumb sizes.
  • platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped: slider-onchange-event.html should pass by this change.
9:37 PM Changeset in webkit [89003] by dpranke@chromium.org
  • 9 edits
    1 delete in trunk/Tools

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Revert the patches in r88995 and r88999; the http servers don't
seem to be shutting down reliably.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
9:25 PM Changeset in webkit [89002] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Anders Carlsson.

Remove ScriptController::isJavaScriptAnchorNavigation
https://bugs.webkit.org/show_bug.cgi?id=62775

This function no longer plays a role in the user gesture code now that
we're not encoding the user gesture state into the ScriptSourceCode
URL.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
9:10 PM Changeset in webkit [89001] by abarth@webkit.org
  • 11 edits in trunk/Source

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove ScriptController::setAllowPopupsFromPlugin
https://bugs.webkit.org/show_bug.cgi?id=62706

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove ScriptController::setAllowPopupsFromPlugin
https://bugs.webkit.org/show_bug.cgi?id=62706

This API is just a poor man's UserGestureIndicator. We should use the
real deal.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h:
  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h:

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove ScriptController::setAllowPopupsFromPlugin
https://bugs.webkit.org/show_bug.cgi?id=62706

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): (WebKit::PluginView::evaluate):
9:09 PM Changeset in webkit [89000] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, whitespace change to force a build.

  • platform/chromium/test_expectations.txt:
8:57 PM Changeset in webkit [88999] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add some debugging messages to triage problems introduced in
r88995.

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
8:43 PM Changeset in webkit [88998] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove forceUserGesture bool in favor of UserGestureIndicator
https://bugs.webkit.org/show_bug.cgi?id=62702

This patch is an intermediate step towards removing the
forceUserGesture bool. In this patch, we use the user gesture
indicator to store the gesture state instead of encoding it in the URL
of the script source code. In a future patch, we'll push the indicator
higher up the stack, closer to the reason for setting it.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
8:38 PM Changeset in webkit [88997] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Refine expectations to eliminate some unexpected passes.

  • platform/chromium/test_expectations.txt:
8:10 PM Changeset in webkit [88996] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Refine expectations to eliminate some unexpected passes.

  • platform/chromium/test_expectations.txt:
7:47 PM Changeset in webkit [88995] by dpranke@chromium.org
  • 9 edits
    1 add in trunk/Tools

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: should clean up stale server processes from a previous run
https://bugs.webkit.org/show_bug.cgi?id=62615

This change fixes cases where NRWT might start a server and then
exit, leaving the server still running. Now NRWT should detect
this case and clean up on the next run, without shutting down
any processes it didn't start.

This change also fixes a bug in executive.kill_process on UNIX
where zombies weren't being handled properly.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
7:08 PM Changeset in webkit [88994] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix test-webkitpy failure introduced in r88986.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
7:07 PM Changeset in webkit [88993] by cevans@google.com
  • 1 edit
    6 copies in branches/chromium/782

Merge 88987
BUG=85943
Review URL: http://codereview.chromium.org/7191003

7:06 PM Changeset in webkit [88992] by cevans@google.com
  • 1 edit
    6 copies in branches/chromium/742

Merge 88987
BUG=85943
Review URL: http://codereview.chromium.org/7191002

7:04 PM Changeset in webkit [88991] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

2011-06-15 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE][WK2] Add an option to build webkit2.
https://bugs.webkit.org/show_bug.cgi?id=62260

Add ENABLE_WEBKIT2 to build WebKit2 using CMake and ENABLE_WEBKIT to disable
WebKit.

  • Source/CMakeLists.txt:
  • Source/cmake/WebKitFS.cmake:

2011-06-15 Ryuan Choi <ryuan.choi@samsung.com>

Rubber stamped by Eric Seidel.

[CMAKE][WK2] Add an option to build webkit2.
https://bugs.webkit.org/show_bug.cgi?id=62260

Add script to build WebKit2 using CMake.

  • CMakeLists.txt: Added.
6:58 PM Changeset in webkit [88990] by dpranke@chromium.org
  • 2 edits
    190 adds in trunk/LayoutTests

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Add Mac Leopard baselines for the new CSS2.1 tests added in
r88913.

  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:54 PM Changeset in webkit [88989] by rwlbuis@webkit.org
  • 16 edits in trunk/Source/WebCore

2011-06-15 Rob Buis <rbuis@rim.com>

Reviewed by Darin Adler.

Try to use fastGetAttribute where possible
https://bugs.webkit.org/show_bug.cgi?id=62747

Use the fast versions of get/hasAttribute where we can.

No new tests since this is a simple cleanup.

  • svg/SVGAElement.cpp: (WebCore::SVGAElement::title): (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::glyphRef): (WebCore::SVGAltGlyphElement::format): (WebCore::SVGAltGlyphElement::glyphElement):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::rotateMode): (WebCore::SVGAnimateMotionElement::animationPath):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::animationMode): (WebCore::SVGAnimationElement::calcMode): (WebCore::SVGAnimationElement::attributeType): (WebCore::SVGAnimationElement::toValue): (WebCore::SVGAnimationElement::byValue): (WebCore::SVGAnimationElement::fromValue): (WebCore::SVGAnimationElement::isAdditive): (WebCore::SVGAnimationElement::isAccumulated): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGElement.cpp: (WebCore::SVGElement::xmlbase):
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::ensureGlyphCache):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): (WebCore::SVGFontFaceElement::xHeight): (WebCore::SVGFontFaceElement::horizontalOriginX): (WebCore::SVGFontFaceElement::horizontalOriginY): (WebCore::SVGFontFaceElement::horizontalAdvanceX): (WebCore::SVGFontFaceElement::verticalOriginX): (WebCore::SVGFontFaceElement::verticalOriginY): (WebCore::SVGFontFaceElement::verticalAdvanceY): (WebCore::SVGFontFaceElement::ascent): (WebCore::SVGFontFaceElement::descent):
  • svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::srcValue):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::srcValue): (WebCore::SVGFontFaceUriElement::loadFont):
  • svg/SVGGlyphElement.cpp: (WebCore::parseSVGGlyphAttribute): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): (WebCore::SVGSVGElement::contentStyleType):
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): (WebCore::SVGStyleElement::media): (WebCore::SVGStyleElement::title):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::buildVerticalKerningPair):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): (WebCore::SVGSMILElement::parseMappedAttribute): (WebCore::SVGSMILElement::restart): (WebCore::SVGSMILElement::fill): (WebCore::SVGSMILElement::xlinkHref): (WebCore::SVGSMILElement::dur): (WebCore::SVGSMILElement::repeatDur): (WebCore::SVGSMILElement::repeatCount): (WebCore::SVGSMILElement::maxValue): (WebCore::SVGSMILElement::minValue):
6:17 PM Changeset in webkit [88988] by Darin Adler
  • 8 edits in trunk/Source

2011-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Remove obsolete LOOSE_OWN_PTR code
https://bugs.webkit.org/show_bug.cgi?id=59909

The internal Apple dependency on this is gone now.

  • wtf/OwnArrayPtr.h: Removed constructor that takes a raw pointer, set function that takes a raw pointer.
  • wtf/OwnPtr.h: Removed constructor that takes a raw pointer, set functino that takes a raw pointer.
  • wtf/PassOwnArrayPtr.h: Made constructor that takes a nullptr and assignment operator that takes a nullptr unconditional. Made constructor that takes a raw pointer private and explicit, and removed assignment operator that takes a raw pointer.
  • wtf/PassOwnPtr.h: Made assignment operator that takes a nullptr unconditional. Made constructor that takes a raw pointer private and explicit, and removed assignment operator that takes a raw pointer.

2011-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Remove obsolete LOOSE_OWN_PTR code
https://bugs.webkit.org/show_bug.cgi?id=59909

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): Use adoptPtr instead of LOOSE_OWN_PTR.
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): Ditto.
6:09 PM Changeset in webkit [88987] by inferno@chromium.org
  • 3 edits
    6 adds in trunk

2011-06-15 Abhishek Arya <inferno@chromium.org>

Reviewed by Antti Koivisto.

Tests that accessing the parent stylesheet in nodes (not in document)
do not result in crash when document is cleared.
https://bugs.webkit.org/show_bug.cgi?id=62586

  • fast/dom/body-clone-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-clone-link-decl-parent-crash.html: Added.
  • fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-clone-inline-style-decl-parent-crash.html: Added.
  • fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html: Added.

2011-06-15 Abhishek Arya <inferno@chromium.org>

Reviewed by Antti Koivisto.

Revert speculative fix in r84151. It caused some issues with
stylesheet lifetimes.
https://bugs.webkit.org/show_bug.cgi?id=62586

Tests: fast/dom/body-clone-link-decl-parent-crash.html

fast/dom/styled-clone-inline-style-decl-parent-crash.html
fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html

  • dom/Document.cpp: (WebCore::Document::removedLastRef):
5:49 PM Changeset in webkit [88986] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-06-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

NRWT: doesn't support webarchives, has stale skipping logic.
https://bugs.webkit.org/show_bug.cgi?id=58293

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:37 PM Changeset in webkit [88985] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-06-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Implement animationXXX functions for Progress Tag
https://bugs.webkit.org/show_bug.cgi?id=62713

Progress tag need to implement acnimationXXX functions in order to show animation of
progress tag. Because, RenderProgress decides to show update progress bar's animation
according to the functions.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeEfl::animationDurationForProgressBar):
  • platform/efl/RenderThemeEfl.h:
5:12 PM Changeset in webkit [88984] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-15 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=62764

This is an non-reproducible high volume crash, so no test :(.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.
4:17 PM Changeset in webkit [88983] by sullivan@apple.com
  • 3 edits in trunk/Source/WebKit2

WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named wrong because they return copied strings
<https://bugs.webkit.org/show_bug.cgi?id=62763>
<rdar://problem/9618071>

Reviewed by Sam Weinig.

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginCopyProtocol):
Renamed to use "Copy" instead of "Get" because it returns a copy.
(WKSecurityOriginCopyHost):
Ditto.

  • Shared/API/c/WKSecurityOrigin.h:

Updated declarations.

4:13 PM Changeset in webkit [88982] by bdakin@apple.com
  • 13 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=62746
Crash possible when switching scrollbar appearance preference on Mac
-and corresponding-
<rdar://problem/9323983>

Reviewed by Simon Fraser.

This crash happens because the current mechanism that is intended to flag
ScrollAnimators as being in the page cache or not does not work correctly.
Long-term the fix for this is to move the ScrollableArea HashSet to a more
appropriate place. In the meantime, this patch addresses the crash by getting
rid of the m_isActive bool on ScrollAnimator that was intended to represent
whether or not the ScrollableArea is in the page cache. Instead, ScrollableArea
implementations now have their own functions to compute whether they are in
active pages. ScrollAnimator::setIsActive() needs to be kept around even though
there is no bool to flip anymore because scrollbars may need to be properly
updated if the appearance was switched while the document was in the page cache.

No longer call FrameView::setAnimatorsAreActive() from
Document::setIsInPageCache(), instead call it in
Document::documentDidBecomeActive()

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidBecomeActive):

ScrollableAreas can now assess whether or not they are on active pages (ie, not
in the page cache).

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isOnActivePage):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isOnActivePage):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isOnActivePage):

  • rendering/RenderListBox.h:

A FrameView cannot access its Document when it's in the page cache, so it
usually determines whether it's in the page cache by checking if its frame
points to a FrameView other than itself.

  • page/FrameView.cpp:

(WebCore::FrameView::isOnActivePage):

Make sure ScrollableAreas are on active pages before setting them as
active. This will not be necessary when the HashSet become a per-web page
HashSet.
(WebCore::FrameView::setAnimatorsAreActive):

  • page/FrameView.h:


ScrollAnimator no longer tracks the m_isActive bool.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::setIsActive):

setIsActive() now exclusively calls updateScrollStyle() if there is a pending
need to do so.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::setIsActive):

Return early if the ScrollableArea is in the page cache.
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

4:08 PM Changeset in webkit [88981] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; more test expectations cleanup.

Get rid of some unexpected passes from the GPU bots.

  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [88980] by simon.fraser@apple.com
  • 6 edits in trunk

2011-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Have Document keep track of whether scroll listeners are registered
https://bugs.webkit.org/show_bug.cgi?id=62757

To avoid extra work dispatching scroll events when there are no listeners,
have Document keep track of whether any scroll listeners are registered,
just like it does for some other event types.

  • dom/Document.cpp: (WebCore::Document::addListenerTypeIfNeeded):
  • dom/Document.h:
  • dom/EventQueue.cpp: (WebCore::EventQueue::enqueueOrDispatchScrollEvent):
3:35 PM Changeset in webkit [88979] by senorblanco@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations cleanup.

Removing some incorrect text results (platform/mac fallback is correct).
Adding some bug IDs from my lazy gardening last time around.

  • platform/chromium-win/animations/animation-drt-api-expected.txt: Removed.
  • platform/chromium-win/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [88978] by jhoneycutt@apple.com
  • 8 edits
    1 copy in trunk/Source/WebKit2

REGRESSION(78201): Windowless Flash plug-ins are transparent on some sites
https://bugs.webkit.org/show_bug.cgi?id=62690
<rdar://problem/9512026>

Reviewed by Ada Chan.

The bug arises when mixing CoreGraphics and GDI. When we create a Windows
bitmap for a windowless plug-in to draw into, we first fill it with "clear",
or all 0s. If the plug-in uses GDI to draw, the GDI calls will ignore the
alpha channel, and if we then use CG to blend this bitmap onto the
GraphicsContext for the rest of the page, CG will treat the 0-filled
alpha channel as being transparent.

To fix this, on Windows, use a GDI-backed GraphicsContext to paint the
page in the WebProcess, and use GDI to blit from the UpdateInfo to the
backing store in the UI process.

  • Platform/SharedMemory.h:

(WebKit::SharedMemory::handle):
Return the handle for the memory.

  • Shared/ShareableBitmap.h:

Declared windowsContext() to return a HDC with the bitmap selected into it.
Added members to store the HDC and the HBITMAP.

  • Shared/win/ShareableBitmapWin.cpp: Added.

(WebKit::ShareableBitmap::windowsContext):
Get the screen DC, and create a compatible DC from it. Create a DIB
section backed by the shared memory, select it into the context, and
return it.

  • UIProcess/win/BackingStoreWin.cpp:

(WebKit::BackingStore::incorporateUpdate):
Use GDI to blit from the update info's bitmap into the backing store bitmap.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::createGraphicsContext):
Return a GraphicsContext from the ShareableBitmap.
(WebKit::DrawingAreaImpl::display):
Call createGraphicsContext(), and pass the ShareableBitmap.

  • WebProcess/WebPage/DrawingAreaImpl.h:

Declare createGraphicsContext(), which on Windows will create a GDI-backed
GraphicsContext.

  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Added.

(WebKit::DrawingAreaImpl::createGraphicsContext):
Get a Windows context for the bitmap, and create and return a new
GraphicsContext using the DC.

  • win/WebKit2.vcproj:

Added new files.

3:11 PM Changeset in webkit [88977] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

2011-06-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Clarify FileChooser creation code.
https://bugs.webkit.org/show_bug.cgi?id=62756

initialize() method is only used once and that is not obvious, so just fold it into the create method.

Refactoring, no change in behavior.

  • platform/FileChooser.cpp: (WebCore::FileChooser::create): Folded initialize() code there.
  • platform/FileChooser.h: Removed decl.
3:02 PM Changeset in webkit [88976] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; yet more test expectations updates.

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [88975] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make access-nseive ~9x faster on the non-speculative path by
adding special casing for doubles that can lossless-ly be converted
to a uint32_t in getByVal and putByVal. This avoids calls to stringification
and the hash lookup. Long term, we should try and get property of a getByVal
and putByVal to be an integer immediate even in the non-speculative path.

Reviewed by Geoffrey Garen and Gavin Barraclough.

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):

2:46 PM Changeset in webkit [88974] by oliver@apple.com
  • 5 edits in trunk

2011-06-15 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
https://bugs.webkit.org/show_bug.cgi?id=62720

Add test for the "interesting" ascii characters that may occur in an identifier

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:

2011-06-15 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION (r88719): 5by5.tv schedule is not visible
https://bugs.webkit.org/show_bug.cgi?id=62720

Problem here is that the lexer wasn't considering '$' to be
a valid character in an identifier.

  • parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):
2:39 PM Changeset in webkit [88973] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move more argument coders to WebCoreArgumentCoders.cpp
https://bugs.webkit.org/show_bug.cgi?id=62755

  • Shared/WebCoreArgumentCoders.cpp: (CoreIPC::::decode): (CoreIPC::::encode): (CoreIPC::encodeImage): (CoreIPC::decodeImage):
  • Shared/WebCoreArgumentCoders.h:
2:12 PM Changeset in webkit [88972] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; more chromium test expectations updates.

Rebaseline one GPU test on Linux.

  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium/test_expectations.txt:
1:58 PM Changeset in webkit [88971] by senorblanco@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; more chromium test expectations updates.

Rebaselined one additional CSS 2.1 test on Linux.

  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:27 PM Changeset in webkit [88970] by senorblanco@chromium.org
  • 2 edits
    622 adds in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; new chromium test baselines.

New chromium baselines for CSS 2.1 tests introduced in r88913. Note
that some results are incorrect, and were left failing in
test_expectations (yes, I checked them all).

  • platform/chromium-linux/css2.1/20110323: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-height-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-013-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-014-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-015-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-016-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-017-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-018-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-019-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-020-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-021-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-022-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-023-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-non-replaced-width-024-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-014-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-016-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-017-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-018-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-019-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-021-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-022-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-023-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-024-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-025-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-026-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-028-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-029-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-030-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-031-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-032-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-033-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-035-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-height-036-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-013-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-015-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-020-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-022-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-027-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-029-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-034-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-036-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-041-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-043-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-048-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-050-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-055-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-057-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-062-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-064-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-069-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-071-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/absolute-replaced-width-076-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-013-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-014-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-015-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-height-016-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-non-replaced-width-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/block-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-008-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-009-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-010-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-non-replaced-width-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/float-replaced-width-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-block-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-non-replaced-width-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-height-007-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-006-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-011-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-012-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-013-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-014-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/inline-replaced-width-015-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/width-replaced-element-001-expected.txt: Added.
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:56 PM Changeset in webkit [88969] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

versioning.

12:52 PM Changeset in webkit [88968] by ddkilzer@apple.com
  • 3 edits
    1 move in trunk/Source/WebKit

<http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++

Reviewed by Joseph Pecoraro.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

(WebNSFileManagerExtras.m): Rename to WebNSFileManagerExtras.mm
and change file type to Objective-C++.

Source/WebKit/mac:

  • Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.

(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Added static_cast<MetaDataInfo *>.

12:50 PM Changeset in webkit [88967] by andersca@apple.com
  • 8 edits
    1 delete in trunk/Source/WebKit2

2011-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add ShareableBitmap::createImage and get rid of WebCoreArgumentCodersCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=62742

  • Shared/ShareableBitmap.h: Move createImage out of the #if PLATFORM(QT) section.
  • Shared/WebCoreArgumentCoders.cpp: (CoreIPC::decodeImage): Call ShareableBitmap::createImage.
  • Shared/WebCoreArgumentCoders.h: remove createImage function declaration.
  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::createImage): Add implementation.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::createImage): Move createImage implementation from WebCoreArgumentCodersCG.cpp here.
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Update projects.
12:44 PM WebKit Team edited by oliver@apple.com
(diff)
12:42 PM Changeset in webkit [88966] by Lucas Forschler
  • 1 copy in tags/Safari-534.46.1

New tag.

12:42 PM Changeset in webkit [88965] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning for windows build fix.

12:37 PM QtWebKitRelease22 edited by joel.parks@nokia.com
(diff)
12:26 PM Changeset in webkit [88964] by jorlow@webkit.org
  • 2 edits in trunk/Tools

Change my email to @webkit.org

Patch by Jeremy Orlow <jorlow@webkit.org> on 2011-06-15

  • Scripts/webkitpy/common/config/committers.py:
11:47 AM Changeset in webkit [88963] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-06-15 Eric Carlson <eric.carlson@apple.com>

Skip new failing test.

[Qt] http/tests/appcache/video.html fails
https://bugs.webkit.org/show_bug.cgi?id=62741

  • platform/gtk/Skipped:
11:27 AM Changeset in webkit [88962] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-15 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Reduce the size of global_resolve
https://bugs.webkit.org/show_bug.cgi?id=62738

Reduce the code size of global_resolve in the JIT by replacing
multiple pointer loads with a single pointer move + two offset
loads.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_global):
11:23 AM Changeset in webkit [88961] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp

Windows build fix.

11:14 AM Changeset in webkit [88960] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Alexey Proskuryakov.

Move some argument coders to WebCoreArgumentCoders.cpp
https://bugs.webkit.org/show_bug.cgi?id=62739

  • GNUmakefile.am:
  • Shared/WebCoreArgumentCoders.cpp: (CoreIPC::::encode): (CoreIPC::::decode):
  • Shared/WebCoreArgumentCoders.h:
  • WebKit2.pro:
11:11 AM Changeset in webkit [88959] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-15 Tony Chang <tony@chromium.org>

Fix Qt results for RenderDeprecatedFlexibleBox rename.

  • platform/qt/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.txt:
10:40 AM Changeset in webkit [88958] by eric.carlson@apple.com
  • 11 edits
    3 adds in trunk

2011-06-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

MediaPlayerPrivate should not know about application cache
https://bugs.webkit.org/show_bug.cgi?id=62648

Test: http/tests/appcache/video.html

  • html/HTMLMediaElement.cpp: (WebCore::createFileURLForApplicationCacheResource): Create a url for a file

in the application cache folder.

(WebCore::HTMLMediaElement::loadResource): Change url to point to file in the application

cache if necessary.

(WebCore::HTMLMediaElement::mediaLoadingFailed): Split failure logic out of setNetworkState

so it can be called when asked to load a file that is not in the application cache.

(WebCore::HTMLMediaElement::setNetworkState): Move failure logic out to mediaLoadingFailed.

  • html/HTMLMediaElement.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Remove app cache logic.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::loadInternal): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Ditto.

2011-06-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

MediaPlayerPrivate should not know about application cache
https://bugs.webkit.org/show_bug.cgi?id=62648

Add test for <video> in the application cache.

  • http/tests/appcache/resources/video.manifest: Added.
  • http/tests/appcache/video-expected.txt: Added.
  • http/tests/appcache/video.html: Added.
10:33 AM Changeset in webkit [88957] by tony@chromium.org
  • 28 edits in trunk/LayoutTests

2011-06-15 Tony Chang <tony@chromium.org>

Fixing more results with RenderDeprecatedFlexibleBot rename.

  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/win-xp/media/audio-repaint-expected.txt:
10:32 AM Changeset in webkit [88956] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix possible null dereference in webSecKeychainItemCreateFromContentOnMainThread
https://bugs.webkit.org/show_bug.cgi?id=62736
<rdar://problem/9601595>

  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webSecKeychainItemCreateFromContentOnMainThread): SecKeychainItemCreateFromContent can potentially return a null keychain item, so add a null check before trying to retain it.
10:28 AM Changeset in webkit [88955] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaseline after r88913.

  • platform/gtk/svg/hixie/text/003-expected.txt:
10:24 AM Changeset in webkit [88954] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-15 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

  • storage/indexeddb/database-name-undefined-expected.txt: Added.
  • storage/indexeddb/database-name-undefined.html: Added.

2011-06-15 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398

Test: storage/indexeddb/database-name-undefined.html

  • storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
10:12 AM Changeset in webkit [88953] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-15 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Ignore responsiveness timer callbacks on closed pages
https://bugs.webkit.org/show_bug.cgi?id=62735
<rdar://problem/9511295>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Use nullptr instead of clear.

(WebKit::WebPageProxy::processDidBecomeUnresponsive):
Return early if the page isn't valid.

(WebKit::WebPageProxy::processDidBecomeResponsive):
Ditto.

(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
Assert that the page is valid.

10:12 AM Changeset in webkit [88952] by tony@chromium.org
  • 284 edits
    2 moves in trunk

2011-06-15 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Rename RenderFlexibleBox to RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=62670

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/MediaControlElements.cpp: (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay): (WebCore::RenderMediaControlTimeDisplay::layout):
  • html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderContainer::RenderSliderContainer): (WebCore::RenderSliderContainer::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
  • rendering/RenderBox.cpp:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::addChild): (WebCore::RenderButton::removeChild):
  • rendering/RenderButton.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::reset): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox): (WebCore::RenderDeprecatedFlexibleBox::~RenderDeprecatedFlexibleBox): (WebCore::marginWidthForChild): (WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths): (WebCore::RenderDeprecatedFlexibleBox::layoutBlock): (WebCore::gatherFlexChildrenInfo): (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): (WebCore::RenderDeprecatedFlexibleBox::placeChild): (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex): (WebCore::RenderDeprecatedFlexibleBox::renderName):
  • rendering/RenderDeprecatedFlexibleBox.h: (WebCore::RenderDeprecatedFlexibleBox::avoidsFloats): (WebCore::RenderDeprecatedFlexibleBox::isFlexibleBox): (WebCore::RenderDeprecatedFlexibleBox::isFlexingChildren): (WebCore::RenderDeprecatedFlexibleBox::isStretchingChildren): (WebCore::RenderDeprecatedFlexibleBox::hasMultipleLines): (WebCore::RenderDeprecatedFlexibleBox::isVertical): (WebCore::RenderDeprecatedFlexibleBox::isHorizontal):
  • rendering/RenderDetails.h: Removed the header since it wasn't actually

needed. Looks like a copy/paste error from RenderButton.h.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::RenderFullScreen): (RenderFullScreen::destroy):
  • rendering/RenderFullScreen.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::createInnerBlock): (WebCore::RenderMenuList::removeChild):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):
  • rendering/RenderingAllInOne.cpp:
10:11 AM Changeset in webkit [88951] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

Can't type text when input element is shrunken by a CSS rule
https://bugs.webkit.org/show_bug.cgi?id=62550

Added a regression test now that the bug no longer reproduces.

  • fast/forms/type-after-focus-rule-shrink-width-expected.txt: Added.
  • fast/forms/type-after-focus-rule-shrink-width.html: Added.
10:02 AM Changeset in webkit [88950] by apavlov@chromium.org
  • 12 edits in trunk

2011-06-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Serious performance regression during continuous focused element style updates
https://bugs.webkit.org/show_bug.cgi?id=61038

  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/set-attribute.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:

2011-06-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Serious performance regression during continuous focused element style updates
https://bugs.webkit.org/show_bug.cgi?id=61038

Inline style invalidation events are coalesced in the backend and sent over the wire on timer.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::RevalidateStyleAttributeTask::onTimer): (WebCore::InspectorDOMAgent::getAttributes): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::styleAttributeInvalidated):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute): (WebCore::InspectorStyleSheetForInlineStyle::text): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._loadNodeAttributesSoon): (WebInspector.DOMAgent.prototype._loadNodeAttributes): (WebInspector.DOMDispatcher.prototype.attributesUpdated): (WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):
9:55 AM Changeset in webkit [88949] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Martin Robinson <mrobinson@igalia.com>

Reclassify a failing GTK+ test.

  • platform/gtk/Skipped: This test is actually failing because EventSender.mouseScrollBy is missing.
9:51 AM Changeset in webkit [88948] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-15 Jer Noble <jer.noble@apple.com>

Reviewed by Timothy Hatcher.

Full-screen live streams have status text in wrong location
https://bugs.webkit.org/show_bug.cgi?id=62733

Fix a misspelling in the user-agent stylesheet for full-screen mode.

  • css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-status-display):
9:45 AM Changeset in webkit [88947] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-15 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fix and update doxygen documentation for ewk_frame.
https://bugs.webkit.org/show_bug.cgi?id=62533

This patch:

  • fixes method descriptions,
  • adds briefs for structure and typdef,
  • replaces NULL to 0 in doxygen documentation (webkit's style required it),
  • removes dots from the end of params and return description (see EFL's documentation),
  • moves includes and defines below a brief of ewk_frame.h
  • moves internal methods to the end of ewk_frame.cpp.
  • ewk/ewk_frame.cpp: (ewk_frame_add):
  • ewk/ewk_frame.h:
9:28 AM Changeset in webkit [88946] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Alexey Proskuryakov.

Textarea will not accept space characters at end of line
https://bugs.webkit.org/show_bug.cgi?id=61483

Added a regression test now that the bug has been resolved by r88883.

  • editing/input/insert-wrapping-space-in-textarea-expected.txt: Added.
  • editing/input/insert-wrapping-space-in-textarea.html: Added.
9:26 AM Changeset in webkit [88945] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

(AVFoundation) Apple event video appears as live stream and is not seekable
https://bugs.webkit.org/show_bug.cgi?id=62694

No new tests; There are no media-player port specific tests yet.

Work around a bug in apple.com live stream javascript controller library. When an AVAsset returns an indefinite time
for its duration, return 0 if the asset has no tracks, and infinity otherwise. This keeps the apple.com controller
from identifying the stored stream as a live stream.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
9:18 AM Changeset in webkit [88944] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88907.
http://trac.webkit.org/changeset/88907
https://bugs.webkit.org/show_bug.cgi?id=62732

See comment #15 by Nikolas Zimmermann on bug 62527 regarding
the deprecation of makeString() (Requested by acidx on
#webkit).

  • UIProcess/efl/WebPageProxyEfl.cpp: (WebKit::WebPageProxy::standardUserAgent):
9:11 AM Changeset in webkit [88943] by caseq@chromium.org
  • 31 edits
    6 deletes in trunk

2011-06-15 Andrey Kosyakov < caseq@chromium.org>

Unreviewed, rolled out r88937 (broke build on mac)

9:00 AM Changeset in webkit [88942] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-15 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce context menu on ImageView with Copy and Open in new tab actions.
https://bugs.webkit.org/show_bug.cgi?id=62727

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._base64ToSize): (WebInspector.ImageView.prototype._contextMenu): (WebInspector.ImageView.prototype._copyImageURL): (WebInspector.ImageView.prototype._openInNewTab):
8:59 AM Changeset in webkit [88941] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-15 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixing new inspector test.

  • inspector/debugger/error-in-watch-expressions-expected.txt:
  • inspector/debugger/error-in-watch-expressions.html:
8:44 AM Changeset in webkit [88940] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide unique identifiers for frames
https://bugs.webkit.org/show_bug.cgi?id=62721

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::frameDestroyedImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::frameDestroyed):
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::frameForId): (WebCore::InspectorPageAgent::frameId): (WebCore::InspectorPageAgent::frameDestroyed):
  • inspector/InspectorPageAgent.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame):
8:42 AM Changeset in webkit [88939] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-15 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix: comment unused parameter names.

  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didReceiveResponse): (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
8:23 AM Changeset in webkit [88938] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

A few more updates to bring test_expectations in line with reality.

  • platform/chromium/test_expectations.txt:
8:20 AM Changeset in webkit [88937] by commit-queue@webkit.org
  • 31 edits
    6 adds in trunk

2011-06-15 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.
https://bugs.webkit.org/show_bug.cgi?id=61205

Added inspector backend cache for XHR content.

  • http/tests/inspector/network/network-xhr-async-expected.txt: Added.
  • http/tests/inspector/network/network-xhr-async.html: Added.
  • http/tests/inspector/network/network-xhr-sync-expected.txt: Added.
  • http/tests/inspector/network/network-xhr-sync.html: Added.

2011-06-15 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.
https://bugs.webkit.org/show_bug.cgi?id=61205

Added inspector backend cache for XHR content.

Tests: http/tests/inspector/network/network-xhr-async.html

http/tests/inspector/network/network-xhr-sync.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::didReceiveResponse):
  • fileapi/FileReaderLoader.h:
  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveXHRResponseImpl): (WebCore::InspectorInstrumentation::willLoadXHRSynchronouslyImpl): (WebCore::InspectorInstrumentation::didLoadXHRSynchronouslyImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveXHRResponse): (WebCore::InspectorInstrumentation::willLoadXHRSynchronously): (WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::setInitialXHRContent): (WebCore::InspectorResourceAgent::didReceiveXHRResponse): (WebCore::InspectorResourceAgent::willLoadXHRSynchronously): (WebCore::InspectorResourceAgent::didLoadXHRSynchronously): (WebCore::InspectorResourceAgent::getResourceContent): (WebCore::InspectorResourceAgent::mainFrameNavigated): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h:
  • inspector/NetworkResourcesData.cpp: Added. (WebCore::NetworkResourcesData::ResourceData::ResourceData): (WebCore::NetworkResourcesData::ResourceData::content): (WebCore::NetworkResourcesData::ResourceData::appendContent): (WebCore::NetworkResourcesData::ResourceData::purgeContent): (WebCore::NetworkResourcesData::NetworkResourcesData): (WebCore::NetworkResourcesData::~NetworkResourcesData): (WebCore::NetworkResourcesData::resourceCreated): (WebCore::NetworkResourcesData::responseReceived): (WebCore::NetworkResourcesData::didReceiveXHRResponse): (WebCore::NetworkResourcesData::addResourceContent): (WebCore::NetworkResourcesData::isXHR): (WebCore::NetworkResourcesData::data): (WebCore::NetworkResourcesData::clear): (WebCore::NetworkResourcesData::ensureFreeSpace):
  • inspector/NetworkResourcesData.h: Added. (WebCore::NetworkResourcesData::ResourceData::identifier): (WebCore::NetworkResourcesData::ResourceData::loaderId): (WebCore::NetworkResourcesData::ResourceData::frameId): (WebCore::NetworkResourcesData::ResourceData::setFrameId): (WebCore::NetworkResourcesData::ResourceData::url): (WebCore::NetworkResourcesData::ResourceData::setUrl): (WebCore::NetworkResourcesData::ResourceData::isXHR): (WebCore::NetworkResourcesData::ResourceData::setIsXHR): (WebCore::NetworkResourcesData::ResourceData::hasContent): (WebCore::NetworkResourcesData::ResourceData::isContentPurged): (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkDispatcher.prototype._appendRedirect):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._appendResource): (WebInspector.NetworkPanel.prototype._frameNavigated):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::receivedCancellation): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didReceiveResponse): (WebCore::ThreadableLoaderClient::didReceiveAuthenticationCancellation):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didReceiveResponse): (WebCore::ThreadableLoaderClientWrapper::didReceiveAuthenticationCancellation):
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::workerContextDidReceiveAuthenticationCancellation): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
  • loader/WorkerThreadableLoader.h:
  • notifications/Notification.cpp: (WebCore::Notification::didReceiveResponse): (WebCore::Notification::didReceiveAuthenticationCancellation):
  • notifications/Notification.h:
  • page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse):
  • page/EventSource.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveAuthenticationCancellation):
  • xml/XMLHttpRequest.h:

2011-06-15 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.
https://bugs.webkit.org/show_bug.cgi?id=61205

Added inspector backend cache for XHR content.

  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
8:17 AM Changeset in webkit [88936] by podivilov@chromium.org
  • 6 edits in trunk

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script select can be too wide.
https://bugs.webkit.org/show_bug.cgi?id=62701

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script select can be too wide.
https://bugs.webkit.org/show_bug.cgi?id=62701

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._displayNameForScriptURL): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
  • inspector/front-end/SourceFile.js:
8:16 AM Changeset in webkit [88935] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-15 Claudio Saavedra <Claudio Saavedra>

Reviewed by Xan Lopez.

[GTK] Fix the build with introspection enabled
https://bugs.webkit.org/show_bug.cgi?id=62705

  • GNUmakefile.am: Remove include of *.c files, since there are no such files anymore.
8:09 AM Changeset in webkit [88934] by commit-queue@webkit.org
  • 4 edits
    10 adds in trunk

2011-06-15 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

CSS property outline not displayed on an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/replaced/no-focus-ring-embed-expected.txt: Added.
  • fast/replaced/no-focus-ring-embed.html: Added.
  • fast/replaced/no-focus-ring-iframe-expected.txt: Added.
  • fast/replaced/no-focus-ring-iframe.html: Added.
  • fast/replaced/no-focus-ring-object-expected.txt: Added.
  • fast/replaced/no-focus-ring-object.html: Added.
  • fast/replaced/outline-replaced-elements-expected.txt: Added.
  • fast/replaced/outline-replaced-elements.html: Added.
  • fast/replaced/resources/focus-test.js: Added. (element.onfocus): Use a small delay to avoid test false positives.
  • platform/mac/fast/replaced/outline-replaced-elements-expected.png: Added.

2011-06-15 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Eric Seidel.

Draw CSS outline style for render widgets: iframe, embed, object, applet.
https://bugs.webkit.org/show_bug.cgi?id=57439

Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
be focused (via clicks or tabIndex) but should not have a visible focus ring by default.

Tests: fast/replaced/no-focus-ring-embed.html

fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object.html
fast/replaced/outline-replaced-elements.html

  • css/html.css: (applet:focus, embed:focus, iframe:focus, object:focus): Default to no focus ring.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
8:08 AM Changeset in webkit [88933] by diegohcg@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-15 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Inconsistent behavior on a form submit request...
https://bugs.webkit.org/show_bug.cgi?id=45523

The inconsistency occurs when a form submission requests a new window.
Two windows are opened (instead of only one) and the first window is opened
as a blank page.

By default each page is put into their own unique page group, which affects popup windows
and visited links. Page groups (per process only) is a feature making it possible to use
separate settings for each group, so that for instance an integrated browser/email reader
can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
as expected out of the box, we use a default group similar to what other ports are doing.

  • Api/qwebpage.cpp:
8:08 AM Changeset in webkit [88932] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-15 Steve Block <steveblock@google.com>

Reviewed by Tony Gentilcore.

V8PerformanceCustom.cpp lacks WEB_TIMING guards
https://bugs.webkit.org/show_bug.cgi?id=62689

No new tests, build fix only.

  • bindings/v8/custom/V8PerformanceCustom.cpp:
7:57 AM Changeset in webkit [88931] by podivilov@chromium.org
  • 6 edits in trunk

2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88916.
http://trac.webkit.org/changeset/88916
https://bugs.webkit.org/show_bug.cgi?id=62728

Broke a bunch of layout tests on chromium (Requested by
podivilov on #webkit).

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:

2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88916.
http://trac.webkit.org/changeset/88916
https://bugs.webkit.org/show_bug.cgi?id=62728

Broke a bunch of layout tests on chromium (Requested by
podivilov on #webkit).

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype.get displayName):
7:55 AM Changeset in webkit [88930] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

Suppressing the failures introduced at r88913.

  • platform/chromium/test_expectations.txt:
7:49 AM Changeset in webkit [88929] by demarchi@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebKit/efl

2011-06-15 Kamil Blank <k.blank@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Soup authentication feature implementation.
https://bugs.webkit.org/show_bug.cgi?id=54752

This implementation is based on GTK implementation.
During ewk initialization SoupSessionFeature is added which provides possibility to handle HTTP basic auth.

To support authentication we have to set function (callback) via ewk_auth_show_dialog_callback_set()
which will be responsible for session authentication.
If callback is set and authentication required - webkit pauses soup message, calls previously set callback
and waits for authentication data (username/password) which should be passed by ewk_auth_credentials_set().

  • CMakeListsEfl.txt:
  • ewk/ewk_auth.cpp: Added. (ewk_auth_show_dialog_callback_set): Setting callback which should be called when authentication is required. (ewk_auth_credentials_set): Passing authentication data.
  • ewk/ewk_auth.h: Added. Authentication API.
  • ewk/ewk_auth_soup.cpp: Added. Soup authentication implementation. (_Ewk_Auth_Data::ewk_auth_soup_dialog_class_init): (_Ewk_Auth_Data::ewk_auth_soup_dialog_init): (_Ewk_Auth_Data::ewk_auth_soup_dialog_session_feature_init): (_Ewk_Auth_Data::ewk_auth_soup_show_dialog_callback_set): (_Ewk_Auth_Data::ewk_auth_soup_credentials_set): (_Ewk_Auth_Data::session_authenticate): (_Ewk_Auth_Data::free_auth_data): (_Ewk_Auth_Data::attach): (_Ewk_Auth_Data::detach):
  • ewk/ewk_auth_soup.h: Added.
  • ewk/ewk_main.cpp: (_ewk_init_body): SoupSessionFeature responsible for authentication added to SoupSession.
7:38 AM Changeset in webkit [88928] by demarchi@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88723.
http://trac.webkit.org/changeset/88723
https://bugs.webkit.org/show_bug.cgi?id=62726

Stack can be empty, so it needs to be checked before as
pointed out in the comments of the bug. (Requested by demarchi
on #webkit).

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
  • WebCoreSupport/EditorClientEfl.h:
7:30 AM Changeset in webkit [88927] by podivilov@chromium.org
  • 10 edits in trunk

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script links are displayed with original line number in pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=62282

  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script links are displayed with original line number in pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=62282

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.registerAnchor): (WebInspector.DebuggerPresentationModel.prototype._updateAnchor.didGetUILocation): (WebInspector.DebuggerPresentationModel.prototype._updateAnchor): (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.showAnchorLocation): (WebInspector.NetworkPanel.prototype._showResource):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.createAnchor): (WebInspector.Panel.prototype.formatAnchorText):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.createAnchor.): (WebInspector.ScriptsPanel.prototype.createAnchor): (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation): (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
  • inspector/front-end/inspector.js: (WebInspector._showAnchorLocation): (WebInspector.linkifyResourceAsNode):
7:21 AM Changeset in webkit [88926] by Csaba Osztrogonác
  • 10 edits
    1 delete in trunk/Source/WebKit2

[Qt][WK2] Unreviewed rolling out r88799, because it made web process crash.

  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::collectCompositingInfoForThisLayer):

  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.
6:57 AM Changeset in webkit [88925] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-14 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Use fileExists() first when checking if SQLite db exists
https://bugs.webkit.org/show_bug.cgi?id=62638

In IDBSQLiteBackingStore::backingStoreExists(), which is used to check
if a SQLite database exists and should be considered for migration,
check if the file exists first.

Trying to open a SQLite database for a non-existing file prints a
noisy error message in debug builds.

No new functionality, no new tests.

  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
6:53 AM Changeset in webkit [88924] by tkent@chromium.org
  • 59 edits in trunk/LayoutTests

2011-06-15 Kent Tamura <tkent@chromium.org>

[Chromium] Test expectation update for r88757 and r88901.
https://bugs.webkit.org/show_bug.cgi?id=52920
https://bugs.webkit.org/show_bug.cgi?id=62685

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
6:32 AM Changeset in webkit [88923] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests.

  • platform/qt-mac/Skipped:
6:19 AM Changeset in webkit [88922] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: [Chromium] one line background color fix for inspector.

  • src/js/devTools.css: (body.detached.platform-mac-snowleopard #toolbar): (body.detached.platform-mac-snowleopard.inactive #toolbar):
6:17 AM Changeset in webkit [88921] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-14 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: LevelDB doesn't do incognito mode; fall back to SQLite.
https://bugs.webkit.org/show_bug.cgi?id=62633

LevelDB does not support in-memory databases. Fall back to SQLite
for incognito mode browsing. This will be tested by browser_tests
in Chromium.

  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
5:09 AM Changeset in webkit [88920] by apavlov@chromium.org
  • 5 edits in trunk

2011-06-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "data" URLs not detected in CSS url(...) values properly
https://bugs.webkit.org/show_bug.cgi?id=62643

WebCore:

  • inspector/front-end/inspector.js: (WebInspector.completeURL):

LayoutTests:

  • inspector/styles/styles-url-linkify-expected.txt:
  • inspector/styles/styles-url-linkify.html:
4:46 AM Changeset in webkit [88919] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped accessibility test failing in GTK.

Failing after r88830, filed bug 62335 for fixing this issue.

  • platform/gtk/Skipped: Skipped test.
4:31 AM Changeset in webkit [88918] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-06-15 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] errors in watches and in console are not rendered in red.
https://bugs.webkit.org/show_bug.cgi?id=62708

  • inspector/debugger/error-in-watch-expressions-expected.txt: Added.
  • inspector/debugger/error-in-watch-expressions.html: Added.

2011-06-15 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] errors in watches and in console are not rendered in red.
https://bugs.webkit.org/show_bug.cgi?id=62708

Test: inspector/debugger/error-in-watch-expressions.html

  • inspector/front-end/RemoteObject.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update.appendResult): (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
  • inspector/front-end/inspector.css: (.console-error-level .console-message-text, .console-error-level .section .header .title): (.console-formatted-object, .console-formatted-node):
4:02 AM Changeset in webkit [88917] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-06-15 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Remove unneeded constructor declaration added by mistake in r88800.

  • platform/gtk/GtkAuthenticationDialog.h:
3:38 AM Changeset in webkit [88916] by podivilov@chromium.org
  • 6 edits in trunk

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script select can be too wide.
https://bugs.webkit.org/show_bug.cgi?id=62701

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:

2011-06-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script select can be too wide.
https://bugs.webkit.org/show_bug.cgi?id=62701

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._displayNameForScriptURL): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
  • inspector/front-end/SourceFile.js:
3:03 AM Changeset in webkit [88915] by Csaba Osztrogonác
  • 2 edits
    403 adds in trunk/LayoutTests

Add Qt specific expected files for new passing tests introduced in r88913.

[Qt] css2.1/20110323/inline-non-replaced-height-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=62710

  • platform/qt/Skipped: Skip failing tests.
    • css2.1/20110323/inline-non-replaced-height-002.htm
    • css2.1/20110323/inline-non-replaced-height-003.htm
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-018-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-019-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-021-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-025-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-026-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-028-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-032-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-033-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-035-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-height-036-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.txt: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-height-016-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-non-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-non-replaced-width-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-height-007-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-011-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-012-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-013-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.txt: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/qt/css2.1/20110323/replaced-min-max-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Added.
  • platform/qt/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/qt/css2.1/20110323/width-replaced-element-001-expected.txt: Added.
1:24 AM Changeset in webkit [88914] by yurys@chromium.org
  • 4 edits
    3 adds in trunk

2011-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Worker object may be garbage collected if it doesn't send any messages
https://bugs.webkit.org/show_bug.cgi?id=62446

  • fast/workers/resources/worker-init.js: Added.
  • fast/workers/worker-init-expected.txt: Added.
  • fast/workers/worker-init.html: Added.

2011-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dmitry Titov.

[Chromium] Worker object may be garbage collected if it doesn't send any messages
https://bugs.webkit.org/show_bug.cgi?id=62446

Assume that WorkerContext has pending activity before explicit notification
is received from it. It prevents worker object from being collected before
the first message from its context is received.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::startWorkerContext): (WebKit::WebWorkerClientImpl::startWorkerContextInternal): (WebKit::WebWorkerClientImpl::startWorkerContextTask):
  • src/WebWorkerClientImpl.h:
1:02 AM Changeset in webkit [88913] by Nikolas Zimmermann
  • 17 edits
    660 adds in trunk

2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgi?id=15849

CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
https://bugs.webkit.org/show_bug.cgi?id=53099

Imported all CSS 2.1 tests named *replaced* and *intrinsic* (except the still failing background-intrinsic-*) tests.
All of these pass now, except block-non-replaced-width-008.htm which is unrelated to this patch.

  • css2.1/20110323: Added.
  • css2.1/20110323/absolute-non-replaced-height-001.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-002.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-003.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-004.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-005.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-006.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-007.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-008.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-009.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-010.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-011.htm: Added.
  • css2.1/20110323/absolute-non-replaced-height-012.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-001.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-002.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-003.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-004.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-005.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-006.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-007.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-008.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-009.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-010.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-011.htm: Added.
  • css2.1/20110323/absolute-non-replaced-max-height-012.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-001.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-002.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-003.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-004.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-005.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-006.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-007.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-008.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-009.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-010.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-011.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-012.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-013.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-014.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-015.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-016.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-017.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-018.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-019.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-020.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-021.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-022.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-023.htm: Added.
  • css2.1/20110323/absolute-non-replaced-width-024.htm: Added.
  • css2.1/20110323/absolute-replaced-height-001.htm: Added.
  • css2.1/20110323/absolute-replaced-height-002.htm: Added.
  • css2.1/20110323/absolute-replaced-height-003.htm: Added.
  • css2.1/20110323/absolute-replaced-height-004.htm: Added.
  • css2.1/20110323/absolute-replaced-height-005.htm: Added.
  • css2.1/20110323/absolute-replaced-height-007.htm: Added.
  • css2.1/20110323/absolute-replaced-height-008.htm: Added.
  • css2.1/20110323/absolute-replaced-height-009.htm: Added.
  • css2.1/20110323/absolute-replaced-height-010.htm: Added.
  • css2.1/20110323/absolute-replaced-height-011.htm: Added.
  • css2.1/20110323/absolute-replaced-height-012.htm: Added.
  • css2.1/20110323/absolute-replaced-height-014.htm: Added.
  • css2.1/20110323/absolute-replaced-height-016.htm: Added.
  • css2.1/20110323/absolute-replaced-height-017.htm: Added.
  • css2.1/20110323/absolute-replaced-height-018.htm: Added.
  • css2.1/20110323/absolute-replaced-height-019.htm: Added.
  • css2.1/20110323/absolute-replaced-height-021.htm: Added.
  • css2.1/20110323/absolute-replaced-height-022.htm: Added.
  • css2.1/20110323/absolute-replaced-height-023.htm: Added.
  • css2.1/20110323/absolute-replaced-height-024.htm: Added.
  • css2.1/20110323/absolute-replaced-height-025.htm: Added.
  • css2.1/20110323/absolute-replaced-height-026.htm: Added.
  • css2.1/20110323/absolute-replaced-height-028.htm: Added.
  • css2.1/20110323/absolute-replaced-height-029.htm: Added.
  • css2.1/20110323/absolute-replaced-height-030.htm: Added.
  • css2.1/20110323/absolute-replaced-height-031.htm: Added.
  • css2.1/20110323/absolute-replaced-height-032.htm: Added.
  • css2.1/20110323/absolute-replaced-height-033.htm: Added.
  • css2.1/20110323/absolute-replaced-height-035.htm: Added.
  • css2.1/20110323/absolute-replaced-height-036.htm: Added.
  • css2.1/20110323/absolute-replaced-width-001.htm: Added.
  • css2.1/20110323/absolute-replaced-width-006.htm: Added.
  • css2.1/20110323/absolute-replaced-width-008.htm: Added.
  • css2.1/20110323/absolute-replaced-width-013.htm: Added.
  • css2.1/20110323/absolute-replaced-width-015.htm: Added.
  • css2.1/20110323/absolute-replaced-width-020.htm: Added.
  • css2.1/20110323/absolute-replaced-width-022.htm: Added.
  • css2.1/20110323/absolute-replaced-width-027.htm: Added.
  • css2.1/20110323/absolute-replaced-width-029.htm: Added.
  • css2.1/20110323/absolute-replaced-width-034.htm: Added.
  • css2.1/20110323/absolute-replaced-width-036.htm: Added.
  • css2.1/20110323/absolute-replaced-width-041.htm: Added.
  • css2.1/20110323/absolute-replaced-width-043.htm: Added.
  • css2.1/20110323/absolute-replaced-width-048.htm: Added.
  • css2.1/20110323/absolute-replaced-width-050.htm: Added.
  • css2.1/20110323/absolute-replaced-width-055.htm: Added.
  • css2.1/20110323/absolute-replaced-width-057.htm: Added.
  • css2.1/20110323/absolute-replaced-width-062.htm: Added.
  • css2.1/20110323/absolute-replaced-width-064.htm: Added.
  • css2.1/20110323/absolute-replaced-width-069.htm: Added.
  • css2.1/20110323/absolute-replaced-width-071.htm: Added.
  • css2.1/20110323/absolute-replaced-width-076.htm: Added.
  • css2.1/20110323/abspos-non-replaced-width-margin-000-ref.htm: Added.
  • css2.1/20110323/abspos-non-replaced-width-margin-000.htm: Added.
  • css2.1/20110323/abspos-replaced-width-margin-000-ref.htm: Added.
  • css2.1/20110323/abspos-replaced-width-margin-000.htm: Added.
  • css2.1/20110323/block-non-replaced-height-001.htm: Added.
  • css2.1/20110323/block-non-replaced-height-002.htm: Added.
  • css2.1/20110323/block-non-replaced-height-003.htm: Added.
  • css2.1/20110323/block-non-replaced-height-004.htm: Added.
  • css2.1/20110323/block-non-replaced-height-005.htm: Added.
  • css2.1/20110323/block-non-replaced-height-006.htm: Added.
  • css2.1/20110323/block-non-replaced-height-007.htm: Added.
  • css2.1/20110323/block-non-replaced-height-008.htm: Added.
  • css2.1/20110323/block-non-replaced-height-009.htm: Added.
  • css2.1/20110323/block-non-replaced-height-010.htm: Added.
  • css2.1/20110323/block-non-replaced-height-011.htm: Added.
  • css2.1/20110323/block-non-replaced-height-012.htm: Added.
  • css2.1/20110323/block-non-replaced-height-013.htm: Added.
  • css2.1/20110323/block-non-replaced-height-014.htm: Added.
  • css2.1/20110323/block-non-replaced-height-015.htm: Added.
  • css2.1/20110323/block-non-replaced-height-016.htm: Added.
  • css2.1/20110323/block-non-replaced-width-001.htm: Added.
  • css2.1/20110323/block-non-replaced-width-002.htm: Added.
  • css2.1/20110323/block-non-replaced-width-003.htm: Added.
  • css2.1/20110323/block-non-replaced-width-004.htm: Added.
  • css2.1/20110323/block-non-replaced-width-005.htm: Added.
  • css2.1/20110323/block-non-replaced-width-006.htm: Added.
  • css2.1/20110323/block-non-replaced-width-007.htm: Added.
  • css2.1/20110323/block-non-replaced-width-008.htm: Added.
  • css2.1/20110323/block-replaced-height-001.htm: Added.
  • css2.1/20110323/block-replaced-height-002.htm: Added.
  • css2.1/20110323/block-replaced-height-003.htm: Added.
  • css2.1/20110323/block-replaced-height-004.htm: Added.
  • css2.1/20110323/block-replaced-height-005.htm: Added.
  • css2.1/20110323/block-replaced-height-007.htm: Added.
  • css2.1/20110323/block-replaced-width-001.htm: Added.
  • css2.1/20110323/block-replaced-width-006.htm: Added.
  • css2.1/20110323/float-non-replaced-height-001.htm: Added.
  • css2.1/20110323/float-non-replaced-width-001.htm: Added.
  • css2.1/20110323/float-non-replaced-width-002.htm: Added.
  • css2.1/20110323/float-non-replaced-width-003.htm: Added.
  • css2.1/20110323/float-non-replaced-width-004.htm: Added.
  • css2.1/20110323/float-non-replaced-width-005.htm: Added.
  • css2.1/20110323/float-non-replaced-width-006.htm: Added.
  • css2.1/20110323/float-non-replaced-width-007.htm: Added.
  • css2.1/20110323/float-non-replaced-width-008.htm: Added.
  • css2.1/20110323/float-non-replaced-width-009.htm: Added.
  • css2.1/20110323/float-non-replaced-width-010.htm: Added.
  • css2.1/20110323/float-non-replaced-width-011.htm: Added.
  • css2.1/20110323/float-non-replaced-width-012.htm: Added.
  • css2.1/20110323/float-replaced-height-001.htm: Added.
  • css2.1/20110323/float-replaced-height-002.htm: Added.
  • css2.1/20110323/float-replaced-height-003.htm: Added.
  • css2.1/20110323/float-replaced-height-004.htm: Added.
  • css2.1/20110323/float-replaced-height-005.htm: Added.
  • css2.1/20110323/float-replaced-height-007.htm: Added.
  • css2.1/20110323/float-replaced-width-001.htm: Added.
  • css2.1/20110323/float-replaced-width-002.htm: Added.
  • css2.1/20110323/float-replaced-width-003.htm: Added.
  • css2.1/20110323/float-replaced-width-004.htm: Added.
  • css2.1/20110323/float-replaced-width-005.htm: Added.
  • css2.1/20110323/float-replaced-width-006.htm: Added.
  • css2.1/20110323/float-replaced-width-011.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-height-001.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-height-002.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-width-001.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-width-002.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-width-003.htm: Added.
  • css2.1/20110323/inline-block-non-replaced-width-004.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-001.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-002.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-003.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-004.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-005.htm: Added.
  • css2.1/20110323/inline-block-replaced-height-007.htm: Added.
  • css2.1/20110323/inline-block-replaced-width-001.htm: Added.
  • css2.1/20110323/inline-block-replaced-width-006.htm: Added.
  • css2.1/20110323/inline-non-replaced-height-002.htm: Added.
  • css2.1/20110323/inline-non-replaced-height-003.htm: Added.
  • css2.1/20110323/inline-non-replaced-width-001.htm: Added.
  • css2.1/20110323/inline-non-replaced-width-002.htm: Added.
  • css2.1/20110323/inline-replaced-height-001.htm: Added.
  • css2.1/20110323/inline-replaced-height-002.htm: Added.
  • css2.1/20110323/inline-replaced-height-003.htm: Added.
  • css2.1/20110323/inline-replaced-height-004.htm: Added.
  • css2.1/20110323/inline-replaced-height-005.htm: Added.
  • css2.1/20110323/inline-replaced-height-007.htm: Added.
  • css2.1/20110323/inline-replaced-width-001.htm: Added.
  • css2.1/20110323/inline-replaced-width-006.htm: Added.
  • css2.1/20110323/inline-replaced-width-011.htm: Added.
  • css2.1/20110323/inline-replaced-width-012.htm: Added.
  • css2.1/20110323/inline-replaced-width-013.htm: Added.
  • css2.1/20110323/inline-replaced-width-014.htm: Added.
  • css2.1/20110323/inline-replaced-width-015.htm: Added.
  • css2.1/20110323/replaced-elements-001.htm: Added.
  • css2.1/20110323/replaced-intrinsic-001.htm: Added.
  • css2.1/20110323/replaced-intrinsic-002.htm: Added.
  • css2.1/20110323/replaced-intrinsic-003.htm: Added.
  • css2.1/20110323/replaced-intrinsic-004.htm: Added.
  • css2.1/20110323/replaced-intrinsic-005.htm: Added.
  • css2.1/20110323/replaced-intrinsic-ratio-001.htm: Added.
  • css2.1/20110323/replaced-min-max-001.htm: Added.
  • css2.1/20110323/resources: Added.
  • css2.1/20110323/resources/1x1-green.png: Added.
  • css2.1/20110323/resources/1x1-lime.png: Added.
  • css2.1/20110323/resources/1x1-red.png: Added.
  • css2.1/20110323/resources/abspos-replaced-width-margin-000-narrow.png: Added.
  • css2.1/20110323/resources/abspos-replaced-width-margin-000-wide.png: Added.
  • css2.1/20110323/resources/blue15x15.png: Added.
  • css2.1/20110323/resources/blue96x96.png: Added.
  • css2.1/20110323/resources/intrinsic-ratio.svg: Added.
  • css2.1/20110323/resources/replaced-intrinsic-001.svg: Added.
  • css2.1/20110323/resources/replaced-intrinsic-002.svg: Added.
  • css2.1/20110323/resources/replaced-intrinsic-003.svg: Added.
  • css2.1/20110323/resources/replaced-intrinsic-004.svg: Added.
  • css2.1/20110323/resources/replaced-intrinsic-005.svg: Added.
  • css2.1/20110323/resources/replaced-min-max-1.png: Added.
  • css2.1/20110323/resources/replaced-min-max-10.png: Added.
  • css2.1/20110323/resources/replaced-min-max-11.png: Added.
  • css2.1/20110323/resources/replaced-min-max-12.png: Added.
  • css2.1/20110323/resources/replaced-min-max-13.png: Added.
  • css2.1/20110323/resources/replaced-min-max-14.png: Added.
  • css2.1/20110323/resources/replaced-min-max-15.png: Added.
  • css2.1/20110323/resources/replaced-min-max-16.png: Added.
  • css2.1/20110323/resources/replaced-min-max-17.png: Added.
  • css2.1/20110323/resources/replaced-min-max-18.png: Added.
  • css2.1/20110323/resources/replaced-min-max-19.png: Added.
  • css2.1/20110323/resources/replaced-min-max-2.png: Added.
  • css2.1/20110323/resources/replaced-min-max-3.png: Added.
  • css2.1/20110323/resources/replaced-min-max-4.png: Added.
  • css2.1/20110323/resources/replaced-min-max-5.png: Added.
  • css2.1/20110323/resources/replaced-min-max-6.png: Added.
  • css2.1/20110323/resources/replaced-min-max-7.png: Added.
  • css2.1/20110323/resources/replaced-min-max-8.png: Added.
  • css2.1/20110323/resources/replaced-min-max-9.png: Added.
  • css2.1/20110323/resources/replaced-min-max.png: Added.
  • css2.1/20110323/resources/swatch-green.png: Added.
  • css2.1/20110323/resources/swatch-white.png: Added.
  • css2.1/20110323/resources/test-bl.png: Added.
  • css2.1/20110323/resources/test-br.png: Added.
  • css2.1/20110323/resources/test-tl.png: Added.
  • css2.1/20110323/resources/test-tr.png: Added.
  • css2.1/20110323/width-non-replaced-inline-001.htm: Added.
  • css2.1/20110323/width-replaced-element-001.htm: Added.
  • http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm: Added.
  • http/tests/misc/resources/intrinsic-ratio-slow.pl: Added.
  • http/tests/misc/resources/intrinsic-ratio.svg: Added.
  • platform/mac/css2.1/20110323: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-006-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-008-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-009-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-010-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-011-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-012-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-height-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-006-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-009-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-010-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-011-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-012-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-max-height-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-003-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-004-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-005-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-007-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-008-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-009-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-010-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-011-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-012-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-013-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-014-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-015-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-016-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-016-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-017-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-017-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-018-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-018-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-019-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-019-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-020-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-020-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-021-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-021-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-022-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-023-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-023-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-024-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-non-replaced-width-024-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-008-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-009-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-016-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-016-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-017-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-023-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-023-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-024-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-029-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-029-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-030-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-030-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-031-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-height-036-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-008-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-015-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-020-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-022-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-027-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-029-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-034-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-036-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-041-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-043-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-048-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-050-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-055-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-057-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-062-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-064-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-069-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-071-expected.txt: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/mac/css2.1/20110323/absolute-replaced-width-076-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Added.
  • platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-006-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-011-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-013-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-015-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-height-016-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-005-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-007-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
  • platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/block-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-003-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-004-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-005-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-007-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-008-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-008-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-009-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-009-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-010-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-010-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-011-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-012-expected.png: Added.
  • platform/mac/css2.1/20110323/float-non-replaced-width-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/mac/css2.1/20110323/float-replaced-width-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-003-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-004-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-non-replaced-width-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-block-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-width-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-non-replaced-width-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-002-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-006-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-011-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-011-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-012-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-012-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-013-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-013-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-014-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-014-expected.txt: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-015-expected.png: Added.
  • platform/mac/css2.1/20110323/inline-replaced-width-015-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/replaced-min-max-001-expected.png: Added.
  • platform/mac/css2.1/20110323/replaced-min-max-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.png: Added.
  • platform/mac/css2.1/20110323/width-non-replaced-inline-001-expected.txt: Added.
  • platform/mac/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/mac/css2.1/20110323/width-replaced-element-001-expected.txt: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/mac/svg/hixie/text/003-expected.png: Slight width difference, but a progression, exactly like FF now.
  • platform/mac/svg/hixie/text/003-expected.txt: Ditto.
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
  • svg/zoom/page/resources/intrinsic-ratio.svg: Added.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Added.

2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgi?id=15849

CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
https://bugs.webkit.org/show_bug.cgi?id=53099

Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/test_files.py:

2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

CSS 2.1: Support replaced elements with relative intrinsic sizes
https://bugs.webkit.org/show_bug.cgi?id=15849

CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
https://bugs.webkit.org/show_bug.cgi?id=53099

Generalize the recently added SVG specific host <-> embedded document size-negotiation used
to support embedding SVGs with intrinsic ratio/size via <iframe>/<object>/<embed> from
RenderPart right into RenderReplaced. It will be used to share the size-negotiation logic
with RenderImage, which still has its own way to negotiate with the embedded SVG to figure
out its size (and it's broken in several ways).

This fully implements intrinsic size/ratio support for replaced elements, as specified in:
http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width
http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height

RenderImage has not yet been converted to use the new size negotiation logic, this is just
the ground work. As soon as this is done all ways of embedding SVG is unified in a single
way: the same size negotiation logic used for object/embed/iframe/img for SVG documents.

To use it for non-SVG target documents, it's just a matter of implementing
"RenderBox* embeddedContentBox()" which needs to return the root renderer of the embedded document.
For SVG it's the embedded document RenderSVGRoot renderer, associated with the outermost <svg> element.
It's easy to implement this for embedded MathML documents or PDF documents now, if needed.

Imported all CSS 2.1 tests named *replaced* and *intrinsic* tests, except the still failing background-intrinsic-*
which embed SVGs through background-image or <img>, which still use the old size-negotiation logic.

Tests: css2.1/20110323/* (203 tests + support files)

svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm (same as replaced-intrinsic-ratio-001.htm, but zooms in a few times, to see whether all boxes react properly)
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm (same as replaced-intrinsic-ratio-001.htm, but with delayed loading of the SVG to test late-size-negotiation)

This fixes:
css2.1/20110323/replaced-intrinsic-ratio-001.htm
css2.1/20110323/replaced-intrinsic-003.htm
css2.1/20110323/block-replaced-height-007.htm
css2.1/20110323/float-replaced-height-007.htm
css2.1/20110323/inline-block-replaced-height-007.htm
css2.1/20110323/inline-replaced-height-007.htm

We're now the first to properly handle replaced-intrinsic-ratio-001.htm out of Opera/FF/IE9 :-)
This is an important piece of embedding SVGs though, so glad that we finally have it.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Use new helper needsPreferredWidthsRecalculation() to figure out whether pref widths need to be calculated. (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::needsPreferredWidthsRecalculation): Refactored and extended from RenderBlock*. We have to recalculate pref widths upon layout

if we embed a document with an intrinsic ratio/size, extensively covered by
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm

  • rendering/RenderBox.h: (WebCore::RenderBox::computeIntrinsicRatioInformation): New virtual function, only implemented in RenderPart so far. This generalizes the existing method from RenderPart.
  • rendering/RenderPart.cpp: (WebCore::RenderPart::needsPreferredWidthsRecalculation): Always recompute pref widths of we have an embeddedContentBox() - it may depend on our size. (WebCore::RenderPart::embeddedContentBox): Return the RenderSVGRoot box of the embedded SVG document, if we're embedded through object/embed/iframe (soon img as well).
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): New helper function, that either returns a fixed intrinsic size (set by a class inheriting from us) or the embedded target document size. (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. (WebCore::RenderReplaced::computeReplacedLogicalWidth): Full implementation of: 10.3.2 Inline, replaced elements: http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width. (WebCore::RenderReplaced::computeReplacedLogicalHeight): Full implementation of: 10.6.2 Inline, replaced elements: http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::embeddedContentBox):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix problem when zooming replaced-intrinsic-ratio-001.htm: if ownerWidth is auto, don't apply style()->effectiveZoom() twice. (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto for ownerHeight auto.
  • rendering/svg/RenderSVGRoot.h: Mark 'computeIntrinsicRatioInformation' virtual.
12:51 AM Changeset in webkit [88912] by Carlos Garcia Campos
  • 4 edits
    2 adds in trunk/Tools

2011-06-15 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add a statusbar to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=62634

It shows the url of the current hovered link.

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): Create the GtkSatusbar. (mouseDidMoveOverElement): Update statusbar text. (browserWindowUIClientInit): Add implementation for mouseDidMoveOverElement().
  • MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
  • MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added. (mouseDidMoveOverElement): Pass the url of the current hovered link to the UI process. (didCreatePage): Set the UI client adding an implementation for mouseDidMoveOverElement(). (WKBundleInitialize):
  • MiniBrowser/gtk/main.c: (createWKContextWithInjectedBundle): Create a global context with the injected bundle. (loadURI): Use the global context. (main):
12:08 AM Changeset in webkit [88911] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Fixed an inavlid ASSERT I found while investigating
<rdar://problem/9580254> Crash in JSC::HandleHeap::finalizeWeakHandles + 92
https://bugs.webkit.org/show_bug.cgi?id=62699

No test since we don't know of a way to get WebCore to deallocate the
next-to-finalize handle, which is also the last handle in the list,
while finalizing the second-to-last handle in the list.

  • heap/HandleHeap.h: (JSC::HandleHeap::deallocate): Don't ASSERT that m_nextToFinalize has a non-0 next() after updating it, since it is valid to update m_nextToFinalize to point to the tail sentinel.


Do ASSERT that m_nextToFinalize has a non-0 next() before updating it,
since it is not valid to update m_nextToFinalize to point past the tail
sentinel.


Also, use m_nextToFinalize consistently for clarity.

12:02 AM Changeset in webkit [88910] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-15 Kent Tamura <tkent@chromium.org>

[Win] Update expectation for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/win-xp/media/audio-repaint-expected.txt:

Jun 14, 2011:

11:27 PM Changeset in webkit [88909] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Update platform specific expected file.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
11:24 PM Changeset in webkit [88908] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

2011-06-09 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ShadowContentElement should detach its inclusions before attaching them.
https://bugs.webkit.org/show_bug.cgi?id=62428

  • On ShadowContentElement::attach(), changed inclusion attach scheme from per-node reattach() to detach()-all-and-attach()-them. This eliminates attach() order problems which ShadowContentElement possibly has.
  • Changed ShadowContentElement to have m_inclusions as a member variable, which will be used by upcoming changes.
  • Moved attach() code from ShadowContentSelector to ShadowContentElement because the element now owns the inclusion list.

No new tests. No visible behavioral change yet.

  • dom/ShadowContentElement.cpp: (WebCore::ShadowContentElement::attach): (WebCore::ShadowContentElement::detach): Added.
  • dom/ShadowContentElement.h: (WebCore::ShadowContentElement::inclusionAt): Added. (WebCore::ShadowContentElement::inclusionCount): Added. (WebCore::toShadowContentElement):
  • dom/ShadowContentSelector.cpp: Removed attachChildrenFor() (WebCore::ShadowContentSelector::selectInclusion): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::willAttachContentFor): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::didAttachContent): Extracted from attachChildrenFor() (WebCore::ShadowContentSelector::activeElement):
  • dom/ShadowContentSelector.h:
11:13 PM Changeset in webkit [88907] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-14 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Sam Weinig.

[EFL][WK2] Change string operation to makeString()
https://bugs.webkit.org/show_bug.cgi?id=62527

Use makeString() because it is better than creating individual strings and concatenating them.

  • UIProcess/efl/WebPageProxyEfl.cpp: (WebKit::WebPageProxy::standardUserAgent):
10:29 PM Changeset in webkit [88906] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-14 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Follow up for Callers should be robust against WebImage::create() returning an image with a null snapshot
https://bugs.webkit.org/show_bug.cgi?id=62666

  • Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage): (WKImageCreateFromCGImage): Don't null check the arguments (as per our API design) or the direct result of WebImage::create.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): Remove redundant check and make not being able to create a handle the same as not being backed by shareable memory.
9:37 PM Changeset in webkit [88905] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/62677> Part 2/2: Remove duplicate header entries in WebCore project file

Reviewed by Darin Adler.

Most of the DOMSVG*.h headers were added in late 2006, and then
duplicated by late 2007. They've been in the tree a long time.

  • WebCore.xcodeproj/project.pbxproj: Let Xcode 4 remove

duplicate header entries.

9:37 PM Changeset in webkit [88904] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/62677> Part 1/2: Remove duplicate header entries in WebCore project file

Reviewed by Darin Adler.

These headers were added as duplicates in r83256:

DefaultAudioDestinationNode.h
JSOfflineAudioCompletionEvent.h
OfflineAudioCompletionEvent.h
OfflineAudioDestinationNode.h

The following duplicates were introduced in r84053 (after having
been originally added in r83729):

StorageInfo.h
StorageInfoErrorCallback.h
StorageInfoQuotaCallback.h
StorageInfoUsageCallback.h

  • WebCore.xcodeproj/project.pbxproj: Remove duplicates using

'uniq' since sort-Xcode-project-file did most of the work.

8:51 PM Changeset in webkit [88903] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62693>
<rdar://problem/9601436>
windowsKeyCodeForKeyEvent should be robust against NSFlagsChanged events

Reviewed by Ada Chan.

  • Shared/mac/WebEventFactory.mm:

(WebKit::windowsKeyCodeForKeyEvent):
Explicitly check for NSFlagsChanged before calling -charactersIgnoringModifiers, since
charactersIgnoringModifiers throws an exception for NSFlagsChanged events.

8:44 PM Changeset in webkit [88902] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Skip editing/inserting/return-key-span-start.html added by r88890 on Mac WebKit2
since TestRunner doesn't implement eventSender.keyDown.

  • platform/mac-wk2/Skipped:
8:41 PM Changeset in webkit [88901] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-14 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

REGRESSION(r88757): [Chromium] Vertical position of media slider thumb is wrong.
https://bugs.webkit.org/show_bug.cgi?id=62685

No new tests. Covered by existing tests.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Center the thumb position.
  • rendering/RenderSlider.h:
8:27 PM Changeset in webkit [88900] by Lucas Forschler
  • 1 add in branches/safari-534-branch/Tools/BuildSlaveSupport/kill-old-processes

Merge r88857.

8:26 PM Changeset in webkit [88899] by Lucas Forschler
  • 1 edit in branches/safari-534-branch/Tools/ChangeLog

Merge r88857.

7:58 PM Changeset in webkit [88898] by kbr@google.com
  • 12 edits
    6 copies in branches/chromium/782

Merge 88489 - 2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated WebGL implementation to track recent spec updates in this area.

Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html

http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:

2011-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257

Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.

Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
  • http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7171012

7:41 PM Changeset in webkit [88897] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Change color initialization with clear color constant
https://bugs.webkit.org/show_bug.cgi?id=62691

Some color values are initialized by rbg value. Color constant value is more clear than
rgb value.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl):
7:40 PM Changeset in webkit [88896] by jchaffraix@webkit.org
  • 9 edits in trunk

2011-06-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48293

And

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48303

  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt: Added a trailing line.
  • fast/canvas/canvas-composite-alpha.html: Updated now that we clear what is outside the source.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped: Update platform skipped lists.

2011-06-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by James Robinson.

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48293

And

Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48303

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationIn as this is the only one that needs a specific treatment.
7:10 PM Changeset in webkit [88895] by takano.naoki@gmail.com
  • 2 edits
    1 add in trunk/Source/WebCore

2011-06-14 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Forward modifiers + up/down key events to text field when autofill popup window is shown.
https://bugs.webkit.org/show_bug.cgi?id=62350
http://code.google.com/p/chromium/issues/detail?id=61349

Manual test: autofill-popup-shiftupdown.html

  • manual-tests/chromium/autofill-popup-shiftupdown.hml: Added to check modifier + up/down key is working correctly for text area in autofill popup is shown.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent): Check modifier key and menu style to decide if the event should be forwarded or not.
7:03 PM Changeset in webkit [88894] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

GTK rebaseline for r88883.

  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
6:57 PM Changeset in webkit [88893] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

6:56 PM Changeset in webkit [88892] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=43841
SegmentedVector::operator== typo

Reviewed by Sam Weinig.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVectorIterator::operator==):
(WTF::SegmentedVectorIterator::operator!=):

6:56 PM Changeset in webkit [88891] by Lucas Forschler
  • 1 copy in tags/Safari-534.46

New tag.

6:51 PM Changeset in webkit [88890] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-14 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Span ID duplicated when pressing enter at beginning of span
https://bugs.webkit.org/show_bug.cgi?id=62621

Added test for span id not getting duplicated when span is cloned.

  • editing/inserting/return-key-span-start-expected.txt: Added.
  • editing/inserting/return-key-span-start.html: Added.

2011-06-14 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Span ID duplicated when pressing enter at beginning of span
https://bugs.webkit.org/show_bug.cgi?id=62621

Strip id from cloned span, so that it is not duplicated.

Test: editing/inserting/return-key-span-start.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
6:33 PM Changeset in webkit [88889] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Mac, Windows, and Chromium rebaseline for r88883.

  • platform/chromium-linux/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/win/fast/forms/basic-textareas-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
6:13 PM Changeset in webkit [88888] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-14 Kent Tamura <tkent@chromium.org>

[Chromium][Qt] Assign new bug numbers for slider failures, and skip a test on Qt.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
6:11 PM Changeset in webkit [88887] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed. Fixing skip list.

VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

  • platform/mac-leopard/Skipped:
5:48 PM Changeset in webkit [88886] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use new byte array encoding/decoding functions for WTF argument coders
https://bugs.webkit.org/show_bug.cgi?id=62682

  • Platform/CoreIPC/ArgumentCoders.cpp: (CoreIPC::::encode): (CoreIPC::::decode): Use the new functions for the string argument coders.


  • Platform/CoreIPC/ArgumentCoders.h: (CoreIPC::SimpleArgumentCoder::encode): (CoreIPC::SimpleArgumentCoder::decode): Use the new functions to avoid encoding/decoding the size when it's known at decode time.
  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::roundUpToAlignment): Assert that the alignment is a power of 2.

(CoreIPC::decodeFixedLengthData):
Alignment comes before the size.

  • UIProcess/cf/WebBackForwardListCF.cpp: (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Add a FIXME about now using the internal CoreIPC encoding format here.
  • UIProcess/cf/WebPageProxyCF.cpp: Bump the current session state data version number.
5:26 PM Changeset in webkit [88885] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source/WebKit2

Merge r88856.

5:24 PM Changeset in webkit [88884] by Lucas Forschler
  • 8 edits in branches/safari-534-branch/Source

Merge r88833.

5:19 PM Changeset in webkit [88883] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Trailing tabs in a textarea become unselectable under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=54598

The bug was caused by WebKit's erroneously collapsing leading whitespace when white-space is
set to pre-wrap. Per CSS 2.1 spec section 16.1.1, leading whitespace should not be removed
in this case.

See also: http://www.w3.org/TR/CSS2/text.html#white-space-model

Fixed the bug by adding an extra argument to shouldCollapseWhiteSpace, indicating whether
whitespace is leading or trailing. It defaults to leading because 16.1.1 does not allow allow
collapsing of whitespace anywhere but at the end of each line.

Test: fast/text/pre-wrap-trailing-tab.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::shouldCollapseWhiteSpace): Added WhitespacePosition as an argument. Returns false when whitespacePosition is not TrailingWhitespace even if white-space is pre-wrap. (WebCore::requiresLineBox): Takes WhitespacePosition as an argument and passes it to shouldCollapseWhiteSpace. (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Calls requiresLineBox. (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): Ditto. (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Ditto.

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

Trailing tabs in a textarea become unselectable under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=54598

Added a test to ensure Webkit renders leading whitespace when white-space is set to pre-wrap
and word-wrap is set to break-word.

Also rebaselined few tests because WebKit now renders leading whitespace in those tests.

  • fast/text/pre-wrap-trailing-tab-expected.txt: Added.
  • fast/text/pre-wrap-trailing-tab.html: Added.
  • http/tests/misc/acid3-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt
5:15 PM Changeset in webkit [88882] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/WebKit2

Merge r88735.

5:12 PM Changeset in webkit [88881] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/WebKit2

Merge r88607.

5:12 PM Changeset in webkit [88880] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source/WebKit2

2011-06-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Expose viewportVisibleRect(), so that we can detect which parts of a texture actually
need to be uploaded.

Together with Viatcheslav Ostapenko.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::viewportVisibleRect):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::viewportVisibleRect):
5:12 PM Changeset in webkit [88879] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-14 Ryosuke Niwa <rniwa@webkit.org>

Qt rebaseline after r88757.

  • platform/qt/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.txt:
5:11 PM Changeset in webkit [88878] by Lucas Forschler
  • 6 edits
    3 copies in branches/safari-534-branch

Merge r88591.

5:09 PM Changeset in webkit [88877] by bdakin@apple.com
  • 6 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=62678
When the window is small enough, the scrollbars are misplaced with painting
artifacts, after changing the scrollbar appearance
-and corresponding-
<rdar://problem/9414015>

Reviewed by Dan Bernstein.

Get rid of the FrameView implementation of scrollbarStyleChanged(). Its approach
is just not good.

  • page/FrameView.cpp:
  • page/FrameView.h:

Implement scrollbarStyleChanged() on ScrollView instead. And just call
updatedScrollbars().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):

  • platform/ScrollView.h:

Invalidate the old scrollbar before changing it to the new scrollbar. This way
when the scrollbar gets smaller, the older, larger pieces still repaint properly.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

4:50 PM Changeset in webkit [88876] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source/WebCore

Merge r88685.

4:49 PM Changeset in webkit [88875] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r88677.

4:46 PM Changeset in webkit [88874] by Lucas Forschler
  • 6 edits in branches/safari-534-branch/Source

Merge r88654.

4:39 PM Changeset in webkit [88873] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658

Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addImmediateBuffer): (JSC::CodeBlock::immediateBuffer):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addImmediateBuffer): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_new_array_buffer):
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
4:35 PM Changeset in webkit [88872] by xan@webkit.org
  • 29 edits in trunk/Source/WebKit/gtk

2011-06-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove G_CONST_RETURN usage
https://bugs.webkit.org/show_bug.cgi?id=62673

Change G_CONST_RETURN for a simple "const" throughout the
codebase, since G_CONST_RETURN is deprecated now. This should be
totally equivalent since for all practical purposes the macro is
always expanded to const.

  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_get_database_directory_path): use const instead of G_CONST_RETURN.
  • webkit/webkitapplicationcache.h:
  • webkit/webkiticondatabase.cpp: (webkit_icon_database_get_path): ditto.
  • webkit/webkiticondatabase.h:
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_uri): ditto.
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_get_uri): ditto.
  • webkit/webkitnetworkresponse.h:
  • webkit/webkitsecurityorigin.cpp: (webkit_security_origin_get_protocol): ditto. (webkit_security_origin_get_host): ditto.
  • webkit/webkitsecurityorigin.h:
  • webkit/webkitwebdatabase.cpp: (webkit_web_database_get_name): ditto. (webkit_web_database_get_display_name): ditto. (webkit_web_database_get_filename): ditto. (webkit_get_web_database_directory_path): ditto.
  • webkit/webkitwebdatabase.h:
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_get_encoding): ditto. (webkit_web_data_source_get_unreachable_uri): ditto.
  • webkit/webkitwebdatasource.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_title): ditto. (webkit_web_frame_get_uri): ditto. (webkit_web_frame_get_name): ditto.
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_get_title): ditto. (webkit_web_history_item_get_alternate_title): ditto. (webkit_web_history_item_get_uri): ditto. (webkit_web_history_item_get_original_uri): ditto. (webkit_web_history_item_get_target): ditto.
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebhistoryitemprivate.h:
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_target_frame): ditto.
  • webkit/webkitwebnavigationaction.h:
  • webkit/webkitwebresource.cpp: (webkit_web_resource_get_uri): ditto. (webkit_web_resource_get_mime_type): ditto. (webkit_web_resource_get_encoding): ditto. (webkit_web_resource_get_frame_name): ditto.
  • webkit/webkitwebresource.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_get_user_agent): ditto.
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_title): ditto. (webkit_web_view_get_uri): ditto. (webkit_web_view_get_icon_uri): ditto.
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewcommon.h:
4:29 PM Changeset in webkit [88871] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Michael Saboff <msaboff@apple.com>

Reviewed by Joseph Pecoraro.

Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
https://bugs.webkit.org/show_bug.cgi?id=62649

Take 2.
The #ifdef DISPATCH_VM_PRESSURE doesn't work. Combined the code
inside this #ifdef with the prior #ifndef DISPATCH_SOURCE_TYPE_VM.

No functional changes, fixing build issue therefore no tests.

  • platform/mac/MemoryPressureHandlerMac.mm:
4:25 PM Changeset in webkit [88870] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Start using the new encode/decode functions
https://bugs.webkit.org/show_bug.cgi?id=62676

  • Platform/CoreIPC/DataReference.cpp: (CoreIPC::DataReference::encode): Use encodeVariableLengthByteArray.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): Use encodeVariableLengthByteArray and the new dataReference accessors.

(WebKit::UserMessageDecoder::baseDecode):
Use decodeVariableLengthByteArray.


  • Shared/WebData.h: (WebKit::WebData::dataReference): Return a reference to the data.
  • Shared/WebSerializedScriptValue.h: (WebKit::WebSerializedScriptValue::dataReference): Ditto.
  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::encode): Use encodeVariableLengthByteArray.
  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::Handle::encode): Use encodeVariableLengthByteArray.
  • WebProcess/WebPage/DecoderAdapter.cpp: (WebKit::DecoderAdapter::decodeBytes): Use decodeVariableLengthByteArray.
  • WebProcess/WebPage/EncoderAdapter.cpp: (WebKit::EncoderAdapter::dataReference): Rename data() to dataReference() to indicate that it returns a reference to the data.

(WebKit::EncoderAdapter::encodeBytes):
Use encodeVariableLengthByteArray.

4:13 PM Changeset in webkit [88869] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add encodeVariableLengthByteArray and decodeVariableLengthByteArray
https://bugs.webkit.org/show_bug.cgi?id=62674

Rename the ArgumentDecoder::decodeBytes overload that takes a DataReference to
decodeVariableLengthByteArray, to match the added encodeVariableLengthByteArray.

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::decodeVariableLengthByteArray):
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp: (CoreIPC::ArgumentEncoder::encodeFixedLengthData): (CoreIPC::ArgumentEncoder::encodeVariableLengthByteArray):
  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/DataReference.cpp: (CoreIPC::DataReference::decode):
  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::Handle::decode):
4:09 PM Changeset in webkit [88868] by Lucas Forschler
  • 6 edits in branches/safari-534-branch/Source/WebCore

Merge r88653.

4:06 PM Changeset in webkit [88867] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r88647.

4:05 PM Changeset in webkit [88866] by commit-queue@webkit.org
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88841.
http://trac.webkit.org/changeset/88841
https://bugs.webkit.org/show_bug.cgi?id=62672

Caused many tests to crash (Requested by rniwa on #webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_array):
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
4:05 PM Changeset in webkit [88865] by cevans@google.com
  • 4 edits
    4 copies in branches/chromium/782

Merge 88601
BUG=85302
Review URL: http://codereview.chromium.org/7169001

4:05 PM Changeset in webkit [88864] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88629.

4:03 PM Changeset in webkit [88863] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source

Merge r88599.

4:02 PM Changeset in webkit [88862] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebKit2

Merge r88588.

4:00 PM Changeset in webkit [88861] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Merge r88585.

3:57 PM Changeset in webkit [88860] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add functions for converting between DataReferences and vectors
https://bugs.webkit.org/show_bug.cgi?id=62671

  • Platform/CoreIPC/DataReference.h: (CoreIPC::DataReference::DataReference): New implicit constructor that takes a vector.

(CoreIPC::DataReference::vector):
New function that returns a new vector.

  • Shared/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::encode): Use implicit constructor.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScriptInMainFrame): Ditto.
3:57 PM Changeset in webkit [88859] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r88528.

3:54 PM Changeset in webkit [88858] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87834.

3:23 PM Changeset in webkit [88857] by Lucas Forschler
  • 1 edit
    1 move in trunk/Tools

2011-06-14 Lucas Forschler <Lucas Forschler>

Reviewed by Stephanie Lewis.

https://bugs.webkit.org/show_bug.cgi?id=62495
Bug 62495 - combine windows and mac kill-old-processes script
Add a platform agnostic script. Remove the recently added mac flavor.
Note: Leaving the windows one alone, since it is currently used by the WebKit bots.

  • BuildSlaveSupport/kill-old-processes: Added.
  • BuildSlaveSupport/mac: Removed.
  • BuildSlaveSupport/mac/kill-old-processes: Removed.
3:18 PM Changeset in webkit [88856] by sullivan@apple.com
  • 4 edits in trunk/Source/WebKit2

<https://bugs.webkit.org/show_bug.cgi?id=62666>
<rdar://problem/9606676>
Callers should be robust against WebImage::create() returning an image with a null snapshot

Reviewed by Dan Bernstein.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateCGImage):
Return 0 if no bitmap was created.
(WKImageCreateFromCGImage):
Ditto.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
Check for null before dereferencing image->bitmap() in two places.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
Return 0 if no bitmap was created.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):
Ditto.
(WebKit::WebPage::createSnapshotOfVisibleContent):
Bail out if no bitmap was created.

3:07 PM Changeset in webkit [88855] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-14 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Turns out, inspector/cookie-parser.html can timeout out.

  • platform/chromium/test_expectations.txt: Added expectation of TIMEOUT.
2:51 PM Changeset in webkit [88854] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-14 Jeffrey Pfau <jpfau@apple.com>

Reviewed by David Hyatt.

Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028

Added test for spanning elements within an inline-block child of a multicol element.

  • fast/multicol/span/span-as-nested-inline-block-child.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.

2011-06-14 Jeffrey Pfau <jpfau@apple.com>

Reviewed by David Hyatt.

Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028

Ensure that the parent block of a spanning element, if it is not itself
a multicol element, is not inline.

Test: fast/multicol/span/span-as-nested-inline-block-child.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::columnsBlockForSpanningElement):
2:39 PM Changeset in webkit [88853] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add functions for encoding/decoding data with a known size and alignment
https://bugs.webkit.org/show_bug.cgi?id=62663

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::decodeFixedLengthData):
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp: (CoreIPC::ArgumentEncoder::encodeFixedLengthData): (CoreIPC::ArgumentEncoder::encodeVariableLengthData):
  • Platform/CoreIPC/ArgumentEncoder.h:
2:24 PM Changeset in webkit [88852] by vangelis@chromium.org
  • 2 edits
    3 copies in branches/chromium/742

Merge 88288 - 2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Add a test to verify that RTL pages that trigger the compositor
render correctly.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • compositing/geometry/rtl-composited-expected.png: Added.
  • compositing/geometry/rtl-composited-expected.txt: Added.
  • compositing/geometry/rtl-composited.html: Added.

2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

Disable compositing for RTL pages in the RenderLayerCompositor rather
than later on in the WebViewImpl.
https://bugs.webkit.org/show_bug.cgi?id=62246

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::setRootGraphicsLayer):

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7163005

1:51 PM Changeset in webkit [88851] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-14 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Record expectation of crash for inspector/cookie-parser.html.

  • platform/chromium/test_expectations.txt: Recorded.
1:50 PM Changeset in webkit [88850] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 87439
BUG=83270
Review URL: http://codereview.chromium.org/7166003

1:41 PM Changeset in webkit [88849] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/742

Merge 87171
BUG=83270
Review URL: http://codereview.chromium.org/7111053

1:36 PM Changeset in webkit [88848] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-06-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: handle worker exceptions cleanly
https://bugs.webkit.org/show_bug.cgi?id=62614

This change modifiers new-run-webkit-tests to handle exceptions
raised by worker threads better, by:

  • capturing the worker's stack and logging it in the manager
  • propagating the worker's exception in the caller correctly
  • attempting to cancel the workers and clean up even when we get an unexpected exception
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1:35 PM Changeset in webkit [88847] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation)
https://bugs.webkit.org/show_bug.cgi?id=62655

No new tests; we don't have any media-engine specific tests.

AVAssetImageGenerator will, by default, return the nearest keyframe. To get the generator to return
the image from the current time instead of the nearest keyframe, set the requested time tolerance to
zero (which defaults to infinity).

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
1:20 PM Changeset in webkit [88846] by andersca@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move string ArgumentCoder template specializations out into a .cpp file
https://bugs.webkit.org/show_bug.cgi?id=62660

  • GNUmakefile.am:
  • Platform/CoreIPC/ArgumentCoders.cpp: Added. (CoreIPC::::encode): (CoreIPC::::decode):
  • Platform/CoreIPC/ArgumentCoders.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
1:09 PM Changeset in webkit [88845] by cevans@google.com
  • 2 edits in branches/chromium/742/Source

Merge 87103
BUG=83270
Review URL: http://codereview.chromium.org/7155005

1:01 PM Changeset in webkit [88844] by ericu@chromium.org
  • 23 edits in trunk/Source

2011-06-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218

Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs.

No new tests--no change in functionality.

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createWriter): (WebCore::DOMFileSystem::createFile):
  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::getMetadata): (WebCore::DOMFileSystemBase::move): (WebCore::DOMFileSystemBase::copy): (WebCore::DOMFileSystemBase::remove): (WebCore::DOMFileSystemBase::removeRecursively): (WebCore::DOMFileSystemBase::getParent): (WebCore::DOMFileSystemBase::getFile): (WebCore::DOMFileSystemBase::getDirectory): (WebCore::DOMFileSystemBase::readDirectory):
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): (WebCore::DOMFileSystemSync::createWriter):
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::AsyncFileSystem):

2011-06-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Clean up filesystem base path code.
https://bugs.webkit.org/show_bug.cgi?id=60218

Change a bunch of url-held-in-a-string parameters into real KURLS and
WebURLs. Also add a #define to make it easier to stage this change, as
it involves both Chromium and WebKit changes that would ideally be
simultaneous.

No new tests--no change in functionality.

  • public/WebFileSystem.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFrame.h:
  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileSystemChromium.h:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:
  • src/WorkerFileWriterCallbacksBridge.h:
12:54 PM Changeset in webkit [88843] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed.

VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Tables are not supported on Leopard for accessibility.

  • platform/mac-leopard/Skipped:
12:37 PM Changeset in webkit [88842] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove PluginInfoStore::Plugin typedef
https://bugs.webkit.org/show_bug.cgi?id=62657

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
12:10 PM Changeset in webkit [88841] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Constant array literals result in unnecessarily large amounts of code
https://bugs.webkit.org/show_bug.cgi?id=62658

Add a new version of op_new_array that simply copies values from a buffer
we hang off of the CodeBlock, rather than generating code to place each
entry into the registerfile, and then copying it from the registerfile into
the array. This is a slight improvement on some sunspider tests, but no
measurable overall change. That's okay though as our goal was to reduce
code size without hurting performance.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addImmediateBuffer): (JSC::CodeBlock::immediateBuffer):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addImmediateBuffer): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ArrayNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_new_array_buffer):
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
11:48 AM Changeset in webkit [88840] by commit-queue@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-06-14 Wyatt Carss <wcarss@google.com>

Reviewed by Ryosuke Niwa.

dump-as-text conversion: editing/deleting/5300379.html
https://bugs.webkit.org/show_bug.cgi?id=62620

Converted from pixel test to dump-as-text. This tests that delete backward
by word does not hang inside an empty div, and that delete backward by word
deletes exactly one word.

  • editing/deleting/5300379-expected.txt: Added.
  • editing/deleting/5300379.html:
  • platform/chromium-win/editing/deleting/5300379-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/5300379-expected.png: Removed.
  • platform/gtk/editing/deleting/5300379-expected.txt: Removed.
  • platform/gtk/editing/deleting/5300379-expected.png: Removed.
  • platform/mac/editing/deleting/5300379-expected.txt: Removed.
  • platform/mac/editing/deleting/5300379-expected.png: Removed.
  • platform/qt/editing/deleting/5300379-expected.txt: Removed.
  • platform/qt/editing/deleting/5300379-expected.png: Removed.
11:45 AM Changeset in webkit [88839] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Create the PluginModuleInfo class and reverse the typedef so that PluginInfoStore::Plugin is now a typedef
https://bugs.webkit.org/show_bug.cgi?id=62654

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::findPluginForMIMEType): (WebKit::PluginInfoStore::findPluginForExtension): (WebKit::PluginInfoStore::findPlugin): (WebKit::PluginInfoStore::infoForPluginWithPath):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection):
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy):
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::getSitesWithData): (WebKit::WebPluginSiteDataManager::clearSiteData):
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::isOldWindowsMediaPlayerPlugin): (WebKit::isNewWindowsMediaPlayerPlugin): (WebKit::PluginInfoStore::shouldUsePlugin):
11:44 AM Changeset in webkit [88838] by qi.2.zhang@nokia.com
  • 5 edits in trunk

2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227

  • platform/qt/Skipped:

2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
https://bugs.webkit.org/show_bug.cgi?id=62227

QtWebkit does not yet support different CacheModels. This change will
expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:43 AM Changeset in webkit [88837] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 88549
BUG=85211
Review URL: http://codereview.chromium.org/7163002

11:42 AM Changeset in webkit [88836] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 88549
BUG=85211
Review URL: http://codereview.chromium.org/7149024

11:32 AM Changeset in webkit [88835] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-06-14 James Robinson <jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618

This fixes several issues causing slowdowns in compositor shader initialization, mostly due to lack of
parallelism:

  • Avoid initializing all programs eagerly. We only use two programs on every page, the other programs depend on content and are constructed on demand.
  • Defer querying uniform locations until draw time. For the eagerly constructed programs (render surface + tiler) this means that the GPU process has a chance to compile the shader while the renderer is busy painting+uploading instead of blocking on shader compilation in order to get uniform locations.
  • Calls to query COMPILE_STATUS/LINK_STATUS moved behind #ifndef NDEBUG guards since these should never fail in release builds and force synchronous compilation/linking.

This also adds a number of TRACE_EVENT()s to make analysing the performance of this bit of code easier.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::borderProgram): (WebCore::LayerRendererChromium::headsUpDisplayProgram): (WebCore::LayerRendererChromium::renderSurfaceProgram): (WebCore::LayerRendererChromium::renderSurfaceMaskProgram): (WebCore::LayerRendererChromium::tilerProgram): (WebCore::LayerRendererChromium::canvasLayerProgram): (WebCore::LayerRendererChromium::pluginLayerProgram): (WebCore::LayerRendererChromium::videoLayerRGBAProgram): (WebCore::LayerRendererChromium::videoLayerYUVProgram):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTextureSubImage.cpp: (WebCore::LayerTextureSubImage::uploadWithTexSubImage): (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
  • platform/graphics/chromium/ProgramBinding.cpp: (WebCore::ProgramBindingBase::init): (WebCore::ProgramBindingBase::loadShader): (WebCore::ProgramBindingBase::createShaderProgram):
  • platform/graphics/chromium/ProgramBinding.h: (WebCore::ProgramBinding::ProgramBinding): (WebCore::ProgramBinding::initialize):
  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::VertexShaderPosTex::init): (WebCore::VertexShaderPosTexYUVStretch::init): (WebCore::VertexShaderPos::init): (WebCore::VertexShaderPosTexTransform::init): (WebCore::FragmentTexAlphaBinding::init): (WebCore::FragmentShaderRGBATexAlphaMask::init): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderColor::init):
  • platform/graphics/chromium/ShaderChromium.h:

2011-06-14 James Robinson <jamesr@chromium.org>

Reviewed by Stephen White.

[chromium] Compositor shader initialization is inefficient
https://bugs.webkit.org/show_bug.cgi?id=62618

Add a TRACE_EVENT() around initial compositor initialization.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
11:31 AM Changeset in webkit [88834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-06-14 Claudio Saavedra <Claudio Saavedra>

Reviewed by Xan Lopez.

Broken reference to webkitsoupauthdialog.c
https://bugs.webkit.org/show_bug.cgi?id=62650

  • POTFILES: Fix reference to webkitsoupauthdialog.cpp
11:30 AM Changeset in webkit [88833] by slewis@apple.com
  • 8 edits in trunk/Source

<rdar://problem/9511169>
Update order files.

Rubber stamped by Oliver Hunt.

Source/JavaScriptCore:

Source/WebCore:

Build system change, no change in functionality so no new tests.

  • WebCore.order:

Source/WebKit/mac:

  • WebKit.order:

Source/WebKit2:

  • mac/WebKit2.order:
11:26 AM Changeset in webkit [88832] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 88434
BUG=85102
Review URL: http://codereview.chromium.org/7150019

11:25 AM Changeset in webkit [88831] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/782

Merge 88411
BUG=85102
Review URL: http://codereview.chromium.org/7163001

11:20 AM Changeset in webkit [88830] by Chris Fleizach
  • 4 edits
    2 adds in trunk

Source/WebCore: VoiceOver cannot navigate the iTunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Reviewed by David Kilzer.

This is a regression from https://bugs.webkit.org/show_bug.cgi?id=57463.
Part of that patch made a change so that an ARIA table will only look at it's children and grandchildren
for possible rows. That however, doesn't allow arbitrary hierarchies to work with ARIA, like in iTunes album view.

Test: platform/mac/accessibility/aria-grid-with-strange-hierarchy.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

LayoutTests: VoiceOver cannot navigate the itunes album view table
https://bugs.webkit.org/show_bug.cgi?id=62335

Reviewed by David Kilzer.

  • platform/mac/accessibility/aria-grid-with-strange-hierarchy-expected.txt: Added.
  • platform/mac/accessibility/aria-grid-with-strange-hierarchy.html: Added.
11:17 AM Changeset in webkit [88829] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88823.
http://trac.webkit.org/changeset/88823
https://bugs.webkit.org/show_bug.cgi?id=62652

Broke the Lion build (Requested by estes on #webkit).

  • platform/mac/MemoryPressureHandlerMac.mm:
11:16 AM Changeset in webkit [88828] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 88434
BUG=85102
Review URL: http://codereview.chromium.org/7162001

11:14 AM Changeset in webkit [88827] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/742

Merge 88411
BUG=85102
Review URL: http://codereview.chromium.org/7155003

11:05 AM Changeset in webkit [88826] by cevans@google.com
  • 1 edit in branches/chromium/782/Source/WebCore/platform/graphics/win/UniscribeController.cpp

Merge 88277
BUG=85256
Review URL: http://codereview.chromium.org/7104146

11:03 AM Changeset in webkit [88825] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Start replacing PluginInfoStore::Plugin with PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62651

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): (WebKit::PluginInfoStore::findPluginForMIMEType): (WebKit::PluginInfoStore::findPluginForExtension): (WebKit::PluginInfoStore::infoForPluginWithPath):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): (WebKit::PluginProcessManager::getSitesWithData): (WebKit::PluginProcessManager::clearSiteData): (WebKit::PluginProcessManager::getOrCreatePluginProcess):
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::create):
  • UIProcess/Plugins/PluginProcessProxy.h: (WebKit::PluginProcessProxy::pluginInfo):
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::pluginNeedsExecutableHeap): (WebKit::PluginProcessProxy::createPropertyListFile):
10:57 AM Changeset in webkit [88824] by Lucas Forschler
  • 12 edits
    2 copies in branches/safari-534-branch/Source/WebKit2

Merge r87831.

10:54 AM Changeset in webkit [88823] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Michael Saboff <msaboff@apple.com>

Reviewed by Joseph Pecoraro.

Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
https://bugs.webkit.org/show_bug.cgi?id=62649

The #ifdef DISPATCH_VM_PRESSURE actually needs to be #ifndef
to handle when DISPATCH_VM_PRESSURE is NOT defined in the
system header files.

No functional changes, fixing build issue therefore no tests.

  • platform/mac/MemoryPressureHandlerMac.mm:
10:44 AM Changeset in webkit [88822] by enne@google.com
  • 5 edits
    2 adds in trunk

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607

  • platform/chromium/compositing/huge-mask-layer-expected.txt: Added.
  • platform/chromium/compositing/huge-mask-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Disable drawing for huge mask layers
https://bugs.webkit.org/show_bug.cgi?id=62607

Because masks have a different layer size than the layer they are
masking, they are untiled. If they are too large to be contained
within a single texture, then they should just be disabled.

Test: platform/chromium/compositing/huge-mask-layer.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::drawsContent): (WebCore::ContentLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::getSingleTexture): (WebCore::LayerTilerChromium::numTiles):
10:41 AM Changeset in webkit [88821] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix dumping of constants to have the correct constant number.

Reviewed by Geoffrey Garen.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

10:40 AM Changeset in webkit [88820] by Lucas Forschler
  • 7 edits
    1 copy in branches/safari-534-branch/Source/WebKit2

Merge r87806.

10:37 AM Changeset in webkit [88819] by andersca@apple.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

2011-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add PluginModuleInfo header and prepare for renaming of PluginInfoStore::Plugin to PluginModuleInfo
https://bugs.webkit.org/show_bug.cgi?id=62647

Make PluginModuleInfo a typedef of PluginInfoStore::Plugin for now; eventually it should be its own class,
and PluginInfoStore::Plugin should go away.

  • GNUmakefile.am:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::getPluginArchitecture): (WebKit::getMIMETypesFromPluginBundle): (WebKit::getPluginInfoFromPropertyLists): (WebKit::getPluginInfoFromCarbonResources): (WebKit::NetscapePluginModule::getPluginInfo): (WebKit::NetscapePluginModule::determineQuirks):
  • Shared/Plugins/PluginModuleInfo.cpp: Added.
  • Shared/Plugins/PluginModuleInfo.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:34 AM Changeset in webkit [88818] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534-branch/Source/WebKit2

Merge r87805.

10:20 AM Changeset in webkit [88817] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-14 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for flaky tests.

  • platform/chromium/test_expectations.txt: Recorded flakiness.
10:13 AM Changeset in webkit [88816] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] GraphicsLayer: support plugins on symbian
https://bugs.webkit.org/show_bug.cgi?id=57418

Implement graphics layer for plugins on Symbian.

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::shouldUseAcceleratedCompositing): (WebCore::PluginView::platformStart):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt): (WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt): (WebCore::PluginGraphicsLayerQt::paint): (WebCore::PluginView::shouldUseAcceleratedCompositing): (WebCore::PluginView::paint): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformLayer):
10:03 AM Changeset in webkit [88815] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359

Tests that console messages are preserved upon navigation.

  • inspector/console/console-preserve-log-expected.txt: Added.
  • inspector/console/console-preserve-log.html: Added.

2011-06-14 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Allow the console to persist on page refresh or navigation
https://bugs.webkit.org/show_bug.cgi?id=53359

Adds a context menu checkbox to preserve the console log across
navigations. However, the underlying messages and objects are actually
deleted from the backend, so they are not expandable; their continued
display in the console frontend is merely cosmetic.

Test: inspector/console/console-preserve-log.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.preserveLogItemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.reset):
9:59 AM Changeset in webkit [88814] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/742

Merge 87959
BUG=84946
Review URL: http://codereview.chromium.org/7158003

9:48 AM Changeset in webkit [88813] by cevans@google.com
  • 7 edits in branches/chromium/742/Source/WebCore

Merge 87756
BUG=84946
Review URL: http://codereview.chromium.org/7147018

9:46 AM Changeset in webkit [88812] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

WebFrame::url() should use the one true URL
https://bugs.webkit.org/show_bug.cgi?id=62610

The Document's URL is the one true URL. Thou shalt have no URLs before
Document::url().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::url):
9:34 AM Changeset in webkit [88811] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 87863
BUG=82653
Review URL: http://codereview.chromium.org/7149022

9:32 AM Changeset in webkit [88810] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 87863
BUG=82653
Review URL: http://codereview.chromium.org/7150014

9:29 AM Changeset in webkit [88809] by commit-queue@webkit.org
  • 3 edits in trunk

2011-06-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[CMAKE] Add ENABLE_TOUCH_ICON_LOADING feature.
https://bugs.webkit.org/show_bug.cgi?id=62604

Add feature to enable or disable ENABLE_TOUCH_ICON which supports
apple-touch-icon and apple-touch-icon-precomposed in link tag.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:
9:25 AM Changeset in webkit [88808] by podivilov@chromium.org
  • 5 edits in trunk

2011-06-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:

2011-06-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add tooltip to file select options in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=62537

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.compare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
9:25 AM Changeset in webkit [88807] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-14 Benjamin Poulain <benjamin@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator's Trie does not work with Python 3
https://bugs.webkit.org/show_bug.cgi?id=62635

With Python 3, dict.items() return an iterator. Since the iterator
protocol changed between Python 2 and 3, the easiest way to get the
values is to have something that use the iterator implicitely, like a
for() loop.

  • KeywordLookupGenerator.py:
8:56 AM Changeset in webkit [88806] by Ademar Reis
  • 2 edits in trunk/LayoutTests

Unreviewed: unskip test rebasedlined by r88772

[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
http://trac.webkit.org/changeset/88772

The test was rebaselined but the committer forgot to remove it from
the Skip list.

  • platform/qt/Skipped: unskip test
8:48 AM Changeset in webkit [88805] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-14 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp: Implement new class to culculate border radius, initialize for appropriate properties. (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  • css/CSSStyleSelector.cpp: Remove old implementations. (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: Pass LengthSize by value. (WebCore::AnimationBase::ensurePropertyMap):
  • rendering/style/RenderStyle.h: Pass LengthSize by value consistently.
8:46 AM Changeset in webkit [88804] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-14 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Implement CSS border radius properies in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=62265

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp: Implement new class to culculate border radius, initialize for appropriate properties. (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius): (WebCore::ApplyPropertyBorderRadius::applyValue): (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
  • css/CSSStyleSelector.cpp: Remove old implementations. (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: Pass LengthSize by value. (WebCore::AnimationBase::ensurePropertyMap):
  • rendering/style/RenderStyle.h: Pass LengthSize by value consistently.
8:03 AM Changeset in webkit [88803] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=62627

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::menuPositionFunction):
  • UIProcess/gtk/WebContextMenuProxyGtk.h:
7:58 AM Changeset in webkit [88802] by Carlos Garcia Campos
  • 10 edits in trunk/Source

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

The method actually converts coordinates, the rectangle size is
not affected, so it can be modified to return a point
instead. Fix also a bug in the implementation, it was translating
the coordinates twice returning the wrong position when the given
rectangle was not at 0,0.

  • platform/gtk/GtkUtilities.cpp: (WebCore::convertWidgetPointToScreenPoint):
  • platform/gtk/GtkUtilities.h:
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Use convertWidgetPointToScreenPoint().

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowToScreen): Update to use convertWidgetPointToScreenPoint() (WebKit::ChromeClient::screenToWindow): Ditto.
  • webkit/webkitwebview.cpp: Remove globalPointForClientPoint() since it does the same than convertWidgetPointToScreenPoint(). (webkit_web_view_popup_menu_handler): Use convertWidgetPointToScreenPoint() instead of globalPointForClientPoint(). (doDragLeaveLater): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto.

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
https://bugs.webkit.org/show_bug.cgi?id=62626

  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::screenToWindow): Implement this method using convertWidgetPointToScreenPoint(). (WebKit::PageClientImpl::windowToScreen): Update to use convertWidgetPointToScreenPoint().
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp: (WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use convertWidgetPointToScreenPoint().
7:38 AM Changeset in webkit [88801] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

Skip new tests since Windows port does not support the progress element.

  • platform/win/Skipped:
7:36 AM Changeset in webkit [88800] by Carlos Garcia Campos
  • 8 edits
    5 adds
    1 delete in trunk/Source

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new class to show an authentication dialog that is used by
both WebKit1 and WebKit2.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/GtkAuthenticationDialog.cpp: Added. (WebCore::addEntryToTable): (WebCore::sessionCanSavePasswords): (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog): (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): (WebCore::getSavedLogin): (WebCore::GtkAuthenticationDialog::show): (WebCore::GtkAuthenticationDialog::destroy): (WebCore::GtkAuthenticationDialog::savePasswordCallback): (WebCore::GtkAuthenticationDialog::savePassword): (WebCore::GtkAuthenticationDialog::authenticate): (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
  • platform/gtk/GtkAuthenticationDialog.h: Added.

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Move the common code of webkitsoupauthdialog to a common C++ class
in WebCore so that it can be used by WebKit2 too. The file has
been converted into a C++ file.

  • GNUmakefile.am: Rename webkitsoupauthdialog.c to webkitsoupauthdialog.cpp.
  • webkit/webkitsoupauthdialog.c: Removed.
  • webkit/webkitsoupauthdialog.cpp: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (sessionAuthenticate): Use GtkAuthenticationDialog object from WebCore. (attach): (detach):
  • webkit/webkitsoupauthdialog.h:

2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support authentication dialogs in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62366

Add a new soup feature to show an authentication dialog when it
gets a 401 HTTP response.

  • GNUmakefile.am: Add new files to compilation.
  • WebProcess/gtk/WebAuthDialog.cpp: Added. (web_auth_dialog_class_init): (web_auth_dialog_init): (sessionAuthenticate): (attach): (detach): (webAuthDialogSessionFeatureInit):
  • WebProcess/gtk/WebAuthDialog.h: Added.
  • WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):
7:07 AM Changeset in webkit [88799] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/Source/WebKit2

2011-06-14 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Implementing LayerTreeHost and LayerTreeContext and LayerTreeHost for Qt.
Add the necessary plumbing to make the LayerTreeHost work with Qt, based on the original Mac
implementation (the code is nearly identical). This includes creating the right layers for the
overlay and for the non-composited content, and passing the root layer to the UI process.

Also, since LayerTreeHostQt is compiled, we have to add some of the rest of the existing patches,
namely the new messages: syncCompositingLayers and updateCompositingLayerContent, and create a
stub implementation for them in DrawingAreaProxy.

Note that this is not activated yet, until we enable accelerated compositing in the settings and
create the right GraphicsLayer.

  • Scripts/webkit2/messages.py:
  • Shared/LayerTreeContext.h:
  • Shared/qt/LayerTreeContextQt.cpp: (WebKit::LayerTreeContext::LayerTreeContext): (WebKit::LayerTreeContext::~LayerTreeContext): (WebKit::LayerTreeContext::encode): (WebKit::LayerTreeContext::decode): (WebKit::LayerTreeContext::isEmpty): (WebKit::operator==):
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::syncCompositingLayers): (WebKit::DrawingAreaProxy::updateCompositingLayerContent):
  • UIProcess/DrawingAreaProxy.messages.in:
  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: (WebCore::collectCompositingInfoForThisLayer):
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp: (WebKit::LayerTreeHostQt::create): (WebKit::LayerTreeHostQt::~LayerTreeHostQt): (WebKit::LayerTreeHostQt::LayerTreeHostQt): (WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled): (WebKit::LayerTreeHostQt::scheduleLayerFlush): (WebKit::LayerTreeHostQt::cancelPendingLayerFlush): (WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush): (WebKit::LayerTreeHostQt::setRootCompositingLayer): (WebKit::LayerTreeHostQt::invalidate): (WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostQt::scrollNonCompositedContents): (WebKit::LayerTreeHostQt::forceRepaint): (WebKit::LayerTreeHostQt::sizeDidChange): (WebKit::LayerTreeHostQt::didInstallPageOverlay): (WebKit::LayerTreeHostQt::didUninstallPageOverlay): (WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay): (WebKit::LayerTreeHostQt::flushPendingLayerChanges): (WebKit::LayerTreeHostQt::performScheduledLayerFlush): (WebKit::LayerTreeHostQt::layerFlushTimerFired): (WebKit::LayerTreeHostQt::createPageOverlayLayer): (WebKit::LayerTreeHostQt::destroyPageOverlayLayer): (WebKit::LayerTreeHostQt::notifyAnimationStarted): (WebKit::LayerTreeHostQt::notifySyncRequired): (WebKit::LayerTreeHostQt::paintContents): (WebKit::LayerTreeHostQt::showDebugBorders): (WebKit::LayerTreeHostQt::showRepaintCounter): (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
  • WebProcess/WebPage/qt/LayerTreeHostQt.h: Added. (WebKit::LayerTreeHostQt::layerTreeContext): (WebKit::LayerTreeHostQt::pauseRendering): (WebKit::LayerTreeHostQt::resumeRendering):
6:58 AM Changeset in webkit [88798] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk/Source/WebCore

2011-06-14 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Media Stream PeerConnection API: adding the StreamList and supporting classes.
https://bugs.webkit.org/show_bug.cgi?id=61539

  • dom/StreamContainer.h: Added. (WebCore::StreamContainer::create): (WebCore::StreamContainer::~StreamContainer): (WebCore::StreamContainer::length): (WebCore::StreamContainer::item): (WebCore::StreamContainer::add): (WebCore::StreamContainer::remove): (WebCore::StreamContainer::contains): (WebCore::StreamContainer::get): (WebCore::StreamContainer::StreamContainer):
  • dom/StreamList.cpp: Added. (WebCore::StreamList::create): (WebCore::StreamList::StreamList): (WebCore::StreamList::~StreamList): (WebCore::StreamList::length): (WebCore::StreamList::item):
  • dom/StreamList.h: Added.
  • dom/StreamList.idl: Added.
6:54 AM Changeset in webkit [88797] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-14 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Add a createImage() function to ShareableBitmap, for now ifdef'ed to Qt only.
This allows us to support directly composited images across the WebKit2 processes.

Together with Viatcheslav Ostapenko.

  • Shared/ShareableBitmap.h:
  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::createQImage): (WebKit::ShareableBitmap::createImage):
6:53 AM Changeset in webkit [88796] by caio.oliveira@openbossa.org
  • 11 edits in trunk

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Increase the likeness that JSElements are converted to QWebElements. When hinted
with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

We also remove the implicit conversion between JSDocument (which is not an
element) to QWebElement. The conversion only worked for calling slots, while
without hint it returned a QVariantMap (as can be seen in domCycles test). It was
added for supporting DRT, but since this change we can use it as QVariantMap and
get the value for "documentElement".

This patch is based on Noam Rosenthal original patch in the same bug.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::hintForRealType): Extracted function to choose the metatype hint based on the JSValue type. Add QWebElement metatype as a hint for JSElement objects, this way if no hint is provided, JSElement objects will always be converted to QWebElements.

(JSC::Bindings::convertValueToQVariant):
Use previous function. Identify the conversion between JSElement to QWebElement
as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
is QWebElement metatype and we have a JSDocument. Changed from JSHTMLElement to
JSElement to cover the 'documentElement'.

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Since the implicit conversion was removed, change support functions of DRT to
expect a QVariantMap instead of a QWebElement. This matches the exposed function
in the controller, which takes 'document' and not 'document.documentElement'.

And now that Element -> QWebElement is a perfect match, we must use QWebElement
instead of QVariantMap, like in plainText().

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of QVariantMap when getting the startContainer. Also use QVariantMap directly, bridge will do conversion for us now.

(getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
QVariantMap that Qt bridge gives us when 'document' is passed from JS.

(DumpRenderTreeSupportQt::nodesFromRect): Use helper function.

  • tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two different tests. In practice, the original test just checked whether we could create a QVariantMap representing 'document' without infinite looping due to cycles in the DOM. This was more evident before since we haven't a conversion from JSElement to QWebElement, but from JSElement to QVariantMap.

(tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
'documentElement' from it. Compares to QWebFrame::documentElement().

(tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
the documentElement.

(tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.

2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

Since we don't implictly convert 'document' object to QWebElement
in metacalls anymore, change the controller to expect QVariantMap instead.

The method plainText() was updated to use QVariantMap as well to let the bridge
do the conversion directly for us.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp: (PlainTextController::plainText):
  • DumpRenderTree/qt/PlainTextControllerQt.h:
6:42 AM Changeset in webkit [88795] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-06-14 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] Don't include convenience "QWebFoo" headers in WebKit code.
https://bugs.webkit.org/show_bug.cgi?id=62632

  • WebCoreSupport/FrameNetworkingContextQt.cpp:
6:27 AM Changeset in webkit [88794] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-06-14 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

Remove some unnecessary includes.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
6:22 AM Changeset in webkit [88793] by yael.aharon@nokia.com
  • 7 edits
    5 adds in trunk

2011-06-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kent Tamura.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

  • fast/dom/HTMLProgressElement/indeterminate-progress-001.html: Added.
  • fast/dom/HTMLProgressElement/indeterminate-progress-002-expected.txt: Added.
  • fast/dom/HTMLProgressElement/indeterminate-progress-002.html: Added.
  • platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

2011-06-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kent Tamura.

<progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

Add support for :indeterminate pseudo class for progress element.

Tests: fast/dom/HTMLProgressElement/indeterminate-progress-001.html

fast/dom/HTMLProgressElement/indeterminate-progress-002.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithControl): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::isDeterminate): (WebCore::HTMLProgressElement::didElementStateChange):
  • html/HTMLProgressElement.h:
5:53 AM Changeset in webkit [88792] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-14 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631

  • inspector/debugger/debugger-reload-on-pause-expected.txt: Added.
  • inspector/debugger/debugger-reload-on-pause.html: Added.

2011-06-14 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: reload from within inspector window does not work while debugger is paused.
https://bugs.webkit.org/show_bug.cgi?id=62631

Test: inspector/debugger/debugger-reload-on-pause.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
5:32 AM Changeset in webkit [88791] by abecsi@webkit.org
  • 2 edits in trunk/Tools

2011-06-14 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
https://bugs.webkit.org/show_bug.cgi?id=62630

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): remove dead variable 'forceCarbon'
3:47 AM Changeset in webkit [88790] by apavlov@chromium.org
  • 1 edit in branches/chromium/742/Source/WebCore/inspector/front-end/inspector.css

Merge 84485 - 2011-04-21 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: toolbar background is blank on Mac Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59089

  • inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/7024044

3:15 AM Changeset in webkit [88789] by tkent@chromium.org
  • 17 edits
    1 copy
    12 adds
    3 deletes in trunk/LayoutTests

2011-06-14 Kent Tamura <tkent@chromium.org>

[Chromium] Test expectation update for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-linux/fast/forms/slider-thumb-stylability-expected.png: Removed.
  • platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png: Added.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-range-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png:
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.txt: Removed.
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/chromium/test_expectations.txt:
2:49 AM Changeset in webkit [88788] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-06-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174

Replace RenderObject parameter with RenderStyle's in adjustSliderThumbSize.
Because, parameter of the function was changed. And, add constant variable to
paintMediaSliderThumb().

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderThumb):
  • platform/efl/RenderThemeEfl.h:
2:22 AM Changeset in webkit [88787] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-14 Kent Tamura <tkent@chromium.org>

[Qt] Attempt to fix a build break by r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack):
1:36 AM Changeset in webkit [88786] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test failing in the GTK bots.

  • platform/gtk/Skipped: Skipped test
1:13 AM Changeset in webkit [88785] by mario@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baselines for GTK needed after r88266.

  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/gtk/svg/custom/invalid-dasharray-expected.txt: Added.
1:03 AM Changeset in webkit [88784] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-14 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping tests crashing in the GTK bots.

  • platform/gtk/Skipped: Skipped tests.
12:53 AM Changeset in webkit [88783] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-14 Kent Tamura <tkent@chromium.org>

[Mac-WK2] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/mac-wk2/media/controls-without-preload-expected.txt:
12:28 AM Changeset in webkit [88782] by loislo@chromium.org
  • 11 edits
    3 deletes in branches/chromium/782

Merge 88331 - 2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css:
  • inspector/front-end/utilities.js: (Element.prototype.query):

2011-06-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove shadow dom inspection from Elements panel by default.
https://bugs.webkit.org/show_bug.cgi?id=62188

This reverts r85751

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.findNode.documentRequested): (initialize_ElementTest.InspectorTest.findNode):
  • inspector/console/console-shadow-dom-access.html: Removed.
  • inspector/elements/shadow-dom-expected.txt: Removed.
  • inspector/elements/shadow-dom.html: Removed.
  • platform/win/Skipped:

TBR=caseq@chromium.org
Review URL: http://codereview.chromium.org/7147011

Jun 13, 2011:

11:44 PM Changeset in webkit [88781] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/win/media/audio-repaint-expected.txt:
11:31 PM Changeset in webkit [88780] by hayato@chromium.org
  • 2 edits in trunk/Tools

2011-06-13 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188

A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.

No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
11:11 PM Changeset in webkit [88779] by cevans@google.com
  • 4 edits in branches/chromium/782/Source/WebCore

Merge 88139
BUG=84002
Review URL: http://codereview.chromium.org/7145023

10:55 PM Changeset in webkit [88778] by tkent@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

More Leopard and GTK rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/gtk/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/mac-leopard/media/audio-repaint-expected.txt: Added.
  • platform/mac-leopard/media/media-document-audio-repaint-expected.txt: Added.
10:42 PM Changeset in webkit [88777] by tkent@chromium.org
  • 10 edits in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

  • platform/win/media/audio-controls-rendering-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/controls-without-preload-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
10:34 PM Changeset in webkit [88776] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/742

Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145022

10:25 PM Changeset in webkit [88775] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-06-13 Kent Tamura <tkent@chromium.org>

[Chromium-win] Fix two wrong assertions exposed by r88757.

  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar):
10:19 PM Changeset in webkit [88774] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/782

Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145021

10:15 PM Changeset in webkit [88773] by tkent@chromium.org
  • 22 edits in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

[GTK] Rebaseline for r88757.

  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
10:07 PM Changeset in webkit [88772] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125

Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871

  • platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
10:02 PM Changeset in webkit [88771] by Laszlo Gombos
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-13 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224

Fix the expected result and remove the test from the Skipped list.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
10:00 PM Changeset in webkit [88770] by tkent@chromium.org
  • 8 edits in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

[Mac] Leopard expectation files for r88757.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/controls-without-preload-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
9:53 PM Changeset in webkit [88769] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-13 Kent Tamura <tkent@chromium.org>

[Mac] Rebaseline for r88757.

  • media/audio-repaint-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
9:45 PM Changeset in webkit [88768] by ap@apple.com
  • 2 edits in trunk/Tools

Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.

  • Scripts/webkitpy/common/config/committers.py:
9:34 PM Changeset in webkit [88767] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Fix a typo in Mac WebKit2's skipped list.

svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.

  • platform/mac-wk2/Skipped:
9:29 PM Changeset in webkit [88766] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Skip editing/pasteboard/smart-paste-004.html per bug 61633.

  • platform/win/Skipped:
9:23 PM Changeset in webkit [88765] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.

  • platform/chromium/test_expectations.txt:
9:15 PM Changeset in webkit [88764] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] The second try to fix a build break.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
9:08 PM Changeset in webkit [88763] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] Fix a typo.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
9:07 PM Changeset in webkit [88762] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Kent Tamura <tkent@chromium.org>

[EFL] Try to fix a build break by r88757.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
9:05 PM Changeset in webkit [88761] by cevans@google.com
  • 3 edits in branches/chromium/782/Source

Merge 88444
BUG=85559
Review URL: http://codereview.chromium.org/7145019

9:02 PM Changeset in webkit [88760] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.

  • platform/chromium/test_expectations.txt:
8:49 PM Changeset in webkit [88759] by cevans@google.com
  • 1 edit in branches/chromium/782/Source/WebCore/dom/Element.cpp

Merge 87827
BUG=84335
Review URL: http://codereview.chromium.org/7155001

8:48 PM Changeset in webkit [88758] by cevans@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/dom/Element.cpp

Merge 87827
BUG=84355
Review URL: http://codereview.chromium.org/7111044

8:46 PM Changeset in webkit [88757] by tkent@chromium.org
  • 46 edits
    5 adds in trunk

2011-06-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920

Add two new tests, and update tests with sliders.

  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
  • fast/forms/input-appearance-range.html: Added.
  • fast/forms/slider-thumb-stylability.html: Remove text.
  • fast/forms/validation-message-on-range-expected.txt: Added.
  • fast/forms/validation-message-on-range.html: Added.
  • fast/multicol/client-rects-expected.txt:
  • fast/repaint/slider-thumb-float-expected.txt:
  • media/audio-repaint-expected.txt:
  • media/controls-without-preload-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped: Skip validaiton-message-on-range.html because this platform doesn't support the interactive validation.
  • platform/mac-wk2/Skipped: Skip validaiton-message-on-range.html.
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-range-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-range-expected.txt: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/mac/fast/forms/slider-padding-expected.png:
  • platform/mac/fast/forms/slider-padding-expected.txt:
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.png:
  • platform/mac/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/mac/fast/forms/slider-thumb-stylability-expected.png:
  • platform/mac/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
  • platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.png:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/qt/Skipped: Skip validaiton-message-on-range.html.
  • platform/win/Skipped: Skip validaiton-message-on-range.html.

2011-06-10 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920

Remove RenderSlider::layout().
In order to remove it, we introduce new three shadow nodes:

  • A flex box container occupying the whole box
  • A flex box item representing a movable area of the thumb
  • A flex box item limiting the movable area of the thumb

The thumb position is specified by percentage position in the second element.

This change also fixes Bug 60353.

Tests: fast/forms/input-appearance-range.html

fast/forms/validation-message-on-range.html

  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect): Use Node::getRect() for the thumb element.
  • css/html.css: Add new style definitions for the new node layout. (input[type="range"]::-webkit-slider-container): (input[type="range"]::-webkit-slider-runnable-track): (input[type="range"]::-webkit-slider-thumb):
  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Accepts events on shadow nodes, use sliderThumbElementOf(). (WebCore::RangeInputType::createShadowSubtree): Creates new nodes layout. (WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
  • html/RangeInputType.h: Remove shadowSliderThumb().
  • html/shadow/SliderThumbElement.cpp: (WebCore::sliderPosition): Moved from RenderSlider.cpp. (WebCore::hasVerticalAppearance): New utility function. (WebCore::sliderThumbElementOf): New utility function. (WebCore::RenderSliderThumb::layout): Sets CSS top/left values. (WebCore::RenderSliderContainer::RenderSliderContainer): (WebCore::RenderSliderContainer::layout): Add some adjustment code.
    • Setting box-orient
    • Adjust heights of some nodes. It is required to pass existing tests.

(WebCore::SliderThumbElement::setPositionFromValue):

Update comments.

(WebCore::SliderThumbElement::setPositionFromPoint):

Calculate the current position from absolute positions.

(WebCore::SliderThumbElement::hostInput):

Removed unnecessary variable.

(WebCore::TrackLimiterElement::TrackLimiterElement):
(WebCore::TrackLimiterElement::create): Adjust style.
(WebCore::TrackLimiterElement::createRenderer):

This node uses RenderSliderThumb.

(WebCore::TrackLimiterElement::shadowPseudoId):

This node also uses -webkit-slider-thumb.

(WebCore::SliderContainerElement::SliderContainerElement):
(WebCore::SliderContainerElement::create):
(WebCore::SliderContainerElement::createRenderer):

Uses RenderSliderContainer.

(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/SliderThumbElement.h: Make hostInput() public, add declarations of TrackLimiterElement and SliderContainerElement.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): Added an assertion. (WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
  • rendering/RenderSlider.h: Remove declarations of removed functions.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Calls adjustSliderThumbSize().
8:30 PM Changeset in webkit [88756] by cevans@google.com
  • 1 edit in branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp

Merge 87911
BUG=84597
Review URL: http://codereview.chromium.org/7154001

7:55 PM Changeset in webkit [88755] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-13 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, rolled DEPS.

  • DEPS:
7:27 PM Changeset in webkit [88754] by joone.hur@collabora.co.uk
  • 7 edits in trunk

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.

  • configure.ac: Add configure option to enable/disable register protocol handler.

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

  • GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::registerProtocolHandler): Added.
  • WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
7:19 PM Changeset in webkit [88753] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174

Implement paintMediaSliderThumb() function to show thumb of media slider.
adjustSliderThumbSize() should be implemented in order to call paintMediaSliderThumb().

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  • platform/efl/RenderThemeEfl.h:
7:15 PM Changeset in webkit [88752] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.

  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
7:09 PM Changeset in webkit [88751] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Keishi Hattori <keishi@webkit.org>

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
7:08 PM Changeset in webkit [88750] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149011

7:07 PM Changeset in webkit [88749] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149010

6:59 PM Changeset in webkit [88748] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaselines after r88617. The test is now passing on all platforms.

  • platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:46 PM Changeset in webkit [88747] by jberlin@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566

Add/update the (failing?) expected results for Windows in order to get the bots green.

  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/tiling: Added.
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
6:15 PM Changeset in webkit [88746] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-13 David Levin <levin@chromium.org>

Reviewed by Dmitry Titov.

fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609

  • fast/workers/worker-close.html: Move a setTimeout to start after the response message is received to make the ordering of messages deterministic.
6:13 PM Changeset in webkit [88745] by simonjam@chromium.org
  • 6 edits in trunk/Source

2011-06-13 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.

2011-06-13 James Simonsen <simonjam@chromium.org>

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

  • public/WebKitClient.h: (WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
6:10 PM Changeset in webkit [88744] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.

  • platform/chromium/test_expectations.txt:
6:00 PM Changeset in webkit [88743] by jianli@chromium.org
  • 2 edits in branches/chromium/782/Source/WebKit/chromium

Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

  • public/WebNotification.h:
  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

TBR=jianli@chromium.org
BUG=84660
Review URL: http://codereview.chromium.org/7148005

5:58 PM Changeset in webkit [88742] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Skip test added by r88578 on GTK per bug 62585.

  • platform/gtk/Skipped:
5:53 PM Changeset in webkit [88741] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-13 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602

No new tests, build cleanup only.

  • config.h:
5:42 PM Changeset in webkit [88740] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612

This parameter defaults to true anyway.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
5:39 PM Changeset in webkit [88739] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).

  • platform/win/svg/hixie/intrinsic: Added.
  • platform/win/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
5:38 PM Changeset in webkit [88738] by jianli@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

  • public/WebNotification.h:
  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

5:22 PM Changeset in webkit [88737] by dominicc@chromium.org
  • 11 edits
    2 adds in trunk

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256

Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.

  • printing/page-count-with-one-word-expected.txt: Added.
  • printing/page-count-with-one-word.html: Added.

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebCore.exp.in:
  • page/Frame.cpp: (WebCore::Frame::resizePageRectsKeepingRatio):
  • page/Frame.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::begin):

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]): (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): (-[WebHTMLView _endPrintMode]): (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): (-[WebHTMLView _endScreenPaginationMode]): (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]): (-[WebHTMLView layout]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView setPageWidthForPrinting:]):

2011-06-13 Kentaro Hara <haraken@google.com>

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.

Test: printing/page-count-with-one-word.html

  • WebFrame.cpp: (WebFrame::setPrinting): (WebFrame::setInPrintingMode):
  • WebFrame.h:
5:11 PM Changeset in webkit [88736] by mrobinson@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r88734

5:10 PM Changeset in webkit [88735] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611
<rdar://problem/9058370>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::getPluginInfo): Get the plug-in version string instead of the version number.

(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.

(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.

  • Shared/Plugins/PluginQuirks.h: Add the ReturnsNonRetainedScriptableNPObject quirk.
  • UIProcess/Plugins/PluginInfoStore.h: Use a version string. Eventually this should hold the PluginVersion class we added.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginScriptableNPObject): If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
5:09 PM Changeset in webkit [88734] by mrobinson@webkit.org
  • 7 edits in trunk/Source/WebKit/gtk

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.

  • docs/webkitgtk-sections.txt: Add missing sections to the list and remove unneeded sections.
  • docs/webkitgtk.types: Update the types list.
  • webkit/webkithittestresult.cpp: Fix inline documentation errors. (webkit_hit_test_result_class_init): Ditto.
  • webkit/webkiticondatabase.cpp: Ditto.
  • webkit/webkitwebsettings.cpp: Ditto. (webkit_web_settings_class_init): Ditto.
  • webkit/webkitwebview.cpp: Ditto. (webkit_web_view_class_init): Ditto.
4:51 PM Changeset in webkit [88733] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Mac, GTK, and Qt rebaselines after r88717.

  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
4:49 PM Changeset in webkit [88732] by crogers@google.com
  • 2 edits in trunk/Tools

2011-06-13 Chris Rogers <crogers@google.com>

Unreviewed build fix.

Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
4:28 PM Changeset in webkit [88731] by abarth@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601

Previously, our user-gesture state was per-frame. Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture. Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.

This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code. Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
  • bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp):
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setProcessingTimerCallback):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitFromJavaScript): (WebCore::HTMLFormElement::submit):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::createWindow): (WebCore::DOMWindow::open):
4:20 PM Changeset in webkit [88730] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-13 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Added a test that tries to remove the children of munder, mover and munderover elements.

  • mathml/munderover-remove-children-expected.txt: Added.
  • mathml/munderover-remove-children.html: Added.

2011-06-13 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.

Test: mathml/munderover-remove-children.html

  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
  • rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
4:06 PM Changeset in webkit [88729] by commit-queue@webkit.org
  • 11 edits in trunk/Source

2011-06-13 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
  • bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::create): (WebCore::V8BindingPerIsolateData::ensureInitialized): (WebCore::V8BindingPerIsolateData::dispose): (WebCore::getToStringName): (WebCore::getToStringTemplate):
  • bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::get): (WebCore::V8BindingPerIsolateData::current): (WebCore::V8BindingPerIsolateData::rawTemplateMap): (WebCore::V8BindingPerIsolateData::templateMap): (WebCore::V8BindingPerIsolateData::toStringName): (WebCore::V8BindingPerIsolateData::toStringTemplate):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):

2011-06-13 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

  • tests/IDBBindingUtilitiesTest.cpp: (WebCore::TEST):
3:56 PM Changeset in webkit [88728] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-13 Lei Zhang <thestig@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
  • src/WebSettingsImpl.h:
3:53 PM Changeset in webkit [88727] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Barth.

Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598

Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressCompleted):
3:50 PM Changeset in webkit [88726] by crogers@google.com
  • 6 edits in trunk/Tools

2011-06-13 Chris Rogers <crogers@google.com>

Reviewed by Dirk Pranke.

Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::setEncodedAudioData):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::encodedAudioData): (LayoutTestController::shouldDumpAsAudio): (LayoutTestController::setShouldDumpAsAudio):
  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleAudioHeader): (TestShellPrinter::handleAudioHeader):
  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::dump):
3:47 PM Changeset in webkit [88725] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-13 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>

Reviewed by Eric Seidel.

[EFL] Input method hints not updated while clicking non-input field editable area
https://bugs.webkit.org/show_bug.cgi?id=62539

This fixes a minor bug when input method hints are not updated while focus is
changed from editable area with input tags to other which are does not have input
tag i.e. textarea.

  • ewk/ewk_view.cpp: (ewk_view_input_method_state_set):
3:46 PM Changeset in webkit [88724] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605

A simple rename

  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):
3:45 PM Changeset in webkit [88723] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Implements basic functions for "redo" command.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
  • WebCoreSupport/EditorClientEfl.h:
3:44 PM Changeset in webkit [88722] by commit-queue@webkit.org
  • 1 edit
    13 adds in trunk/Source/WebKit2

2011-06-13 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445

Add Efl related directory and files in WebKit2/WebProcess/.

  • WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
  • WebProcess/WebPage/efl/WebPageEfl.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL):
  • WebProcess/efl/WebProcessEfl.cpp: Added. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformTerminate):
  • WebProcess/efl/WebProcessMainEfl.cpp: Added. (WebKit::WebProcessMainEfl):
  • WebProcess/efl/WebProcessMainEfl.h: Added.
  • efl/MainEfl.cpp: Added. (main):
3:39 PM Changeset in webkit [88721] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-06-13 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88704.
http://trac.webkit.org/changeset/88704
https://bugs.webkit.org/show_bug.cgi?id=62466

Caused layout test failures on Chromium Mac.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
3:39 PM Changeset in webkit [88720] by joone.hur@collabora.co.uk
  • 2 edits in trunk

2011-06-13 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Need to report whether touch icon loading is enabled
https://bugs.webkit.org/show_bug.cgi?id=62532

It needs to report whether touch icon loading is enabled.

  • configure.ac: Updated option parsing code for loading touch icons.
3:38 PM Changeset in webkit [88719] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600

Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases. This comes out as a reasonable parsing speed
boost.

  • parser/JSParser.cpp: (JSC::JSParser::nextExpectIdentifier): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
  • parser/Lexer.cpp:
  • parser/Lexer.h: (JSC::Lexer::makeIdentifier): (JSC::Lexer::lexExpectIdentifier):
3:38 PM Changeset in webkit [88718] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562
<rdar://problem/9313885>

Patch by Morgan Winer <mwiner@apple.com> on 2011-06-13
Reviewed by Enrica Casucci.

The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.

There are no layout tests for this, since it can be tested only at API level.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().

3:37 PM Changeset in webkit [88717] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk/LayoutTests

2011-06-13 Wyatt Carss <wcarss@google.com>

Reviewed by Ryosuke Niwa.

dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159

Converted to dump the key part of page as text. The platform-dependent files are
copied from the previous setup of this test, as mac appears to do something different
in its delegate info -- 'insertText' instead of 'insertNode', and some differences
in how it counts indices. Note that chromium-mac works the same as chromium-win, but
would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
a bit accordingly.

  • editing/pasteboard/paste-xml.xhtml:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/win/editing/pasteboard/paste-xml-expected.txt:
3:36 PM Changeset in webkit [88716] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

  • Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE

2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

No change in functionality so no new tests.

  • CMakeLists.txt: move .idl files to be conditionally generated.
3:32 PM Changeset in webkit [88715] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: Infinity as key
https://bugs.webkit.org/show_bug.cgi?id=62285

  • storage/indexeddb/key-type-infinity-expected.txt: Added.
  • storage/indexeddb/key-type-infinity.html: Added.
3:30 PM Changeset in webkit [88714] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add load error handler to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62347

Add a handler function of "load,error" to EWebLauncher.
EWebLauncher now displays a simple error page on load errors.

  • EWebLauncher/main.c: (on_load_error): (browserCreate):
3:29 PM Changeset in webkit [88713] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: odd database names
https://bugs.webkit.org/show_bug.cgi?id=62322

  • storage/indexeddb/database-odd-names-expected.txt: Added.
  • storage/indexeddb/database-odd-names.html: Added.
3:25 PM Changeset in webkit [88712] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
since the TestPlugin no longer prints this event.

  • platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Do not set the plugin as windowless always. Doing this breaks some results on Qt and this seems to be unnecessary for the moment. (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the XP_UNIX block is first by guarding against using a null instance.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add the XP_UNIX define for Linux.
  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  • GNUmakefile.am: Update source list.
3:23 PM Changeset in webkit [88711] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
without plugin support
https://bugs.webkit.org/show_bug.cgi?id=62394

No behaviour changes, so no new tests.

  • CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and Plugin{Package,View}None.cpp and move them to CMakeListWinCE and CMakeListsEfl, respectively.
  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
3:22 PM Changeset in webkit [88710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Eric Seidel.

[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
https://bugs.webkit.org/show_bug.cgi?id=62365

These functions do not exist in any public headers and
they are not used internally.
Moreover ewk_view has the same functionality added
https://bugs.webkit.org/show_bug.cgi?id=60435

  • ewk/ewk_frame.cpp:
3:22 PM Changeset in webkit [88709] by Nate Chapin
  • 35 edits in trunk/LayoutTests

2011-06-13 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Rewrite a bunch of XHR-based tests to use waitUntilDone()/notifyDone().
https://bugs.webkit.org/show_bug.cgi?id=62066

  • fast/xmlhttprequest/xmlhttprequest-gc.html:
  • fast/xmlhttprequest/xmlhttprequest-get.xhtml:
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
  • html5lib/runner.html:
  • html5lib/webkit-resumer.html:
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html:
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html:
  • http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:
  • http/tests/xmlhttprequest/cross-origin-preflight-get.html:
  • http/tests/xmlhttprequest/event-listener-gc.html:
  • http/tests/xmlhttprequest/interactive-state.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html:
  • http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html:
  • http/tests/xmlhttprequest/response-encoding.html:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-004.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-005.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-006.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-007.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-008.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-009.html:
  • http/tests/xmlhttprequest/uri-resolution-opera-open-010.html:
  • http/tests/xmlhttprequest/web-apps/001.html:
  • http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html:
  • http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html:
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
  • http/tests/xmlhttprequest/zero-length-response.html:
3:17 PM Changeset in webkit [88708] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Eric Seidel.

IndexedDB test: readonly properties
https://bugs.webkit.org/show_bug.cgi?id=62392

  • storage/indexeddb/readonly-expected.txt: Added.
  • storage/indexeddb/readonly.html: Added.
3:16 PM Changeset in webkit [88707] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62524

  • UIProcess/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformDidClose): (WebKit::WebInspectorProxy::platformBringToFront): (WebKit::WebInspectorProxy::platformInspectedURLChanged): (WebKit::WebInspectorProxy::inspectorPageURL): (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
3:14 PM Changeset in webkit [88706] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62438

  • UIProcess/efl/TextCheckerEfl.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkSpellingOfString): (WebKit::TextChecker::checkGrammarOfString): (WebKit::TextChecker::spellingUIIsShowing): (WebKit::TextChecker::toggleSpellingUIIsShowing): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::updateSpellingUIWithGrammarString): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
3:09 PM Changeset in webkit [88705] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: [refactoring] remove dead code from NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=62481

  • inspector/front-end/NetworkPanel.js:
3:06 PM Changeset in webkit [88704] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Daniel Cheng <dcheng@chromium.org>

Reviewed by Eric Seidel.

[chromium] Dragging images to Mail.app results in broken attachments
https://bugs.webkit.org/show_bug.cgi?id=62466

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
3:00 PM Changeset in webkit [88703] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-13 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add accessors for selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=62596

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::selectionEnd): (WebKit::WebAccessibilityObject::selectionStart):
2:58 PM Changeset in webkit [88702] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-13 Sangyong Park <sy302.park@gmail.com>

Reviewed by Eric Seidel.

implement to handle wheel event of plugin on x11
https://bugs.webkit.org/show_bug.cgi?id=62522

Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
for to handle wheel event on plugins

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent (WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent (WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin
2:51 PM Changeset in webkit [88701] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62523

  • UIProcess/efl/WebContextEfl.cpp: Added. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformInvalidateContext): (WebKit::WebContext::platformDefaultDatabaseDirectory): (WebKit::WebContext::platformDefaultIconDatabasePath): (WebKit::WebContext::platformDefaultLocalStorageDirectory):
2:44 PM Changeset in webkit [88700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-13 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[efl] Disable tiled backing store debug messages by default.
https://bugs.webkit.org/show_bug.cgi?id=61745

These messages pollute the output and are only useful to people
working on TBS itself. It makes more sense to have them disabled by
default.

  • ewk/ewk_tiled_backing_store.h:
2:36 PM Changeset in webkit [88699] by commit-queue@webkit.org
  • 2 edits
    1 add
    11 deletes in trunk/LayoutTests

2011-06-13 Annie Sullivan <sullivan@chromium.org>

Reviewed by Dimitri Glazkov.

Convert editing/execCommand/outdent-selection.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=62582

Convert the test to dump as markup and clean up the HTML.

  • editing/execCommand/outdent-selection-expected.txt: Added.
  • editing/execCommand/outdent-selection.html:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/gtk/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/outdent-selection-expected.txt: Removed.
  • platform/qt/editing/execCommand/outdent-selection-expected.png: Removed.
  • platform/qt/editing/execCommand/outdent-selection-expected.txt: Removed.
2:33 PM Changeset in webkit [88698] by enne@google.com
  • 3 edits
    3 adds in trunk

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

  • compositing/layer-creation/overlap-child-layer-expected.png: Added.
  • compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-child-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.

Test: compositing/layer-creation/overlap-animated-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2:29 PM Changeset in webkit [88697] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-13 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Correctly classify the test as failing.

  • platform/chromium/test_expectations.txt: It's failing.
2:23 PM Changeset in webkit [88696] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Touch this to try to fix the build...

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget):
2:22 PM Changeset in webkit [88695] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-13 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Record more flakiness...

  • platform/chromium/test_expectations.txt: Added expectation of flakiness.
2:20 PM Changeset in webkit [88694] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597

Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.

  • platform/win/Skipped:
2:14 PM Changeset in webkit [88693] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.list.am: remove CredentialStorage.cpp
2:10 PM Changeset in webkit [88692] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Improve GPU canvas startup time on the SkiaGPU path.
https://bugs.webkit.org/show_bug.cgi?id=62594


Fixed by skipping creation of shaders used only by the legacy path.

Covered by existing canvas tests.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
2:08 PM Changeset in webkit [88691] by msaboff@apple.com
  • 6 edits in trunk/Source/WebCore

2011-06-13 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498

Added some needed and speculative FontCachePurgePreventer objects.
Built and ran Safari with debug version of webkit that purges all
purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
to find system fallback fonts access via code paths that aren't
protected with FontCachePurgePreventer objects. Also examined
platform specific code that calls either Font::drawText() or
Canvas::drawText(). For those methods that may be called from currently
unprotected paths, added FontCachePurgePreventer objects.

No new functionality so no new tests.

  • inspector/DOMNodeHighlighter.cpp:
  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: (PlatformCALayerWinInternal::displayCallback):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::drawHudContents):
  • platform/mac/DragImageMac.mm: (WebCore::widthWithFont): (WebCore::drawAtPoint):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
1:59 PM Changeset in webkit [88690] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Windows rebaseline after r62565. The failure is tracked by the bug 62565.

  • platform/win/fast/harness/results-expected.txt:
1:58 PM Changeset in webkit [88689] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Unreviewed fix - removed parts of r88659 that were committed by mistake.

The patch accidentally included parts that weren't supposed to be there, namely the whole
code was duplicated. This patch rectifies that and brings it to the original reviewed code.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:
1:56 PM Changeset in webkit [88688] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Test fix for Windows.

[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595

  • platform/win/Skipped: Skipped the test with the problem.
1:52 PM Changeset in webkit [88687] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r88683

1:49 PM Changeset in webkit [88686] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

Merging r87766

1:46 PM Changeset in webkit [88685] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544

Fixed the crash by adding null pointer checks.

No new tests since there's no way to open dictionary panel.

  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
  • editing/VisiblePosition.cpp: (WebCore::makeRange):
  • page/Frame.cpp: (WebCore::Frame::rangeForPoint):
1:41 PM Changeset in webkit [88684] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973

Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.

  • platform/win/plugins/mouse-events-expected.txt:
  • platform/win/plugins/mouse-events-fixedpos-expected.txt:
1:39 PM Changeset in webkit [88683] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the list of ignored GTK+ header files for the documentation
generation.

  • docs/GNUmakefile.am: Update ignored header list.
1:36 PM Changeset in webkit [88682] by abarth@webkit.org
  • 16 edits
    2 adds in trunk/Source

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::iconURLs):

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509

This new class contains all the icon-related logic from FrameLoader.
The icon-related logic and state has almost zero interaction with the
rest of FrameLoader and is better handled as a separate concern.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setIconURL):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): (WebCore::DocumentLoader::continueIconLoadWithDecision):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stop):
  • loader/FrameLoader.h: (WebCore::FrameLoader::icon):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
  • loader/icon/IconLoader.h:
1:25 PM Changeset in webkit [88681] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Update NEWS for 1.5.1 release.

  • NEWS: update.
1:20 PM Changeset in webkit [88680] by dpranke@chromium.org
  • 7 edits
    1 delete in trunk/Tools

2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88671.
http://trac.webkit.org/changeset/88671
https://bugs.webkit.org/show_bug.cgi?id=62591

"didn't work" (Requested by dpranke on #webkit).

  • Scripts/new-run-webkit-httpd:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
1:19 PM Changeset in webkit [88679] by Nate Chapin
  • 5 edits
    2 adds in trunk

2011-06-13 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
mostly written by Kelly Norton (knorton@google.com).

  • plugins/npruntime/embed-property-equality-expected.txt: Added.
  • plugins/npruntime/embed-property-equality.html: Added.

2011-06-13 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

[V8] Cache V8NPObjects so that we don't create multiple
NPObjects for the same v8::Object.
https://bugs.webkit.org/show_bug.cgi?id=61482

Test: plugins/npruntime/embed-property-equality.html

  • bindings/v8/NPV8Object.cpp: (WebCore::freeV8NPObject): (WebCore::npCreateV8ScriptObject):

2011-06-13 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1:16 PM Changeset in webkit [88678] by jchaffraix@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-13 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
https://bugs.webkit.org/show_bug.cgi?id=49316

The bug got fixed, thus just landing the test case. Including another test case from
http://code.google.com/p/chromium/issues/detail?id=61562
which should have the same root cause.

  • fast/html/crash-style-first-letter-expected.txt: Added.
  • fast/html/crash-style-first-letter.html: Added.
  • svg/custom/svg-use-style-float-crash-expected.txt: Added.
  • svg/custom/svg-use-style-float-crash.svg: Added.
1:07 PM Changeset in webkit [88677] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

BankID plug-in isn't instantiated correctly
https://bugs.webkit.org/show_bug.cgi?id=62588
<rdar://problem/9586600>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can use the half-baked QuickDraw support.
  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout): Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events and we don't want the plug-in to die while it's waiting for a reply.
1:03 PM Changeset in webkit [88676] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-06-13 James Robinson <jamesr@chromium.org>

[chromium] Fix up a boo-boo in GPU test expectations

  • platform/chromium/test_expectations.txt:
1:01 PM Changeset in webkit [88675] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Test run fix.

[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585

  • platform/gtk/Skipped: Skipping a test which depends on this.
12:47 PM Changeset in webkit [88674] by xan@webkit.org
  • 8 edits in trunk/Source

Source/WebCore:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit/gtk:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:

Source/JavaScriptCore:

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Distcheck fixes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
12:37 PM Changeset in webkit [88673] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Robert Hogan <robert@webkit.org>

Unreviewed, cleanup r87611.

[Qt]Unskip fast/events/backspace-navigates-back.html

This should have been unskipped by http://trac.webkit.org/changeset/87611

  • platform/qt/Skipped:
12:33 PM Changeset in webkit [88672] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Remove an extra space in the Windows-specific failing expected results to ge the bots
green.

  • platform/win/printing/page-count-relayout-shrink-expected.txt:
12:15 PM Changeset in webkit [88671] by dpranke@chromium.org
  • 7 edits
    1 add in trunk/Tools

2011-06-13 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
https://bugs.webkit.org/show_bug.cgi?id=62251

shut_down_http_server() was a total hack that was only used by
new-run-webkit-httpd, so I've moved the code there and switched
to using executive.kill_process() for the common case. The
method itself will be removed in the patch on bug 59993.

  • Scripts/new-run-webkit-httpd:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
12:12 PM Changeset in webkit [88670] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed build fix of mac.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

Forgot to add SVGAnimatedLength.cpp.

  • WebCore.xcodeproj/project.pbxproj:
12:10 PM Changeset in webkit [88669] by Chris Fleizach
  • 16 edits in trunk/Source/WebKit2

kAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547

Reviewed by Darin Adler.

Implement the missing screenToWindow method for WK2.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::screenToWindow):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::screenToWindow):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::screenToWindow):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::screenToWindow):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::screenToWindow):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::screenToWindow):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::screenToWindow):

  • WebProcess/WebPage/WebPage.h:
12:09 PM Changeset in webkit [88668] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-13 Oliver Hunt <oliver@apple.com>

Reviewed by Simon Fraser.

Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584

Move Identifier::equal to the Identifier header file.

  • runtime/Identifier.cpp:
  • runtime/Identifier.h: (JSC::Identifier::equal):
11:59 AM Changeset in webkit [88667] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>

Reviewed by Darin Adler.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.

11:58 AM Changeset in webkit [88666] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-06-13 James Robinson <jamesr@chromium.org>

[chromium] Clean up GPU test expectations.

  • platform/chromium/test_expectations.txt:
11:53 AM Changeset in webkit [88665] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB test: complex keyPaths
https://bugs.webkit.org/show_bug.cgi?id=62468

  • storage/indexeddb/keyPath-expected.txt: Added.
  • storage/indexeddb/keyPath.html: Added.
11:50 AM Changeset in webkit [88664] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Print out bounds origin in layer dump
https://bugs.webkit.org/show_bug.cgi?id=62583

Include m_boundsOrigin in the layer dump, which is used by layerTreeAsText().

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
11:48 AM Changeset in webkit [88663] by krit@webkit.org
  • 17 edits
    55 adds in trunk

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

Added new tests to check correct behavior of SVGLength animations.

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-LengthModeOther.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-1.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-2.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-invalid-value-3.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/svglength-animation-number-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-cm.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-ems.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-exs.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-in.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-pc.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-percentage.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-pt.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-px-to-px.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglength-animation-values.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
  • svg/animations/svglength-animation-LengthModeHeight-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeHeight.html: Added.
  • svg/animations/svglength-animation-LengthModeOther-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeOther.html: Added.
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt: Added.
  • svg/animations/svglength-animation-LengthModeWidth.html: Added.
  • svg/animations/svglength-animation-invalid-value-1-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-1.html: Added.
  • svg/animations/svglength-animation-invalid-value-2-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-2.html: Added.
  • svg/animations/svglength-animation-invalid-value-3-expected.txt: Added.
  • svg/animations/svglength-animation-invalid-value-3.html: Added.
  • svg/animations/svglength-animation-number-to-number-expected.txt: Added.
  • svg/animations/svglength-animation-number-to-number.html: Added.
  • svg/animations/svglength-animation-px-to-cm-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-cm.html: Added.
  • svg/animations/svglength-animation-px-to-ems-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-ems.html: Added.
  • svg/animations/svglength-animation-px-to-exs-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-exs.html: Added.
  • svg/animations/svglength-animation-px-to-in-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-in.html: Added.
  • svg/animations/svglength-animation-px-to-number-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-number.html: Added.
  • svg/animations/svglength-animation-px-to-pc-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-pc.html: Added.
  • svg/animations/svglength-animation-px-to-percentage-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-percentage.html: Added.
  • svg/animations/svglength-animation-px-to-pt-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-pt.html: Added.
  • svg/animations/svglength-animation-px-to-px-expected.txt: Added.
  • svg/animations/svglength-animation-px-to-px.html: Added.
  • svg/animations/svglength-animation-values-expected.txt: Added.
  • svg/animations/svglength-animation-values.html: Added.

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368

When running SMIL animations within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
gets asked for its current value. This value gets transformed to a string. In SVGAnimateElement we try to parse this string again and
split it into a number and its unit. In the further steps we just animate the number. This number gets transformed back to a string
together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAngle, SVGColor, ...), relayout and rerendering.

In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.

This patch does not attempt to change the string transformations, but addresses the parsing of the string back to a number and unit in the
SVG animation code. There's no need to write a new parser in SVGAnimateElement to parse SVG primitive datatypes, we can instead reuse the existing ones.
Also the current parser of SVGAnimateElement does not handle most unit types, nor is it possible to animate lists like SVGLengthList with the
parsed content. An animation of values with different unit types is not possible:

<rect width="20" height="20">

<animate animateAttribute="width" from="20px" to="10%" dur="4s"/>

</rect>

For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
animation.
With using the parsers of SVG primitive datatypes we will also use the SVG primitive datatypes in the animation code itself. And that makes
it possible to do such animations.

In short: SVG primitive datatype -> string -> SVG primitive datatype animation -> string -> SVG primitive datatype.

It will be easier to avoid the string transformation once all SVG primitive datatypes are supported.

To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElement itself just works with the new added generic datatype SVGAnimationType.
SVGAnimatorFactory creates the SVG primitive datatype specific animators. This makes the main animation code a lot more readable and
maintainable.

With this patch I add the SVGAnimatorFactory and convert SVGLength animation to the new concept.

Tests: svg/animations/svglength-animation-LengthModeHeight.html

svg/animations/svglength-animation-LengthModeOther.html
svg/animations/svglength-animation-LengthModeWidth.html
svg/animations/svglength-animation-invalid-value-1.html
svg/animations/svglength-animation-invalid-value-2.html
svg/animations/svglength-animation-invalid-value-3.html
svg/animations/svglength-animation-number-to-number.html
svg/animations/svglength-animation-px-to-cm.html
svg/animations/svglength-animation-px-to-ems.html
svg/animations/svglength-animation-px-to-exs.html
svg/animations/svglength-animation-px-to-in.html
svg/animations/svglength-animation-px-to-number.html
svg/animations/svglength-animation-px-to-pc.html
svg/animations/svglength-animation-px-to-percentage.html
svg/animations/svglength-animation-px-to-pt.html
svg/animations/svglength-animation-px-to-px.html
svg/animations/svglength-animation-values.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other build systems.
  • svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. Use SVGLength parser directly. (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurrentColor public as preperation for SVGAnimatedColor. (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property. (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheritance as preperation for SVGAnimated* files. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now. (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedLength.cpp: Added. (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): (WebCore::sharedSVGLength): (WebCore::SVGAnimatedLengthAnimator::constructFromString): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
  • svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator which is responsible for the actual animation. (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
  • svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement. (WebCore::SVGAnimatedType::createLength): (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::type): (WebCore::SVGAnimatedType::length): (WebCore::SVGAnimatedType::SVGAnimatedType):
  • svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLengthAnimator and future SVG unit animators. (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator): (WebCore::SVGAnimatedTypeAnimator::setContextElement): (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use parseNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespaces shouldn't be stripped on the following attributes: 'from', 'to' and 'by'. This is not the case for SVGLength anymore. Added new tests to check this behavior. (WebCore::SVGAnimationElement::animationMode): Enum is accessible in WebCore namespace now. (WebCore::SVGAnimationElement::calcMode): Ditto.
  • svg/SVGAnimationElement.h:
  • svg/SVGAnimatorFactory.h: Added. (WebCore::SVGAnimatorFactory::create):
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): New setter with string and SVGLengthMode. (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMode for SVGLength depending on the attribute name.
  • svg/SVGLength.h:
11:42 AM WebKit Team edited by caio.oliveira@openbossa.org
(diff)
11:37 AM Changeset in webkit [88662] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

r87539 broke HTMLMediaElement url logging
https://bugs.webkit.org/show_bug.cgi?id=62551

Returning pointers to temporaries is bad times!

  • html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::sourceWasAdded): (WebCore::HTMLMediaElement::sourceWillBeRemoved):
11:36 AM Changeset in webkit [88661] by tony@chromium.org
  • 13 edits in trunk

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • Scripts/build-webkit:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:29 AM Changeset in webkit [88660] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

  • storage/indexeddb/setVersion-undefined-expected.txt: Added.
  • storage/indexeddb/setVersion-undefined.html: Added.

2011-06-13 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401

Test: storage/indexeddb/setVersion-undefined.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
  • storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
11:22 AM Changeset in webkit [88659] by noam.rosenthal@nokia.com
  • 1 edit
    2 adds in trunk/Source/WebKit2

2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Added WebGraphicsLayer, a subclass of WebCore::GraphicsLayer that serializes the state of the layer
tree to the UI process WebLayerTreeInfo.
For now this patch doesn't serialize the animation information, a feature that will be upstreamed later on.

Together with Viatcheslav Ostapenko.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: Added.
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h: Added.
11:20 AM Changeset in webkit [88658] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-13 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Clean up test expectations, add a flake.

  • platform/chromium/test_expectations.txt: Cleaned up.
11:18 AM Changeset in webkit [88657] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Add utility method to report whether a RenderLayer has any scrollbars
https://bugs.webkit.org/show_bug.cgi?id=62579

New method that returns true with either scrollbar is present.

  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasScrollbars):
11:10 AM Changeset in webkit [88656] by jianli@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt: Added.
  • fast/files/blob-builder-crash.html: Added.

TBR=jianli@chromium.org
BUG=85659
Review URL: http://codereview.chromium.org/7134095

11:09 AM Changeset in webkit [88655] by noam.rosenthal@nokia.com
  • 1 edit
    2 adds in trunk/Source/WebKit2

2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935

Added WebLayerTreeInfo: a set of structures that can serialize a tree of GraphicsLayers
across to the UI process.

Together with Viatcheslav Ostapenko.

  • Scripts/webkit2/messages.py:
  • Shared/WebLayerTreeInfo.cpp: Added.
  • Shared/WebLayerTreeInfo.h: Added.
11:05 AM Changeset in webkit [88654] by jer.noble@apple.com
  • 7 edits in trunk/Source

2011-06-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338

No new tests; covered by the existing full-screen tests.

Now that we are forcing a repaint inside of setRootFullScreenLayer() instead of during
the next run loop, make sure that we have disabled animation before calling
setRootFullScreenLayer() so that the RenderFullScreen renderer and its contents are
painted.

  • dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement):

2011-06-11 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338

Instead of making a round-trip between processes by calling forceRepaint
and waiting for a callback, instead make a WebProcess-side call to
forceRepaintWithoutCallback before sending the ExitAcceleratedCompositingMode
message to the WebFullScreenControllerProxy. This also means we can get rid of
the dragImage creation and display.

Because this redraw will happen during the current run-loop instead of a future
one, make sure the background color has been set before the redraw in
didEnterFullScreen().

Wait to hide the full-screen window until after we have received the
ExitAcceleratedCompositingMode message. By this time, repaint will have already
completed.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Disable

screen updates, to be re-enabled during exitAcceleratedCompositingMode.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Don't hide

the full-screen window here; wait for exitAcceleratedCompositing instead.

(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Collapse

the redrawCompleted method into this one.

(-[WKFullScreenWindowController close]): Remove the reference to

exitCompositedModeRepaintCompleted.

  • WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::didEnterFullScreen): Set the full screen

background color first.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Repaint before

sending the ExitAcceleratedCompositingMode message.

11:02 AM Changeset in webkit [88653] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

2011-06-10 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
https://bugs.webkit.org/show_bug.cgi?id=62491
<rdar://problem/9584427>

No new tests; should be covered by existing fullscreen pixel tests.

On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
creation of a tiled CALayer (instead of a normal CALayer). Painting in these layers necessarily
happens asynchronously, so the flash is occurring because of the async painting of the RenderFullScreen
renderer's background color. Since we know the RenderFullScreen does not otherwise paint its contents,
we can add a special case in the RenderLayerBacking to set the GraphicsLayer contents to be the
renderer's background color. Fill in support for creating a contentLayer to contain the background
color inside GraphicsLayerCA.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from setContentsBackgroundColor to match

the other setContentsTo... functions.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the

background color.

(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a comment only.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen

renderer to call updateBackgroundColor.

(WebCore::RenderLayerBacking::updateBackgroundColor): Added.
(WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen

renderer does not paint its contents.

  • rendering/RenderLayerBacking.h:
10:59 AM Changeset in webkit [88652] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

2011-06-13 Tim Horton <timothy_horton@apple.com>

Reviewed by Simon Fraser.

REGRESSION(87152): Crash on page with svg fonts
https://bugs.webkit.org/show_bug.cgi?id=61556

We can't assume that the parent of a SVG-font-styled
text node won't be an anonymous block.

Test: svg/text/text-font-anonymous-parent.xhtml

  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::firstParentRendererForNonTextNode): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
10:49 AM Changeset in webkit [88651] by krit@webkit.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2011-06-13 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

Removing 'transform' animation test. It was added as an example for animateTransform tests but fails on some platforms.
Also it is not part of the fix for 'patternTransform' animation. The test for 'patternTransform' works.
Adding animateTransform-pattern-transform to the skip list of Mac WebKit2, like all other animation or dynamic-update tests.

  • platform/mac-wk2/Skipped:
  • svg/animations/animateTransform-transformable-transform-expected.txt: Removed.
  • svg/animations/animateTransform-transformable-transform.html: Removed.
  • svg/animations/script-tests/animateTransform-transformable-transform.js: Removed.
10:47 AM Changeset in webkit [88650] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Add radar number.

10:32 AM Changeset in webkit [88649] by tony@chromium.org
  • 13 edits in trunk

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Configurations/FeatureDefines.xcconfig:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • Scripts/build-webkit:

2011-06-13 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
10:25 AM Changeset in webkit [88648] by Dimitri Glazkov
  • 4 edits
    3 adds in trunk/LayoutTests

2011-06-13 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated Leopard pixel baselines.

  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [88647] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't access freed memory in the UI process when a plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=62548

Call pluginProcessCrashedOrFailedToLaunch after sending messages to all processes about the plug-in crash,
otherwise we'll try to dereference m_pluginInfo.path after the PluginProcessProxy object has been deleted.

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose):
10:14 AM Changeset in webkit [88646] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix a crash when drawing area has been deleted
https://bugs.webkit.org/show_bug.cgi?id=62541

Check whether WebPageProxy::drawingArea() returns a valid pointer
before using it, it might be null, for example, when the web
process crashes.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): (webkitWebViewBaseSizeAllocate):
10:12 AM Changeset in webkit [88645] by xan@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Some distcheck fixes. Still broken, but this is moves us closer to
the target.

  • GNUmakefile.am: fix vpath syntax and add missing files to EXTRA_DIST.
  • GNUmakefile.list.am: add missing files and remove dead files.
  • bindings/gobject/GNUmakefile.am: fix comment.
9:54 AM Changeset in webkit [88644] by vitalyr@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [88643] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925

Use the new factory function in TextureMapper.

No new functionality so no new tests.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):
8:48 AM Changeset in webkit [88642] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [88641] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-13 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

  • animations/animation-direction-normal-expected.png: Added.
  • animations/animation-direction-normal-expected.txt: Added.
  • animations/animation-direction-normal.html: Added.

2011-06-13 Young Han Lee <joybro@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281

syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.

Test: animations/animation-direction-normal.html

  • platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimations):
8:28 AM Changeset in webkit [88640] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62429

  • UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
  • UIProcess/API/efl/PageClientImpl.h:
8:09 AM Changeset in webkit [88639] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-13 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
https://bugs.webkit.org/show_bug.cgi?id=62448

Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter

  • ewk/ewk_tiled_model.c: (ewk_tile_new):
  • ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
7:58 AM Changeset in webkit [88638] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit2

2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62525

  • UIProcess/efl/WebPreferencesEfl.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey):
7:28 AM Changeset in webkit [88637] by krit@webkit.org
  • 3 edits
    6 adds in trunk

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

SVG animation did not take attribute 'patternTransform' into account. Added support for combination of
SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransformElement.

Tests: svg/animations/animateTransform-pattern-transform.html

svg/animations/animateTransform-transformable-transform.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):

2011-06-13 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538

Test SVG animateTransform for attributes 'transform' and 'patternTransform'.

  • svg/animations/animateTransform-pattern-transform-expected.txt: Added.
  • svg/animations/animateTransform-pattern-transform.html: Added.
  • svg/animations/animateTransform-transformable-transform-expected.txt: Added.
  • svg/animations/animateTransform-transformable-transform.html: Added.
  • svg/animations/script-tests/animateTransform-pattern-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animateTransform-transformable-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
7:12 AM Changeset in webkit [88636] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
6:41 AM Changeset in webkit [88635] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
https://bugs.webkit.org/show_bug.cgi?id=62330

This patch is based on the draft patch by Noam Rosenthal in bug 60842.
Qt API autotests cover the bridge behavior and pass after this patch.

  • bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types. In particular, we got rid of Strong<JSObject> members. Renamed some members and arguments to follow existing naming in QObject::connect().
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper function to create a connection, passing the ExecState* that will be used when the connection is activated (signal emitted). Use JSC API types when looking up the matching signal to disconnect.

(JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
protect the receiver and receiverFunction from being garbage
collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in current
code were Strong<>) anymore.

(JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
to use m_originalSender here. Unprotect values that we protected in constructor.

(JSC::Bindings::isJavaScriptFunction): Helper function to identify whether a
JSObjectRef is a JS function (in contrast to a native function exposed to JS).

(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
Both updated to use JSC API when appliable. Note that convertQVariantToValue
still returns JSC internal types, will be handled in a different patch.

(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
Convenince for the existing caller until it is converted to JSC as well.

2:35 AM Changeset in webkit [88634] by Carlos Garcia Campos
  • 9 edits
    1 copy
    1 add in trunk/Source

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827

  • platform/ContextMenuItem.h: Add gtkAction().
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): Implement constructor that receives a platform menu. (WebCore::ContextMenu::setPlatformDescription): Make sure we don't destroy the menu if the new context menu is the current one. (WebCore::contextMenuItemVector): Implement this method to return the list of menu items in the given context menu, required by WebKit2. (WebCore::platformMenuDescription): Implement this method to return a platform menu for the given menu items.
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::createPlatformMenuItemDescription): Helper function to create a platform context menu item. (WebCore::ContextMenuItem::ContextMenuItem): Use createPlatformMenuItemDescription(). (WebCore::ContextMenuItem::title): Convert the title from UTF-8. (WebCore::ContextMenuItem::setTitle): Use gtkAction(). (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu() that receives a list of items. (WebCore::ContextMenuItem::setChecked): Use gtkAction(). (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2. (WebCore::ContextMenuItem::enabled): Ditto. (WebCore::ContextMenuItem::setEnabled): Use gtkAction(). (WebCore::ContextMenuItem::gtkAction): Return the GtkAction associated to the context menu item.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createContextMenuProxy): Create a context menu proxy.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (globalPointForClientPoint): Function copied from webkit1 to convert a point in widget coordinates to global coordinates. (popupMenuPositionFunction): (webkitWebViewBaseShowContextMenu): Show the given context menu at the given position.
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added. (WebKit::contextMenuItemActivatedCallback): (WebKit::WebContextMenuProxyGtk::createGtkMenu): (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
  • UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h. (WebKit::WebContextMenuProxyGtk::create):
2:03 AM Changeset in webkit [88633] by keishi@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py

2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>

Fix mistake I made in 88632

2:00 AM Changeset in webkit [88632] by keishi@webkit.org
  • 3 edits in trunk

2011-06-13 Keishi Hattori <keishi@webkit.org>

Sort WebCore.xcodeproj

Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
1:56 AM Changeset in webkit [88631] by Carlos Garcia Campos
  • 10 edits
    5 adds in trunk

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

  • GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
  • webkit/webkitwebview.h: Move declarations common to WebKit2 to webkitwebviewcommon.h.
  • webkit/webkitwebviewcommon.h: Added.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

Add first implementation of WebKitWebView, a class with the same
API than webkit1, that wraps the C API to provide a high level
WebKit2 API for GTK port.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebView.cpp: Added. (webkit_web_view_init): (webkit_web_view_class_init): (webkit_web_view_new): (webkit_web_view_load_uri): (webkit_web_view_go_back): (webkit_web_view_go_forward):
  • UIProcess/API/gtk/WebKitWebView.h: Added.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreate): (webkitWebViewBaseCreateWebPage):
  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/webkit/webkit.h: Added.

2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820

Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
code, but linking to libwebkit2gtk.

  • GNUmakefile.am:
  • GtkLauncher/main.c: (createBrowser): (main):

Jun 12, 2011:

11:38 PM Changeset in webkit [88630] by morrita@google.com
  • 10 edits in trunk

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • platform/mac-wk2/Skipped:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKit.vcproj/WebKit.sln:

2011-06-12 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073

Breaks SL Webkit2 Tests

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
11:20 PM Changeset in webkit [88629] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-12 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507

No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.

If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

  • dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
10:15 PM Changeset in webkit [88628] by abarth@webkit.org
  • 41 edits in trunk/Source

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/MainResourceLoader.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
  • src/FrameLoaderClientImpl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
  • WebFrame.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516

  • WebProcess/WebCoreSupport/WebErrors.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
9:55 PM Changeset in webkit [88627] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

  • editing/spelling/spellcheck-api-crash-expected.txt: Added.
  • editing/spelling/spellcheck-api-crash.html: Added.

2011-06-12 Hironori Bono <hbono@chromium.org>

Reviewed by Hajime Morita.

Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526

This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().

Test: editing/spelling/spellcheck-api-crash.html

  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
9:13 PM Changeset in webkit [88626] by mahesh.kulkarni@nokia.com
  • 5 edits in trunk

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Antonio Gomes.

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
8:05 PM Changeset in webkit [88625] by dominicc@chromium.org
  • 10 edits in trunk

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

  • WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport

2011-06-12 Dominic Cooney <dominicc@chromium.org>

Reviewed by Hajime Morita.

Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073

Test: fast/harness/internals-object.html

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
7:17 PM Changeset in webkit [88624] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-12 Adam Barth <abarth@webkit.org>

Attempt to fix Qt build.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
7:05 PM Changeset in webkit [88623] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes should use size_t for length instead of int
https://bugs.webkit.org/show_bug.cgi?id=62508

size_t is the proper type for distances in memory, especially on 64 bit
machines.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
7:03 PM Changeset in webkit [88622] by abarth@webkit.org
  • 14 edits in trunk/Source

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.

This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519

Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
4:34 PM Changeset in webkit [88621] by xan@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-06-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit_web_view_get_selected_text
https://bugs.webkit.org/show_bug.cgi?id=62512

It's no longer used and it's a private method, so it can be
removed.

  • webkit/webkitwebview.cpp: kill it.
  • webkit/webkitwebviewprivate.h: ditto.
2:24 PM Changeset in webkit [88620] by commit-queue@webkit.org
  • 5 edits in trunk

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • platform/qt/Skipped:

2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517

It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
1:01 PM Changeset in webkit [88619] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <abarth@webkit.org>

Fix fullscreen/full-screen-iframe-legacy.html.

  • html/HTMLVideoElement.idl:
12:21 PM Changeset in webkit [88618] by abarth@webkit.org
  • 21 edits in trunk/Source

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.

  • webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
  • loader/FrameLoader.h:
    • cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
  • loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
11:27 AM Changeset in webkit [88617] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557

Reviewed by Darin Adler.

Replaced the fix for bug 58500 with a refined version.

  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.

10:23 AM Changeset in webkit [88616] by mahesh.kulkarni@nokia.com
  • 5 edits in trunk

[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Reviewed by Antonio Gomes.

Tools:

Implements LayoutController.setTextDirection.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setTextDirection):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Unskipping fast/html/set-text-direction.html.

  • platform/qt/Skipped:
9:57 AM Changeset in webkit [88615] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-12 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Minor user-gesture related cleanup
https://bugs.webkit.org/show_bug.cgi?id=62511

In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.

  • bindings/v8/NPV8Object.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLVideoElement.idl:
7:52 AM Changeset in webkit [88614] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-12 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Build fix for !ENABLE(JIT) after r88604.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
5:40 AM Changeset in webkit [88613] by Nikolas Zimmermann
  • 11 edits in trunk/Source/WebCore

2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add TextRun charactersLength member
https://bugs.webkit.org/show_bug.cgi?id=62501

Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).

This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.

  • platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
  • platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
  • platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer

that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.

(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):

  • platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
  • rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
  • rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
  • rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
4:51 AM Changeset in webkit [88612] by robert@webkit.org
  • 5 edits
    13 adds in trunk

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

Our expectations for the unskipped tests have the following differences from the mac
platform:

  • POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
  • DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
  • platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html

http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html

  • platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.

2011-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest (WebCore::QNetworkReplyHandler::getIODevice): ditto (WebCore::QNetworkReplyHandler::sendNetworkRequest):
    • Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
    • If a custom HTTP operation contains data, send it.
  • platform/network/qt/QNetworkReplyHandler.h:

Jun 11, 2011:

11:01 PM Changeset in webkit [88611] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-11 Michael Saboff <msaboff@apple.com>

Reviewed by James Robinson.

REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349

Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.

Change made to address existing Chromium performance test regression.

  • platform/graphics/FontCache.cpp:
9:19 PM Changeset in webkit [88610] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary strlen from DocumentWriter
https://bugs.webkit.org/show_bug.cgi?id=62505

This ugly piece of code appears not to be needed. Rejoice.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/DocumentWriter.h:
5:51 PM Changeset in webkit [88609] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

2011-06-11 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=62499

This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.

There's still lots of on contorting to do here, but it's a start.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
  • dom/DecodedDataDocumentParser.h:
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
  • loader/DocumentWriter.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
1:34 PM Changeset in webkit [88608] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-06-11 Ryosuke Niwa <rniwa@webkit.org>

Chromium rebaseline after r85560.

Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [88607] by slewis@apple.com
  • 5 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::warmInitialProcess):

  • UIProcess/WebContext.h:
1:21 PM Changeset in webkit [88606] by Dimitri Glazkov
  • 3 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/database-name-undefined-expected.txt: Removed.
  • storage/indexeddb/database-name-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBFactory.idl:
1:16 PM Changeset in webkit [88605] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):

  • wtf/DateMath.cpp:

(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

1:07 PM Changeset in webkit [88604] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):

  • jit/JIT.h:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):

  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/Lookup.h:
  • wtf/Platform.h:
11:09 AM Changeset in webkit [88603] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Remove expectation of failure after clobber.
https://bugs.webkit.org/show_bug.cgi?id=62364

  • platform/chromium/test_expectations.txt: Removed.
10:12 AM Changeset in webkit [88602] by Dimitri Glazkov
  • 4 edits
    2 deletes in trunk

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/indexeddb/setVersion-undefined-expected.txt: Removed.
  • storage/indexeddb/setVersion-undefined.html: Removed.

2011-06-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401

Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.idl:
9:37 AM Changeset in webkit [88601] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230

When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.

Tests: fast/dom/body-link-decl-parent-crash.html

fast/dom/styled-inline-style-decl-parent-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
  • html/HTMLBodyElement.h:

2011-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62230

  • fast/dom/body-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-link-decl-parent-crash.html: Added.
  • fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-inline-style-decl-parent-crash.html: Added.
Note: See TracTimeline for information about the timeline view.